{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15961","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15961/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15961/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15961/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15961","id":143987020,"number":15961,"title":"Further ranged cleanup (part 2) [RDY]","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Balance","name":"Balance","color":"fef2c0"},{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/JSON","name":"JSON","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2016-03-28T14:16:07Z","updated_at":"2016-05-22T20:57:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15961","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15961","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15961.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15961.patch"},"body":"Continues from #15936.\r\n\r\n`gun_base` now provides default values for `color` and `symbol`. The previous ad-hoc values were inconsistent but `grey (` was by far the most common. It is entirely possible (and probably desirable) to have a different symbol for each gun class but I don't play curses much so I'll let someone else propose the values.\r\n\r\nAs per @Coolthulhu's suggestion the improvised weapons become much less useless. They now derive their stats from the closest match with suitable penalties including increased `weight`, `volume` and `reload` along with markedly reduced `durability` and accept a much reduced set of modifications to maintain balance. They are serviceable but always strictly inferior to their base type.\r\n\r\nThe 12 gauge pistol is migrated and item drops added whilst the shotgun revolver becomes an unwieldy pistol (e4389d7) to differentiate it from the otherwise identical lever shotgun (84571f4)\r\n\r\nAll migrated guns are tagged with an class with four new classes (`rifle_pipe`, `rifle_machine`, `rifle_carbine` and `smg_compact`) added by cb2412c. Machine guns gain a bonus to recoil via their class in 0432380 which helps make them less useless (although ammo belts still need work). Pipe rifles will be further balanced once I address overall recoil, range and dispersion for ammo as a whole so their class is mainly provided as an extension point for now.\r\n\r\nA further PR will aim to make `aim_speed` more relevant (and probably rename it to `aim_cost`). The Rivtech weapons, small holdout pistols and `compact_smg` are atypically good for their respective classes (81375d3).\r\n\r\nAgain when gun reliability is reworked `durability` (or lack of) will be more significant. This PR applies some sanity so that most guns use `durability 8` with exceptions for improvised weapons (typically `durability -2`) or where their `description` suggests otherwise (9b59163). The Rivtech weapons have above average `durability` whilst many Leadworks weapons (excluding L523 base) become perfectly reliable to offset their rarity and incompatibility with mods (9b59163)\r\n\r\n`sight_dispersion` and melee properties required few exceptions although in the case of the latter we might want to look at how the class value compare to other objects of similar sizes in a future PR.\r\n\r\nTested with `--check-mods`. The only code change is in 57a53af to ensure `magazines` is cleared when a derivative tries to overwrite that field."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/220855910","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15961#issuecomment-220855910","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15961","id":220855910,"user":{"login":"BorkBorkGoesTheCode","id":18560216,"avatar_url":"https://avatars.githubusercontent.com/u/18560216?v=3","gravatar_id":"","url":"https://api.github.com/users/BorkBorkGoesTheCode","html_url":"https://github.com/BorkBorkGoesTheCode","followers_url":"https://api.github.com/users/BorkBorkGoesTheCode/followers","following_url":"https://api.github.com/users/BorkBorkGoesTheCode/following{/other_user}","gists_url":"https://api.github.com/users/BorkBorkGoesTheCode/gists{/gist_id}","starred_url":"https://api.github.com/users/BorkBorkGoesTheCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorkBorkGoesTheCode/subscriptions","organizations_url":"https://api.github.com/users/BorkBorkGoesTheCode/orgs","repos_url":"https://api.github.com/users/BorkBorkGoesTheCode/repos","events_url":"https://api.github.com/users/BorkBorkGoesTheCode/events{/privacy}","received_events_url":"https://api.github.com/users/BorkBorkGoesTheCode/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T20:57:07Z","updated_at":"2016-05-22T20:57:07Z","body":"> For example, I'd absolutely love to have dispersion based on some kind of real gun data, but there seems to be pretty much zero data on gun accuracy available, and there are really no contributing stats that we can base it on. \r\n\r\nIf you're looking for gun dispersion, have you been searching for M.O.A. data? Also, have you looked up shooting competition data? I'm pretty sure you can find info on the specific guns used and the shot groupings achieved."}}
{"actor":{"display_login":"BorkBorkGoesTheCode"}}