{"action":"created","comment":{"url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/comments/80925371","pull_request_review_id":1941691,"id":80925371,"diff_hunk":"@@ -142,37 +147,65 @@ Write-Debug \"targetDatabaseName = $targetDatabaseName\"\n Write-Debug \"authMethodSync = $authMethodSync\"\n Write-Debug \"usernameSync = $usernameSync\"\n Write-Debug \"passwordSync = *********\"\n+Write-Debug \"filterPathSync = $filterPathSync\"\n+Write-Debug \"compareOptionsSync = $compareOptionsSync\"\n+Write-Debug \"scriptFileSync = $scriptFileSync\"\n+Write-Debug \"abortOnWarningsSync = $abortOnWarningsSync\"\n+Write-Debug \"transactionIsolationLevelSync = $transactionIsolationLevelSync\"\n \n # Shared arguments\n-Write-Debug \"additionalParams = $additionalParams\"\n+\n+Write-Debug \"nugetPackageVersionSelector = $nugetPackageVersionSelector\"\n Write-Debug \"nugetPackageVersion = $nugetPackageVersion\"\n-Write-Debug \"nugetPackageVersionUseBuildNumber = $nugetPackageVersionUseBuildNumber\"\n+Write-Debug \"nugetPackageVersionUseBuildId = $nugetPackageVersionUseBuildId\"\n \n \n # This will be empty if it's a Release.\n $buildSourcesDirectory = $env:BUILD_SOURCESDIRECTORY\n \n # Build version number\n-\n-$nugetFullVersion = $nugetPackageVersion.Trim()\n-if($nugetPackageVersionUseBuildNumber -eq 'true')\n+if($nugetPackageVersionSelector -eq 'Specific')\n+{\n+    $nugetFullVersion = $nugetPackageVersion.Trim()\n+    # Append BuildId if selected\n+    if($nugetPackageVersionUseBuildId -eq 'true')\n+    {\n+        $nugetFullVersion += \".\"\n+        $nugetFullVersion += $Env:BUILD_BUILDID\n+    }\n+}\n+# Set NuGet version to BuildNumber if chosen\n+if($nugetPackageVersionSelector -eq 'BuildNumber')\n {\n-    $nugetFullVersion += \".\"\n-    $nugetFullVersion += $Env:BUILD_BUILDNUMBER\n+    $nugetFullVersion = $Env:BUILD_BUILDNUMBER\n }\n \n+# If it is a relative path, then combine with $buildSourcesDirectory\n+if ($filterPathBuild -and (-not (Split-Path $filterPathBuild -IsAbsolute))) {\n+    $filterPathBuild = Join-Path $buildSourcesDirectory $filterPathBuild\n+}\n+if ($filterPathTest -and (-not (Split-Path $filterPathTest))) {","path":"TheTask/DlmAutomationBuild.ps1","position":219,"original_position":219,"commit_id":"4b7a673342bfee57708a429c7fc74b85232cabf6","original_commit_id":"4b7a673342bfee57708a429c7fc74b85232cabf6","user":{"login":"Michael-Upton","id":5537663,"avatar_url":"https://avatars.githubusercontent.com/u/5537663?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Upton","html_url":"https://github.com/Michael-Upton","followers_url":"https://api.github.com/users/Michael-Upton/followers","following_url":"https://api.github.com/users/Michael-Upton/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Upton/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Upton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Upton/subscriptions","organizations_url":"https://api.github.com/users/Michael-Upton/orgs","repos_url":"https://api.github.com/users/Michael-Upton/repos","events_url":"https://api.github.com/users/Michael-Upton/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Upton/received_events","type":"User","site_admin":false},"body":"Are these all supposed to be the same? If so, the `-IsAbsolute` is missing, and anyway it would be much more sensible to extract a function to do this.","created_at":"2016-09-28T14:11:46Z","updated_at":"2016-09-28T14:25:31Z","html_url":"https://github.com/red-gate/SQLCI-VSTSTask/pull/18#discussion_r80925371","pull_request_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/comments/80925371"},"html":{"href":"https://github.com/red-gate/SQLCI-VSTSTask/pull/18#discussion_r80925371"},"pull_request":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18","id":86947998,"html_url":"https://github.com/red-gate/SQLCI-VSTSTask/pull/18","diff_url":"https://github.com/red-gate/SQLCI-VSTSTask/pull/18.diff","patch_url":"https://github.com/red-gate/SQLCI-VSTSTask/pull/18.patch","issue_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/18","number":18,"state":"open","locked":false,"title":"Replace Sql Ci exe with new PowerShell runner","user":{"login":"PeterGerrard","id":1334027,"avatar_url":"https://avatars.githubusercontent.com/u/1334027?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterGerrard","html_url":"https://github.com/PeterGerrard","followers_url":"https://api.github.com/users/PeterGerrard/followers","following_url":"https://api.github.com/users/PeterGerrard/following{/other_user}","gists_url":"https://api.github.com/users/PeterGerrard/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterGerrard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterGerrard/subscriptions","organizations_url":"https://api.github.com/users/PeterGerrard/orgs","repos_url":"https://api.github.com/users/PeterGerrard/repos","events_url":"https://api.github.com/users/PeterGerrard/events{/privacy}","received_events_url":"https://api.github.com/users/PeterGerrard/received_events","type":"User","site_admin":false},"body":"This includes #12, so we should finish that first.\r\n\r\nTests\r\n- [x] Test with on-prem\r\n- [x] Test VSTS with hosted agent (sync to Azure)\r\n- [x] Test VSTS with local agent\r\n","created_at":"2016-09-27T15:01:36Z","updated_at":"2016-09-28T14:25:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7f3e3d0581a8f3ba70898522f42e35e3af71880","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18/commits","review_comments_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18/comments","review_comment_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/18/comments","statuses_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/statuses/4b7a673342bfee57708a429c7fc74b85232cabf6","head":{"label":"red-gate:ReplaceCiWithPowerShell","ref":"ReplaceCiWithPowerShell","sha":"4b7a673342bfee57708a429c7fc74b85232cabf6","user":{"login":"red-gate","id":731505,"avatar_url":"https://avatars.githubusercontent.com/u/731505?v=3","gravatar_id":"","url":"https://api.github.com/users/red-gate","html_url":"https://github.com/red-gate","followers_url":"https://api.github.com/users/red-gate/followers","following_url":"https://api.github.com/users/red-gate/following{/other_user}","gists_url":"https://api.github.com/users/red-gate/gists{/gist_id}","starred_url":"https://api.github.com/users/red-gate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-gate/subscriptions","organizations_url":"https://api.github.com/users/red-gate/orgs","repos_url":"https://api.github.com/users/red-gate/repos","events_url":"https://api.github.com/users/red-gate/events{/privacy}","received_events_url":"https://api.github.com/users/red-gate/received_events","type":"Organization","site_admin":false},"repo":{"id":49713760,"name":"SQLCI-VSTSTask","full_name":"red-gate/SQLCI-VSTSTask","owner":{"login":"red-gate","id":731505,"avatar_url":"https://avatars.githubusercontent.com/u/731505?v=3","gravatar_id":"","url":"https://api.github.com/users/red-gate","html_url":"https://github.com/red-gate","followers_url":"https://api.github.com/users/red-gate/followers","following_url":"https://api.github.com/users/red-gate/following{/other_user}","gists_url":"https://api.github.com/users/red-gate/gists{/gist_id}","starred_url":"https://api.github.com/users/red-gate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-gate/subscriptions","organizations_url":"https://api.github.com/users/red-gate/orgs","repos_url":"https://api.github.com/users/red-gate/repos","events_url":"https://api.github.com/users/red-gate/events{/privacy}","received_events_url":"https://api.github.com/users/red-gate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/red-gate/SQLCI-VSTSTask","description":null,"fork":false,"url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask","forks_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/forks","keys_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/teams","hooks_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/hooks","issue_events_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/events{/number}","events_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/events","assignees_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/assignees{/user}","branches_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/branches{/branch}","tags_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/tags","blobs_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/refs{/sha}","trees_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/statuses/{sha}","languages_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/languages","stargazers_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/stargazers","contributors_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/contributors","subscribers_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/subscribers","subscription_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/subscription","commits_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/commits{/sha}","git_commits_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/commits{/sha}","comments_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/comments{/number}","issue_comment_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/comments{/number}","contents_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/contents/{+path}","compare_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/merges","archive_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/downloads","issues_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues{/number}","pulls_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls{/number}","milestones_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/milestones{/number}","notifications_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/labels{/name}","releases_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/releases{/id}","deployments_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/deployments","created_at":"2016-01-15T10:54:57Z","updated_at":"2016-08-01T08:39:08Z","pushed_at":"2016-09-28T14:20:06Z","git_url":"git://github.com/red-gate/SQLCI-VSTSTask.git","ssh_url":"git@github.com:red-gate/SQLCI-VSTSTask.git","clone_url":"https://github.com/red-gate/SQLCI-VSTSTask.git","svn_url":"https://github.com/red-gate/SQLCI-VSTSTask","homepage":null,"size":1125,"stargazers_count":1,"watchers_count":1,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"red-gate:master","ref":"master","sha":"6ce07dde15109e2a9cc40a93a9f0612fb04d61e8","user":{"login":"red-gate","id":731505,"avatar_url":"https://avatars.githubusercontent.com/u/731505?v=3","gravatar_id":"","url":"https://api.github.com/users/red-gate","html_url":"https://github.com/red-gate","followers_url":"https://api.github.com/users/red-gate/followers","following_url":"https://api.github.com/users/red-gate/following{/other_user}","gists_url":"https://api.github.com/users/red-gate/gists{/gist_id}","starred_url":"https://api.github.com/users/red-gate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-gate/subscriptions","organizations_url":"https://api.github.com/users/red-gate/orgs","repos_url":"https://api.github.com/users/red-gate/repos","events_url":"https://api.github.com/users/red-gate/events{/privacy}","received_events_url":"https://api.github.com/users/red-gate/received_events","type":"Organization","site_admin":false},"repo":{"id":49713760,"name":"SQLCI-VSTSTask","full_name":"red-gate/SQLCI-VSTSTask","owner":{"login":"red-gate","id":731505,"avatar_url":"https://avatars.githubusercontent.com/u/731505?v=3","gravatar_id":"","url":"https://api.github.com/users/red-gate","html_url":"https://github.com/red-gate","followers_url":"https://api.github.com/users/red-gate/followers","following_url":"https://api.github.com/users/red-gate/following{/other_user}","gists_url":"https://api.github.com/users/red-gate/gists{/gist_id}","starred_url":"https://api.github.com/users/red-gate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-gate/subscriptions","organizations_url":"https://api.github.com/users/red-gate/orgs","repos_url":"https://api.github.com/users/red-gate/repos","events_url":"https://api.github.com/users/red-gate/events{/privacy}","received_events_url":"https://api.github.com/users/red-gate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/red-gate/SQLCI-VSTSTask","description":null,"fork":false,"url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask","forks_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/forks","keys_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/teams","hooks_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/hooks","issue_events_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/events{/number}","events_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/events","assignees_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/assignees{/user}","branches_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/branches{/branch}","tags_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/tags","blobs_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/refs{/sha}","trees_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/statuses/{sha}","languages_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/languages","stargazers_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/stargazers","contributors_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/contributors","subscribers_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/subscribers","subscription_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/subscription","commits_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/commits{/sha}","git_commits_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/git/commits{/sha}","comments_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/comments{/number}","issue_comment_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/comments{/number}","contents_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/contents/{+path}","compare_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/merges","archive_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/downloads","issues_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues{/number}","pulls_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls{/number}","milestones_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/milestones{/number}","notifications_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/labels{/name}","releases_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/releases{/id}","deployments_url":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/deployments","created_at":"2016-01-15T10:54:57Z","updated_at":"2016-08-01T08:39:08Z","pushed_at":"2016-09-28T14:20:06Z","git_url":"git://github.com/red-gate/SQLCI-VSTSTask.git","ssh_url":"git@github.com:red-gate/SQLCI-VSTSTask.git","clone_url":"https://github.com/red-gate/SQLCI-VSTSTask.git","svn_url":"https://github.com/red-gate/SQLCI-VSTSTask","homepage":null,"size":1125,"stargazers_count":1,"watchers_count":1,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18"},"html":{"href":"https://github.com/red-gate/SQLCI-VSTSTask/pull/18"},"issue":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/18"},"comments":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/red-gate/SQLCI-VSTSTask/statuses/4b7a673342bfee57708a429c7fc74b85232cabf6"}}}}
{"actor":{"display_login":"Michael-Upton"}}