{"action":"created","comment":{"url":"https://api.github.com/repos/wardpeet/lighthouse/pulls/comments/92256088","pull_request_review_id":12768395,"id":92256088,"diff_hunk":"@@ -60,17 +60,7 @@ class NoConsoleTimeAudit extends Audit {\n     const pageHost = new URL(artifacts.URL.finalUrl).host;\n     // Filter usage from other hosts and keep eval'd code.\n     const results = artifacts.ConsoleTimeUsage.usage.filter(err => {\n-      let result = err.url;\n-\n-      if (!err.isEval) {\n-        try {\n-          result = new URL(err.url).host === pageHost;\n-        } catch (err) {\n-          result = false;\n-        }\n-      }\n-\n-      return result;\n+      return err.isEval ? err.url : new URL(err.url).host === pageHost;","path":"lighthouse-core/audits/dobetterweb/no-console-time.js","position":null,"original_position":15,"commit_id":"39e834933b381102a95359c56aa1dd29a14c649a","original_commit_id":"c546fa741f6ef37d283634f5f49b0704437d20c3","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"body":"oh, it's for `filter`...somehow missed that :)","created_at":"2016-12-13T20:13:32Z","updated_at":"2016-12-13T20:13:32Z","html_url":"https://github.com/wardpeet/lighthouse/pull/2#discussion_r92256088","pull_request_url":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/wardpeet/lighthouse/pulls/comments/92256088"},"html":{"href":"https://github.com/wardpeet/lighthouse/pull/2#discussion_r92256088"},"pull_request":{"href":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2","id":97808525,"html_url":"https://github.com/wardpeet/lighthouse/pull/2","diff_url":"https://github.com/wardpeet/lighthouse/pull/2.diff","patch_url":"https://github.com/wardpeet/lighthouse/pull/2.patch","issue_url":"https://api.github.com/repos/wardpeet/lighthouse/issues/2","number":2,"state":"open","locked":false,"title":"don't parse eval URLs after captureJSCallUsage. parse all others.","user":{"login":"paulirish","id":39191,"avatar_url":"https://avatars.githubusercontent.com/u/39191?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"body":"This PR's destination is PR #997 (Add whatwg-url parser to parse our urls)\r\n\r\nThe unit tests provide nonparsable urls that appear to come from `eval()` however they were tagged as `isEval: false`, which doesn't make sense.\r\n\r\nI think we can trust the V8 Stack Trace API to correctly tag the `isEval` property, so i've adjusted those test fixtures. This allows us to nuke the ugly try/catch on parsing.\r\n\r\n@ebidel does this work for you?","created_at":"2016-12-13T18:31:26Z","updated_at":"2016-12-13T20:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13faf09240cd26b00fcb341429b6b0ce6e969939","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2/commits","review_comments_url":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2/comments","review_comment_url":"https://api.github.com/repos/wardpeet/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wardpeet/lighthouse/issues/2/comments","statuses_url":"https://api.github.com/repos/wardpeet/lighthouse/statuses/39e834933b381102a95359c56aa1dd29a14c649a","head":{"label":"GoogleChrome:whatwg-url-evalurlparsing","ref":"whatwg-url-evalurlparsing","sha":"39e834933b381102a95359c56aa1dd29a14c649a","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":"Auditing, performance metrics, and best practices for Progressive Web Apps","fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-12-13T20:12:00Z","pushed_at":"2016-12-13T20:11:48Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":"","size":8981,"stargazers_count":4972,"watchers_count":4972,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":156,"forks":187,"open_issues":156,"watchers":4972,"default_branch":"master"}},"base":{"label":"wardpeet:whatwg-url","ref":"whatwg-url","sha":"44747898dd762167ba2b500650d4e4df9dad10ca","user":{"login":"wardpeet","id":1120926,"avatar_url":"https://avatars.githubusercontent.com/u/1120926?v=3","gravatar_id":"","url":"https://api.github.com/users/wardpeet","html_url":"https://github.com/wardpeet","followers_url":"https://api.github.com/users/wardpeet/followers","following_url":"https://api.github.com/users/wardpeet/following{/other_user}","gists_url":"https://api.github.com/users/wardpeet/gists{/gist_id}","starred_url":"https://api.github.com/users/wardpeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wardpeet/subscriptions","organizations_url":"https://api.github.com/users/wardpeet/orgs","repos_url":"https://api.github.com/users/wardpeet/repos","events_url":"https://api.github.com/users/wardpeet/events{/privacy}","received_events_url":"https://api.github.com/users/wardpeet/received_events","type":"User","site_admin":false},"repo":{"id":59512656,"name":"lighthouse","full_name":"wardpeet/lighthouse","owner":{"login":"wardpeet","id":1120926,"avatar_url":"https://avatars.githubusercontent.com/u/1120926?v=3","gravatar_id":"","url":"https://api.github.com/users/wardpeet","html_url":"https://github.com/wardpeet","followers_url":"https://api.github.com/users/wardpeet/followers","following_url":"https://api.github.com/users/wardpeet/following{/other_user}","gists_url":"https://api.github.com/users/wardpeet/gists{/gist_id}","starred_url":"https://api.github.com/users/wardpeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wardpeet/subscriptions","organizations_url":"https://api.github.com/users/wardpeet/orgs","repos_url":"https://api.github.com/users/wardpeet/repos","events_url":"https://api.github.com/users/wardpeet/events{/privacy}","received_events_url":"https://api.github.com/users/wardpeet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wardpeet/lighthouse","description":"auditing and performance metrics for Progressive Web Apps","fork":true,"url":"https://api.github.com/repos/wardpeet/lighthouse","forks_url":"https://api.github.com/repos/wardpeet/lighthouse/forks","keys_url":"https://api.github.com/repos/wardpeet/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wardpeet/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wardpeet/lighthouse/teams","hooks_url":"https://api.github.com/repos/wardpeet/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/wardpeet/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/wardpeet/lighthouse/events","assignees_url":"https://api.github.com/repos/wardpeet/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/wardpeet/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/wardpeet/lighthouse/tags","blobs_url":"https://api.github.com/repos/wardpeet/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wardpeet/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wardpeet/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/wardpeet/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wardpeet/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/wardpeet/lighthouse/languages","stargazers_url":"https://api.github.com/repos/wardpeet/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/wardpeet/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/wardpeet/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/wardpeet/lighthouse/subscription","commits_url":"https://api.github.com/repos/wardpeet/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/wardpeet/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/wardpeet/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/wardpeet/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/wardpeet/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/wardpeet/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wardpeet/lighthouse/merges","archive_url":"https://api.github.com/repos/wardpeet/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wardpeet/lighthouse/downloads","issues_url":"https://api.github.com/repos/wardpeet/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/wardpeet/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/wardpeet/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/wardpeet/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wardpeet/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/wardpeet/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/wardpeet/lighthouse/deployments","created_at":"2016-05-23T19:33:12Z","updated_at":"2016-05-23T19:33:13Z","pushed_at":"2016-12-13T20:05:42Z","git_url":"git://github.com/wardpeet/lighthouse.git","ssh_url":"git@github.com:wardpeet/lighthouse.git","clone_url":"https://github.com/wardpeet/lighthouse.git","svn_url":"https://github.com/wardpeet/lighthouse","homepage":"","size":8697,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2"},"html":{"href":"https://github.com/wardpeet/lighthouse/pull/2"},"issue":{"href":"https://api.github.com/repos/wardpeet/lighthouse/issues/2"},"comments":{"href":"https://api.github.com/repos/wardpeet/lighthouse/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/wardpeet/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wardpeet/lighthouse/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/wardpeet/lighthouse/statuses/39e834933b381102a95359c56aa1dd29a14c649a"}}}}
{"actor":{"display_login":"brendankenny"}}