{"action":"created","comment":{"url":"https://api.github.com/repos/aura-project/aura/pulls/comments/71990900","id":71990900,"diff_hunk":"@@ -0,0 +1,496 @@\n+﻿// Copyright (c) Aura development team - Licensed under GNU GPL\n+// For more information, see license file in the main folder\n+\n+using Aura.Channel.Network.Sending;\n+using Aura.Channel.Skills.Base;\n+using Aura.Channel.Skills.Magic;\n+using Aura.Channel.Skills.Combat;\n+using Aura.Channel.World;\n+using Aura.Channel.World.Entities;\n+using Aura.Data.Database;\n+using Aura.Mabi.Const;\n+using Aura.Mabi.Network;\n+using Aura.Shared.Network;\n+using Aura.Shared.Util;\n+using System.Drawing;\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Text;\n+using System.Threading.Tasks;\n+\n+namespace Aura.Channel.Skills.Guns\n+{\n+\t/// <summary>\n+\t/// Bullet Storm skill handler\n+\t/// </summary>\n+\t/// Var1: Initial Bullet Use\n+\t/// Var2: Damage Per Shot\n+\t/// Var5: Max Targets\n+\t/// Var6: Attack Spread (Width)\n+\t/// Var7: Attack Range (Length)\n+\t/// Var8: Maximum Damage\n+\t[Skill(SkillId.BulletStorm)]\n+\tpublic class BulletStorm : ISkillHandler, IPreparable, IReadyable, IUseable, ICancelable, IInitiableSkillHandler\n+\t{\n+\t\t/// <summary>\n+\t\t/// Bullet Count Tag for Gun\n+\t\t/// </summary>\n+\t\tprivate const string BulletCountTag = \"GVBC\";\n+\n+\t\t/// <summary>\n+\t\t/// Max Bullets for Gun\n+\t\t/// </summary>\n+\t\tprivate const string BulletsMaxTag = \"BulletsMax\";\n+\n+\t\t/// <summary>\n+\t\t/// Attacker's stun upon using the skill\n+\t\t/// </summary>\n+\t\tprivate const int AttackerStun = 0;\n+\n+\t\t/// <summary>\n+\t\t/// Target's stun after getting hit\n+\t\t/// </summary>\n+\t\tprivate const int TargetStun = 4000;\n+\n+\t\t/// <summary>\n+\t\t/// Distance target gets knocked back\n+\t\t/// </summary>\n+\t\tprivate const int KnockbackDistance = 200;\n+\n+\t\t/// <summary>\n+\t\t/// Target's stability reduction\n+\t\t/// </summary>\n+\t\tprivate const int StabilityReduction = 10;\n+\n+\t\t/// <summary>\n+\t\t/// Subscribes handlers to events required for training.\n+\t\t/// </summary>\n+\t\tpublic void Init()\n+\t\t{\n+\t\t\tChannelServer.Instance.Events.CreatureAttackedByPlayer += this.OnCreatureAttackedByPlayer;\n+\t\t\tChannelServer.Instance.Events.CreatureAttacks += this.OnCreatureAttacks;\n+\t\t}\n+\n+\t\t/// <summary>\n+\t\t/// Prepares the skill\n+\t\t/// </summary>\n+\t\t/// <param name=\"creature\"></param>\n+\t\t/// <param name=\"skill\"></param>\n+\t\t/// <param name=\"packet\"></param>\n+\t\t/// <returns></returns>\n+\t\tpublic bool Prepare(Creature creature, Skill skill, Packet packet)\n+\t\t{\n+\t\t\tif (creature.RightHand == null)\n+\t\t\t\tSend.SkillPrepareSilentCancel(creature, skill.Info.Id);\n+\n+\t\t\t// Set Bullet Count Tag if it doesn't exist\n+\t\t\tif (!creature.RightHand.MetaData1.Has(BulletCountTag))\n+\t\t\t{\n+\t\t\t\tcreature.RightHand.MetaData1.SetShort(BulletCountTag, 0);\n+\t\t\t\tSend.ItemUpdate(creature, creature.RightHand);\n+\t\t\t}\n+\n+\t\t\t// Check Bullet Count\n+\t\t\tvar bulletCount = creature.RightHand.MetaData1.GetShort(BulletCountTag);\n+\t\t\tif (bulletCount < skill.RankData.Var1 && !creature.Conditions.Has(ConditionsD.WayOfTheGun))\n+\t\t\t\tSend.SkillPrepareSilentCancel(creature, skill.Info.Id);","path":"src/ChannelServer/Skills/Guns/BulletStorm.cs","position":97,"original_position":97,"commit_id":"af8510ad6937ff99292b02751ea0632c0cfdc130","original_commit_id":"af8510ad6937ff99292b02751ea0632c0cfdc130","user":{"login":"xeroplz","id":8395686,"avatar_url":"https://avatars.githubusercontent.com/u/8395686?v=3","gravatar_id":"","url":"https://api.github.com/users/xeroplz","html_url":"https://github.com/xeroplz","followers_url":"https://api.github.com/users/xeroplz/followers","following_url":"https://api.github.com/users/xeroplz/following{/other_user}","gists_url":"https://api.github.com/users/xeroplz/gists{/gist_id}","starred_url":"https://api.github.com/users/xeroplz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeroplz/subscriptions","organizations_url":"https://api.github.com/users/xeroplz/orgs","repos_url":"https://api.github.com/users/xeroplz/repos","events_url":"https://api.github.com/users/xeroplz/events{/privacy}","received_events_url":"https://api.github.com/users/xeroplz/received_events","type":"User","site_admin":false},"body":"So instead of sending that, I should just return false - is what you're saying?","created_at":"2016-07-24T15:52:23Z","updated_at":"2016-07-24T15:52:23Z","html_url":"https://github.com/aura-project/aura/pull/333#discussion_r71990900","pull_request_url":"https://api.github.com/repos/aura-project/aura/pulls/333","_links":{"self":{"href":"https://api.github.com/repos/aura-project/aura/pulls/comments/71990900"},"html":{"href":"https://github.com/aura-project/aura/pull/333#discussion_r71990900"},"pull_request":{"href":"https://api.github.com/repos/aura-project/aura/pulls/333"}}},"pull_request":{"url":"https://api.github.com/repos/aura-project/aura/pulls/333","id":75585764,"html_url":"https://github.com/aura-project/aura/pull/333","diff_url":"https://github.com/aura-project/aura/pull/333.diff","patch_url":"https://github.com/aura-project/aura/pull/333.patch","issue_url":"https://api.github.com/repos/aura-project/aura/issues/333","number":333,"state":"open","locked":false,"title":"Dual Gun Skills added","user":{"login":"xeroplz","id":8395686,"avatar_url":"https://avatars.githubusercontent.com/u/8395686?v=3","gravatar_id":"","url":"https://api.github.com/users/xeroplz","html_url":"https://github.com/xeroplz","followers_url":"https://api.github.com/users/xeroplz/followers","following_url":"https://api.github.com/users/xeroplz/following{/other_user}","gists_url":"https://api.github.com/users/xeroplz/gists{/gist_id}","starred_url":"https://api.github.com/users/xeroplz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeroplz/subscriptions","organizations_url":"https://api.github.com/users/xeroplz/orgs","repos_url":"https://api.github.com/users/xeroplz/repos","events_url":"https://api.github.com/users/xeroplz/events{/privacy}","received_events_url":"https://api.github.com/users/xeroplz/received_events","type":"User","site_admin":false},"body":"- Adds all Dual Gun skills\r\n- Adds bulletsMax entries in the item database for guns\r\n- Adds partial support for MultiHit TargetOptions","created_at":"2016-06-29T04:08:30Z","updated_at":"2016-07-24T15:52:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a6f60ae1f161dfcc6825ff796dff9c75f1acf62","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aura-project/aura/pulls/333/commits","review_comments_url":"https://api.github.com/repos/aura-project/aura/pulls/333/comments","review_comment_url":"https://api.github.com/repos/aura-project/aura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aura-project/aura/issues/333/comments","statuses_url":"https://api.github.com/repos/aura-project/aura/statuses/af8510ad6937ff99292b02751ea0632c0cfdc130","head":{"label":"xeroplz:gunner_skills_pr","ref":"gunner_skills_pr","sha":"af8510ad6937ff99292b02751ea0632c0cfdc130","user":{"login":"xeroplz","id":8395686,"avatar_url":"https://avatars.githubusercontent.com/u/8395686?v=3","gravatar_id":"","url":"https://api.github.com/users/xeroplz","html_url":"https://github.com/xeroplz","followers_url":"https://api.github.com/users/xeroplz/followers","following_url":"https://api.github.com/users/xeroplz/following{/other_user}","gists_url":"https://api.github.com/users/xeroplz/gists{/gist_id}","starred_url":"https://api.github.com/users/xeroplz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeroplz/subscriptions","organizations_url":"https://api.github.com/users/xeroplz/orgs","repos_url":"https://api.github.com/users/xeroplz/repos","events_url":"https://api.github.com/users/xeroplz/events{/privacy}","received_events_url":"https://api.github.com/users/xeroplz/received_events","type":"User","site_admin":false},"repo":{"id":42081201,"name":"aura","full_name":"xeroplz/aura","owner":{"login":"xeroplz","id":8395686,"avatar_url":"https://avatars.githubusercontent.com/u/8395686?v=3","gravatar_id":"","url":"https://api.github.com/users/xeroplz","html_url":"https://github.com/xeroplz","followers_url":"https://api.github.com/users/xeroplz/followers","following_url":"https://api.github.com/users/xeroplz/following{/other_user}","gists_url":"https://api.github.com/users/xeroplz/gists{/gist_id}","starred_url":"https://api.github.com/users/xeroplz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeroplz/subscriptions","organizations_url":"https://api.github.com/users/xeroplz/orgs","repos_url":"https://api.github.com/users/xeroplz/repos","events_url":"https://api.github.com/users/xeroplz/events{/privacy}","received_events_url":"https://api.github.com/users/xeroplz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xeroplz/aura","description":"Open-source server emulator","fork":true,"url":"https://api.github.com/repos/xeroplz/aura","forks_url":"https://api.github.com/repos/xeroplz/aura/forks","keys_url":"https://api.github.com/repos/xeroplz/aura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xeroplz/aura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xeroplz/aura/teams","hooks_url":"https://api.github.com/repos/xeroplz/aura/hooks","issue_events_url":"https://api.github.com/repos/xeroplz/aura/issues/events{/number}","events_url":"https://api.github.com/repos/xeroplz/aura/events","assignees_url":"https://api.github.com/repos/xeroplz/aura/assignees{/user}","branches_url":"https://api.github.com/repos/xeroplz/aura/branches{/branch}","tags_url":"https://api.github.com/repos/xeroplz/aura/tags","blobs_url":"https://api.github.com/repos/xeroplz/aura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xeroplz/aura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xeroplz/aura/git/refs{/sha}","trees_url":"https://api.github.com/repos/xeroplz/aura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xeroplz/aura/statuses/{sha}","languages_url":"https://api.github.com/repos/xeroplz/aura/languages","stargazers_url":"https://api.github.com/repos/xeroplz/aura/stargazers","contributors_url":"https://api.github.com/repos/xeroplz/aura/contributors","subscribers_url":"https://api.github.com/repos/xeroplz/aura/subscribers","subscription_url":"https://api.github.com/repos/xeroplz/aura/subscription","commits_url":"https://api.github.com/repos/xeroplz/aura/commits{/sha}","git_commits_url":"https://api.github.com/repos/xeroplz/aura/git/commits{/sha}","comments_url":"https://api.github.com/repos/xeroplz/aura/comments{/number}","issue_comment_url":"https://api.github.com/repos/xeroplz/aura/issues/comments{/number}","contents_url":"https://api.github.com/repos/xeroplz/aura/contents/{+path}","compare_url":"https://api.github.com/repos/xeroplz/aura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xeroplz/aura/merges","archive_url":"https://api.github.com/repos/xeroplz/aura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xeroplz/aura/downloads","issues_url":"https://api.github.com/repos/xeroplz/aura/issues{/number}","pulls_url":"https://api.github.com/repos/xeroplz/aura/pulls{/number}","milestones_url":"https://api.github.com/repos/xeroplz/aura/milestones{/number}","notifications_url":"https://api.github.com/repos/xeroplz/aura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xeroplz/aura/labels{/name}","releases_url":"https://api.github.com/repos/xeroplz/aura/releases{/id}","deployments_url":"https://api.github.com/repos/xeroplz/aura/deployments","created_at":"2015-09-08T00:42:17Z","updated_at":"2016-02-21T19:10:56Z","pushed_at":"2016-07-18T01:34:18Z","git_url":"git://github.com/xeroplz/aura.git","ssh_url":"git@github.com:xeroplz/aura.git","clone_url":"https://github.com/xeroplz/aura.git","svn_url":"https://github.com/xeroplz/aura","homepage":"http://aura-project.org","size":114112,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master_new"}},"base":{"label":"aura-project:master","ref":"master","sha":"00dff4d456fc75f4d9c8acaa874b0a5a62127962","user":{"login":"aura-project","id":5599478,"avatar_url":"https://avatars.githubusercontent.com/u/5599478?v=3","gravatar_id":"","url":"https://api.github.com/users/aura-project","html_url":"https://github.com/aura-project","followers_url":"https://api.github.com/users/aura-project/followers","following_url":"https://api.github.com/users/aura-project/following{/other_user}","gists_url":"https://api.github.com/users/aura-project/gists{/gist_id}","starred_url":"https://api.github.com/users/aura-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aura-project/subscriptions","organizations_url":"https://api.github.com/users/aura-project/orgs","repos_url":"https://api.github.com/users/aura-project/repos","events_url":"https://api.github.com/users/aura-project/events{/privacy}","received_events_url":"https://api.github.com/users/aura-project/received_events","type":"Organization","site_admin":false},"repo":{"id":41106906,"name":"aura","full_name":"aura-project/aura","owner":{"login":"aura-project","id":5599478,"avatar_url":"https://avatars.githubusercontent.com/u/5599478?v=3","gravatar_id":"","url":"https://api.github.com/users/aura-project","html_url":"https://github.com/aura-project","followers_url":"https://api.github.com/users/aura-project/followers","following_url":"https://api.github.com/users/aura-project/following{/other_user}","gists_url":"https://api.github.com/users/aura-project/gists{/gist_id}","starred_url":"https://api.github.com/users/aura-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aura-project/subscriptions","organizations_url":"https://api.github.com/users/aura-project/orgs","repos_url":"https://api.github.com/users/aura-project/repos","events_url":"https://api.github.com/users/aura-project/events{/privacy}","received_events_url":"https://api.github.com/users/aura-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aura-project/aura","description":"Open-source MMORPG server emulator","fork":false,"url":"https://api.github.com/repos/aura-project/aura","forks_url":"https://api.github.com/repos/aura-project/aura/forks","keys_url":"https://api.github.com/repos/aura-project/aura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aura-project/aura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aura-project/aura/teams","hooks_url":"https://api.github.com/repos/aura-project/aura/hooks","issue_events_url":"https://api.github.com/repos/aura-project/aura/issues/events{/number}","events_url":"https://api.github.com/repos/aura-project/aura/events","assignees_url":"https://api.github.com/repos/aura-project/aura/assignees{/user}","branches_url":"https://api.github.com/repos/aura-project/aura/branches{/branch}","tags_url":"https://api.github.com/repos/aura-project/aura/tags","blobs_url":"https://api.github.com/repos/aura-project/aura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aura-project/aura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aura-project/aura/git/refs{/sha}","trees_url":"https://api.github.com/repos/aura-project/aura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aura-project/aura/statuses/{sha}","languages_url":"https://api.github.com/repos/aura-project/aura/languages","stargazers_url":"https://api.github.com/repos/aura-project/aura/stargazers","contributors_url":"https://api.github.com/repos/aura-project/aura/contributors","subscribers_url":"https://api.github.com/repos/aura-project/aura/subscribers","subscription_url":"https://api.github.com/repos/aura-project/aura/subscription","commits_url":"https://api.github.com/repos/aura-project/aura/commits{/sha}","git_commits_url":"https://api.github.com/repos/aura-project/aura/git/commits{/sha}","comments_url":"https://api.github.com/repos/aura-project/aura/comments{/number}","issue_comment_url":"https://api.github.com/repos/aura-project/aura/issues/comments{/number}","contents_url":"https://api.github.com/repos/aura-project/aura/contents/{+path}","compare_url":"https://api.github.com/repos/aura-project/aura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aura-project/aura/merges","archive_url":"https://api.github.com/repos/aura-project/aura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aura-project/aura/downloads","issues_url":"https://api.github.com/repos/aura-project/aura/issues{/number}","pulls_url":"https://api.github.com/repos/aura-project/aura/pulls{/number}","milestones_url":"https://api.github.com/repos/aura-project/aura/milestones{/number}","notifications_url":"https://api.github.com/repos/aura-project/aura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aura-project/aura/labels{/name}","releases_url":"https://api.github.com/repos/aura-project/aura/releases{/id}","deployments_url":"https://api.github.com/repos/aura-project/aura/deployments","created_at":"2015-08-20T16:32:57Z","updated_at":"2016-07-20T05:55:50Z","pushed_at":"2016-07-24T13:48:13Z","git_url":"git://github.com/aura-project/aura.git","ssh_url":"git@github.com:aura-project/aura.git","clone_url":"https://github.com/aura-project/aura.git","svn_url":"https://github.com/aura-project/aura","homepage":"http://aura-project.org","size":115367,"stargazers_count":67,"watchers_count":67,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":33,"forks":54,"open_issues":33,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aura-project/aura/pulls/333"},"html":{"href":"https://github.com/aura-project/aura/pull/333"},"issue":{"href":"https://api.github.com/repos/aura-project/aura/issues/333"},"comments":{"href":"https://api.github.com/repos/aura-project/aura/issues/333/comments"},"review_comments":{"href":"https://api.github.com/repos/aura-project/aura/pulls/333/comments"},"review_comment":{"href":"https://api.github.com/repos/aura-project/aura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aura-project/aura/pulls/333/commits"},"statuses":{"href":"https://api.github.com/repos/aura-project/aura/statuses/af8510ad6937ff99292b02751ea0632c0cfdc130"}}}}
{"actor":{"display_login":"xeroplz"}}