{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/76056232","id":76056232,"diff_hunk":"@@ -0,0 +1,71 @@\n+#!/opt/mesosphere/bin/python3\n+\n+import os\n+import subprocess\n+import sys\n+\n+class IsolatorDiscoveryException(Exception):\n+        pass\n+\n+def has_nvidia():\n+    \"\"\"\n+    Test if we have nvidia available\n+    \"\"\"\n+    nvidia_smi_binary = '/bin/nvidia-smi'\n+\n+    # Make sure file is there and with correct permissions\n+    if not os.path.isfile(nvidia_smi_binary):\n+        return False\n+    if not os.access(nvidia_smi_binary, os.X_OK):\n+        return False\n+\n+    # Try to run it","path":"packages/mesos/extra/make_isolators.py","position":22,"original_position":22,"commit_id":"23381492c9c5d63df21c1e19f8b708619498e195","original_commit_id":"23381492c9c5d63df21c1e19f8b708619498e195","user":{"login":"orsenthil","id":332330,"avatar_url":"https://avatars.githubusercontent.com/u/332330?v=3","gravatar_id":"","url":"https://api.github.com/users/orsenthil","html_url":"https://github.com/orsenthil","followers_url":"https://api.github.com/users/orsenthil/followers","following_url":"https://api.github.com/users/orsenthil/following{/other_user}","gists_url":"https://api.github.com/users/orsenthil/gists{/gist_id}","starred_url":"https://api.github.com/users/orsenthil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orsenthil/subscriptions","organizations_url":"https://api.github.com/users/orsenthil/orgs","repos_url":"https://api.github.com/users/orsenthil/repos","events_url":"https://api.github.com/users/orsenthil/events{/privacy}","received_events_url":"https://api.github.com/users/orsenthil/received_events","type":"User","site_admin":false},"body":"[readability review] - please kill all the comments in this file. In practice, I have seen comments that explain \"why\" (when needed) are helpful.  Comments that explain \"what\" should be avoided.","created_at":"2016-08-24T13:32:32Z","updated_at":"2016-08-24T13:32:32Z","html_url":"https://github.com/dcos/dcos/pull/550#discussion_r76056232","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/550","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/76056232"},"html":{"href":"https://github.com/dcos/dcos/pull/550#discussion_r76056232"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/550"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/550","id":81557618,"html_url":"https://github.com/dcos/dcos/pull/550","diff_url":"https://github.com/dcos/dcos/pull/550.diff","patch_url":"https://github.com/dcos/dcos/pull/550.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/550","number":550,"state":"open","locked":false,"title":"[WIP] Experimental GPU Support","user":{"login":"wavesoft","id":883486,"avatar_url":"https://avatars.githubusercontent.com/u/883486?v=3","gravatar_id":"","url":"https://api.github.com/users/wavesoft","html_url":"https://github.com/wavesoft","followers_url":"https://api.github.com/users/wavesoft/followers","following_url":"https://api.github.com/users/wavesoft/following{/other_user}","gists_url":"https://api.github.com/users/wavesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/wavesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavesoft/subscriptions","organizations_url":"https://api.github.com/users/wavesoft/orgs","repos_url":"https://api.github.com/users/wavesoft/repos","events_url":"https://api.github.com/users/wavesoft/events{/privacy}","received_events_url":"https://api.github.com/users/wavesoft/received_events","type":"User","site_admin":false},"body":"- Enabling GPU support on marathon\r\n- Adding general purpose isolator detection to private/public slaves in mesos package (currently only detecting GPUs and adding `gpu/nvidia` isolator)\r\n","created_at":"2016-08-16T22:44:37Z","updated_at":"2016-08-24T13:32:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f63392c9d382e7bbfd288d5a34786003e15e5844","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/550/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/550/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/550/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/23381492c9c5d63df21c1e19f8b708619498e195","head":{"label":"wavesoft:ic/feat/gpu-support","ref":"ic/feat/gpu-support","sha":"23381492c9c5d63df21c1e19f8b708619498e195","user":{"login":"wavesoft","id":883486,"avatar_url":"https://avatars.githubusercontent.com/u/883486?v=3","gravatar_id":"","url":"https://api.github.com/users/wavesoft","html_url":"https://github.com/wavesoft","followers_url":"https://api.github.com/users/wavesoft/followers","following_url":"https://api.github.com/users/wavesoft/following{/other_user}","gists_url":"https://api.github.com/users/wavesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/wavesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavesoft/subscriptions","organizations_url":"https://api.github.com/users/wavesoft/orgs","repos_url":"https://api.github.com/users/wavesoft/repos","events_url":"https://api.github.com/users/wavesoft/events{/privacy}","received_events_url":"https://api.github.com/users/wavesoft/received_events","type":"User","site_admin":false},"repo":{"id":65771470,"name":"dcos","full_name":"wavesoft/dcos","owner":{"login":"wavesoft","id":883486,"avatar_url":"https://avatars.githubusercontent.com/u/883486?v=3","gravatar_id":"","url":"https://api.github.com/users/wavesoft","html_url":"https://github.com/wavesoft","followers_url":"https://api.github.com/users/wavesoft/followers","following_url":"https://api.github.com/users/wavesoft/following{/other_user}","gists_url":"https://api.github.com/users/wavesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/wavesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavesoft/subscriptions","organizations_url":"https://api.github.com/users/wavesoft/orgs","repos_url":"https://api.github.com/users/wavesoft/repos","events_url":"https://api.github.com/users/wavesoft/events{/privacy}","received_events_url":"https://api.github.com/users/wavesoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wavesoft/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/wavesoft/dcos","forks_url":"https://api.github.com/repos/wavesoft/dcos/forks","keys_url":"https://api.github.com/repos/wavesoft/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wavesoft/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wavesoft/dcos/teams","hooks_url":"https://api.github.com/repos/wavesoft/dcos/hooks","issue_events_url":"https://api.github.com/repos/wavesoft/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/wavesoft/dcos/events","assignees_url":"https://api.github.com/repos/wavesoft/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/wavesoft/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/wavesoft/dcos/tags","blobs_url":"https://api.github.com/repos/wavesoft/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wavesoft/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wavesoft/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/wavesoft/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wavesoft/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/wavesoft/dcos/languages","stargazers_url":"https://api.github.com/repos/wavesoft/dcos/stargazers","contributors_url":"https://api.github.com/repos/wavesoft/dcos/contributors","subscribers_url":"https://api.github.com/repos/wavesoft/dcos/subscribers","subscription_url":"https://api.github.com/repos/wavesoft/dcos/subscription","commits_url":"https://api.github.com/repos/wavesoft/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/wavesoft/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/wavesoft/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/wavesoft/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/wavesoft/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/wavesoft/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wavesoft/dcos/merges","archive_url":"https://api.github.com/repos/wavesoft/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wavesoft/dcos/downloads","issues_url":"https://api.github.com/repos/wavesoft/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/wavesoft/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/wavesoft/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/wavesoft/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wavesoft/dcos/labels{/name}","releases_url":"https://api.github.com/repos/wavesoft/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/wavesoft/dcos/deployments","created_at":"2016-08-15T23:19:14Z","updated_at":"2016-08-15T23:19:15Z","pushed_at":"2016-08-17T00:02:09Z","git_url":"git://github.com/wavesoft/dcos.git","ssh_url":"git@github.com:wavesoft/dcos.git","clone_url":"https://github.com/wavesoft/dcos.git","svn_url":"https://github.com/wavesoft/dcos","homepage":"https://dcos.io","size":1348,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:1.8.1","ref":"1.8.1","sha":"c1915a9f9f02caf7e34022eaea04f15ff853bd0e","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2016-08-24T08:06:00Z","pushed_at":"2016-08-24T08:07:34Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":2106,"stargazers_count":809,"watchers_count":809,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":30,"forks":139,"open_issues":30,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/550"},"html":{"href":"https://github.com/dcos/dcos/pull/550"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/550"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/550/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/550/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/550/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/23381492c9c5d63df21c1e19f8b708619498e195"}}}}
{"actor":{"display_login":"orsenthil"}}