{"push_id":1392157624,"size":12,"distinct_size":1,"ref":"refs/heads/cjb/DESKTOP-2047-chat-input","head":"8144e626a470eda4fe439e3b8f4ec552fcfd94ca","before":"20cd5361a39ef5e203e6a4e304ae745d38bf01ba","commits":[{"sha":"5b5886b5267b39d683ac297f114e1e42ff60c06f","author":{"name":"Patrick Crosby","email":"d24a499c237ed78fb92811cdc25b4ecc43f0083d@gmail.com"},"message":"Fix empty title handling","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/5b5886b5267b39d683ac297f114e1e42ff60c06f"},{"sha":"55c7724812d3baeb0803accd16cadd1778836103","author":{"name":"Patrick Crosby","email":"d24a499c237ed78fb92811cdc25b4ecc43f0083d@gmail.com"},"message":"Remove WIP test","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/55c7724812d3baeb0803accd16cadd1778836103"},{"sha":"d0ac54ec0b8711479ccd901fd9ff95c81189c254","author":{"name":"Andy Alness","email":"6214817aa919a6dc8a1f1766b0adfdad37b7bfec@gmail.com"},"message":"add crypto.SignForKBFS rpc method","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/d0ac54ec0b8711479ccd901fd9ff95c81189c254"},{"sha":"466c0e5938005a7451cfc0b1f51fa0f16dfa99e4","author":{"name":"Andy Alness","email":"6214817aa919a6dc8a1f1766b0adfdad37b7bfec@gmail.com"},"message":"Merge pull request #4792 from keybase/andy/KBFS-512-signforkbfs\n\nadd crypto.SignForKBFS rpc method","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/466c0e5938005a7451cfc0b1f51fa0f16dfa99e4"},{"sha":"649b8bdb13a746f1884c31d1091edda10a8a5c3f","author":{"name":"Marco Munizaga","email":"b8861d949a418f1cd6fe09603676e34a0f3a51d2@marcopolo.io"},"message":"Fix dropdown picker on android (#4801)","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/649b8bdb13a746f1884c31d1091edda10a8a5c3f"},{"sha":"463116220f74987d5e164a93e555ccafb84e796f","author":{"name":"Jack O'Connor","email":"7f87306ac2919bc45d460ed32f68f968c6dd92b4@gmail.com"},"message":"actually parse Facebook desktop markup, and unescape '--' properly\n\nPreviously we were doing a plain text search for proof text in the\ndesktop page. That was a little sketchy structurally, but it also ran\ninto a correctness issue: comments can't contain a \"--\" character, and\nif proofs contained that pair (as it does in a random 1% of our base64\nmedium sig IDs), we weren't matching it properly.\n\nThe simplest possible thing would be to just replace \"--\" with \"-\\-\\\"\nbefore we match. That would *probably* work. However there's a lot of\nbasic HTML escaping (like &amp;) that's allowed in this context, so\ncomparing escaped strings char-by-char is an escaping-flexibility\nlandmine just waiting to explode and break us again.\n\nInstead of looking for escaped text in the page, we should be\n*unescaping* text and comparing it to our known string. To do that right\nwe need to properly structurally parse the page instead of blindly\nstring searching it. That requires a second parse in the middle, which\nis a little complicated, but it works, and it feels much safer in the\nlong term. (Way less likely to get confused by other text that could\nsneak into the page.)","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/463116220f74987d5e164a93e555ccafb84e796f"},{"sha":"a9a1d2241e6801e7ff0d4a7af8fbb3772fe20f9a","author":{"name":"Maxwell Krohn","email":"399f28450dabdd66e09a2d2778cf0144f63bfad6@gmail.com"},"message":"fix test that can fail if windows is slow (#4810)\n\n- 1 -> 10","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/a9a1d2241e6801e7ff0d4a7af8fbb3772fe20f9a"},{"sha":"a86cda88d8b549a6888dce778cb6f9b13c318846","author":{"name":"Maxwell Krohn","email":"399f28450dabdd66e09a2d2778cf0144f63bfad6@gmail.com"},"message":"fix rare race condition in merkle client rollback (#4809)\n\n- implement @oconnor663's strategy of taking the merkle root before the call is made.","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/a86cda88d8b549a6888dce778cb6f9b13c318846"},{"sha":"007a7ce17ecf54e2baa94c4ae1022124bac7637b","author":{"name":"Jack O'Connor","email":"7f87306ac2919bc45d460ed32f68f968c6dd92b4@gmail.com"},"message":"comment fixes for signencrypt","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/007a7ce17ecf54e2baa94c4ae1022124bac7637b"},{"sha":"a380bd17b6a1058f92a35417e6780d6567a60f57","author":{"name":"Patrick Crosby","email":"d24a499c237ed78fb92811cdc25b4ecc43f0083d@gmail.com"},"message":"Merge pull request #4806 from keybase/fix_title\n\nFix title","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/a380bd17b6a1058f92a35417e6780d6567a60f57"},{"sha":"9a458963684fe9aa3332557bc0fcc7e00fa4b46d","author":{"name":"Steve Sanders","email":"5eb4f8ae09d1b5661f1add989b1c3fabe443bd83@keyba.se"},"message":"Use icon from keybase.exe for kbfs mount (#4799)\n\n* Use icon from keybase.exe for kbfs mount\r\n\r\n* review comment","distinct":false,"url":"https://api.github.com/repos/keybase/client/commits/9a458963684fe9aa3332557bc0fcc7e00fa4b46d"},{"sha":"8144e626a470eda4fe439e3b8f4ec552fcfd94ca","author":{"name":"Chris Ball","email":"4181b934c2715a2bba60cdb3cc1b35b2777d1c23@printf.net"},"message":"Merge branch 'master' of github.com:keybase/client into cjb/DESKTOP-2047-chat-input","distinct":true,"url":"https://api.github.com/repos/keybase/client/commits/8144e626a470eda4fe439e3b8f4ec552fcfd94ca"}]}
{"actor":{"display_login":"cjb"}}