{"push_id":1139382532,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"6eb8844d9731a569e3a012b88acb2ef6826e2861","before":"ba8d9ef692c062891199d1639d435a6259134d7e","commits":[{"sha":"081fc4860b7ba3a87020d2ddae006f667616fed0","author":{"name":"Rodrigo Barbieri","email":"150fd954e4a8fd9773e2e1b54036f8ae9fde601d@fit-tecnologia.org.br"},"message":"Fix HDS HNAS errors caused by incorrect IDs\n\nWhen attempting to allow_access on a managed share, it fails\nbecause the proper share ID is not retrieved from private storage\nprior to attempting to validate that the share exists in the\nbackend. The same happens when trying to create a share from a\nsnapshot created from a managed share, the proper share ID is\nnot retrieved from private storage. While we are dealing with\ntwo possible different IDs it is important to properly display\nthe API share ID in log messages so it can be matched to the\nshare instances ID, and not all log messages are accurately doing\nso.\n\nThis change addresses this by retrieving the ID from\nprivate storage first for update_access and\ncreate_share_from_snapshot operations. The proper unit test changes\nincluded in this patch required a refactor of several IDs to ensure\nthis problem is addressed in unit tests, thus it made sense to\naddress several bugs caused by the same problem, having the same fix\nand requiring modifications to the same lines of code.\n\nCloses-bug: #1581541\nCloses-bug: #1584179\nCloses-bug: #1583785\nChange-Id: I8cdb1a8a72a4ac7e710f57e3c288d48cd2adf0dd","distinct":true,"url":"https://api.github.com/repos/openstack/manila/commits/081fc4860b7ba3a87020d2ddae006f667616fed0"},{"sha":"6eb8844d9731a569e3a012b88acb2ef6826e2861","author":{"name":"Jenkins","email":"61eb39d4445155efb6068840385577c11776cd20@review.openstack.org"},"message":"Merge \"Fix HDS HNAS errors caused by incorrect IDs\"","distinct":true,"url":"https://api.github.com/repos/openstack/manila/commits/6eb8844d9731a569e3a012b88acb2ef6826e2861"}]}
{"actor":{"display_login":"openstack-gerrit"}}