{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/57479572","id":57479572,"diff_hunk":"@@ -68,6 +68,25 @@\n             {false, false, false, false, false, false, false, false, false, false, true},   // POLYGON\n         };\n \n+    // row index provides the type converting \"from\" (user supplied data of certain type)\n+    // column index provides the type converting \"to\" (the actual column type in table)\n+    // to see type for column (to) or row (from), map it's index m_tableColTypeVal to get it's type\n+    // this is based on allowed type conversion for comparison which in list param arguments uses\n+    boolean [][] m_typeConversionMatrixInList =","path":"tests/frontend/org/voltdb/regressionsuites/TestTypeConversionSuite.java","position":17,"original_position":17,"commit_id":"6b60b7b4fa21ca31d4735000c70e7431a51ec147","original_commit_id":"6b60b7b4fa21ca31d4735000c70e7431a51ec147","user":{"login":"hhakimi53","id":13318654,"avatar_url":"https://avatars.githubusercontent.com/u/13318654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhakimi53","html_url":"https://github.com/hhakimi53","followers_url":"https://api.github.com/users/hhakimi53/followers","following_url":"https://api.github.com/users/hhakimi53/following{/other_user}","gists_url":"https://api.github.com/users/hhakimi53/gists{/gist_id}","starred_url":"https://api.github.com/users/hhakimi53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhakimi53/subscriptions","organizations_url":"https://api.github.com/users/hhakimi53/orgs","repos_url":"https://api.github.com/users/hhakimi53/repos","events_url":"https://api.github.com/users/hhakimi53/events{/privacy}","received_events_url":"https://api.github.com/users/hhakimi53/received_events","type":"User","site_admin":false},"body":"ok, sure.","created_at":"2016-03-25T19:16:27Z","updated_at":"2016-03-25T19:16:27Z","html_url":"https://github.com/VoltDB/voltdb/pull/3376#discussion_r57479572","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/57479572"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/3376#discussion_r57479572"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376","id":62292695,"html_url":"https://github.com/VoltDB/voltdb/pull/3376","diff_url":"https://github.com/VoltDB/voltdb/pull/3376.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/3376.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/3376","number":3376,"state":"open","locked":false,"title":"Logic update to voltqueuesql to disallow operation where implicit type conversion is not possible","user":{"login":"hhakimi53","id":13318654,"avatar_url":"https://avatars.githubusercontent.com/u/13318654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhakimi53","html_url":"https://github.com/hhakimi53","followers_url":"https://api.github.com/users/hhakimi53/followers","following_url":"https://api.github.com/users/hhakimi53/following{/other_user}","gists_url":"https://api.github.com/users/hhakimi53/gists{/gist_id}","starred_url":"https://api.github.com/users/hhakimi53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhakimi53/subscriptions","organizations_url":"https://api.github.com/users/hhakimi53/orgs","repos_url":"https://api.github.com/users/hhakimi53/repos","events_url":"https://api.github.com/users/hhakimi53/events{/privacy}","received_events_url":"https://api.github.com/users/hhakimi53/received_events","type":"User","site_admin":false},"body":"Update logic in voltqueuesql to perform check if the implicit type conversion for the passed-in parameter is feasible. If not feasible, the operation in voltqueuesql fails with error message indicating which argument, its type. Conversion matrix is based on the broadest scenarios where implicit conversion can  happen in EE, so that we disallow only the conversion which are not feasible in EE to avoid regression on working case. Disallowing such operation will help in some of the cases where type conversion is not happening in EE, like passing in string for geo type column, and preventing potential undefined behavior.","created_at":"2016-03-09T20:42:59Z","updated_at":"2016-03-25T19:16:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e20bac4ec8beee8b41f0052930ecacd616a035a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/3376/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/6b60b7b4fa21ca31d4735000c70e7431a51ec147","head":{"label":"VoltDB:ENG-9944","ref":"ENG-9944","sha":"6b60b7b4fa21ca31d4735000c70e7431a51ec147","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2016-03-23T19:02:50Z","pushed_at":"2016-03-25T19:15:41Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":585092,"stargazers_count":748,"watchers_count":748,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":21,"forks":224,"open_issues":21,"watchers":748,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"3fbbd2d55acb166ab41882341d2235a2e5867997","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","deployments_url":"https://api.github.com/repos/VoltDB/voltdb/deployments","created_at":"2011-09-23T18:46:12Z","updated_at":"2016-03-23T19:02:50Z","pushed_at":"2016-03-25T19:15:41Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":585092,"stargazers_count":748,"watchers_count":748,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":21,"forks":224,"open_issues":21,"watchers":748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/3376"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/3376"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/3376/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/3376/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/6b60b7b4fa21ca31d4735000c70e7431a51ec147"}}}}