{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/video.js/issues/3772","repository_url":"https://api.github.com/repos/videojs/video.js","labels_url":"https://api.github.com/repos/videojs/video.js/issues/3772/labels{/name}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3772/comments","events_url":"https://api.github.com/repos/videojs/video.js/issues/3772/events","html_url":"https://github.com/videojs/video.js/pull/3772","id":188628822,"number":3772,"title":"fix(html5): exit early on emulated tracks in html5","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-10T21:54:29Z","updated_at":"2016-11-11T15:34:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3772","html_url":"https://github.com/videojs/video.js/pull/3772","diff_url":"https://github.com/videojs/video.js/pull/3772.diff","patch_url":"https://github.com/videojs/video.js/pull/3772.patch"},"body":"addRemoteTextTrack and removeRemoteTextTrack in Html5 tech assumed that\r\nthey are always called for native text tracks. However, Html5 tech can\r\nhave emulated text tracks. For those, we just exit early after the super\r\nmethods are called."},"comment":{"url":"https://api.github.com/repos/videojs/video.js/issues/comments/259983166","html_url":"https://github.com/videojs/video.js/pull/3772#issuecomment-259983166","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3772","id":259983166,"user":{"login":"boushley","id":101239,"avatar_url":"https://avatars.githubusercontent.com/u/101239?v=3","gravatar_id":"","url":"https://api.github.com/users/boushley","html_url":"https://github.com/boushley","followers_url":"https://api.github.com/users/boushley/followers","following_url":"https://api.github.com/users/boushley/following{/other_user}","gists_url":"https://api.github.com/users/boushley/gists{/gist_id}","starred_url":"https://api.github.com/users/boushley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boushley/subscriptions","organizations_url":"https://api.github.com/users/boushley/orgs","repos_url":"https://api.github.com/users/boushley/repos","events_url":"https://api.github.com/users/boushley/events{/privacy}","received_events_url":"https://api.github.com/users/boushley/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T15:34:41Z","updated_at":"2016-11-11T15:34:41Z","body":"This works and so is great!\r\n\r\nI think I would actually prefer using the non-negated if here for both cases. It cleans up the add track case significantly, and the remove track case isn't so big that the extra indentation causes lots of problems. The reason for this is that it makes the return path consistent. For remove this isn't a big deal, but for add it's nice to have a single return since it makes it easier to verify that both cases return the same data.\r\n\r\nThat said, this is a pretty minor thing for such small methods, so I'm fine as is."}}
{"actor":{"display_login":"boushley"}}