{"action":"closed","number":26933,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/26933","id":91515260,"html_url":"https://github.com/rails/rails/pull/26933","diff_url":"https://github.com/rails/rails/pull/26933.diff","patch_url":"https://github.com/rails/rails/pull/26933.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/26933","number":26933,"state":"closed","locked":false,"title":"Fix an issue with JSON encoding of \"Infinity\" and \"NaN\" values","user":{"login":"prathamesh-sonpatki","id":621238,"avatar_url":"https://avatars.githubusercontent.com/u/621238?v=3","gravatar_id":"","url":"https://api.github.com/users/prathamesh-sonpatki","html_url":"https://github.com/prathamesh-sonpatki","followers_url":"https://api.github.com/users/prathamesh-sonpatki/followers","following_url":"https://api.github.com/users/prathamesh-sonpatki/following{/other_user}","gists_url":"https://api.github.com/users/prathamesh-sonpatki/gists{/gist_id}","starred_url":"https://api.github.com/users/prathamesh-sonpatki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prathamesh-sonpatki/subscriptions","organizations_url":"https://api.github.com/users/prathamesh-sonpatki/orgs","repos_url":"https://api.github.com/users/prathamesh-sonpatki/repos","events_url":"https://api.github.com/users/prathamesh-sonpatki/events{/privacy}","received_events_url":"https://api.github.com/users/prathamesh-sonpatki/received_events","type":"User","site_admin":false},"body":"### Summary\n- When `as_json` returns `Infinity` or `NaN` as the value of any of the key,\n  we don't used to call `as_json` on it as it was treated as primitive.\n- This used to pass `Infinity` or `NaN` to `JSON.generate` and Ruby used\n  to throw an error for `Infinity/NaN not allowed in JSON.`\n- This patch changes the code to call `as_json` on these primitives so\n  that they are converted to proper values before being passed to\n  `JSON.generate`.\n- Fixes #26877.\n\nr? @chancancode \n","created_at":"2016-10-30T08:47:45Z","updated_at":"2016-11-13T14:46:21Z","closed_at":"2016-11-13T14:46:21Z","merged_at":"2016-11-13T14:46:21Z","merge_commit_sha":"c85d305a67f83f3a92488a641654b85b90b8747a","assignee":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"assignees":[{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/26933/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/26933/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/26933/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/8776f15b448ed88b1108e70f2de22f0b599818aa","head":{"label":"prathamesh-sonpatki:fix-26877","ref":"fix-26877","sha":"8776f15b448ed88b1108e70f2de22f0b599818aa","user":{"login":"prathamesh-sonpatki","id":621238,"avatar_url":"https://avatars.githubusercontent.com/u/621238?v=3","gravatar_id":"","url":"https://api.github.com/users/prathamesh-sonpatki","html_url":"https://github.com/prathamesh-sonpatki","followers_url":"https://api.github.com/users/prathamesh-sonpatki/followers","following_url":"https://api.github.com/users/prathamesh-sonpatki/following{/other_user}","gists_url":"https://api.github.com/users/prathamesh-sonpatki/gists{/gist_id}","starred_url":"https://api.github.com/users/prathamesh-sonpatki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prathamesh-sonpatki/subscriptions","organizations_url":"https://api.github.com/users/prathamesh-sonpatki/orgs","repos_url":"https://api.github.com/users/prathamesh-sonpatki/repos","events_url":"https://api.github.com/users/prathamesh-sonpatki/events{/privacy}","received_events_url":"https://api.github.com/users/prathamesh-sonpatki/received_events","type":"User","site_admin":false},"repo":{"id":5762217,"name":"rails","full_name":"prathamesh-sonpatki/rails","owner":{"login":"prathamesh-sonpatki","id":621238,"avatar_url":"https://avatars.githubusercontent.com/u/621238?v=3","gravatar_id":"","url":"https://api.github.com/users/prathamesh-sonpatki","html_url":"https://github.com/prathamesh-sonpatki","followers_url":"https://api.github.com/users/prathamesh-sonpatki/followers","following_url":"https://api.github.com/users/prathamesh-sonpatki/following{/other_user}","gists_url":"https://api.github.com/users/prathamesh-sonpatki/gists{/gist_id}","starred_url":"https://api.github.com/users/prathamesh-sonpatki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prathamesh-sonpatki/subscriptions","organizations_url":"https://api.github.com/users/prathamesh-sonpatki/orgs","repos_url":"https://api.github.com/users/prathamesh-sonpatki/repos","events_url":"https://api.github.com/users/prathamesh-sonpatki/events{/privacy}","received_events_url":"https://api.github.com/users/prathamesh-sonpatki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prathamesh-sonpatki/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/prathamesh-sonpatki/rails","forks_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/forks","keys_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/teams","hooks_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/hooks","issue_events_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/issues/events{/number}","events_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/events","assignees_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/assignees{/user}","branches_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/branches{/branch}","tags_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/tags","blobs_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/languages","stargazers_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/stargazers","contributors_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/contributors","subscribers_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/subscribers","subscription_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/subscription","commits_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/contents/{+path}","compare_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/merges","archive_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/downloads","issues_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/issues{/number}","pulls_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/labels{/name}","releases_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/releases{/id}","deployments_url":"https://api.github.com/repos/prathamesh-sonpatki/rails/deployments","created_at":"2012-09-11T08:43:31Z","updated_at":"2016-10-23T15:35:56Z","pushed_at":"2016-10-30T14:39:09Z","git_url":"git://github.com/prathamesh-sonpatki/rails.git","ssh_url":"git@github.com:prathamesh-sonpatki/rails.git","clone_url":"https://github.com/prathamesh-sonpatki/rails.git","svn_url":"https://github.com/prathamesh-sonpatki/rails","homepage":"http://rubyonrails.org","size":130190,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"1f63d09ad78b6dada597e97359dce507c1169081","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-11-13T14:34:55Z","pushed_at":"2016-11-13T14:46:21Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":350002,"stargazers_count":33361,"watchers_count":33361,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13614,"mirror_url":null,"open_issues_count":1225,"forks":13614,"open_issues":1225,"watchers":33361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/26933"},"html":{"href":"https://github.com/rails/rails/pull/26933"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/26933"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/26933/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/26933/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/26933/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/8776f15b448ed88b1108e70f2de22f0b599818aa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pixeltrix","id":6321,"avatar_url":"https://avatars.githubusercontent.com/u/6321?v=3","gravatar_id":"","url":"https://api.github.com/users/pixeltrix","html_url":"https://github.com/pixeltrix","followers_url":"https://api.github.com/users/pixeltrix/followers","following_url":"https://api.github.com/users/pixeltrix/following{/other_user}","gists_url":"https://api.github.com/users/pixeltrix/gists{/gist_id}","starred_url":"https://api.github.com/users/pixeltrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixeltrix/subscriptions","organizations_url":"https://api.github.com/users/pixeltrix/orgs","repos_url":"https://api.github.com/users/pixeltrix/repos","events_url":"https://api.github.com/users/pixeltrix/events{/privacy}","received_events_url":"https://api.github.com/users/pixeltrix/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"commits":1,"additions":23,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"pixeltrix"}}