{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular.js/issues/14309","repository_url":"https://api.github.com/repos/angular/angular.js","labels_url":"https://api.github.com/repos/angular/angular.js/issues/14309/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/14309/comments","events_url":"https://api.github.com/repos/angular/angular.js/issues/14309/events","html_url":"https://github.com/angular/angular.js/pull/14309","id":143030890,"number":14309,"title":"refactor(ngResource): Use core encode methods in ngResource","user":{"login":"nicholasserra","id":512288,"avatar_url":"https://avatars.githubusercontent.com/u/512288?v=3","gravatar_id":"","url":"https://api.github.com/users/nicholasserra","html_url":"https://github.com/nicholasserra","followers_url":"https://api.github.com/users/nicholasserra/followers","following_url":"https://api.github.com/users/nicholasserra/following{/other_user}","gists_url":"https://api.github.com/users/nicholasserra/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholasserra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholasserra/subscriptions","organizations_url":"https://api.github.com/users/nicholasserra/orgs","repos_url":"https://api.github.com/users/nicholasserra/repos","events_url":"https://api.github.com/users/nicholasserra/events{/privacy}","received_events_url":"https://api.github.com/users/nicholasserra/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular.js/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20misc%20core","name":"component: misc core","color":"fef2c0"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20ngResource","name":"component: ngResource","color":"0b02e1"},{"url":"https://api.github.com/repos/angular/angular.js/labels/needs:%20investigation","name":"needs: investigation","color":"444444"},{"url":"https://api.github.com/repos/angular/angular.js/labels/needs:%20public%20api","name":"needs: public api","color":"eb6420"},{"url":"https://api.github.com/repos/angular/angular.js/labels/type:%20refactor","name":"type: refactor","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/35","html_url":"https://github.com/angular/angular.js/milestones/Purgatory","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/35/labels","id":526241,"number":35,"title":"Purgatory","description":"This milestone is for issues and PRs that weren't accepted yet and we are waiting for more info from the submitter.\r\n\r\nFor issues this typically means that we weren't able to reproduce the issue or we haven't decided yet if a feature request is a good idea at all.\r\n\r\nFor PRs this means that the PR still needs a lot of work and we might not even be interested in merging it because it looks like a non-core feature. We are still waiting for more discussion within the team or more info from the contributor before making the final decision.","creator":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"open_issues":116,"closed_issues":677,"state":"open","created_at":"2014-01-04T01:20:50Z","updated_at":"2016-04-07T19:30:11Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2016-03-23T17:41:35Z","updated_at":"2016-04-07T20:23:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/14309","html_url":"https://github.com/angular/angular.js/pull/14309","diff_url":"https://github.com/angular/angular.js/pull/14309.diff","patch_url":"https://github.com/angular/angular.js/pull/14309.patch"},"body":"**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**\r\nRefactor\r\n\r\n**What is the current behavior? (You can also link to an open issue here)**\r\nCore package and ngResource both define methods for encodeUriQuery and encodeUriSegment.\r\nngResource's methods are out of date, as changes were made to core encodeUriQuery over a year ago.\r\n\r\n\r\n**What is the new behavior (if this is a feature change)?**\r\nRefactor the usage of these methods in ngResource by removing the duplicate methods, and using the core methods instead.\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo\r\n\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular.js/issues/comments/207074573","html_url":"https://github.com/angular/angular.js/pull/14309#issuecomment-207074573","issue_url":"https://api.github.com/repos/angular/angular.js/issues/14309","id":207074573,"user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T20:23:21Z","updated_at":"2016-04-07T20:23:21Z","body":"@lgalfaso, with _\"current approach\"_ did you mean the one currently in effect or the one proposed in the PR ? (I assume the former, right ?)"}}