{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/75107057","id":75107057,"diff_hunk":"@@ -70,9 +70,9 @@ public CompletionTime processOneToOne(String tenantId, Span item) throws RetryAt\n                 ct.setEndpointType(\"Unknown\");\n             }\n \n-            ct.setDuration(TimeUnit.MILLISECONDS.convert(item.getDuration(), TimeUnit.NANOSECONDS));\n+            ct.setDuration(TimeUnit.MILLISECONDS.convert(item.getDuration(), TimeUnit.MICROSECONDS));","path":"processors/zipkin/src/main/java/org/hawkular/apm/processor/zipkin/TraceCompletionTimeDeriver.java","position":5,"original_position":5,"commit_id":"9eb8e1e10d943abab99e8a5548023f58cb912426","original_commit_id":"9eb8e1e10d943abab99e8a5548023f58cb912426","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"We should consider changing duration unit micro or nano. What if a trace completes in micro/nano seconds?","created_at":"2016-08-17T11:46:54Z","updated_at":"2016-08-17T11:46:54Z","html_url":"https://github.com/hawkular/hawkular-apm/pull/525#discussion_r75107057","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/75107057"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/525#discussion_r75107057"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525","id":81625551,"html_url":"https://github.com/hawkular/hawkular-apm/pull/525","diff_url":"https://github.com/hawkular/hawkular-apm/pull/525.diff","patch_url":"https://github.com/hawkular/hawkular-apm/pull/525.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/525","number":525,"state":"open","locked":false,"title":"HWKAPM-578 Fix the duration conversion issues between spans and deriv…","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"…ed events","created_at":"2016-08-17T11:23:18Z","updated_at":"2016-08-17T11:46:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"999e75323d7018b626ce368d70e321cd30dfbf72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/525/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/9eb8e1e10d943abab99e8a5548023f58cb912426","head":{"label":"objectiser:HWKAPM-578","ref":"HWKAPM-578","sha":"9eb8e1e10d943abab99e8a5548023f58cb912426","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"repo":{"id":34446762,"name":"hawkular-apm","full_name":"objectiser/hawkular-apm","owner":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objectiser/hawkular-apm","description":"Application Performance Management for Hawkular","fork":true,"url":"https://api.github.com/repos/objectiser/hawkular-apm","forks_url":"https://api.github.com/repos/objectiser/hawkular-apm/forks","keys_url":"https://api.github.com/repos/objectiser/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objectiser/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objectiser/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/objectiser/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/objectiser/hawkular-apm/events","assignees_url":"https://api.github.com/repos/objectiser/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/objectiser/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objectiser/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/objectiser/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/objectiser/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/objectiser/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/objectiser/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/objectiser/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/objectiser/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objectiser/hawkular-apm/merges","archive_url":"https://api.github.com/repos/objectiser/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objectiser/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/objectiser/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/objectiser/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/objectiser/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objectiser/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/objectiser/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/objectiser/hawkular-apm/deployments","created_at":"2015-04-23T09:26:55Z","updated_at":"2016-06-03T10:47:39Z","pushed_at":"2016-08-17T11:22:24Z","git_url":"git://github.com/objectiser/hawkular-apm.git","ssh_url":"git@github.com:objectiser/hawkular-apm.git","clone_url":"https://github.com/objectiser/hawkular-apm.git","svn_url":"https://github.com/objectiser/hawkular-apm","homepage":"","size":5743,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"c09436a913c3475b0c1d82bf217b0cbecc8794ca","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":34446334,"name":"hawkular-apm","full_name":"hawkular/hawkular-apm","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-apm","description":"Application Performance Management for Hawkular","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-apm","forks_url":"https://api.github.com/repos/hawkular/hawkular-apm/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-apm/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-apm/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-apm/deployments","created_at":"2015-04-23T09:17:50Z","updated_at":"2016-08-01T00:58:50Z","pushed_at":"2016-08-17T11:41:15Z","git_url":"git://github.com/hawkular/hawkular-apm.git","ssh_url":"git@github.com:hawkular/hawkular-apm.git","clone_url":"https://github.com/hawkular/hawkular-apm.git","svn_url":"https://github.com/hawkular/hawkular-apm","homepage":"","size":5833,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/525"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/525"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/9eb8e1e10d943abab99e8a5548023f58cb912426"}}}}
{"actor":{"display_login":"pavolloffay"}}