{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2599","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2599/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2599/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2599/events","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2599","id":156075722,"number":2599,"title":"Use shaders from mapbox-gl-shaders","user":{"login":"jfirebaugh","id":98601,"avatar_url":"https://avatars.githubusercontent.com/u/98601?v=3","gravatar_id":"","url":"https://api.github.com/users/jfirebaugh","html_url":"https://github.com/jfirebaugh","followers_url":"https://api.github.com/users/jfirebaugh/followers","following_url":"https://api.github.com/users/jfirebaugh/following{/other_user}","gists_url":"https://api.github.com/users/jfirebaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/jfirebaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfirebaugh/subscriptions","organizations_url":"https://api.github.com/users/jfirebaugh/orgs","repos_url":"https://api.github.com/users/jfirebaugh/repos","events_url":"https://api.github.com/users/jfirebaugh/events{/privacy}","received_events_url":"https://api.github.com/users/jfirebaugh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-21T01:05:28Z","updated_at":"2016-05-23T15:12:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/2599","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2599","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/2599.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/2599.patch"},"body":"Our shaders were getting out of sync in ways that made it more and more difficult to port changes from gl-js to gl-native and vice versa. By moving them to a shared repository, and pinning a precise revision in each project's package.json, we can ensure that shader evolution follows a single path.\r\n\r\nThis doesn't necessarily mean that gl-js and gl-native have to use the same exact version at all times. The two can be pinned to different mapbox-gl-shaders git SHAs, and we can create branches in mapbox-gl-shaders as needed for experimentation. It _does_ mean that if you want to integrate shader changes to one project, you have to also accept any other changes that came before. This is a good thing: it enforces non-divergence over the long term.\r\n\r\nCurrently, mapbox-gl-shaders contains the shader code that was in mapbox-gl-js as of today. I will be following up with PRs that bring mapbox-gl-shaders in sync with and compatible with mapbox-gl-native.\r\n\r\ncc @mapbox/gl "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/221006733","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2599#issuecomment-221006733","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2599","id":221006733,"user":{"login":"bleege","id":989928,"avatar_url":"https://avatars.githubusercontent.com/u/989928?v=3","gravatar_id":"","url":"https://api.github.com/users/bleege","html_url":"https://github.com/bleege","followers_url":"https://api.github.com/users/bleege/followers","following_url":"https://api.github.com/users/bleege/following{/other_user}","gists_url":"https://api.github.com/users/bleege/gists{/gist_id}","starred_url":"https://api.github.com/users/bleege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleege/subscriptions","organizations_url":"https://api.github.com/users/bleege/orgs","repos_url":"https://api.github.com/users/bleege/repos","events_url":"https://api.github.com/users/bleege/events{/privacy}","received_events_url":"https://api.github.com/users/bleege/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T15:12:09Z","updated_at":"2016-05-23T15:12:09Z","body":"> it'll be a while before Native can support DDS-related constructs\r\n\r\nIs this due to natural GL JS / GL Native code bases being out of sync right now or is this something that's different between WebGL and OpenGL?"}}
{"actor":{"display_login":"bleege"}}