{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/comments/52349304","id":52349304,"diff_hunk":"@@ -599,19 +693,34 @@ extern \"C\" void EmitDebugFunctionInfo(ObjectWriter *OW,\n     // This is the important bit that tells the debugger where the function\n     // code is located and what's its size:\n     OST.EmitIntValue(FunctionSize, 4);\n-    OST.EmitFill(12, 0);\n+    OST.EmitFill(4, 0);                // SS_DBGSTART","path":"lib/ObjWriter/objwriter.cpp","position":167,"original_position":167,"commit_id":"8475bf2592604da6be5c8b4432216060c04e6b30","original_commit_id":"8475bf2592604da6be5c8b4432216060c04e6b30","user":{"login":"kyulee1","id":10963908,"avatar_url":"https://avatars.githubusercontent.com/u/10963908?v=3","gravatar_id":"","url":"https://api.github.com/users/kyulee1","html_url":"https://github.com/kyulee1","followers_url":"https://api.github.com/users/kyulee1/followers","following_url":"https://api.github.com/users/kyulee1/following{/other_user}","gists_url":"https://api.github.com/users/kyulee1/gists{/gist_id}","starred_url":"https://api.github.com/users/kyulee1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyulee1/subscriptions","organizations_url":"https://api.github.com/users/kyulee1/orgs","repos_url":"https://api.github.com/users/kyulee1/repos","events_url":"https://api.github.com/users/kyulee1/events{/privacy}","received_events_url":"https://api.github.com/users/kyulee1/received_events","type":"User","site_admin":false},"body":"Well. You are now in here. Can you use \"ProcSym\" to emit function symbol instead of emitting individual bytes like this? Then we don't need to add bunch of comments like this.","created_at":"2016-02-09T18:16:59Z","updated_at":"2016-02-09T18:16:59Z","html_url":"https://github.com/dotnet/llilc/pull/1021#discussion_r52349304","pull_request_url":"https://api.github.com/repos/dotnet/llilc/pulls/1021","_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments/52349304"},"html":{"href":"https://github.com/dotnet/llilc/pull/1021#discussion_r52349304"},"pull_request":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/1021"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/1021","id":58080337,"html_url":"https://github.com/dotnet/llilc/pull/1021","diff_url":"https://github.com/dotnet/llilc/pull/1021.diff","patch_url":"https://github.com/dotnet/llilc/pull/1021.patch","issue_url":"https://api.github.com/repos/dotnet/llilc/issues/1021","number":1021,"state":"open","locked":false,"title":"Emit PDB local var debug information in object writer","user":{"login":"hoyMS","id":15899383,"avatar_url":"https://avatars.githubusercontent.com/u/15899383?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyMS","html_url":"https://github.com/hoyMS","followers_url":"https://api.github.com/users/hoyMS/followers","following_url":"https://api.github.com/users/hoyMS/following{/other_user}","gists_url":"https://api.github.com/users/hoyMS/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyMS/subscriptions","organizations_url":"https://api.github.com/users/hoyMS/orgs","repos_url":"https://api.github.com/users/hoyMS/repos","events_url":"https://api.github.com/users/hoyMS/events{/privacy}","received_events_url":"https://api.github.com/users/hoyMS/received_events","type":"User","site_admin":false},"body":"This change enables displaying local var and parameter values during debugging coreRT apps on Windows.\r\n\r\nThe build script is also changed to allow the use of two Code View header files from Micorsoft pdb repo https://github.com/Microsoft/microsoft-pdb.git. To build LLILC without ObjectWriter, use the original command line :\r\n\r\ncmake -G \"Visual Studio 14 2015 Win64\" %llilcSrc% -DWITH_CORECLR=%coreclrBuild% -DWITH_LLVM=%llvmBuild% -DLLVM_OPTIMIZED_TABLEGEN=ON\r\n\r\nTo build LLILC with ObjectWriter which in turn checks out the MS pdb git repo, use\r\ncmake -G \"Visual Studio 14 2015 Win64\" %llilcSrc% -DWITH_CORECLR=%coreclrBuild% -DWITH_LLVM=%llvmBuild% -DLLVM_OPTIMIZED_TABLEGEN=ON -DOBJWRITER=1\r\n\r\n\r\n","created_at":"2016-02-03T01:52:22Z","updated_at":"2016-02-09T18:16:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c75856342d22a1108b5fa13a743cba4581287226","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/llilc/pulls/1021/commits","review_comments_url":"https://api.github.com/repos/dotnet/llilc/pulls/1021/comments","review_comment_url":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/llilc/issues/1021/comments","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/8475bf2592604da6be5c8b4432216060c04e6b30","head":{"label":"hoyMS:pdb","ref":"pdb","sha":"8475bf2592604da6be5c8b4432216060c04e6b30","user":{"login":"hoyMS","id":15899383,"avatar_url":"https://avatars.githubusercontent.com/u/15899383?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyMS","html_url":"https://github.com/hoyMS","followers_url":"https://api.github.com/users/hoyMS/followers","following_url":"https://api.github.com/users/hoyMS/following{/other_user}","gists_url":"https://api.github.com/users/hoyMS/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyMS/subscriptions","organizations_url":"https://api.github.com/users/hoyMS/orgs","repos_url":"https://api.github.com/users/hoyMS/repos","events_url":"https://api.github.com/users/hoyMS/events{/privacy}","received_events_url":"https://api.github.com/users/hoyMS/received_events","type":"User","site_admin":false},"repo":{"id":50469968,"name":"llilc","full_name":"hoyMS/llilc","owner":{"login":"hoyMS","id":15899383,"avatar_url":"https://avatars.githubusercontent.com/u/15899383?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyMS","html_url":"https://github.com/hoyMS","followers_url":"https://api.github.com/users/hoyMS/followers","following_url":"https://api.github.com/users/hoyMS/following{/other_user}","gists_url":"https://api.github.com/users/hoyMS/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyMS/subscriptions","organizations_url":"https://api.github.com/users/hoyMS/orgs","repos_url":"https://api.github.com/users/hoyMS/repos","events_url":"https://api.github.com/users/hoyMS/events{/privacy}","received_events_url":"https://api.github.com/users/hoyMS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoyMS/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":true,"url":"https://api.github.com/repos/hoyMS/llilc","forks_url":"https://api.github.com/repos/hoyMS/llilc/forks","keys_url":"https://api.github.com/repos/hoyMS/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoyMS/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoyMS/llilc/teams","hooks_url":"https://api.github.com/repos/hoyMS/llilc/hooks","issue_events_url":"https://api.github.com/repos/hoyMS/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/hoyMS/llilc/events","assignees_url":"https://api.github.com/repos/hoyMS/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/hoyMS/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/hoyMS/llilc/tags","blobs_url":"https://api.github.com/repos/hoyMS/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoyMS/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoyMS/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoyMS/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoyMS/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/hoyMS/llilc/languages","stargazers_url":"https://api.github.com/repos/hoyMS/llilc/stargazers","contributors_url":"https://api.github.com/repos/hoyMS/llilc/contributors","subscribers_url":"https://api.github.com/repos/hoyMS/llilc/subscribers","subscription_url":"https://api.github.com/repos/hoyMS/llilc/subscription","commits_url":"https://api.github.com/repos/hoyMS/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoyMS/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoyMS/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoyMS/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoyMS/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/hoyMS/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoyMS/llilc/merges","archive_url":"https://api.github.com/repos/hoyMS/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoyMS/llilc/downloads","issues_url":"https://api.github.com/repos/hoyMS/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/hoyMS/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/hoyMS/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/hoyMS/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoyMS/llilc/labels{/name}","releases_url":"https://api.github.com/repos/hoyMS/llilc/releases{/id}","deployments_url":"https://api.github.com/repos/hoyMS/llilc/deployments","created_at":"2016-01-27T00:41:05Z","updated_at":"2016-01-27T00:41:07Z","pushed_at":"2016-02-09T17:01:43Z","git_url":"git://github.com/hoyMS/llilc.git","ssh_url":"git@github.com:hoyMS/llilc.git","clone_url":"https://github.com/hoyMS/llilc.git","svn_url":"https://github.com/hoyMS/llilc","homepage":"","size":8226,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e3091506b157822c65149bbb2e9f0905a64d5676","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30043131,"name":"llilc","full_name":"dotnet/llilc","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":false,"url":"https://api.github.com/repos/dotnet/llilc","forks_url":"https://api.github.com/repos/dotnet/llilc/forks","keys_url":"https://api.github.com/repos/dotnet/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/llilc/teams","hooks_url":"https://api.github.com/repos/dotnet/llilc/hooks","issue_events_url":"https://api.github.com/repos/dotnet/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/llilc/events","assignees_url":"https://api.github.com/repos/dotnet/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/llilc/tags","blobs_url":"https://api.github.com/repos/dotnet/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/llilc/languages","stargazers_url":"https://api.github.com/repos/dotnet/llilc/stargazers","contributors_url":"https://api.github.com/repos/dotnet/llilc/contributors","subscribers_url":"https://api.github.com/repos/dotnet/llilc/subscribers","subscription_url":"https://api.github.com/repos/dotnet/llilc/subscription","commits_url":"https://api.github.com/repos/dotnet/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/llilc/merges","archive_url":"https://api.github.com/repos/dotnet/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/llilc/downloads","issues_url":"https://api.github.com/repos/dotnet/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/llilc/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/llilc/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/llilc/deployments","created_at":"2015-01-29T21:52:01Z","updated_at":"2016-02-07T21:45:23Z","pushed_at":"2016-02-09T17:36:57Z","git_url":"git://github.com/dotnet/llilc.git","ssh_url":"git@github.com:dotnet/llilc.git","clone_url":"https://github.com/dotnet/llilc.git","svn_url":"https://github.com/dotnet/llilc","homepage":"","size":9679,"stargazers_count":977,"watchers_count":977,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":149,"forks":94,"open_issues":149,"watchers":977,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/1021"},"html":{"href":"https://github.com/dotnet/llilc/pull/1021"},"issue":{"href":"https://api.github.com/repos/dotnet/llilc/issues/1021"},"comments":{"href":"https://api.github.com/repos/dotnet/llilc/issues/1021/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/1021/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/1021/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/llilc/statuses/8475bf2592604da6be5c8b4432216060c04e6b30"}}}}