{"action":"created","issue":{"url":"https://api.github.com/repos/atom/language-java/issues/58","repository_url":"https://api.github.com/repos/atom/language-java","labels_url":"https://api.github.com/repos/atom/language-java/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/atom/language-java/issues/58/comments","events_url":"https://api.github.com/repos/atom/language-java/issues/58/events","html_url":"https://github.com/atom/language-java/pull/58","id":159938964,"number":58,"title":"Variables structure take two","user":{"login":"noseglid","id":933880,"avatar_url":"https://avatars.githubusercontent.com/u/933880?v=3","gravatar_id":"","url":"https://api.github.com/users/noseglid","html_url":"https://github.com/noseglid","followers_url":"https://api.github.com/users/noseglid/followers","following_url":"https://api.github.com/users/noseglid/following{/other_user}","gists_url":"https://api.github.com/users/noseglid/gists{/gist_id}","starred_url":"https://api.github.com/users/noseglid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noseglid/subscriptions","organizations_url":"https://api.github.com/users/noseglid/orgs","repos_url":"https://api.github.com/users/noseglid/repos","events_url":"https://api.github.com/users/noseglid/events{/privacy}","received_events_url":"https://api.github.com/users/noseglid/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-13T12:29:47Z","updated_at":"2016-06-13T22:44:08Z","closed_at":"2016-06-13T22:41:25Z","pull_request":{"url":"https://api.github.com/repos/atom/language-java/pulls/58","html_url":"https://github.com/atom/language-java/pull/58","diff_url":"https://github.com/atom/language-java/pull/58.diff","patch_url":"https://github.com/atom/language-java/pull/58.patch"},"body":"Main problem is the identification of variables.\r\nIt was too lenient in the first take because it didn't require the a space to exist (e.g. between `int` and `name` in `int name;`).\r\n\r\nI am not super happy with the current solution (repeating the \"generics, dots, commas blalba\" regex and check for a space in between), but I'm at a loss for better alternatives. The way it was before didn't work with generics (see comment in #47). At least this works in all cases.\r\n\r\nThe issue in #47 is different with this PR. E.g. example (row 13) below gets\r\n  * `meta.definition.variable.java storage.type.java` on `Rectangle2D` (correct) \r\n  * `meta.definition.variable.java punctuation.separator.period.java` on `.` (correct)\r\n  * `meta.definition.variable.java variable.other.property.java` on `Double` (while correct, I'd like to se `storage.type.java` here too)\r\n  * `meta.definition.variable.java variable.other.definition.java` on `d` (correct)\r\n\r\nSo much better, just a minor wrinkle to iron out.\r\n\r\nExample:\r\n![screen shot 2016-06-13 at 2 23 17 pm](https://cloud.githubusercontent.com/assets/933880/16007388/66230ab8-3172-11e6-9851-634d1aeac77e.png)\r\n"},"comment":{"url":"https://api.github.com/repos/atom/language-java/issues/comments/225730789","html_url":"https://github.com/atom/language-java/pull/58#issuecomment-225730789","issue_url":"https://api.github.com/repos/atom/language-java/issues/58","id":225730789,"user":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=3","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T22:44:08Z","updated_at":"2016-06-13T22:44:08Z","body":"And of course the moment I hit the merge button I see something:\r\n```java\r\nsomething.add(0, new Integer(((variable >= 0) ? 1 : -1)));\r\n```\r\nAnything inside `Integer()` isn't highlighted."}}
{"actor":{"display_login":"50Wliu"}}