{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments/83876314","pull_request_review_id":4682198,"id":83876314,"diff_hunk":"@@ -0,0 +1,68 @@\n+/*\n+ * Copyright 2016 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.google.cloud.bigtable.grpc;\n+\n+import com.google.bigtable.v2.Cell;\n+import com.google.bigtable.v2.Column;\n+import com.google.bigtable.v2.Family;\n+import com.google.bigtable.v2.Row;\n+import com.google.protobuf.ByteString;\n+\n+import java.util.ArrayDeque;\n+\n+public class SimpleRow {\n+  public class SimpleColumn {\n+    public byte[] family;\n+    public ByteString qualifier;\n+    public Column.Builder builder;\n+  }\n+  private final ArrayDeque<SimpleColumn> columns;\n+\t\n+  public SimpleRow() {\n+    columns = new ArrayDeque<SimpleColumn>();\n+  }\n+\t\n+  public void addCell(String family, ByteString qualifier, Cell cell) {\n+    SimpleColumn column = new SimpleColumn();\n+    column.family = family.getBytes();","path":"bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/SimpleRow.java","position":40,"original_position":40,"commit_id":"d01bde9bd01b16fd7c32232ebecc2675ca599e0f","original_commit_id":"d01bde9bd01b16fd7c32232ebecc2675ca599e0f","user":{"login":"garye","id":37807,"avatar_url":"https://avatars.githubusercontent.com/u/37807?v=3","gravatar_id":"","url":"https://api.github.com/users/garye","html_url":"https://github.com/garye","followers_url":"https://api.github.com/users/garye/followers","following_url":"https://api.github.com/users/garye/following{/other_user}","gists_url":"https://api.github.com/users/garye/gists{/gist_id}","starred_url":"https://api.github.com/users/garye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garye/subscriptions","organizations_url":"https://api.github.com/users/garye/orgs","repos_url":"https://api.github.com/users/garye/repos","events_url":"https://api.github.com/users/garye/events{/privacy}","received_events_url":"https://api.github.com/users/garye/received_events","type":"User","site_admin":false},"body":"I don't think you need to turn this into bytes and then back into a String. Can it be left a String and compared against previous families using .equals() instead of the byte array comparison?","created_at":"2016-10-18T15:07:31Z","updated_at":"2016-10-18T15:10:20Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1045#discussion_r83876314","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments/83876314"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1045#discussion_r83876314"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045","id":89497512,"html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1045","diff_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1045.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1045.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1045","number":1045,"state":"open","locked":false,"title":"Adding a new SimpleRow class","user":{"login":"tyagihas","id":1037740,"avatar_url":"https://avatars.githubusercontent.com/u/1037740?v=3","gravatar_id":"","url":"https://api.github.com/users/tyagihas","html_url":"https://github.com/tyagihas","followers_url":"https://api.github.com/users/tyagihas/followers","following_url":"https://api.github.com/users/tyagihas/following{/other_user}","gists_url":"https://api.github.com/users/tyagihas/gists{/gist_id}","starred_url":"https://api.github.com/users/tyagihas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyagihas/subscriptions","organizations_url":"https://api.github.com/users/tyagihas/orgs","repos_url":"https://api.github.com/users/tyagihas/repos","events_url":"https://api.github.com/users/tyagihas/events{/privacy}","received_events_url":"https://api.github.com/users/tyagihas/received_events","type":"User","site_admin":false},"body":"Adding new data structure, SimpleRow, for the issue [https://github.com/GoogleCloudPlatform/cloud-bigtable-client/issues/1027](url)","created_at":"2016-10-15T16:03:00Z","updated_at":"2016-10-18T15:10:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63d896db8fe561b45687ffa1b612155ce202aafe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1045/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/statuses/d01bde9bd01b16fd7c32232ebecc2675ca599e0f","head":{"label":"tyagihas:master","ref":"master","sha":"d01bde9bd01b16fd7c32232ebecc2675ca599e0f","user":{"login":"tyagihas","id":1037740,"avatar_url":"https://avatars.githubusercontent.com/u/1037740?v=3","gravatar_id":"","url":"https://api.github.com/users/tyagihas","html_url":"https://github.com/tyagihas","followers_url":"https://api.github.com/users/tyagihas/followers","following_url":"https://api.github.com/users/tyagihas/following{/other_user}","gists_url":"https://api.github.com/users/tyagihas/gists{/gist_id}","starred_url":"https://api.github.com/users/tyagihas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyagihas/subscriptions","organizations_url":"https://api.github.com/users/tyagihas/orgs","repos_url":"https://api.github.com/users/tyagihas/repos","events_url":"https://api.github.com/users/tyagihas/events{/privacy}","received_events_url":"https://api.github.com/users/tyagihas/received_events","type":"User","site_admin":false},"repo":{"id":70995514,"name":"cloud-bigtable-client","full_name":"tyagihas/cloud-bigtable-client","owner":{"login":"tyagihas","id":1037740,"avatar_url":"https://avatars.githubusercontent.com/u/1037740?v=3","gravatar_id":"","url":"https://api.github.com/users/tyagihas","html_url":"https://github.com/tyagihas","followers_url":"https://api.github.com/users/tyagihas/followers","following_url":"https://api.github.com/users/tyagihas/following{/other_user}","gists_url":"https://api.github.com/users/tyagihas/gists{/gist_id}","starred_url":"https://api.github.com/users/tyagihas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyagihas/subscriptions","organizations_url":"https://api.github.com/users/tyagihas/orgs","repos_url":"https://api.github.com/users/tyagihas/repos","events_url":"https://api.github.com/users/tyagihas/events{/privacy}","received_events_url":"https://api.github.com/users/tyagihas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tyagihas/cloud-bigtable-client","description":"Java libraries and HBase client extensions for accessing Google Cloud Bigtable","fork":true,"url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client","forks_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/forks","keys_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/teams","hooks_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/hooks","issue_events_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/issues/events{/number}","events_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/events","assignees_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/assignees{/user}","branches_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/branches{/branch}","tags_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/tags","blobs_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/statuses/{sha}","languages_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/languages","stargazers_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/stargazers","contributors_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/contributors","subscribers_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/subscribers","subscription_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/subscription","commits_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/contents/{+path}","compare_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/merges","archive_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/downloads","issues_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/issues{/number}","pulls_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/pulls{/number}","milestones_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/milestones{/number}","notifications_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/labels{/name}","releases_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/releases{/id}","deployments_url":"https://api.github.com/repos/tyagihas/cloud-bigtable-client/deployments","created_at":"2016-10-15T15:18:05Z","updated_at":"2016-10-15T15:18:08Z","pushed_at":"2016-10-15T15:53:06Z","git_url":"git://github.com/tyagihas/cloud-bigtable-client.git","ssh_url":"git@github.com:tyagihas/cloud-bigtable-client.git","clone_url":"https://github.com/tyagihas/cloud-bigtable-client.git","svn_url":"https://github.com/tyagihas/cloud-bigtable-client","homepage":"https://cloud.google.com/bigtable/","size":7658,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"70761192d8022413007686b2d69433b03069cdba","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":18442381,"name":"cloud-bigtable-client","full_name":"GoogleCloudPlatform/cloud-bigtable-client","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client","description":"Java libraries and HBase client extensions for accessing Google Cloud Bigtable","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/deployments","created_at":"2014-04-04T14:54:35Z","updated_at":"2016-10-17T13:48:04Z","pushed_at":"2016-10-15T16:03:01Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-bigtable-client.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-bigtable-client.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client","homepage":"https://cloud.google.com/bigtable/","size":15018,"stargazers_count":62,"watchers_count":62,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":21,"forks":51,"open_issues":21,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1045"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1045"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1045/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/1045/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/statuses/d01bde9bd01b16fd7c32232ebecc2675ca599e0f"}}}}
{"actor":{"display_login":"garye"}}