{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/9149","labels_url":"https://api.github.com/repos/servo/servo/issues/9149/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/9149/comments","events_url":"https://api.github.com/repos/servo/servo/issues/9149/events","html_url":"https://github.com/servo/servo/pull/9149","id":124752712,"number":9149,"title":"Correctly handle local sources for CSS3 fonts","user":{"login":"adrianheine","id":139208,"avatar_url":"https://avatars.githubusercontent.com/u/139208?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianheine","html_url":"https://github.com/adrianheine","followers_url":"https://api.github.com/users/adrianheine/followers","following_url":"https://api.github.com/users/adrianheine/following{/other_user}","gists_url":"https://api.github.com/users/adrianheine/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianheine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianheine/subscriptions","organizations_url":"https://api.github.com/users/adrianheine/orgs","repos_url":"https://api.github.com/users/adrianheine/repos","events_url":"https://api.github.com/users/adrianheine/events{/privacy}","received_events_url":"https://api.github.com/users/adrianheine/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-tests-failed","name":"S-tests-failed","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"glennw","id":2350882,"avatar_url":"https://avatars.githubusercontent.com/u/2350882?v=3","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-01-04T12:36:28Z","updated_at":"2016-01-08T01:08:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/9149","html_url":"https://github.com/servo/servo/pull/9149","diff_url":"https://github.com/servo/servo/pull/9149.diff","patch_url":"https://github.com/servo/servo/pull/9149.patch"},"body":"Currently, servo panics for me when loading something like this:\r\n\r\n```\r\n@font-face {\r\n  font-family: \"test family\";\r\n  src: local(test font face);\r\n}\r\n```\r\n\r\nThat's due to a bug in `FontCacheTask`. `FontCacheTask` tries to get the value for the key\r\n\"test font face\" from `self.web_families`, but previously initialized a value for the key \"test family\".\r\n\r\nThese two commits add an awkward test and fix the bug by not shadowing the variable `family_name`. Since the argument to `local()` should explicitly not be the name of a font family, the previous variable name was wrong and misleading anyways.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/9149)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/169856624","html_url":"https://github.com/servo/servo/pull/9149#issuecomment-169856624","issue_url":"https://api.github.com/repos/servo/servo/issues/9149","id":169856624,"user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T01:08:46Z","updated_at":"2016-01-08T01:08:46Z","body":"@bors-servo retry\r\n* #9124, #9148, #8769"}}