{"action":"created","issue":{"url":"https://api.github.com/repos/twbs/bootlint/issues/294","labels_url":"https://api.github.com/repos/twbs/bootlint/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/twbs/bootlint/issues/294/comments","events_url":"https://api.github.com/repos/twbs/bootlint/issues/294/events","html_url":"https://github.com/twbs/bootlint/pull/294","id":92680678,"number":294,"title":"Warn about button.disabled","user":{"login":"zacechola","id":498418,"avatar_url":"https://avatars.githubusercontent.com/u/498418?v=3","gravatar_id":"","url":"https://api.github.com/users/zacechola","html_url":"https://github.com/zacechola","followers_url":"https://api.github.com/users/zacechola/followers","following_url":"https://api.github.com/users/zacechola/following{/other_user}","gists_url":"https://api.github.com/users/zacechola/gists{/gist_id}","starred_url":"https://api.github.com/users/zacechola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zacechola/subscriptions","organizations_url":"https://api.github.com/users/zacechola/orgs","repos_url":"https://api.github.com/users/zacechola/repos","events_url":"https://api.github.com/users/zacechola/events{/privacy}","received_events_url":"https://api.github.com/users/zacechola/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/twbs/bootlint/labels/enhancement","name":"enhancement","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/twbs/bootlint/milestones/15","html_url":"https://github.com/twbs/bootlint/milestones/v0.14.0","labels_url":"https://api.github.com/repos/twbs/bootlint/milestones/15/labels","id":1057400,"number":15,"title":"v0.14.0","description":"","creator":{"login":"cvrebert","id":419884,"avatar_url":"https://avatars.githubusercontent.com/u/419884?v=3","gravatar_id":"","url":"https://api.github.com/users/cvrebert","html_url":"https://github.com/cvrebert","followers_url":"https://api.github.com/users/cvrebert/followers","following_url":"https://api.github.com/users/cvrebert/following{/other_user}","gists_url":"https://api.github.com/users/cvrebert/gists{/gist_id}","starred_url":"https://api.github.com/users/cvrebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvrebert/subscriptions","organizations_url":"https://api.github.com/users/cvrebert/orgs","repos_url":"https://api.github.com/users/cvrebert/repos","events_url":"https://api.github.com/users/cvrebert/events{/privacy}","received_events_url":"https://api.github.com/users/cvrebert/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":7,"state":"closed","created_at":"2015-04-08T00:19:16Z","updated_at":"2015-11-16T11:07:40Z","due_on":null,"closed_at":"2015-11-16T11:07:40Z"},"comments":2,"created_at":"2015-07-02T16:35:31Z","updated_at":"2016-01-30T06:55:12Z","closed_at":"2015-11-16T10:33:08Z","pull_request":{"url":"https://api.github.com/repos/twbs/bootlint/pulls/294","html_url":"https://github.com/twbs/bootlint/pull/294","diff_url":"https://github.com/twbs/bootlint/pull/294.diff","patch_url":"https://github.com/twbs/bootlint/pull/294.patch"},"body":"Fixes #293 \r\n\r\nW006 causes some conflicts here in the unit tests because on-disabled-elems.html specifically puts `.disabled` on button elements, so they also now report this new warning about `.disabled` on a `<button>`. \r\n\r\nIn nodeunit, I can just pass `['W006']` and `['W016']` (the new warning for this one) as disabledIds in each respective unit test, but disabledIds weren't set up for qunit, so I added `data-disabled` as an attribute.\r\n\r\nThis isn't a case that comes up often, so maybe there's a better approach here. Maybe this is overkill and we simply remove the two lines from on-disabled-elems.html that use buttons. Thoughts?\r\n\r\ncc @cvrebert @hnrch02 for review."},"comment":{"url":"https://api.github.com/repos/twbs/bootlint/issues/comments/177090283","html_url":"https://github.com/twbs/bootlint/pull/294#issuecomment-177090283","issue_url":"https://api.github.com/repos/twbs/bootlint/issues/294","id":177090283,"user":{"login":"cvrebert","id":419884,"avatar_url":"https://avatars.githubusercontent.com/u/419884?v=3","gravatar_id":"","url":"https://api.github.com/users/cvrebert","html_url":"https://github.com/cvrebert","followers_url":"https://api.github.com/users/cvrebert/followers","following_url":"https://api.github.com/users/cvrebert/following{/other_user}","gists_url":"https://api.github.com/users/cvrebert/gists{/gist_id}","starred_url":"https://api.github.com/users/cvrebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvrebert/subscriptions","organizations_url":"https://api.github.com/users/cvrebert/orgs","repos_url":"https://api.github.com/users/cvrebert/repos","events_url":"https://api.github.com/users/cvrebert/events{/privacy}","received_events_url":"https://api.github.com/users/cvrebert/received_events","type":"User","site_admin":false},"created_at":"2016-01-30T06:55:12Z","updated_at":"2016-01-30T06:55:12Z","body":"Apparently I neglected to add a wiki page for this. Wrote one just now: https://github.com/twbs/bootlint/wiki/W016\r\n@patrickhlauke Would appreciate any feedback you have on the wiki article since it touches on widgets-which-would-probably-need-ARIA a bit."}}