{"action":"closed","number":1635,"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/1635","id":84798953,"html_url":"https://github.com/NLog/NLog/pull/1635","diff_url":"https://github.com/NLog/NLog/pull/1635.diff","patch_url":"https://github.com/NLog/NLog/pull/1635.patch","issue_url":"https://api.github.com/repos/NLog/NLog/issues/1635","number":1635,"state":"closed","locked":false,"title":"Fix ${tempdir} and ${nlogdir} if both have dir and file.","user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"body":"according to docs both should be appended\r\n\r\nalso removed code duplication\r\n\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/nlog/nlog/1635)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-09-11T21:39:52Z","updated_at":"2016-09-12T19:41:50Z","closed_at":"2016-09-12T19:41:50Z","merged_at":"2016-09-12T19:41:50Z","merge_commit_sha":"3afce4ac30ccd71d64db358424cac2b1e35a9bc5","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NLog/NLog/milestones/30","html_url":"https://github.com/NLog/NLog/milestones/4.3.9","labels_url":"https://api.github.com/repos/NLog/NLog/milestones/30/labels","id":1996182,"number":30,"title":"4.3.9","description":"","creator":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2016-09-10T22:26:07Z","updated_at":"2016-09-12T19:41:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NLog/NLog/pulls/1635/commits","review_comments_url":"https://api.github.com/repos/NLog/NLog/pulls/1635/comments","review_comment_url":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/1635/comments","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/3adff481f037e9e5e1af9acd9613067aadc7d2c5","head":{"label":"NLog:fix-tempdir-layoutrenderer","ref":"fix-tempdir-layoutrenderer","sha":"3adff481f037e9e5e1af9acd9613067aadc7d2c5","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET, Silverlight and Xamarin Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/NLog/NLog/deployments","created_at":"2012-09-12T13:49:29Z","updated_at":"2016-09-12T14:07:35Z","pushed_at":"2016-09-12T19:41:50Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":165913,"stargazers_count":1857,"watchers_count":1857,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":647,"mirror_url":null,"open_issues_count":192,"forks":647,"open_issues":192,"watchers":1857,"default_branch":"master"}},"base":{"label":"NLog:master","ref":"master","sha":"b8362f5913af6e4ec51e62e2a47c6deba1b8f5bd","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET, Silverlight and Xamarin Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/NLog/NLog/deployments","created_at":"2012-09-12T13:49:29Z","updated_at":"2016-09-12T14:07:35Z","pushed_at":"2016-09-12T19:41:50Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":165913,"stargazers_count":1857,"watchers_count":1857,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":647,"mirror_url":null,"open_issues_count":192,"forks":647,"open_issues":192,"watchers":1857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1635"},"html":{"href":"https://github.com/NLog/NLog/pull/1635"},"issue":{"href":"https://api.github.com/repos/NLog/NLog/issues/1635"},"comments":{"href":"https://api.github.com/repos/NLog/NLog/issues/1635/comments"},"review_comments":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1635/comments"},"review_comment":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1635/commits"},"statuses":{"href":"https://api.github.com/repos/NLog/NLog/statuses/3adff481f037e9e5e1af9acd9613067aadc7d2c5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":251,"deletions":56,"changed_files":25}}
{"actor":{"display_login":"304NotModified"}}