{"action":"created","issue":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/256","repository_url":"https://api.github.com/repos/gramps-project/gramps","labels_url":"https://api.github.com/repos/gramps-project/gramps/issues/256/labels{/name}","comments_url":"https://api.github.com/repos/gramps-project/gramps/issues/256/comments","events_url":"https://api.github.com/repos/gramps-project/gramps/issues/256/events","html_url":"https://github.com/gramps-project/gramps/pull/256","id":184894067,"number":256,"title":"Improve test coverage in the Gedcom importer","user":{"login":"prculley","id":18122203,"avatar_url":"https://avatars.githubusercontent.com/u/18122203?v=3","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gramps-project/gramps/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/gramps-project/gramps/labels/Work%20in%20progress","name":"Work in progress","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-24T16:45:18Z","updated_at":"2016-10-24T17:01:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gramps-project/gramps/pulls/256","html_url":"https://github.com/gramps-project/gramps/pull/256","diff_url":"https://github.com/gramps-project/gramps/pull/256.diff","patch_url":"https://github.com/gramps-project/gramps/pull/256.patch"},"body":"This PR is primarily to improve test coverage.  The goal was to test as much of the standard code (as used in normal imports) as possible.  Some unusual conditions are also added, but most exceptions remain untested.\r\n\r\nIt was necessary to use Mock to keep the test_imports routine from failing on some dates, this in turn required a few changes to the Python imports in the 'unknown.py' module.  I have not figured out how to properly Mock patch standard time.time in an individual module yet unless it imports via the 'from time import time' sytax.  So I changed the module to use that syntax, rather than importing the entire time module via 'import time'.\r\n\r\nI also added in the 'tag on import' to the tests when the '_dfs' is part of the file name; this causes Gedcom (or others) to tag imported data (and increase test coverage of that feature).\r\n\r\nI commented out an 'assert' statement in libgedcom.py that got executed with the added test coverage; it prevented the test from completing.  Apparently the author thought that that particular code path should not ever be executed.\r\n\r\nI found several (minor) issues with the Gedcom importer by doing this process, I will submit bugs and PRs to address these as time permits."},"comment":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/comments/255800478","html_url":"https://github.com/gramps-project/gramps/pull/256#issuecomment-255800478","issue_url":"https://api.github.com/repos/gramps-project/gramps/issues/256","id":255800478,"user":{"login":"prculley","id":18122203,"avatar_url":"https://avatars.githubusercontent.com/u/18122203?v=3","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T17:01:22Z","updated_at":"2016-10-24T17:01:22Z","body":"Oops; looks like there is some difference between Windows and Linux implementations of time.strftime..."}}
{"actor":{"display_login":"prculley"}}