{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/93410497","pull_request_review_id":13936022,"id":93410497,"diff_hunk":"@@ -0,0 +1,51 @@\n+package net.corda.explorer.model\n+\n+import javafx.collections.ObservableList\n+import net.corda.client.model.NetworkIdentityModel\n+import net.corda.client.model.observableList\n+import net.corda.client.model.observableValue\n+import net.corda.core.contracts.currency\n+import net.corda.core.node.NodeInfo\n+import tornadofx.observable\n+import java.util.*\n+\n+val ISSUER_SERVICE_TYPE = Regex(\"corda.issuer.(USD|GBP|CHF)\")\n+\n+class IssuerModel {","path":"tools/explorer/src/main/kotlin/net/corda/explorer/model/IssuerModel.kt","position":14,"original_position":14,"commit_id":"958308ca7b706bf576a226cc2113658c506f3a10","original_commit_id":"7469c9e08bdf9be195c74522646f0fe904970151","user":{"login":"josecoll","id":23558646,"avatar_url":"https://avatars.githubusercontent.com/u/23558646?v=3","gravatar_id":"","url":"https://api.github.com/users/josecoll","html_url":"https://github.com/josecoll","followers_url":"https://api.github.com/users/josecoll/followers","following_url":"https://api.github.com/users/josecoll/following{/other_user}","gists_url":"https://api.github.com/users/josecoll/gists{/gist_id}","starred_url":"https://api.github.com/users/josecoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josecoll/subscriptions","organizations_url":"https://api.github.com/users/josecoll/orgs","repos_url":"https://api.github.com/users/josecoll/repos","events_url":"https://api.github.com/users/josecoll/events{/privacy}","received_events_url":"https://api.github.com/users/josecoll/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2016-12-21T10:14:27Z","updated_at":"2016-12-21T10:14:27Z","html_url":"https://github.com/corda/corda/pull/49#discussion_r93410497","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/93410497"},"html":{"href":"https://github.com/corda/corda/pull/49#discussion_r93410497"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/49","id":97364088,"html_url":"https://github.com/corda/corda/pull/49","diff_url":"https://github.com/corda/corda/pull/49.diff","patch_url":"https://github.com/corda/corda/pull/49.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/49","number":49,"state":"open","locked":false,"title":"Bank of Corda integration with Trader Demo and Explorer","user":{"login":"josecoll","id":23558646,"avatar_url":"https://avatars.githubusercontent.com/u/23558646?v=3","gravatar_id":"","url":"https://api.github.com/users/josecoll","html_url":"https://github.com/josecoll","followers_url":"https://api.github.com/users/josecoll/followers","following_url":"https://api.github.com/users/josecoll/following{/other_user}","gists_url":"https://api.github.com/users/josecoll/gists{/gist_id}","starred_url":"https://api.github.com/users/josecoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josecoll/subscriptions","organizations_url":"https://api.github.com/users/josecoll/orgs","repos_url":"https://api.github.com/users/josecoll/repos","events_url":"https://api.github.com/users/josecoll/events{/privacy}","received_events_url":"https://api.github.com/users/josecoll/received_events","type":"User","site_admin":false},"body":"Initial conversion of Explorer to use IssuerFlow (from BankOfCorda)\r\n\r\nInitial conversion of TraderDemo to use IssuerFlow (from BankOfCorda)\r\n\r\nUpdated TraderDemo to use IssuerFlow (from BankOfCorda)\r\n\r\nFixed TraderDemo integration text (added new BankOfCorda node)\r\n\r\nUpdated Explorer with changes IssuerRequest params\r\n\r\nExplorer now correctly displaying transaction id upon Issue.\r\n\r\nMoved IssuerFlow into finance package so can be reused across multiple demos (TraderDemo) and applications (eg Explorer)\r\n\r\nRefactored BankOfCorda demo to use Finance package and TestUtil constants\r\n\r\nUpdated TraderDemo to use IssuerFlow\r\n\r\nUpdated Explorer to use finance package IssuerFlow.\r\n\r\nAdvertised BankOfCorda as Issuer for usage by Explorer.\r\n\r\nExplorer no longer depends on BankOfCorda demo since IssuerFlow promoted to Finance module\r\n\r\nAdded IssuerFlow to AbstractNode whitelist.\r\nExplicit declarations of IssuerFlow no longer required.\r\n\r\nAdded plugin registration of IssuerFlow at bootstrap.\r\n\r\nRevert whitelisting of IssuerFlow (plugin configured)\r\n\r\nRefactored to use constant BOC definition.\r\n\r\nAdded gradle RPC security config.\r\n\r\nUpdated documentation","created_at":"2016-12-09T19:16:03Z","updated_at":"2016-12-21T10:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7371b5719a230934eb92380e85570ad3143c4fc8","assignee":{"login":"patrickkuo","id":1888654,"avatar_url":"https://avatars.githubusercontent.com/u/1888654?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickkuo","html_url":"https://github.com/patrickkuo","followers_url":"https://api.github.com/users/patrickkuo/followers","following_url":"https://api.github.com/users/patrickkuo/following{/other_user}","gists_url":"https://api.github.com/users/patrickkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickkuo/subscriptions","organizations_url":"https://api.github.com/users/patrickkuo/orgs","repos_url":"https://api.github.com/users/patrickkuo/repos","events_url":"https://api.github.com/users/patrickkuo/events{/privacy}","received_events_url":"https://api.github.com/users/patrickkuo/received_events","type":"User","site_admin":false},"assignees":[{"login":"patrickkuo","id":1888654,"avatar_url":"https://avatars.githubusercontent.com/u/1888654?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickkuo","html_url":"https://github.com/patrickkuo","followers_url":"https://api.github.com/users/patrickkuo/followers","following_url":"https://api.github.com/users/patrickkuo/following{/other_user}","gists_url":"https://api.github.com/users/patrickkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickkuo/subscriptions","organizations_url":"https://api.github.com/users/patrickkuo/orgs","repos_url":"https://api.github.com/users/patrickkuo/repos","events_url":"https://api.github.com/users/patrickkuo/events{/privacy}","received_events_url":"https://api.github.com/users/patrickkuo/received_events","type":"User","site_admin":false},{"login":"roger3cev","id":22620030,"avatar_url":"https://avatars.githubusercontent.com/u/22620030?v=3","gravatar_id":"","url":"https://api.github.com/users/roger3cev","html_url":"https://github.com/roger3cev","followers_url":"https://api.github.com/users/roger3cev/followers","following_url":"https://api.github.com/users/roger3cev/following{/other_user}","gists_url":"https://api.github.com/users/roger3cev/gists{/gist_id}","starred_url":"https://api.github.com/users/roger3cev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roger3cev/subscriptions","organizations_url":"https://api.github.com/users/roger3cev/orgs","repos_url":"https://api.github.com/users/roger3cev/repos","events_url":"https://api.github.com/users/roger3cev/events{/privacy}","received_events_url":"https://api.github.com/users/roger3cev/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/49/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/49/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/49/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/958308ca7b706bf576a226cc2113658c506f3a10","head":{"label":"corda:boc-demo-integration","ref":"boc-demo-integration","sha":"958308ca7b706bf576a226cc2113658c506f3a10","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions, it offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2016-12-21T08:41:18Z","pushed_at":"2016-12-21T09:58:16Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":53316,"stargazers_count":369,"watchers_count":369,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":16,"forks":97,"open_issues":16,"watchers":369,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"f44dd969ce1bea553820396992932d0f65cdbe10","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions, it offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2016-12-21T08:41:18Z","pushed_at":"2016-12-21T09:58:16Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":53316,"stargazers_count":369,"watchers_count":369,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":16,"forks":97,"open_issues":16,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/49"},"html":{"href":"https://github.com/corda/corda/pull/49"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/49"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/958308ca7b706bf576a226cc2113658c506f3a10"}}}}
{"actor":{"display_login":"josecoll"}}