{"action":"opened","number":46,"pull_request":{"url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/46","id":93358337,"html_url":"https://github.com/tjjjwxzq/SUTD-REvents/pull/46","diff_url":"https://github.com/tjjjwxzq/SUTD-REvents/pull/46.diff","patch_url":"https://github.com/tjjjwxzq/SUTD-REvents/pull/46.patch","issue_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/46","number":46,"state":"open","locked":false,"title":"Bugfix/event proposal project finances","user":{"login":"tjjjwxzq","id":11689299,"avatar_url":"https://avatars.githubusercontent.com/u/11689299?v=3","gravatar_id":"","url":"https://api.github.com/users/tjjjwxzq","html_url":"https://github.com/tjjjwxzq","followers_url":"https://api.github.com/users/tjjjwxzq/followers","following_url":"https://api.github.com/users/tjjjwxzq/following{/other_user}","gists_url":"https://api.github.com/users/tjjjwxzq/gists{/gist_id}","starred_url":"https://api.github.com/users/tjjjwxzq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjjjwxzq/subscriptions","organizations_url":"https://api.github.com/users/tjjjwxzq/orgs","repos_url":"https://api.github.com/users/tjjjwxzq/repos","events_url":"https://api.github.com/users/tjjjwxzq/events{/privacy}","received_events_url":"https://api.github.com/users/tjjjwxzq/received_events","type":"User","site_admin":false},"body":"This PR fixes a bug in the project finances form, where if the user tries to submit the form with no revenue items, but with revenue generated checked an error will be raised, but there will not be any descriptive error displayed on the form.\r\n\r\nAmended the project finances form to validate the presence of revenue items if revenue generated is checked and set a descriptive error message on `revenue_generated` if there is an error. Additionally amended the event proposal model and specs to reflect that this validation should be done even when the form is in progress.","created_at":"2016-11-11T16:24:56Z","updated_at":"2016-11-11T16:24:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/46/commits","review_comments_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/46/comments","review_comment_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/46/comments","statuses_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/statuses/224e9b2ea683a5eb493a696bbfbbb2178aeaa97a","head":{"label":"tjjjwxzq:bugfix/event-proposal-project-finances","ref":"bugfix/event-proposal-project-finances","sha":"224e9b2ea683a5eb493a696bbfbbb2178aeaa97a","user":{"login":"tjjjwxzq","id":11689299,"avatar_url":"https://avatars.githubusercontent.com/u/11689299?v=3","gravatar_id":"","url":"https://api.github.com/users/tjjjwxzq","html_url":"https://github.com/tjjjwxzq","followers_url":"https://api.github.com/users/tjjjwxzq/followers","following_url":"https://api.github.com/users/tjjjwxzq/following{/other_user}","gists_url":"https://api.github.com/users/tjjjwxzq/gists{/gist_id}","starred_url":"https://api.github.com/users/tjjjwxzq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjjjwxzq/subscriptions","organizations_url":"https://api.github.com/users/tjjjwxzq/orgs","repos_url":"https://api.github.com/users/tjjjwxzq/repos","events_url":"https://api.github.com/users/tjjjwxzq/events{/privacy}","received_events_url":"https://api.github.com/users/tjjjwxzq/received_events","type":"User","site_admin":false},"repo":{"id":67472099,"name":"SUTD-REvents","full_name":"tjjjwxzq/SUTD-REvents","owner":{"login":"tjjjwxzq","id":11689299,"avatar_url":"https://avatars.githubusercontent.com/u/11689299?v=3","gravatar_id":"","url":"https://api.github.com/users/tjjjwxzq","html_url":"https://github.com/tjjjwxzq","followers_url":"https://api.github.com/users/tjjjwxzq/followers","following_url":"https://api.github.com/users/tjjjwxzq/following{/other_user}","gists_url":"https://api.github.com/users/tjjjwxzq/gists{/gist_id}","starred_url":"https://api.github.com/users/tjjjwxzq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjjjwxzq/subscriptions","organizations_url":"https://api.github.com/users/tjjjwxzq/orgs","repos_url":"https://api.github.com/users/tjjjwxzq/repos","events_url":"https://api.github.com/users/tjjjwxzq/events{/privacy}","received_events_url":"https://api.github.com/users/tjjjwxzq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjjjwxzq/SUTD-REvents","description":"Events app for SUTD built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents","forks_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/forks","keys_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/teams","hooks_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/hooks","issue_events_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/events{/number}","events_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/events","assignees_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/assignees{/user}","branches_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/branches{/branch}","tags_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/tags","blobs_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/statuses/{sha}","languages_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/languages","stargazers_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/stargazers","contributors_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/contributors","subscribers_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/subscribers","subscription_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/subscription","commits_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/contents/{+path}","compare_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/merges","archive_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/downloads","issues_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues{/number}","pulls_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls{/number}","milestones_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/milestones{/number}","notifications_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/labels{/name}","releases_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/releases{/id}","deployments_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/deployments","created_at":"2016-09-06T04:03:28Z","updated_at":"2016-10-24T16:04:07Z","pushed_at":"2016-11-11T16:24:56Z","git_url":"git://github.com/tjjjwxzq/SUTD-REvents.git","ssh_url":"git@github.com:tjjjwxzq/SUTD-REvents.git","clone_url":"https://github.com/tjjjwxzq/SUTD-REvents.git","svn_url":"https://github.com/tjjjwxzq/SUTD-REvents","homepage":null,"size":768,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"tjjjwxzq:master","ref":"master","sha":"5651858467d55e608197891baf68849f4b89182d","user":{"login":"tjjjwxzq","id":11689299,"avatar_url":"https://avatars.githubusercontent.com/u/11689299?v=3","gravatar_id":"","url":"https://api.github.com/users/tjjjwxzq","html_url":"https://github.com/tjjjwxzq","followers_url":"https://api.github.com/users/tjjjwxzq/followers","following_url":"https://api.github.com/users/tjjjwxzq/following{/other_user}","gists_url":"https://api.github.com/users/tjjjwxzq/gists{/gist_id}","starred_url":"https://api.github.com/users/tjjjwxzq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjjjwxzq/subscriptions","organizations_url":"https://api.github.com/users/tjjjwxzq/orgs","repos_url":"https://api.github.com/users/tjjjwxzq/repos","events_url":"https://api.github.com/users/tjjjwxzq/events{/privacy}","received_events_url":"https://api.github.com/users/tjjjwxzq/received_events","type":"User","site_admin":false},"repo":{"id":67472099,"name":"SUTD-REvents","full_name":"tjjjwxzq/SUTD-REvents","owner":{"login":"tjjjwxzq","id":11689299,"avatar_url":"https://avatars.githubusercontent.com/u/11689299?v=3","gravatar_id":"","url":"https://api.github.com/users/tjjjwxzq","html_url":"https://github.com/tjjjwxzq","followers_url":"https://api.github.com/users/tjjjwxzq/followers","following_url":"https://api.github.com/users/tjjjwxzq/following{/other_user}","gists_url":"https://api.github.com/users/tjjjwxzq/gists{/gist_id}","starred_url":"https://api.github.com/users/tjjjwxzq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjjjwxzq/subscriptions","organizations_url":"https://api.github.com/users/tjjjwxzq/orgs","repos_url":"https://api.github.com/users/tjjjwxzq/repos","events_url":"https://api.github.com/users/tjjjwxzq/events{/privacy}","received_events_url":"https://api.github.com/users/tjjjwxzq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjjjwxzq/SUTD-REvents","description":"Events app for SUTD built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents","forks_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/forks","keys_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/teams","hooks_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/hooks","issue_events_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/events{/number}","events_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/events","assignees_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/assignees{/user}","branches_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/branches{/branch}","tags_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/tags","blobs_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/statuses/{sha}","languages_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/languages","stargazers_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/stargazers","contributors_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/contributors","subscribers_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/subscribers","subscription_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/subscription","commits_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/contents/{+path}","compare_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/merges","archive_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/downloads","issues_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues{/number}","pulls_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls{/number}","milestones_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/milestones{/number}","notifications_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/labels{/name}","releases_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/releases{/id}","deployments_url":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/deployments","created_at":"2016-09-06T04:03:28Z","updated_at":"2016-10-24T16:04:07Z","pushed_at":"2016-11-11T16:24:56Z","git_url":"git://github.com/tjjjwxzq/SUTD-REvents.git","ssh_url":"git@github.com:tjjjwxzq/SUTD-REvents.git","clone_url":"https://github.com/tjjjwxzq/SUTD-REvents.git","svn_url":"https://github.com/tjjjwxzq/SUTD-REvents","homepage":null,"size":768,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/46"},"html":{"href":"https://github.com/tjjjwxzq/SUTD-REvents/pull/46"},"issue":{"href":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/46"},"comments":{"href":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/tjjjwxzq/SUTD-REvents/statuses/224e9b2ea683a5eb493a696bbfbbb2178aeaa97a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":32,"deletions":14,"changed_files":5}}
{"actor":{"display_login":"tjjjwxzq"}}