{"action":"created","comment":{"url":"https://api.github.com/repos/implydata/pivot/pulls/comments/63404693","id":63404693,"diff_hunk":"@@ -2,173 +2,64 @@\n \n $header-height: 38px;\n $segment-width: 300px;\n-$measure-width: 100px;\n+$measure-width: 130px;\n $row-height: 30px;\n $space-left: 10px;\n+$measure-column-padding-left: 10px;\n \n $header-padding-top: 12px;\n \n .table {\n-  .sort-arrow {\n-    position: absolute;\n-    top: 12px;\n-    width: 8px;\n \n-    &.ascending {\n-      transform: rotate(180deg);\n-    }\n-  }\n-\n-  .corner {\n+  // Used for both row (i.e. body rows) and segments\n+  @mixin row-style {\n     position: absolute;\n-    left: $space-left;\n-    top: 0;\n-    width: $segment-width;\n-    height: $header-height;\n-    overflow: hidden;\n-    padding: $header-padding-top 0 0 6px;\n+    height: $row-height;\n     border-bottom: 1px solid $border-extra-light;\n+    left: 0;\n \n-    .sort-arrow {\n-      right: 2px;\n-    }\n-  }\n-\n-  .simple-table {\n-    .header-cont {\n-      left: $space-left + $segment-width;\n-\n-      .header {\n-        height: $header-height;\n-      }\n-\n-      .sort-arrow {\n-        right: -15px;\n-      }\n-    }\n-\n-    .body-cont {\n-      @include unpin-top($header-height);\n-      left: $space-left + $segment-width;\n-    }\n-\n-    .row {\n-      width: 100%;\n+    &.hover {\n+      background: $hover;\n     }\n \n-    .segments-cont {\n-      position: absolute;\n-      left: $space-left;\n-      top: $header-height;\n-      bottom: 0;\n-      width: $segment-width;\n-      overflow: hidden;\n+    &.selected {\n+      background: $hover;\n     }\n \n-    .highlight-cont {\n-      position: absolute;\n-      left: $space-left;\n-      right: 0;\n-      top: $header-height;\n-      bottom: 0;\n-      overflow: hidden;\n-\n-      .highlighter {\n-        right: 0;\n-        height: $row-height + 1;\n-        margin-top: -1px;\n-        border: 1px solid $hover;\n-\n-        &:after {\n-          @include unpin-full(-1px);\n-          content: '';\n-          border: 1px dashed $highlight-border;\n-        }\n+    &.not-selected {\n+      &:after {\n+        @include pin-full;\n+        background: $white;\n+        opacity: 0.5;\n+        content: '';\n       }\n     }\n   }\n \n-  .vertical-scroll-shadow {\n+  .corner {\n     position: absolute;\n     left: $space-left;\n     top: 0;\n-    bottom: 0;\n     width: $segment-width;\n-    box-shadow: 4px 0 4px -3px hsla(0, 0, 0, 0.2);\n-  }\n-\n-  .highlight-controls {\n-    position: absolute;\n-    right: 20px;\n-  }\n-\n-  .segment,\n-  .row {\n-    position: absolute;\n-    height: $row-height;\n+    height: $header-height;\n+    overflow: hidden;\n+    padding: $header-padding-top 0 0 6px;\n     border-bottom: 1px solid $border-extra-light;\n \n-    &.hover {\n-      background: $hover;\n-    }\n-\n-    &.selected {\n-      background: $hover;\n-    }\n-\n-    &.nest0 {\n-      background: $background-lightest;\n-    }\n-  }\n-\n-  .row {\n-    left: 0;\n-  }\n-\n-  .not-selected {\n-    &:after {\n-      @include pin-full;\n-      background: $white;\n-      opacity: 0.5;\n-      content: '';\n+    .sort-arrow {\n+      right: 2px;\n     }\n   }\n \n-  .measure-name {\n-    padding-top: $header-padding-top;\n+  .simple-table {\n+    @import './header';\n+    @import './segments'; // first, left column of the table\n+    @import './body'; // actual values\n+    @import './post-body'; // v-scroll shadow, highlighter...","path":"src/client/visualizations/table/table.scss","position":164,"original_position":164,"commit_id":"1fd989c5a135327e93ab808c62b9ac0fb41006f6","original_commit_id":"1fd989c5a135327e93ab808c62b9ac0fb41006f6","user":{"login":"vogievetsky","id":177816,"avatar_url":"https://avatars.githubusercontent.com/u/177816?v=3","gravatar_id":"","url":"https://api.github.com/users/vogievetsky","html_url":"https://github.com/vogievetsky","followers_url":"https://api.github.com/users/vogievetsky/followers","following_url":"https://api.github.com/users/vogievetsky/following{/other_user}","gists_url":"https://api.github.com/users/vogievetsky/gists{/gist_id}","starred_url":"https://api.github.com/users/vogievetsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogievetsky/subscriptions","organizations_url":"https://api.github.com/users/vogievetsky/orgs","repos_url":"https://api.github.com/users/vogievetsky/repos","events_url":"https://api.github.com/users/vogievetsky/events{/privacy}","received_events_url":"https://api.github.com/users/vogievetsky/received_events","type":"User","site_admin":false},"body":"OMG yes. So clean! did not know you could do this. It was not possible last time I checked (which was like 3 years ago)","created_at":"2016-05-16T18:51:23Z","updated_at":"2016-05-16T18:51:23Z","html_url":"https://github.com/implydata/pivot/pull/190#discussion_r63404693","pull_request_url":"https://api.github.com/repos/implydata/pivot/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/implydata/pivot/pulls/comments/63404693"},"html":{"href":"https://github.com/implydata/pivot/pull/190#discussion_r63404693"},"pull_request":{"href":"https://api.github.com/repos/implydata/pivot/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/implydata/pivot/pulls/190","id":70127750,"html_url":"https://github.com/implydata/pivot/pull/190","diff_url":"https://github.com/implydata/pivot/pull/190.diff","patch_url":"https://github.com/implydata/pivot/pull/190.patch","issue_url":"https://api.github.com/repos/implydata/pivot/issues/190","number":190,"state":"open","locked":false,"title":"Table bars","user":{"login":"lorem--ipsum","id":1224709,"avatar_url":"https://avatars.githubusercontent.com/u/1224709?v=3","gravatar_id":"","url":"https://api.github.com/users/lorem--ipsum","html_url":"https://github.com/lorem--ipsum","followers_url":"https://api.github.com/users/lorem--ipsum/followers","following_url":"https://api.github.com/users/lorem--ipsum/following{/other_user}","gists_url":"https://api.github.com/users/lorem--ipsum/gists{/gist_id}","starred_url":"https://api.github.com/users/lorem--ipsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorem--ipsum/subscriptions","organizations_url":"https://api.github.com/users/lorem--ipsum/orgs","repos_url":"https://api.github.com/users/lorem--ipsum/repos","events_url":"https://api.github.com/users/lorem--ipsum/events{/privacy}","received_events_url":"https://api.github.com/users/lorem--ipsum/received_events","type":"User","site_admin":false},"body":"![pouet](http://g.recordit.co/1wtEKtk1SJ.gif)","created_at":"2016-05-15T17:45:05Z","updated_at":"2016-05-16T18:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffbf7ae7c4eb59047e10ffe2d79f2ff473d404bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/implydata/pivot/pulls/190/commits","review_comments_url":"https://api.github.com/repos/implydata/pivot/pulls/190/comments","review_comment_url":"https://api.github.com/repos/implydata/pivot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/implydata/pivot/issues/190/comments","statuses_url":"https://api.github.com/repos/implydata/pivot/statuses/1fd989c5a135327e93ab808c62b9ac0fb41006f6","head":{"label":"implydata:table-bars","ref":"table-bars","sha":"1fd989c5a135327e93ab808c62b9ac0fb41006f6","user":{"login":"implydata","id":11660206,"avatar_url":"https://avatars.githubusercontent.com/u/11660206?v=3","gravatar_id":"","url":"https://api.github.com/users/implydata","html_url":"https://github.com/implydata","followers_url":"https://api.github.com/users/implydata/followers","following_url":"https://api.github.com/users/implydata/following{/other_user}","gists_url":"https://api.github.com/users/implydata/gists{/gist_id}","starred_url":"https://api.github.com/users/implydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/implydata/subscriptions","organizations_url":"https://api.github.com/users/implydata/orgs","repos_url":"https://api.github.com/users/implydata/repos","events_url":"https://api.github.com/users/implydata/events{/privacy}","received_events_url":"https://api.github.com/users/implydata/received_events","type":"Organization","site_admin":false},"repo":{"id":39598888,"name":"pivot","full_name":"implydata/pivot","owner":{"login":"implydata","id":11660206,"avatar_url":"https://avatars.githubusercontent.com/u/11660206?v=3","gravatar_id":"","url":"https://api.github.com/users/implydata","html_url":"https://github.com/implydata","followers_url":"https://api.github.com/users/implydata/followers","following_url":"https://api.github.com/users/implydata/following{/other_user}","gists_url":"https://api.github.com/users/implydata/gists{/gist_id}","starred_url":"https://api.github.com/users/implydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/implydata/subscriptions","organizations_url":"https://api.github.com/users/implydata/orgs","repos_url":"https://api.github.com/users/implydata/repos","events_url":"https://api.github.com/users/implydata/events{/privacy}","received_events_url":"https://api.github.com/users/implydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/implydata/pivot","description":"An interactive data exploration UI for Druid","fork":false,"url":"https://api.github.com/repos/implydata/pivot","forks_url":"https://api.github.com/repos/implydata/pivot/forks","keys_url":"https://api.github.com/repos/implydata/pivot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/implydata/pivot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/implydata/pivot/teams","hooks_url":"https://api.github.com/repos/implydata/pivot/hooks","issue_events_url":"https://api.github.com/repos/implydata/pivot/issues/events{/number}","events_url":"https://api.github.com/repos/implydata/pivot/events","assignees_url":"https://api.github.com/repos/implydata/pivot/assignees{/user}","branches_url":"https://api.github.com/repos/implydata/pivot/branches{/branch}","tags_url":"https://api.github.com/repos/implydata/pivot/tags","blobs_url":"https://api.github.com/repos/implydata/pivot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/implydata/pivot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/implydata/pivot/git/refs{/sha}","trees_url":"https://api.github.com/repos/implydata/pivot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/implydata/pivot/statuses/{sha}","languages_url":"https://api.github.com/repos/implydata/pivot/languages","stargazers_url":"https://api.github.com/repos/implydata/pivot/stargazers","contributors_url":"https://api.github.com/repos/implydata/pivot/contributors","subscribers_url":"https://api.github.com/repos/implydata/pivot/subscribers","subscription_url":"https://api.github.com/repos/implydata/pivot/subscription","commits_url":"https://api.github.com/repos/implydata/pivot/commits{/sha}","git_commits_url":"https://api.github.com/repos/implydata/pivot/git/commits{/sha}","comments_url":"https://api.github.com/repos/implydata/pivot/comments{/number}","issue_comment_url":"https://api.github.com/repos/implydata/pivot/issues/comments{/number}","contents_url":"https://api.github.com/repos/implydata/pivot/contents/{+path}","compare_url":"https://api.github.com/repos/implydata/pivot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/implydata/pivot/merges","archive_url":"https://api.github.com/repos/implydata/pivot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/implydata/pivot/downloads","issues_url":"https://api.github.com/repos/implydata/pivot/issues{/number}","pulls_url":"https://api.github.com/repos/implydata/pivot/pulls{/number}","milestones_url":"https://api.github.com/repos/implydata/pivot/milestones{/number}","notifications_url":"https://api.github.com/repos/implydata/pivot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/implydata/pivot/labels{/name}","releases_url":"https://api.github.com/repos/implydata/pivot/releases{/id}","deployments_url":"https://api.github.com/repos/implydata/pivot/deployments","created_at":"2015-07-23T23:12:28Z","updated_at":"2016-05-16T00:43:24Z","pushed_at":"2016-05-16T17:45:43Z","git_url":"git://github.com/implydata/pivot.git","ssh_url":"git@github.com:implydata/pivot.git","clone_url":"https://github.com/implydata/pivot.git","svn_url":"https://github.com/implydata/pivot","homepage":"","size":41880,"stargazers_count":368,"watchers_count":368,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":21,"forks":78,"open_issues":21,"watchers":368,"default_branch":"master"}},"base":{"label":"implydata:master","ref":"master","sha":"7782ef393e5be874d9b5e25968f4b31ffca9e15c","user":{"login":"implydata","id":11660206,"avatar_url":"https://avatars.githubusercontent.com/u/11660206?v=3","gravatar_id":"","url":"https://api.github.com/users/implydata","html_url":"https://github.com/implydata","followers_url":"https://api.github.com/users/implydata/followers","following_url":"https://api.github.com/users/implydata/following{/other_user}","gists_url":"https://api.github.com/users/implydata/gists{/gist_id}","starred_url":"https://api.github.com/users/implydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/implydata/subscriptions","organizations_url":"https://api.github.com/users/implydata/orgs","repos_url":"https://api.github.com/users/implydata/repos","events_url":"https://api.github.com/users/implydata/events{/privacy}","received_events_url":"https://api.github.com/users/implydata/received_events","type":"Organization","site_admin":false},"repo":{"id":39598888,"name":"pivot","full_name":"implydata/pivot","owner":{"login":"implydata","id":11660206,"avatar_url":"https://avatars.githubusercontent.com/u/11660206?v=3","gravatar_id":"","url":"https://api.github.com/users/implydata","html_url":"https://github.com/implydata","followers_url":"https://api.github.com/users/implydata/followers","following_url":"https://api.github.com/users/implydata/following{/other_user}","gists_url":"https://api.github.com/users/implydata/gists{/gist_id}","starred_url":"https://api.github.com/users/implydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/implydata/subscriptions","organizations_url":"https://api.github.com/users/implydata/orgs","repos_url":"https://api.github.com/users/implydata/repos","events_url":"https://api.github.com/users/implydata/events{/privacy}","received_events_url":"https://api.github.com/users/implydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/implydata/pivot","description":"An interactive data exploration UI for Druid","fork":false,"url":"https://api.github.com/repos/implydata/pivot","forks_url":"https://api.github.com/repos/implydata/pivot/forks","keys_url":"https://api.github.com/repos/implydata/pivot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/implydata/pivot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/implydata/pivot/teams","hooks_url":"https://api.github.com/repos/implydata/pivot/hooks","issue_events_url":"https://api.github.com/repos/implydata/pivot/issues/events{/number}","events_url":"https://api.github.com/repos/implydata/pivot/events","assignees_url":"https://api.github.com/repos/implydata/pivot/assignees{/user}","branches_url":"https://api.github.com/repos/implydata/pivot/branches{/branch}","tags_url":"https://api.github.com/repos/implydata/pivot/tags","blobs_url":"https://api.github.com/repos/implydata/pivot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/implydata/pivot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/implydata/pivot/git/refs{/sha}","trees_url":"https://api.github.com/repos/implydata/pivot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/implydata/pivot/statuses/{sha}","languages_url":"https://api.github.com/repos/implydata/pivot/languages","stargazers_url":"https://api.github.com/repos/implydata/pivot/stargazers","contributors_url":"https://api.github.com/repos/implydata/pivot/contributors","subscribers_url":"https://api.github.com/repos/implydata/pivot/subscribers","subscription_url":"https://api.github.com/repos/implydata/pivot/subscription","commits_url":"https://api.github.com/repos/implydata/pivot/commits{/sha}","git_commits_url":"https://api.github.com/repos/implydata/pivot/git/commits{/sha}","comments_url":"https://api.github.com/repos/implydata/pivot/comments{/number}","issue_comment_url":"https://api.github.com/repos/implydata/pivot/issues/comments{/number}","contents_url":"https://api.github.com/repos/implydata/pivot/contents/{+path}","compare_url":"https://api.github.com/repos/implydata/pivot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/implydata/pivot/merges","archive_url":"https://api.github.com/repos/implydata/pivot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/implydata/pivot/downloads","issues_url":"https://api.github.com/repos/implydata/pivot/issues{/number}","pulls_url":"https://api.github.com/repos/implydata/pivot/pulls{/number}","milestones_url":"https://api.github.com/repos/implydata/pivot/milestones{/number}","notifications_url":"https://api.github.com/repos/implydata/pivot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/implydata/pivot/labels{/name}","releases_url":"https://api.github.com/repos/implydata/pivot/releases{/id}","deployments_url":"https://api.github.com/repos/implydata/pivot/deployments","created_at":"2015-07-23T23:12:28Z","updated_at":"2016-05-16T00:43:24Z","pushed_at":"2016-05-16T17:45:43Z","git_url":"git://github.com/implydata/pivot.git","ssh_url":"git@github.com:implydata/pivot.git","clone_url":"https://github.com/implydata/pivot.git","svn_url":"https://github.com/implydata/pivot","homepage":"","size":41880,"stargazers_count":368,"watchers_count":368,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":21,"forks":78,"open_issues":21,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/implydata/pivot/pulls/190"},"html":{"href":"https://github.com/implydata/pivot/pull/190"},"issue":{"href":"https://api.github.com/repos/implydata/pivot/issues/190"},"comments":{"href":"https://api.github.com/repos/implydata/pivot/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/implydata/pivot/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/implydata/pivot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/implydata/pivot/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/implydata/pivot/statuses/1fd989c5a135327e93ab808c62b9ac0fb41006f6"}}}}