{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10492","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10492/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10492/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10492/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10492","id":187573633,"number":10492,"title":"storage: prioritize up-replication over dead-replica removal","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-06T16:54:36Z","updated_at":"2016-11-07T13:23:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10492","html_url":"https://github.com/cockroachdb/cockroach/pull/10492","diff_url":"https://github.com/cockroachdb/cockroach/pull/10492.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10492.patch"},"body":"Previously, dead-replica removal was prioritized over up-replication\nwhich could lead to situations in which the up-replication work created\nby the removal of a dead-replica was starved for a significant period of\ntime. Additionally, dead-replica removal is quite fast in comparison to\nup-replication so prioritizing it allows a whole bunch of up-replication\nwork to be generated fairly quickly. Now we prioritize up-replication\nwork over dead-replica removal. If a stable cluster (no replication work\nneeded), when a node dies each replicateQueue will alternate between\nremoving a dead replica from a range and bringing that same range back\nto full replication.\n\nFixes #10476\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10492)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/258834027","html_url":"https://github.com/cockroachdb/cockroach/pull/10492#issuecomment-258834027","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10492","id":258834027,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T13:23:32Z","updated_at":"2016-11-07T13:23:32Z","body":"> This change should be monitored when it get deployed to blue.\r\n\r\nDefinitely."}}
{"actor":{"display_login":"petermattis"}}