{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/90293399","pull_request_review_id":10814861,"id":90293399,"diff_hunk":"@@ -65,6 +65,35 @@ public void teardown() {\n     public void testFetchElasticsearchOnTrigger() throws IOException {\n         runner = TestRunners.newTestRunner(new FetchElasticsearchHttpTestProcessor(true)); // all docs are found\n         runner.setValidateExpressionUsage(true);\n+        runner.setProperty(AbstractElasticsearchHttpProcessor.ES_URL, \"${es.url}\");\n+\n+        runner.setProperty(FetchElasticsearchHttp.INDEX, \"doc\");\n+        runner.assertNotValid();\n+        runner.setProperty(FetchElasticsearchHttp.TYPE, \"status\");\n+        runner.assertNotValid();\n+        runner.setProperty(FetchElasticsearchHttp.DOC_ID, \"${doc_id}\");\n+        runner.assertValid();\n+        runner.setProperty(AbstractElasticsearchHttpProcessor.CONNECT_TIMEOUT, \"${connect.timeout}\");\n+        runner.assertValid();\n+\n+        runner.setVariable(\"es.url\", \"http://127.0.0.1:9200\");\n+        runner.setVariable(\"connect.timeout\", \"5s\");\n+\n+        runner.enqueue(docExample, new HashMap<String, String>() {{\n+            put(\"doc_id\", \"28039652140\");\n+        }});\n+        runner.run(1, true, true);\n+\n+        runner.assertAllFlowFilesTransferred(FetchElasticsearchHttp.REL_SUCCESS, 1);\n+        final MockFlowFile out = runner.getFlowFilesForRelationship(FetchElasticsearchHttp.REL_SUCCESS).get(0);\n+        assertNotNull(out);\n+        out.assertAttributeEquals(\"doc_id\", \"28039652140\");\n+    }\n+\n+    @Test\n+    public void testFetchElasticsearchOnTriggerEL() throws IOException {","path":"nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch/TestFetchElasticsearchHttp.java","position":30,"original_position":30,"commit_id":"3a849a0419671f81594f8a2c21d4b67f0ec357bf","original_commit_id":"3a849a0419671f81594f8a2c21d4b67f0ec357bf","user":{"login":"JPercivall","id":11302527,"avatar_url":"https://avatars.githubusercontent.com/u/11302527?v=3","gravatar_id":"","url":"https://api.github.com/users/JPercivall","html_url":"https://github.com/JPercivall","followers_url":"https://api.github.com/users/JPercivall/followers","following_url":"https://api.github.com/users/JPercivall/following{/other_user}","gists_url":"https://api.github.com/users/JPercivall/gists{/gist_id}","starred_url":"https://api.github.com/users/JPercivall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPercivall/subscriptions","organizations_url":"https://api.github.com/users/JPercivall/orgs","repos_url":"https://api.github.com/users/JPercivall/repos","events_url":"https://api.github.com/users/JPercivall/events{/privacy}","received_events_url":"https://api.github.com/users/JPercivall/received_events","type":"User","site_admin":false},"body":"Looks like the test names got mixed up here","created_at":"2016-11-30T18:16:51Z","updated_at":"2016-11-30T18:16:51Z","html_url":"https://github.com/apache/nifi/pull/1276#discussion_r90293399","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/1276","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/90293399"},"html":{"href":"https://github.com/apache/nifi/pull/1276#discussion_r90293399"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/1276"}}},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/1276","id":95731188,"html_url":"https://github.com/apache/nifi/pull/1276","diff_url":"https://github.com/apache/nifi/pull/1276.diff","patch_url":"https://github.com/apache/nifi/pull/1276.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/1276","number":1276,"state":"open","locked":false,"title":"NIFI-3095: Add EL support to Elasticsearch 2.x (and HTTP) processors","user":{"login":"mattyb149","id":2124747,"avatar_url":"https://avatars.githubusercontent.com/u/2124747?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyb149","html_url":"https://github.com/mattyb149","followers_url":"https://api.github.com/users/mattyb149/followers","following_url":"https://api.github.com/users/mattyb149/following{/other_user}","gists_url":"https://api.github.com/users/mattyb149/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyb149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyb149/subscriptions","organizations_url":"https://api.github.com/users/mattyb149/orgs","repos_url":"https://api.github.com/users/mattyb149/repos","events_url":"https://api.github.com/users/mattyb149/events{/privacy}","received_events_url":"https://api.github.com/users/mattyb149/received_events","type":"User","site_admin":false},"body":"For feature parity with the ES 5.0 processors, I added EL support to all appropriate properties. Also I moved the relationship and property descriptor creation to static blocks (as is the conventional wisdom). Unit tests were added to exercise the EL logic, and I changed some Java 7 constructs to Java 8 constructs (lambdas, e.g.)\r\n","created_at":"2016-11-29T16:51:46Z","updated_at":"2016-11-30T18:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2c7fb05f48ac88e0a0d5161a8664ae3aac2c0f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/1276/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/1276/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/1276/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/3a849a0419671f81594f8a2c21d4b67f0ec357bf","head":{"label":"mattyb149:NIFI-3095","ref":"NIFI-3095","sha":"3a849a0419671f81594f8a2c21d4b67f0ec357bf","user":{"login":"mattyb149","id":2124747,"avatar_url":"https://avatars.githubusercontent.com/u/2124747?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyb149","html_url":"https://github.com/mattyb149","followers_url":"https://api.github.com/users/mattyb149/followers","following_url":"https://api.github.com/users/mattyb149/following{/other_user}","gists_url":"https://api.github.com/users/mattyb149/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyb149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyb149/subscriptions","organizations_url":"https://api.github.com/users/mattyb149/orgs","repos_url":"https://api.github.com/users/mattyb149/repos","events_url":"https://api.github.com/users/mattyb149/events{/privacy}","received_events_url":"https://api.github.com/users/mattyb149/received_events","type":"User","site_admin":false},"repo":{"id":28576559,"name":"nifi","full_name":"mattyb149/nifi","owner":{"login":"mattyb149","id":2124747,"avatar_url":"https://avatars.githubusercontent.com/u/2124747?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyb149","html_url":"https://github.com/mattyb149","followers_url":"https://api.github.com/users/mattyb149/followers","following_url":"https://api.github.com/users/mattyb149/following{/other_user}","gists_url":"https://api.github.com/users/mattyb149/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyb149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyb149/subscriptions","organizations_url":"https://api.github.com/users/mattyb149/orgs","repos_url":"https://api.github.com/users/mattyb149/repos","events_url":"https://api.github.com/users/mattyb149/events{/privacy}","received_events_url":"https://api.github.com/users/mattyb149/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattyb149/nifi","description":"Mirror of Apache NiFi (Incubating)","fork":true,"url":"https://api.github.com/repos/mattyb149/nifi","forks_url":"https://api.github.com/repos/mattyb149/nifi/forks","keys_url":"https://api.github.com/repos/mattyb149/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattyb149/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattyb149/nifi/teams","hooks_url":"https://api.github.com/repos/mattyb149/nifi/hooks","issue_events_url":"https://api.github.com/repos/mattyb149/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/mattyb149/nifi/events","assignees_url":"https://api.github.com/repos/mattyb149/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/mattyb149/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/mattyb149/nifi/tags","blobs_url":"https://api.github.com/repos/mattyb149/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattyb149/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattyb149/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattyb149/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattyb149/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/mattyb149/nifi/languages","stargazers_url":"https://api.github.com/repos/mattyb149/nifi/stargazers","contributors_url":"https://api.github.com/repos/mattyb149/nifi/contributors","subscribers_url":"https://api.github.com/repos/mattyb149/nifi/subscribers","subscription_url":"https://api.github.com/repos/mattyb149/nifi/subscription","commits_url":"https://api.github.com/repos/mattyb149/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattyb149/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattyb149/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattyb149/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattyb149/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/mattyb149/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattyb149/nifi/merges","archive_url":"https://api.github.com/repos/mattyb149/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattyb149/nifi/downloads","issues_url":"https://api.github.com/repos/mattyb149/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/mattyb149/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/mattyb149/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/mattyb149/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattyb149/nifi/labels{/name}","releases_url":"https://api.github.com/repos/mattyb149/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/mattyb149/nifi/deployments","created_at":"2014-12-29T01:48:08Z","updated_at":"2016-11-09T18:22:19Z","pushed_at":"2016-11-29T16:48:26Z","git_url":"git://github.com/mattyb149/nifi.git","ssh_url":"git@github.com:mattyb149/nifi.git","clone_url":"https://github.com/mattyb149/nifi.git","svn_url":"https://github.com/mattyb149/nifi","homepage":null,"size":70798,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9d6ca6e1e60e604852cb3ad46eba6d58189b0864","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2016-11-30T02:54:21Z","pushed_at":"2016-11-30T18:07:56Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":100908,"stargazers_count":404,"watchers_count":404,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":369,"mirror_url":"git://git.apache.org/nifi.git","open_issues_count":59,"forks":369,"open_issues":59,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/1276"},"html":{"href":"https://github.com/apache/nifi/pull/1276"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/1276"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/1276/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/1276/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/1276/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/3a849a0419671f81594f8a2c21d4b67f0ec357bf"}}}}
{"actor":{"display_login":"JPercivall"}}