{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/48915954","id":48915954,"diff_hunk":"@@ -446,13 +485,17 @@ private void handleContainerCompletion(ContainerStatus containerStatus) {\n     @Override\n     public void onContainersCompleted(List<ContainerStatus> statuses) {\n       for (ContainerStatus containerStatus : statuses) {\n-        handleContainerCompletion(containerStatus);\n+        int retryCount = handleContainerCompletion(containerStatus);\n+        eventSubmitter.submit(GobblinYarnEventConstants.EventNames.CONTAINER_COMPLETION,","path":"gobblin-yarn/src/main/java/gobblin/yarn/YarnService.java","position":120,"original_position":120,"commit_id":"106d1b0e33cb25638cfe250d316bdf06184674c9","original_commit_id":"106d1b0e33cb25638cfe250d316bdf06184674c9","user":{"login":"liyinan926","id":3709137,"avatar_url":"https://avatars.githubusercontent.com/u/3709137?v=3","gravatar_id":"","url":"https://api.github.com/users/liyinan926","html_url":"https://github.com/liyinan926","followers_url":"https://api.github.com/users/liyinan926/followers","following_url":"https://api.github.com/users/liyinan926/following{/other_user}","gists_url":"https://api.github.com/users/liyinan926/gists{/gist_id}","starred_url":"https://api.github.com/users/liyinan926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyinan926/subscriptions","organizations_url":"https://api.github.com/users/liyinan926/orgs","repos_url":"https://api.github.com/users/liyinan926/repos","events_url":"https://api.github.com/users/liyinan926/events{/privacy}","received_events_url":"https://api.github.com/users/liyinan926/received_events","type":"User","site_admin":false},"body":"You can move this call to inside `handleContainerCompletion`, then you don't need to change the signature of `handleContainerCompletion`.","created_at":"2016-01-06T00:38:08Z","updated_at":"2016-01-06T00:38:08Z","html_url":"https://github.com/linkedin/gobblin/pull/585#discussion_r48915954","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/585","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/48915954"},"html":{"href":"https://github.com/linkedin/gobblin/pull/585#discussion_r48915954"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/585","id":55162963,"html_url":"https://github.com/linkedin/gobblin/pull/585","diff_url":"https://github.com/linkedin/gobblin/pull/585.diff","patch_url":"https://github.com/linkedin/gobblin/pull/585.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/585","number":585,"state":"open","locked":false,"title":"Emit events on container status changes","user":{"login":"abti","id":69499,"avatar_url":"https://avatars.githubusercontent.com/u/69499?v=3","gravatar_id":"","url":"https://api.github.com/users/abti","html_url":"https://github.com/abti","followers_url":"https://api.github.com/users/abti/followers","following_url":"https://api.github.com/users/abti/following{/other_user}","gists_url":"https://api.github.com/users/abti/gists{/gist_id}","starred_url":"https://api.github.com/users/abti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abti/subscriptions","organizations_url":"https://api.github.com/users/abti/orgs","repos_url":"https://api.github.com/users/abti/repos","events_url":"https://api.github.com/users/abti/events{/privacy}","received_events_url":"https://api.github.com/users/abti/received_events","type":"User","site_admin":false},"body":"Summary on changes:\r\n\r\n- Added code to emit events on container changes (when notified via callbacks in AMRMClientCallback and NMClientCallback)\r\n- Refactored code to introduce common standard for tags in metric context","created_at":"2016-01-06T00:31:53Z","updated_at":"2016-01-06T00:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"953b37c699e36729ea9c73d5ee0d635a1be57116","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/585/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/585/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/585/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/106d1b0e33cb25638cfe250d316bdf06184674c9","head":{"label":"abti:master","ref":"master","sha":"106d1b0e33cb25638cfe250d316bdf06184674c9","user":{"login":"abti","id":69499,"avatar_url":"https://avatars.githubusercontent.com/u/69499?v=3","gravatar_id":"","url":"https://api.github.com/users/abti","html_url":"https://github.com/abti","followers_url":"https://api.github.com/users/abti/followers","following_url":"https://api.github.com/users/abti/following{/other_user}","gists_url":"https://api.github.com/users/abti/gists{/gist_id}","starred_url":"https://api.github.com/users/abti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abti/subscriptions","organizations_url":"https://api.github.com/users/abti/orgs","repos_url":"https://api.github.com/users/abti/repos","events_url":"https://api.github.com/users/abti/events{/privacy}","received_events_url":"https://api.github.com/users/abti/received_events","type":"User","site_admin":false},"repo":{"id":42212016,"name":"gobblin","full_name":"abti/gobblin","owner":{"login":"abti","id":69499,"avatar_url":"https://avatars.githubusercontent.com/u/69499?v=3","gravatar_id":"","url":"https://api.github.com/users/abti","html_url":"https://github.com/abti","followers_url":"https://api.github.com/users/abti/followers","following_url":"https://api.github.com/users/abti/following{/other_user}","gists_url":"https://api.github.com/users/abti/gists{/gist_id}","starred_url":"https://api.github.com/users/abti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abti/subscriptions","organizations_url":"https://api.github.com/users/abti/orgs","repos_url":"https://api.github.com/users/abti/repos","events_url":"https://api.github.com/users/abti/events{/privacy}","received_events_url":"https://api.github.com/users/abti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abti/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":true,"url":"https://api.github.com/repos/abti/gobblin","forks_url":"https://api.github.com/repos/abti/gobblin/forks","keys_url":"https://api.github.com/repos/abti/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abti/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abti/gobblin/teams","hooks_url":"https://api.github.com/repos/abti/gobblin/hooks","issue_events_url":"https://api.github.com/repos/abti/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/abti/gobblin/events","assignees_url":"https://api.github.com/repos/abti/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/abti/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/abti/gobblin/tags","blobs_url":"https://api.github.com/repos/abti/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abti/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abti/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abti/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abti/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/abti/gobblin/languages","stargazers_url":"https://api.github.com/repos/abti/gobblin/stargazers","contributors_url":"https://api.github.com/repos/abti/gobblin/contributors","subscribers_url":"https://api.github.com/repos/abti/gobblin/subscribers","subscription_url":"https://api.github.com/repos/abti/gobblin/subscription","commits_url":"https://api.github.com/repos/abti/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abti/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abti/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abti/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abti/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/abti/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abti/gobblin/merges","archive_url":"https://api.github.com/repos/abti/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abti/gobblin/downloads","issues_url":"https://api.github.com/repos/abti/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/abti/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/abti/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/abti/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abti/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/abti/gobblin/releases{/id}","created_at":"2015-09-10T00:25:20Z","updated_at":"2015-09-10T00:25:21Z","pushed_at":"2016-01-06T00:28:56Z","git_url":"git://github.com/abti/gobblin.git","ssh_url":"git@github.com:abti/gobblin.git","clone_url":"https://github.com/abti/gobblin.git","svn_url":"https://github.com/abti/gobblin","homepage":"","size":81911,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"9b51e9b4c811ee19b99537385f5614ce70853b07","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","created_at":"2014-12-01T18:10:50Z","updated_at":"2016-01-05T20:49:51Z","pushed_at":"2016-01-06T00:31:53Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":159735,"stargazers_count":353,"watchers_count":353,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":140,"mirror_url":null,"open_issues_count":36,"forks":140,"open_issues":36,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/585"},"html":{"href":"https://github.com/linkedin/gobblin/pull/585"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/585"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/106d1b0e33cb25638cfe250d316bdf06184674c9"}}}}