{"action":"created","comment":{"url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/comments/68655591","id":68655591,"diff_hunk":"@@ -0,0 +1,77 @@\n+app.directive('addGraph', function($http) {\n+    return {\n+        restrict: 'E',\n+        templateUrl: 'js/common/directives/graphs/add-graph.directive.html',\n+        scope: {\n+            data: \"=\",\n+            info: \"=\",\n+            columns: \"=\"\n+        },\n+        link: function(scope, ele, attrs) {\n+\n+        \tfunction validateNumber(col) {\n+        \t\tlet numArray = [];\n+        \t\tfor (let i=0; i < scope.data.length; i++) {\n+        \t\t\tif (i === 10) break;\n+        \t\t\telse {\n+        \t\t\t\tif (!isNaN(scope.data[i][col.name])) numArray.push(scope.data[i]);\n+        \t\t\t}\n+        \t\t}\n+        \t\treturn numArray.length > 0 ? true : false;","path":"browser/js/common/directives/graphs/add-graph.directive.js","position":20,"original_position":20,"commit_id":"1653b4997b0949ca50ceb03e3a2ef175d65138f8","original_commit_id":"1653b4997b0949ca50ceb03e3a2ef175d65138f8","user":{"login":"omriBernstein","id":1399417,"avatar_url":"https://avatars.githubusercontent.com/u/1399417?v=3","gravatar_id":"","url":"https://api.github.com/users/omriBernstein","html_url":"https://github.com/omriBernstein","followers_url":"https://api.github.com/users/omriBernstein/followers","following_url":"https://api.github.com/users/omriBernstein/following{/other_user}","gists_url":"https://api.github.com/users/omriBernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/omriBernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omriBernstein/subscriptions","organizations_url":"https://api.github.com/users/omriBernstein/orgs","repos_url":"https://api.github.com/users/omriBernstein/repos","events_url":"https://api.github.com/users/omriBernstein/events{/privacy}","received_events_url":"https://api.github.com/users/omriBernstein/received_events","type":"User","site_admin":false},"body":"Could just `return numArray.length > 0`, no need for ternary operator.","created_at":"2016-06-27T21:01:58Z","updated_at":"2016-06-27T21:01:58Z","html_url":"https://github.com/jonperrelle/Google_Graphs/pull/45#discussion_r68655591","pull_request_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/comments/68655591"},"html":{"href":"https://github.com/jonperrelle/Google_Graphs/pull/45#discussion_r68655591"},"pull_request":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45","id":75375176,"html_url":"https://github.com/jonperrelle/Google_Graphs/pull/45","diff_url":"https://github.com/jonperrelle/Google_Graphs/pull/45.diff","patch_url":"https://github.com/jonperrelle/Google_Graphs/pull/45.patch","issue_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/45","number":45,"state":"open","locked":false,"title":"Line graph","user":{"login":"jonperrelle","id":15789641,"avatar_url":"https://avatars.githubusercontent.com/u/15789641?v=3","gravatar_id":"","url":"https://api.github.com/users/jonperrelle","html_url":"https://github.com/jonperrelle","followers_url":"https://api.github.com/users/jonperrelle/followers","following_url":"https://api.github.com/users/jonperrelle/following{/other_user}","gists_url":"https://api.github.com/users/jonperrelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonperrelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonperrelle/subscriptions","organizations_url":"https://api.github.com/users/jonperrelle/orgs","repos_url":"https://api.github.com/users/jonperrelle/repos","events_url":"https://api.github.com/users/jonperrelle/events{/privacy}","received_events_url":"https://api.github.com/users/jonperrelle/received_events","type":"User","site_admin":false},"body":"@omriBernstein ","created_at":"2016-06-27T20:33:29Z","updated_at":"2016-06-27T21:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"559dfa9bf2e9a496d82b5fe04d4d22fe6e525ca6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45/commits","review_comments_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45/comments","review_comment_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/45/comments","statuses_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/statuses/1653b4997b0949ca50ceb03e3a2ef175d65138f8","head":{"label":"jonperrelle:lineGraph","ref":"lineGraph","sha":"1653b4997b0949ca50ceb03e3a2ef175d65138f8","user":{"login":"jonperrelle","id":15789641,"avatar_url":"https://avatars.githubusercontent.com/u/15789641?v=3","gravatar_id":"","url":"https://api.github.com/users/jonperrelle","html_url":"https://github.com/jonperrelle","followers_url":"https://api.github.com/users/jonperrelle/followers","following_url":"https://api.github.com/users/jonperrelle/following{/other_user}","gists_url":"https://api.github.com/users/jonperrelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonperrelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonperrelle/subscriptions","organizations_url":"https://api.github.com/users/jonperrelle/orgs","repos_url":"https://api.github.com/users/jonperrelle/repos","events_url":"https://api.github.com/users/jonperrelle/events{/privacy}","received_events_url":"https://api.github.com/users/jonperrelle/received_events","type":"User","site_admin":false},"repo":{"id":61752686,"name":"Google_Graphs","full_name":"jonperrelle/Google_Graphs","owner":{"login":"jonperrelle","id":15789641,"avatar_url":"https://avatars.githubusercontent.com/u/15789641?v=3","gravatar_id":"","url":"https://api.github.com/users/jonperrelle","html_url":"https://github.com/jonperrelle","followers_url":"https://api.github.com/users/jonperrelle/followers","following_url":"https://api.github.com/users/jonperrelle/following{/other_user}","gists_url":"https://api.github.com/users/jonperrelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonperrelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonperrelle/subscriptions","organizations_url":"https://api.github.com/users/jonperrelle/orgs","repos_url":"https://api.github.com/users/jonperrelle/repos","events_url":"https://api.github.com/users/jonperrelle/events{/privacy}","received_events_url":"https://api.github.com/users/jonperrelle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonperrelle/Google_Graphs","description":"","fork":false,"url":"https://api.github.com/repos/jonperrelle/Google_Graphs","forks_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/forks","keys_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/teams","hooks_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/hooks","issue_events_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/events{/number}","events_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/events","assignees_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/assignees{/user}","branches_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/branches{/branch}","tags_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/tags","blobs_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/statuses/{sha}","languages_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/languages","stargazers_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/stargazers","contributors_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/contributors","subscribers_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/subscribers","subscription_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/subscription","commits_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/contents/{+path}","compare_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/merges","archive_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/downloads","issues_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues{/number}","pulls_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls{/number}","milestones_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/milestones{/number}","notifications_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/labels{/name}","releases_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/releases{/id}","deployments_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/deployments","created_at":"2016-06-22T21:28:20Z","updated_at":"2016-06-22T21:30:18Z","pushed_at":"2016-06-27T20:45:45Z","git_url":"git://github.com/jonperrelle/Google_Graphs.git","ssh_url":"git@github.com:jonperrelle/Google_Graphs.git","clone_url":"https://github.com/jonperrelle/Google_Graphs.git","svn_url":"https://github.com/jonperrelle/Google_Graphs","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":0,"default_branch":"master"}},"base":{"label":"jonperrelle:master","ref":"master","sha":"0b29aec5373a77cdcb961bf8d3922a826faa6bca","user":{"login":"jonperrelle","id":15789641,"avatar_url":"https://avatars.githubusercontent.com/u/15789641?v=3","gravatar_id":"","url":"https://api.github.com/users/jonperrelle","html_url":"https://github.com/jonperrelle","followers_url":"https://api.github.com/users/jonperrelle/followers","following_url":"https://api.github.com/users/jonperrelle/following{/other_user}","gists_url":"https://api.github.com/users/jonperrelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonperrelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonperrelle/subscriptions","organizations_url":"https://api.github.com/users/jonperrelle/orgs","repos_url":"https://api.github.com/users/jonperrelle/repos","events_url":"https://api.github.com/users/jonperrelle/events{/privacy}","received_events_url":"https://api.github.com/users/jonperrelle/received_events","type":"User","site_admin":false},"repo":{"id":61752686,"name":"Google_Graphs","full_name":"jonperrelle/Google_Graphs","owner":{"login":"jonperrelle","id":15789641,"avatar_url":"https://avatars.githubusercontent.com/u/15789641?v=3","gravatar_id":"","url":"https://api.github.com/users/jonperrelle","html_url":"https://github.com/jonperrelle","followers_url":"https://api.github.com/users/jonperrelle/followers","following_url":"https://api.github.com/users/jonperrelle/following{/other_user}","gists_url":"https://api.github.com/users/jonperrelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonperrelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonperrelle/subscriptions","organizations_url":"https://api.github.com/users/jonperrelle/orgs","repos_url":"https://api.github.com/users/jonperrelle/repos","events_url":"https://api.github.com/users/jonperrelle/events{/privacy}","received_events_url":"https://api.github.com/users/jonperrelle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonperrelle/Google_Graphs","description":"","fork":false,"url":"https://api.github.com/repos/jonperrelle/Google_Graphs","forks_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/forks","keys_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/teams","hooks_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/hooks","issue_events_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/events{/number}","events_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/events","assignees_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/assignees{/user}","branches_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/branches{/branch}","tags_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/tags","blobs_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/statuses/{sha}","languages_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/languages","stargazers_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/stargazers","contributors_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/contributors","subscribers_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/subscribers","subscription_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/subscription","commits_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/contents/{+path}","compare_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/merges","archive_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/downloads","issues_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues{/number}","pulls_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls{/number}","milestones_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/milestones{/number}","notifications_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/labels{/name}","releases_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/releases{/id}","deployments_url":"https://api.github.com/repos/jonperrelle/Google_Graphs/deployments","created_at":"2016-06-22T21:28:20Z","updated_at":"2016-06-22T21:30:18Z","pushed_at":"2016-06-27T20:45:45Z","git_url":"git://github.com/jonperrelle/Google_Graphs.git","ssh_url":"git@github.com:jonperrelle/Google_Graphs.git","clone_url":"https://github.com/jonperrelle/Google_Graphs.git","svn_url":"https://github.com/jonperrelle/Google_Graphs","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45"},"html":{"href":"https://github.com/jonperrelle/Google_Graphs/pull/45"},"issue":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/45"},"comments":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/jonperrelle/Google_Graphs/statuses/1653b4997b0949ca50ceb03e3a2ef175d65138f8"}}}}
{"actor":{"display_login":"omriBernstein"}}