{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/verify-frontend/issues/201","repository_url":"https://api.github.com/repos/alphagov/verify-frontend","labels_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/201/comments","events_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/201/events","html_url":"https://github.com/alphagov/verify-frontend/pull/201","id":171464772,"number":201,"title":"Upgrade to Rails 5","user":{"login":"chrisholmes","id":799295,"avatar_url":"https://avatars.githubusercontent.com/u/799295?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisholmes","html_url":"https://github.com/chrisholmes","followers_url":"https://api.github.com/users/chrisholmes/followers","following_url":"https://api.github.com/users/chrisholmes/following{/other_user}","gists_url":"https://api.github.com/users/chrisholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisholmes/subscriptions","organizations_url":"https://api.github.com/users/chrisholmes/orgs","repos_url":"https://api.github.com/users/chrisholmes/repos","events_url":"https://api.github.com/users/chrisholmes/events{/privacy}","received_events_url":"https://api.github.com/users/chrisholmes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-16T16:52:53Z","updated_at":"2016-09-01T10:58:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/verify-frontend/pulls/201","html_url":"https://github.com/alphagov/verify-frontend/pull/201","diff_url":"https://github.com/alphagov/verify-frontend/pull/201.diff","patch_url":"https://github.com/alphagov/verify-frontend/pull/201.patch"},"body":"This should provide a working version of the FE under Rails 5 with minimal deprecation warnings\r\n\r\nMost of the changes are contained within a single purpose commit message where the majority of changes were made to remove deprecation warnings.\r\n\r\nOne of the significant changes is that the stub api app has been isolated into its own directly and no longer shares a Gemfile with the FE. This was required as the Sinatra dependency of the stub has its own dependencies that conflict with the FE and Rails. It also provides us with a stricter separation of concerns which is lovely.\r\n\r\nOne change aside from basic renaming is that we have to use #add (which is additive) in place of #set (which replaces) when there are validation errors. I'm confident that our unit tests for ours validations are strong enough that this won't produce any funky behaviour.\r\n\r\nWe've switched our jasmine library because jasmine-rails was producing a lot of\r\ndeprecation warnings on rails 5. The new jasmine gem is maintained by the jasmine team\r\nso this is probably the better long term option for updates/upgrades.\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/verify-frontend/issues/comments/244045518","html_url":"https://github.com/alphagov/verify-frontend/pull/201#issuecomment-244045518","issue_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/201","id":244045518,"user":{"login":"chrisholmes","id":799295,"avatar_url":"https://avatars.githubusercontent.com/u/799295?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisholmes","html_url":"https://github.com/chrisholmes","followers_url":"https://api.github.com/users/chrisholmes/followers","following_url":"https://api.github.com/users/chrisholmes/following{/other_user}","gists_url":"https://api.github.com/users/chrisholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisholmes/subscriptions","organizations_url":"https://api.github.com/users/chrisholmes/orgs","repos_url":"https://api.github.com/users/chrisholmes/repos","events_url":"https://api.github.com/users/chrisholmes/events{/privacy}","received_events_url":"https://api.github.com/users/chrisholmes/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T10:58:09Z","updated_at":"2016-09-01T10:58:09Z","body":"Those should have been removed with the jasmine change. \r\n\r\nCan you check that you're running the latest version of the branch and report back?"}}
{"actor":{"display_login":"chrisholmes"}}