{"action":"created","comment":{"url":"https://api.github.com/repos/obiba/mica2/pulls/comments/81397133","pull_request_review_id":2379124,"id":81397133,"diff_hunk":"@@ -52,15 +52,25 @@ public AsyncUncaughtExceptionHandler getAsyncUncaughtExceptionHandler() {\n     return new SimpleAsyncUncaughtExceptionHandler();\n   }\n \n-  @Bean\n   @Override\n+  @Bean\n   public Executor getAsyncExecutor() {\n-    log.debug(\"Creating Async Task Executor\");\n     ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();\n     executor.setCorePoolSize(propertyResolver.getProperty(\"corePoolSize\", Integer.class, DEFAULT_POOL_SIZE));\n     executor.setMaxPoolSize(propertyResolver.getProperty(\"maxPoolSize\", Integer.class, DEFAULT_MAX_POOL_SIZE));\n     executor.setQueueCapacity(propertyResolver.getProperty(\"queueCapacity\", Integer.class, DEFAULT_QUEUE_CAPACITY));\n     executor.setThreadNamePrefix(\"mica-executor-\");\n     return new ExceptionHandlingAsyncTaskExecutor(executor);\n   }\n+\n+  @Bean(name=\"opalExecutor\")\n+  public Executor getOpalAsyncExecutor() {\n+    log.debug(\"Creating Async Task Executor\");\n+    ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();\n+    executor.setCorePoolSize(propertyResolver.getProperty(\"opal.corePoolSize\", Integer.class, DEFAULT_POOL_SIZE));\n+    executor.setMaxPoolSize(propertyResolver.getProperty(\"opal.maxPoolSize\", Integer.class, DEFAULT_MAX_POOL_SIZE));\n+    executor.setQueueCapacity(propertyResolver.getProperty(\"queueCapacity\", Integer.class, DEFAULT_QUEUE_CAPACITY));\n+    executor.setThreadNamePrefix(\"mica-opal-executor-\");\n+    return new ExceptionHandlingAsyncTaskExecutor(executor);","path":"mica-core/src/main/java/org/obiba/mica/config/AsyncConfiguration.java","position":55,"original_position":55,"commit_id":"203dbd830760bdcefc1a8ade47c07ddd51aeb4ce","original_commit_id":"88766fc02adb8b119361e04ab416480d12873fba","user":{"login":"firone","id":1081187,"avatar_url":"https://avatars.githubusercontent.com/u/1081187?v=3","gravatar_id":"","url":"https://api.github.com/users/firone","html_url":"https://github.com/firone","followers_url":"https://api.github.com/users/firone/followers","following_url":"https://api.github.com/users/firone/following{/other_user}","gists_url":"https://api.github.com/users/firone/gists{/gist_id}","starred_url":"https://api.github.com/users/firone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firone/subscriptions","organizations_url":"https://api.github.com/users/firone/orgs","repos_url":"https://api.github.com/users/firone/repos","events_url":"https://api.github.com/users/firone/events{/privacy}","received_events_url":"https://api.github.com/users/firone/received_events","type":"User","site_admin":false},"body":"It's dangerous ... We wait that queue is full to add thread and if we add another task before another task is finished, there is an error ...\r\nExecutors.newFixedThreadPool() can be a better solution. We set a fixed number of thread that are already running, si no probleme of queue size.\r\n","created_at":"2016-09-30T18:50:24Z","updated_at":"2016-09-30T18:52:23Z","html_url":"https://github.com/obiba/mica2/pull/1184#discussion_r81397133","pull_request_url":"https://api.github.com/repos/obiba/mica2/pulls/1184","_links":{"self":{"href":"https://api.github.com/repos/obiba/mica2/pulls/comments/81397133"},"html":{"href":"https://github.com/obiba/mica2/pull/1184#discussion_r81397133"},"pull_request":{"href":"https://api.github.com/repos/obiba/mica2/pulls/1184"}}},"pull_request":{"url":"https://api.github.com/repos/obiba/mica2/pulls/1184","id":87538818,"html_url":"https://github.com/obiba/mica2/pull/1184","diff_url":"https://github.com/obiba/mica2/pull/1184.diff","patch_url":"https://github.com/obiba/mica2/pull/1184.patch","issue_url":"https://api.github.com/repos/obiba/mica2/issues/1184","number":1184,"state":"open","locked":false,"title":"Enhancement - modified default thread pool settings to optimize Async…","user":{"login":"kazoompa","id":2814716,"avatar_url":"https://avatars.githubusercontent.com/u/2814716?v=3","gravatar_id":"","url":"https://api.github.com/users/kazoompa","html_url":"https://github.com/kazoompa","followers_url":"https://api.github.com/users/kazoompa/followers","following_url":"https://api.github.com/users/kazoompa/following{/other_user}","gists_url":"https://api.github.com/users/kazoompa/gists{/gist_id}","starred_url":"https://api.github.com/users/kazoompa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazoompa/subscriptions","organizations_url":"https://api.github.com/users/kazoompa/orgs","repos_url":"https://api.github.com/users/kazoompa/repos","events_url":"https://api.github.com/users/kazoompa/events{/privacy}","received_events_url":"https://api.github.com/users/kazoompa/received_events","type":"User","site_admin":false},"body":"… and especially nested Async calls.","created_at":"2016-09-30T18:01:52Z","updated_at":"2016-09-30T18:52:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d547c6d81567da7e84254f44f20566638e1f9c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/obiba/mica2/pulls/1184/commits","review_comments_url":"https://api.github.com/repos/obiba/mica2/pulls/1184/comments","review_comment_url":"https://api.github.com/repos/obiba/mica2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obiba/mica2/issues/1184/comments","statuses_url":"https://api.github.com/repos/obiba/mica2/statuses/203dbd830760bdcefc1a8ade47c07ddd51aeb4ce","head":{"label":"kazoompa:rhaeri-dev","ref":"rhaeri-dev","sha":"203dbd830760bdcefc1a8ade47c07ddd51aeb4ce","user":{"login":"kazoompa","id":2814716,"avatar_url":"https://avatars.githubusercontent.com/u/2814716?v=3","gravatar_id":"","url":"https://api.github.com/users/kazoompa","html_url":"https://github.com/kazoompa","followers_url":"https://api.github.com/users/kazoompa/followers","following_url":"https://api.github.com/users/kazoompa/following{/other_user}","gists_url":"https://api.github.com/users/kazoompa/gists{/gist_id}","starred_url":"https://api.github.com/users/kazoompa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazoompa/subscriptions","organizations_url":"https://api.github.com/users/kazoompa/orgs","repos_url":"https://api.github.com/users/kazoompa/repos","events_url":"https://api.github.com/users/kazoompa/events{/privacy}","received_events_url":"https://api.github.com/users/kazoompa/received_events","type":"User","site_admin":false},"repo":{"id":20693531,"name":"mica2","full_name":"kazoompa/mica2","owner":{"login":"kazoompa","id":2814716,"avatar_url":"https://avatars.githubusercontent.com/u/2814716?v=3","gravatar_id":"","url":"https://api.github.com/users/kazoompa","html_url":"https://github.com/kazoompa","followers_url":"https://api.github.com/users/kazoompa/followers","following_url":"https://api.github.com/users/kazoompa/following{/other_user}","gists_url":"https://api.github.com/users/kazoompa/gists{/gist_id}","starred_url":"https://api.github.com/users/kazoompa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazoompa/subscriptions","organizations_url":"https://api.github.com/users/kazoompa/orgs","repos_url":"https://api.github.com/users/kazoompa/repos","events_url":"https://api.github.com/users/kazoompa/events{/privacy}","received_events_url":"https://api.github.com/users/kazoompa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kazoompa/mica2","description":"","fork":true,"url":"https://api.github.com/repos/kazoompa/mica2","forks_url":"https://api.github.com/repos/kazoompa/mica2/forks","keys_url":"https://api.github.com/repos/kazoompa/mica2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kazoompa/mica2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kazoompa/mica2/teams","hooks_url":"https://api.github.com/repos/kazoompa/mica2/hooks","issue_events_url":"https://api.github.com/repos/kazoompa/mica2/issues/events{/number}","events_url":"https://api.github.com/repos/kazoompa/mica2/events","assignees_url":"https://api.github.com/repos/kazoompa/mica2/assignees{/user}","branches_url":"https://api.github.com/repos/kazoompa/mica2/branches{/branch}","tags_url":"https://api.github.com/repos/kazoompa/mica2/tags","blobs_url":"https://api.github.com/repos/kazoompa/mica2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kazoompa/mica2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kazoompa/mica2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kazoompa/mica2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kazoompa/mica2/statuses/{sha}","languages_url":"https://api.github.com/repos/kazoompa/mica2/languages","stargazers_url":"https://api.github.com/repos/kazoompa/mica2/stargazers","contributors_url":"https://api.github.com/repos/kazoompa/mica2/contributors","subscribers_url":"https://api.github.com/repos/kazoompa/mica2/subscribers","subscription_url":"https://api.github.com/repos/kazoompa/mica2/subscription","commits_url":"https://api.github.com/repos/kazoompa/mica2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kazoompa/mica2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kazoompa/mica2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kazoompa/mica2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kazoompa/mica2/contents/{+path}","compare_url":"https://api.github.com/repos/kazoompa/mica2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kazoompa/mica2/merges","archive_url":"https://api.github.com/repos/kazoompa/mica2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kazoompa/mica2/downloads","issues_url":"https://api.github.com/repos/kazoompa/mica2/issues{/number}","pulls_url":"https://api.github.com/repos/kazoompa/mica2/pulls{/number}","milestones_url":"https://api.github.com/repos/kazoompa/mica2/milestones{/number}","notifications_url":"https://api.github.com/repos/kazoompa/mica2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kazoompa/mica2/labels{/name}","releases_url":"https://api.github.com/repos/kazoompa/mica2/releases{/id}","deployments_url":"https://api.github.com/repos/kazoompa/mica2/deployments","created_at":"2014-06-10T16:52:17Z","updated_at":"2016-01-11T20:50:47Z","pushed_at":"2016-09-30T18:43:57Z","git_url":"git://github.com/kazoompa/mica2.git","ssh_url":"git@github.com:kazoompa/mica2.git","clone_url":"https://github.com/kazoompa/mica2.git","svn_url":"https://github.com/kazoompa/mica2","homepage":null,"size":50263,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"obiba:master","ref":"master","sha":"116764ab6336b9bcf72385c0869ed93170faa4b1","user":{"login":"obiba","id":2547522,"avatar_url":"https://avatars.githubusercontent.com/u/2547522?v=3","gravatar_id":"","url":"https://api.github.com/users/obiba","html_url":"https://github.com/obiba","followers_url":"https://api.github.com/users/obiba/followers","following_url":"https://api.github.com/users/obiba/following{/other_user}","gists_url":"https://api.github.com/users/obiba/gists{/gist_id}","starred_url":"https://api.github.com/users/obiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiba/subscriptions","organizations_url":"https://api.github.com/users/obiba/orgs","repos_url":"https://api.github.com/users/obiba/repos","events_url":"https://api.github.com/users/obiba/events{/privacy}","received_events_url":"https://api.github.com/users/obiba/received_events","type":"Organization","site_admin":false},"repo":{"id":18178675,"name":"mica2","full_name":"obiba/mica2","owner":{"login":"obiba","id":2547522,"avatar_url":"https://avatars.githubusercontent.com/u/2547522?v=3","gravatar_id":"","url":"https://api.github.com/users/obiba","html_url":"https://github.com/obiba","followers_url":"https://api.github.com/users/obiba/followers","following_url":"https://api.github.com/users/obiba/following{/other_user}","gists_url":"https://api.github.com/users/obiba/gists{/gist_id}","starred_url":"https://api.github.com/users/obiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiba/subscriptions","organizations_url":"https://api.github.com/users/obiba/orgs","repos_url":"https://api.github.com/users/obiba/repos","events_url":"https://api.github.com/users/obiba/events{/privacy}","received_events_url":"https://api.github.com/users/obiba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obiba/mica2","description":"Mica is a web portal for epidemiological study consortia.","fork":false,"url":"https://api.github.com/repos/obiba/mica2","forks_url":"https://api.github.com/repos/obiba/mica2/forks","keys_url":"https://api.github.com/repos/obiba/mica2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obiba/mica2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obiba/mica2/teams","hooks_url":"https://api.github.com/repos/obiba/mica2/hooks","issue_events_url":"https://api.github.com/repos/obiba/mica2/issues/events{/number}","events_url":"https://api.github.com/repos/obiba/mica2/events","assignees_url":"https://api.github.com/repos/obiba/mica2/assignees{/user}","branches_url":"https://api.github.com/repos/obiba/mica2/branches{/branch}","tags_url":"https://api.github.com/repos/obiba/mica2/tags","blobs_url":"https://api.github.com/repos/obiba/mica2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obiba/mica2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obiba/mica2/git/refs{/sha}","trees_url":"https://api.github.com/repos/obiba/mica2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obiba/mica2/statuses/{sha}","languages_url":"https://api.github.com/repos/obiba/mica2/languages","stargazers_url":"https://api.github.com/repos/obiba/mica2/stargazers","contributors_url":"https://api.github.com/repos/obiba/mica2/contributors","subscribers_url":"https://api.github.com/repos/obiba/mica2/subscribers","subscription_url":"https://api.github.com/repos/obiba/mica2/subscription","commits_url":"https://api.github.com/repos/obiba/mica2/commits{/sha}","git_commits_url":"https://api.github.com/repos/obiba/mica2/git/commits{/sha}","comments_url":"https://api.github.com/repos/obiba/mica2/comments{/number}","issue_comment_url":"https://api.github.com/repos/obiba/mica2/issues/comments{/number}","contents_url":"https://api.github.com/repos/obiba/mica2/contents/{+path}","compare_url":"https://api.github.com/repos/obiba/mica2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obiba/mica2/merges","archive_url":"https://api.github.com/repos/obiba/mica2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obiba/mica2/downloads","issues_url":"https://api.github.com/repos/obiba/mica2/issues{/number}","pulls_url":"https://api.github.com/repos/obiba/mica2/pulls{/number}","milestones_url":"https://api.github.com/repos/obiba/mica2/milestones{/number}","notifications_url":"https://api.github.com/repos/obiba/mica2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obiba/mica2/labels{/name}","releases_url":"https://api.github.com/repos/obiba/mica2/releases{/id}","deployments_url":"https://api.github.com/repos/obiba/mica2/deployments","created_at":"2014-03-27T14:29:14Z","updated_at":"2016-01-12T15:56:42Z","pushed_at":"2016-09-30T18:43:57Z","git_url":"git://github.com/obiba/mica2.git","ssh_url":"git@github.com:obiba/mica2.git","clone_url":"https://github.com/obiba/mica2.git","svn_url":"https://github.com/obiba/mica2","homepage":"http://www.obiba.org/pages/products/mica/","size":50845,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obiba/mica2/pulls/1184"},"html":{"href":"https://github.com/obiba/mica2/pull/1184"},"issue":{"href":"https://api.github.com/repos/obiba/mica2/issues/1184"},"comments":{"href":"https://api.github.com/repos/obiba/mica2/issues/1184/comments"},"review_comments":{"href":"https://api.github.com/repos/obiba/mica2/pulls/1184/comments"},"review_comment":{"href":"https://api.github.com/repos/obiba/mica2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obiba/mica2/pulls/1184/commits"},"statuses":{"href":"https://api.github.com/repos/obiba/mica2/statuses/203dbd830760bdcefc1a8ade47c07ddd51aeb4ce"}}}}
{"actor":{"display_login":"firone"}}