{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/elide/pulls/comments/48770581","id":48770581,"diff_hunk":"@@ -0,0 +1,22 @@\n+/*\n+ * Copyright 2015, Yahoo Inc.\n+ * Licensed under the Apache License, Version 2.0\n+ * See LICENSE file in project root for terms.\n+ */\n+package com.yahoo.elide.security;\n+\n+import lombok.AllArgsConstructor;\n+import lombok.Getter;\n+\n+/**\n+ * ChangeSpec for a particular field.\n+ *\n+ * @param <T> type parameter\n+ */\n+@AllArgsConstructor\n+public class ChangeSpec<T> {\n+    @Getter private final String parentType;","path":"elide-core/src/main/java/com/yahoo/elide/security/ChangeSpec.java","position":18,"original_position":18,"commit_id":"aea0b4a4014d037b193d01f1d9d56c15c8c9b794","original_commit_id":"aea0b4a4014d037b193d01f1d9d56c15c8c9b794","user":{"login":"aklish","id":6979393,"avatar_url":"https://avatars.githubusercontent.com/u/6979393?v=3","gravatar_id":"","url":"https://api.github.com/users/aklish","html_url":"https://github.com/aklish","followers_url":"https://api.github.com/users/aklish/followers","following_url":"https://api.github.com/users/aklish/following{/other_user}","gists_url":"https://api.github.com/users/aklish/gists{/gist_id}","starred_url":"https://api.github.com/users/aklish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aklish/subscriptions","organizations_url":"https://api.github.com/users/aklish/orgs","repos_url":"https://api.github.com/users/aklish/repos","events_url":"https://api.github.com/users/aklish/events{/privacy}","received_events_url":"https://api.github.com/users/aklish/received_events","type":"User","site_admin":false},"body":"Why do we need this?  If it is a type, why is it a String?","created_at":"2016-01-04T19:36:17Z","updated_at":"2016-01-04T19:36:17Z","html_url":"https://github.com/yahoo/elide/pull/94#discussion_r48770581","pull_request_url":"https://api.github.com/repos/yahoo/elide/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments/48770581"},"html":{"href":"https://github.com/yahoo/elide/pull/94#discussion_r48770581"},"pull_request":{"href":"https://api.github.com/repos/yahoo/elide/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/elide/pulls/94","id":54691752,"html_url":"https://github.com/yahoo/elide/pull/94","diff_url":"https://github.com/yahoo/elide/pull/94.diff","patch_url":"https://github.com/yahoo/elide/pull/94.patch","issue_url":"https://api.github.com/repos/yahoo/elide/issues/94","number":94,"state":"open","locked":false,"title":"Security Revamp","user":{"login":"DeathByTape","id":732305,"avatar_url":"https://avatars.githubusercontent.com/u/732305?v=3","gravatar_id":"","url":"https://api.github.com/users/DeathByTape","html_url":"https://github.com/DeathByTape","followers_url":"https://api.github.com/users/DeathByTape/followers","following_url":"https://api.github.com/users/DeathByTape/following{/other_user}","gists_url":"https://api.github.com/users/DeathByTape/gists{/gist_id}","starred_url":"https://api.github.com/users/DeathByTape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeathByTape/subscriptions","organizations_url":"https://api.github.com/users/DeathByTape/orgs","repos_url":"https://api.github.com/users/DeathByTape/repos","events_url":"https://api.github.com/users/DeathByTape/events{/privacy}","received_events_url":"https://api.github.com/users/DeathByTape/received_events","type":"User","site_admin":false},"body":"This is the first PR for the security revamp discussed here: https://github.com/yahoo/elide/issues/84. This reworks the code into the new proposed structure.\r\n\r\n**NOTE:** This PR is still missing the actual calculation of Changesets (i.e. they're always null still in this code). I will work that into a different PR.","created_at":"2015-12-28T23:27:12Z","updated_at":"2016-01-04T19:36:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d42531e372f3fe7d3998be275d916e1b7304556","assignee":null,"milestone":{"url":"https://api.github.com/repos/yahoo/elide/milestones/1","html_url":"https://github.com/yahoo/elide/milestones/elide-2.0","labels_url":"https://api.github.com/repos/yahoo/elide/milestones/1/labels","id":1460147,"number":1,"title":"elide-2.0","description":null,"creator":{"login":"DeathByTape","id":732305,"avatar_url":"https://avatars.githubusercontent.com/u/732305?v=3","gravatar_id":"","url":"https://api.github.com/users/DeathByTape","html_url":"https://github.com/DeathByTape","followers_url":"https://api.github.com/users/DeathByTape/followers","following_url":"https://api.github.com/users/DeathByTape/following{/other_user}","gists_url":"https://api.github.com/users/DeathByTape/gists{/gist_id}","starred_url":"https://api.github.com/users/DeathByTape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeathByTape/subscriptions","organizations_url":"https://api.github.com/users/DeathByTape/orgs","repos_url":"https://api.github.com/users/DeathByTape/repos","events_url":"https://api.github.com/users/DeathByTape/events{/privacy}","received_events_url":"https://api.github.com/users/DeathByTape/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2015-12-14T21:01:40Z","updated_at":"2015-12-29T16:06:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/yahoo/elide/pulls/94/commits","review_comments_url":"https://api.github.com/repos/yahoo/elide/pulls/94/comments","review_comment_url":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/elide/issues/94/comments","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/aea0b4a4014d037b193d01f1d9d56c15c8c9b794","head":{"label":"yahoo:securityRevamp","ref":"securityRevamp","sha":"aea0b4a4014d037b193d01f1d9d56c15c8c9b794","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","created_at":"2015-10-12T17:55:01Z","updated_at":"2016-01-04T09:52:13Z","pushed_at":"2016-01-04T16:47:44Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":892,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":49,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"8f04bfe4f04a275e63b00d8b6b6c665540cd6585","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","created_at":"2015-10-12T17:55:01Z","updated_at":"2016-01-04T09:52:13Z","pushed_at":"2016-01-04T16:47:44Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":892,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/94"},"html":{"href":"https://github.com/yahoo/elide/pull/94"},"issue":{"href":"https://api.github.com/repos/yahoo/elide/issues/94"},"comments":{"href":"https://api.github.com/repos/yahoo/elide/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/elide/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/elide/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/elide/statuses/aea0b4a4014d037b193d01f1d9d56c15c8c9b794"}}}}