{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/comments/62598998","id":62598998,"diff_hunk":"@@ -164,12 +164,12 @@ achieve this we must first create an instance of the Connector object.\n The constructor of the Connector class is defined as:\n \n ```\n-    Connector(const std::string& broker_ws_uri,\n-              const std::string& client_type,\n-              const std::string& ca_crt_path,\n-              const std::string& client_crt_path,\n-              const std::string& client_key_path,\n-              const long& connection_timeout = 5000)","path":"README.md","position":9,"original_position":9,"commit_id":"1ea5c3a8a15ba9a7ff78ed131892ab4e7439fcdf","original_commit_id":"1ea5c3a8a15ba9a7ff78ed131892ab4e7439fcdf","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"This is long because websocketpp uses long :( I guess I'll have to go back to longs.","created_at":"2016-05-10T01:07:46Z","updated_at":"2016-05-10T01:07:46Z","html_url":"https://github.com/puppetlabs/cpp-pcp-client/pull/162#discussion_r62598998","pull_request_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/comments/62598998"},"html":{"href":"https://github.com/puppetlabs/cpp-pcp-client/pull/162#discussion_r62598998"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162","id":69191092,"html_url":"https://github.com/puppetlabs/cpp-pcp-client/pull/162","diff_url":"https://github.com/puppetlabs/cpp-pcp-client/pull/162.diff","patch_url":"https://github.com/puppetlabs/cpp-pcp-client/pull/162.patch","issue_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/issues/162","number":162,"state":"open","locked":false,"title":"(maint) C++ Style Cleanup","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"## (maint) Default to pass constructor arguments by value\r\n\r\nWhen passing arguments to a constructor that will be stored directly\r\ninto the object, pass by value. This allows move semantics while not\r\nincurring any overhead if we need to create a copy (the copy will be\r\ncreated on constructor invocation rather than in the constructor). This\r\nrequires that the argument is then `std::move`d into the object storage.\r\n\r\nIn most other cases, preserve pass-by-reference.\r\n\r\nSee\r\nhttps://github.com/puppetlabs/cppbestpractices/blob/master/03-FAQ.md#q-arguments-and-return-types-in-class-methods\r\n\r\n## (maint) Prefer enum classes\r\n\r\nUse an enum rather than the more complicated `namespace { enum };\r\nusing` pattern. Add a comment when that pattern's still needed.\r\n\r\n## (maint) Ban long integers\r\n\r\nLong integers (`long`) are not portable. On 32-bit platforms, `long` is\r\n4 bytes. On LP64 platforms, `long` is 8 bytes, while on LLP64 platforms,\r\n`long` is 4 bytes. Don't use `long`.\r\n\r\nReplace `long` with `int64_t` so this isn't a breaking change; `long`\r\nwill safely implicitly cast to `int64_t` on all platforms. `size_t`\r\nwould also have worked, but in most cases we prefer to represent time as\r\na 64-bit integer.","created_at":"2016-05-06T18:30:06Z","updated_at":"2016-05-10T01:07:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ca3168446e1ae01a2e0b037c44790a734a6771d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/issues/162/comments","statuses_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/statuses/1ea5c3a8a15ba9a7ff78ed131892ab4e7439fcdf","head":{"label":"MikaelSmith:cpp-cleanup","ref":"cpp-cleanup","sha":"1ea5c3a8a15ba9a7ff78ed131892ab4e7439fcdf","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":44123857,"name":"cpp-pcp-client","full_name":"MikaelSmith/cpp-pcp-client","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/cpp-pcp-client","description":"Client libraries for the PCP protocol","fork":true,"url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client","forks_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/forks","keys_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/events","assignees_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/merges","archive_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/releases{/id}","deployments_url":"https://api.github.com/repos/MikaelSmith/cpp-pcp-client/deployments","created_at":"2015-10-12T17:46:33Z","updated_at":"2016-02-05T17:55:22Z","pushed_at":"2016-05-10T00:49:32Z","git_url":"git://github.com/MikaelSmith/cpp-pcp-client.git","ssh_url":"git@github.com:MikaelSmith/cpp-pcp-client.git","clone_url":"https://github.com/MikaelSmith/cpp-pcp-client.git","svn_url":"https://github.com/MikaelSmith/cpp-pcp-client","homepage":"","size":9826,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"c07a39fa927812155361bf3ef59ca0a26778e36f","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23116824,"name":"cpp-pcp-client","full_name":"puppetlabs/cpp-pcp-client","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/cpp-pcp-client","description":"Client libraries for the PCP protocol","fork":false,"url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client","forks_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/forks","keys_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/teams","hooks_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/events","assignees_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/tags","blobs_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/subscription","commits_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/merges","archive_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/downloads","issues_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/deployments","created_at":"2014-08-19T16:12:35Z","updated_at":"2016-01-19T18:14:48Z","pushed_at":"2016-05-10T00:49:32Z","git_url":"git://github.com/puppetlabs/cpp-pcp-client.git","ssh_url":"git@github.com:puppetlabs/cpp-pcp-client.git","clone_url":"https://github.com/puppetlabs/cpp-pcp-client.git","svn_url":"https://github.com/puppetlabs/cpp-pcp-client","homepage":"","size":8974,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162"},"html":{"href":"https://github.com/puppetlabs/cpp-pcp-client/pull/162"},"issue":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/issues/162"},"comments":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/cpp-pcp-client/statuses/1ea5c3a8a15ba9a7ff78ed131892ab4e7439fcdf"}}}}