{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/77107375","id":77107375,"diff_hunk":"@@ -1,84 +1,17 @@\n 'use strict';\n \n-var async = require('async');\n var fs = require('fs');\n-var glob = require('glob');\n var grunt = require('grunt');\n var path = require('path');\n \n-var rootPath = path.resolve('.');\n-var buildPath = path.join(rootPath, 'build');\n-var tempConfigPath = path.join(buildPath, 'jest-config.json');\n-\n-var config = require(path.join(rootPath, 'package.json')).jest;\n-\n-var collectCoverageOnlyFrom = {\n-  'src/**/*.js': {\n-    ignore: [\n-      'src/**/__tests__/*.js',\n-      'src/shared/vendor/third_party/*.js',\n-      'src/test/*.js',\n-    ],\n-  },\n-};\n-\n-function getCollectCoverageOnlyFrom(callback) {\n-  var patterns = Object.keys(collectCoverageOnlyFrom);\n-  var result = {};\n-\n-  async.each(patterns, function(pattern) {\n-    var options = Object.assign({ nodir: true }, collectCoverageOnlyFrom[pattern]);\n-    glob(pattern, options, function(err, files) {\n-      (files || []).reduce(function(object, key) {\n-        object[key] = true;\n-        return object;\n-      }, result);\n-\n-      callback(err);\n-    });\n-  }, function(err) {\n-    callback(err, result);\n-  });\n-}\n-\n-function getJestConfig(callback) {\n-  var rootDir = path.resolve(buildPath, path.resolve(config.rootDir));\n-  getCollectCoverageOnlyFrom(function(err, data) {\n-    callback(err, Object.assign({}, config, {\n-      rootDir: rootDir,\n-      name: 'react',\n-      collectCoverage: true,\n-      collectCoverageOnlyFrom: data,\n-    }));\n-  });\n-}\n-\n-function onError(err) {\n-  grunt.log.error('jest failed');\n-  grunt.log.error(err);\n-}\n-\n-function writeTempConfig(callback) {\n-  getJestConfig(function(err, data) {\n-    if (err) {\n-      callback(err);\n-    } else {\n-      grunt.file.mkdir(buildPath);\n-      fs.writeFile(tempConfigPath, JSON.stringify(data, null, '  '), 'utf8', callback);\n-    }\n-  });\n-}\n-\n-function run(done, configPath) {\n+function run(done, coverage) {\n   grunt.log.writeln('running jest');\n \n   var args = [\n     path.join('node_modules', 'jest', 'bin', 'jest'),\n-    '--runInBand',\n-    '--no-watchman',","path":"grunt/tasks/jest.js","position":79,"original_position":79,"commit_id":"0cf3bac6c9c4bfc60f7c40aaf66d787ccf6dd701","original_commit_id":"0cf3bac6c9c4bfc60f7c40aaf66d787ccf6dd701","user":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"body":"@cpojer told me to try and remove those as jest should be more robust. I'll put them back if they cause issues.","created_at":"2016-09-01T02:53:33Z","updated_at":"2016-09-01T02:53:33Z","html_url":"https://github.com/facebook/react/pull/7628#discussion_r77107375","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/7628","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/77107375"},"html":{"href":"https://github.com/facebook/react/pull/7628#discussion_r77107375"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/7628"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/7628","id":83562447,"html_url":"https://github.com/facebook/react/pull/7628","diff_url":"https://github.com/facebook/react/pull/7628.diff","patch_url":"https://github.com/facebook/react/pull/7628.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/7628","number":7628,"state":"open","locked":false,"title":"Restore coverage in Travis","user":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"body":"We disabled coverage in Travis because the implementation was crashing ( https://github.com/facebook/react/issues/6290 ). Since we upgraded to Jest 15, the entire coverage implementation is brand new so we should give it another try.","created_at":"2016-09-01T02:52:23Z","updated_at":"2016-09-01T02:53:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a73e2660becc7d704eeb91e56c0182dd03dbf06","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/7628/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/7628/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/7628/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/0cf3bac6c9c4bfc60f7c40aaf66d787ccf6dd701","head":{"label":"vjeux:fix_coverage","ref":"fix_coverage","sha":"0cf3bac6c9c4bfc60f7c40aaf66d787ccf6dd701","user":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"repo":{"id":22545610,"name":"react","full_name":"vjeux/react","owner":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjeux/react","description":"React is a JavaScript library for building user interfaces. It's declarative, efficient, and extremely flexible. What's more, it works with the libraries and frameworks that you already know.","fork":true,"url":"https://api.github.com/repos/vjeux/react","forks_url":"https://api.github.com/repos/vjeux/react/forks","keys_url":"https://api.github.com/repos/vjeux/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjeux/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjeux/react/teams","hooks_url":"https://api.github.com/repos/vjeux/react/hooks","issue_events_url":"https://api.github.com/repos/vjeux/react/issues/events{/number}","events_url":"https://api.github.com/repos/vjeux/react/events","assignees_url":"https://api.github.com/repos/vjeux/react/assignees{/user}","branches_url":"https://api.github.com/repos/vjeux/react/branches{/branch}","tags_url":"https://api.github.com/repos/vjeux/react/tags","blobs_url":"https://api.github.com/repos/vjeux/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjeux/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjeux/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjeux/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjeux/react/statuses/{sha}","languages_url":"https://api.github.com/repos/vjeux/react/languages","stargazers_url":"https://api.github.com/repos/vjeux/react/stargazers","contributors_url":"https://api.github.com/repos/vjeux/react/contributors","subscribers_url":"https://api.github.com/repos/vjeux/react/subscribers","subscription_url":"https://api.github.com/repos/vjeux/react/subscription","commits_url":"https://api.github.com/repos/vjeux/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjeux/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjeux/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjeux/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/vjeux/react/contents/{+path}","compare_url":"https://api.github.com/repos/vjeux/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjeux/react/merges","archive_url":"https://api.github.com/repos/vjeux/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjeux/react/downloads","issues_url":"https://api.github.com/repos/vjeux/react/issues{/number}","pulls_url":"https://api.github.com/repos/vjeux/react/pulls{/number}","milestones_url":"https://api.github.com/repos/vjeux/react/milestones{/number}","notifications_url":"https://api.github.com/repos/vjeux/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjeux/react/labels{/name}","releases_url":"https://api.github.com/repos/vjeux/react/releases{/id}","deployments_url":"https://api.github.com/repos/vjeux/react/deployments","created_at":"2014-08-02T12:21:36Z","updated_at":"2016-08-28T06:26:14Z","pushed_at":"2016-09-01T02:51:59Z","git_url":"git://github.com/vjeux/react.git","ssh_url":"git@github.com:vjeux/react.git","clone_url":"https://github.com/vjeux/react.git","svn_url":"https://github.com/vjeux/react","homepage":"http://facebook.github.io/react/","size":69077,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"1bd55c8cbdb456890cfbaad0759f15edfd37d080","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-09-01T02:29:56Z","pushed_at":"2016-09-01T02:52:24Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":129177,"stargazers_count":48324,"watchers_count":48324,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8501,"mirror_url":null,"open_issues_count":648,"forks":8501,"open_issues":648,"watchers":48324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/7628"},"html":{"href":"https://github.com/facebook/react/pull/7628"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/7628"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/7628/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/7628/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/7628/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/0cf3bac6c9c4bfc60f7c40aaf66d787ccf6dd701"}}}}
{"actor":{"display_login":"vjeux"}}