{"action":"opened","number":1805,"pull_request":{"url":"https://api.github.com/repos/airbnb/superset/pulls/1805","id":97236724,"html_url":"https://github.com/airbnb/superset/pull/1805","diff_url":"https://github.com/airbnb/superset/pull/1805.diff","patch_url":"https://github.com/airbnb/superset/pull/1805.patch","issue_url":"https://api.github.com/repos/airbnb/superset/issues/1805","number":1805,"state":"open","locked":false,"title":"Vliu count distinct metrics","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"body":"Issues solved:\r\n - when metrics is not valid in query(), the error message gives 'NoneType' has no attribute sqla_col, which is not very descriptive\r\n - count_distinct was transfered to count_distinct(col) expression in sqllab_viz\r\n\r\nneeds-review @mistercrunch @bkyryliuk ","created_at":"2016-12-09T01:43:00Z","updated_at":"2016-12-09T01:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2155185c1c2a674d61007205203ab4504f3a15a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/superset/pulls/1805/commits","review_comments_url":"https://api.github.com/repos/airbnb/superset/pulls/1805/comments","review_comment_url":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/superset/issues/1805/comments","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/9ab4e7b79c2b83471ada0f4dc349de2781a52f1b","head":{"label":"vera-liu:vliu_count_distinct_metrics","ref":"vliu_count_distinct_metrics","sha":"9ab4e7b79c2b83471ada0f4dc349de2781a52f1b","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"repo":{"id":65501764,"name":"caravel","full_name":"vera-liu/caravel","owner":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vera-liu/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":true,"url":"https://api.github.com/repos/vera-liu/caravel","forks_url":"https://api.github.com/repos/vera-liu/caravel/forks","keys_url":"https://api.github.com/repos/vera-liu/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vera-liu/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vera-liu/caravel/teams","hooks_url":"https://api.github.com/repos/vera-liu/caravel/hooks","issue_events_url":"https://api.github.com/repos/vera-liu/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/vera-liu/caravel/events","assignees_url":"https://api.github.com/repos/vera-liu/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/vera-liu/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/vera-liu/caravel/tags","blobs_url":"https://api.github.com/repos/vera-liu/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vera-liu/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vera-liu/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/vera-liu/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vera-liu/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/vera-liu/caravel/languages","stargazers_url":"https://api.github.com/repos/vera-liu/caravel/stargazers","contributors_url":"https://api.github.com/repos/vera-liu/caravel/contributors","subscribers_url":"https://api.github.com/repos/vera-liu/caravel/subscribers","subscription_url":"https://api.github.com/repos/vera-liu/caravel/subscription","commits_url":"https://api.github.com/repos/vera-liu/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/vera-liu/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/vera-liu/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/vera-liu/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/vera-liu/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/vera-liu/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vera-liu/caravel/merges","archive_url":"https://api.github.com/repos/vera-liu/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vera-liu/caravel/downloads","issues_url":"https://api.github.com/repos/vera-liu/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/vera-liu/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/vera-liu/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/vera-liu/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vera-liu/caravel/labels{/name}","releases_url":"https://api.github.com/repos/vera-liu/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/vera-liu/caravel/deployments","created_at":"2016-08-11T21:10:17Z","updated_at":"2016-08-11T21:10:18Z","pushed_at":"2016-12-09T01:39:37Z","git_url":"git://github.com/vera-liu/caravel.git","ssh_url":"git@github.com:vera-liu/caravel.git","clone_url":"https://github.com/vera-liu/caravel.git","svn_url":"https://github.com/vera-liu/caravel","homepage":"","size":38693,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"68c2eab6b93a13966b19aae20fb6c82fc34e3bcf","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"superset","full_name":"airbnb/superset","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/superset","description":"Superset is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/superset","forks_url":"https://api.github.com/repos/airbnb/superset/forks","keys_url":"https://api.github.com/repos/airbnb/superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/superset/teams","hooks_url":"https://api.github.com/repos/airbnb/superset/hooks","issue_events_url":"https://api.github.com/repos/airbnb/superset/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/superset/events","assignees_url":"https://api.github.com/repos/airbnb/superset/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/superset/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/superset/tags","blobs_url":"https://api.github.com/repos/airbnb/superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/superset/languages","stargazers_url":"https://api.github.com/repos/airbnb/superset/stargazers","contributors_url":"https://api.github.com/repos/airbnb/superset/contributors","subscribers_url":"https://api.github.com/repos/airbnb/superset/subscribers","subscription_url":"https://api.github.com/repos/airbnb/superset/subscription","commits_url":"https://api.github.com/repos/airbnb/superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/superset/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/superset/merges","archive_url":"https://api.github.com/repos/airbnb/superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/superset/downloads","issues_url":"https://api.github.com/repos/airbnb/superset/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/superset/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/superset/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/superset/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/superset/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-12-09T00:57:32Z","pushed_at":"2016-12-09T01:43:00Z","git_url":"git://github.com/airbnb/superset.git","ssh_url":"git@github.com:airbnb/superset.git","clone_url":"https://github.com/airbnb/superset.git","svn_url":"https://github.com/airbnb/superset","homepage":"","size":46879,"stargazers_count":9854,"watchers_count":9854,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1163,"mirror_url":null,"open_issues_count":371,"forks":1163,"open_issues":371,"watchers":9854,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1805"},"html":{"href":"https://github.com/airbnb/superset/pull/1805"},"issue":{"href":"https://api.github.com/repos/airbnb/superset/issues/1805"},"comments":{"href":"https://api.github.com/repos/airbnb/superset/issues/1805/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1805/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1805/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/superset/statuses/9ab4e7b79c2b83471ada0f4dc349de2781a52f1b"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":13,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"vera-liu"}}