{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31410","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31410/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31410/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31410/events","html_url":"https://github.com/kubernetes/kubernetes/pull/31410","id":173109418,"number":31410,"title":"[kube-proxy] Modify func updateServiceListener's parameter name from addOrDelete to add","user":{"login":"m1093782566","id":4953962,"avatar_url":"https://avatars.githubusercontent.com/u/4953962?v=3","gravatar_id":"","url":"https://api.github.com/users/m1093782566","html_url":"https://github.com/m1093782566","followers_url":"https://api.github.com/users/m1093782566/followers","following_url":"https://api.github.com/users/m1093782566/following{/other_user}","gists_url":"https://api.github.com/users/m1093782566/gists{/gist_id}","starred_url":"https://api.github.com/users/m1093782566/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m1093782566/subscriptions","organizations_url":"https://api.github.com/users/m1093782566/orgs","repos_url":"https://api.github.com/users/m1093782566/repos","events_url":"https://api.github.com/users/m1093782566/events{/privacy}","received_events_url":"https://api.github.com/users/m1093782566/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-25T04:00:46Z","updated_at":"2016-08-25T04:01:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31410","html_url":"https://github.com/kubernetes/kubernetes/pull/31410","diff_url":"https://github.com/kubernetes/kubernetes/pull/31410.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/31410.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nCurrently, the 4th parameter name of `updateServiceListener` in kube-proxy is `addOrDelete`, \r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/healthcheck/api.go#L36\r\n\r\nHowever, from the func caller, we just pass `true` for `AddServiceListener`, \r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/healthcheck/api.go#L50\r\n\r\nand `false` for `DeleteServiceListener`,\r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/healthcheck/api.go#L55\r\n\r\nSo, I think the name `addOrDelete` is unreasonable. I prefer to change the parameter name `addOrDelete` to `add`.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #31382\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/31410)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/242275610","html_url":"https://github.com/kubernetes/kubernetes/pull/31410#issuecomment-242275610","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31410","id":242275610,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T04:01:28Z","updated_at":"2016-08-25T04:01:28Z","body":"Can one of the admins verify that this patch is reasonable to test? If so, please reply \"ok to test\".\n(Note: \"add to whitelist\" is no longer supported. Please update configurations in [kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull](https://github.com/kubernetes/test-infra/tree/master/jenkins/job-configs/kubernetes-jenkins-pull) instead.)\n\nThis message will repeat several times in short succession due to https://github.com/jenkinsci/ghprb-plugin/issues/292. Sorry."}}
{"actor":{"display_login":"k8s-bot"}}