{"action":"created","comment":{"url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/comments/69242237","id":69242237,"diff_hunk":"@@ -260,11 +260,15 @@ private void uploadFile(String localFile, String remoteFile, CallbackContext cal\n \t\t{\n \t\t\ttry {\n \t\t\t\tString remoteFilePath = remoteFile.substring(0, remoteFile.lastIndexOf('/') + 1);\n-\t\t\t\t//String remoteFileName = remoteFile.substring(remoteFile.lastIndexOf('/') + 1);\n+\t\t\t\tString remoteFileName = remoteFile.substring(remoteFile.lastIndexOf('/') + 1);","path":"src/android/CDVFtp.java","position":14,"original_position":14,"commit_id":"94fe65baafb451c3ab5573dc66f8c48ec1c25b16","original_commit_id":"94fe65baafb451c3ab5573dc66f8c48ec1c25b16","user":{"login":"xfally","id":5096620,"avatar_url":"https://avatars.githubusercontent.com/u/5096620?v=3","gravatar_id":"","url":"https://api.github.com/users/xfally","html_url":"https://github.com/xfally","followers_url":"https://api.github.com/users/xfally/followers","following_url":"https://api.github.com/users/xfally/following{/other_user}","gists_url":"https://api.github.com/users/xfally/gists{/gist_id}","starred_url":"https://api.github.com/users/xfally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfally/subscriptions","organizations_url":"https://api.github.com/users/xfally/orgs","repos_url":"https://api.github.com/users/xfally/repos","events_url":"https://api.github.com/users/xfally/events{/privacy}","received_events_url":"https://api.github.com/users/xfally/received_events","type":"User","site_admin":false},"body":"Indent with *tab* instead of *space*.","created_at":"2016-07-01T03:08:37Z","updated_at":"2016-07-01T03:08:37Z","html_url":"https://github.com/xfally/cordova-plugin-ftp/pull/2#discussion_r69242237","pull_request_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/comments/69242237"},"html":{"href":"https://github.com/xfally/cordova-plugin-ftp/pull/2#discussion_r69242237"},"pull_request":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2","id":75599925,"html_url":"https://github.com/xfally/cordova-plugin-ftp/pull/2","diff_url":"https://github.com/xfally/cordova-plugin-ftp/pull/2.diff","patch_url":"https://github.com/xfally/cordova-plugin-ftp/pull/2.patch","issue_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/issues/2","number":2,"state":"open","locked":false,"title":"Use input stream to set the remote file name (android)","user":{"login":"ben870418","id":12545927,"avatar_url":"https://avatars.githubusercontent.com/u/12545927?v=3","gravatar_id":"","url":"https://api.github.com/users/ben870418","html_url":"https://github.com/ben870418","followers_url":"https://api.github.com/users/ben870418/followers","following_url":"https://api.github.com/users/ben870418/following{/other_user}","gists_url":"https://api.github.com/users/ben870418/gists{/gist_id}","starred_url":"https://api.github.com/users/ben870418/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben870418/subscriptions","organizations_url":"https://api.github.com/users/ben870418/orgs","repos_url":"https://api.github.com/users/ben870418/repos","events_url":"https://api.github.com/users/ben870418/events{/privacy}","received_events_url":"https://api.github.com/users/ben870418/received_events","type":"User","site_admin":false},"body":"android ftp upload with remote file name same as local file name, which is not the same behavior as iOS plugin.\r\n\r\npeople get confused when they give a remote file path parameter but the remote file uploaded with a different name.\r\n\r\nSince ftp4j don't have a function to set the uploaded file name, I tried to change local file name as a workaround.","created_at":"2016-06-29T07:24:36Z","updated_at":"2016-07-01T03:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"521f4acf700f40e38dafae765c044013902579f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2/commits","review_comments_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2/comments","review_comment_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/issues/2/comments","statuses_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/statuses/94fe65baafb451c3ab5573dc66f8c48ec1c25b16","head":{"label":"ben870418:master","ref":"master","sha":"94fe65baafb451c3ab5573dc66f8c48ec1c25b16","user":{"login":"ben870418","id":12545927,"avatar_url":"https://avatars.githubusercontent.com/u/12545927?v=3","gravatar_id":"","url":"https://api.github.com/users/ben870418","html_url":"https://github.com/ben870418","followers_url":"https://api.github.com/users/ben870418/followers","following_url":"https://api.github.com/users/ben870418/following{/other_user}","gists_url":"https://api.github.com/users/ben870418/gists{/gist_id}","starred_url":"https://api.github.com/users/ben870418/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben870418/subscriptions","organizations_url":"https://api.github.com/users/ben870418/orgs","repos_url":"https://api.github.com/users/ben870418/repos","events_url":"https://api.github.com/users/ben870418/events{/privacy}","received_events_url":"https://api.github.com/users/ben870418/received_events","type":"User","site_admin":false},"repo":{"id":62204032,"name":"cordova-plugin-ftp","full_name":"ben870418/cordova-plugin-ftp","owner":{"login":"ben870418","id":12545927,"avatar_url":"https://avatars.githubusercontent.com/u/12545927?v=3","gravatar_id":"","url":"https://api.github.com/users/ben870418","html_url":"https://github.com/ben870418","followers_url":"https://api.github.com/users/ben870418/followers","following_url":"https://api.github.com/users/ben870418/following{/other_user}","gists_url":"https://api.github.com/users/ben870418/gists{/gist_id}","starred_url":"https://api.github.com/users/ben870418/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben870418/subscriptions","organizations_url":"https://api.github.com/users/ben870418/orgs","repos_url":"https://api.github.com/users/ben870418/repos","events_url":"https://api.github.com/users/ben870418/events{/privacy}","received_events_url":"https://api.github.com/users/ben870418/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ben870418/cordova-plugin-ftp","description":"A cordova plugin to use ftp (client) in web/js for both iOS and Android.","fork":true,"url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp","forks_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/forks","keys_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/teams","hooks_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/hooks","issue_events_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/issues/events{/number}","events_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/events","assignees_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/assignees{/user}","branches_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/branches{/branch}","tags_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/tags","blobs_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/statuses/{sha}","languages_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/languages","stargazers_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/stargazers","contributors_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/contributors","subscribers_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/subscribers","subscription_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/subscription","commits_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/contents/{+path}","compare_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/merges","archive_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/downloads","issues_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/issues{/number}","pulls_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/pulls{/number}","milestones_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/milestones{/number}","notifications_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/labels{/name}","releases_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/releases{/id}","deployments_url":"https://api.github.com/repos/ben870418/cordova-plugin-ftp/deployments","created_at":"2016-06-29T07:09:40Z","updated_at":"2016-06-29T07:09:41Z","pushed_at":"2016-06-30T08:53:24Z","git_url":"git://github.com/ben870418/cordova-plugin-ftp.git","ssh_url":"git@github.com:ben870418/cordova-plugin-ftp.git","clone_url":"https://github.com/ben870418/cordova-plugin-ftp.git","svn_url":"https://github.com/ben870418/cordova-plugin-ftp","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xfally:master","ref":"master","sha":"79af27fdc89d65e334d6b1a576cd3316f6b2bc5c","user":{"login":"xfally","id":5096620,"avatar_url":"https://avatars.githubusercontent.com/u/5096620?v=3","gravatar_id":"","url":"https://api.github.com/users/xfally","html_url":"https://github.com/xfally","followers_url":"https://api.github.com/users/xfally/followers","following_url":"https://api.github.com/users/xfally/following{/other_user}","gists_url":"https://api.github.com/users/xfally/gists{/gist_id}","starred_url":"https://api.github.com/users/xfally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfally/subscriptions","organizations_url":"https://api.github.com/users/xfally/orgs","repos_url":"https://api.github.com/users/xfally/repos","events_url":"https://api.github.com/users/xfally/events{/privacy}","received_events_url":"https://api.github.com/users/xfally/received_events","type":"User","site_admin":false},"repo":{"id":49542447,"name":"cordova-plugin-ftp","full_name":"xfally/cordova-plugin-ftp","owner":{"login":"xfally","id":5096620,"avatar_url":"https://avatars.githubusercontent.com/u/5096620?v=3","gravatar_id":"","url":"https://api.github.com/users/xfally","html_url":"https://github.com/xfally","followers_url":"https://api.github.com/users/xfally/followers","following_url":"https://api.github.com/users/xfally/following{/other_user}","gists_url":"https://api.github.com/users/xfally/gists{/gist_id}","starred_url":"https://api.github.com/users/xfally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfally/subscriptions","organizations_url":"https://api.github.com/users/xfally/orgs","repos_url":"https://api.github.com/users/xfally/repos","events_url":"https://api.github.com/users/xfally/events{/privacy}","received_events_url":"https://api.github.com/users/xfally/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xfally/cordova-plugin-ftp","description":"A cordova plugin to use ftp (client) in web/js for both iOS and Android.","fork":false,"url":"https://api.github.com/repos/xfally/cordova-plugin-ftp","forks_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/forks","keys_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/teams","hooks_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/hooks","issue_events_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/issues/events{/number}","events_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/events","assignees_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/assignees{/user}","branches_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/branches{/branch}","tags_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/tags","blobs_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/git/refs{/sha}","trees_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/statuses/{sha}","languages_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/languages","stargazers_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/stargazers","contributors_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/contributors","subscribers_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/subscribers","subscription_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/subscription","commits_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/commits{/sha}","git_commits_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/git/commits{/sha}","comments_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/comments{/number}","issue_comment_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/issues/comments{/number}","contents_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/contents/{+path}","compare_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/merges","archive_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/downloads","issues_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/issues{/number}","pulls_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls{/number}","milestones_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/milestones{/number}","notifications_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/labels{/name}","releases_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/releases{/id}","deployments_url":"https://api.github.com/repos/xfally/cordova-plugin-ftp/deployments","created_at":"2016-01-13T02:04:43Z","updated_at":"2016-06-27T15:29:21Z","pushed_at":"2016-06-30T08:53:25Z","git_url":"git://github.com/xfally/cordova-plugin-ftp.git","ssh_url":"git@github.com:xfally/cordova-plugin-ftp.git","clone_url":"https://github.com/xfally/cordova-plugin-ftp.git","svn_url":"https://github.com/xfally/cordova-plugin-ftp","homepage":"","size":100,"stargazers_count":5,"watchers_count":5,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2"},"html":{"href":"https://github.com/xfally/cordova-plugin-ftp/pull/2"},"issue":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/issues/2"},"comments":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/xfally/cordova-plugin-ftp/statuses/94fe65baafb451c3ab5573dc66f8c48ec1c25b16"}}}}
{"actor":{"display_login":"xfally"}}