{"action":"created","comment":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments/72308108","id":72308108,"diff_hunk":"@@ -24,6 +21,33 @@\n \n catalog = i18nCatalog(\"cura\")\n \n+class SliceInfoThread(Thread):\n+    data = None\n+    url = None\n+\n+    def __init__(self, url, data):\n+        Thread.__init__(self)\n+        self.url = url\n+        self.data = data\n+\n+    def run(self):\n+        if not self.url or not self.data:\n+            Logger.log(\"e\", \"URL or DATA for sending slice info was not set!\")","path":"plugins/SliceInfoPlugin/SliceInfo.py","position":29,"original_position":27,"commit_id":"260b68286475afc59eb31ab2b7a995b268e9f43e","original_commit_id":"c137cb4109135e74adcfffa43aa38a4675d3ec9d","user":{"login":"thopiekar","id":1847437,"avatar_url":"https://avatars.githubusercontent.com/u/1847437?v=3","gravatar_id":"","url":"https://api.github.com/users/thopiekar","html_url":"https://github.com/thopiekar","followers_url":"https://api.github.com/users/thopiekar/followers","following_url":"https://api.github.com/users/thopiekar/following{/other_user}","gists_url":"https://api.github.com/users/thopiekar/gists{/gist_id}","starred_url":"https://api.github.com/users/thopiekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thopiekar/subscriptions","organizations_url":"https://api.github.com/users/thopiekar/orgs","repos_url":"https://api.github.com/users/thopiekar/repos","events_url":"https://api.github.com/users/thopiekar/events{/privacy}","received_events_url":"https://api.github.com/users/thopiekar/received_events","type":"User","site_admin":false},"body":"Yes, of course. Fixed that :+1: ","created_at":"2016-07-26T18:24:17Z","updated_at":"2016-07-26T18:24:17Z","html_url":"https://github.com/Ultimaker/Cura/pull/889#discussion_r72308108","pull_request_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/889","_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments/72308108"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/889#discussion_r72308108"},"pull_request":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/889"}}},"pull_request":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/889","id":78746758,"html_url":"https://github.com/Ultimaker/Cura/pull/889","diff_url":"https://github.com/Ultimaker/Cura/pull/889.diff","patch_url":"https://github.com/Ultimaker/Cura/pull/889.patch","issue_url":"https://api.github.com/repos/Ultimaker/Cura/issues/889","number":889,"state":"open","locked":false,"title":"CURA-1923: SliceInfo: Sending data threaded","user":{"login":"thopiekar","id":1847437,"avatar_url":"https://avatars.githubusercontent.com/u/1847437?v=3","gravatar_id":"","url":"https://api.github.com/users/thopiekar","html_url":"https://github.com/thopiekar","followers_url":"https://api.github.com/users/thopiekar/followers","following_url":"https://api.github.com/users/thopiekar/following{/other_user}","gists_url":"https://api.github.com/users/thopiekar/gists{/gist_id}","starred_url":"https://api.github.com/users/thopiekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thopiekar/subscriptions","organizations_url":"https://api.github.com/users/thopiekar/orgs","repos_url":"https://api.github.com/users/thopiekar/repos","events_url":"https://api.github.com/users/thopiekar/events{/privacy}","received_events_url":"https://api.github.com/users/thopiekar/received_events","type":"User","site_admin":false},"body":"The idea is to make the sending process, so it won't block the UI until the data is sent or the timeout has reached.\r\nThis commit does the following:\r\n* Increasing the timeout to 5s\r\n-> As we are sending our data threaded now this won't hurt. At least for clients in slow networks.\r\n* Moving section for \"sending data to info_url\" into a seperate thread.\r\n* Starting the thread instead and collecting all threads in a list\r\n* Removing all threads from the list, if they have already finished their work.\r\n* When the SliceInfo Extension gets ```__del__```'d, it will wait for the threads until they finish.\r\n\r\nContributes to CURA-1923\r\n\r\nPS: Also adds a Logger.logException to get debug info, when something goes wrong.","created_at":"2016-07-25T20:32:38Z","updated_at":"2016-07-26T18:24:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d5271c277f456764b3db48a68812defcdd742d1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/889/commits","review_comments_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/889/comments","review_comment_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/issues/889/comments","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/260b68286475afc59eb31ab2b7a995b268e9f43e","head":{"label":"thopiekar:master-CURA-1923","ref":"master-CURA-1923","sha":"260b68286475afc59eb31ab2b7a995b268e9f43e","user":{"login":"thopiekar","id":1847437,"avatar_url":"https://avatars.githubusercontent.com/u/1847437?v=3","gravatar_id":"","url":"https://api.github.com/users/thopiekar","html_url":"https://github.com/thopiekar","followers_url":"https://api.github.com/users/thopiekar/followers","following_url":"https://api.github.com/users/thopiekar/following{/other_user}","gists_url":"https://api.github.com/users/thopiekar/gists{/gist_id}","starred_url":"https://api.github.com/users/thopiekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thopiekar/subscriptions","organizations_url":"https://api.github.com/users/thopiekar/orgs","repos_url":"https://api.github.com/users/thopiekar/repos","events_url":"https://api.github.com/users/thopiekar/events{/privacy}","received_events_url":"https://api.github.com/users/thopiekar/received_events","type":"User","site_admin":false},"repo":{"id":40126390,"name":"Cura","full_name":"thopiekar/Cura","owner":{"login":"thopiekar","id":1847437,"avatar_url":"https://avatars.githubusercontent.com/u/1847437?v=3","gravatar_id":"","url":"https://api.github.com/users/thopiekar","html_url":"https://github.com/thopiekar","followers_url":"https://api.github.com/users/thopiekar/followers","following_url":"https://api.github.com/users/thopiekar/following{/other_user}","gists_url":"https://api.github.com/users/thopiekar/gists{/gist_id}","starred_url":"https://api.github.com/users/thopiekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thopiekar/subscriptions","organizations_url":"https://api.github.com/users/thopiekar/orgs","repos_url":"https://api.github.com/users/thopiekar/repos","events_url":"https://api.github.com/users/thopiekar/events{/privacy}","received_events_url":"https://api.github.com/users/thopiekar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thopiekar/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":true,"url":"https://api.github.com/repos/thopiekar/Cura","forks_url":"https://api.github.com/repos/thopiekar/Cura/forks","keys_url":"https://api.github.com/repos/thopiekar/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thopiekar/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thopiekar/Cura/teams","hooks_url":"https://api.github.com/repos/thopiekar/Cura/hooks","issue_events_url":"https://api.github.com/repos/thopiekar/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/thopiekar/Cura/events","assignees_url":"https://api.github.com/repos/thopiekar/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/thopiekar/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/thopiekar/Cura/tags","blobs_url":"https://api.github.com/repos/thopiekar/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thopiekar/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thopiekar/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/thopiekar/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thopiekar/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/thopiekar/Cura/languages","stargazers_url":"https://api.github.com/repos/thopiekar/Cura/stargazers","contributors_url":"https://api.github.com/repos/thopiekar/Cura/contributors","subscribers_url":"https://api.github.com/repos/thopiekar/Cura/subscribers","subscription_url":"https://api.github.com/repos/thopiekar/Cura/subscription","commits_url":"https://api.github.com/repos/thopiekar/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/thopiekar/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/thopiekar/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/thopiekar/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/thopiekar/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/thopiekar/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thopiekar/Cura/merges","archive_url":"https://api.github.com/repos/thopiekar/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thopiekar/Cura/downloads","issues_url":"https://api.github.com/repos/thopiekar/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/thopiekar/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/thopiekar/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/thopiekar/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thopiekar/Cura/labels{/name}","releases_url":"https://api.github.com/repos/thopiekar/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/thopiekar/Cura/deployments","created_at":"2015-08-03T13:31:06Z","updated_at":"2016-04-15T12:26:21Z","pushed_at":"2016-07-26T18:21:15Z","git_url":"git://github.com/thopiekar/Cura.git","ssh_url":"git@github.com:thopiekar/Cura.git","clone_url":"https://github.com/thopiekar/Cura.git","svn_url":"https://github.com/thopiekar/Cura","homepage":"","size":36819,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Ultimaker:master","ref":"master","sha":"b3f0c257e4c251847c1f5d1882b2fa35cf804bcd","user":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"name":"Cura","full_name":"Ultimaker/Cura","owner":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Cura/deployments","created_at":"2014-06-16T12:55:31Z","updated_at":"2016-07-24T16:09:46Z","pushed_at":"2016-07-26T18:21:55Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":40239,"stargazers_count":192,"watchers_count":192,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":208,"forks":127,"open_issues":208,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/889"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/889"},"issue":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/889"},"comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/889/comments"},"review_comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/889/comments"},"review_comment":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/889/commits"},"statuses":{"href":"https://api.github.com/repos/Ultimaker/Cura/statuses/260b68286475afc59eb31ab2b7a995b268e9f43e"}}}}
{"actor":{"display_login":"thopiekar"}}