{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/71829041","id":71829041,"diff_hunk":"@@ -0,0 +1,127 @@\n+#\n+# Copyright 2016, SUSE\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+class Chef\n+  class Recipe\n+    def get_sql_connection","path":"chef/cookbooks/trove/libraries/helpers.rb","position":19,"original_position":19,"commit_id":"94bc22c2fe1454dde42f87e13e1af8a40b3c23f9","original_commit_id":"94bc22c2fe1454dde42f87e13e1af8a40b3c23f9","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"body":"@vuntz so where should I move the code? Or should I prefix the function names with ```trove_``` ?","created_at":"2016-07-22T05:38:21Z","updated_at":"2016-07-22T05:38:21Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/443#discussion_r71829041","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/71829041"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/443#discussion_r71829041"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443","id":77136073,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/443","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/443.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/443.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/443","number":443,"state":"open","locked":false,"title":"trove: Replace openstack-identity with keystone_register","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"body":"This is a first step to unify the trove cookbook with the rest of the\r\ncookbooks.\r\nRemove the openstack-identity cookbook and replace it with the keystone_register\r\nmethods to have a single resource provider handling the user/service/endpoint\r\nregistration.\r\nNote: The reason why the code to register the endpoints and users moved to api.rb\r\nis that this is an ongoing effort to also get rid of openstack-database and\r\nhave the chef recipies all in the trove cookbook. And all the other services are\r\ndoing the endpoint/service/user handling in the api.rb recipe.","created_at":"2016-07-12T15:02:38Z","updated_at":"2016-07-22T05:38:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7292682bd8fd9ace67778e565904e7bfa51e20a8","assignee":{"login":"aplanas","id":645701,"avatar_url":"https://avatars.githubusercontent.com/u/645701?v=3","gravatar_id":"","url":"https://api.github.com/users/aplanas","html_url":"https://github.com/aplanas","followers_url":"https://api.github.com/users/aplanas/followers","following_url":"https://api.github.com/users/aplanas/following{/other_user}","gists_url":"https://api.github.com/users/aplanas/gists{/gist_id}","starred_url":"https://api.github.com/users/aplanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aplanas/subscriptions","organizations_url":"https://api.github.com/users/aplanas/orgs","repos_url":"https://api.github.com/users/aplanas/repos","events_url":"https://api.github.com/users/aplanas/events{/privacy}","received_events_url":"https://api.github.com/users/aplanas/received_events","type":"User","site_admin":false},"assignees":[{"login":"aplanas","id":645701,"avatar_url":"https://avatars.githubusercontent.com/u/645701?v=3","gravatar_id":"","url":"https://api.github.com/users/aplanas","html_url":"https://github.com/aplanas","followers_url":"https://api.github.com/users/aplanas/followers","following_url":"https://api.github.com/users/aplanas/following{/other_user}","gists_url":"https://api.github.com/users/aplanas/gists{/gist_id}","starred_url":"https://api.github.com/users/aplanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aplanas/subscriptions","organizations_url":"https://api.github.com/users/aplanas/orgs","repos_url":"https://api.github.com/users/aplanas/repos","events_url":"https://api.github.com/users/aplanas/events{/privacy}","received_events_url":"https://api.github.com/users/aplanas/received_events","type":"User","site_admin":false},{"login":"sayalilunkad","id":2324148,"avatar_url":"https://avatars.githubusercontent.com/u/2324148?v=3","gravatar_id":"","url":"https://api.github.com/users/sayalilunkad","html_url":"https://github.com/sayalilunkad","followers_url":"https://api.github.com/users/sayalilunkad/followers","following_url":"https://api.github.com/users/sayalilunkad/following{/other_user}","gists_url":"https://api.github.com/users/sayalilunkad/gists{/gist_id}","starred_url":"https://api.github.com/users/sayalilunkad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayalilunkad/subscriptions","organizations_url":"https://api.github.com/users/sayalilunkad/orgs","repos_url":"https://api.github.com/users/sayalilunkad/repos","events_url":"https://api.github.com/users/sayalilunkad/events{/privacy}","received_events_url":"https://api.github.com/users/sayalilunkad/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/443/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/94bc22c2fe1454dde42f87e13e1af8a40b3c23f9","head":{"label":"toabctl:trove-fixes","ref":"trove-fixes","sha":"94bc22c2fe1454dde42f87e13e1af8a40b3c23f9","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"repo":{"id":40896453,"name":"crowbar-openstack","full_name":"toabctl/crowbar-openstack","owner":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toabctl/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/toabctl/crowbar-openstack","forks_url":"https://api.github.com/repos/toabctl/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/toabctl/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toabctl/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toabctl/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/toabctl/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/toabctl/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/toabctl/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/toabctl/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/toabctl/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toabctl/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/toabctl/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/toabctl/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/toabctl/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/toabctl/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/toabctl/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/toabctl/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/toabctl/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/toabctl/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/toabctl/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toabctl/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/toabctl/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toabctl/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/toabctl/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/toabctl/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/toabctl/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toabctl/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/toabctl/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/toabctl/crowbar-openstack/deployments","created_at":"2015-08-17T13:21:21Z","updated_at":"2016-01-18T17:32:04Z","pushed_at":"2016-07-21T13:16:40Z","git_url":"git://github.com/toabctl/crowbar-openstack.git","ssh_url":"git@github.com:toabctl/crowbar-openstack.git","clone_url":"https://github.com/toabctl/crowbar-openstack.git","svn_url":"https://github.com/toabctl/crowbar-openstack","homepage":null,"size":17061,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"f5e83d14f3207e1156946f4451d6e6133593199e","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-01-11T12:29:07Z","pushed_at":"2016-07-21T13:19:09Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":17479,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":35,"forks":31,"open_issues":35,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/443"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/443"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/94bc22c2fe1454dde42f87e13e1af8a40b3c23f9"}}}}
{"actor":{"display_login":"toabctl"}}