{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/workload-automation/pulls/comments/62017294","id":62017294,"diff_hunk":"@@ -32,19 +32,22 @@ class UbootMenu(object):\n     option_regex = re.compile(r'^\\[(\\d+)\\]\\s+([^\\r]+)\\r\\n', re.M)\n     prompt_regex = re.compile(r'^([^\\r\\n]+):\\s*', re.M)\n     invalid_regex = re.compile(r'Invalid input \\(max (\\d+)\\)', re.M)\n+    uboot_regex = re.compile(r\"U-Boot\\s(\\d[\\w.-]+)\\s\")","path":"wlauto/utils/uboot.py","position":13,"original_position":13,"commit_id":"df6ba78db83ccbd6bd5f088ae1865e3f32643862","original_commit_id":"df6ba78db83ccbd6bd5f088ae1865e3f32643862","user":{"login":"setrofim","id":904685,"avatar_url":"https://avatars.githubusercontent.com/u/904685?v=3","gravatar_id":"","url":"https://api.github.com/users/setrofim","html_url":"https://github.com/setrofim","followers_url":"https://api.github.com/users/setrofim/followers","following_url":"https://api.github.com/users/setrofim/following{/other_user}","gists_url":"https://api.github.com/users/setrofim/gists{/gist_id}","starred_url":"https://api.github.com/users/setrofim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/setrofim/subscriptions","organizations_url":"https://api.github.com/users/setrofim/orgs","repos_url":"https://api.github.com/users/setrofim/repos","events_url":"https://api.github.com/users/setrofim/events{/privacy}","received_events_url":"https://api.github.com/users/setrofim/received_events","type":"User","site_admin":false},"body":"I would change parenthesized part of the regex to `(\\d\\S*)`","created_at":"2016-05-04T10:16:47Z","updated_at":"2016-05-04T10:16:47Z","html_url":"https://github.com/ARM-software/workload-automation/pull/153#discussion_r62017294","pull_request_url":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/workload-automation/pulls/comments/62017294"},"html":{"href":"https://github.com/ARM-software/workload-automation/pull/153#discussion_r62017294"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153","id":68714021,"html_url":"https://github.com/ARM-software/workload-automation/pull/153","diff_url":"https://github.com/ARM-software/workload-automation/pull/153.diff","patch_url":"https://github.com/ARM-software/workload-automation/pull/153.patch","issue_url":"https://api.github.com/repos/ARM-software/workload-automation/issues/153","number":153,"state":"open","locked":false,"title":"Juno fixes","user":{"login":"ep1cman","id":5303409,"avatar_url":"https://avatars.githubusercontent.com/u/5303409?v=3","gravatar_id":"","url":"https://api.github.com/users/ep1cman","html_url":"https://github.com/ep1cman","followers_url":"https://api.github.com/users/ep1cman/followers","following_url":"https://api.github.com/users/ep1cman/following{/other_user}","gists_url":"https://api.github.com/users/ep1cman/gists{/gist_id}","starred_url":"https://api.github.com/users/ep1cman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ep1cman/subscriptions","organizations_url":"https://api.github.com/users/ep1cman/orgs","repos_url":"https://api.github.com/users/ep1cman/repos","events_url":"https://api.github.com/users/ep1cman/events{/privacy}","received_events_url":"https://api.github.com/users/ep1cman/received_events","type":"User","site_admin":false},"body":"juno:\r\n- The default boot args have been removed since these cause issues with the latest Linaro builds, which boot correctly without any bootargs.\r\n- made a regex string a raw-string.\r\n\r\nuboot: \r\n- Now detects the U-Boot version to use correct line endings","created_at":"2016-05-03T14:25:37Z","updated_at":"2016-05-04T10:16:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8666b0ac1133e23c68c39fe57676257de6552e46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153/commits","review_comments_url":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153/comments","review_comment_url":"https://api.github.com/repos/ARM-software/workload-automation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/workload-automation/issues/153/comments","statuses_url":"https://api.github.com/repos/ARM-software/workload-automation/statuses/df6ba78db83ccbd6bd5f088ae1865e3f32643862","head":{"label":"ep1cman:juno-fixes","ref":"juno-fixes","sha":"df6ba78db83ccbd6bd5f088ae1865e3f32643862","user":{"login":"ep1cman","id":5303409,"avatar_url":"https://avatars.githubusercontent.com/u/5303409?v=3","gravatar_id":"","url":"https://api.github.com/users/ep1cman","html_url":"https://github.com/ep1cman","followers_url":"https://api.github.com/users/ep1cman/followers","following_url":"https://api.github.com/users/ep1cman/following{/other_user}","gists_url":"https://api.github.com/users/ep1cman/gists{/gist_id}","starred_url":"https://api.github.com/users/ep1cman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ep1cman/subscriptions","organizations_url":"https://api.github.com/users/ep1cman/orgs","repos_url":"https://api.github.com/users/ep1cman/repos","events_url":"https://api.github.com/users/ep1cman/events{/privacy}","received_events_url":"https://api.github.com/users/ep1cman/received_events","type":"User","site_admin":false},"repo":{"id":44668301,"name":"workload-automation","full_name":"ep1cman/workload-automation","owner":{"login":"ep1cman","id":5303409,"avatar_url":"https://avatars.githubusercontent.com/u/5303409?v=3","gravatar_id":"","url":"https://api.github.com/users/ep1cman","html_url":"https://github.com/ep1cman","followers_url":"https://api.github.com/users/ep1cman/followers","following_url":"https://api.github.com/users/ep1cman/following{/other_user}","gists_url":"https://api.github.com/users/ep1cman/gists{/gist_id}","starred_url":"https://api.github.com/users/ep1cman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ep1cman/subscriptions","organizations_url":"https://api.github.com/users/ep1cman/orgs","repos_url":"https://api.github.com/users/ep1cman/repos","events_url":"https://api.github.com/users/ep1cman/events{/privacy}","received_events_url":"https://api.github.com/users/ep1cman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ep1cman/workload-automation","description":"A framework for automating workload execution and measurement collection on ARM devices.","fork":true,"url":"https://api.github.com/repos/ep1cman/workload-automation","forks_url":"https://api.github.com/repos/ep1cman/workload-automation/forks","keys_url":"https://api.github.com/repos/ep1cman/workload-automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ep1cman/workload-automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ep1cman/workload-automation/teams","hooks_url":"https://api.github.com/repos/ep1cman/workload-automation/hooks","issue_events_url":"https://api.github.com/repos/ep1cman/workload-automation/issues/events{/number}","events_url":"https://api.github.com/repos/ep1cman/workload-automation/events","assignees_url":"https://api.github.com/repos/ep1cman/workload-automation/assignees{/user}","branches_url":"https://api.github.com/repos/ep1cman/workload-automation/branches{/branch}","tags_url":"https://api.github.com/repos/ep1cman/workload-automation/tags","blobs_url":"https://api.github.com/repos/ep1cman/workload-automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ep1cman/workload-automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ep1cman/workload-automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/ep1cman/workload-automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ep1cman/workload-automation/statuses/{sha}","languages_url":"https://api.github.com/repos/ep1cman/workload-automation/languages","stargazers_url":"https://api.github.com/repos/ep1cman/workload-automation/stargazers","contributors_url":"https://api.github.com/repos/ep1cman/workload-automation/contributors","subscribers_url":"https://api.github.com/repos/ep1cman/workload-automation/subscribers","subscription_url":"https://api.github.com/repos/ep1cman/workload-automation/subscription","commits_url":"https://api.github.com/repos/ep1cman/workload-automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/ep1cman/workload-automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/ep1cman/workload-automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/ep1cman/workload-automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/ep1cman/workload-automation/contents/{+path}","compare_url":"https://api.github.com/repos/ep1cman/workload-automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ep1cman/workload-automation/merges","archive_url":"https://api.github.com/repos/ep1cman/workload-automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ep1cman/workload-automation/downloads","issues_url":"https://api.github.com/repos/ep1cman/workload-automation/issues{/number}","pulls_url":"https://api.github.com/repos/ep1cman/workload-automation/pulls{/number}","milestones_url":"https://api.github.com/repos/ep1cman/workload-automation/milestones{/number}","notifications_url":"https://api.github.com/repos/ep1cman/workload-automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ep1cman/workload-automation/labels{/name}","releases_url":"https://api.github.com/repos/ep1cman/workload-automation/releases{/id}","deployments_url":"https://api.github.com/repos/ep1cman/workload-automation/deployments","created_at":"2015-10-21T10:15:43Z","updated_at":"2016-01-12T10:59:09Z","pushed_at":"2016-05-04T10:13:36Z","git_url":"git://github.com/ep1cman/workload-automation.git","ssh_url":"git@github.com:ep1cman/workload-automation.git","clone_url":"https://github.com/ep1cman/workload-automation.git","svn_url":"https://github.com/ep1cman/workload-automation","homepage":null,"size":32862,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:master","ref":"master","sha":"6c4d88ff57cbc3e6147c026d0aecc663cec6bdf9","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":31957801,"name":"workload-automation","full_name":"ARM-software/workload-automation","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/workload-automation","description":"A framework for automating workload execution and measurement collection on ARM devices.","fork":false,"url":"https://api.github.com/repos/ARM-software/workload-automation","forks_url":"https://api.github.com/repos/ARM-software/workload-automation/forks","keys_url":"https://api.github.com/repos/ARM-software/workload-automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/workload-automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/workload-automation/teams","hooks_url":"https://api.github.com/repos/ARM-software/workload-automation/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/workload-automation/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/workload-automation/events","assignees_url":"https://api.github.com/repos/ARM-software/workload-automation/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/workload-automation/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/workload-automation/tags","blobs_url":"https://api.github.com/repos/ARM-software/workload-automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/workload-automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/workload-automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/workload-automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/workload-automation/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/workload-automation/languages","stargazers_url":"https://api.github.com/repos/ARM-software/workload-automation/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/workload-automation/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/workload-automation/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/workload-automation/subscription","commits_url":"https://api.github.com/repos/ARM-software/workload-automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/workload-automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/workload-automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/workload-automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/workload-automation/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/workload-automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/workload-automation/merges","archive_url":"https://api.github.com/repos/ARM-software/workload-automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/workload-automation/downloads","issues_url":"https://api.github.com/repos/ARM-software/workload-automation/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/workload-automation/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/workload-automation/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/workload-automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/workload-automation/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/workload-automation/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/workload-automation/deployments","created_at":"2015-03-10T13:05:03Z","updated_at":"2016-05-03T13:16:31Z","pushed_at":"2016-05-04T10:13:37Z","git_url":"git://github.com/ARM-software/workload-automation.git","ssh_url":"git@github.com:ARM-software/workload-automation.git","clone_url":"https://github.com/ARM-software/workload-automation.git","svn_url":"https://github.com/ARM-software/workload-automation","homepage":null,"size":32997,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":10,"forks":28,"open_issues":10,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153"},"html":{"href":"https://github.com/ARM-software/workload-automation/pull/153"},"issue":{"href":"https://api.github.com/repos/ARM-software/workload-automation/issues/153"},"comments":{"href":"https://api.github.com/repos/ARM-software/workload-automation/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/workload-automation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/workload-automation/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/workload-automation/statuses/df6ba78db83ccbd6bd5f088ae1865e3f32643862"}}}}