{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7846","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7846/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7846/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7846/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7846","id":188187966,"number":7846,"title":"[WIP] Add check for estimator: parameters not modified by `fit`","user":{"login":"kiote","id":123637,"avatar_url":"https://avatars.githubusercontent.com/u/123637?v=3","gravatar_id":"","url":"https://api.github.com/users/kiote","html_url":"https://github.com/kiote","followers_url":"https://api.github.com/users/kiote/followers","following_url":"https://api.github.com/users/kiote/following{/other_user}","gists_url":"https://api.github.com/users/kiote/gists{/gist_id}","starred_url":"https://api.github.com/users/kiote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiote/subscriptions","organizations_url":"https://api.github.com/users/kiote/orgs","repos_url":"https://api.github.com/users/kiote/repos","events_url":"https://api.github.com/users/kiote/events{/privacy}","received_events_url":"https://api.github.com/users/kiote/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-09T08:11:34Z","updated_at":"2016-11-22T07:11:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7846","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7846","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7846.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7846.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n\r\nFixes #7763\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nAdd simple test to estimator_tests, which checks that `__dict__` does not have non-private attributes after `fit`\r\n\r\n#### Any other comments?\r\n\r\ndidn't add any documentation for that, do I need to?\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/262164672","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7846#issuecomment-262164672","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7846","id":262164672,"user":{"login":"kiote","id":123637,"avatar_url":"https://avatars.githubusercontent.com/u/123637?v=3","gravatar_id":"","url":"https://api.github.com/users/kiote","html_url":"https://github.com/kiote","followers_url":"https://api.github.com/users/kiote/followers","following_url":"https://api.github.com/users/kiote/following{/other_user}","gists_url":"https://api.github.com/users/kiote/gists{/gist_id}","starred_url":"https://api.github.com/users/kiote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiote/subscriptions","organizations_url":"https://api.github.com/users/kiote/orgs","repos_url":"https://api.github.com/users/kiote/repos","events_url":"https://api.github.com/users/kiote/events{/privacy}","received_events_url":"https://api.github.com/users/kiote/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T07:11:36Z","updated_at":"2016-11-22T07:11:36Z","body":"I uncommented passing of the estimators. So now those ones which do not follow the rule \"do not change public attributes\" are failing in the CI."}}
{"actor":{"display_login":"kiote"}}