{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/67786613","id":67786613,"diff_hunk":"@@ -793,15 +826,95 @@ func (oe *operationExecutor) generateUnmountDeviceFunc(\n \t\tmarkDeviceUnmountedErr := actualStateOfWorld.MarkDeviceAsUnmounted(\n \t\t\tdeviceToDetach.VolumeName)\n \t\tif markDeviceUnmountedErr != nil {\n-\t\t\t// On failure, just log and exit. The controller will retry\n-\t\t\tglog.Errorf(\n+\t\t\t// On failure, return error. Caller will log and retry.\n+\t\t\treturn fmt.Errorf(\n \t\t\t\t\"MarkDeviceAsUnmounted failed for device %q (spec.Name: %q) with: %v\",\n \t\t\t\tdeviceToDetach.VolumeName,\n \t\t\t\tdeviceToDetach.VolumeSpec.Name(),\n \t\t\t\tmarkDeviceUnmountedErr)\n-\t\t\treturn markDeviceUnmountedErr\n \t\t}\n \n \t\treturn nil\n \t}, nil\n }\n+\n+func (oe *operationExecutor) generateVerifyControllerAttachedVolumeFunc(\n+\tvolumeToMount VolumeToMount,\n+\tnodeName string,\n+\tactualStateOfWorld ActualStateOfWorldAttacherUpdater) (func() error, error) {\n+\treturn func() error {\n+\t\tif !volumeToMount.PluginIsAttachable {\n+\t\t\t// If the volume does not implement the attacher interface, it is\n+\t\t\t// assumed to be attached and the the actual state of the world is\n+\t\t\t// updated accordingly.\n+\t\t\taddVolumeNodeErr := actualStateOfWorld.MarkVolumeAsAttached(\n+\t\t\t\tvolumeToMount.VolumeSpec, nodeName, volumeToMount.DevicePath)\n+\t\t\tif addVolumeNodeErr != nil {\n+\t\t\t\t// On failure, return error. Caller will log and retry.\n+\t\t\t\treturn fmt.Errorf(\n+\t\t\t\t\t\"VerifyControllerAttachedVolume.MarkVolumeAsAttached failed for volume %q (spec.Name: %q) pod %q (UID: %q) with: %v.\",","path":"pkg/volume/util/operationexecutor/operation_executor.go","position":353,"original_position":353,"commit_id":"046db52fa0190dae1aae6c26dc90240e618b0404","original_commit_id":"046db52fa0190dae1aae6c26dc90240e618b0404","user":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"body":"Just want to make sure, this error will be returned as func() error, or the second error?\r\n'","created_at":"2016-06-20T23:41:53Z","updated_at":"2016-06-20T23:41:53Z","html_url":"https://github.com/kubernetes/kubernetes/pull/27567#discussion_r67786613","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/67786613"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27567#discussion_r67786613"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567","id":74155053,"html_url":"https://github.com/kubernetes/kubernetes/pull/27567","diff_url":"https://github.com/kubernetes/kubernetes/pull/27567.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27567.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27567","number":27567,"state":"open","locked":false,"title":"Kubelet Volume Manager Wait For Attach Detach Controller and Backoff on Error","user":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"body":"* Closes https://github.com/kubernetes/kubernetes/issues/27483\r\n  * Modified Attach/Detach controller to report `Node.Status.AttachedVolumes` on successful attach (unique volume name along with device path).\r\n  * Modified Kubelet Volume Manager wait for Attach/Detach controller to report success before proceeding with attach.\r\n* Closes https://github.com/kubernetes/kubernetes/issues/27492\r\n  * Implemented an exponential backoff mechanism for for volume manager and attach/detach controller to prevent operations (attach/detach/mount/unmount/wait for controller attach/etc) from executing back to back unchecked.\r\n* Closes https://github.com/kubernetes/kubernetes/issues/26679\r\n  * Modified volume `Attacher.WaitForAttach()` methods to uses the device path reported by the Attach/Detach controller in `Node.Status.AttachedVolumes` instead of calling out to cloud providers.\r\n","created_at":"2016-06-16T21:25:42Z","updated_at":"2016-06-20T23:41:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94cebb663049d4ff871e007d392ba00188c7a767","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":863,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-06-20T23:40:09Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27567/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/046db52fa0190dae1aae6c26dc90240e618b0404","head":{"label":"saad-ali:blockKubeletOnAttachController","ref":"blockKubeletOnAttachController","sha":"046db52fa0190dae1aae6c26dc90240e618b0404","user":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"repo":{"id":27614790,"name":"kubernetes","full_name":"saad-ali/kubernetes","owner":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saad-ali/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/saad-ali/kubernetes","forks_url":"https://api.github.com/repos/saad-ali/kubernetes/forks","keys_url":"https://api.github.com/repos/saad-ali/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saad-ali/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saad-ali/kubernetes/teams","hooks_url":"https://api.github.com/repos/saad-ali/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/saad-ali/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/saad-ali/kubernetes/events","assignees_url":"https://api.github.com/repos/saad-ali/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/saad-ali/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/saad-ali/kubernetes/tags","blobs_url":"https://api.github.com/repos/saad-ali/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saad-ali/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saad-ali/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/saad-ali/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saad-ali/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/saad-ali/kubernetes/languages","stargazers_url":"https://api.github.com/repos/saad-ali/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/saad-ali/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/saad-ali/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/saad-ali/kubernetes/subscription","commits_url":"https://api.github.com/repos/saad-ali/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/saad-ali/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/saad-ali/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/saad-ali/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/saad-ali/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/saad-ali/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saad-ali/kubernetes/merges","archive_url":"https://api.github.com/repos/saad-ali/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saad-ali/kubernetes/downloads","issues_url":"https://api.github.com/repos/saad-ali/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/saad-ali/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/saad-ali/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/saad-ali/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saad-ali/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/saad-ali/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/saad-ali/kubernetes/deployments","created_at":"2014-12-05T23:31:31Z","updated_at":"2016-01-22T23:53:04Z","pushed_at":"2016-06-20T07:39:09Z","git_url":"git://github.com/saad-ali/kubernetes.git","ssh_url":"git@github.com:saad-ali/kubernetes.git","clone_url":"https://github.com/saad-ali/kubernetes.git","svn_url":"https://github.com/saad-ali/kubernetes","homepage":null,"size":262955,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a055c4e80f25db190805749481fe8c70b8900ce5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-20T21:51:25Z","pushed_at":"2016-06-20T23:40:11Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":481368,"stargazers_count":15007,"watchers_count":15007,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4653,"mirror_url":null,"open_issues_count":3773,"forks":4653,"open_issues":3773,"watchers":15007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27567"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27567"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27567/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27567/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/046db52fa0190dae1aae6c26dc90240e618b0404"}}}}
{"actor":{"display_login":"jingxu97"}}