{"action":"closed","number":175,"pull_request":{"url":"https://api.github.com/repos/log4cplus/log4cplus/pulls/175","id":69485910,"html_url":"https://github.com/log4cplus/log4cplus/pull/175","diff_url":"https://github.com/log4cplus/log4cplus/pull/175.diff","patch_url":"https://github.com/log4cplus/log4cplus/pull/175.patch","issue_url":"https://api.github.com/repos/log4cplus/log4cplus/issues/175","number":175,"state":"closed","locked":false,"title":"proposal for SocketBuffer v4","user":{"login":"joseAndresGomezTovar","id":6407828,"avatar_url":"https://avatars.githubusercontent.com/u/6407828?v=3","gravatar_id":"","url":"https://api.github.com/users/joseAndresGomezTovar","html_url":"https://github.com/joseAndresGomezTovar","followers_url":"https://api.github.com/users/joseAndresGomezTovar/followers","following_url":"https://api.github.com/users/joseAndresGomezTovar/following{/other_user}","gists_url":"https://api.github.com/users/joseAndresGomezTovar/gists{/gist_id}","starred_url":"https://api.github.com/users/joseAndresGomezTovar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseAndresGomezTovar/subscriptions","organizations_url":"https://api.github.com/users/joseAndresGomezTovar/orgs","repos_url":"https://api.github.com/users/joseAndresGomezTovar/repos","events_url":"https://api.github.com/users/joseAndresGomezTovar/events{/privacy}","received_events_url":"https://api.github.com/users/joseAndresGomezTovar/received_events","type":"User","site_admin":false},"body":"It could be nice to have the \"proccess id\" of the client.\r\nit could be done like\r\n\r\n```cpp\r\nconvertToBuffer(SocketBuffer & buffer,\r\n    const spi::InternalLoggingEvent& event,\r\n    const tstring& serverName)\r\n{\r\n    buffer.appendByte(LOG4CPLUS_MESSAGE_VERSION); //v4\r\n#ifndef UNICODE\r\n    buffer.appendByte(1);\r\n#else\r\n    buffer.appendByte(2);\r\n#endif\r\n\r\n    buffer.appendString(serverName);\r\n    buffer.appendString(event.getLoggerName());\r\n    buffer.appendInt(event.getLogLevel());\r\n    buffer.appendString(event.getNDC());\r\n    buffer.appendString(event.getMessage());\r\n    buffer.appendString(event.getThread());\r\n    buffer.appendString(event.getProcessId());\r\n    buffer.appendInt( static_cast<unsigned int>(event.getTimestamp().sec()) );\r\n    buffer.appendInt( static_cast<unsigned int>(event.getTimestamp().usec()) );\r\n    buffer.appendString(event.getFile());\r\n    buffer.appendInt(event.getLine());\r\n    buffer.appendString(event.getFunction());\r\n}\r\n```\r\n\r\n`%i` - process id\r\n`%t` - thread id\r\n`%ii` - client proccess id\r\n\r\nwhat do you think?","created_at":"2016-05-10T10:54:47Z","updated_at":"2016-07-24T15:11:33Z","closed_at":"2016-07-24T15:11:33Z","merged_at":null,"merge_commit_sha":null,"assignee":{"login":"wilx","id":1098563,"avatar_url":"https://avatars.githubusercontent.com/u/1098563?v=3","gravatar_id":"","url":"https://api.github.com/users/wilx","html_url":"https://github.com/wilx","followers_url":"https://api.github.com/users/wilx/followers","following_url":"https://api.github.com/users/wilx/following{/other_user}","gists_url":"https://api.github.com/users/wilx/gists{/gist_id}","starred_url":"https://api.github.com/users/wilx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilx/subscriptions","organizations_url":"https://api.github.com/users/wilx/orgs","repos_url":"https://api.github.com/users/wilx/repos","events_url":"https://api.github.com/users/wilx/events{/privacy}","received_events_url":"https://api.github.com/users/wilx/received_events","type":"User","site_admin":false},"assignees":[{"login":"wilx","id":1098563,"avatar_url":"https://avatars.githubusercontent.com/u/1098563?v=3","gravatar_id":"","url":"https://api.github.com/users/wilx","html_url":"https://github.com/wilx","followers_url":"https://api.github.com/users/wilx/followers","following_url":"https://api.github.com/users/wilx/following{/other_user}","gists_url":"https://api.github.com/users/wilx/gists{/gist_id}","starred_url":"https://api.github.com/users/wilx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilx/subscriptions","organizations_url":"https://api.github.com/users/wilx/orgs","repos_url":"https://api.github.com/users/wilx/repos","events_url":"https://api.github.com/users/wilx/events{/privacy}","received_events_url":"https://api.github.com/users/wilx/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/log4cplus/log4cplus/pulls/175/commits","review_comments_url":"https://api.github.com/repos/log4cplus/log4cplus/pulls/175/comments","review_comment_url":"https://api.github.com/repos/log4cplus/log4cplus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/log4cplus/log4cplus/issues/175/comments","statuses_url":"https://api.github.com/repos/log4cplus/log4cplus/statuses/7912cb47d769b33dcb11e4b68470dd4b196f73fd","head":{"label":"log4cplus:master","ref":"master","sha":"7912cb47d769b33dcb11e4b68470dd4b196f73fd","user":{"login":"log4cplus","id":6375941,"avatar_url":"https://avatars.githubusercontent.com/u/6375941?v=3","gravatar_id":"","url":"https://api.github.com/users/log4cplus","html_url":"https://github.com/log4cplus","followers_url":"https://api.github.com/users/log4cplus/followers","following_url":"https://api.github.com/users/log4cplus/following{/other_user}","gists_url":"https://api.github.com/users/log4cplus/gists{/gist_id}","starred_url":"https://api.github.com/users/log4cplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/log4cplus/subscriptions","organizations_url":"https://api.github.com/users/log4cplus/orgs","repos_url":"https://api.github.com/users/log4cplus/repos","events_url":"https://api.github.com/users/log4cplus/events{/privacy}","received_events_url":"https://api.github.com/users/log4cplus/received_events","type":"Organization","site_admin":false},"repo":{"id":15830219,"name":"log4cplus","full_name":"log4cplus/log4cplus","owner":{"login":"log4cplus","id":6375941,"avatar_url":"https://avatars.githubusercontent.com/u/6375941?v=3","gravatar_id":"","url":"https://api.github.com/users/log4cplus","html_url":"https://github.com/log4cplus","followers_url":"https://api.github.com/users/log4cplus/followers","following_url":"https://api.github.com/users/log4cplus/following{/other_user}","gists_url":"https://api.github.com/users/log4cplus/gists{/gist_id}","starred_url":"https://api.github.com/users/log4cplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/log4cplus/subscriptions","organizations_url":"https://api.github.com/users/log4cplus/orgs","repos_url":"https://api.github.com/users/log4cplus/repos","events_url":"https://api.github.com/users/log4cplus/events{/privacy}","received_events_url":"https://api.github.com/users/log4cplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/log4cplus/log4cplus","description":"log4cplus is a simple to use C++ logging API providing thread-safe, flexible, and arbitrarily granular control over log management and configuration. It is modelled after the Java log4j API.","fork":false,"url":"https://api.github.com/repos/log4cplus/log4cplus","forks_url":"https://api.github.com/repos/log4cplus/log4cplus/forks","keys_url":"https://api.github.com/repos/log4cplus/log4cplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/log4cplus/log4cplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/log4cplus/log4cplus/teams","hooks_url":"https://api.github.com/repos/log4cplus/log4cplus/hooks","issue_events_url":"https://api.github.com/repos/log4cplus/log4cplus/issues/events{/number}","events_url":"https://api.github.com/repos/log4cplus/log4cplus/events","assignees_url":"https://api.github.com/repos/log4cplus/log4cplus/assignees{/user}","branches_url":"https://api.github.com/repos/log4cplus/log4cplus/branches{/branch}","tags_url":"https://api.github.com/repos/log4cplus/log4cplus/tags","blobs_url":"https://api.github.com/repos/log4cplus/log4cplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/log4cplus/log4cplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/log4cplus/log4cplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/log4cplus/log4cplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/log4cplus/log4cplus/statuses/{sha}","languages_url":"https://api.github.com/repos/log4cplus/log4cplus/languages","stargazers_url":"https://api.github.com/repos/log4cplus/log4cplus/stargazers","contributors_url":"https://api.github.com/repos/log4cplus/log4cplus/contributors","subscribers_url":"https://api.github.com/repos/log4cplus/log4cplus/subscribers","subscription_url":"https://api.github.com/repos/log4cplus/log4cplus/subscription","commits_url":"https://api.github.com/repos/log4cplus/log4cplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/log4cplus/log4cplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/log4cplus/log4cplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/log4cplus/log4cplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/log4cplus/log4cplus/contents/{+path}","compare_url":"https://api.github.com/repos/log4cplus/log4cplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/log4cplus/log4cplus/merges","archive_url":"https://api.github.com/repos/log4cplus/log4cplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/log4cplus/log4cplus/downloads","issues_url":"https://api.github.com/repos/log4cplus/log4cplus/issues{/number}","pulls_url":"https://api.github.com/repos/log4cplus/log4cplus/pulls{/number}","milestones_url":"https://api.github.com/repos/log4cplus/log4cplus/milestones{/number}","notifications_url":"https://api.github.com/repos/log4cplus/log4cplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/log4cplus/log4cplus/labels{/name}","releases_url":"https://api.github.com/repos/log4cplus/log4cplus/releases{/id}","deployments_url":"https://api.github.com/repos/log4cplus/log4cplus/deployments","created_at":"2014-01-11T20:37:02Z","updated_at":"2016-07-17T02:57:38Z","pushed_at":"2016-07-24T15:03:46Z","git_url":"git://github.com/log4cplus/log4cplus.git","ssh_url":"git@github.com:log4cplus/log4cplus.git","clone_url":"https://github.com/log4cplus/log4cplus.git","svn_url":"https://github.com/log4cplus/log4cplus","homepage":"https://sourceforge.net/projects/log4cplus/","size":23798,"stargazers_count":251,"watchers_count":251,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":7,"forks":160,"open_issues":7,"watchers":251,"default_branch":"master"}},"base":{"label":"log4cplus:1.2.x","ref":"1.2.x","sha":"1a4a39c20c4ce1b00e9f661d1ae62716cc821fd1","user":{"login":"log4cplus","id":6375941,"avatar_url":"https://avatars.githubusercontent.com/u/6375941?v=3","gravatar_id":"","url":"https://api.github.com/users/log4cplus","html_url":"https://github.com/log4cplus","followers_url":"https://api.github.com/users/log4cplus/followers","following_url":"https://api.github.com/users/log4cplus/following{/other_user}","gists_url":"https://api.github.com/users/log4cplus/gists{/gist_id}","starred_url":"https://api.github.com/users/log4cplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/log4cplus/subscriptions","organizations_url":"https://api.github.com/users/log4cplus/orgs","repos_url":"https://api.github.com/users/log4cplus/repos","events_url":"https://api.github.com/users/log4cplus/events{/privacy}","received_events_url":"https://api.github.com/users/log4cplus/received_events","type":"Organization","site_admin":false},"repo":{"id":15830219,"name":"log4cplus","full_name":"log4cplus/log4cplus","owner":{"login":"log4cplus","id":6375941,"avatar_url":"https://avatars.githubusercontent.com/u/6375941?v=3","gravatar_id":"","url":"https://api.github.com/users/log4cplus","html_url":"https://github.com/log4cplus","followers_url":"https://api.github.com/users/log4cplus/followers","following_url":"https://api.github.com/users/log4cplus/following{/other_user}","gists_url":"https://api.github.com/users/log4cplus/gists{/gist_id}","starred_url":"https://api.github.com/users/log4cplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/log4cplus/subscriptions","organizations_url":"https://api.github.com/users/log4cplus/orgs","repos_url":"https://api.github.com/users/log4cplus/repos","events_url":"https://api.github.com/users/log4cplus/events{/privacy}","received_events_url":"https://api.github.com/users/log4cplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/log4cplus/log4cplus","description":"log4cplus is a simple to use C++ logging API providing thread-safe, flexible, and arbitrarily granular control over log management and configuration. It is modelled after the Java log4j API.","fork":false,"url":"https://api.github.com/repos/log4cplus/log4cplus","forks_url":"https://api.github.com/repos/log4cplus/log4cplus/forks","keys_url":"https://api.github.com/repos/log4cplus/log4cplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/log4cplus/log4cplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/log4cplus/log4cplus/teams","hooks_url":"https://api.github.com/repos/log4cplus/log4cplus/hooks","issue_events_url":"https://api.github.com/repos/log4cplus/log4cplus/issues/events{/number}","events_url":"https://api.github.com/repos/log4cplus/log4cplus/events","assignees_url":"https://api.github.com/repos/log4cplus/log4cplus/assignees{/user}","branches_url":"https://api.github.com/repos/log4cplus/log4cplus/branches{/branch}","tags_url":"https://api.github.com/repos/log4cplus/log4cplus/tags","blobs_url":"https://api.github.com/repos/log4cplus/log4cplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/log4cplus/log4cplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/log4cplus/log4cplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/log4cplus/log4cplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/log4cplus/log4cplus/statuses/{sha}","languages_url":"https://api.github.com/repos/log4cplus/log4cplus/languages","stargazers_url":"https://api.github.com/repos/log4cplus/log4cplus/stargazers","contributors_url":"https://api.github.com/repos/log4cplus/log4cplus/contributors","subscribers_url":"https://api.github.com/repos/log4cplus/log4cplus/subscribers","subscription_url":"https://api.github.com/repos/log4cplus/log4cplus/subscription","commits_url":"https://api.github.com/repos/log4cplus/log4cplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/log4cplus/log4cplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/log4cplus/log4cplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/log4cplus/log4cplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/log4cplus/log4cplus/contents/{+path}","compare_url":"https://api.github.com/repos/log4cplus/log4cplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/log4cplus/log4cplus/merges","archive_url":"https://api.github.com/repos/log4cplus/log4cplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/log4cplus/log4cplus/downloads","issues_url":"https://api.github.com/repos/log4cplus/log4cplus/issues{/number}","pulls_url":"https://api.github.com/repos/log4cplus/log4cplus/pulls{/number}","milestones_url":"https://api.github.com/repos/log4cplus/log4cplus/milestones{/number}","notifications_url":"https://api.github.com/repos/log4cplus/log4cplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/log4cplus/log4cplus/labels{/name}","releases_url":"https://api.github.com/repos/log4cplus/log4cplus/releases{/id}","deployments_url":"https://api.github.com/repos/log4cplus/log4cplus/deployments","created_at":"2014-01-11T20:37:02Z","updated_at":"2016-07-17T02:57:38Z","pushed_at":"2016-07-24T15:03:46Z","git_url":"git://github.com/log4cplus/log4cplus.git","ssh_url":"git@github.com:log4cplus/log4cplus.git","clone_url":"https://github.com/log4cplus/log4cplus.git","svn_url":"https://github.com/log4cplus/log4cplus","homepage":"https://sourceforge.net/projects/log4cplus/","size":23798,"stargazers_count":251,"watchers_count":251,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":7,"forks":160,"open_issues":7,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/log4cplus/log4cplus/pulls/175"},"html":{"href":"https://github.com/log4cplus/log4cplus/pull/175"},"issue":{"href":"https://api.github.com/repos/log4cplus/log4cplus/issues/175"},"comments":{"href":"https://api.github.com/repos/log4cplus/log4cplus/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/log4cplus/log4cplus/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/log4cplus/log4cplus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/log4cplus/log4cplus/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/log4cplus/log4cplus/statuses/7912cb47d769b33dcb11e4b68470dd4b196f73fd"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":465,"additions":22227,"deletions":16870,"changed_files":416}}
{"actor":{"display_login":"wilx"}}