{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/client/issues/20","repository_url":"https://api.github.com/repos/hypothesis/client","labels_url":"https://api.github.com/repos/hypothesis/client/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/client/issues/20/comments","events_url":"https://api.github.com/repos/hypothesis/client/issues/20/events","html_url":"https://github.com/hypothesis/client/pull/20","id":163858207,"number":20,"title":"Defer initialization of websocket client until sidebar is interacted with for logged-out users","user":{"login":"finitud","id":209716,"avatar_url":"https://avatars.githubusercontent.com/u/209716?v=3","gravatar_id":"","url":"https://api.github.com/users/finitud","html_url":"https://github.com/finitud","followers_url":"https://api.github.com/users/finitud/followers","following_url":"https://api.github.com/users/finitud/following{/other_user}","gists_url":"https://api.github.com/users/finitud/gists{/gist_id}","starred_url":"https://api.github.com/users/finitud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finitud/subscriptions","organizations_url":"https://api.github.com/users/finitud/orgs","repos_url":"https://api.github.com/users/finitud/repos","events_url":"https://api.github.com/users/finitud/events{/privacy}","received_events_url":"https://api.github.com/users/finitud/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hypothesis/client/labels/WIP","name":"WIP","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"assignees":[{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-05T14:02:14Z","updated_at":"2016-07-12T09:34:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/client/pulls/20","html_url":"https://github.com/hypothesis/client/pull/20","diff_url":"https://github.com/hypothesis/client/pull/20.diff","patch_url":"https://github.com/hypothesis/client/pull/20.patch"},"body":"https://trello.com/c/53uY3Xit/386-defer-initialization-of-websocket-client-until-sidebar-is-interacted-with-for-logged-out-users#"},"comment":{"url":"https://api.github.com/repos/hypothesis/client/issues/comments/231988222","html_url":"https://github.com/hypothesis/client/pull/20#issuecomment-231988222","issue_url":"https://api.github.com/repos/hypothesis/client/issues/20","id":231988222,"user":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T09:34:48Z","updated_at":"2016-07-12T09:34:48Z","body":"> What sort of testing would this require for the WidgetController?\r\n\r\nI think its a case of enumerating the user-facing behavior changes and making sure we have tests for those. Off the top of my head:\r\n\r\n- When the sidebar opens, the WebSocket should connect but only the first time\r\n- When the authenticated user changes, the WebSocket should reconnect, but only if the sidebar was open\r\n\r\nWe have several other event handlers in that class, I'd suggest having a look at those for examples of how the tests work."}}
{"actor":{"display_login":"robertknight"}}