{"action":"created","comment":{"url":"https://api.github.com/repos/atom/apm/pulls/comments/71981500","id":71981500,"diff_hunk":"@@ -71,6 +72,7 @@ class Dedupe extends Command\n \n   forkDedupeCommand: (options, callback) ->\n     dedupeArgs = ['--globalconfig', config.getGlobalConfigPath(), '--userconfig', config.getUserConfigPath(), 'dedupe']\n+    dedupeArgs.push(\"--runtime=electron\")","path":"src/dedupe.coffee","position":16,"original_position":12,"commit_id":"a5d467635d19a0f6ed998d1a5749f50121522a79","original_commit_id":"500aba9fe01e303fe324516fae5f01211b095806","user":{"login":"maxbrunsfeld","id":326587,"avatar_url":"https://avatars.githubusercontent.com/u/326587?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbrunsfeld","html_url":"https://github.com/maxbrunsfeld","followers_url":"https://api.github.com/users/maxbrunsfeld/followers","following_url":"https://api.github.com/users/maxbrunsfeld/following{/other_user}","gists_url":"https://api.github.com/users/maxbrunsfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbrunsfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbrunsfeld/subscriptions","organizations_url":"https://api.github.com/users/maxbrunsfeld/orgs","repos_url":"https://api.github.com/users/maxbrunsfeld/repos","events_url":"https://api.github.com/users/maxbrunsfeld/events{/privacy}","received_events_url":"https://api.github.com/users/maxbrunsfeld/received_events","type":"User","site_admin":true},"body":"I believe the variable is called `dedupeArgs` because it is the list of arguments passed to `npm dedupe`","created_at":"2016-07-24T03:52:10Z","updated_at":"2016-07-24T03:52:10Z","html_url":"https://github.com/atom/apm/pull/596#discussion_r71981500","pull_request_url":"https://api.github.com/repos/atom/apm/pulls/596","_links":{"self":{"href":"https://api.github.com/repos/atom/apm/pulls/comments/71981500"},"html":{"href":"https://github.com/atom/apm/pull/596#discussion_r71981500"},"pull_request":{"href":"https://api.github.com/repos/atom/apm/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/atom/apm/pulls/596","id":78477371,"html_url":"https://github.com/atom/apm/pull/596","diff_url":"https://github.com/atom/apm/pull/596.diff","patch_url":"https://github.com/atom/apm/pull/596.patch","issue_url":"https://api.github.com/repos/atom/apm/issues/596","number":596,"state":"closed","locked":false,"title":"Fix missing and hardcoded flags","user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":true},"body":"This pull-request fixes a problem when installing dependencies via `apm` that prevents the runtime from being recognized, causing packages such as nodegit to fail the build. In particular, we are adding the `--runtime=electron` flag to every `npm` command that interfaces with modules installation and their subsequent compilation. \r\n\r\nPlease, note that this is the approach that [electron-rebuild uses too](https://github.com/electron/electron-rebuild/blob/27158b165715731836425369c5c5e680420c7cd9/src/main.js#L122-L126).\r\n\r\nWhile in the process of adding such flag, we spotted a couple of places in the `dedupe` command where the target architecture of native modules was being hardcoded; this was probably not an issue, but it feels reasonable to use `config.getElectronArch()` as we do elsewhere.\r\n\r\n@atom/core: I'd ❤️ to have some more 👀 on this, so that we can 🚢 it before getting the new `apm` version into beta.","created_at":"2016-07-22T13:31:47Z","updated_at":"2016-07-24T03:52:10Z","closed_at":"2016-07-22T16:02:02Z","merged_at":"2016-07-22T16:02:02Z","merge_commit_sha":"3b36e184a553d1e832efa713115408dd97ee1fe4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/apm/pulls/596/commits","review_comments_url":"https://api.github.com/repos/atom/apm/pulls/596/comments","review_comment_url":"https://api.github.com/repos/atom/apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/apm/issues/596/comments","statuses_url":"https://api.github.com/repos/atom/apm/statuses/a5d467635d19a0f6ed998d1a5749f50121522a79","head":{"label":"atom:as-fix-missing-flags","ref":"as-fix-missing-flags","sha":"a5d467635d19a0f6ed998d1a5749f50121522a79","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9916379,"name":"apm","full_name":"atom/apm","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/apm","description":"Atom Package Manager","fork":false,"url":"https://api.github.com/repos/atom/apm","forks_url":"https://api.github.com/repos/atom/apm/forks","keys_url":"https://api.github.com/repos/atom/apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/apm/teams","hooks_url":"https://api.github.com/repos/atom/apm/hooks","issue_events_url":"https://api.github.com/repos/atom/apm/issues/events{/number}","events_url":"https://api.github.com/repos/atom/apm/events","assignees_url":"https://api.github.com/repos/atom/apm/assignees{/user}","branches_url":"https://api.github.com/repos/atom/apm/branches{/branch}","tags_url":"https://api.github.com/repos/atom/apm/tags","blobs_url":"https://api.github.com/repos/atom/apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/apm/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/apm/languages","stargazers_url":"https://api.github.com/repos/atom/apm/stargazers","contributors_url":"https://api.github.com/repos/atom/apm/contributors","subscribers_url":"https://api.github.com/repos/atom/apm/subscribers","subscription_url":"https://api.github.com/repos/atom/apm/subscription","commits_url":"https://api.github.com/repos/atom/apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/apm/contents/{+path}","compare_url":"https://api.github.com/repos/atom/apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/apm/merges","archive_url":"https://api.github.com/repos/atom/apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/apm/downloads","issues_url":"https://api.github.com/repos/atom/apm/issues{/number}","pulls_url":"https://api.github.com/repos/atom/apm/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/apm/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/apm/labels{/name}","releases_url":"https://api.github.com/repos/atom/apm/releases{/id}","deployments_url":"https://api.github.com/repos/atom/apm/deployments","created_at":"2013-05-07T16:27:05Z","updated_at":"2016-07-24T02:33:46Z","pushed_at":"2016-07-22T16:03:09Z","git_url":"git://github.com/atom/apm.git","ssh_url":"git@github.com:atom/apm.git","clone_url":"https://github.com/atom/apm.git","svn_url":"https://github.com/atom/apm","homepage":"https://atom.io/packages","size":6061,"stargazers_count":714,"watchers_count":714,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":138,"forks":147,"open_issues":138,"watchers":714,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"546b3371ec22e3fa7c325e24047fe5fc7e06dcb6","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9916379,"name":"apm","full_name":"atom/apm","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/apm","description":"Atom Package Manager","fork":false,"url":"https://api.github.com/repos/atom/apm","forks_url":"https://api.github.com/repos/atom/apm/forks","keys_url":"https://api.github.com/repos/atom/apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/apm/teams","hooks_url":"https://api.github.com/repos/atom/apm/hooks","issue_events_url":"https://api.github.com/repos/atom/apm/issues/events{/number}","events_url":"https://api.github.com/repos/atom/apm/events","assignees_url":"https://api.github.com/repos/atom/apm/assignees{/user}","branches_url":"https://api.github.com/repos/atom/apm/branches{/branch}","tags_url":"https://api.github.com/repos/atom/apm/tags","blobs_url":"https://api.github.com/repos/atom/apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/apm/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/apm/languages","stargazers_url":"https://api.github.com/repos/atom/apm/stargazers","contributors_url":"https://api.github.com/repos/atom/apm/contributors","subscribers_url":"https://api.github.com/repos/atom/apm/subscribers","subscription_url":"https://api.github.com/repos/atom/apm/subscription","commits_url":"https://api.github.com/repos/atom/apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/apm/contents/{+path}","compare_url":"https://api.github.com/repos/atom/apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/apm/merges","archive_url":"https://api.github.com/repos/atom/apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/apm/downloads","issues_url":"https://api.github.com/repos/atom/apm/issues{/number}","pulls_url":"https://api.github.com/repos/atom/apm/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/apm/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/apm/labels{/name}","releases_url":"https://api.github.com/repos/atom/apm/releases{/id}","deployments_url":"https://api.github.com/repos/atom/apm/deployments","created_at":"2013-05-07T16:27:05Z","updated_at":"2016-07-24T02:33:46Z","pushed_at":"2016-07-22T16:03:09Z","git_url":"git://github.com/atom/apm.git","ssh_url":"git@github.com:atom/apm.git","clone_url":"https://github.com/atom/apm.git","svn_url":"https://github.com/atom/apm","homepage":"https://atom.io/packages","size":6061,"stargazers_count":714,"watchers_count":714,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":138,"forks":147,"open_issues":138,"watchers":714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/apm/pulls/596"},"html":{"href":"https://github.com/atom/apm/pull/596"},"issue":{"href":"https://api.github.com/repos/atom/apm/issues/596"},"comments":{"href":"https://api.github.com/repos/atom/apm/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/apm/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/apm/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/atom/apm/statuses/a5d467635d19a0f6ed998d1a5749f50121522a79"}}}}
{"actor":{"display_login":"maxbrunsfeld"}}