{"action":"closed","number":1137,"pull_request":{"url":"https://api.github.com/repos/antlr/antlr4/pulls/1137","id":62836798,"html_url":"https://github.com/antlr/antlr4/pull/1137","diff_url":"https://github.com/antlr/antlr4/pull/1137.diff","patch_url":"https://github.com/antlr/antlr4/pull/1137.patch","issue_url":"https://api.github.com/repos/antlr/antlr4/issues/1137","number":1137,"state":"closed","locked":false,"title":"JS: Do deep Actions array comparison in LexerActionExecutor equals()","user":{"login":"dtymon","id":1925877,"avatar_url":"https://avatars.githubusercontent.com/u/1925877?v=3","gravatar_id":"","url":"https://api.github.com/users/dtymon","html_url":"https://github.com/dtymon","followers_url":"https://api.github.com/users/dtymon/followers","following_url":"https://api.github.com/users/dtymon/following{/other_user}","gists_url":"https://api.github.com/users/dtymon/gists{/gist_id}","starred_url":"https://api.github.com/users/dtymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtymon/subscriptions","organizations_url":"https://api.github.com/users/dtymon/orgs","repos_url":"https://api.github.com/users/dtymon/repos","events_url":"https://api.github.com/users/dtymon/events{/privacy}","received_events_url":"https://api.github.com/users/dtymon/received_events","type":"User","site_admin":false},"body":"According to the corresponding Java implementation, the equals() method for LexerActionExecutor should be doing an equals() test on each of the actions rather than testing the Array reference is equal.","created_at":"2016-03-15T00:03:57Z","updated_at":"2016-03-30T16:38:56Z","closed_at":"2016-03-30T16:38:56Z","merged_at":"2016-03-30T16:38:56Z","merge_commit_sha":"0c804f0a28c6b0653b2019d19c37beec32e68138","assignee":null,"milestone":{"url":"https://api.github.com/repos/antlr/antlr4/milestones/14","html_url":"https://github.com/antlr/antlr4/milestones/4.5.3","labels_url":"https://api.github.com/repos/antlr/antlr4/milestones/14/labels","id":1576442,"number":14,"title":"4.5.3","description":null,"creator":{"login":"parrt","id":178777,"avatar_url":"https://avatars.githubusercontent.com/u/178777?v=3","gravatar_id":"","url":"https://api.github.com/users/parrt","html_url":"https://github.com/parrt","followers_url":"https://api.github.com/users/parrt/followers","following_url":"https://api.github.com/users/parrt/following{/other_user}","gists_url":"https://api.github.com/users/parrt/gists{/gist_id}","starred_url":"https://api.github.com/users/parrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parrt/subscriptions","organizations_url":"https://api.github.com/users/parrt/orgs","repos_url":"https://api.github.com/users/parrt/repos","events_url":"https://api.github.com/users/parrt/events{/privacy}","received_events_url":"https://api.github.com/users/parrt/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":15,"state":"open","created_at":"2016-02-10T20:40:49Z","updated_at":"2016-03-30T16:38:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/antlr/antlr4/pulls/1137/commits","review_comments_url":"https://api.github.com/repos/antlr/antlr4/pulls/1137/comments","review_comment_url":"https://api.github.com/repos/antlr/antlr4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/antlr/antlr4/issues/1137/comments","statuses_url":"https://api.github.com/repos/antlr/antlr4/statuses/0262aac8f6ef2a65efd724448c9adae76c6d4ade","head":{"label":"dtymon:04_lexerActionExecutor_equals","ref":"04_lexerActionExecutor_equals","sha":"0262aac8f6ef2a65efd724448c9adae76c6d4ade","user":{"login":"dtymon","id":1925877,"avatar_url":"https://avatars.githubusercontent.com/u/1925877?v=3","gravatar_id":"","url":"https://api.github.com/users/dtymon","html_url":"https://github.com/dtymon","followers_url":"https://api.github.com/users/dtymon/followers","following_url":"https://api.github.com/users/dtymon/following{/other_user}","gists_url":"https://api.github.com/users/dtymon/gists{/gist_id}","starred_url":"https://api.github.com/users/dtymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtymon/subscriptions","organizations_url":"https://api.github.com/users/dtymon/orgs","repos_url":"https://api.github.com/users/dtymon/repos","events_url":"https://api.github.com/users/dtymon/events{/privacy}","received_events_url":"https://api.github.com/users/dtymon/received_events","type":"User","site_admin":false},"repo":{"id":48459626,"name":"antlr4","full_name":"dtymon/antlr4","owner":{"login":"dtymon","id":1925877,"avatar_url":"https://avatars.githubusercontent.com/u/1925877?v=3","gravatar_id":"","url":"https://api.github.com/users/dtymon","html_url":"https://github.com/dtymon","followers_url":"https://api.github.com/users/dtymon/followers","following_url":"https://api.github.com/users/dtymon/following{/other_user}","gists_url":"https://api.github.com/users/dtymon/gists{/gist_id}","starred_url":"https://api.github.com/users/dtymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtymon/subscriptions","organizations_url":"https://api.github.com/users/dtymon/orgs","repos_url":"https://api.github.com/users/dtymon/repos","events_url":"https://api.github.com/users/dtymon/events{/privacy}","received_events_url":"https://api.github.com/users/dtymon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtymon/antlr4","description":"ANTLR (ANother Tool for Language Recognition) is a powerful parser generator for reading, processing, executing, or translating structured text or binary files.","fork":true,"url":"https://api.github.com/repos/dtymon/antlr4","forks_url":"https://api.github.com/repos/dtymon/antlr4/forks","keys_url":"https://api.github.com/repos/dtymon/antlr4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtymon/antlr4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtymon/antlr4/teams","hooks_url":"https://api.github.com/repos/dtymon/antlr4/hooks","issue_events_url":"https://api.github.com/repos/dtymon/antlr4/issues/events{/number}","events_url":"https://api.github.com/repos/dtymon/antlr4/events","assignees_url":"https://api.github.com/repos/dtymon/antlr4/assignees{/user}","branches_url":"https://api.github.com/repos/dtymon/antlr4/branches{/branch}","tags_url":"https://api.github.com/repos/dtymon/antlr4/tags","blobs_url":"https://api.github.com/repos/dtymon/antlr4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtymon/antlr4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtymon/antlr4/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtymon/antlr4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtymon/antlr4/statuses/{sha}","languages_url":"https://api.github.com/repos/dtymon/antlr4/languages","stargazers_url":"https://api.github.com/repos/dtymon/antlr4/stargazers","contributors_url":"https://api.github.com/repos/dtymon/antlr4/contributors","subscribers_url":"https://api.github.com/repos/dtymon/antlr4/subscribers","subscription_url":"https://api.github.com/repos/dtymon/antlr4/subscription","commits_url":"https://api.github.com/repos/dtymon/antlr4/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtymon/antlr4/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtymon/antlr4/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtymon/antlr4/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtymon/antlr4/contents/{+path}","compare_url":"https://api.github.com/repos/dtymon/antlr4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtymon/antlr4/merges","archive_url":"https://api.github.com/repos/dtymon/antlr4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtymon/antlr4/downloads","issues_url":"https://api.github.com/repos/dtymon/antlr4/issues{/number}","pulls_url":"https://api.github.com/repos/dtymon/antlr4/pulls{/number}","milestones_url":"https://api.github.com/repos/dtymon/antlr4/milestones{/number}","notifications_url":"https://api.github.com/repos/dtymon/antlr4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtymon/antlr4/labels{/name}","releases_url":"https://api.github.com/repos/dtymon/antlr4/releases{/id}","deployments_url":"https://api.github.com/repos/dtymon/antlr4/deployments","created_at":"2015-12-22T23:57:21Z","updated_at":"2016-01-29T04:41:54Z","pushed_at":"2016-03-15T02:39:48Z","git_url":"git://github.com/dtymon/antlr4.git","ssh_url":"git@github.com:dtymon/antlr4.git","clone_url":"https://github.com/dtymon/antlr4.git","svn_url":"https://github.com/dtymon/antlr4","homepage":"http://antlr.org","size":32045,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"antlr:master","ref":"master","sha":"d0fb48c2b89128158950f4b32a61d50d52d981ea","user":{"login":"antlr","id":80584,"avatar_url":"https://avatars.githubusercontent.com/u/80584?v=3","gravatar_id":"","url":"https://api.github.com/users/antlr","html_url":"https://github.com/antlr","followers_url":"https://api.github.com/users/antlr/followers","following_url":"https://api.github.com/users/antlr/following{/other_user}","gists_url":"https://api.github.com/users/antlr/gists{/gist_id}","starred_url":"https://api.github.com/users/antlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antlr/subscriptions","organizations_url":"https://api.github.com/users/antlr/orgs","repos_url":"https://api.github.com/users/antlr/repos","events_url":"https://api.github.com/users/antlr/events{/privacy}","received_events_url":"https://api.github.com/users/antlr/received_events","type":"Organization","site_admin":false},"repo":{"id":501687,"name":"antlr4","full_name":"antlr/antlr4","owner":{"login":"antlr","id":80584,"avatar_url":"https://avatars.githubusercontent.com/u/80584?v=3","gravatar_id":"","url":"https://api.github.com/users/antlr","html_url":"https://github.com/antlr","followers_url":"https://api.github.com/users/antlr/followers","following_url":"https://api.github.com/users/antlr/following{/other_user}","gists_url":"https://api.github.com/users/antlr/gists{/gist_id}","starred_url":"https://api.github.com/users/antlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antlr/subscriptions","organizations_url":"https://api.github.com/users/antlr/orgs","repos_url":"https://api.github.com/users/antlr/repos","events_url":"https://api.github.com/users/antlr/events{/privacy}","received_events_url":"https://api.github.com/users/antlr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/antlr/antlr4","description":"ANTLR (ANother Tool for Language Recognition) is a powerful parser generator for reading, processing, executing, or translating structured text or binary files.","fork":false,"url":"https://api.github.com/repos/antlr/antlr4","forks_url":"https://api.github.com/repos/antlr/antlr4/forks","keys_url":"https://api.github.com/repos/antlr/antlr4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antlr/antlr4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antlr/antlr4/teams","hooks_url":"https://api.github.com/repos/antlr/antlr4/hooks","issue_events_url":"https://api.github.com/repos/antlr/antlr4/issues/events{/number}","events_url":"https://api.github.com/repos/antlr/antlr4/events","assignees_url":"https://api.github.com/repos/antlr/antlr4/assignees{/user}","branches_url":"https://api.github.com/repos/antlr/antlr4/branches{/branch}","tags_url":"https://api.github.com/repos/antlr/antlr4/tags","blobs_url":"https://api.github.com/repos/antlr/antlr4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antlr/antlr4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antlr/antlr4/git/refs{/sha}","trees_url":"https://api.github.com/repos/antlr/antlr4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antlr/antlr4/statuses/{sha}","languages_url":"https://api.github.com/repos/antlr/antlr4/languages","stargazers_url":"https://api.github.com/repos/antlr/antlr4/stargazers","contributors_url":"https://api.github.com/repos/antlr/antlr4/contributors","subscribers_url":"https://api.github.com/repos/antlr/antlr4/subscribers","subscription_url":"https://api.github.com/repos/antlr/antlr4/subscription","commits_url":"https://api.github.com/repos/antlr/antlr4/commits{/sha}","git_commits_url":"https://api.github.com/repos/antlr/antlr4/git/commits{/sha}","comments_url":"https://api.github.com/repos/antlr/antlr4/comments{/number}","issue_comment_url":"https://api.github.com/repos/antlr/antlr4/issues/comments{/number}","contents_url":"https://api.github.com/repos/antlr/antlr4/contents/{+path}","compare_url":"https://api.github.com/repos/antlr/antlr4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antlr/antlr4/merges","archive_url":"https://api.github.com/repos/antlr/antlr4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antlr/antlr4/downloads","issues_url":"https://api.github.com/repos/antlr/antlr4/issues{/number}","pulls_url":"https://api.github.com/repos/antlr/antlr4/pulls{/number}","milestones_url":"https://api.github.com/repos/antlr/antlr4/milestones{/number}","notifications_url":"https://api.github.com/repos/antlr/antlr4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antlr/antlr4/labels{/name}","releases_url":"https://api.github.com/repos/antlr/antlr4/releases{/id}","deployments_url":"https://api.github.com/repos/antlr/antlr4/deployments","created_at":"2010-02-04T01:36:28Z","updated_at":"2016-03-30T09:25:22Z","pushed_at":"2016-03-30T16:38:56Z","git_url":"git://github.com/antlr/antlr4.git","ssh_url":"git@github.com:antlr/antlr4.git","clone_url":"https://github.com/antlr/antlr4.git","svn_url":"https://github.com/antlr/antlr4","homepage":"http://antlr.org","size":34924,"stargazers_count":1287,"watchers_count":1287,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"open_issues_count":170,"forks":362,"open_issues":170,"watchers":1287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/antlr/antlr4/pulls/1137"},"html":{"href":"https://github.com/antlr/antlr4/pull/1137"},"issue":{"href":"https://api.github.com/repos/antlr/antlr4/issues/1137"},"comments":{"href":"https://api.github.com/repos/antlr/antlr4/issues/1137/comments"},"review_comments":{"href":"https://api.github.com/repos/antlr/antlr4/pulls/1137/comments"},"review_comment":{"href":"https://api.github.com/repos/antlr/antlr4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/antlr/antlr4/pulls/1137/commits"},"statuses":{"href":"https://api.github.com/repos/antlr/antlr4/statuses/0262aac8f6ef2a65efd724448c9adae76c6d4ade"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"parrt","id":178777,"avatar_url":"https://avatars.githubusercontent.com/u/178777?v=3","gravatar_id":"","url":"https://api.github.com/users/parrt","html_url":"https://github.com/parrt","followers_url":"https://api.github.com/users/parrt/followers","following_url":"https://api.github.com/users/parrt/following{/other_user}","gists_url":"https://api.github.com/users/parrt/gists{/gist_id}","starred_url":"https://api.github.com/users/parrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parrt/subscriptions","organizations_url":"https://api.github.com/users/parrt/orgs","repos_url":"https://api.github.com/users/parrt/repos","events_url":"https://api.github.com/users/parrt/events{/privacy}","received_events_url":"https://api.github.com/users/parrt/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":11,"deletions":2,"changed_files":1}}