{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Localization/pulls/comments/51648899","id":51648899,"diff_hunk":"@@ -0,0 +1,49 @@\n+// Copyright (c) .NET Foundation. All rights reserved. \n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. \n+\n+using System.IO;\n+using System.Threading.Tasks;\n+using Microsoft.AspNet.Server.Testing;\n+using Microsoft.AspNet.Testing.xunit;\n+using Xunit;\n+\n+namespace Microsoft.AspNet.Localization.FunctionalTests\n+{\n+    public class LocalizationSampleTest\n+    {\n+        private static readonly string _applicationPath = Path.GetFullPath(Path.Combine(\"../../samples\", \"LocalizationSample\"));\n+        \n+        [ConditionalTheory]\n+        [OSSkipCondition(OperatingSystems.Linux)]\n+        [OSSkipCondition(OperatingSystems.MacOSX)]\n+        [InlineData(RuntimeFlavor.Clr, \"http://localhost:5070/\", RuntimeArchitecture.x86)]\n+        [InlineData(RuntimeFlavor.CoreClr, \"http://localhost:5071/\", RuntimeArchitecture.x86)]\n+        public Task RunSite_WindowsOnly(RuntimeFlavor runtimeFlavor, string applicationBaseUrl, RuntimeArchitecture runtimeArchitecture)","path":"test/Microsoft.AspNet.Localization.FunctionalTests/LocalizationSampleTest.cs","position":21,"original_position":21,"commit_id":"e9d1b58eb0202c6c9c3c952d425865f2edc8f561","original_commit_id":"e9d1b58eb0202c6c9c3c952d425865f2edc8f561","user":{"login":"ryanbrandenburg","id":14987221,"avatar_url":"https://avatars.githubusercontent.com/u/14987221?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbrandenburg","html_url":"https://github.com/ryanbrandenburg","followers_url":"https://api.github.com/users/ryanbrandenburg/followers","following_url":"https://api.github.com/users/ryanbrandenburg/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrandenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrandenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrandenburg/subscriptions","organizations_url":"https://api.github.com/users/ryanbrandenburg/orgs","repos_url":"https://api.github.com/users/ryanbrandenburg/repos","events_url":"https://api.github.com/users/ryanbrandenburg/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrandenburg/received_events","type":"User","site_admin":false},"body":"You're just following the pattern set by the other tests, but I was wondering what the reasoning was to have separate tests by OS when the parameters and actions identical as far as I can tell.","created_at":"2016-02-02T22:43:40Z","updated_at":"2016-02-02T22:43:40Z","html_url":"https://github.com/aspnet/Localization/pull/190#discussion_r51648899","pull_request_url":"https://api.github.com/repos/aspnet/Localization/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/comments/51648899"},"html":{"href":"https://github.com/aspnet/Localization/pull/190#discussion_r51648899"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Localization/pulls/190","id":54448657,"html_url":"https://github.com/aspnet/Localization/pull/190","diff_url":"https://github.com/aspnet/Localization/pull/190.diff","patch_url":"https://github.com/aspnet/Localization/pull/190.patch","issue_url":"https://api.github.com/repos/aspnet/Localization/issues/190","number":190,"state":"open","locked":false,"title":"FunctionalTest for LocalizationSample","user":{"login":"hishamco","id":3237266,"avatar_url":"https://avatars.githubusercontent.com/u/3237266?v=3","gravatar_id":"","url":"https://api.github.com/users/hishamco","html_url":"https://github.com/hishamco","followers_url":"https://api.github.com/users/hishamco/followers","following_url":"https://api.github.com/users/hishamco/following{/other_user}","gists_url":"https://api.github.com/users/hishamco/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamco/subscriptions","organizations_url":"https://api.github.com/users/hishamco/orgs","repos_url":"https://api.github.com/users/hishamco/repos","events_url":"https://api.github.com/users/hishamco/events{/privacy}","received_events_url":"https://api.github.com/users/hishamco/received_events","type":"User","site_admin":false},"body":"I made this PR long time back to fix issue #148, I was worrying because the current functional test is compare the actual html content which is not effecient in the Localization Sample, so I introduce a new method to check if a heading part is localized, hopefully this enough in this case\r\nThanks @DamianEdwards for the sample you push here https://github.com/aspnet/Entropy/pull/83","created_at":"2015-12-23T08:24:47Z","updated_at":"2016-02-02T22:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8be4c7b957f72cf256bc00930f3819c8a3e05e46","assignee":{"login":"ryanbrandenburg","id":14987221,"avatar_url":"https://avatars.githubusercontent.com/u/14987221?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbrandenburg","html_url":"https://github.com/ryanbrandenburg","followers_url":"https://api.github.com/users/ryanbrandenburg/followers","following_url":"https://api.github.com/users/ryanbrandenburg/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrandenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrandenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrandenburg/subscriptions","organizations_url":"https://api.github.com/users/ryanbrandenburg/orgs","repos_url":"https://api.github.com/users/ryanbrandenburg/repos","events_url":"https://api.github.com/users/ryanbrandenburg/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrandenburg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Localization/pulls/190/commits","review_comments_url":"https://api.github.com/repos/aspnet/Localization/pulls/190/comments","review_comment_url":"https://api.github.com/repos/aspnet/Localization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Localization/issues/190/comments","statuses_url":"https://api.github.com/repos/aspnet/Localization/statuses/e9d1b58eb0202c6c9c3c952d425865f2edc8f561","head":{"label":"hishamco:test","ref":"test","sha":"e9d1b58eb0202c6c9c3c952d425865f2edc8f561","user":{"login":"hishamco","id":3237266,"avatar_url":"https://avatars.githubusercontent.com/u/3237266?v=3","gravatar_id":"","url":"https://api.github.com/users/hishamco","html_url":"https://github.com/hishamco","followers_url":"https://api.github.com/users/hishamco/followers","following_url":"https://api.github.com/users/hishamco/following{/other_user}","gists_url":"https://api.github.com/users/hishamco/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamco/subscriptions","organizations_url":"https://api.github.com/users/hishamco/orgs","repos_url":"https://api.github.com/users/hishamco/repos","events_url":"https://api.github.com/users/hishamco/events{/privacy}","received_events_url":"https://api.github.com/users/hishamco/received_events","type":"User","site_admin":false},"repo":{"id":46144164,"name":"Localization","full_name":"hishamco/Localization","owner":{"login":"hishamco","id":3237266,"avatar_url":"https://avatars.githubusercontent.com/u/3237266?v=3","gravatar_id":"","url":"https://api.github.com/users/hishamco","html_url":"https://github.com/hishamco","followers_url":"https://api.github.com/users/hishamco/followers","following_url":"https://api.github.com/users/hishamco/following{/other_user}","gists_url":"https://api.github.com/users/hishamco/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamco/subscriptions","organizations_url":"https://api.github.com/users/hishamco/orgs","repos_url":"https://api.github.com/users/hishamco/repos","events_url":"https://api.github.com/users/hishamco/events{/privacy}","received_events_url":"https://api.github.com/users/hishamco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hishamco/Localization","description":"Interfaces and implementations for providing localization in applications. ","fork":true,"url":"https://api.github.com/repos/hishamco/Localization","forks_url":"https://api.github.com/repos/hishamco/Localization/forks","keys_url":"https://api.github.com/repos/hishamco/Localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hishamco/Localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hishamco/Localization/teams","hooks_url":"https://api.github.com/repos/hishamco/Localization/hooks","issue_events_url":"https://api.github.com/repos/hishamco/Localization/issues/events{/number}","events_url":"https://api.github.com/repos/hishamco/Localization/events","assignees_url":"https://api.github.com/repos/hishamco/Localization/assignees{/user}","branches_url":"https://api.github.com/repos/hishamco/Localization/branches{/branch}","tags_url":"https://api.github.com/repos/hishamco/Localization/tags","blobs_url":"https://api.github.com/repos/hishamco/Localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hishamco/Localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hishamco/Localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/hishamco/Localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hishamco/Localization/statuses/{sha}","languages_url":"https://api.github.com/repos/hishamco/Localization/languages","stargazers_url":"https://api.github.com/repos/hishamco/Localization/stargazers","contributors_url":"https://api.github.com/repos/hishamco/Localization/contributors","subscribers_url":"https://api.github.com/repos/hishamco/Localization/subscribers","subscription_url":"https://api.github.com/repos/hishamco/Localization/subscription","commits_url":"https://api.github.com/repos/hishamco/Localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/hishamco/Localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/hishamco/Localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/hishamco/Localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/hishamco/Localization/contents/{+path}","compare_url":"https://api.github.com/repos/hishamco/Localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hishamco/Localization/merges","archive_url":"https://api.github.com/repos/hishamco/Localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hishamco/Localization/downloads","issues_url":"https://api.github.com/repos/hishamco/Localization/issues{/number}","pulls_url":"https://api.github.com/repos/hishamco/Localization/pulls{/number}","milestones_url":"https://api.github.com/repos/hishamco/Localization/milestones{/number}","notifications_url":"https://api.github.com/repos/hishamco/Localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hishamco/Localization/labels{/name}","releases_url":"https://api.github.com/repos/hishamco/Localization/releases{/id}","deployments_url":"https://api.github.com/repos/hishamco/Localization/deployments","created_at":"2015-11-13T19:59:06Z","updated_at":"2016-01-23T16:30:54Z","pushed_at":"2016-02-02T20:05:25Z","git_url":"git://github.com/hishamco/Localization.git","ssh_url":"git@github.com:hishamco/Localization.git","clone_url":"https://github.com/hishamco/Localization.git","svn_url":"https://github.com/hishamco/Localization","homepage":null,"size":391,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"4010676634216a8cb5d7a7208084a14e14a74600","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35138798,"name":"Localization","full_name":"aspnet/Localization","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Localization","description":"Interfaces and implementations for providing localization in applications. ","fork":false,"url":"https://api.github.com/repos/aspnet/Localization","forks_url":"https://api.github.com/repos/aspnet/Localization/forks","keys_url":"https://api.github.com/repos/aspnet/Localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Localization/teams","hooks_url":"https://api.github.com/repos/aspnet/Localization/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Localization/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Localization/events","assignees_url":"https://api.github.com/repos/aspnet/Localization/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Localization/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Localization/tags","blobs_url":"https://api.github.com/repos/aspnet/Localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Localization/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Localization/languages","stargazers_url":"https://api.github.com/repos/aspnet/Localization/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Localization/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Localization/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Localization/subscription","commits_url":"https://api.github.com/repos/aspnet/Localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Localization/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Localization/merges","archive_url":"https://api.github.com/repos/aspnet/Localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Localization/downloads","issues_url":"https://api.github.com/repos/aspnet/Localization/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Localization/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Localization/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Localization/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Localization/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Localization/deployments","created_at":"2015-05-06T04:07:17Z","updated_at":"2016-01-28T19:57:55Z","pushed_at":"2016-02-02T22:31:31Z","git_url":"git://github.com/aspnet/Localization.git","ssh_url":"git@github.com:aspnet/Localization.git","clone_url":"https://github.com/aspnet/Localization.git","svn_url":"https://github.com/aspnet/Localization","homepage":null,"size":673,"stargazers_count":38,"watchers_count":38,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":15,"forks":21,"open_issues":15,"watchers":38,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/190"},"html":{"href":"https://github.com/aspnet/Localization/pull/190"},"issue":{"href":"https://api.github.com/repos/aspnet/Localization/issues/190"},"comments":{"href":"https://api.github.com/repos/aspnet/Localization/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Localization/statuses/e9d1b58eb0202c6c9c3c952d425865f2edc8f561"}}}}