{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/52481733","id":52481733,"diff_hunk":"@@ -45,6 +49,14 @@ class SerializedPageReader : public PageReader {\n   // Implement the PageReader interface\n   virtual std::shared_ptr<Page> NextPage();\n \n+  void set_max_page_header_size(int size) {\n+    max_page_header_size_ = size;\n+  }\n+\n+  void set_page_header_size(int size) {\n+    page_header_size_ = size;\n+  }","path":"src/parquet/column/serialized-page.h","position":21,"original_position":21,"commit_id":"b4eec360de8ceefea1b7b44148fb076940027ac3","original_commit_id":"b4eec360de8ceefea1b7b44148fb076940027ac3","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"this one isn't needed","created_at":"2016-02-10T16:22:58Z","updated_at":"2016-02-10T16:22:58Z","html_url":"https://github.com/apache/parquet-cpp/pull/44#discussion_r52481733","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/52481733"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/44#discussion_r52481733"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/44","id":58805039,"html_url":"https://github.com/apache/parquet-cpp/pull/44","diff_url":"https://github.com/apache/parquet-cpp/pull/44.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/44.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/44","number":44,"state":"open","locked":false,"title":"PARQUET-505: Column reader should automatically handle large data pages","user":{"login":"majetideepak","id":5091159,"avatar_url":"https://avatars.githubusercontent.com/u/5091159?v=3","gravatar_id":"","url":"https://api.github.com/users/majetideepak","html_url":"https://github.com/majetideepak","followers_url":"https://api.github.com/users/majetideepak/followers","following_url":"https://api.github.com/users/majetideepak/following{/other_user}","gists_url":"https://api.github.com/users/majetideepak/gists{/gist_id}","starred_url":"https://api.github.com/users/majetideepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majetideepak/subscriptions","organizations_url":"https://api.github.com/users/majetideepak/orgs","repos_url":"https://api.github.com/users/majetideepak/repos","events_url":"https://api.github.com/users/majetideepak/events{/privacy}","received_events_url":"https://api.github.com/users/majetideepak/received_events","type":"User","site_admin":false},"body":"This PR implements\r\n1) PARQUET-505: Column reader should automatically handle large data pages\r\n2) Adds support for Serialization\r\n3) Test case for Serialization and Deserialization\r\n4) Test case for SerializedPageReader and PARQUET-505","created_at":"2016-02-09T20:37:05Z","updated_at":"2016-02-10T16:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca52a99132b79bf06d5f29e212a9f31aed68e614","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/44/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/44/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/44/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/b4eec360de8ceefea1b7b44148fb076940027ac3","head":{"label":"majetideepak:PARQUET-505","ref":"PARQUET-505","sha":"b4eec360de8ceefea1b7b44148fb076940027ac3","user":{"login":"majetideepak","id":5091159,"avatar_url":"https://avatars.githubusercontent.com/u/5091159?v=3","gravatar_id":"","url":"https://api.github.com/users/majetideepak","html_url":"https://github.com/majetideepak","followers_url":"https://api.github.com/users/majetideepak/followers","following_url":"https://api.github.com/users/majetideepak/following{/other_user}","gists_url":"https://api.github.com/users/majetideepak/gists{/gist_id}","starred_url":"https://api.github.com/users/majetideepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majetideepak/subscriptions","organizations_url":"https://api.github.com/users/majetideepak/orgs","repos_url":"https://api.github.com/users/majetideepak/repos","events_url":"https://api.github.com/users/majetideepak/events{/privacy}","received_events_url":"https://api.github.com/users/majetideepak/received_events","type":"User","site_admin":false},"repo":{"id":49598967,"name":"parquet-cpp","full_name":"majetideepak/parquet-cpp","owner":{"login":"majetideepak","id":5091159,"avatar_url":"https://avatars.githubusercontent.com/u/5091159?v=3","gravatar_id":"","url":"https://api.github.com/users/majetideepak","html_url":"https://github.com/majetideepak","followers_url":"https://api.github.com/users/majetideepak/followers","following_url":"https://api.github.com/users/majetideepak/following{/other_user}","gists_url":"https://api.github.com/users/majetideepak/gists{/gist_id}","starred_url":"https://api.github.com/users/majetideepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majetideepak/subscriptions","organizations_url":"https://api.github.com/users/majetideepak/orgs","repos_url":"https://api.github.com/users/majetideepak/repos","events_url":"https://api.github.com/users/majetideepak/events{/privacy}","received_events_url":"https://api.github.com/users/majetideepak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majetideepak/parquet-cpp","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/majetideepak/parquet-cpp","forks_url":"https://api.github.com/repos/majetideepak/parquet-cpp/forks","keys_url":"https://api.github.com/repos/majetideepak/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majetideepak/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majetideepak/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/majetideepak/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/majetideepak/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/majetideepak/parquet-cpp/events","assignees_url":"https://api.github.com/repos/majetideepak/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/majetideepak/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/majetideepak/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majetideepak/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/majetideepak/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/majetideepak/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/majetideepak/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/majetideepak/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/majetideepak/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/majetideepak/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/majetideepak/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/majetideepak/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/majetideepak/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/majetideepak/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/majetideepak/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majetideepak/parquet-cpp/merges","archive_url":"https://api.github.com/repos/majetideepak/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majetideepak/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/majetideepak/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/majetideepak/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/majetideepak/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/majetideepak/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majetideepak/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/majetideepak/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/majetideepak/parquet-cpp/deployments","created_at":"2016-01-13T20:12:53Z","updated_at":"2016-01-13T20:12:54Z","pushed_at":"2016-02-10T15:39:18Z","git_url":"git://github.com/majetideepak/parquet-cpp.git","ssh_url":"git@github.com:majetideepak/parquet-cpp.git","clone_url":"https://github.com/majetideepak/parquet-cpp.git","svn_url":"https://github.com/majetideepak/parquet-cpp","homepage":null,"size":405,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fdbe437b1b6e85385a41a0038637cc4c87d4d640","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-02-09T04:29:23Z","pushed_at":"2016-02-10T15:39:18Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":null,"size":609,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":"git://git.apache.org/parquet-cpp.git","open_issues_count":5,"forks":20,"open_issues":5,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/44"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/44"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/44"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/b4eec360de8ceefea1b7b44148fb076940027ac3"}}}}