{"push_id":1392912810,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"f32baf46e2615055a9e36c173fdc08bf271f5c68","before":"62de83cd1395aaf0ebe5d4c2621c497299975437","commits":[{"sha":"f32baf46e2615055a9e36c173fdc08bf271f5c68","author":{"name":"MXAmin","email":"3218bd086051e267831545deb618ea2648d41c56@gmail.com"},"message":"tc: fix HTB QDisc generation with default arguments\n\nWhen we call `tc` function for creating the HTB QDisc with NO kwargs,\r\nthe kernel will return error 22 (invalid argument)::\r\n\r\n\t ip.tc(\"add\", \"htb\", eth0, 0x10000)\r\n\t pyroute2.netlink.exceptions.NetlinkError: (22, 'Invalid argument')\r\n\r\nAs you can see by calling the `tc` function without any additional\r\narguments (we only defined `command`, `kind`, `index` and `handle`\r\narguments) the module will raise `NetlinkError`; reason: according to\r\n'net/sched/sch_htb.c' of linux kernel source code, to create a HTB\r\nQDisc we also need to define `direct_pkts`, `rate2quantum` and\r\n`defcls` which is not defined by default (the function `get_parameters`\r\nis responsible for providing these default arguments which WON'T be\r\ncalled unless we have at least ONE argument in kwargs.\r\n\r\nBug-Url: https://github.com/svinota/pyroute2/pull/308","distinct":true,"url":"https://api.github.com/repos/mxamin/pyroute2/commits/f32baf46e2615055a9e36c173fdc08bf271f5c68"}]}
{"actor":{"display_login":"mxamin"}}