{"action":"created","comment":{"url":"https://api.github.com/repos/JFXtras/jfxtras/pulls/comments/52123536","id":52123536,"diff_hunk":"@@ -238,7 +241,15 @@ public void refresh() {\n \t\trefreshLocale();\n \t\tsetupAppointments();\r\n \t\tnowUpdateRunnable.run(); \r\n-\t}\r\n+\t}\n+\n+\t/**\n+\t * \n+\t */\n+\t@Override\n+    public Pane getNodeForPopup(Appointment appointment) { return appointmentNodeMap.get(appointment); }\n+    final private Map<Appointment, Pane> appointmentNodeMap = new WeakHashMap<>();","path":"jfxtras-agenda/src/main/java/jfxtras/internal/scene/control/skin/agenda/base24hour/AgendaSkinTimeScale24HourAbstract.java","position":30,"original_position":30,"commit_id":"c3d95631fab7d5684b37251a136885c56225ddc5","original_commit_id":"c3d95631fab7d5684b37251a136885c56225ddc5","user":{"login":"tbee","id":1429698,"avatar_url":"https://avatars.githubusercontent.com/u/1429698?v=3","gravatar_id":"","url":"https://api.github.com/users/tbee","html_url":"https://github.com/tbee","followers_url":"https://api.github.com/users/tbee/followers","following_url":"https://api.github.com/users/tbee/following{/other_user}","gists_url":"https://api.github.com/users/tbee/gists{/gist_id}","starred_url":"https://api.github.com/users/tbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbee/subscriptions","organizations_url":"https://api.github.com/users/tbee/orgs","repos_url":"https://api.github.com/users/tbee/repos","events_url":"https://api.github.com/users/tbee/events{/privacy}","received_events_url":"https://api.github.com/users/tbee/received_events","type":"User","site_admin":false},"body":"I'm a bit worried about the hashcode method on the appointments and the hashmap being used here. What if one of the properties is changed after an appointment is put in this map?","created_at":"2016-02-07T19:52:09Z","updated_at":"2016-02-07T19:52:09Z","html_url":"https://github.com/JFXtras/jfxtras/pull/53#discussion_r52123536","pull_request_url":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/JFXtras/jfxtras/pulls/comments/52123536"},"html":{"href":"https://github.com/JFXtras/jfxtras/pull/53#discussion_r52123536"},"pull_request":{"href":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53","id":58340035,"html_url":"https://github.com/JFXtras/jfxtras/pull/53","diff_url":"https://github.com/JFXtras/jfxtras/pull/53.diff","patch_url":"https://github.com/JFXtras/jfxtras/pull/53.patch","issue_url":"https://api.github.com/repos/JFXtras/jfxtras/issues/53","number":53,"state":"open","locked":false,"title":"new getNodeForPopup method and more","user":{"login":"daviddbal","id":14855516,"avatar_url":"https://avatars.githubusercontent.com/u/14855516?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddbal","html_url":"https://github.com/daviddbal","followers_url":"https://api.github.com/users/daviddbal/followers","following_url":"https://api.github.com/users/daviddbal/following{/other_user}","gists_url":"https://api.github.com/users/daviddbal/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddbal/subscriptions","organizations_url":"https://api.github.com/users/daviddbal/orgs","repos_url":"https://api.github.com/users/daviddbal/repos","events_url":"https://api.github.com/users/daviddbal/events{/privacy}","received_events_url":"https://api.github.com/users/daviddbal/received_events","type":"User","site_admin":false},"body":"Tom,\r\n\r\nThis PR contains several commits that do the following:\r\n\r\n- adds selectOneAppointmentCallback that is run when only one appointment is selected\r\n- renames the callbacks I added to follow the verb-noun convention like the other callbacks in Agenda.\r\n- adds -fx-fill colors to Agenda.css to allow me to use Rectangles as icons.\r\n- adds getNodeForPopup and a map to back it in AgendaSkinTimeScale24HourAbstract.\r\n\r\nThe appointmentBodyPaneMap I added in the second commit has been removed.\r\n\r\n-David \r\n\r\n","created_at":"2016-02-04T19:58:15Z","updated_at":"2016-02-07T19:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53/commits","review_comments_url":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53/comments","review_comment_url":"https://api.github.com/repos/JFXtras/jfxtras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JFXtras/jfxtras/issues/53/comments","statuses_url":"https://api.github.com/repos/JFXtras/jfxtras/statuses/c3d95631fab7d5684b37251a136885c56225ddc5","head":{"label":"daviddbal:8.0","ref":"8.0","sha":"c3d95631fab7d5684b37251a136885c56225ddc5","user":{"login":"daviddbal","id":14855516,"avatar_url":"https://avatars.githubusercontent.com/u/14855516?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddbal","html_url":"https://github.com/daviddbal","followers_url":"https://api.github.com/users/daviddbal/followers","following_url":"https://api.github.com/users/daviddbal/following{/other_user}","gists_url":"https://api.github.com/users/daviddbal/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddbal/subscriptions","organizations_url":"https://api.github.com/users/daviddbal/orgs","repos_url":"https://api.github.com/users/daviddbal/repos","events_url":"https://api.github.com/users/daviddbal/events{/privacy}","received_events_url":"https://api.github.com/users/daviddbal/received_events","type":"User","site_admin":false},"repo":{"id":43228964,"name":"jfxtras","full_name":"daviddbal/jfxtras","owner":{"login":"daviddbal","id":14855516,"avatar_url":"https://avatars.githubusercontent.com/u/14855516?v=3","gravatar_id":"","url":"https://api.github.com/users/daviddbal","html_url":"https://github.com/daviddbal","followers_url":"https://api.github.com/users/daviddbal/followers","following_url":"https://api.github.com/users/daviddbal/following{/other_user}","gists_url":"https://api.github.com/users/daviddbal/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddbal/subscriptions","organizations_url":"https://api.github.com/users/daviddbal/orgs","repos_url":"https://api.github.com/users/daviddbal/repos","events_url":"https://api.github.com/users/daviddbal/events{/privacy}","received_events_url":"https://api.github.com/users/daviddbal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daviddbal/jfxtras","description":"A supporting library for JavaFX, containing helper classes, extended layouts, controls and other interesting widgets.","fork":true,"url":"https://api.github.com/repos/daviddbal/jfxtras","forks_url":"https://api.github.com/repos/daviddbal/jfxtras/forks","keys_url":"https://api.github.com/repos/daviddbal/jfxtras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daviddbal/jfxtras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daviddbal/jfxtras/teams","hooks_url":"https://api.github.com/repos/daviddbal/jfxtras/hooks","issue_events_url":"https://api.github.com/repos/daviddbal/jfxtras/issues/events{/number}","events_url":"https://api.github.com/repos/daviddbal/jfxtras/events","assignees_url":"https://api.github.com/repos/daviddbal/jfxtras/assignees{/user}","branches_url":"https://api.github.com/repos/daviddbal/jfxtras/branches{/branch}","tags_url":"https://api.github.com/repos/daviddbal/jfxtras/tags","blobs_url":"https://api.github.com/repos/daviddbal/jfxtras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daviddbal/jfxtras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daviddbal/jfxtras/git/refs{/sha}","trees_url":"https://api.github.com/repos/daviddbal/jfxtras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daviddbal/jfxtras/statuses/{sha}","languages_url":"https://api.github.com/repos/daviddbal/jfxtras/languages","stargazers_url":"https://api.github.com/repos/daviddbal/jfxtras/stargazers","contributors_url":"https://api.github.com/repos/daviddbal/jfxtras/contributors","subscribers_url":"https://api.github.com/repos/daviddbal/jfxtras/subscribers","subscription_url":"https://api.github.com/repos/daviddbal/jfxtras/subscription","commits_url":"https://api.github.com/repos/daviddbal/jfxtras/commits{/sha}","git_commits_url":"https://api.github.com/repos/daviddbal/jfxtras/git/commits{/sha}","comments_url":"https://api.github.com/repos/daviddbal/jfxtras/comments{/number}","issue_comment_url":"https://api.github.com/repos/daviddbal/jfxtras/issues/comments{/number}","contents_url":"https://api.github.com/repos/daviddbal/jfxtras/contents/{+path}","compare_url":"https://api.github.com/repos/daviddbal/jfxtras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daviddbal/jfxtras/merges","archive_url":"https://api.github.com/repos/daviddbal/jfxtras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daviddbal/jfxtras/downloads","issues_url":"https://api.github.com/repos/daviddbal/jfxtras/issues{/number}","pulls_url":"https://api.github.com/repos/daviddbal/jfxtras/pulls{/number}","milestones_url":"https://api.github.com/repos/daviddbal/jfxtras/milestones{/number}","notifications_url":"https://api.github.com/repos/daviddbal/jfxtras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daviddbal/jfxtras/labels{/name}","releases_url":"https://api.github.com/repos/daviddbal/jfxtras/releases{/id}","deployments_url":"https://api.github.com/repos/daviddbal/jfxtras/deployments","created_at":"2015-09-27T00:55:28Z","updated_at":"2016-01-26T06:45:53Z","pushed_at":"2016-02-04T23:53:21Z","git_url":"git://github.com/daviddbal/jfxtras.git","ssh_url":"git@github.com:daviddbal/jfxtras.git","clone_url":"https://github.com/daviddbal/jfxtras.git","svn_url":"https://github.com/daviddbal/jfxtras","homepage":"jfxtras.github.com","size":2712,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"JFXtras:8.0","ref":"8.0","sha":"7edae3a49c62ebfc0288223ee88dc4f6a4acd3cd","user":{"login":"JFXtras","id":1429300,"avatar_url":"https://avatars.githubusercontent.com/u/1429300?v=3","gravatar_id":"","url":"https://api.github.com/users/JFXtras","html_url":"https://github.com/JFXtras","followers_url":"https://api.github.com/users/JFXtras/followers","following_url":"https://api.github.com/users/JFXtras/following{/other_user}","gists_url":"https://api.github.com/users/JFXtras/gists{/gist_id}","starred_url":"https://api.github.com/users/JFXtras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFXtras/subscriptions","organizations_url":"https://api.github.com/users/JFXtras/orgs","repos_url":"https://api.github.com/users/JFXtras/repos","events_url":"https://api.github.com/users/JFXtras/events{/privacy}","received_events_url":"https://api.github.com/users/JFXtras/received_events","type":"Organization","site_admin":false},"repo":{"id":3433581,"name":"jfxtras","full_name":"JFXtras/jfxtras","owner":{"login":"JFXtras","id":1429300,"avatar_url":"https://avatars.githubusercontent.com/u/1429300?v=3","gravatar_id":"","url":"https://api.github.com/users/JFXtras","html_url":"https://github.com/JFXtras","followers_url":"https://api.github.com/users/JFXtras/followers","following_url":"https://api.github.com/users/JFXtras/following{/other_user}","gists_url":"https://api.github.com/users/JFXtras/gists{/gist_id}","starred_url":"https://api.github.com/users/JFXtras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFXtras/subscriptions","organizations_url":"https://api.github.com/users/JFXtras/orgs","repos_url":"https://api.github.com/users/JFXtras/repos","events_url":"https://api.github.com/users/JFXtras/events{/privacy}","received_events_url":"https://api.github.com/users/JFXtras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JFXtras/jfxtras","description":"A supporting library for JavaFX, containing helper classes, extended layouts, controls and other interesting widgets.","fork":false,"url":"https://api.github.com/repos/JFXtras/jfxtras","forks_url":"https://api.github.com/repos/JFXtras/jfxtras/forks","keys_url":"https://api.github.com/repos/JFXtras/jfxtras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JFXtras/jfxtras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JFXtras/jfxtras/teams","hooks_url":"https://api.github.com/repos/JFXtras/jfxtras/hooks","issue_events_url":"https://api.github.com/repos/JFXtras/jfxtras/issues/events{/number}","events_url":"https://api.github.com/repos/JFXtras/jfxtras/events","assignees_url":"https://api.github.com/repos/JFXtras/jfxtras/assignees{/user}","branches_url":"https://api.github.com/repos/JFXtras/jfxtras/branches{/branch}","tags_url":"https://api.github.com/repos/JFXtras/jfxtras/tags","blobs_url":"https://api.github.com/repos/JFXtras/jfxtras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JFXtras/jfxtras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JFXtras/jfxtras/git/refs{/sha}","trees_url":"https://api.github.com/repos/JFXtras/jfxtras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JFXtras/jfxtras/statuses/{sha}","languages_url":"https://api.github.com/repos/JFXtras/jfxtras/languages","stargazers_url":"https://api.github.com/repos/JFXtras/jfxtras/stargazers","contributors_url":"https://api.github.com/repos/JFXtras/jfxtras/contributors","subscribers_url":"https://api.github.com/repos/JFXtras/jfxtras/subscribers","subscription_url":"https://api.github.com/repos/JFXtras/jfxtras/subscription","commits_url":"https://api.github.com/repos/JFXtras/jfxtras/commits{/sha}","git_commits_url":"https://api.github.com/repos/JFXtras/jfxtras/git/commits{/sha}","comments_url":"https://api.github.com/repos/JFXtras/jfxtras/comments{/number}","issue_comment_url":"https://api.github.com/repos/JFXtras/jfxtras/issues/comments{/number}","contents_url":"https://api.github.com/repos/JFXtras/jfxtras/contents/{+path}","compare_url":"https://api.github.com/repos/JFXtras/jfxtras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JFXtras/jfxtras/merges","archive_url":"https://api.github.com/repos/JFXtras/jfxtras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JFXtras/jfxtras/downloads","issues_url":"https://api.github.com/repos/JFXtras/jfxtras/issues{/number}","pulls_url":"https://api.github.com/repos/JFXtras/jfxtras/pulls{/number}","milestones_url":"https://api.github.com/repos/JFXtras/jfxtras/milestones{/number}","notifications_url":"https://api.github.com/repos/JFXtras/jfxtras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JFXtras/jfxtras/labels{/name}","releases_url":"https://api.github.com/repos/JFXtras/jfxtras/releases{/id}","deployments_url":"https://api.github.com/repos/JFXtras/jfxtras/deployments","created_at":"2012-02-13T20:03:59Z","updated_at":"2016-02-04T09:29:02Z","pushed_at":"2016-02-07T15:45:51Z","git_url":"git://github.com/JFXtras/jfxtras.git","ssh_url":"git@github.com:JFXtras/jfxtras.git","clone_url":"https://github.com/JFXtras/jfxtras.git","svn_url":"https://github.com/JFXtras/jfxtras","homepage":"jfxtras.github.com","size":2898,"stargazers_count":212,"watchers_count":212,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":3,"forks":59,"open_issues":3,"watchers":212,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53"},"html":{"href":"https://github.com/JFXtras/jfxtras/pull/53"},"issue":{"href":"https://api.github.com/repos/JFXtras/jfxtras/issues/53"},"comments":{"href":"https://api.github.com/repos/JFXtras/jfxtras/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/JFXtras/jfxtras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JFXtras/jfxtras/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/JFXtras/jfxtras/statuses/c3d95631fab7d5684b37251a136885c56225ddc5"}}}}