{"action":"opened","number":3193,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3193","id":75124625,"html_url":"https://github.com/apple/swift/pull/3193","diff_url":"https://github.com/apple/swift/pull/3193.diff","patch_url":"https://github.com/apple/swift/pull/3193.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/3193","number":3193,"state":"open","locked":false,"title":"Support Linux on z as a Swift platform: Part 2","user":{"login":"garyliu1","id":8801690,"avatar_url":"https://avatars.githubusercontent.com/u/8801690?v=3","gravatar_id":"","url":"https://api.github.com/users/garyliu1","html_url":"https://github.com/garyliu1","followers_url":"https://api.github.com/users/garyliu1/followers","following_url":"https://api.github.com/users/garyliu1/following{/other_user}","gists_url":"https://api.github.com/users/garyliu1/gists{/gist_id}","starred_url":"https://api.github.com/users/garyliu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyliu1/subscriptions","organizations_url":"https://api.github.com/users/garyliu1/orgs","repos_url":"https://api.github.com/users/garyliu1/repos","events_url":"https://api.github.com/users/garyliu1/events{/privacy}","received_events_url":"https://api.github.com/users/garyliu1/received_events","type":"User","site_admin":false},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\nCurrent code in emitWildcardDispatch() caters only for case statements, the catch statement in a do-catch block can also have wildcard patterns and it can get to the method.\r\n\r\nIn the case of a catch statement, emitWildcardDispatch() determines that clauses[row].getCaseGuardExpr() is non-null as well, and assumes that clauses[row] refers to a CaseStmt (which is not true; it refers to a CatchStmt instead), and eventually calls usingImplicitVariablesForPattern() to emit the guard branch. \r\n\r\nusingImplicitVariablesForPattern() calls getCaseLabelItems() on the CatchStmt object, which returns garbage in a stack-allocated ArrayRef named labelItems.  An assert is thrown when we try to read from labelItems[0] \r\n\r\nThis is a continuation effort from the previous pull request [https://github.com/apple/swift/pull/2541](https://github.com/apple/swift/pull/2541).  Our team encountered this issue during the build of swiftpm for s390x.  However this issue is platform independent and the same assert is reproducible on x86_64 with the new test case added alongside with this commit.\r\n\r\nRegression test has been run on both s390x and x86_64 with all the commits proposed here, no new issues found.\r\n\r\nThere is also a small s390x test enabling change on test/Prototypes/FloatingPoint.swift, test is passing in s390x after the change.\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n","created_at":"2016-06-24T14:44:33Z","updated_at":"2016-06-24T14:44:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/3193/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/3193/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/3193/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/5224f17ac9c1e3ffcf8ca61778da708e8afcc087","head":{"label":"linux-on-ibm-z:master-s390x","ref":"master-s390x","sha":"5224f17ac9c1e3ffcf8ca61778da708e8afcc087","user":{"login":"linux-on-ibm-z","id":11740175,"avatar_url":"https://avatars.githubusercontent.com/u/11740175?v=3","gravatar_id":"","url":"https://api.github.com/users/linux-on-ibm-z","html_url":"https://github.com/linux-on-ibm-z","followers_url":"https://api.github.com/users/linux-on-ibm-z/followers","following_url":"https://api.github.com/users/linux-on-ibm-z/following{/other_user}","gists_url":"https://api.github.com/users/linux-on-ibm-z/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-on-ibm-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-on-ibm-z/subscriptions","organizations_url":"https://api.github.com/users/linux-on-ibm-z/orgs","repos_url":"https://api.github.com/users/linux-on-ibm-z/repos","events_url":"https://api.github.com/users/linux-on-ibm-z/events{/privacy}","received_events_url":"https://api.github.com/users/linux-on-ibm-z/received_events","type":"Organization","site_admin":false},"repo":{"id":58820292,"name":"swift","full_name":"linux-on-ibm-z/swift","owner":{"login":"linux-on-ibm-z","id":11740175,"avatar_url":"https://avatars.githubusercontent.com/u/11740175?v=3","gravatar_id":"","url":"https://api.github.com/users/linux-on-ibm-z","html_url":"https://github.com/linux-on-ibm-z","followers_url":"https://api.github.com/users/linux-on-ibm-z/followers","following_url":"https://api.github.com/users/linux-on-ibm-z/following{/other_user}","gists_url":"https://api.github.com/users/linux-on-ibm-z/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-on-ibm-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-on-ibm-z/subscriptions","organizations_url":"https://api.github.com/users/linux-on-ibm-z/orgs","repos_url":"https://api.github.com/users/linux-on-ibm-z/repos","events_url":"https://api.github.com/users/linux-on-ibm-z/events{/privacy}","received_events_url":"https://api.github.com/users/linux-on-ibm-z/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linux-on-ibm-z/swift","description":"Porting and evolving the Swift programming language for Linux on IBM z.","fork":true,"url":"https://api.github.com/repos/linux-on-ibm-z/swift","forks_url":"https://api.github.com/repos/linux-on-ibm-z/swift/forks","keys_url":"https://api.github.com/repos/linux-on-ibm-z/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linux-on-ibm-z/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linux-on-ibm-z/swift/teams","hooks_url":"https://api.github.com/repos/linux-on-ibm-z/swift/hooks","issue_events_url":"https://api.github.com/repos/linux-on-ibm-z/swift/issues/events{/number}","events_url":"https://api.github.com/repos/linux-on-ibm-z/swift/events","assignees_url":"https://api.github.com/repos/linux-on-ibm-z/swift/assignees{/user}","branches_url":"https://api.github.com/repos/linux-on-ibm-z/swift/branches{/branch}","tags_url":"https://api.github.com/repos/linux-on-ibm-z/swift/tags","blobs_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linux-on-ibm-z/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/linux-on-ibm-z/swift/languages","stargazers_url":"https://api.github.com/repos/linux-on-ibm-z/swift/stargazers","contributors_url":"https://api.github.com/repos/linux-on-ibm-z/swift/contributors","subscribers_url":"https://api.github.com/repos/linux-on-ibm-z/swift/subscribers","subscription_url":"https://api.github.com/repos/linux-on-ibm-z/swift/subscription","commits_url":"https://api.github.com/repos/linux-on-ibm-z/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/linux-on-ibm-z/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/linux-on-ibm-z/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/linux-on-ibm-z/swift/contents/{+path}","compare_url":"https://api.github.com/repos/linux-on-ibm-z/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linux-on-ibm-z/swift/merges","archive_url":"https://api.github.com/repos/linux-on-ibm-z/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linux-on-ibm-z/swift/downloads","issues_url":"https://api.github.com/repos/linux-on-ibm-z/swift/issues{/number}","pulls_url":"https://api.github.com/repos/linux-on-ibm-z/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/linux-on-ibm-z/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/linux-on-ibm-z/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linux-on-ibm-z/swift/labels{/name}","releases_url":"https://api.github.com/repos/linux-on-ibm-z/swift/releases{/id}","deployments_url":"https://api.github.com/repos/linux-on-ibm-z/swift/deployments","created_at":"2016-05-14T17:16:00Z","updated_at":"2016-05-14T17:21:32Z","pushed_at":"2016-06-23T18:47:15Z","git_url":"git://github.com/linux-on-ibm-z/swift.git","ssh_url":"git@github.com:linux-on-ibm-z/swift.git","clone_url":"https://github.com/linux-on-ibm-z/swift.git","svn_url":"https://github.com/linux-on-ibm-z/swift","homepage":"https://swift.org/","size":99520,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"104a72fe8ec2e37f991f73a5dbe9ed502b25dbfa","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-06-24T14:07:12Z","pushed_at":"2016-06-24T14:35:00Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":155640,"stargazers_count":31805,"watchers_count":31805,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4351,"mirror_url":null,"open_issues_count":105,"forks":4351,"open_issues":105,"watchers":31805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/3193"},"html":{"href":"https://github.com/apple/swift/pull/3193"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/3193"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/3193/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/3193/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/3193/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/5224f17ac9c1e3ffcf8ca61778da708e8afcc087"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":42,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"garyliu1"}}