{"action":"opened","number":300,"pull_request":{"url":"https://api.github.com/repos/eutelescope/eutelescope/pulls/300","id":85190231,"html_url":"https://github.com/eutelescope/eutelescope/pull/300","diff_url":"https://github.com/eutelescope/eutelescope/pull/300.diff","patch_url":"https://github.com/eutelescope/eutelescope/pull/300.patch","issue_url":"https://api.github.com/repos/eutelescope/eutelescope/issues/300","number":300,"state":"open","locked":false,"title":"Analysisupdate","user":{"login":"gollumben","id":20727999,"avatar_url":"https://avatars.githubusercontent.com/u/20727999?v=3","gravatar_id":"","url":"https://api.github.com/users/gollumben","html_url":"https://github.com/gollumben","followers_url":"https://api.github.com/users/gollumben/followers","following_url":"https://api.github.com/users/gollumben/following{/other_user}","gists_url":"https://api.github.com/users/gollumben/gists{/gist_id}","starred_url":"https://api.github.com/users/gollumben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gollumben/subscriptions","organizations_url":"https://api.github.com/users/gollumben/orgs","repos_url":"https://api.github.com/users/gollumben/repos","events_url":"https://api.github.com/users/gollumben/events{/privacy}","received_events_url":"https://api.github.com/users/gollumben/received_events","type":"User","site_admin":false},"body":"The changes here affect the EUTelProcessorAnalysisPALPIDEfs.cc only. I.e. only changes to code from the ALICE testbeam analysis software were done. These changes are:\r\n\r\n1.) The way the RemoveAlign function, which removes the alignment from aligned data, removes the alignment, was made consistent with way the EUTelProcessorApplyAlignment.cc applies the alignment.\r\n\r\n2.) The rotation order in the _EulerRotationBack function was made consistent with the X, Y, Z order from the previous pull-request. If this order should have been changed, please also alter this order, such that it is the inverse of the order, in which the rotations are applied. This refers in particular to the order, in which rotations are applied in the EUTelGeometryTelescopeGeoDescription.cpp.\r\n\r\n3.) Some code was put into the function _LayerRotationBack, to make the overall code more readable.\r\n\r\n4.) Some other, purely cosmetic changes were added.","created_at":"2016-09-14T08:59:56Z","updated_at":"2016-09-14T08:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eutelescope/eutelescope/pulls/300/commits","review_comments_url":"https://api.github.com/repos/eutelescope/eutelescope/pulls/300/comments","review_comment_url":"https://api.github.com/repos/eutelescope/eutelescope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eutelescope/eutelescope/issues/300/comments","statuses_url":"https://api.github.com/repos/eutelescope/eutelescope/statuses/cb712d9fdace4ec9e788b96bd52d428be653e220","head":{"label":"gollumben:analysisupdate","ref":"analysisupdate","sha":"cb712d9fdace4ec9e788b96bd52d428be653e220","user":{"login":"gollumben","id":20727999,"avatar_url":"https://avatars.githubusercontent.com/u/20727999?v=3","gravatar_id":"","url":"https://api.github.com/users/gollumben","html_url":"https://github.com/gollumben","followers_url":"https://api.github.com/users/gollumben/followers","following_url":"https://api.github.com/users/gollumben/following{/other_user}","gists_url":"https://api.github.com/users/gollumben/gists{/gist_id}","starred_url":"https://api.github.com/users/gollumben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gollumben/subscriptions","organizations_url":"https://api.github.com/users/gollumben/orgs","repos_url":"https://api.github.com/users/gollumben/repos","events_url":"https://api.github.com/users/gollumben/events{/privacy}","received_events_url":"https://api.github.com/users/gollumben/received_events","type":"User","site_admin":false},"repo":{"id":64677868,"name":"eutelescope","full_name":"gollumben/eutelescope","owner":{"login":"gollumben","id":20727999,"avatar_url":"https://avatars.githubusercontent.com/u/20727999?v=3","gravatar_id":"","url":"https://api.github.com/users/gollumben","html_url":"https://github.com/gollumben","followers_url":"https://api.github.com/users/gollumben/followers","following_url":"https://api.github.com/users/gollumben/following{/other_user}","gists_url":"https://api.github.com/users/gollumben/gists{/gist_id}","starred_url":"https://api.github.com/users/gollumben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gollumben/subscriptions","organizations_url":"https://api.github.com/users/gollumben/orgs","repos_url":"https://api.github.com/users/gollumben/repos","events_url":"https://api.github.com/users/gollumben/events{/privacy}","received_events_url":"https://api.github.com/users/gollumben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gollumben/eutelescope","description":"EUTelescope -- A Generic Pixel Telescope Data Analysis Framework","fork":true,"url":"https://api.github.com/repos/gollumben/eutelescope","forks_url":"https://api.github.com/repos/gollumben/eutelescope/forks","keys_url":"https://api.github.com/repos/gollumben/eutelescope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gollumben/eutelescope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gollumben/eutelescope/teams","hooks_url":"https://api.github.com/repos/gollumben/eutelescope/hooks","issue_events_url":"https://api.github.com/repos/gollumben/eutelescope/issues/events{/number}","events_url":"https://api.github.com/repos/gollumben/eutelescope/events","assignees_url":"https://api.github.com/repos/gollumben/eutelescope/assignees{/user}","branches_url":"https://api.github.com/repos/gollumben/eutelescope/branches{/branch}","tags_url":"https://api.github.com/repos/gollumben/eutelescope/tags","blobs_url":"https://api.github.com/repos/gollumben/eutelescope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gollumben/eutelescope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gollumben/eutelescope/git/refs{/sha}","trees_url":"https://api.github.com/repos/gollumben/eutelescope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gollumben/eutelescope/statuses/{sha}","languages_url":"https://api.github.com/repos/gollumben/eutelescope/languages","stargazers_url":"https://api.github.com/repos/gollumben/eutelescope/stargazers","contributors_url":"https://api.github.com/repos/gollumben/eutelescope/contributors","subscribers_url":"https://api.github.com/repos/gollumben/eutelescope/subscribers","subscription_url":"https://api.github.com/repos/gollumben/eutelescope/subscription","commits_url":"https://api.github.com/repos/gollumben/eutelescope/commits{/sha}","git_commits_url":"https://api.github.com/repos/gollumben/eutelescope/git/commits{/sha}","comments_url":"https://api.github.com/repos/gollumben/eutelescope/comments{/number}","issue_comment_url":"https://api.github.com/repos/gollumben/eutelescope/issues/comments{/number}","contents_url":"https://api.github.com/repos/gollumben/eutelescope/contents/{+path}","compare_url":"https://api.github.com/repos/gollumben/eutelescope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gollumben/eutelescope/merges","archive_url":"https://api.github.com/repos/gollumben/eutelescope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gollumben/eutelescope/downloads","issues_url":"https://api.github.com/repos/gollumben/eutelescope/issues{/number}","pulls_url":"https://api.github.com/repos/gollumben/eutelescope/pulls{/number}","milestones_url":"https://api.github.com/repos/gollumben/eutelescope/milestones{/number}","notifications_url":"https://api.github.com/repos/gollumben/eutelescope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gollumben/eutelescope/labels{/name}","releases_url":"https://api.github.com/repos/gollumben/eutelescope/releases{/id}","deployments_url":"https://api.github.com/repos/gollumben/eutelescope/deployments","created_at":"2016-08-01T15:17:02Z","updated_at":"2016-08-01T15:17:06Z","pushed_at":"2016-09-13T14:59:52Z","git_url":"git://github.com/gollumben/eutelescope.git","ssh_url":"git@github.com:gollumben/eutelescope.git","clone_url":"https://github.com/gollumben/eutelescope.git","svn_url":"https://github.com/gollumben/eutelescope","homepage":null,"size":9095,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.0-tag"}},"base":{"label":"eutelescope:master","ref":"master","sha":"91d5f6f8ac6619fb70b9bd05d4ce26bc3f25f807","user":{"login":"eutelescope","id":5999095,"avatar_url":"https://avatars.githubusercontent.com/u/5999095?v=3","gravatar_id":"","url":"https://api.github.com/users/eutelescope","html_url":"https://github.com/eutelescope","followers_url":"https://api.github.com/users/eutelescope/followers","following_url":"https://api.github.com/users/eutelescope/following{/other_user}","gists_url":"https://api.github.com/users/eutelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/eutelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eutelescope/subscriptions","organizations_url":"https://api.github.com/users/eutelescope/orgs","repos_url":"https://api.github.com/users/eutelescope/repos","events_url":"https://api.github.com/users/eutelescope/events{/privacy}","received_events_url":"https://api.github.com/users/eutelescope/received_events","type":"Organization","site_admin":false},"repo":{"id":15618918,"name":"eutelescope","full_name":"eutelescope/eutelescope","owner":{"login":"eutelescope","id":5999095,"avatar_url":"https://avatars.githubusercontent.com/u/5999095?v=3","gravatar_id":"","url":"https://api.github.com/users/eutelescope","html_url":"https://github.com/eutelescope","followers_url":"https://api.github.com/users/eutelescope/followers","following_url":"https://api.github.com/users/eutelescope/following{/other_user}","gists_url":"https://api.github.com/users/eutelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/eutelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eutelescope/subscriptions","organizations_url":"https://api.github.com/users/eutelescope/orgs","repos_url":"https://api.github.com/users/eutelescope/repos","events_url":"https://api.github.com/users/eutelescope/events{/privacy}","received_events_url":"https://api.github.com/users/eutelescope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eutelescope/eutelescope","description":"EUTelescope -- A Generic Pixel Telescope Data Analysis Framework","fork":false,"url":"https://api.github.com/repos/eutelescope/eutelescope","forks_url":"https://api.github.com/repos/eutelescope/eutelescope/forks","keys_url":"https://api.github.com/repos/eutelescope/eutelescope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eutelescope/eutelescope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eutelescope/eutelescope/teams","hooks_url":"https://api.github.com/repos/eutelescope/eutelescope/hooks","issue_events_url":"https://api.github.com/repos/eutelescope/eutelescope/issues/events{/number}","events_url":"https://api.github.com/repos/eutelescope/eutelescope/events","assignees_url":"https://api.github.com/repos/eutelescope/eutelescope/assignees{/user}","branches_url":"https://api.github.com/repos/eutelescope/eutelescope/branches{/branch}","tags_url":"https://api.github.com/repos/eutelescope/eutelescope/tags","blobs_url":"https://api.github.com/repos/eutelescope/eutelescope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eutelescope/eutelescope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eutelescope/eutelescope/git/refs{/sha}","trees_url":"https://api.github.com/repos/eutelescope/eutelescope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eutelescope/eutelescope/statuses/{sha}","languages_url":"https://api.github.com/repos/eutelescope/eutelescope/languages","stargazers_url":"https://api.github.com/repos/eutelescope/eutelescope/stargazers","contributors_url":"https://api.github.com/repos/eutelescope/eutelescope/contributors","subscribers_url":"https://api.github.com/repos/eutelescope/eutelescope/subscribers","subscription_url":"https://api.github.com/repos/eutelescope/eutelescope/subscription","commits_url":"https://api.github.com/repos/eutelescope/eutelescope/commits{/sha}","git_commits_url":"https://api.github.com/repos/eutelescope/eutelescope/git/commits{/sha}","comments_url":"https://api.github.com/repos/eutelescope/eutelescope/comments{/number}","issue_comment_url":"https://api.github.com/repos/eutelescope/eutelescope/issues/comments{/number}","contents_url":"https://api.github.com/repos/eutelescope/eutelescope/contents/{+path}","compare_url":"https://api.github.com/repos/eutelescope/eutelescope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eutelescope/eutelescope/merges","archive_url":"https://api.github.com/repos/eutelescope/eutelescope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eutelescope/eutelescope/downloads","issues_url":"https://api.github.com/repos/eutelescope/eutelescope/issues{/number}","pulls_url":"https://api.github.com/repos/eutelescope/eutelescope/pulls{/number}","milestones_url":"https://api.github.com/repos/eutelescope/eutelescope/milestones{/number}","notifications_url":"https://api.github.com/repos/eutelescope/eutelescope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eutelescope/eutelescope/labels{/name}","releases_url":"https://api.github.com/repos/eutelescope/eutelescope/releases{/id}","deployments_url":"https://api.github.com/repos/eutelescope/eutelescope/deployments","created_at":"2014-01-03T20:32:34Z","updated_at":"2016-03-13T11:50:50Z","pushed_at":"2016-09-14T08:47:21Z","git_url":"git://github.com/eutelescope/eutelescope.git","ssh_url":"git@github.com:eutelescope/eutelescope.git","clone_url":"https://github.com/eutelescope/eutelescope.git","svn_url":"https://github.com/eutelescope/eutelescope","homepage":null,"size":83708,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":44,"forks":61,"open_issues":44,"watchers":5,"default_branch":"v1.0-tag"}},"_links":{"self":{"href":"https://api.github.com/repos/eutelescope/eutelescope/pulls/300"},"html":{"href":"https://github.com/eutelescope/eutelescope/pull/300"},"issue":{"href":"https://api.github.com/repos/eutelescope/eutelescope/issues/300"},"comments":{"href":"https://api.github.com/repos/eutelescope/eutelescope/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/eutelescope/eutelescope/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/eutelescope/eutelescope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eutelescope/eutelescope/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/eutelescope/eutelescope/statuses/cb712d9fdace4ec9e788b96bd52d428be653e220"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":96,"deletions":143,"changed_files":2}}
{"actor":{"display_login":"gollumben"}}