{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/714","repository_url":"https://api.github.com/repos/kubernetes/dashboard","labels_url":"https://api.github.com/repos/kubernetes/dashboard/issues/714/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/714/comments","events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/714/events","html_url":"https://github.com/kubernetes/dashboard/pull/714","id":153244558,"number":714,"title":"Add common pods list component","user":{"login":"floreks","id":2285385,"avatar_url":"https://avatars.githubusercontent.com/u/2285385?v=3","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/dashboard/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-05T14:32:18Z","updated_at":"2016-05-06T09:41:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/714","html_url":"https://github.com/kubernetes/dashboard/pull/714","diff_url":"https://github.com/kubernetes/dashboard/pull/714.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/714.patch"},"body":"I'll be refactoring resources lists to common components so it will be easier to create views for new resources.\r\n\r\nThis is pretty small. I've extracted rc pods to common pods list component.\r\n\r\nBackend will for sure need adjustment to this style. Externs also should be renamed. Now everything is tied to replication controller.\r\n\r\nShould we have 1 module for all resource lists (resourcelist module) or separate module for every resource list which will be added to component module?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubernetes/dashboard/714)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments/217398572","html_url":"https://github.com/kubernetes/dashboard/pull/714#issuecomment-217398572","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/714","id":217398572,"user":{"login":"floreks","id":2285385,"avatar_url":"https://avatars.githubusercontent.com/u/2285385?v=3","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T09:41:45Z","updated_at":"2016-05-06T09:41:45Z","body":"\n\n\n\nReview status: 4 of 10 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/app/frontend/podslist/podslist_module.js, line 15 \\[r2\\]](https://reviewable.io:443/reviews/kubernetes/dashboard/714#-KH4NSoIzvGvhyz4Av4a:-KH4QG0MzfoAWo8WPfuo:1136925115) ([raw file](https://github.com/kubernetes/dashboard/blob/3aed4002983be21f3bd19e5d61c747bc7875bfdf/src/app/frontend/podslist/podslist_module.js#L15)):*\nAhh... gramma. Thanks :)\n\n---\n\n*[src/app/frontend/replicationcontrollerdetail/replicationcontrollerdetail.html, line 28 \\[r2\\]](https://reviewable.io:443/reviews/kubernetes/dashboard/714#-KH4NgYqJuP0bYPSWX4h:-KH4Qb5iL3ZNItIn338U:824207094) ([raw file](https://github.com/kubernetes/dashboard/blob/3aed4002983be21f3bd19e5d61c747bc7875bfdf/src/app/frontend/replicationcontrollerdetail/replicationcontrollerdetail.html#L28)):*\nThat's what I thought at first but let's look at this function\n\n```javascript\nreturn this.state_.href(\n        logsStateName,\n        new LogsStateParams(\n            this.stateParams_.namespace, this.stateParams_.replicationController, pod.name));\n```\n\nAs you can see, currently logs are tied to replication controller and created link is based on rc name. We shouldn't make pod card list so closely coupled with this implementation detail because other resources don't necessarily need to use this information or these stateParams.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/kubernetes/dashboard/714)*\n<!-- Sent from Reviewable.io -->\n"}}