{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/82911420","pull_request_review_id":3785502,"id":82911420,"diff_hunk":"@@ -0,0 +1,37 @@\n+package daemon\n+\n+import (\n+\t\"github.com/docker/docker/dockerversion\"\n+\t\"github.com/docker/go-metrics\"\n+)\n+\n+var (\n+\tcontainerActions   metrics.LabeledTimer\n+\timageActions       metrics.LabeledTimer\n+\tcontainerCounter   metrics.LabeledCounter\n+\tdaemonActions      metrics.LabeledTimer\n+\tnetworkActions     metrics.LabeledTimer\n+\tengineVersion      metrics.LabeledGauge\n+\thealthCheckCounter metrics.Counter\n+)\n+\n+func init() {\n+\tns := metrics.NewNamespace(\"engine\", \"daemon\", metrics.Labels{\n+\t\t\"version\": dockerversion.Version,\n+\t\t\"commit\":  dockerversion.GitCommit,\n+\t})\n+\tcontainerActions = ns.NewLabeledTimer(\"container_actions\", \"The number of seconds it takes to process each container action\", \"action\")","path":"daemon/metrics.go","position":23,"original_position":23,"commit_id":"bc6bc4ce2cce3440003f0f1b99c732c506833d88","original_commit_id":"bc6bc4ce2cce3440003f0f1b99c732c506833d88","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"What type of Prometheus metric is this? Prometheus client libraries don't have anything called a \"LabeledTimer\".","created_at":"2016-10-11T23:36:25Z","updated_at":"2016-10-11T23:47:08Z","html_url":"https://github.com/docker/docker/pull/25820#discussion_r82911420","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/25820","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/82911420"},"html":{"href":"https://github.com/docker/docker/pull/25820#discussion_r82911420"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/25820"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/25820","id":81730724,"html_url":"https://github.com/docker/docker/pull/25820","diff_url":"https://github.com/docker/docker/pull/25820.diff","patch_url":"https://github.com/docker/docker/pull/25820.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/25820","number":25820,"state":"open","locked":false,"title":"Add metrics output to docker","user":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"body":"This adds metrics support to docker via the prometheus output.  There is a new `/metrics` endpoint where the prometheus handler is installed.\r\n\r\nThis adds metrics to the daemon package for basic container, image, and daemon operations.\r\n\r\nThe client package being used is located here:\r\n\r\nhttps://github.com/docker/go-metrics\r\n\r\n\r\nThis pr is the beginning, any more packages need to be instrumented but help/suggestions from the individual subsystem maintainers is needed to collection relevant and useful information. \r\n","created_at":"2016-08-17T22:50:03Z","updated_at":"2016-10-11T23:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c1a5c988be7aaa76b24acb0c1ba6d6632fa314c","assignee":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"assignees":[{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":359,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-10-11T22:54:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/25820/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/25820/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/25820/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/bc6bc4ce2cce3440003f0f1b99c732c506833d88","head":{"label":"crosbymichael:prom","ref":"prom","sha":"bc6bc4ce2cce3440003f0f1b99c732c506833d88","user":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"repo":{"id":13808553,"name":"docker","full_name":"crosbymichael/docker","owner":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crosbymichael/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/crosbymichael/docker","forks_url":"https://api.github.com/repos/crosbymichael/docker/forks","keys_url":"https://api.github.com/repos/crosbymichael/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosbymichael/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosbymichael/docker/teams","hooks_url":"https://api.github.com/repos/crosbymichael/docker/hooks","issue_events_url":"https://api.github.com/repos/crosbymichael/docker/issues/events{/number}","events_url":"https://api.github.com/repos/crosbymichael/docker/events","assignees_url":"https://api.github.com/repos/crosbymichael/docker/assignees{/user}","branches_url":"https://api.github.com/repos/crosbymichael/docker/branches{/branch}","tags_url":"https://api.github.com/repos/crosbymichael/docker/tags","blobs_url":"https://api.github.com/repos/crosbymichael/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosbymichael/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosbymichael/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosbymichael/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosbymichael/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/crosbymichael/docker/languages","stargazers_url":"https://api.github.com/repos/crosbymichael/docker/stargazers","contributors_url":"https://api.github.com/repos/crosbymichael/docker/contributors","subscribers_url":"https://api.github.com/repos/crosbymichael/docker/subscribers","subscription_url":"https://api.github.com/repos/crosbymichael/docker/subscription","commits_url":"https://api.github.com/repos/crosbymichael/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosbymichael/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosbymichael/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosbymichael/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosbymichael/docker/contents/{+path}","compare_url":"https://api.github.com/repos/crosbymichael/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosbymichael/docker/merges","archive_url":"https://api.github.com/repos/crosbymichael/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosbymichael/docker/downloads","issues_url":"https://api.github.com/repos/crosbymichael/docker/issues{/number}","pulls_url":"https://api.github.com/repos/crosbymichael/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/crosbymichael/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/crosbymichael/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosbymichael/docker/labels{/name}","releases_url":"https://api.github.com/repos/crosbymichael/docker/releases{/id}","deployments_url":"https://api.github.com/repos/crosbymichael/docker/deployments","created_at":"2013-10-23T16:42:55Z","updated_at":"2016-09-08T09:58:27Z","pushed_at":"2016-10-07T20:29:00Z","git_url":"git://github.com/crosbymichael/docker.git","ssh_url":"git@github.com:crosbymichael/docker.git","clone_url":"https://github.com/crosbymichael/docker.git","svn_url":"https://github.com/crosbymichael/docker","homepage":"http://www.docker.io","size":102668,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"7e29b33546098816d5dbc1fc429e868f02b69e44","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-10-11T23:31:42Z","pushed_at":"2016-10-11T23:38:52Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":210958,"stargazers_count":35771,"watchers_count":35771,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10524,"mirror_url":null,"open_issues_count":1957,"forks":10524,"open_issues":1957,"watchers":35771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/25820"},"html":{"href":"https://github.com/docker/docker/pull/25820"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/25820"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/25820/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/25820/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/25820/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/bc6bc4ce2cce3440003f0f1b99c732c506833d88"}}}}
{"actor":{"display_login":"brian-brazil"}}