{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/math/issues/391","repository_url":"https://api.github.com/repos/stan-dev/math","labels_url":"https://api.github.com/repos/stan-dev/math/issues/391/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/math/issues/391/comments","events_url":"https://api.github.com/repos/stan-dev/math/issues/391/events","html_url":"https://github.com/stan-dev/math/pull/391","id":176143778,"number":391,"title":"Remove bool returns from check functions","user":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/stan-dev/math/labels/code%20reviewed","name":"code reviewed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/stan-dev/math/milestones/10","html_url":"https://github.com/stan-dev/math/milestones/v2.12.0++","labels_url":"https://api.github.com/repos/stan-dev/math/milestones/10/labels","id":1975005,"number":10,"title":"v2.12.0++","description":"Next version after v2.12.0.","creator":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":6,"state":"open","created_at":"2016-08-31T12:59:13Z","updated_at":"2016-09-10T00:46:58Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-09-10T00:46:54Z","updated_at":"2016-09-11T02:00:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/math/pulls/391","html_url":"https://github.com/stan-dev/math/pull/391","diff_url":"https://github.com/stan-dev/math/pull/391.diff","patch_url":"https://github.com/stan-dev/math/pull/391.patch"},"body":"#### Submisison Checklist\r\n\r\n- [x] Run unit tests: `./runTests.py test/unit`\r\n- [x] Run cpplint: `make cpplint`\r\n- [x] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary:\r\n\r\n- Changed all return types from `bool` to `void` for the `check_*` functions.\r\n- Updated doxygen documentation.\r\n- Updated calls that expected a `bool` return.\r\n\r\n#### Intended Effect:\r\n\r\nMake the math library cleaner.\r\nI didn't change any of the implementation.\r\n\r\n#### How to Verify:\r\n\r\nLook at the diff. Lots of files, but it should be easy to see what's going on.\r\n\r\n#### Side Effects:\r\nPlaces that call the check functions and expect a boolean return will fail to compile. I found all the places in the math library. There may be some places upstream that will need to be fixed.\r\n\r\n#### Documentation:\r\nIncluded in the updates to the doxygen documentation.\r\n\r\n#### Reviewer Suggestions: \r\nAnyone.\r\n\r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):\r\n\r\nColumbia University\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/math/issues/comments/246156946","html_url":"https://github.com/stan-dev/math/pull/391#issuecomment-246156946","issue_url":"https://api.github.com/repos/stan-dev/math/issues/391","id":246156946,"user":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"created_at":"2016-09-11T02:00:35Z","updated_at":"2016-09-11T02:00:35Z","body":"I just pushed a branch on Stan that works with this change. I'm merging this pull request and Stan will be updated asap."}}
{"actor":{"display_login":"syclik"}}