{"action":"created","comment":{"url":"https://api.github.com/repos/angular/webdriver-manager/pulls/comments/90144481","pull_request_review_id":10668401,"id":90144481,"diff_hunk":"@@ -61,12 +61,14 @@ if (argv._[0] === 'update-run') {\n   prog.printHelp();\n }\n \n+let browserFile: BrowserFile;\n \n /**\n  * Parses the options and downloads binaries if they do not exist.\n  * @param options\n  */\n-function update(options: Options): void {\n+function update(options: Options): q.IPromise<void> {","path":"lib/cmds/update.ts","position":null,"original_position":11,"commit_id":"8ae77d72936344312f7bca268aacb6401089f9cf","original_commit_id":"b2b9bd07cccdfd8300c839d1982d6b75516e14d0","user":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2016-11-30T00:11:53Z","updated_at":"2016-11-30T00:11:53Z","html_url":"https://github.com/angular/webdriver-manager/pull/140#discussion_r90144481","pull_request_url":"https://api.github.com/repos/angular/webdriver-manager/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/angular/webdriver-manager/pulls/comments/90144481"},"html":{"href":"https://github.com/angular/webdriver-manager/pull/140#discussion_r90144481"},"pull_request":{"href":"https://api.github.com/repos/angular/webdriver-manager/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/angular/webdriver-manager/pulls/140","id":93076675,"html_url":"https://github.com/angular/webdriver-manager/pull/140","diff_url":"https://github.com/angular/webdriver-manager/pull/140.diff","patch_url":"https://github.com/angular/webdriver-manager/pull/140.patch","issue_url":"https://api.github.com/repos/angular/webdriver-manager/issues/140","number":140,"state":"open","locked":false,"title":"feat(update): on update, write full binary paths to file","user":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"body":"This feature will help directConnect users for Protractor. The file\r\nwill keep track of the last binary version as well as all other\r\nbinaries downloaded.\r\n\r\nThe file will be created in the output directory. By default this is\r\n`selenium/update-config.json`\r\n\r\n  ```\r\n  webdriver-manager update --versions.chrome=2.20 --standalone=false\r\n  --gecko=false\r\n  ```\r\n\r\n  file created:\r\n  ```\r\n  {\r\n    \"chrome\": {\r\n      \"last\": \"/opt/src/webdriver-manager/selenium/chromedriver_2.20\",\r\n      \"all\": [\"/opt/src/webdriver-manager/selenium/chromedriver_2.20\"]\r\n    }\r\n  }\r\n  ```\r\n\r\n  then the user wants to use 2.25:\r\n\r\n  ```\r\n  webdriver-manager update --versions.chrome=2.25 --standalone=false\r\n  --gecko=false\r\n\r\n  ```\r\n\r\n  file created:\r\n  ```\r\n  {\r\n    \"chrome\": {\r\n      \"last\": \"/opt/src/webdriver-manager/selenium/chromedriver_2.25\",\r\n      \"all\": [\"/opt/src/webdriver-manager/selenium/chromedriver_2.20\",\r\n              \"/opt/src/webdriver-manager/selenium/chromedriver_2.25\"]\r\n    }\r\n  }\r\n  ```","created_at":"2016-11-10T02:32:29Z","updated_at":"2016-11-30T00:11:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3a4fcb4c788540a2ed979878b10071e9c30ef9e","assignee":{"login":"sjelin","id":4841675,"avatar_url":"https://avatars.githubusercontent.com/u/4841675?v=3","gravatar_id":"","url":"https://api.github.com/users/sjelin","html_url":"https://github.com/sjelin","followers_url":"https://api.github.com/users/sjelin/followers","following_url":"https://api.github.com/users/sjelin/following{/other_user}","gists_url":"https://api.github.com/users/sjelin/gists{/gist_id}","starred_url":"https://api.github.com/users/sjelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjelin/subscriptions","organizations_url":"https://api.github.com/users/sjelin/orgs","repos_url":"https://api.github.com/users/sjelin/repos","events_url":"https://api.github.com/users/sjelin/events{/privacy}","received_events_url":"https://api.github.com/users/sjelin/received_events","type":"User","site_admin":false},"assignees":[{"login":"sjelin","id":4841675,"avatar_url":"https://avatars.githubusercontent.com/u/4841675?v=3","gravatar_id":"","url":"https://api.github.com/users/sjelin","html_url":"https://github.com/sjelin","followers_url":"https://api.github.com/users/sjelin/followers","following_url":"https://api.github.com/users/sjelin/following{/other_user}","gists_url":"https://api.github.com/users/sjelin/gists{/gist_id}","starred_url":"https://api.github.com/users/sjelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjelin/subscriptions","organizations_url":"https://api.github.com/users/sjelin/orgs","repos_url":"https://api.github.com/users/sjelin/repos","events_url":"https://api.github.com/users/sjelin/events{/privacy}","received_events_url":"https://api.github.com/users/sjelin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/webdriver-manager/pulls/140/commits","review_comments_url":"https://api.github.com/repos/angular/webdriver-manager/pulls/140/comments","review_comment_url":"https://api.github.com/repos/angular/webdriver-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/webdriver-manager/issues/140/comments","statuses_url":"https://api.github.com/repos/angular/webdriver-manager/statuses/8ae77d72936344312f7bca268aacb6401089f9cf","head":{"label":"cnishina:last_downloaded","ref":"last_downloaded","sha":"8ae77d72936344312f7bca268aacb6401089f9cf","user":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"repo":{"id":57101380,"name":"webdriver-manager","full_name":"cnishina/webdriver-manager","owner":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cnishina/webdriver-manager","description":"A binary manager for E2E testing","fork":true,"url":"https://api.github.com/repos/cnishina/webdriver-manager","forks_url":"https://api.github.com/repos/cnishina/webdriver-manager/forks","keys_url":"https://api.github.com/repos/cnishina/webdriver-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnishina/webdriver-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnishina/webdriver-manager/teams","hooks_url":"https://api.github.com/repos/cnishina/webdriver-manager/hooks","issue_events_url":"https://api.github.com/repos/cnishina/webdriver-manager/issues/events{/number}","events_url":"https://api.github.com/repos/cnishina/webdriver-manager/events","assignees_url":"https://api.github.com/repos/cnishina/webdriver-manager/assignees{/user}","branches_url":"https://api.github.com/repos/cnishina/webdriver-manager/branches{/branch}","tags_url":"https://api.github.com/repos/cnishina/webdriver-manager/tags","blobs_url":"https://api.github.com/repos/cnishina/webdriver-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnishina/webdriver-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnishina/webdriver-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnishina/webdriver-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnishina/webdriver-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/cnishina/webdriver-manager/languages","stargazers_url":"https://api.github.com/repos/cnishina/webdriver-manager/stargazers","contributors_url":"https://api.github.com/repos/cnishina/webdriver-manager/contributors","subscribers_url":"https://api.github.com/repos/cnishina/webdriver-manager/subscribers","subscription_url":"https://api.github.com/repos/cnishina/webdriver-manager/subscription","commits_url":"https://api.github.com/repos/cnishina/webdriver-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnishina/webdriver-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnishina/webdriver-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnishina/webdriver-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnishina/webdriver-manager/contents/{+path}","compare_url":"https://api.github.com/repos/cnishina/webdriver-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnishina/webdriver-manager/merges","archive_url":"https://api.github.com/repos/cnishina/webdriver-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnishina/webdriver-manager/downloads","issues_url":"https://api.github.com/repos/cnishina/webdriver-manager/issues{/number}","pulls_url":"https://api.github.com/repos/cnishina/webdriver-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/cnishina/webdriver-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/cnishina/webdriver-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnishina/webdriver-manager/labels{/name}","releases_url":"https://api.github.com/repos/cnishina/webdriver-manager/releases{/id}","deployments_url":"https://api.github.com/repos/cnishina/webdriver-manager/deployments","created_at":"2016-04-26T05:45:35Z","updated_at":"2016-10-24T17:50:03Z","pushed_at":"2016-11-30T00:10:31Z","git_url":"git://github.com/cnishina/webdriver-manager.git","ssh_url":"git@github.com:cnishina/webdriver-manager.git","clone_url":"https://github.com/cnishina/webdriver-manager.git","svn_url":"https://github.com/cnishina/webdriver-manager","homepage":"","size":203,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f38a713422ff346f4dc17fba4ae5b30076aa5113","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":55717035,"name":"webdriver-manager","full_name":"angular/webdriver-manager","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/webdriver-manager","description":"A binary manager for E2E testing","fork":false,"url":"https://api.github.com/repos/angular/webdriver-manager","forks_url":"https://api.github.com/repos/angular/webdriver-manager/forks","keys_url":"https://api.github.com/repos/angular/webdriver-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/webdriver-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/webdriver-manager/teams","hooks_url":"https://api.github.com/repos/angular/webdriver-manager/hooks","issue_events_url":"https://api.github.com/repos/angular/webdriver-manager/issues/events{/number}","events_url":"https://api.github.com/repos/angular/webdriver-manager/events","assignees_url":"https://api.github.com/repos/angular/webdriver-manager/assignees{/user}","branches_url":"https://api.github.com/repos/angular/webdriver-manager/branches{/branch}","tags_url":"https://api.github.com/repos/angular/webdriver-manager/tags","blobs_url":"https://api.github.com/repos/angular/webdriver-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/webdriver-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/webdriver-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/webdriver-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/webdriver-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/webdriver-manager/languages","stargazers_url":"https://api.github.com/repos/angular/webdriver-manager/stargazers","contributors_url":"https://api.github.com/repos/angular/webdriver-manager/contributors","subscribers_url":"https://api.github.com/repos/angular/webdriver-manager/subscribers","subscription_url":"https://api.github.com/repos/angular/webdriver-manager/subscription","commits_url":"https://api.github.com/repos/angular/webdriver-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/webdriver-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/webdriver-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/webdriver-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/webdriver-manager/contents/{+path}","compare_url":"https://api.github.com/repos/angular/webdriver-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/webdriver-manager/merges","archive_url":"https://api.github.com/repos/angular/webdriver-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/webdriver-manager/downloads","issues_url":"https://api.github.com/repos/angular/webdriver-manager/issues{/number}","pulls_url":"https://api.github.com/repos/angular/webdriver-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/webdriver-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/webdriver-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/webdriver-manager/labels{/name}","releases_url":"https://api.github.com/repos/angular/webdriver-manager/releases{/id}","deployments_url":"https://api.github.com/repos/angular/webdriver-manager/deployments","created_at":"2016-04-07T18:11:08Z","updated_at":"2016-11-29T15:00:39Z","pushed_at":"2016-11-30T00:10:31Z","git_url":"git://github.com/angular/webdriver-manager.git","ssh_url":"git@github.com:angular/webdriver-manager.git","clone_url":"https://github.com/angular/webdriver-manager.git","svn_url":"https://github.com/angular/webdriver-manager","homepage":"","size":248,"stargazers_count":41,"watchers_count":41,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":21,"forks":25,"open_issues":21,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/webdriver-manager/pulls/140"},"html":{"href":"https://github.com/angular/webdriver-manager/pull/140"},"issue":{"href":"https://api.github.com/repos/angular/webdriver-manager/issues/140"},"comments":{"href":"https://api.github.com/repos/angular/webdriver-manager/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/webdriver-manager/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/webdriver-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/webdriver-manager/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/angular/webdriver-manager/statuses/8ae77d72936344312f7bca268aacb6401089f9cf"}}}}
{"actor":{"display_login":"cnishina"}}