{"action":"created","comment":{"url":"https://api.github.com/repos/milessabin/shapeless/pulls/comments/64992968","id":64992968,"diff_hunk":"@@ -152,4 +193,17 @@ class RecordMacros(val c: whitebox.Context) {\n       case(elem, acc) => q\"\"\" $hconsValueTree(${promoteElem(elem)}, $acc) \"\"\"\n     }\n   }\n+\n+  def mkParamsImpl[L <: HList](method: MethodSymbol, rec: Expr[L]): List[Tree] = {\n+    def mkElem(keyTpe: Type, value: Tree): Tree =\n+      q\"implicitly[shapeless.ops.hlist.Selector[${rec.actualType}, ${mkFieldTpe(keyTpe, value.tpe)}]].apply($rec)\"","path":"core/src/main/scala/shapeless/records.scala","position":83,"original_position":83,"commit_id":"76446d615232159355b09ab14e41ad0cfab0d98a","original_commit_id":"76446d615232159355b09ab14e41ad0cfab0d98a","user":{"login":"fthomas","id":141252,"avatar_url":"https://avatars.githubusercontent.com/u/141252?v=3","gravatar_id":"","url":"https://api.github.com/users/fthomas","html_url":"https://github.com/fthomas","followers_url":"https://api.github.com/users/fthomas/followers","following_url":"https://api.github.com/users/fthomas/following{/other_user}","gists_url":"https://api.github.com/users/fthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/fthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fthomas/subscriptions","organizations_url":"https://api.github.com/users/fthomas/orgs","repos_url":"https://api.github.com/users/fthomas/repos","events_url":"https://api.github.com/users/fthomas/events{/privacy}","received_events_url":"https://api.github.com/users/fthomas/received_events","type":"User","site_admin":false},"body":"@beezee A general remark when writing macros: Non-interpolated terms and types in quasiquotes (like `implicitly` and `Selector`) should be fully qualified to avoid macro hygiene issues. So in this case you should use `_root_.scala.Predef.implicitly` and `_root_.shapeless.ops.hlist.Selector`.","created_at":"2016-05-28T19:26:29Z","updated_at":"2016-05-28T19:26:29Z","html_url":"https://github.com/milessabin/shapeless/pull/603#discussion_r64992968","pull_request_url":"https://api.github.com/repos/milessabin/shapeless/pulls/603","_links":{"self":{"href":"https://api.github.com/repos/milessabin/shapeless/pulls/comments/64992968"},"html":{"href":"https://github.com/milessabin/shapeless/pull/603#discussion_r64992968"},"pull_request":{"href":"https://api.github.com/repos/milessabin/shapeless/pulls/603"}}},"pull_request":{"url":"https://api.github.com/repos/milessabin/shapeless/pulls/603","id":71807045,"html_url":"https://github.com/milessabin/shapeless/pull/603","diff_url":"https://github.com/milessabin/shapeless/pull/603.diff","patch_url":"https://github.com/milessabin/shapeless/pull/603.patch","issue_url":"https://api.github.com/repos/milessabin/shapeless/issues/603","number":603,"state":"open","locked":false,"title":"RecordArg, inverse of RecordArgs trait","user":{"login":"beezee","id":682587,"avatar_url":"https://avatars.githubusercontent.com/u/682587?v=3","gravatar_id":"","url":"https://api.github.com/users/beezee","html_url":"https://github.com/beezee","followers_url":"https://api.github.com/users/beezee/followers","following_url":"https://api.github.com/users/beezee/following{/other_user}","gists_url":"https://api.github.com/users/beezee/gists{/gist_id}","starred_url":"https://api.github.com/users/beezee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beezee/subscriptions","organizations_url":"https://api.github.com/users/beezee/orgs","repos_url":"https://api.github.com/users/beezee/repos","events_url":"https://api.github.com/users/beezee/events{/privacy}","received_events_url":"https://api.github.com/users/beezee/received_events","type":"User","site_admin":false},"body":"This adds a RecordArg trait, which is essentially the inverse of the RecordArgs trait. Specifically, instead of allowing forward from \"method\" to \"methodRecord\" where method can be passed named parameters that will be rolled into a record for the forwarded call, this allows forwarding from \"methodRecord\" to \"method\", where the signature of method is used to access required parameters from a record passed to the original call.\r\n\r\nThis allows a more typesafe application of functions that may take a series of similarly typed parameters, so that parameter order cannot be mistaken in such a way as to produce errors or incorrect behavior at runtime.\r\n\r\nEG - https://gist.github.com/beezee/fe604473c557564f9a6c1be06bc0960d\r\n\r\nRe-open of #602 after correcting commit history and cleaning up a stray import and definition.","created_at":"2016-05-28T17:14:59Z","updated_at":"2016-05-28T19:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2cb3589f66c908430d4981ca7dfb792c590dda","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/milessabin/shapeless/pulls/603/commits","review_comments_url":"https://api.github.com/repos/milessabin/shapeless/pulls/603/comments","review_comment_url":"https://api.github.com/repos/milessabin/shapeless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/milessabin/shapeless/issues/603/comments","statuses_url":"https://api.github.com/repos/milessabin/shapeless/statuses/76446d615232159355b09ab14e41ad0cfab0d98a","head":{"label":"beezee:recordarg_trait","ref":"recordarg_trait","sha":"76446d615232159355b09ab14e41ad0cfab0d98a","user":{"login":"beezee","id":682587,"avatar_url":"https://avatars.githubusercontent.com/u/682587?v=3","gravatar_id":"","url":"https://api.github.com/users/beezee","html_url":"https://github.com/beezee","followers_url":"https://api.github.com/users/beezee/followers","following_url":"https://api.github.com/users/beezee/following{/other_user}","gists_url":"https://api.github.com/users/beezee/gists{/gist_id}","starred_url":"https://api.github.com/users/beezee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beezee/subscriptions","organizations_url":"https://api.github.com/users/beezee/orgs","repos_url":"https://api.github.com/users/beezee/repos","events_url":"https://api.github.com/users/beezee/events{/privacy}","received_events_url":"https://api.github.com/users/beezee/received_events","type":"User","site_admin":false},"repo":{"id":59896640,"name":"shapeless","full_name":"beezee/shapeless","owner":{"login":"beezee","id":682587,"avatar_url":"https://avatars.githubusercontent.com/u/682587?v=3","gravatar_id":"","url":"https://api.github.com/users/beezee","html_url":"https://github.com/beezee","followers_url":"https://api.github.com/users/beezee/followers","following_url":"https://api.github.com/users/beezee/following{/other_user}","gists_url":"https://api.github.com/users/beezee/gists{/gist_id}","starred_url":"https://api.github.com/users/beezee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beezee/subscriptions","organizations_url":"https://api.github.com/users/beezee/orgs","repos_url":"https://api.github.com/users/beezee/repos","events_url":"https://api.github.com/users/beezee/events{/privacy}","received_events_url":"https://api.github.com/users/beezee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beezee/shapeless","description":"Generic programming for Scala","fork":true,"url":"https://api.github.com/repos/beezee/shapeless","forks_url":"https://api.github.com/repos/beezee/shapeless/forks","keys_url":"https://api.github.com/repos/beezee/shapeless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beezee/shapeless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beezee/shapeless/teams","hooks_url":"https://api.github.com/repos/beezee/shapeless/hooks","issue_events_url":"https://api.github.com/repos/beezee/shapeless/issues/events{/number}","events_url":"https://api.github.com/repos/beezee/shapeless/events","assignees_url":"https://api.github.com/repos/beezee/shapeless/assignees{/user}","branches_url":"https://api.github.com/repos/beezee/shapeless/branches{/branch}","tags_url":"https://api.github.com/repos/beezee/shapeless/tags","blobs_url":"https://api.github.com/repos/beezee/shapeless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beezee/shapeless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beezee/shapeless/git/refs{/sha}","trees_url":"https://api.github.com/repos/beezee/shapeless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beezee/shapeless/statuses/{sha}","languages_url":"https://api.github.com/repos/beezee/shapeless/languages","stargazers_url":"https://api.github.com/repos/beezee/shapeless/stargazers","contributors_url":"https://api.github.com/repos/beezee/shapeless/contributors","subscribers_url":"https://api.github.com/repos/beezee/shapeless/subscribers","subscription_url":"https://api.github.com/repos/beezee/shapeless/subscription","commits_url":"https://api.github.com/repos/beezee/shapeless/commits{/sha}","git_commits_url":"https://api.github.com/repos/beezee/shapeless/git/commits{/sha}","comments_url":"https://api.github.com/repos/beezee/shapeless/comments{/number}","issue_comment_url":"https://api.github.com/repos/beezee/shapeless/issues/comments{/number}","contents_url":"https://api.github.com/repos/beezee/shapeless/contents/{+path}","compare_url":"https://api.github.com/repos/beezee/shapeless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beezee/shapeless/merges","archive_url":"https://api.github.com/repos/beezee/shapeless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beezee/shapeless/downloads","issues_url":"https://api.github.com/repos/beezee/shapeless/issues{/number}","pulls_url":"https://api.github.com/repos/beezee/shapeless/pulls{/number}","milestones_url":"https://api.github.com/repos/beezee/shapeless/milestones{/number}","notifications_url":"https://api.github.com/repos/beezee/shapeless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beezee/shapeless/labels{/name}","releases_url":"https://api.github.com/repos/beezee/shapeless/releases{/id}","deployments_url":"https://api.github.com/repos/beezee/shapeless/deployments","created_at":"2016-05-28T13:46:05Z","updated_at":"2016-05-28T13:46:09Z","pushed_at":"2016-05-28T17:11:13Z","git_url":"git://github.com/beezee/shapeless.git","ssh_url":"git@github.com:beezee/shapeless.git","clone_url":"https://github.com/beezee/shapeless.git","svn_url":"https://github.com/beezee/shapeless","homepage":"","size":5177,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"milessabin:master","ref":"master","sha":"a719bba5bf74f5e4225d51a66b3b5f468ba49f02","user":{"login":"milessabin","id":131183,"avatar_url":"https://avatars.githubusercontent.com/u/131183?v=3","gravatar_id":"","url":"https://api.github.com/users/milessabin","html_url":"https://github.com/milessabin","followers_url":"https://api.github.com/users/milessabin/followers","following_url":"https://api.github.com/users/milessabin/following{/other_user}","gists_url":"https://api.github.com/users/milessabin/gists{/gist_id}","starred_url":"https://api.github.com/users/milessabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milessabin/subscriptions","organizations_url":"https://api.github.com/users/milessabin/orgs","repos_url":"https://api.github.com/users/milessabin/repos","events_url":"https://api.github.com/users/milessabin/events{/privacy}","received_events_url":"https://api.github.com/users/milessabin/received_events","type":"User","site_admin":false},"repo":{"id":3006066,"name":"shapeless","full_name":"milessabin/shapeless","owner":{"login":"milessabin","id":131183,"avatar_url":"https://avatars.githubusercontent.com/u/131183?v=3","gravatar_id":"","url":"https://api.github.com/users/milessabin","html_url":"https://github.com/milessabin","followers_url":"https://api.github.com/users/milessabin/followers","following_url":"https://api.github.com/users/milessabin/following{/other_user}","gists_url":"https://api.github.com/users/milessabin/gists{/gist_id}","starred_url":"https://api.github.com/users/milessabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milessabin/subscriptions","organizations_url":"https://api.github.com/users/milessabin/orgs","repos_url":"https://api.github.com/users/milessabin/repos","events_url":"https://api.github.com/users/milessabin/events{/privacy}","received_events_url":"https://api.github.com/users/milessabin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milessabin/shapeless","description":"Generic programming for Scala","fork":false,"url":"https://api.github.com/repos/milessabin/shapeless","forks_url":"https://api.github.com/repos/milessabin/shapeless/forks","keys_url":"https://api.github.com/repos/milessabin/shapeless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milessabin/shapeless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milessabin/shapeless/teams","hooks_url":"https://api.github.com/repos/milessabin/shapeless/hooks","issue_events_url":"https://api.github.com/repos/milessabin/shapeless/issues/events{/number}","events_url":"https://api.github.com/repos/milessabin/shapeless/events","assignees_url":"https://api.github.com/repos/milessabin/shapeless/assignees{/user}","branches_url":"https://api.github.com/repos/milessabin/shapeless/branches{/branch}","tags_url":"https://api.github.com/repos/milessabin/shapeless/tags","blobs_url":"https://api.github.com/repos/milessabin/shapeless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milessabin/shapeless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milessabin/shapeless/git/refs{/sha}","trees_url":"https://api.github.com/repos/milessabin/shapeless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milessabin/shapeless/statuses/{sha}","languages_url":"https://api.github.com/repos/milessabin/shapeless/languages","stargazers_url":"https://api.github.com/repos/milessabin/shapeless/stargazers","contributors_url":"https://api.github.com/repos/milessabin/shapeless/contributors","subscribers_url":"https://api.github.com/repos/milessabin/shapeless/subscribers","subscription_url":"https://api.github.com/repos/milessabin/shapeless/subscription","commits_url":"https://api.github.com/repos/milessabin/shapeless/commits{/sha}","git_commits_url":"https://api.github.com/repos/milessabin/shapeless/git/commits{/sha}","comments_url":"https://api.github.com/repos/milessabin/shapeless/comments{/number}","issue_comment_url":"https://api.github.com/repos/milessabin/shapeless/issues/comments{/number}","contents_url":"https://api.github.com/repos/milessabin/shapeless/contents/{+path}","compare_url":"https://api.github.com/repos/milessabin/shapeless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milessabin/shapeless/merges","archive_url":"https://api.github.com/repos/milessabin/shapeless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milessabin/shapeless/downloads","issues_url":"https://api.github.com/repos/milessabin/shapeless/issues{/number}","pulls_url":"https://api.github.com/repos/milessabin/shapeless/pulls{/number}","milestones_url":"https://api.github.com/repos/milessabin/shapeless/milestones{/number}","notifications_url":"https://api.github.com/repos/milessabin/shapeless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milessabin/shapeless/labels{/name}","releases_url":"https://api.github.com/repos/milessabin/shapeless/releases{/id}","deployments_url":"https://api.github.com/repos/milessabin/shapeless/deployments","created_at":"2011-12-18T13:36:38Z","updated_at":"2016-05-28T16:23:28Z","pushed_at":"2016-05-28T18:51:08Z","git_url":"git://github.com/milessabin/shapeless.git","ssh_url":"git@github.com:milessabin/shapeless.git","clone_url":"https://github.com/milessabin/shapeless.git","svn_url":"https://github.com/milessabin/shapeless","homepage":"","size":7471,"stargazers_count":1575,"watchers_count":1575,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":55,"forks":254,"open_issues":55,"watchers":1575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/milessabin/shapeless/pulls/603"},"html":{"href":"https://github.com/milessabin/shapeless/pull/603"},"issue":{"href":"https://api.github.com/repos/milessabin/shapeless/issues/603"},"comments":{"href":"https://api.github.com/repos/milessabin/shapeless/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/milessabin/shapeless/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/milessabin/shapeless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/milessabin/shapeless/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/milessabin/shapeless/statuses/76446d615232159355b09ab14e41ad0cfab0d98a"}}}}
{"actor":{"display_login":"fthomas"}}