{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/10177","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/10177/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10177/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/10177/events","html_url":"https://github.com/nodejs/node/pull/10177","id":194253162,"number":10177,"title":"test: swaps var for let/const throughout common module","user":{"login":"homosaur","id":109983,"avatar_url":"https://avatars.githubusercontent.com/u/109983?v=3","gravatar_id":"","url":"https://api.github.com/users/homosaur","html_url":"https://github.com/homosaur","followers_url":"https://api.github.com/users/homosaur/followers","following_url":"https://api.github.com/users/homosaur/following{/other_user}","gists_url":"https://api.github.com/users/homosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/homosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homosaur/subscriptions","organizations_url":"https://api.github.com/users/homosaur/orgs","repos_url":"https://api.github.com/users/homosaur/repos","events_url":"https://api.github.com/users/homosaur/events{/privacy}","received_events_url":"https://api.github.com/users/homosaur/received_events","type":"User","site_admin":false},"labels":[{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-12-08T05:52:45Z","updated_at":"2016-12-16T15:51:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10177","html_url":"https://github.com/nodejs/node/pull/10177","diff_url":"https://github.com/nodejs/node/pull/10177.diff","patch_url":"https://github.com/nodejs/node/pull/10177.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nSwaps var for let/const throughout the common.js module. The exception is line 42 in the rimrafSync function. Both let and const are causing tons of test failures in that instance."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/267624333","html_url":"https://github.com/nodejs/node/pull/10177#issuecomment-267624333","issue_url":"https://api.github.com/repos/nodejs/node/issues/10177","id":267624333,"user":{"login":"homosaur","id":109983,"avatar_url":"https://avatars.githubusercontent.com/u/109983?v=3","gravatar_id":"","url":"https://api.github.com/users/homosaur","html_url":"https://github.com/homosaur","followers_url":"https://api.github.com/users/homosaur/followers","following_url":"https://api.github.com/users/homosaur/following{/other_user}","gists_url":"https://api.github.com/users/homosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/homosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homosaur/subscriptions","organizations_url":"https://api.github.com/users/homosaur/orgs","repos_url":"https://api.github.com/users/homosaur/repos","events_url":"https://api.github.com/users/homosaur/events{/privacy}","received_events_url":"https://api.github.com/users/homosaur/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T15:51:36Z","updated_at":"2016-12-16T15:51:36Z","body":"@lpinca Changed block to your suggestion, test suite does pass. Thanks!"}}
{"actor":{"display_login":"homosaur"}}