{"action":"closed","number":470,"pull_request":{"url":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/470","id":65451493,"html_url":"https://github.com/aksonov/react-native-router-flux/pull/470","diff_url":"https://github.com/aksonov/react-native-router-flux/pull/470.diff","patch_url":"https://github.com/aksonov/react-native-router-flux/pull/470.patch","issue_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/470","number":470,"state":"closed","locked":false,"title":"Make `sceneStyle` work without having to apply styles manually","user":{"login":"domchristie","id":111734,"avatar_url":"https://avatars.githubusercontent.com/u/111734?v=3","gravatar_id":"","url":"https://api.github.com/users/domchristie","html_url":"https://github.com/domchristie","followers_url":"https://api.github.com/users/domchristie/followers","following_url":"https://api.github.com/users/domchristie/following{/other_user}","gists_url":"https://api.github.com/users/domchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/domchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domchristie/subscriptions","organizations_url":"https://api.github.com/users/domchristie/orgs","repos_url":"https://api.github.com/users/domchristie/repos","events_url":"https://api.github.com/users/domchristie/events{/privacy}","received_events_url":"https://api.github.com/users/domchristie/received_events","type":"User","site_admin":false},"body":"This PR wraps each Scene component in a view so that `sceneStyle`s can be applied without the developer having to set them manually.\r\n\r\nThis idea was discussed in https://github.com/aksonov/react-native-router-flux/commit/c42b48b1e04bec828b11a6417708320f150493dc\r\n\r\n`sceneStyle` will not have any effect on Scenes that do not specify a component.\r\n\r\nExample code is tidied up to avoid confusion.\r\n\r\nRelated: #452 ","created_at":"2016-04-06T11:40:01Z","updated_at":"2016-04-06T11:41:26Z","closed_at":"2016-04-06T11:41:26Z","merged_at":"2016-04-06T11:41:25Z","merge_commit_sha":"94c544484898f650fa1071d3e0e8af689320dfbf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/470/commits","review_comments_url":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/470/comments","review_comment_url":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/470/comments","statuses_url":"https://api.github.com/repos/aksonov/react-native-router-flux/statuses/94180c1332759f14332a7fd5da18c00f35e22351","head":{"label":"domchristie:sceneStyle","ref":"sceneStyle","sha":"94180c1332759f14332a7fd5da18c00f35e22351","user":{"login":"domchristie","id":111734,"avatar_url":"https://avatars.githubusercontent.com/u/111734?v=3","gravatar_id":"","url":"https://api.github.com/users/domchristie","html_url":"https://github.com/domchristie","followers_url":"https://api.github.com/users/domchristie/followers","following_url":"https://api.github.com/users/domchristie/following{/other_user}","gists_url":"https://api.github.com/users/domchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/domchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domchristie/subscriptions","organizations_url":"https://api.github.com/users/domchristie/orgs","repos_url":"https://api.github.com/users/domchristie/repos","events_url":"https://api.github.com/users/domchristie/events{/privacy}","received_events_url":"https://api.github.com/users/domchristie/received_events","type":"User","site_admin":false},"repo":{"id":55428211,"name":"react-native-router-flux","full_name":"domchristie/react-native-router-flux","owner":{"login":"domchristie","id":111734,"avatar_url":"https://avatars.githubusercontent.com/u/111734?v=3","gravatar_id":"","url":"https://api.github.com/users/domchristie","html_url":"https://github.com/domchristie","followers_url":"https://api.github.com/users/domchristie/followers","following_url":"https://api.github.com/users/domchristie/following{/other_user}","gists_url":"https://api.github.com/users/domchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/domchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domchristie/subscriptions","organizations_url":"https://api.github.com/users/domchristie/orgs","repos_url":"https://api.github.com/users/domchristie/repos","events_url":"https://api.github.com/users/domchristie/events{/privacy}","received_events_url":"https://api.github.com/users/domchristie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domchristie/react-native-router-flux","description":"React Native Router based on new React Native Navigation API","fork":true,"url":"https://api.github.com/repos/domchristie/react-native-router-flux","forks_url":"https://api.github.com/repos/domchristie/react-native-router-flux/forks","keys_url":"https://api.github.com/repos/domchristie/react-native-router-flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domchristie/react-native-router-flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domchristie/react-native-router-flux/teams","hooks_url":"https://api.github.com/repos/domchristie/react-native-router-flux/hooks","issue_events_url":"https://api.github.com/repos/domchristie/react-native-router-flux/issues/events{/number}","events_url":"https://api.github.com/repos/domchristie/react-native-router-flux/events","assignees_url":"https://api.github.com/repos/domchristie/react-native-router-flux/assignees{/user}","branches_url":"https://api.github.com/repos/domchristie/react-native-router-flux/branches{/branch}","tags_url":"https://api.github.com/repos/domchristie/react-native-router-flux/tags","blobs_url":"https://api.github.com/repos/domchristie/react-native-router-flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domchristie/react-native-router-flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domchristie/react-native-router-flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/domchristie/react-native-router-flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domchristie/react-native-router-flux/statuses/{sha}","languages_url":"https://api.github.com/repos/domchristie/react-native-router-flux/languages","stargazers_url":"https://api.github.com/repos/domchristie/react-native-router-flux/stargazers","contributors_url":"https://api.github.com/repos/domchristie/react-native-router-flux/contributors","subscribers_url":"https://api.github.com/repos/domchristie/react-native-router-flux/subscribers","subscription_url":"https://api.github.com/repos/domchristie/react-native-router-flux/subscription","commits_url":"https://api.github.com/repos/domchristie/react-native-router-flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/domchristie/react-native-router-flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/domchristie/react-native-router-flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/domchristie/react-native-router-flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/domchristie/react-native-router-flux/contents/{+path}","compare_url":"https://api.github.com/repos/domchristie/react-native-router-flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domchristie/react-native-router-flux/merges","archive_url":"https://api.github.com/repos/domchristie/react-native-router-flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domchristie/react-native-router-flux/downloads","issues_url":"https://api.github.com/repos/domchristie/react-native-router-flux/issues{/number}","pulls_url":"https://api.github.com/repos/domchristie/react-native-router-flux/pulls{/number}","milestones_url":"https://api.github.com/repos/domchristie/react-native-router-flux/milestones{/number}","notifications_url":"https://api.github.com/repos/domchristie/react-native-router-flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domchristie/react-native-router-flux/labels{/name}","releases_url":"https://api.github.com/repos/domchristie/react-native-router-flux/releases{/id}","deployments_url":"https://api.github.com/repos/domchristie/react-native-router-flux/deployments","created_at":"2016-04-04T16:46:33Z","updated_at":"2016-04-04T16:46:34Z","pushed_at":"2016-04-06T11:39:12Z","git_url":"git://github.com/domchristie/react-native-router-flux.git","ssh_url":"git@github.com:domchristie/react-native-router-flux.git","clone_url":"https://github.com/domchristie/react-native-router-flux.git","svn_url":"https://github.com/domchristie/react-native-router-flux","homepage":"","size":851,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aksonov:master","ref":"master","sha":"c42b48b1e04bec828b11a6417708320f150493dc","user":{"login":"aksonov","id":1321329,"avatar_url":"https://avatars.githubusercontent.com/u/1321329?v=3","gravatar_id":"","url":"https://api.github.com/users/aksonov","html_url":"https://github.com/aksonov","followers_url":"https://api.github.com/users/aksonov/followers","following_url":"https://api.github.com/users/aksonov/following{/other_user}","gists_url":"https://api.github.com/users/aksonov/gists{/gist_id}","starred_url":"https://api.github.com/users/aksonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksonov/subscriptions","organizations_url":"https://api.github.com/users/aksonov/orgs","repos_url":"https://api.github.com/users/aksonov/repos","events_url":"https://api.github.com/users/aksonov/events{/privacy}","received_events_url":"https://api.github.com/users/aksonov/received_events","type":"User","site_admin":false},"repo":{"id":41359055,"name":"react-native-router-flux","full_name":"aksonov/react-native-router-flux","owner":{"login":"aksonov","id":1321329,"avatar_url":"https://avatars.githubusercontent.com/u/1321329?v=3","gravatar_id":"","url":"https://api.github.com/users/aksonov","html_url":"https://github.com/aksonov","followers_url":"https://api.github.com/users/aksonov/followers","following_url":"https://api.github.com/users/aksonov/following{/other_user}","gists_url":"https://api.github.com/users/aksonov/gists{/gist_id}","starred_url":"https://api.github.com/users/aksonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksonov/subscriptions","organizations_url":"https://api.github.com/users/aksonov/orgs","repos_url":"https://api.github.com/users/aksonov/repos","events_url":"https://api.github.com/users/aksonov/events{/privacy}","received_events_url":"https://api.github.com/users/aksonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aksonov/react-native-router-flux","description":"React Native Router based on new React Native Navigation API","fork":false,"url":"https://api.github.com/repos/aksonov/react-native-router-flux","forks_url":"https://api.github.com/repos/aksonov/react-native-router-flux/forks","keys_url":"https://api.github.com/repos/aksonov/react-native-router-flux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aksonov/react-native-router-flux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aksonov/react-native-router-flux/teams","hooks_url":"https://api.github.com/repos/aksonov/react-native-router-flux/hooks","issue_events_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/events{/number}","events_url":"https://api.github.com/repos/aksonov/react-native-router-flux/events","assignees_url":"https://api.github.com/repos/aksonov/react-native-router-flux/assignees{/user}","branches_url":"https://api.github.com/repos/aksonov/react-native-router-flux/branches{/branch}","tags_url":"https://api.github.com/repos/aksonov/react-native-router-flux/tags","blobs_url":"https://api.github.com/repos/aksonov/react-native-router-flux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aksonov/react-native-router-flux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aksonov/react-native-router-flux/git/refs{/sha}","trees_url":"https://api.github.com/repos/aksonov/react-native-router-flux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aksonov/react-native-router-flux/statuses/{sha}","languages_url":"https://api.github.com/repos/aksonov/react-native-router-flux/languages","stargazers_url":"https://api.github.com/repos/aksonov/react-native-router-flux/stargazers","contributors_url":"https://api.github.com/repos/aksonov/react-native-router-flux/contributors","subscribers_url":"https://api.github.com/repos/aksonov/react-native-router-flux/subscribers","subscription_url":"https://api.github.com/repos/aksonov/react-native-router-flux/subscription","commits_url":"https://api.github.com/repos/aksonov/react-native-router-flux/commits{/sha}","git_commits_url":"https://api.github.com/repos/aksonov/react-native-router-flux/git/commits{/sha}","comments_url":"https://api.github.com/repos/aksonov/react-native-router-flux/comments{/number}","issue_comment_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/comments{/number}","contents_url":"https://api.github.com/repos/aksonov/react-native-router-flux/contents/{+path}","compare_url":"https://api.github.com/repos/aksonov/react-native-router-flux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aksonov/react-native-router-flux/merges","archive_url":"https://api.github.com/repos/aksonov/react-native-router-flux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aksonov/react-native-router-flux/downloads","issues_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues{/number}","pulls_url":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls{/number}","milestones_url":"https://api.github.com/repos/aksonov/react-native-router-flux/milestones{/number}","notifications_url":"https://api.github.com/repos/aksonov/react-native-router-flux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aksonov/react-native-router-flux/labels{/name}","releases_url":"https://api.github.com/repos/aksonov/react-native-router-flux/releases{/id}","deployments_url":"https://api.github.com/repos/aksonov/react-native-router-flux/deployments","created_at":"2015-08-25T11:12:44Z","updated_at":"2016-04-06T06:43:40Z","pushed_at":"2016-04-06T11:41:25Z","git_url":"git://github.com/aksonov/react-native-router-flux.git","ssh_url":"git@github.com:aksonov/react-native-router-flux.git","clone_url":"https://github.com/aksonov/react-native-router-flux.git","svn_url":"https://github.com/aksonov/react-native-router-flux","homepage":"","size":889,"stargazers_count":862,"watchers_count":862,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":20,"forks":171,"open_issues":20,"watchers":862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/470"},"html":{"href":"https://github.com/aksonov/react-native-router-flux/pull/470"},"issue":{"href":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/470"},"comments":{"href":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/470/comments"},"review_comments":{"href":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/470/comments"},"review_comment":{"href":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aksonov/react-native-router-flux/pulls/470/commits"},"statuses":{"href":"https://api.github.com/repos/aksonov/react-native-router-flux/statuses/94180c1332759f14332a7fd5da18c00f35e22351"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aksonov","id":1321329,"avatar_url":"https://avatars.githubusercontent.com/u/1321329?v=3","gravatar_id":"","url":"https://api.github.com/users/aksonov","html_url":"https://github.com/aksonov","followers_url":"https://api.github.com/users/aksonov/followers","following_url":"https://api.github.com/users/aksonov/following{/other_user}","gists_url":"https://api.github.com/users/aksonov/gists{/gist_id}","starred_url":"https://api.github.com/users/aksonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aksonov/subscriptions","organizations_url":"https://api.github.com/users/aksonov/orgs","repos_url":"https://api.github.com/users/aksonov/repos","events_url":"https://api.github.com/users/aksonov/events{/privacy}","received_events_url":"https://api.github.com/users/aksonov/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":10,"deletions":5,"changed_files":4}}