{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62275877","id":62275877,"diff_hunk":"@@ -24,6 +24,8 @@ type IngressExpansion interface{}\n \n type JobExpansion interface{}\n \n+type PodSecurityPolicyExpansion interface{}","path":"pkg/client/clientset_generated/internalclientset/typed/extensions/unversioned/generated_expansion.go","position":4,"original_position":4,"commit_id":"0353de88d8aad399dac1aa8e34e5e7b2b8731abb","original_commit_id":"6c420f8231d704105e3b9dd6293d5e1a0dd27539","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"I seemed to have to add these manually or it wouldn't generate correctly.  Either I'm doing it wrong (likely) or possibly running into something like https://github.com/kubernetes/kubernetes/issues/20549","created_at":"2016-05-06T00:25:35Z","updated_at":"2016-05-06T00:25:35Z","html_url":"https://github.com/kubernetes/kubernetes/pull/24600#discussion_r62275877","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62275877"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/24600#discussion_r62275877"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600","id":67368888,"html_url":"https://github.com/kubernetes/kubernetes/pull/24600","diff_url":"https://github.com/kubernetes/kubernetes/pull/24600.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/24600.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24600","number":24600,"state":"open","locked":false,"title":"PSP admission","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"Still working on removing the non-relevant parts of the tests but I wanted to get this open to start soliciting feedback.\r\n\r\n- [x] bring PSP up to date with any new features we've added to SCC for discussion\r\n- [x] create admission controller that is a pared down version of SCC (no ns based strategies, no user/groups/service account permissioning)\r\n- [x] fix tests\r\n\r\n@liggitt @pmorie - this is the simple implementation requested that assumes all PSPs should be checked for each requests.  It is a slimmed down version of our SCC admission controller\r\n\r\n@erictune @smarterclayton ","created_at":"2016-04-21T14:59:06Z","updated_at":"2016-05-06T00:25:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3657ab857401b00b3aa05e0a4aa6d0b15f041beb","assignee":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24600/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0353de88d8aad399dac1aa8e34e5e7b2b8731abb","head":{"label":"pweil-:psp","ref":"psp","sha":"0353de88d8aad399dac1aa8e34e5e7b2b8731abb","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"repo":{"id":24119325,"name":"kubernetes","full_name":"pweil-/kubernetes","owner":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pweil-/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/pweil-/kubernetes","forks_url":"https://api.github.com/repos/pweil-/kubernetes/forks","keys_url":"https://api.github.com/repos/pweil-/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pweil-/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pweil-/kubernetes/teams","hooks_url":"https://api.github.com/repos/pweil-/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pweil-/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pweil-/kubernetes/events","assignees_url":"https://api.github.com/repos/pweil-/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pweil-/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pweil-/kubernetes/tags","blobs_url":"https://api.github.com/repos/pweil-/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pweil-/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pweil-/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pweil-/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pweil-/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pweil-/kubernetes/languages","stargazers_url":"https://api.github.com/repos/pweil-/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pweil-/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pweil-/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pweil-/kubernetes/subscription","commits_url":"https://api.github.com/repos/pweil-/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pweil-/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pweil-/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pweil-/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pweil-/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pweil-/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pweil-/kubernetes/merges","archive_url":"https://api.github.com/repos/pweil-/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pweil-/kubernetes/downloads","issues_url":"https://api.github.com/repos/pweil-/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pweil-/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pweil-/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pweil-/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pweil-/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pweil-/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/pweil-/kubernetes/deployments","created_at":"2014-09-16T21:53:37Z","updated_at":"2016-02-05T20:21:53Z","pushed_at":"2016-05-06T00:22:43Z","git_url":"git://github.com/pweil-/kubernetes.git","ssh_url":"git@github.com:pweil-/kubernetes.git","clone_url":"https://github.com/pweil-/kubernetes.git","svn_url":"https://github.com/pweil-/kubernetes","homepage":null,"size":185038,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a3cbdcaa5b07c466b736c1427e7c3031cfd1e930","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-05T20:50:20Z","pushed_at":"2016-05-06T00:22:45Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":390857,"stargazers_count":14228,"watchers_count":14228,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4256,"mirror_url":null,"open_issues_count":3609,"forks":4256,"open_issues":3609,"watchers":14228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/24600"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24600"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24600/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24600/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0353de88d8aad399dac1aa8e34e5e7b2b8731abb"}}}}