{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/79984923","id":79984923,"diff_hunk":"@@ -902,6 +906,7 @@ bool EvalScript(vector<vector<unsigned char> >& stack, const CScript& script, un\n                         return set_error(serror, SCRIPT_ERR_INVALID_STACK_OPERATION);\n \n                     int nKeysCount = CScriptNum(stacktop(-i), fRequireMinimal).getint();\n+                    int ikey2 = nKeysCount + 2;","path":"src/script/interpreter.cpp","position":null,"original_position":15,"commit_id":"5d23cfecb147bd6fcc745c7f93adc1fb69b9b291","original_commit_id":"d071bfd39be6f530c6dbc3993f0f5a8badd6250b","user":{"login":"jl2012","id":8403418,"avatar_url":"https://avatars.githubusercontent.com/u/8403418?v=3","gravatar_id":"","url":"https://api.github.com/users/jl2012","html_url":"https://github.com/jl2012","followers_url":"https://api.github.com/users/jl2012/followers","following_url":"https://api.github.com/users/jl2012/following{/other_user}","gists_url":"https://api.github.com/users/jl2012/gists{/gist_id}","starred_url":"https://api.github.com/users/jl2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jl2012/subscriptions","organizations_url":"https://api.github.com/users/jl2012/orgs","repos_url":"https://api.github.com/users/jl2012/repos","events_url":"https://api.github.com/users/jl2012/events{/privacy}","received_events_url":"https://api.github.com/users/jl2012/received_events","type":"User","site_admin":false},"body":"Addressed with 5d23cfe","created_at":"2016-09-22T07:07:31Z","updated_at":"2016-09-22T07:07:31Z","html_url":"https://github.com/bitcoin/bitcoin/pull/8634#discussion_r79984923","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/79984923"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8634#discussion_r79984923"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634","id":83391143,"html_url":"https://github.com/bitcoin/bitcoin/pull/8634","diff_url":"https://github.com/bitcoin/bitcoin/pull/8634.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8634.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8634","number":8634,"state":"open","locked":false,"title":"Add policy: null signature for failed CHECK(MULTI)SIG","user":{"login":"jl2012","id":8403418,"avatar_url":"https://avatars.githubusercontent.com/u/8403418?v=3","gravatar_id":"","url":"https://api.github.com/users/jl2012","html_url":"https://github.com/jl2012","followers_url":"https://api.github.com/users/jl2012/followers","following_url":"https://api.github.com/users/jl2012/following{/other_user}","gists_url":"https://api.github.com/users/jl2012/gists{/gist_id}","starred_url":"https://api.github.com/users/jl2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jl2012/subscriptions","organizations_url":"https://api.github.com/users/jl2012/orgs","repos_url":"https://api.github.com/users/jl2012/repos","events_url":"https://api.github.com/users/jl2012/events{/privacy}","received_events_url":"https://api.github.com/users/jl2012/received_events","type":"User","site_admin":false},"body":"Intended for 0.13.1\r\n\r\nThis PR adds a new policy to require that signature(s) must be empty vector for failed CHECK(MULTI)SIG operations.\r\n\r\nThis fixes malleability for some forms of scripts, for example:\r\n\r\n\"key 1\" CHECKSIG IF \"key 2\" CHECKSIG ELSE \"key 3\" CHECKSIGVERIFY \"locktime\" CLTV ENDIF\r\n\r\nwhich is spendable with both sig 1 and sig 2 anytime, or sig 3 only after locktime\r\n\r\nWithout this new policy, a relay node may inject arbitrary BIP66-compliant data to the scriptSig/witness when the ELSE branch is executed.\r\n\r\nThis may become a softfork in the future. I will prepare for a BIP later","created_at":"2016-08-31T05:34:23Z","updated_at":"2016-09-22T07:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9922b5a09f7b447800ab2aac2b9c572890ac3e3b","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/22","html_url":"https://github.com/bitcoin/bitcoin/milestones/0.13.1","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/22/labels","id":1935226,"number":22,"title":"0.13.1","description":null,"creator":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":35,"state":"open","created_at":"2016-08-10T17:30:01Z","updated_at":"2016-09-20T14:22:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8634/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5d23cfecb147bd6fcc745c7f93adc1fb69b9b291","head":{"label":"jl2012:nullfail","ref":"nullfail","sha":"5d23cfecb147bd6fcc745c7f93adc1fb69b9b291","user":{"login":"jl2012","id":8403418,"avatar_url":"https://avatars.githubusercontent.com/u/8403418?v=3","gravatar_id":"","url":"https://api.github.com/users/jl2012","html_url":"https://github.com/jl2012","followers_url":"https://api.github.com/users/jl2012/followers","following_url":"https://api.github.com/users/jl2012/following{/other_user}","gists_url":"https://api.github.com/users/jl2012/gists{/gist_id}","starred_url":"https://api.github.com/users/jl2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jl2012/subscriptions","organizations_url":"https://api.github.com/users/jl2012/orgs","repos_url":"https://api.github.com/users/jl2012/repos","events_url":"https://api.github.com/users/jl2012/events{/privacy}","received_events_url":"https://api.github.com/users/jl2012/received_events","type":"User","site_admin":false},"repo":{"id":48881672,"name":"bitcoin","full_name":"jl2012/bitcoin","owner":{"login":"jl2012","id":8403418,"avatar_url":"https://avatars.githubusercontent.com/u/8403418?v=3","gravatar_id":"","url":"https://api.github.com/users/jl2012","html_url":"https://github.com/jl2012","followers_url":"https://api.github.com/users/jl2012/followers","following_url":"https://api.github.com/users/jl2012/following{/other_user}","gists_url":"https://api.github.com/users/jl2012/gists{/gist_id}","starred_url":"https://api.github.com/users/jl2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jl2012/subscriptions","organizations_url":"https://api.github.com/users/jl2012/orgs","repos_url":"https://api.github.com/users/jl2012/repos","events_url":"https://api.github.com/users/jl2012/events{/privacy}","received_events_url":"https://api.github.com/users/jl2012/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jl2012/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/jl2012/bitcoin","forks_url":"https://api.github.com/repos/jl2012/bitcoin/forks","keys_url":"https://api.github.com/repos/jl2012/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jl2012/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jl2012/bitcoin/teams","hooks_url":"https://api.github.com/repos/jl2012/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jl2012/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jl2012/bitcoin/events","assignees_url":"https://api.github.com/repos/jl2012/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jl2012/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jl2012/bitcoin/tags","blobs_url":"https://api.github.com/repos/jl2012/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jl2012/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jl2012/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jl2012/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jl2012/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jl2012/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jl2012/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jl2012/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jl2012/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jl2012/bitcoin/subscription","commits_url":"https://api.github.com/repos/jl2012/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jl2012/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jl2012/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jl2012/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jl2012/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jl2012/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jl2012/bitcoin/merges","archive_url":"https://api.github.com/repos/jl2012/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jl2012/bitcoin/downloads","issues_url":"https://api.github.com/repos/jl2012/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jl2012/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jl2012/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jl2012/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jl2012/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jl2012/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/jl2012/bitcoin/deployments","created_at":"2016-01-01T15:32:58Z","updated_at":"2016-09-12T20:13:05Z","pushed_at":"2016-09-22T07:06:55Z","git_url":"git://github.com/jl2012/bitcoin.git","ssh_url":"git@github.com:jl2012/bitcoin.git","clone_url":"https://github.com/jl2012/bitcoin.git","svn_url":"https://github.com/jl2012/bitcoin","homepage":"http://www.bitcoin.org","size":62202,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"segwit3"}},"base":{"label":"bitcoin:master","ref":"master","sha":"2b23dbaee5b88d7237144e14eff01391e2cc201d","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-09-21T21:15:58Z","pushed_at":"2016-09-22T07:06:55Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":152611,"stargazers_count":9958,"watchers_count":9958,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6623,"mirror_url":null,"open_issues_count":540,"forks":6623,"open_issues":540,"watchers":9958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8634"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8634"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8634/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8634/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5d23cfecb147bd6fcc745c7f93adc1fb69b9b291"}}}}
{"actor":{"display_login":"jl2012"}}