{"action":"created","issue":{"url":"https://api.github.com/repos/wildland/api_me/issues/33","repository_url":"https://api.github.com/repos/wildland/api_me","labels_url":"https://api.github.com/repos/wildland/api_me/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/wildland/api_me/issues/33/comments","events_url":"https://api.github.com/repos/wildland/api_me/issues/33/events","html_url":"https://github.com/wildland/api_me/pull/33","id":174966692,"number":33,"title":"Upgrade to AMS 0.10.x and make tests pass","user":{"login":"Samsinite","id":166847,"avatar_url":"https://avatars.githubusercontent.com/u/166847?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsinite","html_url":"https://github.com/Samsinite","followers_url":"https://api.github.com/users/Samsinite/followers","following_url":"https://api.github.com/users/Samsinite/following{/other_user}","gists_url":"https://api.github.com/users/Samsinite/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsinite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsinite/subscriptions","organizations_url":"https://api.github.com/users/Samsinite/orgs","repos_url":"https://api.github.com/users/Samsinite/repos","events_url":"https://api.github.com/users/Samsinite/events{/privacy}","received_events_url":"https://api.github.com/users/Samsinite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-04T19:59:42Z","updated_at":"2016-09-13T21:16:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wildland/api_me/pulls/33","html_url":"https://github.com/wildland/api_me/pull/33","diff_url":"https://github.com/wildland/api_me/pull/33.diff","patch_url":"https://github.com/wildland/api_me/pull/33.patch"},"body":"While running the tests, there are two obvious non-backwards compatible\r\nissues. First, the `ActiveModel::Serializer.embed` class method no longer\r\nexists. Instead, to embed has_many or has_one (non fk relations) ids, it is recommended to\r\nimplement these methods manually. I.E.:\r\n\r\n```rb\r\nattribte :comment_ids\r\n\r\ndef commend_ids\r\n  object.comments.map { |c| c.id }\r\nend\r\n```\r\n\r\nSecond, for serializing non active record objects, inheriting from\r\n`ActiveModel::Serializer` no longer works. It is recommended to\r\ninherit from `ActiveModelSerializers::Model` instead. See\r\nhttps://github.com/rails-api/active_model_serializers/blob/master/docs/general/rendering.md#serializing-non-activerecord-objects\r\nfor details. As non-backwards compatible issues become obvious,\r\ndeprecations will be implemented in the last released version of Api Me\r\n0.7.x as they are identified, wherever possible."},"comment":{"url":"https://api.github.com/repos/wildland/api_me/issues/comments/246827200","html_url":"https://github.com/wildland/api_me/pull/33#issuecomment-246827200","issue_url":"https://api.github.com/repos/wildland/api_me/issues/33","id":246827200,"user":{"login":"jweakley","id":347385,"avatar_url":"https://avatars.githubusercontent.com/u/347385?v=3","gravatar_id":"","url":"https://api.github.com/users/jweakley","html_url":"https://github.com/jweakley","followers_url":"https://api.github.com/users/jweakley/followers","following_url":"https://api.github.com/users/jweakley/following{/other_user}","gists_url":"https://api.github.com/users/jweakley/gists{/gist_id}","starred_url":"https://api.github.com/users/jweakley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jweakley/subscriptions","organizations_url":"https://api.github.com/users/jweakley/orgs","repos_url":"https://api.github.com/users/jweakley/repos","events_url":"https://api.github.com/users/jweakley/events{/privacy}","received_events_url":"https://api.github.com/users/jweakley/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T21:16:11Z","updated_at":"2016-09-13T21:16:11Z","body":"Nice. The `README` updates look good."}}
{"actor":{"display_login":"jweakley"}}