{"action":"created","comment":{"url":"https://api.github.com/repos/Moya/Moya/pulls/comments/83703652","pull_request_review_id":4530062,"id":83703652,"diff_hunk":"@@ -2,19 +2,20 @@\n \n # 8.0.0-beta.3\n \n-- **Breaking Change** Throw dedicated `Error.jsonMapping` when `mapJSON` fails to parse JSON\n-- Removed the unused `StreamRequest` typealias that was causing watchOS failures.\n-- **Breaking Change** Renamed `endpointByAddingHTTPHeaders` to `adding(newHttpHeaderFields:)`\n-- **Breaking Change** Renamed `endpointByAddingParameters` to `adding(newParameters:)`\n-- **Breaking Change** Renamed `endpointByAddingParameterEncoding` to `adding(newParameterEncoding:)`\n-- **Breaking Change** Renamed `endpointByAdding(parameters:httpHeaderFields:parameterEncoding)` to `adding(parameters:httpHeaderFields:parameterEncoding)`\n-- **Breaking Change** Changed HTTP verbs enum to lowercase\n+- **Breaking Change** Throw dedicated `Error.jsonMapping` when `mapJSON` fails to parse JSON.\n+- **Breaking Change** Renamed `endpointByAddingHTTPHeaders` to `adding(newHttpHeaderFields:)`.\n+- **Breaking Change** Renamed `endpointByAddingParameters` to `adding(newParameters:)`.\n+- **Breaking Change** Renamed `endpointByAddingParameterEncoding` to `adding(newParameterEncoding:)`.\n+- **Breaking Change** Renamed `endpointByAdding(parameters:httpHeaderFields:parameterEncoding)` to `adding(parameters:httpHeaderFields:parameterEncoding)`.\n+- **Breaking Change** Changed HTTP verbs enum to lowercase.\n - `urlRequest` property of `Endpoint` is now truly optional. The request will fail if the `urlRequest` turns out to be nil and a `requestMapping` error will be returned together with the problematic url.\n - **Breaking Change** Made RxMoya & ReactiveMoya frameworks dependant on Moya framework, making them slimmer and not re-including Moya source in the Reactive extensions. ([PR](https://github.com/Moya/Moya/pull/563))\n+- **Breaking Change** Made some `class func`s [mimicking enum cases](https://github.com/Moya/Moya/blob/master/Source/Moya.swift#L117-L133) lowercased.","path":"Changelog.md","position":19,"original_position":19,"commit_id":"80407210265c66f69dd7b3c8a5933367501f63ac","original_commit_id":"80407210265c66f69dd7b3c8a5933367501f63ac","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"body":"This will need to go above the `8.0.0-beta.3` section.","created_at":"2016-10-17T18:25:09Z","updated_at":"2016-10-17T18:25:19Z","html_url":"https://github.com/Moya/Moya/pull/721#discussion_r83703652","pull_request_url":"https://api.github.com/repos/Moya/Moya/pulls/721","_links":{"self":{"href":"https://api.github.com/repos/Moya/Moya/pulls/comments/83703652"},"html":{"href":"https://github.com/Moya/Moya/pull/721#discussion_r83703652"},"pull_request":{"href":"https://api.github.com/repos/Moya/Moya/pulls/721"}}},"pull_request":{"url":"https://api.github.com/repos/Moya/Moya/pulls/721","id":89537553,"html_url":"https://github.com/Moya/Moya/pull/721","diff_url":"https://github.com/Moya/Moya/pull/721.diff","patch_url":"https://github.com/Moya/Moya/pull/721.patch","issue_url":"https://api.github.com/repos/Moya/Moya/issues/721","number":721,"state":"open","locked":false,"title":"Lowercase class funcs","user":{"login":"BasThomas","id":4190298,"avatar_url":"https://avatars.githubusercontent.com/u/4190298?v=3","gravatar_id":"","url":"https://api.github.com/users/BasThomas","html_url":"https://github.com/BasThomas","followers_url":"https://api.github.com/users/BasThomas/followers","following_url":"https://api.github.com/users/BasThomas/following{/other_user}","gists_url":"https://api.github.com/users/BasThomas/gists{/gist_id}","starred_url":"https://api.github.com/users/BasThomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasThomas/subscriptions","organizations_url":"https://api.github.com/users/BasThomas/orgs","repos_url":"https://api.github.com/users/BasThomas/repos","events_url":"https://api.github.com/users/BasThomas/events{/privacy}","received_events_url":"https://api.github.com/users/BasThomas/received_events","type":"User","site_admin":false},"body":"As discussed [here](https://github.com/Moya/Moya/pull/719#discussion_r83555707), class funcs mimicking enum cases have now been lowercased.\n\nPlease check if I missed any?\n\nI also cleaned up the changelog a bit.","created_at":"2016-10-16T20:02:44Z","updated_at":"2016-10-17T18:25:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"948621060ade64617d28e17333d10a2068a763a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Moya/Moya/pulls/721/commits","review_comments_url":"https://api.github.com/repos/Moya/Moya/pulls/721/comments","review_comment_url":"https://api.github.com/repos/Moya/Moya/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Moya/Moya/issues/721/comments","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/80407210265c66f69dd7b3c8a5933367501f63ac","head":{"label":"Moya:lowercase-class-funcs","ref":"lowercase-class-funcs","sha":"80407210265c66f69dd7b3c8a5933367501f63ac","user":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"repo":{"id":23013268,"name":"Moya","full_name":"Moya/Moya","owner":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Moya/Moya","description":"Network abstraction layer written in Swift.","fork":false,"url":"https://api.github.com/repos/Moya/Moya","forks_url":"https://api.github.com/repos/Moya/Moya/forks","keys_url":"https://api.github.com/repos/Moya/Moya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Moya/Moya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Moya/Moya/teams","hooks_url":"https://api.github.com/repos/Moya/Moya/hooks","issue_events_url":"https://api.github.com/repos/Moya/Moya/issues/events{/number}","events_url":"https://api.github.com/repos/Moya/Moya/events","assignees_url":"https://api.github.com/repos/Moya/Moya/assignees{/user}","branches_url":"https://api.github.com/repos/Moya/Moya/branches{/branch}","tags_url":"https://api.github.com/repos/Moya/Moya/tags","blobs_url":"https://api.github.com/repos/Moya/Moya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Moya/Moya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Moya/Moya/git/refs{/sha}","trees_url":"https://api.github.com/repos/Moya/Moya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/{sha}","languages_url":"https://api.github.com/repos/Moya/Moya/languages","stargazers_url":"https://api.github.com/repos/Moya/Moya/stargazers","contributors_url":"https://api.github.com/repos/Moya/Moya/contributors","subscribers_url":"https://api.github.com/repos/Moya/Moya/subscribers","subscription_url":"https://api.github.com/repos/Moya/Moya/subscription","commits_url":"https://api.github.com/repos/Moya/Moya/commits{/sha}","git_commits_url":"https://api.github.com/repos/Moya/Moya/git/commits{/sha}","comments_url":"https://api.github.com/repos/Moya/Moya/comments{/number}","issue_comment_url":"https://api.github.com/repos/Moya/Moya/issues/comments{/number}","contents_url":"https://api.github.com/repos/Moya/Moya/contents/{+path}","compare_url":"https://api.github.com/repos/Moya/Moya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Moya/Moya/merges","archive_url":"https://api.github.com/repos/Moya/Moya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Moya/Moya/downloads","issues_url":"https://api.github.com/repos/Moya/Moya/issues{/number}","pulls_url":"https://api.github.com/repos/Moya/Moya/pulls{/number}","milestones_url":"https://api.github.com/repos/Moya/Moya/milestones{/number}","notifications_url":"https://api.github.com/repos/Moya/Moya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Moya/Moya/labels{/name}","releases_url":"https://api.github.com/repos/Moya/Moya/releases{/id}","deployments_url":"https://api.github.com/repos/Moya/Moya/deployments","created_at":"2014-08-16T07:41:21Z","updated_at":"2016-10-17T18:16:20Z","pushed_at":"2016-10-17T18:08:50Z","git_url":"git://github.com/Moya/Moya.git","ssh_url":"git@github.com:Moya/Moya.git","clone_url":"https://github.com/Moya/Moya.git","svn_url":"https://github.com/Moya/Moya","homepage":"","size":17793,"stargazers_count":3796,"watchers_count":3796,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":51,"forks":408,"open_issues":51,"watchers":3796,"default_branch":"master"}},"base":{"label":"Moya:master","ref":"master","sha":"3832192c4860d32fdbad2df5828d1590a4c7a2d7","user":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"repo":{"id":23013268,"name":"Moya","full_name":"Moya/Moya","owner":{"login":"Moya","id":13662162,"avatar_url":"https://avatars.githubusercontent.com/u/13662162?v=3","gravatar_id":"","url":"https://api.github.com/users/Moya","html_url":"https://github.com/Moya","followers_url":"https://api.github.com/users/Moya/followers","following_url":"https://api.github.com/users/Moya/following{/other_user}","gists_url":"https://api.github.com/users/Moya/gists{/gist_id}","starred_url":"https://api.github.com/users/Moya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moya/subscriptions","organizations_url":"https://api.github.com/users/Moya/orgs","repos_url":"https://api.github.com/users/Moya/repos","events_url":"https://api.github.com/users/Moya/events{/privacy}","received_events_url":"https://api.github.com/users/Moya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Moya/Moya","description":"Network abstraction layer written in Swift.","fork":false,"url":"https://api.github.com/repos/Moya/Moya","forks_url":"https://api.github.com/repos/Moya/Moya/forks","keys_url":"https://api.github.com/repos/Moya/Moya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Moya/Moya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Moya/Moya/teams","hooks_url":"https://api.github.com/repos/Moya/Moya/hooks","issue_events_url":"https://api.github.com/repos/Moya/Moya/issues/events{/number}","events_url":"https://api.github.com/repos/Moya/Moya/events","assignees_url":"https://api.github.com/repos/Moya/Moya/assignees{/user}","branches_url":"https://api.github.com/repos/Moya/Moya/branches{/branch}","tags_url":"https://api.github.com/repos/Moya/Moya/tags","blobs_url":"https://api.github.com/repos/Moya/Moya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Moya/Moya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Moya/Moya/git/refs{/sha}","trees_url":"https://api.github.com/repos/Moya/Moya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Moya/Moya/statuses/{sha}","languages_url":"https://api.github.com/repos/Moya/Moya/languages","stargazers_url":"https://api.github.com/repos/Moya/Moya/stargazers","contributors_url":"https://api.github.com/repos/Moya/Moya/contributors","subscribers_url":"https://api.github.com/repos/Moya/Moya/subscribers","subscription_url":"https://api.github.com/repos/Moya/Moya/subscription","commits_url":"https://api.github.com/repos/Moya/Moya/commits{/sha}","git_commits_url":"https://api.github.com/repos/Moya/Moya/git/commits{/sha}","comments_url":"https://api.github.com/repos/Moya/Moya/comments{/number}","issue_comment_url":"https://api.github.com/repos/Moya/Moya/issues/comments{/number}","contents_url":"https://api.github.com/repos/Moya/Moya/contents/{+path}","compare_url":"https://api.github.com/repos/Moya/Moya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Moya/Moya/merges","archive_url":"https://api.github.com/repos/Moya/Moya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Moya/Moya/downloads","issues_url":"https://api.github.com/repos/Moya/Moya/issues{/number}","pulls_url":"https://api.github.com/repos/Moya/Moya/pulls{/number}","milestones_url":"https://api.github.com/repos/Moya/Moya/milestones{/number}","notifications_url":"https://api.github.com/repos/Moya/Moya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Moya/Moya/labels{/name}","releases_url":"https://api.github.com/repos/Moya/Moya/releases{/id}","deployments_url":"https://api.github.com/repos/Moya/Moya/deployments","created_at":"2014-08-16T07:41:21Z","updated_at":"2016-10-17T18:16:20Z","pushed_at":"2016-10-17T18:08:50Z","git_url":"git://github.com/Moya/Moya.git","ssh_url":"git@github.com:Moya/Moya.git","clone_url":"https://github.com/Moya/Moya.git","svn_url":"https://github.com/Moya/Moya","homepage":"","size":17793,"stargazers_count":3796,"watchers_count":3796,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":51,"forks":408,"open_issues":51,"watchers":3796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Moya/Moya/pulls/721"},"html":{"href":"https://github.com/Moya/Moya/pull/721"},"issue":{"href":"https://api.github.com/repos/Moya/Moya/issues/721"},"comments":{"href":"https://api.github.com/repos/Moya/Moya/issues/721/comments"},"review_comments":{"href":"https://api.github.com/repos/Moya/Moya/pulls/721/comments"},"review_comment":{"href":"https://api.github.com/repos/Moya/Moya/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Moya/Moya/pulls/721/commits"},"statuses":{"href":"https://api.github.com/repos/Moya/Moya/statuses/80407210265c66f69dd7b3c8a5933367501f63ac"}}}}
{"actor":{"display_login":"ashfurrow"}}