{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/76846995","id":76846995,"diff_hunk":"@@ -242,7 +243,9 @@ def install\n     build_bottle_preinstall if build_bottle?\n \n     unless @poured_bottle\n-      compute_and_install_dependencies if @pour_failed && !ignore_deps?\n+      if (!pour_bottle || @pour_failed) && !ignore_deps?","path":"Library/Homebrew/formula_installer.rb","position":15,"original_position":15,"commit_id":"f97a242f445b03d0a4306a436666615d20be2c9b","original_commit_id":"f97a242f445b03d0a4306a436666615d20be2c9b","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"Could you pull `!pour_bottle || @pour_failed` into a separate variable (because binary logic hurts my brain)","created_at":"2016-08-30T18:00:44Z","updated_at":"2016-08-30T18:00:44Z","html_url":"https://github.com/Homebrew/brew/pull/835#discussion_r76846995","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/835","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/76846995"},"html":{"href":"https://github.com/Homebrew/brew/pull/835#discussion_r76846995"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/835"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/835","id":83213736,"html_url":"https://github.com/Homebrew/brew/pull/835","diff_url":"https://github.com/Homebrew/brew/pull/835.diff","patch_url":"https://github.com/Homebrew/brew/pull/835.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/835","number":835,"state":"open","locked":false,"title":"formula_installer: install deps of dep before dep","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?v=3","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"Dependencies/requirements of a dependency need to be installed/satisfied\nbefore the dependency. The fact that @pour_failed may be false is\nirrelevant to that imperative.\n\nSee https://github.com/Homebrew/homebrew-core/pull/4258 where python3\nwasn't being installed before sip despite the \"with-python3\" option\ncoming from qscintilla's `depends_on \"sip\" => \"with-python3\"`, causing\nthe sip build to fail as soon as it tried to invoke python3.","created_at":"2016-08-30T06:15:31Z","updated_at":"2016-08-30T18:00:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13afc7384ad69045d920c120f876433ed8ffe66d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/835/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/835/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/835/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/f97a242f445b03d0a4306a436666615d20be2c9b","head":{"label":"ilovezfs:install_deps_of_dep_before_dep","ref":"install_deps_of_dep_before_dep","sha":"f97a242f445b03d0a4306a436666615d20be2c9b","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?v=3","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"repo":{"id":55388553,"name":"brew","full_name":"ilovezfs/brew","owner":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?v=3","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilovezfs/brew","description":":beer: The missing package manager for OS X","fork":true,"url":"https://api.github.com/repos/ilovezfs/brew","forks_url":"https://api.github.com/repos/ilovezfs/brew/forks","keys_url":"https://api.github.com/repos/ilovezfs/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilovezfs/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilovezfs/brew/teams","hooks_url":"https://api.github.com/repos/ilovezfs/brew/hooks","issue_events_url":"https://api.github.com/repos/ilovezfs/brew/issues/events{/number}","events_url":"https://api.github.com/repos/ilovezfs/brew/events","assignees_url":"https://api.github.com/repos/ilovezfs/brew/assignees{/user}","branches_url":"https://api.github.com/repos/ilovezfs/brew/branches{/branch}","tags_url":"https://api.github.com/repos/ilovezfs/brew/tags","blobs_url":"https://api.github.com/repos/ilovezfs/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilovezfs/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilovezfs/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilovezfs/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilovezfs/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/ilovezfs/brew/languages","stargazers_url":"https://api.github.com/repos/ilovezfs/brew/stargazers","contributors_url":"https://api.github.com/repos/ilovezfs/brew/contributors","subscribers_url":"https://api.github.com/repos/ilovezfs/brew/subscribers","subscription_url":"https://api.github.com/repos/ilovezfs/brew/subscription","commits_url":"https://api.github.com/repos/ilovezfs/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilovezfs/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilovezfs/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilovezfs/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilovezfs/brew/contents/{+path}","compare_url":"https://api.github.com/repos/ilovezfs/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilovezfs/brew/merges","archive_url":"https://api.github.com/repos/ilovezfs/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilovezfs/brew/downloads","issues_url":"https://api.github.com/repos/ilovezfs/brew/issues{/number}","pulls_url":"https://api.github.com/repos/ilovezfs/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/ilovezfs/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/ilovezfs/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilovezfs/brew/labels{/name}","releases_url":"https://api.github.com/repos/ilovezfs/brew/releases{/id}","deployments_url":"https://api.github.com/repos/ilovezfs/brew/deployments","created_at":"2016-04-04T06:01:34Z","updated_at":"2016-04-04T06:01:35Z","pushed_at":"2016-08-30T07:08:54Z","git_url":"git://github.com/ilovezfs/brew.git","ssh_url":"git@github.com:ilovezfs/brew.git","clone_url":"https://github.com/ilovezfs/brew.git","svn_url":"https://github.com/ilovezfs/brew","homepage":"http://brew.sh","size":16111,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"8e29cf1b1d39f5d86aaeb702597aa34d97cd763a","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":":beer: The missing package manager for OS X","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2016-08-30T15:38:22Z","pushed_at":"2016-08-30T17:49:28Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"http://brew.sh","size":16761,"stargazers_count":2874,"watchers_count":2874,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":836,"mirror_url":null,"open_issues_count":51,"forks":836,"open_issues":51,"watchers":2874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/835"},"html":{"href":"https://github.com/Homebrew/brew/pull/835"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/835"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/835/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/835/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/835/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/f97a242f445b03d0a4306a436666615d20be2c9b"}}}}
{"actor":{"display_login":"MikeMcQuaid"}}