{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/86627054","pull_request_review_id":7279519,"id":86627054,"diff_hunk":"@@ -333,29 +334,42 @@ def node():\n \n \n def find_version():\n-    \"\"\"Determine and return the version of the build.\"\"\"\n-    version_file = 'version'","path":"jenkins/bootstrap.py","position":21,"original_position":21,"commit_id":"75a0959d8c7ea690b727e9a7f100622f8f01d87a","original_commit_id":"75a0959d8c7ea690b727e9a7f100622f8f01d87a","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"it's written when the tarball is created - https://github.com/kubernetes/kubernetes/blob/master/build-tools/lib/release.sh#L428.\r\n\r\nit should be the same as the `GitVersion` in `kubectl version` - but since we're parsing that already, it didn't seem like reading another file was necessary anymore.","created_at":"2016-11-04T20:32:05Z","updated_at":"2016-11-04T20:32:05Z","html_url":"https://github.com/kubernetes/test-infra/pull/988#discussion_r86627054","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/988","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/86627054"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/988#discussion_r86627054"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/988"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/988","id":92264823,"html_url":"https://github.com/kubernetes/test-infra/pull/988","diff_url":"https://github.com/kubernetes/test-infra/pull/988.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/988.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/988","number":988,"state":"open","locked":false,"title":"Save git commit of builds in started.json in addition to version","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/kubernetes/test-infra/issues/987, at least for bootstrapped builds.\r\n\r\nMy python is a bit rusty, so hopefully I didn't screw anything up too badly.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/test-infra/988)\n<!-- Reviewable:end -->\n","created_at":"2016-11-04T00:20:05Z","updated_at":"2016-11-04T20:32:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15fb85386a9bbcad6e6f1e24207ff059acb40f07","assignee":{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false},{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/988/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/988/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/988/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/75a0959d8c7ea690b727e9a7f100622f8f01d87a","head":{"label":"ixdy:bootstrap-save-git-commit","ref":"bootstrap-save-git-commit","sha":"75a0959d8c7ea690b727e9a7f100622f8f01d87a","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"repo":{"id":57921763,"name":"kubernetes-test-infra","full_name":"ixdy/kubernetes-test-infra","owner":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ixdy/kubernetes-test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/ixdy/kubernetes-test-infra","forks_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/forks","keys_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/teams","hooks_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/hooks","issue_events_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/events","assignees_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/tags","blobs_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/languages","stargazers_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/stargazers","contributors_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/contributors","subscribers_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/subscribers","subscription_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/subscription","commits_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/merges","archive_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/downloads","issues_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/labels{/name}","releases_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/ixdy/kubernetes-test-infra/deployments","created_at":"2016-05-02T21:10:33Z","updated_at":"2016-05-02T21:11:38Z","pushed_at":"2016-11-04T00:21:57Z","git_url":"git://github.com/ixdy/kubernetes-test-infra.git","ssh_url":"git@github.com:ixdy/kubernetes-test-infra.git","clone_url":"https://github.com/ixdy/kubernetes-test-infra.git","svn_url":"https://github.com/ixdy/kubernetes-test-infra","homepage":null,"size":5677,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6d857727a301afd5a284764468158a09fc0e489b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2016-11-03T05:29:07Z","pushed_at":"2016-11-04T19:20:24Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":6164,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":64,"forks":66,"open_issues":64,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/988"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/988"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/988"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/988/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/988/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/988/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/75a0959d8c7ea690b727e9a7f100622f8f01d87a"}}}}
{"actor":{"display_login":"ixdy"}}