{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/etcd-operator/issues/344","repository_url":"https://api.github.com/repos/coreos/etcd-operator","labels_url":"https://api.github.com/repos/coreos/etcd-operator/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/coreos/etcd-operator/issues/344/comments","events_url":"https://api.github.com/repos/coreos/etcd-operator/issues/344/events","html_url":"https://github.com/coreos/etcd-operator/pull/344","id":187502964,"number":344,"title":"controller: fix crash on failure to create backup","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-11-05T15:21:51Z","updated_at":"2016-11-06T16:52:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd-operator/pulls/344","html_url":"https://github.com/coreos/etcd-operator/pull/344","diff_url":"https://github.com/coreos/etcd-operator/pull/344.diff","patch_url":"https://github.com/coreos/etcd-operator/pull/344.patch"},"body":"ref: #342\r\n\r\nFor this issue, ideally we should have some way to reject user spec that doesn't match our expectation. However, there is no admission control for TPR objects yet.\r\n\r\nNonetheless, such error shouldn't crash controller. As a fix for this, we will fail the cluster only, i.e. make the cluster die itself."},"comment":{"url":"https://api.github.com/repos/coreos/etcd-operator/issues/comments/258693574","html_url":"https://github.com/coreos/etcd-operator/pull/344#issuecomment-258693574","issue_url":"https://api.github.com/repos/coreos/etcd-operator/issues/344","id":258693574,"user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T16:52:10Z","updated_at":"2016-11-06T16:52:10Z","body":"@xiang90 \r\nI'm writing a e2e test. Let me do it in another PR.\r\n\r\nFor aws, I will do it later next week."}}
{"actor":{"display_login":"hongchaodeng"}}