{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/53551622","id":53551622,"diff_hunk":"@@ -0,0 +1,103 @@\n+﻿using System;\n+using System.IO;\n+using System.Text;\n+using System.Text.Encodings.Web;\n+using System.Threading.Tasks;\n+using Microsoft.AspNetCore.Html;\n+using Microsoft.Extensions.Caching.Distributed;\n+using Microsoft.Extensions.Caching.Memory;\n+\n+namespace Microsoft.AspNetCore.Mvc.TagHelpers.Cache\n+{\n+    public class MemoryHtmlFragmentCache : IHtmlFragmentCache\n+    {\n+        private const string PriorityOptionName = \"priority\";\n+\n+        private readonly IMemoryCache _memoryCache;\n+\n+        public MemoryHtmlFragmentCache(IMemoryCache memoryCache)\n+        {\n+            _memoryCache = memoryCache;\n+        }\n+\n+        public async Task<IHtmlContent> SetAsync(object key, Func<Task<IHtmlContent>> renderContent, HtmlFragmentCacheContext context)\n+        {\n+            var options = new MemoryCacheEntryOptions();\n+\n+            if (context.ExpiresOn != null)\n+            {\n+                options.SetAbsoluteExpiration(context.ExpiresOn.Value);\n+            }\n+\n+            if (context.ExpiresAfter != null)\n+            {\n+                options.SetAbsoluteExpiration(context.ExpiresAfter.Value);\n+            }\n+\n+            if (context.ExpiresSliding != null)\n+            {\n+                options.SetSlidingExpiration(context.ExpiresSliding.Value);\n+            }\n+\n+            if (context.HasOptions && context.Options.ContainsKey(PriorityOptionName))\n+            {\n+                CacheItemPriority priority;\n+                if (Enum.TryParse(context.Options[PriorityOptionName], out priority))\n+                {\n+                    options.SetPriority(priority);\n+                }\n+            }\n+\n+            // Create an entry link scope and flow it so that any tokens related to the cache entries\n+            // created within this scope get copied to this scope.\n+            using (var link = _memoryCache.CreateLinkingScope())\n+            {\n+                var content = await renderContent();\n+\n+                options.AddEntryLink(link);\n+\n+                var stringBuilder = new StringBuilder();\n+                using (var writer = new StringWriter(stringBuilder))\n+                {\n+                    content.WriteTo(writer, context.HtmlEncoder);\n+                }\n+\n+                var result = new StringBuilderHtmlContent(stringBuilder);\n+\n+                _memoryCache.Set(key, result, options);","path":"src/Microsoft.AspNetCore.Mvc.TagHelpers/Cache/MemoryHtmlFragmentCache.cs","position":67,"original_position":67,"commit_id":"190a473a3bc8ca0af0d9a30bed0b23355c4d5c56","original_commit_id":"190a473a3bc8ca0af0d9a30bed0b23355c4d5c56","user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"body":"Curious to see how the get and set would be with a distribute cache implementation...could we have a test(not sure if a sample is better) related to it..","created_at":"2016-02-20T15:04:26Z","updated_at":"2016-02-20T15:04:26Z","html_url":"https://github.com/aspnet/Mvc/pull/4120#discussion_r53551622","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4120","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/53551622"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4120#discussion_r53551622"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4120"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/4120","id":60028142,"html_url":"https://github.com/aspnet/Mvc/pull/4120","diff_url":"https://github.com/aspnet/Mvc/pull/4120.diff","patch_url":"https://github.com/aspnet/Mvc/pull/4120.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/4120","number":4120,"state":"open","locked":false,"title":"[Fixes #3867] Abstracting Cache tag helper storage","user":{"login":"sebastienros","id":1165805,"avatar_url":"https://avatars.githubusercontent.com/u/1165805?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienros","html_url":"https://github.com/sebastienros","followers_url":"https://api.github.com/users/sebastienros/followers","following_url":"https://api.github.com/users/sebastienros/following{/other_user}","gists_url":"https://api.github.com/users/sebastienros/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienros/subscriptions","organizations_url":"https://api.github.com/users/sebastienros/orgs","repos_url":"https://api.github.com/users/sebastienros/repos","events_url":"https://api.github.com/users/sebastienros/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienros/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-20T00:34:34Z","updated_at":"2016-02-20T15:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f08c39074fee85cab077c2a5f509adac0b389a1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4120/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4120/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/4120/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/190a473a3bc8ca0af0d9a30bed0b23355c4d5c56","head":{"label":"aspnet:sebros/cachetaghelper","ref":"sebros/cachetaghelper","sha":"190a473a3bc8ca0af0d9a30bed0b23355c4d5c56","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-02-19T12:38:34Z","pushed_at":"2016-02-20T01:19:33Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":28798,"stargazers_count":2753,"watchers_count":2753,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1090,"mirror_url":null,"open_issues_count":268,"forks":1090,"open_issues":268,"watchers":2753,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"b39f4dfe298bf255a0c5fef3b7d749d0cffd861b","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-02-19T12:38:34Z","pushed_at":"2016-02-20T01:19:33Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":28798,"stargazers_count":2753,"watchers_count":2753,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1090,"mirror_url":null,"open_issues_count":268,"forks":1090,"open_issues":268,"watchers":2753,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4120"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4120"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4120"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4120/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4120/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4120/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/190a473a3bc8ca0af0d9a30bed0b23355c4d5c56"}}}}