{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/69","id":76524010,"html_url":"https://github.com/willowtreeapps/battlebots/pull/69","diff_url":"https://github.com/willowtreeapps/battlebots/pull/69.diff","patch_url":"https://github.com/willowtreeapps/battlebots/pull/69.patch","issue_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues/69","number":69,"state":"closed","locked":false,"title":"Add updated shot reducer logic","user":{"login":"oconn","id":4649439,"avatar_url":"https://avatars.githubusercontent.com/u/4649439?v=3","gravatar_id":"","url":"https://api.github.com/users/oconn","html_url":"https://github.com/oconn","followers_url":"https://api.github.com/users/oconn/followers","following_url":"https://api.github.com/users/oconn/following{/other_user}","gists_url":"https://api.github.com/users/oconn/gists{/gist_id}","starred_url":"https://api.github.com/users/oconn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconn/subscriptions","organizations_url":"https://api.github.com/users/oconn/orgs","repos_url":"https://api.github.com/users/oconn/repos","events_url":"https://api.github.com/users/oconn/events{/privacy}","received_events_url":"https://api.github.com/users/oconn/received_events","type":"User","site_admin":false},"body":"@JanxSpirit \r\n\r\nWhen wiring up the new reducer logic we discussed over L&L, I went to write a few tests and realized that the scope of `resolve-shoot` was pretty large and making testing it a bit difficult. I broke it out a bit for testing purposes, let me know what you think. I did not make any updates to the metadata changes we discussed, but I did leave a few TODO comments in there for refactor. \r\n\r\nOther updated include\r\n\r\n- Damage applied to any element that has energy, but only the max amount of energy that said element has.\r\n- Included minimal tests\r\n- Added `steel` element to arena key (mainly for testing shot occupy logic, but I think it would also be cool to have indestructible walls.\r\n\r\nTODOs: \r\n\r\n- Replace destroyed elements with open space (right now energy will decrease to 0, but the element will not be removed)\r\n- Write metadata update\r\n- More tests when updates applied","created_at":"2016-07-07T00:40:58Z","updated_at":"2016-07-07T12:21:11Z","closed_at":"2016-07-07T12:21:11Z","merged_at":"2016-07-07T12:21:11Z","merge_commit_sha":"7054d568b195c3f2be9ef948152dd02ae0a1076c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/69/commits","review_comments_url":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/69/comments","review_comment_url":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues/69/comments","statuses_url":"https://api.github.com/repos/willowtreeapps/battlebots/statuses/65e1c7d89203e2b02e5cec899158bcffe67067f0","head":{"label":"willowtreeapps:freature/shot-refactor","ref":"freature/shot-refactor","sha":"65e1c7d89203e2b02e5cec899158bcffe67067f0","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":57178012,"name":"battlebots","full_name":"willowtreeapps/battlebots","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/battlebots","description":"","fork":false,"url":"https://api.github.com/repos/willowtreeapps/battlebots","forks_url":"https://api.github.com/repos/willowtreeapps/battlebots/forks","keys_url":"https://api.github.com/repos/willowtreeapps/battlebots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/battlebots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/battlebots/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/battlebots/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/battlebots/events","assignees_url":"https://api.github.com/repos/willowtreeapps/battlebots/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/battlebots/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/battlebots/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/battlebots/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/battlebots/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/battlebots/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/battlebots/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/battlebots/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/battlebots/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/battlebots/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/battlebots/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/battlebots/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/battlebots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/battlebots/merges","archive_url":"https://api.github.com/repos/willowtreeapps/battlebots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/battlebots/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/battlebots/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/battlebots/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/battlebots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/battlebots/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/battlebots/releases{/id}","deployments_url":"https://api.github.com/repos/willowtreeapps/battlebots/deployments","created_at":"2016-04-27T02:43:17Z","updated_at":"2016-06-30T08:21:54Z","pushed_at":"2016-07-07T12:21:11Z","git_url":"git://github.com/willowtreeapps/battlebots.git","ssh_url":"git@github.com:willowtreeapps/battlebots.git","clone_url":"https://github.com/willowtreeapps/battlebots.git","svn_url":"https://github.com/willowtreeapps/battlebots","homepage":null,"size":259,"stargazers_count":4,"watchers_count":4,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":4,"default_branch":"develop"}},"base":{"label":"willowtreeapps:develop","ref":"develop","sha":"fe81f88d6ea439d115a566a8f6d367bd95625bcf","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":57178012,"name":"battlebots","full_name":"willowtreeapps/battlebots","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/battlebots","description":"","fork":false,"url":"https://api.github.com/repos/willowtreeapps/battlebots","forks_url":"https://api.github.com/repos/willowtreeapps/battlebots/forks","keys_url":"https://api.github.com/repos/willowtreeapps/battlebots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/battlebots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/battlebots/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/battlebots/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/battlebots/events","assignees_url":"https://api.github.com/repos/willowtreeapps/battlebots/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/battlebots/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/battlebots/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/battlebots/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/battlebots/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/battlebots/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/battlebots/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/battlebots/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/battlebots/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/battlebots/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/battlebots/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/battlebots/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/battlebots/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/battlebots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/battlebots/merges","archive_url":"https://api.github.com/repos/willowtreeapps/battlebots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/battlebots/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/battlebots/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/battlebots/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/battlebots/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/battlebots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/battlebots/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/battlebots/releases{/id}","deployments_url":"https://api.github.com/repos/willowtreeapps/battlebots/deployments","created_at":"2016-04-27T02:43:17Z","updated_at":"2016-06-30T08:21:54Z","pushed_at":"2016-07-07T12:21:11Z","git_url":"git://github.com/willowtreeapps/battlebots.git","ssh_url":"git@github.com:willowtreeapps/battlebots.git","clone_url":"https://github.com/willowtreeapps/battlebots.git","svn_url":"https://github.com/willowtreeapps/battlebots","homepage":null,"size":259,"stargazers_count":4,"watchers_count":4,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/69"},"html":{"href":"https://github.com/willowtreeapps/battlebots/pull/69"},"issue":{"href":"https://api.github.com/repos/willowtreeapps/battlebots/issues/69"},"comments":{"href":"https://api.github.com/repos/willowtreeapps/battlebots/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/willowtreeapps/battlebots/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/willowtreeapps/battlebots/statuses/65e1c7d89203e2b02e5cec899158bcffe67067f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oconn","id":4649439,"avatar_url":"https://avatars.githubusercontent.com/u/4649439?v=3","gravatar_id":"","url":"https://api.github.com/users/oconn","html_url":"https://github.com/oconn","followers_url":"https://api.github.com/users/oconn/followers","following_url":"https://api.github.com/users/oconn/following{/other_user}","gists_url":"https://api.github.com/users/oconn/gists{/gist_id}","starred_url":"https://api.github.com/users/oconn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oconn/subscriptions","organizations_url":"https://api.github.com/users/oconn/orgs","repos_url":"https://api.github.com/users/oconn/repos","events_url":"https://api.github.com/users/oconn/events{/privacy}","received_events_url":"https://api.github.com/users/oconn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":69,"deletions":32,"changed_files":4}}
{"actor":{"display_login":"oconn"}}