{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/falcor-router/pulls/comments/90732432","pull_request_review_id":11253372,"id":90732432,"diff_hunk":"@@ -238,7 +236,7 @@ describe('Collapse and Batch', function() {\n             get([['lists', [0, 1], 'summary']]);\n         var count = 0;\n         obs.\n-            doAction(function(res) {\n+            subscribe(function(res) {","path":"test/unit/functional/collapse-and-batch.spec.js","position":79,"original_position":79,"commit_id":"ed1680828549cf0613b8f73bca31b64caad21610","original_commit_id":"ed1680828549cf0613b8f73bca31b64caad21610","user":{"login":"trxcllnt","id":178183,"avatar_url":"https://avatars.githubusercontent.com/u/178183?v=3","gravatar_id":"","url":"https://api.github.com/users/trxcllnt","html_url":"https://github.com/trxcllnt","followers_url":"https://api.github.com/users/trxcllnt/followers","following_url":"https://api.github.com/users/trxcllnt/following{/other_user}","gists_url":"https://api.github.com/users/trxcllnt/gists{/gist_id}","starred_url":"https://api.github.com/users/trxcllnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trxcllnt/subscriptions","organizations_url":"https://api.github.com/users/trxcllnt/orgs","repos_url":"https://api.github.com/users/trxcllnt/repos","events_url":"https://api.github.com/users/trxcllnt/events{/privacy}","received_events_url":"https://api.github.com/users/trxcllnt/received_events","type":"User","site_admin":false},"body":"the pattern of `doAction(() => expect(...)).subscribe(noop, done, done)` ensures errors thrown by `expect()` get forwarded to the `done` handler. If expectations happen in the subscribe handlers, the `done` handler never gets invoked.","created_at":"2016-12-02T22:36:09Z","updated_at":"2016-12-02T22:36:09Z","html_url":"https://github.com/Netflix/falcor-router/pull/193#discussion_r90732432","pull_request_url":"https://api.github.com/repos/Netflix/falcor-router/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/Netflix/falcor-router/pulls/comments/90732432"},"html":{"href":"https://github.com/Netflix/falcor-router/pull/193#discussion_r90732432"},"pull_request":{"href":"https://api.github.com/repos/Netflix/falcor-router/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/falcor-router/pulls/193","id":92471105,"html_url":"https://github.com/Netflix/falcor-router/pull/193","diff_url":"https://github.com/Netflix/falcor-router/pull/193.diff","patch_url":"https://github.com/Netflix/falcor-router/pull/193.patch","issue_url":"https://api.github.com/repos/Netflix/falcor-router/issues/193","number":193,"state":"open","locked":false,"title":"Update RxJS to v5.0.0","user":{"login":"blesh","id":1540597,"avatar_url":"https://avatars.githubusercontent.com/u/1540597?v=3","gravatar_id":"","url":"https://api.github.com/users/blesh","html_url":"https://github.com/blesh","followers_url":"https://api.github.com/users/blesh/followers","following_url":"https://api.github.com/users/blesh/following{/other_user}","gists_url":"https://api.github.com/users/blesh/gists{/gist_id}","starred_url":"https://api.github.com/users/blesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blesh/subscriptions","organizations_url":"https://api.github.com/users/blesh/orgs","repos_url":"https://api.github.com/users/blesh/repos","events_url":"https://api.github.com/users/blesh/events{/privacy}","received_events_url":"https://api.github.com/users/blesh/received_events","type":"User","site_admin":false},"body":"### EDIT: updated 12/02/17\r\n\r\nThis just updates this library to use RxJS 5. Primary motivation for this being debugging and performance.\r\n\r\nNOTE: The implementation of `Symbol.observable` used in Falcor is incorrect and causes the `ModelResponse` to not be consumable with Rx5's `Observable.from()`. In order to work around this for the integration tests, I've added a script to reach into falcor and duck-punch ModelResponse. There's a pull request for that that needs to be merged that will solve that problem. (https://github.com/Netflix/falcor/pull/818)\r\n\r\nNOTE: The use of Rx's `expand` had to have the `Rx.Scheduler.queue` scheduler passed to it explicitly, to insure the trampolining behavior that falcor-router was relying on. This was the default with Rx 4 and under. Overall, this is probably a good thing, as falcor router could theoretically be asked to crawl sufficiently large enough graphs to cause a stack overflow in some cases.\r\n\r\nThis just updates this library to use RxJS 5. Primary motivation for this being debugging and performance.","created_at":"2016-11-05T23:28:09Z","updated_at":"2016-12-02T22:36:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21619827208be93aac472161b167f400ee415da3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/falcor-router/pulls/193/commits","review_comments_url":"https://api.github.com/repos/Netflix/falcor-router/pulls/193/comments","review_comment_url":"https://api.github.com/repos/Netflix/falcor-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/falcor-router/issues/193/comments","statuses_url":"https://api.github.com/repos/Netflix/falcor-router/statuses/ed1680828549cf0613b8f73bca31b64caad21610","head":{"label":"blesh:rx5-update","ref":"rx5-update","sha":"ed1680828549cf0613b8f73bca31b64caad21610","user":{"login":"blesh","id":1540597,"avatar_url":"https://avatars.githubusercontent.com/u/1540597?v=3","gravatar_id":"","url":"https://api.github.com/users/blesh","html_url":"https://github.com/blesh","followers_url":"https://api.github.com/users/blesh/followers","following_url":"https://api.github.com/users/blesh/following{/other_user}","gists_url":"https://api.github.com/users/blesh/gists{/gist_id}","starred_url":"https://api.github.com/users/blesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blesh/subscriptions","organizations_url":"https://api.github.com/users/blesh/orgs","repos_url":"https://api.github.com/users/blesh/repos","events_url":"https://api.github.com/users/blesh/events{/privacy}","received_events_url":"https://api.github.com/users/blesh/received_events","type":"User","site_admin":false},"repo":{"id":72942904,"name":"falcor-router","full_name":"blesh/falcor-router","owner":{"login":"blesh","id":1540597,"avatar_url":"https://avatars.githubusercontent.com/u/1540597?v=3","gravatar_id":"","url":"https://api.github.com/users/blesh","html_url":"https://github.com/blesh","followers_url":"https://api.github.com/users/blesh/followers","following_url":"https://api.github.com/users/blesh/following{/other_user}","gists_url":"https://api.github.com/users/blesh/gists{/gist_id}","starred_url":"https://api.github.com/users/blesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blesh/subscriptions","organizations_url":"https://api.github.com/users/blesh/orgs","repos_url":"https://api.github.com/users/blesh/repos","events_url":"https://api.github.com/users/blesh/events{/privacy}","received_events_url":"https://api.github.com/users/blesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blesh/falcor-router","description":"A Falcor JavaScript DataSource which creates a Virtual JSON Graph document on your app server.","fork":true,"url":"https://api.github.com/repos/blesh/falcor-router","forks_url":"https://api.github.com/repos/blesh/falcor-router/forks","keys_url":"https://api.github.com/repos/blesh/falcor-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blesh/falcor-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blesh/falcor-router/teams","hooks_url":"https://api.github.com/repos/blesh/falcor-router/hooks","issue_events_url":"https://api.github.com/repos/blesh/falcor-router/issues/events{/number}","events_url":"https://api.github.com/repos/blesh/falcor-router/events","assignees_url":"https://api.github.com/repos/blesh/falcor-router/assignees{/user}","branches_url":"https://api.github.com/repos/blesh/falcor-router/branches{/branch}","tags_url":"https://api.github.com/repos/blesh/falcor-router/tags","blobs_url":"https://api.github.com/repos/blesh/falcor-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blesh/falcor-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blesh/falcor-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/blesh/falcor-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blesh/falcor-router/statuses/{sha}","languages_url":"https://api.github.com/repos/blesh/falcor-router/languages","stargazers_url":"https://api.github.com/repos/blesh/falcor-router/stargazers","contributors_url":"https://api.github.com/repos/blesh/falcor-router/contributors","subscribers_url":"https://api.github.com/repos/blesh/falcor-router/subscribers","subscription_url":"https://api.github.com/repos/blesh/falcor-router/subscription","commits_url":"https://api.github.com/repos/blesh/falcor-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/blesh/falcor-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/blesh/falcor-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/blesh/falcor-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/blesh/falcor-router/contents/{+path}","compare_url":"https://api.github.com/repos/blesh/falcor-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blesh/falcor-router/merges","archive_url":"https://api.github.com/repos/blesh/falcor-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blesh/falcor-router/downloads","issues_url":"https://api.github.com/repos/blesh/falcor-router/issues{/number}","pulls_url":"https://api.github.com/repos/blesh/falcor-router/pulls{/number}","milestones_url":"https://api.github.com/repos/blesh/falcor-router/milestones{/number}","notifications_url":"https://api.github.com/repos/blesh/falcor-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blesh/falcor-router/labels{/name}","releases_url":"https://api.github.com/repos/blesh/falcor-router/releases{/id}","deployments_url":"https://api.github.com/repos/blesh/falcor-router/deployments","created_at":"2016-11-05T17:40:51Z","updated_at":"2016-11-05T17:40:53Z","pushed_at":"2016-12-02T21:51:34Z","git_url":"git://github.com/blesh/falcor-router.git","ssh_url":"git@github.com:blesh/falcor-router.git","clone_url":"https://github.com/blesh/falcor-router.git","svn_url":"https://github.com/blesh/falcor-router","homepage":"http://netflix.github.io/falcor","size":532,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"d5360f1a7ec9c26ec699d94e2cbe2d079d6ada9f","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":30732623,"name":"falcor-router","full_name":"Netflix/falcor-router","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/falcor-router","description":"A Falcor JavaScript DataSource which creates a Virtual JSON Graph document on your app server.","fork":false,"url":"https://api.github.com/repos/Netflix/falcor-router","forks_url":"https://api.github.com/repos/Netflix/falcor-router/forks","keys_url":"https://api.github.com/repos/Netflix/falcor-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/falcor-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/falcor-router/teams","hooks_url":"https://api.github.com/repos/Netflix/falcor-router/hooks","issue_events_url":"https://api.github.com/repos/Netflix/falcor-router/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/falcor-router/events","assignees_url":"https://api.github.com/repos/Netflix/falcor-router/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/falcor-router/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/falcor-router/tags","blobs_url":"https://api.github.com/repos/Netflix/falcor-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/falcor-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/falcor-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/falcor-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/falcor-router/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/falcor-router/languages","stargazers_url":"https://api.github.com/repos/Netflix/falcor-router/stargazers","contributors_url":"https://api.github.com/repos/Netflix/falcor-router/contributors","subscribers_url":"https://api.github.com/repos/Netflix/falcor-router/subscribers","subscription_url":"https://api.github.com/repos/Netflix/falcor-router/subscription","commits_url":"https://api.github.com/repos/Netflix/falcor-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/falcor-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/falcor-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/falcor-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/falcor-router/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/falcor-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/falcor-router/merges","archive_url":"https://api.github.com/repos/Netflix/falcor-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/falcor-router/downloads","issues_url":"https://api.github.com/repos/Netflix/falcor-router/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/falcor-router/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/falcor-router/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/falcor-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/falcor-router/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/falcor-router/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/falcor-router/deployments","created_at":"2015-02-13T00:26:12Z","updated_at":"2016-10-28T01:01:42Z","pushed_at":"2016-12-02T21:51:35Z","git_url":"git://github.com/Netflix/falcor-router.git","ssh_url":"git@github.com:Netflix/falcor-router.git","clone_url":"https://github.com/Netflix/falcor-router.git","svn_url":"https://github.com/Netflix/falcor-router","homepage":"http://netflix.github.io/falcor","size":580,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":36,"forks":28,"open_issues":36,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/falcor-router/pulls/193"},"html":{"href":"https://github.com/Netflix/falcor-router/pull/193"},"issue":{"href":"https://api.github.com/repos/Netflix/falcor-router/issues/193"},"comments":{"href":"https://api.github.com/repos/Netflix/falcor-router/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/falcor-router/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/falcor-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/falcor-router/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/falcor-router/statuses/ed1680828549cf0613b8f73bca31b64caad21610"}}}}
{"actor":{"display_login":"trxcllnt"}}