{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/92915872","pull_request_review_id":13441360,"id":92915872,"diff_hunk":"@@ -44,46 +40,49 @@ function checkWrap(req) {\n }\n \n TEST(function test_resolve6(done) {\n-  var req = dns.resolve6('ipv6.google.com', function(err, ips) {\n-    if (err) throw err;\n+  const req = dns.resolve6('ipv6.google.com',\n+    common.mustCall((err, ips) => {","path":"test/internet/test-dns-ipv6.js","position":37,"original_position":37,"commit_id":"2899656d79446d0776e82baa23955253c7c0fb2d","original_commit_id":"6c253352e4efa291c0607b1eec794b5b321d6c63","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"And, of course, you can always do something like this too:\r\n\r\n```js\r\nconst callback = common.mustCall((err, ipe) => {\r\n  assert.ifError(err);\r\n  ...\r\n});\r\n\r\nconst req = dns.resolve6('ipv6.google.com', callback);\r\n```","created_at":"2016-12-17T05:28:11Z","updated_at":"2016-12-17T05:28:11Z","html_url":"https://github.com/nodejs/node/pull/10219#discussion_r92915872","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/10219","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/92915872"},"html":{"href":"https://github.com/nodejs/node/pull/10219#discussion_r92915872"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/10219"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10219","id":97430802,"html_url":"https://github.com/nodejs/node/pull/10219","diff_url":"https://github.com/nodejs/node/pull/10219.diff","patch_url":"https://github.com/nodejs/node/pull/10219.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10219","number":10219,"state":"open","locked":false,"title":"test: refactor the code in test-dns-ipv6","user":{"login":"edsadr","id":1189785,"avatar_url":"https://avatars.githubusercontent.com/u/1189785?v=3","gravatar_id":"","url":"https://api.github.com/users/edsadr","html_url":"https://github.com/edsadr","followers_url":"https://api.github.com/users/edsadr/followers","following_url":"https://api.github.com/users/edsadr/following{/other_user}","gists_url":"https://api.github.com/users/edsadr/gists{/gist_id}","starred_url":"https://api.github.com/users/edsadr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsadr/subscriptions","organizations_url":"https://api.github.com/users/edsadr/orgs","repos_url":"https://api.github.com/users/edsadr/repos","events_url":"https://api.github.com/users/edsadr/events{/privacy}","received_events_url":"https://api.github.com/users/edsadr/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ntest\r\n\r\n##### Description of change\r\n\r\n* remove the manual control for functions execution\r\n* use common.mustCall to control the functions execution automatically\r\n* use let and const instead of var","created_at":"2016-12-10T16:53:25Z","updated_at":"2016-12-17T05:28:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fce7cf57d6d748d20521b94f66f13858ac921164","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10219/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10219/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10219/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/2899656d79446d0776e82baa23955253c7c0fb2d","head":{"label":"edsadr:test-dns-ipv6","ref":"test-dns-ipv6","sha":"2899656d79446d0776e82baa23955253c7c0fb2d","user":{"login":"edsadr","id":1189785,"avatar_url":"https://avatars.githubusercontent.com/u/1189785?v=3","gravatar_id":"","url":"https://api.github.com/users/edsadr","html_url":"https://github.com/edsadr","followers_url":"https://api.github.com/users/edsadr/followers","following_url":"https://api.github.com/users/edsadr/following{/other_user}","gists_url":"https://api.github.com/users/edsadr/gists{/gist_id}","starred_url":"https://api.github.com/users/edsadr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsadr/subscriptions","organizations_url":"https://api.github.com/users/edsadr/orgs","repos_url":"https://api.github.com/users/edsadr/repos","events_url":"https://api.github.com/users/edsadr/events{/privacy}","received_events_url":"https://api.github.com/users/edsadr/received_events","type":"User","site_admin":false},"repo":{"id":59757467,"name":"node","full_name":"edsadr/node","owner":{"login":"edsadr","id":1189785,"avatar_url":"https://avatars.githubusercontent.com/u/1189785?v=3","gravatar_id":"","url":"https://api.github.com/users/edsadr","html_url":"https://github.com/edsadr","followers_url":"https://api.github.com/users/edsadr/followers","following_url":"https://api.github.com/users/edsadr/following{/other_user}","gists_url":"https://api.github.com/users/edsadr/gists{/gist_id}","starred_url":"https://api.github.com/users/edsadr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsadr/subscriptions","organizations_url":"https://api.github.com/users/edsadr/orgs","repos_url":"https://api.github.com/users/edsadr/repos","events_url":"https://api.github.com/users/edsadr/events{/privacy}","received_events_url":"https://api.github.com/users/edsadr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edsadr/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/edsadr/node","forks_url":"https://api.github.com/repos/edsadr/node/forks","keys_url":"https://api.github.com/repos/edsadr/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edsadr/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edsadr/node/teams","hooks_url":"https://api.github.com/repos/edsadr/node/hooks","issue_events_url":"https://api.github.com/repos/edsadr/node/issues/events{/number}","events_url":"https://api.github.com/repos/edsadr/node/events","assignees_url":"https://api.github.com/repos/edsadr/node/assignees{/user}","branches_url":"https://api.github.com/repos/edsadr/node/branches{/branch}","tags_url":"https://api.github.com/repos/edsadr/node/tags","blobs_url":"https://api.github.com/repos/edsadr/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edsadr/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edsadr/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/edsadr/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edsadr/node/statuses/{sha}","languages_url":"https://api.github.com/repos/edsadr/node/languages","stargazers_url":"https://api.github.com/repos/edsadr/node/stargazers","contributors_url":"https://api.github.com/repos/edsadr/node/contributors","subscribers_url":"https://api.github.com/repos/edsadr/node/subscribers","subscription_url":"https://api.github.com/repos/edsadr/node/subscription","commits_url":"https://api.github.com/repos/edsadr/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/edsadr/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/edsadr/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/edsadr/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/edsadr/node/contents/{+path}","compare_url":"https://api.github.com/repos/edsadr/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edsadr/node/merges","archive_url":"https://api.github.com/repos/edsadr/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edsadr/node/downloads","issues_url":"https://api.github.com/repos/edsadr/node/issues{/number}","pulls_url":"https://api.github.com/repos/edsadr/node/pulls{/number}","milestones_url":"https://api.github.com/repos/edsadr/node/milestones{/number}","notifications_url":"https://api.github.com/repos/edsadr/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edsadr/node/labels{/name}","releases_url":"https://api.github.com/repos/edsadr/node/releases{/id}","deployments_url":"https://api.github.com/repos/edsadr/node/deployments","created_at":"2016-05-26T14:34:57Z","updated_at":"2016-05-26T14:35:13Z","pushed_at":"2016-12-17T03:10:57Z","git_url":"git://github.com/edsadr/node.git","ssh_url":"git@github.com:edsadr/node.git","clone_url":"https://github.com/edsadr/node.git","svn_url":"https://github.com/edsadr/node","homepage":"https://nodejs.org","size":242516,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"5a41a72b68276e50069c8b38e23317e151fcd7ee","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-17T04:43:21Z","pushed_at":"2016-12-17T05:20:34Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":249892,"stargazers_count":29899,"watchers_count":29899,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5348,"mirror_url":null,"open_issues_count":1020,"forks":5348,"open_issues":1020,"watchers":29899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10219"},"html":{"href":"https://github.com/nodejs/node/pull/10219"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10219"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10219/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10219/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10219/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/2899656d79446d0776e82baa23955253c7c0fb2d"}}}}
{"actor":{"display_login":"Trott"}}