{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/63588845","id":63588845,"diff_hunk":"@@ -13,89 +13,34 @@ namespace System.Reflection.Tests\n {\n     public class PropertyInfoGetSetMethodTests\n     {\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod1()\n-        {\n-            VerifyGetSetMethod(typeof(ReferenceTypeHelper), \"PropertyGetterSetter\", true, true);\n-        }\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod2()\n-        {\n-            VerifyGetSetMethod(typeof(ReferenceTypeHelper), \"PropertyGetter\", true, false);\n-        }\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod3()\n-        {\n-            VerifyGetSetMethod(typeof(ReferenceTypeHelper), \"PropertySetter\", false, true);\n-        }\n-\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod4()\n-        {\n-            VerifyGetSetMethod(typeof(ReferenceTypeHelper), \"Item\", true, true);\n-        }\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod5()\n-        {\n-            VerifyGetSetMethod(typeof(ValueTypeHelper), \"PropertyGetterSetter\", true, true);\n-        }\n \n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod6()\n+        [Theory]\n+        [InlineData(typeof(ReferenceTypeHelper), \"PropertyGetterSetter\", true, true)]\n+        [InlineData(typeof(ReferenceTypeHelper), \"PropertyGetter\", true, false)]\n+        [InlineData(typeof(ReferenceTypeHelper), \"PropertySetter\", false, true)]\n+        [InlineData(typeof(ReferenceTypeHelper), \"Item\", true, true)]\n+        [InlineData(typeof(ValueTypeHelper), \"PropertyGetterSetter\", true, true)]\n+        [InlineData(typeof(ValueTypeHelper), \"PropertyGetter\", true, false)]\n+        [InlineData(typeof(ValueTypeHelper), \"PropertySetter\", false, true)]\n+        [InlineData(typeof(ValueTypeHelper), \"Item\", true, false)]\n+        [InlineData(typeof(InterfaceHelper), \"PropertyGetterSetter\", true, true)]\n+        [InlineData(typeof(InterfaceHelper), \"PropertyGetter\", true, false)]\n+        [InlineData(typeof(InterfaceHelper), \"PropertySetter\", false, true)]\n+        [InlineData(typeof(InterfaceHelper), \"Item\", false, true)]\n+        public void GetSetMethod(Type type, string propertyName, bool getter, bool setter)\n         {\n-            VerifyGetSetMethod(typeof(ValueTypeHelper), \"PropertyGetter\", true, false);\n-        }\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod7()\n-        {\n-            VerifyGetSetMethod(typeof(ValueTypeHelper), \"PropertySetter\", false, true);\n-        }\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod8()\n-        {\n-            VerifyGetSetMethod(typeof(ValueTypeHelper), \"Item\", true, false);\n-        }\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod9()\n-        {\n-            VerifyGetSetMethod(typeof(InterfaceHelper), \"PropertyGetterSetter\", true, true);\n-        }\n-\n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod10()\n-        {\n-            VerifyGetSetMethod(typeof(InterfaceHelper), \"PropertyGetter\", true, false);\n-        }\n+            PropertyInfo pi = getProperty(type, propertyName);\n+            Assert.NotNull(pi);\n \n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod11()\n-        {\n-            VerifyGetSetMethod(typeof(InterfaceHelper), \"PropertySetter\", false, true);\n-        }\n+            if (getter)\n+            {\n+                Assert.NotNull(pi.GetMethod);\n+            }\n \n-        //Verify GetMethod , SetMethod properties for PropertyInfo\n-        [Fact]\n-        public static void TestGetSetMethod12()\n-        {\n-            VerifyGetSetMethod(typeof(InterfaceHelper), \"Item\", false, true);\n+            if (setter)\n+            {\n+                Assert.NotNull(pi.SetMethod);\n+            }","path":"src/System.Reflection/tests/PropertyInfo/PropertyInfo_GetSetMethodTests.cs","position":110,"original_position":110,"commit_id":"044d211da72950936fc831c091b717e6a6a473de","original_commit_id":"044d211da72950936fc831c091b717e6a6a473de","user":{"login":"ioanacrant","id":8014346,"avatar_url":"https://avatars.githubusercontent.com/u/8014346?v=3","gravatar_id":"","url":"https://api.github.com/users/ioanacrant","html_url":"https://github.com/ioanacrant","followers_url":"https://api.github.com/users/ioanacrant/followers","following_url":"https://api.github.com/users/ioanacrant/following{/other_user}","gists_url":"https://api.github.com/users/ioanacrant/gists{/gist_id}","starred_url":"https://api.github.com/users/ioanacrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioanacrant/subscriptions","organizations_url":"https://api.github.com/users/ioanacrant/orgs","repos_url":"https://api.github.com/users/ioanacrant/repos","events_url":"https://api.github.com/users/ioanacrant/events{/privacy}","received_events_url":"https://api.github.com/users/ioanacrant/received_events","type":"User","site_admin":false},"body":"I agree 👍 ","created_at":"2016-05-17T19:35:06Z","updated_at":"2016-05-17T19:35:06Z","html_url":"https://github.com/dotnet/corefx/pull/8609#discussion_r63588845","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/8609","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/63588845"},"html":{"href":"https://github.com/dotnet/corefx/pull/8609#discussion_r63588845"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8609"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/8609","id":70397239,"html_url":"https://github.com/dotnet/corefx/pull/8609","diff_url":"https://github.com/dotnet/corefx/pull/8609.diff","patch_url":"https://github.com/dotnet/corefx/pull/8609.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/8609","number":8609,"state":"open","locked":false,"title":"PropertyInfo tests refactoring","user":{"login":"ioanacrant","id":8014346,"avatar_url":"https://avatars.githubusercontent.com/u/8014346?v=3","gravatar_id":"","url":"https://api.github.com/users/ioanacrant","html_url":"https://github.com/ioanacrant","followers_url":"https://api.github.com/users/ioanacrant/followers","following_url":"https://api.github.com/users/ioanacrant/following{/other_user}","gists_url":"https://api.github.com/users/ioanacrant/gists{/gist_id}","starred_url":"https://api.github.com/users/ioanacrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioanacrant/subscriptions","organizations_url":"https://api.github.com/users/ioanacrant/orgs","repos_url":"https://api.github.com/users/ioanacrant/repos","events_url":"https://api.github.com/users/ioanacrant/events{/privacy}","received_events_url":"https://api.github.com/users/ioanacrant/received_events","type":"User","site_admin":false},"body":"- Leveraged `Theory`\r\n- More descriptive method names\r\n- Merged GetValueTests and SetValueTests\r\n\r\n@ellismg @stephentoub @hughbe","created_at":"2016-05-17T17:27:14Z","updated_at":"2016-05-17T19:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9cb35b44ae7dd194b39eebc92ac87ac9c57645c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/8609/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/8609/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/8609/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/044d211da72950936fc831c091b717e6a6a473de","head":{"label":"ioanacrant:propertyinfo-tests-refactor","ref":"propertyinfo-tests-refactor","sha":"044d211da72950936fc831c091b717e6a6a473de","user":{"login":"ioanacrant","id":8014346,"avatar_url":"https://avatars.githubusercontent.com/u/8014346?v=3","gravatar_id":"","url":"https://api.github.com/users/ioanacrant","html_url":"https://github.com/ioanacrant","followers_url":"https://api.github.com/users/ioanacrant/followers","following_url":"https://api.github.com/users/ioanacrant/following{/other_user}","gists_url":"https://api.github.com/users/ioanacrant/gists{/gist_id}","starred_url":"https://api.github.com/users/ioanacrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioanacrant/subscriptions","organizations_url":"https://api.github.com/users/ioanacrant/orgs","repos_url":"https://api.github.com/users/ioanacrant/repos","events_url":"https://api.github.com/users/ioanacrant/events{/privacy}","received_events_url":"https://api.github.com/users/ioanacrant/received_events","type":"User","site_admin":false},"repo":{"id":58956510,"name":"corefx","full_name":"ioanacrant/corefx","owner":{"login":"ioanacrant","id":8014346,"avatar_url":"https://avatars.githubusercontent.com/u/8014346?v=3","gravatar_id":"","url":"https://api.github.com/users/ioanacrant","html_url":"https://github.com/ioanacrant","followers_url":"https://api.github.com/users/ioanacrant/followers","following_url":"https://api.github.com/users/ioanacrant/following{/other_user}","gists_url":"https://api.github.com/users/ioanacrant/gists{/gist_id}","starred_url":"https://api.github.com/users/ioanacrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioanacrant/subscriptions","organizations_url":"https://api.github.com/users/ioanacrant/orgs","repos_url":"https://api.github.com/users/ioanacrant/repos","events_url":"https://api.github.com/users/ioanacrant/events{/privacy}","received_events_url":"https://api.github.com/users/ioanacrant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ioanacrant/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ioanacrant/corefx","forks_url":"https://api.github.com/repos/ioanacrant/corefx/forks","keys_url":"https://api.github.com/repos/ioanacrant/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioanacrant/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioanacrant/corefx/teams","hooks_url":"https://api.github.com/repos/ioanacrant/corefx/hooks","issue_events_url":"https://api.github.com/repos/ioanacrant/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ioanacrant/corefx/events","assignees_url":"https://api.github.com/repos/ioanacrant/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ioanacrant/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ioanacrant/corefx/tags","blobs_url":"https://api.github.com/repos/ioanacrant/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioanacrant/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioanacrant/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioanacrant/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioanacrant/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ioanacrant/corefx/languages","stargazers_url":"https://api.github.com/repos/ioanacrant/corefx/stargazers","contributors_url":"https://api.github.com/repos/ioanacrant/corefx/contributors","subscribers_url":"https://api.github.com/repos/ioanacrant/corefx/subscribers","subscription_url":"https://api.github.com/repos/ioanacrant/corefx/subscription","commits_url":"https://api.github.com/repos/ioanacrant/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioanacrant/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioanacrant/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioanacrant/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioanacrant/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ioanacrant/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioanacrant/corefx/merges","archive_url":"https://api.github.com/repos/ioanacrant/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioanacrant/corefx/downloads","issues_url":"https://api.github.com/repos/ioanacrant/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ioanacrant/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ioanacrant/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ioanacrant/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioanacrant/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ioanacrant/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ioanacrant/corefx/deployments","created_at":"2016-05-16T18:25:31Z","updated_at":"2016-05-16T18:25:57Z","pushed_at":"2016-05-16T22:45:16Z","git_url":"git://github.com/ioanacrant/corefx.git","ssh_url":"git@github.com:ioanacrant/corefx.git","clone_url":"https://github.com/ioanacrant/corefx.git","svn_url":"https://github.com/ioanacrant/corefx","homepage":"http://dotnet.github.io/","size":69960,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b1651306114d352dd5d87317a975ef5194466e5d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-05-17T18:42:17Z","pushed_at":"2016-05-17T19:30:12Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":94154,"stargazers_count":9693,"watchers_count":9693,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2325,"mirror_url":null,"open_issues_count":978,"forks":2325,"open_issues":978,"watchers":9693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8609"},"html":{"href":"https://github.com/dotnet/corefx/pull/8609"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8609"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8609/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8609/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8609/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/044d211da72950936fc831c091b717e6a6a473de"}}}}