{"action":"created","issue":{"url":"https://api.github.com/repos/theCrag/website/issues/2290","repository_url":"https://api.github.com/repos/theCrag/website","labels_url":"https://api.github.com/repos/theCrag/website/issues/2290/labels{/name}","comments_url":"https://api.github.com/repos/theCrag/website/issues/2290/comments","events_url":"https://api.github.com/repos/theCrag/website/issues/2290/events","html_url":"https://github.com/theCrag/website/issues/2290","id":167845559,"number":2290,"title":"topo image dimension migration required - using wrong aspect ratio","user":{"login":"scd","id":373058,"avatar_url":"https://avatars.githubusercontent.com/u/373058?v=3","gravatar_id":"","url":"https://api.github.com/users/scd","html_url":"https://github.com/scd","followers_url":"https://api.github.com/users/scd/followers","following_url":"https://api.github.com/users/scd/following{/other_user}","gists_url":"https://api.github.com/users/scd/gists{/gist_id}","starred_url":"https://api.github.com/users/scd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scd/subscriptions","organizations_url":"https://api.github.com/users/scd/orgs","repos_url":"https://api.github.com/users/scd/repos","events_url":"https://api.github.com/users/scd/events{/privacy}","received_events_url":"https://api.github.com/users/scd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-27T12:50:09Z","updated_at":"2016-07-31T02:37:49Z","closed_at":null,"body":"There is at least one problem with the Topo images using the wrong aspect ratio. When we save images we are not adjusting the width and height to take into account the aspect ratio or rotation. This is very complex and effects about 1500 topos. The problem was totally hidden the when the image volumes were being used.\r\n\r\nI cannot do anything before next week so I have made a hack in the phototopo code to swap width and heigh it there is old volume dimensions and their aspect rations are different. \r\n\r\n - [ ] establish that the native image size does not return the width and height based on exif and document in code for future logic analysis\r\n - [ ] on upload swap width and height for certain aspect ratios.\r\n - [ ] swap width and height on rotate\r\n - [ ] review upload code if image already exists in the system for upload\r\n - [ ] script that reads all original images (+photos) and works out whether the width / height should be swapped.  Review this with aspect ration for old volume system\r\n - [ ] There are some rotated images - work out why.\r\n - [ ] Update rotate back fix process to also swap width and height\r\n - [ ] remove phototopo hack"},"comment":{"url":"https://api.github.com/repos/theCrag/website/issues/comments/236404565","html_url":"https://github.com/theCrag/website/issues/2290#issuecomment-236404565","issue_url":"https://api.github.com/repos/theCrag/website/issues/2290","id":236404565,"user":{"login":"scd","id":373058,"avatar_url":"https://avatars.githubusercontent.com/u/373058?v=3","gravatar_id":"","url":"https://api.github.com/users/scd","html_url":"https://github.com/scd","followers_url":"https://api.github.com/users/scd/followers","following_url":"https://api.github.com/users/scd/following{/other_user}","gists_url":"https://api.github.com/users/scd/gists{/gist_id}","starred_url":"https://api.github.com/users/scd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scd/subscriptions","organizations_url":"https://api.github.com/users/scd/orgs","repos_url":"https://api.github.com/users/scd/repos","events_url":"https://api.github.com/users/scd/events{/privacy}","received_events_url":"https://api.github.com/users/scd/received_events","type":"User","site_admin":false},"created_at":"2016-07-31T02:37:48Z","updated_at":"2016-07-31T02:37:48Z","body":"Reference topo:\r\n\r\nhttp://www.thecrag.com/topo/936621639\r\n\r\nHere is the thumbor original.\r\n\r\nhttp://static.thecrag.com/img/ee/1e/ee1e1609c9e95fffd0e145778d07d32afe741335"}}
{"actor":{"display_login":"scd"}}