{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/71827403","id":71827403,"diff_hunk":"@@ -127,7 +127,7 @@\n   <PropertyGroup Condition=\"'$(IsTestProject)'=='true'\">\n     <StartWorkingDirectory Condition=\"'$(StartWorkingDirectory)'==''\">$(TestPath)$(DebugTestFrameworkFolder)</StartWorkingDirectory>\n     <StartAction Condition=\"'$(StartAction)'==''\">Program</StartAction>\n-    <StartProgram Condition=\"'$(StartProgram)'==''\">$(TestProgram)</StartProgram>\n+    <StartProgram Condition=\"'$(StartProgram)'==''\">$(TestHostDirectory)$(TestProgram)</StartProgram>","path":"src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets","position":5,"original_position":5,"commit_id":"3d84a908bd0ea5078fd03a93de88e437cf4a9354","original_commit_id":"3d84a908bd0ea5078fd03a93de88e437cf4a9354","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Shouldn't we just set the StartWorkingDirectory to TestHostDirectory instead? ","created_at":"2016-07-22T05:05:20Z","updated_at":"2016-07-22T05:05:20Z","html_url":"https://github.com/dotnet/buildtools/pull/897#discussion_r71827403","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/897","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/71827403"},"html":{"href":"https://github.com/dotnet/buildtools/pull/897#discussion_r71827403"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/897"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/897","id":78182313,"html_url":"https://github.com/dotnet/buildtools/pull/897","diff_url":"https://github.com/dotnet/buildtools/pull/897.diff","patch_url":"https://github.com/dotnet/buildtools/pull/897.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/897","number":897,"state":"open","locked":false,"title":"VS debugging fixes for tests","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"body":"Addresses Issues #699 and #700, with a couple typos fixed as well (searched repository, did not find other usages of the incorrectly spelled properties).\r\n\r\nIn order for the F5 scenario to work for CoreFX and other tests that use these .targets files, we need the files which are normally copied by the runner scripts (RunTests.cmd / .sh) to be copied before starting CoreRun.exe.  Running the script before debugging was a workaround, but by adding a target that executes at the end of other test copying code and only when the condition '$(BuildingInsideVisualStudio)'=='true'  is met works around this.  It uses the exact same file list generated for RunTests, and would not affect execution of the RunTests script before or after it is used.\r\n\r\n@weshaggard @stephentoub @AtsushiKan ","created_at":"2016-07-20T16:56:14Z","updated_at":"2016-07-22T05:05:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5e5e5351810e150c56f3f9e020c4a7cffea09a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/897/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/897/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/897/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/3d84a908bd0ea5078fd03a93de88e437cf4a9354","head":{"label":"MattGal:VS_Debugging_fixes","ref":"VS_Debugging_fixes","sha":"3d84a908bd0ea5078fd03a93de88e437cf4a9354","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"repo":{"id":53159521,"name":"buildtools","full_name":"MattGal/buildtools","owner":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattGal/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/MattGal/buildtools","forks_url":"https://api.github.com/repos/MattGal/buildtools/forks","keys_url":"https://api.github.com/repos/MattGal/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattGal/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattGal/buildtools/teams","hooks_url":"https://api.github.com/repos/MattGal/buildtools/hooks","issue_events_url":"https://api.github.com/repos/MattGal/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/MattGal/buildtools/events","assignees_url":"https://api.github.com/repos/MattGal/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/MattGal/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/MattGal/buildtools/tags","blobs_url":"https://api.github.com/repos/MattGal/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattGal/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattGal/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattGal/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattGal/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/MattGal/buildtools/languages","stargazers_url":"https://api.github.com/repos/MattGal/buildtools/stargazers","contributors_url":"https://api.github.com/repos/MattGal/buildtools/contributors","subscribers_url":"https://api.github.com/repos/MattGal/buildtools/subscribers","subscription_url":"https://api.github.com/repos/MattGal/buildtools/subscription","commits_url":"https://api.github.com/repos/MattGal/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattGal/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattGal/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattGal/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattGal/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/MattGal/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattGal/buildtools/merges","archive_url":"https://api.github.com/repos/MattGal/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattGal/buildtools/downloads","issues_url":"https://api.github.com/repos/MattGal/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/MattGal/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/MattGal/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/MattGal/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattGal/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/MattGal/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/MattGal/buildtools/deployments","created_at":"2016-03-04T19:15:10Z","updated_at":"2016-03-04T19:15:12Z","pushed_at":"2016-07-21T23:17:55Z","git_url":"git://github.com/MattGal/buildtools.git","ssh_url":"git@github.com:MattGal/buildtools.git","clone_url":"https://github.com/MattGal/buildtools.git","svn_url":"https://github.com/MattGal/buildtools","homepage":"","size":3596,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"26050729bcf56e3a8461b282979bf82ef85d3167","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-07-22T04:26:18Z","pushed_at":"2016-07-22T02:28:42Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":4452,"stargazers_count":412,"watchers_count":412,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":101,"forks":197,"open_issues":101,"watchers":412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/897"},"html":{"href":"https://github.com/dotnet/buildtools/pull/897"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/897"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/897/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/897/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/897/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/3d84a908bd0ea5078fd03a93de88e437cf4a9354"}}}}
{"actor":{"display_login":"weshaggard"}}