{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/106","labels_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/106/comments","events_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/106/events","html_url":"https://github.com/ros2/rmw_opensplice/pull/106","id":130537832,"number":106,"title":"Add opensplice c type support","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ros2/rmw_opensplice/labels/in%20progress","name":"in progress","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-02-02T01:15:48Z","updated_at":"2016-02-02T01:17:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/106","html_url":"https://github.com/ros2/rmw_opensplice/pull/106","diff_url":"https://github.com/ros2/rmw_opensplice/pull/106.diff","patch_url":"https://github.com/ros2/rmw_opensplice/pull/106.patch"},"body":"This pull request implements C typesupport for rmw_openspice.\r\n\r\nThere are a few things I didn't get to:\r\n\r\n- Refactoring the code so that the C typesupport package does the idl generation rather than the C++ typesupport\r\n - It seems weird to me that C depends on C++ at the moment\r\n- Add code for services.\r\n - It's not clear to me that this is needed at all, but for now there is no C/OpenSplice specific code that needs to be generated for `.srv` files, so there are some comments and an empty file for future additions."},"comment":{"url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/comments/178292992","html_url":"https://github.com/ros2/rmw_opensplice/pull/106#issuecomment-178292992","issue_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/106","id":178292992,"user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T01:17:41Z","updated_at":"2016-02-02T01:17:41Z","body":"Also this pr (set of pr's) do not include new tests, since they either require all of the rmw implementations to support C before the tests will build and pass or temporary hacks to only build/run those tests with OpenSplice. I'll push the new examples and tests to a branch called `c_typesupport_tests`."}}