{"action":"created","comment":{"url":"https://api.github.com/repos/thusfresh/absinthe/pulls/comments/87602471","pull_request_review_id":8210725,"id":87602471,"diff_hunk":"@@ -263,7 +263,24 @@ extract_atom({Value, _Line}) -> Value.\n extract_binary(Value) when is_binary(Value) -> Value;\n extract_binary({Token, _Line}) -> list_to_binary(atom_to_list(Token));\n extract_binary({_Token, _Line, Value}) -> list_to_binary(Value).\n-extract_quoted_string_token({_Token, _Line, Value}) -> list_to_binary(lists:sublist(Value, 2, length(Value) - 2)).\n+extract_quoted_string_token({_Token, _Line, Value}) -> iolist_to_binary(unescape(lists:sublist(Value, 2, length(Value) - 2))).\n+\n+unescape(Escaped) -> unescape(Escaped, []).\n+\n+unescape([], Acc) -> lists:reverse(Acc);\n+unescape([$\\\\, $\" | T], Acc) -> unescape(T, [16#0022 | Acc]);","path":"src/absinthe_parser.yrl","position":10,"original_position":10,"commit_id":"dfa695d84a60180dc0d0a8c45493aada75443b71","original_commit_id":"dfa695d84a60180dc0d0a8c45493aada75443b71","user":{"login":"nietaki","id":140347,"avatar_url":"https://avatars.githubusercontent.com/u/140347?v=3","gravatar_id":"","url":"https://api.github.com/users/nietaki","html_url":"https://github.com/nietaki","followers_url":"https://api.github.com/users/nietaki/followers","following_url":"https://api.github.com/users/nietaki/following{/other_user}","gists_url":"https://api.github.com/users/nietaki/gists{/gist_id}","starred_url":"https://api.github.com/users/nietaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nietaki/subscriptions","organizations_url":"https://api.github.com/users/nietaki/orgs","repos_url":"https://api.github.com/users/nietaki/repos","events_url":"https://api.github.com/users/nietaki/events{/privacy}","received_events_url":"https://api.github.com/users/nietaki/received_events","type":"User","site_admin":false},"body":"Can do. I just wanted to show the replacements conform to the spec, but I guess the character literals will be more robust and easily understandable","created_at":"2016-11-11T15:10:28Z","updated_at":"2016-11-11T15:10:28Z","html_url":"https://github.com/thusfresh/absinthe/pull/1#discussion_r87602471","pull_request_url":"https://api.github.com/repos/thusfresh/absinthe/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/thusfresh/absinthe/pulls/comments/87602471"},"html":{"href":"https://github.com/thusfresh/absinthe/pull/1#discussion_r87602471"},"pull_request":{"href":"https://api.github.com/repos/thusfresh/absinthe/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/thusfresh/absinthe/pulls/1","id":93341830,"html_url":"https://github.com/thusfresh/absinthe/pull/1","diff_url":"https://github.com/thusfresh/absinthe/pull/1.diff","patch_url":"https://github.com/thusfresh/absinthe/pull/1.patch","issue_url":"https://api.github.com/repos/thusfresh/absinthe/issues/1","number":1,"state":"open","locked":false,"title":"Fix escaped characters in input literals (#165)","user":{"login":"nietaki","id":140347,"avatar_url":"https://avatars.githubusercontent.com/u/140347?v=3","gravatar_id":"","url":"https://api.github.com/users/nietaki","html_url":"https://github.com/nietaki","followers_url":"https://api.github.com/users/nietaki/followers","following_url":"https://api.github.com/users/nietaki/following{/other_user}","gists_url":"https://api.github.com/users/nietaki/gists{/gist_id}","starred_url":"https://api.github.com/users/nietaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nietaki/subscriptions","organizations_url":"https://api.github.com/users/nietaki/orgs","repos_url":"https://api.github.com/users/nietaki/repos","events_url":"https://api.github.com/users/nietaki/events{/privacy}","received_events_url":"https://api.github.com/users/nietaki/received_events","type":"User","site_admin":false},"body":"GraphQL escaping spec: https://facebook.github.io/graphql/#sec-String-Value","created_at":"2016-11-11T14:39:53Z","updated_at":"2016-11-11T15:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8de5439062b244440d718cbe5deca7e62c4423ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thusfresh/absinthe/pulls/1/commits","review_comments_url":"https://api.github.com/repos/thusfresh/absinthe/pulls/1/comments","review_comment_url":"https://api.github.com/repos/thusfresh/absinthe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thusfresh/absinthe/issues/1/comments","statuses_url":"https://api.github.com/repos/thusfresh/absinthe/statuses/dfa695d84a60180dc0d0a8c45493aada75443b71","head":{"label":"thusfresh:escaping_fix","ref":"escaping_fix","sha":"dfa695d84a60180dc0d0a8c45493aada75443b71","user":{"login":"thusfresh","id":4616210,"avatar_url":"https://avatars.githubusercontent.com/u/4616210?v=3","gravatar_id":"","url":"https://api.github.com/users/thusfresh","html_url":"https://github.com/thusfresh","followers_url":"https://api.github.com/users/thusfresh/followers","following_url":"https://api.github.com/users/thusfresh/following{/other_user}","gists_url":"https://api.github.com/users/thusfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/thusfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusfresh/subscriptions","organizations_url":"https://api.github.com/users/thusfresh/orgs","repos_url":"https://api.github.com/users/thusfresh/repos","events_url":"https://api.github.com/users/thusfresh/events{/privacy}","received_events_url":"https://api.github.com/users/thusfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":70688385,"name":"absinthe","full_name":"thusfresh/absinthe","owner":{"login":"thusfresh","id":4616210,"avatar_url":"https://avatars.githubusercontent.com/u/4616210?v=3","gravatar_id":"","url":"https://api.github.com/users/thusfresh","html_url":"https://github.com/thusfresh","followers_url":"https://api.github.com/users/thusfresh/followers","following_url":"https://api.github.com/users/thusfresh/following{/other_user}","gists_url":"https://api.github.com/users/thusfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/thusfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusfresh/subscriptions","organizations_url":"https://api.github.com/users/thusfresh/orgs","repos_url":"https://api.github.com/users/thusfresh/repos","events_url":"https://api.github.com/users/thusfresh/events{/privacy}","received_events_url":"https://api.github.com/users/thusfresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thusfresh/absinthe","description":"GraphQL for Elixir","fork":true,"url":"https://api.github.com/repos/thusfresh/absinthe","forks_url":"https://api.github.com/repos/thusfresh/absinthe/forks","keys_url":"https://api.github.com/repos/thusfresh/absinthe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thusfresh/absinthe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thusfresh/absinthe/teams","hooks_url":"https://api.github.com/repos/thusfresh/absinthe/hooks","issue_events_url":"https://api.github.com/repos/thusfresh/absinthe/issues/events{/number}","events_url":"https://api.github.com/repos/thusfresh/absinthe/events","assignees_url":"https://api.github.com/repos/thusfresh/absinthe/assignees{/user}","branches_url":"https://api.github.com/repos/thusfresh/absinthe/branches{/branch}","tags_url":"https://api.github.com/repos/thusfresh/absinthe/tags","blobs_url":"https://api.github.com/repos/thusfresh/absinthe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thusfresh/absinthe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thusfresh/absinthe/git/refs{/sha}","trees_url":"https://api.github.com/repos/thusfresh/absinthe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thusfresh/absinthe/statuses/{sha}","languages_url":"https://api.github.com/repos/thusfresh/absinthe/languages","stargazers_url":"https://api.github.com/repos/thusfresh/absinthe/stargazers","contributors_url":"https://api.github.com/repos/thusfresh/absinthe/contributors","subscribers_url":"https://api.github.com/repos/thusfresh/absinthe/subscribers","subscription_url":"https://api.github.com/repos/thusfresh/absinthe/subscription","commits_url":"https://api.github.com/repos/thusfresh/absinthe/commits{/sha}","git_commits_url":"https://api.github.com/repos/thusfresh/absinthe/git/commits{/sha}","comments_url":"https://api.github.com/repos/thusfresh/absinthe/comments{/number}","issue_comment_url":"https://api.github.com/repos/thusfresh/absinthe/issues/comments{/number}","contents_url":"https://api.github.com/repos/thusfresh/absinthe/contents/{+path}","compare_url":"https://api.github.com/repos/thusfresh/absinthe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thusfresh/absinthe/merges","archive_url":"https://api.github.com/repos/thusfresh/absinthe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thusfresh/absinthe/downloads","issues_url":"https://api.github.com/repos/thusfresh/absinthe/issues{/number}","pulls_url":"https://api.github.com/repos/thusfresh/absinthe/pulls{/number}","milestones_url":"https://api.github.com/repos/thusfresh/absinthe/milestones{/number}","notifications_url":"https://api.github.com/repos/thusfresh/absinthe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thusfresh/absinthe/labels{/name}","releases_url":"https://api.github.com/repos/thusfresh/absinthe/releases{/id}","deployments_url":"https://api.github.com/repos/thusfresh/absinthe/deployments","created_at":"2016-10-12T10:17:36Z","updated_at":"2016-11-09T17:32:14Z","pushed_at":"2016-11-11T14:45:09Z","git_url":"git://github.com/thusfresh/absinthe.git","ssh_url":"git@github.com:thusfresh/absinthe.git","clone_url":"https://github.com/thusfresh/absinthe.git","svn_url":"https://github.com/thusfresh/absinthe","homepage":"http://absinthe-graphql.org","size":1086,"stargazers_count":1,"watchers_count":1,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"thusfresh:v1.2-bug-165","ref":"v1.2-bug-165","sha":"f5239f897c2506970f4bd32db9bf1a472c113fd2","user":{"login":"thusfresh","id":4616210,"avatar_url":"https://avatars.githubusercontent.com/u/4616210?v=3","gravatar_id":"","url":"https://api.github.com/users/thusfresh","html_url":"https://github.com/thusfresh","followers_url":"https://api.github.com/users/thusfresh/followers","following_url":"https://api.github.com/users/thusfresh/following{/other_user}","gists_url":"https://api.github.com/users/thusfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/thusfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusfresh/subscriptions","organizations_url":"https://api.github.com/users/thusfresh/orgs","repos_url":"https://api.github.com/users/thusfresh/repos","events_url":"https://api.github.com/users/thusfresh/events{/privacy}","received_events_url":"https://api.github.com/users/thusfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":70688385,"name":"absinthe","full_name":"thusfresh/absinthe","owner":{"login":"thusfresh","id":4616210,"avatar_url":"https://avatars.githubusercontent.com/u/4616210?v=3","gravatar_id":"","url":"https://api.github.com/users/thusfresh","html_url":"https://github.com/thusfresh","followers_url":"https://api.github.com/users/thusfresh/followers","following_url":"https://api.github.com/users/thusfresh/following{/other_user}","gists_url":"https://api.github.com/users/thusfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/thusfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusfresh/subscriptions","organizations_url":"https://api.github.com/users/thusfresh/orgs","repos_url":"https://api.github.com/users/thusfresh/repos","events_url":"https://api.github.com/users/thusfresh/events{/privacy}","received_events_url":"https://api.github.com/users/thusfresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thusfresh/absinthe","description":"GraphQL for Elixir","fork":true,"url":"https://api.github.com/repos/thusfresh/absinthe","forks_url":"https://api.github.com/repos/thusfresh/absinthe/forks","keys_url":"https://api.github.com/repos/thusfresh/absinthe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thusfresh/absinthe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thusfresh/absinthe/teams","hooks_url":"https://api.github.com/repos/thusfresh/absinthe/hooks","issue_events_url":"https://api.github.com/repos/thusfresh/absinthe/issues/events{/number}","events_url":"https://api.github.com/repos/thusfresh/absinthe/events","assignees_url":"https://api.github.com/repos/thusfresh/absinthe/assignees{/user}","branches_url":"https://api.github.com/repos/thusfresh/absinthe/branches{/branch}","tags_url":"https://api.github.com/repos/thusfresh/absinthe/tags","blobs_url":"https://api.github.com/repos/thusfresh/absinthe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thusfresh/absinthe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thusfresh/absinthe/git/refs{/sha}","trees_url":"https://api.github.com/repos/thusfresh/absinthe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thusfresh/absinthe/statuses/{sha}","languages_url":"https://api.github.com/repos/thusfresh/absinthe/languages","stargazers_url":"https://api.github.com/repos/thusfresh/absinthe/stargazers","contributors_url":"https://api.github.com/repos/thusfresh/absinthe/contributors","subscribers_url":"https://api.github.com/repos/thusfresh/absinthe/subscribers","subscription_url":"https://api.github.com/repos/thusfresh/absinthe/subscription","commits_url":"https://api.github.com/repos/thusfresh/absinthe/commits{/sha}","git_commits_url":"https://api.github.com/repos/thusfresh/absinthe/git/commits{/sha}","comments_url":"https://api.github.com/repos/thusfresh/absinthe/comments{/number}","issue_comment_url":"https://api.github.com/repos/thusfresh/absinthe/issues/comments{/number}","contents_url":"https://api.github.com/repos/thusfresh/absinthe/contents/{+path}","compare_url":"https://api.github.com/repos/thusfresh/absinthe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thusfresh/absinthe/merges","archive_url":"https://api.github.com/repos/thusfresh/absinthe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thusfresh/absinthe/downloads","issues_url":"https://api.github.com/repos/thusfresh/absinthe/issues{/number}","pulls_url":"https://api.github.com/repos/thusfresh/absinthe/pulls{/number}","milestones_url":"https://api.github.com/repos/thusfresh/absinthe/milestones{/number}","notifications_url":"https://api.github.com/repos/thusfresh/absinthe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thusfresh/absinthe/labels{/name}","releases_url":"https://api.github.com/repos/thusfresh/absinthe/releases{/id}","deployments_url":"https://api.github.com/repos/thusfresh/absinthe/deployments","created_at":"2016-10-12T10:17:36Z","updated_at":"2016-11-09T17:32:14Z","pushed_at":"2016-11-11T14:45:09Z","git_url":"git://github.com/thusfresh/absinthe.git","ssh_url":"git@github.com:thusfresh/absinthe.git","clone_url":"https://github.com/thusfresh/absinthe.git","svn_url":"https://github.com/thusfresh/absinthe","homepage":"http://absinthe-graphql.org","size":1086,"stargazers_count":1,"watchers_count":1,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thusfresh/absinthe/pulls/1"},"html":{"href":"https://github.com/thusfresh/absinthe/pull/1"},"issue":{"href":"https://api.github.com/repos/thusfresh/absinthe/issues/1"},"comments":{"href":"https://api.github.com/repos/thusfresh/absinthe/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/thusfresh/absinthe/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/thusfresh/absinthe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thusfresh/absinthe/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/thusfresh/absinthe/statuses/dfa695d84a60180dc0d0a8c45493aada75443b71"}}}}
{"actor":{"display_login":"nietaki"}}