{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/57739169","id":57739169,"diff_hunk":"@@ -297,23 +297,22 @@ def to_datetime(arg, errors='raise', dayfirst=False, yearfirst=False,\n     NaT\n \n     \"\"\"\n-    if origin == 'unix':\n-        return _to_datetime(arg, errors=errors, dayfirst=dayfirst, yearfirst=yearfirst,\n-                            utc=utc, box=box, format=format, exact=exact,\n-                            unit=unit, infer_datetime_format=infer_datetime_format)\n-    elif origin == 'julian':\n+    offset = None\n+    if origin == 'julian':\n         if unit != 'D':","path":"pandas/tseries/tools.py","position":41,"original_position":41,"commit_id":"ea7780917d0c030dc7c3717b0c818b23861b013f","original_commit_id":"ea7780917d0c030dc7c3717b0c818b23861b013f","user":{"login":"sumitbinnani","id":11199045,"avatar_url":"https://avatars.githubusercontent.com/u/11199045?v=3","gravatar_id":"","url":"https://api.github.com/users/sumitbinnani","html_url":"https://github.com/sumitbinnani","followers_url":"https://api.github.com/users/sumitbinnani/followers","following_url":"https://api.github.com/users/sumitbinnani/following{/other_user}","gists_url":"https://api.github.com/users/sumitbinnani/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitbinnani/subscriptions","organizations_url":"https://api.github.com/users/sumitbinnani/orgs","repos_url":"https://api.github.com/users/sumitbinnani/repos","events_url":"https://api.github.com/users/sumitbinnani/events{/privacy}","received_events_url":"https://api.github.com/users/sumitbinnani/received_events","type":"User","site_admin":false},"body":"The default for ``unit`` is ``ns``. So explicitly providing it as a ``None`` might be confusing (as julian dates are always defines as 'julian day'). Let me know what do you think, @jreback? ","created_at":"2016-03-29T15:05:30Z","updated_at":"2016-03-29T15:05:30Z","html_url":"https://github.com/pydata/pandas/pull/11470#discussion_r57739169","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/11470","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/57739169"},"html":{"href":"https://github.com/pydata/pandas/pull/11470#discussion_r57739169"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11470"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/11470","id":49126349,"html_url":"https://github.com/pydata/pandas/pull/11470","diff_url":"https://github.com/pydata/pandas/pull/11470.diff","patch_url":"https://github.com/pydata/pandas/pull/11470.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/11470","number":11470,"state":"open","locked":false,"title":"ENH: Adding origin parameter in pd.to_datetime","user":{"login":"sumitbinnani","id":11199045,"avatar_url":"https://avatars.githubusercontent.com/u/11199045?v=3","gravatar_id":"","url":"https://api.github.com/users/sumitbinnani","html_url":"https://github.com/sumitbinnani","followers_url":"https://api.github.com/users/sumitbinnani/followers","following_url":"https://api.github.com/users/sumitbinnani/following{/other_user}","gists_url":"https://api.github.com/users/sumitbinnani/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitbinnani/subscriptions","organizations_url":"https://api.github.com/users/sumitbinnani/orgs","repos_url":"https://api.github.com/users/sumitbinnani/repos","events_url":"https://api.github.com/users/sumitbinnani/events{/privacy}","received_events_url":"https://api.github.com/users/sumitbinnani/received_events","type":"User","site_admin":false},"body":"Fixes #11276\r\nFixes  #11745","created_at":"2015-10-29T11:20:00Z","updated_at":"2016-03-29T15:05:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0abcc9f3b0bca5e897775475b030e8349d7a79a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/11470/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/11470/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/11470/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/ea7780917d0c030dc7c3717b0c818b23861b013f","head":{"label":"sumitbinnani:ENH-Adding-unit-``julian``-to-``to_datetime``","ref":"ENH-Adding-unit-``julian``-to-``to_datetime``","sha":"ea7780917d0c030dc7c3717b0c818b23861b013f","user":{"login":"sumitbinnani","id":11199045,"avatar_url":"https://avatars.githubusercontent.com/u/11199045?v=3","gravatar_id":"","url":"https://api.github.com/users/sumitbinnani","html_url":"https://github.com/sumitbinnani","followers_url":"https://api.github.com/users/sumitbinnani/followers","following_url":"https://api.github.com/users/sumitbinnani/following{/other_user}","gists_url":"https://api.github.com/users/sumitbinnani/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitbinnani/subscriptions","organizations_url":"https://api.github.com/users/sumitbinnani/orgs","repos_url":"https://api.github.com/users/sumitbinnani/repos","events_url":"https://api.github.com/users/sumitbinnani/events{/privacy}","received_events_url":"https://api.github.com/users/sumitbinnani/received_events","type":"User","site_admin":false},"repo":{"id":44153212,"name":"pandas","full_name":"sumitbinnani/pandas","owner":{"login":"sumitbinnani","id":11199045,"avatar_url":"https://avatars.githubusercontent.com/u/11199045?v=3","gravatar_id":"","url":"https://api.github.com/users/sumitbinnani","html_url":"https://github.com/sumitbinnani","followers_url":"https://api.github.com/users/sumitbinnani/followers","following_url":"https://api.github.com/users/sumitbinnani/following{/other_user}","gists_url":"https://api.github.com/users/sumitbinnani/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitbinnani/subscriptions","organizations_url":"https://api.github.com/users/sumitbinnani/orgs","repos_url":"https://api.github.com/users/sumitbinnani/repos","events_url":"https://api.github.com/users/sumitbinnani/events{/privacy}","received_events_url":"https://api.github.com/users/sumitbinnani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sumitbinnani/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/sumitbinnani/pandas","forks_url":"https://api.github.com/repos/sumitbinnani/pandas/forks","keys_url":"https://api.github.com/repos/sumitbinnani/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumitbinnani/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumitbinnani/pandas/teams","hooks_url":"https://api.github.com/repos/sumitbinnani/pandas/hooks","issue_events_url":"https://api.github.com/repos/sumitbinnani/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/sumitbinnani/pandas/events","assignees_url":"https://api.github.com/repos/sumitbinnani/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/sumitbinnani/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/sumitbinnani/pandas/tags","blobs_url":"https://api.github.com/repos/sumitbinnani/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumitbinnani/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumitbinnani/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumitbinnani/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumitbinnani/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/sumitbinnani/pandas/languages","stargazers_url":"https://api.github.com/repos/sumitbinnani/pandas/stargazers","contributors_url":"https://api.github.com/repos/sumitbinnani/pandas/contributors","subscribers_url":"https://api.github.com/repos/sumitbinnani/pandas/subscribers","subscription_url":"https://api.github.com/repos/sumitbinnani/pandas/subscription","commits_url":"https://api.github.com/repos/sumitbinnani/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumitbinnani/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumitbinnani/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumitbinnani/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumitbinnani/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/sumitbinnani/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumitbinnani/pandas/merges","archive_url":"https://api.github.com/repos/sumitbinnani/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumitbinnani/pandas/downloads","issues_url":"https://api.github.com/repos/sumitbinnani/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/sumitbinnani/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/sumitbinnani/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/sumitbinnani/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumitbinnani/pandas/labels{/name}","releases_url":"https://api.github.com/repos/sumitbinnani/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/sumitbinnani/pandas/deployments","created_at":"2015-10-13T05:05:51Z","updated_at":"2016-03-24T04:37:58Z","pushed_at":"2016-03-28T18:09:20Z","git_url":"git://github.com/sumitbinnani/pandas.git","ssh_url":"git@github.com:sumitbinnani/pandas.git","clone_url":"https://github.com/sumitbinnani/pandas.git","svn_url":"https://github.com/sumitbinnani/pandas","homepage":"http://pandas.pydata.org","size":79707,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"4e7974aef2b114c62f010c3c77fe80ed8ac41aee","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-03-29T09:16:54Z","pushed_at":"2016-03-29T14:39:19Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":142142,"stargazers_count":5962,"watchers_count":5962,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2438,"mirror_url":null,"open_issues_count":1712,"forks":2438,"open_issues":1712,"watchers":5962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11470"},"html":{"href":"https://github.com/pydata/pandas/pull/11470"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/11470"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/11470/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11470/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11470/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/ea7780917d0c030dc7c3717b0c818b23861b013f"}}}}