{"action":"created","issue":{"url":"https://api.github.com/repos/igniterealtime/Openfire/issues/638","repository_url":"https://api.github.com/repos/igniterealtime/Openfire","labels_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/638/labels{/name}","comments_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/638/comments","events_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/638/events","html_url":"https://github.com/igniterealtime/Openfire/pull/638","id":172512720,"number":638,"title":"4.0.x branch - EXTERNAL auth with BOSH - avoid NPE when peer certificates array is null","user":{"login":"hdeadman","id":1556777,"avatar_url":"https://avatars.githubusercontent.com/u/1556777?v=3","gravatar_id":"","url":"https://api.github.com/users/hdeadman","html_url":"https://github.com/hdeadman","followers_url":"https://api.github.com/users/hdeadman/followers","following_url":"https://api.github.com/users/hdeadman/following{/other_user}","gists_url":"https://api.github.com/users/hdeadman/gists{/gist_id}","starred_url":"https://api.github.com/users/hdeadman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdeadman/subscriptions","organizations_url":"https://api.github.com/users/hdeadman/orgs","repos_url":"https://api.github.com/users/hdeadman/repos","events_url":"https://api.github.com/users/hdeadman/events{/privacy}","received_events_url":"https://api.github.com/users/hdeadman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-22T17:47:24Z","updated_at":"2016-09-26T16:56:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/igniterealtime/Openfire/pulls/638","html_url":"https://github.com/igniterealtime/Openfire/pull/638","diff_url":"https://github.com/igniterealtime/Openfire/pull/638.diff","patch_url":"https://github.com/igniterealtime/Openfire/pull/638.patch"},"body":"This only applies to 4.0.x branch b/c SASLAuthentication is very different in master, but if you put out a 4.0.4 this shouldn't hurt anything and it allows us to get back an error message rather than just timing out when doing external auth over https (with client certs).  \r\n\r\nThe second commit avoids a StackOverflowException that was happening when the code was retrieving keystores, see commit comment for details. "},"comment":{"url":"https://api.github.com/repos/igniterealtime/Openfire/issues/comments/249629547","html_url":"https://github.com/igniterealtime/Openfire/pull/638#issuecomment-249629547","issue_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/638","id":249629547,"user":{"login":"hdeadman","id":1556777,"avatar_url":"https://avatars.githubusercontent.com/u/1556777?v=3","gravatar_id":"","url":"https://api.github.com/users/hdeadman","html_url":"https://github.com/hdeadman","followers_url":"https://api.github.com/users/hdeadman/followers","following_url":"https://api.github.com/users/hdeadman/following{/other_user}","gists_url":"https://api.github.com/users/hdeadman/gists{/gist_id}","starred_url":"https://api.github.com/users/hdeadman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdeadman/subscriptions","organizations_url":"https://api.github.com/users/hdeadman/orgs","repos_url":"https://api.github.com/users/hdeadman/repos","events_url":"https://api.github.com/users/hdeadman/events{/privacy}","received_events_url":"https://api.github.com/users/hdeadman/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T16:56:44Z","updated_at":"2016-09-26T16:56:44Z","body":"I rebased the pull request to one commit. I think the code is looking up the C2S keystores in a block of code that is specific to client to server connections. Is openfire allowing different keystores for different C2S connections? The current code was getting a stack overflow exception. My changes allow client auth to work with BOSH (from strophe.js), at least in our setup. "}}
{"actor":{"display_login":"hdeadman"}}