{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/62666646","id":62666646,"diff_hunk":"@@ -149,8 +82,43 @@ angular.module('openshiftConsole')\n           }\n         );\n \n+      watches.push(DataService.watch(\"builds\", context, function(builds, action, build) {\n+        $scope.emptyMessage = \"No builds to show\";\n+        // TODO we should send the ?labelSelector=buildconfig=<name> on the API request","path":"assets/app/scripts/controllers/buildConfig.js","position":95,"original_position":95,"commit_id":"8e34ab3578d8633bd530af75884e200b2d968763","original_commit_id":"8e34ab3578d8633bd530af75884e200b2d968763","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"body":"can you actually take this comment out, it should have been removed as part of @benjaminapetersen PR that added the selector but i missed it","created_at":"2016-05-10T13:03:23Z","updated_at":"2016-05-10T13:03:23Z","html_url":"https://github.com/openshift/origin/pull/8722#discussion_r62666646","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8722","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/62666646"},"html":{"href":"https://github.com/openshift/origin/pull/8722#discussion_r62666646"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8722"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8722","id":68709636,"html_url":"https://github.com/openshift/origin/pull/8722","diff_url":"https://github.com/openshift/origin/pull/8722.diff","patch_url":"https://github.com/openshift/origin/pull/8722.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8722","number":8722,"state":"open","locked":false,"title":"Show/edit run policy for a BuildConfig","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"body":"Based on https://trello.com/c/qVzqRo0t/654\r\nThings we want:\r\n- show/edit buildConfigs `runPolicy` \r\n- get rid of disabling `Start Build` and `Rebuild` buttons (based on https://github.com/openshift/origin/issues/8510)\r\n\r\nThings we might want:\r\n- bulk actions on BCs - start-build\r\n- bulk actions on Builds - rebuild, cancel-build\r\n\r\nPreview of showing BS's runPolicy:\r\n![screenshot-34](https://cloud.githubusercontent.com/assets/1668218/14984206/d6cf281a-1141-11e6-98a5-65ddde535aec.png)\r\n![screenshot-35](https://cloud.githubusercontent.com/assets/1668218/14984196/c6190d4c-1141-11e6-9898-0d0eea2af252.png)\r\n\r\n\r\nAnd here are couple of drafts for the BC's edit page. In here I've created a separate section, since it wouldnt make sense to have the `runPolicy` in any of the other section(source config., image config.,) :\r\n1. dropdown with a description under\r\n![screenshot-31](https://cloud.githubusercontent.com/assets/1668218/14984261/0c8fd9f4-1142-11e6-9536-e4695b31d07b.png)\r\n2. dropdown with a italic description under\r\n![screenshot-30](https://cloud.githubusercontent.com/assets/1668218/14984286/2ea537d2-1142-11e6-9339-78d6b70ef483.png)\r\n3. radio buttons with tooltip for description\r\n![screenshot-33](https://cloud.githubusercontent.com/assets/1668218/14984297/3b28a0b6-1142-11e6-8342-290ace000efe.png)\r\n\r\n\r\nDrafts 1 and 2 contain tooltip next to the section header that says `The build run policy describes the order in which the builds created from the build configuration should run`. Draft 3 wont have the scetion header tooltip just a tooltip to each radio button, explaining the given runPolicy type.\r\n\r\nAlso I've haven't done any effort to show the `runPolicy` type for the build show page, since the type is a part of the build labels and those we are already listing, so I think thats enough.\r\n\r\n@jwforres @spadgett PTAL. We also need to align on whether we want to have the bulk actions I've described at the top. I think they could come really handy, mainly the bulk cancellation of builds.\r\nThoughts ?  \r\n\r\n","created_at":"2016-05-03T13:57:20Z","updated_at":"2016-05-10T13:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d0c2cdad7d70d388301b9f9e2f220940bbe0c7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8722/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8722/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8722/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/8e34ab3578d8633bd530af75884e200b2d968763","head":{"label":"jhadvig:runPolicy","ref":"runPolicy","sha":"8e34ab3578d8633bd530af75884e200b2d968763","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"repo":{"id":24180023,"name":"origin","full_name":"jhadvig/origin","owner":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhadvig/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/jhadvig/origin","forks_url":"https://api.github.com/repos/jhadvig/origin/forks","keys_url":"https://api.github.com/repos/jhadvig/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhadvig/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhadvig/origin/teams","hooks_url":"https://api.github.com/repos/jhadvig/origin/hooks","issue_events_url":"https://api.github.com/repos/jhadvig/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jhadvig/origin/events","assignees_url":"https://api.github.com/repos/jhadvig/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jhadvig/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jhadvig/origin/tags","blobs_url":"https://api.github.com/repos/jhadvig/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhadvig/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhadvig/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhadvig/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhadvig/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jhadvig/origin/languages","stargazers_url":"https://api.github.com/repos/jhadvig/origin/stargazers","contributors_url":"https://api.github.com/repos/jhadvig/origin/contributors","subscribers_url":"https://api.github.com/repos/jhadvig/origin/subscribers","subscription_url":"https://api.github.com/repos/jhadvig/origin/subscription","commits_url":"https://api.github.com/repos/jhadvig/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhadvig/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhadvig/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhadvig/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhadvig/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jhadvig/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhadvig/origin/merges","archive_url":"https://api.github.com/repos/jhadvig/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhadvig/origin/downloads","issues_url":"https://api.github.com/repos/jhadvig/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jhadvig/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jhadvig/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jhadvig/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhadvig/origin/labels{/name}","releases_url":"https://api.github.com/repos/jhadvig/origin/releases{/id}","deployments_url":"https://api.github.com/repos/jhadvig/origin/deployments","created_at":"2014-09-18T08:22:36Z","updated_at":"2015-08-13T16:47:19Z","pushed_at":"2016-05-10T09:48:58Z","git_url":"git://github.com/jhadvig/origin.git","ssh_url":"git@github.com:jhadvig/origin.git","clone_url":"https://github.com/jhadvig/origin.git","svn_url":"https://github.com/jhadvig/origin","homepage":"https://openshift.github.io","size":258457,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"fd7caa6b8648f7c40b6547c400e0621beeb395e9","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-05-09T06:34:35Z","pushed_at":"2016-05-10T12:56:23Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":341293,"stargazers_count":1276,"watchers_count":1276,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":769,"mirror_url":null,"open_issues_count":985,"forks":769,"open_issues":985,"watchers":1276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8722"},"html":{"href":"https://github.com/openshift/origin/pull/8722"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8722"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8722/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8722/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8722/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/8e34ab3578d8633bd530af75884e200b2d968763"}}}}