{"action":"created","comment":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/comments/64065698","id":64065698,"diff_hunk":"@@ -103,68 +95,29 @@ export default AbstractModal.extend({\n   willDestroyElement () {\n     this.get('modalForms').setModalActive(false)\n   },\n-\n-  formData: {\n-    state: {},\n-    isValid: false\n-  },\n-\n-  clearForm () {\n-    this.set('formData', {\n-      state: {},\n-      isValid: false\n-    })\n-  },\n-\n-  actions: {\n-    cancel () {\n-      this.clearForm()\n-      this.sendAction('dismiss')\n-    },\n-\n-    formValueChanged (formState) {\n-      this.set('formData.state', formState)\n-    },\n-\n-    onValidation (info) {\n-      this.set('formData.isValid', info.valid)\n-    },\n-\n-    save () {\n-      if (this.get('formData.isValid')) {\n-        this.sendAction('save', this.get('formData.state'))\n-        this.sendAction('dismiss')\n-        this.clearForm()\n-      }\n-    }\n-  }\n })\n ```\n-##### 2) Parent Component Template with ember-perfectscroll\n-###### a) Wrap container element with ember-perfectscroll helper\n-###### b) Footer element must have class 'actions'\n-###### c) Specify options for [ember-perfectscroll](https://www.npmjs.com/package/ember-perfectscroll) helper such as wheelSpeed, minScrollbarLength, etc.\n-\n-For more documentation on options: ember-perfectscroll uses [perfect-scrollbar](https://github.com/noraesae/perfect-scrollbar)\n-\n+#### Component template using ember-block-slots\n Below is an example of template.hbs\n ```handlebars\n-{{#frost-modal-input title='Test title' subtitle='Subtitle'}}\n-{{!#frost-modal-input titleComponent='myTitle'}}\n-\n-  {{#perfect-scroll\n-    wheelSpeed=2\n-    minScrollbarLength=20\n-    maxScrollbarLength=150\n-  }}\n-  {{frost-bunsen-form\n+{{#frost-modal-input\n+  title='Test title'\n+  subtitle='Subtitle'\n+  modalName=modalName as |slot|}}\n+  {{#block-slot slot 'openButton' as |item|}}","path":"README.md","position":140,"original_position":140,"commit_id":"4379d33380e518302998bbfb6f2f418eb0de47b3","original_commit_id":"4379d33380e518302998bbfb6f2f418eb0de47b3","user":{"login":"rox163","id":313318,"avatar_url":"https://avatars.githubusercontent.com/u/313318?v=3","gravatar_id":"","url":"https://api.github.com/users/rox163","html_url":"https://github.com/rox163","followers_url":"https://api.github.com/users/rox163/followers","following_url":"https://api.github.com/users/rox163/following{/other_user}","gists_url":"https://api.github.com/users/rox163/gists{/gist_id}","starred_url":"https://api.github.com/users/rox163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rox163/subscriptions","organizations_url":"https://api.github.com/users/rox163/orgs","repos_url":"https://api.github.com/users/rox163/repos","events_url":"https://api.github.com/users/rox163/events{/privacy}","received_events_url":"https://api.github.com/users/rox163/received_events","type":"User","site_admin":false},"body":"Yeah I suppose we should support any kind of launch element, not just a button. ","created_at":"2016-05-20T16:03:52Z","updated_at":"2016-05-20T16:03:52Z","html_url":"https://github.com/ciena-frost/ember-frost-modal-input/pull/23#discussion_r64065698","pull_request_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/comments/64065698"},"html":{"href":"https://github.com/ciena-frost/ember-frost-modal-input/pull/23#discussion_r64065698"},"pull_request":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23","id":70551311,"html_url":"https://github.com/ciena-frost/ember-frost-modal-input/pull/23","diff_url":"https://github.com/ciena-frost/ember-frost-modal-input/pull/23.diff","patch_url":"https://github.com/ciena-frost/ember-frost-modal-input/pull/23.patch","issue_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/issues/23","number":23,"state":"open","locked":false,"title":"Use ember-remodal to simplify modal use","user":{"login":"rox163","id":313318,"avatar_url":"https://avatars.githubusercontent.com/u/313318?v=3","gravatar_id":"","url":"https://api.github.com/users/rox163","html_url":"https://github.com/rox163","followers_url":"https://api.github.com/users/rox163/followers","following_url":"https://api.github.com/users/rox163/following{/other_user}","gists_url":"https://api.github.com/users/rox163/gists{/gist_id}","starred_url":"https://api.github.com/users/rox163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rox163/subscriptions","organizations_url":"https://api.github.com/users/rox163/orgs","repos_url":"https://api.github.com/users/rox163/repos","events_url":"https://api.github.com/users/rox163/events{/privacy}","received_events_url":"https://api.github.com/users/rox163/received_events","type":"User","site_admin":false},"body":"#major#\r\n# CHANGELOG\r\n## Changed\r\n\r\n- BREAKING Using [ember-remodal](http://sethbrasile.github.io/ember-remodal/) addon to simplify modal dialog support. Additional modal-input template options required\r\n\r\n## Removed\r\n\r\n- BREAKING Removed liquid-fire modal code. Removed transitions and unneeded router config","created_at":"2016-05-18T15:40:49Z","updated_at":"2016-05-20T16:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6db74f700c99ff5e09f3dca2fd59f9787b6701bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23/commits","review_comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23/comments","review_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/issues/23/comments","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/statuses/4379d33380e518302998bbfb6f2f418eb0de47b3","head":{"label":"rox163:use-remodal","ref":"use-remodal","sha":"4379d33380e518302998bbfb6f2f418eb0de47b3","user":{"login":"rox163","id":313318,"avatar_url":"https://avatars.githubusercontent.com/u/313318?v=3","gravatar_id":"","url":"https://api.github.com/users/rox163","html_url":"https://github.com/rox163","followers_url":"https://api.github.com/users/rox163/followers","following_url":"https://api.github.com/users/rox163/following{/other_user}","gists_url":"https://api.github.com/users/rox163/gists{/gist_id}","starred_url":"https://api.github.com/users/rox163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rox163/subscriptions","organizations_url":"https://api.github.com/users/rox163/orgs","repos_url":"https://api.github.com/users/rox163/repos","events_url":"https://api.github.com/users/rox163/events{/privacy}","received_events_url":"https://api.github.com/users/rox163/received_events","type":"User","site_admin":false},"repo":{"id":52376432,"name":"ember-frost-modal-input","full_name":"rox163/ember-frost-modal-input","owner":{"login":"rox163","id":313318,"avatar_url":"https://avatars.githubusercontent.com/u/313318?v=3","gravatar_id":"","url":"https://api.github.com/users/rox163","html_url":"https://github.com/rox163","followers_url":"https://api.github.com/users/rox163/followers","following_url":"https://api.github.com/users/rox163/following{/other_user}","gists_url":"https://api.github.com/users/rox163/gists{/gist_id}","starred_url":"https://api.github.com/users/rox163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rox163/subscriptions","organizations_url":"https://api.github.com/users/rox163/orgs","repos_url":"https://api.github.com/users/rox163/repos","events_url":"https://api.github.com/users/rox163/events{/privacy}","received_events_url":"https://api.github.com/users/rox163/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rox163/ember-frost-modal-input","description":"","fork":true,"url":"https://api.github.com/repos/rox163/ember-frost-modal-input","forks_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/forks","keys_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/teams","hooks_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/hooks","issue_events_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/issues/events{/number}","events_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/events","assignees_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/assignees{/user}","branches_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/branches{/branch}","tags_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/tags","blobs_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/statuses/{sha}","languages_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/languages","stargazers_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/stargazers","contributors_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/contributors","subscribers_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/subscribers","subscription_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/subscription","commits_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/contents/{+path}","compare_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/merges","archive_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/downloads","issues_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/issues{/number}","pulls_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/pulls{/number}","milestones_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/milestones{/number}","notifications_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/labels{/name}","releases_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/releases{/id}","deployments_url":"https://api.github.com/repos/rox163/ember-frost-modal-input/deployments","created_at":"2016-02-23T17:06:36Z","updated_at":"2016-02-23T17:06:37Z","pushed_at":"2016-05-19T18:11:43Z","git_url":"git://github.com/rox163/ember-frost-modal-input.git","ssh_url":"git@github.com:rox163/ember-frost-modal-input.git","clone_url":"https://github.com/rox163/ember-frost-modal-input.git","svn_url":"https://github.com/rox163/ember-frost-modal-input","homepage":null,"size":134,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciena-frost:master","ref":"master","sha":"9279d59a92bd2b11a0f68d22b3daacce0550cdcb","user":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"repo":{"id":52375542,"name":"ember-frost-modal-input","full_name":"ciena-frost/ember-frost-modal-input","owner":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciena-frost/ember-frost-modal-input","description":"A modal container for forms/input components","fork":false,"url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input","forks_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/forks","keys_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/teams","hooks_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/hooks","issue_events_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/issues/events{/number}","events_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/events","assignees_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/assignees{/user}","branches_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/branches{/branch}","tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/tags","blobs_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/statuses/{sha}","languages_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/languages","stargazers_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/stargazers","contributors_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/contributors","subscribers_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/subscribers","subscription_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/subscription","commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/contents/{+path}","compare_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/merges","archive_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/downloads","issues_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/issues{/number}","pulls_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls{/number}","milestones_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/milestones{/number}","notifications_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/labels{/name}","releases_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/releases{/id}","deployments_url":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/deployments","created_at":"2016-02-23T16:54:28Z","updated_at":"2016-04-07T18:14:08Z","pushed_at":"2016-05-19T18:11:43Z","git_url":"git://github.com/ciena-frost/ember-frost-modal-input.git","ssh_url":"git@github.com:ciena-frost/ember-frost-modal-input.git","clone_url":"https://github.com/ciena-frost/ember-frost-modal-input.git","svn_url":"https://github.com/ciena-frost/ember-frost-modal-input","homepage":"http://ciena-frost.github.io/ember-frost-modal-input/ ","size":4391,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23"},"html":{"href":"https://github.com/ciena-frost/ember-frost-modal-input/pull/23"},"issue":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/issues/23"},"comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-modal-input/statuses/4379d33380e518302998bbfb6f2f418eb0de47b3"}}}}
{"actor":{"display_login":"rox163"}}