{"action":"created","comment":{"url":"https://api.github.com/repos/hanami/hanami/pulls/comments/53151948","id":53151948,"diff_hunk":"@@ -461,7 +459,7 @@ def set_hanami_env_vars!\n     # @since 0.2.0\n     # @api private\n     def set_application_env_vars!\n-      Dotenv.load     root.join(DEFAULT_DOTENV)\n+      return unless defined?(Dotenv)\n       Dotenv.overload root.join(DEFAULT_DOTENV_ENV % environment)","path":"lib/hanami/environment.rb","position":35,"original_position":35,"commit_id":"7004d58d151d2162d235bd52bbf413d225afb541","original_commit_id":"7004d58d151d2162d235bd52bbf413d225afb541","user":{"login":"aderyabin","id":88676,"avatar_url":"https://avatars.githubusercontent.com/u/88676?v=3","gravatar_id":"","url":"https://api.github.com/users/aderyabin","html_url":"https://github.com/aderyabin","followers_url":"https://api.github.com/users/aderyabin/followers","following_url":"https://api.github.com/users/aderyabin/following{/other_user}","gists_url":"https://api.github.com/users/aderyabin/gists{/gist_id}","starred_url":"https://api.github.com/users/aderyabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aderyabin/subscriptions","organizations_url":"https://api.github.com/users/aderyabin/orgs","repos_url":"https://api.github.com/users/aderyabin/repos","events_url":"https://api.github.com/users/aderyabin/events{/privacy}","received_events_url":"https://api.github.com/users/aderyabin/received_events","type":"User","site_admin":false},"body":"@jodosha \r\n`#load` and `#overload` has only one difference `#load` uses `#apply` and `#overload` uses `#apply!` [proof link](https://github.com/bkeepers/dotenv/blob/c44af19abeb12240995358fb350c1dab42d3c0fe/lib/dotenv/environment.rb#L20-L26)\r\n\r\n```\r\n    def apply\r\n      each { |k, v| ENV[k] ||= v }\r\n    end\r\n\r\n    def apply!\r\n      each { |k, v| ENV[k] = v }\r\n    end\r\n```\r\n\r\nSo have to use `#overload` because if the variable exists it should be overrided.","created_at":"2016-02-17T11:33:23Z","updated_at":"2016-02-17T11:33:23Z","html_url":"https://github.com/hanami/hanami/pull/518#discussion_r53151948","pull_request_url":"https://api.github.com/repos/hanami/hanami/pulls/518","_links":{"self":{"href":"https://api.github.com/repos/hanami/hanami/pulls/comments/53151948"},"html":{"href":"https://github.com/hanami/hanami/pull/518#discussion_r53151948"},"pull_request":{"href":"https://api.github.com/repos/hanami/hanami/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/hanami/hanami/pulls/518","id":59549854,"html_url":"https://github.com/hanami/hanami/pull/518","diff_url":"https://github.com/hanami/hanami/pull/518.diff","patch_url":"https://github.com/hanami/hanami/pull/518.patch","issue_url":"https://api.github.com/repos/hanami/hanami/issues/518","number":518,"state":"open","locked":false,"title":"Make Dotenv a soft dependency","user":{"login":"aderyabin","id":88676,"avatar_url":"https://avatars.githubusercontent.com/u/88676?v=3","gravatar_id":"","url":"https://api.github.com/users/aderyabin","html_url":"https://github.com/aderyabin","followers_url":"https://api.github.com/users/aderyabin/followers","following_url":"https://api.github.com/users/aderyabin/following{/other_user}","gists_url":"https://api.github.com/users/aderyabin/gists{/gist_id}","starred_url":"https://api.github.com/users/aderyabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aderyabin/subscriptions","organizations_url":"https://api.github.com/users/aderyabin/orgs","repos_url":"https://api.github.com/users/aderyabin/repos","events_url":"https://api.github.com/users/aderyabin/events{/privacy}","received_events_url":"https://api.github.com/users/aderyabin/received_events","type":"User","site_admin":false},"body":"Closes #516. I'm open for discussion.\r\n// cc @jodosha ","created_at":"2016-02-16T20:33:33Z","updated_at":"2016-02-17T11:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34b45ef1860bb57b11c44a7b7b37e0ff3ba0a9a9","assignee":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hanami/hanami/milestones/12","html_url":"https://github.com/hanami/hanami/milestones/v0.8.0","labels_url":"https://api.github.com/repos/hanami/hanami/milestones/12/labels","id":1543738,"number":12,"title":"v0.8.0","description":"","creator":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":12,"state":"open","created_at":"2016-01-26T09:37:50Z","updated_at":"2016-02-17T08:22:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hanami/hanami/pulls/518/commits","review_comments_url":"https://api.github.com/repos/hanami/hanami/pulls/518/comments","review_comment_url":"https://api.github.com/repos/hanami/hanami/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hanami/hanami/issues/518/comments","statuses_url":"https://api.github.com/repos/hanami/hanami/statuses/7004d58d151d2162d235bd52bbf413d225afb541","head":{"label":"aderyabin:dotenv","ref":"dotenv","sha":"7004d58d151d2162d235bd52bbf413d225afb541","user":{"login":"aderyabin","id":88676,"avatar_url":"https://avatars.githubusercontent.com/u/88676?v=3","gravatar_id":"","url":"https://api.github.com/users/aderyabin","html_url":"https://github.com/aderyabin","followers_url":"https://api.github.com/users/aderyabin/followers","following_url":"https://api.github.com/users/aderyabin/following{/other_user}","gists_url":"https://api.github.com/users/aderyabin/gists{/gist_id}","starred_url":"https://api.github.com/users/aderyabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aderyabin/subscriptions","organizations_url":"https://api.github.com/users/aderyabin/orgs","repos_url":"https://api.github.com/users/aderyabin/repos","events_url":"https://api.github.com/users/aderyabin/events{/privacy}","received_events_url":"https://api.github.com/users/aderyabin/received_events","type":"User","site_admin":false},"repo":{"id":51752026,"name":"hanami","full_name":"aderyabin/hanami","owner":{"login":"aderyabin","id":88676,"avatar_url":"https://avatars.githubusercontent.com/u/88676?v=3","gravatar_id":"","url":"https://api.github.com/users/aderyabin","html_url":"https://github.com/aderyabin","followers_url":"https://api.github.com/users/aderyabin/followers","following_url":"https://api.github.com/users/aderyabin/following{/other_user}","gists_url":"https://api.github.com/users/aderyabin/gists{/gist_id}","starred_url":"https://api.github.com/users/aderyabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aderyabin/subscriptions","organizations_url":"https://api.github.com/users/aderyabin/orgs","repos_url":"https://api.github.com/users/aderyabin/repos","events_url":"https://api.github.com/users/aderyabin/events{/privacy}","received_events_url":"https://api.github.com/users/aderyabin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aderyabin/hanami","description":"The web, with simplicity.","fork":true,"url":"https://api.github.com/repos/aderyabin/hanami","forks_url":"https://api.github.com/repos/aderyabin/hanami/forks","keys_url":"https://api.github.com/repos/aderyabin/hanami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aderyabin/hanami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aderyabin/hanami/teams","hooks_url":"https://api.github.com/repos/aderyabin/hanami/hooks","issue_events_url":"https://api.github.com/repos/aderyabin/hanami/issues/events{/number}","events_url":"https://api.github.com/repos/aderyabin/hanami/events","assignees_url":"https://api.github.com/repos/aderyabin/hanami/assignees{/user}","branches_url":"https://api.github.com/repos/aderyabin/hanami/branches{/branch}","tags_url":"https://api.github.com/repos/aderyabin/hanami/tags","blobs_url":"https://api.github.com/repos/aderyabin/hanami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aderyabin/hanami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aderyabin/hanami/git/refs{/sha}","trees_url":"https://api.github.com/repos/aderyabin/hanami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aderyabin/hanami/statuses/{sha}","languages_url":"https://api.github.com/repos/aderyabin/hanami/languages","stargazers_url":"https://api.github.com/repos/aderyabin/hanami/stargazers","contributors_url":"https://api.github.com/repos/aderyabin/hanami/contributors","subscribers_url":"https://api.github.com/repos/aderyabin/hanami/subscribers","subscription_url":"https://api.github.com/repos/aderyabin/hanami/subscription","commits_url":"https://api.github.com/repos/aderyabin/hanami/commits{/sha}","git_commits_url":"https://api.github.com/repos/aderyabin/hanami/git/commits{/sha}","comments_url":"https://api.github.com/repos/aderyabin/hanami/comments{/number}","issue_comment_url":"https://api.github.com/repos/aderyabin/hanami/issues/comments{/number}","contents_url":"https://api.github.com/repos/aderyabin/hanami/contents/{+path}","compare_url":"https://api.github.com/repos/aderyabin/hanami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aderyabin/hanami/merges","archive_url":"https://api.github.com/repos/aderyabin/hanami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aderyabin/hanami/downloads","issues_url":"https://api.github.com/repos/aderyabin/hanami/issues{/number}","pulls_url":"https://api.github.com/repos/aderyabin/hanami/pulls{/number}","milestones_url":"https://api.github.com/repos/aderyabin/hanami/milestones{/number}","notifications_url":"https://api.github.com/repos/aderyabin/hanami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aderyabin/hanami/labels{/name}","releases_url":"https://api.github.com/repos/aderyabin/hanami/releases{/id}","deployments_url":"https://api.github.com/repos/aderyabin/hanami/deployments","created_at":"2016-02-15T11:48:44Z","updated_at":"2016-02-15T11:48:45Z","pushed_at":"2016-02-16T20:31:43Z","git_url":"git://github.com/aderyabin/hanami.git","ssh_url":"git@github.com:aderyabin/hanami.git","clone_url":"https://github.com/aderyabin/hanami.git","svn_url":"https://github.com/aderyabin/hanami","homepage":"http://hanamirb.org","size":1516,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hanami:master","ref":"master","sha":"f2881cf789755fe3000948de9ffdab8b1af147cb","user":{"login":"hanami","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/hanami","html_url":"https://github.com/hanami","followers_url":"https://api.github.com/users/hanami/followers","following_url":"https://api.github.com/users/hanami/following{/other_user}","gists_url":"https://api.github.com/users/hanami/gists{/gist_id}","starred_url":"https://api.github.com/users/hanami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanami/subscriptions","organizations_url":"https://api.github.com/users/hanami/orgs","repos_url":"https://api.github.com/users/hanami/repos","events_url":"https://api.github.com/users/hanami/events{/privacy}","received_events_url":"https://api.github.com/users/hanami/received_events","type":"Organization","site_admin":false},"repo":{"id":12004006,"name":"hanami","full_name":"hanami/hanami","owner":{"login":"hanami","id":3210273,"avatar_url":"https://avatars.githubusercontent.com/u/3210273?v=3","gravatar_id":"","url":"https://api.github.com/users/hanami","html_url":"https://github.com/hanami","followers_url":"https://api.github.com/users/hanami/followers","following_url":"https://api.github.com/users/hanami/following{/other_user}","gists_url":"https://api.github.com/users/hanami/gists{/gist_id}","starred_url":"https://api.github.com/users/hanami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanami/subscriptions","organizations_url":"https://api.github.com/users/hanami/orgs","repos_url":"https://api.github.com/users/hanami/repos","events_url":"https://api.github.com/users/hanami/events{/privacy}","received_events_url":"https://api.github.com/users/hanami/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hanami/hanami","description":"The web, with simplicity.","fork":false,"url":"https://api.github.com/repos/hanami/hanami","forks_url":"https://api.github.com/repos/hanami/hanami/forks","keys_url":"https://api.github.com/repos/hanami/hanami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanami/hanami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanami/hanami/teams","hooks_url":"https://api.github.com/repos/hanami/hanami/hooks","issue_events_url":"https://api.github.com/repos/hanami/hanami/issues/events{/number}","events_url":"https://api.github.com/repos/hanami/hanami/events","assignees_url":"https://api.github.com/repos/hanami/hanami/assignees{/user}","branches_url":"https://api.github.com/repos/hanami/hanami/branches{/branch}","tags_url":"https://api.github.com/repos/hanami/hanami/tags","blobs_url":"https://api.github.com/repos/hanami/hanami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanami/hanami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanami/hanami/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanami/hanami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanami/hanami/statuses/{sha}","languages_url":"https://api.github.com/repos/hanami/hanami/languages","stargazers_url":"https://api.github.com/repos/hanami/hanami/stargazers","contributors_url":"https://api.github.com/repos/hanami/hanami/contributors","subscribers_url":"https://api.github.com/repos/hanami/hanami/subscribers","subscription_url":"https://api.github.com/repos/hanami/hanami/subscription","commits_url":"https://api.github.com/repos/hanami/hanami/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanami/hanami/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanami/hanami/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanami/hanami/issues/comments{/number}","contents_url":"https://api.github.com/repos/hanami/hanami/contents/{+path}","compare_url":"https://api.github.com/repos/hanami/hanami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanami/hanami/merges","archive_url":"https://api.github.com/repos/hanami/hanami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanami/hanami/downloads","issues_url":"https://api.github.com/repos/hanami/hanami/issues{/number}","pulls_url":"https://api.github.com/repos/hanami/hanami/pulls{/number}","milestones_url":"https://api.github.com/repos/hanami/hanami/milestones{/number}","notifications_url":"https://api.github.com/repos/hanami/hanami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanami/hanami/labels{/name}","releases_url":"https://api.github.com/repos/hanami/hanami/releases{/id}","deployments_url":"https://api.github.com/repos/hanami/hanami/deployments","created_at":"2013-08-09T15:24:44Z","updated_at":"2016-02-16T23:12:15Z","pushed_at":"2016-02-16T22:45:57Z","git_url":"git://github.com/hanami/hanami.git","ssh_url":"git@github.com:hanami/hanami.git","clone_url":"https://github.com/hanami/hanami.git","svn_url":"https://github.com/hanami/hanami","homepage":"http://hanamirb.org","size":2119,"stargazers_count":2542,"watchers_count":2542,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"open_issues_count":24,"forks":260,"open_issues":24,"watchers":2542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hanami/hanami/pulls/518"},"html":{"href":"https://github.com/hanami/hanami/pull/518"},"issue":{"href":"https://api.github.com/repos/hanami/hanami/issues/518"},"comments":{"href":"https://api.github.com/repos/hanami/hanami/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/hanami/hanami/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/hanami/hanami/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hanami/hanami/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/hanami/hanami/statuses/7004d58d151d2162d235bd52bbf413d225afb541"}}}}