{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments/80413685","id":80413685,"diff_hunk":"@@ -0,0 +1,12 @@\n+import Ember from 'ember';\n+\n+export default Ember.Component.extend({\n+  actions: {\n+    setIsClosed() {","path":"app/components/warning-message.js","position":5,"original_position":5,"commit_id":"b41648b19d1d47a5aea4ce92dbf0c47b25c29dfc","original_commit_id":"b41648b19d1d47a5aea4ce92dbf0c47b25c29dfc","user":{"login":"locks","id":32344,"avatar_url":"https://avatars.githubusercontent.com/u/32344?v=3","gravatar_id":"","url":"https://api.github.com/users/locks","html_url":"https://github.com/locks","followers_url":"https://api.github.com/users/locks/followers","following_url":"https://api.github.com/users/locks/following{/other_user}","gists_url":"https://api.github.com/users/locks/gists{/gist_id}","starred_url":"https://api.github.com/users/locks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locks/subscriptions","organizations_url":"https://api.github.com/users/locks/orgs","repos_url":"https://api.github.com/users/locks/repos","events_url":"https://api.github.com/users/locks/events{/privacy}","received_events_url":"https://api.github.com/users/locks/received_events","type":"User","site_admin":false},"body":"You are manually manipulating the DOM in this action handler, which isn't a good practice in Ember. This is because Ember expects to control the DOM, and when you manually mutate it, the state of the DOM gets out of sync with what Ember thinks it is.\r\nYou already have the `isClosed` property in the controller, and are conditionally wrapping the warning-message on it, you should fully utilize it.","created_at":"2016-09-26T06:28:38Z","updated_at":"2016-09-26T06:32:30Z","html_url":"https://github.com/emberjs/ember-inspector/pull/601#discussion_r80413685","pull_request_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments/80413685"},"html":{"href":"https://github.com/emberjs/ember-inspector/pull/601#discussion_r80413685"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601","id":86619239,"html_url":"https://github.com/emberjs/ember-inspector/pull/601","diff_url":"https://github.com/emberjs/ember-inspector/pull/601.diff","patch_url":"https://github.com/emberjs/ember-inspector/pull/601.patch","issue_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/601","number":601,"state":"open","locked":false,"title":"feat(warning-msg): adds a warning message on Render pane.","user":{"login":"arjunkathuria","id":12858057,"avatar_url":"https://avatars.githubusercontent.com/u/12858057?v=3","gravatar_id":"","url":"https://api.github.com/users/arjunkathuria","html_url":"https://github.com/arjunkathuria","followers_url":"https://api.github.com/users/arjunkathuria/followers","following_url":"https://api.github.com/users/arjunkathuria/following{/other_user}","gists_url":"https://api.github.com/users/arjunkathuria/gists{/gist_id}","starred_url":"https://api.github.com/users/arjunkathuria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjunkathuria/subscriptions","organizations_url":"https://api.github.com/users/arjunkathuria/orgs","repos_url":"https://api.github.com/users/arjunkathuria/repos","events_url":"https://api.github.com/users/arjunkathuria/events{/privacy}","received_events_url":"https://api.github.com/users/arjunkathuria/received_events","type":"User","site_admin":false},"body":"PR for issue #249 \r\nAdds a warning message atop the render pane for the view timings being inaccurate due to overhead and environment.\r\n\r\n- [ ] Chrome\r\n- [ ] Firefox\r\n- [ ] Bookmarklet (?)\r\n\r\ncc:- @locks @teddyzeenny \r\n\r\nissue:- works fine on chrome, while on firefox, when pressing X, the warning doesn't instantly goes away like its designed to and does in chrome but needs a refresh. is it a Firefox xpi thing?","created_at":"2016-09-24T14:17:37Z","updated_at":"2016-09-26T06:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81fac8d2bb505d2e1117fce2b996b5c8cd5a5048","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/601/comments","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/b41648b19d1d47a5aea4ce92dbf0c47b25c29dfc","head":{"label":"arjunkathuria:dev","ref":"dev","sha":"b41648b19d1d47a5aea4ce92dbf0c47b25c29dfc","user":{"login":"arjunkathuria","id":12858057,"avatar_url":"https://avatars.githubusercontent.com/u/12858057?v=3","gravatar_id":"","url":"https://api.github.com/users/arjunkathuria","html_url":"https://github.com/arjunkathuria","followers_url":"https://api.github.com/users/arjunkathuria/followers","following_url":"https://api.github.com/users/arjunkathuria/following{/other_user}","gists_url":"https://api.github.com/users/arjunkathuria/gists{/gist_id}","starred_url":"https://api.github.com/users/arjunkathuria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjunkathuria/subscriptions","organizations_url":"https://api.github.com/users/arjunkathuria/orgs","repos_url":"https://api.github.com/users/arjunkathuria/repos","events_url":"https://api.github.com/users/arjunkathuria/events{/privacy}","received_events_url":"https://api.github.com/users/arjunkathuria/received_events","type":"User","site_admin":false},"repo":{"id":68741223,"name":"ember-inspector","full_name":"arjunkathuria/ember-inspector","owner":{"login":"arjunkathuria","id":12858057,"avatar_url":"https://avatars.githubusercontent.com/u/12858057?v=3","gravatar_id":"","url":"https://api.github.com/users/arjunkathuria","html_url":"https://github.com/arjunkathuria","followers_url":"https://api.github.com/users/arjunkathuria/followers","following_url":"https://api.github.com/users/arjunkathuria/following{/other_user}","gists_url":"https://api.github.com/users/arjunkathuria/gists{/gist_id}","starred_url":"https://api.github.com/users/arjunkathuria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjunkathuria/subscriptions","organizations_url":"https://api.github.com/users/arjunkathuria/orgs","repos_url":"https://api.github.com/users/arjunkathuria/repos","events_url":"https://api.github.com/users/arjunkathuria/events{/privacy}","received_events_url":"https://api.github.com/users/arjunkathuria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arjunkathuria/ember-inspector","description":null,"fork":true,"url":"https://api.github.com/repos/arjunkathuria/ember-inspector","forks_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/forks","keys_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/teams","hooks_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/events","assignees_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/tags","blobs_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/subscription","commits_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/merges","archive_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/downloads","issues_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/releases{/id}","deployments_url":"https://api.github.com/repos/arjunkathuria/ember-inspector/deployments","created_at":"2016-09-20T18:26:49Z","updated_at":"2016-09-20T18:26:51Z","pushed_at":"2016-09-24T14:05:03Z","git_url":"git://github.com/arjunkathuria/ember-inspector.git","ssh_url":"git@github.com:arjunkathuria/ember-inspector.git","clone_url":"https://github.com/arjunkathuria/ember-inspector.git","svn_url":"https://github.com/arjunkathuria/ember-inspector","homepage":null,"size":3713,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"679643037032fab3e4388a8dcb8cd0f20d1cc660","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7876204,"name":"ember-inspector","full_name":"emberjs/ember-inspector","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-inspector","description":"","fork":false,"url":"https://api.github.com/repos/emberjs/ember-inspector","forks_url":"https://api.github.com/repos/emberjs/ember-inspector/forks","keys_url":"https://api.github.com/repos/emberjs/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-inspector/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-inspector/events","assignees_url":"https://api.github.com/repos/emberjs/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-inspector/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-inspector/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-inspector/merges","archive_url":"https://api.github.com/repos/emberjs/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-inspector/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-inspector/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember-inspector/deployments","created_at":"2013-01-28T18:36:15Z","updated_at":"2016-09-25T18:18:22Z","pushed_at":"2016-09-24T14:17:37Z","git_url":"git://github.com/emberjs/ember-inspector.git","ssh_url":"git@github.com:emberjs/ember-inspector.git","clone_url":"https://github.com/emberjs/ember-inspector.git","svn_url":"https://github.com/emberjs/ember-inspector","homepage":null,"size":3990,"stargazers_count":786,"watchers_count":786,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":82,"forks":175,"open_issues":82,"watchers":786,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601"},"html":{"href":"https://github.com/emberjs/ember-inspector/pull/601"},"issue":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/601"},"comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember-inspector/statuses/b41648b19d1d47a5aea4ce92dbf0c47b25c29dfc"}}}}
{"actor":{"display_login":"locks"}}