{"action":"created","issue":{"url":"https://api.github.com/repos/RadicalFx/Radical.Windows/issues/46","repository_url":"https://api.github.com/repos/RadicalFx/Radical.Windows","labels_url":"https://api.github.com/repos/RadicalFx/Radical.Windows/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/RadicalFx/Radical.Windows/issues/46/comments","events_url":"https://api.github.com/repos/RadicalFx/Radical.Windows/issues/46/events","html_url":"https://github.com/RadicalFx/Radical.Windows/pull/46","id":149858099,"number":46,"title":"Release/1.5.0","user":{"login":"mauroservienti","id":1325611,"avatar_url":"https://avatars.githubusercontent.com/u/1325611?v=3","gravatar_id":"","url":"https://api.github.com/users/mauroservienti","html_url":"https://github.com/mauroservienti","followers_url":"https://api.github.com/users/mauroservienti/followers","following_url":"https://api.github.com/users/mauroservienti/following{/other_user}","gists_url":"https://api.github.com/users/mauroservienti/gists{/gist_id}","starred_url":"https://api.github.com/users/mauroservienti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauroservienti/subscriptions","organizations_url":"https://api.github.com/users/mauroservienti/orgs","repos_url":"https://api.github.com/users/mauroservienti/repos","events_url":"https://api.github.com/users/mauroservienti/events{/privacy}","received_events_url":"https://api.github.com/users/mauroservienti/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RadicalFx/Radical.Windows/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"micdenny","id":1633595,"avatar_url":"https://avatars.githubusercontent.com/u/1633595?v=3","gravatar_id":"","url":"https://api.github.com/users/micdenny","html_url":"https://github.com/micdenny","followers_url":"https://api.github.com/users/micdenny/followers","following_url":"https://api.github.com/users/micdenny/following{/other_user}","gists_url":"https://api.github.com/users/micdenny/gists{/gist_id}","starred_url":"https://api.github.com/users/micdenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micdenny/subscriptions","organizations_url":"https://api.github.com/users/micdenny/orgs","repos_url":"https://api.github.com/users/micdenny/repos","events_url":"https://api.github.com/users/micdenny/events{/privacy}","received_events_url":"https://api.github.com/users/micdenny/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-04-20T19:08:15Z","updated_at":"2016-04-22T08:12:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RadicalFx/Radical.Windows/pulls/46","html_url":"https://github.com/RadicalFx/Radical.Windows/pull/46","diff_url":"https://github.com/RadicalFx/Radical.Windows/pull/46.diff","patch_url":"https://github.com/RadicalFx/Radical.Windows/pull/46.patch"},"body":"@micdenny please review and merge if good\r\nConnected to https://github.com/RadicalFx/housekeeping/issues/57\r\n\r\nQuestion: once this is merged should we:\r\n\r\n* reverse merge from `master` to `develop`?\r\n* rebase `develop` on `master`?\r\n* merge this release branch to `develop` as well?"},"comment":{"url":"https://api.github.com/repos/RadicalFx/Radical.Windows/issues/comments/213316584","html_url":"https://github.com/RadicalFx/Radical.Windows/pull/46#issuecomment-213316584","issue_url":"https://api.github.com/repos/RadicalFx/Radical.Windows/issues/46","id":213316584,"user":{"login":"micdenny","id":1633595,"avatar_url":"https://avatars.githubusercontent.com/u/1633595?v=3","gravatar_id":"","url":"https://api.github.com/users/micdenny","html_url":"https://github.com/micdenny","followers_url":"https://api.github.com/users/micdenny/followers","following_url":"https://api.github.com/users/micdenny/following{/other_user}","gists_url":"https://api.github.com/users/micdenny/gists{/gist_id}","starred_url":"https://api.github.com/users/micdenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micdenny/subscriptions","organizations_url":"https://api.github.com/users/micdenny/orgs","repos_url":"https://api.github.com/users/micdenny/repos","events_url":"https://api.github.com/users/micdenny/events{/privacy}","received_events_url":"https://api.github.com/users/micdenny/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T08:12:18Z","updated_at":"2016-04-22T08:12:18Z","body":"> reverse merge from master to develop?\r\n> rebase develop on master?\r\n\r\nfor sure a reverse merge that force a merge commit would be a shame and useless, so at least a merge without a PR that end-up in a fast-forward merge with no additional commit, or like you said a rebase, that actually is the same in case of ff merge.\r\n\r\n> merge this release branch to develop as well?\r\n\r\nis the same as merging from master unless in the meanwhile there were another commit in master, but anyway develop must be always aligned to master, so merge always everything from master to develop is a good way.\r\n\r\nAnother idea could be to avoid PR for releasing, just merge from git and gitversion will do the rest tagging the source, in this way you don't need a reverse merge at all, the history then is simply the same with an additional tag after the build, but in the history could be good to have a clear sign of the release.... what do you think? what others do?"}}