{"action":"created","comment":{"url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/comments/90359865","pull_request_review_id":10879810,"id":90359865,"diff_hunk":"@@ -17,8 +17,10 @@\n \n #= Campaign model\n class Campaign < ActiveRecord::Base\n-  has_many :campaigns_courses, class_name: CampaignsCourses\n+  has_many :campaigns_courses, class_name: CampaignsCourses, dependent: :destroy\n+  has_many :campaigns_users, class_name: CampaignsUsers, dependent: :destroy\n   has_many :courses, through: :campaigns_courses\n+  has_many :users, -> { distinct }, through: :campaigns_users","path":"app/models/campaign.rb","position":8,"original_position":8,"commit_id":"6b8c80bc069c4c8ef2799dbb5e36d7fdc23466cc","original_commit_id":"1ec68d05510d995bc66649c0559fe6d5e93ce2f9","user":{"login":"ragesoss","id":848483,"avatar_url":"https://avatars.githubusercontent.com/u/848483?v=3","gravatar_id":"","url":"https://api.github.com/users/ragesoss","html_url":"https://github.com/ragesoss","followers_url":"https://api.github.com/users/ragesoss/followers","following_url":"https://api.github.com/users/ragesoss/following{/other_user}","gists_url":"https://api.github.com/users/ragesoss/gists{/gist_id}","starred_url":"https://api.github.com/users/ragesoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragesoss/subscriptions","organizations_url":"https://api.github.com/users/ragesoss/orgs","repos_url":"https://api.github.com/users/ragesoss/repos","events_url":"https://api.github.com/users/ragesoss/events{/privacy}","received_events_url":"https://api.github.com/users/ragesoss/received_events","type":"User","site_admin":false},"body":"I think 'users' is a dangerous name for this. If I weren't looking at the definition, I would assume it scopes all the users in all the courses, rather than just the organizers of the campaign itself.\r\n\r\nIf it's not going to be used at this point, we should leave it out entirely. If it is going to be used, let's name it 'campaign_managers' or something else that makes it clear that it's not going through courses.","created_at":"2016-12-01T00:22:28Z","updated_at":"2016-12-01T00:22:28Z","html_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1033#discussion_r90359865","pull_request_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033","_links":{"self":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/comments/90359865"},"html":{"href":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1033#discussion_r90359865"},"pull_request":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033"}}},"pull_request":{"url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033","id":94274492,"html_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1033","diff_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1033.diff","patch_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1033.patch","issue_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/1033","number":1033,"state":"open","locked":false,"title":"[WIP] Start on CampaignsUsers","user":{"login":"MusikAnimal","id":366374,"avatar_url":"https://avatars.githubusercontent.com/u/366374?v=3","gravatar_id":"","url":"https://api.github.com/users/MusikAnimal","html_url":"https://github.com/MusikAnimal","followers_url":"https://api.github.com/users/MusikAnimal/followers","following_url":"https://api.github.com/users/MusikAnimal/following{/other_user}","gists_url":"https://api.github.com/users/MusikAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikAnimal/subscriptions","organizations_url":"https://api.github.com/users/MusikAnimal/orgs","repos_url":"https://api.github.com/users/MusikAnimal/repos","events_url":"https://api.github.com/users/MusikAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/MusikAnimal/received_events","type":"User","site_admin":false},"body":"Bug: [T148804](https://phabricator.wikimedia.org/T148804)","created_at":"2016-11-17T23:34:09Z","updated_at":"2016-12-01T00:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87927ff704b43b73117ffecea9081e80187bb5c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033/commits","review_comments_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033/comments","review_comment_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/1033/comments","statuses_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/statuses/6b8c80bc069c4c8ef2799dbb5e36d7fdc23466cc","head":{"label":"MusikAnimal:campaigns-users","ref":"campaigns-users","sha":"6b8c80bc069c4c8ef2799dbb5e36d7fdc23466cc","user":{"login":"MusikAnimal","id":366374,"avatar_url":"https://avatars.githubusercontent.com/u/366374?v=3","gravatar_id":"","url":"https://api.github.com/users/MusikAnimal","html_url":"https://github.com/MusikAnimal","followers_url":"https://api.github.com/users/MusikAnimal/followers","following_url":"https://api.github.com/users/MusikAnimal/following{/other_user}","gists_url":"https://api.github.com/users/MusikAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikAnimal/subscriptions","organizations_url":"https://api.github.com/users/MusikAnimal/orgs","repos_url":"https://api.github.com/users/MusikAnimal/repos","events_url":"https://api.github.com/users/MusikAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/MusikAnimal/received_events","type":"User","site_admin":false},"repo":{"id":65228624,"name":"WikiEduDashboard","full_name":"MusikAnimal/WikiEduDashboard","owner":{"login":"MusikAnimal","id":366374,"avatar_url":"https://avatars.githubusercontent.com/u/366374?v=3","gravatar_id":"","url":"https://api.github.com/users/MusikAnimal","html_url":"https://github.com/MusikAnimal","followers_url":"https://api.github.com/users/MusikAnimal/followers","following_url":"https://api.github.com/users/MusikAnimal/following{/other_user}","gists_url":"https://api.github.com/users/MusikAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikAnimal/subscriptions","organizations_url":"https://api.github.com/users/MusikAnimal/orgs","repos_url":"https://api.github.com/users/MusikAnimal/repos","events_url":"https://api.github.com/users/MusikAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/MusikAnimal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MusikAnimal/WikiEduDashboard","description":"Wiki Education Foundation's Wikipedia course dashboard system","fork":true,"url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard","forks_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/forks","keys_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/teams","hooks_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/hooks","issue_events_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/issues/events{/number}","events_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/events","assignees_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/assignees{/user}","branches_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/branches{/branch}","tags_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/tags","blobs_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/languages","stargazers_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/stargazers","contributors_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/contributors","subscribers_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/subscribers","subscription_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/subscription","commits_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/contents/{+path}","compare_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/merges","archive_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/downloads","issues_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/issues{/number}","pulls_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/labels{/name}","releases_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/releases{/id}","deployments_url":"https://api.github.com/repos/MusikAnimal/WikiEduDashboard/deployments","created_at":"2016-08-08T18:26:08Z","updated_at":"2016-08-08T18:26:11Z","pushed_at":"2016-12-01T00:16:47Z","git_url":"git://github.com/MusikAnimal/WikiEduDashboard.git","ssh_url":"git@github.com:MusikAnimal/WikiEduDashboard.git","clone_url":"https://github.com/MusikAnimal/WikiEduDashboard.git","svn_url":"https://github.com/MusikAnimal/WikiEduDashboard","homepage":"https://dashboard.wikiedu.org","size":59920,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WikiEducationFoundation:master","ref":"master","sha":"1b092f59a521b9d0df108b9c1447da36eb77b861","user":{"login":"WikiEducationFoundation","id":9489865,"avatar_url":"https://avatars.githubusercontent.com/u/9489865?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiEducationFoundation","html_url":"https://github.com/WikiEducationFoundation","followers_url":"https://api.github.com/users/WikiEducationFoundation/followers","following_url":"https://api.github.com/users/WikiEducationFoundation/following{/other_user}","gists_url":"https://api.github.com/users/WikiEducationFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiEducationFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiEducationFoundation/subscriptions","organizations_url":"https://api.github.com/users/WikiEducationFoundation/orgs","repos_url":"https://api.github.com/users/WikiEducationFoundation/repos","events_url":"https://api.github.com/users/WikiEducationFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/WikiEducationFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":27940263,"name":"WikiEduDashboard","full_name":"WikiEducationFoundation/WikiEduDashboard","owner":{"login":"WikiEducationFoundation","id":9489865,"avatar_url":"https://avatars.githubusercontent.com/u/9489865?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiEducationFoundation","html_url":"https://github.com/WikiEducationFoundation","followers_url":"https://api.github.com/users/WikiEducationFoundation/followers","following_url":"https://api.github.com/users/WikiEducationFoundation/following{/other_user}","gists_url":"https://api.github.com/users/WikiEducationFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiEducationFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiEducationFoundation/subscriptions","organizations_url":"https://api.github.com/users/WikiEducationFoundation/orgs","repos_url":"https://api.github.com/users/WikiEducationFoundation/repos","events_url":"https://api.github.com/users/WikiEducationFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/WikiEducationFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard","description":"Wiki Education Foundation's Wikipedia course dashboard system","fork":false,"url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard","forks_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/forks","keys_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/teams","hooks_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/hooks","issue_events_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/events{/number}","events_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/events","assignees_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/assignees{/user}","branches_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/branches{/branch}","tags_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/tags","blobs_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/languages","stargazers_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/stargazers","contributors_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/contributors","subscribers_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/subscribers","subscription_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/subscription","commits_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/contents/{+path}","compare_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/merges","archive_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/downloads","issues_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues{/number}","pulls_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/labels{/name}","releases_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/releases{/id}","deployments_url":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/deployments","created_at":"2014-12-12T22:13:19Z","updated_at":"2016-11-30T04:22:40Z","pushed_at":"2016-12-01T00:16:48Z","git_url":"git://github.com/WikiEducationFoundation/WikiEduDashboard.git","ssh_url":"git@github.com:WikiEducationFoundation/WikiEduDashboard.git","clone_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard.git","svn_url":"https://github.com/WikiEducationFoundation/WikiEduDashboard","homepage":"https://dashboard.wikiedu.org","size":60273,"stargazers_count":23,"watchers_count":23,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":138,"forks":31,"open_issues":138,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033"},"html":{"href":"https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1033"},"issue":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/1033"},"comments":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/issues/1033/comments"},"review_comments":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033/comments"},"review_comment":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/pulls/1033/commits"},"statuses":{"href":"https://api.github.com/repos/WikiEducationFoundation/WikiEduDashboard/statuses/6b8c80bc069c4c8ef2799dbb5e36d7fdc23466cc"}}}}
{"actor":{"display_login":"ragesoss"}}