{"action":"created","comment":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments/68119309","id":68119309,"diff_hunk":"@@ -122,6 +122,7 @@ def get_proxy_config(cls):\n             cadir = cls.cadir,\n             authenticator = cls.authenticator,\n             add_upstream_certs_to_client_chain = cls.add_upstream_certs_to_client_chain,\n+            ssl_insecure = True,","path":"test/mitmproxy/tservers.py","position":4,"original_position":4,"commit_id":"77b5b06c3b2b83b9cb72af3ba9f79351ce90a1e9","original_commit_id":"77b5b06c3b2b83b9cb72af3ba9f79351ce90a1e9","user":{"login":"mhils","id":1019198,"avatar_url":"https://avatars.githubusercontent.com/u/1019198?v=3","gravatar_id":"","url":"https://api.github.com/users/mhils","html_url":"https://github.com/mhils","followers_url":"https://api.github.com/users/mhils/followers","following_url":"https://api.github.com/users/mhils/following{/other_user}","gists_url":"https://api.github.com/users/mhils/gists{/gist_id}","starred_url":"https://api.github.com/users/mhils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhils/subscriptions","organizations_url":"https://api.github.com/users/mhils/orgs","repos_url":"https://api.github.com/users/mhils/repos","events_url":"https://api.github.com/users/mhils/events{/privacy}","received_events_url":"https://api.github.com/users/mhils/received_events","type":"User","site_admin":false},"body":"It's fine if all tests are run using `--insecure`. We should add a tests that assures that we actually verify the certificate if `ssl_insecure` is not passed.","created_at":"2016-06-22T19:31:15Z","updated_at":"2016-06-22T19:31:15Z","html_url":"https://github.com/mitmproxy/mitmproxy/pull/1197#discussion_r68119309","pull_request_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197","_links":{"self":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments/68119309"},"html":{"href":"https://github.com/mitmproxy/mitmproxy/pull/1197#discussion_r68119309"},"pull_request":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197"}}},"pull_request":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197","id":72381132,"html_url":"https://github.com/mitmproxy/mitmproxy/pull/1197","diff_url":"https://github.com/mitmproxy/mitmproxy/pull/1197.diff","patch_url":"https://github.com/mitmproxy/mitmproxy/pull/1197.patch","issue_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1197","number":1197,"state":"open","locked":false,"title":" Verify upstream certificates by default. #1111","user":{"login":"s4chin","id":5997735,"avatar_url":"https://avatars.githubusercontent.com/u/5997735?v=3","gravatar_id":"","url":"https://api.github.com/users/s4chin","html_url":"https://github.com/s4chin","followers_url":"https://api.github.com/users/s4chin/followers","following_url":"https://api.github.com/users/s4chin/following{/other_user}","gists_url":"https://api.github.com/users/s4chin/gists{/gist_id}","starred_url":"https://api.github.com/users/s4chin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s4chin/subscriptions","organizations_url":"https://api.github.com/users/s4chin/orgs","repos_url":"https://api.github.com/users/s4chin/repos","events_url":"https://api.github.com/users/s4chin/events{/privacy}","received_events_url":"https://api.github.com/users/s4chin/received_events","type":"User","site_admin":false},"body":"This adds the `--insecure` option and enables certificate verification by default. The tests fail and I need help in knowing how to fix them.","created_at":"2016-06-02T16:55:31Z","updated_at":"2016-06-22T19:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f7cb532969389b6abfbd47eabbdcc8bd7f07ff9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197/commits","review_comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197/comments","review_comment_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1197/comments","statuses_url":"https://api.github.com/repos/mitmproxy/mitmproxy/statuses/77b5b06c3b2b83b9cb72af3ba9f79351ce90a1e9","head":{"label":"s4chin:add-insecure-option","ref":"add-insecure-option","sha":"77b5b06c3b2b83b9cb72af3ba9f79351ce90a1e9","user":{"login":"s4chin","id":5997735,"avatar_url":"https://avatars.githubusercontent.com/u/5997735?v=3","gravatar_id":"","url":"https://api.github.com/users/s4chin","html_url":"https://github.com/s4chin","followers_url":"https://api.github.com/users/s4chin/followers","following_url":"https://api.github.com/users/s4chin/following{/other_user}","gists_url":"https://api.github.com/users/s4chin/gists{/gist_id}","starred_url":"https://api.github.com/users/s4chin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s4chin/subscriptions","organizations_url":"https://api.github.com/users/s4chin/orgs","repos_url":"https://api.github.com/users/s4chin/repos","events_url":"https://api.github.com/users/s4chin/events{/privacy}","received_events_url":"https://api.github.com/users/s4chin/received_events","type":"User","site_admin":false},"repo":{"id":60246462,"name":"mitmproxy","full_name":"s4chin/mitmproxy","owner":{"login":"s4chin","id":5997735,"avatar_url":"https://avatars.githubusercontent.com/u/5997735?v=3","gravatar_id":"","url":"https://api.github.com/users/s4chin","html_url":"https://github.com/s4chin","followers_url":"https://api.github.com/users/s4chin/followers","following_url":"https://api.github.com/users/s4chin/following{/other_user}","gists_url":"https://api.github.com/users/s4chin/gists{/gist_id}","starred_url":"https://api.github.com/users/s4chin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s4chin/subscriptions","organizations_url":"https://api.github.com/users/s4chin/orgs","repos_url":"https://api.github.com/users/s4chin/repos","events_url":"https://api.github.com/users/s4chin/events{/privacy}","received_events_url":"https://api.github.com/users/s4chin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s4chin/mitmproxy","description":"An interactive SSL-capable intercepting HTTP proxy for penetration testers and software developers","fork":true,"url":"https://api.github.com/repos/s4chin/mitmproxy","forks_url":"https://api.github.com/repos/s4chin/mitmproxy/forks","keys_url":"https://api.github.com/repos/s4chin/mitmproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s4chin/mitmproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s4chin/mitmproxy/teams","hooks_url":"https://api.github.com/repos/s4chin/mitmproxy/hooks","issue_events_url":"https://api.github.com/repos/s4chin/mitmproxy/issues/events{/number}","events_url":"https://api.github.com/repos/s4chin/mitmproxy/events","assignees_url":"https://api.github.com/repos/s4chin/mitmproxy/assignees{/user}","branches_url":"https://api.github.com/repos/s4chin/mitmproxy/branches{/branch}","tags_url":"https://api.github.com/repos/s4chin/mitmproxy/tags","blobs_url":"https://api.github.com/repos/s4chin/mitmproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s4chin/mitmproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s4chin/mitmproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/s4chin/mitmproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s4chin/mitmproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/s4chin/mitmproxy/languages","stargazers_url":"https://api.github.com/repos/s4chin/mitmproxy/stargazers","contributors_url":"https://api.github.com/repos/s4chin/mitmproxy/contributors","subscribers_url":"https://api.github.com/repos/s4chin/mitmproxy/subscribers","subscription_url":"https://api.github.com/repos/s4chin/mitmproxy/subscription","commits_url":"https://api.github.com/repos/s4chin/mitmproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/s4chin/mitmproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/s4chin/mitmproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/s4chin/mitmproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/s4chin/mitmproxy/contents/{+path}","compare_url":"https://api.github.com/repos/s4chin/mitmproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s4chin/mitmproxy/merges","archive_url":"https://api.github.com/repos/s4chin/mitmproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s4chin/mitmproxy/downloads","issues_url":"https://api.github.com/repos/s4chin/mitmproxy/issues{/number}","pulls_url":"https://api.github.com/repos/s4chin/mitmproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/s4chin/mitmproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/s4chin/mitmproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s4chin/mitmproxy/labels{/name}","releases_url":"https://api.github.com/repos/s4chin/mitmproxy/releases{/id}","deployments_url":"https://api.github.com/repos/s4chin/mitmproxy/deployments","created_at":"2016-06-02T08:29:46Z","updated_at":"2016-06-15T13:58:36Z","pushed_at":"2016-06-18T08:23:02Z","git_url":"git://github.com/s4chin/mitmproxy.git","ssh_url":"git@github.com:s4chin/mitmproxy.git","clone_url":"https://github.com/s4chin/mitmproxy.git","svn_url":"https://github.com/s4chin/mitmproxy","homepage":"http://mitmproxy.org","size":30523,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitmproxy:master","ref":"master","sha":"23b976a999f41439e83c1010474ec9dc680b8486","user":{"login":"mitmproxy","id":4652787,"avatar_url":"https://avatars.githubusercontent.com/u/4652787?v=3","gravatar_id":"","url":"https://api.github.com/users/mitmproxy","html_url":"https://github.com/mitmproxy","followers_url":"https://api.github.com/users/mitmproxy/followers","following_url":"https://api.github.com/users/mitmproxy/following{/other_user}","gists_url":"https://api.github.com/users/mitmproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmproxy/subscriptions","organizations_url":"https://api.github.com/users/mitmproxy/orgs","repos_url":"https://api.github.com/users/mitmproxy/repos","events_url":"https://api.github.com/users/mitmproxy/events{/privacy}","received_events_url":"https://api.github.com/users/mitmproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":519832,"name":"mitmproxy","full_name":"mitmproxy/mitmproxy","owner":{"login":"mitmproxy","id":4652787,"avatar_url":"https://avatars.githubusercontent.com/u/4652787?v=3","gravatar_id":"","url":"https://api.github.com/users/mitmproxy","html_url":"https://github.com/mitmproxy","followers_url":"https://api.github.com/users/mitmproxy/followers","following_url":"https://api.github.com/users/mitmproxy/following{/other_user}","gists_url":"https://api.github.com/users/mitmproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmproxy/subscriptions","organizations_url":"https://api.github.com/users/mitmproxy/orgs","repos_url":"https://api.github.com/users/mitmproxy/repos","events_url":"https://api.github.com/users/mitmproxy/events{/privacy}","received_events_url":"https://api.github.com/users/mitmproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitmproxy/mitmproxy","description":"An interactive SSL-capable intercepting HTTP proxy for penetration testers and software developers","fork":false,"url":"https://api.github.com/repos/mitmproxy/mitmproxy","forks_url":"https://api.github.com/repos/mitmproxy/mitmproxy/forks","keys_url":"https://api.github.com/repos/mitmproxy/mitmproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitmproxy/mitmproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitmproxy/mitmproxy/teams","hooks_url":"https://api.github.com/repos/mitmproxy/mitmproxy/hooks","issue_events_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/events{/number}","events_url":"https://api.github.com/repos/mitmproxy/mitmproxy/events","assignees_url":"https://api.github.com/repos/mitmproxy/mitmproxy/assignees{/user}","branches_url":"https://api.github.com/repos/mitmproxy/mitmproxy/branches{/branch}","tags_url":"https://api.github.com/repos/mitmproxy/mitmproxy/tags","blobs_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitmproxy/mitmproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mitmproxy/mitmproxy/languages","stargazers_url":"https://api.github.com/repos/mitmproxy/mitmproxy/stargazers","contributors_url":"https://api.github.com/repos/mitmproxy/mitmproxy/contributors","subscribers_url":"https://api.github.com/repos/mitmproxy/mitmproxy/subscribers","subscription_url":"https://api.github.com/repos/mitmproxy/mitmproxy/subscription","commits_url":"https://api.github.com/repos/mitmproxy/mitmproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitmproxy/mitmproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitmproxy/mitmproxy/contents/{+path}","compare_url":"https://api.github.com/repos/mitmproxy/mitmproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitmproxy/mitmproxy/merges","archive_url":"https://api.github.com/repos/mitmproxy/mitmproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitmproxy/mitmproxy/downloads","issues_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues{/number}","pulls_url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mitmproxy/mitmproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mitmproxy/mitmproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitmproxy/mitmproxy/labels{/name}","releases_url":"https://api.github.com/repos/mitmproxy/mitmproxy/releases{/id}","deployments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/deployments","created_at":"2010-02-16T04:10:13Z","updated_at":"2016-06-22T17:12:31Z","pushed_at":"2016-06-22T19:29:34Z","git_url":"git://github.com/mitmproxy/mitmproxy.git","ssh_url":"git@github.com:mitmproxy/mitmproxy.git","clone_url":"https://github.com/mitmproxy/mitmproxy.git","svn_url":"https://github.com/mitmproxy/mitmproxy","homepage":"http://mitmproxy.org","size":33984,"stargazers_count":5106,"watchers_count":5106,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":736,"mirror_url":null,"open_issues_count":78,"forks":736,"open_issues":78,"watchers":5106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197"},"html":{"href":"https://github.com/mitmproxy/mitmproxy/pull/1197"},"issue":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1197"},"comments":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1197/comments"},"review_comments":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197/comments"},"review_comment":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1197/commits"},"statuses":{"href":"https://api.github.com/repos/mitmproxy/mitmproxy/statuses/77b5b06c3b2b83b9cb72af3ba9f79351ce90a1e9"}}}}
{"actor":{"display_login":"mhils"}}