{"action":"created","comment":{"url":"https://api.github.com/repos/Runnable/ponos/pulls/comments/49394077","id":49394077,"diff_hunk":"@@ -104,6 +88,12 @@ Server.prototype._assertHaveAllTasks = function () {\n Server.prototype._subscribe = function (queueName) {\n   debug('_subscribe(' + queueName + ')')\n   this.log.trace('ponos.Server: subscribing to ' + queueName)\n+  if (!this._tasks[queueName]) {\n+    this.log.warn({\n+      queueName: queueName\n+    }, 'ponos.Server: handler not defined')\n+    return\n+  }","path":"lib/server.js","position":32,"original_position":32,"commit_id":"7fb015aece899b7a759cb6f03703cbf04367e42d","original_commit_id":"7fb015aece899b7a759cb6f03703cbf04367e42d","user":{"login":"bkendall","id":160236,"avatar_url":"https://avatars.githubusercontent.com/u/160236?v=3","gravatar_id":"","url":"https://api.github.com/users/bkendall","html_url":"https://github.com/bkendall","followers_url":"https://api.github.com/users/bkendall/followers","following_url":"https://api.github.com/users/bkendall/following{/other_user}","gists_url":"https://api.github.com/users/bkendall/gists{/gist_id}","starred_url":"https://api.github.com/users/bkendall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkendall/subscriptions","organizations_url":"https://api.github.com/users/bkendall/orgs","repos_url":"https://api.github.com/users/bkendall/repos","events_url":"https://api.github.com/users/bkendall/events{/privacy}","received_events_url":"https://api.github.com/users/bkendall/received_events","type":"User","site_admin":false},"body":"can you wrap this and the next `return` block in a `Promise.resolve().then(function () { ... })`? Then it'll keep with the documentation that it is supposed to return a promise.\r\n\r\nonce you do that, can you expand the unit tests for `_subscribe` to account for this log? you should be able to stub `server.log.warn`, IIRC.","created_at":"2016-01-11T23:13:54Z","updated_at":"2016-01-11T23:13:54Z","html_url":"https://github.com/Runnable/ponos/pull/22#discussion_r49394077","pull_request_url":"https://api.github.com/repos/Runnable/ponos/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Runnable/ponos/pulls/comments/49394077"},"html":{"href":"https://github.com/Runnable/ponos/pull/22#discussion_r49394077"},"pull_request":{"href":"https://api.github.com/repos/Runnable/ponos/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Runnable/ponos/pulls/22","id":55685254,"html_url":"https://github.com/Runnable/ponos/pull/22","diff_url":"https://github.com/Runnable/ponos/pull/22.diff","patch_url":"https://github.com/Runnable/ponos/pull/22.patch","issue_url":"https://api.github.com/repos/Runnable/ponos/issues/22","number":22,"state":"open","locked":false,"title":"Change throw to warn log on queue checks","user":{"login":"cflynn07","id":467885,"avatar_url":"https://avatars.githubusercontent.com/u/467885?v=3","gravatar_id":"","url":"https://api.github.com/users/cflynn07","html_url":"https://github.com/cflynn07","followers_url":"https://api.github.com/users/cflynn07/followers","following_url":"https://api.github.com/users/cflynn07/following{/other_user}","gists_url":"https://api.github.com/users/cflynn07/gists{/gist_id}","starred_url":"https://api.github.com/users/cflynn07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cflynn07/subscriptions","organizations_url":"https://api.github.com/users/cflynn07/orgs","repos_url":"https://api.github.com/users/cflynn07/repos","events_url":"https://api.github.com/users/cflynn07/events{/privacy}","received_events_url":"https://api.github.com/users/cflynn07/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-01-11T22:07:14Z","updated_at":"2016-01-11T23:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d40caee99916b1bd2e1d7421b5797560e849531","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Runnable/ponos/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Runnable/ponos/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Runnable/ponos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Runnable/ponos/issues/22/comments","statuses_url":"https://api.github.com/repos/Runnable/ponos/statuses/7fb015aece899b7a759cb6f03703cbf04367e42d","head":{"label":"Runnable:throw-to-warn-log","ref":"throw-to-warn-log","sha":"7fb015aece899b7a759cb6f03703cbf04367e42d","user":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"repo":{"id":41134020,"name":"ponos","full_name":"Runnable/ponos","owner":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Runnable/ponos","description":"An opinionated queue based worker server for node.","fork":false,"url":"https://api.github.com/repos/Runnable/ponos","forks_url":"https://api.github.com/repos/Runnable/ponos/forks","keys_url":"https://api.github.com/repos/Runnable/ponos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Runnable/ponos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Runnable/ponos/teams","hooks_url":"https://api.github.com/repos/Runnable/ponos/hooks","issue_events_url":"https://api.github.com/repos/Runnable/ponos/issues/events{/number}","events_url":"https://api.github.com/repos/Runnable/ponos/events","assignees_url":"https://api.github.com/repos/Runnable/ponos/assignees{/user}","branches_url":"https://api.github.com/repos/Runnable/ponos/branches{/branch}","tags_url":"https://api.github.com/repos/Runnable/ponos/tags","blobs_url":"https://api.github.com/repos/Runnable/ponos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Runnable/ponos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Runnable/ponos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Runnable/ponos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Runnable/ponos/statuses/{sha}","languages_url":"https://api.github.com/repos/Runnable/ponos/languages","stargazers_url":"https://api.github.com/repos/Runnable/ponos/stargazers","contributors_url":"https://api.github.com/repos/Runnable/ponos/contributors","subscribers_url":"https://api.github.com/repos/Runnable/ponos/subscribers","subscription_url":"https://api.github.com/repos/Runnable/ponos/subscription","commits_url":"https://api.github.com/repos/Runnable/ponos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Runnable/ponos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Runnable/ponos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Runnable/ponos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Runnable/ponos/contents/{+path}","compare_url":"https://api.github.com/repos/Runnable/ponos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Runnable/ponos/merges","archive_url":"https://api.github.com/repos/Runnable/ponos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Runnable/ponos/downloads","issues_url":"https://api.github.com/repos/Runnable/ponos/issues{/number}","pulls_url":"https://api.github.com/repos/Runnable/ponos/pulls{/number}","milestones_url":"https://api.github.com/repos/Runnable/ponos/milestones{/number}","notifications_url":"https://api.github.com/repos/Runnable/ponos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Runnable/ponos/labels{/name}","releases_url":"https://api.github.com/repos/Runnable/ponos/releases{/id}","created_at":"2015-08-21T04:08:01Z","updated_at":"2016-01-11T21:07:51Z","pushed_at":"2016-01-11T23:09:54Z","git_url":"git://github.com/Runnable/ponos.git","ssh_url":"git@github.com:Runnable/ponos.git","clone_url":"https://github.com/Runnable/ponos.git","svn_url":"https://github.com/Runnable/ponos","homepage":null,"size":499,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"Runnable:master","ref":"master","sha":"e2e01386acf63fafaf3269b0d7150687931b49cf","user":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"repo":{"id":41134020,"name":"ponos","full_name":"Runnable/ponos","owner":{"login":"Runnable","id":2828361,"avatar_url":"https://avatars.githubusercontent.com/u/2828361?v=3","gravatar_id":"","url":"https://api.github.com/users/Runnable","html_url":"https://github.com/Runnable","followers_url":"https://api.github.com/users/Runnable/followers","following_url":"https://api.github.com/users/Runnable/following{/other_user}","gists_url":"https://api.github.com/users/Runnable/gists{/gist_id}","starred_url":"https://api.github.com/users/Runnable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Runnable/subscriptions","organizations_url":"https://api.github.com/users/Runnable/orgs","repos_url":"https://api.github.com/users/Runnable/repos","events_url":"https://api.github.com/users/Runnable/events{/privacy}","received_events_url":"https://api.github.com/users/Runnable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Runnable/ponos","description":"An opinionated queue based worker server for node.","fork":false,"url":"https://api.github.com/repos/Runnable/ponos","forks_url":"https://api.github.com/repos/Runnable/ponos/forks","keys_url":"https://api.github.com/repos/Runnable/ponos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Runnable/ponos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Runnable/ponos/teams","hooks_url":"https://api.github.com/repos/Runnable/ponos/hooks","issue_events_url":"https://api.github.com/repos/Runnable/ponos/issues/events{/number}","events_url":"https://api.github.com/repos/Runnable/ponos/events","assignees_url":"https://api.github.com/repos/Runnable/ponos/assignees{/user}","branches_url":"https://api.github.com/repos/Runnable/ponos/branches{/branch}","tags_url":"https://api.github.com/repos/Runnable/ponos/tags","blobs_url":"https://api.github.com/repos/Runnable/ponos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Runnable/ponos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Runnable/ponos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Runnable/ponos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Runnable/ponos/statuses/{sha}","languages_url":"https://api.github.com/repos/Runnable/ponos/languages","stargazers_url":"https://api.github.com/repos/Runnable/ponos/stargazers","contributors_url":"https://api.github.com/repos/Runnable/ponos/contributors","subscribers_url":"https://api.github.com/repos/Runnable/ponos/subscribers","subscription_url":"https://api.github.com/repos/Runnable/ponos/subscription","commits_url":"https://api.github.com/repos/Runnable/ponos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Runnable/ponos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Runnable/ponos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Runnable/ponos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Runnable/ponos/contents/{+path}","compare_url":"https://api.github.com/repos/Runnable/ponos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Runnable/ponos/merges","archive_url":"https://api.github.com/repos/Runnable/ponos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Runnable/ponos/downloads","issues_url":"https://api.github.com/repos/Runnable/ponos/issues{/number}","pulls_url":"https://api.github.com/repos/Runnable/ponos/pulls{/number}","milestones_url":"https://api.github.com/repos/Runnable/ponos/milestones{/number}","notifications_url":"https://api.github.com/repos/Runnable/ponos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Runnable/ponos/labels{/name}","releases_url":"https://api.github.com/repos/Runnable/ponos/releases{/id}","created_at":"2015-08-21T04:08:01Z","updated_at":"2016-01-11T21:07:51Z","pushed_at":"2016-01-11T23:09:54Z","git_url":"git://github.com/Runnable/ponos.git","ssh_url":"git@github.com:Runnable/ponos.git","clone_url":"https://github.com/Runnable/ponos.git","svn_url":"https://github.com/Runnable/ponos","homepage":null,"size":499,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Runnable/ponos/pulls/22"},"html":{"href":"https://github.com/Runnable/ponos/pull/22"},"issue":{"href":"https://api.github.com/repos/Runnable/ponos/issues/22"},"comments":{"href":"https://api.github.com/repos/Runnable/ponos/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Runnable/ponos/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Runnable/ponos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Runnable/ponos/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Runnable/ponos/statuses/7fb015aece899b7a759cb6f03703cbf04367e42d"}}}}