{"action":"created","issue":{"url":"https://api.github.com/repos/p5pclub/devel-quickcover/issues/14","repository_url":"https://api.github.com/repos/p5pclub/devel-quickcover","labels_url":"https://api.github.com/repos/p5pclub/devel-quickcover/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/p5pclub/devel-quickcover/issues/14/comments","events_url":"https://api.github.com/repos/p5pclub/devel-quickcover/issues/14/events","html_url":"https://github.com/p5pclub/devel-quickcover/issues/14","id":163590577,"number":14,"title":"Undocumented and untested functions in Devel::QuickCover","user":{"login":"jkeenan","id":96524,"avatar_url":"https://avatars.githubusercontent.com/u/96524?v=3","gravatar_id":"","url":"https://api.github.com/users/jkeenan","html_url":"https://github.com/jkeenan","followers_url":"https://api.github.com/users/jkeenan/followers","following_url":"https://api.github.com/users/jkeenan/following{/other_user}","gists_url":"https://api.github.com/users/jkeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/jkeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkeenan/subscriptions","organizations_url":"https://api.github.com/users/jkeenan/orgs","repos_url":"https://api.github.com/users/jkeenan/repos","events_url":"https://api.github.com/users/jkeenan/events{/privacy}","received_events_url":"https://api.github.com/users/jkeenan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-04T01:43:33Z","updated_at":"2016-07-04T07:27:52Z","closed_at":null,"body":"Devel::QuickCover (i.e., lib/Devel/QuickCover.pm) source code contains two functions, set_output_directory() and set_metadata(), neither of which are documented.\r\n```sh\r\n[devel-quickcover] 34 $ ack set_output_directory .\r\nlib/Devel/QuickCover.pm\r\n43:sub set_output_directory {\r\n[devel-quickcover] 35 $ ack set_metadata .\r\nlib/Devel/QuickCover.pm\r\n50:sub set_metadata {\r\n```\r\nNor are these functions exercised in your test suite (as I learned by running the distribution through Devel::Cover).\r\n\r\nWhat purpose do they serve?  If they should be used, they should be publicly documented and tested.\r\n\r\nThank you very much.\r\nJim Keenan"},"comment":{"url":"https://api.github.com/repos/p5pclub/devel-quickcover/issues/comments/230223342","html_url":"https://github.com/p5pclub/devel-quickcover/issues/14#issuecomment-230223342","issue_url":"https://api.github.com/repos/p5pclub/devel-quickcover/issues/14","id":230223342,"user":{"login":"gonzus","id":208546,"avatar_url":"https://avatars.githubusercontent.com/u/208546?v=3","gravatar_id":"","url":"https://api.github.com/users/gonzus","html_url":"https://github.com/gonzus","followers_url":"https://api.github.com/users/gonzus/followers","following_url":"https://api.github.com/users/gonzus/following{/other_user}","gists_url":"https://api.github.com/users/gonzus/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzus/subscriptions","organizations_url":"https://api.github.com/users/gonzus/orgs","repos_url":"https://api.github.com/users/gonzus/repos","events_url":"https://api.github.com/users/gonzus/events{/privacy}","received_events_url":"https://api.github.com/users/gonzus/received_events","type":"User","site_admin":false},"created_at":"2016-07-04T07:27:52Z","updated_at":"2016-07-04T07:27:52Z","body":"You are right, need to document and test these two. Thanks for bringing \nit to my attention, will do so presently.\n\nCheers!\n\nOn 04/07/2016 03:43, James E Keenan wrote:\n>\n> Devel::QuickCover (i.e., lib/Devel/QuickCover.pm) source code contains \n> two functions, set_output_directory() and set_metadata(), neither of \n> which are documented.\n>\n> [devel-quickcover] 34 $ ack set_output_directory.\n> lib/Devel/QuickCover.pm\n> 43:sub set_output_directory {\n> [devel-quickcover] 35 $ ack set_metadata.\n> lib/Devel/QuickCover.pm\n> 50:sub set_metadata {\n>\n> Nor are these functions exercised in your test suite (as I learned by \n> running the distribution through Devel::Cover).\n>\n> What purpose do they serve? If they should be used, they should be \n> publicly documented and tested.\n>\n> Thank you very much.\n> Jim Keenan\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/p5pclub/devel-quickcover/issues/14>, or mute the \n> thread \n> <https://github.com/notifications/unsubscribe/AAMuohBvNc84NxxmQl6Ltu_azLH6faiHks5qSGVGgaJpZM4JD_vJ>.\n>\n\n"}}
{"actor":{"display_login":"gonzus"}}