{"action":"created","issue":{"url":"https://api.github.com/repos/idaholab/moose/issues/7793","repository_url":"https://api.github.com/repos/idaholab/moose","labels_url":"https://api.github.com/repos/idaholab/moose/issues/7793/labels{/name}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/7793/comments","events_url":"https://api.github.com/repos/idaholab/moose/issues/7793/events","html_url":"https://github.com/idaholab/moose/pull/7793","id":179932032,"number":7793,"title":"Brine fluid properties","user":{"login":"cpgr","id":7664823,"avatar_url":"https://avatars.githubusercontent.com/u/7664823?v=3","gravatar_id":"","url":"https://api.github.com/users/cpgr","html_url":"https://github.com/cpgr","followers_url":"https://api.github.com/users/cpgr/followers","following_url":"https://api.github.com/users/cpgr/following{/other_user}","gists_url":"https://api.github.com/users/cpgr/gists{/gist_id}","starred_url":"https://api.github.com/users/cpgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpgr/subscriptions","organizations_url":"https://api.github.com/users/cpgr/orgs","repos_url":"https://api.github.com/users/cpgr/repos","events_url":"https://api.github.com/users/cpgr/events{/privacy}","received_events_url":"https://api.github.com/users/cpgr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andrsd","id":85632,"avatar_url":"https://avatars.githubusercontent.com/u/85632?v=3","gravatar_id":"","url":"https://api.github.com/users/andrsd","html_url":"https://github.com/andrsd","followers_url":"https://api.github.com/users/andrsd/followers","following_url":"https://api.github.com/users/andrsd/following{/other_user}","gists_url":"https://api.github.com/users/andrsd/gists{/gist_id}","starred_url":"https://api.github.com/users/andrsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrsd/subscriptions","organizations_url":"https://api.github.com/users/andrsd/orgs","repos_url":"https://api.github.com/users/andrsd/repos","events_url":"https://api.github.com/users/andrsd/events{/privacy}","received_events_url":"https://api.github.com/users/andrsd/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrsd","id":85632,"avatar_url":"https://avatars.githubusercontent.com/u/85632?v=3","gravatar_id":"","url":"https://api.github.com/users/andrsd","html_url":"https://github.com/andrsd","followers_url":"https://api.github.com/users/andrsd/followers","following_url":"https://api.github.com/users/andrsd/following{/other_user}","gists_url":"https://api.github.com/users/andrsd/gists{/gist_id}","starred_url":"https://api.github.com/users/andrsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrsd/subscriptions","organizations_url":"https://api.github.com/users/andrsd/orgs","repos_url":"https://api.github.com/users/andrsd/repos","events_url":"https://api.github.com/users/andrsd/events{/privacy}","received_events_url":"https://api.github.com/users/andrsd/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-09-29T01:35:58Z","updated_at":"2016-10-06T03:51:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/7793","html_url":"https://github.com/idaholab/moose/pull/7793","diff_url":"https://github.com/idaholab/moose/pull/7793.diff","patch_url":"https://github.com/idaholab/moose/pull/7793.patch"},"body":"- Initial version of a multicomponent fluid base class added\r\n- Adds a binary fluid - brine (NaCl-H2O) - to the `fluid_properties` module. \r\n- Adds tests of brine properties\r\n\r\nLet me know what you think @andrsd. I haven't added all of the properties that are in the single component fluids yet, as I don't need them at the moment. Also, I have called the base class _multicomponent_ even though it only has two components. It could be generalised in future, but I have no need for more than two components.\r\n\r\nRefs #6972 \r\n"},"comment":{"url":"https://api.github.com/repos/idaholab/moose/issues/comments/251860898","html_url":"https://github.com/idaholab/moose/pull/7793#issuecomment-251860898","issue_url":"https://api.github.com/repos/idaholab/moose/issues/7793","id":251860898,"user":{"login":"cpgr","id":7664823,"avatar_url":"https://avatars.githubusercontent.com/u/7664823?v=3","gravatar_id":"","url":"https://api.github.com/users/cpgr","html_url":"https://github.com/cpgr","followers_url":"https://api.github.com/users/cpgr/followers","following_url":"https://api.github.com/users/cpgr/following{/other_user}","gists_url":"https://api.github.com/users/cpgr/gists{/gist_id}","starred_url":"https://api.github.com/users/cpgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpgr/subscriptions","organizations_url":"https://api.github.com/users/cpgr/orgs","repos_url":"https://api.github.com/users/cpgr/repos","events_url":"https://api.github.com/users/cpgr/events{/privacy}","received_events_url":"https://api.github.com/users/cpgr/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T03:51:07Z","updated_at":"2016-10-06T03:51:07Z","body":"@andrsd - before I go nuts, is this along the lines of what you meant? BrineFluidProperties now takes in water and NaCl properties user objects, and has a `getComponent(component)` method that passes back a `const SinglePhaseFluidPropertiesPT` reference. I changed the test material to use this to access halite density etc, and it seems to work. "}}
{"actor":{"display_login":"cpgr"}}