{"action":"created","issue":{"url":"https://api.github.com/repos/googlei18n/fontmake/issues/207","repository_url":"https://api.github.com/repos/googlei18n/fontmake","labels_url":"https://api.github.com/repos/googlei18n/fontmake/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/googlei18n/fontmake/issues/207/comments","events_url":"https://api.github.com/repos/googlei18n/fontmake/issues/207/events","html_url":"https://github.com/googlei18n/fontmake/pull/207","id":194140762,"number":207,"title":"follow up on PR #200","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-07T19:14:16Z","updated_at":"2016-12-08T13:34:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/googlei18n/fontmake/pulls/207","html_url":"https://github.com/googlei18n/fontmake/pull/207","diff_url":"https://github.com/googlei18n/fontmake/pull/207.diff","patch_url":"https://github.com/googlei18n/fontmake/pull/207.patch"},"body":"hey Adam @twardoch \r\nI reviewed your PR #200 and added a few commits on top of it.\r\n\r\n- I renamed the options to `--kern-writer-module` and `--mark-writer-module`; I think it's better as they take a module name argument, while `--use-...` seems to imply a boolean value.\r\n\r\n- the argument parser passes the class objects themselves rather than the module names; this also gives the chance to raise a parser.error when the module can't be imported or does not contain a class with the expected name. I think it's more reasonable to raise here, instead of just log a warning.\r\n\r\n- I kept the grouping of the arguments, and only made cosmetic changes here and there.\r\n\r\nPlease take a look, thanks."},"comment":{"url":"https://api.github.com/repos/googlei18n/fontmake/issues/comments/265740625","html_url":"https://github.com/googlei18n/fontmake/pull/207#issuecomment-265740625","issue_url":"https://api.github.com/repos/googlei18n/fontmake/issues/207","id":265740625,"user":{"login":"twardoch","id":519108,"avatar_url":"https://avatars.githubusercontent.com/u/519108?v=3","gravatar_id":"","url":"https://api.github.com/users/twardoch","html_url":"https://github.com/twardoch","followers_url":"https://api.github.com/users/twardoch/followers","following_url":"https://api.github.com/users/twardoch/following{/other_user}","gists_url":"https://api.github.com/users/twardoch/gists{/gist_id}","starred_url":"https://api.github.com/users/twardoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twardoch/subscriptions","organizations_url":"https://api.github.com/users/twardoch/orgs","repos_url":"https://api.github.com/users/twardoch/repos","events_url":"https://api.github.com/users/twardoch/events{/privacy}","received_events_url":"https://api.github.com/users/twardoch/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T13:34:30Z","updated_at":"2016-12-08T13:34:30Z","body":"confirm"}}
{"actor":{"display_login":"twardoch"}}