{"action":"closed","number":47,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/python-common/pulls/47","id":62238094,"html_url":"https://github.com/Metaswitch/python-common/pull/47","diff_url":"https://github.com/Metaswitch/python-common/pull/47.diff","patch_url":"https://github.com/Metaswitch/python-common/pull/47.patch","issue_url":"https://api.github.com/repos/Metaswitch/python-common/issues/47","number":47,"state":"closed","locked":false,"title":"Reviewer CNE: Define should_start","user":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"body":"Chris,\r\n\r\nOn nodes with multiple cluster-manager plugins, clearwater-cluster-manager is failing to start with the stack below. I believe this should fix it, and I'm just testing now. Does it look sensible to you?\r\n\r\n```\r\n09-03-2016 14:28:30.180 UTC ERROR logging_config.py:107 (thread MainThread): Uncaught exception:\r\n  Exception: UnboundLocalError\r\n  Detail: local variable 'should_start' referenced before assignment\r\n  Traceback:\r\n    File \"/usr/share/clearwater/bin/clearwater-cluster-manager\", line 40, in <module>\r\n    main(sys.argv[1:])\r\n  File \"build_clustermgr/bdist.linux-x86_64/egg/metaswitch/clearwater/cluster_manager/main.py\", line 194, in main\r\n    syncer = EtcdSynchronizer(plugin, sig_ip, etcd_ip=mgmt_ip)\r\n  File \"build_clustermgr/bdist.linux-x86_64/egg/metaswitch/clearwater/cluster_manager/etcd_synchronizer.py\", line 50, in __init__\r\n    self._fsm = SyncFSM(self._plugin, self._ip)\r\n  File \"build_clustermgr/bdist.linux-x86_64/egg/metaswitch/clearwater/cluster_manager/synchronization_fsm.py\", line 82, in __init__\r\n    self._alarm = TooLongAlarm()\r\n  File \"build_clustermgr/bdist.linux-x86_64/egg/metaswitch/clearwater/cluster_manager/alarms.py\", line 57, in __init__\r\n    TOO_LONG_CLUSTERING)\r\n  File \"build/bdist.linux-x86_64/egg/metaswitch/common/alarms.py\", line 151, in get_alarm\r\n    if should_start:\r\n```","created_at":"2016-03-09T14:42:53Z","updated_at":"2016-03-09T16:23:31Z","closed_at":"2016-03-09T16:23:31Z","merged_at":"2016-03-09T16:23:31Z","merge_commit_sha":"435012984013bd138e160567e0beef4ab731148d","assignee":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/python-common/pulls/47/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/python-common/pulls/47/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/python-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/python-common/issues/47/comments","statuses_url":"https://api.github.com/repos/Metaswitch/python-common/statuses/a9163eda51db526d247439d643992a7ffbe2a553","head":{"label":"Metaswitch:fix_undefined_variable","ref":"fix_undefined_variable","sha":"a9163eda51db526d247439d643992a7ffbe2a553","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885259,"name":"python-common","full_name":"Metaswitch/python-common","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/python-common","description":"Common python utilities and function library.","fork":false,"url":"https://api.github.com/repos/Metaswitch/python-common","forks_url":"https://api.github.com/repos/Metaswitch/python-common/forks","keys_url":"https://api.github.com/repos/Metaswitch/python-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/python-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/python-common/teams","hooks_url":"https://api.github.com/repos/Metaswitch/python-common/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/python-common/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/python-common/events","assignees_url":"https://api.github.com/repos/Metaswitch/python-common/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/python-common/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/python-common/tags","blobs_url":"https://api.github.com/repos/Metaswitch/python-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/python-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/python-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/python-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/python-common/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/python-common/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/python-common/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/python-common/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/python-common/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/python-common/subscription","commits_url":"https://api.github.com/repos/Metaswitch/python-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/python-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/python-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/python-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/python-common/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/python-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/python-common/merges","archive_url":"https://api.github.com/repos/Metaswitch/python-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/python-common/downloads","issues_url":"https://api.github.com/repos/Metaswitch/python-common/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/python-common/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/python-common/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/python-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/python-common/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/python-common/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/python-common/deployments","created_at":"2013-05-06T11:20:46Z","updated_at":"2016-01-11T14:37:09Z","pushed_at":"2016-03-09T16:23:31Z","git_url":"git://github.com/Metaswitch/python-common.git","ssh_url":"git@github.com:Metaswitch/python-common.git","clone_url":"https://github.com/Metaswitch/python-common.git","svn_url":"https://github.com/Metaswitch/python-common","homepage":null,"size":129,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"0b8baeb565c6d31a876a4e61c2fab32655c59894","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885259,"name":"python-common","full_name":"Metaswitch/python-common","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/python-common","description":"Common python utilities and function library.","fork":false,"url":"https://api.github.com/repos/Metaswitch/python-common","forks_url":"https://api.github.com/repos/Metaswitch/python-common/forks","keys_url":"https://api.github.com/repos/Metaswitch/python-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/python-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/python-common/teams","hooks_url":"https://api.github.com/repos/Metaswitch/python-common/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/python-common/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/python-common/events","assignees_url":"https://api.github.com/repos/Metaswitch/python-common/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/python-common/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/python-common/tags","blobs_url":"https://api.github.com/repos/Metaswitch/python-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/python-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/python-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/python-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/python-common/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/python-common/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/python-common/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/python-common/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/python-common/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/python-common/subscription","commits_url":"https://api.github.com/repos/Metaswitch/python-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/python-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/python-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/python-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/python-common/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/python-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/python-common/merges","archive_url":"https://api.github.com/repos/Metaswitch/python-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/python-common/downloads","issues_url":"https://api.github.com/repos/Metaswitch/python-common/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/python-common/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/python-common/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/python-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/python-common/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/python-common/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/python-common/deployments","created_at":"2013-05-06T11:20:46Z","updated_at":"2016-01-11T14:37:09Z","pushed_at":"2016-03-09T16:23:31Z","git_url":"git://github.com/Metaswitch/python-common.git","ssh_url":"git@github.com:Metaswitch/python-common.git","clone_url":"https://github.com/Metaswitch/python-common.git","svn_url":"https://github.com/Metaswitch/python-common","homepage":null,"size":129,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/47"},"html":{"href":"https://github.com/Metaswitch/python-common/pull/47"},"issue":{"href":"https://api.github.com/repos/Metaswitch/python-common/issues/47"},"comments":{"href":"https://api.github.com/repos/Metaswitch/python-common/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/python-common/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/python-common/statuses/a9163eda51db526d247439d643992a7ffbe2a553"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":19,"deletions":0,"changed_files":2}}