{"action":"created","comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/comments/77639917","id":77639917,"diff_hunk":"@@ -39,6 +39,20 @@ void DeclarativeHistoryModel::clear()\n     emit countChanged();\n }\n \n+void DeclarativeHistoryModel::remove(int index)\n+{\n+    if (index < 0 || index > m_links.count()) {","path":"src/history/declarativehistorymodel.cpp","position":6,"original_position":6,"commit_id":"816f3c79bee4f1246593c43ec371eef00a7e7cab","original_commit_id":"816f3c79bee4f1246593c43ec371eef00a7e7cab","user":{"login":"rainemak","id":3470958,"avatar_url":"https://avatars.githubusercontent.com/u/3470958?v=3","gravatar_id":"","url":"https://api.github.com/users/rainemak","html_url":"https://github.com/rainemak","followers_url":"https://api.github.com/users/rainemak/followers","following_url":"https://api.github.com/users/rainemak/following{/other_user}","gists_url":"https://api.github.com/users/rainemak/gists{/gist_id}","starred_url":"https://api.github.com/users/rainemak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainemak/subscriptions","organizations_url":"https://api.github.com/users/rainemak/orgs","repos_url":"https://api.github.com/users/rainemak/repos","events_url":"https://api.github.com/users/rainemak/events{/privacy}","received_events_url":"https://api.github.com/users/rainemak/received_events","type":"User","site_admin":false},"body":"Yes it should, blindly copy-pasted a piece of old code. There seems to be a potential bug in data method as well. :)","created_at":"2016-09-06T14:01:24Z","updated_at":"2016-09-06T14:01:24Z","html_url":"https://github.com/sailfishos/sailfish-browser/pull/502#discussion_r77639917","pull_request_url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502","_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/comments/77639917"},"html":{"href":"https://github.com/sailfishos/sailfish-browser/pull/502#discussion_r77639917"},"pull_request":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502"}}},"pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502","id":82847378,"html_url":"https://github.com/sailfishos/sailfish-browser/pull/502","diff_url":"https://github.com/sailfishos/sailfish-browser/pull/502.diff","patch_url":"https://github.com/sailfishos/sailfish-browser/pull/502.patch","issue_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/502","number":502,"state":"open","locked":false,"title":"Make it possible to remove single history entry","user":{"login":"rainemak","id":3470958,"avatar_url":"https://avatars.githubusercontent.com/u/3470958?v=3","gravatar_id":"","url":"https://api.github.com/users/rainemak","html_url":"https://github.com/rainemak","followers_url":"https://api.github.com/users/rainemak/followers","following_url":"https://api.github.com/users/rainemak/following{/other_user}","gists_url":"https://api.github.com/users/rainemak/gists{/gist_id}","starred_url":"https://api.github.com/users/rainemak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainemak/subscriptions","organizations_url":"https://api.github.com/users/rainemak/orgs","repos_url":"https://api.github.com/users/rainemak/repos","events_url":"https://api.github.com/users/rainemak/events{/privacy}","received_events_url":"https://api.github.com/users/rainemak/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-26T08:05:44Z","updated_at":"2016-09-06T14:01:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8273bbbbe1f4b3e1ea51b37ae208ac4c1397bf2e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502/commits","review_comments_url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502/comments","review_comment_url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/502/comments","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-browser/statuses/816f3c79bee4f1246593c43ec371eef00a7e7cab","head":{"label":"sailfishos:jb36062","ref":"jb36062","sha":"816f3c79bee4f1246593c43ec371eef00a7e7cab","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":16723800,"name":"sailfish-browser","full_name":"sailfishos/sailfish-browser","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-browser","description":"Sailfish Browser","fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-browser","forks_url":"https://api.github.com/repos/sailfishos/sailfish-browser/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-browser/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-browser/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-browser/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-browser/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-browser/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-browser/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-browser/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-browser/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-browser/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-browser/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-browser/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-browser/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-browser/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-browser/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-browser/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-browser/releases{/id}","deployments_url":"https://api.github.com/repos/sailfishos/sailfish-browser/deployments","created_at":"2014-02-11T08:11:37Z","updated_at":"2016-09-06T11:10:21Z","pushed_at":"2016-09-05T14:14:51Z","git_url":"git://github.com/sailfishos/sailfish-browser.git","ssh_url":"git@github.com:sailfishos/sailfish-browser.git","clone_url":"https://github.com/sailfishos/sailfish-browser.git","svn_url":"https://github.com/sailfishos/sailfish-browser","homepage":"https://github.com/sailfishos/sailfish-browser/wiki/Sailfish-Browser-wiki","size":5870,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":74,"forks":64,"open_issues":74,"watchers":207,"default_branch":"master"}},"base":{"label":"sailfishos:next","ref":"next","sha":"9837333f322810b83a81a5c27f2f8b6edd97abc1","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":16723800,"name":"sailfish-browser","full_name":"sailfishos/sailfish-browser","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars.githubusercontent.com/u/6198659?v=3","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-browser","description":"Sailfish Browser","fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-browser","forks_url":"https://api.github.com/repos/sailfishos/sailfish-browser/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-browser/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-browser/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-browser/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-browser/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-browser/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-browser/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-browser/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-browser/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-browser/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-browser/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-browser/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-browser/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-browser/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-browser/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-browser/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-browser/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-browser/releases{/id}","deployments_url":"https://api.github.com/repos/sailfishos/sailfish-browser/deployments","created_at":"2014-02-11T08:11:37Z","updated_at":"2016-09-06T11:10:21Z","pushed_at":"2016-09-05T14:14:51Z","git_url":"git://github.com/sailfishos/sailfish-browser.git","ssh_url":"git@github.com:sailfishos/sailfish-browser.git","clone_url":"https://github.com/sailfishos/sailfish-browser.git","svn_url":"https://github.com/sailfishos/sailfish-browser","homepage":"https://github.com/sailfishos/sailfish-browser/wiki/Sailfish-Browser-wiki","size":5870,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":74,"forks":64,"open_issues":74,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502"},"html":{"href":"https://github.com/sailfishos/sailfish-browser/pull/502"},"issue":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/502"},"comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/issues/502/comments"},"review_comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502/comments"},"review_comment":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/pulls/502/commits"},"statuses":{"href":"https://api.github.com/repos/sailfishos/sailfish-browser/statuses/816f3c79bee4f1246593c43ec371eef00a7e7cab"}}}}
{"actor":{"display_login":"rainemak"}}