{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments/56105779","id":56105779,"diff_hunk":"@@ -612,8 +612,16 @@ def node_remove(remove_endpoints):\n                         \"in the normal way.\")\n         sys.exit(1)\n \n+    # Remove the veths, and release all IPs associated with the endpoint.\n+    ips = set()\n     for endpoint in endpoints:\n         remove_veth(endpoint.name)\n+        ips |= {net.ip for net in endpoint.ipv4_nets}\n+        ips |= {net.ip for net in endpoint.ipv6_nets}\n+    client.release_ips(ips)\n+\n+    # Remove the IPAM host data.\n+    client.remove_ipam_host(hostname)","path":"calicoctl/calico_ctl/node.py","position":13,"original_position":13,"commit_id":"a98ba7e3210aa91adc698abd64aab8121b89413d","original_commit_id":"a98ba7e3210aa91adc698abd64aab8121b89413d","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"body":"Yup already rebased and fixed up. ","created_at":"2016-03-15T01:58:18Z","updated_at":"2016-03-15T01:58:18Z","html_url":"https://github.com/projectcalico/calico-containers/pull/864#discussion_r56105779","pull_request_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments/56105779"},"html":{"href":"https://github.com/projectcalico/calico-containers/pull/864#discussion_r56105779"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864","id":62566533,"html_url":"https://github.com/projectcalico/calico-containers/pull/864","diff_url":"https://github.com/projectcalico/calico-containers/pull/864.diff","patch_url":"https://github.com/projectcalico/calico-containers/pull/864.patch","issue_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/864","number":864,"state":"open","locked":false,"title":"Fix IP Pool deletion to correctly remove block affinity","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-11T16:23:41Z","updated_at":"2016-03-15T01:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54f2c0a15fee21f2a4823bbc54f8d615e9c36877","assignee":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/864/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico-containers/statuses/a98ba7e3210aa91adc698abd64aab8121b89413d","head":{"label":"robbrockbank:delete-ip-pool","ref":"delete-ip-pool","sha":"a98ba7e3210aa91adc698abd64aab8121b89413d","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"repo":{"id":38005495,"name":"calico-docker","full_name":"robbrockbank/calico-docker","owner":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robbrockbank/calico-docker","description":"Docker version of Project Calico","fork":true,"url":"https://api.github.com/repos/robbrockbank/calico-docker","forks_url":"https://api.github.com/repos/robbrockbank/calico-docker/forks","keys_url":"https://api.github.com/repos/robbrockbank/calico-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robbrockbank/calico-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robbrockbank/calico-docker/teams","hooks_url":"https://api.github.com/repos/robbrockbank/calico-docker/hooks","issue_events_url":"https://api.github.com/repos/robbrockbank/calico-docker/issues/events{/number}","events_url":"https://api.github.com/repos/robbrockbank/calico-docker/events","assignees_url":"https://api.github.com/repos/robbrockbank/calico-docker/assignees{/user}","branches_url":"https://api.github.com/repos/robbrockbank/calico-docker/branches{/branch}","tags_url":"https://api.github.com/repos/robbrockbank/calico-docker/tags","blobs_url":"https://api.github.com/repos/robbrockbank/calico-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robbrockbank/calico-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robbrockbank/calico-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/robbrockbank/calico-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robbrockbank/calico-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/robbrockbank/calico-docker/languages","stargazers_url":"https://api.github.com/repos/robbrockbank/calico-docker/stargazers","contributors_url":"https://api.github.com/repos/robbrockbank/calico-docker/contributors","subscribers_url":"https://api.github.com/repos/robbrockbank/calico-docker/subscribers","subscription_url":"https://api.github.com/repos/robbrockbank/calico-docker/subscription","commits_url":"https://api.github.com/repos/robbrockbank/calico-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/robbrockbank/calico-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/robbrockbank/calico-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/robbrockbank/calico-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/robbrockbank/calico-docker/contents/{+path}","compare_url":"https://api.github.com/repos/robbrockbank/calico-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robbrockbank/calico-docker/merges","archive_url":"https://api.github.com/repos/robbrockbank/calico-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robbrockbank/calico-docker/downloads","issues_url":"https://api.github.com/repos/robbrockbank/calico-docker/issues{/number}","pulls_url":"https://api.github.com/repos/robbrockbank/calico-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/robbrockbank/calico-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/robbrockbank/calico-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robbrockbank/calico-docker/labels{/name}","releases_url":"https://api.github.com/repos/robbrockbank/calico-docker/releases{/id}","deployments_url":"https://api.github.com/repos/robbrockbank/calico-docker/deployments","created_at":"2015-06-24T19:10:26Z","updated_at":"2015-06-24T19:10:26Z","pushed_at":"2016-03-14T22:13:13Z","git_url":"git://github.com/robbrockbank/calico-docker.git","ssh_url":"git@github.com:robbrockbank/calico-docker.git","clone_url":"https://github.com/robbrockbank/calico-docker.git","svn_url":"https://github.com/robbrockbank/calico-docker","homepage":"http://www.projectcalico.org","size":20220,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"a1f47bfcf2ec77b1744482b798f5426177d2f4c8","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":29629333,"name":"calico-containers","full_name":"projectcalico/calico-containers","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calico-containers","description":"Project Calico deployed in a containerized environment","fork":false,"url":"https://api.github.com/repos/projectcalico/calico-containers","forks_url":"https://api.github.com/repos/projectcalico/calico-containers/forks","keys_url":"https://api.github.com/repos/projectcalico/calico-containers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico-containers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico-containers/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico-containers/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico-containers/events","assignees_url":"https://api.github.com/repos/projectcalico/calico-containers/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico-containers/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico-containers/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico-containers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico-containers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico-containers/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico-containers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico-containers/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico-containers/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico-containers/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico-containers/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico-containers/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico-containers/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico-containers/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico-containers/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico-containers/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico-containers/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico-containers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico-containers/merges","archive_url":"https://api.github.com/repos/projectcalico/calico-containers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico-containers/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico-containers/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico-containers/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico-containers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico-containers/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico-containers/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calico-containers/deployments","created_at":"2015-01-21T23:46:47Z","updated_at":"2016-03-14T10:49:09Z","pushed_at":"2016-03-14T23:31:14Z","git_url":"git://github.com/projectcalico/calico-containers.git","ssh_url":"git@github.com:projectcalico/calico-containers.git","clone_url":"https://github.com/projectcalico/calico-containers.git","svn_url":"https://github.com/projectcalico/calico-containers","homepage":"http://www.projectcalico.org","size":20305,"stargazers_count":328,"watchers_count":328,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":40,"forks":68,"open_issues":40,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864"},"html":{"href":"https://github.com/projectcalico/calico-containers/pull/864"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico-containers/issues/864"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico-containers/issues/864/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/864/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico-containers/statuses/a98ba7e3210aa91adc698abd64aab8121b89413d"}}}}