{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/24","id":78929544,"html_url":"https://github.com/bitzesty/trade-tariff-frontend/pull/24","diff_url":"https://github.com/bitzesty/trade-tariff-frontend/pull/24.diff","patch_url":"https://github.com/bitzesty/trade-tariff-frontend/pull/24.patch","issue_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/24","number":24,"state":"closed","locked":false,"title":"Optimize changes pages","user":{"login":"theharq","id":1143421,"avatar_url":"https://avatars.githubusercontent.com/u/1143421?v=3","gravatar_id":"","url":"https://api.github.com/users/theharq","html_url":"https://github.com/theharq","followers_url":"https://api.github.com/users/theharq/followers","following_url":"https://api.github.com/users/theharq/following{/other_user}","gists_url":"https://api.github.com/users/theharq/gists{/gist_id}","starred_url":"https://api.github.com/users/theharq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theharq/subscriptions","organizations_url":"https://api.github.com/users/theharq/orgs","repos_url":"https://api.github.com/users/theharq/repos","events_url":"https://api.github.com/users/theharq/events{/privacy}","received_events_url":"https://api.github.com/users/theharq/received_events","type":"User","site_admin":false},"body":"#### What this PR does:\r\n\r\nThis PR restore the changes links and makes a minor optimization memoizing the call to the declarable model.. it's a small change but a big performance improvement since the objects do not live in memory but makes a new request to the external API.\r\n\r\nBefore:\r\n\r\n![before](https://cloud.githubusercontent.com/assets/1143421/17156247/6d55f28e-534e-11e6-8dc8-7a7757d32889.png)\r\n\r\nAfter:\r\n\r\n![after](https://cloud.githubusercontent.com/assets/1143421/17156263/81819902-534e-11e6-9f41-faf411a42eb0.png)\r\n\r\n#### Notes\r\n\r\nTo help debugging the logs I've added the `quiet_assets` gem to the development group.\r\n\r\nI've also removed the verbosity of the logs, is more distracting than helpful all the info about the connection and response from the backend.\r\n","created_at":"2016-07-26T21:32:54Z","updated_at":"2016-07-27T22:12:39Z","closed_at":"2016-07-27T22:12:39Z","merged_at":"2016-07-27T22:12:39Z","merge_commit_sha":"f5bb27c4b6b724c450f4d4f346cb22edc01e6faf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/24/commits","review_comments_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/24/comments","review_comment_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/24/comments","statuses_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/statuses/dce02d9d8e7ce856dec9985ab6e0b6b3d1329ca1","head":{"label":"bitzesty:optimize-changes-pages","ref":"optimize-changes-pages","sha":"dce02d9d8e7ce856dec9985ab6e0b6b3d1329ca1","user":{"login":"bitzesty","id":70534,"avatar_url":"https://avatars.githubusercontent.com/u/70534?v=3","gravatar_id":"","url":"https://api.github.com/users/bitzesty","html_url":"https://github.com/bitzesty","followers_url":"https://api.github.com/users/bitzesty/followers","following_url":"https://api.github.com/users/bitzesty/following{/other_user}","gists_url":"https://api.github.com/users/bitzesty/gists{/gist_id}","starred_url":"https://api.github.com/users/bitzesty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitzesty/subscriptions","organizations_url":"https://api.github.com/users/bitzesty/orgs","repos_url":"https://api.github.com/users/bitzesty/repos","events_url":"https://api.github.com/users/bitzesty/events{/privacy}","received_events_url":"https://api.github.com/users/bitzesty/received_events","type":"Organization","site_admin":false},"repo":{"id":18222345,"name":"trade-tariff-frontend","full_name":"bitzesty/trade-tariff-frontend","owner":{"login":"bitzesty","id":70534,"avatar_url":"https://avatars.githubusercontent.com/u/70534?v=3","gravatar_id":"","url":"https://api.github.com/users/bitzesty","html_url":"https://github.com/bitzesty","followers_url":"https://api.github.com/users/bitzesty/followers","following_url":"https://api.github.com/users/bitzesty/following{/other_user}","gists_url":"https://api.github.com/users/bitzesty/gists{/gist_id}","starred_url":"https://api.github.com/users/bitzesty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitzesty/subscriptions","organizations_url":"https://api.github.com/users/bitzesty/orgs","repos_url":"https://api.github.com/users/bitzesty/repos","events_url":"https://api.github.com/users/bitzesty/events{/privacy}","received_events_url":"https://api.github.com/users/bitzesty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitzesty/trade-tariff-frontend","description":"A web application front end for use with the UK Trade Tariff API","fork":true,"url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend","forks_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/forks","keys_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/teams","hooks_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/hooks","issue_events_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/events","assignees_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/tags","blobs_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/languages","stargazers_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/stargazers","contributors_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/contributors","subscribers_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/subscribers","subscription_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/subscription","commits_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/merges","archive_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/downloads","issues_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/deployments","created_at":"2014-03-28T18:34:32Z","updated_at":"2016-01-21T23:06:37Z","pushed_at":"2016-07-27T22:12:39Z","git_url":"git://github.com/bitzesty/trade-tariff-frontend.git","ssh_url":"git@github.com:bitzesty/trade-tariff-frontend.git","clone_url":"https://github.com/bitzesty/trade-tariff-frontend.git","svn_url":"https://github.com/bitzesty/trade-tariff-frontend","homepage":null,"size":13354,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"cf"}},"base":{"label":"bitzesty:cf","ref":"cf","sha":"da702fd09b0a5d0e63325a18e9ca232d6aee3d24","user":{"login":"bitzesty","id":70534,"avatar_url":"https://avatars.githubusercontent.com/u/70534?v=3","gravatar_id":"","url":"https://api.github.com/users/bitzesty","html_url":"https://github.com/bitzesty","followers_url":"https://api.github.com/users/bitzesty/followers","following_url":"https://api.github.com/users/bitzesty/following{/other_user}","gists_url":"https://api.github.com/users/bitzesty/gists{/gist_id}","starred_url":"https://api.github.com/users/bitzesty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitzesty/subscriptions","organizations_url":"https://api.github.com/users/bitzesty/orgs","repos_url":"https://api.github.com/users/bitzesty/repos","events_url":"https://api.github.com/users/bitzesty/events{/privacy}","received_events_url":"https://api.github.com/users/bitzesty/received_events","type":"Organization","site_admin":false},"repo":{"id":18222345,"name":"trade-tariff-frontend","full_name":"bitzesty/trade-tariff-frontend","owner":{"login":"bitzesty","id":70534,"avatar_url":"https://avatars.githubusercontent.com/u/70534?v=3","gravatar_id":"","url":"https://api.github.com/users/bitzesty","html_url":"https://github.com/bitzesty","followers_url":"https://api.github.com/users/bitzesty/followers","following_url":"https://api.github.com/users/bitzesty/following{/other_user}","gists_url":"https://api.github.com/users/bitzesty/gists{/gist_id}","starred_url":"https://api.github.com/users/bitzesty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitzesty/subscriptions","organizations_url":"https://api.github.com/users/bitzesty/orgs","repos_url":"https://api.github.com/users/bitzesty/repos","events_url":"https://api.github.com/users/bitzesty/events{/privacy}","received_events_url":"https://api.github.com/users/bitzesty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitzesty/trade-tariff-frontend","description":"A web application front end for use with the UK Trade Tariff API","fork":true,"url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend","forks_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/forks","keys_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/teams","hooks_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/hooks","issue_events_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/events","assignees_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/tags","blobs_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/languages","stargazers_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/stargazers","contributors_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/contributors","subscribers_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/subscribers","subscription_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/subscription","commits_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/merges","archive_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/downloads","issues_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/deployments","created_at":"2014-03-28T18:34:32Z","updated_at":"2016-01-21T23:06:37Z","pushed_at":"2016-07-27T22:12:39Z","git_url":"git://github.com/bitzesty/trade-tariff-frontend.git","ssh_url":"git@github.com:bitzesty/trade-tariff-frontend.git","clone_url":"https://github.com/bitzesty/trade-tariff-frontend.git","svn_url":"https://github.com/bitzesty/trade-tariff-frontend","homepage":null,"size":13354,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"cf"}},"_links":{"self":{"href":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/24"},"html":{"href":"https://github.com/bitzesty/trade-tariff-frontend/pull/24"},"issue":{"href":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/24"},"comments":{"href":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/bitzesty/trade-tariff-frontend/statuses/dce02d9d8e7ce856dec9985ab6e0b6b3d1329ca1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matthewford","id":215,"avatar_url":"https://avatars.githubusercontent.com/u/215?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewford","html_url":"https://github.com/matthewford","followers_url":"https://api.github.com/users/matthewford/followers","following_url":"https://api.github.com/users/matthewford/following{/other_user}","gists_url":"https://api.github.com/users/matthewford/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewford/subscriptions","organizations_url":"https://api.github.com/users/matthewford/orgs","repos_url":"https://api.github.com/users/matthewford/repos","events_url":"https://api.github.com/users/matthewford/events{/privacy}","received_events_url":"https://api.github.com/users/matthewford/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":31,"deletions":17,"changed_files":10}}
{"actor":{"display_login":"matthewford"}}