{"action":"created","comment":{"url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/comments/87223935","pull_request_review_id":7844011,"id":87223935,"diff_hunk":"@@ -0,0 +1,13 @@\n+# Language choice\n+\n+A guide for determining what language to choose for bug fixes, improvements or new features.\n+Generally, any new class has to be written in Swift, unless it brings many interoperability problems to solve.\n+\n+## Bug fixes and improvements\n+\n+* Bug fixes and improvements are written in the same language of where bugs exist or where improvements need to be done. \n+* If there is a new class to be written, it has to be written in Swift unless it causes many problems specially in Unit Testing the Swift class from Objective-C.","path":"docs/language_choice_guide.md","position":9,"original_position":9,"commit_id":"fe3a0baabc36a6104d1bbaaf898f859cbcb66ee1","original_commit_id":"c7f7dc1b676ec3da3610cf5632a459c80fda1912","user":{"login":"Mourad-Aly","id":1419945,"avatar_url":"https://avatars.githubusercontent.com/u/1419945?v=3","gravatar_id":"","url":"https://api.github.com/users/Mourad-Aly","html_url":"https://github.com/Mourad-Aly","followers_url":"https://api.github.com/users/Mourad-Aly/followers","following_url":"https://api.github.com/users/Mourad-Aly/following{/other_user}","gists_url":"https://api.github.com/users/Mourad-Aly/gists{/gist_id}","starred_url":"https://api.github.com/users/Mourad-Aly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mourad-Aly/subscriptions","organizations_url":"https://api.github.com/users/Mourad-Aly/orgs","repos_url":"https://api.github.com/users/Mourad-Aly/repos","events_url":"https://api.github.com/users/Mourad-Aly/events{/privacy}","received_events_url":"https://api.github.com/users/Mourad-Aly/received_events","type":"User","site_admin":false},"body":"Although i see both of them has same meanings, it's fixed in \tfe3a0ba\r\nAlso, i prefer if you can give this feedback in your first review 🙃","created_at":"2016-11-09T16:14:54Z","updated_at":"2016-11-09T16:14:54Z","html_url":"https://github.com/conichiGMBH/ios-team/pull/34#discussion_r87223935","pull_request_url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/comments/87223935"},"html":{"href":"https://github.com/conichiGMBH/ios-team/pull/34#discussion_r87223935"},"pull_request":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34","id":92826781,"html_url":"https://github.com/conichiGMBH/ios-team/pull/34","diff_url":"https://github.com/conichiGMBH/ios-team/pull/34.diff","patch_url":"https://github.com/conichiGMBH/ios-team/pull/34.patch","issue_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues/34","number":34,"state":"open","locked":false,"title":"Updates for new features flow and branches management","user":{"login":"Mourad-Aly","id":1419945,"avatar_url":"https://avatars.githubusercontent.com/u/1419945?v=3","gravatar_id":"","url":"https://api.github.com/users/Mourad-Aly","html_url":"https://github.com/Mourad-Aly","followers_url":"https://api.github.com/users/Mourad-Aly/followers","following_url":"https://api.github.com/users/Mourad-Aly/following{/other_user}","gists_url":"https://api.github.com/users/Mourad-Aly/gists{/gist_id}","starred_url":"https://api.github.com/users/Mourad-Aly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mourad-Aly/subscriptions","organizations_url":"https://api.github.com/users/Mourad-Aly/orgs","repos_url":"https://api.github.com/users/Mourad-Aly/repos","events_url":"https://api.github.com/users/Mourad-Aly/events{/privacy}","received_events_url":"https://api.github.com/users/Mourad-Aly/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-08T17:50:59Z","updated_at":"2016-11-09T16:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16041e6cd8925e6c79a9d8083648511fff2f5ebe","assignee":{"login":"Antondomashnev","id":2076088,"avatar_url":"https://avatars.githubusercontent.com/u/2076088?v=3","gravatar_id":"","url":"https://api.github.com/users/Antondomashnev","html_url":"https://github.com/Antondomashnev","followers_url":"https://api.github.com/users/Antondomashnev/followers","following_url":"https://api.github.com/users/Antondomashnev/following{/other_user}","gists_url":"https://api.github.com/users/Antondomashnev/gists{/gist_id}","starred_url":"https://api.github.com/users/Antondomashnev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Antondomashnev/subscriptions","organizations_url":"https://api.github.com/users/Antondomashnev/orgs","repos_url":"https://api.github.com/users/Antondomashnev/repos","events_url":"https://api.github.com/users/Antondomashnev/events{/privacy}","received_events_url":"https://api.github.com/users/Antondomashnev/received_events","type":"User","site_admin":false},"assignees":[{"login":"Antondomashnev","id":2076088,"avatar_url":"https://avatars.githubusercontent.com/u/2076088?v=3","gravatar_id":"","url":"https://api.github.com/users/Antondomashnev","html_url":"https://github.com/Antondomashnev","followers_url":"https://api.github.com/users/Antondomashnev/followers","following_url":"https://api.github.com/users/Antondomashnev/following{/other_user}","gists_url":"https://api.github.com/users/Antondomashnev/gists{/gist_id}","starred_url":"https://api.github.com/users/Antondomashnev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Antondomashnev/subscriptions","organizations_url":"https://api.github.com/users/Antondomashnev/orgs","repos_url":"https://api.github.com/users/Antondomashnev/repos","events_url":"https://api.github.com/users/Antondomashnev/events{/privacy}","received_events_url":"https://api.github.com/users/Antondomashnev/received_events","type":"User","site_admin":false},{"login":"wladyslaws","id":23215636,"avatar_url":"https://avatars.githubusercontent.com/u/23215636?v=3","gravatar_id":"","url":"https://api.github.com/users/wladyslaws","html_url":"https://github.com/wladyslaws","followers_url":"https://api.github.com/users/wladyslaws/followers","following_url":"https://api.github.com/users/wladyslaws/following{/other_user}","gists_url":"https://api.github.com/users/wladyslaws/gists{/gist_id}","starred_url":"https://api.github.com/users/wladyslaws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wladyslaws/subscriptions","organizations_url":"https://api.github.com/users/wladyslaws/orgs","repos_url":"https://api.github.com/users/wladyslaws/repos","events_url":"https://api.github.com/users/wladyslaws/events{/privacy}","received_events_url":"https://api.github.com/users/wladyslaws/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34/commits","review_comments_url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34/comments","review_comment_url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues/34/comments","statuses_url":"https://api.github.com/repos/conichiGMBH/ios-team/statuses/fe3a0baabc36a6104d1bbaaf898f859cbcb66ee1","head":{"label":"conichiGMBH:git_protocol_updates","ref":"git_protocol_updates","sha":"fe3a0baabc36a6104d1bbaaf898f859cbcb66ee1","user":{"login":"conichiGMBH","id":10826800,"avatar_url":"https://avatars.githubusercontent.com/u/10826800?v=3","gravatar_id":"","url":"https://api.github.com/users/conichiGMBH","html_url":"https://github.com/conichiGMBH","followers_url":"https://api.github.com/users/conichiGMBH/followers","following_url":"https://api.github.com/users/conichiGMBH/following{/other_user}","gists_url":"https://api.github.com/users/conichiGMBH/gists{/gist_id}","starred_url":"https://api.github.com/users/conichiGMBH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conichiGMBH/subscriptions","organizations_url":"https://api.github.com/users/conichiGMBH/orgs","repos_url":"https://api.github.com/users/conichiGMBH/repos","events_url":"https://api.github.com/users/conichiGMBH/events{/privacy}","received_events_url":"https://api.github.com/users/conichiGMBH/received_events","type":"Organization","site_admin":false},"repo":{"id":51296240,"name":"ios-team","full_name":"conichiGMBH/ios-team","owner":{"login":"conichiGMBH","id":10826800,"avatar_url":"https://avatars.githubusercontent.com/u/10826800?v=3","gravatar_id":"","url":"https://api.github.com/users/conichiGMBH","html_url":"https://github.com/conichiGMBH","followers_url":"https://api.github.com/users/conichiGMBH/followers","following_url":"https://api.github.com/users/conichiGMBH/following{/other_user}","gists_url":"https://api.github.com/users/conichiGMBH/gists{/gist_id}","starred_url":"https://api.github.com/users/conichiGMBH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conichiGMBH/subscriptions","organizations_url":"https://api.github.com/users/conichiGMBH/orgs","repos_url":"https://api.github.com/users/conichiGMBH/repos","events_url":"https://api.github.com/users/conichiGMBH/events{/privacy}","received_events_url":"https://api.github.com/users/conichiGMBH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conichiGMBH/ios-team","description":"home for iOS team at conichi","fork":false,"url":"https://api.github.com/repos/conichiGMBH/ios-team","forks_url":"https://api.github.com/repos/conichiGMBH/ios-team/forks","keys_url":"https://api.github.com/repos/conichiGMBH/ios-team/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conichiGMBH/ios-team/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conichiGMBH/ios-team/teams","hooks_url":"https://api.github.com/repos/conichiGMBH/ios-team/hooks","issue_events_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues/events{/number}","events_url":"https://api.github.com/repos/conichiGMBH/ios-team/events","assignees_url":"https://api.github.com/repos/conichiGMBH/ios-team/assignees{/user}","branches_url":"https://api.github.com/repos/conichiGMBH/ios-team/branches{/branch}","tags_url":"https://api.github.com/repos/conichiGMBH/ios-team/tags","blobs_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/refs{/sha}","trees_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conichiGMBH/ios-team/statuses/{sha}","languages_url":"https://api.github.com/repos/conichiGMBH/ios-team/languages","stargazers_url":"https://api.github.com/repos/conichiGMBH/ios-team/stargazers","contributors_url":"https://api.github.com/repos/conichiGMBH/ios-team/contributors","subscribers_url":"https://api.github.com/repos/conichiGMBH/ios-team/subscribers","subscription_url":"https://api.github.com/repos/conichiGMBH/ios-team/subscription","commits_url":"https://api.github.com/repos/conichiGMBH/ios-team/commits{/sha}","git_commits_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/commits{/sha}","comments_url":"https://api.github.com/repos/conichiGMBH/ios-team/comments{/number}","issue_comment_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues/comments{/number}","contents_url":"https://api.github.com/repos/conichiGMBH/ios-team/contents/{+path}","compare_url":"https://api.github.com/repos/conichiGMBH/ios-team/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conichiGMBH/ios-team/merges","archive_url":"https://api.github.com/repos/conichiGMBH/ios-team/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conichiGMBH/ios-team/downloads","issues_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues{/number}","pulls_url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls{/number}","milestones_url":"https://api.github.com/repos/conichiGMBH/ios-team/milestones{/number}","notifications_url":"https://api.github.com/repos/conichiGMBH/ios-team/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conichiGMBH/ios-team/labels{/name}","releases_url":"https://api.github.com/repos/conichiGMBH/ios-team/releases{/id}","deployments_url":"https://api.github.com/repos/conichiGMBH/ios-team/deployments","created_at":"2016-02-08T12:18:57Z","updated_at":"2016-10-26T21:13:53Z","pushed_at":"2016-11-09T16:14:09Z","git_url":"git://github.com/conichiGMBH/ios-team.git","ssh_url":"git@github.com:conichiGMBH/ios-team.git","clone_url":"https://github.com/conichiGMBH/ios-team.git","svn_url":"https://github.com/conichiGMBH/ios-team","homepage":"","size":64,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"conichiGMBH:master","ref":"master","sha":"55e0366eac3400e965015602c6e9b9b6486d083a","user":{"login":"conichiGMBH","id":10826800,"avatar_url":"https://avatars.githubusercontent.com/u/10826800?v=3","gravatar_id":"","url":"https://api.github.com/users/conichiGMBH","html_url":"https://github.com/conichiGMBH","followers_url":"https://api.github.com/users/conichiGMBH/followers","following_url":"https://api.github.com/users/conichiGMBH/following{/other_user}","gists_url":"https://api.github.com/users/conichiGMBH/gists{/gist_id}","starred_url":"https://api.github.com/users/conichiGMBH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conichiGMBH/subscriptions","organizations_url":"https://api.github.com/users/conichiGMBH/orgs","repos_url":"https://api.github.com/users/conichiGMBH/repos","events_url":"https://api.github.com/users/conichiGMBH/events{/privacy}","received_events_url":"https://api.github.com/users/conichiGMBH/received_events","type":"Organization","site_admin":false},"repo":{"id":51296240,"name":"ios-team","full_name":"conichiGMBH/ios-team","owner":{"login":"conichiGMBH","id":10826800,"avatar_url":"https://avatars.githubusercontent.com/u/10826800?v=3","gravatar_id":"","url":"https://api.github.com/users/conichiGMBH","html_url":"https://github.com/conichiGMBH","followers_url":"https://api.github.com/users/conichiGMBH/followers","following_url":"https://api.github.com/users/conichiGMBH/following{/other_user}","gists_url":"https://api.github.com/users/conichiGMBH/gists{/gist_id}","starred_url":"https://api.github.com/users/conichiGMBH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conichiGMBH/subscriptions","organizations_url":"https://api.github.com/users/conichiGMBH/orgs","repos_url":"https://api.github.com/users/conichiGMBH/repos","events_url":"https://api.github.com/users/conichiGMBH/events{/privacy}","received_events_url":"https://api.github.com/users/conichiGMBH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conichiGMBH/ios-team","description":"home for iOS team at conichi","fork":false,"url":"https://api.github.com/repos/conichiGMBH/ios-team","forks_url":"https://api.github.com/repos/conichiGMBH/ios-team/forks","keys_url":"https://api.github.com/repos/conichiGMBH/ios-team/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conichiGMBH/ios-team/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conichiGMBH/ios-team/teams","hooks_url":"https://api.github.com/repos/conichiGMBH/ios-team/hooks","issue_events_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues/events{/number}","events_url":"https://api.github.com/repos/conichiGMBH/ios-team/events","assignees_url":"https://api.github.com/repos/conichiGMBH/ios-team/assignees{/user}","branches_url":"https://api.github.com/repos/conichiGMBH/ios-team/branches{/branch}","tags_url":"https://api.github.com/repos/conichiGMBH/ios-team/tags","blobs_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/refs{/sha}","trees_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conichiGMBH/ios-team/statuses/{sha}","languages_url":"https://api.github.com/repos/conichiGMBH/ios-team/languages","stargazers_url":"https://api.github.com/repos/conichiGMBH/ios-team/stargazers","contributors_url":"https://api.github.com/repos/conichiGMBH/ios-team/contributors","subscribers_url":"https://api.github.com/repos/conichiGMBH/ios-team/subscribers","subscription_url":"https://api.github.com/repos/conichiGMBH/ios-team/subscription","commits_url":"https://api.github.com/repos/conichiGMBH/ios-team/commits{/sha}","git_commits_url":"https://api.github.com/repos/conichiGMBH/ios-team/git/commits{/sha}","comments_url":"https://api.github.com/repos/conichiGMBH/ios-team/comments{/number}","issue_comment_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues/comments{/number}","contents_url":"https://api.github.com/repos/conichiGMBH/ios-team/contents/{+path}","compare_url":"https://api.github.com/repos/conichiGMBH/ios-team/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conichiGMBH/ios-team/merges","archive_url":"https://api.github.com/repos/conichiGMBH/ios-team/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conichiGMBH/ios-team/downloads","issues_url":"https://api.github.com/repos/conichiGMBH/ios-team/issues{/number}","pulls_url":"https://api.github.com/repos/conichiGMBH/ios-team/pulls{/number}","milestones_url":"https://api.github.com/repos/conichiGMBH/ios-team/milestones{/number}","notifications_url":"https://api.github.com/repos/conichiGMBH/ios-team/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conichiGMBH/ios-team/labels{/name}","releases_url":"https://api.github.com/repos/conichiGMBH/ios-team/releases{/id}","deployments_url":"https://api.github.com/repos/conichiGMBH/ios-team/deployments","created_at":"2016-02-08T12:18:57Z","updated_at":"2016-10-26T21:13:53Z","pushed_at":"2016-11-09T16:14:09Z","git_url":"git://github.com/conichiGMBH/ios-team.git","ssh_url":"git@github.com:conichiGMBH/ios-team.git","clone_url":"https://github.com/conichiGMBH/ios-team.git","svn_url":"https://github.com/conichiGMBH/ios-team","homepage":"","size":64,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34"},"html":{"href":"https://github.com/conichiGMBH/ios-team/pull/34"},"issue":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/issues/34"},"comments":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/conichiGMBH/ios-team/statuses/fe3a0baabc36a6104d1bbaaf898f859cbcb66ee1"}}}}
{"actor":{"display_login":"Mourad-Aly"}}