{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/56435411","id":56435411,"diff_hunk":"@@ -558,10 +559,29 @@ export class BaseElement {\n    * @protected\n    */\n   attemptChangeHeight(newHeight, opt_callback) {\n-    this.resources_.attemptChangeHeight(this.element, newHeight, opt_callback);\n+    this.resources_.attemptChangeSize(\n+        this.element, newHeight, /** newWidth */undefined, opt_callback);\n   }\n \n  /**\n+  * Requests the runtime to update the size of this element to the specified\n+  * values. The runtime will schedule this request and attempt to process it\n+  * as soon as possible. However, unlike in {@link changeSize}, the runtime\n+  * may refuse to make a change in which case it will show the element's\n+  * overflow element if provided, which is supposed to provide the reader with\n+  * the necessary user action. (The overflow element is shown only if the\n+  * requested height is greater than 0.)\n+  * If the height is successfully updated then the opt_callback is called.\n+  * @param {number} newHeight\n+  * @param {function=} opt_callback A callback function.","path":"src/base-element.js","position":29,"original_position":29,"commit_id":"9abc76afbdc2d1bf13a32e63a7f03bc6df711684","original_commit_id":"9abc76afbdc2d1bf13a32e63a7f03bc6df711684","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"body":"add `@param ... newWidth`","created_at":"2016-03-16T23:45:34Z","updated_at":"2016-03-16T23:45:34Z","html_url":"https://github.com/ampproject/amphtml/pull/2584#discussion_r56435411","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2584","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/56435411"},"html":{"href":"https://github.com/ampproject/amphtml/pull/2584#discussion_r56435411"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2584"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/2584","id":62834119,"html_url":"https://github.com/ampproject/amphtml/pull/2584","diff_url":"https://github.com/ampproject/amphtml/pull/2584.diff","patch_url":"https://github.com/ampproject/amphtml/pull/2584.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/2584","number":2584,"state":"open","locked":false,"title":"Replace change height with change size - Make resize width actually change the width.","user":{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false},"body":"fixes #2192 ","created_at":"2016-03-14T23:32:00Z","updated_at":"2016-03-16T23:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45cb355b299cf709dcbb62021c8e040dcd129f93","assignee":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2584/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2584/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/2584/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/9abc76afbdc2d1bf13a32e63a7f03bc6df711684","head":{"label":"sriramkrish85:resize","ref":"resize","sha":"9abc76afbdc2d1bf13a32e63a7f03bc6df711684","user":{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false},"repo":{"id":44337813,"name":"amphtml","full_name":"sriramkrish85/amphtml","owner":{"login":"sriramkrish85","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/sriramkrish85","html_url":"https://github.com/sriramkrish85","followers_url":"https://api.github.com/users/sriramkrish85/followers","following_url":"https://api.github.com/users/sriramkrish85/following{/other_user}","gists_url":"https://api.github.com/users/sriramkrish85/gists{/gist_id}","starred_url":"https://api.github.com/users/sriramkrish85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriramkrish85/subscriptions","organizations_url":"https://api.github.com/users/sriramkrish85/orgs","repos_url":"https://api.github.com/users/sriramkrish85/repos","events_url":"https://api.github.com/users/sriramkrish85/events{/privacy}","received_events_url":"https://api.github.com/users/sriramkrish85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sriramkrish85/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/sriramkrish85/amphtml","forks_url":"https://api.github.com/repos/sriramkrish85/amphtml/forks","keys_url":"https://api.github.com/repos/sriramkrish85/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sriramkrish85/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sriramkrish85/amphtml/teams","hooks_url":"https://api.github.com/repos/sriramkrish85/amphtml/hooks","issue_events_url":"https://api.github.com/repos/sriramkrish85/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/sriramkrish85/amphtml/events","assignees_url":"https://api.github.com/repos/sriramkrish85/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/sriramkrish85/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/sriramkrish85/amphtml/tags","blobs_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sriramkrish85/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/sriramkrish85/amphtml/languages","stargazers_url":"https://api.github.com/repos/sriramkrish85/amphtml/stargazers","contributors_url":"https://api.github.com/repos/sriramkrish85/amphtml/contributors","subscribers_url":"https://api.github.com/repos/sriramkrish85/amphtml/subscribers","subscription_url":"https://api.github.com/repos/sriramkrish85/amphtml/subscription","commits_url":"https://api.github.com/repos/sriramkrish85/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/sriramkrish85/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/sriramkrish85/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/sriramkrish85/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/sriramkrish85/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/sriramkrish85/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sriramkrish85/amphtml/merges","archive_url":"https://api.github.com/repos/sriramkrish85/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sriramkrish85/amphtml/downloads","issues_url":"https://api.github.com/repos/sriramkrish85/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/sriramkrish85/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/sriramkrish85/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/sriramkrish85/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sriramkrish85/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/sriramkrish85/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/sriramkrish85/amphtml/deployments","created_at":"2015-10-15T18:39:52Z","updated_at":"2016-01-13T02:54:37Z","pushed_at":"2016-03-16T21:10:08Z","git_url":"git://github.com/sriramkrish85/amphtml.git","ssh_url":"git@github.com:sriramkrish85/amphtml.git","clone_url":"https://github.com/sriramkrish85/amphtml.git","svn_url":"https://github.com/sriramkrish85/amphtml","homepage":"https://ampproject.org","size":31147,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"e33d632b50ac1075e0d3698dc2d369a072c36f0d","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-03-16T22:35:20Z","pushed_at":"2016-03-16T23:40:37Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":42368,"stargazers_count":6887,"watchers_count":6887,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":833,"mirror_url":null,"open_issues_count":353,"forks":833,"open_issues":353,"watchers":6887,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2584"},"html":{"href":"https://github.com/ampproject/amphtml/pull/2584"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/2584"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/2584/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2584/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2584/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/9abc76afbdc2d1bf13a32e63a7f03bc6df711684"}}}}