{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/55703219","id":55703219,"diff_hunk":"@@ -100,6 +100,13 @@ angular.module(\"openshiftConsole\")\n             scope.buildConfig.contextDir = annotations.sampleContextDir || \"\";\n           };\n \n+          scope.usingSampleRepo = function() {\n+            if (!scope.image && !scope.image.metadata && !scope.image.metadata.annotations) {\n+              return false;\n+            }\n+            return scope.buildConfig.sourceUrl === scope.image.metadata.annotations.sampleRepo;","path":"assets/app/scripts/controllers/create/createFromImage.js","position":8,"original_position":8,"commit_id":"e91e1f0527026f00be49563a1cdf41c197d084fb","original_commit_id":"e91e1f0527026f00be49563a1cdf41c197d084fb","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"body":"this function can be simplified down to\r\n\r\n````\r\nreturn _.get('scope.image.metadata.annotations.sampleRepo');\r\n```","created_at":"2016-03-10T16:11:48Z","updated_at":"2016-03-10T16:11:48Z","html_url":"https://github.com/openshift/origin/pull/7915#discussion_r55703219","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/7915","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/55703219"},"html":{"href":"https://github.com/openshift/origin/pull/7915#discussion_r55703219"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/7915"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7915","id":62302938,"html_url":"https://github.com/openshift/origin/pull/7915","diff_url":"https://github.com/openshift/origin/pull/7915.diff","patch_url":"https://github.com/openshift/origin/pull/7915.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/7915","number":7915,"state":"open","locked":false,"title":"Improved next steps page for bcs using sample repos","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"body":"When creating from image on the web console, make the \"Next Steps\" page smart enough to know when it's being created from one of the sample repositories suggested in the creation flow, and if so, adjust the suggestions about setting up webhooks on GitHub properly.\r\n\r\nSample: creating from own repo\r\n![next-steps-own-repo](https://cloud.githubusercontent.com/assets/158611/13650617/43b7a24a-e622-11e5-984d-1ae5ab0680f0.png)\r\n\r\nSample: creating from sample repo\r\n![next-steps-sample-repo](https://cloud.githubusercontent.com/assets/158611/13650629/4df66368-e622-11e5-8f7f-b96f7e3fe806.png)\r\n\r\nFixes https://github.com/openshift/origin/issues/7865\r\n\r\n@jwforres PTAL, feel free to suggest changes. Notice I'm relying on a route param so we don't have to get the image again in the next steps page.","created_at":"2016-03-09T21:56:57Z","updated_at":"2016-03-10T16:11:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdd593bac1d0581e769109a2ad96969e9f8fa73e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/7915/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/7915/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7915/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/e91e1f0527026f00be49563a1cdf41c197d084fb","head":{"label":"fabianofranz:issues_7865","ref":"issues_7865","sha":"e91e1f0527026f00be49563a1cdf41c197d084fb","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"repo":{"id":23366851,"name":"origin","full_name":"fabianofranz/origin","owner":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabianofranz/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/fabianofranz/origin","forks_url":"https://api.github.com/repos/fabianofranz/origin/forks","keys_url":"https://api.github.com/repos/fabianofranz/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabianofranz/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabianofranz/origin/teams","hooks_url":"https://api.github.com/repos/fabianofranz/origin/hooks","issue_events_url":"https://api.github.com/repos/fabianofranz/origin/issues/events{/number}","events_url":"https://api.github.com/repos/fabianofranz/origin/events","assignees_url":"https://api.github.com/repos/fabianofranz/origin/assignees{/user}","branches_url":"https://api.github.com/repos/fabianofranz/origin/branches{/branch}","tags_url":"https://api.github.com/repos/fabianofranz/origin/tags","blobs_url":"https://api.github.com/repos/fabianofranz/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabianofranz/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabianofranz/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabianofranz/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabianofranz/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabianofranz/origin/languages","stargazers_url":"https://api.github.com/repos/fabianofranz/origin/stargazers","contributors_url":"https://api.github.com/repos/fabianofranz/origin/contributors","subscribers_url":"https://api.github.com/repos/fabianofranz/origin/subscribers","subscription_url":"https://api.github.com/repos/fabianofranz/origin/subscription","commits_url":"https://api.github.com/repos/fabianofranz/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabianofranz/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabianofranz/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabianofranz/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabianofranz/origin/contents/{+path}","compare_url":"https://api.github.com/repos/fabianofranz/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabianofranz/origin/merges","archive_url":"https://api.github.com/repos/fabianofranz/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabianofranz/origin/downloads","issues_url":"https://api.github.com/repos/fabianofranz/origin/issues{/number}","pulls_url":"https://api.github.com/repos/fabianofranz/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabianofranz/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabianofranz/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabianofranz/origin/labels{/name}","releases_url":"https://api.github.com/repos/fabianofranz/origin/releases{/id}","deployments_url":"https://api.github.com/repos/fabianofranz/origin/deployments","created_at":"2014-08-26T21:06:40Z","updated_at":"2015-04-24T16:39:47Z","pushed_at":"2016-03-10T01:40:25Z","git_url":"git://github.com/fabianofranz/origin.git","ssh_url":"git@github.com:fabianofranz/origin.git","clone_url":"https://github.com/fabianofranz/origin.git","svn_url":"https://github.com/fabianofranz/origin","homepage":"https://openshift.github.io","size":236101,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"728d467c841c0e9b66cfbb00f15c52ee36b86ec0","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-03-10T14:04:49Z","pushed_at":"2016-03-10T15:42:53Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":300131,"stargazers_count":1109,"watchers_count":1109,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":689,"mirror_url":null,"open_issues_count":926,"forks":689,"open_issues":926,"watchers":1109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/7915"},"html":{"href":"https://github.com/openshift/origin/pull/7915"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/7915"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/7915/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/7915/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/7915/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/e91e1f0527026f00be49563a1cdf41c197d084fb"}}}}