{"action":"created","comment":{"url":"https://api.github.com/repos/jacoco/jacoco/pulls/comments/88777165","pull_request_review_id":9343331,"id":88777165,"diff_hunk":"@@ -41,11 +41,26 @@\n   the tests with the <tt>javaagent</tt> set and no coverage would be recorded.\n </p>\n \n+<p class=\"hint\">\n+  When using the <tt>maven-surefire-plugin</tt> with custom <a href=\"http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine\">\n+   <tt>argLine</tt></a> you need to append <tt>@{argLine}</tt> to the custom <tt>argLine</tt><br>\n+   <tt>&lt;argLine&gt;-Xms1024m -Xmx2048m <b>@{argLine}</b>&lt;/argLine&gt;</tt>\n+</p>\n+\n+<p class=\"hint\">\n+  For a multi-module maven project using <tt>maven-surefire-plugin</tt> with custom <a href=\"http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine\">\n+  <tt>argLine</tt></a> and not running JaCoCo runtime agent in all modules, you can set an empty <tt>argLine</tt> property.\n+  This will prevent the build from failing with message <tt>Error: Could not find or load main class @{argLine}</tt>.<br>\n+  This is required because undeclared property is not expanded to empty string during <a href=\"http://maven.apache.org/surefire/maven-surefire-plugin/faq.html#late-property-evaluation\">\n+  late property evaluation</a> in <tt>maven-surefire-plugin</tt>.<br>\n+  <tt>&lt;properties&gt;&lt;argLine&gt;&lt;/argLine&gt;&lt;/properties&gt;</tt>\n+</p>","path":"org.jacoco.doc/docroot/doc/maven.html","position":26,"original_position":26,"commit_id":"6283d77ae57a641e8a44904941409f71d4f33fdd","original_commit_id":"6283d77ae57a641e8a44904941409f71d4f33fdd","user":{"login":"Godin","id":138671,"avatar_url":"https://avatars.githubusercontent.com/u/138671?v=3","gravatar_id":"","url":"https://api.github.com/users/Godin","html_url":"https://github.com/Godin","followers_url":"https://api.github.com/users/Godin/followers","following_url":"https://api.github.com/users/Godin/following{/other_user}","gists_url":"https://api.github.com/users/Godin/gists{/gist_id}","starred_url":"https://api.github.com/users/Godin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godin/subscriptions","organizations_url":"https://api.github.com/users/Godin/orgs","repos_url":"https://api.github.com/users/Godin/repos","events_url":"https://api.github.com/users/Godin/events{/privacy}","received_events_url":"https://api.github.com/users/Godin/received_events","type":"User","site_admin":false},"body":"We already have note about `argLine` on [page dedicated to `prepare-agent` mojo](http://www.eclemma.org/jacoco/trunk/doc/prepare-agent-mojo.html) page that is rendered from its [javadoc](https://github.com/jacoco/jacoco/blob/0988e8c083f34f84312056dc7782488c6e147504/jacoco-maven-plugin/src/org/jacoco/maven/AgentMojo.java#L40), which is btw also visible on `mvn jacoco:help`. So seems more logical to relocate this change to the javadoc. And only part about empty property is missing in it.","created_at":"2016-11-19T10:31:45Z","updated_at":"2016-11-19T10:39:41Z","html_url":"https://github.com/jacoco/jacoco/pull/465#discussion_r88777165","pull_request_url":"https://api.github.com/repos/jacoco/jacoco/pulls/465","_links":{"self":{"href":"https://api.github.com/repos/jacoco/jacoco/pulls/comments/88777165"},"html":{"href":"https://github.com/jacoco/jacoco/pull/465#discussion_r88777165"},"pull_request":{"href":"https://api.github.com/repos/jacoco/jacoco/pulls/465"}}},"pull_request":{"url":"https://api.github.com/repos/jacoco/jacoco/pulls/465","id":94463172,"html_url":"https://github.com/jacoco/jacoco/pull/465","diff_url":"https://github.com/jacoco/jacoco/pull/465.diff","patch_url":"https://github.com/jacoco/jacoco/pull/465.patch","issue_url":"https://api.github.com/repos/jacoco/jacoco/issues/465","number":465,"state":"open","locked":false,"title":"Add hints about surefire-plugin and argLine.","user":{"login":"nikhilnanivadekar","id":9932381,"avatar_url":"https://avatars.githubusercontent.com/u/9932381?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilnanivadekar","html_url":"https://github.com/nikhilnanivadekar","followers_url":"https://api.github.com/users/nikhilnanivadekar/followers","following_url":"https://api.github.com/users/nikhilnanivadekar/following{/other_user}","gists_url":"https://api.github.com/users/nikhilnanivadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilnanivadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilnanivadekar/subscriptions","organizations_url":"https://api.github.com/users/nikhilnanivadekar/orgs","repos_url":"https://api.github.com/users/nikhilnanivadekar/repos","events_url":"https://api.github.com/users/nikhilnanivadekar/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilnanivadekar/received_events","type":"User","site_admin":false},"body":"Add hints for the issues faced during integration of JaCoCo with [Eclipse Collections](http://www.eclipse.org/collections/). \r\nEclipse Collections Pull Request: https://github.com/eclipse/eclipse-collections/pull/166","created_at":"2016-11-19T01:07:19Z","updated_at":"2016-11-19T10:39:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f594c6f95bf3f1002d2c2403d6bdde5d7495d6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jacoco/jacoco/pulls/465/commits","review_comments_url":"https://api.github.com/repos/jacoco/jacoco/pulls/465/comments","review_comment_url":"https://api.github.com/repos/jacoco/jacoco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jacoco/jacoco/issues/465/comments","statuses_url":"https://api.github.com/repos/jacoco/jacoco/statuses/6283d77ae57a641e8a44904941409f71d4f33fdd","head":{"label":"nikhilnanivadekar:master","ref":"master","sha":"6283d77ae57a641e8a44904941409f71d4f33fdd","user":{"login":"nikhilnanivadekar","id":9932381,"avatar_url":"https://avatars.githubusercontent.com/u/9932381?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilnanivadekar","html_url":"https://github.com/nikhilnanivadekar","followers_url":"https://api.github.com/users/nikhilnanivadekar/followers","following_url":"https://api.github.com/users/nikhilnanivadekar/following{/other_user}","gists_url":"https://api.github.com/users/nikhilnanivadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilnanivadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilnanivadekar/subscriptions","organizations_url":"https://api.github.com/users/nikhilnanivadekar/orgs","repos_url":"https://api.github.com/users/nikhilnanivadekar/repos","events_url":"https://api.github.com/users/nikhilnanivadekar/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilnanivadekar/received_events","type":"User","site_admin":false},"repo":{"id":74177008,"name":"jacoco","full_name":"nikhilnanivadekar/jacoco","owner":{"login":"nikhilnanivadekar","id":9932381,"avatar_url":"https://avatars.githubusercontent.com/u/9932381?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilnanivadekar","html_url":"https://github.com/nikhilnanivadekar","followers_url":"https://api.github.com/users/nikhilnanivadekar/followers","following_url":"https://api.github.com/users/nikhilnanivadekar/following{/other_user}","gists_url":"https://api.github.com/users/nikhilnanivadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilnanivadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilnanivadekar/subscriptions","organizations_url":"https://api.github.com/users/nikhilnanivadekar/orgs","repos_url":"https://api.github.com/users/nikhilnanivadekar/repos","events_url":"https://api.github.com/users/nikhilnanivadekar/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilnanivadekar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhilnanivadekar/jacoco","description":":microscope: JaCoCo - Java Code Coverage Library","fork":true,"url":"https://api.github.com/repos/nikhilnanivadekar/jacoco","forks_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/forks","keys_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/teams","hooks_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/hooks","issue_events_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/issues/events{/number}","events_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/events","assignees_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/assignees{/user}","branches_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/branches{/branch}","tags_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/tags","blobs_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/languages","stargazers_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/stargazers","contributors_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/contributors","subscribers_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/subscribers","subscription_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/subscription","commits_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/contents/{+path}","compare_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/merges","archive_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/downloads","issues_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/issues{/number}","pulls_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/labels{/name}","releases_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/releases{/id}","deployments_url":"https://api.github.com/repos/nikhilnanivadekar/jacoco/deployments","created_at":"2016-11-19T00:27:27Z","updated_at":"2016-11-19T00:27:30Z","pushed_at":"2016-11-19T01:02:12Z","git_url":"git://github.com/nikhilnanivadekar/jacoco.git","ssh_url":"git@github.com:nikhilnanivadekar/jacoco.git","clone_url":"https://github.com/nikhilnanivadekar/jacoco.git","svn_url":"https://github.com/nikhilnanivadekar/jacoco","homepage":"http://jacoco.org/jacoco/","size":7518,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jacoco:master","ref":"master","sha":"0988e8c083f34f84312056dc7782488c6e147504","user":{"login":"jacoco","id":1939631,"avatar_url":"https://avatars.githubusercontent.com/u/1939631?v=3","gravatar_id":"","url":"https://api.github.com/users/jacoco","html_url":"https://github.com/jacoco","followers_url":"https://api.github.com/users/jacoco/followers","following_url":"https://api.github.com/users/jacoco/following{/other_user}","gists_url":"https://api.github.com/users/jacoco/gists{/gist_id}","starred_url":"https://api.github.com/users/jacoco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacoco/subscriptions","organizations_url":"https://api.github.com/users/jacoco/orgs","repos_url":"https://api.github.com/users/jacoco/repos","events_url":"https://api.github.com/users/jacoco/events{/privacy}","received_events_url":"https://api.github.com/users/jacoco/received_events","type":"Organization","site_admin":false},"repo":{"id":4950187,"name":"jacoco","full_name":"jacoco/jacoco","owner":{"login":"jacoco","id":1939631,"avatar_url":"https://avatars.githubusercontent.com/u/1939631?v=3","gravatar_id":"","url":"https://api.github.com/users/jacoco","html_url":"https://github.com/jacoco","followers_url":"https://api.github.com/users/jacoco/followers","following_url":"https://api.github.com/users/jacoco/following{/other_user}","gists_url":"https://api.github.com/users/jacoco/gists{/gist_id}","starred_url":"https://api.github.com/users/jacoco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacoco/subscriptions","organizations_url":"https://api.github.com/users/jacoco/orgs","repos_url":"https://api.github.com/users/jacoco/repos","events_url":"https://api.github.com/users/jacoco/events{/privacy}","received_events_url":"https://api.github.com/users/jacoco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jacoco/jacoco","description":":microscope: JaCoCo - Java Code Coverage Library","fork":false,"url":"https://api.github.com/repos/jacoco/jacoco","forks_url":"https://api.github.com/repos/jacoco/jacoco/forks","keys_url":"https://api.github.com/repos/jacoco/jacoco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacoco/jacoco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacoco/jacoco/teams","hooks_url":"https://api.github.com/repos/jacoco/jacoco/hooks","issue_events_url":"https://api.github.com/repos/jacoco/jacoco/issues/events{/number}","events_url":"https://api.github.com/repos/jacoco/jacoco/events","assignees_url":"https://api.github.com/repos/jacoco/jacoco/assignees{/user}","branches_url":"https://api.github.com/repos/jacoco/jacoco/branches{/branch}","tags_url":"https://api.github.com/repos/jacoco/jacoco/tags","blobs_url":"https://api.github.com/repos/jacoco/jacoco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacoco/jacoco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacoco/jacoco/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacoco/jacoco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacoco/jacoco/statuses/{sha}","languages_url":"https://api.github.com/repos/jacoco/jacoco/languages","stargazers_url":"https://api.github.com/repos/jacoco/jacoco/stargazers","contributors_url":"https://api.github.com/repos/jacoco/jacoco/contributors","subscribers_url":"https://api.github.com/repos/jacoco/jacoco/subscribers","subscription_url":"https://api.github.com/repos/jacoco/jacoco/subscription","commits_url":"https://api.github.com/repos/jacoco/jacoco/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacoco/jacoco/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacoco/jacoco/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacoco/jacoco/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacoco/jacoco/contents/{+path}","compare_url":"https://api.github.com/repos/jacoco/jacoco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacoco/jacoco/merges","archive_url":"https://api.github.com/repos/jacoco/jacoco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacoco/jacoco/downloads","issues_url":"https://api.github.com/repos/jacoco/jacoco/issues{/number}","pulls_url":"https://api.github.com/repos/jacoco/jacoco/pulls{/number}","milestones_url":"https://api.github.com/repos/jacoco/jacoco/milestones{/number}","notifications_url":"https://api.github.com/repos/jacoco/jacoco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacoco/jacoco/labels{/name}","releases_url":"https://api.github.com/repos/jacoco/jacoco/releases{/id}","deployments_url":"https://api.github.com/repos/jacoco/jacoco/deployments","created_at":"2012-07-08T21:45:13Z","updated_at":"2016-11-18T08:23:50Z","pushed_at":"2016-11-19T01:07:19Z","git_url":"git://github.com/jacoco/jacoco.git","ssh_url":"git@github.com:jacoco/jacoco.git","clone_url":"https://github.com/jacoco/jacoco.git","svn_url":"https://github.com/jacoco/jacoco","homepage":"http://jacoco.org/jacoco/","size":15973,"stargazers_count":604,"watchers_count":604,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":64,"forks":259,"open_issues":64,"watchers":604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jacoco/jacoco/pulls/465"},"html":{"href":"https://github.com/jacoco/jacoco/pull/465"},"issue":{"href":"https://api.github.com/repos/jacoco/jacoco/issues/465"},"comments":{"href":"https://api.github.com/repos/jacoco/jacoco/issues/465/comments"},"review_comments":{"href":"https://api.github.com/repos/jacoco/jacoco/pulls/465/comments"},"review_comment":{"href":"https://api.github.com/repos/jacoco/jacoco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jacoco/jacoco/pulls/465/commits"},"statuses":{"href":"https://api.github.com/repos/jacoco/jacoco/statuses/6283d77ae57a641e8a44904941409f71d4f33fdd"}}}}
{"actor":{"display_login":"Godin"}}