{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/nvml/issues/819","repository_url":"https://api.github.com/repos/pmem/nvml","labels_url":"https://api.github.com/repos/pmem/nvml/issues/819/labels{/name}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/819/comments","events_url":"https://api.github.com/repos/pmem/nvml/issues/819/events","html_url":"https://github.com/pmem/nvml/pull/819","id":154911718,"number":819,"title":"test: add windows UT support and multiple tests and VS projects","user":{"login":"peluse","id":4650360,"avatar_url":"https://avatars.githubusercontent.com/u/4650360?v=3","gravatar_id":"","url":"https://api.github.com/users/peluse","html_url":"https://github.com/peluse","followers_url":"https://api.github.com/users/peluse/followers","following_url":"https://api.github.com/users/peluse/following{/other_user}","gists_url":"https://api.github.com/users/peluse/gists{/gist_id}","starred_url":"https://api.github.com/users/peluse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peluse/subscriptions","organizations_url":"https://api.github.com/users/peluse/orgs","repos_url":"https://api.github.com/users/peluse/repos","events_url":"https://api.github.com/users/peluse/events{/privacy}","received_events_url":"https://api.github.com/users/peluse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-05-15T14:36:27Z","updated_at":"2016-05-19T15:24:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/819","html_url":"https://github.com/pmem/nvml/pull/819","diff_url":"https://github.com/pmem/nvml/pull/819.diff","patch_url":"https://github.com/pmem/nvml/pull/819.patch"},"body":"Also misc modifications to support windows compilation. Not all\r\ntests are included in this patch, just the required framework,\r\ntwo sets of tests, blk_nblock and blk_non_zero, and several but\r\nnot all VS project files for the tests\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/819)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/nvml/issues/comments/220359182","html_url":"https://github.com/pmem/nvml/pull/819#issuecomment-220359182","issue_url":"https://api.github.com/repos/pmem/nvml/issues/819","id":220359182,"user":{"login":"marcinslusarz","id":12811376,"avatar_url":"https://avatars.githubusercontent.com/u/12811376?v=3","gravatar_id":"","url":"https://api.github.com/users/marcinslusarz","html_url":"https://github.com/marcinslusarz","followers_url":"https://api.github.com/users/marcinslusarz/followers","following_url":"https://api.github.com/users/marcinslusarz/following{/other_user}","gists_url":"https://api.github.com/users/marcinslusarz/gists{/gist_id}","starred_url":"https://api.github.com/users/marcinslusarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcinslusarz/subscriptions","organizations_url":"https://api.github.com/users/marcinslusarz/orgs","repos_url":"https://api.github.com/users/marcinslusarz/repos","events_url":"https://api.github.com/users/marcinslusarz/events{/privacy}","received_events_url":"https://api.github.com/users/marcinslusarz/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T15:24:08Z","updated_at":"2016-05-19T15:24:08Z","body":"\n\n\n\n\n\nReview status: 57 of 101 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[src/libpmemobj/memblock.c, line 87 \\[r5\\]](https://reviewable.io:443/reviews/pmem/nvml/819#-KI8_SY6LvG6wuL-qMun:-KI8bQ9B-Ldse10t52Kf:-2000955550) ([raw file](https://github.com/pmem/nvml/blob/8e334368138fced5daf26b64ad8bb997bf409604/src/libpmemobj/memblock.c#L87)):*\n<details><summary><i>Previously, marcinslusarz (Marcin Ślusarz) wrote…</i></summary>\n> This change suggests FATAL \"unreachable\" annotation does not work for your compiler. Please fix it if possible and don't change this code.\n</details>\ns/unreachable/noreturn/\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/nvml/819)*\n<!-- Sent from Reviewable.io -->\n"}}