{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Localization/pulls/comments/50599913","id":50599913,"diff_hunk":"@@ -157,7 +163,26 @@ protected IEnumerable<LocalizedString> GetAllStrings(bool includeAncestorCulture\n             foreach (var name in resourceNames)\n             {\n                 var value = GetStringSafely(name, culture);\n-                yield return new LocalizedString(name, value ?? name, resourceNotFound: value == null);\n+                yield return new LocalizedString(name, value, resourceNotFound: value == null);\n+            }\n+        }\n+\n+        private string ApplyResourceLookupBehavior(string name, string value)\n+        {\n+            switch(_resourceLookupBehavior)","path":"src/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.cs","position":83,"original_position":83,"commit_id":"97358f7de0b0ab8914417833046b48acafc0d00d","original_commit_id":"97358f7de0b0ab8914417833046b48acafc0d00d","user":{"login":"DamianEdwards","id":249088,"avatar_url":"https://avatars.githubusercontent.com/u/249088?v=3","gravatar_id":"","url":"https://api.github.com/users/DamianEdwards","html_url":"https://github.com/DamianEdwards","followers_url":"https://api.github.com/users/DamianEdwards/followers","following_url":"https://api.github.com/users/DamianEdwards/following{/other_user}","gists_url":"https://api.github.com/users/DamianEdwards/gists{/gist_id}","starred_url":"https://api.github.com/users/DamianEdwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DamianEdwards/subscriptions","organizations_url":"https://api.github.com/users/DamianEdwards/orgs","repos_url":"https://api.github.com/users/DamianEdwards/repos","events_url":"https://api.github.com/users/DamianEdwards/events{/privacy}","received_events_url":"https://api.github.com/users/DamianEdwards/received_events","type":"User","site_admin":false},"body":"Just use an `if` block here","created_at":"2016-01-22T22:29:00Z","updated_at":"2016-01-22T22:29:00Z","html_url":"https://github.com/aspnet/Localization/pull/141#discussion_r50599913","pull_request_url":"https://api.github.com/repos/aspnet/Localization/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/comments/50599913"},"html":{"href":"https://github.com/aspnet/Localization/pull/141#discussion_r50599913"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Localization/pulls/141","id":49976153,"html_url":"https://github.com/aspnet/Localization/pull/141","diff_url":"https://github.com/aspnet/Localization/pull/141.diff","patch_url":"https://github.com/aspnet/Localization/pull/141.patch","issue_url":"https://api.github.com/repos/aspnet/Localization/issues/141","number":141,"state":"open","locked":false,"title":"Added support for throwing if name not found to ResourceManagerStringLocalizer","user":{"login":"leonardlabat","id":642160,"avatar_url":"https://avatars.githubusercontent.com/u/642160?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardlabat","html_url":"https://github.com/leonardlabat","followers_url":"https://api.github.com/users/leonardlabat/followers","following_url":"https://api.github.com/users/leonardlabat/following{/other_user}","gists_url":"https://api.github.com/users/leonardlabat/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardlabat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardlabat/subscriptions","organizations_url":"https://api.github.com/users/leonardlabat/orgs","repos_url":"https://api.github.com/users/leonardlabat/repos","events_url":"https://api.github.com/users/leonardlabat/events{/privacy}","received_events_url":"https://api.github.com/users/leonardlabat/received_events","type":"User","site_admin":false},"body":"- Added the ResourceLookupBehavior enum\r\n- Using it into the LocalizationOptions\r\n- Added it to the ResourceMangerStringLocalizer\r\n- Refactored all the automatic fallbacks to the resource name (now use a\r\nsingle method)\r\n- Added unit tests for both specific behaviors\r\n\r\nAddresses #13","created_at":"2015-11-06T16:44:49Z","updated_at":"2016-01-22T22:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96991b4ea164f0eb78f4a7d49336ba0924ee134d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Localization/pulls/141/commits","review_comments_url":"https://api.github.com/repos/aspnet/Localization/pulls/141/comments","review_comment_url":"https://api.github.com/repos/aspnet/Localization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Localization/issues/141/comments","statuses_url":"https://api.github.com/repos/aspnet/Localization/statuses/97358f7de0b0ab8914417833046b48acafc0d00d","head":{"label":"leonardlabat:dev","ref":"dev","sha":"97358f7de0b0ab8914417833046b48acafc0d00d","user":{"login":"leonardlabat","id":642160,"avatar_url":"https://avatars.githubusercontent.com/u/642160?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardlabat","html_url":"https://github.com/leonardlabat","followers_url":"https://api.github.com/users/leonardlabat/followers","following_url":"https://api.github.com/users/leonardlabat/following{/other_user}","gists_url":"https://api.github.com/users/leonardlabat/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardlabat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardlabat/subscriptions","organizations_url":"https://api.github.com/users/leonardlabat/orgs","repos_url":"https://api.github.com/users/leonardlabat/repos","events_url":"https://api.github.com/users/leonardlabat/events{/privacy}","received_events_url":"https://api.github.com/users/leonardlabat/received_events","type":"User","site_admin":false},"repo":{"id":45583042,"name":"Localization","full_name":"leonardlabat/Localization","owner":{"login":"leonardlabat","id":642160,"avatar_url":"https://avatars.githubusercontent.com/u/642160?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardlabat","html_url":"https://github.com/leonardlabat","followers_url":"https://api.github.com/users/leonardlabat/followers","following_url":"https://api.github.com/users/leonardlabat/following{/other_user}","gists_url":"https://api.github.com/users/leonardlabat/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardlabat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardlabat/subscriptions","organizations_url":"https://api.github.com/users/leonardlabat/orgs","repos_url":"https://api.github.com/users/leonardlabat/repos","events_url":"https://api.github.com/users/leonardlabat/events{/privacy}","received_events_url":"https://api.github.com/users/leonardlabat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leonardlabat/Localization","description":"Interfaces and implementations for providing localization in applications. ","fork":true,"url":"https://api.github.com/repos/leonardlabat/Localization","forks_url":"https://api.github.com/repos/leonardlabat/Localization/forks","keys_url":"https://api.github.com/repos/leonardlabat/Localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leonardlabat/Localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leonardlabat/Localization/teams","hooks_url":"https://api.github.com/repos/leonardlabat/Localization/hooks","issue_events_url":"https://api.github.com/repos/leonardlabat/Localization/issues/events{/number}","events_url":"https://api.github.com/repos/leonardlabat/Localization/events","assignees_url":"https://api.github.com/repos/leonardlabat/Localization/assignees{/user}","branches_url":"https://api.github.com/repos/leonardlabat/Localization/branches{/branch}","tags_url":"https://api.github.com/repos/leonardlabat/Localization/tags","blobs_url":"https://api.github.com/repos/leonardlabat/Localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leonardlabat/Localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leonardlabat/Localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/leonardlabat/Localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leonardlabat/Localization/statuses/{sha}","languages_url":"https://api.github.com/repos/leonardlabat/Localization/languages","stargazers_url":"https://api.github.com/repos/leonardlabat/Localization/stargazers","contributors_url":"https://api.github.com/repos/leonardlabat/Localization/contributors","subscribers_url":"https://api.github.com/repos/leonardlabat/Localization/subscribers","subscription_url":"https://api.github.com/repos/leonardlabat/Localization/subscription","commits_url":"https://api.github.com/repos/leonardlabat/Localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/leonardlabat/Localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/leonardlabat/Localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/leonardlabat/Localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/leonardlabat/Localization/contents/{+path}","compare_url":"https://api.github.com/repos/leonardlabat/Localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leonardlabat/Localization/merges","archive_url":"https://api.github.com/repos/leonardlabat/Localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leonardlabat/Localization/downloads","issues_url":"https://api.github.com/repos/leonardlabat/Localization/issues{/number}","pulls_url":"https://api.github.com/repos/leonardlabat/Localization/pulls{/number}","milestones_url":"https://api.github.com/repos/leonardlabat/Localization/milestones{/number}","notifications_url":"https://api.github.com/repos/leonardlabat/Localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leonardlabat/Localization/labels{/name}","releases_url":"https://api.github.com/repos/leonardlabat/Localization/releases{/id}","deployments_url":"https://api.github.com/repos/leonardlabat/Localization/deployments","created_at":"2015-11-05T02:50:19Z","updated_at":"2015-11-05T02:50:21Z","pushed_at":"2015-11-06T16:41:42Z","git_url":"git://github.com/leonardlabat/Localization.git","ssh_url":"git@github.com:leonardlabat/Localization.git","clone_url":"https://github.com/leonardlabat/Localization.git","svn_url":"https://github.com/leonardlabat/Localization","homepage":null,"size":380,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"e88655bf29dbfedf5ce5a7fcf0884932445d008c","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35138798,"name":"Localization","full_name":"aspnet/Localization","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Localization","description":"Interfaces and implementations for providing localization in applications. ","fork":false,"url":"https://api.github.com/repos/aspnet/Localization","forks_url":"https://api.github.com/repos/aspnet/Localization/forks","keys_url":"https://api.github.com/repos/aspnet/Localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Localization/teams","hooks_url":"https://api.github.com/repos/aspnet/Localization/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Localization/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Localization/events","assignees_url":"https://api.github.com/repos/aspnet/Localization/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Localization/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Localization/tags","blobs_url":"https://api.github.com/repos/aspnet/Localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Localization/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Localization/languages","stargazers_url":"https://api.github.com/repos/aspnet/Localization/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Localization/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Localization/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Localization/subscription","commits_url":"https://api.github.com/repos/aspnet/Localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Localization/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Localization/merges","archive_url":"https://api.github.com/repos/aspnet/Localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Localization/downloads","issues_url":"https://api.github.com/repos/aspnet/Localization/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Localization/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Localization/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Localization/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Localization/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Localization/deployments","created_at":"2015-05-06T04:07:17Z","updated_at":"2016-01-22T18:09:58Z","pushed_at":"2016-01-22T21:03:40Z","git_url":"git://github.com/aspnet/Localization.git","ssh_url":"git@github.com:aspnet/Localization.git","clone_url":"https://github.com/aspnet/Localization.git","svn_url":"https://github.com/aspnet/Localization","homepage":null,"size":624,"stargazers_count":36,"watchers_count":36,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":16,"forks":20,"open_issues":16,"watchers":36,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/141"},"html":{"href":"https://github.com/aspnet/Localization/pull/141"},"issue":{"href":"https://api.github.com/repos/aspnet/Localization/issues/141"},"comments":{"href":"https://api.github.com/repos/aspnet/Localization/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Localization/statuses/97358f7de0b0ab8914417833046b48acafc0d00d"}}}}