{"action":"closed","issue":{"url":"https://api.github.com/repos/tuura/workcraft/issues/308","repository_url":"https://api.github.com/repos/tuura/workcraft","labels_url":"https://api.github.com/repos/tuura/workcraft/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/tuura/workcraft/issues/308/comments","events_url":"https://api.github.com/repos/tuura/workcraft/issues/308/events","html_url":"https://github.com/tuura/workcraft/issues/308","id":131969209,"number":308,"title":"Improving code quality for SONs","user":{"login":"workcraft-lp","id":17065435,"avatar_url":"https://avatars.githubusercontent.com/u/17065435?v=3","gravatar_id":"","url":"https://api.github.com/users/workcraft-lp","html_url":"https://github.com/workcraft-lp","followers_url":"https://api.github.com/users/workcraft-lp/followers","following_url":"https://api.github.com/users/workcraft-lp/following{/other_user}","gists_url":"https://api.github.com/users/workcraft-lp/gists{/gist_id}","starred_url":"https://api.github.com/users/workcraft-lp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workcraft-lp/subscriptions","organizations_url":"https://api.github.com/users/workcraft-lp/orgs","repos_url":"https://api.github.com/users/workcraft-lp/repos","events_url":"https://api.github.com/users/workcraft-lp/events{/privacy}","received_events_url":"https://api.github.com/users/workcraft-lp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tuura/workcraft/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/tuura/workcraft/labels/priority/low","name":"priority/low","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-07T13:41:30Z","updated_at":"2016-02-07T13:43:19Z","closed_at":"2016-02-07T13:43:19Z","body":"The current implementation of SONs plugin is partially copied from PetryNetPlugin, this has created some dublicated code in the model, and nodes.\nThe simulation tool was rewritten, however, the features that are created in the SON simulation (such as the concurrent transition fire) can be also useful PN. they are largely compatible.\nI suggest refactoring the code, and inherit SONs from the Petry Nets.\n\nWork items:\nRefactor SONConnection and VisualSONConnection classes: DONE\nRefactor SONConnectionTool: DONE\n\n------------------------------------\nThis issue was imported from a Launchpad blueprint.\n\n * name: son-refactoring\n * date created: 2014-07-22T14:36:40Z\n * date closed: 2015-02-11T14:38:17Z\n * assignee: libowen96\n * the launchpad url was https://blueprints.launchpad.net/workcraft/+spec/son-refactoring\n"}}