{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/83779041","pull_request_review_id":4599052,"id":83779041,"diff_hunk":"@@ -985,11 +985,15 @@ svr_strtjob2(job *pjob, struct batch_request *preq)\n \n \t/* send the job to MOM */\n \n+\t/* clearing old comment since we are sending a fresh job */\n+\tjob_attr_def[(int) JOB_ATR_Comment].at_decode(\n+\t\t\t&pjob->ji_wattr[(int) JOB_ATR_Comment], (char *) 0,\n+\t\t\t(char *) 0, \"\");","path":"src/server/req_runjob.c","position":7,"original_position":7,"commit_id":"31fd6ec99e6be034b62b74f54a8cc43bfbd45289","original_commit_id":"31fd6ec99e6be034b62b74f54a8cc43bfbd45289","user":{"login":"arungrover","id":17924134,"avatar_url":"https://avatars.githubusercontent.com/u/17924134?v=3","gravatar_id":"","url":"https://api.github.com/users/arungrover","html_url":"https://github.com/arungrover","followers_url":"https://api.github.com/users/arungrover/followers","following_url":"https://api.github.com/users/arungrover/following{/other_user}","gists_url":"https://api.github.com/users/arungrover/gists{/gist_id}","starred_url":"https://api.github.com/users/arungrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arungrover/subscriptions","organizations_url":"https://api.github.com/users/arungrover/orgs","repos_url":"https://api.github.com/users/arungrover/repos","events_url":"https://api.github.com/users/arungrover/events{/privacy}","received_events_url":"https://api.github.com/users/arungrover/received_events","type":"User","site_admin":false},"body":"you are right that we are not introducing a new message/comment but we are momentarily removing the comment from a job which is scheduled to run on a mom and is in substate 41. This wasn't the case earlier, So I think it does impact external behavior. Why don't we set the job comment to \"Job run\" (as it was earlier) or introduce a new \"Job about to run\" comment when server gets a run job request. This was we don't have to clear the comment and even mom rejects will show up on the job.","created_at":"2016-10-18T04:08:30Z","updated_at":"2016-10-18T04:08:30Z","html_url":"https://github.com/PBSPro/pbspro/pull/176#discussion_r83779041","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/83779041"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/176#discussion_r83779041"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/176","id":88989170,"html_url":"https://github.com/PBSPro/pbspro/pull/176","diff_url":"https://github.com/PBSPro/pbspro/pull/176.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/176.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/176","number":176,"state":"open","locked":false,"title":"PP-374: Job with a root-owned script runs even if root_reject_scripts…","user":{"login":"nithinj","id":16252556,"avatar_url":"https://avatars.githubusercontent.com/u/16252556?v=3","gravatar_id":"","url":"https://api.github.com/users/nithinj","html_url":"https://github.com/nithinj","followers_url":"https://api.github.com/users/nithinj/followers","following_url":"https://api.github.com/users/nithinj/following{/other_user}","gists_url":"https://api.github.com/users/nithinj/gists{/gist_id}","starred_url":"https://api.github.com/users/nithinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithinj/subscriptions","organizations_url":"https://api.github.com/users/nithinj/orgs","repos_url":"https://api.github.com/users/nithinj/repos","events_url":"https://api.github.com/users/nithinj/events{/privacy}","received_events_url":"https://api.github.com/users/nithinj/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Issue-ID\r\n<!--- Replace XXXX below (2 places) with the actual JIRA id -->\r\n* **[PP-374](https://pbspro.atlassian.net/browse/PP-374)**\r\n\r\n#### Problem description\r\n* Job with a root-owned script runs even if root_reject_scripts is set to true in asynchronous communication.\r\n\r\n#### Cause / Analysis\r\n* Job with a root-owned script should not run and job comment should get updated with appropriate error message.\r\n\r\n#### Solution description\r\n* Dequeue job from the mom's list before sending the reject reply so that job will not run even if a commit message is received.\r\n* Handle root script reject error in post_sendmom and update the ATR_Comment with error.\r\n* In case of asynchronous job server will always reply back scheduler with success and consequently scheduler updates the job comment as job has started running. This block has moved to server so that server will update the comment only after receiving a success from mom.\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n- [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n- [x] I have added  **manual test(s) to the Jira ticket and explained why PTL is not appropriate** for this case.\r\n- [x] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to the Jira ticket** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n\r\n… is set to true","created_at":"2016-10-12T10:16:31Z","updated_at":"2016-10-18T04:08:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"084a9a83427dcda5651526f215950424e636b574","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/176/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/176/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/176/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/31fd6ec99e6be034b62b74f54a8cc43bfbd45289","head":{"label":"nithinj:PP-472","ref":"PP-472","sha":"31fd6ec99e6be034b62b74f54a8cc43bfbd45289","user":{"login":"nithinj","id":16252556,"avatar_url":"https://avatars.githubusercontent.com/u/16252556?v=3","gravatar_id":"","url":"https://api.github.com/users/nithinj","html_url":"https://github.com/nithinj","followers_url":"https://api.github.com/users/nithinj/followers","following_url":"https://api.github.com/users/nithinj/following{/other_user}","gists_url":"https://api.github.com/users/nithinj/gists{/gist_id}","starred_url":"https://api.github.com/users/nithinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithinj/subscriptions","organizations_url":"https://api.github.com/users/nithinj/orgs","repos_url":"https://api.github.com/users/nithinj/repos","events_url":"https://api.github.com/users/nithinj/events{/privacy}","received_events_url":"https://api.github.com/users/nithinj/received_events","type":"User","site_admin":false},"repo":{"id":61099753,"name":"pbspro","full_name":"nithinj/pbspro","owner":{"login":"nithinj","id":16252556,"avatar_url":"https://avatars.githubusercontent.com/u/16252556?v=3","gravatar_id":"","url":"https://api.github.com/users/nithinj","html_url":"https://github.com/nithinj","followers_url":"https://api.github.com/users/nithinj/followers","following_url":"https://api.github.com/users/nithinj/following{/other_user}","gists_url":"https://api.github.com/users/nithinj/gists{/gist_id}","starred_url":"https://api.github.com/users/nithinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithinj/subscriptions","organizations_url":"https://api.github.com/users/nithinj/orgs","repos_url":"https://api.github.com/users/nithinj/repos","events_url":"https://api.github.com/users/nithinj/events{/privacy}","received_events_url":"https://api.github.com/users/nithinj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nithinj/pbspro","description":null,"fork":true,"url":"https://api.github.com/repos/nithinj/pbspro","forks_url":"https://api.github.com/repos/nithinj/pbspro/forks","keys_url":"https://api.github.com/repos/nithinj/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nithinj/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nithinj/pbspro/teams","hooks_url":"https://api.github.com/repos/nithinj/pbspro/hooks","issue_events_url":"https://api.github.com/repos/nithinj/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/nithinj/pbspro/events","assignees_url":"https://api.github.com/repos/nithinj/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/nithinj/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/nithinj/pbspro/tags","blobs_url":"https://api.github.com/repos/nithinj/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nithinj/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nithinj/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/nithinj/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nithinj/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/nithinj/pbspro/languages","stargazers_url":"https://api.github.com/repos/nithinj/pbspro/stargazers","contributors_url":"https://api.github.com/repos/nithinj/pbspro/contributors","subscribers_url":"https://api.github.com/repos/nithinj/pbspro/subscribers","subscription_url":"https://api.github.com/repos/nithinj/pbspro/subscription","commits_url":"https://api.github.com/repos/nithinj/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/nithinj/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/nithinj/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/nithinj/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/nithinj/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/nithinj/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nithinj/pbspro/merges","archive_url":"https://api.github.com/repos/nithinj/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nithinj/pbspro/downloads","issues_url":"https://api.github.com/repos/nithinj/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/nithinj/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/nithinj/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/nithinj/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nithinj/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/nithinj/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/nithinj/pbspro/deployments","created_at":"2016-06-14T07:02:19Z","updated_at":"2016-06-14T07:02:25Z","pushed_at":"2016-10-17T06:51:07Z","git_url":"git://github.com/nithinj/pbspro.git","ssh_url":"git@github.com:nithinj/pbspro.git","clone_url":"https://github.com/nithinj/pbspro.git","svn_url":"https://github.com/nithinj/pbspro","homepage":null,"size":5464,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"ada357c6cd04fba33df14dc6bb9207f08050f65c","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars.githubusercontent.com/u/19280436?v=3","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars.githubusercontent.com/u/19280436?v=3","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2016-10-15T09:08:45Z","pushed_at":"2016-10-17T06:51:08Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":6318,"stargazers_count":56,"watchers_count":56,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":3,"forks":58,"open_issues":3,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/176"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/176"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/176"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/31fd6ec99e6be034b62b74f54a8cc43bfbd45289"}}}}
{"actor":{"display_login":"arungrover"}}