{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/3557","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/3557/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/3557/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/3557/events","html_url":"https://github.com/Microsoft/vscode/issues/3557","id":137311656,"number":3557,"title":"Rename (refactor) parameter object doesn't rename the shape declaration","user":{"login":"bill-mybiz","id":1253349,"avatar_url":"https://avatars.githubusercontent.com/u/1253349?v=3","gravatar_id":"","url":"https://api.github.com/users/bill-mybiz","html_url":"https://github.com/bill-mybiz","followers_url":"https://api.github.com/users/bill-mybiz/followers","following_url":"https://api.github.com/users/bill-mybiz/following{/other_user}","gists_url":"https://api.github.com/users/bill-mybiz/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-mybiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-mybiz/subscriptions","organizations_url":"https://api.github.com/users/bill-mybiz/orgs","repos_url":"https://api.github.com/users/bill-mybiz/repos","events_url":"https://api.github.com/users/bill-mybiz/events{/privacy}","received_events_url":"https://api.github.com/users/bill-mybiz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-29T17:05:02Z","updated_at":"2016-02-29T17:06:52Z","closed_at":null,"body":"I have the following code:\r\n```\r\n getExistingThing({\r\n        id, \r\n        spaceId\r\n    }: {\r\n        id: string, \r\n        spaceId: string\r\n    }): IThingInfo {\r\n   // Use the params object here with destructuring...\r\n}\r\n```\r\n\r\nWhen I tried to refactor `id` to `thingId`, it renamed it correctly in the parameter object variable and the symbols in the function body, but it did not rename it in the \"shape\" of the parameter object (I don't know what else to call it).\r\n\r\nExpected:\r\n```\r\n    getExistingThing({\r\n        thingId,\r\n        spaceId\r\n    }: {\r\n        thingId: string, <<< should change here\r\n        spaceId: string\r\n    }): IThingInfo {\r\n```\r\n\r\nGot: \r\n```\r\n    getExistingThing({\r\n        thingId, \r\n        spaceId\r\n    }: {\r\n        id: string, <<< doesn't change though\r\n        spaceId: string\r\n    }): IThingInfo {\r\n```\r\n\r\nI would also love it if someone could tell me what the various parts of this kind of function declaration is called. I use it for named arguments which I love, but I just don't know what the various pieces are called. I just know it's awesomeness."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/190292307","html_url":"https://github.com/Microsoft/vscode/issues/3557#issuecomment-190292307","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/3557","id":190292307,"user":{"login":"bill-mybiz","id":1253349,"avatar_url":"https://avatars.githubusercontent.com/u/1253349?v=3","gravatar_id":"","url":"https://api.github.com/users/bill-mybiz","html_url":"https://github.com/bill-mybiz","followers_url":"https://api.github.com/users/bill-mybiz/followers","following_url":"https://api.github.com/users/bill-mybiz/following{/other_user}","gists_url":"https://api.github.com/users/bill-mybiz/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-mybiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-mybiz/subscriptions","organizations_url":"https://api.github.com/users/bill-mybiz/orgs","repos_url":"https://api.github.com/users/bill-mybiz/repos","events_url":"https://api.github.com/users/bill-mybiz/events{/privacy}","received_events_url":"https://api.github.com/users/bill-mybiz/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T17:06:52Z","updated_at":"2016-02-29T17:06:52Z","body":"Also it fails in the reverse as well. If I perform the refactor on the shape declaration, it does not change the corresponding symbols in the parameter object, nor in the function body."}}