{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/17966","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/17966/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17966/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/17966/events","html_url":"https://github.com/mantidproject/mantid/pull/17966","id":187295493,"number":17966,"title":"LoadILLTOF monitor numbering","user":{"login":"ianbush","id":7047413,"avatar_url":"https://avatars.githubusercontent.com/u/7047413?v=3","gravatar_id":"","url":"https://api.github.com/users/ianbush","html_url":"https://github.com/ianbush","followers_url":"https://api.github.com/users/ianbush/followers","following_url":"https://api.github.com/users/ianbush/following{/other_user}","gists_url":"https://api.github.com/users/ianbush/gists{/gist_id}","starred_url":"https://api.github.com/users/ianbush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianbush/subscriptions","organizations_url":"https://api.github.com/users/ianbush/orgs","repos_url":"https://api.github.com/users/ianbush/repos","events_url":"https://api.github.com/users/ianbush/events{/privacy}","received_events_url":"https://api.github.com/users/ianbush/received_events","type":"User","site_admin":false},"labels":[{"id":177607615,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800","default":false},{"id":220075626,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Easy","name":"Misc: Easy","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"assignees":[{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/59","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.9","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/59/labels","id":1622022,"number":59,"title":"Release 3.9","description":"","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars.githubusercontent.com/u/1017173?v=3","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":167,"closed_issues":205,"state":"open","created_at":"2016-03-04T11:29:48Z","updated_at":"2016-11-04T15:44:13Z","due_on":"2017-02-13T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-11-04T10:09:09Z","updated_at":"2016-11-04T16:21:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17966","html_url":"https://github.com/mantidproject/mantid/pull/17966","diff_url":"https://github.com/mantidproject/mantid/pull/17966.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17966.patch"},"body":"Fixes issue with monitor not being loaded correctly for ILL ToF data.\r\n\r\n**To test:**\r\n\r\nLoad a data file such as ILL/IN6/164192.nxs or ILL/IN5/104007.nxs. After loading check the detector table, to see that the monitors do not have the same detector IDs as any detectors.\r\n\r\nCheck the unit test additional now makes sense.  Can also check it fails if the line `m_localWorkspace->getSpectrum(spec).setDetectorID(monitorIDs[spec]);` (line 554) is commented out in `LoadILLTOF.cpp`\r\n\r\nFixes #17954 .\r\n\r\n*Does not need to be in the release notes.*\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/258478003","html_url":"https://github.com/mantidproject/mantid/pull/17966#issuecomment-258478003","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17966","id":258478003,"user":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T16:21:56Z","updated_at":"2016-11-04T16:21:56Z","body":"Test shows monitors and gives them unique detector ID. :shipit: "}}
{"actor":{"display_login":"KarlPalmen"}}