{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/73947548","id":73947548,"diff_hunk":"@@ -126,7 +126,11 @@ class Zapper\n \n #if defined(FEATURE_CORECLR) && !defined(FEATURE_MERGE_JIT_AND_ENGINE)\n     SString                 m_CLRJITPath;\n+    bool                    m_fDontLoadJit;","path":"src/inc/zapper.h","position":4,"original_position":4,"commit_id":"1140fe90fd349f23d1ed0e2d8054b53f726a2b2d","original_commit_id":"1140fe90fd349f23d1ed0e2d8054b53f726a2b2d","user":{"login":"gkhanna79","id":9451457,"avatar_url":"https://avatars.githubusercontent.com/u/9451457?v=3","gravatar_id":"","url":"https://api.github.com/users/gkhanna79","html_url":"https://github.com/gkhanna79","followers_url":"https://api.github.com/users/gkhanna79/followers","following_url":"https://api.github.com/users/gkhanna79/following{/other_user}","gists_url":"https://api.github.com/users/gkhanna79/gists{/gist_id}","starred_url":"https://api.github.com/users/gkhanna79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkhanna79/subscriptions","organizations_url":"https://api.github.com/users/gkhanna79/orgs","repos_url":"https://api.github.com/users/gkhanna79/repos","events_url":"https://api.github.com/users/gkhanna79/events{/privacy}","received_events_url":"https://api.github.com/users/gkhanna79/received_events","type":"User","site_admin":false},"body":"> his bool variable is still needed to control whether or not to load JIT\r\n\r\nIf JITPath is not specified, shouldn't that suffice since the path will be null?","created_at":"2016-08-08T20:27:22Z","updated_at":"2016-08-08T20:27:22Z","html_url":"https://github.com/dotnet/coreclr/pull/6652#discussion_r73947548","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6652","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/73947548"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6652#discussion_r73947548"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6652"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6652","id":80495187,"html_url":"https://github.com/dotnet/coreclr/pull/6652","diff_url":"https://github.com/dotnet/coreclr/pull/6652.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6652.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6652","number":6652,"state":"open","locked":false,"title":"Modify \"crossgen -createpdb\" to skip loading clrjit.dll (#6607)","user":{"login":"JohnChen0","id":10659588,"avatar_url":"https://avatars.githubusercontent.com/u/10659588?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnChen0","html_url":"https://github.com/JohnChen0","followers_url":"https://api.github.com/users/JohnChen0/followers","following_url":"https://api.github.com/users/JohnChen0/following{/other_user}","gists_url":"https://api.github.com/users/JohnChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChen0/subscriptions","organizations_url":"https://api.github.com/users/JohnChen0/orgs","repos_url":"https://api.github.com/users/JohnChen0/repos","events_url":"https://api.github.com/users/JohnChen0/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChen0/received_events","type":"User","site_admin":false},"body":"The -JITPath option doesn't work properly when CrossGen is used to\r\ncreate a PDB file (issue #6607). Since clrjit.dll isn't really\r\nneeded for creating PDB files, the issue is fixed by modifying\r\nCrossGen to skip loading clrjit.dll when -createpdb option is given.\r\n\r\nAlso following suggestion from issue #6607, added a new switch\r\n-diasymreaderPath to CrossGen, to allow loading diasymreader.dll\r\nfrom an alternative path.","created_at":"2016-08-08T18:06:35Z","updated_at":"2016-08-08T20:27:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ca90fdfac6a8a000814ab09a035fa615ac7975b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6652/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6652/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6652/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/1140fe90fd349f23d1ed0e2d8054b53f726a2b2d","head":{"label":"JohnChen0:crossgen-createpdb","ref":"crossgen-createpdb","sha":"1140fe90fd349f23d1ed0e2d8054b53f726a2b2d","user":{"login":"JohnChen0","id":10659588,"avatar_url":"https://avatars.githubusercontent.com/u/10659588?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnChen0","html_url":"https://github.com/JohnChen0","followers_url":"https://api.github.com/users/JohnChen0/followers","following_url":"https://api.github.com/users/JohnChen0/following{/other_user}","gists_url":"https://api.github.com/users/JohnChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChen0/subscriptions","organizations_url":"https://api.github.com/users/JohnChen0/orgs","repos_url":"https://api.github.com/users/JohnChen0/repos","events_url":"https://api.github.com/users/JohnChen0/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChen0/received_events","type":"User","site_admin":false},"repo":{"id":33200840,"name":"coreclr","full_name":"JohnChen0/coreclr","owner":{"login":"JohnChen0","id":10659588,"avatar_url":"https://avatars.githubusercontent.com/u/10659588?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnChen0","html_url":"https://github.com/JohnChen0","followers_url":"https://api.github.com/users/JohnChen0/followers","following_url":"https://api.github.com/users/JohnChen0/following{/other_user}","gists_url":"https://api.github.com/users/JohnChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChen0/subscriptions","organizations_url":"https://api.github.com/users/JohnChen0/orgs","repos_url":"https://api.github.com/users/JohnChen0/repos","events_url":"https://api.github.com/users/JohnChen0/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChen0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnChen0/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/JohnChen0/coreclr","forks_url":"https://api.github.com/repos/JohnChen0/coreclr/forks","keys_url":"https://api.github.com/repos/JohnChen0/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnChen0/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnChen0/coreclr/teams","hooks_url":"https://api.github.com/repos/JohnChen0/coreclr/hooks","issue_events_url":"https://api.github.com/repos/JohnChen0/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/JohnChen0/coreclr/events","assignees_url":"https://api.github.com/repos/JohnChen0/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/JohnChen0/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/JohnChen0/coreclr/tags","blobs_url":"https://api.github.com/repos/JohnChen0/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnChen0/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnChen0/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnChen0/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnChen0/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnChen0/coreclr/languages","stargazers_url":"https://api.github.com/repos/JohnChen0/coreclr/stargazers","contributors_url":"https://api.github.com/repos/JohnChen0/coreclr/contributors","subscribers_url":"https://api.github.com/repos/JohnChen0/coreclr/subscribers","subscription_url":"https://api.github.com/repos/JohnChen0/coreclr/subscription","commits_url":"https://api.github.com/repos/JohnChen0/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnChen0/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnChen0/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnChen0/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnChen0/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/JohnChen0/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnChen0/coreclr/merges","archive_url":"https://api.github.com/repos/JohnChen0/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnChen0/coreclr/downloads","issues_url":"https://api.github.com/repos/JohnChen0/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/JohnChen0/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnChen0/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnChen0/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnChen0/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/JohnChen0/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/JohnChen0/coreclr/deployments","created_at":"2015-03-31T17:56:31Z","updated_at":"2016-01-11T16:36:13Z","pushed_at":"2016-08-08T20:14:16Z","git_url":"git://github.com/JohnChen0/coreclr.git","ssh_url":"git@github.com:JohnChen0/coreclr.git","clone_url":"https://github.com/JohnChen0/coreclr.git","svn_url":"https://github.com/JohnChen0/coreclr","homepage":"","size":94945,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"deb00ad58acf627763b6c0a7833fa789e3bb1cd0","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-08-08T19:48:44Z","pushed_at":"2016-08-08T20:18:12Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":106346,"stargazers_count":6767,"watchers_count":6767,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1593,"mirror_url":null,"open_issues_count":913,"forks":1593,"open_issues":913,"watchers":6767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6652"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6652"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6652"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6652/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6652/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6652/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/1140fe90fd349f23d1ed0e2d8054b53f726a2b2d"}}}}
{"actor":{"display_login":"gkhanna79"}}