{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/comments/62927554","id":62927554,"diff_hunk":"@@ -0,0 +1,36 @@\n+/***\n+Copyright 2016 Cisco Systems Inc. All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package api\n+\n+type IPAMRequestArgs struct {\n+\tHostname  string              `json:\"hostname,omitempty\"`\n+\tNumIPv4   int                 `json:\"num_ipv4,omitempty\"`\n+\tNumIPv6   int                 `json:\"num_ipv6,omitempty\"`\n+\tUID       string              `json:\"uid,omitempty\"`\n+\tNetgroups []string            `json:\"netgroups,omitempty\"`\n+\tLabels    []map[string]string `json:\"labels,omitempty\"`\n+\tIPs       []string            `json:\"ips,omitempty\"`\n+}\n+\n+type IPAMRequest struct {","path":"mgmtfn/mesosplugin/api/ipam.go","position":28,"original_position":28,"commit_id":"d376685f0d1a5b28d76c3c587f130ad67431d3c0","original_commit_id":"d376685f0d1a5b28d76c3c587f130ad67431d3c0","user":{"login":"shaleman","id":5446536,"avatar_url":"https://avatars.githubusercontent.com/u/5446536?v=3","gravatar_id":"","url":"https://api.github.com/users/shaleman","html_url":"https://github.com/shaleman","followers_url":"https://api.github.com/users/shaleman/followers","following_url":"https://api.github.com/users/shaleman/following{/other_user}","gists_url":"https://api.github.com/users/shaleman/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleman/subscriptions","organizations_url":"https://api.github.com/users/shaleman/orgs","repos_url":"https://api.github.com/users/shaleman/repos","events_url":"https://api.github.com/users/shaleman/events{/privacy}","received_events_url":"https://api.github.com/users/shaleman/received_events","type":"User","site_admin":false},"body":"Why do we need this struct? isn't just IPAMRequestArgs sufficient?","created_at":"2016-05-11T21:10:39Z","updated_at":"2016-05-11T21:10:39Z","html_url":"https://github.com/contiv/netplugin/pull/354#discussion_r62927554","pull_request_url":"https://api.github.com/repos/contiv/netplugin/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments/62927554"},"html":{"href":"https://github.com/contiv/netplugin/pull/354#discussion_r62927554"},"pull_request":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/354","id":69325717,"html_url":"https://github.com/contiv/netplugin/pull/354","diff_url":"https://github.com/contiv/netplugin/pull/354.diff","patch_url":"https://github.com/contiv/netplugin/pull/354.patch","issue_url":"https://api.github.com/repos/contiv/netplugin/issues/354","number":354,"state":"open","locked":false,"title":"mesos net-modules support","user":{"login":"unclejack","id":1409668,"avatar_url":"https://avatars.githubusercontent.com/u/1409668?v=3","gravatar_id":"","url":"https://api.github.com/users/unclejack","html_url":"https://github.com/unclejack","followers_url":"https://api.github.com/users/unclejack/followers","following_url":"https://api.github.com/users/unclejack/following{/other_user}","gists_url":"https://api.github.com/users/unclejack/gists{/gist_id}","starred_url":"https://api.github.com/users/unclejack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unclejack/subscriptions","organizations_url":"https://api.github.com/users/unclejack/orgs","repos_url":"https://api.github.com/users/unclejack/repos","events_url":"https://api.github.com/users/unclejack/events{/privacy}","received_events_url":"https://api.github.com/users/unclejack/received_events","type":"User","site_admin":false},"body":"This PR adds support for Mesos net-modules.\r\n\r\nThis PR is WIP.","created_at":"2016-05-09T10:38:15Z","updated_at":"2016-05-11T21:10:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d8f95d57dc3460bf9b245e06bdf7a0f1d740b33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiv/netplugin/pulls/354/commits","review_comments_url":"https://api.github.com/repos/contiv/netplugin/pulls/354/comments","review_comment_url":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/netplugin/issues/354/comments","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/d376685f0d1a5b28d76c3c587f130ad67431d3c0","head":{"label":"unclejack:mesos_netmodules","ref":"mesos_netmodules","sha":"d376685f0d1a5b28d76c3c587f130ad67431d3c0","user":{"login":"unclejack","id":1409668,"avatar_url":"https://avatars.githubusercontent.com/u/1409668?v=3","gravatar_id":"","url":"https://api.github.com/users/unclejack","html_url":"https://github.com/unclejack","followers_url":"https://api.github.com/users/unclejack/followers","following_url":"https://api.github.com/users/unclejack/following{/other_user}","gists_url":"https://api.github.com/users/unclejack/gists{/gist_id}","starred_url":"https://api.github.com/users/unclejack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unclejack/subscriptions","organizations_url":"https://api.github.com/users/unclejack/orgs","repos_url":"https://api.github.com/users/unclejack/repos","events_url":"https://api.github.com/users/unclejack/events{/privacy}","received_events_url":"https://api.github.com/users/unclejack/received_events","type":"User","site_admin":false},"repo":{"id":34112222,"name":"netplugin","full_name":"unclejack/netplugin","owner":{"login":"unclejack","id":1409668,"avatar_url":"https://avatars.githubusercontent.com/u/1409668?v=3","gravatar_id":"","url":"https://api.github.com/users/unclejack","html_url":"https://github.com/unclejack","followers_url":"https://api.github.com/users/unclejack/followers","following_url":"https://api.github.com/users/unclejack/following{/other_user}","gists_url":"https://api.github.com/users/unclejack/gists{/gist_id}","starred_url":"https://api.github.com/users/unclejack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unclejack/subscriptions","organizations_url":"https://api.github.com/users/unclejack/orgs","repos_url":"https://api.github.com/users/unclejack/repos","events_url":"https://api.github.com/users/unclejack/events{/privacy}","received_events_url":"https://api.github.com/users/unclejack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unclejack/netplugin","description":null,"fork":true,"url":"https://api.github.com/repos/unclejack/netplugin","forks_url":"https://api.github.com/repos/unclejack/netplugin/forks","keys_url":"https://api.github.com/repos/unclejack/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unclejack/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unclejack/netplugin/teams","hooks_url":"https://api.github.com/repos/unclejack/netplugin/hooks","issue_events_url":"https://api.github.com/repos/unclejack/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/unclejack/netplugin/events","assignees_url":"https://api.github.com/repos/unclejack/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/unclejack/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/unclejack/netplugin/tags","blobs_url":"https://api.github.com/repos/unclejack/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unclejack/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unclejack/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/unclejack/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unclejack/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/unclejack/netplugin/languages","stargazers_url":"https://api.github.com/repos/unclejack/netplugin/stargazers","contributors_url":"https://api.github.com/repos/unclejack/netplugin/contributors","subscribers_url":"https://api.github.com/repos/unclejack/netplugin/subscribers","subscription_url":"https://api.github.com/repos/unclejack/netplugin/subscription","commits_url":"https://api.github.com/repos/unclejack/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/unclejack/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/unclejack/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/unclejack/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/unclejack/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/unclejack/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unclejack/netplugin/merges","archive_url":"https://api.github.com/repos/unclejack/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unclejack/netplugin/downloads","issues_url":"https://api.github.com/repos/unclejack/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/unclejack/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/unclejack/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/unclejack/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unclejack/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/unclejack/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/unclejack/netplugin/deployments","created_at":"2015-04-17T11:09:13Z","updated_at":"2016-01-13T23:24:34Z","pushed_at":"2016-05-09T13:40:16Z","git_url":"git://github.com/unclejack/netplugin.git","ssh_url":"git@github.com:unclejack/netplugin.git","clone_url":"https://github.com/unclejack/netplugin.git","svn_url":"https://github.com/unclejack/netplugin","homepage":null,"size":18677,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"fc546ce94f5f1a61a8d85ca304b36f698c7601b9","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":28353322,"name":"netplugin","full_name":"contiv/netplugin","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/netplugin","description":"Container networking for various use cases","fork":false,"url":"https://api.github.com/repos/contiv/netplugin","forks_url":"https://api.github.com/repos/contiv/netplugin/forks","keys_url":"https://api.github.com/repos/contiv/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/netplugin/teams","hooks_url":"https://api.github.com/repos/contiv/netplugin/hooks","issue_events_url":"https://api.github.com/repos/contiv/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/netplugin/events","assignees_url":"https://api.github.com/repos/contiv/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/netplugin/tags","blobs_url":"https://api.github.com/repos/contiv/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/netplugin/languages","stargazers_url":"https://api.github.com/repos/contiv/netplugin/stargazers","contributors_url":"https://api.github.com/repos/contiv/netplugin/contributors","subscribers_url":"https://api.github.com/repos/contiv/netplugin/subscribers","subscription_url":"https://api.github.com/repos/contiv/netplugin/subscription","commits_url":"https://api.github.com/repos/contiv/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/netplugin/merges","archive_url":"https://api.github.com/repos/contiv/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/netplugin/downloads","issues_url":"https://api.github.com/repos/contiv/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/contiv/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/netplugin/deployments","created_at":"2014-12-22T18:45:21Z","updated_at":"2016-05-10T23:00:22Z","pushed_at":"2016-05-11T18:43:57Z","git_url":"git://github.com/contiv/netplugin.git","ssh_url":"git@github.com:contiv/netplugin.git","clone_url":"https://github.com/contiv/netplugin.git","svn_url":"https://github.com/contiv/netplugin","homepage":"","size":18945,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":49,"forks":49,"open_issues":49,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/354"},"html":{"href":"https://github.com/contiv/netplugin/pull/354"},"issue":{"href":"https://api.github.com/repos/contiv/netplugin/issues/354"},"comments":{"href":"https://api.github.com/repos/contiv/netplugin/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/netplugin/statuses/d376685f0d1a5b28d76c3c587f130ad67431d3c0"}}}}