{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef-dk/issues/880","repository_url":"https://api.github.com/repos/chef/chef-dk","labels_url":"https://api.github.com/repos/chef/chef-dk/issues/880/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef-dk/issues/880/comments","events_url":"https://api.github.com/repos/chef/chef-dk/issues/880/events","html_url":"https://github.com/chef/chef-dk/pull/880","id":158227289,"number":880,"title":"Removed call to write updated lockfile when pushing policy","user":{"login":"emachnic","id":169018,"avatar_url":"https://avatars.githubusercontent.com/u/169018?v=3","gravatar_id":"","url":"https://api.github.com/users/emachnic","html_url":"https://github.com/emachnic","followers_url":"https://api.github.com/users/emachnic/followers","following_url":"https://api.github.com/users/emachnic/following{/other_user}","gists_url":"https://api.github.com/users/emachnic/gists{/gist_id}","starred_url":"https://api.github.com/users/emachnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emachnic/subscriptions","organizations_url":"https://api.github.com/users/emachnic/orgs","repos_url":"https://api.github.com/users/emachnic/repos","events_url":"https://api.github.com/users/emachnic/events{/privacy}","received_events_url":"https://api.github.com/users/emachnic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef/chef-dk/labels/Signed%20CLA","name":"Signed CLA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-02T20:03:22Z","updated_at":"2016-06-07T00:40:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef/chef-dk/pulls/880","html_url":"https://github.com/chef/chef-dk/pull/880","diff_url":"https://github.com/chef/chef-dk/pull/880.diff","patch_url":"https://github.com/chef/chef-dk/pull/880.patch"},"body":"I wanted to try and fix #831 with this Pull Request. After the change, all RSpec tests passed. I also tested that this works by adding my fork as a dependency in the Gemfile of my cookbook. I was still able to run `chef install` and `chef update` successfully. I was also able to run `chef push` without it generating a new lock file so that multiple policy groups end up having the same policy revision."},"comment":{"url":"https://api.github.com/repos/chef/chef-dk/issues/comments/224130478","html_url":"https://github.com/chef/chef-dk/pull/880#issuecomment-224130478","issue_url":"https://api.github.com/repos/chef/chef-dk/issues/880","id":224130478,"user":{"login":"mwrock","id":655165,"avatar_url":"https://avatars.githubusercontent.com/u/655165?v=3","gravatar_id":"","url":"https://api.github.com/users/mwrock","html_url":"https://github.com/mwrock","followers_url":"https://api.github.com/users/mwrock/followers","following_url":"https://api.github.com/users/mwrock/following{/other_user}","gists_url":"https://api.github.com/users/mwrock/gists{/gist_id}","starred_url":"https://api.github.com/users/mwrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwrock/subscriptions","organizations_url":"https://api.github.com/users/mwrock/orgs","repos_url":"https://api.github.com/users/mwrock/repos","events_url":"https://api.github.com/users/mwrock/events{/privacy}","received_events_url":"https://api.github.com/users/mwrock/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T00:40:39Z","updated_at":"2016-06-07T00:40:39Z","body":"just took a closer look at this and it makes sense now why you are not seeing the id change. generating the lock data should be consistent as long as nothing being locked is changing. When I was playing with this last week, I had done a `chef update` and then `chef install` and finall did a `git commit` of the lock file. Then a `chef push` immediately after changed the lock file. I see now that this is not because of some randomization but because the commit caused the lock metadata of the cookbook i was testing with to change.\r\n\r\nI still think we want this PR but I'd just leave your tests as is and remove the dead function. I'd also be curious what @danielsdeleo thinks."}}
{"actor":{"display_login":"mwrock"}}