{"action":"created","issue":{"url":"https://api.github.com/repos/eliben/pyelftools/issues/98","repository_url":"https://api.github.com/repos/eliben/pyelftools","labels_url":"https://api.github.com/repos/eliben/pyelftools/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/eliben/pyelftools/issues/98/comments","events_url":"https://api.github.com/repos/eliben/pyelftools/issues/98/events","html_url":"https://github.com/eliben/pyelftools/pull/98","id":136147390,"number":98,"title":" Fix _data_member_location_extra to not crash  ","user":{"login":"bseifers","id":17010558,"avatar_url":"https://avatars.githubusercontent.com/u/17010558?v=3","gravatar_id":"","url":"https://api.github.com/users/bseifers","html_url":"https://github.com/bseifers","followers_url":"https://api.github.com/users/bseifers/followers","following_url":"https://api.github.com/users/bseifers/following{/other_user}","gists_url":"https://api.github.com/users/bseifers/gists{/gist_id}","starred_url":"https://api.github.com/users/bseifers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bseifers/subscriptions","organizations_url":"https://api.github.com/users/bseifers/orgs","repos_url":"https://api.github.com/users/bseifers/repos","events_url":"https://api.github.com/users/bseifers/events{/privacy}","received_events_url":"https://api.github.com/users/bseifers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-24T18:31:04Z","updated_at":"2016-03-01T17:13:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eliben/pyelftools/pulls/98","html_url":"https://github.com/eliben/pyelftools/pull/98","diff_url":"https://github.com/eliben/pyelftools/pull/98.diff","patch_url":"https://github.com/eliben/pyelftools/pull/98.patch"},"body":"When running scripts/readelf.py --debug-dump=info on file test/testfiles_for_readelf/hello.out (which is a new file I added for this pull request), the original code crashes with a python error. I created a workaround in elftools/dwarf/descriptions.py that fixes the problem, but you probably have a better way (I am a novice elftools and python user). Feel free to improve on my fix."},"comment":{"url":"https://api.github.com/repos/eliben/pyelftools/issues/comments/190819049","html_url":"https://github.com/eliben/pyelftools/pull/98#issuecomment-190819049","issue_url":"https://api.github.com/repos/eliben/pyelftools/issues/98","id":190819049,"user":{"login":"eliben","id":1130906,"avatar_url":"https://avatars.githubusercontent.com/u/1130906?v=3","gravatar_id":"","url":"https://api.github.com/users/eliben","html_url":"https://github.com/eliben","followers_url":"https://api.github.com/users/eliben/followers","following_url":"https://api.github.com/users/eliben/following{/other_user}","gists_url":"https://api.github.com/users/eliben/gists{/gist_id}","starred_url":"https://api.github.com/users/eliben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliben/subscriptions","organizations_url":"https://api.github.com/users/eliben/orgs","repos_url":"https://api.github.com/users/eliben/repos","events_url":"https://api.github.com/users/eliben/events{/privacy}","received_events_url":"https://api.github.com/users/eliben/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T17:13:39Z","updated_at":"2016-03-01T17:13:39Z","body":"Brad, I linked a blog post that explains how to do this.\n\nOn Tue, Mar 1, 2016 at 8:51 AM, bseifers <notifications@github.com> wrote:\n\n> Hi Eli,\n>\n> OK, I’ve made all the requested changes, but I don’t know how to squash\n> all the commits into one, because it looks like I need some sort of command\n> line interface, and all I know how to do is bring up the web site/html\n> pages. I don’t see anything on those pages that lets me bring up a CL\n> window. Hope you can help.\n>\n> Brad\n> 408-742-4764\n>\n> From: Eli Bendersky [mailto:notifications@github.com]\n> Sent: Friday, February 26, 2016 5:30 AM\n> To: eliben/pyelftools <pyelftools@noreply.github.com>\n> Cc: Seifers, Brad (US) <brad.seifers@lmco.com>\n> Subject: EXTERNAL: Re: [pyelftools] Fix _data_member_location_extra to not\n> crash (#98)\n>\n>\n> Well, descriptions.py is mostly kludges to be compatible with readelf\n> anyway :-)\n>\n> To make this better suitable for merging, two requests:\n>\n> 1. Add the source of hello.out with directions on how to reproduce it --\n> follow example in test/testfiles_for_readelf/gcc48-simple.src.c\n> 2. Squash into single commit with as descriptive a commit message as\n> possible [\n> http://eli.thegreenplace.net/2014/02/19/squashing-github-pull-requests-into-a-single-commit]\n>\n>\n> —\n> Reply to this email directly or view it on GitHub<\n> https://github.com/eliben/pyelftools/pull/98#issuecomment-189273320>.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/eliben/pyelftools/pull/98#issuecomment-190807568>.\n>\n"}}