{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/5265","repository_url":"https://api.github.com/repos/callemall/material-ui","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/5265/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5265/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/5265/events","html_url":"https://github.com/callemall/material-ui/pull/5265","id":179559904,"number":5265,"title":"[TableFooter] Add children to footerRows when adjustForCheckbox === f…","user":{"login":"lukewhyte","id":3096144,"avatar_url":"https://avatars.githubusercontent.com/u/3096144?v=3","gravatar_id":"","url":"https://api.github.com/users/lukewhyte","html_url":"https://github.com/lukewhyte","followers_url":"https://api.github.com/users/lukewhyte/followers","following_url":"https://api.github.com/users/lukewhyte/following{/other_user}","gists_url":"https://api.github.com/users/lukewhyte/gists{/gist_id}","starred_url":"https://api.github.com/users/lukewhyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukewhyte/subscriptions","organizations_url":"https://api.github.com/users/lukewhyte/orgs","repos_url":"https://api.github.com/users/lukewhyte/repos","events_url":"https://api.github.com/users/lukewhyte/events{/privacy}","received_events_url":"https://api.github.com/users/lukewhyte/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/callemall/material-ui/labels/PR:%20Needs%20Revision","name":"PR: Needs Revision","color":"e11d21"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-27T17:29:43Z","updated_at":"2016-10-01T12:09:04Z","closed_at":"2016-10-01T12:09:04Z","pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/5265","html_url":"https://github.com/callemall/material-ui/pull/5265","diff_url":"https://github.com/callemall/material-ui/pull/5265.diff","patch_url":"https://github.com/callemall/material-ui/pull/5265.patch"},"body":"<!-- Thanks so much for your PR, your contribution is appreciated! -->\r\n\r\nChildren (columns) weren't being added to `const footerRows` (found on line 67 of TableFooter.js) when `adjustForCheckbox` was set to false. Thus, they weren't rendering.\r\n\r\nI didn't see any tests for this component in the repo, so I didn't add any. I did, however, put together some code in the WebpackBin playground the renders two tables. The first using the code with the bug and the second using the fix from my PR. It can be found here: http://www.webpackbin.com/41NXLqQTZ"},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/250909076","html_url":"https://github.com/callemall/material-ui/pull/5265#issuecomment-250909076","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5265","id":250909076,"user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"created_at":"2016-10-01T12:09:04Z","updated_at":"2016-10-01T12:09:04Z","body":"The `Table` component was partially / fully migrated on the `next` branch.\r\nWe are now focusing on releasing out the `next` branch.\r\nWe plan to stop the support of the *migrated* components.\r\nI'm gonna close this PR. Thanks for your time.\r\nWould be great if you check out the new component. Any PR is welcomed."}}
{"actor":{"display_login":"oliviertassinari"}}