{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/90622054","pull_request_review_id":11140407,"id":90622054,"diff_hunk":"@@ -454,6 +540,23 @@ func (d *glusterfsVolumeDeleter) Delete() error {\n \n \tglog.V(4).Infof(\"glusterfs: deleting volume %q with configuration %+v\", volumeId, d.provisioningConfig)\n \n+\tgid, err := d.getGid()","path":"pkg/volume/glusterfs/glusterfs.go","position":155,"original_position":115,"commit_id":"1fdcf601682d016414655e1bef6fa3ccb3a26056","original_commit_id":"61d53efc0f896b1fcdd504d595fa9337a14ea24b","user":{"login":"obnoxxx","id":8081179,"avatar_url":"https://avatars.githubusercontent.com/u/8081179?v=3","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"body":"ok. right.\r\ndo we ignore non-existence of the gid or any failure?","created_at":"2016-12-02T10:49:35Z","updated_at":"2016-12-02T10:49:35Z","html_url":"https://github.com/kubernetes/kubernetes/pull/37886#discussion_r90622054","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/90622054"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37886#discussion_r90622054"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886","id":96215807,"html_url":"https://github.com/kubernetes/kubernetes/pull/37886","diff_url":"https://github.com/kubernetes/kubernetes/pull/37886.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37886.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37886","number":37886,"state":"open","locked":false,"title":"Implement GID security for the GlusterFS dynamic provisioner.","user":{"login":"obnoxxx","id":8081179,"avatar_url":"https://avatars.githubusercontent.com/u/8081179?v=3","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR implements GID security for the glusterfs dynamic provisioner.\r\nIt is a reworked version of PR #37549 .\r\n\r\n<!--\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n-->\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\n```\r\n","created_at":"2016-12-02T03:28:49Z","updated_at":"2016-12-02T10:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecd4e91a27a2ff3cff482c802bc18846d7b5da30","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"assignees":[{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37886/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1fdcf601682d016414655e1bef6fa3ccb3a26056","head":{"label":"obnoxxx:gluster-dp-gid","ref":"gluster-dp-gid","sha":"1fdcf601682d016414655e1bef6fa3ccb3a26056","user":{"login":"obnoxxx","id":8081179,"avatar_url":"https://avatars.githubusercontent.com/u/8081179?v=3","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"repo":{"id":75355993,"name":"kubernetes","full_name":"obnoxxx/kubernetes","owner":{"login":"obnoxxx","id":8081179,"avatar_url":"https://avatars.githubusercontent.com/u/8081179?v=3","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obnoxxx/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/obnoxxx/kubernetes","forks_url":"https://api.github.com/repos/obnoxxx/kubernetes/forks","keys_url":"https://api.github.com/repos/obnoxxx/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obnoxxx/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obnoxxx/kubernetes/teams","hooks_url":"https://api.github.com/repos/obnoxxx/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/obnoxxx/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/obnoxxx/kubernetes/events","assignees_url":"https://api.github.com/repos/obnoxxx/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/obnoxxx/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/obnoxxx/kubernetes/tags","blobs_url":"https://api.github.com/repos/obnoxxx/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obnoxxx/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obnoxxx/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/obnoxxx/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obnoxxx/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/obnoxxx/kubernetes/languages","stargazers_url":"https://api.github.com/repos/obnoxxx/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/obnoxxx/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/obnoxxx/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/obnoxxx/kubernetes/subscription","commits_url":"https://api.github.com/repos/obnoxxx/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/obnoxxx/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/obnoxxx/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/obnoxxx/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/obnoxxx/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/obnoxxx/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obnoxxx/kubernetes/merges","archive_url":"https://api.github.com/repos/obnoxxx/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obnoxxx/kubernetes/downloads","issues_url":"https://api.github.com/repos/obnoxxx/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/obnoxxx/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/obnoxxx/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/obnoxxx/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obnoxxx/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/obnoxxx/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/obnoxxx/kubernetes/deployments","created_at":"2016-12-02T03:13:25Z","updated_at":"2016-12-02T03:14:04Z","pushed_at":"2016-12-02T03:38:55Z","git_url":"git://github.com/obnoxxx/kubernetes.git","ssh_url":"git@github.com:obnoxxx/kubernetes.git","clone_url":"https://github.com/obnoxxx/kubernetes.git","svn_url":"https://github.com/obnoxxx/kubernetes","homepage":"http://kubernetes.io","size":358700,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6abb4723571fc6b9e4dc05807511569dfc865f83","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-02T10:03:09Z","pushed_at":"2016-12-02T10:37:37Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":650283,"stargazers_count":18846,"watchers_count":18846,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6255,"mirror_url":null,"open_issues_count":5376,"forks":6255,"open_issues":5376,"watchers":18846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37886"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37886"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37886/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37886/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1fdcf601682d016414655e1bef6fa3ccb3a26056"}}}}
{"actor":{"display_login":"obnoxxx"}}