{"action":"created","comment":{"url":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/comments/75921971","id":75921971,"diff_hunk":"@@ -90,7 +90,7 @@ public void threadedPortTest() throws Exception{\n                 lowLatencyTag = (String) placement.get(JOperator.PLACEMENT_LOW_LATENCY_REGION_ID);\n             String kind = (String)op.get(\"kind\");\n             JSONObject queue = (JSONObject) op.get(\"queue\");\n-            if(queue != null && (lowLatencyTag!=null || lowLatencyTag.equals(\"\"))){\n+            if(queue != null && (lowLatencyTag == null || lowLatencyTag.equals(\"\"))){","path":"test/java/src/com/ibm/streamsx/topology/test/api/LowLatencyTest.java","position":5,"original_position":5,"commit_id":"de8099088e7e41be89d8cd8e86759f455fa28491","original_commit_id":"de8099088e7e41be89d8cd8e86759f455fa28491","user":{"login":"vdogaru","id":13647061,"avatar_url":"https://avatars.githubusercontent.com/u/13647061?v=3","gravatar_id":"","url":"https://api.github.com/users/vdogaru","html_url":"https://github.com/vdogaru","followers_url":"https://api.github.com/users/vdogaru/followers","following_url":"https://api.github.com/users/vdogaru/following{/other_user}","gists_url":"https://api.github.com/users/vdogaru/gists{/gist_id}","starred_url":"https://api.github.com/users/vdogaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdogaru/subscriptions","organizations_url":"https://api.github.com/users/vdogaru/orgs","repos_url":"https://api.github.com/users/vdogaru/repos","events_url":"https://api.github.com/users/vdogaru/events{/privacy}","received_events_url":"https://api.github.com/users/vdogaru/received_events","type":"User","site_admin":false},"body":"Replacing `equals(\"\")` with i`sEmpty()`:\r\n\r\n1. `if (queue != null && (lowLatencyTag == null || lowLatencyTag.isEmpty()))`\r\n2. `if (queue != null && (lowLatencyTag != null && !lowLatencyTag.isEmpty()))`\r\n\r\nI'm not familiar with the graph model and cannot decide: which alternative makes more sense, (1) or (2)?","created_at":"2016-08-23T18:17:10Z","updated_at":"2016-08-23T18:17:10Z","html_url":"https://github.com/IBMStreams/streamsx.topology/pull/473#discussion_r75921971","pull_request_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473","_links":{"self":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/comments/75921971"},"html":{"href":"https://github.com/IBMStreams/streamsx.topology/pull/473#discussion_r75921971"},"pull_request":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473","id":82251868,"html_url":"https://github.com/IBMStreams/streamsx.topology/pull/473","diff_url":"https://github.com/IBMStreams/streamsx.topology/pull/473.diff","patch_url":"https://github.com/IBMStreams/streamsx.topology/pull/473.patch","issue_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/issues/473","number":473,"state":"open","locked":false,"title":"Add python 3 to the dependency list and fix several build warnings","user":{"login":"vdogaru","id":13647061,"avatar_url":"https://avatars.githubusercontent.com/u/13647061?v=3","gravatar_id":"","url":"https://api.github.com/users/vdogaru","html_url":"https://github.com/vdogaru","followers_url":"https://api.github.com/users/vdogaru/followers","following_url":"https://api.github.com/users/vdogaru/following{/other_user}","gists_url":"https://api.github.com/users/vdogaru/gists{/gist_id}","starred_url":"https://api.github.com/users/vdogaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdogaru/subscriptions","organizations_url":"https://api.github.com/users/vdogaru/orgs","repos_url":"https://api.github.com/users/vdogaru/repos","events_url":"https://api.github.com/users/vdogaru/events{/privacy}","received_events_url":"https://api.github.com/users/vdogaru/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-22T19:53:09Z","updated_at":"2016-08-23T18:17:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9145d0f775cb3f8d41c7148c4b0b5985cdd9678","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473/commits","review_comments_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473/comments","review_comment_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/issues/473/comments","statuses_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/statuses/de8099088e7e41be89d8cd8e86759f455fa28491","head":{"label":"vdogaru:warn-fix-vdogaru","ref":"warn-fix-vdogaru","sha":"de8099088e7e41be89d8cd8e86759f455fa28491","user":{"login":"vdogaru","id":13647061,"avatar_url":"https://avatars.githubusercontent.com/u/13647061?v=3","gravatar_id":"","url":"https://api.github.com/users/vdogaru","html_url":"https://github.com/vdogaru","followers_url":"https://api.github.com/users/vdogaru/followers","following_url":"https://api.github.com/users/vdogaru/following{/other_user}","gists_url":"https://api.github.com/users/vdogaru/gists{/gist_id}","starred_url":"https://api.github.com/users/vdogaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdogaru/subscriptions","organizations_url":"https://api.github.com/users/vdogaru/orgs","repos_url":"https://api.github.com/users/vdogaru/repos","events_url":"https://api.github.com/users/vdogaru/events{/privacy}","received_events_url":"https://api.github.com/users/vdogaru/received_events","type":"User","site_admin":false},"repo":{"id":60130056,"name":"streamsx.topology","full_name":"vdogaru/streamsx.topology","owner":{"login":"vdogaru","id":13647061,"avatar_url":"https://avatars.githubusercontent.com/u/13647061?v=3","gravatar_id":"","url":"https://api.github.com/users/vdogaru","html_url":"https://github.com/vdogaru","followers_url":"https://api.github.com/users/vdogaru/followers","following_url":"https://api.github.com/users/vdogaru/following{/other_user}","gists_url":"https://api.github.com/users/vdogaru/gists{/gist_id}","starred_url":"https://api.github.com/users/vdogaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdogaru/subscriptions","organizations_url":"https://api.github.com/users/vdogaru/orgs","repos_url":"https://api.github.com/users/vdogaru/repos","events_url":"https://api.github.com/users/vdogaru/events{/privacy}","received_events_url":"https://api.github.com/users/vdogaru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdogaru/streamsx.topology","description":"(Incubation) A project that supports building streaming topologies (applications) for IBM Streams in different programming languages, such as Java, Scala and Python.","fork":true,"url":"https://api.github.com/repos/vdogaru/streamsx.topology","forks_url":"https://api.github.com/repos/vdogaru/streamsx.topology/forks","keys_url":"https://api.github.com/repos/vdogaru/streamsx.topology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdogaru/streamsx.topology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdogaru/streamsx.topology/teams","hooks_url":"https://api.github.com/repos/vdogaru/streamsx.topology/hooks","issue_events_url":"https://api.github.com/repos/vdogaru/streamsx.topology/issues/events{/number}","events_url":"https://api.github.com/repos/vdogaru/streamsx.topology/events","assignees_url":"https://api.github.com/repos/vdogaru/streamsx.topology/assignees{/user}","branches_url":"https://api.github.com/repos/vdogaru/streamsx.topology/branches{/branch}","tags_url":"https://api.github.com/repos/vdogaru/streamsx.topology/tags","blobs_url":"https://api.github.com/repos/vdogaru/streamsx.topology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdogaru/streamsx.topology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdogaru/streamsx.topology/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdogaru/streamsx.topology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdogaru/streamsx.topology/statuses/{sha}","languages_url":"https://api.github.com/repos/vdogaru/streamsx.topology/languages","stargazers_url":"https://api.github.com/repos/vdogaru/streamsx.topology/stargazers","contributors_url":"https://api.github.com/repos/vdogaru/streamsx.topology/contributors","subscribers_url":"https://api.github.com/repos/vdogaru/streamsx.topology/subscribers","subscription_url":"https://api.github.com/repos/vdogaru/streamsx.topology/subscription","commits_url":"https://api.github.com/repos/vdogaru/streamsx.topology/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdogaru/streamsx.topology/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdogaru/streamsx.topology/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdogaru/streamsx.topology/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdogaru/streamsx.topology/contents/{+path}","compare_url":"https://api.github.com/repos/vdogaru/streamsx.topology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdogaru/streamsx.topology/merges","archive_url":"https://api.github.com/repos/vdogaru/streamsx.topology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdogaru/streamsx.topology/downloads","issues_url":"https://api.github.com/repos/vdogaru/streamsx.topology/issues{/number}","pulls_url":"https://api.github.com/repos/vdogaru/streamsx.topology/pulls{/number}","milestones_url":"https://api.github.com/repos/vdogaru/streamsx.topology/milestones{/number}","notifications_url":"https://api.github.com/repos/vdogaru/streamsx.topology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdogaru/streamsx.topology/labels{/name}","releases_url":"https://api.github.com/repos/vdogaru/streamsx.topology/releases{/id}","deployments_url":"https://api.github.com/repos/vdogaru/streamsx.topology/deployments","created_at":"2016-05-31T23:17:35Z","updated_at":"2016-05-31T23:17:37Z","pushed_at":"2016-08-22T19:49:42Z","git_url":"git://github.com/vdogaru/streamsx.topology.git","ssh_url":"git@github.com:vdogaru/streamsx.topology.git","clone_url":"https://github.com/vdogaru/streamsx.topology.git","svn_url":"https://github.com/vdogaru/streamsx.topology","homepage":"http://ibmstreams.github.io/streamsx.topology","size":7209,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IBMStreams:master","ref":"master","sha":"d8828ccf3e32cb8a7629f9e325fc14f565cf913e","user":{"login":"IBMStreams","id":5439177,"avatar_url":"https://avatars.githubusercontent.com/u/5439177?v=3","gravatar_id":"","url":"https://api.github.com/users/IBMStreams","html_url":"https://github.com/IBMStreams","followers_url":"https://api.github.com/users/IBMStreams/followers","following_url":"https://api.github.com/users/IBMStreams/following{/other_user}","gists_url":"https://api.github.com/users/IBMStreams/gists{/gist_id}","starred_url":"https://api.github.com/users/IBMStreams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBMStreams/subscriptions","organizations_url":"https://api.github.com/users/IBMStreams/orgs","repos_url":"https://api.github.com/users/IBMStreams/repos","events_url":"https://api.github.com/users/IBMStreams/events{/privacy}","received_events_url":"https://api.github.com/users/IBMStreams/received_events","type":"Organization","site_admin":false},"repo":{"id":36458001,"name":"streamsx.topology","full_name":"IBMStreams/streamsx.topology","owner":{"login":"IBMStreams","id":5439177,"avatar_url":"https://avatars.githubusercontent.com/u/5439177?v=3","gravatar_id":"","url":"https://api.github.com/users/IBMStreams","html_url":"https://github.com/IBMStreams","followers_url":"https://api.github.com/users/IBMStreams/followers","following_url":"https://api.github.com/users/IBMStreams/following{/other_user}","gists_url":"https://api.github.com/users/IBMStreams/gists{/gist_id}","starred_url":"https://api.github.com/users/IBMStreams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBMStreams/subscriptions","organizations_url":"https://api.github.com/users/IBMStreams/orgs","repos_url":"https://api.github.com/users/IBMStreams/repos","events_url":"https://api.github.com/users/IBMStreams/events{/privacy}","received_events_url":"https://api.github.com/users/IBMStreams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IBMStreams/streamsx.topology","description":"(Incubation) A project that supports building streaming topologies (applications) for IBM Streams in different programming languages, such as Java, Scala and Python.","fork":false,"url":"https://api.github.com/repos/IBMStreams/streamsx.topology","forks_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/forks","keys_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/teams","hooks_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/hooks","issue_events_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/issues/events{/number}","events_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/events","assignees_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/assignees{/user}","branches_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/branches{/branch}","tags_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/tags","blobs_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/statuses/{sha}","languages_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/languages","stargazers_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/stargazers","contributors_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/contributors","subscribers_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/subscribers","subscription_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/subscription","commits_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/contents/{+path}","compare_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/merges","archive_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/downloads","issues_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/issues{/number}","pulls_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls{/number}","milestones_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/milestones{/number}","notifications_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/labels{/name}","releases_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/releases{/id}","deployments_url":"https://api.github.com/repos/IBMStreams/streamsx.topology/deployments","created_at":"2015-05-28T18:30:13Z","updated_at":"2016-07-21T04:09:27Z","pushed_at":"2016-08-23T15:40:17Z","git_url":"git://github.com/IBMStreams/streamsx.topology.git","ssh_url":"git@github.com:IBMStreams/streamsx.topology.git","clone_url":"https://github.com/IBMStreams/streamsx.topology.git","svn_url":"https://github.com/IBMStreams/streamsx.topology","homepage":"http://ibmstreams.github.io/streamsx.topology","size":7255,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":89,"forks":24,"open_issues":89,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473"},"html":{"href":"https://github.com/IBMStreams/streamsx.topology/pull/473"},"issue":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/issues/473"},"comments":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/IBMStreams/streamsx.topology/statuses/de8099088e7e41be89d8cd8e86759f455fa28491"}}}}
{"actor":{"display_login":"vdogaru"}}