{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/14261","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/14261/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/14261/comments","events_url":"https://api.github.com/repos/servo/servo/issues/14261/events","html_url":"https://github.com/servo/servo/pull/14261","id":190067723,"number":14261,"title":"Prefer Either type for LengthOrNumber","user":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"labels":[{"id":155503129,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-merge","name":"S-awaiting-merge","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"assignees":[{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-11-17T14:49:36Z","updated_at":"2016-11-18T13:35:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/14261","html_url":"https://github.com/servo/servo/pull/14261","diff_url":"https://github.com/servo/servo/pull/14261.diff","patch_url":"https://github.com/servo/servo/pull/14261.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nThis adds `impl GeckoStyleCoordConvertible for Either<A, B>` and makes `LengthOrNumber` prefer `Either<A, B>`.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach build-geckolib` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n\r\n<!-- Either: -->\r\n- [x] These changes do not require tests because it's a refactor\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\nr? @SimonSapin\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/14261)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/261532919","html_url":"https://github.com/servo/servo/pull/14261#issuecomment-261532919","issue_url":"https://api.github.com/repos/servo/servo/issues/14261","id":261532919,"user":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T13:35:58Z","updated_at":"2016-11-18T13:35:58Z","body":"Thanks! :)"}}
{"actor":{"display_login":"Wafflespeanut"}}