{"action":"created","comment":{"url":"https://api.github.com/repos/ponylang/ponyc/pulls/comments/85405874","pull_request_review_id":6125467,"id":85405874,"diff_hunk":"@@ -44,7 +44,14 @@ Before issuing a pull request we ask that you squash all your commits into a sin\n \n If you aren't sure how to squash multiple commits into one, Steve Klabnik wrote [a handy guide](http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request) that you can refer to.\n \n-We keep a [CHANGELOG](CHANGELOG.md) of all software changes with behavioural effects in ponyc. If your PR includes such changes (rather than say a documentation update), please make sure that as part of PR, you have also updated the CHANGELOG. The entries in the CHANGELOG are in time-ascending order, so please add your change description to the bottom of the appropriate section (\"Fixed\", \"Added\", or \"Changed\") of the \"unreleased\" log.\n+We keep a [CHANGELOG](CHANGELOG.md) of all software changes with behavioural effects in ponyc. If your PR includes such changes (rather than say a documentation update), a Pony team member will do the following before merging it, so that the PR will be automatically added to the CHANGELOG:\n+\n+* Ensure that the ticket is tagged with one or more appropriate \"changelog - *\" labels - each label corresponds to a section of the changelog where this change will be automatically mentioned.\n+* Ensure that the ticket title is appropriate - the title will be used as the summary of the change, so it should be appropriately formatted, including a ticket reference if the PR is a fix to an existing bug ticket.\n+  * For example, an appropriate title for a PR that fixes a bug reported in issue ticket #98 might look like:\n+  * *Fixed compiler crash related to tuple recovery (issue #98)*\n+\n+Once those conditions are met, the PR can be merged, and an automated system will immediately add the entry to the changelog. Keeping the changelog entries out of the file changes in the PR helps to avoid conflicts and other administrative headaches when many PRs are in progress.","path":"CONTRIBUTING.md","position":12,"original_position":12,"commit_id":"c5669465878c025a39661ddc3e0167232bd42dd8","original_commit_id":"c5669465878c025a39661ddc3e0167232bd42dd8","user":{"login":"jemc","id":4623870,"avatar_url":"https://avatars.githubusercontent.com/u/4623870?v=3","gravatar_id":"","url":"https://api.github.com/users/jemc","html_url":"https://github.com/jemc","followers_url":"https://api.github.com/users/jemc/followers","following_url":"https://api.github.com/users/jemc/following{/other_user}","gists_url":"https://api.github.com/users/jemc/gists{/gist_id}","starred_url":"https://api.github.com/users/jemc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jemc/subscriptions","organizations_url":"https://api.github.com/users/jemc/orgs","repos_url":"https://api.github.com/users/jemc/repos","events_url":"https://api.github.com/users/jemc/events{/privacy}","received_events_url":"https://api.github.com/users/jemc/received_events","type":"User","site_admin":false},"body":"Such a plan would seem to add a lot more complexity and dependence on the bot than I otherwise anticipated.\r\n\r\nI also don't think I can do a `commit --amend` via the github API, so I don't think I can do it with this hosted hook service I picked up - I think such a bot would have to be implemented in a self-hosted way that we were trying to avoid.","created_at":"2016-10-27T19:06:31Z","updated_at":"2016-10-27T19:06:31Z","html_url":"https://github.com/ponylang/ponyc/pull/1373#discussion_r85405874","pull_request_url":"https://api.github.com/repos/ponylang/ponyc/pulls/1373","_links":{"self":{"href":"https://api.github.com/repos/ponylang/ponyc/pulls/comments/85405874"},"html":{"href":"https://github.com/ponylang/ponyc/pull/1373#discussion_r85405874"},"pull_request":{"href":"https://api.github.com/repos/ponylang/ponyc/pulls/1373"}}},"pull_request":{"url":"https://api.github.com/repos/ponylang/ponyc/pulls/1373","id":91145165,"html_url":"https://github.com/ponylang/ponyc/pull/1373","diff_url":"https://github.com/ponylang/ponyc/pull/1373.diff","patch_url":"https://github.com/ponylang/ponyc/pull/1373.patch","issue_url":"https://api.github.com/repos/ponylang/ponyc/issues/1373","number":1373,"state":"open","locked":false,"title":"Automated changelog entry system for PR merges.","user":{"login":"jemc","id":4623870,"avatar_url":"https://avatars.githubusercontent.com/u/4623870?v=3","gravatar_id":"","url":"https://api.github.com/users/jemc","html_url":"https://github.com/jemc","followers_url":"https://api.github.com/users/jemc/followers","following_url":"https://api.github.com/users/jemc/following{/other_user}","gists_url":"https://api.github.com/users/jemc/gists{/gist_id}","starred_url":"https://api.github.com/users/jemc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jemc/subscriptions","organizations_url":"https://api.github.com/users/jemc/orgs","repos_url":"https://api.github.com/users/jemc/repos","events_url":"https://api.github.com/users/jemc/events{/privacy}","received_events_url":"https://api.github.com/users/jemc/received_events","type":"User","site_admin":false},"body":"This PR adds documentation for a new way of dealing with the changelog entries for new PRs.\r\n\r\nPony team members who merge PRs should review the new system.  The TLDR is:\r\n\r\n* stop requiring users to include a changelog entry in their PR.\r\n* instead, just be sure the PR has an appropriate title and any applicable \"changelog - *\" label(s) before merging.\r\n\r\nTheoretically this system should already be usable at the time of this writing, though I haven't tested the bot on the \"real\" ponyc repository yet.\r\n\r\nNote that the old system will still continue to work.  For existing PRs where the user already included a changelog entry in the diff, simply avoid applying the \"changelog - *\" label and the bot will leave the changelog alone.","created_at":"2016-10-27T07:15:38Z","updated_at":"2016-10-27T19:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9bc2422d3a1c9437e345bb794821529a04c3e37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ponylang/ponyc/pulls/1373/commits","review_comments_url":"https://api.github.com/repos/ponylang/ponyc/pulls/1373/comments","review_comment_url":"https://api.github.com/repos/ponylang/ponyc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ponylang/ponyc/issues/1373/comments","statuses_url":"https://api.github.com/repos/ponylang/ponyc/statuses/c5669465878c025a39661ddc3e0167232bd42dd8","head":{"label":"ponylang:feature/automatic-changelog-entry-on-pr-merge","ref":"feature/automatic-changelog-entry-on-pr-merge","sha":"c5669465878c025a39661ddc3e0167232bd42dd8","user":{"login":"ponylang","id":12997238,"avatar_url":"https://avatars.githubusercontent.com/u/12997238?v=3","gravatar_id":"","url":"https://api.github.com/users/ponylang","html_url":"https://github.com/ponylang","followers_url":"https://api.github.com/users/ponylang/followers","following_url":"https://api.github.com/users/ponylang/following{/other_user}","gists_url":"https://api.github.com/users/ponylang/gists{/gist_id}","starred_url":"https://api.github.com/users/ponylang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ponylang/subscriptions","organizations_url":"https://api.github.com/users/ponylang/orgs","repos_url":"https://api.github.com/users/ponylang/repos","events_url":"https://api.github.com/users/ponylang/events{/privacy}","received_events_url":"https://api.github.com/users/ponylang/received_events","type":"Organization","site_admin":false},"repo":{"id":6667084,"name":"ponyc","full_name":"ponylang/ponyc","owner":{"login":"ponylang","id":12997238,"avatar_url":"https://avatars.githubusercontent.com/u/12997238?v=3","gravatar_id":"","url":"https://api.github.com/users/ponylang","html_url":"https://github.com/ponylang","followers_url":"https://api.github.com/users/ponylang/followers","following_url":"https://api.github.com/users/ponylang/following{/other_user}","gists_url":"https://api.github.com/users/ponylang/gists{/gist_id}","starred_url":"https://api.github.com/users/ponylang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ponylang/subscriptions","organizations_url":"https://api.github.com/users/ponylang/orgs","repos_url":"https://api.github.com/users/ponylang/repos","events_url":"https://api.github.com/users/ponylang/events{/privacy}","received_events_url":"https://api.github.com/users/ponylang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ponylang/ponyc","description":"Pony is an open-source, object-oriented, actor-model, capabilities-secure, high performance programming language","fork":false,"url":"https://api.github.com/repos/ponylang/ponyc","forks_url":"https://api.github.com/repos/ponylang/ponyc/forks","keys_url":"https://api.github.com/repos/ponylang/ponyc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ponylang/ponyc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ponylang/ponyc/teams","hooks_url":"https://api.github.com/repos/ponylang/ponyc/hooks","issue_events_url":"https://api.github.com/repos/ponylang/ponyc/issues/events{/number}","events_url":"https://api.github.com/repos/ponylang/ponyc/events","assignees_url":"https://api.github.com/repos/ponylang/ponyc/assignees{/user}","branches_url":"https://api.github.com/repos/ponylang/ponyc/branches{/branch}","tags_url":"https://api.github.com/repos/ponylang/ponyc/tags","blobs_url":"https://api.github.com/repos/ponylang/ponyc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ponylang/ponyc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ponylang/ponyc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ponylang/ponyc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ponylang/ponyc/statuses/{sha}","languages_url":"https://api.github.com/repos/ponylang/ponyc/languages","stargazers_url":"https://api.github.com/repos/ponylang/ponyc/stargazers","contributors_url":"https://api.github.com/repos/ponylang/ponyc/contributors","subscribers_url":"https://api.github.com/repos/ponylang/ponyc/subscribers","subscription_url":"https://api.github.com/repos/ponylang/ponyc/subscription","commits_url":"https://api.github.com/repos/ponylang/ponyc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ponylang/ponyc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ponylang/ponyc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ponylang/ponyc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ponylang/ponyc/contents/{+path}","compare_url":"https://api.github.com/repos/ponylang/ponyc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ponylang/ponyc/merges","archive_url":"https://api.github.com/repos/ponylang/ponyc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ponylang/ponyc/downloads","issues_url":"https://api.github.com/repos/ponylang/ponyc/issues{/number}","pulls_url":"https://api.github.com/repos/ponylang/ponyc/pulls{/number}","milestones_url":"https://api.github.com/repos/ponylang/ponyc/milestones{/number}","notifications_url":"https://api.github.com/repos/ponylang/ponyc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ponylang/ponyc/labels{/name}","releases_url":"https://api.github.com/repos/ponylang/ponyc/releases{/id}","deployments_url":"https://api.github.com/repos/ponylang/ponyc/deployments","created_at":"2012-11-13T07:38:25Z","updated_at":"2016-10-26T03:01:15Z","pushed_at":"2016-10-27T17:49:26Z","git_url":"git://github.com/ponylang/ponyc.git","ssh_url":"git@github.com:ponylang/ponyc.git","clone_url":"https://github.com/ponylang/ponyc.git","svn_url":"https://github.com/ponylang/ponyc","homepage":"http://www.ponylang.org","size":118369,"stargazers_count":1893,"watchers_count":1893,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":143,"mirror_url":null,"open_issues_count":83,"forks":143,"open_issues":83,"watchers":1893,"default_branch":"master"}},"base":{"label":"ponylang:master","ref":"master","sha":"f9591b2ed4ee95b5db181574c030da22531a13ad","user":{"login":"ponylang","id":12997238,"avatar_url":"https://avatars.githubusercontent.com/u/12997238?v=3","gravatar_id":"","url":"https://api.github.com/users/ponylang","html_url":"https://github.com/ponylang","followers_url":"https://api.github.com/users/ponylang/followers","following_url":"https://api.github.com/users/ponylang/following{/other_user}","gists_url":"https://api.github.com/users/ponylang/gists{/gist_id}","starred_url":"https://api.github.com/users/ponylang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ponylang/subscriptions","organizations_url":"https://api.github.com/users/ponylang/orgs","repos_url":"https://api.github.com/users/ponylang/repos","events_url":"https://api.github.com/users/ponylang/events{/privacy}","received_events_url":"https://api.github.com/users/ponylang/received_events","type":"Organization","site_admin":false},"repo":{"id":6667084,"name":"ponyc","full_name":"ponylang/ponyc","owner":{"login":"ponylang","id":12997238,"avatar_url":"https://avatars.githubusercontent.com/u/12997238?v=3","gravatar_id":"","url":"https://api.github.com/users/ponylang","html_url":"https://github.com/ponylang","followers_url":"https://api.github.com/users/ponylang/followers","following_url":"https://api.github.com/users/ponylang/following{/other_user}","gists_url":"https://api.github.com/users/ponylang/gists{/gist_id}","starred_url":"https://api.github.com/users/ponylang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ponylang/subscriptions","organizations_url":"https://api.github.com/users/ponylang/orgs","repos_url":"https://api.github.com/users/ponylang/repos","events_url":"https://api.github.com/users/ponylang/events{/privacy}","received_events_url":"https://api.github.com/users/ponylang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ponylang/ponyc","description":"Pony is an open-source, object-oriented, actor-model, capabilities-secure, high performance programming language","fork":false,"url":"https://api.github.com/repos/ponylang/ponyc","forks_url":"https://api.github.com/repos/ponylang/ponyc/forks","keys_url":"https://api.github.com/repos/ponylang/ponyc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ponylang/ponyc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ponylang/ponyc/teams","hooks_url":"https://api.github.com/repos/ponylang/ponyc/hooks","issue_events_url":"https://api.github.com/repos/ponylang/ponyc/issues/events{/number}","events_url":"https://api.github.com/repos/ponylang/ponyc/events","assignees_url":"https://api.github.com/repos/ponylang/ponyc/assignees{/user}","branches_url":"https://api.github.com/repos/ponylang/ponyc/branches{/branch}","tags_url":"https://api.github.com/repos/ponylang/ponyc/tags","blobs_url":"https://api.github.com/repos/ponylang/ponyc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ponylang/ponyc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ponylang/ponyc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ponylang/ponyc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ponylang/ponyc/statuses/{sha}","languages_url":"https://api.github.com/repos/ponylang/ponyc/languages","stargazers_url":"https://api.github.com/repos/ponylang/ponyc/stargazers","contributors_url":"https://api.github.com/repos/ponylang/ponyc/contributors","subscribers_url":"https://api.github.com/repos/ponylang/ponyc/subscribers","subscription_url":"https://api.github.com/repos/ponylang/ponyc/subscription","commits_url":"https://api.github.com/repos/ponylang/ponyc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ponylang/ponyc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ponylang/ponyc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ponylang/ponyc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ponylang/ponyc/contents/{+path}","compare_url":"https://api.github.com/repos/ponylang/ponyc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ponylang/ponyc/merges","archive_url":"https://api.github.com/repos/ponylang/ponyc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ponylang/ponyc/downloads","issues_url":"https://api.github.com/repos/ponylang/ponyc/issues{/number}","pulls_url":"https://api.github.com/repos/ponylang/ponyc/pulls{/number}","milestones_url":"https://api.github.com/repos/ponylang/ponyc/milestones{/number}","notifications_url":"https://api.github.com/repos/ponylang/ponyc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ponylang/ponyc/labels{/name}","releases_url":"https://api.github.com/repos/ponylang/ponyc/releases{/id}","deployments_url":"https://api.github.com/repos/ponylang/ponyc/deployments","created_at":"2012-11-13T07:38:25Z","updated_at":"2016-10-26T03:01:15Z","pushed_at":"2016-10-27T17:49:26Z","git_url":"git://github.com/ponylang/ponyc.git","ssh_url":"git@github.com:ponylang/ponyc.git","clone_url":"https://github.com/ponylang/ponyc.git","svn_url":"https://github.com/ponylang/ponyc","homepage":"http://www.ponylang.org","size":118369,"stargazers_count":1893,"watchers_count":1893,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":143,"mirror_url":null,"open_issues_count":83,"forks":143,"open_issues":83,"watchers":1893,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ponylang/ponyc/pulls/1373"},"html":{"href":"https://github.com/ponylang/ponyc/pull/1373"},"issue":{"href":"https://api.github.com/repos/ponylang/ponyc/issues/1373"},"comments":{"href":"https://api.github.com/repos/ponylang/ponyc/issues/1373/comments"},"review_comments":{"href":"https://api.github.com/repos/ponylang/ponyc/pulls/1373/comments"},"review_comment":{"href":"https://api.github.com/repos/ponylang/ponyc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ponylang/ponyc/pulls/1373/commits"},"statuses":{"href":"https://api.github.com/repos/ponylang/ponyc/statuses/c5669465878c025a39661ddc3e0167232bd42dd8"}}}}
{"actor":{"display_login":"jemc"}}