{"action":"closed","number":76,"pull_request":{"url":"https://api.github.com/repos/guilhermesad/rspotify/pulls/76","id":57505783,"html_url":"https://github.com/guilhermesad/rspotify/pull/76","diff_url":"https://github.com/guilhermesad/rspotify/pull/76.diff","patch_url":"https://github.com/guilhermesad/rspotify/pull/76.patch","issue_url":"https://api.github.com/repos/guilhermesad/rspotify/issues/76","number":76,"state":"closed","locked":false,"title":"Fix an issue that leads to an SystemStackError: stack level too deep","user":{"login":"oliverprater","id":44027,"avatar_url":"https://avatars.githubusercontent.com/u/44027?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverprater","html_url":"https://github.com/oliverprater","followers_url":"https://api.github.com/users/oliverprater/followers","following_url":"https://api.github.com/users/oliverprater/following{/other_user}","gists_url":"https://api.github.com/users/oliverprater/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverprater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverprater/subscriptions","organizations_url":"https://api.github.com/users/oliverprater/orgs","repos_url":"https://api.github.com/users/oliverprater/repos","events_url":"https://api.github.com/users/oliverprater/events{/privacy}","received_events_url":"https://api.github.com/users/oliverprater/received_events","type":"User","site_admin":false},"body":"Our application has experienced the following issue:\r\n\r\n```\r\nSystemStackError: stack level too deep\r\nfrom lib/rspotify/base.rb:135:in `complete!'\r\n```\r\n\r\nWhile investigating the issue we found that this error was caused with the merge of https://github.com/guilhermesad/rspotify/commit/c5a62ca155e17393c3a038a8dec8f1aeed2ad3ce\r\n\r\nThe code prior was correctly using the class instance variable with `pluralized_type = \"#{@type}s\"`.\r\n\r\nThe new code calls method_missing on the variable `type` in `initialize RSpotify.get(\"#{type}s/#{@id}\")`.\r\n\r\nIn case `@type` is `nil` the system stack overflows as `complete!` is called from `method_missing`.\r\n\r\nWe have fixed the issue by monkey patching RSpotify, but I think an stack overflow should also be fixed on ruby gems, hence the pull request.\r\n\r\nBest!\r\nOliver \r\n\r\n","created_at":"2016-01-28T14:03:58Z","updated_at":"2016-01-31T19:18:20Z","closed_at":"2016-01-31T19:18:19Z","merged_at":"2016-01-31T19:18:19Z","merge_commit_sha":"2d1bf399a75bd2eb6cd5ea5a23f4959cd81608cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guilhermesad/rspotify/pulls/76/commits","review_comments_url":"https://api.github.com/repos/guilhermesad/rspotify/pulls/76/comments","review_comment_url":"https://api.github.com/repos/guilhermesad/rspotify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guilhermesad/rspotify/issues/76/comments","statuses_url":"https://api.github.com/repos/guilhermesad/rspotify/statuses/b25b7f83305b95fe4bd985bf7d4a445f80ff32e0","head":{"label":"oliverprater:master","ref":"master","sha":"b25b7f83305b95fe4bd985bf7d4a445f80ff32e0","user":{"login":"oliverprater","id":44027,"avatar_url":"https://avatars.githubusercontent.com/u/44027?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverprater","html_url":"https://github.com/oliverprater","followers_url":"https://api.github.com/users/oliverprater/followers","following_url":"https://api.github.com/users/oliverprater/following{/other_user}","gists_url":"https://api.github.com/users/oliverprater/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverprater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverprater/subscriptions","organizations_url":"https://api.github.com/users/oliverprater/orgs","repos_url":"https://api.github.com/users/oliverprater/repos","events_url":"https://api.github.com/users/oliverprater/events{/privacy}","received_events_url":"https://api.github.com/users/oliverprater/received_events","type":"User","site_admin":false},"repo":{"id":50585340,"name":"rspotify","full_name":"oliverprater/rspotify","owner":{"login":"oliverprater","id":44027,"avatar_url":"https://avatars.githubusercontent.com/u/44027?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverprater","html_url":"https://github.com/oliverprater","followers_url":"https://api.github.com/users/oliverprater/followers","following_url":"https://api.github.com/users/oliverprater/following{/other_user}","gists_url":"https://api.github.com/users/oliverprater/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverprater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverprater/subscriptions","organizations_url":"https://api.github.com/users/oliverprater/orgs","repos_url":"https://api.github.com/users/oliverprater/repos","events_url":"https://api.github.com/users/oliverprater/events{/privacy}","received_events_url":"https://api.github.com/users/oliverprater/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oliverprater/rspotify","description":"A ruby wrapper for the Spotify Web API","fork":true,"url":"https://api.github.com/repos/oliverprater/rspotify","forks_url":"https://api.github.com/repos/oliverprater/rspotify/forks","keys_url":"https://api.github.com/repos/oliverprater/rspotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oliverprater/rspotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oliverprater/rspotify/teams","hooks_url":"https://api.github.com/repos/oliverprater/rspotify/hooks","issue_events_url":"https://api.github.com/repos/oliverprater/rspotify/issues/events{/number}","events_url":"https://api.github.com/repos/oliverprater/rspotify/events","assignees_url":"https://api.github.com/repos/oliverprater/rspotify/assignees{/user}","branches_url":"https://api.github.com/repos/oliverprater/rspotify/branches{/branch}","tags_url":"https://api.github.com/repos/oliverprater/rspotify/tags","blobs_url":"https://api.github.com/repos/oliverprater/rspotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oliverprater/rspotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oliverprater/rspotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/oliverprater/rspotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oliverprater/rspotify/statuses/{sha}","languages_url":"https://api.github.com/repos/oliverprater/rspotify/languages","stargazers_url":"https://api.github.com/repos/oliverprater/rspotify/stargazers","contributors_url":"https://api.github.com/repos/oliverprater/rspotify/contributors","subscribers_url":"https://api.github.com/repos/oliverprater/rspotify/subscribers","subscription_url":"https://api.github.com/repos/oliverprater/rspotify/subscription","commits_url":"https://api.github.com/repos/oliverprater/rspotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/oliverprater/rspotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/oliverprater/rspotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/oliverprater/rspotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/oliverprater/rspotify/contents/{+path}","compare_url":"https://api.github.com/repos/oliverprater/rspotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oliverprater/rspotify/merges","archive_url":"https://api.github.com/repos/oliverprater/rspotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oliverprater/rspotify/downloads","issues_url":"https://api.github.com/repos/oliverprater/rspotify/issues{/number}","pulls_url":"https://api.github.com/repos/oliverprater/rspotify/pulls{/number}","milestones_url":"https://api.github.com/repos/oliverprater/rspotify/milestones{/number}","notifications_url":"https://api.github.com/repos/oliverprater/rspotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oliverprater/rspotify/labels{/name}","releases_url":"https://api.github.com/repos/oliverprater/rspotify/releases{/id}","deployments_url":"https://api.github.com/repos/oliverprater/rspotify/deployments","created_at":"2016-01-28T13:38:41Z","updated_at":"2016-01-28T13:38:42Z","pushed_at":"2016-01-28T13:45:18Z","git_url":"git://github.com/oliverprater/rspotify.git","ssh_url":"git@github.com:oliverprater/rspotify.git","clone_url":"https://github.com/oliverprater/rspotify.git","svn_url":"https://github.com/oliverprater/rspotify","homepage":null,"size":790,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"guilhermesad:master","ref":"master","sha":"07811aedc8ebb888dab319b9cc38c9dcedcc4616","user":{"login":"guilhermesad","id":1436748,"avatar_url":"https://avatars.githubusercontent.com/u/1436748?v=3","gravatar_id":"","url":"https://api.github.com/users/guilhermesad","html_url":"https://github.com/guilhermesad","followers_url":"https://api.github.com/users/guilhermesad/followers","following_url":"https://api.github.com/users/guilhermesad/following{/other_user}","gists_url":"https://api.github.com/users/guilhermesad/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermesad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermesad/subscriptions","organizations_url":"https://api.github.com/users/guilhermesad/orgs","repos_url":"https://api.github.com/users/guilhermesad/repos","events_url":"https://api.github.com/users/guilhermesad/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermesad/received_events","type":"User","site_admin":false},"repo":{"id":20988230,"name":"rspotify","full_name":"guilhermesad/rspotify","owner":{"login":"guilhermesad","id":1436748,"avatar_url":"https://avatars.githubusercontent.com/u/1436748?v=3","gravatar_id":"","url":"https://api.github.com/users/guilhermesad","html_url":"https://github.com/guilhermesad","followers_url":"https://api.github.com/users/guilhermesad/followers","following_url":"https://api.github.com/users/guilhermesad/following{/other_user}","gists_url":"https://api.github.com/users/guilhermesad/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermesad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermesad/subscriptions","organizations_url":"https://api.github.com/users/guilhermesad/orgs","repos_url":"https://api.github.com/users/guilhermesad/repos","events_url":"https://api.github.com/users/guilhermesad/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermesad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guilhermesad/rspotify","description":"A ruby wrapper for the Spotify Web API","fork":false,"url":"https://api.github.com/repos/guilhermesad/rspotify","forks_url":"https://api.github.com/repos/guilhermesad/rspotify/forks","keys_url":"https://api.github.com/repos/guilhermesad/rspotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guilhermesad/rspotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guilhermesad/rspotify/teams","hooks_url":"https://api.github.com/repos/guilhermesad/rspotify/hooks","issue_events_url":"https://api.github.com/repos/guilhermesad/rspotify/issues/events{/number}","events_url":"https://api.github.com/repos/guilhermesad/rspotify/events","assignees_url":"https://api.github.com/repos/guilhermesad/rspotify/assignees{/user}","branches_url":"https://api.github.com/repos/guilhermesad/rspotify/branches{/branch}","tags_url":"https://api.github.com/repos/guilhermesad/rspotify/tags","blobs_url":"https://api.github.com/repos/guilhermesad/rspotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guilhermesad/rspotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guilhermesad/rspotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/guilhermesad/rspotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guilhermesad/rspotify/statuses/{sha}","languages_url":"https://api.github.com/repos/guilhermesad/rspotify/languages","stargazers_url":"https://api.github.com/repos/guilhermesad/rspotify/stargazers","contributors_url":"https://api.github.com/repos/guilhermesad/rspotify/contributors","subscribers_url":"https://api.github.com/repos/guilhermesad/rspotify/subscribers","subscription_url":"https://api.github.com/repos/guilhermesad/rspotify/subscription","commits_url":"https://api.github.com/repos/guilhermesad/rspotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/guilhermesad/rspotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/guilhermesad/rspotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/guilhermesad/rspotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/guilhermesad/rspotify/contents/{+path}","compare_url":"https://api.github.com/repos/guilhermesad/rspotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guilhermesad/rspotify/merges","archive_url":"https://api.github.com/repos/guilhermesad/rspotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guilhermesad/rspotify/downloads","issues_url":"https://api.github.com/repos/guilhermesad/rspotify/issues{/number}","pulls_url":"https://api.github.com/repos/guilhermesad/rspotify/pulls{/number}","milestones_url":"https://api.github.com/repos/guilhermesad/rspotify/milestones{/number}","notifications_url":"https://api.github.com/repos/guilhermesad/rspotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guilhermesad/rspotify/labels{/name}","releases_url":"https://api.github.com/repos/guilhermesad/rspotify/releases{/id}","deployments_url":"https://api.github.com/repos/guilhermesad/rspotify/deployments","created_at":"2014-06-19T04:57:40Z","updated_at":"2016-01-24T05:12:08Z","pushed_at":"2016-01-31T19:18:19Z","git_url":"git://github.com/guilhermesad/rspotify.git","ssh_url":"git@github.com:guilhermesad/rspotify.git","clone_url":"https://github.com/guilhermesad/rspotify.git","svn_url":"https://github.com/guilhermesad/rspotify","homepage":null,"size":893,"stargazers_count":170,"watchers_count":170,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":5,"forks":57,"open_issues":5,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guilhermesad/rspotify/pulls/76"},"html":{"href":"https://github.com/guilhermesad/rspotify/pull/76"},"issue":{"href":"https://api.github.com/repos/guilhermesad/rspotify/issues/76"},"comments":{"href":"https://api.github.com/repos/guilhermesad/rspotify/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/guilhermesad/rspotify/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/guilhermesad/rspotify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guilhermesad/rspotify/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/guilhermesad/rspotify/statuses/b25b7f83305b95fe4bd985bf7d4a445f80ff32e0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"guilhermesad","id":1436748,"avatar_url":"https://avatars.githubusercontent.com/u/1436748?v=3","gravatar_id":"","url":"https://api.github.com/users/guilhermesad","html_url":"https://github.com/guilhermesad","followers_url":"https://api.github.com/users/guilhermesad/followers","following_url":"https://api.github.com/users/guilhermesad/following{/other_user}","gists_url":"https://api.github.com/users/guilhermesad/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermesad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermesad/subscriptions","organizations_url":"https://api.github.com/users/guilhermesad/orgs","repos_url":"https://api.github.com/users/guilhermesad/repos","events_url":"https://api.github.com/users/guilhermesad/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermesad/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}