{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/91713806","pull_request_review_id":12223419,"id":91713806,"diff_hunk":"@@ -51,74 +52,79 @@ def _writeKS(ksdata):\n         f.write(str(ksdata))\n \n def doConfiguration(storage, payload, ksdata, instClass):\n-    willWriteNetwork = not flags.flags.imageInstall and not flags.flags.dirInstall\n-    willRunRealmd = ksdata.realm.discovered\n-\n-    # configure base, create users, configure addons, initramfs, post-install\n-    step_count = 5\n-\n-    # network, maybe\n-    if willWriteNetwork:\n-        step_count += 1\n-\n-    # if a realm was discovered,\n-    # increment the counter as the\n-    # real joining step will be executed\n-    if willRunRealmd:\n-        step_count += 1\n-\n-    progress_init(step_count)\n-\n-    # Now run the execute methods of ksdata that require an installed system\n-    # to be present first.\n-    with progress_report(N_(\"Configuring installed system\")):\n-        ksdata.authconfig.execute(storage, ksdata, instClass)\n-        ksdata.selinux.execute(storage, ksdata, instClass)\n-        ksdata.firstboot.execute(storage, ksdata, instClass)\n-        ksdata.services.execute(storage, ksdata, instClass)\n-        ksdata.keyboard.execute(storage, ksdata, instClass)\n-        ksdata.timezone.execute(storage, ksdata, instClass)\n-        ksdata.lang.execute(storage, ksdata, instClass)\n-        ksdata.firewall.execute(storage, ksdata, instClass)\n-        ksdata.xconfig.execute(storage, ksdata, instClass)\n-        ksdata.skipx.execute(storage, ksdata, instClass)\n-\n-    if willWriteNetwork:\n-        with progress_report(N_(\"Writing network configuration\")):\n-            ksdata.network.execute(storage, ksdata, instClass)\n-\n-    # Creating users and groups requires some pre-configuration.\n-    with progress_report(N_(\"Creating users\")):\n-        u = Users()\n-        ksdata.rootpw.execute(storage, ksdata, instClass, u)\n-        ksdata.group.execute(storage, ksdata, instClass, u)\n-        ksdata.user.execute(storage, ksdata, instClass, u)\n-        ksdata.sshkey.execute(storage, ksdata, instClass, u)\n-\n-    with progress_report(N_(\"Configuring addons\")):\n-        ksdata.addons.execute(storage, ksdata, instClass, u, payload)\n-\n-    with progress_report(N_(\"Generating initramfs\")):\n-        payload.recreateInitrds()\n+    \"\"\"Configure the installed system.\"\"\"\n+\n+    configuration_queue = TaskQueue(\"Configuration queue\")\n+    # connect progress reporting\n+    configuration_queue.queue_started.connect(lambda x: progress_message(x.status_message))\n+    configuration_queue.queue_completed.connect(lambda x: progress_step(\"%s -- DONE\" % x.status_message))\n+\n+    # schedule the execute methods of ksdata that require an installed system to be present\n+    os_config = TaskQueue(\"Installed system configuration\", N_(\"Configuring installed system\"))\n+    os_config.append(Task(\"Configure authconfig\", lambda: ksdata.authconfig.execute(storage, ksdata, instClass)))","path":"pyanaconda/install.py","position":79,"original_position":79,"commit_id":"bf2dfbf1d175ff73ed554925a5ec9f11d50cd77e","original_commit_id":"bf2dfbf1d175ff73ed554925a5ec9f11d50cd77e","user":{"login":"vpodzime","id":1044278,"avatar_url":"https://avatars.githubusercontent.com/u/1044278?v=3","gravatar_id":"","url":"https://api.github.com/users/vpodzime","html_url":"https://github.com/vpodzime","followers_url":"https://api.github.com/users/vpodzime/followers","following_url":"https://api.github.com/users/vpodzime/following{/other_user}","gists_url":"https://api.github.com/users/vpodzime/gists{/gist_id}","starred_url":"https://api.github.com/users/vpodzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpodzime/subscriptions","organizations_url":"https://api.github.com/users/vpodzime/orgs","repos_url":"https://api.github.com/users/vpodzime/repos","events_url":"https://api.github.com/users/vpodzime/events{/privacy}","received_events_url":"https://api.github.com/users/vpodzime/received_events","type":"User","site_admin":false},"body":"These ``lambda``s look really weird. Wouldn't it be better to pass the function/method and its attributes as separate things?","created_at":"2016-12-09T13:18:12Z","updated_at":"2016-12-09T13:20:03Z","html_url":"https://github.com/rhinstaller/anaconda/pull/898#discussion_r91713806","pull_request_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/91713806"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/898#discussion_r91713806"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898"}}},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898","id":96719508,"html_url":"https://github.com/rhinstaller/anaconda/pull/898","diff_url":"https://github.com/rhinstaller/anaconda/pull/898.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/898.patch","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/898","number":898,"state":"open","locked":false,"title":"Structured installation tasks","user":{"login":"M4rtinK","id":829558,"avatar_url":"https://avatars.githubusercontent.com/u/829558?v=3","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"body":"The first two commits add structured installation task classes and the Signal class they use.\r\nThe third commit the installation phase to use the structured installation task classes.","created_at":"2016-12-06T13:00:30Z","updated_at":"2016-12-09T13:20:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f1dc70013d0578155f1ac377e3ecc0ae46bd6fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/898/comments","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/bf2dfbf1d175ff73ed554925a5ec9f11d50cd77e","head":{"label":"M4rtinK:master-structured_installation_tasks","ref":"master-structured_installation_tasks","sha":"bf2dfbf1d175ff73ed554925a5ec9f11d50cd77e","user":{"login":"M4rtinK","id":829558,"avatar_url":"https://avatars.githubusercontent.com/u/829558?v=3","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"repo":{"id":30928257,"name":"anaconda","full_name":"M4rtinK/anaconda","owner":{"login":"M4rtinK","id":829558,"avatar_url":"https://avatars.githubusercontent.com/u/829558?v=3","gravatar_id":"","url":"https://api.github.com/users/M4rtinK","html_url":"https://github.com/M4rtinK","followers_url":"https://api.github.com/users/M4rtinK/followers","following_url":"https://api.github.com/users/M4rtinK/following{/other_user}","gists_url":"https://api.github.com/users/M4rtinK/gists{/gist_id}","starred_url":"https://api.github.com/users/M4rtinK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M4rtinK/subscriptions","organizations_url":"https://api.github.com/users/M4rtinK/orgs","repos_url":"https://api.github.com/users/M4rtinK/repos","events_url":"https://api.github.com/users/M4rtinK/events{/privacy}","received_events_url":"https://api.github.com/users/M4rtinK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/M4rtinK/anaconda","description":"Graphical system installer","fork":true,"url":"https://api.github.com/repos/M4rtinK/anaconda","forks_url":"https://api.github.com/repos/M4rtinK/anaconda/forks","keys_url":"https://api.github.com/repos/M4rtinK/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/M4rtinK/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/M4rtinK/anaconda/teams","hooks_url":"https://api.github.com/repos/M4rtinK/anaconda/hooks","issue_events_url":"https://api.github.com/repos/M4rtinK/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/M4rtinK/anaconda/events","assignees_url":"https://api.github.com/repos/M4rtinK/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/M4rtinK/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/M4rtinK/anaconda/tags","blobs_url":"https://api.github.com/repos/M4rtinK/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/M4rtinK/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/M4rtinK/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/M4rtinK/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/M4rtinK/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/M4rtinK/anaconda/languages","stargazers_url":"https://api.github.com/repos/M4rtinK/anaconda/stargazers","contributors_url":"https://api.github.com/repos/M4rtinK/anaconda/contributors","subscribers_url":"https://api.github.com/repos/M4rtinK/anaconda/subscribers","subscription_url":"https://api.github.com/repos/M4rtinK/anaconda/subscription","commits_url":"https://api.github.com/repos/M4rtinK/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/M4rtinK/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/M4rtinK/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/M4rtinK/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/M4rtinK/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/M4rtinK/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/M4rtinK/anaconda/merges","archive_url":"https://api.github.com/repos/M4rtinK/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/M4rtinK/anaconda/downloads","issues_url":"https://api.github.com/repos/M4rtinK/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/M4rtinK/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/M4rtinK/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/M4rtinK/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/M4rtinK/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/M4rtinK/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/M4rtinK/anaconda/deployments","created_at":"2015-02-17T17:27:17Z","updated_at":"2015-02-17T17:27:20Z","pushed_at":"2016-12-07T12:37:32Z","git_url":"git://github.com/M4rtinK/anaconda.git","ssh_url":"git@github.com:M4rtinK/anaconda.git","clone_url":"https://github.com/M4rtinK/anaconda.git","svn_url":"https://github.com/M4rtinK/anaconda","homepage":null,"size":134871,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:master","ref":"master","sha":"f53199ae7e774dd8449edf696aeb2fe0a479ebae","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":30210846,"name":"anaconda","full_name":"rhinstaller/anaconda","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/anaconda","description":"Graphical system installer","fork":false,"url":"https://api.github.com/repos/rhinstaller/anaconda","forks_url":"https://api.github.com/repos/rhinstaller/anaconda/forks","keys_url":"https://api.github.com/repos/rhinstaller/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/anaconda/teams","hooks_url":"https://api.github.com/repos/rhinstaller/anaconda/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/anaconda/events","assignees_url":"https://api.github.com/repos/rhinstaller/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/anaconda/tags","blobs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/anaconda/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/anaconda/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/anaconda/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/anaconda/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/anaconda/subscription","commits_url":"https://api.github.com/repos/rhinstaller/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/anaconda/merges","archive_url":"https://api.github.com/repos/rhinstaller/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/anaconda/downloads","issues_url":"https://api.github.com/repos/rhinstaller/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/rhinstaller/anaconda/deployments","created_at":"2015-02-02T21:56:45Z","updated_at":"2016-12-04T23:24:53Z","pushed_at":"2016-12-08T15:19:52Z","git_url":"git://github.com/rhinstaller/anaconda.git","ssh_url":"git@github.com:rhinstaller/anaconda.git","clone_url":"https://github.com/rhinstaller/anaconda.git","svn_url":"https://github.com/rhinstaller/anaconda","homepage":null,"size":178799,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":29,"forks":86,"open_issues":29,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/898"},"issue":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/898"},"comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/anaconda/statuses/bf2dfbf1d175ff73ed554925a5ec9f11d50cd77e"}}}}
{"actor":{"display_login":"vpodzime"}}