{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/86690291","pull_request_review_id":7336107,"id":86690291,"diff_hunk":"@@ -59,6 +59,9 @@ def uri_from_name(conn_name):\n \n     settings.endGroup()\n \n+    if hasattr(authcfg, 'isNull') and authcfg.isNull():","path":"python/plugins/processing/tools/postgis.py","position":4,"original_position":4,"commit_id":"9cd39e79dd6bac0b79d3f2da9217777f60c70d66","original_commit_id":"8b8bc26ee00fb4049cfdae26af6fd80f8649529f","user":{"login":"rouault","id":1192433,"avatar_url":"https://avatars.githubusercontent.com/u/1192433?v=3","gravatar_id":"","url":"https://api.github.com/users/rouault","html_url":"https://github.com/rouault","followers_url":"https://api.github.com/users/rouault/followers","following_url":"https://api.github.com/users/rouault/following{/other_user}","gists_url":"https://api.github.com/users/rouault/gists{/gist_id}","starred_url":"https://api.github.com/users/rouault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouault/subscriptions","organizations_url":"https://api.github.com/users/rouault/orgs","repos_url":"https://api.github.com/users/rouault/repos","events_url":"https://api.github.com/users/rouault/events{/privacy}","received_events_url":"https://api.github.com/users/rouault/received_events","type":"User","site_admin":false},"body":"This part looks a bit awkward to me\r\nWhy is the hasattr(authcfg, 'isNull') needed ? Are there case where authcfg wouldn't be a QString ?\r\nAnd then why transforming a null QString into an empty QString ?\r\n Shouldn't rather setConnection() be made robust to support null strings in addition to empty strings.","created_at":"2016-11-06T16:39:28Z","updated_at":"2016-11-06T16:39:28Z","html_url":"https://github.com/qgis/QGIS/pull/3635#discussion_r86690291","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/3635","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/86690291"},"html":{"href":"https://github.com/qgis/QGIS/pull/3635#discussion_r86690291"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3635"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/3635","id":89969082,"html_url":"https://github.com/qgis/QGIS/pull/3635","diff_url":"https://github.com/qgis/QGIS/pull/3635.diff","patch_url":"https://github.com/qgis/QGIS/pull/3635.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/3635","number":3635,"state":"open","locked":false,"title":"[processing][db_manager] Fix connection to postgis","user":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"body":"Fix some postgis connection errors, probably due to Python3.\n","created_at":"2016-10-19T09:10:57Z","updated_at":"2016-11-06T16:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcf975e1aafd8b68c6ce44e619ef968c66a31dd8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/3635/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/3635/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/3635/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/9cd39e79dd6bac0b79d3f2da9217777f60c70d66","head":{"label":"arnaud-morvan:processing_postgis_connect","ref":"processing_postgis_connect","sha":"9cd39e79dd6bac0b79d3f2da9217777f60c70d66","user":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"repo":{"id":15884637,"name":"QGIS","full_name":"arnaud-morvan/QGIS","owner":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnaud-morvan/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/arnaud-morvan/QGIS","forks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/forks","keys_url":"https://api.github.com/repos/arnaud-morvan/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnaud-morvan/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnaud-morvan/QGIS/teams","hooks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/hooks","issue_events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/events","assignees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/arnaud-morvan/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/tags","blobs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnaud-morvan/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/arnaud-morvan/QGIS/languages","stargazers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/stargazers","contributors_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contributors","subscribers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscribers","subscription_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscription","commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/arnaud-morvan/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnaud-morvan/QGIS/merges","archive_url":"https://api.github.com/repos/arnaud-morvan/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnaud-morvan/QGIS/downloads","issues_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/arnaud-morvan/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/arnaud-morvan/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/arnaud-morvan/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnaud-morvan/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/arnaud-morvan/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/deployments","created_at":"2014-01-13T22:47:33Z","updated_at":"2016-09-02T18:51:23Z","pushed_at":"2016-11-06T15:19:54Z","git_url":"git://github.com/arnaud-morvan/QGIS.git","ssh_url":"git@github.com:arnaud-morvan/QGIS.git","clone_url":"https://github.com/arnaud-morvan/QGIS.git","svn_url":"https://github.com/arnaud-morvan/QGIS","homepage":"http://qgis.org","size":1132585,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"e426dbc86b37d22fe55eea788e28688207707f96","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2016-11-06T02:17:59Z","pushed_at":"2016-11-06T14:27:37Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1287323,"stargazers_count":1152,"watchers_count":1152,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":934,"mirror_url":null,"open_issues_count":75,"forks":934,"open_issues":75,"watchers":1152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3635"},"html":{"href":"https://github.com/qgis/QGIS/pull/3635"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3635"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3635/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3635/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3635/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/9cd39e79dd6bac0b79d3f2da9217777f60c70d66"}}}}
{"actor":{"display_login":"rouault"}}