{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/61397763","id":61397763,"diff_hunk":"@@ -196,9 +195,4 @@ Datum s3_import(PG_FUNCTION_ARGS) {\n  */\n Datum s3_export(PG_FUNCTION_ARGS) { PG_RETURN_INT32(0); }\n \n-Datum s3_validate_urls(PG_FUNCTION_ARGS) {\n-    int nurls;\n-    int i;\n-    ValidatorDirection direction;\n-    PG_RETURN_VOID();\n-}\n+Datum s3_validate_urls(PG_FUNCTION_ARGS) { PG_RETURN_VOID(); }","path":"gpAux/extensions/gps3ext/src/gps3ext.cpp","position":18,"original_position":18,"commit_id":"4ca7d78befad799f388af4bc8ba94c15b0a3edb6","original_commit_id":"7d85ca26a709ecd180b03ea2fadab29f47297642","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"body":"This function doesn't seem particularly useful, isn't it better to remove it until it's been implemented?","created_at":"2016-04-28T09:25:34Z","updated_at":"2016-04-28T09:25:34Z","html_url":"https://github.com/greenplum-db/gpdb/pull/681#discussion_r61397763","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/61397763"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/681#discussion_r61397763"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681","id":68182751,"html_url":"https://github.com/greenplum-db/gpdb/pull/681","diff_url":"https://github.com/greenplum-db/gpdb/pull/681.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/681.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/681","number":681,"state":"open","locked":false,"title":"s3ext: optimization and small amends","user":{"login":"adam8157","id":153160,"avatar_url":"https://avatars.githubusercontent.com/u/153160?v=3","gravatar_id":"","url":"https://api.github.com/users/adam8157","html_url":"https://github.com/adam8157","followers_url":"https://api.github.com/users/adam8157/followers","following_url":"https://api.github.com/users/adam8157/following{/other_user}","gists_url":"https://api.github.com/users/adam8157/gists{/gist_id}","starred_url":"https://api.github.com/users/adam8157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam8157/subscriptions","organizations_url":"https://api.github.com/users/adam8157/orgs","repos_url":"https://api.github.com/users/adam8157/repos","events_url":"https://api.github.com/users/adam8157/events{/privacy}","received_events_url":"https://api.github.com/users/adam8157/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-28T08:35:21Z","updated_at":"2016-04-28T09:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d935409ff94cded6dda9be654d5bdbec973190d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/681/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/4ca7d78befad799f388af4bc8ba94c15b0a3edb6","head":{"label":"adam8157:optimization","ref":"optimization","sha":"4ca7d78befad799f388af4bc8ba94c15b0a3edb6","user":{"login":"adam8157","id":153160,"avatar_url":"https://avatars.githubusercontent.com/u/153160?v=3","gravatar_id":"","url":"https://api.github.com/users/adam8157","html_url":"https://github.com/adam8157","followers_url":"https://api.github.com/users/adam8157/followers","following_url":"https://api.github.com/users/adam8157/following{/other_user}","gists_url":"https://api.github.com/users/adam8157/gists{/gist_id}","starred_url":"https://api.github.com/users/adam8157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam8157/subscriptions","organizations_url":"https://api.github.com/users/adam8157/orgs","repos_url":"https://api.github.com/users/adam8157/repos","events_url":"https://api.github.com/users/adam8157/events{/privacy}","received_events_url":"https://api.github.com/users/adam8157/received_events","type":"User","site_admin":false},"repo":{"id":52776218,"name":"gpdb","full_name":"adam8157/gpdb","owner":{"login":"adam8157","id":153160,"avatar_url":"https://avatars.githubusercontent.com/u/153160?v=3","gravatar_id":"","url":"https://api.github.com/users/adam8157","html_url":"https://github.com/adam8157","followers_url":"https://api.github.com/users/adam8157/followers","following_url":"https://api.github.com/users/adam8157/following{/other_user}","gists_url":"https://api.github.com/users/adam8157/gists{/gist_id}","starred_url":"https://api.github.com/users/adam8157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam8157/subscriptions","organizations_url":"https://api.github.com/users/adam8157/orgs","repos_url":"https://api.github.com/users/adam8157/repos","events_url":"https://api.github.com/users/adam8157/events{/privacy}","received_events_url":"https://api.github.com/users/adam8157/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam8157/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/adam8157/gpdb","forks_url":"https://api.github.com/repos/adam8157/gpdb/forks","keys_url":"https://api.github.com/repos/adam8157/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam8157/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam8157/gpdb/teams","hooks_url":"https://api.github.com/repos/adam8157/gpdb/hooks","issue_events_url":"https://api.github.com/repos/adam8157/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/adam8157/gpdb/events","assignees_url":"https://api.github.com/repos/adam8157/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/adam8157/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/adam8157/gpdb/tags","blobs_url":"https://api.github.com/repos/adam8157/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam8157/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam8157/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam8157/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam8157/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/adam8157/gpdb/languages","stargazers_url":"https://api.github.com/repos/adam8157/gpdb/stargazers","contributors_url":"https://api.github.com/repos/adam8157/gpdb/contributors","subscribers_url":"https://api.github.com/repos/adam8157/gpdb/subscribers","subscription_url":"https://api.github.com/repos/adam8157/gpdb/subscription","commits_url":"https://api.github.com/repos/adam8157/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam8157/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam8157/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam8157/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/adam8157/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/adam8157/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam8157/gpdb/merges","archive_url":"https://api.github.com/repos/adam8157/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam8157/gpdb/downloads","issues_url":"https://api.github.com/repos/adam8157/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/adam8157/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/adam8157/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/adam8157/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam8157/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/adam8157/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/adam8157/gpdb/deployments","created_at":"2016-02-29T08:35:15Z","updated_at":"2016-02-29T08:35:46Z","pushed_at":"2016-04-28T08:32:00Z","git_url":"git://github.com/adam8157/gpdb.git","ssh_url":"git@github.com:adam8157/gpdb.git","clone_url":"https://github.com/adam8157/gpdb.git","svn_url":"https://github.com/adam8157/gpdb","homepage":"http://greenplum.org","size":139478,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"57cc8456f892a1160f8819ccdaa491d3500c1f1d","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-04-28T08:57:01Z","pushed_at":"2016-04-28T08:35:22Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":151946,"stargazers_count":1415,"watchers_count":1415,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":370,"mirror_url":null,"open_issues_count":85,"forks":370,"open_issues":85,"watchers":1415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/681"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/681"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/4ca7d78befad799f388af4bc8ba94c15b0a3edb6"}}}}