{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/702","repository_url":"https://api.github.com/repos/wikimedia/wikipedia-ios","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/702/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/702/comments","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/702/events","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/702","id":156128705,"number":702,"title":"Save the section id of the \"continue reading\" article.","user":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-22T00:45:52Z","updated_at":"2016-05-28T03:00:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/702","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/702","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/702.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/702.patch"},"body":"@coreyfloyd \r\nWith this PR the wmf_openArticleTitle will have its \"fragment\" set to whatever the WebViewController's currently onscreen section was. This fragment can then be used later for things like calling WebViewController's \"scrollToFragment:\" method. The web view controller already scrolls to a fragment if one is present in an MWKTitle when an article is opened iirc.\r\n\r\nNote: **MWKTitle's *fragment* == MWKSection's *anchor* == that section's HTML div *id*.** \r\n(We may want to rename one of the first two, probably *anchor* should be changed to *fragment*, in the future. I believe *fragment* is standard url terminology and that *anchor* comes from *mobileview* api naming... iirc.)\r\n\r\nThis approach moves the \"saving\" of the \"continue reading\" title to the WebViewController. \r\n\r\nThe following assumptions are made:\r\n- a web view controller probably only scrolls if it is currently onscreen\r\n- we need to record when the onscreen article's current section has changed, i.e. after scroll\r\n- the web view can be scrolled either by the user or the TOC"},"comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments/222286589","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/702#issuecomment-222286589","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/702","id":222286589,"user":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"created_at":"2016-05-28T03:00:02Z","updated_at":"2016-05-28T03:00:02Z","body":"@coreyfloyd Fixed! :)"}}
{"actor":{"display_login":"montehurd"}}