{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11078","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11078/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11078/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11078/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11078","id":175556262,"number":11078,"title":"Update ::Button::OrchestrationTemplateEditRemove methods","user":{"login":"jzigmund","id":2270962,"avatar_url":"https://avatars.githubusercontent.com/u/2270962?v=3","gravatar_id":"","url":"https://api.github.com/users/jzigmund","html_url":"https://github.com/jzigmund","followers_url":"https://api.github.com/users/jzigmund/followers","following_url":"https://api.github.com/users/jzigmund/following{/other_user}","gists_url":"https://api.github.com/users/jzigmund/gists{/gist_id}","starred_url":"https://api.github.com/users/jzigmund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzigmund/subscriptions","organizations_url":"https://api.github.com/users/jzigmund/orgs","repos_url":"https://api.github.com/users/jzigmund/repos","events_url":"https://api.github.com/users/jzigmund/events{/privacy}","received_events_url":"https://api.github.com/users/jzigmund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"assignees":[{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-09-07T17:04:22Z","updated_at":"2016-09-13T15:47:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11078","html_url":"https://github.com/ManageIQ/manageiq/pull/11078","diff_url":"https://github.com/ManageIQ/manageiq/pull/11078.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11078.patch"},"body":"Purpose or Intent\r\n-----------------\r\nUpdated already defined button class, used in Services/Catalogs/listnav 'Orchestration Templates'.\r\n\r\n1st commit - Method ```calculate_properties``` in ```::Button::Basic``` class is calling the ```disabled?``` so let the setting of the enable flag there, just call ```disabled?``` defined in the class. Also remove the code from ```build_toolbar_disable_button``` in toolbar_builder.rb (that's the main goal of the refactoring).\r\n```if @view_context.x_active_tree == :ot_tree && @record``` is not needed as I found the buttons of the class generated in ```ot_tree``` only. ```@record``` is checked before the ```calculate_properties``` method call.\r\n\r\n2nd commit - role_allows? will be solved in https://github.com/ManageIQ/manageiq/pull/10942\r\n\r\nMarking the PR as WIP as it needs to have solved PR mentioned above.\r\n\r\nLinks\r\n-----\r\nParent issue: https://github.com/ManageIQ/manageiq/issues/6259"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/246726873","html_url":"https://github.com/ManageIQ/manageiq/pull/11078#issuecomment-246726873","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11078","id":246726873,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T15:47:21Z","updated_at":"2016-09-13T15:47:21Z","body":"<rubocop />Checked commits https://github.com/jzigmund/manageiq/compare/c2ea53f8b0ab946110eff4f74f550128f09f8bde~...070d601861642bd62e812c9dccd543480b6cad25 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n2 files checked, 0 offenses detected\nEverything looks good. :trophy:\n"}}
{"actor":{"display_login":"miq-bot"}}