{"action":"created","comment":{"url":"https://api.github.com/repos/Payum/Payum/pulls/comments/57122232","id":57122232,"diff_hunk":"@@ -39,7 +39,10 @@\n     \"require\": {\n         \"php\": \"^5.5.0|^7.0\",\n         \"payum/iso4217\": \"~1.0\",\n-        \"guzzlehttp/guzzle\": \"~6.0\",\n+        \"php-http/httplug\": \"^1.0\",","path":"composer.json","position":5,"original_position":5,"commit_id":"02d7172607f7a09bed9d2f38b413e66b2054e2b8","original_commit_id":"02d7172607f7a09bed9d2f38b413e66b2054e2b8","user":{"login":"makasim","id":143206,"avatar_url":"https://avatars.githubusercontent.com/u/143206?v=3","gravatar_id":"","url":"https://api.github.com/users/makasim","html_url":"https://github.com/makasim","followers_url":"https://api.github.com/users/makasim/followers","following_url":"https://api.github.com/users/makasim/following{/other_user}","gists_url":"https://api.github.com/users/makasim/gists{/gist_id}","starred_url":"https://api.github.com/users/makasim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makasim/subscriptions","organizations_url":"https://api.github.com/users/makasim/orgs","repos_url":"https://api.github.com/users/makasim/repos","events_url":"https://api.github.com/users/makasim/events{/privacy}","received_events_url":"https://api.github.com/users/makasim/received_events","type":"User","site_admin":false},"body":"let's keep it.","created_at":"2016-03-23T08:17:12Z","updated_at":"2016-03-23T08:17:12Z","html_url":"https://github.com/Payum/Payum/pull/505#discussion_r57122232","pull_request_url":"https://api.github.com/repos/Payum/Payum/pulls/505","_links":{"self":{"href":"https://api.github.com/repos/Payum/Payum/pulls/comments/57122232"},"html":{"href":"https://github.com/Payum/Payum/pull/505#discussion_r57122232"},"pull_request":{"href":"https://api.github.com/repos/Payum/Payum/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/Payum/Payum/pulls/505","id":63578479,"html_url":"https://github.com/Payum/Payum/pull/505","diff_url":"https://github.com/Payum/Payum/pull/505.diff","patch_url":"https://github.com/Payum/Payum/pull/505.patch","issue_url":"https://api.github.com/repos/Payum/Payum/issues/505","number":505,"state":"open","locked":false,"title":"[WIP] Using Httplug instead of Guzzle6","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"body":"This is PR will remove our hard coupled dependency on Guzzle6 and instead rely on an interface. This will make the Payum package more SOLID. With this PR we allow users that are stuck with using Guzzle5 to use Payum. \r\n\r\nThis PR introduce some small BC breaks. I've removed the function `HttpClientFactory::createGuzzle` and also the config parameter named `guzzle.client`.\r\n\r\nThis will fix #491\r\n\r\n### Usage\r\n\r\n```php\r\n/** @var Payum $payum */\r\n$payum = (new PayumBuilder())\r\n    ->addDefaultStorages()\r\n    ->addGateway('gatewayName', [\r\n        'factory' => 'aGateway'\r\n        'httplug.client' => new \\Http\\Adapter\\Guzzle6\\Client(),\r\n    ])\r\n    ->getPayum()\r\n;\r\n```\r\n\r\n### TODO\r\n* [x] Make code changes\r\n* [x] Deprecate existing classes tightly coupled to Guzzle\r\n* [ ] Add documentation\r\n#","created_at":"2016-03-21T15:07:08Z","updated_at":"2016-03-23T08:17:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e017db26f8b9ba7f3d1825f2e451b4d380a28472","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Payum/Payum/pulls/505/commits","review_comments_url":"https://api.github.com/repos/Payum/Payum/pulls/505/comments","review_comment_url":"https://api.github.com/repos/Payum/Payum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Payum/Payum/issues/505/comments","statuses_url":"https://api.github.com/repos/Payum/Payum/statuses/02d7172607f7a09bed9d2f38b413e66b2054e2b8","head":{"label":"Nyholm:httplug","ref":"httplug","sha":"02d7172607f7a09bed9d2f38b413e66b2054e2b8","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"repo":{"id":54398273,"name":"Payum","full_name":"Nyholm/Payum","owner":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nyholm/Payum","description":"PHP 5.5+ Payment processing library. It offers everything you need to work with payments. It fully abstracts the flow  and partly the data.","fork":true,"url":"https://api.github.com/repos/Nyholm/Payum","forks_url":"https://api.github.com/repos/Nyholm/Payum/forks","keys_url":"https://api.github.com/repos/Nyholm/Payum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nyholm/Payum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nyholm/Payum/teams","hooks_url":"https://api.github.com/repos/Nyholm/Payum/hooks","issue_events_url":"https://api.github.com/repos/Nyholm/Payum/issues/events{/number}","events_url":"https://api.github.com/repos/Nyholm/Payum/events","assignees_url":"https://api.github.com/repos/Nyholm/Payum/assignees{/user}","branches_url":"https://api.github.com/repos/Nyholm/Payum/branches{/branch}","tags_url":"https://api.github.com/repos/Nyholm/Payum/tags","blobs_url":"https://api.github.com/repos/Nyholm/Payum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nyholm/Payum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nyholm/Payum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nyholm/Payum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nyholm/Payum/statuses/{sha}","languages_url":"https://api.github.com/repos/Nyholm/Payum/languages","stargazers_url":"https://api.github.com/repos/Nyholm/Payum/stargazers","contributors_url":"https://api.github.com/repos/Nyholm/Payum/contributors","subscribers_url":"https://api.github.com/repos/Nyholm/Payum/subscribers","subscription_url":"https://api.github.com/repos/Nyholm/Payum/subscription","commits_url":"https://api.github.com/repos/Nyholm/Payum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nyholm/Payum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nyholm/Payum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nyholm/Payum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nyholm/Payum/contents/{+path}","compare_url":"https://api.github.com/repos/Nyholm/Payum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nyholm/Payum/merges","archive_url":"https://api.github.com/repos/Nyholm/Payum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nyholm/Payum/downloads","issues_url":"https://api.github.com/repos/Nyholm/Payum/issues{/number}","pulls_url":"https://api.github.com/repos/Nyholm/Payum/pulls{/number}","milestones_url":"https://api.github.com/repos/Nyholm/Payum/milestones{/number}","notifications_url":"https://api.github.com/repos/Nyholm/Payum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nyholm/Payum/labels{/name}","releases_url":"https://api.github.com/repos/Nyholm/Payum/releases{/id}","deployments_url":"https://api.github.com/repos/Nyholm/Payum/deployments","created_at":"2016-03-21T15:00:21Z","updated_at":"2016-03-21T15:00:23Z","pushed_at":"2016-03-22T18:47:02Z","git_url":"git://github.com/Nyholm/Payum.git","ssh_url":"git@github.com:Nyholm/Payum.git","clone_url":"https://github.com/Nyholm/Payum.git","svn_url":"https://github.com/Nyholm/Payum","homepage":"http://payum.org","size":4140,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Payum:master","ref":"master","sha":"6e00500a71ec95bb4a375948c955f27a4ab838cf","user":{"login":"Payum","id":2638697,"avatar_url":"https://avatars.githubusercontent.com/u/2638697?v=3","gravatar_id":"","url":"https://api.github.com/users/Payum","html_url":"https://github.com/Payum","followers_url":"https://api.github.com/users/Payum/followers","following_url":"https://api.github.com/users/Payum/following{/other_user}","gists_url":"https://api.github.com/users/Payum/gists{/gist_id}","starred_url":"https://api.github.com/users/Payum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Payum/subscriptions","organizations_url":"https://api.github.com/users/Payum/orgs","repos_url":"https://api.github.com/users/Payum/repos","events_url":"https://api.github.com/users/Payum/events{/privacy}","received_events_url":"https://api.github.com/users/Payum/received_events","type":"Organization","site_admin":false},"repo":{"id":6825542,"name":"Payum","full_name":"Payum/Payum","owner":{"login":"Payum","id":2638697,"avatar_url":"https://avatars.githubusercontent.com/u/2638697?v=3","gravatar_id":"","url":"https://api.github.com/users/Payum","html_url":"https://github.com/Payum","followers_url":"https://api.github.com/users/Payum/followers","following_url":"https://api.github.com/users/Payum/following{/other_user}","gists_url":"https://api.github.com/users/Payum/gists{/gist_id}","starred_url":"https://api.github.com/users/Payum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Payum/subscriptions","organizations_url":"https://api.github.com/users/Payum/orgs","repos_url":"https://api.github.com/users/Payum/repos","events_url":"https://api.github.com/users/Payum/events{/privacy}","received_events_url":"https://api.github.com/users/Payum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Payum/Payum","description":"PHP 5.5+ Payment processing library. It offers everything you need to work with payments. It fully abstracts the flow  and partly the data.","fork":false,"url":"https://api.github.com/repos/Payum/Payum","forks_url":"https://api.github.com/repos/Payum/Payum/forks","keys_url":"https://api.github.com/repos/Payum/Payum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Payum/Payum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Payum/Payum/teams","hooks_url":"https://api.github.com/repos/Payum/Payum/hooks","issue_events_url":"https://api.github.com/repos/Payum/Payum/issues/events{/number}","events_url":"https://api.github.com/repos/Payum/Payum/events","assignees_url":"https://api.github.com/repos/Payum/Payum/assignees{/user}","branches_url":"https://api.github.com/repos/Payum/Payum/branches{/branch}","tags_url":"https://api.github.com/repos/Payum/Payum/tags","blobs_url":"https://api.github.com/repos/Payum/Payum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Payum/Payum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Payum/Payum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Payum/Payum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Payum/Payum/statuses/{sha}","languages_url":"https://api.github.com/repos/Payum/Payum/languages","stargazers_url":"https://api.github.com/repos/Payum/Payum/stargazers","contributors_url":"https://api.github.com/repos/Payum/Payum/contributors","subscribers_url":"https://api.github.com/repos/Payum/Payum/subscribers","subscription_url":"https://api.github.com/repos/Payum/Payum/subscription","commits_url":"https://api.github.com/repos/Payum/Payum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Payum/Payum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Payum/Payum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Payum/Payum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Payum/Payum/contents/{+path}","compare_url":"https://api.github.com/repos/Payum/Payum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Payum/Payum/merges","archive_url":"https://api.github.com/repos/Payum/Payum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Payum/Payum/downloads","issues_url":"https://api.github.com/repos/Payum/Payum/issues{/number}","pulls_url":"https://api.github.com/repos/Payum/Payum/pulls{/number}","milestones_url":"https://api.github.com/repos/Payum/Payum/milestones{/number}","notifications_url":"https://api.github.com/repos/Payum/Payum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Payum/Payum/labels{/name}","releases_url":"https://api.github.com/repos/Payum/Payum/releases{/id}","deployments_url":"https://api.github.com/repos/Payum/Payum/deployments","created_at":"2012-11-23T10:06:16Z","updated_at":"2016-03-22T19:08:03Z","pushed_at":"2016-03-22T18:47:02Z","git_url":"git://github.com/Payum/Payum.git","ssh_url":"git@github.com:Payum/Payum.git","clone_url":"https://github.com/Payum/Payum.git","svn_url":"https://github.com/Payum/Payum","homepage":"http://payum.org","size":4315,"stargazers_count":638,"watchers_count":638,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":18,"forks":104,"open_issues":18,"watchers":638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Payum/Payum/pulls/505"},"html":{"href":"https://github.com/Payum/Payum/pull/505"},"issue":{"href":"https://api.github.com/repos/Payum/Payum/issues/505"},"comments":{"href":"https://api.github.com/repos/Payum/Payum/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/Payum/Payum/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/Payum/Payum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Payum/Payum/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/Payum/Payum/statuses/02d7172607f7a09bed9d2f38b413e66b2054e2b8"}}}}