{"action":"created","comment":{"url":"https://api.github.com/repos/briansmith/ring/pulls/comments/73795373","id":73795373,"diff_hunk":"@@ -151,7 +98,43 @@ rsa_pkcs1_padding!(RSA_PKCS1_SHA512, &digest::SHA512,\n                    &SHA512_PKCS1_DIGESTINFO_PREFIX,\n                    \"Signing using RSA with PKCS#1 1.5 padding and SHA-512.\");\n \n-macro_rules! rsa_pkcs1 {\n+rsa_pss_padding!(RSA_PSS_SHA1, &digest::SHA1,\n+                   \"Signing using RSA with PSS padding and SHA-1.\", 0);\n+rsa_pss_padding!(RSA_PSS_SHA256, &digest::SHA256,\n+                   \"Signing using RSA with PSS padding and SHA-256.\", 0);\n+rsa_pss_padding!(RSA_PSS_SHA384, &digest::SHA384,\n+                   \"Signing using RSA with PSS padding and SHA-384.\", 0);\n+rsa_pss_padding!(RSA_PSS_SHA512, &digest::SHA512,\n+                   \"Signing using RSA with PSS padding and SHA-512.\", 0);\n+\n+rsa_pss_padding!(RSA_PSS_SHA1_20, &digest::SHA1,\n+                   \"Signing using RSA with PSS padding, 20 byte salt, and SHA-1.\", 20);\n+rsa_pss_padding!(RSA_PSS_SHA256_20, &digest::SHA256,\n+                   \"Signing using RSA with PSS padding, 20 byte salt, and SHA-256.\", 20);","path":"src/rsa.rs","position":146,"original_position":146,"commit_id":"ec6e043bba170635191ca8c8848a77c34eda6092","original_commit_id":"ec6e043bba170635191ca8c8848a77c34eda6092","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"body":"You can drop the \", XXX byte salt, \" part. Instead, in the boilerplate for PSS, we can state that the salt length is equal to the digest length and the MGF digest is the same as the digest function used to hash the message.","created_at":"2016-08-07T03:55:43Z","updated_at":"2016-08-07T03:55:43Z","html_url":"https://github.com/briansmith/ring/pull/262#discussion_r73795373","pull_request_url":"https://api.github.com/repos/briansmith/ring/pulls/262","_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments/73795373"},"html":{"href":"https://github.com/briansmith/ring/pull/262#discussion_r73795373"},"pull_request":{"href":"https://api.github.com/repos/briansmith/ring/pulls/262"}}},"pull_request":{"url":"https://api.github.com/repos/briansmith/ring/pulls/262","id":79736348,"html_url":"https://github.com/briansmith/ring/pull/262","diff_url":"https://github.com/briansmith/ring/pull/262.diff","patch_url":"https://github.com/briansmith/ring/pull/262.patch","issue_url":"https://api.github.com/repos/briansmith/ring/issues/262","number":262,"state":"open","locked":false,"title":"Work in progress on PSS implementation.","user":{"login":"samscott89","id":13355482,"avatar_url":"https://avatars.githubusercontent.com/u/13355482?v=3","gravatar_id":"","url":"https://api.github.com/users/samscott89","html_url":"https://github.com/samscott89","followers_url":"https://api.github.com/users/samscott89/followers","following_url":"https://api.github.com/users/samscott89/following{/other_user}","gists_url":"https://api.github.com/users/samscott89/gists{/gist_id}","starred_url":"https://api.github.com/users/samscott89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samscott89/subscriptions","organizations_url":"https://api.github.com/users/samscott89/orgs","repos_url":"https://api.github.com/users/samscott89/repos","events_url":"https://api.github.com/users/samscott89/events{/privacy}","received_events_url":"https://api.github.com/users/samscott89/received_events","type":"User","site_admin":false},"body":"Steps taken so far:\r\n - Create separate module for padding.\r\n - Refactor existing PKCS padding to use this system.\r\n - Implement PSS padding (encoding and verification).\r\n - Add test cases for PSS signatures.\r\n\r\nThis is a bit rough at the moment. There are some fairly large changes made by this so I thought it would be best to put it out there for feedback before proceeding.\r\n\r\nRelevant issues: #115 and #213 ","created_at":"2016-08-02T13:37:32Z","updated_at":"2016-08-07T03:55:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c627734e1ef722a0bcc880d190745afeb49392dd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/briansmith/ring/pulls/262/commits","review_comments_url":"https://api.github.com/repos/briansmith/ring/pulls/262/comments","review_comment_url":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/briansmith/ring/issues/262/comments","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/ec6e043bba170635191ca8c8848a77c34eda6092","head":{"label":"samscott89:padding","ref":"padding","sha":"ec6e043bba170635191ca8c8848a77c34eda6092","user":{"login":"samscott89","id":13355482,"avatar_url":"https://avatars.githubusercontent.com/u/13355482?v=3","gravatar_id":"","url":"https://api.github.com/users/samscott89","html_url":"https://github.com/samscott89","followers_url":"https://api.github.com/users/samscott89/followers","following_url":"https://api.github.com/users/samscott89/following{/other_user}","gists_url":"https://api.github.com/users/samscott89/gists{/gist_id}","starred_url":"https://api.github.com/users/samscott89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samscott89/subscriptions","organizations_url":"https://api.github.com/users/samscott89/orgs","repos_url":"https://api.github.com/users/samscott89/repos","events_url":"https://api.github.com/users/samscott89/events{/privacy}","received_events_url":"https://api.github.com/users/samscott89/received_events","type":"User","site_admin":false},"repo":{"id":59747872,"name":"ring","full_name":"samscott89/ring","owner":{"login":"samscott89","id":13355482,"avatar_url":"https://avatars.githubusercontent.com/u/13355482?v=3","gravatar_id":"","url":"https://api.github.com/users/samscott89","html_url":"https://github.com/samscott89","followers_url":"https://api.github.com/users/samscott89/followers","following_url":"https://api.github.com/users/samscott89/following{/other_user}","gists_url":"https://api.github.com/users/samscott89/gists{/gist_id}","starred_url":"https://api.github.com/users/samscott89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samscott89/subscriptions","organizations_url":"https://api.github.com/users/samscott89/orgs","repos_url":"https://api.github.com/users/samscott89/repos","events_url":"https://api.github.com/users/samscott89/events{/privacy}","received_events_url":"https://api.github.com/users/samscott89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samscott89/ring","description":"Safe, fast, small crypto using Rust & BoringSSL's cryptography primitives.","fork":true,"url":"https://api.github.com/repos/samscott89/ring","forks_url":"https://api.github.com/repos/samscott89/ring/forks","keys_url":"https://api.github.com/repos/samscott89/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samscott89/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samscott89/ring/teams","hooks_url":"https://api.github.com/repos/samscott89/ring/hooks","issue_events_url":"https://api.github.com/repos/samscott89/ring/issues/events{/number}","events_url":"https://api.github.com/repos/samscott89/ring/events","assignees_url":"https://api.github.com/repos/samscott89/ring/assignees{/user}","branches_url":"https://api.github.com/repos/samscott89/ring/branches{/branch}","tags_url":"https://api.github.com/repos/samscott89/ring/tags","blobs_url":"https://api.github.com/repos/samscott89/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samscott89/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samscott89/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/samscott89/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samscott89/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/samscott89/ring/languages","stargazers_url":"https://api.github.com/repos/samscott89/ring/stargazers","contributors_url":"https://api.github.com/repos/samscott89/ring/contributors","subscribers_url":"https://api.github.com/repos/samscott89/ring/subscribers","subscription_url":"https://api.github.com/repos/samscott89/ring/subscription","commits_url":"https://api.github.com/repos/samscott89/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/samscott89/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/samscott89/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/samscott89/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/samscott89/ring/contents/{+path}","compare_url":"https://api.github.com/repos/samscott89/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samscott89/ring/merges","archive_url":"https://api.github.com/repos/samscott89/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samscott89/ring/downloads","issues_url":"https://api.github.com/repos/samscott89/ring/issues{/number}","pulls_url":"https://api.github.com/repos/samscott89/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/samscott89/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/samscott89/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samscott89/ring/labels{/name}","releases_url":"https://api.github.com/repos/samscott89/ring/releases{/id}","deployments_url":"https://api.github.com/repos/samscott89/ring/deployments","created_at":"2016-05-26T12:19:25Z","updated_at":"2016-05-26T12:19:27Z","pushed_at":"2016-08-02T13:34:01Z","git_url":"git://github.com/samscott89/ring.git","ssh_url":"git@github.com:samscott89/ring.git","clone_url":"https://github.com/samscott89/ring.git","svn_url":"https://github.com/samscott89/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":22826,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"briansmith:master","ref":"master","sha":"0ab853aeaf771f1d1969e20d23b414f38f667025","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"repo":{"id":39527318,"name":"ring","full_name":"briansmith/ring","owner":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briansmith/ring","description":"Safe, fast, small crypto using Rust & BoringSSL's cryptography primitives.","fork":false,"url":"https://api.github.com/repos/briansmith/ring","forks_url":"https://api.github.com/repos/briansmith/ring/forks","keys_url":"https://api.github.com/repos/briansmith/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansmith/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansmith/ring/teams","hooks_url":"https://api.github.com/repos/briansmith/ring/hooks","issue_events_url":"https://api.github.com/repos/briansmith/ring/issues/events{/number}","events_url":"https://api.github.com/repos/briansmith/ring/events","assignees_url":"https://api.github.com/repos/briansmith/ring/assignees{/user}","branches_url":"https://api.github.com/repos/briansmith/ring/branches{/branch}","tags_url":"https://api.github.com/repos/briansmith/ring/tags","blobs_url":"https://api.github.com/repos/briansmith/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansmith/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansmith/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansmith/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/briansmith/ring/languages","stargazers_url":"https://api.github.com/repos/briansmith/ring/stargazers","contributors_url":"https://api.github.com/repos/briansmith/ring/contributors","subscribers_url":"https://api.github.com/repos/briansmith/ring/subscribers","subscription_url":"https://api.github.com/repos/briansmith/ring/subscription","commits_url":"https://api.github.com/repos/briansmith/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansmith/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansmith/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansmith/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansmith/ring/contents/{+path}","compare_url":"https://api.github.com/repos/briansmith/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansmith/ring/merges","archive_url":"https://api.github.com/repos/briansmith/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansmith/ring/downloads","issues_url":"https://api.github.com/repos/briansmith/ring/issues{/number}","pulls_url":"https://api.github.com/repos/briansmith/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/briansmith/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/briansmith/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansmith/ring/labels{/name}","releases_url":"https://api.github.com/repos/briansmith/ring/releases{/id}","deployments_url":"https://api.github.com/repos/briansmith/ring/deployments","created_at":"2015-07-22T19:57:40Z","updated_at":"2016-08-07T03:48:08Z","pushed_at":"2016-08-06T17:56:02Z","git_url":"git://github.com/briansmith/ring.git","ssh_url":"git@github.com:briansmith/ring.git","clone_url":"https://github.com/briansmith/ring.git","svn_url":"https://github.com/briansmith/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":23691,"stargazers_count":228,"watchers_count":228,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":133,"forks":26,"open_issues":133,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/262"},"html":{"href":"https://github.com/briansmith/ring/pull/262"},"issue":{"href":"https://api.github.com/repos/briansmith/ring/issues/262"},"comments":{"href":"https://api.github.com/repos/briansmith/ring/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/briansmith/ring/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/briansmith/ring/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/briansmith/ring/statuses/ec6e043bba170635191ca8c8848a77c34eda6092"}}}}
{"actor":{"display_login":"briansmith"}}