{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/comments/68427970","id":68427970,"diff_hunk":"@@ -0,0 +1,41 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony CMF package.\n+ *\n+ * (c) 2011-2015 Symfony CMF\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Cmf\\Bundle\\CoreBundle\\Tests\\Functional\\DependencyInjection;\n+\n+use Symfony\\Component\\DependencyInjection\\ContainerBuilder;\n+use Symfony\\Cmf\\Bundle\\CoreBundle\\DependencyInjection\\CmfCoreExtension;\n+use Symfony\\Cmf\\Bundle\\CoreBundle\\PublishWorkflow\\AlwaysPublishedWorkflowChecker;\n+\n+class CmfCoreExtensionTest extends \\PHPUnit_Framework_TestCase\n+{\n+    private $container;\n+\n+    protected function setUp()\n+    {\n+        $this->container = new ContainerBuilder();\n+        $this->container->registerExtension(new CmfCoreExtension());\n+        $this->container->setParameter('kernel.bundles', array('CmfCoreBundle' => true));\n+    }\n+\n+    public function testPublishWorkflowDisabled()\n+    {\n+        $this->container->loadFromExtension('cmf_core', [\n+            'publish_workflow' => false,\n+        ]);\n+\n+        $this->container->setAlias('app.workflow_checker', 'cmf_core.publish_workflow.checker');","path":"Tests/Functional/DependencyInjection/CmfCoreExtensionTest.php","position":35,"original_position":35,"commit_id":"34e5b9f3e736702bf9133aa7ecdd640f5949ab27","original_commit_id":"34e5b9f3e736702bf9133aa7ecdd640f5949ab27","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"using aliasing, because I want to make these services private in CMF 2.0.","created_at":"2016-06-24T17:00:45Z","updated_at":"2016-06-24T17:00:45Z","html_url":"https://github.com/symfony-cmf/core-bundle/pull/200#discussion_r68427970","pull_request_url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/comments/68427970"},"html":{"href":"https://github.com/symfony-cmf/core-bundle/pull/200#discussion_r68427970"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200","id":75143283,"html_url":"https://github.com/symfony-cmf/core-bundle/pull/200","diff_url":"https://github.com/symfony-cmf/core-bundle/pull/200.diff","patch_url":"https://github.com/symfony-cmf/core-bundle/pull/200.patch","issue_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/200","number":200,"state":"open","locked":false,"title":"Fix wrong publish workflow class when disabled","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"My automation tool got confused, because the class name was overridden. This fixes the little introduced bug.\r\n\r\nAlso added a test to prevent this from happening again.","created_at":"2016-06-24T16:59:31Z","updated_at":"2016-06-24T17:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a372ac6f0dd4b36a570588ce4820f5a6c55677af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/200/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/core-bundle/statuses/34e5b9f3e736702bf9133aa7ecdd640f5949ab27","head":{"label":"symfony-cmf:fix-pwc-disabled","ref":"fix-pwc-disabled","sha":"34e5b9f3e736702bf9133aa7ecdd640f5949ab27","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":1443095,"name":"core-bundle","full_name":"symfony-cmf/core-bundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/core-bundle","description":"Provides some basic helpers for rendering content documents","fork":false,"url":"https://api.github.com/repos/symfony-cmf/core-bundle","forks_url":"https://api.github.com/repos/symfony-cmf/core-bundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/core-bundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/core-bundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/core-bundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/core-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/core-bundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/core-bundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/core-bundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/core-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/core-bundle/deployments","created_at":"2011-03-05T12:49:34Z","updated_at":"2016-04-07T08:03:25Z","pushed_at":"2016-06-24T17:00:01Z","git_url":"git://github.com/symfony-cmf/core-bundle.git","ssh_url":"git@github.com:symfony-cmf/core-bundle.git","clone_url":"https://github.com/symfony-cmf/core-bundle.git","svn_url":"https://github.com/symfony-cmf/core-bundle","homepage":"http://cmf.symfony-project.org/","size":728,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":15,"forks":25,"open_issues":15,"watchers":17,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"6ea52b4afe4ec9dc38f3d01c8af85ab6d2a6e1b2","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":1443095,"name":"core-bundle","full_name":"symfony-cmf/core-bundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/core-bundle","description":"Provides some basic helpers for rendering content documents","fork":false,"url":"https://api.github.com/repos/symfony-cmf/core-bundle","forks_url":"https://api.github.com/repos/symfony-cmf/core-bundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/core-bundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/core-bundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/core-bundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/core-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/core-bundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/core-bundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/core-bundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/core-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/core-bundle/deployments","created_at":"2011-03-05T12:49:34Z","updated_at":"2016-04-07T08:03:25Z","pushed_at":"2016-06-24T17:00:01Z","git_url":"git://github.com/symfony-cmf/core-bundle.git","ssh_url":"git@github.com:symfony-cmf/core-bundle.git","clone_url":"https://github.com/symfony-cmf/core-bundle.git","svn_url":"https://github.com/symfony-cmf/core-bundle","homepage":"http://cmf.symfony-project.org/","size":728,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":15,"forks":25,"open_issues":15,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200"},"html":{"href":"https://github.com/symfony-cmf/core-bundle/pull/200"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/200"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/core-bundle/statuses/34e5b9f3e736702bf9133aa7ecdd640f5949ab27"}}}}
{"actor":{"display_login":"WouterJ"}}