{"action":"created","issue":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1225","repository_url":"https://api.github.com/repos/SUSE-Cloud/automation","labels_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1225/labels{/name}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1225/comments","events_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1225/events","html_url":"https://github.com/SUSE-Cloud/automation/pull/1225","id":176073564,"number":1225,"title":"[UNTESTED] fix selection of cinder-volume node","user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SUSE-Cloud/automation/labels/do%20not%20merge%20yet","name":"do not merge yet","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"assignees":[{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2016-09-09T18:14:35Z","updated_at":"2016-09-20T14:47:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1225","html_url":"https://github.com/SUSE-Cloud/automation/pull/1225","diff_url":"https://github.com/SUSE-Cloud/automation/pull/1225.diff","patch_url":"https://github.com/SUSE-Cloud/automation/pull/1225.patch"},"body":"PR #1195 introduced breakage in Jenkins openstack-mkcloud, because it can cause values of `cinder_volume` such as `\"d52-54-77-77-77-03.ve1.cloud.suse.de\\nd52-54-77-77-77-04.ve1.cloud.suse.de\"`, i.e. multiple hostnames delimited by `\"\\n\"` rather than comma-separated like is correctly done with the other barclamps above.\r\n\r\nSo instead we assign to an array breaking on whitespace, so that the first host is correctly picked.\r\n\r\nHere's an example failure:\r\n\r\n    W, [2016-09-08T20:36:56.103076 #8898:0x00000005f37410]  WARN -- Could not recover Chef Crowbar Node on load d52-54-77-77-77-03.ve1.cloud.suse.de\r\n    d52-54-77-77-77-04.ve1.cloud.suse.de: #<URI::InvalidURIError: bad URI(is not URI?): http://localhost:4000/nodes/d52-54-77-77-77-03.ve1.cloud.suse.de\r\n    d52-54-77-77-77-04.ve1.cloud.suse.de>\r\n    I, [2016-09-08T20:36:56.103681 #8898:0x00000005f37410]  INFO -- Completed 500 Internal Server Error in 85ms (ActiveRecord: 8.0ms)\r\n    F, [2016-09-08T20:36:56.104726 #8898:0x00000005f37410] FATAL --\r\n    NoMethodError (undefined method `[]' for nil:NilClass):\r\n      app/models/service_object.rb:744:in `block (2 levels) in violates_exclude_platform_constraint?'\r\n      app/models/service_object.rb:743:in `each'\r\n      app/models/service_object.rb:743:in `any?'\r\n      app/models/service_object.rb:743:in `block in violates_exclude_platform_constraint?'\r\n      app/models/service_object.rb:739:in `each'\r\n      app/models/service_object.rb:739:in `violates_exclude_platform_constraint?'\r\n      app/models/service_object.rb:805:in `block in validate_proposal_constraints'\r\n      app/models/service_object.rb:778:in `each'\r\n      app/models/service_object.rb:778:in `validate_proposal_constraints'\r\n      app/models/service_object.rb:669:in `validate_proposal_after_save'\r\n      app/models/cinder_service.rb:204:in `validate_proposal_after_save'\r\n      app/models/service_object.rb:547:in `save_proposal!'\r\n      app/models/service_object.rb:871:in `_proposal_update'\r\n      app/models/service_object.rb:526:in `proposal_edit'\r\n      app/controllers/barclamp_controller.rb:563:in `proposal_update'\r\n\r\nThe problem occurs in this line in\r\n`ServiceObject#violates_exclude_platform_constraint?`:\r\n\r\n        node = NodeObject.find_node_by_name(element)\r\n\r\n`Chef::Node.load` raises the `URI::InvalidURIError` exception which gets caught, turned into a warning, and then `nil` is returned for the node, causing the `NoMethodError` soon after."},"comment":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/comments/248323868","html_url":"https://github.com/SUSE-Cloud/automation/pull/1225#issuecomment-248323868","issue_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1225","id":248323868,"user":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T14:47:34Z","updated_at":"2016-09-20T14:47:34Z","body":"I've created https://github.com/SUSE-Cloud/automation/pull/1255 which is rather similar to this, but also tries to avoid similar issues for ceilometer and nova.\r\n\r\nThe \r\n\r\n> qa_crowbarsetup.sh: line 2866: [: too many arguments\r\n\r\nerror was btw caused by missing quotation in the ```if [ -z $something ]``` tests.\r\n\r\n"}}
{"actor":{"display_login":"rhafer"}}