{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments/76305304","id":76305304,"diff_hunk":"@@ -161,7 +161,9 @@ function runBrowsers(context: Context) {\n       // TODO(nevir): Better rationalize run-end and hook.\n       await context.emitHook('cleanup');\n \n-      return error;\n+      if (error) {\n+        throw error;","path":"runner/steps.ts","position":null,"original_position":6,"commit_id":"eb8b06cdae93a222d45765978ee313134f14be0b","original_commit_id":"0c1be00eb661d626a05f4bc88b5d7854e247704f","user":{"login":"FredKSchott","id":622227,"avatar_url":"https://avatars.githubusercontent.com/u/622227?v=3","gravatar_id":"","url":"https://api.github.com/users/FredKSchott","html_url":"https://github.com/FredKSchott","followers_url":"https://api.github.com/users/FredKSchott/followers","following_url":"https://api.github.com/users/FredKSchott/following{/other_user}","gists_url":"https://api.github.com/users/FredKSchott/gists{/gist_id}","starred_url":"https://api.github.com/users/FredKSchott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredKSchott/subscriptions","organizations_url":"https://api.github.com/users/FredKSchott/orgs","repos_url":"https://api.github.com/users/FredKSchott/repos","events_url":"https://api.github.com/users/FredKSchott/events{/privacy}","received_events_url":"https://api.github.com/users/FredKSchott/received_events","type":"User","site_admin":false},"body":"agreed, it's completely crazy that *anything* can be an exception.","created_at":"2016-08-25T19:03:33Z","updated_at":"2016-08-25T19:03:33Z","html_url":"https://github.com/Polymer/web-component-tester/pull/376#discussion_r76305304","pull_request_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376","_links":{"self":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments/76305304"},"html":{"href":"https://github.com/Polymer/web-component-tester/pull/376#discussion_r76305304"},"pull_request":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376","id":82759983,"html_url":"https://github.com/Polymer/web-component-tester/pull/376","diff_url":"https://github.com/Polymer/web-component-tester/pull/376.diff","patch_url":"https://github.com/Polymer/web-component-tester/pull/376.patch","issue_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/376","number":376,"state":"closed","locked":false,"title":"test() function must reject when any test fails.","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"Fixes #375 \r\n\r\nIn the future we should have an integration test that actually shells out to `wct` and we should assert on the exit code. The integration test cleanup needs to land first though in #374","created_at":"2016-08-25T17:25:27Z","updated_at":"2016-08-25T19:03:33Z","closed_at":"2016-08-25T18:58:38Z","merged_at":"2016-08-25T18:58:38Z","merge_commit_sha":"b916c512837fcb81fa404d7b18ae0ed9b617379e","assignee":{"login":"azakus","id":46725,"avatar_url":"https://avatars.githubusercontent.com/u/46725?v=3","gravatar_id":"","url":"https://api.github.com/users/azakus","html_url":"https://github.com/azakus","followers_url":"https://api.github.com/users/azakus/followers","following_url":"https://api.github.com/users/azakus/following{/other_user}","gists_url":"https://api.github.com/users/azakus/gists{/gist_id}","starred_url":"https://api.github.com/users/azakus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azakus/subscriptions","organizations_url":"https://api.github.com/users/azakus/orgs","repos_url":"https://api.github.com/users/azakus/repos","events_url":"https://api.github.com/users/azakus/events{/privacy}","received_events_url":"https://api.github.com/users/azakus/received_events","type":"User","site_admin":false},"assignees":[{"login":"azakus","id":46725,"avatar_url":"https://avatars.githubusercontent.com/u/46725?v=3","gravatar_id":"","url":"https://api.github.com/users/azakus","html_url":"https://github.com/azakus","followers_url":"https://api.github.com/users/azakus/followers","following_url":"https://api.github.com/users/azakus/following{/other_user}","gists_url":"https://api.github.com/users/azakus/gists{/gist_id}","starred_url":"https://api.github.com/users/azakus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azakus/subscriptions","organizations_url":"https://api.github.com/users/azakus/orgs","repos_url":"https://api.github.com/users/azakus/repos","events_url":"https://api.github.com/users/azakus/events{/privacy}","received_events_url":"https://api.github.com/users/azakus/received_events","type":"User","site_admin":false},{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376/commits","review_comments_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376/comments","review_comment_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/376/comments","statuses_url":"https://api.github.com/repos/Polymer/web-component-tester/statuses/eb8b06cdae93a222d45765978ee313134f14be0b","head":{"label":"Polymer:exit-code","ref":"exit-code","sha":"eb8b06cdae93a222d45765978ee313134f14be0b","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":23168206,"name":"web-component-tester","full_name":"Polymer/web-component-tester","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/web-component-tester","description":"","fork":false,"url":"https://api.github.com/repos/Polymer/web-component-tester","forks_url":"https://api.github.com/repos/Polymer/web-component-tester/forks","keys_url":"https://api.github.com/repos/Polymer/web-component-tester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/web-component-tester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/web-component-tester/teams","hooks_url":"https://api.github.com/repos/Polymer/web-component-tester/hooks","issue_events_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/web-component-tester/events","assignees_url":"https://api.github.com/repos/Polymer/web-component-tester/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/web-component-tester/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/web-component-tester/tags","blobs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/web-component-tester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/web-component-tester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/web-component-tester/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/web-component-tester/languages","stargazers_url":"https://api.github.com/repos/Polymer/web-component-tester/stargazers","contributors_url":"https://api.github.com/repos/Polymer/web-component-tester/contributors","subscribers_url":"https://api.github.com/repos/Polymer/web-component-tester/subscribers","subscription_url":"https://api.github.com/repos/Polymer/web-component-tester/subscription","commits_url":"https://api.github.com/repos/Polymer/web-component-tester/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/web-component-tester/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/web-component-tester/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/web-component-tester/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/web-component-tester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/web-component-tester/merges","archive_url":"https://api.github.com/repos/Polymer/web-component-tester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/web-component-tester/downloads","issues_url":"https://api.github.com/repos/Polymer/web-component-tester/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/web-component-tester/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/web-component-tester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/web-component-tester/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/web-component-tester/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/web-component-tester/deployments","created_at":"2014-08-20T23:59:40Z","updated_at":"2016-08-22T09:32:17Z","pushed_at":"2016-08-25T19:02:18Z","git_url":"git://github.com/Polymer/web-component-tester.git","ssh_url":"git@github.com:Polymer/web-component-tester.git","clone_url":"https://github.com/Polymer/web-component-tester.git","svn_url":"https://github.com/Polymer/web-component-tester","homepage":"","size":5879,"stargazers_count":346,"watchers_count":346,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":101,"forks":86,"open_issues":101,"watchers":346,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"142faf172cb0b9699d3cbbc1d301eb8f673512e4","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":23168206,"name":"web-component-tester","full_name":"Polymer/web-component-tester","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/web-component-tester","description":"","fork":false,"url":"https://api.github.com/repos/Polymer/web-component-tester","forks_url":"https://api.github.com/repos/Polymer/web-component-tester/forks","keys_url":"https://api.github.com/repos/Polymer/web-component-tester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/web-component-tester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/web-component-tester/teams","hooks_url":"https://api.github.com/repos/Polymer/web-component-tester/hooks","issue_events_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/web-component-tester/events","assignees_url":"https://api.github.com/repos/Polymer/web-component-tester/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/web-component-tester/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/web-component-tester/tags","blobs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/web-component-tester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/web-component-tester/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/web-component-tester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/web-component-tester/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/web-component-tester/languages","stargazers_url":"https://api.github.com/repos/Polymer/web-component-tester/stargazers","contributors_url":"https://api.github.com/repos/Polymer/web-component-tester/contributors","subscribers_url":"https://api.github.com/repos/Polymer/web-component-tester/subscribers","subscription_url":"https://api.github.com/repos/Polymer/web-component-tester/subscription","commits_url":"https://api.github.com/repos/Polymer/web-component-tester/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/web-component-tester/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/web-component-tester/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/web-component-tester/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/web-component-tester/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/web-component-tester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/web-component-tester/merges","archive_url":"https://api.github.com/repos/Polymer/web-component-tester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/web-component-tester/downloads","issues_url":"https://api.github.com/repos/Polymer/web-component-tester/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/web-component-tester/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/web-component-tester/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/web-component-tester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/web-component-tester/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/web-component-tester/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/web-component-tester/deployments","created_at":"2014-08-20T23:59:40Z","updated_at":"2016-08-22T09:32:17Z","pushed_at":"2016-08-25T19:02:18Z","git_url":"git://github.com/Polymer/web-component-tester.git","ssh_url":"git@github.com:Polymer/web-component-tester.git","clone_url":"https://github.com/Polymer/web-component-tester.git","svn_url":"https://github.com/Polymer/web-component-tester","homepage":"","size":5879,"stargazers_count":346,"watchers_count":346,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":101,"forks":86,"open_issues":101,"watchers":346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376"},"html":{"href":"https://github.com/Polymer/web-component-tester/pull/376"},"issue":{"href":"https://api.github.com/repos/Polymer/web-component-tester/issues/376"},"comments":{"href":"https://api.github.com/repos/Polymer/web-component-tester/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/web-component-tester/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/web-component-tester/statuses/eb8b06cdae93a222d45765978ee313134f14be0b"}}}}
{"actor":{"display_login":"FredKSchott"}}