{"push_id":959074015,"size":57,"distinct_size":57,"ref":"refs/heads/get-logs","head":"6dcc5df56ed9311b9aa9d1d3f3cabad1184620ae","before":"7c6c1100eadf47878e5d77babb402a728f3d5fe4","commits":[{"sha":"dc837ae7fe6f36552cf3bcde7b938f307361c7d2","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"Merge pull request #2037 from yifan-gu/fix_annotation\n\nMetadata-service: Handle annotation names that contain slash.","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/dc837ae7fe6f36552cf3bcde7b938f307361c7d2"},{"sha":"69210ca0347ff39577107ef79602b5f06ad1ac32","author":{"email":"5d61c11e6df8ed8ffd2a3627a86b97e825765970@kinvolk.io","name":"Alban Crequy"},"message":"*: fill resolv.conf from command line\n\nrkt now provides /etc/resolv.conf in each app's chroot. All apps in the\npod have the same /etc/resolv.conf.\n\nGetting DNS information from the CNI or from the host's resolv.conf is\nout of scope of this patch. The content of /etc/resolv.conf comes from\nthe command line parameters:\n- \"--dns=8.8.8.8\": DNS name server\n- \"--dns-search=domain.com\": DNS search domain\n- \"--dns-opt=debug\": DNS options\n\nImplementation detail: systemd-nspawn can overwrite /etc/resolv.conf. It\nis supposed to overwrite it only when the container uses the host\nnetwork namespace.  However, the container network namespace is created\nby rkt via CNI and not by systemd-nspawn, so systemd-nspawn is not aware\nof the network configuration. As a consequence, we cannot use stage1's\n/etc/resolv.conf. Instead, rkt write /etc/rkt-resolv.conf in stage1 and\nprepare-app bind-mounts it in stage2's /etc/resolv.conf.\n\nIt works in this way:\n\n> $ sudo rkt run --net=alban --dns=1.1.1.1 --dns=2.2.2.2 \\\n>                --dns-search=foo.com --dns-opt=debug \\\n>                sha512-a2fb8f390702 --interactive\n> / # cat /etc/resolv.conf\n> # Generated by rkt\n>\n> search foo.com\n> nameserver 1.1.1.1\n> nameserver 2.2.2.2\n> options debug\n>\n> / #\n\nFixes https://github.com/coreos/rkt/issues/660","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/69210ca0347ff39577107ef79602b5f06ad1ac32"},{"sha":"ccc7442bcf885d48843be04579ccb7aec8be0cbd","author":{"email":"5c02e9e9f8717ecc4c298a0b35bf5fc741c9cf6a@users.noreply.github.com","name":"Stefan Junker"},"message":"Merge pull request #2040 from kinvolk/alban/dns-2\n\n*: fill resolv.conf from command line --dns* flags","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/ccc7442bcf885d48843be04579ccb7aec8be0cbd"},{"sha":"27a18ff2fbf319e34d1a0e998c9e114804dc453d","author":{"email":"08b3ee9e6b18a12a2e38b65d7c8561c9337dccee@kinvolk.io","name":"Iago López Galeiras"},"message":"Documentation: put flags in the order they're displayed in rkt","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/27a18ff2fbf319e34d1a0e998c9e114804dc453d"},{"sha":"2d8bf9f1b814f7934f27861bc7efbf82943c2542","author":{"email":"08b3ee9e6b18a12a2e38b65d7c8561c9337dccee@kinvolk.io","name":"Iago López Galeiras"},"message":"Documentation: add install and version subcommands\n\nFor completeness.","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/2d8bf9f1b814f7934f27861bc7efbf82943c2542"},{"sha":"49aa9e2801cfdc64ec74baf846ecb0f5453601e0","author":{"email":"08b3ee9e6b18a12a2e38b65d7c8561c9337dccee@kinvolk.io","name":"Iago López Galeiras"},"message":"Documentation: document subcommand flags","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/49aa9e2801cfdc64ec74baf846ecb0f5453601e0"},{"sha":"51ad35db6225d38a6b838aea323f4bf190a18925","author":{"email":"08b3ee9e6b18a12a2e38b65d7c8561c9337dccee@kinvolk.io","name":"Iago López Galeiras"},"message":"Documentation/run: better document --volume","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/51ad35db6225d38a6b838aea323f4bf190a18925"},{"sha":"42306765d6688e91744de9b5f4e372889255652c","author":{"email":"08b3ee9e6b18a12a2e38b65d7c8561c9337dccee@kinvolk.io","name":"Iago López Galeiras"},"message":"Documentation: review changes","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/42306765d6688e91744de9b5f4e372889255652c"},{"sha":"fd93b834809e71331df39b2a37e86947adca018d","author":{"email":"08b3ee9e6b18a12a2e38b65d7c8561c9337dccee@kinvolk.io","name":"Iago López Galeiras"},"message":"rkt/*: changes to flags' help text","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/fd93b834809e71331df39b2a37e86947adca018d"},{"sha":"d0ba73a299e00165e0d1c1e755089572cb816951","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"godeps: add errwrap package dependency\n\nerrwrap provides a means of structuring error messages.","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/d0ba73a299e00165e0d1c1e755089572cb816951"},{"sha":"22e54719bc3fbe5d6002777e90eba57b96dceeb8","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"rkt: make error handling structured\n\nUp to now errors in rkt have been a concatenated string. This often\nended with the user being presented with a very long, hard to decipher\nerror message. Furthermore, sometimes the message was prefixed with the\nname of the command, sometimes not. In essencce, errors messages were\ninconsistent and confusing.\n\nThis patch introduces structured error messages using the errwrap\npackage. The goal is to have errors be useful & consistant, and have a\nsingle location (common/errors.go) where we can modify the error output.\n\nErrors are stored as an inner and outer errors. We do this by nesting\nerrors using errwrap.Wrap. With this structure we have much more control\nover how we can display errors.","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/22e54719bc3fbe5d6002777e90eba57b96dceeb8"},{"sha":"b9ea3b72386c7d7139f9e67223c48f9efce6245d","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"rkt: handle all output through new log package\n\nThis change creates a new type, Logger, that wraps go's own Logger type\nto provide consistent output across go commands. Along with the methods\nfrom go's log package, there are also methods that accept our structured\nerror type introduced in the previous commit. These commands append an\n'E' to the end of the familiar methods. For example, we now have\n'PrintE', 'PanicE', & 'FatalE'.\n\nWith this, we have one, central location to modify the way output is displayed in\nrkt.\n\nThe output generated when printing errors is:\n\n```\ncat-manifest: problem retrieving pod: no matches found for \"asf\"\n```\n\nor when using the `--debug` flag we'll get the entire error stack.\n\n```\ncat-manifest: problem retrieving pod\n  └─unable to resolve UUID\n    └─no matches found for \"asf\"\n```\n\nFrom this example we can see that when no `--debug` flag is used, you\nget the innermost error as the last output on the line. All other errors\nare hidden. This text between the 'command name' is the programmer\ndefined message that accompanies the errors sent to output. This can be\nleft empty.\n\nWhen using the `--debug` flag we only get the 'command name' and\naccompanying message on the first line. Under that we get the unwound\nerror messages, with the innermost one at the bottom.\n\nFurthermore, all output to stderr has a prefix that is either\nprogramatically set using the command or subsommand name, or one set in\nthe package.\n\nrefs: #1550\nfixes: #1754","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/b9ea3b72386c7d7139f9e67223c48f9efce6245d"},{"sha":"b01a806fc9e23cb4ca1033dd84cb129a92ed5855","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"rkt: make error messages start lowercase\n\nThis makes casing for diagnostic and error messages consistent across\nrkt.","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/b01a806fc9e23cb4ca1033dd84cb129a92ed5855"},{"sha":"c5ca860c5e47f8d430ae58759ed03de5648ee9a1","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"tests: update output matches in tests\n\nWith the changes in error and diagnostic tests, some strings needed to\nbe updated.","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/c5ca860c5e47f8d430ae58759ed03de5648ee9a1"},{"sha":"ab3236ab6deb27623feee9a2a7babe4fdccbdaf8","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"tests: add unit test for pkg/log","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/ab3236ab6deb27623feee9a2a7babe4fdccbdaf8"},{"sha":"696b9b5af6e6f44f9d81b5cb35e89cd0164394e4","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"rkt: use Logger for image & pubkey packages","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/696b9b5af6e6f44f9d81b5cb35e89cd0164394e4"},{"sha":"fc6db5ccbab09c0da46668448526641998f27576","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"Add missing import in keygen","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/fc6db5ccbab09c0da46668448526641998f27576"},{"sha":"24e3fbc91db8edcad2c7bceac929438dd9ba28a7","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"tests: match against HTTP status in auth test","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/24e3fbc91db8edcad2c7bceac929438dd9ba28a7"},{"sha":"362b8ac7f9fd631966e8e77f6e85f76a30f32b58","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"Fix various logging and error msg issues","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/362b8ac7f9fd631966e8e77f6e85f76a30f32b58"},{"sha":"0f839657f648a0d87d4d9040fb0e9e318eefe1e1","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@kinvolk.io","name":"Chris Kühl"},"message":"Remove extra line in api_service init","distinct":true,"url":"https://api.github.com/repos/derekparker/rkt/commits/0f839657f648a0d87d4d9040fb0e9e318eefe1e1"}]}