{"action":"created","comment":{"url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/comments/83701335","pull_request_review_id":4527811,"id":83701335,"diff_hunk":"@@ -116,6 +116,8 @@ def main():\n                                                        cleanup=False, designation=title, grade=grade)\n             certificate_data.append((name, course, args.long_org, args.long_course, download_url))\n             gen_dir = os.path.join(cert.dir_prefix, S3_CERT_PATH, download_uuid)\n+            # Remove non-ascii chars since this is a filename\n+            name = ''.join([i if ord(i) < 128 else ' ' for i in name])","path":"create_pdfs.py","position":5,"original_position":5,"commit_id":"fb043593abc9c5cb76ac9b588f2d7b8e60df9870","original_commit_id":"fb043593abc9c5cb76ac9b588f2d7b8e60df9870","user":{"login":"caesar2164","id":3364609,"avatar_url":"https://avatars.githubusercontent.com/u/3364609?v=3","gravatar_id":"","url":"https://api.github.com/users/caesar2164","html_url":"https://github.com/caesar2164","followers_url":"https://api.github.com/users/caesar2164/followers","following_url":"https://api.github.com/users/caesar2164/following{/other_user}","gists_url":"https://api.github.com/users/caesar2164/gists{/gist_id}","starred_url":"https://api.github.com/users/caesar2164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesar2164/subscriptions","organizations_url":"https://api.github.com/users/caesar2164/orgs","repos_url":"https://api.github.com/users/caesar2164/repos","events_url":"https://api.github.com/users/caesar2164/events{/privacy}","received_events_url":"https://api.github.com/users/caesar2164/received_events","type":"User","site_admin":false},"body":"clearly this works, but don't really like it...","created_at":"2016-10-17T18:12:39Z","updated_at":"2016-10-17T18:13:31Z","html_url":"https://github.com/Stanford-Online/openedx-certificates/pull/30#discussion_r83701335","pull_request_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/comments/83701335"},"html":{"href":"https://github.com/Stanford-Online/openedx-certificates/pull/30#discussion_r83701335"},"pull_request":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30","id":89458662,"html_url":"https://github.com/Stanford-Online/openedx-certificates/pull/30","diff_url":"https://github.com/Stanford-Online/openedx-certificates/pull/30.diff","patch_url":"https://github.com/Stanford-Online/openedx-certificates/pull/30.patch","issue_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/issues/30","number":30,"state":"open","locked":false,"title":"Cme unicode issue hotseat","user":{"login":"caseylitton","id":6748589,"avatar_url":"https://avatars.githubusercontent.com/u/6748589?v=3","gravatar_id":"","url":"https://api.github.com/users/caseylitton","html_url":"https://github.com/caseylitton","followers_url":"https://api.github.com/users/caseylitton/followers","following_url":"https://api.github.com/users/caseylitton/following{/other_user}","gists_url":"https://api.github.com/users/caseylitton/gists{/gist_id}","starred_url":"https://api.github.com/users/caseylitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseylitton/subscriptions","organizations_url":"https://api.github.com/users/caseylitton/orgs","repos_url":"https://api.github.com/users/caseylitton/repos","events_url":"https://api.github.com/users/caseylitton/events{/privacy}","received_events_url":"https://api.github.com/users/caseylitton/received_events","type":"User","site_admin":false},"body":"@stvstnfrd @dcadams @kluo @caesar2164 PR for fixing non ascii student name hot seat issue for the cme renderer.  Fixed associated test.\r\n\r\nCreating certs with non-ascii student names like 'Raquel Sá Lopes da Slva' had two problems.\r\n1.  Could not save pdfs for any cert locally because the student name with non-ascii chars was used in the file name.  I couldn't find a good way to do this, the code just replaces 'bad' chars with a dash\r\n\r\n2.  CME certs would fail because there is a second formatting done on the student name because of the designations.  That was a decoding issue with a string format. \r\n","created_at":"2016-10-14T21:35:37Z","updated_at":"2016-10-17T18:13:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27bcedc3a2ecda7f5ac450df550673b208117c28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30/commits","review_comments_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30/comments","review_comment_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/issues/30/comments","statuses_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/statuses/fb043593abc9c5cb76ac9b588f2d7b8e60df9870","head":{"label":"caseylitton:cme_unicode_issue_hotseat","ref":"cme_unicode_issue_hotseat","sha":"fb043593abc9c5cb76ac9b588f2d7b8e60df9870","user":{"login":"caseylitton","id":6748589,"avatar_url":"https://avatars.githubusercontent.com/u/6748589?v=3","gravatar_id":"","url":"https://api.github.com/users/caseylitton","html_url":"https://github.com/caseylitton","followers_url":"https://api.github.com/users/caseylitton/followers","following_url":"https://api.github.com/users/caseylitton/following{/other_user}","gists_url":"https://api.github.com/users/caseylitton/gists{/gist_id}","starred_url":"https://api.github.com/users/caseylitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseylitton/subscriptions","organizations_url":"https://api.github.com/users/caseylitton/orgs","repos_url":"https://api.github.com/users/caseylitton/repos","events_url":"https://api.github.com/users/caseylitton/events{/privacy}","received_events_url":"https://api.github.com/users/caseylitton/received_events","type":"User","site_admin":false},"repo":{"id":66667920,"name":"openedx-certificates","full_name":"caseylitton/openedx-certificates","owner":{"login":"caseylitton","id":6748589,"avatar_url":"https://avatars.githubusercontent.com/u/6748589?v=3","gravatar_id":"","url":"https://api.github.com/users/caseylitton","html_url":"https://github.com/caseylitton","followers_url":"https://api.github.com/users/caseylitton/followers","following_url":"https://api.github.com/users/caseylitton/following{/other_user}","gists_url":"https://api.github.com/users/caseylitton/gists{/gist_id}","starred_url":"https://api.github.com/users/caseylitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseylitton/subscriptions","organizations_url":"https://api.github.com/users/caseylitton/orgs","repos_url":"https://api.github.com/users/caseylitton/repos","events_url":"https://api.github.com/users/caseylitton/events{/privacy}","received_events_url":"https://api.github.com/users/caseylitton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caseylitton/openedx-certificates","description":"The code Stanford uses to generate PDF certificates","fork":true,"url":"https://api.github.com/repos/caseylitton/openedx-certificates","forks_url":"https://api.github.com/repos/caseylitton/openedx-certificates/forks","keys_url":"https://api.github.com/repos/caseylitton/openedx-certificates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caseylitton/openedx-certificates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caseylitton/openedx-certificates/teams","hooks_url":"https://api.github.com/repos/caseylitton/openedx-certificates/hooks","issue_events_url":"https://api.github.com/repos/caseylitton/openedx-certificates/issues/events{/number}","events_url":"https://api.github.com/repos/caseylitton/openedx-certificates/events","assignees_url":"https://api.github.com/repos/caseylitton/openedx-certificates/assignees{/user}","branches_url":"https://api.github.com/repos/caseylitton/openedx-certificates/branches{/branch}","tags_url":"https://api.github.com/repos/caseylitton/openedx-certificates/tags","blobs_url":"https://api.github.com/repos/caseylitton/openedx-certificates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caseylitton/openedx-certificates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caseylitton/openedx-certificates/git/refs{/sha}","trees_url":"https://api.github.com/repos/caseylitton/openedx-certificates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caseylitton/openedx-certificates/statuses/{sha}","languages_url":"https://api.github.com/repos/caseylitton/openedx-certificates/languages","stargazers_url":"https://api.github.com/repos/caseylitton/openedx-certificates/stargazers","contributors_url":"https://api.github.com/repos/caseylitton/openedx-certificates/contributors","subscribers_url":"https://api.github.com/repos/caseylitton/openedx-certificates/subscribers","subscription_url":"https://api.github.com/repos/caseylitton/openedx-certificates/subscription","commits_url":"https://api.github.com/repos/caseylitton/openedx-certificates/commits{/sha}","git_commits_url":"https://api.github.com/repos/caseylitton/openedx-certificates/git/commits{/sha}","comments_url":"https://api.github.com/repos/caseylitton/openedx-certificates/comments{/number}","issue_comment_url":"https://api.github.com/repos/caseylitton/openedx-certificates/issues/comments{/number}","contents_url":"https://api.github.com/repos/caseylitton/openedx-certificates/contents/{+path}","compare_url":"https://api.github.com/repos/caseylitton/openedx-certificates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caseylitton/openedx-certificates/merges","archive_url":"https://api.github.com/repos/caseylitton/openedx-certificates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caseylitton/openedx-certificates/downloads","issues_url":"https://api.github.com/repos/caseylitton/openedx-certificates/issues{/number}","pulls_url":"https://api.github.com/repos/caseylitton/openedx-certificates/pulls{/number}","milestones_url":"https://api.github.com/repos/caseylitton/openedx-certificates/milestones{/number}","notifications_url":"https://api.github.com/repos/caseylitton/openedx-certificates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caseylitton/openedx-certificates/labels{/name}","releases_url":"https://api.github.com/repos/caseylitton/openedx-certificates/releases{/id}","deployments_url":"https://api.github.com/repos/caseylitton/openedx-certificates/deployments","created_at":"2016-08-26T17:49:54Z","updated_at":"2016-08-26T17:49:56Z","pushed_at":"2016-10-14T23:21:34Z","git_url":"git://github.com/caseylitton/openedx-certificates.git","ssh_url":"git@github.com:caseylitton/openedx-certificates.git","clone_url":"https://github.com/caseylitton/openedx-certificates.git","svn_url":"https://github.com/caseylitton/openedx-certificates","homepage":"","size":17419,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Stanford-Online:master","ref":"master","sha":"aab0bf382f18313b3bc04b5c474efba60ce9a0af","user":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=3","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":29034681,"name":"openedx-certificates","full_name":"Stanford-Online/openedx-certificates","owner":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=3","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stanford-Online/openedx-certificates","description":"The code Stanford uses to generate PDF certificates","fork":true,"url":"https://api.github.com/repos/Stanford-Online/openedx-certificates","forks_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/forks","keys_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/teams","hooks_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/hooks","issue_events_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/issues/events{/number}","events_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/events","assignees_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/assignees{/user}","branches_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/branches{/branch}","tags_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/tags","blobs_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/statuses/{sha}","languages_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/languages","stargazers_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/stargazers","contributors_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/contributors","subscribers_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/subscribers","subscription_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/subscription","commits_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/contents/{+path}","compare_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/merges","archive_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/downloads","issues_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/issues{/number}","pulls_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls{/number}","milestones_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/milestones{/number}","notifications_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/labels{/name}","releases_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/releases{/id}","deployments_url":"https://api.github.com/repos/Stanford-Online/openedx-certificates/deployments","created_at":"2015-01-09T20:47:10Z","updated_at":"2016-04-22T23:38:33Z","pushed_at":"2016-10-14T23:21:35Z","git_url":"git://github.com/Stanford-Online/openedx-certificates.git","ssh_url":"git@github.com:Stanford-Online/openedx-certificates.git","clone_url":"https://github.com/Stanford-Online/openedx-certificates.git","svn_url":"https://github.com/Stanford-Online/openedx-certificates","homepage":"","size":17439,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30"},"html":{"href":"https://github.com/Stanford-Online/openedx-certificates/pull/30"},"issue":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/issues/30"},"comments":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/Stanford-Online/openedx-certificates/statuses/fb043593abc9c5cb76ac9b588f2d7b8e60df9870"}}}}
{"actor":{"display_login":"caesar2164"}}