{"action":"closed","number":2320,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2320","id":64028968,"html_url":"https://github.com/coreos/rkt/pull/2320","diff_url":"https://github.com/coreos/rkt/pull/2320.diff","patch_url":"https://github.com/coreos/rkt/pull/2320.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2320","number":2320,"state":"closed","locked":false,"title":"rkt: Improve build shell script","user":{"login":"mstachowski","id":9694425,"avatar_url":"https://avatars.githubusercontent.com/u/9694425?v=3","gravatar_id":"","url":"https://api.github.com/users/mstachowski","html_url":"https://github.com/mstachowski","followers_url":"https://api.github.com/users/mstachowski/followers","following_url":"https://api.github.com/users/mstachowski/following{/other_user}","gists_url":"https://api.github.com/users/mstachowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mstachowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstachowski/subscriptions","organizations_url":"https://api.github.com/users/mstachowski/orgs","repos_url":"https://api.github.com/users/mstachowski/repos","events_url":"https://api.github.com/users/mstachowski/events{/privacy}","received_events_url":"https://api.github.com/users/mstachowski/received_events","type":"User","site_admin":false},"body":"Rework of run-build shell script.\r\n\r\nNew run-build script will have got following features:\r\n- [x] Add temporary build files cleanup (during Semaphore build, it\r\n   improves test stability for kvm)\r\n- [x] Split script body into functions\r\n- [x] Add better argument parsing\r\n- [x] Fix build directory name\r\n- [x] Add parameter validation\r\n- [x] Add ```usage```\r\n- [x] Add/fix documentation\r\n- [x] Add ```force``` flag\r\n- [x] Repair cloudInit files\r\n\r\nThis code required new SemaphoreCI configuration - current check will fail\r\n[![Build Status](https://semaphoreci.com/api/v1/mstachowski/rkt/branches/mstachow-rkt_test_cleanup/badge.svg)](https://semaphoreci.com/mstachowski/rkt)","created_at":"2016-03-24T12:48:47Z","updated_at":"2016-04-08T11:11:51Z","closed_at":"2016-04-08T11:11:51Z","merged_at":"2016-04-08T11:11:51Z","merge_commit_sha":"d06a4949d8e226e89dd2141b64e30eaf10d049b7","assignee":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2320/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2320/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2320/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/e9a00d7324936ec00525265ec8ceae3ea584cf8d","head":{"label":"intelsdi-x:mstachow/rkt_test_cleanup","ref":"mstachow/rkt_test_cleanup","sha":"e9a00d7324936ec00525265ec8ceae3ea584cf8d","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":38779722,"name":"rkt","full_name":"intelsdi-x/rkt","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/intelsdi-x/rkt","forks_url":"https://api.github.com/repos/intelsdi-x/rkt/forks","keys_url":"https://api.github.com/repos/intelsdi-x/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/rkt/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/rkt/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/rkt/events","assignees_url":"https://api.github.com/repos/intelsdi-x/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/rkt/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/rkt/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/rkt/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/rkt/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/rkt/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/rkt/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/rkt/merges","archive_url":"https://api.github.com/repos/intelsdi-x/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/rkt/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/rkt/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/rkt/deployments","created_at":"2015-07-08T21:00:32Z","updated_at":"2016-02-13T13:35:14Z","pushed_at":"2016-04-08T10:59:22Z","git_url":"git://github.com/intelsdi-x/rkt.git","ssh_url":"git@github.com:intelsdi-x/rkt.git","clone_url":"https://github.com/intelsdi-x/rkt.git","svn_url":"https://github.com/intelsdi-x/rkt","homepage":"","size":19911,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"cfc0d7ff785b4ae38d8ed706f4ef84b30ab4d761","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-04-08T09:55:31Z","pushed_at":"2016-04-08T11:11:51Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":26059,"stargazers_count":5380,"watchers_count":5380,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":491,"mirror_url":null,"open_issues_count":276,"forks":491,"open_issues":276,"watchers":5380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2320"},"html":{"href":"https://github.com/coreos/rkt/pull/2320"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2320"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2320/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2320/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2320/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/e9a00d7324936ec00525265ec8ceae3ea584cf8d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"comments":15,"review_comments":17,"commits":1,"additions":271,"deletions":130,"changed_files":7}}