{"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/93432564","pull_request_review_id":13957820,"id":93432564,"diff_hunk":"@@ -474,12 +1142,63 @@ def test_positive_list_filter_by_product_name_and_org_id(self):\n         1. erratum list --product=<product_name> --organization-id=<org_id>\n \n         @Assert: Errata is filtered by product name and Org id.\n-\n-        @caseautomation: notautomated\n-\n         \"\"\"\n-\n-    @stubbed()\n+        product_erratum_list = Erratum.list({","path":"tests/foreman/cli/test_errata.py","position":689,"original_position":909,"commit_id":"027bf3f4787280e0bb0d0731ae5d853f49855208","original_commit_id":"027bf3f4787280e0bb0d0731ae5d853f49855208","user":{"login":"renzon","id":3457115,"avatar_url":"https://avatars.githubusercontent.com/u/3457115?v=3","gravatar_id":"","url":"https://api.github.com/users/renzon","html_url":"https://github.com/renzon","followers_url":"https://api.github.com/users/renzon/followers","following_url":"https://api.github.com/users/renzon/following{/other_user}","gists_url":"https://api.github.com/users/renzon/gists{/gist_id}","starred_url":"https://api.github.com/users/renzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzon/subscriptions","organizations_url":"https://api.github.com/users/renzon/orgs","repos_url":"https://api.github.com/users/renzon/repos","events_url":"https://api.github.com/users/renzon/events{/privacy}","received_events_url":"https://api.github.com/users/renzon/received_events","type":"User","site_admin":false},"body":"I compared the assert part of test bellow this line and it is exactly the same as the on begining on line 1085. I suppose it is the same on other tests that I made comment about set with empty list. So what you think about extraction a method `assert_errata_conditions' receiving the all errata related as parameters? At least we would have less code and no repetition.","created_at":"2016-12-21T12:53:03Z","updated_at":"2016-12-21T12:53:03Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/4112#discussion_r93432564","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/93432564"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/4112#discussion_r93432564"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112","id":98921538,"html_url":"https://github.com/SatelliteQE/robottelo/pull/4112","diff_url":"https://github.com/SatelliteQE/robottelo/pull/4112.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/4112.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/4112","number":4112,"state":"open","locked":false,"title":"[6.2.z] CLI Errata, cherry-picked from 6.3 with some additions","user":{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"body":"```bash\r\n(2.7) dlezz@elysion:~/projects/robottelo-fork$ py.test tests/foreman/cli/test_errata.py -v -k \"ErrataTestCase\"\r\n================================================= test session starts ==================================================\r\nplatform linux2 -- Python 2.7.12, pytest-3.0.3, py-1.4.31, pluggy-0.4.0 -- /home/dlezz/bin/redhat/python/2.7/bin/python\r\ncachedir: .cache\r\nrootdir: /home/dlezz/projects/robottelo-fork, inifile: \r\nplugins: cov-2.4.0, xdist-1.15.0\r\ncollected 34 items \r\n\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_affected_chosts <- ../../bin/redhat/python/2.7/lib/python2.7/site-packages/unittest2/case.py SKIPPED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_affected_chosts_by_erratum_restrict_flag <- ../../bin/redhat/python/2.7/lib/python2.7/site-packages/unittest2/case.py SKIPPED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_cve <- robottelo/decorators/__init__.py PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_id PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_id_and_sort_by_issued_date PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_id_and_sort_by_updated_date PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_label PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_label_and_sort_by_issued_date PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_label_and_sort_by_updated_date PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_name PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_name_and_sort_by_issued_date PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_org_name_and_sort_by_updated_date PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_id <- robottelo/decorators/__init__.py SKIPPED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_id_and_org_id PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_id_and_org_label PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_id_and_org_name PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_name <- ../../bin/redhat/python/2.7/lib/python2.7/site-packages/unittest2/case.py SKIPPED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_name_and_org_id PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_name_and_org_label PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_filter_by_product_name_and_org_name PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_list_sort_by_issued_date PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_user_permission PASSED\r\ntests/foreman/cli/test_errata.py::ErrataTestCase::test_positive_view_available_count_in_affected_chosts <- ../../bin/redhat/python/2.7/lib/python2.7/site-packages/unittest2/case.py SKIPPED\r\n\r\n================================================= 11 tests deselected ==================================================\r\n================================ 18 passed, 5 skipped, 11 deselected in 1429.30 seconds ================================\r\n(2.7) dlezz@elysion:~/projects/robottelo-fork$ \r\n```\r\n**PLEASE DO NOT SQUASH WHEN MERGING**","created_at":"2016-12-21T12:07:17Z","updated_at":"2016-12-21T12:56:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e01a2e8d9494899111aacdcec4a1df0def2475f","assignee":{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"assignees":[{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/4112/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/027bf3f4787280e0bb0d0731ae5d853f49855208","head":{"label":"ldjebran:6.2.z_CLI_ERRATA","ref":"6.2.z_CLI_ERRATA","sha":"027bf3f4787280e0bb0d0731ae5d853f49855208","user":{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"repo":{"id":71339453,"name":"robottelo","full_name":"ldjebran/robottelo","owner":{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldjebran/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":true,"url":"https://api.github.com/repos/ldjebran/robottelo","forks_url":"https://api.github.com/repos/ldjebran/robottelo/forks","keys_url":"https://api.github.com/repos/ldjebran/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldjebran/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldjebran/robottelo/teams","hooks_url":"https://api.github.com/repos/ldjebran/robottelo/hooks","issue_events_url":"https://api.github.com/repos/ldjebran/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/ldjebran/robottelo/events","assignees_url":"https://api.github.com/repos/ldjebran/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/ldjebran/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/ldjebran/robottelo/tags","blobs_url":"https://api.github.com/repos/ldjebran/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldjebran/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldjebran/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldjebran/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldjebran/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/ldjebran/robottelo/languages","stargazers_url":"https://api.github.com/repos/ldjebran/robottelo/stargazers","contributors_url":"https://api.github.com/repos/ldjebran/robottelo/contributors","subscribers_url":"https://api.github.com/repos/ldjebran/robottelo/subscribers","subscription_url":"https://api.github.com/repos/ldjebran/robottelo/subscription","commits_url":"https://api.github.com/repos/ldjebran/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldjebran/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldjebran/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldjebran/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldjebran/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/ldjebran/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldjebran/robottelo/merges","archive_url":"https://api.github.com/repos/ldjebran/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldjebran/robottelo/downloads","issues_url":"https://api.github.com/repos/ldjebran/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/ldjebran/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/ldjebran/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/ldjebran/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldjebran/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/ldjebran/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/ldjebran/robottelo/deployments","created_at":"2016-10-19T09:11:49Z","updated_at":"2016-10-19T09:11:52Z","pushed_at":"2016-12-21T12:17:27Z","git_url":"git://github.com/ldjebran/robottelo.git","ssh_url":"git@github.com:ldjebran/robottelo.git","clone_url":"https://github.com/ldjebran/robottelo.git","svn_url":"https://github.com/ldjebran/robottelo","homepage":"","size":14177,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:6.2.z","ref":"6.2.z","sha":"0db9c3aa76e1d7591bbb5361df594fb4f5efb6f0","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/SatelliteQE/robottelo/deployments","created_at":"2012-04-12T01:36:39Z","updated_at":"2016-11-05T02:46:41Z","pushed_at":"2016-12-21T12:34:14Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":"","size":14182,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":161,"forks":47,"open_issues":161,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/4112"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/4112"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/4112/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/4112/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/027bf3f4787280e0bb0d0731ae5d853f49855208"}}}}
{"actor":{"display_login":"renzon"}}