{"action":"created","issue":{"url":"https://api.github.com/repos/savonrb/wasabi/issues/63","repository_url":"https://api.github.com/repos/savonrb/wasabi","labels_url":"https://api.github.com/repos/savonrb/wasabi/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/savonrb/wasabi/issues/63/comments","events_url":"https://api.github.com/repos/savonrb/wasabi/issues/63/events","html_url":"https://github.com/savonrb/wasabi/pull/63","id":138200612,"number":63,"title":"Add support for rpc encoded wsdl","user":{"login":"fernandes","id":517743,"avatar_url":"https://avatars.githubusercontent.com/u/517743?v=3","gravatar_id":"","url":"https://api.github.com/users/fernandes","html_url":"https://github.com/fernandes","followers_url":"https://api.github.com/users/fernandes/followers","following_url":"https://api.github.com/users/fernandes/following{/other_user}","gists_url":"https://api.github.com/users/fernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandes/subscriptions","organizations_url":"https://api.github.com/users/fernandes/orgs","repos_url":"https://api.github.com/users/fernandes/repos","events_url":"https://api.github.com/users/fernandes/events{/privacy}","received_events_url":"https://api.github.com/users/fernandes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-03T14:53:22Z","updated_at":"2016-03-04T05:30:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/savonrb/wasabi/pulls/63","html_url":"https://github.com/savonrb/wasabi/pull/63","diff_url":"https://github.com/savonrb/wasabi/pull/63.diff","patch_url":"https://github.com/savonrb/wasabi/pull/63.patch"},"body":"Wasabi::Parser always returns a array with [0] being the namespace and [1]\r\nbeing the parameter name.\r\n\r\nThe problem is that rpc has part elements that represent \"arguments\" for the\r\nparameter, so now on parser checks if it's a multi part then returns the\r\nparameter and all it part elements (including its type).\r\n\r\ndisclaimer: I'm totally new to SOAP, sorry if I misunderstood any concept.\r\nI tried to implement touch as few places as possible on current code base."},"comment":{"url":"https://api.github.com/repos/savonrb/wasabi/issues/comments/192111355","html_url":"https://github.com/savonrb/wasabi/pull/63#issuecomment-192111355","issue_url":"https://api.github.com/repos/savonrb/wasabi/issues/63","id":192111355,"user":{"login":"tjarratt","id":249262,"avatar_url":"https://avatars.githubusercontent.com/u/249262?v=3","gravatar_id":"","url":"https://api.github.com/users/tjarratt","html_url":"https://github.com/tjarratt","followers_url":"https://api.github.com/users/tjarratt/followers","following_url":"https://api.github.com/users/tjarratt/following{/other_user}","gists_url":"https://api.github.com/users/tjarratt/gists{/gist_id}","starred_url":"https://api.github.com/users/tjarratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjarratt/subscriptions","organizations_url":"https://api.github.com/users/tjarratt/orgs","repos_url":"https://api.github.com/users/tjarratt/repos","events_url":"https://api.github.com/users/tjarratt/events{/privacy}","received_events_url":"https://api.github.com/users/tjarratt/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T05:30:43Z","updated_at":"2016-03-04T05:30:43Z","body":"Thanks for the contribution @fernandes. I'm not at all familiar with RPC encoded WSDLs, but if the tests are all still passing as they were before and this fixes something you need, then by all means.\r\n\r\nThe only downside I see to this is that the complexity of the function you changed is very, very, very high. This isn't only your fault, lots of people (myself included) have tried to have a light touch in this code, and it resulted in some of these functions growing massively over time. There's a lot of different concerns in this one method, and I don't even know how to start unraveling it at this point in time."}}