{"action":"closed","issue":{"url":"https://api.github.com/repos/dojo/core/issues/61","repository_url":"https://api.github.com/repos/dojo/core","labels_url":"https://api.github.com/repos/dojo/core/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/dojo/core/issues/61/comments","events_url":"https://api.github.com/repos/dojo/core/issues/61/events","html_url":"https://github.com/dojo/core/issues/61","id":99242945,"number":61,"title":"core/aspect#on removal?","user":{"login":"kitsonk","id":1282577,"avatar_url":"https://avatars.githubusercontent.com/u/1282577?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsonk","html_url":"https://github.com/kitsonk","followers_url":"https://api.github.com/users/kitsonk/followers","following_url":"https://api.github.com/users/kitsonk/following{/other_user}","gists_url":"https://api.github.com/users/kitsonk/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsonk/subscriptions","organizations_url":"https://api.github.com/users/kitsonk/orgs","repos_url":"https://api.github.com/users/kitsonk/repos","events_url":"https://api.github.com/users/kitsonk/events{/privacy}","received_events_url":"https://api.github.com/users/kitsonk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dojo/core/labels/discussion","name":"discussion","color":"d4c5f9"},{"url":"https://api.github.com/repos/dojo/core/labels/needs%20info","name":"needs info","color":"8657ff"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2015-08-05T16:21:49Z","updated_at":"2016-10-04T18:10:02Z","closed_at":"2016-10-04T18:10:02Z","body":"The `on` advice is not generally recognised in AOP.  The sorts of advice that are recognised are:\r\n- before\r\n- after\r\n- afterThrowing\r\n- afterFinally\r\n- around\r\n\r\nReference [Spring](http://docs.spring.io/spring/docs/current/spring-framework-reference/html/aop.html#aop-introduction-defn) and [AspectJ](https://eclipse.org/aspectj/doc/next/progguide/semantics-advice.html).\r\n\r\nFor ordering of advice, in Spring, there is the concept of [advice ordering](http://docs.spring.io/spring/docs/current/spring-framework-reference/html/aop.html#aop-ataspectj-advice-ordering) with the advice specifying an order value and the advice is applied lowest to highest.  AspectJ does this [via a directive](https://eclipse.org/aspectj/doc/next/adk15notebook/ataspectj-declare.html).\r\n\r\nTherefore I don't think we should introduce `on()` advice.  It maybe worth considering the other types of advice though.\r\n"}}
{"actor":{"display_login":"kitsonk"}}