{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/71078080","id":71078080,"diff_hunk":"@@ -183,6 +186,24 @@ public function testProcessParameterValueClassMetadata()\n         );\n     }\n \n+    /**\n+     * @group 5936\n+     */\n+    public function testProcessParameterValueEmbeddable()\n+    {\n+        $query  = $this->_em->createQuery(\"SELECT a FROM \" . DDC3597Image::class . \" a\");\n+\n+        // load class meta data\n+        $this->_em->getClassMetadata(DDC3597Image::class);\n+        $this->assertTrue($this->_em->getMetadataFactory()->hasMetadataFor(DDC3597Image::class));\n+        $this->assertTrue($this->_em->getMetadataFactory()->hasMetadataFor(DDC3597Dimension::class));\n+\n+        $this->assertInstanceOf(\n+            DDC3597Dimension::class,\n+            $query->processParameterValue(new DDC3597Dimension())\n+        );","path":"tests/Doctrine/Tests/ORM/Query/QueryTest.php","position":29,"original_position":29,"commit_id":"4d2a64a85aa0c7922500d0b5959bda4db0e88b0d","original_commit_id":"4d2a64a85aa0c7922500d0b5959bda4db0e88b0d","user":{"login":"mishal","id":24276,"avatar_url":"https://avatars.githubusercontent.com/u/24276?v=3","gravatar_id":"","url":"https://api.github.com/users/mishal","html_url":"https://github.com/mishal","followers_url":"https://api.github.com/users/mishal/followers","following_url":"https://api.github.com/users/mishal/following{/other_user}","gists_url":"https://api.github.com/users/mishal/gists{/gist_id}","starred_url":"https://api.github.com/users/mishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishal/subscriptions","organizations_url":"https://api.github.com/users/mishal/orgs","repos_url":"https://api.github.com/users/mishal/repos","events_url":"https://api.github.com/users/mishal/events{/privacy}","received_events_url":"https://api.github.com/users/mishal/received_events","type":"User","site_admin":false},"body":"I based the test on this one: https://github.com/doctrine/doctrine2/blob/master/tests/Doctrine/Tests/ORM/Query/QueryTest.php#L177","created_at":"2016-07-17T07:41:24Z","updated_at":"2016-07-17T07:41:24Z","html_url":"https://github.com/doctrine/doctrine2/pull/5937#discussion_r71078080","pull_request_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937","_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/71078080"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/5937#discussion_r71078080"},"pull_request":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937","id":77654511,"html_url":"https://github.com/doctrine/doctrine2/pull/5937","diff_url":"https://github.com/doctrine/doctrine2/pull/5937.diff","patch_url":"https://github.com/doctrine/doctrine2/pull/5937.patch","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/5937","number":5937,"state":"open","locked":false,"title":"Embeddables object as query parameter","user":{"login":"mishal","id":24276,"avatar_url":"https://avatars.githubusercontent.com/u/24276?v=3","gravatar_id":"","url":"https://api.github.com/users/mishal","html_url":"https://github.com/mishal","followers_url":"https://api.github.com/users/mishal/followers","following_url":"https://api.github.com/users/mishal/following{/other_user}","gists_url":"https://api.github.com/users/mishal/gists{/gist_id}","starred_url":"https://api.github.com/users/mishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishal/subscriptions","organizations_url":"https://api.github.com/users/mishal/orgs","repos_url":"https://api.github.com/users/mishal/repos","events_url":"https://api.github.com/users/mishal/events{/privacy}","received_events_url":"https://api.github.com/users/mishal/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-15T18:01:47Z","updated_at":"2016-07-17T07:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"492e5defd02d5bbeb62c4031b9507967fd920fa8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937/commits","review_comments_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937/comments","review_comment_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/5937/comments","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/4d2a64a85aa0c7922500d0b5959bda4db0e88b0d","head":{"label":"mishal:embeddables-query-param","ref":"embeddables-query-param","sha":"4d2a64a85aa0c7922500d0b5959bda4db0e88b0d","user":{"login":"mishal","id":24276,"avatar_url":"https://avatars.githubusercontent.com/u/24276?v=3","gravatar_id":"","url":"https://api.github.com/users/mishal","html_url":"https://github.com/mishal","followers_url":"https://api.github.com/users/mishal/followers","following_url":"https://api.github.com/users/mishal/following{/other_user}","gists_url":"https://api.github.com/users/mishal/gists{/gist_id}","starred_url":"https://api.github.com/users/mishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishal/subscriptions","organizations_url":"https://api.github.com/users/mishal/orgs","repos_url":"https://api.github.com/users/mishal/repos","events_url":"https://api.github.com/users/mishal/events{/privacy}","received_events_url":"https://api.github.com/users/mishal/received_events","type":"User","site_admin":false},"repo":{"id":63414046,"name":"doctrine2","full_name":"mishal/doctrine2","owner":{"login":"mishal","id":24276,"avatar_url":"https://avatars.githubusercontent.com/u/24276?v=3","gravatar_id":"","url":"https://api.github.com/users/mishal","html_url":"https://github.com/mishal","followers_url":"https://api.github.com/users/mishal/followers","following_url":"https://api.github.com/users/mishal/following{/other_user}","gists_url":"https://api.github.com/users/mishal/gists{/gist_id}","starred_url":"https://api.github.com/users/mishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishal/subscriptions","organizations_url":"https://api.github.com/users/mishal/orgs","repos_url":"https://api.github.com/users/mishal/repos","events_url":"https://api.github.com/users/mishal/events{/privacy}","received_events_url":"https://api.github.com/users/mishal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishal/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":true,"url":"https://api.github.com/repos/mishal/doctrine2","forks_url":"https://api.github.com/repos/mishal/doctrine2/forks","keys_url":"https://api.github.com/repos/mishal/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishal/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishal/doctrine2/teams","hooks_url":"https://api.github.com/repos/mishal/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/mishal/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/mishal/doctrine2/events","assignees_url":"https://api.github.com/repos/mishal/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/mishal/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/mishal/doctrine2/tags","blobs_url":"https://api.github.com/repos/mishal/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishal/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishal/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishal/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishal/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/mishal/doctrine2/languages","stargazers_url":"https://api.github.com/repos/mishal/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/mishal/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/mishal/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/mishal/doctrine2/subscription","commits_url":"https://api.github.com/repos/mishal/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishal/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishal/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishal/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishal/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/mishal/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishal/doctrine2/merges","archive_url":"https://api.github.com/repos/mishal/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishal/doctrine2/downloads","issues_url":"https://api.github.com/repos/mishal/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/mishal/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/mishal/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/mishal/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishal/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/mishal/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/mishal/doctrine2/deployments","created_at":"2016-07-15T10:32:40Z","updated_at":"2016-07-15T10:32:45Z","pushed_at":"2016-07-15T12:03:14Z","git_url":"git://github.com/mishal/doctrine2.git","ssh_url":"git@github.com:mishal/doctrine2.git","clone_url":"https://github.com/mishal/doctrine2.git","svn_url":"https://github.com/mishal/doctrine2","homepage":"http://www.doctrine-project.org","size":27742,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"2b476708311b6003881a0cb944ca8c1bf996d58a","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":597887,"name":"doctrine2","full_name":"doctrine/doctrine2","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":false,"url":"https://api.github.com/repos/doctrine/doctrine2","forks_url":"https://api.github.com/repos/doctrine/doctrine2/forks","keys_url":"https://api.github.com/repos/doctrine/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/doctrine2/teams","hooks_url":"https://api.github.com/repos/doctrine/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/doctrine2/events","assignees_url":"https://api.github.com/repos/doctrine/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/doctrine2/tags","blobs_url":"https://api.github.com/repos/doctrine/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/doctrine2/languages","stargazers_url":"https://api.github.com/repos/doctrine/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/doctrine/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/doctrine/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/doctrine/doctrine2/subscription","commits_url":"https://api.github.com/repos/doctrine/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/doctrine2/merges","archive_url":"https://api.github.com/repos/doctrine/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/doctrine2/downloads","issues_url":"https://api.github.com/repos/doctrine/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/doctrine2/deployments","created_at":"2010-04-06T21:42:59Z","updated_at":"2016-07-16T19:55:11Z","pushed_at":"2016-07-16T11:43:22Z","git_url":"git://github.com/doctrine/doctrine2.git","ssh_url":"git@github.com:doctrine/doctrine2.git","clone_url":"https://github.com/doctrine/doctrine2.git","svn_url":"https://github.com/doctrine/doctrine2","homepage":"http://www.doctrine-project.org","size":37902,"stargazers_count":3126,"watchers_count":3126,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1534,"mirror_url":null,"open_issues_count":1071,"forks":1534,"open_issues":1071,"watchers":3126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/5937"},"issue":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/5937"},"comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/5937/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5937/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/doctrine2/statuses/4d2a64a85aa0c7922500d0b5959bda4db0e88b0d"}}}}
{"actor":{"display_login":"mishal"}}