{"action":"created","comment":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/84134829","pull_request_review_id":4931517,"id":84134829,"diff_hunk":"@@ -40,5 +40,13 @@ $backend = new BackendInit($kernel);\n $backend->initialize('Console');\n \n $application = new Application($kernel);\n-$application->add(new \\Common\\Command\\ImportLocaleCommand());\n+$application->add(new \\Console\\Locale\\ImportLocaleCommand());\n+if ($kernel->getContainer()->getParameter('site.multilanguage')) {","path":"app/console","position":6,"original_position":6,"commit_id":"292a0bd7a3a78168b166fa88e290189738ea2974","original_commit_id":"292a0bd7a3a78168b166fa88e290189738ea2974","user":{"login":"jeroendesloovere","id":588616,"avatar_url":"https://avatars.githubusercontent.com/u/588616?v=3","gravatar_id":"","url":"https://api.github.com/users/jeroendesloovere","html_url":"https://github.com/jeroendesloovere","followers_url":"https://api.github.com/users/jeroendesloovere/followers","following_url":"https://api.github.com/users/jeroendesloovere/following{/other_user}","gists_url":"https://api.github.com/users/jeroendesloovere/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroendesloovere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroendesloovere/subscriptions","organizations_url":"https://api.github.com/users/jeroendesloovere/orgs","repos_url":"https://api.github.com/users/jeroendesloovere/repos","events_url":"https://api.github.com/users/jeroendesloovere/events{/privacy}","received_events_url":"https://api.github.com/users/jeroendesloovere/received_events","type":"User","site_admin":false},"body":"@carakas, wouldn't it be better to enable the `\\Console\\Locale\\EnableLocaleCommand` and integrate the \"site.multilanguage\" check in there, so you can throw an error to let people know they have to change the parameter... ? ","created_at":"2016-10-19T18:21:55Z","updated_at":"2016-10-19T18:26:29Z","html_url":"https://github.com/forkcms/forkcms/pull/1766#discussion_r84134829","pull_request_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1766","_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/84134829"},"html":{"href":"https://github.com/forkcms/forkcms/pull/1766#discussion_r84134829"},"pull_request":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1766"}}},"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/1766","id":88285596,"html_url":"https://github.com/forkcms/forkcms/pull/1766","diff_url":"https://github.com/forkcms/forkcms/pull/1766.diff","patch_url":"https://github.com/forkcms/forkcms/pull/1766.patch","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/1766","number":1766,"state":"open","locked":false,"title":"command to enable a locale","user":{"login":"carakas","id":3634654,"avatar_url":"https://avatars.githubusercontent.com/u/3634654?v=3","gravatar_id":"","url":"https://api.github.com/users/carakas","html_url":"https://github.com/carakas","followers_url":"https://api.github.com/users/carakas/followers","following_url":"https://api.github.com/users/carakas/following{/other_user}","gists_url":"https://api.github.com/users/carakas/gists{/gist_id}","starred_url":"https://api.github.com/users/carakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carakas/subscriptions","organizations_url":"https://api.github.com/users/carakas/orgs","repos_url":"https://api.github.com/users/carakas/repos","events_url":"https://api.github.com/users/carakas/events{/privacy}","received_events_url":"https://api.github.com/users/carakas/received_events","type":"User","site_admin":false},"body":"## Type\r\n\r\n- Feature\r\n\r\n## Resolves the following issues\r\n\r\nimplements a command for #1715\r\n\r\n## Pull request description\r\n\r\nAdds a command to enable/install a locale\r\n\r\nalso adds the option to only import a translation for a specific locale\r\n\r\n<img width=\"886\" alt=\"locale overview\" src=\"https://cloud.githubusercontent.com/assets/3634654/19173392/69855a52-8c27-11e6-9e65-ef437efb7041.png\">\r\n\r\n<img width=\"869\" alt=\"locale enable process\" src=\"https://cloud.githubusercontent.com/assets/3634654/19173393/6985c14a-8c27-11e6-9757-b207dcff1bc5.png\">\r\n\r\n","created_at":"2016-10-06T15:30:04Z","updated_at":"2016-10-19T18:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ed2be12349b85056786aa52725a1b9c35556921","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/forkcms/forkcms/milestones/22","html_url":"https://github.com/forkcms/forkcms/milestones/4.3.0","labels_url":"https://api.github.com/repos/forkcms/forkcms/milestones/22/labels","id":1959880,"number":22,"title":"4.3.0","description":null,"creator":{"login":"carakas","id":3634654,"avatar_url":"https://avatars.githubusercontent.com/u/3634654?v=3","gravatar_id":"","url":"https://api.github.com/users/carakas","html_url":"https://github.com/carakas","followers_url":"https://api.github.com/users/carakas/followers","following_url":"https://api.github.com/users/carakas/following{/other_user}","gists_url":"https://api.github.com/users/carakas/gists{/gist_id}","starred_url":"https://api.github.com/users/carakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carakas/subscriptions","organizations_url":"https://api.github.com/users/carakas/orgs","repos_url":"https://api.github.com/users/carakas/repos","events_url":"https://api.github.com/users/carakas/events{/privacy}","received_events_url":"https://api.github.com/users/carakas/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":2,"state":"open","created_at":"2016-08-24T07:40:11Z","updated_at":"2016-10-19T15:35:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1766/commits","review_comments_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1766/comments","review_comment_url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/1766/comments","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/292a0bd7a3a78168b166fa88e290189738ea2974","head":{"label":"justcarakas:1715-command-to-enable-a-language","ref":"1715-command-to-enable-a-language","sha":"292a0bd7a3a78168b166fa88e290189738ea2974","user":{"login":"justcarakas","id":11027428,"avatar_url":"https://avatars.githubusercontent.com/u/11027428?v=3","gravatar_id":"","url":"https://api.github.com/users/justcarakas","html_url":"https://github.com/justcarakas","followers_url":"https://api.github.com/users/justcarakas/followers","following_url":"https://api.github.com/users/justcarakas/following{/other_user}","gists_url":"https://api.github.com/users/justcarakas/gists{/gist_id}","starred_url":"https://api.github.com/users/justcarakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justcarakas/subscriptions","organizations_url":"https://api.github.com/users/justcarakas/orgs","repos_url":"https://api.github.com/users/justcarakas/repos","events_url":"https://api.github.com/users/justcarakas/events{/privacy}","received_events_url":"https://api.github.com/users/justcarakas/received_events","type":"Organization","site_admin":false},"repo":{"id":30862709,"name":"forkcms","full_name":"justcarakas/forkcms","owner":{"login":"justcarakas","id":11027428,"avatar_url":"https://avatars.githubusercontent.com/u/11027428?v=3","gravatar_id":"","url":"https://api.github.com/users/justcarakas","html_url":"https://github.com/justcarakas","followers_url":"https://api.github.com/users/justcarakas/followers","following_url":"https://api.github.com/users/justcarakas/following{/other_user}","gists_url":"https://api.github.com/users/justcarakas/gists{/gist_id}","starred_url":"https://api.github.com/users/justcarakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justcarakas/subscriptions","organizations_url":"https://api.github.com/users/justcarakas/orgs","repos_url":"https://api.github.com/users/justcarakas/repos","events_url":"https://api.github.com/users/justcarakas/events{/privacy}","received_events_url":"https://api.github.com/users/justcarakas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/justcarakas/forkcms","description":"Fork is an open source CMS.","fork":true,"url":"https://api.github.com/repos/justcarakas/forkcms","forks_url":"https://api.github.com/repos/justcarakas/forkcms/forks","keys_url":"https://api.github.com/repos/justcarakas/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justcarakas/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justcarakas/forkcms/teams","hooks_url":"https://api.github.com/repos/justcarakas/forkcms/hooks","issue_events_url":"https://api.github.com/repos/justcarakas/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/justcarakas/forkcms/events","assignees_url":"https://api.github.com/repos/justcarakas/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/justcarakas/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/justcarakas/forkcms/tags","blobs_url":"https://api.github.com/repos/justcarakas/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justcarakas/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justcarakas/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/justcarakas/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justcarakas/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/justcarakas/forkcms/languages","stargazers_url":"https://api.github.com/repos/justcarakas/forkcms/stargazers","contributors_url":"https://api.github.com/repos/justcarakas/forkcms/contributors","subscribers_url":"https://api.github.com/repos/justcarakas/forkcms/subscribers","subscription_url":"https://api.github.com/repos/justcarakas/forkcms/subscription","commits_url":"https://api.github.com/repos/justcarakas/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/justcarakas/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/justcarakas/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/justcarakas/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/justcarakas/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/justcarakas/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justcarakas/forkcms/merges","archive_url":"https://api.github.com/repos/justcarakas/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justcarakas/forkcms/downloads","issues_url":"https://api.github.com/repos/justcarakas/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/justcarakas/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/justcarakas/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/justcarakas/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justcarakas/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/justcarakas/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/justcarakas/forkcms/deployments","created_at":"2015-02-16T10:05:25Z","updated_at":"2016-03-14T08:12:31Z","pushed_at":"2016-10-19T15:58:43Z","git_url":"git://github.com/justcarakas/forkcms.git","ssh_url":"git@github.com:justcarakas/forkcms.git","clone_url":"https://github.com/justcarakas/forkcms.git","svn_url":"https://github.com/justcarakas/forkcms","homepage":"http://www.fork-cms.com","size":43408,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forkcms:master","ref":"master","sha":"62c5dee34f26c59e3107044aa993e7bb6ca09c65","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an easy to use open source CMS using Symfony Components.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/forkcms/forkcms/deployments","created_at":"2010-12-04T18:06:15Z","updated_at":"2016-10-18T04:55:45Z","pushed_at":"2016-10-19T18:08:34Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":63784,"stargazers_count":934,"watchers_count":934,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":240,"mirror_url":null,"open_issues_count":56,"forks":240,"open_issues":56,"watchers":934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1766"},"html":{"href":"https://github.com/forkcms/forkcms/pull/1766"},"issue":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1766"},"comments":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1766/comments"},"review_comments":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1766/comments"},"review_comment":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1766/commits"},"statuses":{"href":"https://api.github.com/repos/forkcms/forkcms/statuses/292a0bd7a3a78168b166fa88e290189738ea2974"}}}}
{"actor":{"display_login":"jeroendesloovere"}}