{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/html/issues/1681","repository_url":"https://api.github.com/repos/whatwg/html","labels_url":"https://api.github.com/repos/whatwg/html/issues/1681/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/html/issues/1681/comments","events_url":"https://api.github.com/repos/whatwg/html/issues/1681/events","html_url":"https://github.com/whatwg/html/issues/1681","id":171524936,"number":1681,"title":"'none' value for CanvasFilters.filter should probably be case insensitive, and certainly be explicit about case","user":{"login":"dbaron","id":248721,"avatar_url":"https://avatars.githubusercontent.com/u/248721?v=3","gravatar_id":"","url":"https://api.github.com/users/dbaron","html_url":"https://github.com/dbaron","followers_url":"https://api.github.com/users/dbaron/followers","following_url":"https://api.github.com/users/dbaron/following{/other_user}","gists_url":"https://api.github.com/users/dbaron/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaron/subscriptions","organizations_url":"https://api.github.com/users/dbaron/orgs","repos_url":"https://api.github.com/users/dbaron/repos","events_url":"https://api.github.com/users/dbaron/events{/privacy}","received_events_url":"https://api.github.com/users/dbaron/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/whatwg/html/labels/topic:%20canvas","name":"topic: canvas","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"junov","id":2607864,"avatar_url":"https://avatars.githubusercontent.com/u/2607864?v=3","gravatar_id":"","url":"https://api.github.com/users/junov","html_url":"https://github.com/junov","followers_url":"https://api.github.com/users/junov/followers","following_url":"https://api.github.com/users/junov/following{/other_user}","gists_url":"https://api.github.com/users/junov/gists{/gist_id}","starred_url":"https://api.github.com/users/junov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junov/subscriptions","organizations_url":"https://api.github.com/users/junov/orgs","repos_url":"https://api.github.com/users/junov/repos","events_url":"https://api.github.com/users/junov/events{/privacy}","received_events_url":"https://api.github.com/users/junov/received_events","type":"User","site_admin":false},"assignees":[{"login":"junov","id":2607864,"avatar_url":"https://avatars.githubusercontent.com/u/2607864?v=3","gravatar_id":"","url":"https://api.github.com/users/junov","html_url":"https://github.com/junov","followers_url":"https://api.github.com/users/junov/followers","following_url":"https://api.github.com/users/junov/following{/other_user}","gists_url":"https://api.github.com/users/junov/gists{/gist_id}","starred_url":"https://api.github.com/users/junov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junov/subscriptions","organizations_url":"https://api.github.com/users/junov/orgs","repos_url":"https://api.github.com/users/junov/repos","events_url":"https://api.github.com/users/junov/events{/privacy}","received_events_url":"https://api.github.com/users/junov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-08-16T21:40:54Z","updated_at":"2016-08-17T16:44:47Z","closed_at":null,"body":"The [definition of CanvasFilters.filter](https://html.spec.whatwg.org/multipage/scripting.html#filters) currently defines the 'none' value as:\r\n> On setting, if the new value is 'none' (not the empty string, null, or undefined), filters must be disabled for the context.\r\n\r\nThis doesn't mention case sensitivity, which I presume means that it's case-sensitive.\r\n\r\nHowever, the 'none' value here is essentially CSS syntax; it's an alternative to &lt;filter-function-list&gt;, which is explicitly CSS syntax, and CSS syntax is case insensitive.\r\n\r\nIt seems to me that given that the rest of the filter syntax is CSS syntax, the rule for setting the 'none' value should specify that it's a case-*in*sensitive match for 'none'.  Either way, though, it ought to be explicitly specified, given that I could see an implementor getting it wrong in either direction.\r\n\r\n(Yes, canvas is generally odd this way.  Attributes that use CSS syntax, like [fillStyle](https://html.spec.whatwg.org/multipage/scripting.html#fill-and-stroke-styles), are case insensitive, while other attributes like [textAlign](https://html.spec.whatwg.org/multipage/scripting.html#text-styles) are not.  See [test that you can fiddle with](http://software.hixie.ch/utilities/js/live-dom-viewer/?%3C!DOCTYPE%20html%3E%0A%3Ccanvas%20id%3D%22c%22%20style%3D%22border%3A%20medium%20solid%20fuchsia%3B%22%3E%0A%3C%2Fcanvas%3E%0A%3Cscript%3E%0Avar%20cx%20%3D%20document.getElementById(%22c%22).getContext(%222d%22)%3B%0Acx.fillStyle%20%3D%20%22RGB(0%2C%200%2C%20255)%22%3B%0Acx.fillRect(10%2C%2010%2C%2050%2C%2050)%3B%0Acx.textAlign%20%3D%20%22end%22%3B%0Acx.fillText(%22hello%22%2C%2075%2C%2075)%3B%0A%3C%2Fscript%3E).)\r\n\r\n(I'm reviewing this for https://github.com/w3ctag/spec-reviews/issues/116 .)"},"comment":{"url":"https://api.github.com/repos/whatwg/html/issues/comments/240472542","html_url":"https://github.com/whatwg/html/issues/1681#issuecomment-240472542","issue_url":"https://api.github.com/repos/whatwg/html/issues/1681","id":240472542,"user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars.githubusercontent.com/u/1544111?v=3","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T16:44:47Z","updated_at":"2016-08-17T16:44:47Z","body":"Fair, if parsing that can return the none token that seems fine too and probably better.\r\n\r\n(As for your other idea, we already support escapes in places, such as media, prolly not worth it to add more branches.)"}}
{"actor":{"display_login":"annevk"}}