{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/68791566","id":68791566,"diff_hunk":"@@ -44,29 +44,38 @@ export class OfflineCompiler {\n   constructor(\n       private _directiveNormalizer: DirectiveNormalizer, private _templateParser: TemplateParser,\n       private _styleCompiler: StyleCompiler, private _viewCompiler: ViewCompiler,\n-      private _outputEmitter: OutputEmitter, private _xhr: XHR) {}\n+      private _outputEmitter: OutputEmitter) {}\n \n   normalizeDirectiveMetadata(directive: CompileDirectiveMetadata):\n       Promise<CompileDirectiveMetadata> {\n-    return this._directiveNormalizer.normalizeDirective(directive);\n+    return this._directiveNormalizer.normalizeDirective(directive).asyncResult;\n   }\n \n-  compileTemplates(components: NormalizedComponentWithViewDirectives[]): SourceModule {\n+  compileTemplates(components: NormalizedComponentWithViewDirectives[]): SourceModule[] {\n     if (components.length === 0) {\n       throw new BaseException('No components given');\n     }\n     var statements: o.DeclareVarStmt[] = [];\n     var exportedVars: string[] = [];\n     var moduleUrl = _ngfactoryModuleUrl(components[0].component.type);\n+    var outputSourceModules: SourceModule[] = [];\n     components.forEach(componentWithDirs => {\n       var compMeta = <CompileDirectiveMetadata>componentWithDirs.component;\n       _assertComponent(compMeta);\n+      var fileSuffix = _splitSuffix(compMeta.type.moduleUrl)[1];","path":"modules/@angular/compiler/src/offline_compiler.ts","position":34,"original_position":34,"commit_id":"1d3f0c8104b52dce2d74aee833eaf44a4c71ea5a","original_commit_id":"1d3f0c8104b52dce2d74aee833eaf44a4c71ea5a","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"Rename `_splitSuffix` into `_splitLastSuffix`","created_at":"2016-06-28T16:24:46Z","updated_at":"2016-06-28T16:24:46Z","html_url":"https://github.com/angular/angular/pull/9594#discussion_r68791566","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/9594","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/68791566"},"html":{"href":"https://github.com/angular/angular/pull/9594#discussion_r68791566"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/9594"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/9594","id":75190902,"html_url":"https://github.com/angular/angular/pull/9594","diff_url":"https://github.com/angular/angular/pull/9594.diff","patch_url":"https://github.com/angular/angular/pull/9594.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/9594","number":9594,"state":"open","locked":false,"title":"Synchronous compile","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-25T00:54:59Z","updated_at":"2016-06-28T16:24:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3eba120c2b39339d0d7a0915915896590be15b99","assignee":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"assignees":[{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/9594/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/9594/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/9594/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/1d3f0c8104b52dce2d74aee833eaf44a4c71ea5a","head":{"label":"tbosch:sync_compile","ref":"sync_compile","sha":"1d3f0c8104b52dce2d74aee833eaf44a4c71ea5a","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"repo":{"id":24733374,"name":"angular","full_name":"tbosch/angular","owner":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbosch/angular","description":"","fork":true,"url":"https://api.github.com/repos/tbosch/angular","forks_url":"https://api.github.com/repos/tbosch/angular/forks","keys_url":"https://api.github.com/repos/tbosch/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbosch/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbosch/angular/teams","hooks_url":"https://api.github.com/repos/tbosch/angular/hooks","issue_events_url":"https://api.github.com/repos/tbosch/angular/issues/events{/number}","events_url":"https://api.github.com/repos/tbosch/angular/events","assignees_url":"https://api.github.com/repos/tbosch/angular/assignees{/user}","branches_url":"https://api.github.com/repos/tbosch/angular/branches{/branch}","tags_url":"https://api.github.com/repos/tbosch/angular/tags","blobs_url":"https://api.github.com/repos/tbosch/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbosch/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbosch/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbosch/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbosch/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/tbosch/angular/languages","stargazers_url":"https://api.github.com/repos/tbosch/angular/stargazers","contributors_url":"https://api.github.com/repos/tbosch/angular/contributors","subscribers_url":"https://api.github.com/repos/tbosch/angular/subscribers","subscription_url":"https://api.github.com/repos/tbosch/angular/subscription","commits_url":"https://api.github.com/repos/tbosch/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbosch/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbosch/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbosch/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbosch/angular/contents/{+path}","compare_url":"https://api.github.com/repos/tbosch/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbosch/angular/merges","archive_url":"https://api.github.com/repos/tbosch/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbosch/angular/downloads","issues_url":"https://api.github.com/repos/tbosch/angular/issues{/number}","pulls_url":"https://api.github.com/repos/tbosch/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/tbosch/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/tbosch/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbosch/angular/labels{/name}","releases_url":"https://api.github.com/repos/tbosch/angular/releases{/id}","deployments_url":"https://api.github.com/repos/tbosch/angular/deployments","created_at":"2014-10-02T19:30:59Z","updated_at":"2015-06-02T21:15:59Z","pushed_at":"2016-06-28T15:32:36Z","git_url":"git://github.com/tbosch/angular.git","ssh_url":"git@github.com:tbosch/angular.git","clone_url":"https://github.com/tbosch/angular.git","svn_url":"https://github.com/tbosch/angular","homepage":null,"size":32629,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"24eb8389d21707f198a19a4fad1db7b0330ec8ea","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-06-28T16:10:21Z","pushed_at":"2016-06-28T15:32:37Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":655396,"stargazers_count":13304,"watchers_count":13304,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3436,"mirror_url":null,"open_issues_count":1398,"forks":3436,"open_issues":1398,"watchers":13304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/9594"},"html":{"href":"https://github.com/angular/angular/pull/9594"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/9594"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/9594/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/9594/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/9594/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/1d3f0c8104b52dce2d74aee833eaf44a4c71ea5a"}}}}
{"actor":{"display_login":"tbosch"}}