{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8791","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8791/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8791/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8791/events","html_url":"https://github.com/nodejs/node/pull/8791","id":179268699,"number":8791,"title":"addin test for _stream.writable finished state","user":{"login":"italoacasas","id":6354455,"avatar_url":"https://avatars.githubusercontent.com/u/6354455?v=3","gravatar_id":"","url":"https://api.github.com/users/italoacasas","html_url":"https://github.com/italoacasas","followers_url":"https://api.github.com/users/italoacasas/followers","following_url":"https://api.github.com/users/italoacasas/following{/other_user}","gists_url":"https://api.github.com/users/italoacasas/gists{/gist_id}","starred_url":"https://api.github.com/users/italoacasas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/italoacasas/subscriptions","organizations_url":"https://api.github.com/users/italoacasas/orgs","repos_url":"https://api.github.com/users/italoacasas/repos","events_url":"https://api.github.com/users/italoacasas/events{/privacy}","received_events_url":"https://api.github.com/users/italoacasas/received_events","type":"User","site_admin":false},"labels":[{"id":155435883,"url":"https://api.github.com/repos/nodejs/node/labels/stream","name":"stream","color":"c7def8","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"closed","locked":false,"assignee":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"assignees":[{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-09-26T15:58:42Z","updated_at":"2016-10-28T06:31:25Z","closed_at":"2016-10-28T06:31:25Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8791","html_url":"https://github.com/nodejs/node/pull/8791","diff_url":"https://github.com/nodejs/node/pull/8791.diff","patch_url":"https://github.com/nodejs/node/pull/8791.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n- Adding tests for stream._writableState.finished\r\n\r\nIssue related: #8686 "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/256846566","html_url":"https://github.com/nodejs/node/pull/8791#issuecomment-256846566","issue_url":"https://api.github.com/repos/nodejs/node/issues/8791","id":256846566,"user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T06:31:25Z","updated_at":"2016-10-28T06:31:25Z","body":"Merged in 6cf2726"}}
{"actor":{"display_login":"mcollina"}}