{"action":"created","issue":{"url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin/issues/68","repository_url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin","labels_url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin/issues/68/comments","events_url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin/issues/68/events","html_url":"https://github.com/heroku/heroku-kafka-jsplugin/pull/68","id":170277228,"number":68,"title":"Address CLI review issues","user":{"login":"uhoh-itsmaciek","id":159100,"avatar_url":"https://avatars.githubusercontent.com/u/159100?v=3","gravatar_id":"","url":"https://api.github.com/users/uhoh-itsmaciek","html_url":"https://github.com/uhoh-itsmaciek","followers_url":"https://api.github.com/users/uhoh-itsmaciek/followers","following_url":"https://api.github.com/users/uhoh-itsmaciek/following{/other_user}","gists_url":"https://api.github.com/users/uhoh-itsmaciek/gists{/gist_id}","starred_url":"https://api.github.com/users/uhoh-itsmaciek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uhoh-itsmaciek/subscriptions","organizations_url":"https://api.github.com/users/uhoh-itsmaciek/orgs","repos_url":"https://api.github.com/users/uhoh-itsmaciek/repos","events_url":"https://api.github.com/users/uhoh-itsmaciek/events{/privacy}","received_events_url":"https://api.github.com/users/uhoh-itsmaciek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-09T21:37:28Z","updated_at":"2016-08-22T17:10:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin/pulls/68","html_url":"https://github.com/heroku/heroku-kafka-jsplugin/pull/68","diff_url":"https://github.com/heroku/heroku-kafka-jsplugin/pull/68.diff","patch_url":"https://github.com/heroku/heroku-kafka-jsplugin/pull/68.patch"},"body":"- [x] should use same resolver as `heroku-pg`\r\n- [x] `kafka:wait` should work like `pg:wait`\r\n- [x] `kafka:info` should work like `pg:info`\r\n- [ ] `kafka:configure` -> `kafka:topics:compaction`\r\n- [ ] `kafka:configure` -> `kafka:topics:retention-time`\r\n- [ ] `kafka:configure` -> `kafka:topics:replication-factor`\r\n- [x] `kafka:zookeeper`\r\n- [x] `kafka:jmx`\r\n- [x] `kafka:create` -> `kafka:topics:create`\r\n- [x] `kafka:delete` -> `kafka:topics:delete`\r\n- [x] `kafka:list` -> `kafka:topics`\r\n- [x] `kafka:topic` -> `kafka:topics:info`\r\n- [x] `kafka:tail` -> `kafka:topics:tail`\r\n- [x] `kafka:write` -> `kafka:topics:write`\r\n- [x] un-hide `kafka:upgrade` for kafka version upgrades\r\n\r\nExtras:\r\n\r\n- [ ] replace `printWaitingDots` hack with `cli.action`\r\n- [ ] resolver should be extracted, made parameterizable, and shared across between this plugin and `heroku-pg`\r\n- [ ] use `cli.log` and `cli.error` instead of `console.log` and `process.stdout.write` where possible"},"comment":{"url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin/issues/comments/241481853","html_url":"https://github.com/heroku/heroku-kafka-jsplugin/pull/68#issuecomment-241481853","issue_url":"https://api.github.com/repos/heroku/heroku-kafka-jsplugin/issues/68","id":241481853,"user":{"login":"uhoh-itsmaciek","id":159100,"avatar_url":"https://avatars.githubusercontent.com/u/159100?v=3","gravatar_id":"","url":"https://api.github.com/users/uhoh-itsmaciek","html_url":"https://github.com/uhoh-itsmaciek","followers_url":"https://api.github.com/users/uhoh-itsmaciek/followers","following_url":"https://api.github.com/users/uhoh-itsmaciek/following{/other_user}","gists_url":"https://api.github.com/users/uhoh-itsmaciek/gists{/gist_id}","starred_url":"https://api.github.com/users/uhoh-itsmaciek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uhoh-itsmaciek/subscriptions","organizations_url":"https://api.github.com/users/uhoh-itsmaciek/orgs","repos_url":"https://api.github.com/users/uhoh-itsmaciek/repos","events_url":"https://api.github.com/users/uhoh-itsmaciek/events{/privacy}","received_events_url":"https://api.github.com/users/uhoh-itsmaciek/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T17:10:52Z","updated_at":"2016-08-22T17:10:52Z","body":"Should we use a more concise `kafka:topics:retention` and `kafka:topics:replication` instead of `kafka:topics:retention-time` and `kafka:topics-replication-factor`? I don't think that introduces any ambiguity..."}}
{"actor":{"display_login":"uhoh-itsmaciek"}}