{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/25337","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/25337/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/25337/comments","events_url":"https://api.github.com/repos/docker/docker/issues/25337/events","html_url":"https://github.com/docker/docker/pull/25337","id":168930119,"number":25337,"title":"Add --no-trunc to service/node/stack ps output","user":{"login":"jhorwit2","id":3876739,"avatar_url":"https://avatars.githubusercontent.com/u/3876739?v=3","gravatar_id":"","url":"https://api.github.com/users/jhorwit2","html_url":"https://github.com/jhorwit2","followers_url":"https://api.github.com/users/jhorwit2/followers","following_url":"https://api.github.com/users/jhorwit2/following{/other_user}","gists_url":"https://api.github.com/users/jhorwit2/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorwit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorwit2/subscriptions","organizations_url":"https://api.github.com/users/jhorwit2/orgs","repos_url":"https://api.github.com/users/jhorwit2/repos","events_url":"https://api.github.com/users/jhorwit2/events{/privacy}","received_events_url":"https://api.github.com/users/jhorwit2/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-02T16:29:32Z","updated_at":"2016-08-02T17:03:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/25337","html_url":"https://github.com/docker/docker/pull/25337","diff_url":"https://github.com/docker/docker/pull/25337.diff","patch_url":"https://github.com/docker/docker/pull/25337.patch"},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\ncloses #25332\r\n\r\n**- What I did**\r\n\r\nAdded `--no-trunc` option like `docker ps` has to `docker service ps`, `docker node ps` and `docker stack ps`. Currently only errors were being truncated. \r\n\r\n**- How I did it**\r\n\r\nAdded cli option to the 3 commands & check for it in `task.Print`\r\n\r\n**- How to verify it**\r\n\r\nCreate a service that has tasks that error out -> run `docker node ps self --no-trunc` to see the full error. \r\n\r\n```\r\n$ docker swarm init\r\n$ echo 'FROM busybox \\\r\n      HEALTHCHECK --interval=1s --timeout=1s CMD ls /foo \\\r\n     CMD top' | docker build -t test_none -\r\n\r\n$ docker service create --name test test_none\r\n1ktygqey58cgpz43p54tl35e3\r\n\r\n$ docker node ps self\r\nID                         NAME        IMAGE      NODE          DESIRED STATE  CURRENT STATE         ERROR\r\n4nb1pvcty3a7co574cg6kscaf  test.1      test_none  e96bbd330fee  Ready          Ready 1 seconds ago\r\n7fjobb83ee0k3dmxfky0qalpd   \\_ test.1  test_none  e96bbd330fee  Shutdown       Failed 2 seconds ago  \"task: non-zero exit (137): do…\"\r\n\r\n$ docker node ps self --no-trunc\r\nID                         NAME        IMAGE      NODE          DESIRED STATE  CURRENT STATE           ERROR\r\n4nb1pvcty3a7co574cg6kscaf  test.1      test_none  e96bbd330fee  Running        Starting 1 seconds ago\r\n7fjobb83ee0k3dmxfky0qalpd   \\_ test.1  test_none  e96bbd330fee  Shutdown       Failed 6 seconds ago    \"task: non-zero exit (137): dockerexec: unhealthy container\"\r\n\r\n$ docker service ps test --no-trunc\r\nID                         NAME        IMAGE      NODE          DESIRED STATE  CURRENT STATE           ERROR\r\n279eltuipxm8sbz19syl8a1o9  test.1      test_none  e96bbd330fee  Running        Starting 4 seconds ago\r\n4nb1pvcty3a7co574cg6kscaf   \\_ test.1  test_none  e96bbd330fee  Shutdown       Failed 9 seconds ago    \"task: non-zero exit (137): dockerexec: unhealthy container\"\r\n7fjobb83ee0k3dmxfky0qalpd   \\_ test.1  test_none  e96bbd330fee  Shutdown       Failed 28 seconds ago   \"task: non-zero exit (137): dockerexec: unhealthy container\"\r\n```\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\nAdd --no-trunc to service/node/stack ps output\r\n\r\n\r\n\r\nSigned-off-by: Josh Horwitz <horwitzja@gmail.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/236971155","html_url":"https://github.com/docker/docker/pull/25337#issuecomment-236971155","issue_url":"https://api.github.com/repos/docker/docker/issues/25337","id":236971155,"user":{"login":"jhorwit2","id":3876739,"avatar_url":"https://avatars.githubusercontent.com/u/3876739?v=3","gravatar_id":"","url":"https://api.github.com/users/jhorwit2","html_url":"https://github.com/jhorwit2","followers_url":"https://api.github.com/users/jhorwit2/followers","following_url":"https://api.github.com/users/jhorwit2/following{/other_user}","gists_url":"https://api.github.com/users/jhorwit2/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorwit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorwit2/subscriptions","organizations_url":"https://api.github.com/users/jhorwit2/orgs","repos_url":"https://api.github.com/users/jhorwit2/repos","events_url":"https://api.github.com/users/jhorwit2/events{/privacy}","received_events_url":"https://api.github.com/users/jhorwit2/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T17:03:32Z","updated_at":"2016-08-02T17:03:32Z","body":"@vdemeester Although that's the only thing `docker ps` truncates currently the docs don't specify that. It only says `--no-trunc        Don't truncate output`"}}
{"actor":{"display_login":"jhorwit2"}}