{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/comments/82534366","pull_request_review_id":3435872,"id":82534366,"diff_hunk":"@@ -163,3 +163,11 @@ end\n         return a\n     end\n end\n+\n+Base.min{T1<:Real,T2<:Real}(a::StaticArray{T1}, b::StaticArray{T2}) = _min(promote(a, b)...)","path":"src/arraymath.jl","position":5,"original_position":5,"commit_id":"49ff2ee11e066acc114cfe6698a8dd5e6d59fa58","original_commit_id":"49ff2ee11e066acc114cfe6698a8dd5e6d59fa58","user":{"login":"andyferris","id":2974526,"avatar_url":"https://avatars.githubusercontent.com/u/2974526?v=3","gravatar_id":"","url":"https://api.github.com/users/andyferris","html_url":"https://github.com/andyferris","followers_url":"https://api.github.com/users/andyferris/followers","following_url":"https://api.github.com/users/andyferris/following{/other_user}","gists_url":"https://api.github.com/users/andyferris/gists{/gist_id}","starred_url":"https://api.github.com/users/andyferris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyferris/subscriptions","organizations_url":"https://api.github.com/users/andyferris/orgs","repos_url":"https://api.github.com/users/andyferris/repos","events_url":"https://api.github.com/users/andyferris/events{/privacy}","received_events_url":"https://api.github.com/users/andyferris/received_events","type":"User","site_admin":false},"body":"Hmm... the definition of `min` here is just plain *odd*. I see now that `Base` defines this, but wouldn't `min.(a, b)` work better and semantically make *much* more sense? And codegen for this is already great with *StaticArrays*.\r\n\r\nPersonally, I see this as one of the autovectorization operations that accidentally has not been pruned from `Base` yet. Can whatever method that calls this be updated to use the dot-call syntax?","created_at":"2016-10-09T23:14:57Z","updated_at":"2016-10-09T23:14:57Z","html_url":"https://github.com/JuliaArrays/StaticArrays.jl/pull/47#discussion_r82534366","pull_request_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/comments/82534366"},"html":{"href":"https://github.com/JuliaArrays/StaticArrays.jl/pull/47#discussion_r82534366"},"pull_request":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47","id":88591499,"html_url":"https://github.com/JuliaArrays/StaticArrays.jl/pull/47","diff_url":"https://github.com/JuliaArrays/StaticArrays.jl/pull/47.diff","patch_url":"https://github.com/JuliaArrays/StaticArrays.jl/pull/47.patch","issue_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/47","number":47,"state":"open","locked":false,"title":"Support M*CartesianIndex, min, max, promotion","user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"body":"Multiplication by a CartesianIndex is nice in multidimensional loops.","created_at":"2016-10-09T19:27:08Z","updated_at":"2016-10-09T23:14:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c08a0b7160180e6a166a91d2b59e2cf47b42ab41","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47/commits","review_comments_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47/comments","review_comment_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/47/comments","statuses_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/statuses/49ff2ee11e066acc114cfe6698a8dd5e6d59fa58","head":{"label":"JuliaArrays:teh/cartesian","ref":"teh/cartesian","sha":"49ff2ee11e066acc114cfe6698a8dd5e6d59fa58","user":{"login":"JuliaArrays","id":21312771,"avatar_url":"https://avatars.githubusercontent.com/u/21312771?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaArrays","html_url":"https://github.com/JuliaArrays","followers_url":"https://api.github.com/users/JuliaArrays/followers","following_url":"https://api.github.com/users/JuliaArrays/following{/other_user}","gists_url":"https://api.github.com/users/JuliaArrays/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaArrays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaArrays/subscriptions","organizations_url":"https://api.github.com/users/JuliaArrays/orgs","repos_url":"https://api.github.com/users/JuliaArrays/repos","events_url":"https://api.github.com/users/JuliaArrays/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaArrays/received_events","type":"Organization","site_admin":false},"repo":{"id":58931685,"name":"StaticArrays.jl","full_name":"JuliaArrays/StaticArrays.jl","owner":{"login":"JuliaArrays","id":21312771,"avatar_url":"https://avatars.githubusercontent.com/u/21312771?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaArrays","html_url":"https://github.com/JuliaArrays","followers_url":"https://api.github.com/users/JuliaArrays/followers","following_url":"https://api.github.com/users/JuliaArrays/following{/other_user}","gists_url":"https://api.github.com/users/JuliaArrays/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaArrays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaArrays/subscriptions","organizations_url":"https://api.github.com/users/JuliaArrays/orgs","repos_url":"https://api.github.com/users/JuliaArrays/repos","events_url":"https://api.github.com/users/JuliaArrays/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaArrays/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaArrays/StaticArrays.jl","description":"Statically sized arrays for Julia 0.5","fork":false,"url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl","forks_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/forks","keys_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/teams","hooks_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/events","assignees_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/tags","blobs_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/subscription","commits_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/merges","archive_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/downloads","issues_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/deployments","created_at":"2016-05-16T12:45:37Z","updated_at":"2016-09-20T17:19:40Z","pushed_at":"2016-10-09T23:06:15Z","git_url":"git://github.com/JuliaArrays/StaticArrays.jl.git","ssh_url":"git@github.com:JuliaArrays/StaticArrays.jl.git","clone_url":"https://github.com/JuliaArrays/StaticArrays.jl.git","svn_url":"https://github.com/JuliaArrays/StaticArrays.jl","homepage":"","size":231,"stargazers_count":20,"watchers_count":20,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":18,"forks":6,"open_issues":18,"watchers":20,"default_branch":"master"}},"base":{"label":"JuliaArrays:master","ref":"master","sha":"f83dcf120ae34a69256821fb12cf298472efcf4e","user":{"login":"JuliaArrays","id":21312771,"avatar_url":"https://avatars.githubusercontent.com/u/21312771?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaArrays","html_url":"https://github.com/JuliaArrays","followers_url":"https://api.github.com/users/JuliaArrays/followers","following_url":"https://api.github.com/users/JuliaArrays/following{/other_user}","gists_url":"https://api.github.com/users/JuliaArrays/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaArrays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaArrays/subscriptions","organizations_url":"https://api.github.com/users/JuliaArrays/orgs","repos_url":"https://api.github.com/users/JuliaArrays/repos","events_url":"https://api.github.com/users/JuliaArrays/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaArrays/received_events","type":"Organization","site_admin":false},"repo":{"id":58931685,"name":"StaticArrays.jl","full_name":"JuliaArrays/StaticArrays.jl","owner":{"login":"JuliaArrays","id":21312771,"avatar_url":"https://avatars.githubusercontent.com/u/21312771?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaArrays","html_url":"https://github.com/JuliaArrays","followers_url":"https://api.github.com/users/JuliaArrays/followers","following_url":"https://api.github.com/users/JuliaArrays/following{/other_user}","gists_url":"https://api.github.com/users/JuliaArrays/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaArrays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaArrays/subscriptions","organizations_url":"https://api.github.com/users/JuliaArrays/orgs","repos_url":"https://api.github.com/users/JuliaArrays/repos","events_url":"https://api.github.com/users/JuliaArrays/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaArrays/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaArrays/StaticArrays.jl","description":"Statically sized arrays for Julia 0.5","fork":false,"url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl","forks_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/forks","keys_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/teams","hooks_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/events","assignees_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/tags","blobs_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/subscription","commits_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/merges","archive_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/downloads","issues_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/deployments","created_at":"2016-05-16T12:45:37Z","updated_at":"2016-09-20T17:19:40Z","pushed_at":"2016-10-09T23:06:15Z","git_url":"git://github.com/JuliaArrays/StaticArrays.jl.git","ssh_url":"git@github.com:JuliaArrays/StaticArrays.jl.git","clone_url":"https://github.com/JuliaArrays/StaticArrays.jl.git","svn_url":"https://github.com/JuliaArrays/StaticArrays.jl","homepage":"","size":231,"stargazers_count":20,"watchers_count":20,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":18,"forks":6,"open_issues":18,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47"},"html":{"href":"https://github.com/JuliaArrays/StaticArrays.jl/pull/47"},"issue":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/47"},"comments":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaArrays/StaticArrays.jl/statuses/49ff2ee11e066acc114cfe6698a8dd5e6d59fa58"}}}}
{"actor":{"display_login":"andyferris"}}