{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/57105580","id":57105580,"diff_hunk":"@@ -115,13 +115,8 @@\n //!\n //! If this syntax is used, then the number of characters to print precedes the\n //! actual object being formatted, and the number of characters must have the\n-//! type `usize`. Although a `usize` can be printed with `{}`, it is invalid to","path":"src/libcollections/fmt.rs","position":4,"original_position":4,"commit_id":"20dff2b566b5c4659bfb6daa807b9db0f7366ca8","original_commit_id":"20dff2b566b5c4659bfb6daa807b9db0f7366ca8","user":{"login":"nodakai","id":90726,"avatar_url":"https://avatars.githubusercontent.com/u/90726?v=3","gravatar_id":"","url":"https://api.github.com/users/nodakai","html_url":"https://github.com/nodakai","followers_url":"https://api.github.com/users/nodakai/followers","following_url":"https://api.github.com/users/nodakai/following{/other_user}","gists_url":"https://api.github.com/users/nodakai/gists{/gist_id}","starred_url":"https://api.github.com/users/nodakai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodakai/subscriptions","organizations_url":"https://api.github.com/users/nodakai/orgs","repos_url":"https://api.github.com/users/nodakai/repos","events_url":"https://api.github.com/users/nodakai/events{/privacy}","received_events_url":"https://api.github.com/users/nodakai/received_events","type":"User","site_admin":false},"body":"> it is invalid to reference an argument as such.\r\n\r\nPersonally I struggled to grasp the meaning of this sentence, so I'm glad to see it'll be replaced with a slightly better alternative. But the section still contains so many problems. Perhaps all the descriptions about the variable-precision thingy should be consolidated to an independent section because it is such a unique \"precision specifier\" that incurs special restrictions on how to consume a \"positional argument\" and on the \"argument type.\"\r\n\r\nThe \"invalid format string\" example surely contained some information but I'd say it would make sense only to those who already understood the internal mechanism of `std::fmt`. It was not a complete executable code snippet and required some context to make sense. But by extending the definition of the \"context\", I could indeed make it work: `println!(\"{} {:.*} {0}\", 1, 2, 3.456);`","created_at":"2016-03-23T03:32:04Z","updated_at":"2016-03-23T03:32:04Z","html_url":"https://github.com/rust-lang/rust/pull/32422#discussion_r57105580","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/32422","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/57105580"},"html":{"href":"https://github.com/rust-lang/rust/pull/32422#discussion_r57105580"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32422"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/32422","id":63674337,"html_url":"https://github.com/rust-lang/rust/pull/32422","diff_url":"https://github.com/rust-lang/rust/pull/32422.diff","patch_url":"https://github.com/rust-lang/rust/pull/32422.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/32422","number":32422,"state":"open","locked":false,"title":"Document {:.*} syntax with named/positional parameters","user":{"login":"shahn","id":128636,"avatar_url":"https://avatars.githubusercontent.com/u/128636?v=3","gravatar_id":"","url":"https://api.github.com/users/shahn","html_url":"https://github.com/shahn","followers_url":"https://api.github.com/users/shahn/followers","following_url":"https://api.github.com/users/shahn/following{/other_user}","gists_url":"https://api.github.com/users/shahn/gists{/gist_id}","starred_url":"https://api.github.com/users/shahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahn/subscriptions","organizations_url":"https://api.github.com/users/shahn/orgs","repos_url":"https://api.github.com/users/shahn/repos","events_url":"https://api.github.com/users/shahn/events{/privacy}","received_events_url":"https://api.github.com/users/shahn/received_events","type":"User","site_admin":false},"body":"Inspired by #32391.","created_at":"2016-03-22T06:16:42Z","updated_at":"2016-03-23T03:32:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adf46bb6f27c41018f49ded53e17bdb8d6829511","assignee":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/32422/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/32422/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/32422/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/20dff2b566b5c4659bfb6daa807b9db0f7366ca8","head":{"label":"shahn:+issue32391","ref":"+issue32391","sha":"20dff2b566b5c4659bfb6daa807b9db0f7366ca8","user":{"login":"shahn","id":128636,"avatar_url":"https://avatars.githubusercontent.com/u/128636?v=3","gravatar_id":"","url":"https://api.github.com/users/shahn","html_url":"https://github.com/shahn","followers_url":"https://api.github.com/users/shahn/followers","following_url":"https://api.github.com/users/shahn/following{/other_user}","gists_url":"https://api.github.com/users/shahn/gists{/gist_id}","starred_url":"https://api.github.com/users/shahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahn/subscriptions","organizations_url":"https://api.github.com/users/shahn/orgs","repos_url":"https://api.github.com/users/shahn/repos","events_url":"https://api.github.com/users/shahn/events{/privacy}","received_events_url":"https://api.github.com/users/shahn/received_events","type":"User","site_admin":false},"repo":{"id":41910325,"name":"rust","full_name":"shahn/rust","owner":{"login":"shahn","id":128636,"avatar_url":"https://avatars.githubusercontent.com/u/128636?v=3","gravatar_id":"","url":"https://api.github.com/users/shahn","html_url":"https://github.com/shahn","followers_url":"https://api.github.com/users/shahn/followers","following_url":"https://api.github.com/users/shahn/following{/other_user}","gists_url":"https://api.github.com/users/shahn/gists{/gist_id}","starred_url":"https://api.github.com/users/shahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahn/subscriptions","organizations_url":"https://api.github.com/users/shahn/orgs","repos_url":"https://api.github.com/users/shahn/repos","events_url":"https://api.github.com/users/shahn/events{/privacy}","received_events_url":"https://api.github.com/users/shahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shahn/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/shahn/rust","forks_url":"https://api.github.com/repos/shahn/rust/forks","keys_url":"https://api.github.com/repos/shahn/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shahn/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shahn/rust/teams","hooks_url":"https://api.github.com/repos/shahn/rust/hooks","issue_events_url":"https://api.github.com/repos/shahn/rust/issues/events{/number}","events_url":"https://api.github.com/repos/shahn/rust/events","assignees_url":"https://api.github.com/repos/shahn/rust/assignees{/user}","branches_url":"https://api.github.com/repos/shahn/rust/branches{/branch}","tags_url":"https://api.github.com/repos/shahn/rust/tags","blobs_url":"https://api.github.com/repos/shahn/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shahn/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shahn/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/shahn/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shahn/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/shahn/rust/languages","stargazers_url":"https://api.github.com/repos/shahn/rust/stargazers","contributors_url":"https://api.github.com/repos/shahn/rust/contributors","subscribers_url":"https://api.github.com/repos/shahn/rust/subscribers","subscription_url":"https://api.github.com/repos/shahn/rust/subscription","commits_url":"https://api.github.com/repos/shahn/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/shahn/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/shahn/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/shahn/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/shahn/rust/contents/{+path}","compare_url":"https://api.github.com/repos/shahn/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shahn/rust/merges","archive_url":"https://api.github.com/repos/shahn/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shahn/rust/downloads","issues_url":"https://api.github.com/repos/shahn/rust/issues{/number}","pulls_url":"https://api.github.com/repos/shahn/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/shahn/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/shahn/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shahn/rust/labels{/name}","releases_url":"https://api.github.com/repos/shahn/rust/releases{/id}","deployments_url":"https://api.github.com/repos/shahn/rust/deployments","created_at":"2015-09-04T10:31:32Z","updated_at":"2015-09-04T10:31:47Z","pushed_at":"2016-03-22T06:15:17Z","git_url":"git://github.com/shahn/rust.git","ssh_url":"git@github.com:shahn/rust.git","clone_url":"https://github.com/shahn/rust.git","svn_url":"https://github.com/shahn/rust","homepage":"http://www.rust-lang.org","size":285572,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"4621dd21715c2abee70f3057c608d1ee9c3e8b84","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-03-23T03:30:23Z","pushed_at":"2016-03-23T03:09:13Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":481176,"stargazers_count":15892,"watchers_count":15892,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3046,"mirror_url":null,"open_issues_count":2377,"forks":3046,"open_issues":2377,"watchers":15892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32422"},"html":{"href":"https://github.com/rust-lang/rust/pull/32422"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32422"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32422/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32422/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32422/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/20dff2b566b5c4659bfb6daa807b9db0f7366ca8"}}}}