{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/64380777","id":64380777,"diff_hunk":"@@ -18,92 +18,101 @@ func defaultTagImagesHookContainerName(hook *LifecycleHook, containerName string\n \t}\n }\n \n-func addDefaultingFuncs(scheme *runtime.Scheme) {\n-\tmkintp := func(i int64) *int64 {\n-\t\treturn &i\n+func SetDefaults_DeploymentConfigSpec(obj *DeploymentConfigSpec) {\n+\tif obj.Triggers == nil {\n+\t\tobj.Triggers = []DeploymentTriggerPolicy{\n+\t\t\t{Type: DeploymentTriggerOnConfigChange},\n+\t\t}\n+\t}\n+\tif len(obj.Selector) == 0 && obj.Template != nil {\n+\t\tobj.Selector = obj.Template.Labels\n \t}\n \n-\terr := scheme.AddDefaultingFuncs(\n-\t\tfunc(obj *DeploymentConfigSpec) {\n-\t\t\tif obj.Triggers == nil {\n-\t\t\t\tobj.Triggers = []DeploymentTriggerPolicy{\n-\t\t\t\t\t{Type: DeploymentTriggerOnConfigChange},\n-\t\t\t\t}\n-\t\t\t}\n-\t\t\tif len(obj.Selector) == 0 && obj.Template != nil {\n-\t\t\t\tobj.Selector = obj.Template.Labels\n-\t\t\t}\n+\t// if you only specify a single container, default the TagImages hook to the container name\n+\tif obj.Template != nil && len(obj.Template.Spec.Containers) == 1 {\n+\t\tcontainerName := obj.Template.Spec.Containers[0].Name\n+\t\tif p := obj.Strategy.RecreateParams; p != nil {\n+\t\t\tdefaultTagImagesHookContainerName(p.Pre, containerName)\n+\t\t\tdefaultTagImagesHookContainerName(p.Mid, containerName)\n+\t\t\tdefaultTagImagesHookContainerName(p.Post, containerName)\n+\t\t}\n+\t\tif p := obj.Strategy.RollingParams; p != nil {\n+\t\t\tdefaultTagImagesHookContainerName(p.Pre, containerName)\n+\t\t\tdefaultTagImagesHookContainerName(p.Post, containerName)\n+\t\t}\n+\t}\n+}\n \n-\t\t\t// if you only specify a single container, default the TagImages hook to the container name\n-\t\t\tif obj.Template != nil && len(obj.Template.Spec.Containers) == 1 {\n-\t\t\t\tcontainerName := obj.Template.Spec.Containers[0].Name\n-\t\t\t\tif p := obj.Strategy.RecreateParams; p != nil {\n-\t\t\t\t\tdefaultTagImagesHookContainerName(p.Pre, containerName)\n-\t\t\t\t\tdefaultTagImagesHookContainerName(p.Mid, containerName)\n-\t\t\t\t\tdefaultTagImagesHookContainerName(p.Post, containerName)\n-\t\t\t\t}\n-\t\t\t\tif p := obj.Strategy.RollingParams; p != nil {\n-\t\t\t\t\tdefaultTagImagesHookContainerName(p.Pre, containerName)\n-\t\t\t\t\tdefaultTagImagesHookContainerName(p.Post, containerName)\n-\t\t\t\t}\n-\t\t\t}\n-\t\t},\n-\t\tfunc(obj *DeploymentStrategy) {\n-\t\t\tif len(obj.Type) == 0 {\n-\t\t\t\tobj.Type = DeploymentStrategyTypeRolling\n-\t\t\t}\n+func SetDefaults_DeploymentStrategy(obj *DeploymentStrategy) {\n+\tif len(obj.Type) == 0 {\n+\t\tobj.Type = DeploymentStrategyTypeRolling\n+\t}\n \n-\t\t\tif obj.Type == DeploymentStrategyTypeRolling && obj.RollingParams == nil {\n-\t\t\t\tobj.RollingParams = &RollingDeploymentStrategyParams{\n-\t\t\t\t\tIntervalSeconds:     mkintp(deployapi.DefaultRollingIntervalSeconds),\n-\t\t\t\t\tUpdatePeriodSeconds: mkintp(deployapi.DefaultRollingUpdatePeriodSeconds),\n-\t\t\t\t\tTimeoutSeconds:      mkintp(deployapi.DefaultRollingTimeoutSeconds),\n-\t\t\t\t}\n-\t\t\t}\n-\t\t\tif obj.Type == DeploymentStrategyTypeRecreate && obj.RecreateParams == nil {\n-\t\t\t\tobj.RecreateParams = &RecreateDeploymentStrategyParams{}\n-\t\t\t}\n-\t\t},\n-\t\tfunc(obj *RecreateDeploymentStrategyParams) {\n-\t\t\tif obj.TimeoutSeconds == nil {\n-\t\t\t\tobj.TimeoutSeconds = mkintp(deployapi.DefaultRollingTimeoutSeconds)\n-\t\t\t}\n-\t\t},\n-\t\tfunc(obj *RollingDeploymentStrategyParams) {\n-\t\t\tif obj.IntervalSeconds == nil {\n-\t\t\t\tobj.IntervalSeconds = mkintp(deployapi.DefaultRollingIntervalSeconds)\n-\t\t\t}\n+\tif obj.Type == DeploymentStrategyTypeRolling && obj.RollingParams == nil {\n+\t\tobj.RollingParams = &RollingDeploymentStrategyParams{\n+\t\t\tIntervalSeconds:     mkintp(deployapi.DefaultRollingIntervalSeconds),\n+\t\t\tUpdatePeriodSeconds: mkintp(deployapi.DefaultRollingUpdatePeriodSeconds),\n+\t\t\tTimeoutSeconds:      mkintp(deployapi.DefaultRollingTimeoutSeconds),\n+\t\t}\n+\t}\n+\tif obj.Type == DeploymentStrategyTypeRecreate && obj.RecreateParams == nil {\n+\t\tobj.RecreateParams = &RecreateDeploymentStrategyParams{}\n+\t}\n+}\n \n-\t\t\tif obj.UpdatePeriodSeconds == nil {\n-\t\t\t\tobj.UpdatePeriodSeconds = mkintp(deployapi.DefaultRollingUpdatePeriodSeconds)\n-\t\t\t}\n+func SetDefaults_RecreateDeploymentStrategyParams(obj *RecreateDeploymentStrategyParams) {\n+\tif obj.TimeoutSeconds == nil {\n+\t\tobj.TimeoutSeconds = mkintp(deployapi.DefaultRollingTimeoutSeconds)\n+\t}\n+}\n+func SetDefaults_RollingDeploymentStrategyParams(obj *RollingDeploymentStrategyParams) {\n+\tif obj.IntervalSeconds == nil {\n+\t\tobj.IntervalSeconds = mkintp(deployapi.DefaultRollingIntervalSeconds)\n+\t}\n \n-\t\t\tif obj.TimeoutSeconds == nil {\n-\t\t\t\tobj.TimeoutSeconds = mkintp(deployapi.DefaultRollingTimeoutSeconds)\n-\t\t\t}\n+\tif obj.UpdatePeriodSeconds == nil {\n+\t\tobj.UpdatePeriodSeconds = mkintp(deployapi.DefaultRollingUpdatePeriodSeconds)\n+\t}\n \n-\t\t\tif obj.UpdatePercent == nil {\n-\t\t\t\t// Apply defaults.\n-\t\t\t\tif obj.MaxUnavailable == nil {\n-\t\t\t\t\tmaxUnavailable := intstr.FromString(\"25%\")\n-\t\t\t\t\tobj.MaxUnavailable = &maxUnavailable\n-\t\t\t\t}\n-\t\t\t\tif obj.MaxSurge == nil {\n-\t\t\t\t\tmaxSurge := intstr.FromString(\"25%\")\n-\t\t\t\t\tobj.MaxSurge = &maxSurge\n-\t\t\t\t}\n-\t\t\t}\n-\t\t},\n-\t\tfunc(obj *DeploymentConfig) {\n-\t\t\tfor _, t := range obj.Spec.Triggers {\n-\t\t\t\tif t.ImageChangeParams != nil {\n-\t\t\t\t\tt.ImageChangeParams.From.Kind = \"ImageStreamTag\"\n-\t\t\t\t\tif len(t.ImageChangeParams.From.Name) > 0 && len(t.ImageChangeParams.From.Namespace) == 0 {\n-\t\t\t\t\t\tt.ImageChangeParams.From.Namespace = obj.Namespace\n-\t\t\t\t\t}\n-\t\t\t\t}\n+\tif obj.TimeoutSeconds == nil {\n+\t\tobj.TimeoutSeconds = mkintp(deployapi.DefaultRollingTimeoutSeconds)\n+\t}\n+\n+\tif obj.UpdatePercent == nil {\n+\t\t// Apply defaults.\n+\t\tif obj.MaxUnavailable == nil {\n+\t\t\tmaxUnavailable := intstr.FromString(\"25%\")\n+\t\t\tobj.MaxUnavailable = &maxUnavailable\n+\t\t}\n+\t\tif obj.MaxSurge == nil {\n+\t\t\tmaxSurge := intstr.FromString(\"25%\")\n+\t\t\tobj.MaxSurge = &maxSurge\n+\t\t}\n+\t}\n+}\n+\n+func SetDefaults_DeploymentConfig(obj *DeploymentConfig) {","path":"pkg/deploy/api/v1/defaults.go","position":null,"original_position":154,"commit_id":"b7a107ed09d0563b2dd070d1a951e1ce5bafe1ed","original_commit_id":"b7a107ed09d0563b2dd070d1a951e1ce5bafe1ed","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Oh actually you need the dc name. ","created_at":"2016-05-24T12:25:07Z","updated_at":"2016-05-24T12:25:07Z","html_url":"https://github.com/openshift/origin/pull/8856#discussion_r64380777","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8856","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/64380777"},"html":{"href":"https://github.com/openshift/origin/pull/8856#discussion_r64380777"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8856","id":69815590,"html_url":"https://github.com/openshift/origin/pull/8856","diff_url":"https://github.com/openshift/origin/pull/8856.diff","patch_url":"https://github.com/openshift/origin/pull/8856.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8856","number":8856,"state":"open","locked":false,"title":"[WIP] Rebase","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"Kubernetes fork PR: https://github.com/openshift/kubernetes/pull/19\r\nRemaining work for this PR:\r\n\r\n- [x] Fix `Godeps/Godeps.json` (must be generated for **each** UPSTREAM commit)\r\n- [ ] If we have https://github.com/kubernetes/kubernetes/pull/23795, we picked up a couple important bugs https://github.com/kubernetes/kubernetes/pull/25671 and https://github.com/kubernetes/kubernetes/pull/25669\r\n- [x] The `update-generated-conversions` script is broken\r\n- [ ] The `RateLimiter` needs a fuzzer in master config test\r\n- [x] Fix compilation\r\n- [ ] Fix broken template unit test (`pkg/template`)\r\n- [ ] Fix integration: `sa_oauthclient_test.go:165: unexpected error: Missing configuration`\r\n- [ ] Fix integration: `storage_versions_test.go:117: batch: expected api version extensions/v1beta1 in etcd, got batch/v1, Kind=Job reading Job`\r\n- [ ] Fix E2E tests\r\n\r\nFollow ups / good to know:\r\n\r\n- The new `generic.Decorator{}` now takes the `cacheSize` argument. I hardcoded it to `100` but this should be configurable from the master config (or we should at least have map with resources and set the numbers there, in one place)\r\n- There was `cacheSize` introduced in various places (grep for 'cacheSize'), there should be an issue opened to track them\r\n- The `iptables.NewProxier()` now takes extra `c.ClusterCIDR` argument. This should be configurable as well (current set to empty string which means no off-cluster bridging will be performed) \r\n- Kubernetes is now using https://github.com/docker/engine-api instead of https://github.com/fsouza/go-dockerclient and they of course have incompatible interfaces. I created a simple wrapper for the engine-api client: https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-f2e698c988010fe8fd27effa4c84a80eR41 but we should consider switching to engine-api client as well.\r\n- If we have https://github.com/kubernetes/kubernetes/pull/23795, we picked up a couple important bugs https://github.com/kubernetes/kubernetes/pull/25671 and https://github.com/kubernetes/kubernetes/pull/25669 .\r\n- Follow up with updating `ktestclient.Action` to `core.Action` to reflect upstream changes\r\n- Follow up on migrating go-dockerclient to engine-api (need to disable newapp integration test)\r\n\r\nAs @smarterclayton noted, this rebase might require go-1.6, but I can see this builds fine on 1.5 as well.\r\n\r\nImportant changes that should be reviewed:\r\n\r\n- [x] https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-05523003a782d7b3b61c2608a29dfb39R228 (as the StorageDestination is no more)\r\n- [x] https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-90ac63ed95fc5a187e3347f9cded16cbR84 (and friends... what happened is that kube now use `credentialprovider.LazyAuthConfiguration` which is not compatible with `docker.AuthConfiguration`. I will add some nicer wrapper for these.\r\n- [ ] https://github.com/openshift/origin/pull/8856/commits/06396fd50e7c5dc3ffbb6afae7ee899c89a95b08#diff-adefa6892d6212c6873413c96b805bb3R258 as I don't really know how much important is this method for SDN\r\n","created_at":"2016-05-12T10:48:00Z","updated_at":"2016-05-24T12:25:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09c2561becd709f597b48a82f01e620babc399c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8856/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8856/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8856/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/b7a107ed09d0563b2dd070d1a951e1ce5bafe1ed","head":{"label":"mfojtik:rebase","ref":"rebase","sha":"b7a107ed09d0563b2dd070d1a951e1ce5bafe1ed","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22954249,"name":"origin","full_name":"mfojtik/origin","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/mfojtik/origin","forks_url":"https://api.github.com/repos/mfojtik/origin/forks","keys_url":"https://api.github.com/repos/mfojtik/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/origin/teams","hooks_url":"https://api.github.com/repos/mfojtik/origin/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/origin/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/origin/events","assignees_url":"https://api.github.com/repos/mfojtik/origin/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/origin/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/origin/tags","blobs_url":"https://api.github.com/repos/mfojtik/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/origin/languages","stargazers_url":"https://api.github.com/repos/mfojtik/origin/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/origin/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/origin/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/origin/subscription","commits_url":"https://api.github.com/repos/mfojtik/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/origin/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/origin/merges","archive_url":"https://api.github.com/repos/mfojtik/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/origin/downloads","issues_url":"https://api.github.com/repos/mfojtik/origin/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/origin/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/origin/releases{/id}","deployments_url":"https://api.github.com/repos/mfojtik/origin/deployments","created_at":"2014-08-14T13:11:47Z","updated_at":"2016-01-12T09:38:06Z","pushed_at":"2016-05-24T12:20:18Z","git_url":"git://github.com/mfojtik/origin.git","ssh_url":"git@github.com:mfojtik/origin.git","clone_url":"https://github.com/mfojtik/origin.git","svn_url":"https://github.com/mfojtik/origin","homepage":"https://openshift.github.io","size":264270,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5f098ef25334dc463df2ec352731f5a04bd6818e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-05-24T05:42:55Z","pushed_at":"2016-05-24T12:20:20Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":507739,"stargazers_count":1315,"watchers_count":1315,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":785,"mirror_url":null,"open_issues_count":996,"forks":785,"open_issues":996,"watchers":1315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856"},"html":{"href":"https://github.com/openshift/origin/pull/8856"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8856"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8856/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/b7a107ed09d0563b2dd070d1a951e1ce5bafe1ed"}}}}
{"actor":{"display_login":"kargakis"}}