{"action":"created","comment":{"url":"https://api.github.com/repos/google/vrview/pulls/comments/72551105","id":72551105,"diff_hunk":"@@ -39,7 +39,8 @@ PhotosphereRenderer.prototype.init = function() {\n   renderer.setSize(window.innerWidth, window.innerHeight);\n \n   // Round down fractional DPR values for better performance.\n-  renderer.setPixelRatio(Math.floor(window.devicePixelRatio));\n+  var pixelRatio = window.devicePixelRatio < 1 ? 1 : Math.floor(window.devicePixelRatio)","path":"src/photosphere-renderer.js","position":null,"original_position":5,"commit_id":"501713efa04982bcfc771164bce30788aa4e465c","original_commit_id":"4b380c51b953e00857d50d2365955c4f71c929c3","user":{"login":"nyako","id":3353266,"avatar_url":"https://avatars.githubusercontent.com/u/3353266?v=3","gravatar_id":"","url":"https://api.github.com/users/nyako","html_url":"https://github.com/nyako","followers_url":"https://api.github.com/users/nyako/followers","following_url":"https://api.github.com/users/nyako/following{/other_user}","gists_url":"https://api.github.com/users/nyako/gists{/gist_id}","starred_url":"https://api.github.com/users/nyako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyako/subscriptions","organizations_url":"https://api.github.com/users/nyako/orgs","repos_url":"https://api.github.com/users/nyako/repos","events_url":"https://api.github.com/users/nyako/events{/privacy}","received_events_url":"https://api.github.com/users/nyako/received_events","type":"User","site_admin":false},"body":"Good idea! I've just made those changes.","created_at":"2016-07-28T01:03:06Z","updated_at":"2016-07-28T01:03:06Z","html_url":"https://github.com/google/vrview/pull/36#discussion_r72551105","pull_request_url":"https://api.github.com/repos/google/vrview/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/google/vrview/pulls/comments/72551105"},"html":{"href":"https://github.com/google/vrview/pull/36#discussion_r72551105"},"pull_request":{"href":"https://api.github.com/repos/google/vrview/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/google/vrview/pulls/36","id":78977729,"html_url":"https://github.com/google/vrview/pull/36","diff_url":"https://github.com/google/vrview/pull/36.diff","patch_url":"https://github.com/google/vrview/pull/36.patch","issue_url":"https://api.github.com/repos/google/vrview/issues/36","number":36,"state":"open","locked":false,"title":"Prevent zero pixel ratio in renderer","user":{"login":"nyako","id":3353266,"avatar_url":"https://avatars.githubusercontent.com/u/3353266?v=3","gravatar_id":"","url":"https://api.github.com/users/nyako","html_url":"https://github.com/nyako","followers_url":"https://api.github.com/users/nyako/followers","following_url":"https://api.github.com/users/nyako/following{/other_user}","gists_url":"https://api.github.com/users/nyako/gists{/gist_id}","starred_url":"https://api.github.com/users/nyako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyako/subscriptions","organizations_url":"https://api.github.com/users/nyako/orgs","repos_url":"https://api.github.com/users/nyako/repos","events_url":"https://api.github.com/users/nyako/events{/privacy}","received_events_url":"https://api.github.com/users/nyako/received_events","type":"User","site_admin":false},"body":"... so that on browsers where page is zoomed out (zoom level less than 100%), the canvas dimension is not zero on page refresh. \r\n\r\nWhen the width and height of the canvas are zero on initialization, the loaded scene is black.","created_at":"2016-07-27T07:34:40Z","updated_at":"2016-07-28T01:03:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f86e4ae896d0ecabd2acf26293d4f2a69a95b534","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/vrview/pulls/36/commits","review_comments_url":"https://api.github.com/repos/google/vrview/pulls/36/comments","review_comment_url":"https://api.github.com/repos/google/vrview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/vrview/issues/36/comments","statuses_url":"https://api.github.com/repos/google/vrview/statuses/501713efa04982bcfc771164bce30788aa4e465c","head":{"label":"nyako:patchZeroCanvasDimension","ref":"patchZeroCanvasDimension","sha":"501713efa04982bcfc771164bce30788aa4e465c","user":{"login":"nyako","id":3353266,"avatar_url":"https://avatars.githubusercontent.com/u/3353266?v=3","gravatar_id":"","url":"https://api.github.com/users/nyako","html_url":"https://github.com/nyako","followers_url":"https://api.github.com/users/nyako/followers","following_url":"https://api.github.com/users/nyako/following{/other_user}","gists_url":"https://api.github.com/users/nyako/gists{/gist_id}","starred_url":"https://api.github.com/users/nyako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyako/subscriptions","organizations_url":"https://api.github.com/users/nyako/orgs","repos_url":"https://api.github.com/users/nyako/repos","events_url":"https://api.github.com/users/nyako/events{/privacy}","received_events_url":"https://api.github.com/users/nyako/received_events","type":"User","site_admin":false},"repo":{"id":64284104,"name":"vrview","full_name":"nyako/vrview","owner":{"login":"nyako","id":3353266,"avatar_url":"https://avatars.githubusercontent.com/u/3353266?v=3","gravatar_id":"","url":"https://api.github.com/users/nyako","html_url":"https://github.com/nyako","followers_url":"https://api.github.com/users/nyako/followers","following_url":"https://api.github.com/users/nyako/following{/other_user}","gists_url":"https://api.github.com/users/nyako/gists{/gist_id}","starred_url":"https://api.github.com/users/nyako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyako/subscriptions","organizations_url":"https://api.github.com/users/nyako/orgs","repos_url":"https://api.github.com/users/nyako/repos","events_url":"https://api.github.com/users/nyako/events{/privacy}","received_events_url":"https://api.github.com/users/nyako/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyako/vrview","description":null,"fork":true,"url":"https://api.github.com/repos/nyako/vrview","forks_url":"https://api.github.com/repos/nyako/vrview/forks","keys_url":"https://api.github.com/repos/nyako/vrview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyako/vrview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyako/vrview/teams","hooks_url":"https://api.github.com/repos/nyako/vrview/hooks","issue_events_url":"https://api.github.com/repos/nyako/vrview/issues/events{/number}","events_url":"https://api.github.com/repos/nyako/vrview/events","assignees_url":"https://api.github.com/repos/nyako/vrview/assignees{/user}","branches_url":"https://api.github.com/repos/nyako/vrview/branches{/branch}","tags_url":"https://api.github.com/repos/nyako/vrview/tags","blobs_url":"https://api.github.com/repos/nyako/vrview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyako/vrview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyako/vrview/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyako/vrview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyako/vrview/statuses/{sha}","languages_url":"https://api.github.com/repos/nyako/vrview/languages","stargazers_url":"https://api.github.com/repos/nyako/vrview/stargazers","contributors_url":"https://api.github.com/repos/nyako/vrview/contributors","subscribers_url":"https://api.github.com/repos/nyako/vrview/subscribers","subscription_url":"https://api.github.com/repos/nyako/vrview/subscription","commits_url":"https://api.github.com/repos/nyako/vrview/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyako/vrview/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyako/vrview/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyako/vrview/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyako/vrview/contents/{+path}","compare_url":"https://api.github.com/repos/nyako/vrview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyako/vrview/merges","archive_url":"https://api.github.com/repos/nyako/vrview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyako/vrview/downloads","issues_url":"https://api.github.com/repos/nyako/vrview/issues{/number}","pulls_url":"https://api.github.com/repos/nyako/vrview/pulls{/number}","milestones_url":"https://api.github.com/repos/nyako/vrview/milestones{/number}","notifications_url":"https://api.github.com/repos/nyako/vrview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyako/vrview/labels{/name}","releases_url":"https://api.github.com/repos/nyako/vrview/releases{/id}","deployments_url":"https://api.github.com/repos/nyako/vrview/deployments","created_at":"2016-07-27T06:41:18Z","updated_at":"2016-07-27T06:41:19Z","pushed_at":"2016-07-28T00:59:18Z","git_url":"git://github.com/nyako/vrview.git","ssh_url":"git@github.com:nyako/vrview.git","clone_url":"https://github.com/nyako/vrview.git","svn_url":"https://github.com/nyako/vrview","homepage":"http://developers.google.com/cardboard/vrview","size":47322,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"571ae97666d7add26cd7b69be1998703e2205001","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":44144887,"name":"vrview","full_name":"google/vrview","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/vrview","description":"","fork":false,"url":"https://api.github.com/repos/google/vrview","forks_url":"https://api.github.com/repos/google/vrview/forks","keys_url":"https://api.github.com/repos/google/vrview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/vrview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/vrview/teams","hooks_url":"https://api.github.com/repos/google/vrview/hooks","issue_events_url":"https://api.github.com/repos/google/vrview/issues/events{/number}","events_url":"https://api.github.com/repos/google/vrview/events","assignees_url":"https://api.github.com/repos/google/vrview/assignees{/user}","branches_url":"https://api.github.com/repos/google/vrview/branches{/branch}","tags_url":"https://api.github.com/repos/google/vrview/tags","blobs_url":"https://api.github.com/repos/google/vrview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/vrview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/vrview/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/vrview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/vrview/statuses/{sha}","languages_url":"https://api.github.com/repos/google/vrview/languages","stargazers_url":"https://api.github.com/repos/google/vrview/stargazers","contributors_url":"https://api.github.com/repos/google/vrview/contributors","subscribers_url":"https://api.github.com/repos/google/vrview/subscribers","subscription_url":"https://api.github.com/repos/google/vrview/subscription","commits_url":"https://api.github.com/repos/google/vrview/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/vrview/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/vrview/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/vrview/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/vrview/contents/{+path}","compare_url":"https://api.github.com/repos/google/vrview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/vrview/merges","archive_url":"https://api.github.com/repos/google/vrview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/vrview/downloads","issues_url":"https://api.github.com/repos/google/vrview/issues{/number}","pulls_url":"https://api.github.com/repos/google/vrview/pulls{/number}","milestones_url":"https://api.github.com/repos/google/vrview/milestones{/number}","notifications_url":"https://api.github.com/repos/google/vrview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/vrview/labels{/name}","releases_url":"https://api.github.com/repos/google/vrview/releases{/id}","deployments_url":"https://api.github.com/repos/google/vrview/deployments","created_at":"2015-10-13T01:45:58Z","updated_at":"2016-07-28T00:00:36Z","pushed_at":"2016-07-28T00:59:19Z","git_url":"git://github.com/google/vrview.git","ssh_url":"git@github.com:google/vrview.git","clone_url":"https://github.com/google/vrview.git","svn_url":"https://github.com/google/vrview","homepage":"http://developers.google.com/cardboard/vrview","size":48133,"stargazers_count":809,"watchers_count":809,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":28,"forks":243,"open_issues":28,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/vrview/pulls/36"},"html":{"href":"https://github.com/google/vrview/pull/36"},"issue":{"href":"https://api.github.com/repos/google/vrview/issues/36"},"comments":{"href":"https://api.github.com/repos/google/vrview/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/google/vrview/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/google/vrview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/vrview/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/google/vrview/statuses/501713efa04982bcfc771164bce30788aa4e465c"}}}}
{"actor":{"display_login":"nyako"}}