{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/EntityFramework6/issues/41","repository_url":"https://api.github.com/repos/aspnet/EntityFramework6","labels_url":"https://api.github.com/repos/aspnet/EntityFramework6/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework6/issues/41/comments","events_url":"https://api.github.com/repos/aspnet/EntityFramework6/issues/41/events","html_url":"https://github.com/aspnet/EntityFramework6/pull/41","id":170431722,"number":41,"title":"Large models fail to update","user":{"login":"bengutt","id":20947228,"avatar_url":"https://avatars.githubusercontent.com/u/20947228?v=3","gravatar_id":"","url":"https://api.github.com/users/bengutt","html_url":"https://github.com/bengutt","followers_url":"https://api.github.com/users/bengutt/followers","following_url":"https://api.github.com/users/bengutt/following{/other_user}","gists_url":"https://api.github.com/users/bengutt/gists{/gist_id}","starred_url":"https://api.github.com/users/bengutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengutt/subscriptions","organizations_url":"https://api.github.com/users/bengutt/orgs","repos_url":"https://api.github.com/users/bengutt/repos","events_url":"https://api.github.com/users/bengutt/events{/privacy}","received_events_url":"https://api.github.com/users/bengutt/received_events","type":"User","site_admin":false},"labels":[{"id":414655896,"url":"https://api.github.com/repos/aspnet/EntityFramework6/labels/cla-signed","name":"cla-signed","color":"207de5","default":false}],"state":"open","locked":false,"assignee":{"login":"divega","id":1253414,"avatar_url":"https://avatars.githubusercontent.com/u/1253414?v=3","gravatar_id":"","url":"https://api.github.com/users/divega","html_url":"https://github.com/divega","followers_url":"https://api.github.com/users/divega/followers","following_url":"https://api.github.com/users/divega/following{/other_user}","gists_url":"https://api.github.com/users/divega/gists{/gist_id}","starred_url":"https://api.github.com/users/divega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divega/subscriptions","organizations_url":"https://api.github.com/users/divega/orgs","repos_url":"https://api.github.com/users/divega/repos","events_url":"https://api.github.com/users/divega/events{/privacy}","received_events_url":"https://api.github.com/users/divega/received_events","type":"User","site_admin":false},"assignees":[{"login":"divega","id":1253414,"avatar_url":"https://avatars.githubusercontent.com/u/1253414?v=3","gravatar_id":"","url":"https://api.github.com/users/divega","html_url":"https://github.com/divega","followers_url":"https://api.github.com/users/divega/followers","following_url":"https://api.github.com/users/divega/following{/other_user}","gists_url":"https://api.github.com/users/divega/gists{/gist_id}","starred_url":"https://api.github.com/users/divega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divega/subscriptions","organizations_url":"https://api.github.com/users/divega/orgs","repos_url":"https://api.github.com/users/divega/repos","events_url":"https://api.github.com/users/divega/events{/privacy}","received_events_url":"https://api.github.com/users/divega/received_events","type":"User","site_admin":false},{"login":"lajones","id":1915927,"avatar_url":"https://avatars.githubusercontent.com/u/1915927?v=3","gravatar_id":"","url":"https://api.github.com/users/lajones","html_url":"https://github.com/lajones","followers_url":"https://api.github.com/users/lajones/followers","following_url":"https://api.github.com/users/lajones/following{/other_user}","gists_url":"https://api.github.com/users/lajones/gists{/gist_id}","starred_url":"https://api.github.com/users/lajones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lajones/subscriptions","organizations_url":"https://api.github.com/users/lajones/orgs","repos_url":"https://api.github.com/users/lajones/repos","events_url":"https://api.github.com/users/lajones/events{/privacy}","received_events_url":"https://api.github.com/users/lajones/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aspnet/EntityFramework6/milestones/1","html_url":"https://github.com/aspnet/EntityFramework6/milestone/1","labels_url":"https://api.github.com/repos/aspnet/EntityFramework6/milestones/1/labels","id":1905902,"number":1,"title":"6.2.0","description":"","creator":{"login":"rowanmiller","id":4741851,"avatar_url":"https://avatars.githubusercontent.com/u/4741851?v=3","gravatar_id":"","url":"https://api.github.com/users/rowanmiller","html_url":"https://github.com/rowanmiller","followers_url":"https://api.github.com/users/rowanmiller/followers","following_url":"https://api.github.com/users/rowanmiller/following{/other_user}","gists_url":"https://api.github.com/users/rowanmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/rowanmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowanmiller/subscriptions","organizations_url":"https://api.github.com/users/rowanmiller/orgs","repos_url":"https://api.github.com/users/rowanmiller/repos","events_url":"https://api.github.com/users/rowanmiller/events{/privacy}","received_events_url":"https://api.github.com/users/rowanmiller/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":31,"state":"open","created_at":"2016-07-26T21:17:29Z","updated_at":"2016-12-22T19:41:01Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-08-10T14:30:46Z","updated_at":"2016-12-23T02:30:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFramework6/pulls/41","html_url":"https://github.com/aspnet/EntityFramework6/pull/41","diff_url":"https://github.com/aspnet/EntityFramework6/pull/41.diff","patch_url":"https://github.com/aspnet/EntityFramework6/pull/41.patch"},"body":"This is a best attempt fix for http://entityframework.codeplex.com/workitem/520. The problem has the potential to reoccur due to the fact that there is a fixed limit of 2100 parameters in SQL server. A rewrite other the entire function would need to be completed in order to get round it . You will need a very, very, large model to hit the problem again with this fix in place.\n\nThis issues occurs when you have a large number of tables in a model and you need to update the model.\n\nWhen the parameters are being generated for the update, the code is now checking that there isn't a parameter already created with the same value. If it has it will reuse that parameter instead of simply just adding another one.\n\nAdditional information is available in the Issue.\n\nWhile there are no unit tests specifically for this fix, it has been used extensively in house without issue. Further existing unit tests had to be altered in order to pass to allow for the parameter reuse.\n"},"comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework6/issues/comments/268931211","html_url":"https://github.com/aspnet/EntityFramework6/pull/41#issuecomment-268931211","issue_url":"https://api.github.com/repos/aspnet/EntityFramework6/issues/41","id":268931211,"user":{"login":"IanYates","id":1314477,"avatar_url":"https://avatars.githubusercontent.com/u/1314477?v=3","gravatar_id":"","url":"https://api.github.com/users/IanYates","html_url":"https://github.com/IanYates","followers_url":"https://api.github.com/users/IanYates/followers","following_url":"https://api.github.com/users/IanYates/following{/other_user}","gists_url":"https://api.github.com/users/IanYates/gists{/gist_id}","starred_url":"https://api.github.com/users/IanYates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanYates/subscriptions","organizations_url":"https://api.github.com/users/IanYates/orgs","repos_url":"https://api.github.com/users/IanYates/repos","events_url":"https://api.github.com/users/IanYates/events{/privacy}","received_events_url":"https://api.github.com/users/IanYates/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T02:30:09Z","updated_at":"2016-12-23T02:30:09Z","body":"👍 @bengutt \r\nJust ran into this.  I guess a Christmas project will be me building the dev tools and getting them used by VS 2017 (if that's even possible).  \r\nIn the meantime I've removed a few tables from our model to get me through."}}
{"actor":{"display_login":"IanYates"}}