{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62691126","id":62691126,"diff_hunk":"@@ -69,6 +69,26 @@ const TagNameSubnetPublicELB = \"kubernetes.io/role/elb\"\n // This lets us define more advanced semantics in future.\n const ServiceAnnotationLoadBalancerInternal = \"service.beta.kubernetes.io/aws-load-balancer-internal\"\n \n+// Service annotation requesting a secure listener. Value is a valid certificate ARN.\n+// For more, see http://docs.aws.amazon.com/ElasticLoadBalancing/latest/DeveloperGuide/elb-listener-config.html\n+// CertARN is an IAM or CM certificate ARN, e.g. arn:aws:acm:us-east-1:123456789012:certificate/12345678-1234-1234-1234-123456789012\n+const ServiceAnnotationLoadBalancerCertificate = \"service.beta.kubernetes.io/aws-load-balancer-ssl-cert\"\n+\n+// Service annotation specifying the protocol spoken by the backend (pod) behind a secure listener.\n+// Only inspected when `aws-load-balancer-ssl-cert` is used.\n+// If `http` (default) or `https`, an HTTPS listener that terminates the connection and parses headers is created.\n+// If set to `ssl` or `tcp`, a \"raw\" SSL listener is used.\n+","path":"pkg/cloudprovider/providers/aws/aws.go","position":13,"original_position":13,"commit_id":"898df1f52b1fdabacb6c6b0f7faaf0e2691fad90","original_commit_id":"898df1f52b1fdabacb6c6b0f7faaf0e2691fad90","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"Nit: remove blank line here","created_at":"2016-05-10T15:14:57Z","updated_at":"2016-05-10T15:14:57Z","html_url":"https://github.com/kubernetes/kubernetes/pull/23495#discussion_r62691126","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62691126"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23495#discussion_r62691126"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495","id":64187262,"html_url":"https://github.com/kubernetes/kubernetes/pull/23495","diff_url":"https://github.com/kubernetes/kubernetes/pull/23495.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23495.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23495","number":23495,"state":"open","locked":false,"title":"Add SSL support for ELB listeners through annotations","user":{"login":"therc","id":13481082,"avatar_url":"https://avatars.githubusercontent.com/u/13481082?v=3","gravatar_id":"","url":"https://api.github.com/users/therc","html_url":"https://github.com/therc","followers_url":"https://api.github.com/users/therc/followers","following_url":"https://api.github.com/users/therc/following{/other_user}","gists_url":"https://api.github.com/users/therc/gists{/gist_id}","starred_url":"https://api.github.com/users/therc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therc/subscriptions","organizations_url":"https://api.github.com/users/therc/orgs","repos_url":"https://api.github.com/users/therc/repos","events_url":"https://api.github.com/users/therc/events{/privacy}","received_events_url":"https://api.github.com/users/therc/received_events","type":"User","site_admin":false},"body":"In the API, ports have only either TCP or UDP as their protocols, but ELB distinguishes HTTPS->HTTP[S]? from SSL->(SSL|TCP). \r\n\r\nPer #24978, this is implemented through two separate annotations:\r\n\r\n`service.beta.kubernetes.io/aws-load-balancer-ssl-cert=arn:aws:acm:us-east-1:123456789012:certificate/12345678-1234-1234-1234-123456789012`\r\n`service.beta.kubernetes.io/aws-load-balancer-backend-protocol=(https|http|ssl|tcp)`\r\n\r\nMixing plain-text and encrypted listeners will be in a separate PR, implementing #24978's `aws-load-balancer-ssl-ports=LIST`","created_at":"2016-03-25T17:44:35Z","updated_at":"2016-05-10T15:14:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d44cdcb34c409b015eb8f71877f00f30293082b4","assignee":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":211,"closed_issues":49,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-05-10T12:32:00Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23495/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/898df1f52b1fdabacb6c6b0f7faaf0e2691fad90","head":{"label":"Clarifai:elb","ref":"elb","sha":"898df1f52b1fdabacb6c6b0f7faaf0e2691fad90","user":{"login":"Clarifai","id":8550654,"avatar_url":"https://avatars.githubusercontent.com/u/8550654?v=3","gravatar_id":"","url":"https://api.github.com/users/Clarifai","html_url":"https://github.com/Clarifai","followers_url":"https://api.github.com/users/Clarifai/followers","following_url":"https://api.github.com/users/Clarifai/following{/other_user}","gists_url":"https://api.github.com/users/Clarifai/gists{/gist_id}","starred_url":"https://api.github.com/users/Clarifai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clarifai/subscriptions","organizations_url":"https://api.github.com/users/Clarifai/orgs","repos_url":"https://api.github.com/users/Clarifai/repos","events_url":"https://api.github.com/users/Clarifai/events{/privacy}","received_events_url":"https://api.github.com/users/Clarifai/received_events","type":"Organization","site_admin":false},"repo":{"id":49165232,"name":"kubernetes","full_name":"Clarifai/kubernetes","owner":{"login":"Clarifai","id":8550654,"avatar_url":"https://avatars.githubusercontent.com/u/8550654?v=3","gravatar_id":"","url":"https://api.github.com/users/Clarifai","html_url":"https://github.com/Clarifai","followers_url":"https://api.github.com/users/Clarifai/followers","following_url":"https://api.github.com/users/Clarifai/following{/other_user}","gists_url":"https://api.github.com/users/Clarifai/gists{/gist_id}","starred_url":"https://api.github.com/users/Clarifai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clarifai/subscriptions","organizations_url":"https://api.github.com/users/Clarifai/orgs","repos_url":"https://api.github.com/users/Clarifai/repos","events_url":"https://api.github.com/users/Clarifai/events{/privacy}","received_events_url":"https://api.github.com/users/Clarifai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clarifai/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/Clarifai/kubernetes","forks_url":"https://api.github.com/repos/Clarifai/kubernetes/forks","keys_url":"https://api.github.com/repos/Clarifai/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clarifai/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clarifai/kubernetes/teams","hooks_url":"https://api.github.com/repos/Clarifai/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Clarifai/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Clarifai/kubernetes/events","assignees_url":"https://api.github.com/repos/Clarifai/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Clarifai/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Clarifai/kubernetes/tags","blobs_url":"https://api.github.com/repos/Clarifai/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clarifai/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clarifai/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clarifai/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clarifai/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Clarifai/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Clarifai/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Clarifai/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Clarifai/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Clarifai/kubernetes/subscription","commits_url":"https://api.github.com/repos/Clarifai/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clarifai/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clarifai/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clarifai/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clarifai/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Clarifai/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clarifai/kubernetes/merges","archive_url":"https://api.github.com/repos/Clarifai/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clarifai/kubernetes/downloads","issues_url":"https://api.github.com/repos/Clarifai/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Clarifai/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Clarifai/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Clarifai/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clarifai/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Clarifai/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Clarifai/kubernetes/deployments","created_at":"2016-01-06T22:19:11Z","updated_at":"2016-01-11T08:28:58Z","pushed_at":"2016-05-09T23:20:23Z","git_url":"git://github.com/Clarifai/kubernetes.git","ssh_url":"git@github.com:Clarifai/kubernetes.git","clone_url":"https://github.com/Clarifai/kubernetes.git","svn_url":"https://github.com/Clarifai/kubernetes","homepage":"http://kubernetes.io","size":189712,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3a4f179c751f682b7a30f47dc22bba83ad5af8f9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-10T14:45:09Z","pushed_at":"2016-05-10T15:00:01Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":391765,"stargazers_count":14295,"watchers_count":14295,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4288,"mirror_url":null,"open_issues_count":3573,"forks":4288,"open_issues":3573,"watchers":14295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23495"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23495"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23495/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23495/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/898df1f52b1fdabacb6c6b0f7faaf0e2691fad90"}}}}