{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/89256438","pull_request_review_id":9802988,"id":89256438,"diff_hunk":"@@ -119,11 +119,14 @@ func (plugin *vsphereVolumePlugin) newUnmounterInternal(volName string, podUID t\n }\n \n func (plugin *vsphereVolumePlugin) ConstructVolumeSpec(volumeName, mountPath string) (*volume.Spec, error) {\n+\tmounter := plugin.host.GetMounter()\n+\tpluginDir := plugin.host.GetPluginDir(plugin.GetPluginName())\n+\tvolumePath, _ := mounter.GetDeviceNameFromMount(mountPath, pluginDir)\n \tvsphereVolume := &api.Volume{","path":"pkg/volume/vsphere_volume/vsphere_volume.go","position":7,"original_position":7,"commit_id":"9bca93ed30bb1b0296105b6596510867289ee4dc","original_commit_id":"9bca93ed30bb1b0296105b6596510867289ee4dc","user":{"login":"abrarshivani","id":1269660,"avatar_url":"https://avatars.githubusercontent.com/u/1269660?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarshivani","html_url":"https://github.com/abrarshivani","followers_url":"https://api.github.com/users/abrarshivani/followers","following_url":"https://api.github.com/users/abrarshivani/following{/other_user}","gists_url":"https://api.github.com/users/abrarshivani/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarshivani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarshivani/subscriptions","organizations_url":"https://api.github.com/users/abrarshivani/orgs","repos_url":"https://api.github.com/users/abrarshivani/repos","events_url":"https://api.github.com/users/abrarshivani/events{/privacy}","received_events_url":"https://api.github.com/users/abrarshivani/received_events","type":"User","site_admin":false},"body":"Add volumePath to log ","created_at":"2016-11-23T04:49:22Z","updated_at":"2016-11-23T04:49:43Z","html_url":"https://github.com/kubernetes/kubernetes/pull/37332#discussion_r89256438","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/89256438"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37332#discussion_r89256438"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332","id":94932670,"html_url":"https://github.com/kubernetes/kubernetes/pull/37332","diff_url":"https://github.com/kubernetes/kubernetes/pull/37332.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37332.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332","number":37332,"state":"open","locked":false,"title":"kubernetes attempts to unmount a wrong vSphere volume and stops making any progress after that","user":{"login":"BaluDontu","id":22899615,"avatar_url":"https://avatars.githubusercontent.com/u/22899615?v=3","gravatar_id":"","url":"https://api.github.com/users/BaluDontu","html_url":"https://github.com/BaluDontu","followers_url":"https://api.github.com/users/BaluDontu/followers","following_url":"https://api.github.com/users/BaluDontu/following{/other_user}","gists_url":"https://api.github.com/users/BaluDontu/gists{/gist_id}","starred_url":"https://api.github.com/users/BaluDontu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaluDontu/subscriptions","organizations_url":"https://api.github.com/users/BaluDontu/orgs","repos_url":"https://api.github.com/users/BaluDontu/repos","events_url":"https://api.github.com/users/BaluDontu/events{/privacy}","received_events_url":"https://api.github.com/users/BaluDontu/received_events","type":"User","site_admin":false},"body":"Kubernetes attempts to unmount a wrong vSphere volume in v1.4.5. This fix addresses issue #37022 \r\n\r\nThe following steps are made to reproduce the issue:\r\n1. kubectl create -f guestbook.yaml\r\nA deployment is created with a volume spec - \"hello-master\" and volumePath - \"[datastore1] kubevols/sample-volume\". At this point, the pod has the volume \"[datastore1]kubevols/sample-volume\" mounted on it.\r\n\r\n2. kubectl delete -f guestbook.yaml\r\nWhen the deployment is deleted, kubernetes attempts to unmount the volume with volumeName - hello-master. Since it cannot find the volume \"hello-master\" mounted on the node, it stalls and doesn't make any progress after it.\r\n\r\nBecause of this, any subsequent recreation of deployments fails to mount the volume on the node as  the node stalls.\r\n\r\nThis problem occurred after fixing for issue #33203 on kubernetes repo -  Fix volume states out of sync problem after kubelet restarts. There were changes to SYNC loop logic in this fix.\r\n\r\nThere are 2 fixes that needs to made on 1.4.5 branch\r\n1. The changes to constructVolumeSpec() in the vSphere plugin to get the volumePath instead of volumeName.\r\n2. The changes to getDeviceNameFromMount() to get the full volumePath - \"[datastore1]kubevols/sample-volume\" instead of the just base of the volumePath -\"sample-volume\". I just observed that this function is fixed as a part of #36840 on master branch.\r\n\r\nAfter these changes, the deployment creations and deletions worked perfectly fine. Also the recreation of the deployment worked fine. The volumes are mounted to the pods correctly.\r\n\r\n@abrarshivani @kerneltime \r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/37332)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-11-23T01:49:14Z","updated_at":"2016-11-23T04:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e8c9d90bd3bdb8b3621b12eb72930f0fa9baa51","assignee":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"assignees":[{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":131,"closed_issues":828,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-11-23T04:45:25Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9bca93ed30bb1b0296105b6596510867289ee4dc","head":{"label":"vmware:FixUnmountVolume","ref":"FixUnmountVolume","sha":"9bca93ed30bb1b0296105b6596510867289ee4dc","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49536898,"name":"kubernetes","full_name":"vmware/kubernetes","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/vmware/kubernetes","forks_url":"https://api.github.com/repos/vmware/kubernetes/forks","keys_url":"https://api.github.com/repos/vmware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/kubernetes/events","assignees_url":"https://api.github.com/repos/vmware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmware/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/kubernetes/merges","archive_url":"https://api.github.com/repos/vmware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/kubernetes/deployments","created_at":"2016-01-12T23:58:29Z","updated_at":"2016-11-04T08:04:24Z","pushed_at":"2016-11-23T01:07:29Z","git_url":"git://github.com/vmware/kubernetes.git","ssh_url":"git@github.com:vmware/kubernetes.git","clone_url":"https://github.com/vmware/kubernetes.git","svn_url":"https://github.com/vmware/kubernetes","homepage":"http://kubernetes.io","size":347267,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":6,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d5402e63a3789b259da63c46667f89205d557c81","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-11-23T03:45:08Z","pushed_at":"2016-11-23T04:45:25Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":636914,"stargazers_count":18598,"watchers_count":18598,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6145,"mirror_url":null,"open_issues_count":5240,"forks":6145,"open_issues":5240,"watchers":18598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37332"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9bca93ed30bb1b0296105b6596510867289ee4dc"}}}}
{"actor":{"display_login":"abrarshivani"}}