{"action":"created","issue":{"url":"https://api.github.com/repos/stevefaulkner/HTML5accessibility/issues/26","repository_url":"https://api.github.com/repos/stevefaulkner/HTML5accessibility","labels_url":"https://api.github.com/repos/stevefaulkner/HTML5accessibility/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/stevefaulkner/HTML5accessibility/issues/26/comments","events_url":"https://api.github.com/repos/stevefaulkner/HTML5accessibility/issues/26/events","html_url":"https://github.com/stevefaulkner/HTML5accessibility/issues/26","id":150025992,"number":26,"title":"Remove aria-pressed from expand/collapse buttons","user":{"login":"LjWatson","id":3501033,"avatar_url":"https://avatars.githubusercontent.com/u/3501033?v=3","gravatar_id":"","url":"https://api.github.com/users/LjWatson","html_url":"https://github.com/LjWatson","followers_url":"https://api.github.com/users/LjWatson/followers","following_url":"https://api.github.com/users/LjWatson/following{/other_user}","gists_url":"https://api.github.com/users/LjWatson/gists{/gist_id}","starred_url":"https://api.github.com/users/LjWatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LjWatson/subscriptions","organizations_url":"https://api.github.com/users/LjWatson/orgs","repos_url":"https://api.github.com/users/LjWatson/repos","events_url":"https://api.github.com/users/LjWatson/events{/privacy}","received_events_url":"https://api.github.com/users/LjWatson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-21T09:58:25Z","updated_at":"2016-04-25T00:59:39Z","closed_at":null,"body":"Would remove aria-pressed from the expand/collapse buttons. The attribute makes it a toggle button, in which case the label of the button shouldn't change.\r\n\r\nFrom ARIA 1.1 APG 2.6 button [1]:\r\n\r\n\"Toggle button: A two-state button that can be either off (not pressed) or on (pressed). To tell assistive technologies that a button is a toggle button, specify a value for the attribute aria-pressed… Important: the label on a toggle button should never change when the state changes.\"\r\n\r\n[1] https://www.w3.org/TR/2016/WD-wai-aria-practices-1.1-20160317/#button\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/stevefaulkner/HTML5accessibility/issues/comments/214077843","html_url":"https://github.com/stevefaulkner/HTML5accessibility/issues/26#issuecomment-214077843","issue_url":"https://api.github.com/repos/stevefaulkner/HTML5accessibility/issues/26","id":214077843,"user":{"login":"dstorey","id":465069,"avatar_url":"https://avatars.githubusercontent.com/u/465069?v=3","gravatar_id":"","url":"https://api.github.com/users/dstorey","html_url":"https://github.com/dstorey","followers_url":"https://api.github.com/users/dstorey/followers","following_url":"https://api.github.com/users/dstorey/following{/other_user}","gists_url":"https://api.github.com/users/dstorey/gists{/gist_id}","starred_url":"https://api.github.com/users/dstorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstorey/subscriptions","organizations_url":"https://api.github.com/users/dstorey/orgs","repos_url":"https://api.github.com/users/dstorey/repos","events_url":"https://api.github.com/users/dstorey/events{/privacy}","received_events_url":"https://api.github.com/users/dstorey/received_events","type":"User","site_admin":false},"created_at":"2016-04-25T00:59:39Z","updated_at":"2016-04-25T00:59:39Z","body":"@LjWatson comments:\r\n\r\n* The button text is visually hidden and replaced by a plus or minus icon (depending on expand/collapse state), so it can contain which ever text you think is most appropriate. The only limit I have on the button text is that they're programatically created to make it easier to maintain the file by hand and stop people making mistakes when editing. I could probably just pull the text content from the links, or perhaps the full  TD.\r\n\r\nFor the link text, were you expecting it to be the spec, mostly because you're used to editing specs where that is the link text? There isn't any thing in the text to suggest it is the spec or the test. I'd prefer to not add a spec link as it is double the maintenance, more UI to scan through, and the spec is linked from the test pages. I'd argue that for this test the spec for the element is the least important spec. The HTML and Core AAM specs, plus perhaps the name/description specs are more relevant to how accessible the elements are. All of those are linked from the test pages too.\r\n\r\nWould the links be more clear if the accessible description / help text for each one mentioned where they go? For this I'd probably use the title attribute as it is just as much an issue for sighted users as screen reader users. I was thinking something like:\r\n\r\n````HTML\r\n<a href=\"#\" title=\"test file for article\">article</a>\r\n````\r\n\r\nTo make that easier to maintain I could probably do the same as the buttons and inject via JS by pulling in the anchor element text content. "}}