{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/88867590","pull_request_review_id":9422786,"id":88867590,"diff_hunk":"@@ -977,8 +1075,44 @@ void PolicyHandler::OnActivateApp(uint32_t connection_key,\n     }\n   } else {\n     permissions = policy_manager_->GetAppPermissionsChanges(policy_app_id);\n+#ifdef EXTENDED_PROPRIETARY\n+    UsageStatistics& usage = app->usage_report();\n+\n+    usage.RecordAppUserSelection();\n+    DeviceParams device_params = GetDeviceParams(\n+        app->device(),\n+        application_manager_.connection_handler().get_session_observer());\n+    permissions.deviceInfo = device_params;\n+\n+    DeviceConsent consent = policy_manager_->GetUserConsentForDevice(\n+        permissions.deviceInfo.device_mac_address);\n+    permissions.isSDLAllowed = kDeviceAllowed == consent ? true : false;\n+\n+    // According to the SDLAQ-CRS-2794, p.9\n+    // 'priority' should be ommited in case when device\n+    // is not allowed.\n+    if (permissions.isSDLAllowed == false) {","path":"src/components/application_manager/src/policies/policy_handler.cc","position":227,"original_position":227,"commit_id":"1f0c6f89ec2af597e7c0a2d45ecd799a5af35348","original_commit_id":"48446e29c29fd7fc38d33bdbe95d86a8d7390a2e","user":{"login":"orhan-mehmedov","id":20279277,"avatar_url":"https://avatars.githubusercontent.com/u/20279277?v=3","gravatar_id":"","url":"https://api.github.com/users/orhan-mehmedov","html_url":"https://github.com/orhan-mehmedov","followers_url":"https://api.github.com/users/orhan-mehmedov/followers","following_url":"https://api.github.com/users/orhan-mehmedov/following{/other_user}","gists_url":"https://api.github.com/users/orhan-mehmedov/gists{/gist_id}","starred_url":"https://api.github.com/users/orhan-mehmedov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orhan-mehmedov/subscriptions","organizations_url":"https://api.github.com/users/orhan-mehmedov/orgs","repos_url":"https://api.github.com/users/orhan-mehmedov/repos","events_url":"https://api.github.com/users/orhan-mehmedov/events{/privacy}","received_events_url":"https://api.github.com/users/orhan-mehmedov/received_events","type":"User","site_admin":false},"body":"@LuxoftAKutsan just !permissions.isSDLAllowed. At least is used few lines below. In one or other way good to be consistent.","created_at":"2016-11-21T10:38:36Z","updated_at":"2016-11-21T10:52:21Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/1054#discussion_r88867590","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/88867590"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/1054#discussion_r88867590"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054","id":94574334,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/1054","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/1054.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/1054.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1054","number":1054,"state":"open","locked":false,"title":"Feature/support extended proprietary policy","user":{"login":"LuxoftAKutsan","id":11158563,"avatar_url":"https://avatars.githubusercontent.com/u/11158563?v=3","gravatar_id":"","url":"https://api.github.com/users/LuxoftAKutsan","html_url":"https://github.com/LuxoftAKutsan","followers_url":"https://api.github.com/users/LuxoftAKutsan/followers","following_url":"https://api.github.com/users/LuxoftAKutsan/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftAKutsan/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftAKutsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftAKutsan/subscriptions","organizations_url":"https://api.github.com/users/LuxoftAKutsan/orgs","repos_url":"https://api.github.com/users/LuxoftAKutsan/repos","events_url":"https://api.github.com/users/LuxoftAKutsan/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftAKutsan/received_events","type":"User","site_admin":false},"body":"Add extended proprietary policy flow\r\nChanges moved from F-S commit Feature/support extended proprietary policy\r\nPartially reviewed in  #1053 ","created_at":"2016-11-21T08:51:36Z","updated_at":"2016-11-21T10:52:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43897050a02586c0c9b691b61c5bbb91e7b88e5e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1054/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/1f0c6f89ec2af597e7c0a2d45ecd799a5af35348","head":{"label":"smartdevicelink:feature/support_extended_propriatary_policy","ref":"feature/support_extended_propriatary_policy","sha":"1f0c6f89ec2af597e7c0a2d45ecd799a5af35348","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-11-18T02:52:43Z","pushed_at":"2016-11-21T09:55:14Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":315763,"stargazers_count":84,"watchers_count":84,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":178,"forks":104,"open_issues":178,"watchers":84,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"d98c8a8b40942efc4c0cee159687ee4c6c1317f6","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-11-18T02:52:43Z","pushed_at":"2016-11-21T09:55:14Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":315763,"stargazers_count":84,"watchers_count":84,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":178,"forks":104,"open_issues":178,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/1054"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1054"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/1f0c6f89ec2af597e7c0a2d45ecd799a5af35348"}}}}
{"actor":{"display_login":"orhan-mehmedov"}}