{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/comments/84053071","pull_request_review_id":4854183,"id":84053071,"diff_hunk":"@@ -2,6 +2,12 @@\n require \"publishing_api_finder_publisher\"\n \n describe PublishingApiFinderPublisher do\n+  before do\n+    @schema_type = GovukContentSchemaTestHelpers.configuration.schema_type\n+    GovukContentSchemaTestHelpers.configuration.schema_type = \"publisher\"","path":"spec/lib/publishing_api_finder_publisher_spec.rb","position":6,"original_position":6,"commit_id":"c20785f2d9897ff3d1a581ae37f078769f3fadcc","original_commit_id":"c20785f2d9897ff3d1a581ae37f078769f3fadcc","user":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars.githubusercontent.com/u/233676?v=3","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"body":"This means we won't be able to remove the old v1 schemas from content schemas. We could also remove this test or `skip: true` it? ","created_at":"2016-10-19T11:57:49Z","updated_at":"2016-10-19T11:57:49Z","html_url":"https://github.com/alphagov/manuals-publisher/pull/757#discussion_r84053071","pull_request_url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757","_links":{"self":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/comments/84053071"},"html":{"href":"https://github.com/alphagov/manuals-publisher/pull/757#discussion_r84053071"},"pull_request":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757","id":89964749,"html_url":"https://github.com/alphagov/manuals-publisher/pull/757","diff_url":"https://github.com/alphagov/manuals-publisher/pull/757.diff","patch_url":"https://github.com/alphagov/manuals-publisher/pull/757.patch","issue_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues/757","number":757,"state":"open","locked":false,"title":"Manuals to use V2 of the Publishing API","user":{"login":"kevindew","id":282717,"avatar_url":"https://avatars.githubusercontent.com/u/282717?v=3","gravatar_id":"","url":"https://api.github.com/users/kevindew","html_url":"https://github.com/kevindew","followers_url":"https://api.github.com/users/kevindew/followers","following_url":"https://api.github.com/users/kevindew/following{/other_user}","gists_url":"https://api.github.com/users/kevindew/gists{/gist_id}","starred_url":"https://api.github.com/users/kevindew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevindew/subscriptions","organizations_url":"https://api.github.com/users/kevindew/orgs","repos_url":"https://api.github.com/users/kevindew/repos","events_url":"https://api.github.com/users/kevindew/events{/privacy}","received_events_url":"https://api.github.com/users/kevindew/received_events","type":"User","site_admin":false},"body":"This updates the API methods to use V2 of the Publishing API rather than the V1 endpoints. Thus the approach has changed somewhat from pushing full content items to instead push only a full representation to PUT content and just a small one to publish and unpublish. This has meant creating new exporter classes that represent this distinction.\r\n\r\nAs part of this work I've:\r\n- Changed it so the publish button only shows when you have a draft (you receive an error on V2 of the Publishing API if you try to publish a published item)\r\n- Updated published state to be draft whenever you update an item (I assume it's a bug that this doesn't happen already as the submit button says \"Save as Draft\")\r\n- Discard drafts from Publishing API when the delete task is run","created_at":"2016-10-19T08:42:57Z","updated_at":"2016-10-19T11:57:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95f0066059e6fca2cc94894a183dbe0be0611387","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757/commits","review_comments_url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757/comments","review_comment_url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues/757/comments","statuses_url":"https://api.github.com/repos/alphagov/manuals-publisher/statuses/c20785f2d9897ff3d1a581ae37f078769f3fadcc","head":{"label":"alphagov:publishing-api-v2","ref":"publishing-api-v2","sha":"c20785f2d9897ff3d1a581ae37f078769f3fadcc","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"manuals-publisher","full_name":"alphagov/manuals-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/manuals-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/manuals-publisher","forks_url":"https://api.github.com/repos/alphagov/manuals-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/manuals-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/manuals-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/manuals-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/manuals-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/manuals-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/manuals-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/manuals-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/manuals-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/manuals-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/manuals-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/manuals-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/manuals-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/manuals-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/manuals-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/manuals-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/manuals-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/manuals-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/manuals-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/manuals-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/manuals-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/manuals-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/manuals-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/manuals-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/manuals-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/manuals-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/manuals-publisher/deployments","created_at":"2014-01-23T15:21:42Z","updated_at":"2016-09-16T11:04:18Z","pushed_at":"2016-10-19T10:25:59Z","git_url":"git://github.com/alphagov/manuals-publisher.git","ssh_url":"git@github.com:alphagov/manuals-publisher.git","clone_url":"https://github.com/alphagov/manuals-publisher.git","svn_url":"https://github.com/alphagov/manuals-publisher","homepage":"","size":5922,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"abe44257a134cfb13c6e2b6de2aa59ba159a6586","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176198,"name":"manuals-publisher","full_name":"alphagov/manuals-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/manuals-publisher","description":"Publishing App for Specialist Documents and Manuals on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/manuals-publisher","forks_url":"https://api.github.com/repos/alphagov/manuals-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/manuals-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/manuals-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/manuals-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/manuals-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/manuals-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/manuals-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/manuals-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/manuals-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/manuals-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/manuals-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/manuals-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/manuals-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/manuals-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/manuals-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/manuals-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/manuals-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/manuals-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/manuals-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/manuals-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/manuals-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/manuals-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/manuals-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/manuals-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/manuals-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/manuals-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/manuals-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/manuals-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/manuals-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/manuals-publisher/deployments","created_at":"2014-01-23T15:21:42Z","updated_at":"2016-09-16T11:04:18Z","pushed_at":"2016-10-19T10:25:59Z","git_url":"git://github.com/alphagov/manuals-publisher.git","ssh_url":"git@github.com:alphagov/manuals-publisher.git","clone_url":"https://github.com/alphagov/manuals-publisher.git","svn_url":"https://github.com/alphagov/manuals-publisher","homepage":"","size":5922,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757"},"html":{"href":"https://github.com/alphagov/manuals-publisher/pull/757"},"issue":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/issues/757"},"comments":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/manuals-publisher/statuses/c20785f2d9897ff3d1a581ae37f078769f3fadcc"}}}}
{"actor":{"display_login":"tijmenb"}}