{"action":"created","issue":{"url":"https://api.github.com/repos/tapio/rlutil/issues/50","repository_url":"https://api.github.com/repos/tapio/rlutil","labels_url":"https://api.github.com/repos/tapio/rlutil/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/tapio/rlutil/issues/50/comments","events_url":"https://api.github.com/repos/tapio/rlutil/issues/50/events","html_url":"https://github.com/tapio/rlutil/issues/50","id":181123348,"number":50,"title":"`setConsoleTitle` strings","user":{"login":"MangaD","id":11088596,"avatar_url":"https://avatars.githubusercontent.com/u/11088596?v=3","gravatar_id":"","url":"https://api.github.com/users/MangaD","html_url":"https://github.com/MangaD","followers_url":"https://api.github.com/users/MangaD/followers","following_url":"https://api.github.com/users/MangaD/following{/other_user}","gists_url":"https://api.github.com/users/MangaD/gists{/gist_id}","starred_url":"https://api.github.com/users/MangaD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MangaD/subscriptions","organizations_url":"https://api.github.com/users/MangaD/orgs","repos_url":"https://api.github.com/users/MangaD/repos","events_url":"https://api.github.com/users/MangaD/events{/privacy}","received_events_url":"https://api.github.com/users/MangaD/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-05T11:01:04Z","updated_at":"2016-10-05T19:41:08Z","closed_at":null,"body":"There is a problem with the `setConsoleTitle` function. It uses `const char *` as string parameter for the print function when compiling with C++. This seems to be a problem because when compiling with clang++ and with the flag `-fsanitizer=memory`, I just get a warning about uninitialized value at the line:\r\n`RLUTIL_PRINT(true_title);`\r\n\r\nSo, I'd advise to change the code of that function to:\r\n```\r\nRLUTIL_INLINE void setConsoleTitle(RLUTIL_STRING_T title) {\r\n#if defined(_WIN32) && !defined(RLUTIL_USE_ANSI)\r\n#ifdef __cplusplus\r\n\tSetConsoleTitleA(title.c_str());\r\n#else\r\n\tSetConsoleTitleA(title);\r\n#endif\r\n#else\r\n\tRLUTIL_PRINT(ANSI_CONSOLE_TITLE_PRE);\r\n\tRLUTIL_PRINT(title);\r\n\tRLUTIL_PRINT(ANSI_CONSOLE_TITLE_POST);\r\n#endif // defined(_WIN32) && !defined(RLUTIL_USE_ANSI)\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/tapio/rlutil/issues/comments/251777500","html_url":"https://github.com/tapio/rlutil/issues/50#issuecomment-251777500","issue_url":"https://api.github.com/repos/tapio/rlutil/issues/50","id":251777500,"user":{"login":"nabijaczleweli","id":6709544,"avatar_url":"https://avatars.githubusercontent.com/u/6709544?v=3","gravatar_id":"","url":"https://api.github.com/users/nabijaczleweli","html_url":"https://github.com/nabijaczleweli","followers_url":"https://api.github.com/users/nabijaczleweli/followers","following_url":"https://api.github.com/users/nabijaczleweli/following{/other_user}","gists_url":"https://api.github.com/users/nabijaczleweli/gists{/gist_id}","starred_url":"https://api.github.com/users/nabijaczleweli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabijaczleweli/subscriptions","organizations_url":"https://api.github.com/users/nabijaczleweli/orgs","repos_url":"https://api.github.com/users/nabijaczleweli/repos","events_url":"https://api.github.com/users/nabijaczleweli/events{/privacy}","received_events_url":"https://api.github.com/users/nabijaczleweli/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T19:41:08Z","updated_at":"2016-10-05T19:41:08Z","body":"It did seem to be :P"}}
{"actor":{"display_login":"nabijaczleweli"}}