{"action":"created","comment":{"url":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/comments/79325059","id":79325059,"diff_hunk":"@@ -23,6 +23,17 @@ html, body {\n   height: 100%;\n }\n \n+.flexbox-container {\n+  display: flex;\n+  flex-direction: column;\n+  justify-content: space-between;\n+  min-height: 100vh;\n+}\n+\n+.flexbox-spacer {\n+  flex-grow: 2;","path":"app/styles/main.scss","position":12,"original_position":12,"commit_id":"e5e5f15d49a83c09732f38a6db41f45837143aa2","original_commit_id":"e5e5f15d49a83c09732f38a6db41f45837143aa2","user":{"login":"JoshSmith","id":321667,"avatar_url":"https://avatars.githubusercontent.com/u/321667?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshSmith","html_url":"https://github.com/JoshSmith","followers_url":"https://api.github.com/users/JoshSmith/followers","following_url":"https://api.github.com/users/JoshSmith/following{/other_user}","gists_url":"https://api.github.com/users/JoshSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshSmith/subscriptions","organizations_url":"https://api.github.com/users/JoshSmith/orgs","repos_url":"https://api.github.com/users/JoshSmith/repos","events_url":"https://api.github.com/users/JoshSmith/events{/privacy}","received_events_url":"https://api.github.com/users/JoshSmith/received_events","type":"User","site_admin":false},"body":"Yeah, I would change to that. It looks clearer to me and does what it says: fills the space completely.","created_at":"2016-09-19T03:35:17Z","updated_at":"2016-09-19T03:35:17Z","html_url":"https://github.com/code-corps/code-corps-ember/pull/453#discussion_r79325059","pull_request_url":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453","_links":{"self":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/comments/79325059"},"html":{"href":"https://github.com/code-corps/code-corps-ember/pull/453#discussion_r79325059"},"pull_request":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453","id":85731772,"html_url":"https://github.com/code-corps/code-corps-ember/pull/453","diff_url":"https://github.com/code-corps/code-corps-ember/pull/453.diff","patch_url":"https://github.com/code-corps/code-corps-ember/pull/453.patch","issue_url":"https://api.github.com/repos/code-corps/code-corps-ember/issues/453","number":453,"state":"open","locked":false,"title":"Make footer sticky by adding flexbox container around nav, body, and …","user":{"login":"appleJax","id":13618860,"avatar_url":"https://avatars.githubusercontent.com/u/13618860?v=3","gravatar_id":"","url":"https://api.github.com/users/appleJax","html_url":"https://github.com/appleJax","followers_url":"https://api.github.com/users/appleJax/followers","following_url":"https://api.github.com/users/appleJax/following{/other_user}","gists_url":"https://api.github.com/users/appleJax/gists{/gist_id}","starred_url":"https://api.github.com/users/appleJax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleJax/subscriptions","organizations_url":"https://api.github.com/users/appleJax/orgs","repos_url":"https://api.github.com/users/appleJax/repos","events_url":"https://api.github.com/users/appleJax/events{/privacy}","received_events_url":"https://api.github.com/users/appleJax/received_events","type":"User","site_admin":false},"body":"# What's in this PR?\r\n\r\nAdds a .flexbox-container div around the nav, body, and footer to make footer stick to bottom of screen.\r\n\r\nAlso adds a .flexbox-spacer div beween the body and footer to make the body appear as normal (without the spacer, the body is centered between the nav and footer, leaving more space between the nav and body)\r\n\r\nStyles for .flexbox-container:\r\n- flex-direction: column\r\n- justify-content: space-between\r\n- min-height: 100vh\r\n\r\nStyles for .flexbox-spacer:\r\n- flex-grow: 2\r\n\r\nBefore:\r\n\r\n![screen shot 2016-09-18 at 6 45 17 pm](https://cloud.githubusercontent.com/assets/13618860/18621162/4c1c9306-7dd4-11e6-90d8-7a2c4d54f157.png)\r\n\r\nAfter:\r\n\r\n![screen shot 2016-09-18 at 7 05 16 pm](https://cloud.githubusercontent.com/assets/13618860/18621168/541b6492-7dd4-11e6-89b5-b539f940da4b.png)\r\n\r\nAlternate option without spacer (NOT PART OF THIS PR, SHOWN ONLY FOR COMPARISON):\r\n\r\n![screen shot 2016-09-18 at 6 43 02 pm](https://cloud.githubusercontent.com/assets/13618860/18621192/8f37b4f4-7dd4-11e6-90dd-9d553e40eacf.png)\r\n\r\n\r\n","created_at":"2016-09-19T02:17:49Z","updated_at":"2016-09-19T03:35:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6bca0de838a0c14b9cb5f3ad1365fadd2fa6eca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453/commits","review_comments_url":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453/comments","review_comment_url":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-corps/code-corps-ember/issues/453/comments","statuses_url":"https://api.github.com/repos/code-corps/code-corps-ember/statuses/e5e5f15d49a83c09732f38a6db41f45837143aa2","head":{"label":"appleJax:sticky-footer","ref":"sticky-footer","sha":"e5e5f15d49a83c09732f38a6db41f45837143aa2","user":{"login":"appleJax","id":13618860,"avatar_url":"https://avatars.githubusercontent.com/u/13618860?v=3","gravatar_id":"","url":"https://api.github.com/users/appleJax","html_url":"https://github.com/appleJax","followers_url":"https://api.github.com/users/appleJax/followers","following_url":"https://api.github.com/users/appleJax/following{/other_user}","gists_url":"https://api.github.com/users/appleJax/gists{/gist_id}","starred_url":"https://api.github.com/users/appleJax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleJax/subscriptions","organizations_url":"https://api.github.com/users/appleJax/orgs","repos_url":"https://api.github.com/users/appleJax/repos","events_url":"https://api.github.com/users/appleJax/events{/privacy}","received_events_url":"https://api.github.com/users/appleJax/received_events","type":"User","site_admin":false},"repo":{"id":66174507,"name":"code-corps-ember","full_name":"appleJax/code-corps-ember","owner":{"login":"appleJax","id":13618860,"avatar_url":"https://avatars.githubusercontent.com/u/13618860?v=3","gravatar_id":"","url":"https://api.github.com/users/appleJax","html_url":"https://github.com/appleJax","followers_url":"https://api.github.com/users/appleJax/followers","following_url":"https://api.github.com/users/appleJax/following{/other_user}","gists_url":"https://api.github.com/users/appleJax/gists{/gist_id}","starred_url":"https://api.github.com/users/appleJax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleJax/subscriptions","organizations_url":"https://api.github.com/users/appleJax/orgs","repos_url":"https://api.github.com/users/appleJax/repos","events_url":"https://api.github.com/users/appleJax/events{/privacy}","received_events_url":"https://api.github.com/users/appleJax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/appleJax/code-corps-ember","description":"Ember front-end for Code Corps.","fork":true,"url":"https://api.github.com/repos/appleJax/code-corps-ember","forks_url":"https://api.github.com/repos/appleJax/code-corps-ember/forks","keys_url":"https://api.github.com/repos/appleJax/code-corps-ember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleJax/code-corps-ember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleJax/code-corps-ember/teams","hooks_url":"https://api.github.com/repos/appleJax/code-corps-ember/hooks","issue_events_url":"https://api.github.com/repos/appleJax/code-corps-ember/issues/events{/number}","events_url":"https://api.github.com/repos/appleJax/code-corps-ember/events","assignees_url":"https://api.github.com/repos/appleJax/code-corps-ember/assignees{/user}","branches_url":"https://api.github.com/repos/appleJax/code-corps-ember/branches{/branch}","tags_url":"https://api.github.com/repos/appleJax/code-corps-ember/tags","blobs_url":"https://api.github.com/repos/appleJax/code-corps-ember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleJax/code-corps-ember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleJax/code-corps-ember/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleJax/code-corps-ember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleJax/code-corps-ember/statuses/{sha}","languages_url":"https://api.github.com/repos/appleJax/code-corps-ember/languages","stargazers_url":"https://api.github.com/repos/appleJax/code-corps-ember/stargazers","contributors_url":"https://api.github.com/repos/appleJax/code-corps-ember/contributors","subscribers_url":"https://api.github.com/repos/appleJax/code-corps-ember/subscribers","subscription_url":"https://api.github.com/repos/appleJax/code-corps-ember/subscription","commits_url":"https://api.github.com/repos/appleJax/code-corps-ember/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleJax/code-corps-ember/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleJax/code-corps-ember/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleJax/code-corps-ember/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleJax/code-corps-ember/contents/{+path}","compare_url":"https://api.github.com/repos/appleJax/code-corps-ember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleJax/code-corps-ember/merges","archive_url":"https://api.github.com/repos/appleJax/code-corps-ember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleJax/code-corps-ember/downloads","issues_url":"https://api.github.com/repos/appleJax/code-corps-ember/issues{/number}","pulls_url":"https://api.github.com/repos/appleJax/code-corps-ember/pulls{/number}","milestones_url":"https://api.github.com/repos/appleJax/code-corps-ember/milestones{/number}","notifications_url":"https://api.github.com/repos/appleJax/code-corps-ember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleJax/code-corps-ember/labels{/name}","releases_url":"https://api.github.com/repos/appleJax/code-corps-ember/releases{/id}","deployments_url":"https://api.github.com/repos/appleJax/code-corps-ember/deployments","created_at":"2016-08-21T00:41:38Z","updated_at":"2016-08-21T00:41:42Z","pushed_at":"2016-09-19T02:10:49Z","git_url":"git://github.com/appleJax/code-corps-ember.git","ssh_url":"git@github.com:appleJax/code-corps-ember.git","clone_url":"https://github.com/appleJax/code-corps-ember.git","svn_url":"https://github.com/appleJax/code-corps-ember","homepage":"https://codecorps.org","size":2049,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"code-corps:develop","ref":"develop","sha":"b67983648db4fc06d06aec48077c86516a08d23c","user":{"login":"code-corps","id":12991115,"avatar_url":"https://avatars.githubusercontent.com/u/12991115?v=3","gravatar_id":"","url":"https://api.github.com/users/code-corps","html_url":"https://github.com/code-corps","followers_url":"https://api.github.com/users/code-corps/followers","following_url":"https://api.github.com/users/code-corps/following{/other_user}","gists_url":"https://api.github.com/users/code-corps/gists{/gist_id}","starred_url":"https://api.github.com/users/code-corps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-corps/subscriptions","organizations_url":"https://api.github.com/users/code-corps/orgs","repos_url":"https://api.github.com/users/code-corps/repos","events_url":"https://api.github.com/users/code-corps/events{/privacy}","received_events_url":"https://api.github.com/users/code-corps/received_events","type":"Organization","site_admin":false},"repo":{"id":37887675,"name":"code-corps-ember","full_name":"code-corps/code-corps-ember","owner":{"login":"code-corps","id":12991115,"avatar_url":"https://avatars.githubusercontent.com/u/12991115?v=3","gravatar_id":"","url":"https://api.github.com/users/code-corps","html_url":"https://github.com/code-corps","followers_url":"https://api.github.com/users/code-corps/followers","following_url":"https://api.github.com/users/code-corps/following{/other_user}","gists_url":"https://api.github.com/users/code-corps/gists{/gist_id}","starred_url":"https://api.github.com/users/code-corps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-corps/subscriptions","organizations_url":"https://api.github.com/users/code-corps/orgs","repos_url":"https://api.github.com/users/code-corps/repos","events_url":"https://api.github.com/users/code-corps/events{/privacy}","received_events_url":"https://api.github.com/users/code-corps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-corps/code-corps-ember","description":"Ember front-end for Code Corps.","fork":false,"url":"https://api.github.com/repos/code-corps/code-corps-ember","forks_url":"https://api.github.com/repos/code-corps/code-corps-ember/forks","keys_url":"https://api.github.com/repos/code-corps/code-corps-ember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-corps/code-corps-ember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-corps/code-corps-ember/teams","hooks_url":"https://api.github.com/repos/code-corps/code-corps-ember/hooks","issue_events_url":"https://api.github.com/repos/code-corps/code-corps-ember/issues/events{/number}","events_url":"https://api.github.com/repos/code-corps/code-corps-ember/events","assignees_url":"https://api.github.com/repos/code-corps/code-corps-ember/assignees{/user}","branches_url":"https://api.github.com/repos/code-corps/code-corps-ember/branches{/branch}","tags_url":"https://api.github.com/repos/code-corps/code-corps-ember/tags","blobs_url":"https://api.github.com/repos/code-corps/code-corps-ember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-corps/code-corps-ember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-corps/code-corps-ember/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-corps/code-corps-ember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-corps/code-corps-ember/statuses/{sha}","languages_url":"https://api.github.com/repos/code-corps/code-corps-ember/languages","stargazers_url":"https://api.github.com/repos/code-corps/code-corps-ember/stargazers","contributors_url":"https://api.github.com/repos/code-corps/code-corps-ember/contributors","subscribers_url":"https://api.github.com/repos/code-corps/code-corps-ember/subscribers","subscription_url":"https://api.github.com/repos/code-corps/code-corps-ember/subscription","commits_url":"https://api.github.com/repos/code-corps/code-corps-ember/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-corps/code-corps-ember/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-corps/code-corps-ember/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-corps/code-corps-ember/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-corps/code-corps-ember/contents/{+path}","compare_url":"https://api.github.com/repos/code-corps/code-corps-ember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-corps/code-corps-ember/merges","archive_url":"https://api.github.com/repos/code-corps/code-corps-ember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-corps/code-corps-ember/downloads","issues_url":"https://api.github.com/repos/code-corps/code-corps-ember/issues{/number}","pulls_url":"https://api.github.com/repos/code-corps/code-corps-ember/pulls{/number}","milestones_url":"https://api.github.com/repos/code-corps/code-corps-ember/milestones{/number}","notifications_url":"https://api.github.com/repos/code-corps/code-corps-ember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-corps/code-corps-ember/labels{/name}","releases_url":"https://api.github.com/repos/code-corps/code-corps-ember/releases{/id}","deployments_url":"https://api.github.com/repos/code-corps/code-corps-ember/deployments","created_at":"2015-06-23T00:18:45Z","updated_at":"2016-09-15T19:09:57Z","pushed_at":"2016-09-19T02:17:49Z","git_url":"git://github.com/code-corps/code-corps-ember.git","ssh_url":"git@github.com:code-corps/code-corps-ember.git","clone_url":"https://github.com/code-corps/code-corps-ember.git","svn_url":"https://github.com/code-corps/code-corps-ember","homepage":"https://codecorps.org","size":2098,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":84,"forks":23,"open_issues":84,"watchers":23,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453"},"html":{"href":"https://github.com/code-corps/code-corps-ember/pull/453"},"issue":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/issues/453"},"comments":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/code-corps/code-corps-ember/statuses/e5e5f15d49a83c09732f38a6db41f45837143aa2"}}}}
{"actor":{"display_login":"JoshSmith"}}