{"action":"created","comment":{"url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/comments/72832527","id":72832527,"diff_hunk":"@@ -142,14 +170,18 @@ contributors: Jordan Harband\n \t\t\t1. Else if _type_ is `\"Reject\"`, let _handlerResult_ be Completion{[[Type]]: ~throw~, [[Value]]: _argument_, [[Target]]: ~empty~}.\n \t\t\t1. Else if _type_ is `\"Finally\"`, let _handlerResult_ be NormalCompletion(_argument_).\n \t\t\t1. Assert: _handlerResult_ is defined.\n-\t\t1. Else if _type_ is `\"Finally\"`, let _handlerResult_ be Call(_handler_, *undefined*, &laquo; &raquo;).\n+\t\t1. Else if _type_ is `\"Finally\"`, then\n+\t\t\t1. let _handlerResult_ be Call(_handler_, *undefined*, &laquo; &raquo;).\n+\t\t\t1. If _handlerResult_ is not an abrupt completion, then\n+\t\t\t\t1. Let _handlerPromise_ be ? PromiseResolve(%Promise%, _handlerResult_.[[Value]]).\n+\t\t\t\t1. Let _argumentThunk_ be equivalent to a function that returns _argument_.","path":"spec.emu","position":44,"original_position":44,"commit_id":"996157c2315da2f91fcf2fbbf505db3f21432d01","original_commit_id":"996157c2315da2f91fcf2fbbf505db3f21432d01","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"neat, but can this be described like this without it being considered a layering violation? (I honestly don't know) @domenic ?","created_at":"2016-07-29T17:47:46Z","updated_at":"2016-07-29T17:47:46Z","html_url":"https://github.com/ljharb/proposal-promise-finally/pull/5#discussion_r72832527","pull_request_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/comments/72832527"},"html":{"href":"https://github.com/ljharb/proposal-promise-finally/pull/5#discussion_r72832527"},"pull_request":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5","id":71216788,"html_url":"https://github.com/ljharb/proposal-promise-finally/pull/5","diff_url":"https://github.com/ljharb/proposal-promise-finally/pull/5.diff","patch_url":"https://github.com/ljharb/proposal-promise-finally/pull/5.patch","issue_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/5","number":5,"state":"open","locked":false,"title":"Fix spec","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Attempt to fix #2 and close #1.\r\n\r\nSpec HTML viewable [here](https://rawgit.com/ljharb/proposal-promise-finally/fix_spec/index.html)\r\n\r\nThis attempts to fix the spec by:\r\n1) spec-refactor of Promise.resolve logic so the meat of it is available as an abstract operation\r\n2) use that abstract operation to produce a promise with certainty inside PromiseReactionJob, and resolve that with a thunk for the intended \"argument\".","created_at":"2016-05-24T13:10:25Z","updated_at":"2016-07-29T17:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f15e27c2c9487c5e5c6b212b364cb4076cc37ea6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/5/comments","statuses_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/statuses/996157c2315da2f91fcf2fbbf505db3f21432d01","head":{"label":"ljharb:fix_spec","ref":"fix_spec","sha":"996157c2315da2f91fcf2fbbf505db3f21432d01","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"repo":{"id":58994693,"name":"proposal-promise-finally","full_name":"ljharb/proposal-promise-finally","owner":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljharb/proposal-promise-finally","description":"ECMAScript Proposal, specs, and reference implementation for Promise.prototype.finally","fork":false,"url":"https://api.github.com/repos/ljharb/proposal-promise-finally","forks_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/forks","keys_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/teams","hooks_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/hooks","issue_events_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/events{/number}","events_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/events","assignees_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/assignees{/user}","branches_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/branches{/branch}","tags_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/tags","blobs_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/statuses/{sha}","languages_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/languages","stargazers_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/stargazers","contributors_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/contributors","subscribers_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/subscribers","subscription_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/subscription","commits_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/contents/{+path}","compare_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/merges","archive_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/downloads","issues_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues{/number}","pulls_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls{/number}","milestones_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/milestones{/number}","notifications_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/labels{/name}","releases_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/releases{/id}","deployments_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/deployments","created_at":"2016-05-17T06:01:54Z","updated_at":"2016-05-26T07:45:48Z","pushed_at":"2016-07-29T06:43:34Z","git_url":"git://github.com/ljharb/proposal-promise-finally.git","ssh_url":"git@github.com:ljharb/proposal-promise-finally.git","clone_url":"https://github.com/ljharb/proposal-promise-finally.git","svn_url":"https://github.com/ljharb/proposal-promise-finally","homepage":"http://ljharb.github.io/proposal-promise-finally/","size":52,"stargazers_count":6,"watchers_count":6,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"ljharb:master","ref":"master","sha":"c685deeb54ad2bdf0bc54d2eac5dd31319d5c569","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"repo":{"id":58994693,"name":"proposal-promise-finally","full_name":"ljharb/proposal-promise-finally","owner":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljharb/proposal-promise-finally","description":"ECMAScript Proposal, specs, and reference implementation for Promise.prototype.finally","fork":false,"url":"https://api.github.com/repos/ljharb/proposal-promise-finally","forks_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/forks","keys_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/teams","hooks_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/hooks","issue_events_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/events{/number}","events_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/events","assignees_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/assignees{/user}","branches_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/branches{/branch}","tags_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/tags","blobs_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/statuses/{sha}","languages_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/languages","stargazers_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/stargazers","contributors_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/contributors","subscribers_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/subscribers","subscription_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/subscription","commits_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/contents/{+path}","compare_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/merges","archive_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/downloads","issues_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues{/number}","pulls_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls{/number}","milestones_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/milestones{/number}","notifications_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/labels{/name}","releases_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/releases{/id}","deployments_url":"https://api.github.com/repos/ljharb/proposal-promise-finally/deployments","created_at":"2016-05-17T06:01:54Z","updated_at":"2016-05-26T07:45:48Z","pushed_at":"2016-07-29T06:43:34Z","git_url":"git://github.com/ljharb/proposal-promise-finally.git","ssh_url":"git@github.com:ljharb/proposal-promise-finally.git","clone_url":"https://github.com/ljharb/proposal-promise-finally.git","svn_url":"https://github.com/ljharb/proposal-promise-finally","homepage":"http://ljharb.github.io/proposal-promise-finally/","size":52,"stargazers_count":6,"watchers_count":6,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5"},"html":{"href":"https://github.com/ljharb/proposal-promise-finally/pull/5"},"issue":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/5"},"comments":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ljharb/proposal-promise-finally/statuses/996157c2315da2f91fcf2fbbf505db3f21432d01"}}}}
{"actor":{"display_login":"stefanpenner"}}