{"action":"closed","number":256,"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/256","id":56004761,"html_url":"https://github.com/convox/rack/pull/256","diff_url":"https://github.com/convox/rack/pull/256.diff","patch_url":"https://github.com/convox/rack/pull/256.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/256","number":256,"state":"closed","locked":false,"title":"SSL chain fix","user":{"login":"mattmanning","id":44615,"avatar_url":"https://avatars.githubusercontent.com/u/44615?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmanning","html_url":"https://github.com/mattmanning","followers_url":"https://api.github.com/users/mattmanning/followers","following_url":"https://api.github.com/users/mattmanning/following{/other_user}","gists_url":"https://api.github.com/users/mattmanning/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmanning/subscriptions","organizations_url":"https://api.github.com/users/mattmanning/orgs","repos_url":"https://api.github.com/users/mattmanning/repos","events_url":"https://api.github.com/users/mattmanning/events{/privacy}","received_events_url":"https://api.github.com/users/mattmanning/received_events","type":"User","site_admin":false},"body":"Automatic intermediate cert chain generation was causing problems with the `convox ssl create` command for:\r\n\r\n* Manually-created self-signed certs\r\n* Self signed-certs created with the `--self-signed` option\r\n* Any other cert with the full chain already bundled\r\n\r\nThe fixes for these were:\r\n\r\n* Detect if the cert is self-signed, and if so, don't try to complete the chain and don't upload a chain to AWS\r\n* For non-self-signed, strip away everything except the end-entity cert and then regenerate the chain","created_at":"2016-01-14T08:25:44Z","updated_at":"2016-01-15T20:29:41Z","closed_at":"2016-01-15T20:29:41Z","merged_at":"2016-01-15T20:29:41Z","merge_commit_sha":"59aebfbac2eb5eee6d3ce43e506648d872f4c4e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/256/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/256/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/256/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/6735022037cdf15ad049af36f6ba022a11dcd8f8","head":{"label":"convox:ssl-chain-fix","ref":"ssl-chain-fix","sha":"6735022037cdf15ad049af36f6ba022a11dcd8f8","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-01-15T17:44:46Z","pushed_at":"2016-01-15T20:29:41Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":39620,"stargazers_count":124,"watchers_count":124,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":51,"forks":19,"open_issues":51,"watchers":124,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"ec0907e3dac6cd6a521b34cbe2999726ab8b184f","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-01-15T17:44:46Z","pushed_at":"2016-01-15T20:29:41Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":39620,"stargazers_count":124,"watchers_count":124,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":51,"forks":19,"open_issues":51,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/256"},"html":{"href":"https://github.com/convox/rack/pull/256"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/256"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/6735022037cdf15ad049af36f6ba022a11dcd8f8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattmanning","id":44615,"avatar_url":"https://avatars.githubusercontent.com/u/44615?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmanning","html_url":"https://github.com/mattmanning","followers_url":"https://api.github.com/users/mattmanning/followers","following_url":"https://api.github.com/users/mattmanning/following{/other_user}","gists_url":"https://api.github.com/users/mattmanning/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmanning/subscriptions","organizations_url":"https://api.github.com/users/mattmanning/orgs","repos_url":"https://api.github.com/users/mattmanning/repos","events_url":"https://api.github.com/users/mattmanning/events{/privacy}","received_events_url":"https://api.github.com/users/mattmanning/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":4,"additions":29,"deletions":12,"changed_files":2}}