{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/19","id":96687365,"html_url":"https://github.com/mattdesl/three-orbit-controls/pull/19","diff_url":"https://github.com/mattdesl/three-orbit-controls/pull/19.diff","patch_url":"https://github.com/mattdesl/three-orbit-controls/pull/19.patch","issue_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/issues/19","number":19,"state":"closed","locked":false,"title":"Ties event handling to scope.domElement only","user":{"login":"charlesfleche","id":2563098,"avatar_url":"https://avatars.githubusercontent.com/u/2563098?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesfleche","html_url":"https://github.com/charlesfleche","followers_url":"https://api.github.com/users/charlesfleche/followers","following_url":"https://api.github.com/users/charlesfleche/following{/other_user}","gists_url":"https://api.github.com/users/charlesfleche/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesfleche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesfleche/subscriptions","organizations_url":"https://api.github.com/users/charlesfleche/orgs","repos_url":"https://api.github.com/users/charlesfleche/repos","events_url":"https://api.github.com/users/charlesfleche/events{/privacy}","received_events_url":"https://api.github.com/users/charlesfleche/received_events","type":"User","site_admin":false},"body":"`OrbitControls` globally listens to `mousemove`, `mouseup` and `keydown` events. That means that even if an`<input>` element exists outside of the OrbitControls, moving the text cursor with the key arrows within this `<input>` will pan the OrbitControls.\r\n\r\nThis PR ensures that only scope key / mouse events are processed by the `OrbitControls`.","created_at":"2016-12-06T09:24:10Z","updated_at":"2016-12-07T04:07:03Z","closed_at":"2016-12-07T04:07:03Z","merged_at":null,"merge_commit_sha":"223a45b8356622b2f5eb47f3a165defe3d5229ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/19/commits","review_comments_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/19/comments","review_comment_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/issues/19/comments","statuses_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/statuses/0b71919f35a8a241b2039fb651e3e43e90bb2e46","head":{"label":"charlesfleche:keep-handlers-local-to-element","ref":"keep-handlers-local-to-element","sha":"0b71919f35a8a241b2039fb651e3e43e90bb2e46","user":{"login":"charlesfleche","id":2563098,"avatar_url":"https://avatars.githubusercontent.com/u/2563098?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesfleche","html_url":"https://github.com/charlesfleche","followers_url":"https://api.github.com/users/charlesfleche/followers","following_url":"https://api.github.com/users/charlesfleche/following{/other_user}","gists_url":"https://api.github.com/users/charlesfleche/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesfleche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesfleche/subscriptions","organizations_url":"https://api.github.com/users/charlesfleche/orgs","repos_url":"https://api.github.com/users/charlesfleche/repos","events_url":"https://api.github.com/users/charlesfleche/events{/privacy}","received_events_url":"https://api.github.com/users/charlesfleche/received_events","type":"User","site_admin":false},"repo":{"id":75714577,"name":"three-orbit-controls","full_name":"charlesfleche/three-orbit-controls","owner":{"login":"charlesfleche","id":2563098,"avatar_url":"https://avatars.githubusercontent.com/u/2563098?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesfleche","html_url":"https://github.com/charlesfleche","followers_url":"https://api.github.com/users/charlesfleche/followers","following_url":"https://api.github.com/users/charlesfleche/following{/other_user}","gists_url":"https://api.github.com/users/charlesfleche/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesfleche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesfleche/subscriptions","organizations_url":"https://api.github.com/users/charlesfleche/orgs","repos_url":"https://api.github.com/users/charlesfleche/repos","events_url":"https://api.github.com/users/charlesfleche/events{/privacy}","received_events_url":"https://api.github.com/users/charlesfleche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charlesfleche/three-orbit-controls","description":"orbit controls for ThreeJS","fork":true,"url":"https://api.github.com/repos/charlesfleche/three-orbit-controls","forks_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/forks","keys_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/teams","hooks_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/hooks","issue_events_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/issues/events{/number}","events_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/events","assignees_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/assignees{/user}","branches_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/branches{/branch}","tags_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/tags","blobs_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/statuses/{sha}","languages_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/languages","stargazers_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/stargazers","contributors_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/contributors","subscribers_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/subscribers","subscription_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/subscription","commits_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/contents/{+path}","compare_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/merges","archive_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/downloads","issues_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/issues{/number}","pulls_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/pulls{/number}","milestones_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/milestones{/number}","notifications_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/labels{/name}","releases_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/releases{/id}","deployments_url":"https://api.github.com/repos/charlesfleche/three-orbit-controls/deployments","created_at":"2016-12-06T09:13:34Z","updated_at":"2016-12-06T09:13:35Z","pushed_at":"2016-12-06T09:17:44Z","git_url":"git://github.com/charlesfleche/three-orbit-controls.git","ssh_url":"git@github.com:charlesfleche/three-orbit-controls.git","clone_url":"https://github.com/charlesfleche/three-orbit-controls.git","svn_url":"https://github.com/charlesfleche/three-orbit-controls","homepage":"","size":28,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattdesl:master","ref":"master","sha":"f7703452f6373d870e9e5bae4df46e7b53a4aa3e","user":{"login":"mattdesl","id":1383811,"avatar_url":"https://avatars.githubusercontent.com/u/1383811?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdesl","html_url":"https://github.com/mattdesl","followers_url":"https://api.github.com/users/mattdesl/followers","following_url":"https://api.github.com/users/mattdesl/following{/other_user}","gists_url":"https://api.github.com/users/mattdesl/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdesl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdesl/subscriptions","organizations_url":"https://api.github.com/users/mattdesl/orgs","repos_url":"https://api.github.com/users/mattdesl/repos","events_url":"https://api.github.com/users/mattdesl/events{/privacy}","received_events_url":"https://api.github.com/users/mattdesl/received_events","type":"User","site_admin":false},"repo":{"id":26788676,"name":"three-orbit-controls","full_name":"mattdesl/three-orbit-controls","owner":{"login":"mattdesl","id":1383811,"avatar_url":"https://avatars.githubusercontent.com/u/1383811?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdesl","html_url":"https://github.com/mattdesl","followers_url":"https://api.github.com/users/mattdesl/followers","following_url":"https://api.github.com/users/mattdesl/following{/other_user}","gists_url":"https://api.github.com/users/mattdesl/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdesl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdesl/subscriptions","organizations_url":"https://api.github.com/users/mattdesl/orgs","repos_url":"https://api.github.com/users/mattdesl/repos","events_url":"https://api.github.com/users/mattdesl/events{/privacy}","received_events_url":"https://api.github.com/users/mattdesl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattdesl/three-orbit-controls","description":"orbit controls for ThreeJS","fork":false,"url":"https://api.github.com/repos/mattdesl/three-orbit-controls","forks_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/forks","keys_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/teams","hooks_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/hooks","issue_events_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/issues/events{/number}","events_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/events","assignees_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/assignees{/user}","branches_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/branches{/branch}","tags_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/tags","blobs_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/statuses/{sha}","languages_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/languages","stargazers_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/stargazers","contributors_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/contributors","subscribers_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/subscribers","subscription_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/subscription","commits_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/contents/{+path}","compare_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/merges","archive_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/downloads","issues_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/issues{/number}","pulls_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls{/number}","milestones_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/milestones{/number}","notifications_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/labels{/name}","releases_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/releases{/id}","deployments_url":"https://api.github.com/repos/mattdesl/three-orbit-controls/deployments","created_at":"2014-11-18T02:41:12Z","updated_at":"2016-12-01T23:02:32Z","pushed_at":"2016-12-06T09:24:10Z","git_url":"git://github.com/mattdesl/three-orbit-controls.git","ssh_url":"git@github.com:mattdesl/three-orbit-controls.git","clone_url":"https://github.com/mattdesl/three-orbit-controls.git","svn_url":"https://github.com/mattdesl/three-orbit-controls","homepage":"","size":49,"stargazers_count":58,"watchers_count":58,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/19"},"html":{"href":"https://github.com/mattdesl/three-orbit-controls/pull/19"},"issue":{"href":"https://api.github.com/repos/mattdesl/three-orbit-controls/issues/19"},"comments":{"href":"https://api.github.com/repos/mattdesl/three-orbit-controls/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattdesl/three-orbit-controls/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/mattdesl/three-orbit-controls/statuses/0b71919f35a8a241b2039fb651e3e43e90bb2e46"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"charlesfleche"}}