{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/90406284","pull_request_review_id":10923640,"id":90406284,"diff_hunk":"@@ -104,7 +121,7 @@ class AlertAndroid {\n     };\n \n     if (options) {\n-      config = {...config, cancelable: options.cancelable};","path":"Libraries/Alert/Alert.js","position":36,"original_position":28,"commit_id":"8d6aabce098a6537818168ad298217bff9368061","original_commit_id":"a7b3ad992338786d370b919b95530e4dab1eb693","user":{"login":"pandiaraj44","id":22169327,"avatar_url":"https://avatars.githubusercontent.com/u/22169327?v=3","gravatar_id":"","url":"https://api.github.com/users/pandiaraj44","html_url":"https://github.com/pandiaraj44","followers_url":"https://api.github.com/users/pandiaraj44/followers","following_url":"https://api.github.com/users/pandiaraj44/following{/other_user}","gists_url":"https://api.github.com/users/pandiaraj44/gists{/gist_id}","starred_url":"https://api.github.com/users/pandiaraj44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandiaraj44/subscriptions","organizations_url":"https://api.github.com/users/pandiaraj44/orgs","repos_url":"https://api.github.com/users/pandiaraj44/repos","events_url":"https://api.github.com/users/pandiaraj44/events{/privacy}","received_events_url":"https://api.github.com/users/pandiaraj44/received_events","type":"User","site_admin":false},"body":"`     config = {...config, cancelable: options.cancelable, mode: options.mode};`","created_at":"2016-12-01T09:08:10Z","updated_at":"2016-12-01T09:08:10Z","html_url":"https://github.com/facebook/react-native/pull/11240#discussion_r90406284","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/11240","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/90406284"},"html":{"href":"https://github.com/facebook/react-native/pull/11240#discussion_r90406284"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/11240"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/11240","id":96046783,"html_url":"https://github.com/facebook/react-native/pull/11240","diff_url":"https://github.com/facebook/react-native/pull/11240.diff","patch_url":"https://github.com/facebook/react-native/pull/11240.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/11240","number":11240,"state":"open","locked":false,"title":"Android material alert dialog configurations added","user":{"login":"pandiaraj44","id":22169327,"avatar_url":"https://avatars.githubusercontent.com/u/22169327?v=3","gravatar_id":"","url":"https://api.github.com/users/pandiaraj44","html_url":"https://github.com/pandiaraj44","followers_url":"https://api.github.com/users/pandiaraj44/followers","following_url":"https://api.github.com/users/pandiaraj44/following{/other_user}","gists_url":"https://api.github.com/users/pandiaraj44/gists{/gist_id}","starred_url":"https://api.github.com/users/pandiaraj44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandiaraj44/subscriptions","organizations_url":"https://api.github.com/users/pandiaraj44/orgs","repos_url":"https://api.github.com/users/pandiaraj44/repos","events_url":"https://api.github.com/users/pandiaraj44/events{/privacy}","received_events_url":"https://api.github.com/users/pandiaraj44/received_events","type":"User","site_admin":false},"body":"## Motivation\r\nTo support the android material alert dialog features for all the android versions.\r\n## Solution\r\nAndroid provides the [appcompat library](https://developer.android.com/topic/libraries/support-library/features.html#v7-appcompat) which supports the material designs for the most of the android versions. With the help of [appcompat library](https://developer.android.com/topic/libraries/support-library/features.html#v7-appcompat), I have added the customization to the android alert dialog. \r\n## Test Plan\r\nWhen opening an alert dialog on Android, We need to pass the option value(mode: 'material/default').\r\n\r\n### Example 1\r\n```\r\nAlert.alert(\r\n  'Alert Title',\r\n  'My Alert Msg',\r\n  null,\r\n  {\r\n    mode: 'material'\r\n  }\r\n)\r\n```\r\n**Android < 5.0**\r\n![screenshot_20161201-073541](https://cloud.githubusercontent.com/assets/22169327/20784393/e9b1d142-b7bf-11e6-8af2-471ad89dad49.png)\r\n\r\n**Android >= 5.0**\r\n![screenshot_20161201-073541](https://cloud.githubusercontent.com/assets/22169327/20784393/e9b1d142-b7bf-11e6-8af2-471ad89dad49.png)\r\n\r\n### Example 2\r\n```\r\nAlert.alert(\r\n  'Alert Title',\r\n  'My Alert Msg',\r\n  null,\r\n  {\r\n    mode: 'default'\r\n  }\r\n)\r\n(or)\r\nAlert.alert(\r\n  'Alert Title',\r\n  'My Alert Msg',\r\n  null\r\n)\r\n```\r\n**Android < 5.0**\r\n![screenshot_20161201-073518](https://cloud.githubusercontent.com/assets/22169327/20784429/40033676-b7c0-11e6-80db-53838cab0105.png)\r\n\r\n\r\n**Android >= 5.0**\r\n![screenshot_20161201-073541](https://cloud.githubusercontent.com/assets/22169327/20784393/e9b1d142-b7bf-11e6-8af2-471ad89dad49.png)\r\n\r\nFor real-time testing, you can run UIExplorer android project. I have added the example code.\r\n![screenshot_20161201-073532](https://cloud.githubusercontent.com/assets/22169327/20787055/dbc17d52-b7cf-11e6-9180-049ce04cc384.png)\r\n","created_at":"2016-12-01T08:43:23Z","updated_at":"2016-12-01T09:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cfaf1887bb1ccc5aee8f2c891ec8f84e781cb95","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/11240/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/11240/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/11240/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/8d6aabce098a6537818168ad298217bff9368061","head":{"label":"pandiaraj44:material-alert-dialog","ref":"material-alert-dialog","sha":"8d6aabce098a6537818168ad298217bff9368061","user":{"login":"pandiaraj44","id":22169327,"avatar_url":"https://avatars.githubusercontent.com/u/22169327?v=3","gravatar_id":"","url":"https://api.github.com/users/pandiaraj44","html_url":"https://github.com/pandiaraj44","followers_url":"https://api.github.com/users/pandiaraj44/followers","following_url":"https://api.github.com/users/pandiaraj44/following{/other_user}","gists_url":"https://api.github.com/users/pandiaraj44/gists{/gist_id}","starred_url":"https://api.github.com/users/pandiaraj44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandiaraj44/subscriptions","organizations_url":"https://api.github.com/users/pandiaraj44/orgs","repos_url":"https://api.github.com/users/pandiaraj44/repos","events_url":"https://api.github.com/users/pandiaraj44/events{/privacy}","received_events_url":"https://api.github.com/users/pandiaraj44/received_events","type":"User","site_admin":false},"repo":{"id":73673404,"name":"react-native","full_name":"pandiaraj44/react-native","owner":{"login":"pandiaraj44","id":22169327,"avatar_url":"https://avatars.githubusercontent.com/u/22169327?v=3","gravatar_id":"","url":"https://api.github.com/users/pandiaraj44","html_url":"https://github.com/pandiaraj44","followers_url":"https://api.github.com/users/pandiaraj44/followers","following_url":"https://api.github.com/users/pandiaraj44/following{/other_user}","gists_url":"https://api.github.com/users/pandiaraj44/gists{/gist_id}","starred_url":"https://api.github.com/users/pandiaraj44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandiaraj44/subscriptions","organizations_url":"https://api.github.com/users/pandiaraj44/orgs","repos_url":"https://api.github.com/users/pandiaraj44/repos","events_url":"https://api.github.com/users/pandiaraj44/events{/privacy}","received_events_url":"https://api.github.com/users/pandiaraj44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pandiaraj44/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/pandiaraj44/react-native","forks_url":"https://api.github.com/repos/pandiaraj44/react-native/forks","keys_url":"https://api.github.com/repos/pandiaraj44/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandiaraj44/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandiaraj44/react-native/teams","hooks_url":"https://api.github.com/repos/pandiaraj44/react-native/hooks","issue_events_url":"https://api.github.com/repos/pandiaraj44/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/pandiaraj44/react-native/events","assignees_url":"https://api.github.com/repos/pandiaraj44/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/pandiaraj44/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/pandiaraj44/react-native/tags","blobs_url":"https://api.github.com/repos/pandiaraj44/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandiaraj44/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandiaraj44/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandiaraj44/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandiaraj44/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/pandiaraj44/react-native/languages","stargazers_url":"https://api.github.com/repos/pandiaraj44/react-native/stargazers","contributors_url":"https://api.github.com/repos/pandiaraj44/react-native/contributors","subscribers_url":"https://api.github.com/repos/pandiaraj44/react-native/subscribers","subscription_url":"https://api.github.com/repos/pandiaraj44/react-native/subscription","commits_url":"https://api.github.com/repos/pandiaraj44/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandiaraj44/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandiaraj44/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandiaraj44/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandiaraj44/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/pandiaraj44/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandiaraj44/react-native/merges","archive_url":"https://api.github.com/repos/pandiaraj44/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandiaraj44/react-native/downloads","issues_url":"https://api.github.com/repos/pandiaraj44/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/pandiaraj44/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/pandiaraj44/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/pandiaraj44/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandiaraj44/react-native/labels{/name}","releases_url":"https://api.github.com/repos/pandiaraj44/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/pandiaraj44/react-native/deployments","created_at":"2016-11-14T06:24:10Z","updated_at":"2016-11-14T06:24:20Z","pushed_at":"2016-12-01T09:04:15Z","git_url":"git://github.com/pandiaraj44/react-native.git","ssh_url":"git@github.com:pandiaraj44/react-native.git","clone_url":"https://github.com/pandiaraj44/react-native.git","svn_url":"https://github.com/pandiaraj44/react-native","homepage":"http://facebook.github.io/react-native/","size":102194,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c5da1068f8fa17f5f10067b744c623f8d696e057","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-12-01T09:04:48Z","pushed_at":"2016-12-01T09:04:22Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":164100,"stargazers_count":41081,"watchers_count":41081,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9317,"mirror_url":null,"open_issues_count":810,"forks":9317,"open_issues":810,"watchers":41081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/11240"},"html":{"href":"https://github.com/facebook/react-native/pull/11240"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/11240"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/11240/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/11240/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/11240/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/8d6aabce098a6537818168ad298217bff9368061"}}}}
{"actor":{"display_login":"pandiaraj44"}}