{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-beam/issues/1466","repository_url":"https://api.github.com/repos/apache/incubator-beam","labels_url":"https://api.github.com/repos/apache/incubator-beam/issues/1466/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1466/comments","events_url":"https://api.github.com/repos/apache/incubator-beam/issues/1466/events","html_url":"https://github.com/apache/incubator-beam/pull/1466","id":192663953,"number":1466,"title":"[BEAM-1000,BEAM-595,BEAM-1050] Aligned the Spark batch and streaming pipelines to adhere to waitUntilFinish and cancel","user":{"login":"staslev","id":6048315,"avatar_url":"https://avatars.githubusercontent.com/u/6048315?v=3","gravatar_id":"","url":"https://api.github.com/users/staslev","html_url":"https://github.com/staslev","followers_url":"https://api.github.com/users/staslev/followers","following_url":"https://api.github.com/users/staslev/following{/other_user}","gists_url":"https://api.github.com/users/staslev/gists{/gist_id}","starred_url":"https://api.github.com/users/staslev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staslev/subscriptions","organizations_url":"https://api.github.com/users/staslev/orgs","repos_url":"https://api.github.com/users/staslev/repos","events_url":"https://api.github.com/users/staslev/events{/privacy}","received_events_url":"https://api.github.com/users/staslev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-11-30T20:00:03Z","updated_at":"2016-12-01T20:00:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1466","html_url":"https://github.com/apache/incubator-beam/pull/1466","diff_url":"https://github.com/apache/incubator-beam/pull/1466.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1466.patch"},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [ ] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\nIntroduced SparkPipelineResult that should be able to better support `PipelineResult` semantics, such as `waitUntilFinish` and `cancel`. \r\n\r\nAlso relates to `BEAM-1000`,  `BEAM-595` and `BEAM-1050` as well as to #1438.\r\n\r\nR: @amitsela "},"comment":{"url":"https://api.github.com/repos/apache/incubator-beam/issues/comments/264278048","html_url":"https://github.com/apache/incubator-beam/pull/1466#issuecomment-264278048","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1466","id":264278048,"user":{"login":"staslev","id":6048315,"avatar_url":"https://avatars.githubusercontent.com/u/6048315?v=3","gravatar_id":"","url":"https://api.github.com/users/staslev","html_url":"https://github.com/staslev","followers_url":"https://api.github.com/users/staslev/followers","following_url":"https://api.github.com/users/staslev/following{/other_user}","gists_url":"https://api.github.com/users/staslev/gists{/gist_id}","starred_url":"https://api.github.com/users/staslev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staslev/subscriptions","organizations_url":"https://api.github.com/users/staslev/orgs","repos_url":"https://api.github.com/users/staslev/repos","events_url":"https://api.github.com/users/staslev/events{/privacy}","received_events_url":"https://api.github.com/users/staslev/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T20:00:25Z","updated_at":"2016-12-01T20:00:25Z","body":"Technically it could, but I don't think it is as intuitive in terms of design.\r\nThe reason it (i.e. the `ExecutorService`) is in `SparkRunner#run()` is because the runner is responsible for **starting** pipeline executions, so that `SparkPipelineResult` does not have to, which it will in case the `ExecutorService` moves there. It sounds a bit off to have the `SparkPipelineResult` start executions, don't you think?"}}
{"actor":{"display_login":"staslev"}}