{"action":"created","issue":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/722","repository_url":"https://api.github.com/repos/BuoyantIO/linkerd","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/722/labels{/name}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/722/comments","events_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/722/events","html_url":"https://github.com/BuoyantIO/linkerd/issues/722","id":181791528,"number":722,"title":"use TracingFilter for Http.Server","user":{"login":"siggy","id":236915,"avatar_url":"https://avatars.githubusercontent.com/u/236915?v=3","gravatar_id":"","url":"https://api.github.com/users/siggy","html_url":"https://github.com/siggy","followers_url":"https://api.github.com/users/siggy/followers","following_url":"https://api.github.com/users/siggy/following{/other_user}","gists_url":"https://api.github.com/users/siggy/gists{/gist_id}","starred_url":"https://api.github.com/users/siggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siggy/subscriptions","organizations_url":"https://api.github.com/users/siggy/orgs","repos_url":"https://api.github.com/users/siggy/repos","events_url":"https://api.github.com/users/siggy/events{/privacy}","received_events_url":"https://api.github.com/users/siggy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-08T00:13:59Z","updated_at":"2016-10-10T18:18:56Z","closed_at":null,"body":"linkerd's `TracingFilter` captures a lot of useful information, namely `req.uri` and `http.req.host`:\r\nhttps://github.com/BuoyantIO/linkerd/blob/master/router/http/src/main/scala/io/buoyant/router/http/TracingFilter.scala\r\n\r\nthis filter is added to `Http.Router.client`, but not `Http.Server.stack`:\r\nhttps://github.com/BuoyantIO/linkerd/blob/master/router/http/src/main/scala/io/buoyant/router/Http.scala\r\n\r\nit would be useful if both client and server traces recorded the same set of data, particularly for linker-to-linker vs. non-linker-to-linker modes."},"comment":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/comments/252699320","html_url":"https://github.com/BuoyantIO/linkerd/issues/722#issuecomment-252699320","issue_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/722","id":252699320,"user":{"login":"olix0r","id":240738,"avatar_url":"https://avatars.githubusercontent.com/u/240738?v=3","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T18:18:56Z","updated_at":"2016-10-10T18:18:56Z","body":"We talked about this offline: what we really want is to ensure that client spans are emitted even when the client fails to bind properly.  I think we want to do this by moving the client tracing filter up into the bottom of the path stack."}}
{"actor":{"display_login":"olix0r"}}