{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments/81210486","pull_request_review_id":2206383,"id":81210486,"diff_hunk":"@@ -767,9 +776,20 @@ def _list_versions(app_id, expected_count, max_count=None):\n \n     assert returncode == 0\n     assert isinstance(result, list)\n-    assert len(result) == expected_count\n     assert stderr == b''\n \n+    # Marathon persists app versions indefinitely by ID, so there may be extras\n+    assert len(result) >= expected_min_count\n+\n+    if max_count is not None:\n+        assert len(result) <= max_count\n+\n+\n+def _assert_matches_with_groups(pattern, text, groups):\n+    match = re.fullmatch(pattern, text, flags=re.DOTALL)\n+    assert match\n+    assert match.groups() == groups","path":"cli/tests/integrations/test_marathon.py","position":131,"original_position":131,"commit_id":"b234638d72b754cc855e05995f4bcc5580bb70cd","original_commit_id":"b234638d72b754cc855e05995f4bcc5580bb70cd","user":{"login":"tamarrow","id":1292768,"avatar_url":"https://avatars.githubusercontent.com/u/1292768?v=3","gravatar_id":"","url":"https://api.github.com/users/tamarrow","html_url":"https://github.com/tamarrow","followers_url":"https://api.github.com/users/tamarrow/followers","following_url":"https://api.github.com/users/tamarrow/following{/other_user}","gists_url":"https://api.github.com/users/tamarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tamarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamarrow/subscriptions","organizations_url":"https://api.github.com/users/tamarrow/orgs","repos_url":"https://api.github.com/users/tamarrow/repos","events_url":"https://api.github.com/users/tamarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tamarrow/received_events","type":"User","site_admin":false},"body":"lets just put the app-id where it should be in the str output","created_at":"2016-09-29T18:59:11Z","updated_at":"2016-09-29T18:59:21Z","html_url":"https://github.com/dcos/dcos-cli/pull/777#discussion_r81210486","pull_request_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/777","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments/81210486"},"html":{"href":"https://github.com/dcos/dcos-cli/pull/777#discussion_r81210486"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/777"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-cli/pulls/777","id":86828389,"html_url":"https://github.com/dcos/dcos-cli/pull/777","diff_url":"https://github.com/dcos/dcos-cli/pull/777.diff","patch_url":"https://github.com/dcos/dcos-cli/pull/777.patch","issue_url":"https://api.github.com/repos/dcos/dcos-cli/issues/777","number":777,"state":"open","locked":false,"title":"All pods integration tests pass against pods-enabled Marathon and Mesos","user":{"login":"cruhland","id":1936682,"avatar_url":"https://avatars.githubusercontent.com/u/1936682?v=3","gravatar_id":"","url":"https://api.github.com/users/cruhland","html_url":"https://github.com/cruhland","followers_url":"https://api.github.com/users/cruhland/followers","following_url":"https://api.github.com/users/cruhland/following{/other_user}","gists_url":"https://api.github.com/users/cruhland/gists{/gist_id}","starred_url":"https://api.github.com/users/cruhland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruhland/subscriptions","organizations_url":"https://api.github.com/users/cruhland/orgs","repos_url":"https://api.github.com/users/cruhland/repos","events_url":"https://api.github.com/users/cruhland/events{/privacy}","received_events_url":"https://api.github.com/users/cruhland/received_events","type":"User","site_admin":false},"body":"The tests are still marked as skipped to prevent CI breakage.","created_at":"2016-09-26T22:07:59Z","updated_at":"2016-09-29T18:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3666d9e19e59e9a43bbe1e03153642e76a2d08b","assignee":{"login":"tamarrow","id":1292768,"avatar_url":"https://avatars.githubusercontent.com/u/1292768?v=3","gravatar_id":"","url":"https://api.github.com/users/tamarrow","html_url":"https://github.com/tamarrow","followers_url":"https://api.github.com/users/tamarrow/followers","following_url":"https://api.github.com/users/tamarrow/following{/other_user}","gists_url":"https://api.github.com/users/tamarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tamarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamarrow/subscriptions","organizations_url":"https://api.github.com/users/tamarrow/orgs","repos_url":"https://api.github.com/users/tamarrow/repos","events_url":"https://api.github.com/users/tamarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tamarrow/received_events","type":"User","site_admin":false},"assignees":[{"login":"tamarrow","id":1292768,"avatar_url":"https://avatars.githubusercontent.com/u/1292768?v=3","gravatar_id":"","url":"https://api.github.com/users/tamarrow","html_url":"https://github.com/tamarrow","followers_url":"https://api.github.com/users/tamarrow/followers","following_url":"https://api.github.com/users/tamarrow/following{/other_user}","gists_url":"https://api.github.com/users/tamarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tamarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamarrow/subscriptions","organizations_url":"https://api.github.com/users/tamarrow/orgs","repos_url":"https://api.github.com/users/tamarrow/repos","events_url":"https://api.github.com/users/tamarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tamarrow/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dcos/dcos-cli/milestones/21","html_url":"https://github.com/dcos/dcos-cli/milestones/pods","labels_url":"https://api.github.com/repos/dcos/dcos-cli/milestones/21/labels","id":2002224,"number":21,"title":"pods","description":"","creator":{"login":"tamarrow","id":1292768,"avatar_url":"https://avatars.githubusercontent.com/u/1292768?v=3","gravatar_id":"","url":"https://api.github.com/users/tamarrow","html_url":"https://github.com/tamarrow","followers_url":"https://api.github.com/users/tamarrow/followers","following_url":"https://api.github.com/users/tamarrow/following{/other_user}","gists_url":"https://api.github.com/users/tamarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/tamarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamarrow/subscriptions","organizations_url":"https://api.github.com/users/tamarrow/orgs","repos_url":"https://api.github.com/users/tamarrow/repos","events_url":"https://api.github.com/users/tamarrow/events{/privacy}","received_events_url":"https://api.github.com/users/tamarrow/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":7,"state":"open","created_at":"2016-09-13T19:02:01Z","updated_at":"2016-09-29T15:44:55Z","due_on":"2016-09-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/777/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/777/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-cli/issues/777/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-cli/statuses/b234638d72b754cc855e05995f4bcc5580bb70cd","head":{"label":"dcos:update-integration-tests","ref":"update-integration-tests","sha":"b234638d72b754cc855e05995f4bcc5580bb70cd","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":26653348,"name":"dcos-cli","full_name":"dcos/dcos-cli","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-cli","description":"The command line for your datacenter! ","fork":false,"url":"https://api.github.com/repos/dcos/dcos-cli","forks_url":"https://api.github.com/repos/dcos/dcos-cli/forks","keys_url":"https://api.github.com/repos/dcos/dcos-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-cli/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-cli/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-cli/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-cli/events","assignees_url":"https://api.github.com/repos/dcos/dcos-cli/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-cli/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-cli/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-cli/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-cli/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-cli/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-cli/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-cli/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-cli/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-cli/merges","archive_url":"https://api.github.com/repos/dcos/dcos-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-cli/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-cli/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-cli/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-cli/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-cli/deployments","created_at":"2014-11-14T19:11:48Z","updated_at":"2016-09-29T10:46:26Z","pushed_at":"2016-09-29T18:47:52Z","git_url":"git://github.com/dcos/dcos-cli.git","ssh_url":"git@github.com:dcos/dcos-cli.git","clone_url":"https://github.com/dcos/dcos-cli.git","svn_url":"https://github.com/dcos/dcos-cli","homepage":"https://dcos.io/docs/latest/usage/cli/","size":3293,"stargazers_count":167,"watchers_count":167,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":65,"forks":70,"open_issues":65,"watchers":167,"default_branch":"master"}},"base":{"label":"dcos:pods","ref":"pods","sha":"92c3c3b8031dce918be4402c9ce4c0228f3cc118","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":26653348,"name":"dcos-cli","full_name":"dcos/dcos-cli","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-cli","description":"The command line for your datacenter! ","fork":false,"url":"https://api.github.com/repos/dcos/dcos-cli","forks_url":"https://api.github.com/repos/dcos/dcos-cli/forks","keys_url":"https://api.github.com/repos/dcos/dcos-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-cli/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-cli/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-cli/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-cli/events","assignees_url":"https://api.github.com/repos/dcos/dcos-cli/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-cli/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-cli/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-cli/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-cli/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-cli/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-cli/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-cli/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-cli/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-cli/merges","archive_url":"https://api.github.com/repos/dcos/dcos-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-cli/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-cli/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-cli/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-cli/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-cli/deployments","created_at":"2014-11-14T19:11:48Z","updated_at":"2016-09-29T10:46:26Z","pushed_at":"2016-09-29T18:47:52Z","git_url":"git://github.com/dcos/dcos-cli.git","ssh_url":"git@github.com:dcos/dcos-cli.git","clone_url":"https://github.com/dcos/dcos-cli.git","svn_url":"https://github.com/dcos/dcos-cli","homepage":"https://dcos.io/docs/latest/usage/cli/","size":3293,"stargazers_count":167,"watchers_count":167,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":65,"forks":70,"open_issues":65,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/777"},"html":{"href":"https://github.com/dcos/dcos-cli/pull/777"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-cli/issues/777"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-cli/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-cli/statuses/b234638d72b754cc855e05995f4bcc5580bb70cd"}}}}
{"actor":{"display_login":"tamarrow"}}