{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4608","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4608/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4608/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4608/events","html_url":"https://github.com/RobotLocomotion/drake/pull/4608","id":197614839,"number":4608,"title":"add botcore and robotlocomotion lcmtypes externals to bazel","user":{"login":"RussTedrake","id":6442292,"avatar_url":"https://avatars.githubusercontent.com/u/6442292?v=3","gravatar_id":"","url":"https://api.github.com/users/RussTedrake","html_url":"https://github.com/RussTedrake","followers_url":"https://api.github.com/users/RussTedrake/followers","following_url":"https://api.github.com/users/RussTedrake/following{/other_user}","gists_url":"https://api.github.com/users/RussTedrake/gists{/gist_id}","starred_url":"https://api.github.com/users/RussTedrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussTedrake/subscriptions","organizations_url":"https://api.github.com/users/RussTedrake/orgs","repos_url":"https://api.github.com/users/RussTedrake/repos","events_url":"https://api.github.com/users/RussTedrake/events{/privacy}","received_events_url":"https://api.github.com/users/RussTedrake/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-12-26T19:38:57Z","updated_at":"2016-12-26T20:28:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4608","html_url":"https://github.com/RobotLocomotion/drake/pull/4608","diff_url":"https://github.com/RobotLocomotion/drake/pull/4608.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/4608.patch"},"body":"and kuka_ik_demo for coverage\r\n\r\nrequired some work on the lcm.bzl and a rename of the files in bot_core_lcmtypes (currently pointing to my fork instead of @mwoehlke-kitware 's fork(!) pending that PR landing).\r\n\r\nalso fixed inconsistency - bazel was building `lcmgen` instead of `lcm-gen` executable.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/4608)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/269239847","html_url":"https://github.com/RobotLocomotion/drake/pull/4608#issuecomment-269239847","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4608","id":269239847,"user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"created_at":"2016-12-26T20:28:51Z","updated_at":"2016-12-26T20:28:51Z","body":"Well, of course the OSX build doesn't work because #4607 isn't merged yet.  But both linux variants failed as well.  See inline comment below.\n\n---\n\nReview status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.\n\n---\n\n*[tools/robotlocomotion_lcmtypes.BUILD, line 13 at r2](https://reviewable.io:443/reviews/robotlocomotion/drake/4608#-KZwnJwDMb4pWLo4zHpg:-KZwnJwDMb4pWLo4zHph:blryb7w) ([raw file](https://github.com/robotlocomotion/drake/blob/ed1fa53c5ee841dcfc08f03f04451041ece580da/tools/robotlocomotion_lcmtypes.BUILD#L13)):*\n> ```\n>     lcm_srcs = glob([\"lcmtypes/*.lcm\"]),\n>     linkstatic = 1,\n> )\n> ```\n\nCI is failing because`includes = [\"lcmtypes\"]` is missing here (we also need the same change in bot_core) -- confirmed / tested locally.  I am surprised it passes locally for you on OSX -- if reproducible, it could be a sandboxing defect that I should report upstream.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/4608#-:-KZwnFuMQd7yfKBuJUJX:b-m4jzjv)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jwnimmer-tri"}}