{"action":"closed","number":158,"pull_request":{"url":"https://api.github.com/repos/Azure/DotNetty/pulls/158","id":83710715,"html_url":"https://github.com/Azure/DotNetty/pull/158","diff_url":"https://github.com/Azure/DotNetty/pull/158.diff","patch_url":"https://github.com/Azure/DotNetty/pull/158.patch","issue_url":"https://api.github.com/repos/Azure/DotNetty/issues/158","number":158,"state":"closed","locked":false,"title":"Bug: StringDecoder not marked as Sharable","user":{"login":"RonnyA","id":1153345,"avatar_url":"https://avatars.githubusercontent.com/u/1153345?v=3","gravatar_id":"","url":"https://api.github.com/users/RonnyA","html_url":"https://github.com/RonnyA","followers_url":"https://api.github.com/users/RonnyA/followers","following_url":"https://api.github.com/users/RonnyA/following{/other_user}","gists_url":"https://api.github.com/users/RonnyA/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyA/subscriptions","organizations_url":"https://api.github.com/users/RonnyA/orgs","repos_url":"https://api.github.com/users/RonnyA/repos","events_url":"https://api.github.com/users/RonnyA/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyA/received_events","type":"User","site_admin":false},"body":"Marked StringDecoder as Sharable\r\n\r\nMotivation:\r\n\r\nCan use StringDecoder in a server where you have more than 1 connect to the server. \r\nThis is a bug, since StringEncoder is marked Sharable and there is nothing that stands out as different.\r\n\r\nModifications:\r\n\r\nMarked StringDecoder as Sharable\r\n\r\n\r\nResult:\r\nSample project like EchoServer and TelnetServer will now be able to receive more than 1 connections.\r\nSo will all other code using the StringDecoder","created_at":"2016-09-01T21:31:49Z","updated_at":"2016-09-01T21:33:43Z","closed_at":"2016-09-01T21:33:43Z","merged_at":"2016-09-01T21:33:43Z","merge_commit_sha":"ab4b47f91ffc5190b2eb5dbf45c7504cac2c6274","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/DotNetty/pulls/158/commits","review_comments_url":"https://api.github.com/repos/Azure/DotNetty/pulls/158/comments","review_comment_url":"https://api.github.com/repos/Azure/DotNetty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/DotNetty/issues/158/comments","statuses_url":"https://api.github.com/repos/Azure/DotNetty/statuses/1af29c7d1089e1433c8f92bd71c0e9ec12de7a33","head":{"label":"RonnyA:Issue157","ref":"Issue157","sha":"1af29c7d1089e1433c8f92bd71c0e9ec12de7a33","user":{"login":"RonnyA","id":1153345,"avatar_url":"https://avatars.githubusercontent.com/u/1153345?v=3","gravatar_id":"","url":"https://api.github.com/users/RonnyA","html_url":"https://github.com/RonnyA","followers_url":"https://api.github.com/users/RonnyA/followers","following_url":"https://api.github.com/users/RonnyA/following{/other_user}","gists_url":"https://api.github.com/users/RonnyA/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyA/subscriptions","organizations_url":"https://api.github.com/users/RonnyA/orgs","repos_url":"https://api.github.com/users/RonnyA/repos","events_url":"https://api.github.com/users/RonnyA/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyA/received_events","type":"User","site_admin":false},"repo":{"id":67166259,"name":"DotNetty","full_name":"RonnyA/DotNetty","owner":{"login":"RonnyA","id":1153345,"avatar_url":"https://avatars.githubusercontent.com/u/1153345?v=3","gravatar_id":"","url":"https://api.github.com/users/RonnyA","html_url":"https://github.com/RonnyA","followers_url":"https://api.github.com/users/RonnyA/followers","following_url":"https://api.github.com/users/RonnyA/following{/other_user}","gists_url":"https://api.github.com/users/RonnyA/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyA/subscriptions","organizations_url":"https://api.github.com/users/RonnyA/orgs","repos_url":"https://api.github.com/users/RonnyA/repos","events_url":"https://api.github.com/users/RonnyA/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RonnyA/DotNetty","description":"DotNetty project – a port of netty, event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/RonnyA/DotNetty","forks_url":"https://api.github.com/repos/RonnyA/DotNetty/forks","keys_url":"https://api.github.com/repos/RonnyA/DotNetty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RonnyA/DotNetty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RonnyA/DotNetty/teams","hooks_url":"https://api.github.com/repos/RonnyA/DotNetty/hooks","issue_events_url":"https://api.github.com/repos/RonnyA/DotNetty/issues/events{/number}","events_url":"https://api.github.com/repos/RonnyA/DotNetty/events","assignees_url":"https://api.github.com/repos/RonnyA/DotNetty/assignees{/user}","branches_url":"https://api.github.com/repos/RonnyA/DotNetty/branches{/branch}","tags_url":"https://api.github.com/repos/RonnyA/DotNetty/tags","blobs_url":"https://api.github.com/repos/RonnyA/DotNetty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RonnyA/DotNetty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RonnyA/DotNetty/git/refs{/sha}","trees_url":"https://api.github.com/repos/RonnyA/DotNetty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RonnyA/DotNetty/statuses/{sha}","languages_url":"https://api.github.com/repos/RonnyA/DotNetty/languages","stargazers_url":"https://api.github.com/repos/RonnyA/DotNetty/stargazers","contributors_url":"https://api.github.com/repos/RonnyA/DotNetty/contributors","subscribers_url":"https://api.github.com/repos/RonnyA/DotNetty/subscribers","subscription_url":"https://api.github.com/repos/RonnyA/DotNetty/subscription","commits_url":"https://api.github.com/repos/RonnyA/DotNetty/commits{/sha}","git_commits_url":"https://api.github.com/repos/RonnyA/DotNetty/git/commits{/sha}","comments_url":"https://api.github.com/repos/RonnyA/DotNetty/comments{/number}","issue_comment_url":"https://api.github.com/repos/RonnyA/DotNetty/issues/comments{/number}","contents_url":"https://api.github.com/repos/RonnyA/DotNetty/contents/{+path}","compare_url":"https://api.github.com/repos/RonnyA/DotNetty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RonnyA/DotNetty/merges","archive_url":"https://api.github.com/repos/RonnyA/DotNetty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RonnyA/DotNetty/downloads","issues_url":"https://api.github.com/repos/RonnyA/DotNetty/issues{/number}","pulls_url":"https://api.github.com/repos/RonnyA/DotNetty/pulls{/number}","milestones_url":"https://api.github.com/repos/RonnyA/DotNetty/milestones{/number}","notifications_url":"https://api.github.com/repos/RonnyA/DotNetty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RonnyA/DotNetty/labels{/name}","releases_url":"https://api.github.com/repos/RonnyA/DotNetty/releases{/id}","deployments_url":"https://api.github.com/repos/RonnyA/DotNetty/deployments","created_at":"2016-09-01T21:05:11Z","updated_at":"2016-09-01T21:05:14Z","pushed_at":"2016-09-01T21:23:23Z","git_url":"git://github.com/RonnyA/DotNetty.git","ssh_url":"git@github.com:RonnyA/DotNetty.git","clone_url":"https://github.com/RonnyA/DotNetty.git","svn_url":"https://github.com/RonnyA/DotNetty","homepage":"","size":1142,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"fe25038624ec5e6a7ac0da3bea34fdc14431992d","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":35290377,"name":"DotNetty","full_name":"Azure/DotNetty","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/DotNetty","description":"DotNetty project – a port of netty, event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/Azure/DotNetty","forks_url":"https://api.github.com/repos/Azure/DotNetty/forks","keys_url":"https://api.github.com/repos/Azure/DotNetty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/DotNetty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/DotNetty/teams","hooks_url":"https://api.github.com/repos/Azure/DotNetty/hooks","issue_events_url":"https://api.github.com/repos/Azure/DotNetty/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/DotNetty/events","assignees_url":"https://api.github.com/repos/Azure/DotNetty/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/DotNetty/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/DotNetty/tags","blobs_url":"https://api.github.com/repos/Azure/DotNetty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/DotNetty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/DotNetty/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/DotNetty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/DotNetty/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/DotNetty/languages","stargazers_url":"https://api.github.com/repos/Azure/DotNetty/stargazers","contributors_url":"https://api.github.com/repos/Azure/DotNetty/contributors","subscribers_url":"https://api.github.com/repos/Azure/DotNetty/subscribers","subscription_url":"https://api.github.com/repos/Azure/DotNetty/subscription","commits_url":"https://api.github.com/repos/Azure/DotNetty/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/DotNetty/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/DotNetty/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/DotNetty/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/DotNetty/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/DotNetty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/DotNetty/merges","archive_url":"https://api.github.com/repos/Azure/DotNetty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/DotNetty/downloads","issues_url":"https://api.github.com/repos/Azure/DotNetty/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/DotNetty/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/DotNetty/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/DotNetty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/DotNetty/labels{/name}","releases_url":"https://api.github.com/repos/Azure/DotNetty/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/DotNetty/deployments","created_at":"2015-05-08T16:41:53Z","updated_at":"2016-09-01T08:24:53Z","pushed_at":"2016-09-01T21:33:43Z","git_url":"git://github.com/Azure/DotNetty.git","ssh_url":"git@github.com:Azure/DotNetty.git","clone_url":"https://github.com/Azure/DotNetty.git","svn_url":"https://github.com/Azure/DotNetty","homepage":"","size":1142,"stargazers_count":503,"watchers_count":503,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":21,"forks":153,"open_issues":21,"watchers":503,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/DotNetty/pulls/158"},"html":{"href":"https://github.com/Azure/DotNetty/pull/158"},"issue":{"href":"https://api.github.com/repos/Azure/DotNetty/issues/158"},"comments":{"href":"https://api.github.com/repos/Azure/DotNetty/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/DotNetty/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/DotNetty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/DotNetty/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/DotNetty/statuses/1af29c7d1089e1433c8f92bd71c0e9ec12de7a33"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nayato","id":818017,"avatar_url":"https://avatars.githubusercontent.com/u/818017?v=3","gravatar_id":"","url":"https://api.github.com/users/nayato","html_url":"https://github.com/nayato","followers_url":"https://api.github.com/users/nayato/followers","following_url":"https://api.github.com/users/nayato/following{/other_user}","gists_url":"https://api.github.com/users/nayato/gists{/gist_id}","starred_url":"https://api.github.com/users/nayato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nayato/subscriptions","organizations_url":"https://api.github.com/users/nayato/orgs","repos_url":"https://api.github.com/users/nayato/repos","events_url":"https://api.github.com/users/nayato/events{/privacy}","received_events_url":"https://api.github.com/users/nayato/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"nayato"}}