{"action":"created","comment":{"url":"https://api.github.com/repos/staltz/xstream/pulls/comments/70188081","id":70188081,"diff_hunk":"@@ -103,3 +136,56 @@ describe('fromEvent (extra)', () => {\n     target.emit(2);\n   });\n });\n+\n+describe('fromEvent (extra) - EventEmitter', () => {\n+  it('should call addListener with expected parameters', () => {\n+    const target = new FakeEventEmitter();\n+    const stream = fromEvent(target, 'test');\n+\n+    stream.addListener({next: noop, error: noop, complete: noop});\n+\n+    assert.strictEqual('test', target.event);","path":"tests/extra/fromEvent.ts","position":60,"original_position":60,"commit_id":"575408d855b672b2f24193f49eba8d13c45008f7","original_commit_id":"575408d855b672b2f24193f49eba8d13c45008f7","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"body":"These are good tests. However over here there's some Yoda talk going on (e.g. \"if monday is today\", as opposed to \"if today is monday\"). The API is `assert.strictEqual(actual, expected)`, so it should be `assert.strictEqual(target.event, 'test')`","created_at":"2016-07-10T20:47:37Z","updated_at":"2016-07-10T20:47:37Z","html_url":"https://github.com/staltz/xstream/pull/73#discussion_r70188081","pull_request_url":"https://api.github.com/repos/staltz/xstream/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/staltz/xstream/pulls/comments/70188081"},"html":{"href":"https://github.com/staltz/xstream/pull/73#discussion_r70188081"},"pull_request":{"href":"https://api.github.com/repos/staltz/xstream/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/staltz/xstream/pulls/73","id":76851526,"html_url":"https://github.com/staltz/xstream/pull/73","diff_url":"https://github.com/staltz/xstream/pull/73.diff","patch_url":"https://github.com/staltz/xstream/pull/73.patch","issue_url":"https://api.github.com/repos/staltz/xstream/issues/73","number":73,"state":"open","locked":false,"title":"Support NodeJS Event Emitters in fromEvent extra","user":{"login":"xtianjohns","id":2087279,"avatar_url":"https://avatars.githubusercontent.com/u/2087279?v=3","gravatar_id":"","url":"https://api.github.com/users/xtianjohns","html_url":"https://github.com/xtianjohns","followers_url":"https://api.github.com/users/xtianjohns/followers","following_url":"https://api.github.com/users/xtianjohns/following{/other_user}","gists_url":"https://api.github.com/users/xtianjohns/gists{/gist_id}","starred_url":"https://api.github.com/users/xtianjohns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtianjohns/subscriptions","organizations_url":"https://api.github.com/users/xtianjohns/orgs","repos_url":"https://api.github.com/users/xtianjohns/repos","events_url":"https://api.github.com/users/xtianjohns/events{/privacy}","received_events_url":"https://api.github.com/users/xtianjohns/received_events","type":"User","site_admin":false},"body":"Add support for stream generation from EventEmitters. \r\n\r\n## Description\r\n`fromEvent` will accept as a first argument either a DOMElement or an EventEmitter. When providing `fromEvent` with an EventEmitter, the third argument (useCapture) is always ignored.\r\n\r\nThere are two potentially outstanding concerns.\r\n\r\n**First**: This is my first contribution to xtream and I'm not familiar with how the documentation is built. I've updated JSDOC comments with new examples, but it's possible that my comments don't work with the documentation generator. I can take a deeper look into this soon.\r\n\r\n**Second**: Parity with RxJS and Most.js should probably involve a change to the third parameter here. I believe they support an object with configuration options, rather than a boolean. I'm not certain if that work would be a requirement to merge, but a brief discussion probably couldn't hurt. I'm happy to update the implementation to accommodate any updated signatures.\r\n\r\n## Motivation and Context\r\nThis should resolve staltz/xstream#65.\r\n\r\n## How Has This Been Tested?\r\nTests have been split between the two possible uses of the extra and are passing.\r\n\r\n## Checklist:\r\n- [ ] My code follows the code style of this project. (I think so?)\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly. (I've done some work, but need to confirm)\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.","created_at":"2016-07-09T16:55:56Z","updated_at":"2016-07-10T20:47:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e86a791782294424291e832af1b7e506fbe9741","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/staltz/xstream/pulls/73/commits","review_comments_url":"https://api.github.com/repos/staltz/xstream/pulls/73/comments","review_comment_url":"https://api.github.com/repos/staltz/xstream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/staltz/xstream/issues/73/comments","statuses_url":"https://api.github.com/repos/staltz/xstream/statuses/575408d855b672b2f24193f49eba8d13c45008f7","head":{"label":"xtianjohns:node-event-support","ref":"node-event-support","sha":"575408d855b672b2f24193f49eba8d13c45008f7","user":{"login":"xtianjohns","id":2087279,"avatar_url":"https://avatars.githubusercontent.com/u/2087279?v=3","gravatar_id":"","url":"https://api.github.com/users/xtianjohns","html_url":"https://github.com/xtianjohns","followers_url":"https://api.github.com/users/xtianjohns/followers","following_url":"https://api.github.com/users/xtianjohns/following{/other_user}","gists_url":"https://api.github.com/users/xtianjohns/gists{/gist_id}","starred_url":"https://api.github.com/users/xtianjohns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtianjohns/subscriptions","organizations_url":"https://api.github.com/users/xtianjohns/orgs","repos_url":"https://api.github.com/users/xtianjohns/repos","events_url":"https://api.github.com/users/xtianjohns/events{/privacy}","received_events_url":"https://api.github.com/users/xtianjohns/received_events","type":"User","site_admin":false},"repo":{"id":62958493,"name":"xstream","full_name":"xtianjohns/xstream","owner":{"login":"xtianjohns","id":2087279,"avatar_url":"https://avatars.githubusercontent.com/u/2087279?v=3","gravatar_id":"","url":"https://api.github.com/users/xtianjohns","html_url":"https://github.com/xtianjohns","followers_url":"https://api.github.com/users/xtianjohns/followers","following_url":"https://api.github.com/users/xtianjohns/following{/other_user}","gists_url":"https://api.github.com/users/xtianjohns/gists{/gist_id}","starred_url":"https://api.github.com/users/xtianjohns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtianjohns/subscriptions","organizations_url":"https://api.github.com/users/xtianjohns/orgs","repos_url":"https://api.github.com/users/xtianjohns/repos","events_url":"https://api.github.com/users/xtianjohns/events{/privacy}","received_events_url":"https://api.github.com/users/xtianjohns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xtianjohns/xstream","description":"An extremely intuitive, small, and fast functional reactive stream library for JavaScript","fork":true,"url":"https://api.github.com/repos/xtianjohns/xstream","forks_url":"https://api.github.com/repos/xtianjohns/xstream/forks","keys_url":"https://api.github.com/repos/xtianjohns/xstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xtianjohns/xstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xtianjohns/xstream/teams","hooks_url":"https://api.github.com/repos/xtianjohns/xstream/hooks","issue_events_url":"https://api.github.com/repos/xtianjohns/xstream/issues/events{/number}","events_url":"https://api.github.com/repos/xtianjohns/xstream/events","assignees_url":"https://api.github.com/repos/xtianjohns/xstream/assignees{/user}","branches_url":"https://api.github.com/repos/xtianjohns/xstream/branches{/branch}","tags_url":"https://api.github.com/repos/xtianjohns/xstream/tags","blobs_url":"https://api.github.com/repos/xtianjohns/xstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xtianjohns/xstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xtianjohns/xstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/xtianjohns/xstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xtianjohns/xstream/statuses/{sha}","languages_url":"https://api.github.com/repos/xtianjohns/xstream/languages","stargazers_url":"https://api.github.com/repos/xtianjohns/xstream/stargazers","contributors_url":"https://api.github.com/repos/xtianjohns/xstream/contributors","subscribers_url":"https://api.github.com/repos/xtianjohns/xstream/subscribers","subscription_url":"https://api.github.com/repos/xtianjohns/xstream/subscription","commits_url":"https://api.github.com/repos/xtianjohns/xstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/xtianjohns/xstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/xtianjohns/xstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/xtianjohns/xstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/xtianjohns/xstream/contents/{+path}","compare_url":"https://api.github.com/repos/xtianjohns/xstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xtianjohns/xstream/merges","archive_url":"https://api.github.com/repos/xtianjohns/xstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xtianjohns/xstream/downloads","issues_url":"https://api.github.com/repos/xtianjohns/xstream/issues{/number}","pulls_url":"https://api.github.com/repos/xtianjohns/xstream/pulls{/number}","milestones_url":"https://api.github.com/repos/xtianjohns/xstream/milestones{/number}","notifications_url":"https://api.github.com/repos/xtianjohns/xstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xtianjohns/xstream/labels{/name}","releases_url":"https://api.github.com/repos/xtianjohns/xstream/releases{/id}","deployments_url":"https://api.github.com/repos/xtianjohns/xstream/deployments","created_at":"2016-07-09T16:30:37Z","updated_at":"2016-07-09T16:30:39Z","pushed_at":"2016-07-09T16:43:29Z","git_url":"git://github.com/xtianjohns/xstream.git","ssh_url":"git@github.com:xtianjohns/xstream.git","clone_url":"https://github.com/xtianjohns/xstream.git","svn_url":"https://github.com/xtianjohns/xstream","homepage":"http://staltz.com/xstream/","size":618,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"staltz:master","ref":"master","sha":"c0071c69e50cd59f93720aa505e47a76a555f397","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"repo":{"id":56880047,"name":"xstream","full_name":"staltz/xstream","owner":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/staltz/xstream","description":"An extremely intuitive, small, and fast functional reactive stream library for JavaScript","fork":false,"url":"https://api.github.com/repos/staltz/xstream","forks_url":"https://api.github.com/repos/staltz/xstream/forks","keys_url":"https://api.github.com/repos/staltz/xstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/staltz/xstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/staltz/xstream/teams","hooks_url":"https://api.github.com/repos/staltz/xstream/hooks","issue_events_url":"https://api.github.com/repos/staltz/xstream/issues/events{/number}","events_url":"https://api.github.com/repos/staltz/xstream/events","assignees_url":"https://api.github.com/repos/staltz/xstream/assignees{/user}","branches_url":"https://api.github.com/repos/staltz/xstream/branches{/branch}","tags_url":"https://api.github.com/repos/staltz/xstream/tags","blobs_url":"https://api.github.com/repos/staltz/xstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/staltz/xstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/staltz/xstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/staltz/xstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/staltz/xstream/statuses/{sha}","languages_url":"https://api.github.com/repos/staltz/xstream/languages","stargazers_url":"https://api.github.com/repos/staltz/xstream/stargazers","contributors_url":"https://api.github.com/repos/staltz/xstream/contributors","subscribers_url":"https://api.github.com/repos/staltz/xstream/subscribers","subscription_url":"https://api.github.com/repos/staltz/xstream/subscription","commits_url":"https://api.github.com/repos/staltz/xstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/staltz/xstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/staltz/xstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/staltz/xstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/staltz/xstream/contents/{+path}","compare_url":"https://api.github.com/repos/staltz/xstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/staltz/xstream/merges","archive_url":"https://api.github.com/repos/staltz/xstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/staltz/xstream/downloads","issues_url":"https://api.github.com/repos/staltz/xstream/issues{/number}","pulls_url":"https://api.github.com/repos/staltz/xstream/pulls{/number}","milestones_url":"https://api.github.com/repos/staltz/xstream/milestones{/number}","notifications_url":"https://api.github.com/repos/staltz/xstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/staltz/xstream/labels{/name}","releases_url":"https://api.github.com/repos/staltz/xstream/releases{/id}","deployments_url":"https://api.github.com/repos/staltz/xstream/deployments","created_at":"2016-04-22T19:25:41Z","updated_at":"2016-07-10T18:23:27Z","pushed_at":"2016-07-10T03:04:49Z","git_url":"git://github.com/staltz/xstream.git","ssh_url":"git@github.com:staltz/xstream.git","clone_url":"https://github.com/staltz/xstream.git","svn_url":"https://github.com/staltz/xstream","homepage":"http://staltz.com/xstream/","size":686,"stargazers_count":520,"watchers_count":520,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":18,"forks":22,"open_issues":18,"watchers":520,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/staltz/xstream/pulls/73"},"html":{"href":"https://github.com/staltz/xstream/pull/73"},"issue":{"href":"https://api.github.com/repos/staltz/xstream/issues/73"},"comments":{"href":"https://api.github.com/repos/staltz/xstream/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/staltz/xstream/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/staltz/xstream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/staltz/xstream/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/staltz/xstream/statuses/575408d855b672b2f24193f49eba8d13c45008f7"}}}}
{"actor":{"display_login":"staltz"}}