{"action":"closed","number":411,"pull_request":{"url":"https://api.github.com/repos/Microsoft/pxt/pulls/411","id":87816372,"html_url":"https://github.com/Microsoft/pxt/pull/411","diff_url":"https://github.com/Microsoft/pxt/pull/411.diff","patch_url":"https://github.com/Microsoft/pxt/pull/411.patch","issue_url":"https://api.github.com/repos/Microsoft/pxt/issues/411","number":411,"state":"closed","locked":false,"title":"Display an error for floating point numbers if not supported","user":{"login":"riknoll","id":13754588,"avatar_url":"https://avatars.githubusercontent.com/u/13754588?v=3","gravatar_id":"","url":"https://api.github.com/users/riknoll","html_url":"https://github.com/riknoll","followers_url":"https://api.github.com/users/riknoll/followers","following_url":"https://api.github.com/users/riknoll/following{/other_user}","gists_url":"https://api.github.com/users/riknoll/gists{/gist_id}","starred_url":"https://api.github.com/users/riknoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riknoll/subscriptions","organizations_url":"https://api.github.com/users/riknoll/orgs","repos_url":"https://api.github.com/users/riknoll/repos","events_url":"https://api.github.com/users/riknoll/events{/privacy}","received_events_url":"https://api.github.com/users/riknoll/received_events","type":"User","site_admin":false},"body":"Fixes #2 (mostly)\r\n\r\nMakes using floating point numbers when targeting a board that does not support them an error. It looks like this:\r\n\r\n![decimal_errors](https://cloud.githubusercontent.com/assets/13754588/19058756/ccd05fa8-898e-11e6-9360-8a06b29a6b0e.png)\r\n\r\nAs part of this, I had to move the max-int check from the block compiler to the emitter, so typing in a huge number will give a similar error now. I also removed the max-float check because it didn't work (not sure if we want to add in a different working one?)","created_at":"2016-10-04T00:30:31Z","updated_at":"2016-10-04T05:09:50Z","closed_at":"2016-10-04T05:09:50Z","merged_at":"2016-10-04T05:09:50Z","merge_commit_sha":"4b0a75188b7dedbd17db24f490015f6c6a772311","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pxt/pulls/411/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pxt/pulls/411/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pxt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pxt/issues/411/comments","statuses_url":"https://api.github.com/repos/Microsoft/pxt/statuses/8db5d147c205ca97e92dcbaf271bd294e0c4d019","head":{"label":"Microsoft:float_checking","ref":"float_checking","sha":"8db5d147c205ca97e92dcbaf271bd294e0c4d019","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50304279,"name":"pxt","full_name":"Microsoft/pxt","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pxt","description":"Programming eXperience Toolkit","fork":false,"url":"https://api.github.com/repos/Microsoft/pxt","forks_url":"https://api.github.com/repos/Microsoft/pxt/forks","keys_url":"https://api.github.com/repos/Microsoft/pxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pxt/teams","hooks_url":"https://api.github.com/repos/Microsoft/pxt/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pxt/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pxt/events","assignees_url":"https://api.github.com/repos/Microsoft/pxt/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pxt/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pxt/tags","blobs_url":"https://api.github.com/repos/Microsoft/pxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pxt/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pxt/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pxt/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pxt/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pxt/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pxt/subscription","commits_url":"https://api.github.com/repos/Microsoft/pxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pxt/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pxt/merges","archive_url":"https://api.github.com/repos/Microsoft/pxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pxt/downloads","issues_url":"https://api.github.com/repos/Microsoft/pxt/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pxt/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pxt/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pxt/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pxt/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pxt/deployments","created_at":"2016-01-24T19:35:52Z","updated_at":"2016-09-25T15:05:52Z","pushed_at":"2016-10-04T05:09:50Z","git_url":"git://github.com/Microsoft/pxt.git","ssh_url":"git@github.com:Microsoft/pxt.git","clone_url":"https://github.com/Microsoft/pxt.git","svn_url":"https://github.com/Microsoft/pxt","homepage":"https://www.pxt.io","size":15484,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":89,"forks":21,"open_issues":89,"watchers":137,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"6def801a09a47f29317aa8b7c3d21338b31fbb6c","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50304279,"name":"pxt","full_name":"Microsoft/pxt","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pxt","description":"Programming eXperience Toolkit","fork":false,"url":"https://api.github.com/repos/Microsoft/pxt","forks_url":"https://api.github.com/repos/Microsoft/pxt/forks","keys_url":"https://api.github.com/repos/Microsoft/pxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pxt/teams","hooks_url":"https://api.github.com/repos/Microsoft/pxt/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pxt/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pxt/events","assignees_url":"https://api.github.com/repos/Microsoft/pxt/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pxt/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pxt/tags","blobs_url":"https://api.github.com/repos/Microsoft/pxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pxt/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pxt/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pxt/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pxt/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pxt/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pxt/subscription","commits_url":"https://api.github.com/repos/Microsoft/pxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pxt/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pxt/merges","archive_url":"https://api.github.com/repos/Microsoft/pxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pxt/downloads","issues_url":"https://api.github.com/repos/Microsoft/pxt/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pxt/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pxt/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pxt/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pxt/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pxt/deployments","created_at":"2016-01-24T19:35:52Z","updated_at":"2016-09-25T15:05:52Z","pushed_at":"2016-10-04T05:09:50Z","git_url":"git://github.com/Microsoft/pxt.git","ssh_url":"git@github.com:Microsoft/pxt.git","clone_url":"https://github.com/Microsoft/pxt.git","svn_url":"https://github.com/Microsoft/pxt","homepage":"https://www.pxt.io","size":15484,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":89,"forks":21,"open_issues":89,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/411"},"html":{"href":"https://github.com/Microsoft/pxt/pull/411"},"issue":{"href":"https://api.github.com/repos/Microsoft/pxt/issues/411"},"comments":{"href":"https://api.github.com/repos/Microsoft/pxt/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pxt/statuses/8db5d147c205ca97e92dcbaf271bd294e0c4d019"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pelikhan","id":4175913,"avatar_url":"https://avatars.githubusercontent.com/u/4175913?v=3","gravatar_id":"","url":"https://api.github.com/users/pelikhan","html_url":"https://github.com/pelikhan","followers_url":"https://api.github.com/users/pelikhan/followers","following_url":"https://api.github.com/users/pelikhan/following{/other_user}","gists_url":"https://api.github.com/users/pelikhan/gists{/gist_id}","starred_url":"https://api.github.com/users/pelikhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelikhan/subscriptions","organizations_url":"https://api.github.com/users/pelikhan/orgs","repos_url":"https://api.github.com/users/pelikhan/repos","events_url":"https://api.github.com/users/pelikhan/events{/privacy}","received_events_url":"https://api.github.com/users/pelikhan/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":17,"deletions":23,"changed_files":2}}
{"actor":{"display_login":"pelikhan"}}