{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_client/pulls/comments/76577691","id":76577691,"diff_hunk":"@@ -170,6 +172,20 @@ static void process_fs(union tee_rpc_invoke *request)\n \trequest->send.ret = TEEC_SUCCESS;;\n }\n \n+\n+static void process_sql_fs(union tee_rpc_invoke *request)\n+{\n+\tTEEC_SharedMemory shm;\n+\n+\tif (request->recv.num_params != 1 || get_param(request, 0, &shm)) {\n+\t\trequest->send.ret = TEEC_ERROR_BAD_PARAMETERS;\n+\t\treturn;\n+\t}\n+\n+\tsql_fs_process(shm.buffer, shm.size);","path":"tee-supplicant/src/tee_supplicant.c","position":40,"original_position":30,"commit_id":"41430757cbff931d763a98eee8742d838942d58a","original_commit_id":"30cc45af4acb201c61cf4160c1550e6f9c7aaf44","user":{"login":"etienne-lms","id":19990310,"avatar_url":"https://avatars.githubusercontent.com/u/19990310?v=3","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"you updated the legacy fs return status but `sql_fs_process()` return value is still discarded.","created_at":"2016-08-29T09:21:47Z","updated_at":"2016-08-29T09:21:47Z","html_url":"https://github.com/OP-TEE/optee_client/pull/50#discussion_r76577691","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_client/pulls/comments/76577691"},"html":{"href":"https://github.com/OP-TEE/optee_client/pull/50#discussion_r76577691"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50","id":69312120,"html_url":"https://github.com/OP-TEE/optee_client/pull/50","diff_url":"https://github.com/OP-TEE/optee_client/pull/50.diff","patch_url":"https://github.com/OP-TEE/optee_client/pull/50.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_client/issues/50","number":50,"state":"open","locked":false,"title":"SQLFS","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"body":"Adding support for a file system in a SQLite database. Will allow simplifying the REE-based Trusted Storage implementation  in OP-TEE, since SQLite provides atomicity thanks to its transaction-oriented interface.","created_at":"2016-05-09T08:41:52Z","updated_at":"2016-08-29T09:21:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7327b485f69f6a9cc5b23cb26a83a747300cc163","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_client/issues/50/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_client/statuses/41430757cbff931d763a98eee8742d838942d58a","head":{"label":"jforissier:sqlfs","ref":"sqlfs","sha":"41430757cbff931d763a98eee8742d838942d58a","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"repo":{"id":22476023,"name":"optee_client","full_name":"jforissier/optee_client","owner":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jforissier/optee_client","description":"Normal World Client side of the TEE","fork":true,"url":"https://api.github.com/repos/jforissier/optee_client","forks_url":"https://api.github.com/repos/jforissier/optee_client/forks","keys_url":"https://api.github.com/repos/jforissier/optee_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jforissier/optee_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jforissier/optee_client/teams","hooks_url":"https://api.github.com/repos/jforissier/optee_client/hooks","issue_events_url":"https://api.github.com/repos/jforissier/optee_client/issues/events{/number}","events_url":"https://api.github.com/repos/jforissier/optee_client/events","assignees_url":"https://api.github.com/repos/jforissier/optee_client/assignees{/user}","branches_url":"https://api.github.com/repos/jforissier/optee_client/branches{/branch}","tags_url":"https://api.github.com/repos/jforissier/optee_client/tags","blobs_url":"https://api.github.com/repos/jforissier/optee_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jforissier/optee_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jforissier/optee_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jforissier/optee_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jforissier/optee_client/statuses/{sha}","languages_url":"https://api.github.com/repos/jforissier/optee_client/languages","stargazers_url":"https://api.github.com/repos/jforissier/optee_client/stargazers","contributors_url":"https://api.github.com/repos/jforissier/optee_client/contributors","subscribers_url":"https://api.github.com/repos/jforissier/optee_client/subscribers","subscription_url":"https://api.github.com/repos/jforissier/optee_client/subscription","commits_url":"https://api.github.com/repos/jforissier/optee_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jforissier/optee_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jforissier/optee_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jforissier/optee_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jforissier/optee_client/contents/{+path}","compare_url":"https://api.github.com/repos/jforissier/optee_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jforissier/optee_client/merges","archive_url":"https://api.github.com/repos/jforissier/optee_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jforissier/optee_client/downloads","issues_url":"https://api.github.com/repos/jforissier/optee_client/issues{/number}","pulls_url":"https://api.github.com/repos/jforissier/optee_client/pulls{/number}","milestones_url":"https://api.github.com/repos/jforissier/optee_client/milestones{/number}","notifications_url":"https://api.github.com/repos/jforissier/optee_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jforissier/optee_client/labels{/name}","releases_url":"https://api.github.com/repos/jforissier/optee_client/releases{/id}","deployments_url":"https://api.github.com/repos/jforissier/optee_client/deployments","created_at":"2014-07-31T16:14:37Z","updated_at":"2014-12-07T18:49:59Z","pushed_at":"2016-08-18T14:55:39Z","git_url":"git://github.com/jforissier/optee_client.git","ssh_url":"git@github.com:jforissier/optee_client.git","clone_url":"https://github.com/jforissier/optee_client.git","svn_url":"https://github.com/jforissier/optee_client","homepage":"","size":2048,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"17d1addc465a667f375837cdbe4fa7ebac08539b","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":19610475,"name":"optee_client","full_name":"OP-TEE/optee_client","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_client","description":"Normal World Client side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_client","forks_url":"https://api.github.com/repos/OP-TEE/optee_client/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_client/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_client/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_client/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_client/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_client/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_client/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_client/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_client/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_client/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_client/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_client/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_client/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_client/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_client/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_client/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_client/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_client/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_client/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_client/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_client/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_client/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_client/deployments","created_at":"2014-05-09T12:33:33Z","updated_at":"2016-07-08T13:27:50Z","pushed_at":"2016-08-26T11:20:11Z","git_url":"git://github.com/OP-TEE/optee_client.git","ssh_url":"git@github.com:OP-TEE/optee_client.git","clone_url":"https://github.com/OP-TEE/optee_client.git","svn_url":"https://github.com/OP-TEE/optee_client","homepage":"","size":2051,"stargazers_count":37,"watchers_count":37,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":2,"forks":48,"open_issues":2,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50"},"html":{"href":"https://github.com/OP-TEE/optee_client/pull/50"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_client/issues/50"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_client/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_client/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_client/statuses/41430757cbff931d763a98eee8742d838942d58a"}}}}
{"actor":{"display_login":"etienne-lms"}}