{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/67770411","id":67770411,"diff_hunk":"@@ -345,6 +345,15 @@ func describeCustomStrategy(s *buildapi.CustomBuildStrategy, out *tabwriter.Writ\n }\n \n func describeJenkinsPipelineStrategy(s *buildapi.JenkinsPipelineBuildStrategy, out *tabwriter.Writer) {\n+\tif len(s.JenkinsfilePath) != 0 {\n+\t\tformatString(out, \"Jenkinsfile path\", s.JenkinsfilePath)\n+\t}\n+\tif len(s.Jenkinsfile) != 0 {\n+\t\tformatString(out, \"Jenkinsfile contents\", s.Jenkinsfile)\n+\t}\n+\tif len(s.Jenkinsfile) == 0 && len(s.JenkinsfilePath) == 0 {\n+\t\tformatString(out, \"Jenkinsfile\", \"neither file nor contents specified\")","path":"pkg/cmd/cli/describe/describer.go","position":11,"original_position":11,"commit_id":"1cdcf4f9cee1fb7b4d198b2e9579e16c4254dcda","original_commit_id":"1cdcf4f9cee1fb7b4d198b2e9579e16c4254dcda","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"\"Jenkinsfile\", \"from source repository root\"\r\n","created_at":"2016-06-20T21:30:49Z","updated_at":"2016-06-20T21:30:49Z","html_url":"https://github.com/openshift/origin/pull/9446#discussion_r67770411","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/9446","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/67770411"},"html":{"href":"https://github.com/openshift/origin/pull/9446#discussion_r67770411"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/9446"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/9446","id":74512540,"html_url":"https://github.com/openshift/origin/pull/9446","diff_url":"https://github.com/openshift/origin/pull/9446.diff","patch_url":"https://github.com/openshift/origin/pull/9446.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/9446","number":9446,"state":"open","locked":false,"title":"oc describe for JenkinsBuildStrategy","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/openshift/origin/issues/9441\r\n\r\n@bparees PTAL\r\n\r\nbtw, my reading of the types.go is that both Jenkinsfile and JenkinsfilePath can be empty, and I don't see any validation insuring at least one of them is set.  Is that intended?","created_at":"2016-06-20T21:01:19Z","updated_at":"2016-06-20T21:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6e2884600bbdac4abc9ae921d25979cc5954748","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/9446/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/9446/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/9446/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/1cdcf4f9cee1fb7b4d198b2e9579e16c4254dcda","head":{"label":"gabemontero:issue9441","ref":"issue9441","sha":"1cdcf4f9cee1fb7b4d198b2e9579e16c4254dcda","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36941154,"name":"origin","full_name":"gabemontero/origin","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/gabemontero/origin","forks_url":"https://api.github.com/repos/gabemontero/origin/forks","keys_url":"https://api.github.com/repos/gabemontero/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/origin/teams","hooks_url":"https://api.github.com/repos/gabemontero/origin/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/origin/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/origin/events","assignees_url":"https://api.github.com/repos/gabemontero/origin/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/origin/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/origin/tags","blobs_url":"https://api.github.com/repos/gabemontero/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/origin/languages","stargazers_url":"https://api.github.com/repos/gabemontero/origin/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/origin/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/origin/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/origin/subscription","commits_url":"https://api.github.com/repos/gabemontero/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/origin/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/origin/merges","archive_url":"https://api.github.com/repos/gabemontero/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/origin/downloads","issues_url":"https://api.github.com/repos/gabemontero/origin/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/origin/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/origin/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/origin/deployments","created_at":"2015-06-05T15:48:08Z","updated_at":"2016-01-11T14:36:57Z","pushed_at":"2016-06-20T20:59:56Z","git_url":"git://github.com/gabemontero/origin.git","ssh_url":"git@github.com:gabemontero/origin.git","clone_url":"https://github.com/gabemontero/origin.git","svn_url":"https://github.com/gabemontero/origin","homepage":"http://www.openshift.org","size":271376,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"7d6a536172ff82a6a60fbc51a71c35409e9017a0","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-06-20T12:48:45Z","pushed_at":"2016-06-20T21:18:01Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":514285,"stargazers_count":1391,"watchers_count":1391,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":833,"mirror_url":null,"open_issues_count":1051,"forks":833,"open_issues":1051,"watchers":1391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/9446"},"html":{"href":"https://github.com/openshift/origin/pull/9446"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/9446"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/9446/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/9446/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/9446/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/1cdcf4f9cee1fb7b4d198b2e9579e16c4254dcda"}}}}
{"actor":{"display_login":"bparees"}}