{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/85656143","pull_request_review_id":6360780,"id":85656143,"diff_hunk":"@@ -2795,7 +2795,9 @@ in\n \n   netboot = callPackage ../tools/networking/netboot {};\n \n-  netcat = callPackage ../tools/networking/netcat { };\n+  netcat = netcat-openbsd;\n+\n+  netcat-gnu = callPackage ../tools/networking/gnu-netcat { };","path":"pkgs/top-level/all-packages.nix","position":7,"original_position":7,"commit_id":"ffa7ee0d743532a494bb4b26f8569769cc2ded49","original_commit_id":"ffa7ee0d743532a494bb4b26f8569769cc2ded49","user":{"login":"sternenseemann","id":3154475,"avatar_url":"https://avatars.githubusercontent.com/u/3154475?v=3","gravatar_id":"","url":"https://api.github.com/users/sternenseemann","html_url":"https://github.com/sternenseemann","followers_url":"https://api.github.com/users/sternenseemann/followers","following_url":"https://api.github.com/users/sternenseemann/following{/other_user}","gists_url":"https://api.github.com/users/sternenseemann/gists{/gist_id}","starred_url":"https://api.github.com/users/sternenseemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternenseemann/subscriptions","organizations_url":"https://api.github.com/users/sternenseemann/orgs","repos_url":"https://api.github.com/users/sternenseemann/repos","events_url":"https://api.github.com/users/sternenseemann/events{/privacy}","received_events_url":"https://api.github.com/users/sternenseemann/received_events","type":"User","site_admin":false},"body":"Yeah, I had named it differently before, good point","created_at":"2016-10-30T09:34:39Z","updated_at":"2016-10-30T09:34:39Z","html_url":"https://github.com/NixOS/nixpkgs/pull/19982#discussion_r85656143","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/85656143"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/19982#discussion_r85656143"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982","id":91507296,"html_url":"https://github.com/NixOS/nixpkgs/pull/19982","diff_url":"https://github.com/NixOS/nixpkgs/pull/19982.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/19982.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19982","number":19982,"state":"open","locked":false,"title":"Make netcat-openbsd the default netcat","user":{"login":"sternenseemann","id":3154475,"avatar_url":"https://avatars.githubusercontent.com/u/3154475?v=3","gravatar_id":"","url":"https://api.github.com/users/sternenseemann","html_url":"https://github.com/sternenseemann","followers_url":"https://api.github.com/users/sternenseemann/followers","following_url":"https://api.github.com/users/sternenseemann/following{/other_user}","gists_url":"https://api.github.com/users/sternenseemann/gists{/gist_id}","starred_url":"https://api.github.com/users/sternenseemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternenseemann/subscriptions","organizations_url":"https://api.github.com/users/sternenseemann/orgs","repos_url":"https://api.github.com/users/sternenseemann/repos","events_url":"https://api.github.com/users/sternenseemann/events{/privacy}","received_events_url":"https://api.github.com/users/sternenseemann/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nSee Issue #19411. \r\n\r\nTL;DR: netcat-gnu does not support IPv6 and is therefore not a good idea for a default netcat.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [x] Fixed and tested compilation of all pkgs that depend on this change using\r\n    - [x] NixOS tests\r\n        - [x] `nixos/tests/hibernate.nix`\r\n        - [x] `nixos/tests/virtualbox.nix`\r\n    - [x] playonlinux\r\n    - [x] xfce4-sensors-plugin\r\n   - [ ] `build-support/vm/windows`\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\nI am open for suggestions on, how to test the windows vm build-support with GNU netcat, it might be broken.\r\n\r\n---\r\n\r\nA problem I see here is, that there is no standard deprecation process in nixpkgs (#15357). This change would certainly benefit from a `warnSemanticChange` which I proposed in this PR: #19315.","created_at":"2016-10-30T01:01:43Z","updated_at":"2016-10-30T09:34:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f39ef8afb6a730fcde9abffe68110f317d2e57c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19982/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ffa7ee0d743532a494bb4b26f8569769cc2ded49","head":{"label":"sternenseemann:netcat","ref":"netcat","sha":"ffa7ee0d743532a494bb4b26f8569769cc2ded49","user":{"login":"sternenseemann","id":3154475,"avatar_url":"https://avatars.githubusercontent.com/u/3154475?v=3","gravatar_id":"","url":"https://api.github.com/users/sternenseemann","html_url":"https://github.com/sternenseemann","followers_url":"https://api.github.com/users/sternenseemann/followers","following_url":"https://api.github.com/users/sternenseemann/following{/other_user}","gists_url":"https://api.github.com/users/sternenseemann/gists{/gist_id}","starred_url":"https://api.github.com/users/sternenseemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternenseemann/subscriptions","organizations_url":"https://api.github.com/users/sternenseemann/orgs","repos_url":"https://api.github.com/users/sternenseemann/repos","events_url":"https://api.github.com/users/sternenseemann/events{/privacy}","received_events_url":"https://api.github.com/users/sternenseemann/received_events","type":"User","site_admin":false},"repo":{"id":64657078,"name":"nixpkgs","full_name":"sternenseemann/nixpkgs","owner":{"login":"sternenseemann","id":3154475,"avatar_url":"https://avatars.githubusercontent.com/u/3154475?v=3","gravatar_id":"","url":"https://api.github.com/users/sternenseemann","html_url":"https://github.com/sternenseemann","followers_url":"https://api.github.com/users/sternenseemann/followers","following_url":"https://api.github.com/users/sternenseemann/following{/other_user}","gists_url":"https://api.github.com/users/sternenseemann/gists{/gist_id}","starred_url":"https://api.github.com/users/sternenseemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sternenseemann/subscriptions","organizations_url":"https://api.github.com/users/sternenseemann/orgs","repos_url":"https://api.github.com/users/sternenseemann/repos","events_url":"https://api.github.com/users/sternenseemann/events{/privacy}","received_events_url":"https://api.github.com/users/sternenseemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sternenseemann/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/sternenseemann/nixpkgs","forks_url":"https://api.github.com/repos/sternenseemann/nixpkgs/forks","keys_url":"https://api.github.com/repos/sternenseemann/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sternenseemann/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sternenseemann/nixpkgs/teams","hooks_url":"https://api.github.com/repos/sternenseemann/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/sternenseemann/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/sternenseemann/nixpkgs/events","assignees_url":"https://api.github.com/repos/sternenseemann/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/sternenseemann/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/sternenseemann/nixpkgs/tags","blobs_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sternenseemann/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/sternenseemann/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/sternenseemann/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/sternenseemann/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/sternenseemann/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/sternenseemann/nixpkgs/subscription","commits_url":"https://api.github.com/repos/sternenseemann/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sternenseemann/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sternenseemann/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sternenseemann/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sternenseemann/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/sternenseemann/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sternenseemann/nixpkgs/merges","archive_url":"https://api.github.com/repos/sternenseemann/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sternenseemann/nixpkgs/downloads","issues_url":"https://api.github.com/repos/sternenseemann/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/sternenseemann/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/sternenseemann/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/sternenseemann/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sternenseemann/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/sternenseemann/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/sternenseemann/nixpkgs/deployments","created_at":"2016-08-01T10:10:35Z","updated_at":"2016-08-01T10:11:06Z","pushed_at":"2016-10-30T00:54:25Z","git_url":"git://github.com/sternenseemann/nixpkgs.git","ssh_url":"git@github.com:sternenseemann/nixpkgs.git","clone_url":"https://github.com/sternenseemann/nixpkgs.git","svn_url":"https://github.com/sternenseemann/nixpkgs","homepage":null,"size":367123,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"9ca0521099ab44b65c763a200f741356b6073f33","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-10-29T19:37:02Z","pushed_at":"2016-10-30T09:00:17Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":625824,"stargazers_count":1362,"watchers_count":1362,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1687,"mirror_url":null,"open_issues_count":1563,"forks":1687,"open_issues":1563,"watchers":1362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/19982"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19982"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19982/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19982/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ffa7ee0d743532a494bb4b26f8569769cc2ded49"}}}}
{"actor":{"display_login":"sternenseemann"}}