{"action":"closed","number":9977,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9977","id":96129591,"html_url":"https://github.com/nodejs/node/pull/9977","diff_url":"https://github.com/nodejs/node/pull/9977.diff","patch_url":"https://github.com/nodejs/node/pull/9977.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/9977","number":9977,"state":"closed","locked":false,"title":"nina 2016 code-n-learn, issue: use assert.Equal()","user":{"login":"ianwhitedeveloper","id":5799538,"avatar_url":"https://avatars.githubusercontent.com/u/5799538?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwhitedeveloper","html_url":"https://github.com/ianwhitedeveloper","followers_url":"https://api.github.com/users/ianwhitedeveloper/followers","following_url":"https://api.github.com/users/ianwhitedeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ianwhitedeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwhitedeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwhitedeveloper/subscriptions","organizations_url":"https://api.github.com/users/ianwhitedeveloper/orgs","repos_url":"https://api.github.com/users/ianwhitedeveloper/repos","events_url":"https://api.github.com/users/ianwhitedeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ianwhitedeveloper/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nTest\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\ntest: change `assert.equal` to `assert.strictEqual`\r\n\r\nthe following lines have been updated:\r\n```\r\n27:1\r\n37:1\r\n49:1\r\n61:3\r\n66:1\r\n79:1\r\n```\r\n","created_at":"2016-12-01T17:04:46Z","updated_at":"2016-12-04T05:08:58Z","closed_at":"2016-12-04T05:08:58Z","merged_at":null,"merge_commit_sha":"f4cd16ffee89f12b8c7d2c131513960a6572391c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/9977/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/9977/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9977/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/a66cd9af38f336e9e30825864927cc64950f68ba","head":{"label":"ianwhitedeveloper:use-assert-equal","ref":"use-assert-equal","sha":"a66cd9af38f336e9e30825864927cc64950f68ba","user":{"login":"ianwhitedeveloper","id":5799538,"avatar_url":"https://avatars.githubusercontent.com/u/5799538?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwhitedeveloper","html_url":"https://github.com/ianwhitedeveloper","followers_url":"https://api.github.com/users/ianwhitedeveloper/followers","following_url":"https://api.github.com/users/ianwhitedeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ianwhitedeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwhitedeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwhitedeveloper/subscriptions","organizations_url":"https://api.github.com/users/ianwhitedeveloper/orgs","repos_url":"https://api.github.com/users/ianwhitedeveloper/repos","events_url":"https://api.github.com/users/ianwhitedeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ianwhitedeveloper/received_events","type":"User","site_admin":false},"repo":{"id":75308703,"name":"node","full_name":"ianwhitedeveloper/node","owner":{"login":"ianwhitedeveloper","id":5799538,"avatar_url":"https://avatars.githubusercontent.com/u/5799538?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwhitedeveloper","html_url":"https://github.com/ianwhitedeveloper","followers_url":"https://api.github.com/users/ianwhitedeveloper/followers","following_url":"https://api.github.com/users/ianwhitedeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ianwhitedeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwhitedeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwhitedeveloper/subscriptions","organizations_url":"https://api.github.com/users/ianwhitedeveloper/orgs","repos_url":"https://api.github.com/users/ianwhitedeveloper/repos","events_url":"https://api.github.com/users/ianwhitedeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ianwhitedeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianwhitedeveloper/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/ianwhitedeveloper/node","forks_url":"https://api.github.com/repos/ianwhitedeveloper/node/forks","keys_url":"https://api.github.com/repos/ianwhitedeveloper/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianwhitedeveloper/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianwhitedeveloper/node/teams","hooks_url":"https://api.github.com/repos/ianwhitedeveloper/node/hooks","issue_events_url":"https://api.github.com/repos/ianwhitedeveloper/node/issues/events{/number}","events_url":"https://api.github.com/repos/ianwhitedeveloper/node/events","assignees_url":"https://api.github.com/repos/ianwhitedeveloper/node/assignees{/user}","branches_url":"https://api.github.com/repos/ianwhitedeveloper/node/branches{/branch}","tags_url":"https://api.github.com/repos/ianwhitedeveloper/node/tags","blobs_url":"https://api.github.com/repos/ianwhitedeveloper/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianwhitedeveloper/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianwhitedeveloper/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianwhitedeveloper/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianwhitedeveloper/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ianwhitedeveloper/node/languages","stargazers_url":"https://api.github.com/repos/ianwhitedeveloper/node/stargazers","contributors_url":"https://api.github.com/repos/ianwhitedeveloper/node/contributors","subscribers_url":"https://api.github.com/repos/ianwhitedeveloper/node/subscribers","subscription_url":"https://api.github.com/repos/ianwhitedeveloper/node/subscription","commits_url":"https://api.github.com/repos/ianwhitedeveloper/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianwhitedeveloper/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianwhitedeveloper/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianwhitedeveloper/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianwhitedeveloper/node/contents/{+path}","compare_url":"https://api.github.com/repos/ianwhitedeveloper/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianwhitedeveloper/node/merges","archive_url":"https://api.github.com/repos/ianwhitedeveloper/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianwhitedeveloper/node/downloads","issues_url":"https://api.github.com/repos/ianwhitedeveloper/node/issues{/number}","pulls_url":"https://api.github.com/repos/ianwhitedeveloper/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ianwhitedeveloper/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ianwhitedeveloper/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianwhitedeveloper/node/labels{/name}","releases_url":"https://api.github.com/repos/ianwhitedeveloper/node/releases{/id}","deployments_url":"https://api.github.com/repos/ianwhitedeveloper/node/deployments","created_at":"2016-12-01T15:59:56Z","updated_at":"2016-12-01T16:00:23Z","pushed_at":"2016-12-02T15:54:07Z","git_url":"git://github.com/ianwhitedeveloper/node.git","ssh_url":"git@github.com:ianwhitedeveloper/node.git","clone_url":"https://github.com/ianwhitedeveloper/node.git","svn_url":"https://github.com/ianwhitedeveloper/node","homepage":"https://nodejs.org","size":247143,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"8a959107c0da7fe61ba0c54edc931a4a96144526","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-04T05:08:35Z","pushed_at":"2016-12-04T05:08:44Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":370707,"stargazers_count":29541,"watchers_count":29541,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5261,"mirror_url":null,"open_issues_count":1156,"forks":5261,"open_issues":1156,"watchers":29541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/9977"},"html":{"href":"https://github.com/nodejs/node/pull/9977"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/9977"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/9977/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/9977/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/9977/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/a66cd9af38f336e9e30825864927cc64950f68ba"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":9,"review_comments":3,"commits":2,"additions":9,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"Trott"}}