{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/dijit/issues/111","repository_url":"https://api.github.com/repos/dojo/dijit","labels_url":"https://api.github.com/repos/dojo/dijit/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/dojo/dijit/issues/111/comments","events_url":"https://api.github.com/repos/dojo/dijit/issues/111/events","html_url":"https://github.com/dojo/dijit/pull/111","id":136267940,"number":111,"title":"StackContainer: Don't prevent close if onClose is not defined","user":{"login":"kfranqueiro","id":398379,"avatar_url":"https://avatars.githubusercontent.com/u/398379?v=3","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-25T03:38:26Z","updated_at":"2016-02-25T05:40:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dojo/dijit/pulls/111","html_url":"https://github.com/dojo/dijit/pull/111","diff_url":"https://github.com/dojo/dijit/pull/111.diff","patch_url":"https://github.com/dojo/dijit/pull/111.patch"},"body":"Fixes [#18797](https://bugs.dojotoolkit.org/ticket/18797).\r\n\r\nIncludes an additional manual test; I didn't see any automated tests for `onClose` in general.  Admittedly setting `onClose` to `null` is a bit contrived, but `_Widget` includes a default `onClose` method that always returns `true`.  This issue mainly crops up with custom widgets extending only `_WidgetBase`, or something like dgrid."},"comment":{"url":"https://api.github.com/repos/dojo/dijit/issues/comments/188622790","html_url":"https://github.com/dojo/dijit/pull/111#issuecomment-188622790","issue_url":"https://api.github.com/repos/dojo/dijit/issues/111","id":188622790,"user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T05:40:38Z","updated_at":"2016-02-25T05:40:38Z","body":"Sure, seems fine."}}