{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/681","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/681/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/681/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/681/events","html_url":"https://github.com/vufind-org/vufind/pull/681","id":149216982,"number":681,"title":"[deb] Support for php7 and mariadb","user":{"login":"samueloph","id":2778482,"avatar_url":"https://avatars.githubusercontent.com/u/2778482?v=3","gravatar_id":"","url":"https://api.github.com/users/samueloph","html_url":"https://github.com/samueloph","followers_url":"https://api.github.com/users/samueloph/followers","following_url":"https://api.github.com/users/samueloph/following{/other_user}","gists_url":"https://api.github.com/users/samueloph/gists{/gist_id}","starred_url":"https://api.github.com/users/samueloph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueloph/subscriptions","organizations_url":"https://api.github.com/users/samueloph/orgs","repos_url":"https://api.github.com/users/samueloph/repos","events_url":"https://api.github.com/users/samueloph/events{/privacy}","received_events_url":"https://api.github.com/users/samueloph/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-18T17:26:12Z","updated_at":"2016-04-18T19:31:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/681","html_url":"https://github.com/vufind-org/vufind/pull/681","diff_url":"https://github.com/vufind-org/vufind/pull/681.diff","patch_url":"https://github.com/vufind-org/vufind/pull/681.patch"},"body":"# TO-DO\r\n- [ ] Confirm php7 support using debian sid.\r\n\r\nAs discussed on https://sourceforge.net/p/vufind/mailman/message/35002108/\r\n\r\nThis is the main change i would like to make in time to 3.0 release. The packaging process needs other changes that i'm planning to discuss and make (if you're willing) but they're not so much important as this one. This will make vufind compatible with php7 and mariadb de facto, because as long as vufind itself already support them its deb package don't.\r\n\r\nI would like to point out that this changes won't break the previous behaviour, it will just introduce new alternative dependencies based on virtual packages that can either provide php5 or php7, i did not test them yet, i'm planning to virtualize a debian sid to do so but it's very unlikelly that something is wrong and if it is, it would just break the php7 use case.\r\n\r\nHow are you guys on the release schedule? I'm planning to make the test at about this friday, but i understand that i may be pushing you guys to close to the deadline and if that's the case i can hurry up and test it tomorrow or wednesday.\r\n\r\nPS.: If i'm not wrong, only members of the project can label PRs, so i'm leaving this one without it."},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/211542259","html_url":"https://github.com/vufind-org/vufind/pull/681#issuecomment-211542259","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/681","id":211542259,"user":{"login":"samueloph","id":2778482,"avatar_url":"https://avatars.githubusercontent.com/u/2778482?v=3","gravatar_id":"","url":"https://api.github.com/users/samueloph","html_url":"https://github.com/samueloph","followers_url":"https://api.github.com/users/samueloph/followers","following_url":"https://api.github.com/users/samueloph/following{/other_user}","gists_url":"https://api.github.com/users/samueloph/gists{/gist_id}","starred_url":"https://api.github.com/users/samueloph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueloph/subscriptions","organizations_url":"https://api.github.com/users/samueloph/orgs","repos_url":"https://api.github.com/users/samueloph/repos","events_url":"https://api.github.com/users/samueloph/events{/privacy}","received_events_url":"https://api.github.com/users/samueloph/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T19:31:22Z","updated_at":"2016-04-18T19:31:22Z","body":"@demiankatz sorry, i forgot to mention how the dependencies will work in this case.\r\n\r\nThe package is requesting either mysql-server or virtual-mysql-server-core, which means any of these two is enough.\r\nIf none is installed, vufind will ask for mysql-server, and that's how it will work with php too, php5 by default but php7 acceptable instead.\r\n\r\nThe virtual-mysql-server-core package is a virtual package, the purpose of a virtual package is to group packages that satisfies equal needs, what happens is that when one installs mysql-server OR mariadb-server, the package virtual-mysql-server-core is installed as well as a dependency, so anybody with mariadb-server installed won't need to install mysql-server as well.\r\n\r\nI believe the only way to cause a problem would be if some debian based distro did a very strange and somewhat erroneous package of mariadb, causing it to not comply with the virtual package, but i don't think this is the case, and if it was, it would be a distro problem and probably fixed as soon as reported.\r\n\r\n> whether the package will install the correct dependencies if it encounters a Debian-based distro that has only mariadb and not mysql.\r\n\r\nThe only difference would be that mysql-server wouldn't be installed, the other dependencies would not be affected, especially since php-mysql is mariadb compatible.\r\n\r\nIf you find it better, I can test the new package with php7 and mariadb instead of php7 and mysql."}}