{"action":"created","comment":{"url":"https://api.github.com/repos/fetzerch/game.libretro/pulls/comments/86660503","pull_request_review_id":7310518,"id":86660503,"diff_hunk":"@@ -40,13 +40,6 @@ CInputManager& CInputManager::Get(void)\n   return _instance;\n }\n \n-CInputManager::CInputManager()\n-{\n-  game_controller mouseControllerStruct = {};\n-  mouseControllerStruct.controller_id = \"game.controller.mouse\";\n-  m_mouseDevice = std::make_shared<CLibretroDevice>(&mouseControllerStruct);\n-}","path":"src/input/InputManager.cpp","position":9,"original_position":9,"commit_id":"e9078fd7a7341d2653896070881b67f90914b1d4","original_commit_id":"e9078fd7a7341d2653896070881b67f90914b1d4","user":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"body":"It's not clear to me how this change is supposed to work. m_devices has no element for the mouse, because so far only OpenPort (via DeviceConnected) adds a new libretrodevice for it.","created_at":"2016-11-05T08:23:30Z","updated_at":"2016-11-05T08:24:14Z","html_url":"https://github.com/fetzerch/game.libretro/pull/4#discussion_r86660503","pull_request_url":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/fetzerch/game.libretro/pulls/comments/86660503"},"html":{"href":"https://github.com/fetzerch/game.libretro/pull/4#discussion_r86660503"},"pull_request":{"href":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4","id":92435840,"html_url":"https://github.com/fetzerch/game.libretro/pull/4","diff_url":"https://github.com/fetzerch/game.libretro/pull/4.diff","patch_url":"https://github.com/fetzerch/game.libretro/pull/4.patch","issue_url":"https://api.github.com/repos/fetzerch/game.libretro/issues/4","number":4,"state":"open","locked":false,"title":"Remove specialized mouse handling","user":{"login":"garbear","id":531482,"avatar_url":"https://avatars.githubusercontent.com/u/531482?v=3","gravatar_id":"","url":"https://api.github.com/users/garbear","html_url":"https://github.com/garbear","followers_url":"https://api.github.com/users/garbear/followers","following_url":"https://api.github.com/users/garbear/following{/other_user}","gists_url":"https://api.github.com/users/garbear/gists{/gist_id}","starred_url":"https://api.github.com/users/garbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbear/subscriptions","organizations_url":"https://api.github.com/users/garbear/orgs","repos_url":"https://api.github.com/users/garbear/repos","events_url":"https://api.github.com/users/garbear/events{/privacy}","received_events_url":"https://api.github.com/users/garbear/received_events","type":"User","site_admin":false},"body":"This should shrink the diff a little. I'll do another review when this is squashed into the v1.0.28 commit\r\n\r\nFor https://github.com/kodi-game/game.libretro/pull/7","created_at":"2016-11-05T00:42:56Z","updated_at":"2016-11-05T08:24:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81add7c0f325847779d3c53a2de2bef18992dc37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4/commits","review_comments_url":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4/comments","review_comment_url":"https://api.github.com/repos/fetzerch/game.libretro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fetzerch/game.libretro/issues/4/comments","statuses_url":"https://api.github.com/repos/fetzerch/game.libretro/statuses/e9078fd7a7341d2653896070881b67f90914b1d4","head":{"label":"kodi-game:mouse-pr","ref":"mouse-pr","sha":"e9078fd7a7341d2653896070881b67f90914b1d4","user":{"login":"kodi-game","id":11261185,"avatar_url":"https://avatars.githubusercontent.com/u/11261185?v=3","gravatar_id":"","url":"https://api.github.com/users/kodi-game","html_url":"https://github.com/kodi-game","followers_url":"https://api.github.com/users/kodi-game/followers","following_url":"https://api.github.com/users/kodi-game/following{/other_user}","gists_url":"https://api.github.com/users/kodi-game/gists{/gist_id}","starred_url":"https://api.github.com/users/kodi-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kodi-game/subscriptions","organizations_url":"https://api.github.com/users/kodi-game/orgs","repos_url":"https://api.github.com/users/kodi-game/repos","events_url":"https://api.github.com/users/kodi-game/events{/privacy}","received_events_url":"https://api.github.com/users/kodi-game/received_events","type":"Organization","site_admin":false},"repo":{"id":31511696,"name":"game.libretro","full_name":"kodi-game/game.libretro","owner":{"login":"kodi-game","id":11261185,"avatar_url":"https://avatars.githubusercontent.com/u/11261185?v=3","gravatar_id":"","url":"https://api.github.com/users/kodi-game","html_url":"https://github.com/kodi-game","followers_url":"https://api.github.com/users/kodi-game/followers","following_url":"https://api.github.com/users/kodi-game/following{/other_user}","gists_url":"https://api.github.com/users/kodi-game/gists{/gist_id}","starred_url":"https://api.github.com/users/kodi-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kodi-game/subscriptions","organizations_url":"https://api.github.com/users/kodi-game/orgs","repos_url":"https://api.github.com/users/kodi-game/repos","events_url":"https://api.github.com/users/kodi-game/events{/privacy}","received_events_url":"https://api.github.com/users/kodi-game/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kodi-game/game.libretro","description":"Libretro compatibility layer for the Kodi Game API","fork":false,"url":"https://api.github.com/repos/kodi-game/game.libretro","forks_url":"https://api.github.com/repos/kodi-game/game.libretro/forks","keys_url":"https://api.github.com/repos/kodi-game/game.libretro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kodi-game/game.libretro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kodi-game/game.libretro/teams","hooks_url":"https://api.github.com/repos/kodi-game/game.libretro/hooks","issue_events_url":"https://api.github.com/repos/kodi-game/game.libretro/issues/events{/number}","events_url":"https://api.github.com/repos/kodi-game/game.libretro/events","assignees_url":"https://api.github.com/repos/kodi-game/game.libretro/assignees{/user}","branches_url":"https://api.github.com/repos/kodi-game/game.libretro/branches{/branch}","tags_url":"https://api.github.com/repos/kodi-game/game.libretro/tags","blobs_url":"https://api.github.com/repos/kodi-game/game.libretro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kodi-game/game.libretro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kodi-game/game.libretro/git/refs{/sha}","trees_url":"https://api.github.com/repos/kodi-game/game.libretro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kodi-game/game.libretro/statuses/{sha}","languages_url":"https://api.github.com/repos/kodi-game/game.libretro/languages","stargazers_url":"https://api.github.com/repos/kodi-game/game.libretro/stargazers","contributors_url":"https://api.github.com/repos/kodi-game/game.libretro/contributors","subscribers_url":"https://api.github.com/repos/kodi-game/game.libretro/subscribers","subscription_url":"https://api.github.com/repos/kodi-game/game.libretro/subscription","commits_url":"https://api.github.com/repos/kodi-game/game.libretro/commits{/sha}","git_commits_url":"https://api.github.com/repos/kodi-game/game.libretro/git/commits{/sha}","comments_url":"https://api.github.com/repos/kodi-game/game.libretro/comments{/number}","issue_comment_url":"https://api.github.com/repos/kodi-game/game.libretro/issues/comments{/number}","contents_url":"https://api.github.com/repos/kodi-game/game.libretro/contents/{+path}","compare_url":"https://api.github.com/repos/kodi-game/game.libretro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kodi-game/game.libretro/merges","archive_url":"https://api.github.com/repos/kodi-game/game.libretro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kodi-game/game.libretro/downloads","issues_url":"https://api.github.com/repos/kodi-game/game.libretro/issues{/number}","pulls_url":"https://api.github.com/repos/kodi-game/game.libretro/pulls{/number}","milestones_url":"https://api.github.com/repos/kodi-game/game.libretro/milestones{/number}","notifications_url":"https://api.github.com/repos/kodi-game/game.libretro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kodi-game/game.libretro/labels{/name}","releases_url":"https://api.github.com/repos/kodi-game/game.libretro/releases{/id}","deployments_url":"https://api.github.com/repos/kodi-game/game.libretro/deployments","created_at":"2015-03-01T21:35:09Z","updated_at":"2016-10-24T21:08:49Z","pushed_at":"2016-11-05T04:35:12Z","git_url":"git://github.com/kodi-game/game.libretro.git","ssh_url":"git@github.com:kodi-game/game.libretro.git","clone_url":"https://github.com/kodi-game/game.libretro.git","svn_url":"https://github.com/kodi-game/game.libretro","homepage":null,"size":323,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"fetzerch:mouse","ref":"mouse","sha":"d595463a6d1e19cf9496b001b328a7667723d851","user":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"repo":{"id":71812693,"name":"game.libretro","full_name":"fetzerch/game.libretro","owner":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fetzerch/game.libretro","description":"Libretro compatibility layer for the Kodi Game API","fork":true,"url":"https://api.github.com/repos/fetzerch/game.libretro","forks_url":"https://api.github.com/repos/fetzerch/game.libretro/forks","keys_url":"https://api.github.com/repos/fetzerch/game.libretro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fetzerch/game.libretro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fetzerch/game.libretro/teams","hooks_url":"https://api.github.com/repos/fetzerch/game.libretro/hooks","issue_events_url":"https://api.github.com/repos/fetzerch/game.libretro/issues/events{/number}","events_url":"https://api.github.com/repos/fetzerch/game.libretro/events","assignees_url":"https://api.github.com/repos/fetzerch/game.libretro/assignees{/user}","branches_url":"https://api.github.com/repos/fetzerch/game.libretro/branches{/branch}","tags_url":"https://api.github.com/repos/fetzerch/game.libretro/tags","blobs_url":"https://api.github.com/repos/fetzerch/game.libretro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fetzerch/game.libretro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fetzerch/game.libretro/git/refs{/sha}","trees_url":"https://api.github.com/repos/fetzerch/game.libretro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fetzerch/game.libretro/statuses/{sha}","languages_url":"https://api.github.com/repos/fetzerch/game.libretro/languages","stargazers_url":"https://api.github.com/repos/fetzerch/game.libretro/stargazers","contributors_url":"https://api.github.com/repos/fetzerch/game.libretro/contributors","subscribers_url":"https://api.github.com/repos/fetzerch/game.libretro/subscribers","subscription_url":"https://api.github.com/repos/fetzerch/game.libretro/subscription","commits_url":"https://api.github.com/repos/fetzerch/game.libretro/commits{/sha}","git_commits_url":"https://api.github.com/repos/fetzerch/game.libretro/git/commits{/sha}","comments_url":"https://api.github.com/repos/fetzerch/game.libretro/comments{/number}","issue_comment_url":"https://api.github.com/repos/fetzerch/game.libretro/issues/comments{/number}","contents_url":"https://api.github.com/repos/fetzerch/game.libretro/contents/{+path}","compare_url":"https://api.github.com/repos/fetzerch/game.libretro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fetzerch/game.libretro/merges","archive_url":"https://api.github.com/repos/fetzerch/game.libretro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fetzerch/game.libretro/downloads","issues_url":"https://api.github.com/repos/fetzerch/game.libretro/issues{/number}","pulls_url":"https://api.github.com/repos/fetzerch/game.libretro/pulls{/number}","milestones_url":"https://api.github.com/repos/fetzerch/game.libretro/milestones{/number}","notifications_url":"https://api.github.com/repos/fetzerch/game.libretro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fetzerch/game.libretro/labels{/name}","releases_url":"https://api.github.com/repos/fetzerch/game.libretro/releases{/id}","deployments_url":"https://api.github.com/repos/fetzerch/game.libretro/deployments","created_at":"2016-10-24T17:13:58Z","updated_at":"2016-10-24T17:14:00Z","pushed_at":"2016-11-05T04:35:13Z","git_url":"git://github.com/fetzerch/game.libretro.git","ssh_url":"git@github.com:fetzerch/game.libretro.git","clone_url":"https://github.com/fetzerch/game.libretro.git","svn_url":"https://github.com/fetzerch/game.libretro","homepage":null,"size":330,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4"},"html":{"href":"https://github.com/fetzerch/game.libretro/pull/4"},"issue":{"href":"https://api.github.com/repos/fetzerch/game.libretro/issues/4"},"comments":{"href":"https://api.github.com/repos/fetzerch/game.libretro/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/fetzerch/game.libretro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fetzerch/game.libretro/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/fetzerch/game.libretro/statuses/e9078fd7a7341d2653896070881b67f90914b1d4"}}}}
{"actor":{"display_login":"fetzerch"}}