{"action":"created","issue":{"url":"https://api.github.com/repos/jonathanewerner/webpack-validator/issues/55","repository_url":"https://api.github.com/repos/jonathanewerner/webpack-validator","labels_url":"https://api.github.com/repos/jonathanewerner/webpack-validator/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/jonathanewerner/webpack-validator/issues/55/comments","events_url":"https://api.github.com/repos/jonathanewerner/webpack-validator/issues/55/events","html_url":"https://github.com/jonathanewerner/webpack-validator/pull/55","id":150161830,"number":55,"title":"Proposal new console output handling","user":{"login":"nyrosmith","id":2511026,"avatar_url":"https://avatars.githubusercontent.com/u/2511026?v=3","gravatar_id":"","url":"https://api.github.com/users/nyrosmith","html_url":"https://github.com/nyrosmith","followers_url":"https://api.github.com/users/nyrosmith/followers","following_url":"https://api.github.com/users/nyrosmith/following{/other_user}","gists_url":"https://api.github.com/users/nyrosmith/gists{/gist_id}","starred_url":"https://api.github.com/users/nyrosmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyrosmith/subscriptions","organizations_url":"https://api.github.com/users/nyrosmith/orgs","repos_url":"https://api.github.com/users/nyrosmith/repos","events_url":"https://api.github.com/users/nyrosmith/events{/privacy}","received_events_url":"https://api.github.com/users/nyrosmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2016-04-21T18:58:41Z","updated_at":"2016-04-23T12:52:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jonathanewerner/webpack-validator/pulls/55","html_url":"https://github.com/jonathanewerner/webpack-validator/pull/55","diff_url":"https://github.com/jonathanewerner/webpack-validator/pull/55.diff","patch_url":"https://github.com/jonathanewerner/webpack-validator/pull/55.patch"},"body":"As discussed in https://github.com/jonathanewerner/webpack-validator/issues/54 I changed the behavior to use Joi.validate and instead of throwing an error I set the correct exit code. This way webpack-validator can still be used for CI environments and makes it easier for integrating with the cli.\r\nWith Joi.validate all keys get validated and we can show the complete validationResult. Also no callstack gets printed. I think this is a big plus. Today I showed a peer webpack-validator and as he saw the callstack he was very confused and thought this means there is a bug...\r\nCaveat: we can no longer test the validate() function itself in its current form as it exits on validation errors. But I don't think that's a big deal as validate only calls Joi and does the console output. And with a bit of refactoring most of its logic can be tested again...\r\nATM lots of tests are broken as they expect thrown errors. I didn't want to put effort in fixing tests before I know you like my approach.\r\n\r\nHow do you think about this change @jonathanewerner @kentcdodds "},"comment":{"url":"https://api.github.com/repos/jonathanewerner/webpack-validator/issues/comments/213735771","html_url":"https://github.com/jonathanewerner/webpack-validator/pull/55#issuecomment-213735771","issue_url":"https://api.github.com/repos/jonathanewerner/webpack-validator/issues/55","id":213735771,"user":{"login":"nyrosmith","id":2511026,"avatar_url":"https://avatars.githubusercontent.com/u/2511026?v=3","gravatar_id":"","url":"https://api.github.com/users/nyrosmith","html_url":"https://github.com/nyrosmith","followers_url":"https://api.github.com/users/nyrosmith/followers","following_url":"https://api.github.com/users/nyrosmith/following{/other_user}","gists_url":"https://api.github.com/users/nyrosmith/gists{/gist_id}","starred_url":"https://api.github.com/users/nyrosmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyrosmith/subscriptions","organizations_url":"https://api.github.com/users/nyrosmith/orgs","repos_url":"https://api.github.com/users/nyrosmith/repos","events_url":"https://api.github.com/users/nyrosmith/events{/privacy}","received_events_url":"https://api.github.com/users/nyrosmith/received_events","type":"User","site_admin":false},"created_at":"2016-04-23T12:52:18Z","updated_at":"2016-04-23T12:52:18Z","body":"Maybe something with DX? Bc this is what all of us want to improve"}}