{"action":"created","issue":{"url":"https://api.github.com/repos/keokilee/react-electron-webview/issues/3","repository_url":"https://api.github.com/repos/keokilee/react-electron-webview","labels_url":"https://api.github.com/repos/keokilee/react-electron-webview/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/keokilee/react-electron-webview/issues/3/comments","events_url":"https://api.github.com/repos/keokilee/react-electron-webview/issues/3/events","html_url":"https://github.com/keokilee/react-electron-webview/pull/3","id":188766432,"number":3,"title":"Rename <eventName> props to <onEventName>","user":{"login":"flying-sheep","id":291575,"avatar_url":"https://avatars.githubusercontent.com/u/291575?v=3","gravatar_id":"","url":"https://api.github.com/users/flying-sheep","html_url":"https://github.com/flying-sheep","followers_url":"https://api.github.com/users/flying-sheep/followers","following_url":"https://api.github.com/users/flying-sheep/following{/other_user}","gists_url":"https://api.github.com/users/flying-sheep/gists{/gist_id}","starred_url":"https://api.github.com/users/flying-sheep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flying-sheep/subscriptions","organizations_url":"https://api.github.com/users/flying-sheep/orgs","repos_url":"https://api.github.com/users/flying-sheep/repos","events_url":"https://api.github.com/users/flying-sheep/events{/privacy}","received_events_url":"https://api.github.com/users/flying-sheep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-11T14:02:38Z","updated_at":"2016-11-11T14:13:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keokilee/react-electron-webview/pulls/3","html_url":"https://github.com/keokilee/react-electron-webview/pull/3","diff_url":"https://github.com/keokilee/react-electron-webview/pull/3.diff","patch_url":"https://github.com/keokilee/react-electron-webview/pull/3.patch"},"body":"also updates dependencies and fixes the event props being passed to the `<webview/>` tag.\r\n\r\nthese fixes remove all react warnings that previously occurred in the tests. so if there’s a switch to turn on test failure on warnings, it can be toggled now.\r\n\r\nafter this is pulled, a semver update to 2.0.0 is in order since this renames the event props"},"comment":{"url":"https://api.github.com/repos/keokilee/react-electron-webview/issues/comments/259965376","html_url":"https://github.com/keokilee/react-electron-webview/pull/3#issuecomment-259965376","issue_url":"https://api.github.com/repos/keokilee/react-electron-webview/issues/3","id":259965376,"user":{"login":"flying-sheep","id":291575,"avatar_url":"https://avatars.githubusercontent.com/u/291575?v=3","gravatar_id":"","url":"https://api.github.com/users/flying-sheep","html_url":"https://github.com/flying-sheep","followers_url":"https://api.github.com/users/flying-sheep/followers","following_url":"https://api.github.com/users/flying-sheep/following{/other_user}","gists_url":"https://api.github.com/users/flying-sheep/gists{/gist_id}","starred_url":"https://api.github.com/users/flying-sheep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flying-sheep/subscriptions","organizations_url":"https://api.github.com/users/flying-sheep/orgs","repos_url":"https://api.github.com/users/flying-sheep/repos","events_url":"https://api.github.com/users/flying-sheep/events{/privacy}","received_events_url":"https://api.github.com/users/flying-sheep/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T14:13:41Z","updated_at":"2016-11-11T14:13:41Z","body":"if you wonder why i changed the `EVENTS.reduce(…);` line: it’s clear that you went for a functional approach, but you only went halfway.\r\n\r\ninstead of\r\n\r\n```js\r\nanArray.reduce((o, k) => o[k] = thing, existingResultObject);\r\n```\r\n\r\ni’d just write\r\n\r\n```js\r\nfor (const k of anArray { existingResultObject[k] = thing; }\r\n```\r\n\r\nwhich is clearly imperative. i went for something (optimally close to) purely functional:\r\n\r\n```js\r\nconst resultObjectPart1 = { … };\r\nconst resultObjectPart2 = anArray.reduce((o, k) => { o[k] = thing; return o}, {});\r\nconst finalResultObject = Object.assign({}, resultObjectPart1, resultObjectPart1);\r\n```"}}
{"actor":{"display_login":"flying-sheep"}}