{"action":"opened","number":379,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/379","id":92409883,"html_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/379","diff_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/379.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-aws/pull/379.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/379","number":379,"state":"open","locked":false,"title":"Add support for security_group changes on ec2_instance","user":{"login":"zleswomp","id":16090312,"avatar_url":"https://avatars.githubusercontent.com/u/16090312?v=3","gravatar_id":"","url":"https://api.github.com/users/zleswomp","html_url":"https://github.com/zleswomp","followers_url":"https://api.github.com/users/zleswomp/followers","following_url":"https://api.github.com/users/zleswomp/following{/other_user}","gists_url":"https://api.github.com/users/zleswomp/gists{/gist_id}","starred_url":"https://api.github.com/users/zleswomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zleswomp/subscriptions","organizations_url":"https://api.github.com/users/zleswomp/orgs","repos_url":"https://api.github.com/users/zleswomp/repos","events_url":"https://api.github.com/users/zleswomp/events{/privacy}","received_events_url":"https://api.github.com/users/zleswomp/received_events","type":"User","site_admin":false},"body":"Without this work, the security_groups parameter on the ec2_instance\r\ntype is marked as read-only.  Here we remove the security_groups\r\nparameter from the read-only list and implement a setter method and the\r\nnecessary flush logic to modify the security groups attached to an\r\ninterface.\r\n\r\nThis is currently only implemented for instances with a single\r\ninterface, as the modification for what security groups are associated\r\nwith an instance is a change needed on the interface, and not the\r\ninstance.  This is a bit confusing because the interface security groups\r\nare represented on both the main instance object, and the interface\r\nobject.  For this reason, a new read-only parameter is also added here\r\nto collect information about the interfaces interfaces to ensure that we\r\nare only modifying the instances we know how, as well as collecting the\r\ndata to get the interface ID for modification in the flush method.","created_at":"2016-11-04T20:25:23Z","updated_at":"2016-11-04T20:25:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/379/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/379/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/379/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/statuses/689a127094524eb8a7c5dc6aab66945b2ab5fa47","head":{"label":"zleswomp:securitygroupmodify","ref":"securitygroupmodify","sha":"689a127094524eb8a7c5dc6aab66945b2ab5fa47","user":{"login":"zleswomp","id":16090312,"avatar_url":"https://avatars.githubusercontent.com/u/16090312?v=3","gravatar_id":"","url":"https://api.github.com/users/zleswomp","html_url":"https://github.com/zleswomp","followers_url":"https://api.github.com/users/zleswomp/followers","following_url":"https://api.github.com/users/zleswomp/following{/other_user}","gists_url":"https://api.github.com/users/zleswomp/gists{/gist_id}","starred_url":"https://api.github.com/users/zleswomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zleswomp/subscriptions","organizations_url":"https://api.github.com/users/zleswomp/orgs","repos_url":"https://api.github.com/users/zleswomp/repos","events_url":"https://api.github.com/users/zleswomp/events{/privacy}","received_events_url":"https://api.github.com/users/zleswomp/received_events","type":"User","site_admin":false},"repo":{"id":57080930,"name":"puppetlabs-aws","full_name":"zleswomp/puppetlabs-aws","owner":{"login":"zleswomp","id":16090312,"avatar_url":"https://avatars.githubusercontent.com/u/16090312?v=3","gravatar_id":"","url":"https://api.github.com/users/zleswomp","html_url":"https://github.com/zleswomp","followers_url":"https://api.github.com/users/zleswomp/followers","following_url":"https://api.github.com/users/zleswomp/following{/other_user}","gists_url":"https://api.github.com/users/zleswomp/gists{/gist_id}","starred_url":"https://api.github.com/users/zleswomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zleswomp/subscriptions","organizations_url":"https://api.github.com/users/zleswomp/orgs","repos_url":"https://api.github.com/users/zleswomp/repos","events_url":"https://api.github.com/users/zleswomp/events{/privacy}","received_events_url":"https://api.github.com/users/zleswomp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zleswomp/puppetlabs-aws","description":"Puppet module for managing AWS resources to build out infrastructure","fork":true,"url":"https://api.github.com/repos/zleswomp/puppetlabs-aws","forks_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/forks","keys_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/teams","hooks_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/hooks","issue_events_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/issues/events{/number}","events_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/events","assignees_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/assignees{/user}","branches_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/branches{/branch}","tags_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/tags","blobs_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/languages","stargazers_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/stargazers","contributors_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/contributors","subscribers_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/subscribers","subscription_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/subscription","commits_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/contents/{+path}","compare_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/merges","archive_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/downloads","issues_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/issues{/number}","pulls_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/labels{/name}","releases_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/releases{/id}","deployments_url":"https://api.github.com/repos/zleswomp/puppetlabs-aws/deployments","created_at":"2016-04-25T22:38:03Z","updated_at":"2016-04-25T22:38:05Z","pushed_at":"2016-11-04T20:25:09Z","git_url":"git://github.com/zleswomp/puppetlabs-aws.git","ssh_url":"git@github.com:zleswomp/puppetlabs-aws.git","clone_url":"https://github.com/zleswomp/puppetlabs-aws.git","svn_url":"https://github.com/zleswomp/puppetlabs-aws","homepage":"","size":1488,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"e3d574f289c8752b196a496f9733e2f157e0d341","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23803367,"name":"puppetlabs-aws","full_name":"puppetlabs/puppetlabs-aws","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-aws","description":"Puppet module for managing AWS resources to build out infrastructure","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/deployments","created_at":"2014-09-08T18:42:08Z","updated_at":"2016-10-26T05:29:50Z","pushed_at":"2016-11-03T15:12:48Z","git_url":"git://github.com/puppetlabs/puppetlabs-aws.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-aws.git","clone_url":"https://github.com/puppetlabs/puppetlabs-aws.git","svn_url":"https://github.com/puppetlabs/puppetlabs-aws","homepage":"","size":2290,"stargazers_count":149,"watchers_count":149,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":92,"forks":143,"open_issues":92,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/379"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-aws/pull/379"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/379"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-aws/statuses/689a127094524eb8a7c5dc6aab66945b2ab5fa47"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":63,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"zleswomp"}}