{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/76498134","id":76498134,"diff_hunk":"@@ -115,8 +115,8 @@\n   public enum MinorType {\n     NULL(Null.INSTANCE) {\n       @Override\n-      public Field getField() {\n-        return NULL_FIELD;\n+      public Field getField(String name) {\n+        return NULL_FIELD.newFieldWithName(name);","path":"java/vector/src/main/java/org/apache/arrow/vector/types/Types.java","position":7,"original_position":7,"commit_id":"d988d2e10e65281389992eadc1cc9b603e033c9c","original_commit_id":"d988d2e10e65281389992eadc1cc9b603e033c9c","user":{"login":"julienledem","id":367841,"avatar_url":"https://avatars.githubusercontent.com/u/367841?v=3","gravatar_id":"","url":"https://api.github.com/users/julienledem","html_url":"https://github.com/julienledem","followers_url":"https://api.github.com/users/julienledem/followers","following_url":"https://api.github.com/users/julienledem/following{/other_user}","gists_url":"https://api.github.com/users/julienledem/gists{/gist_id}","starred_url":"https://api.github.com/users/julienledem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienledem/subscriptions","organizations_url":"https://api.github.com/users/julienledem/orgs","repos_url":"https://api.github.com/users/julienledem/repos","events_url":"https://api.github.com/users/julienledem/events{/privacy}","received_events_url":"https://api.github.com/users/julienledem/received_events","type":"User","site_admin":false},"body":"The minor type is derived from the Field object. \r\nWe should be able to just pass the Field along wherever we pass the minor type and use that instead of trying to reconstruct it from the MinorType. The minorType can always be derived from Field when needed.","created_at":"2016-08-26T22:37:11Z","updated_at":"2016-08-26T22:37:11Z","html_url":"https://github.com/apache/arrow/pull/126#discussion_r76498134","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/76498134"},"html":{"href":"https://github.com/apache/arrow/pull/126#discussion_r76498134"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/126","id":82942508,"html_url":"https://github.com/apache/arrow/pull/126","diff_url":"https://github.com/apache/arrow/pull/126.diff","patch_url":"https://github.com/apache/arrow/pull/126.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/126","number":126,"state":"open","locked":false,"title":"ARROW-277: Fix Flatbuffer serialization for Timestamp type","user":{"login":"StevenMPhillips","id":3360419,"avatar_url":"https://avatars.githubusercontent.com/u/3360419?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenMPhillips","html_url":"https://github.com/StevenMPhillips","followers_url":"https://api.github.com/users/StevenMPhillips/followers","following_url":"https://api.github.com/users/StevenMPhillips/following{/other_user}","gists_url":"https://api.github.com/users/StevenMPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenMPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenMPhillips/subscriptions","organizations_url":"https://api.github.com/users/StevenMPhillips/orgs","repos_url":"https://api.github.com/users/StevenMPhillips/repos","events_url":"https://api.github.com/users/StevenMPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/StevenMPhillips/received_events","type":"User","site_admin":false},"body":"also add tests for roundtrip serde of all types","created_at":"2016-08-26T19:39:18Z","updated_at":"2016-08-26T22:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/126/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/126/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/126/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/d988d2e10e65281389992eadc1cc9b603e033c9c","head":{"label":"StevenMPhillips:arrow-277","ref":"arrow-277","sha":"d988d2e10e65281389992eadc1cc9b603e033c9c","user":{"login":"StevenMPhillips","id":3360419,"avatar_url":"https://avatars.githubusercontent.com/u/3360419?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenMPhillips","html_url":"https://github.com/StevenMPhillips","followers_url":"https://api.github.com/users/StevenMPhillips/followers","following_url":"https://api.github.com/users/StevenMPhillips/following{/other_user}","gists_url":"https://api.github.com/users/StevenMPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenMPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenMPhillips/subscriptions","organizations_url":"https://api.github.com/users/StevenMPhillips/orgs","repos_url":"https://api.github.com/users/StevenMPhillips/repos","events_url":"https://api.github.com/users/StevenMPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/StevenMPhillips/received_events","type":"User","site_admin":false},"repo":{"id":52549424,"name":"arrow","full_name":"StevenMPhillips/arrow","owner":{"login":"StevenMPhillips","id":3360419,"avatar_url":"https://avatars.githubusercontent.com/u/3360419?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenMPhillips","html_url":"https://github.com/StevenMPhillips","followers_url":"https://api.github.com/users/StevenMPhillips/followers","following_url":"https://api.github.com/users/StevenMPhillips/following{/other_user}","gists_url":"https://api.github.com/users/StevenMPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenMPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenMPhillips/subscriptions","organizations_url":"https://api.github.com/users/StevenMPhillips/orgs","repos_url":"https://api.github.com/users/StevenMPhillips/repos","events_url":"https://api.github.com/users/StevenMPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/StevenMPhillips/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StevenMPhillips/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/StevenMPhillips/arrow","forks_url":"https://api.github.com/repos/StevenMPhillips/arrow/forks","keys_url":"https://api.github.com/repos/StevenMPhillips/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StevenMPhillips/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StevenMPhillips/arrow/teams","hooks_url":"https://api.github.com/repos/StevenMPhillips/arrow/hooks","issue_events_url":"https://api.github.com/repos/StevenMPhillips/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/StevenMPhillips/arrow/events","assignees_url":"https://api.github.com/repos/StevenMPhillips/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/StevenMPhillips/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/StevenMPhillips/arrow/tags","blobs_url":"https://api.github.com/repos/StevenMPhillips/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StevenMPhillips/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StevenMPhillips/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/StevenMPhillips/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StevenMPhillips/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/StevenMPhillips/arrow/languages","stargazers_url":"https://api.github.com/repos/StevenMPhillips/arrow/stargazers","contributors_url":"https://api.github.com/repos/StevenMPhillips/arrow/contributors","subscribers_url":"https://api.github.com/repos/StevenMPhillips/arrow/subscribers","subscription_url":"https://api.github.com/repos/StevenMPhillips/arrow/subscription","commits_url":"https://api.github.com/repos/StevenMPhillips/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/StevenMPhillips/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/StevenMPhillips/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/StevenMPhillips/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/StevenMPhillips/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/StevenMPhillips/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StevenMPhillips/arrow/merges","archive_url":"https://api.github.com/repos/StevenMPhillips/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StevenMPhillips/arrow/downloads","issues_url":"https://api.github.com/repos/StevenMPhillips/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/StevenMPhillips/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/StevenMPhillips/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/StevenMPhillips/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StevenMPhillips/arrow/labels{/name}","releases_url":"https://api.github.com/repos/StevenMPhillips/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/StevenMPhillips/arrow/deployments","created_at":"2016-02-25T19:03:08Z","updated_at":"2016-03-01T08:01:37Z","pushed_at":"2016-08-26T19:38:45Z","git_url":"git://github.com/StevenMPhillips/arrow.git","ssh_url":"git@github.com:StevenMPhillips/arrow.git","clone_url":"https://github.com/StevenMPhillips/arrow.git","svn_url":"https://github.com/StevenMPhillips/arrow","homepage":null,"size":1470,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"803afeb502dcdd802fada2ed0d66c145546b8a78","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"name":"arrow","full_name":"apache/arrow","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/arrow","description":"Mirror of Apache Arrow","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2016-08-25T03:27:05Z","pushed_at":"2016-08-26T21:48:19Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":null,"size":1952,"stargazers_count":633,"watchers_count":633,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":"git://git.apache.org/arrow.git","open_issues_count":14,"forks":140,"open_issues":14,"watchers":633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/126"},"html":{"href":"https://github.com/apache/arrow/pull/126"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/126"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/d988d2e10e65281389992eadc1cc9b603e033c9c"}}}}
{"actor":{"display_login":"julienledem"}}