{"action":"created","comment":{"url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/comments/59719035","id":59719035,"diff_hunk":"@@ -0,0 +1,123 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Globalization;\n+using System.Threading.Tasks;\n+using System.Web;\n+using GitHubExtension.Statistics.WebApi.CommunicationModels;\n+using GitHubExtension.Statistics.WebApi.Extensions.Cookie;\n+using GitHubExtension.Statistics.WebApi.Mappers.GitHub;\n+using GitHubExtension.Statistics.WebApi.Queries.Interfaces;\n+\n+namespace GitHubExtension.Statistics.WebApi.Queries.Implementations\n+{\n+    public class StatisticsQuery : IStatisticsQuery\n+    {\n+        #region fields\n+        private readonly IGitHubQuery _gitHubQuery;\n+        private DateTime timeTo = DateTime.Now;\n+        private DateTime timeFrom;\n+        private int countDaysInYear = 364;\n+        private int countMounthInYear = 12;\n+        private ICollection<string> _activityMonths;\n+        private ICollection<RepositoryModel> _repositories;\n+        private ICollection<ICollection<int>> _commitsRepositories;\n+        private ICollection<int> _commitsForYear;\n+        private ICollection<int> _commitsRepository;\n+        private int countFollower;","path":"DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs","position":26,"original_position":26,"commit_id":"a8329aa049e82fda617f956fc5987bfd8a1ec82c","original_commit_id":"a8329aa049e82fda617f956fc5987bfd8a1ec82c","user":{"login":"AndrewGumenyuk","id":12097084,"avatar_url":"https://avatars.githubusercontent.com/u/12097084?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewGumenyuk","html_url":"https://github.com/AndrewGumenyuk","followers_url":"https://api.github.com/users/AndrewGumenyuk/followers","following_url":"https://api.github.com/users/AndrewGumenyuk/following{/other_user}","gists_url":"https://api.github.com/users/AndrewGumenyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewGumenyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewGumenyuk/subscriptions","organizations_url":"https://api.github.com/users/AndrewGumenyuk/orgs","repos_url":"https://api.github.com/users/AndrewGumenyuk/repos","events_url":"https://api.github.com/users/AndrewGumenyuk/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewGumenyuk/received_events","type":"User","site_admin":false},"body":"Some these variables is global variables, and i relocated their to top of class.\r\nBut I did a mistake when I relocated some variables to top of class i relocated some local variables.\r\nI know it's very bad. And i'm going to fix it .","created_at":"2016-04-14T13:45:48Z","updated_at":"2016-04-14T13:45:48Z","html_url":"https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59719035","pull_request_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/comments/59719035"},"html":{"href":"https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59719035"},"pull_request":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37","id":65893465,"html_url":"https://github.com/ITsvetkoFF/Kv-013/pull/37","diff_url":"https://github.com/ITsvetkoFF/Kv-013/pull/37.diff","patch_url":"https://github.com/ITsvetkoFF/Kv-013/pull/37.patch","issue_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/37","number":37,"state":"open","locked":false,"title":"Feature/statistics-back-end","user":{"login":"AndrewGumenyuk","id":12097084,"avatar_url":"https://avatars.githubusercontent.com/u/12097084?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewGumenyuk","html_url":"https://github.com/AndrewGumenyuk","followers_url":"https://api.github.com/users/AndrewGumenyuk/followers","following_url":"https://api.github.com/users/AndrewGumenyuk/following{/other_user}","gists_url":"https://api.github.com/users/AndrewGumenyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewGumenyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewGumenyuk/subscriptions","organizations_url":"https://api.github.com/users/AndrewGumenyuk/orgs","repos_url":"https://api.github.com/users/AndrewGumenyuk/repos","events_url":"https://api.github.com/users/AndrewGumenyuk/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewGumenyuk/received_events","type":"User","site_admin":false},"body":"**_In this pull request I have already corrected the remarks my reviewer._**\r\n_So, i added separation between FE and BE, also i delete WebConfig, Builder. I added extension methods, deleted Magic strings.\r\nAnd I've used Query (CQRS)_\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59166527%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59166710%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59166937%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59167048%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59167253%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59167527%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59169940%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59171125%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676396%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676720%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676791%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676873%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59677164%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59714343%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59715145%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%20a8329aa049e82fda617f956fc5987bfd8a1ec82c%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs%2095%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59677164%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20twi%20queries%20works%20only%20in%20pair%3F%20Or%20you%20have%20a%20case%20where%20they%20used%20separately%3F%22%2C%20%22created_at%22%3A%20%222016-04-14T08%3A09%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs%3AL1-124%22%7D%2C%20%22Pull%20a8329aa049e82fda617f956fc5987bfd8a1ec82c%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs%2064%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676873%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Extract%20to%20method.%22%2C%20%22created_at%22%3A%20%222016-04-14T08%3A07%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs%3AL1-124%22%7D%2C%20%22Pull%203614fb8d417bfd39648fea2635071726f3c42404%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs%2024%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59167527%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Nice%20method%20splitting.%20May%20be%20you%20can%20use%20all%20this%20method%20directly%20from%20the%20client%20and%20skipping%20any%20transformations%20on%20server%20side%3F%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A11%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%2C%20%7B%22body%22%3A%20%22Our%20task%20was%20to%20communicate%20through%20our%20web%20api%20with%20GitHub%20.%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A43%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12097084%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/AndrewGumenyuk%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs%3AL1-61%22%7D%2C%20%22Pull%20a8329aa049e82fda617f956fc5987bfd8a1ec82c%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676396%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Can%20you%20explain%20why%20you%20are%20created%20this%20private%20variables%3F%22%2C%20%22created_at%22%3A%20%222016-04-14T08%3A02%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%2C%20%7B%22body%22%3A%20%22Opps%2C%20I%20can%27nt%20explain%20this.%20But%20i%20can%20fix%20it%22%2C%20%22created_at%22%3A%20%222016-04-14T13%3A22%3A56Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12097084%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/AndrewGumenyuk%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs%3AL1-124%22%7D%2C%20%22Pull%203614fb8d417bfd39648fea2635071726f3c42404%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs%2013%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59166527%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22What%20means%20Bll%3F%3F%3F%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A02%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%2C%20%7B%22body%22%3A%20%22It%27s%20business%20logic%20layer%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A33%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12097084%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/AndrewGumenyuk%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs%3AL1-95%22%7D%2C%20%22Pull%203614fb8d417bfd39648fea2635071726f3c42404%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/CommunicationModels/GraphModel.cs%207%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59166937%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Do%20you%20really%20need%20model%20which%20holds%20just%20collections%20of%20objects%3F%20I%20suggest%20may%20be%20you%20can%20send%20multiple%20requests%20to%20server%20to%20get%20all%20parts%20of%20this%20model.%20May%20be%20you%20don%27t%20needed%20such%20monolitic%20model%3F%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A07%3A18Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/CommunicationModels/GraphModel.cs%3AL1-25%22%7D%2C%20%22Pull%203614fb8d417bfd39648fea2635071726f3c42404%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs%2037%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59167048%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20like%20such%20small%20piceces%20of%20code%20with%20loads%20data.%20Because%20it%20can%20be%20tuned%20and%20optimize%20in%20independent%20manner.%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A08%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs%3AL1-49%22%7D%2C%20%22Pull%203614fb8d417bfd39648fea2635071726f3c42404%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs%2054%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59166710%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Don%27t%20use%20explaining%20comments%21%20Use%20mote%20expressive%20method%20names%21%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A04%3A45Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs%3AL1-95%22%7D%2C%20%22Pull%20a8329aa049e82fda617f956fc5987bfd8a1ec82c%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs%2026%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676791%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20you%20need%20this%20private%20variables%3F%22%2C%20%22created_at%22%3A%20%222016-04-14T08%3A06%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%2C%20%7B%22body%22%3A%20%22ou%2C%20sorry.%5Cr%5CnI%20wiil%20fix%20it%20in%20next%20commit%22%2C%20%22created_at%22%3A%20%222016-04-14T13%3A17%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12097084%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/AndrewGumenyuk%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs%3AL1-124%22%7D%2C%20%22Pull%203614fb8d417bfd39648fea2635071726f3c42404%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Mappers/Identity/ClaimMapper.cs%207%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59167253%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22It%27s%20not%20a%20mapper.%20It%27s%20IdentityExtensions%20class.%22%2C%20%22created_at%22%3A%20%222016-04-11T08%3A09%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Mappers/Identity/ClaimMapper.cs%3AL1-21%22%7D%2C%20%22Pull%20a8329aa049e82fda617f956fc5987bfd8a1ec82c%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs%2036%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/37%23discussion_r59676720%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Btw%20please%20explain%20why%20ICollection%20is%20better%20then%20IEnumerable%3F%22%2C%20%22created_at%22%3A%20%222016-04-14T08%3A06%3A18Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs%3AL1-61%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [x] <a href='#crh-comment-Pull 3614fb8d417bfd39648fea2635071726f3c42404 DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs 13'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59166527'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs:L1-95</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> What means Bll???\n- <a href='https://github.com/AndrewGumenyuk'><img border=0 src='https://avatars.githubusercontent.com/u/12097084?v=3' height=16 width=16'></a> It's business logic layer\n- [x] <a href='#crh-comment-Pull 3614fb8d417bfd39648fea2635071726f3c42404 DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs 54'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59166710'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/BLL/Implementations/GraphsBLL.cs:L1-95</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Don't use explaining comments! Use mote expressive method names!\n- [x] <a href='#crh-comment-Pull 3614fb8d417bfd39648fea2635071726f3c42404 DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/CommunicationModels/GraphModel.cs 7'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59166937'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/CommunicationModels/GraphModel.cs:L1-25</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Do you really need model which holds just collections of objects? I suggest may be you can send multiple requests to server to get all parts of this model. May be you don't needed such monolitic model?\n- [x] <a href='#crh-comment-Pull 3614fb8d417bfd39648fea2635071726f3c42404 DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs 37'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59167048'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs:L1-49</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> I like such small piceces of code with loads data. Because it can be tuned and optimize in independent manner.\n- [x] <a href='#crh-comment-Pull 3614fb8d417bfd39648fea2635071726f3c42404 DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Mappers/Identity/ClaimMapper.cs 7'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59167253'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Mappers/Identity/ClaimMapper.cs:L1-21</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> It's not a mapper. It's IdentityExtensions class.\n- [x] <a href='#crh-comment-Pull 3614fb8d417bfd39648fea2635071726f3c42404 DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs 24'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59167527'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs:L1-61</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Nice method splitting. May be you can use all this method directly from the client and skipping any transformations on server side?\n- <a href='https://github.com/AndrewGumenyuk'><img border=0 src='https://avatars.githubusercontent.com/u/12097084?v=3' height=16 width=16'></a> Our task was to communicate through our web api with GitHub .\n- [ ] <a href='#crh-comment-Pull a8329aa049e82fda617f956fc5987bfd8a1ec82c DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs 17'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59676396'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Controllers/StatisticController.cs:L1-124</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Can you explain why you are created this private variables?\n- <a href='https://github.com/AndrewGumenyuk'><img border=0 src='https://avatars.githubusercontent.com/u/12097084?v=3' height=16 width=16'></a> Opps, I can'nt explain this. But i can fix it\n- [ ] <a href='#crh-comment-Pull a8329aa049e82fda617f956fc5987bfd8a1ec82c DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs 36'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59676720'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/GitHubQuery.cs:L1-61</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Btw please explain why ICollection is better then IEnumerable?\n- [ ] <a href='#crh-comment-Pull a8329aa049e82fda617f956fc5987bfd8a1ec82c DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs 26'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59676791'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs:L1-124</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Why you need this private variables?\n- <a href='https://github.com/AndrewGumenyuk'><img border=0 src='https://avatars.githubusercontent.com/u/12097084?v=3' height=16 width=16'></a> ou, sorry.\nI wiil fix it in next commit\n- [ ] <a href='#crh-comment-Pull a8329aa049e82fda617f956fc5987bfd8a1ec82c DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs 64'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59676873'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs:L1-124</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Extract to method.\n- [ ] <a href='#crh-comment-Pull a8329aa049e82fda617f956fc5987bfd8a1ec82c DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs 95'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/37#discussion_r59677164'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Statistics.WebApi/Queries/Implementations/StatisticsQuery.cs:L1-124</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> This twi queries works only in pair? Or you have a case where they used separately?\n\n\n<a href='https://www.codereviewhub.com/ITsvetkoFF/Kv-013/pull/37?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/ITsvetkoFF/Kv-013/pull/37?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/ITsvetkoFF/Kv-013/pull/37'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-04-09T21:44:45Z","updated_at":"2016-04-14T13:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c730f3dab9144ca568586dd57ef73606458c1eec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37/commits","review_comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37/comments","review_comment_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/37/comments","statuses_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/a8329aa049e82fda617f956fc5987bfd8a1ec82c","head":{"label":"ITsvetkoFF:feature/statistics-back-end","ref":"feature/statistics-back-end","sha":"a8329aa049e82fda617f956fc5987bfd8a1ec82c","user":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"repo":{"id":52432402,"name":"Kv-013","full_name":"ITsvetkoFF/Kv-013","owner":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ITsvetkoFF/Kv-013","description":"","fork":false,"url":"https://api.github.com/repos/ITsvetkoFF/Kv-013","forks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/forks","keys_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/teams","hooks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/hooks","issue_events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/events{/number}","events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/events","assignees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/assignees{/user}","branches_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/branches{/branch}","tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/tags","blobs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/refs{/sha}","trees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/{sha}","languages_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/languages","stargazers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/stargazers","contributors_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contributors","subscribers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscribers","subscription_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscription","commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/commits{/sha}","git_commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/commits{/sha}","comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/comments{/number}","issue_comment_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/comments{/number}","contents_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contents/{+path}","compare_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/merges","archive_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/downloads","issues_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues{/number}","pulls_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls{/number}","milestones_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/milestones{/number}","notifications_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/labels{/name}","releases_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/releases{/id}","deployments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/deployments","created_at":"2016-02-24T10:00:53Z","updated_at":"2016-04-13T16:22:43Z","pushed_at":"2016-04-14T13:20:18Z","git_url":"git://github.com/ITsvetkoFF/Kv-013.git","ssh_url":"git@github.com:ITsvetkoFF/Kv-013.git","clone_url":"https://github.com/ITsvetkoFF/Kv-013.git","svn_url":"https://github.com/ITsvetkoFF/Kv-013","homepage":null,"size":3179,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":6,"default_branch":"develop"}},"base":{"label":"ITsvetkoFF:develop","ref":"develop","sha":"3db59a9b10acf11feb405b3f47f60ed9541c2e47","user":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"repo":{"id":52432402,"name":"Kv-013","full_name":"ITsvetkoFF/Kv-013","owner":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ITsvetkoFF/Kv-013","description":"","fork":false,"url":"https://api.github.com/repos/ITsvetkoFF/Kv-013","forks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/forks","keys_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/teams","hooks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/hooks","issue_events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/events{/number}","events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/events","assignees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/assignees{/user}","branches_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/branches{/branch}","tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/tags","blobs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/refs{/sha}","trees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/{sha}","languages_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/languages","stargazers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/stargazers","contributors_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contributors","subscribers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscribers","subscription_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscription","commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/commits{/sha}","git_commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/commits{/sha}","comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/comments{/number}","issue_comment_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/comments{/number}","contents_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contents/{+path}","compare_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/merges","archive_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/downloads","issues_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues{/number}","pulls_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls{/number}","milestones_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/milestones{/number}","notifications_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/labels{/name}","releases_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/releases{/id}","deployments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/deployments","created_at":"2016-02-24T10:00:53Z","updated_at":"2016-04-13T16:22:43Z","pushed_at":"2016-04-14T13:20:18Z","git_url":"git://github.com/ITsvetkoFF/Kv-013.git","ssh_url":"git@github.com:ITsvetkoFF/Kv-013.git","clone_url":"https://github.com/ITsvetkoFF/Kv-013.git","svn_url":"https://github.com/ITsvetkoFF/Kv-013","homepage":null,"size":3179,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37"},"html":{"href":"https://github.com/ITsvetkoFF/Kv-013/pull/37"},"issue":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/37"},"comments":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/a8329aa049e82fda617f956fc5987bfd8a1ec82c"}}}}