{"action":"created","issue":{"url":"https://api.github.com/repos/daisy/pipeline-mod-braille/issues/88","repository_url":"https://api.github.com/repos/daisy/pipeline-mod-braille","labels_url":"https://api.github.com/repos/daisy/pipeline-mod-braille/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/daisy/pipeline-mod-braille/issues/88/comments","events_url":"https://api.github.com/repos/daisy/pipeline-mod-braille/issues/88/events","html_url":"https://github.com/daisy/pipeline-mod-braille/pull/88","id":137596857,"number":88,"title":"Deep inheritance, ++","user":{"login":"josteinaj","id":295481,"avatar_url":"https://avatars.githubusercontent.com/u/295481?v=3","gravatar_id":"","url":"https://api.github.com/users/josteinaj","html_url":"https://github.com/josteinaj","followers_url":"https://api.github.com/users/josteinaj/followers","following_url":"https://api.github.com/users/josteinaj/following{/other_user}","gists_url":"https://api.github.com/users/josteinaj/gists{/gist_id}","starred_url":"https://api.github.com/users/josteinaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josteinaj/subscriptions","organizations_url":"https://api.github.com/users/josteinaj/orgs","repos_url":"https://api.github.com/users/josteinaj/repos","events_url":"https://api.github.com/users/josteinaj/events{/privacy}","received_events_url":"https://api.github.com/users/josteinaj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/daisy/pipeline-mod-braille/labels/3%20-%20Review","name":"3 - Review","color":"cccccc"},{"url":"https://api.github.com/repos/daisy/pipeline-mod-braille/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"bertfrees","id":1167989,"avatar_url":"https://avatars.githubusercontent.com/u/1167989?v=3","gravatar_id":"","url":"https://api.github.com/users/bertfrees","html_url":"https://github.com/bertfrees","followers_url":"https://api.github.com/users/bertfrees/followers","following_url":"https://api.github.com/users/bertfrees/following{/other_user}","gists_url":"https://api.github.com/users/bertfrees/gists{/gist_id}","starred_url":"https://api.github.com/users/bertfrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertfrees/subscriptions","organizations_url":"https://api.github.com/users/bertfrees/orgs","repos_url":"https://api.github.com/users/bertfrees/repos","events_url":"https://api.github.com/users/bertfrees/events{/privacy}","received_events_url":"https://api.github.com/users/bertfrees/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-03-01T15:00:54Z","updated_at":"2016-03-01T16:24:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/daisy/pipeline-mod-braille/pulls/88","html_url":"https://github.com/daisy/pipeline-mod-braille/pull/88","diff_url":"https://github.com/daisy/pipeline-mod-braille/pull/88.diff","patch_url":"https://github.com/daisy/pipeline-mod-braille/pull/88.patch"},"body":"## Allow scripts to inherit from scripts that inherit from scripts\r\n\r\nIf you have scripts A and B in the same module, and script C in either the same module or another module, then A needs to extend the *generated* version of B so that documentation and attributes are carried through from C.\r\n\r\n## Added support for `px:inherit=\"prepend|append\"` on elements with `px:role=\"name|desc\"`.\r\n\r\nFor instance:\r\n\r\n```xml\r\n<p:option name=\"stuff\" ...>\r\n    <p:documentation xmlns=\"...\">\r\n        <p px:role=\"name\">Stuff</p>\r\n        <p px:role=\"desc\" px:inherit=\"prepend\">This and that</p>\r\n    </p:documentation>\r\n</p:option>\r\n```\r\n\r\nIn the above example, the content of the `<p px:role=\"desc\">` for the option `stuff` in the script that this script extends, will be prepended to the description in this script. So the generated content might be:\r\n\r\n```xml\r\n<p:option name=\"stuff\" ...>\r\n    <p:documentation xmlns=\"...\">\r\n        <p px:role=\"name\">Stuff</p>\r\n        <p px:role=\"desc\">Short description\r\n\r\nMore description\r\n\r\nThis and that</p>\r\n    </p:documentation>\r\n</p:option>\r\n```\r\n\r\nTwo newlines are inserted between the documentation in the script and the documentation in the script that is extended.\r\n\r\n## Allow referencing uris from same catalog in px:extends\r\n\r\nThe issue is that when loading documents referenced by px:extends using the XSLT `document` function; URIs from within the same catalog.xml does not seem to work. Using this patch, it works. However, corner cases using rewriteURI etc won't work, so it would be better to fix this in ProcessCatalogMojo.java. I'm just not quite sure how.\r\n\r\n## Other\r\n\r\n- if an optional option becomes required; don't copy its select attribute\r\n"},"comment":{"url":"https://api.github.com/repos/daisy/pipeline-mod-braille/issues/comments/190794535","html_url":"https://github.com/daisy/pipeline-mod-braille/pull/88#issuecomment-190794535","issue_url":"https://api.github.com/repos/daisy/pipeline-mod-braille/issues/88","id":190794535,"user":{"login":"bertfrees","id":1167989,"avatar_url":"https://avatars.githubusercontent.com/u/1167989?v=3","gravatar_id":"","url":"https://api.github.com/users/bertfrees","html_url":"https://github.com/bertfrees","followers_url":"https://api.github.com/users/bertfrees/followers","following_url":"https://api.github.com/users/bertfrees/following{/other_user}","gists_url":"https://api.github.com/users/bertfrees/gists{/gist_id}","starred_url":"https://api.github.com/users/bertfrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertfrees/subscriptions","organizations_url":"https://api.github.com/users/bertfrees/orgs","repos_url":"https://api.github.com/users/bertfrees/repos","events_url":"https://api.github.com/users/bertfrees/events{/privacy}","received_events_url":"https://api.github.com/users/bertfrees/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T16:24:58Z","updated_at":"2016-03-01T16:24:58Z","body":"Aha! I wondered what that last commit was about, but that was before I saw this PR. Now it makes sense. Great stuff.\r\n\r\nWhat is \"rewriteURI\"?"}}