{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/2096","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/2096/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2096/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/2096/events","html_url":"https://github.com/theforeman/foreman/pull/2096","id":54771300,"number":2096,"title":"fixes #8874 - rework POT/PO updates for gettext 3's edit.po","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-01-19T14:38:30Z","updated_at":"2016-01-21T12:44:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2096","html_url":"https://github.com/theforeman/foreman/pull/2096","diff_url":"https://github.com/theforeman/foreman/pull/2096.diff","patch_url":"https://github.com/theforeman/foreman/pull/2096.patch"},"body":"3.1.13 adds an intermediate .edit.po file alongside each .po, which is meant\r\nto be kept outside of SCM and updated by users, whereupon it's merged back into\r\nthe .po on the next rake gettext:find execution.\r\n\r\nPreviously we overwrote all gettext .po file changes with files directly from\r\nTransifex, but now these are downloaded to .edit.po and gettext merges them\r\nback in.  Fuzzy merges have been disabled as they were inaccurate.\r\n\r\n---\r\n\r\nReminder, use `make -C locale tx-update` to trigger it all.\r\n\r\nNote there are a couple of style changes in the POT file, but I think they're good.  1) \"TRANSLATORS\" is now showing up in the comments, 2) source locations are enabled, 3) the header is in template form.\r\n\r\nMore details on the ticket comments too."},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/173559422","html_url":"https://github.com/theforeman/foreman/pull/2096#issuecomment-173559422","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2096","id":173559422,"user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T12:44:17Z","updated_at":"2016-01-21T12:44:17Z","body":"Yes, that's the set of steps I was unhappy with in https://github.com/theforeman/foreman/pull/2096#issuecomment-71007012.  There's also an additional step after running the core rake task in (c) as the merged POs have to be recompiled into MO files (usually by running make in the plugin), which should be done with an extra target in the plugin's Makefile.  I think we'll have to live with this four-step process for now.\r\n\r\nhttps://github.com/theforeman/foreman_plugin_template/pull/13 shows the matching changes from the plugin perspective, and I've outlined the steps in the plugin maintainer's docs here: http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Pulling-translations-from-Transifex"}}