{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin-web-console/issues/125","repository_url":"https://api.github.com/repos/openshift/origin-web-console","labels_url":"https://api.github.com/repos/openshift/origin-web-console/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/125/comments","events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/125/events","html_url":"https://github.com/openshift/origin-web-console/pull/125","id":163242652,"number":125,"title":"[WIP][DO NOT MERGE] Fix Issue #109 - Table Empty Messages","user":{"login":"MarkDeMaria","id":19572090,"avatar_url":"https://avatars.githubusercontent.com/u/19572090?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkDeMaria","html_url":"https://github.com/MarkDeMaria","followers_url":"https://api.github.com/users/MarkDeMaria/followers","following_url":"https://api.github.com/users/MarkDeMaria/following{/other_user}","gists_url":"https://api.github.com/users/MarkDeMaria/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkDeMaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkDeMaria/subscriptions","organizations_url":"https://api.github.com/users/MarkDeMaria/orgs","repos_url":"https://api.github.com/users/MarkDeMaria/repos","events_url":"https://api.github.com/users/MarkDeMaria/events{/privacy}","received_events_url":"https://api.github.com/users/MarkDeMaria/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin-web-console/labels/needs-rebase","name":"needs-rebase","color":"cccccc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-06-30T18:59:46Z","updated_at":"2016-07-29T21:55:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/125","html_url":"https://github.com/openshift/origin-web-console/pull/125","diff_url":"https://github.com/openshift/origin-web-console/pull/125.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/125.patch"},"body":"This is to get the ball rolling on how I should approach these empty state table messages, as some pages have a 'Create Button' option when the table is empty and some pages do not. I know that some pages have tables in their sub-pages (the Events tab of a Deployment, the page for an Image Stream, the Events tab of a Pod, the page for a Service). If I have missed any major pages with tables please let me know!\r\n\r\nFixes #109\r\n\r\nThose with Create buttons that I have found:\r\n1. Routes\r\n\r\nThose without Create Buttons that I have found:\r\n1. Deployments\r\n2. Events\r\n3. Image Streams\r\n4. Pods\r\n5. Services\r\n6. Storage\r\n7. Other Resources\r\n\r\nFor pages without 'Create Buttons,' which pages should have create buttons added and which should not? Below are three screenshots - The first is an Empty State Table without a 'create button,' and the other two are tables with 'create buttons,' but one keeps its original 'create button' in the top right while the other removes it until there is something to show in the table.\r\n\r\nBuilds - No create buttons\r\n![image](https://cloud.githubusercontent.com/assets/19572090/16500400/58dda8c8-3ed2-11e6-8e75-7ef2bf6ea589.png)\r\n\r\nRoutes - Two Buttons\r\n![image](https://cloud.githubusercontent.com/assets/19572090/16500308/0c891eb2-3ed2-11e6-9f33-4ee77cb0df43.png)\r\n\r\nRoutes - One Button in Table (Other button will appear after there is >=1 route present)\r\n![image](https://cloud.githubusercontent.com/assets/19572090/16500371/485c98ce-3ed2-11e6-92c4-ef2993952fb7.png)\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments/236303596","html_url":"https://github.com/openshift/origin-web-console/pull/125#issuecomment-236303596","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/125","id":236303596,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T21:55:11Z","updated_at":"2016-07-29T21:55:11Z","body":"Origin Web Console Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again"}}
{"actor":{"display_login":"openshift-bot"}}