{"action":"created","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/2127","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/2127/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/2127/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/2127/events","html_url":"https://github.com/serverless/serverless/pull/2127","id":176830759,"number":2127,"title":"Automatically include policy to enable Lambda to access VPC when using VPC config","user":{"login":"andymac4182","id":1297073,"avatar_url":"https://avatars.githubusercontent.com/u/1297073?v=3","gravatar_id":"","url":"https://api.github.com/users/andymac4182","html_url":"https://github.com/andymac4182","followers_url":"https://api.github.com/users/andymac4182/followers","following_url":"https://api.github.com/users/andymac4182/following{/other_user}","gists_url":"https://api.github.com/users/andymac4182/gists{/gist_id}","starred_url":"https://api.github.com/users/andymac4182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymac4182/subscriptions","organizations_url":"https://api.github.com/users/andymac4182/orgs","repos_url":"https://api.github.com/users/andymac4182/repos","events_url":"https://api.github.com/users/andymac4182/events{/privacy}","received_events_url":"https://api.github.com/users/andymac4182/received_events","type":"User","site_admin":false},"labels":[{"id":376236320,"url":"https://api.github.com/repos/serverless/serverless/labels/area/serverless-core","name":"area/serverless-core","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2016-09-14T07:03:36Z","updated_at":"2016-11-10T09:31:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/2127","html_url":"https://github.com/serverless/serverless/pull/2127","diff_url":"https://github.com/serverless/serverless/pull/2127.diff","patch_url":"https://github.com/serverless/serverless/pull/2127.patch"},"body":"## What did you implement:\r\n\r\n**Closes:** #1934 and #1786 \r\n\r\n## How did you implement it:\r\n\r\nI have included moved the policies from separate Cloudformation objects to be included in the role. This ensures that the role has been created before the functions start to create removing the error \"Your access has been denied by EC2, please make sure your function execution role have permission to CreateNetworkInterface. EC2 Error Code: UnauthorizedOperation. EC2 Error Message: You are not authorized to perform this operation.\" from #1981. It will allow the functions to be deployed successfully\r\n## How can we verify it:\r\n\r\nDeploy a service with a vpc config with no custom iamRoleStatements and it will fail currently.\r\n## Todos:\r\n- [x] Write tests\r\n- [x] Write documentation\r\n- [x] Fix linting errors\r\n- [x] Make sure code coverage hasn't dropped\r\n- [x] Provide verification config/commands/resources\r\n- [x] Leave a comment that this is ready for review once you've finished the implementation\r\n"},"comment":{"url":"https://api.github.com/repos/serverless/serverless/issues/comments/259642555","html_url":"https://github.com/serverless/serverless/pull/2127#issuecomment-259642555","issue_url":"https://api.github.com/repos/serverless/serverless/issues/2127","id":259642555,"user":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T09:31:15Z","updated_at":"2016-11-10T09:31:15Z","body":"Hey @andymac4182 don't want to do a quick follow-up if you've heard something new or if we can help in any way?"}}
{"actor":{"display_login":"pmuens"}}