{"action":"created","comment":{"url":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/comments/61514526","id":61514526,"diff_hunk":"@@ -234,6 +234,10 @@ public String toString() {\n     return addressType;\n   }\n \n+  public String toCanonicalLiteral() {","path":"src/main/java/com/google/maps/model/AddressType.java","position":4,"original_position":4,"commit_id":"7e0e970f8a8f75180b0fcb1f8520be36ee5fe702","original_commit_id":"7e0e970f8a8f75180b0fcb1f8520be36ee5fe702","user":{"login":"domesticmouse","id":30503,"avatar_url":"https://avatars.githubusercontent.com/u/30503?v=3","gravatar_id":"","url":"https://api.github.com/users/domesticmouse","html_url":"https://github.com/domesticmouse","followers_url":"https://api.github.com/users/domesticmouse/followers","following_url":"https://api.github.com/users/domesticmouse/following{/other_user}","gists_url":"https://api.github.com/users/domesticmouse/gists{/gist_id}","starred_url":"https://api.github.com/users/domesticmouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domesticmouse/subscriptions","organizations_url":"https://api.github.com/users/domesticmouse/orgs","repos_url":"https://api.github.com/users/domesticmouse/repos","events_url":"https://api.github.com/users/domesticmouse/events{/privacy}","received_events_url":"https://api.github.com/users/domesticmouse/received_events","type":"User","site_admin":false},"body":"That's a reasonable request, now that I understand the context. Can you please add tests to cover the two `toCanonicalLiteral` calls you have added, just to make sure we don't break these while moving forwward. Thanks!","created_at":"2016-04-28T22:43:32Z","updated_at":"2016-04-28T22:43:32Z","html_url":"https://github.com/googlemaps/google-maps-services-java/pull/152#discussion_r61514526","pull_request_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/comments/61514526"},"html":{"href":"https://github.com/googlemaps/google-maps-services-java/pull/152#discussion_r61514526"},"pull_request":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152","id":68160500,"html_url":"https://github.com/googlemaps/google-maps-services-java/pull/152","diff_url":"https://github.com/googlemaps/google-maps-services-java/pull/152.diff","patch_url":"https://github.com/googlemaps/google-maps-services-java/pull/152.patch","issue_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/issues/152","number":152,"state":"open","locked":false,"title":"Adding canonical literals for AddressComponentType","user":{"login":"manjeshnilange","id":4511855,"avatar_url":"https://avatars.githubusercontent.com/u/4511855?v=3","gravatar_id":"","url":"https://api.github.com/users/manjeshnilange","html_url":"https://github.com/manjeshnilange","followers_url":"https://api.github.com/users/manjeshnilange/followers","following_url":"https://api.github.com/users/manjeshnilange/following{/other_user}","gists_url":"https://api.github.com/users/manjeshnilange/gists{/gist_id}","starred_url":"https://api.github.com/users/manjeshnilange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manjeshnilange/subscriptions","organizations_url":"https://api.github.com/users/manjeshnilange/orgs","repos_url":"https://api.github.com/users/manjeshnilange/repos","events_url":"https://api.github.com/users/manjeshnilange/events{/privacy}","received_events_url":"https://api.github.com/users/manjeshnilange/received_events","type":"User","site_admin":false},"body":"I noticed that while AddressType had the canonical literals (the exact strings in the server response), AddressComponentType didn't have them.","created_at":"2016-04-28T03:56:35Z","updated_at":"2016-04-28T22:43:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bee3200a2b9f1129f5ca160a0a13d35bc7e918d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152/commits","review_comments_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152/comments","review_comment_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/issues/152/comments","statuses_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/statuses/7e0e970f8a8f75180b0fcb1f8520be36ee5fe702","head":{"label":"manjeshnilange:canonical-literals","ref":"canonical-literals","sha":"7e0e970f8a8f75180b0fcb1f8520be36ee5fe702","user":{"login":"manjeshnilange","id":4511855,"avatar_url":"https://avatars.githubusercontent.com/u/4511855?v=3","gravatar_id":"","url":"https://api.github.com/users/manjeshnilange","html_url":"https://github.com/manjeshnilange","followers_url":"https://api.github.com/users/manjeshnilange/followers","following_url":"https://api.github.com/users/manjeshnilange/following{/other_user}","gists_url":"https://api.github.com/users/manjeshnilange/gists{/gist_id}","starred_url":"https://api.github.com/users/manjeshnilange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manjeshnilange/subscriptions","organizations_url":"https://api.github.com/users/manjeshnilange/orgs","repos_url":"https://api.github.com/users/manjeshnilange/repos","events_url":"https://api.github.com/users/manjeshnilange/events{/privacy}","received_events_url":"https://api.github.com/users/manjeshnilange/received_events","type":"User","site_admin":false},"repo":{"id":57269117,"name":"google-maps-services-java","full_name":"manjeshnilange/google-maps-services-java","owner":{"login":"manjeshnilange","id":4511855,"avatar_url":"https://avatars.githubusercontent.com/u/4511855?v=3","gravatar_id":"","url":"https://api.github.com/users/manjeshnilange","html_url":"https://github.com/manjeshnilange","followers_url":"https://api.github.com/users/manjeshnilange/followers","following_url":"https://api.github.com/users/manjeshnilange/following{/other_user}","gists_url":"https://api.github.com/users/manjeshnilange/gists{/gist_id}","starred_url":"https://api.github.com/users/manjeshnilange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manjeshnilange/subscriptions","organizations_url":"https://api.github.com/users/manjeshnilange/orgs","repos_url":"https://api.github.com/users/manjeshnilange/repos","events_url":"https://api.github.com/users/manjeshnilange/events{/privacy}","received_events_url":"https://api.github.com/users/manjeshnilange/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manjeshnilange/google-maps-services-java","description":"Java client library for Google Maps API Web Services","fork":true,"url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java","forks_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/forks","keys_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/teams","hooks_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/hooks","issue_events_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/issues/events{/number}","events_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/events","assignees_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/assignees{/user}","branches_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/branches{/branch}","tags_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/tags","blobs_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/statuses/{sha}","languages_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/languages","stargazers_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/stargazers","contributors_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/contributors","subscribers_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/subscribers","subscription_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/subscription","commits_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/contents/{+path}","compare_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/merges","archive_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/downloads","issues_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/issues{/number}","pulls_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/pulls{/number}","milestones_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/milestones{/number}","notifications_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/labels{/name}","releases_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/releases{/id}","deployments_url":"https://api.github.com/repos/manjeshnilange/google-maps-services-java/deployments","created_at":"2016-04-28T03:48:44Z","updated_at":"2016-04-28T03:48:45Z","pushed_at":"2016-04-28T03:54:16Z","git_url":"git://github.com/manjeshnilange/google-maps-services-java.git","ssh_url":"git@github.com:manjeshnilange/google-maps-services-java.git","clone_url":"https://github.com/manjeshnilange/google-maps-services-java.git","svn_url":"https://github.com/manjeshnilange/google-maps-services-java","homepage":"","size":1225,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlemaps:master","ref":"master","sha":"d8c94ddbe06b3fcea10f4e311bbb69124320208e","user":{"login":"googlemaps","id":3717923,"avatar_url":"https://avatars.githubusercontent.com/u/3717923?v=3","gravatar_id":"","url":"https://api.github.com/users/googlemaps","html_url":"https://github.com/googlemaps","followers_url":"https://api.github.com/users/googlemaps/followers","following_url":"https://api.github.com/users/googlemaps/following{/other_user}","gists_url":"https://api.github.com/users/googlemaps/gists{/gist_id}","starred_url":"https://api.github.com/users/googlemaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlemaps/subscriptions","organizations_url":"https://api.github.com/users/googlemaps/orgs","repos_url":"https://api.github.com/users/googlemaps/repos","events_url":"https://api.github.com/users/googlemaps/events{/privacy}","received_events_url":"https://api.github.com/users/googlemaps/received_events","type":"Organization","site_admin":false},"repo":{"id":22978651,"name":"google-maps-services-java","full_name":"googlemaps/google-maps-services-java","owner":{"login":"googlemaps","id":3717923,"avatar_url":"https://avatars.githubusercontent.com/u/3717923?v=3","gravatar_id":"","url":"https://api.github.com/users/googlemaps","html_url":"https://github.com/googlemaps","followers_url":"https://api.github.com/users/googlemaps/followers","following_url":"https://api.github.com/users/googlemaps/following{/other_user}","gists_url":"https://api.github.com/users/googlemaps/gists{/gist_id}","starred_url":"https://api.github.com/users/googlemaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlemaps/subscriptions","organizations_url":"https://api.github.com/users/googlemaps/orgs","repos_url":"https://api.github.com/users/googlemaps/repos","events_url":"https://api.github.com/users/googlemaps/events{/privacy}","received_events_url":"https://api.github.com/users/googlemaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlemaps/google-maps-services-java","description":"Java client library for Google Maps API Web Services","fork":false,"url":"https://api.github.com/repos/googlemaps/google-maps-services-java","forks_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/forks","keys_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/teams","hooks_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/hooks","issue_events_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/issues/events{/number}","events_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/events","assignees_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/assignees{/user}","branches_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/branches{/branch}","tags_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/tags","blobs_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/statuses/{sha}","languages_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/languages","stargazers_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/stargazers","contributors_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/contributors","subscribers_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/subscribers","subscription_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/subscription","commits_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/contents/{+path}","compare_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/merges","archive_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/downloads","issues_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/issues{/number}","pulls_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls{/number}","milestones_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/milestones{/number}","notifications_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/labels{/name}","releases_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/releases{/id}","deployments_url":"https://api.github.com/repos/googlemaps/google-maps-services-java/deployments","created_at":"2014-08-15T04:35:21Z","updated_at":"2016-04-28T08:30:54Z","pushed_at":"2016-04-28T03:56:36Z","git_url":"git://github.com/googlemaps/google-maps-services-java.git","ssh_url":"git@github.com:googlemaps/google-maps-services-java.git","clone_url":"https://github.com/googlemaps/google-maps-services-java.git","svn_url":"https://github.com/googlemaps/google-maps-services-java","homepage":"","size":1523,"stargazers_count":339,"watchers_count":339,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":263,"mirror_url":null,"open_issues_count":17,"forks":263,"open_issues":17,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152"},"html":{"href":"https://github.com/googlemaps/google-maps-services-java/pull/152"},"issue":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/issues/152"},"comments":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/googlemaps/google-maps-services-java/statuses/7e0e970f8a8f75180b0fcb1f8520be36ee5fe702"}}}}