{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/86019170","pull_request_review_id":6699588,"id":86019170,"diff_hunk":"@@ -8336,14 +8329,6 @@ namespace Js\n         if (sharedPropertyGuards != nullptr)\n         {\n             auto guards = AnewArray(alloc, Js::PropertyId, sharedPropertyGuards->Count());\n-\n-            struct AutoResizeLock\n-            {\n-                AutoResizeLock(SharedPropertyGuardDictionary* d) :d(d) { d->LockResize(); }\n-                ~AutoResizeLock() { d->UnlockResize(); }\n-                SharedPropertyGuardDictionary* d;\n-            } autoResizeLock(sharedPropertyGuards);","path":"lib/Runtime/Base/FunctionBody.cpp","position":null,"original_position":24,"commit_id":"21ddc33c92609daaabc92a3d463485ab4a11d0af","original_commit_id":"21ddc33c92609daaabc92a3d463485ab4a11d0af","user":{"login":"MikeHolman","id":4925255,"avatar_url":"https://avatars.githubusercontent.com/u/4925255?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeHolman","html_url":"https://github.com/MikeHolman","followers_url":"https://api.github.com/users/MikeHolman/followers","following_url":"https://api.github.com/users/MikeHolman/following{/other_user}","gists_url":"https://api.github.com/users/MikeHolman/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeHolman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeHolman/subscriptions","organizations_url":"https://api.github.com/users/MikeHolman/orgs","repos_url":"https://api.github.com/users/MikeHolman/repos","events_url":"https://api.github.com/users/MikeHolman/events{/privacy}","received_events_url":"https://api.github.com/users/MikeHolman/received_events","type":"User","site_admin":false},"body":"I think this one we still need resize lock","created_at":"2016-11-01T20:38:38Z","updated_at":"2016-11-01T20:38:38Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1894#discussion_r86019170","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/86019170"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1894#discussion_r86019170"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894","id":91841921,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1894","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1894.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1894.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1894","number":1894,"state":"open","locked":false,"title":"fix dead lock on GetSharedPropertyGuardsWithLock","user":{"login":"leirocks","id":15365664,"avatar_url":"https://avatars.githubusercontent.com/u/15365664?v=3","gravatar_id":"","url":"https://api.github.com/users/leirocks","html_url":"https://github.com/leirocks","followers_url":"https://api.github.com/users/leirocks/followers","following_url":"https://api.github.com/users/leirocks/following{/other_user}","gists_url":"https://api.github.com/users/leirocks/gists{/gist_id}","starred_url":"https://api.github.com/users/leirocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leirocks/subscriptions","organizations_url":"https://api.github.com/users/leirocks/orgs","repos_url":"https://api.github.com/users/leirocks/repos","events_url":"https://api.github.com/users/leirocks/events{/privacy}","received_events_url":"https://api.github.com/users/leirocks/received_events","type":"User","site_admin":false},"body":"GetSharedPropertyGuardsWithLock is called in background thread, should use the lock on the dictionary to sync","created_at":"2016-11-01T18:53:58Z","updated_at":"2016-11-01T20:38:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35314abbafc43eca640eeb945fb4bcf6f07d39db","assignee":{"login":"MikeHolman","id":4925255,"avatar_url":"https://avatars.githubusercontent.com/u/4925255?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeHolman","html_url":"https://github.com/MikeHolman","followers_url":"https://api.github.com/users/MikeHolman/followers","following_url":"https://api.github.com/users/MikeHolman/following{/other_user}","gists_url":"https://api.github.com/users/MikeHolman/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeHolman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeHolman/subscriptions","organizations_url":"https://api.github.com/users/MikeHolman/orgs","repos_url":"https://api.github.com/users/MikeHolman/repos","events_url":"https://api.github.com/users/MikeHolman/events{/privacy}","received_events_url":"https://api.github.com/users/MikeHolman/received_events","type":"User","site_admin":false},"assignees":[{"login":"MikeHolman","id":4925255,"avatar_url":"https://avatars.githubusercontent.com/u/4925255?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeHolman","html_url":"https://github.com/MikeHolman","followers_url":"https://api.github.com/users/MikeHolman/followers","following_url":"https://api.github.com/users/MikeHolman/following{/other_user}","gists_url":"https://api.github.com/users/MikeHolman/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeHolman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeHolman/subscriptions","organizations_url":"https://api.github.com/users/MikeHolman/orgs","repos_url":"https://api.github.com/users/MikeHolman/repos","events_url":"https://api.github.com/users/MikeHolman/events{/privacy}","received_events_url":"https://api.github.com/users/MikeHolman/received_events","type":"User","site_admin":false},{"login":"curtisman","id":12101885,"avatar_url":"https://avatars.githubusercontent.com/u/12101885?v=3","gravatar_id":"","url":"https://api.github.com/users/curtisman","html_url":"https://github.com/curtisman","followers_url":"https://api.github.com/users/curtisman/followers","following_url":"https://api.github.com/users/curtisman/following{/other_user}","gists_url":"https://api.github.com/users/curtisman/gists{/gist_id}","starred_url":"https://api.github.com/users/curtisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curtisman/subscriptions","organizations_url":"https://api.github.com/users/curtisman/orgs","repos_url":"https://api.github.com/users/curtisman/repos","events_url":"https://api.github.com/users/curtisman/events{/privacy}","received_events_url":"https://api.github.com/users/curtisman/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1894/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/21ddc33c92609daaabc92a3d463485ab4a11d0af","head":{"label":"leirocks:deadlock","ref":"deadlock","sha":"21ddc33c92609daaabc92a3d463485ab4a11d0af","user":{"login":"leirocks","id":15365664,"avatar_url":"https://avatars.githubusercontent.com/u/15365664?v=3","gravatar_id":"","url":"https://api.github.com/users/leirocks","html_url":"https://github.com/leirocks","followers_url":"https://api.github.com/users/leirocks/followers","following_url":"https://api.github.com/users/leirocks/following{/other_user}","gists_url":"https://api.github.com/users/leirocks/gists{/gist_id}","starred_url":"https://api.github.com/users/leirocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leirocks/subscriptions","organizations_url":"https://api.github.com/users/leirocks/orgs","repos_url":"https://api.github.com/users/leirocks/repos","events_url":"https://api.github.com/users/leirocks/events{/privacy}","received_events_url":"https://api.github.com/users/leirocks/received_events","type":"User","site_admin":false},"repo":{"id":49605998,"name":"ChakraCore","full_name":"leirocks/ChakraCore","owner":{"login":"leirocks","id":15365664,"avatar_url":"https://avatars.githubusercontent.com/u/15365664?v=3","gravatar_id":"","url":"https://api.github.com/users/leirocks","html_url":"https://github.com/leirocks","followers_url":"https://api.github.com/users/leirocks/followers","following_url":"https://api.github.com/users/leirocks/following{/other_user}","gists_url":"https://api.github.com/users/leirocks/gists{/gist_id}","starred_url":"https://api.github.com/users/leirocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leirocks/subscriptions","organizations_url":"https://api.github.com/users/leirocks/orgs","repos_url":"https://api.github.com/users/leirocks/repos","events_url":"https://api.github.com/users/leirocks/events{/privacy}","received_events_url":"https://api.github.com/users/leirocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leirocks/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/leirocks/ChakraCore","forks_url":"https://api.github.com/repos/leirocks/ChakraCore/forks","keys_url":"https://api.github.com/repos/leirocks/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leirocks/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leirocks/ChakraCore/teams","hooks_url":"https://api.github.com/repos/leirocks/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/leirocks/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/leirocks/ChakraCore/events","assignees_url":"https://api.github.com/repos/leirocks/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/leirocks/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/leirocks/ChakraCore/tags","blobs_url":"https://api.github.com/repos/leirocks/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leirocks/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leirocks/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/leirocks/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leirocks/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/leirocks/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/leirocks/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/leirocks/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/leirocks/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/leirocks/ChakraCore/subscription","commits_url":"https://api.github.com/repos/leirocks/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/leirocks/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/leirocks/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/leirocks/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/leirocks/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/leirocks/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leirocks/ChakraCore/merges","archive_url":"https://api.github.com/repos/leirocks/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leirocks/ChakraCore/downloads","issues_url":"https://api.github.com/repos/leirocks/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/leirocks/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/leirocks/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/leirocks/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leirocks/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/leirocks/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/leirocks/ChakraCore/deployments","created_at":"2016-01-13T22:22:27Z","updated_at":"2016-01-13T22:52:58Z","pushed_at":"2016-11-01T20:30:14Z","git_url":"git://github.com/leirocks/ChakraCore.git","ssh_url":"git@github.com:leirocks/ChakraCore.git","clone_url":"https://github.com/leirocks/ChakraCore.git","svn_url":"https://github.com/leirocks/ChakraCore","homepage":null,"size":42717,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0cdf92d105067cc00fe1be9d2eccb6b54c03dd13","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-11-01T20:04:51Z","pushed_at":"2016-11-01T20:36:17Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":54990,"stargazers_count":5715,"watchers_count":5715,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":647,"mirror_url":null,"open_issues_count":231,"forks":647,"open_issues":231,"watchers":5715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1894"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1894"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1894/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1894/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/21ddc33c92609daaabc92a3d463485ab4a11d0af"}}}}
{"actor":{"display_login":"MikeHolman"}}