{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/90928859","pull_request_review_id":11442286,"id":90928859,"diff_hunk":"@@ -991,6 +1000,14 @@ hashing_cost=8\n # Disable Active-Directory domain configuration from within PacketFence\n disable_pf_domain_auth=disabled\n #\n+# advanced.ntlm_redis_cache\n+#\n+# Enables a Redis driven cache for NTLM authentication. \n+# In order for this to work, you need to setup proper NT hash syncronization between your PacketFence server and your AD.\n+# Refer to the Administration guide for more details.\n+# Applying this requires a restart of radiusd.","path":"conf/pf.conf.defaults","position":25,"original_position":25,"commit_id":"49f7d38ff9480bf7c9f47850200b25c585bab88b","original_commit_id":"49f7d38ff9480bf7c9f47850200b25c585bab88b","user":{"login":"extrafu","id":1616141,"avatar_url":"https://avatars.githubusercontent.com/u/1616141?v=3","gravatar_id":"","url":"https://api.github.com/users/extrafu","html_url":"https://github.com/extrafu","followers_url":"https://api.github.com/users/extrafu/followers","following_url":"https://api.github.com/users/extrafu/following{/other_user}","gists_url":"https://api.github.com/users/extrafu/gists{/gist_id}","starred_url":"https://api.github.com/users/extrafu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/extrafu/subscriptions","organizations_url":"https://api.github.com/users/extrafu/orgs","repos_url":"https://api.github.com/users/extrafu/repos","events_url":"https://api.github.com/users/extrafu/events{/privacy}","received_events_url":"https://api.github.com/users/extrafu/received_events","type":"User","site_admin":false},"body":"See above for comment","created_at":"2016-12-05T18:45:06Z","updated_at":"2016-12-05T18:45:07Z","html_url":"https://github.com/inverse-inc/packetfence/pull/1885#discussion_r90928859","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/90928859"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/1885#discussion_r90928859"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885","id":96584371,"html_url":"https://github.com/inverse-inc/packetfence/pull/1885","diff_url":"https://github.com/inverse-inc/packetfence/pull/1885.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/1885.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1885","number":1885,"state":"open","locked":false,"title":"Feature/ntlm redis cache","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"# NOT READY\r\n\r\n## Missing\r\n* post-authentication caching (not batch driven)\r\n* documentation\r\n\r\n# Description\r\nAdds an NTLM authentication cache to FreeRADIUS via Redis\r\nReworks the domain page so modifying non-binding infos doesn't always trigger a join\r\n\r\n# Impacts\r\nNTLM authentication\r\n\r\n# Delete branch after merge\r\nYES\r\n\r\n# NEWS file entries\r\n## New Features\r\n* Added an optional Redis driven cache for NTLM (Active Directory) 802.1x authentication\r\n","created_at":"2016-12-05T18:35:36Z","updated_at":"2016-12-05T18:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7bc4d5694ab7956e23f9214d20b20877d412c40","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1885/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/49f7d38ff9480bf7c9f47850200b25c585bab88b","head":{"label":"julsemaan:feature/ntlm-redis-cache","ref":"feature/ntlm-redis-cache","sha":"49f7d38ff9480bf7c9f47850200b25c585bab88b","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"repo":{"id":9198603,"name":"packetfence","full_name":"julsemaan/packetfence","owner":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julsemaan/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/julsemaan/packetfence","forks_url":"https://api.github.com/repos/julsemaan/packetfence/forks","keys_url":"https://api.github.com/repos/julsemaan/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julsemaan/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julsemaan/packetfence/teams","hooks_url":"https://api.github.com/repos/julsemaan/packetfence/hooks","issue_events_url":"https://api.github.com/repos/julsemaan/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/julsemaan/packetfence/events","assignees_url":"https://api.github.com/repos/julsemaan/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/julsemaan/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/julsemaan/packetfence/tags","blobs_url":"https://api.github.com/repos/julsemaan/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julsemaan/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julsemaan/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/julsemaan/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julsemaan/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/julsemaan/packetfence/languages","stargazers_url":"https://api.github.com/repos/julsemaan/packetfence/stargazers","contributors_url":"https://api.github.com/repos/julsemaan/packetfence/contributors","subscribers_url":"https://api.github.com/repos/julsemaan/packetfence/subscribers","subscription_url":"https://api.github.com/repos/julsemaan/packetfence/subscription","commits_url":"https://api.github.com/repos/julsemaan/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/julsemaan/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/julsemaan/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/julsemaan/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/julsemaan/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/julsemaan/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julsemaan/packetfence/merges","archive_url":"https://api.github.com/repos/julsemaan/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julsemaan/packetfence/downloads","issues_url":"https://api.github.com/repos/julsemaan/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/julsemaan/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/julsemaan/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/julsemaan/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julsemaan/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/julsemaan/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/julsemaan/packetfence/deployments","created_at":"2013-04-03T15:52:51Z","updated_at":"2014-06-17T14:56:13Z","pushed_at":"2016-12-05T18:38:55Z","git_url":"git://github.com/julsemaan/packetfence.git","ssh_url":"git@github.com:julsemaan/packetfence.git","clone_url":"https://github.com/julsemaan/packetfence.git","svn_url":"https://github.com/julsemaan/packetfence","homepage":"http://www.packetfence.org","size":181207,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"9f4f001a5a34aa55f8b3fc7272b4f49154877fae","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful BYOD management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2016-11-30T19:31:43Z","pushed_at":"2016-12-05T18:38:55Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"https://packetfence.org","size":213491,"stargazers_count":240,"watchers_count":240,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":249,"forks":106,"open_issues":249,"watchers":240,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/1885"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/1885"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/1885/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1885/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/49f7d38ff9480bf7c9f47850200b25c585bab88b"}}}}
{"actor":{"display_login":"extrafu"}}