{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab/pulls/comments/82501282","pull_request_review_id":3407395,"id":82501282,"diff_hunk":"@@ -0,0 +1,334 @@\n+/**\n+ * Copyright (c) 2010-2016, openHAB.org and others.\n+ *\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ */\n+package org.openhab.persistence.dynamodb.internal;\n+\n+import static org.junit.Assert.*;\n+\n+import java.util.Date;\n+import java.util.Iterator;\n+\n+import org.junit.Assume;\n+import org.junit.BeforeClass;\n+import org.junit.Test;\n+import org.openhab.core.persistence.FilterCriteria;\n+import org.openhab.core.persistence.FilterCriteria.Operator;\n+import org.openhab.core.persistence.FilterCriteria.Ordering;\n+import org.openhab.core.persistence.HistoricItem;\n+import org.openhab.core.types.State;\n+\n+/**\n+ * See DimmerItemIntegrationTest for example how to use this base class.\n+ *\n+ * Implementor need to store two items. The first one needs to be smaller than the second. Protected static timestamps\n+ * in this class needs to be updated\n+ *\n+ *\n+ */\n+public abstract class AbstractTwoItemIntegrationTest extends BaseIntegrationTest {\n+\n+    protected static Date beforeStore;\n+    protected static Date afterStore1;\n+    protected static Date afterStore2;\n+\n+    protected abstract String getItemName();\n+\n+    /**\n+     * State of the time item stored first, should be smaller than the second value\n+     *\n+     * @return","path":"bundles/persistence/org.openhab.persistence.dynamodb.test/src/test/java/org/openhab/persistence/dynamodb/internal/AbstractTwoItemIntegrationTest.java","position":58,"original_position":44,"commit_id":"51987b659b006396790431dbb7bfe055544999f5","original_commit_id":"f5f35e8fb9c25eb4f79abd07ca7997b654946287","user":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars.githubusercontent.com/u/315866?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"body":"Fixed in b355205f23e3a588bedd6e3c46fb5128ebfe1ddc","created_at":"2016-10-08T11:51:21Z","updated_at":"2016-10-08T11:51:22Z","html_url":"https://github.com/openhab/openhab/pull/4542#discussion_r82501282","pull_request_url":"https://api.github.com/repos/openhab/openhab/pulls/4542","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments/82501282"},"html":{"href":"https://github.com/openhab/openhab/pull/4542#discussion_r82501282"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4542"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab/pulls/4542","id":77706729,"html_url":"https://github.com/openhab/openhab/pull/4542","diff_url":"https://github.com/openhab/openhab/pull/4542.diff","patch_url":"https://github.com/openhab/openhab/pull/4542.patch","issue_url":"https://api.github.com/repos/openhab/openhab/issues/4542","number":4542,"state":"open","locked":false,"title":"Persistence service implementation for AWS DynamoDB","user":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars.githubusercontent.com/u/315866?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"body":"Fixes #4541 \r\n\r\n- Tested with openhab1 and openhab2 (with compatibility layer)\r\n- Integration tests with all item types (requires AWS credentials, see test project README)\r\n- Documentation in Wiki: https://github.com/openhab/openhab/wiki/Amazon-DynamoDB-Persistence\r\n\r\nPrecompiled JAR: https://github.com/ssalonen/openhab/releases/tag/pooling-pr-20160517-rebase-utc-fix (matches 9e6adab)","created_at":"2016-07-16T10:51:12Z","updated_at":"2016-10-08T11:51:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2665517f8e33bf6e0b87567a440f88ad5e6f93ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab/pulls/4542/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab/pulls/4542/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab/issues/4542/comments","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/51987b659b006396790431dbb7bfe055544999f5","head":{"label":"ssalonen:persistence-dynamodb","ref":"persistence-dynamodb","sha":"51987b659b006396790431dbb7bfe055544999f5","user":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars.githubusercontent.com/u/315866?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"repo":{"id":47491242,"name":"openhab","full_name":"ssalonen/openhab","owner":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars.githubusercontent.com/u/315866?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssalonen/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/ssalonen/openhab","forks_url":"https://api.github.com/repos/ssalonen/openhab/forks","keys_url":"https://api.github.com/repos/ssalonen/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssalonen/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssalonen/openhab/teams","hooks_url":"https://api.github.com/repos/ssalonen/openhab/hooks","issue_events_url":"https://api.github.com/repos/ssalonen/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/ssalonen/openhab/events","assignees_url":"https://api.github.com/repos/ssalonen/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/ssalonen/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/ssalonen/openhab/tags","blobs_url":"https://api.github.com/repos/ssalonen/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssalonen/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssalonen/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssalonen/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssalonen/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/ssalonen/openhab/languages","stargazers_url":"https://api.github.com/repos/ssalonen/openhab/stargazers","contributors_url":"https://api.github.com/repos/ssalonen/openhab/contributors","subscribers_url":"https://api.github.com/repos/ssalonen/openhab/subscribers","subscription_url":"https://api.github.com/repos/ssalonen/openhab/subscription","commits_url":"https://api.github.com/repos/ssalonen/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssalonen/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssalonen/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssalonen/openhab/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssalonen/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/ssalonen/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssalonen/openhab/merges","archive_url":"https://api.github.com/repos/ssalonen/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssalonen/openhab/downloads","issues_url":"https://api.github.com/repos/ssalonen/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/ssalonen/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/ssalonen/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/ssalonen/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssalonen/openhab/labels{/name}","releases_url":"https://api.github.com/repos/ssalonen/openhab/releases{/id}","deployments_url":"https://api.github.com/repos/ssalonen/openhab/deployments","created_at":"2015-12-06T09:51:01Z","updated_at":"2016-01-16T09:00:56Z","pushed_at":"2016-10-08T11:47:49Z","git_url":"git://github.com/ssalonen/openhab.git","ssh_url":"git@github.com:ssalonen/openhab.git","clone_url":"https://github.com/ssalonen/openhab.git","svn_url":"https://github.com/ssalonen/openhab","homepage":null,"size":205387,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"08fb0ff708144cf8d9f09476d89d86dcd998f37a","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":12983151,"name":"openhab","full_name":"openhab/openhab","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":false,"url":"https://api.github.com/repos/openhab/openhab","forks_url":"https://api.github.com/repos/openhab/openhab/forks","keys_url":"https://api.github.com/repos/openhab/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab/teams","hooks_url":"https://api.github.com/repos/openhab/openhab/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab/events","assignees_url":"https://api.github.com/repos/openhab/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab/tags","blobs_url":"https://api.github.com/repos/openhab/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab/subscription","commits_url":"https://api.github.com/repos/openhab/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab/merges","archive_url":"https://api.github.com/repos/openhab/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab/downloads","issues_url":"https://api.github.com/repos/openhab/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab/deployments","created_at":"2013-09-20T20:28:43Z","updated_at":"2016-10-07T21:43:49Z","pushed_at":"2016-10-08T11:47:53Z","git_url":"git://github.com/openhab/openhab.git","ssh_url":"git@github.com:openhab/openhab.git","clone_url":"https://github.com/openhab/openhab.git","svn_url":"https://github.com/openhab/openhab","homepage":null,"size":302032,"stargazers_count":3072,"watchers_count":3072,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1460,"mirror_url":null,"open_issues_count":362,"forks":1460,"open_issues":362,"watchers":3072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4542"},"html":{"href":"https://github.com/openhab/openhab/pull/4542"},"issue":{"href":"https://api.github.com/repos/openhab/openhab/issues/4542"},"comments":{"href":"https://api.github.com/repos/openhab/openhab/issues/4542/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4542/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4542/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab/statuses/51987b659b006396790431dbb7bfe055544999f5"}}}}
{"actor":{"display_login":"ssalonen"}}