{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/67452367","id":67452367,"diff_hunk":"@@ -4,7 +4,6 @@\n #ifndef CEPH_LIBRBD_IMAGE_REFRESH_PARENT_REQUEST_H\n #define CEPH_LIBRBD_IMAGE_REFRESH_PARENT_REQUEST_H\n \n-#include \"include/int_types.h\"","path":"src/librbd/image/RefreshParentRequest.h","position":4,"original_position":4,"commit_id":"ed437578020ae6372474bcf40af87921e874edb2","original_commit_id":"ed437578020ae6372474bcf40af87921e874edb2","user":{"login":"cxwshawn","id":4486102,"avatar_url":"https://avatars.githubusercontent.com/u/4486102?v=3","gravatar_id":"","url":"https://api.github.com/users/cxwshawn","html_url":"https://github.com/cxwshawn","followers_url":"https://api.github.com/users/cxwshawn/followers","following_url":"https://api.github.com/users/cxwshawn/following{/other_user}","gists_url":"https://api.github.com/users/cxwshawn/gists{/gist_id}","starred_url":"https://api.github.com/users/cxwshawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxwshawn/subscriptions","organizations_url":"https://api.github.com/users/cxwshawn/orgs","repos_url":"https://api.github.com/users/cxwshawn/repos","events_url":"https://api.github.com/users/cxwshawn/events{/privacy}","received_events_url":"https://api.github.com/users/cxwshawn/received_events","type":"User","site_admin":false},"body":"@dillaman since as we know include/int_types.h is so basic header file, and on librbd level(image parent level), there is librbd/parent_types.h, and this has included int_types.h, so there is really no need to reinclude.","created_at":"2016-06-17T02:03:49Z","updated_at":"2016-06-17T02:03:49Z","html_url":"https://github.com/ceph/ceph/pull/9539#discussion_r67452367","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9539","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/67452367"},"html":{"href":"https://github.com/ceph/ceph/pull/9539#discussion_r67452367"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9539"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9539","id":72843652,"html_url":"https://github.com/ceph/ceph/pull/9539","diff_url":"https://github.com/ceph/ceph/pull/9539.diff","patch_url":"https://github.com/ceph/ceph/pull/9539.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9539","number":9539,"state":"open","locked":false,"title":"librbd: optimize header file dependency & modify related file.  ","user":{"login":"cxwshawn","id":4486102,"avatar_url":"https://avatars.githubusercontent.com/u/4486102?v=3","gravatar_id":"","url":"https://api.github.com/users/cxwshawn","html_url":"https://github.com/cxwshawn","followers_url":"https://api.github.com/users/cxwshawn/followers","following_url":"https://api.github.com/users/cxwshawn/following{/other_user}","gists_url":"https://api.github.com/users/cxwshawn/gists{/gist_id}","starred_url":"https://api.github.com/users/cxwshawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxwshawn/subscriptions","organizations_url":"https://api.github.com/users/cxwshawn/orgs","repos_url":"https://api.github.com/users/cxwshawn/repos","events_url":"https://api.github.com/users/cxwshawn/events{/privacy}","received_events_url":"https://api.github.com/users/cxwshawn/received_events","type":"User","site_admin":false},"body":"same work as https://github.com/ceph/ceph/pull/9336, https://github.com/ceph/ceph/pull/9307, https://github.com/ceph/ceph/pull/9287\r\n\r\n Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>","created_at":"2016-06-07T09:36:36Z","updated_at":"2016-06-17T02:03:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87b9bf97494c92bc89769fdc093461a000fb3efb","assignee":{"login":"dillaman","id":4739042,"avatar_url":"https://avatars.githubusercontent.com/u/4739042?v=3","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9539/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9539/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9539/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/ed437578020ae6372474bcf40af87921e874edb2","head":{"label":"cxwshawn:wip-tc9-fix","ref":"wip-tc9-fix","sha":"ed437578020ae6372474bcf40af87921e874edb2","user":{"login":"cxwshawn","id":4486102,"avatar_url":"https://avatars.githubusercontent.com/u/4486102?v=3","gravatar_id":"","url":"https://api.github.com/users/cxwshawn","html_url":"https://github.com/cxwshawn","followers_url":"https://api.github.com/users/cxwshawn/followers","following_url":"https://api.github.com/users/cxwshawn/following{/other_user}","gists_url":"https://api.github.com/users/cxwshawn/gists{/gist_id}","starred_url":"https://api.github.com/users/cxwshawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxwshawn/subscriptions","organizations_url":"https://api.github.com/users/cxwshawn/orgs","repos_url":"https://api.github.com/users/cxwshawn/repos","events_url":"https://api.github.com/users/cxwshawn/events{/privacy}","received_events_url":"https://api.github.com/users/cxwshawn/received_events","type":"User","site_admin":false},"repo":{"id":38021156,"name":"ceph","full_name":"cxwshawn/ceph","owner":{"login":"cxwshawn","id":4486102,"avatar_url":"https://avatars.githubusercontent.com/u/4486102?v=3","gravatar_id":"","url":"https://api.github.com/users/cxwshawn","html_url":"https://github.com/cxwshawn","followers_url":"https://api.github.com/users/cxwshawn/followers","following_url":"https://api.github.com/users/cxwshawn/following{/other_user}","gists_url":"https://api.github.com/users/cxwshawn/gists{/gist_id}","starred_url":"https://api.github.com/users/cxwshawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxwshawn/subscriptions","organizations_url":"https://api.github.com/users/cxwshawn/orgs","repos_url":"https://api.github.com/users/cxwshawn/repos","events_url":"https://api.github.com/users/cxwshawn/events{/privacy}","received_events_url":"https://api.github.com/users/cxwshawn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cxwshawn/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/cxwshawn/ceph","forks_url":"https://api.github.com/repos/cxwshawn/ceph/forks","keys_url":"https://api.github.com/repos/cxwshawn/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cxwshawn/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cxwshawn/ceph/teams","hooks_url":"https://api.github.com/repos/cxwshawn/ceph/hooks","issue_events_url":"https://api.github.com/repos/cxwshawn/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/cxwshawn/ceph/events","assignees_url":"https://api.github.com/repos/cxwshawn/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/cxwshawn/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/cxwshawn/ceph/tags","blobs_url":"https://api.github.com/repos/cxwshawn/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cxwshawn/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cxwshawn/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/cxwshawn/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cxwshawn/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/cxwshawn/ceph/languages","stargazers_url":"https://api.github.com/repos/cxwshawn/ceph/stargazers","contributors_url":"https://api.github.com/repos/cxwshawn/ceph/contributors","subscribers_url":"https://api.github.com/repos/cxwshawn/ceph/subscribers","subscription_url":"https://api.github.com/repos/cxwshawn/ceph/subscription","commits_url":"https://api.github.com/repos/cxwshawn/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/cxwshawn/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/cxwshawn/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/cxwshawn/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/cxwshawn/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/cxwshawn/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cxwshawn/ceph/merges","archive_url":"https://api.github.com/repos/cxwshawn/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cxwshawn/ceph/downloads","issues_url":"https://api.github.com/repos/cxwshawn/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/cxwshawn/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/cxwshawn/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/cxwshawn/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cxwshawn/ceph/labels{/name}","releases_url":"https://api.github.com/repos/cxwshawn/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/cxwshawn/ceph/deployments","created_at":"2015-06-25T01:38:43Z","updated_at":"2016-05-19T07:36:57Z","pushed_at":"2016-06-15T07:20:42Z","git_url":"git://github.com/cxwshawn/ceph.git","ssh_url":"git@github.com:cxwshawn/ceph.git","clone_url":"https://github.com/cxwshawn/ceph.git","svn_url":"https://github.com/cxwshawn/ceph","homepage":"http://ceph.com","size":161101,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"efc9bf1dc07a263ee4c8f2bb2a0e1fc2dd83b075","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-06-16T16:15:08Z","pushed_at":"2016-06-17T01:58:34Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":220120,"stargazers_count":2234,"watchers_count":2234,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1328,"mirror_url":null,"open_issues_count":390,"forks":1328,"open_issues":390,"watchers":2234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9539"},"html":{"href":"https://github.com/ceph/ceph/pull/9539"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9539"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9539/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9539/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9539/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/ed437578020ae6372474bcf40af87921e874edb2"}}}}
{"actor":{"display_login":"cxwshawn"}}