{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/streams/issues/430","repository_url":"https://api.github.com/repos/whatwg/streams","labels_url":"https://api.github.com/repos/whatwg/streams/issues/430/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/streams/issues/430/comments","events_url":"https://api.github.com/repos/whatwg/streams/issues/430/events","html_url":"https://github.com/whatwg/streams/pull/430","id":134557060,"number":430,"title":"Merge ReadableByteStream into ReadableStream","user":{"login":"tyoshino","id":4511440,"avatar_url":"https://avatars.githubusercontent.com/u/4511440?v=3","gravatar_id":"","url":"https://api.github.com/users/tyoshino","html_url":"https://github.com/tyoshino","followers_url":"https://api.github.com/users/tyoshino/followers","following_url":"https://api.github.com/users/tyoshino/following{/other_user}","gists_url":"https://api.github.com/users/tyoshino/gists{/gist_id}","starred_url":"https://api.github.com/users/tyoshino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyoshino/subscriptions","organizations_url":"https://api.github.com/users/tyoshino/orgs","repos_url":"https://api.github.com/users/tyoshino/repos","events_url":"https://api.github.com/users/tyoshino/events{/privacy}","received_events_url":"https://api.github.com/users/tyoshino/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/whatwg/streams/labels/byte%20streams","name":"byte streams","color":"5319e7"},{"url":"https://api.github.com/repos/whatwg/streams/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/whatwg/streams/labels/reference%20implementation","name":"reference implementation","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"tyoshino","id":4511440,"avatar_url":"https://avatars.githubusercontent.com/u/4511440?v=3","gravatar_id":"","url":"https://api.github.com/users/tyoshino","html_url":"https://github.com/tyoshino","followers_url":"https://api.github.com/users/tyoshino/followers","following_url":"https://api.github.com/users/tyoshino/following{/other_user}","gists_url":"https://api.github.com/users/tyoshino/gists{/gist_id}","starred_url":"https://api.github.com/users/tyoshino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyoshino/subscriptions","organizations_url":"https://api.github.com/users/tyoshino/orgs","repos_url":"https://api.github.com/users/tyoshino/repos","events_url":"https://api.github.com/users/tyoshino/events{/privacy}","received_events_url":"https://api.github.com/users/tyoshino/received_events","type":"User","site_admin":false},"milestone":null,"comments":18,"created_at":"2016-02-18T11:41:07Z","updated_at":"2016-03-09T23:42:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whatwg/streams/pulls/430","html_url":"https://github.com/whatwg/streams/pull/430","diff_url":"https://github.com/whatwg/streams/pull/430.diff","patch_url":"https://github.com/whatwg/streams/pull/430.patch"},"body":"This commit includes the following design changes:\r\n\r\n- sync the spec text with the new reference implementation\r\n- #423\r\n  - add byobRequest getter to the controller\r\n- port the asserts in the non-byte source version to the byte source version\r\n- remove auto release feature from the byte source version\r\n- rename Byob to BYOB\r\n- move TransferArrayBuffer to helpers.js\r\n- make the default highWaterMark of the byte source version to 0\r\n- port the functionality that the start method can delay pulling by returning a pending Promise to the byte source version\r\n- add `[[disturbed]]` feature to the byte source version\r\n- port highWaterMark mechanism to ReadableByteStreamController\r\n- merge ReadableStream and ReadableByteStream\r\n  - now it behaves differently based on whether the given source has pullInto or not\r\n  - bunch of renaming for merge\r\n- merge ReadableStreamReader and ReadableByteStreamReader\r\n- #424\r\n  - make controller.close() and controller.enqueue() fail when the stream is not in the readable state\r\n  - make controller.enqueue() throw a predefined TypeError, not the stored error\r\n  - as a result test/pipe-to-options.js, readable-streams/general.js and test/readable-stream-templated.js have been updated\r\n- rename ReadableStreamController to ReadableStreamDefaultController\r\n- rename ReadableStreamReader to ReadableStreamDefaultReader\r\n- rename ReadableByteStreamController to ReadableStreamBYOBController"},"comment":{"url":"https://api.github.com/repos/whatwg/streams/issues/comments/194569475","html_url":"https://github.com/whatwg/streams/pull/430#issuecomment-194569475","issue_url":"https://api.github.com/repos/whatwg/streams/issues/430","id":194569475,"user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T23:42:05Z","updated_at":"2016-03-09T23:42:05Z","body":"Sorry for the spam. I will fix the things I commented on except the examples. (That is: adding IsReadableStreamBYOBRequest, adding the missing brand check, moving the BYOB request abstract ops, and the syntax in the .js files.)"}}