{"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/59","id":82782436,"html_url":"https://github.com/ReactiveSocket/reactivesocket-js/pull/59","diff_url":"https://github.com/ReactiveSocket/reactivesocket-js/pull/59.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-js/pull/59.patch","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/59","number":59,"state":"closed","locked":false,"title":"Add metrics to reactivesocket","user":{"login":"stevegury","id":376195,"avatar_url":"https://avatars.githubusercontent.com/u/376195?v=3","gravatar_id":"","url":"https://api.github.com/users/stevegury","html_url":"https://github.com/stevegury","followers_url":"https://api.github.com/users/stevegury/followers","following_url":"https://api.github.com/users/stevegury/following{/other_user}","gists_url":"https://api.github.com/users/stevegury/gists{/gist_id}","starred_url":"https://api.github.com/users/stevegury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevegury/subscriptions","organizations_url":"https://api.github.com/users/stevegury/orgs","repos_url":"https://api.github.com/users/stevegury/repos","events_url":"https://api.github.com/users/stevegury/events{/privacy}","received_events_url":"https://api.github.com/users/stevegury/received_events","type":"User","site_admin":false},"body":"Use the 'metrix' library to add metrics at two different locations:\r\n\r\n- stream.js: to measure latency of request/response\r\n- connection.js: to measure success/errors\r\n\r\nI also refactor a little bit the wy timeout is handle in stream, so that only client side deal with timeout. I also fix a bug because `setInterval` was called instead of `setTimeout`.\r\n\r\nI would also appreciate a review of [metrix](https://github.com/stevegury/metrix), this can be done via a PR.","created_at":"2016-08-25T19:54:18Z","updated_at":"2016-09-12T22:22:06Z","closed_at":"2016-09-12T22:22:06Z","merged_at":"2016-09-12T22:22:06Z","merge_commit_sha":"8b25b65c3251de878ade892d89600b0e1e708519","assignee":{"login":"yunong","id":1226256,"avatar_url":"https://avatars.githubusercontent.com/u/1226256?v=3","gravatar_id":"","url":"https://api.github.com/users/yunong","html_url":"https://github.com/yunong","followers_url":"https://api.github.com/users/yunong/followers","following_url":"https://api.github.com/users/yunong/following{/other_user}","gists_url":"https://api.github.com/users/yunong/gists{/gist_id}","starred_url":"https://api.github.com/users/yunong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunong/subscriptions","organizations_url":"https://api.github.com/users/yunong/orgs","repos_url":"https://api.github.com/users/yunong/repos","events_url":"https://api.github.com/users/yunong/events{/privacy}","received_events_url":"https://api.github.com/users/yunong/received_events","type":"User","site_admin":false},"assignees":[{"login":"yunong","id":1226256,"avatar_url":"https://avatars.githubusercontent.com/u/1226256?v=3","gravatar_id":"","url":"https://api.github.com/users/yunong","html_url":"https://github.com/yunong","followers_url":"https://api.github.com/users/yunong/followers","following_url":"https://api.github.com/users/yunong/following{/other_user}","gists_url":"https://api.github.com/users/yunong/gists{/gist_id}","starred_url":"https://api.github.com/users/yunong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunong/subscriptions","organizations_url":"https://api.github.com/users/yunong/orgs","repos_url":"https://api.github.com/users/yunong/repos","events_url":"https://api.github.com/users/yunong/events{/privacy}","received_events_url":"https://api.github.com/users/yunong/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/59/commits","review_comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/59/comments","review_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/59/comments","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/statuses/c5abead8f5c15faf4b2f0737c4901d001c624393","head":{"label":"ReactiveSocket:stevegury/use-metrix","ref":"stevegury/use-metrix","sha":"c5abead8f5c15faf4b2f0737c4901d001c624393","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":40513205,"name":"reactivesocket-js","full_name":"ReactiveSocket/reactivesocket-js","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-js","description":"ReactiveSocket Protocol for Client/Server for Javascript ","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/deployments","created_at":"2015-08-11T00:44:48Z","updated_at":"2016-09-12T11:58:28Z","pushed_at":"2016-09-12T22:22:06Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-js.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-js.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-js.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-js","homepage":null,"size":474,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":44,"default_branch":"master"}},"base":{"label":"ReactiveSocket:master","ref":"master","sha":"d12f5caa8ee2f5058b9401688ed0cfd30e6b8d6f","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":40513205,"name":"reactivesocket-js","full_name":"ReactiveSocket/reactivesocket-js","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-js","description":"ReactiveSocket Protocol for Client/Server for Javascript ","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/deployments","created_at":"2015-08-11T00:44:48Z","updated_at":"2016-09-12T11:58:28Z","pushed_at":"2016-09-12T22:22:06Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-js.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-js.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-js.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-js","homepage":null,"size":474,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/59"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-js/pull/59"},"issue":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/59"},"comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-js/statuses/c5abead8f5c15faf4b2f0737c4901d001c624393"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stevegury","id":376195,"avatar_url":"https://avatars.githubusercontent.com/u/376195?v=3","gravatar_id":"","url":"https://api.github.com/users/stevegury","html_url":"https://github.com/stevegury","followers_url":"https://api.github.com/users/stevegury/followers","following_url":"https://api.github.com/users/stevegury/following{/other_user}","gists_url":"https://api.github.com/users/stevegury/gists{/gist_id}","starred_url":"https://api.github.com/users/stevegury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevegury/subscriptions","organizations_url":"https://api.github.com/users/stevegury/orgs","repos_url":"https://api.github.com/users/stevegury/repos","events_url":"https://api.github.com/users/stevegury/events{/privacy}","received_events_url":"https://api.github.com/users/stevegury/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"commits":6,"additions":132,"deletions":84,"changed_files":5}}
{"actor":{"display_login":"stevegury"}}