{"action":"created","issue":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/823","repository_url":"https://api.github.com/repos/quattor/configuration-modules-core","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/823/labels{/name}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/823/comments","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/823/events","html_url":"https://github.com/quattor/configuration-modules-core/pull/823","id":168373360,"number":823,"title":"ncm_afsclt: use FileEditor not FileReader (for old CAF).","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/13","html_url":"https://github.com/quattor/configuration-modules-core/milestones/16.8","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/13/labels","id":1383518,"number":13,"title":"16.8","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":4,"state":"open","created_at":"2015-10-29T14:13:09Z","updated_at":"2016-07-30T11:04:44Z","due_on":"2016-08-30T07:00:00Z","closed_at":null},"comments":2,"created_at":"2016-07-29T17:24:09Z","updated_at":"2016-07-30T16:41:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/823","html_url":"https://github.com/quattor/configuration-modules-core/pull/823","diff_url":"https://github.com/quattor/configuration-modules-core/pull/823.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/823.patch"},"body":"Found a small issue with @jouvin's refactoring - a missing use FileReader (it didn't use FileReader before). I think this only happens if you run ncm-afsclt alone (as we do at one point in our build) presumably because another components hasn't loaded it already.\r\n\r\nI've changed the new use of FileReader to a FileEditor with explicit cancel so it's essentially the same, and consistent with another read in the component. Sorry, we have an old version of CAF on older builds, they will hopefully go away soon.\r\n\r\nEnsure the title of this pull-request starts with the component name followed by a colon, e.g.\r\n> ncm-example: demonstrate what titles should look like\r\n\r\nDescribe the change you are making here, in particular we would like to know:\r\n\r\n* Why the change is necessary.\r\n* What backwards incompatibility it may introduce.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments/236375381","html_url":"https://github.com/quattor/configuration-modules-core/pull/823#issuecomment-236375381","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/823","id":236375381,"user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"created_at":"2016-07-30T16:41:37Z","updated_at":"2016-07-30T16:41:37Z","body":"@stdweird - we have CAF 14.10.0 on some of our older builds which are hopefully going soon.\r\n\r\nTo be clear, the main reason for a PR was the missing use statement causing it to break when run alone. I would have simply added the use statement, but since we're one of the few users of this module and to make it consistent with the other file read, I changed it to FileEditor. \r\n\r\nI'm not going to be submitting PR's to change various FileReaders to FileEditors :) I think we have patched a small number of components locally for this (don't know which off the top of my head), and we can stop doing this soon."}}
{"actor":{"display_login":"ajf8"}}