{"push_id":1332472659,"size":1,"distinct_size":1,"ref":"refs/heads/fix-details-rendering-error-bug1304441","head":"b0689b72ee13e83187343331f9ebae7510957baa","before":"143c2a46a0bf80b37da77fc909f55d2545b41905","commits":[{"sha":"b0689b72ee13e83187343331f9ebae7510957baa","author":{"name":"Ting-Yu Lin","email":"fb8eadf56169561f1ece9943bda33d2b24ff38ad@mozilla.com"},"message":"Bug 1304441 Part 3 - Insert main summary's frame construction item at front of the list.\n\nChange the logic that moves the main summary to the front from operating\non generated frames in DetailsFrame::SetInitialChildList() to operating\non frame construction item list in AddFrameConstructionItemsInternal()\nso that it will be correct when cooperating with ::first-line.\n\nThe root cause of the bug reported is because when specifying\n::first-line on details element, the first frame of summary element,\nwhich is generated due to ib-split, will be wrapped in nsFirstLineFrame.\nThe original code fails to find the summary frame in the wrapper frame\nand triggers assertion because of the second ib-split summary frame. To\nfix that, we need to descend into the child list of wrapper frames when\nchecking the main summary.\n\nAdd original test case as a crashtest as well as reftests to clearly\nreproduce the issue.\n\nNote that in the reftest, the blue color in ::first-line is applied\nincorrectly to the second line in the summary due to bug 520605.\n\nMozReview-Commit-ID: Bv4Vcvxp6pY","distinct":true,"url":"https://api.github.com/repos/aethanyc/gecko-dev/commits/b0689b72ee13e83187343331f9ebae7510957baa"}]}
{"actor":{"display_login":"aethanyc"}}