{"action":"created","issue":{"url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2989","repository_url":"https://api.github.com/repos/pentaho/pentaho-platform","labels_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2989/labels{/name}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2989/comments","events_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2989/events","html_url":"https://github.com/pentaho/pentaho-platform/pull/2989","id":167270876,"number":2989,"title":"[BISERVER-13049, BISERVER-13267] Adding back PentahoXmlaServlet which…","user":{"login":"pentaho-nbaker","id":1828484,"avatar_url":"https://avatars.githubusercontent.com/u/1828484?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho-nbaker","html_url":"https://github.com/pentaho-nbaker","followers_url":"https://api.github.com/users/pentaho-nbaker/followers","following_url":"https://api.github.com/users/pentaho-nbaker/following{/other_user}","gists_url":"https://api.github.com/users/pentaho-nbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho-nbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho-nbaker/subscriptions","organizations_url":"https://api.github.com/users/pentaho-nbaker/orgs","repos_url":"https://api.github.com/users/pentaho-nbaker/repos","events_url":"https://api.github.com/users/pentaho-nbaker/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho-nbaker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-25T02:32:19Z","updated_at":"2016-07-25T03:09:04Z","closed_at":"2016-07-25T02:37:38Z","pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-platform/pulls/2989","html_url":"https://github.com/pentaho/pentaho-platform/pull/2989","diff_url":"https://github.com/pentaho/pentaho-platform/pull/2989.diff","patch_url":"https://github.com/pentaho/pentaho-platform/pull/2989.patch"},"body":"… was erroneously excluded from initial commit"},"comment":{"url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/comments/234826947","html_url":"https://github.com/pentaho/pentaho-platform/pull/2989#issuecomment-234826947","issue_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2989","id":234826947,"user":{"login":"wingman-pentaho","id":18704365,"avatar_url":"https://avatars.githubusercontent.com/u/18704365?v=3","gravatar_id":"","url":"https://api.github.com/users/wingman-pentaho","html_url":"https://github.com/wingman-pentaho","followers_url":"https://api.github.com/users/wingman-pentaho/followers","following_url":"https://api.github.com/users/wingman-pentaho/following{/other_user}","gists_url":"https://api.github.com/users/wingman-pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/wingman-pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingman-pentaho/subscriptions","organizations_url":"https://api.github.com/users/wingman-pentaho/orgs","repos_url":"https://api.github.com/users/wingman-pentaho/repos","events_url":"https://api.github.com/users/wingman-pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/wingman-pentaho/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T03:09:04Z","updated_at":"2016-07-25T03:09:04Z","body":"### Build Completed\n\n:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.\n\n#### Build Commands\n\n```sh\nant -Dpentaho.resolve.repo=http://ivy-nexus.pentaho.org/content/groups/approved -Dtestreports.dir=bin/reports/unit-test -f extensions/build.xml clean-all resolve jacoco && ant -Dpentaho.resolve.repo=http://ivy-nexus.pentaho.org/content/groups/approved -Dtestreports.dir=bin/reports/integration-test -f extensions/build.xml jacoco-integration checkstyle publish-local\n```\n\n#### Cleanup Commands\n```sh\nrm -r ~/.ivy2/local || echo no publish local to remove\n```\n\n#### Changed files\n\n```console\n  extensions/src/org/pentaho/platform/web/servlet/PentahoXmlaServlet.java\n```\n\nNewly Fixed Tests:\n======================\n###### org.pentaho.platform.web.servlet.PentahoXmlaServletTest.createConnectionFactory:\n\n:red_circle: `junit.framework.AssertionFailedError`\n\n```java\njunit.framework.AssertionFailedError: \npentahoXmlaServlet.makeCatalogLocator(<any>);\nWanted 1 time:\n-> at org.pentaho.platform.web.servlet.PentahoXmlaServletTest.createConnectionFactory(PentahoXmlaServletTest.java:198)\nBut was 5 times. Undesired invocation:\n-> at org.pentaho.platform.web.servlet.PentahoXmlaServlet$4.getConnection(PentahoXmlaServlet.java:350)\n\n\tat org.pentaho.platform.web.servlet.PentahoXmlaServletTest.createConnectionFactory(PentahoXmlaServletTest.java:198)\n\tat org.powermock.mod\n```\n\n#### Unit test coverage change\n\nThese statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to [Jacoco's documentation](http://eclemma.org/jacoco/trunk/doc/counters.html).\n\n###### org.pentaho.platform.config.MondrianConfigProperties\n * Branch Change: **-7.14%**:small_red_triangle_down:\n * Instruction Change: **-3.16%**:small_red_triangle_down:\n\n###### org.pentaho.platform.plugin.services.metadata.PentahoMetadataDomainRepository\n * Branch Change:  + 1.25%\n * Complexity Change:  + .80%\n * Instruction Change:  + .93%\n * Line Change:  + .82%\n\n#### License header violations\n\n> :heavy_exclamation_mark: Copyright year is not the current year on extensions/src/org/pentaho/platform/web/servlet/PentahoXmlaServlet.java. Found 2014. Was expecting 2016\n\n#### Checkstyle violations\n\nThe code submitted is not complying with one or more of our guidelines. To perform these checks locally, [please use this tool](https://github.com/pentaho/pentaho-coding-standards).\n\n###### /home/buildguy/project/extensions/src/org/pentaho/platform/web/servlet/PentahoXmlaServlet.java\n\n> :heavy_exclamation_mark: Using the '.*' form of import should be avoided - org.apache.commons.collections.CollectionUtils.*. at Line: 72"}}
{"actor":{"display_login":"wingman-pentaho"}}