{"action":"created","comment":{"url":"https://api.github.com/repos/dashpay/dash/pulls/comments/85210082","pull_request_review_id":5938738,"id":85210082,"diff_hunk":"@@ -190,48 +187,56 @@ void CActiveMasternode::ManageStateInitial()\n         eType = MASTERNODE_LOCAL;\n     }\n \n-    LogPrint(\"masternode\", \"CActiveMasternode::ManageStateInitial -- End status = %s, type = %s, pinger enabled = %d\\n\", GetStatus(), GetType(), fPingerEnabled);\n+    LogPrint(\"masternode\", \"CActiveMasternode::ManageStateInitial -- End status = %s, type = %s, pinger enabled = %d\\n\", GetStatus(), GetTypeString(), fPingerEnabled);\n }\n \n void CActiveMasternode::ManageStateRemote()\n {\n     LogPrint(\"masternode\", \"CActiveMasternode::ManageStateRemote -- Start status = %s, type = %s, pinger enabled = %d, pubKeyMasternode.GetID() = %s\\n\", \n-             GetStatus(),\n-             GetType(),\n-             fPingerEnabled,\n-             pubKeyMasternode.GetID().ToString());\n+             GetStatus(), fPingerEnabled, GetTypeString(), pubKeyMasternode.GetID().ToString());\n \n     mnodeman.CheckMasternode(pubKeyMasternode);\n-    masternode_info_t infoMn = mnodeman.GetMasternodeInfo(pubKeyMasternode);\n-    if(infoMn.fInfoValid) {\n-        if(infoMn.nProtocolVersion != PROTOCOL_VERSION) {\n+    CMasternode mn;","path":"src/activemasternode.cpp","position":193,"original_position":187,"commit_id":"94d078d6bb0e1361f5bcb9ad8a4c8ad1050882b7","original_commit_id":"94d078d6bb0e1361f5bcb9ad8a4c8ad1050882b7","user":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"body":"I needed `mn.GetStateString()` for a more precise error message, shouldn't add a lot of overhead here imo, `ManageStateRemote` is called initially and then only every `MASTERNODE_MIN_MNP_SECONDS`.","created_at":"2016-10-26T20:14:10Z","updated_at":"2016-10-26T20:14:10Z","html_url":"https://github.com/dashpay/dash/pull/1102#discussion_r85210082","pull_request_url":"https://api.github.com/repos/dashpay/dash/pulls/1102","_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments/85210082"},"html":{"href":"https://github.com/dashpay/dash/pull/1102#discussion_r85210082"},"pull_request":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1102"}}},"pull_request":{"url":"https://api.github.com/repos/dashpay/dash/pulls/1102","id":91077484,"html_url":"https://github.com/dashpay/dash/pull/1102","diff_url":"https://github.com/dashpay/dash/pull/1102.diff","patch_url":"https://github.com/dashpay/dash/pull/1102.patch","issue_url":"https://api.github.com/repos/dashpay/dash/issues/1102","number":1102,"state":"open","locked":false,"title":"Fix CActiveMasternode","user":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"body":"- should run `ManageStateLocal` only when `eType == MASTERNODE_LOCAL`\r\n- should set `nState = ACTIVE_MASTERNODE_NOT_CAPABLE` in `ManageStateInitial` to let `GetStatus` return proper message\r\n- more/better log output\r\n- _side work - added `GetStateString` helpers_\r\n\r\nEDIT:\r\n- slightly refactored `SendMasternodePing`","created_at":"2016-10-26T20:03:11Z","updated_at":"2016-10-26T20:14:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68b52c51df445c50073c057e7c10c56fc13b6bc3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dashpay/dash/pulls/1102/commits","review_comments_url":"https://api.github.com/repos/dashpay/dash/pulls/1102/comments","review_comment_url":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dashpay/dash/issues/1102/comments","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/94d078d6bb0e1361f5bcb9ad8a4c8ad1050882b7","head":{"label":"UdjinM6:fixCActiveMasternode","ref":"fixCActiveMasternode","sha":"94d078d6bb0e1361f5bcb9ad8a4c8ad1050882b7","user":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"repo":{"id":26767942,"name":"dash","full_name":"UdjinM6/dash","owner":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UdjinM6/dash","description":"Dash - Reinventing Cryptocurrency","fork":true,"url":"https://api.github.com/repos/UdjinM6/dash","forks_url":"https://api.github.com/repos/UdjinM6/dash/forks","keys_url":"https://api.github.com/repos/UdjinM6/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UdjinM6/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UdjinM6/dash/teams","hooks_url":"https://api.github.com/repos/UdjinM6/dash/hooks","issue_events_url":"https://api.github.com/repos/UdjinM6/dash/issues/events{/number}","events_url":"https://api.github.com/repos/UdjinM6/dash/events","assignees_url":"https://api.github.com/repos/UdjinM6/dash/assignees{/user}","branches_url":"https://api.github.com/repos/UdjinM6/dash/branches{/branch}","tags_url":"https://api.github.com/repos/UdjinM6/dash/tags","blobs_url":"https://api.github.com/repos/UdjinM6/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UdjinM6/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UdjinM6/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/UdjinM6/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UdjinM6/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/UdjinM6/dash/languages","stargazers_url":"https://api.github.com/repos/UdjinM6/dash/stargazers","contributors_url":"https://api.github.com/repos/UdjinM6/dash/contributors","subscribers_url":"https://api.github.com/repos/UdjinM6/dash/subscribers","subscription_url":"https://api.github.com/repos/UdjinM6/dash/subscription","commits_url":"https://api.github.com/repos/UdjinM6/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/UdjinM6/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/UdjinM6/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/UdjinM6/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/UdjinM6/dash/contents/{+path}","compare_url":"https://api.github.com/repos/UdjinM6/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UdjinM6/dash/merges","archive_url":"https://api.github.com/repos/UdjinM6/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UdjinM6/dash/downloads","issues_url":"https://api.github.com/repos/UdjinM6/dash/issues{/number}","pulls_url":"https://api.github.com/repos/UdjinM6/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/UdjinM6/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/UdjinM6/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UdjinM6/dash/labels{/name}","releases_url":"https://api.github.com/repos/UdjinM6/dash/releases{/id}","deployments_url":"https://api.github.com/repos/UdjinM6/dash/deployments","created_at":"2014-11-17T17:21:16Z","updated_at":"2016-06-02T12:33:04Z","pushed_at":"2016-10-26T19:53:02Z","git_url":"git://github.com/UdjinM6/dash.git","ssh_url":"git@github.com:UdjinM6/dash.git","clone_url":"https://github.com/UdjinM6/dash.git","svn_url":"https://github.com/UdjinM6/dash","homepage":"https://www.dash.org","size":142500,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"dashpay:v0.12.1.x","ref":"v0.12.1.x","sha":"77852d938e7eadd899eff041dae20ea018c30d2f","user":{"login":"dashpay","id":11511719,"avatar_url":"https://avatars.githubusercontent.com/u/11511719?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"repo":{"id":19352450,"name":"dash","full_name":"dashpay/dash","owner":{"login":"dashpay","id":11511719,"avatar_url":"https://avatars.githubusercontent.com/u/11511719?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpay","html_url":"https://github.com/dashpay","followers_url":"https://api.github.com/users/dashpay/followers","following_url":"https://api.github.com/users/dashpay/following{/other_user}","gists_url":"https://api.github.com/users/dashpay/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpay/subscriptions","organizations_url":"https://api.github.com/users/dashpay/orgs","repos_url":"https://api.github.com/users/dashpay/repos","events_url":"https://api.github.com/users/dashpay/events{/privacy}","received_events_url":"https://api.github.com/users/dashpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dashpay/dash","description":"Dash - Reinventing Cryptocurrency","fork":true,"url":"https://api.github.com/repos/dashpay/dash","forks_url":"https://api.github.com/repos/dashpay/dash/forks","keys_url":"https://api.github.com/repos/dashpay/dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashpay/dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashpay/dash/teams","hooks_url":"https://api.github.com/repos/dashpay/dash/hooks","issue_events_url":"https://api.github.com/repos/dashpay/dash/issues/events{/number}","events_url":"https://api.github.com/repos/dashpay/dash/events","assignees_url":"https://api.github.com/repos/dashpay/dash/assignees{/user}","branches_url":"https://api.github.com/repos/dashpay/dash/branches{/branch}","tags_url":"https://api.github.com/repos/dashpay/dash/tags","blobs_url":"https://api.github.com/repos/dashpay/dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashpay/dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashpay/dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashpay/dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashpay/dash/statuses/{sha}","languages_url":"https://api.github.com/repos/dashpay/dash/languages","stargazers_url":"https://api.github.com/repos/dashpay/dash/stargazers","contributors_url":"https://api.github.com/repos/dashpay/dash/contributors","subscribers_url":"https://api.github.com/repos/dashpay/dash/subscribers","subscription_url":"https://api.github.com/repos/dashpay/dash/subscription","commits_url":"https://api.github.com/repos/dashpay/dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashpay/dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashpay/dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashpay/dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashpay/dash/contents/{+path}","compare_url":"https://api.github.com/repos/dashpay/dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashpay/dash/merges","archive_url":"https://api.github.com/repos/dashpay/dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashpay/dash/downloads","issues_url":"https://api.github.com/repos/dashpay/dash/issues{/number}","pulls_url":"https://api.github.com/repos/dashpay/dash/pulls{/number}","milestones_url":"https://api.github.com/repos/dashpay/dash/milestones{/number}","notifications_url":"https://api.github.com/repos/dashpay/dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashpay/dash/labels{/name}","releases_url":"https://api.github.com/repos/dashpay/dash/releases{/id}","deployments_url":"https://api.github.com/repos/dashpay/dash/deployments","created_at":"2014-05-01T17:45:34Z","updated_at":"2016-10-19T02:54:59Z","pushed_at":"2016-10-26T20:03:11Z","git_url":"git://github.com/dashpay/dash.git","ssh_url":"git@github.com:dashpay/dash.git","clone_url":"https://github.com/dashpay/dash.git","svn_url":"https://github.com/dashpay/dash","homepage":"https://www.dash.org","size":119298,"stargazers_count":328,"watchers_count":328,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":40,"forks":179,"open_issues":40,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1102"},"html":{"href":"https://github.com/dashpay/dash/pull/1102"},"issue":{"href":"https://api.github.com/repos/dashpay/dash/issues/1102"},"comments":{"href":"https://api.github.com/repos/dashpay/dash/issues/1102/comments"},"review_comments":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1102/comments"},"review_comment":{"href":"https://api.github.com/repos/dashpay/dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dashpay/dash/pulls/1102/commits"},"statuses":{"href":"https://api.github.com/repos/dashpay/dash/statuses/94d078d6bb0e1361f5bcb9ad8a4c8ad1050882b7"}}}}
{"actor":{"display_login":"UdjinM6"}}