{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/26579","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/26579/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/26579/comments","events_url":"https://api.github.com/repos/docker/docker/issues/26579/events","html_url":"https://github.com/docker/docker/pull/26579","id":176990642,"number":26579,"title":"Windows: OCI `process` struct and console size to uint","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/group/windows","name":"group/windows","color":"ededed"},{"url":"https://api.github.com/repos/docker/docker/labels/status/4-merge","name":"status/4-merge","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":201,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-09-20T17:19:14Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-09-14T18:56:42Z","updated_at":"2016-09-20T17:21:27Z","closed_at":"2016-09-19T20:52:16Z","pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/26579","html_url":"https://github.com/docker/docker/pull/26579","diff_url":"https://github.com/docker/docker/pull/26579.diff","patch_url":"https://github.com/docker/docker/pull/26579.patch"},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\nConvergence closer to OCI compliance - this modifies the Process struct definition in the hacked OCI spec used on Windows to match the existing structure from https://github.com/opencontainers/runtime-spec/blob/master/specs-go/config.go#L30-L54, but also adding the initialConsoleSize field which is required on Windows submitted to OCI as https://github.com/opencontainers/runtime-spec/pull/563.\r\n\r\nAs a result of https://github.com/opencontainers/runtime-spec/pull/563#r78852905, have changed the docker codebase to use uint instead of int for the console size throughout.\r\n\r\nThere is one further update which will be required (and simplify the code by no longer needing to cast from uint to int in the Windows libcontainerd files) after https://github.com/Microsoft/hcsshim/pull/67 is merged, and a revendor of https://github.com/Microsoft/hcsshim is done in docker.\r\n\r\nThere are no functional changes in the PR."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/248370033","html_url":"https://github.com/docker/docker/pull/26579#issuecomment-248370033","issue_url":"https://api.github.com/repos/docker/docker/issues/26579","id":248370033,"user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T17:21:27Z","updated_at":"2016-09-20T17:21:27Z","body":"> Oh, damned. Just realized this is part of the common HostConfig struct\r\n\r\n:) wanna take a peek at this? I'm going ahead and fix it if I can"}}
{"actor":{"display_login":"runcom"}}