{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/49633819","id":49633819,"diff_hunk":"@@ -301,68 +301,44 @@ public ArrayCreation(IArrayTypeSymbol arrayType, ImmutableArray<IExpression> ele\n \n         public ITypeSymbol ElementType => _arrayType.ElementType;\n \n-        public IArrayInitializer ElementValues { get; }\n+        public IArrayInitializer Initializer { get; }\n \n         public SyntaxNode Syntax { get; }\n \n         public OperationKind Kind => OperationKind.ArrayCreationExpression;\n \n-        public bool IsInvalid => IsInvalidInitializer(ElementValues);\n+        public bool IsInvalid => IsInvalidInitializer(Initializer);\n        \n-        static bool IsInvalidInitializer(IArrayInitializer initializer)\n-        {\n-            switch (initializer.ArrayClass)\n-            {\n-                case ArrayInitializerKind.Dimension:\n-                    foreach (IArrayInitializer element in ((IDimensionArrayInitializer)initializer).ElementValues)\n-                    {\n-                        if (IsInvalidInitializer(element))\n-                        {\n-                            return true;\n-                        }\n-                    }\n-\n-                    break;\n-\n-                case ArrayInitializerKind.Expression:\n-                    return ((IExpressionArrayInitializer)initializer).ElementValue.IsInvalid;\n-            }\n-\n-            return false;\n-        }\n+        static bool IsInvalidInitializer(IArrayInitializer initializer) => initializer.IsInvalid;\n \n         public Optional<object> ConstantValue => default(Optional<object>);\n \n-        private class DimensionInitializer : IDimensionArrayInitializer\n+        private class ArrayInitializer : IArrayInitializer\n         {\n-            private readonly ImmutableArray<IArrayInitializer> _elementValues;\n-\n-            public DimensionInitializer(ImmutableArray<IExpression> elementValues)\n+            public ArrayInitializer(ImmutableArray<IExpression> elementValues, SyntaxNode syntax, ITypeSymbol arrayType)\n             {\n-                ArrayBuilder<IArrayInitializer> builder = ArrayBuilder<IArrayInitializer>.GetInstance();\n+                ArrayBuilder<IExpression> builder = ArrayBuilder<IExpression>.GetInstance();","path":"src/Compilers/Core/Portable/Compilation/Expression.cs","position":74,"original_position":74,"commit_id":"e89d04ca9926ebd479518b43ac0923f7b4820bfd","original_commit_id":"e89d04ca9926ebd479518b43ac0923f7b4820bfd","user":{"login":"genlu","id":788783,"avatar_url":"https://avatars.githubusercontent.com/u/788783?v=3","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"body":"Yes, will fix.","created_at":"2016-01-13T19:00:51Z","updated_at":"2016-01-13T19:00:51Z","html_url":"https://github.com/dotnet/roslyn/pull/7352#discussion_r49633819","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7352","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/49633819"},"html":{"href":"https://github.com/dotnet/roslyn/pull/7352#discussion_r49633819"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7352"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/7352","id":53065713,"html_url":"https://github.com/dotnet/roslyn/pull/7352","diff_url":"https://github.com/dotnet/roslyn/pull/7352.diff","patch_url":"https://github.com/dotnet/roslyn/pull/7352.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/7352","number":7352,"state":"open","locked":false,"title":"Make all internal nodes of IOperation tree subtypes of IOperation","user":{"login":"genlu","id":788783,"avatar_url":"https://avatars.githubusercontent.com/u/788783?v=3","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"body":"- Make `IArgument` an `IOperation`, add `OperationKind.Argument`\r\n\r\n- Make `IMemberInitializer` an `IOperation`, add `OperationKind.FieldInitializer`, `OperationKind.PropertyInitialzer`. This change has nothing to do with inline field and property initialization. (Note: member initializers won't be double counted as assignment expressions, even though they are both backed by assignment bound node.)\r\n\r\n- Remove `IExpressionArrayInitializer` and `IDimensionArrayInitializer`, unify their logic under `IArrayInitializer`, which was the base type of both, and make it an `IExpression`. Add `OperationKind.ArrayInitlizer`\r\n\r\n- Make `IVariable` an `IOperation`, add `OperationKind.VariableDeclaration`.\r\n\r\n- Make `ICase` an `IStatement` and `ICaseClause` an `IOperation`. \r\n\r\nThis is still a work in progress and isn't ready to be merged (until at least all the public API changes get reviewed), I'd appreciate any feedback, especially things that related to VB bound tree. More change will be pushed to this branch.\r\n\r\n@JohnHamby @AlekseyTs Could you please take a look at this? The commits are mostly grouped by specific topic and have minimal/no overlap with each other, so it would probably easier to review them separately.\r\n\r\nUpdate: \r\nAll the nodes are converted, so adding more people for code review\r\n@dotnet/roslyn-interactive @nguerrera @mavasani  @gafter @cston @CyrusNajmabadi","created_at":"2015-12-09T01:37:38Z","updated_at":"2016-01-13T19:00:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b739e95075bef7629ee67203bf2571f3499cbd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7352/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/7352/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/7352/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/e89d04ca9926ebd479518b43ac0923f7b4820bfd","head":{"label":"genlu:IOperationTree","ref":"IOperationTree","sha":"e89d04ca9926ebd479518b43ac0923f7b4820bfd","user":{"login":"genlu","id":788783,"avatar_url":"https://avatars.githubusercontent.com/u/788783?v=3","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"repo":{"id":38650594,"name":"roslyn","full_name":"genlu/roslyn","owner":{"login":"genlu","id":788783,"avatar_url":"https://avatars.githubusercontent.com/u/788783?v=3","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/genlu/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/genlu/roslyn","forks_url":"https://api.github.com/repos/genlu/roslyn/forks","keys_url":"https://api.github.com/repos/genlu/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genlu/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genlu/roslyn/teams","hooks_url":"https://api.github.com/repos/genlu/roslyn/hooks","issue_events_url":"https://api.github.com/repos/genlu/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/genlu/roslyn/events","assignees_url":"https://api.github.com/repos/genlu/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/genlu/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/genlu/roslyn/tags","blobs_url":"https://api.github.com/repos/genlu/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genlu/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genlu/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/genlu/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genlu/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/genlu/roslyn/languages","stargazers_url":"https://api.github.com/repos/genlu/roslyn/stargazers","contributors_url":"https://api.github.com/repos/genlu/roslyn/contributors","subscribers_url":"https://api.github.com/repos/genlu/roslyn/subscribers","subscription_url":"https://api.github.com/repos/genlu/roslyn/subscription","commits_url":"https://api.github.com/repos/genlu/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/genlu/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/genlu/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/genlu/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/genlu/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/genlu/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genlu/roslyn/merges","archive_url":"https://api.github.com/repos/genlu/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genlu/roslyn/downloads","issues_url":"https://api.github.com/repos/genlu/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/genlu/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/genlu/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/genlu/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genlu/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/genlu/roslyn/releases{/id}","created_at":"2015-07-06T22:48:49Z","updated_at":"2015-07-06T22:49:19Z","pushed_at":"2016-01-07T20:20:29Z","git_url":"git://github.com/genlu/roslyn.git","ssh_url":"git@github.com:genlu/roslyn.git","clone_url":"https://github.com/genlu/roslyn.git","svn_url":"https://github.com/genlu/roslyn","homepage":"","size":123714,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"beda2c2956b92f842a234a4a5c34620862279f22","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-01-13T15:00:15Z","pushed_at":"2016-01-13T18:44:14Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":149205,"stargazers_count":4213,"watchers_count":4213,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1032,"mirror_url":null,"open_issues_count":1893,"forks":1032,"open_issues":1893,"watchers":4213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7352"},"html":{"href":"https://github.com/dotnet/roslyn/pull/7352"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/7352"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/7352/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7352/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/7352/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/e89d04ca9926ebd479518b43ac0923f7b4820bfd"}}}}