{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/6648","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/6648/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6648/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/6648/events","html_url":"https://github.com/dotnet/coreclr/pull/6648","id":169886634,"number":6648,"title":"Add TryCopyTo and Set methods to Spans API #5857","user":{"login":"adamsitnik","id":6011991,"avatar_url":"https://avatars.githubusercontent.com/u/6011991?v=3","gravatar_id":"","url":"https://api.github.com/users/adamsitnik","html_url":"https://github.com/adamsitnik","followers_url":"https://api.github.com/users/adamsitnik/followers","following_url":"https://api.github.com/users/adamsitnik/following{/other_user}","gists_url":"https://api.github.com/users/adamsitnik/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsitnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsitnik/subscriptions","organizations_url":"https://api.github.com/users/adamsitnik/orgs","repos_url":"https://api.github.com/users/adamsitnik/repos","events_url":"https://api.github.com/users/adamsitnik/events{/privacy}","received_events_url":"https://api.github.com/users/adamsitnik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-08-08T10:05:01Z","updated_at":"2016-09-12T09:10:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6648","html_url":"https://github.com/dotnet/coreclr/pull/6648","diff_url":"https://github.com/dotnet/coreclr/pull/6648.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6648.patch"},"body":"Hello!\r\n\r\n@jkotas @KrzysztofCwalina  Could you review the code and tell if everything is ok before I implement Set method and copy the code for ReadOnlySpan?\r\n\r\nJan I have seen that you added some basic tests for Span, but it seems that they are not executed during build with tests included. Could you add it to the SpanOfT branch or tell me how can I quickly execute this tests?"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/246290816","html_url":"https://github.com/dotnet/coreclr/pull/6648#issuecomment-246290816","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6648","id":246290816,"user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T09:10:42Z","updated_at":"2016-09-12T09:10:42Z","body":"I'm going to answer those questions even though it probably doesn't matter:\r\n\r\n> Should I rename CreateArray to ToArray?\r\n\r\nYes. Matches with the rest of the CLR nomenclature. `ToArray()` allocates which is the reason it's called `CreateArray()` (to make sure you know what you're doing).\r\n\r\n> Should I remove unsafe bool TryCopyTo(void* destination, int elementsCount) or change elementsCount to sizeInBytes?\r\n\r\nRemove it. Span all the things!\r\n\r\n> Should I add implicit cast operator of Span to Array?\r\n\r\nYes. It matches this https://github.com/dotnet/corefxlab/commit/97afeb6b51928d37a98e58b415bf30907028abdd."}}
{"actor":{"display_login":"davidfowl"}}