{"action":"created","issue":{"url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/234","repository_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin","labels_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/234/comments","events_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/234/events","html_url":"https://github.com/ktoso/maven-git-commit-id-plugin/issues/234","id":124670636,"number":234,"title":"Inconsistency in dirty state","user":{"login":"autayeu","id":495207,"avatar_url":"https://avatars.githubusercontent.com/u/495207?v=3","gravatar_id":"","url":"https://api.github.com/users/autayeu","html_url":"https://github.com/autayeu","followers_url":"https://api.github.com/users/autayeu/followers","following_url":"https://api.github.com/users/autayeu/following{/other_user}","gists_url":"https://api.github.com/users/autayeu/gists{/gist_id}","starred_url":"https://api.github.com/users/autayeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autayeu/subscriptions","organizations_url":"https://api.github.com/users/autayeu/orgs","repos_url":"https://api.github.com/users/autayeu/repos","events_url":"https://api.github.com/users/autayeu/events{/privacy}","received_events_url":"https://api.github.com/users/autayeu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-01-03T20:54:12Z","updated_at":"2016-06-07T17:29:17Z","closed_at":null,"body":"Got this in build logs:\r\n```\r\n[INFO] Repo is in dirty state [false]\r\n[INFO] git.commit.id.describe 9fc943a\r\n[INFO] git.commit.id 9fc943ac73c89ff05eda679774ede4c1b358ccd7\r\n[INFO] git.commit.id.abbrev 9fc943a\r\n[INFO] git.dirty true\r\n```\r\n\r\nFirst and last lines seem to be inconsistent..."},"comment":{"url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/comments/224353780","html_url":"https://github.com/ktoso/maven-git-commit-id-plugin/issues/234#issuecomment-224353780","issue_url":"https://api.github.com/repos/ktoso/maven-git-commit-id-plugin/issues/234","id":224353780,"user":{"login":"TheSnoozer","id":6849390,"avatar_url":"https://avatars.githubusercontent.com/u/6849390?v=3","gravatar_id":"","url":"https://api.github.com/users/TheSnoozer","html_url":"https://github.com/TheSnoozer","followers_url":"https://api.github.com/users/TheSnoozer/followers","following_url":"https://api.github.com/users/TheSnoozer/following{/other_user}","gists_url":"https://api.github.com/users/TheSnoozer/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSnoozer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSnoozer/subscriptions","organizations_url":"https://api.github.com/users/TheSnoozer/orgs","repos_url":"https://api.github.com/users/TheSnoozer/repos","events_url":"https://api.github.com/users/TheSnoozer/events{/privacy}","received_events_url":"https://api.github.com/users/TheSnoozer/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T17:29:17Z","updated_at":"2016-06-07T17:29:17Z","body":"This is indeed a simple inconsistency.\r\nFirst of all the \"native\" git implementation does not tell you in the first place if the ``Repo is in dirty state [ true/false ]`` this only happens if you run the jgit-Implementation with the describe enabled.\r\n\r\nAnd indeed the dirty check for the jgit differs-slightly:\r\n1) first dirty-message (only printed when someone want's to run the git describe): https://github.com/ktoso/maven-git-commit-id-plugin/blob/master/src/main/java/pl/project13/jgit/DescribeCommand.java#L329\r\n2) second dirty-message: https://github.com/ktoso/maven-git-commit-id-plugin/blob/master/src/main/java/pl/project13/maven/git/JGitProvider.java#L131\r\n\r\nBased on the comments in 1) I would suggest to change the dirty to the same as it is as in https://github.com/ktoso/maven-git-commit-id-plugin/blob/master/src/main/java/pl/project13/jgit/DescribeCommand.java#L329\r\nalso I would either remove the additional log message weather the repo is dirty or not or would move it to a place where it will be printed regardless of jgit or native git."}}
{"actor":{"display_login":"TheSnoozer"}}