{"action":"opened","number":30821,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/30821","id":58031019,"html_url":"https://github.com/saltstack/salt/pull/30821","diff_url":"https://github.com/saltstack/salt/pull/30821.diff","patch_url":"https://github.com/saltstack/salt/pull/30821.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/30821","number":30821,"state":"open","locked":false,"title":"Fix for win_network changing dhcp to static DNS","user":{"login":"iamseth","id":131665,"avatar_url":"https://avatars.githubusercontent.com/u/131665?v=3","gravatar_id":"","url":"https://api.github.com/users/iamseth","html_url":"https://github.com/iamseth","followers_url":"https://api.github.com/users/iamseth/followers","following_url":"https://api.github.com/users/iamseth/following{/other_user}","gists_url":"https://api.github.com/users/iamseth/gists{/gist_id}","starred_url":"https://api.github.com/users/iamseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamseth/subscriptions","organizations_url":"https://api.github.com/users/iamseth/orgs","repos_url":"https://api.github.com/users/iamseth/repos","events_url":"https://api.github.com/users/iamseth/events{/privacy}","received_events_url":"https://api.github.com/users/iamseth/received_events","type":"User","site_admin":false},"body":"This fixes a bug that happens when managing network configuration for Windows hosts.\r\n\r\nIf the current mode is 'dhcp' but the state specifies 'static', the state fails with a generic error \"Failed to set desired configuration settings for interface {IFACE}\"\r\n\r\nThis is because the changes['dns_servers'] value doesn't get set so the win_ip module doesn't get invoked later on.\r\n\r\nThis can be reproduced by creating a Windows VM with DNS set to DHCP and running the following state config.\r\n\r\n```yaml\r\nEthernet:\r\n  network.managed:\r\n    - ip_proto: dhcp\r\n    - dns_proto: static\r\n    - dns_servers:\r\n      - 8.8.8.8\r\n      - 8.8.4.4\r\n```","created_at":"2016-02-02T18:43:59Z","updated_at":"2016-02-02T18:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/30821/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/30821/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/30821/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/c4c11f8d0e7bd78939911ce0af2e499878935cfe","head":{"label":"iamseth:develop","ref":"develop","sha":"c4c11f8d0e7bd78939911ce0af2e499878935cfe","user":{"login":"iamseth","id":131665,"avatar_url":"https://avatars.githubusercontent.com/u/131665?v=3","gravatar_id":"","url":"https://api.github.com/users/iamseth","html_url":"https://github.com/iamseth","followers_url":"https://api.github.com/users/iamseth/followers","following_url":"https://api.github.com/users/iamseth/following{/other_user}","gists_url":"https://api.github.com/users/iamseth/gists{/gist_id}","starred_url":"https://api.github.com/users/iamseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamseth/subscriptions","organizations_url":"https://api.github.com/users/iamseth/orgs","repos_url":"https://api.github.com/users/iamseth/repos","events_url":"https://api.github.com/users/iamseth/events{/privacy}","received_events_url":"https://api.github.com/users/iamseth/received_events","type":"User","site_admin":false},"repo":{"id":50940188,"name":"salt","full_name":"iamseth/salt","owner":{"login":"iamseth","id":131665,"avatar_url":"https://avatars.githubusercontent.com/u/131665?v=3","gravatar_id":"","url":"https://api.github.com/users/iamseth","html_url":"https://github.com/iamseth","followers_url":"https://api.github.com/users/iamseth/followers","following_url":"https://api.github.com/users/iamseth/following{/other_user}","gists_url":"https://api.github.com/users/iamseth/gists{/gist_id}","starred_url":"https://api.github.com/users/iamseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamseth/subscriptions","organizations_url":"https://api.github.com/users/iamseth/orgs","repos_url":"https://api.github.com/users/iamseth/repos","events_url":"https://api.github.com/users/iamseth/events{/privacy}","received_events_url":"https://api.github.com/users/iamseth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamseth/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":true,"url":"https://api.github.com/repos/iamseth/salt","forks_url":"https://api.github.com/repos/iamseth/salt/forks","keys_url":"https://api.github.com/repos/iamseth/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamseth/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamseth/salt/teams","hooks_url":"https://api.github.com/repos/iamseth/salt/hooks","issue_events_url":"https://api.github.com/repos/iamseth/salt/issues/events{/number}","events_url":"https://api.github.com/repos/iamseth/salt/events","assignees_url":"https://api.github.com/repos/iamseth/salt/assignees{/user}","branches_url":"https://api.github.com/repos/iamseth/salt/branches{/branch}","tags_url":"https://api.github.com/repos/iamseth/salt/tags","blobs_url":"https://api.github.com/repos/iamseth/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamseth/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamseth/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamseth/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamseth/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/iamseth/salt/languages","stargazers_url":"https://api.github.com/repos/iamseth/salt/stargazers","contributors_url":"https://api.github.com/repos/iamseth/salt/contributors","subscribers_url":"https://api.github.com/repos/iamseth/salt/subscribers","subscription_url":"https://api.github.com/repos/iamseth/salt/subscription","commits_url":"https://api.github.com/repos/iamseth/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamseth/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamseth/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamseth/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamseth/salt/contents/{+path}","compare_url":"https://api.github.com/repos/iamseth/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamseth/salt/merges","archive_url":"https://api.github.com/repos/iamseth/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamseth/salt/downloads","issues_url":"https://api.github.com/repos/iamseth/salt/issues{/number}","pulls_url":"https://api.github.com/repos/iamseth/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/iamseth/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/iamseth/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamseth/salt/labels{/name}","releases_url":"https://api.github.com/repos/iamseth/salt/releases{/id}","deployments_url":"https://api.github.com/repos/iamseth/salt/deployments","created_at":"2016-02-02T17:59:26Z","updated_at":"2016-02-02T17:59:38Z","pushed_at":"2016-02-02T18:42:04Z","git_url":"git://github.com/iamseth/salt.git","ssh_url":"git@github.com:iamseth/salt.git","clone_url":"https://github.com/iamseth/salt.git","svn_url":"https://github.com/iamseth/salt","homepage":"https://repo.saltstack.com/","size":139293,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"d79efe89919bcbf5df091c3d42ab5f41b5af52b2","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-02-02T17:45:42Z","pushed_at":"2016-02-02T18:43:59Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":153448,"stargazers_count":6157,"watchers_count":6157,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2676,"mirror_url":null,"open_issues_count":3279,"forks":2676,"open_issues":3279,"watchers":6157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/30821"},"html":{"href":"https://github.com/saltstack/salt/pull/30821"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/30821"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/30821/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/30821/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/30821/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/c4c11f8d0e7bd78939911ce0af2e499878935cfe"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":1}}