{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments/72033351","id":72033351,"diff_hunk":"@@ -74,12 +101,33 @@ def jsonRegionsExports():\n \n def generateListPerProduct(product):\n     releases = getReleases(ready=True, productFilter=product)\n-    version_list = []\n+    registrar = _L10nReleasesRegistrar()\n     for r in releases:\n-        if r._shippedAt and r.l10nChangesets != config.LEGACY_KEYWORD:\n-            # Only list version which shipped with l10n content\n-            version_list.append(r.name)\n-    return version_list\n+        registrar.addRelease(r)\n+    return registrar.releases\n+\n+\n+class _L10nReleasesRegistrar:\n+    # Matches strings like \"Firefox-19.0b1-build1\" and stores \"Firefox-19.0b\"\n+    BETA_REGEX = re.compile(r\"([^\\-]+-(\\d+\\.)+0b)\\d+-build\\d+\")\n+\n+    def __init__(self):\n+        self.releases = []\n+        self._betas_already_processed = set()\n+\n+    def addRelease(self, release):\n+        if release.isShippedWithL10n:\n+            self._addAggregatedBetaIfNeeded(release)\n+            self.releases.append(release.name)\n+\n+    def _addAggregatedBetaIfNeeded(self, release):\n+        first_beta_match = self.BETA_REGEX.match(release.name)","path":"kickoff/jsonexportl10n.py","position":null,"original_position":106,"commit_id":"e48f60b166d56726140915308399b8d68915ac6c","original_commit_id":"332a10ab5cf5439f1c93bea28ab5b19b0a365f8f","user":{"login":"sylvestre","id":733326,"avatar_url":"https://avatars.githubusercontent.com/u/733326?v=3","gravatar_id":"","url":"https://api.github.com/users/sylvestre","html_url":"https://github.com/sylvestre","followers_url":"https://api.github.com/users/sylvestre/followers","following_url":"https://api.github.com/users/sylvestre/following{/other_user}","gists_url":"https://api.github.com/users/sylvestre/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvestre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvestre/subscriptions","organizations_url":"https://api.github.com/users/sylvestre/orgs","repos_url":"https://api.github.com/users/sylvestre/repos","events_url":"https://api.github.com/users/sylvestre/events{/privacy}","received_events_url":"https://api.github.com/users/sylvestre/received_events","type":"User","site_admin":false},"body":"this is fine, thanks :)\r\n","created_at":"2016-07-25T09:25:57Z","updated_at":"2016-07-25T09:25:57Z","html_url":"https://github.com/mozilla-releng/ship-it/pull/77#discussion_r72033351","pull_request_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments/72033351"},"html":{"href":"https://github.com/mozilla-releng/ship-it/pull/77#discussion_r72033351"},"pull_request":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77","id":78157605,"html_url":"https://github.com/mozilla-releng/ship-it/pull/77","diff_url":"https://github.com/mozilla-releng/ship-it/pull/77.diff","patch_url":"https://github.com/mozilla-releng/ship-it/pull/77.patch","issue_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/77","number":77,"state":"open","locked":false,"title":"Bug 1287828 - Change the export of the l10n files to merge the beta c…","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"body":"…hanges","created_at":"2016-07-20T14:32:04Z","updated_at":"2016-07-25T09:25:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"908e90ef2c574f274807cf90cf1cd2eab0d94b14","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77/commits","review_comments_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77/comments","review_comment_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/77/comments","statuses_url":"https://api.github.com/repos/mozilla-releng/ship-it/statuses/e48f60b166d56726140915308399b8d68915ac6c","head":{"label":"JohanLorenzo:aggregate-beta","ref":"aggregate-beta","sha":"e48f60b166d56726140915308399b8d68915ac6c","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"repo":{"id":63788367,"name":"ship-it","full_name":"JohanLorenzo/ship-it","owner":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohanLorenzo/ship-it","description":"Internal tool to manage release builds","fork":true,"url":"https://api.github.com/repos/JohanLorenzo/ship-it","forks_url":"https://api.github.com/repos/JohanLorenzo/ship-it/forks","keys_url":"https://api.github.com/repos/JohanLorenzo/ship-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohanLorenzo/ship-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohanLorenzo/ship-it/teams","hooks_url":"https://api.github.com/repos/JohanLorenzo/ship-it/hooks","issue_events_url":"https://api.github.com/repos/JohanLorenzo/ship-it/issues/events{/number}","events_url":"https://api.github.com/repos/JohanLorenzo/ship-it/events","assignees_url":"https://api.github.com/repos/JohanLorenzo/ship-it/assignees{/user}","branches_url":"https://api.github.com/repos/JohanLorenzo/ship-it/branches{/branch}","tags_url":"https://api.github.com/repos/JohanLorenzo/ship-it/tags","blobs_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohanLorenzo/ship-it/statuses/{sha}","languages_url":"https://api.github.com/repos/JohanLorenzo/ship-it/languages","stargazers_url":"https://api.github.com/repos/JohanLorenzo/ship-it/stargazers","contributors_url":"https://api.github.com/repos/JohanLorenzo/ship-it/contributors","subscribers_url":"https://api.github.com/repos/JohanLorenzo/ship-it/subscribers","subscription_url":"https://api.github.com/repos/JohanLorenzo/ship-it/subscription","commits_url":"https://api.github.com/repos/JohanLorenzo/ship-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohanLorenzo/ship-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohanLorenzo/ship-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohanLorenzo/ship-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohanLorenzo/ship-it/contents/{+path}","compare_url":"https://api.github.com/repos/JohanLorenzo/ship-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohanLorenzo/ship-it/merges","archive_url":"https://api.github.com/repos/JohanLorenzo/ship-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohanLorenzo/ship-it/downloads","issues_url":"https://api.github.com/repos/JohanLorenzo/ship-it/issues{/number}","pulls_url":"https://api.github.com/repos/JohanLorenzo/ship-it/pulls{/number}","milestones_url":"https://api.github.com/repos/JohanLorenzo/ship-it/milestones{/number}","notifications_url":"https://api.github.com/repos/JohanLorenzo/ship-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohanLorenzo/ship-it/labels{/name}","releases_url":"https://api.github.com/repos/JohanLorenzo/ship-it/releases{/id}","deployments_url":"https://api.github.com/repos/JohanLorenzo/ship-it/deployments","created_at":"2016-07-20T14:31:15Z","updated_at":"2016-07-20T14:31:16Z","pushed_at":"2016-07-25T09:25:21Z","git_url":"git://github.com/JohanLorenzo/ship-it.git","ssh_url":"git@github.com:JohanLorenzo/ship-it.git","clone_url":"https://github.com/JohanLorenzo/ship-it.git","svn_url":"https://github.com/JohanLorenzo/ship-it","homepage":null,"size":2477,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-releng:master","ref":"master","sha":"bc2c01de271399df099b12e7c289b97bbcbd2de5","user":{"login":"mozilla-releng","id":19614164,"avatar_url":"https://avatars.githubusercontent.com/u/19614164?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"repo":{"id":31218912,"name":"ship-it","full_name":"mozilla-releng/ship-it","owner":{"login":"mozilla-releng","id":19614164,"avatar_url":"https://avatars.githubusercontent.com/u/19614164?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-releng/ship-it","description":"Internal tool to manage release builds","fork":false,"url":"https://api.github.com/repos/mozilla-releng/ship-it","forks_url":"https://api.github.com/repos/mozilla-releng/ship-it/forks","keys_url":"https://api.github.com/repos/mozilla-releng/ship-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-releng/ship-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-releng/ship-it/teams","hooks_url":"https://api.github.com/repos/mozilla-releng/ship-it/hooks","issue_events_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-releng/ship-it/events","assignees_url":"https://api.github.com/repos/mozilla-releng/ship-it/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-releng/ship-it/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-releng/ship-it/tags","blobs_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-releng/ship-it/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-releng/ship-it/languages","stargazers_url":"https://api.github.com/repos/mozilla-releng/ship-it/stargazers","contributors_url":"https://api.github.com/repos/mozilla-releng/ship-it/contributors","subscribers_url":"https://api.github.com/repos/mozilla-releng/ship-it/subscribers","subscription_url":"https://api.github.com/repos/mozilla-releng/ship-it/subscription","commits_url":"https://api.github.com/repos/mozilla-releng/ship-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-releng/ship-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-releng/ship-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-releng/ship-it/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-releng/ship-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-releng/ship-it/merges","archive_url":"https://api.github.com/repos/mozilla-releng/ship-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-releng/ship-it/downloads","issues_url":"https://api.github.com/repos/mozilla-releng/ship-it/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-releng/ship-it/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-releng/ship-it/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-releng/ship-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-releng/ship-it/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-releng/ship-it/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-releng/ship-it/deployments","created_at":"2015-02-23T17:07:32Z","updated_at":"2016-07-07T18:09:13Z","pushed_at":"2016-07-25T09:25:21Z","git_url":"git://github.com/mozilla-releng/ship-it.git","ssh_url":"git@github.com:mozilla-releng/ship-it.git","clone_url":"https://github.com/mozilla-releng/ship-it.git","svn_url":"https://github.com/mozilla-releng/ship-it","homepage":null,"size":2830,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":3,"forks":23,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77"},"html":{"href":"https://github.com/mozilla-releng/ship-it/pull/77"},"issue":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/issues/77"},"comments":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-releng/ship-it/statuses/e48f60b166d56726140915308399b8d68915ac6c"}}}}
{"actor":{"display_login":"sylvestre"}}