{"action":"created","issue":{"url":"https://api.github.com/repos/dankelley/oce/issues/1136","repository_url":"https://api.github.com/repos/dankelley/oce","labels_url":"https://api.github.com/repos/dankelley/oce/issues/1136/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/oce/issues/1136/comments","events_url":"https://api.github.com/repos/dankelley/oce/issues/1136/events","html_url":"https://github.com/dankelley/oce/pull/1136","id":195422807,"number":1136,"title":"Fix two aquadopp bugs -- one for axis plotting and one for NA values","user":{"login":"richardsc","id":233584,"avatar_url":"https://avatars.githubusercontent.com/u/233584?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsc","html_url":"https://github.com/richardsc","followers_url":"https://api.github.com/users/richardsc/followers","following_url":"https://api.github.com/users/richardsc/following{/other_user}","gists_url":"https://api.github.com/users/richardsc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsc/subscriptions","organizations_url":"https://api.github.com/users/richardsc/orgs","repos_url":"https://api.github.com/users/richardsc/repos","events_url":"https://api.github.com/users/richardsc/events{/privacy}","received_events_url":"https://api.github.com/users/richardsc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-14T02:15:43Z","updated_at":"2016-12-14T13:53:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dankelley/oce/pulls/1136","html_url":"https://github.com/dankelley/oce/pull/1136","diff_url":"https://github.com/dankelley/oce/pull/1136.diff","patch_url":"https://github.com/dankelley/oce/pull/1136.patch"},"body":"In doing some work on some (private) aquadopp files recently, I discovered that something seemed to be broken about the adp plot method for such instruments.\r\n\r\nAlso, I discovered that apparently sometimes an aquadopp file can have an \"extra\" sample, for which the time is `NA`, but other values exist, but the remaining times are all consecutive as would be expected without the NA. I don't know what causes this, and it should probably be looked into further (are we reading something wrong in the file?), but for now I added a check for such \"NA times\" and just remove the ensemble if any are found.\r\n\r\nIt just occurred to me that it might be a good idea to add a read-time warning that such an ensemble was found and removed."},"comment":{"url":"https://api.github.com/repos/dankelley/oce/issues/comments/267038900","html_url":"https://github.com/dankelley/oce/pull/1136#issuecomment-267038900","issue_url":"https://api.github.com/repos/dankelley/oce/issues/1136","id":267038900,"user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T13:53:28Z","updated_at":"2016-12-14T13:53:28Z","body":"Yes, please send a data file. Also, as a note: I've never seen TravisCI find a real error that Rstudio's \"check\" didn't find. It has some false positives, though; I'd say about 1 in 5 or 10 builds fails because it cannot download something, in setting itself up to run R, etc. (It also has to build a local gdal library, because the debian-provided one is older than the CRAN version. And that takes maybe 10 minutes to build, hence the 25min travisCI time.)"}}
{"actor":{"display_login":"dankelley"}}