{"action":"closed","number":3725,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/3725","id":92485065,"html_url":"https://github.com/qgis/QGIS/pull/3725","diff_url":"https://github.com/qgis/QGIS/pull/3725.diff","patch_url":"https://github.com/qgis/QGIS/pull/3725.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/3725","number":3725,"state":"closed","locked":false,"title":"[processing] Remove parameter geometry predicate","user":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"body":"Here I remove class ParameterGeometryPredicate and related widget by replacing it by ParameterSelection with multiple selection.\r\n\r\nAs replacing list of predicates by list of indexes will break models using impacted algorithms, I've added support for options as (text, value) in ParameterSelection. IMHO it seems mode sustainable to use fixed values (keys) instead of indexes. Command line also seems more understandable, and do not break with QGIS 2, example : \r\n```\r\nprocessing.runalg(\"qgis:selectbylocation\",\"file1.shp\",\"file2.shp\",['intersects'],0.0,0)\r\n```\r\nintead of : \r\n```\r\nprocessing.runalg(\"qgis:selectbylocation\",\"file1.shp\",\"file2.shp\",[1],0.0,0)\r\n```\r\nAs a side effect, we need to open a dialog to see the selected values, maybe this could be improved later, displaying the values in selection widget until 3 values and count of values after that, or adding an option to selection widget for showing the checkboxes list directly in form.\r\n\r\nFix http://hub.qgis.org/issues/15784","created_at":"2016-11-06T11:59:45Z","updated_at":"2016-12-13T14:58:16Z","closed_at":"2016-12-13T14:58:16Z","merged_at":"2016-12-13T14:58:16Z","merge_commit_sha":"0035c97f5be74f579c16733ef0efb8bc64ab96f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/3725/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/3725/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/3725/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/322a565b8b0b8a8fd70bfaa296f1d0f9fcab95f4","head":{"label":"arnaud-morvan:processing_geometry_predicate","ref":"processing_geometry_predicate","sha":"322a565b8b0b8a8fd70bfaa296f1d0f9fcab95f4","user":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"repo":{"id":15884637,"name":"QGIS","full_name":"arnaud-morvan/QGIS","owner":{"login":"arnaud-morvan","id":6095494,"avatar_url":"https://avatars.githubusercontent.com/u/6095494?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaud-morvan","html_url":"https://github.com/arnaud-morvan","followers_url":"https://api.github.com/users/arnaud-morvan/followers","following_url":"https://api.github.com/users/arnaud-morvan/following{/other_user}","gists_url":"https://api.github.com/users/arnaud-morvan/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaud-morvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaud-morvan/subscriptions","organizations_url":"https://api.github.com/users/arnaud-morvan/orgs","repos_url":"https://api.github.com/users/arnaud-morvan/repos","events_url":"https://api.github.com/users/arnaud-morvan/events{/privacy}","received_events_url":"https://api.github.com/users/arnaud-morvan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnaud-morvan/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/arnaud-morvan/QGIS","forks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/forks","keys_url":"https://api.github.com/repos/arnaud-morvan/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnaud-morvan/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnaud-morvan/QGIS/teams","hooks_url":"https://api.github.com/repos/arnaud-morvan/QGIS/hooks","issue_events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/arnaud-morvan/QGIS/events","assignees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/arnaud-morvan/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/tags","blobs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnaud-morvan/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/arnaud-morvan/QGIS/languages","stargazers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/stargazers","contributors_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contributors","subscribers_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscribers","subscription_url":"https://api.github.com/repos/arnaud-morvan/QGIS/subscription","commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnaud-morvan/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnaud-morvan/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/arnaud-morvan/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnaud-morvan/QGIS/merges","archive_url":"https://api.github.com/repos/arnaud-morvan/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnaud-morvan/QGIS/downloads","issues_url":"https://api.github.com/repos/arnaud-morvan/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/arnaud-morvan/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/arnaud-morvan/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/arnaud-morvan/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnaud-morvan/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/arnaud-morvan/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/arnaud-morvan/QGIS/deployments","created_at":"2014-01-13T22:47:33Z","updated_at":"2016-09-02T18:51:23Z","pushed_at":"2016-12-13T11:29:28Z","git_url":"git://github.com/arnaud-morvan/QGIS.git","ssh_url":"git@github.com:arnaud-morvan/QGIS.git","clone_url":"https://github.com/arnaud-morvan/QGIS.git","svn_url":"https://github.com/arnaud-morvan/QGIS","homepage":"http://qgis.org","size":1137134,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"7028eee198d3101f40b7234e505a6c555533382c","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2016-12-12T07:54:58Z","pushed_at":"2016-12-13T14:58:16Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1242704,"stargazers_count":1198,"watchers_count":1198,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":958,"mirror_url":null,"open_issues_count":57,"forks":958,"open_issues":57,"watchers":1198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3725"},"html":{"href":"https://github.com/qgis/QGIS/pull/3725"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3725"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/3725/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3725/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/3725/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/322a565b8b0b8a8fd70bfaa296f1d0f9fcab95f4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"volaya","id":2101651,"avatar_url":"https://avatars.githubusercontent.com/u/2101651?v=3","gravatar_id":"","url":"https://api.github.com/users/volaya","html_url":"https://github.com/volaya","followers_url":"https://api.github.com/users/volaya/followers","following_url":"https://api.github.com/users/volaya/following{/other_user}","gists_url":"https://api.github.com/users/volaya/gists{/gist_id}","starred_url":"https://api.github.com/users/volaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volaya/subscriptions","organizations_url":"https://api.github.com/users/volaya/orgs","repos_url":"https://api.github.com/users/volaya/repos","events_url":"https://api.github.com/users/volaya/events{/privacy}","received_events_url":"https://api.github.com/users/volaya/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":5,"additions":103,"deletions":246,"changed_files":11}}
{"actor":{"display_login":"volaya"}}