{"push_id":1472766485,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"90c09c7f08586e63125fabf8674f3d76842c0fd5","before":"812d82ac17acb1463ad515155ff256b04a55a396","commits":[{"sha":"90c09c7f08586e63125fabf8674f3d76842c0fd5","author":{"name":"simon.fraser@apple.com","email":"daa055b893832bbe20acb7911685e075f8a9ec26@apple.com"},"message":"REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad\nhttps://bugs.webkit.org/show_bug.cgi?id=166472\nrdar://problem/29675551\n\nReviewed by Tim Horton.\n\nSource/WebCore:\n\nr209299 broke autoscroll in zoomed pages because it changed RenderLayer::scrollRectToVisible()\nto shrink viewRect by page scale. This is incorrect for all callers of scrollRectToVisible, since\nthe \"absoluteRect\" passed in is actually in zoomed document coordinates for all the callers I tested.\n\nThis code is also fixed to account for headers and footers. getRectToExpose() takes rectangles\nin \"scroll view contents\" coordinates (i.e. including header, and zoomed document), so doesn't need\nthe separate visibleRectRelativeToDocument parameter.\n\nTests: fast/events/autoscroll-main-document.html\n       fast/events/autoscroll-when-zoomed.html\n       fast/events/drag-select-when-zoomed-with-header.html\n       fast/events/drag-select-when-zoomed.html\n       fast/scrolling/scroll-to-anchor-zoomed-header.html\n\n* rendering/RenderLayer.cpp:\n(WebCore::RenderLayer::scrollRectToVisible):\n(WebCore::RenderLayer::getRectToExpose):\n* rendering/RenderLayer.h:\n\nTools:\n\nThese changes are necessary to allow the mouse to leave the WTR window while\ndrag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged\n(which DRT does); we'd always go through mouseMoved, which hits an early return\nin WebViewImpl::mouseMoved() when the point is outside the view.\n\n* WebKitTestRunner/mac/EventSenderProxy.mm:\n(WTR::EventSenderProxy::mouseMoveTo):\n\nLayoutTests:\n\nAdd some test coverage for autoscroll of the main document. I could only get this\nworking in WebKitTestRunner, not DumpRenderTree.\n\n* TestExpectations:\n* fast/events/autoscroll-main-document-expected.txt: Added.\n* fast/events/autoscroll-main-document.html: Added.\n* fast/events/autoscroll-when-zoomed-expected.txt: Added.\n* fast/events/autoscroll-when-zoomed.html: Added.\n* fast/events/drag-select-when-zoomed-expected.txt: Added.\n* fast/events/drag-select-when-zoomed-with-header-expected.txt: Added.\n* fast/events/drag-select-when-zoomed-with-header.html: Added.\n* fast/events/drag-select-when-zoomed.html: Added.\n* fast/scrolling/scroll-to-anchor-zoomed-header-expected.txt: Added.\n* fast/scrolling/scroll-to-anchor-zoomed-header.html: Added.\n* fast/transforms/selection-bounds-in-transformed-view.html: Revert the target scroll position to what it was\nbefore r209299, and improve the failure output.\n* platform/ios-simulator/TestExpectations:\n* platform/mac-wk2/TestExpectations:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@210147 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/90c09c7f08586e63125fabf8674f3d76842c0fd5"}]}
{"actor":{"display_login":"kisg"}}