{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5858","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5858/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5858/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5858/events","html_url":"https://github.com/NREL/EnergyPlus/pull/5858","id":176666843,"number":5858,"title":"Fix ASIHPMixedTank crash, sizing problems, and output variable names","user":{"login":"shenb","id":5950258,"avatar_url":"https://avatars.githubusercontent.com/u/5950258?v=3","gravatar_id":"","url":"https://api.github.com/users/shenb","html_url":"https://github.com/shenb","followers_url":"https://api.github.com/users/shenb/followers","following_url":"https://api.github.com/users/shenb/following{/other_user}","gists_url":"https://api.github.com/users/shenb/gists{/gist_id}","starred_url":"https://api.github.com/users/shenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenb/subscriptions","organizations_url":"https://api.github.com/users/shenb/orgs","repos_url":"https://api.github.com/users/shenb/repos","events_url":"https://api.github.com/users/shenb/events{/privacy}","received_events_url":"https://api.github.com/users/shenb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/DoNotPublish","name":"DoNotPublish","color":"888888"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4","html_url":"https://github.com/NREL/EnergyPlus/milestones/EnergyPlus%208.6.0","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4/labels","id":1634827,"number":4,"title":"EnergyPlus 8.6.0","description":"The EnergyPlus 8.6.0 public release at the end of FY16Q4.","creator":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"open_issues":133,"closed_issues":107,"state":"open","created_at":"2016-03-09T17:04:23Z","updated_at":"2016-09-16T13:10:12Z","due_on":"2016-09-30T05:00:00Z","closed_at":null},"comments":8,"created_at":"2016-09-13T15:07:10Z","updated_at":"2016-09-16T20:51:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5858","html_url":"https://github.com/NREL/EnergyPlus/pull/5858","diff_url":"https://github.com/NREL/EnergyPlus/pull/5858.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5858.patch"},"body":"Addresses #5845 regarding the crash with running ASIHPMixedTank.idf test file on Linux.  After the fix, diffs in running ASIHPMixedTank.idf are expected. "},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/247705980","html_url":"https://github.com/NREL/EnergyPlus/pull/5858#issuecomment-247705980","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5858","id":247705980,"user":{"login":"shenb","id":5950258,"avatar_url":"https://avatars.githubusercontent.com/u/5950258?v=3","gravatar_id":"","url":"https://api.github.com/users/shenb","html_url":"https://github.com/shenb","followers_url":"https://api.github.com/users/shenb/followers","following_url":"https://api.github.com/users/shenb/following{/other_user}","gists_url":"https://api.github.com/users/shenb/gists{/gist_id}","starred_url":"https://api.github.com/users/shenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenb/subscriptions","organizations_url":"https://api.github.com/users/shenb/orgs","repos_url":"https://api.github.com/users/shenb/repos","events_url":"https://api.github.com/users/shenb/events{/privacy}","received_events_url":"https://api.github.com/users/shenb/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T20:51:10Z","updated_at":"2016-09-16T20:51:10Z","body":"And one more that overlapped with the one from the cooling coil, should keep the \"Total\" if it is truly total=sensible+latent\r\nIntegrated Heat Pump Cooling Coil Total Cooling Rate\r\n\r\nThis is true.\r\n\r\nFrom: Michael J. Witte [mailto:notifications@github.com]\r\nSent: Friday, September 16, 2016 3:04 PM\r\nTo: NREL/EnergyPlus\r\nCc: Shen, Bo; Mention\r\nSubject: Re: [NREL/EnergyPlus] Fix ASIHPMixedTank crash, sizing problems, and output variable names (#5858)\r\n\r\n\r\n@mjwitte requested changes on this pull request.\r\n\r\nAnd one more that overlapped with the one from the cooling coil, should keep the \"Total\" if it is truly total=sensible+latent\r\nIntegrated Heat Pump Cooling Coil Total Cooling Rate\r\n\r\nLooking more at the \"Rate\" variables vs \"Energy\" variables. If they represent the same quantity just one as W and the other as J, then the names should be the same. Right now there is\r\n\r\nIntegrated Heat Pump Heating Coil Air Heating Rate\r\n\r\nIntegrated Heat Pump Air Heating Energy\r\n\r\nUnless they represent a different heat flow, then they should be identical except for the last work \"Rate\" and \"Energy\". Some others have the same issue.\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://github.com/NREL/EnergyPlus/pull/5858#pullrequestreview-410251>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFrLMrrQPDcZTlk4dXvYEVgpmuHXw0giks5qqug9gaJpZM4J7yMC>.\r\n"}}
{"actor":{"display_login":"shenb"}}