{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments/84542998","pull_request_review_id":5317831,"id":84542998,"diff_hunk":"@@ -52,23 +63,14 @@\n import org.eclipse.wst.server.core.ServerEvent;\n import org.eclipse.wst.server.core.ServerUtil;\n \n-import java.io.File;\n-import java.net.MalformedURLException;\n-import java.net.URL;\n-import java.util.ArrayList;\n-import java.util.HashMap;\n-import java.util.List;\n-import java.util.Map;\n-import java.util.logging.Level;\n-import java.util.logging.Logger;\n-\n public class LocalAppEngineServerLaunchConfigurationDelegate\n     extends AbstractJavaLaunchConfigurationDelegate {\n \n   private final static Logger logger =\n       Logger.getLogger(LocalAppEngineServerLaunchConfigurationDelegate.class.getName());\n \n   private static final String DEBUGGER_HOST = \"localhost\";","path":"plugins/com.google.cloud.tools.eclipse.appengine.localserver/src/com/google/cloud/tools/eclipse/appengine/localserver/server/LocalAppEngineServerLaunchConfigurationDelegate.java","position":72,"original_position":72,"commit_id":"3dd43ab21a23c1a1c52b78c8c89c9b0a3efffd2a","original_commit_id":"3dd43ab21a23c1a1c52b78c8c89c9b0a3efffd2a","user":{"login":"briandealwis","id":202851,"avatar_url":"https://avatars.githubusercontent.com/u/202851?v=3","gravatar_id":"","url":"https://api.github.com/users/briandealwis","html_url":"https://github.com/briandealwis","followers_url":"https://api.github.com/users/briandealwis/followers","following_url":"https://api.github.com/users/briandealwis/following{/other_user}","gists_url":"https://api.github.com/users/briandealwis/gists{/gist_id}","starred_url":"https://api.github.com/users/briandealwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandealwis/subscriptions","organizations_url":"https://api.github.com/users/briandealwis/orgs","repos_url":"https://api.github.com/users/briandealwis/repos","events_url":"https://api.github.com/users/briandealwis/events{/privacy}","received_events_url":"https://api.github.com/users/briandealwis/received_events","type":"User","site_admin":false},"body":"Is `DEBUGGER_HOST` still needed then?","created_at":"2016-10-21T20:56:14Z","updated_at":"2016-10-21T21:01:07Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871#discussion_r84542998","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments/84542998"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871#discussion_r84542998"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871","id":90436997,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871","number":871,"state":"open","locked":false,"title":"Enable configuring service port for local run","user":{"login":"chanseokoh","id":10523105,"avatar_url":"https://avatars.githubusercontent.com/u/10523105?v=3","gravatar_id":"","url":"https://api.github.com/users/chanseokoh","html_url":"https://github.com/chanseokoh","followers_url":"https://api.github.com/users/chanseokoh/followers","following_url":"https://api.github.com/users/chanseokoh/following{/other_user}","gists_url":"https://api.github.com/users/chanseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/chanseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanseokoh/subscriptions","organizations_url":"https://api.github.com/users/chanseokoh/orgs","repos_url":"https://api.github.com/users/chanseokoh/repos","events_url":"https://api.github.com/users/chanseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/chanseokoh/received_events","type":"User","site_admin":false},"body":"The server port field (spinner) is placed below the runtime environment combo. That's practically the only place we can add this field. This spinner is dynamically shown/hide as you change the server type to/from our App Engine Server.\r\n\r\n![new server _009](https://cloud.githubusercontent.com/assets/10523105/19604848/0b9578e6-9785-11e6-9bf9-375e4b16a1ef.png)\r\n\r\nOne minor problem: the new spinner makes the server selection box even smaller on my machine, to the point that it looks like a single-line text box. I can still clearly see that our \"App Engine Standard\" server.\r\n\r\nLastly, I removed `<useUIThread>false</useUIThread>` (which will set it to true by default) in `pom.xml` to make tests work. Tests can't access `Display` or `Shell` when they are run in a background thread.","created_at":"2016-10-21T20:16:53Z","updated_at":"2016-10-21T21:01:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feec37c3008fb7f18a7141e40de357517e9a053f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/3dd43ab21a23c1a1c52b78c8c89c9b0a3efffd2a","head":{"label":"GoogleCloudPlatform:allow-server-port-config","ref":"allow-server-port-config","sha":"3dd43ab21a23c1a1c52b78c8c89c9b0a3efffd2a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":53369484,"name":"google-cloud-eclipse","full_name":"GoogleCloudPlatform/google-cloud-eclipse","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","description":"Google Cloud Platform plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/deployments","created_at":"2016-03-08T00:30:03Z","updated_at":"2016-10-09T10:27:59Z","pushed_at":"2016-10-21T20:46:28Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-eclipse.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","homepage":"","size":6706,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":185,"forks":5,"open_issues":185,"watchers":14,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"aa220bd68e3f82daa4be60e10209713a3626b6bf","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":53369484,"name":"google-cloud-eclipse","full_name":"GoogleCloudPlatform/google-cloud-eclipse","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","description":"Google Cloud Platform plugin for Eclipse","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/deployments","created_at":"2016-03-08T00:30:03Z","updated_at":"2016-10-09T10:27:59Z","pushed_at":"2016-10-21T20:46:28Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-eclipse.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse","homepage":"","size":6706,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":185,"forks":5,"open_issues":185,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/871"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/issues/871/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/pulls/871/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-eclipse/statuses/3dd43ab21a23c1a1c52b78c8c89c9b0a3efffd2a"}}}}
{"actor":{"display_login":"briandealwis"}}