{"action":"created","comment":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments/81146322","pull_request_review_id":2147185,"id":81146322,"diff_hunk":"@@ -14,7 +14,7 @@\n # limitations under the License.\n \n - name: Gather mons facts for ceph.conf template\n-  hosts: mons\n+  include: gen-facts.yml","path":"rpcd/playbooks/ceph-osd.yml","position":5,"original_position":5,"commit_id":"acb2491e89e163c78fe776524f31925bd008de54","original_commit_id":"acb2491e89e163c78fe776524f31925bd008de54","user":{"login":"git-harry","id":687171,"avatar_url":"https://avatars.githubusercontent.com/u/687171?v=3","gravatar_id":"","url":"https://api.github.com/users/git-harry","html_url":"https://github.com/git-harry","followers_url":"https://api.github.com/users/git-harry/followers","following_url":"https://api.github.com/users/git-harry/following{/other_user}","gists_url":"https://api.github.com/users/git-harry/gists{/gist_id}","starred_url":"https://api.github.com/users/git-harry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-harry/subscriptions","organizations_url":"https://api.github.com/users/git-harry/orgs","repos_url":"https://api.github.com/users/git-harry/repos","events_url":"https://api.github.com/users/git-harry/events{/privacy}","received_events_url":"https://api.github.com/users/git-harry/received_events","type":"User","site_admin":false},"body":"What is the benefit of putting this in a playbook?","created_at":"2016-09-29T14:15:50Z","updated_at":"2016-09-29T14:15:51Z","html_url":"https://github.com/rcbops/rpc-openstack/pull/1431#discussion_r81146322","pull_request_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431","_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments/81146322"},"html":{"href":"https://github.com/rcbops/rpc-openstack/pull/1431#discussion_r81146322"},"pull_request":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431"}}},"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431","id":86215745,"html_url":"https://github.com/rcbops/rpc-openstack/pull/1431","diff_url":"https://github.com/rcbops/rpc-openstack/pull/1431.diff","patch_url":"https://github.com/rcbops/rpc-openstack/pull/1431.patch","issue_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1431","number":1431,"state":"open","locked":false,"title":"Ceph hostname change during upgrade","user":{"login":"evrardjp","id":3110235,"avatar_url":"https://avatars.githubusercontent.com/u/3110235?v=3","gravatar_id":"","url":"https://api.github.com/users/evrardjp","html_url":"https://github.com/evrardjp","followers_url":"https://api.github.com/users/evrardjp/followers","following_url":"https://api.github.com/users/evrardjp/following{/other_user}","gists_url":"https://api.github.com/users/evrardjp/gists{/gist_id}","starred_url":"https://api.github.com/users/evrardjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evrardjp/subscriptions","organizations_url":"https://api.github.com/users/evrardjp/orgs","repos_url":"https://api.github.com/users/evrardjp/repos","events_url":"https://api.github.com/users/evrardjp/events{/privacy}","received_events_url":"https://api.github.com/users/evrardjp/received_events","type":"User","site_admin":false},"body":"L>M has changed the hostname of our containers, therefore we\r\nneed to adapt this everywhere. Ceph was left behind, and this\r\nis fixing the hostnames by shutting down the monitors, removing the mons,\r\ndeleting the containers, recreating them, and rejoining the cluster, all\r\nof this in a serial way.\r\n\r\nThe ceph-mon playbook was adapted to verify the bind mount is there, in\r\norder to avoid data loss.\r\n\r\nComments are added explaining what is done, and what is needed\r\nwhen upgrading an environment with ceph.\r\n\r\nThis commit also ensures the generation of the facts used in the\r\nsetup-maas is properly done (explicitly asking the generation of\r\nthe facts by including our new gen-facts playbook).\r\n\r\nSigned-off-by: Jean-Philippe Evrard <jean-philippe.evrard@rackspace.co.uk>\r\nConnected rcbops/u-suk-dev#383","created_at":"2016-09-21T18:26:03Z","updated_at":"2016-09-29T14:15:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7b86f224f403c65256616b7385d05af81802d52","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431/commits","review_comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431/comments","review_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1431/comments","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/acb2491e89e163c78fe776524f31925bd008de54","head":{"label":"rcbops:ceph-master","ref":"ceph-master","sha":"acb2491e89e163c78fe776524f31925bd008de54","user":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":30100099,"name":"rpc-openstack","full_name":"rcbops/rpc-openstack","owner":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc-openstack","description":"Rackspace Private Cloud Offering based on OpenStack","fork":false,"url":"https://api.github.com/repos/rcbops/rpc-openstack","forks_url":"https://api.github.com/repos/rcbops/rpc-openstack/forks","keys_url":"https://api.github.com/repos/rcbops/rpc-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc-openstack/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc-openstack/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/events","assignees_url":"https://api.github.com/repos/rcbops/rpc-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc-openstack/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc-openstack/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc-openstack/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc-openstack/merges","archive_url":"https://api.github.com/repos/rcbops/rpc-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc-openstack/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc-openstack/deployments","created_at":"2015-01-31T02:51:12Z","updated_at":"2016-09-15T22:19:56Z","pushed_at":"2016-09-29T12:12:09Z","git_url":"git://github.com/rcbops/rpc-openstack.git","ssh_url":"git@github.com:rcbops/rpc-openstack.git","clone_url":"https://github.com/rcbops/rpc-openstack.git","svn_url":"https://github.com/rcbops/rpc-openstack","homepage":"","size":2939,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":91,"forks":45,"open_issues":91,"watchers":35,"default_branch":"master"}},"base":{"label":"rcbops:master","ref":"master","sha":"1ac759b3a3fe4f39f782f0cabf13cc0e4c10fdc0","user":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":30100099,"name":"rpc-openstack","full_name":"rcbops/rpc-openstack","owner":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc-openstack","description":"Rackspace Private Cloud Offering based on OpenStack","fork":false,"url":"https://api.github.com/repos/rcbops/rpc-openstack","forks_url":"https://api.github.com/repos/rcbops/rpc-openstack/forks","keys_url":"https://api.github.com/repos/rcbops/rpc-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc-openstack/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc-openstack/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/events","assignees_url":"https://api.github.com/repos/rcbops/rpc-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc-openstack/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc-openstack/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc-openstack/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc-openstack/merges","archive_url":"https://api.github.com/repos/rcbops/rpc-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc-openstack/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc-openstack/deployments","created_at":"2015-01-31T02:51:12Z","updated_at":"2016-09-15T22:19:56Z","pushed_at":"2016-09-29T12:12:09Z","git_url":"git://github.com/rcbops/rpc-openstack.git","ssh_url":"git@github.com:rcbops/rpc-openstack.git","clone_url":"https://github.com/rcbops/rpc-openstack.git","svn_url":"https://github.com/rcbops/rpc-openstack","homepage":"","size":2939,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":91,"forks":45,"open_issues":91,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431"},"html":{"href":"https://github.com/rcbops/rpc-openstack/pull/1431"},"issue":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1431"},"comments":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1431/comments"},"review_comments":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431/comments"},"review_comment":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1431/commits"},"statuses":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/acb2491e89e163c78fe776524f31925bd008de54"}}}}
{"actor":{"display_login":"git-harry"}}