{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/2","id":67082588,"html_url":"https://github.com/NVIDIA/tegrarcm/pull/2","diff_url":"https://github.com/NVIDIA/tegrarcm/pull/2.diff","patch_url":"https://github.com/NVIDIA/tegrarcm/pull/2.patch","issue_url":"https://api.github.com/repos/NVIDIA/tegrarcm/issues/2","number":2,"state":"open","locked":false,"title":"Don't assume cryptopp is system-wide installed","user":{"login":"tpetazzoni","id":1089203,"avatar_url":"https://avatars.githubusercontent.com/u/1089203?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetazzoni","html_url":"https://github.com/tpetazzoni","followers_url":"https://api.github.com/users/tpetazzoni/followers","following_url":"https://api.github.com/users/tpetazzoni/following{/other_user}","gists_url":"https://api.github.com/users/tpetazzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetazzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetazzoni/subscriptions","organizations_url":"https://api.github.com/users/tpetazzoni/orgs","repos_url":"https://api.github.com/users/tpetazzoni/repos","events_url":"https://api.github.com/users/tpetazzoni/events{/privacy}","received_events_url":"https://api.github.com/users/tpetazzoni/received_events","type":"User","site_admin":false},"body":"The current build system adds \"-isystem /usr/include/$(CRYPTOLIB)\" to\r\nAM_CPPFLAGS, but this is wrong because cryptopp might not be installed\r\nin this location. Instead, the build system should simply include\r\n<cryptopp/...> or <crypto++/...> and rely on the compiler include\r\npath.\r\n\r\nThe tricky part is that it can be <cryptopp/...> or <crypto++/...>. To\r\nsolve this, we use a solution similar to the one used in\r\nhttps://github.com/bingmann/crypto-speedtest/blob/master/m4/cryptopp.m4\r\nand\r\nhttps://github.com/bingmann/crypto-speedtest/blob/master/src/speedtest_cryptopp.cpp:\r\nthe configure script fills in a variable called\r\nCRYPTOLIB_HEADER_PREFIX, and we use that in the C++ code to include\r\nthe right header file.\r\n\r\nIt is worth mentioning that doing #include\r\n<CRYPTOLIB_HEADER_PREFIX/foobar.h> doesn't work, and we have to use an\r\nintermediate #define'd constant to overcome this C preprocessor\r\nlimitation.\r\n\r\nSigned-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","created_at":"2016-04-19T20:18:25Z","updated_at":"2016-04-19T20:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/2/commits","review_comments_url":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/2/comments","review_comment_url":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NVIDIA/tegrarcm/issues/2/comments","statuses_url":"https://api.github.com/repos/NVIDIA/tegrarcm/statuses/5ea6b3859ebe16ff47856b58262b14463e119c13","head":{"label":"tpetazzoni:fix-header-path","ref":"fix-header-path","sha":"5ea6b3859ebe16ff47856b58262b14463e119c13","user":{"login":"tpetazzoni","id":1089203,"avatar_url":"https://avatars.githubusercontent.com/u/1089203?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetazzoni","html_url":"https://github.com/tpetazzoni","followers_url":"https://api.github.com/users/tpetazzoni/followers","following_url":"https://api.github.com/users/tpetazzoni/following{/other_user}","gists_url":"https://api.github.com/users/tpetazzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetazzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetazzoni/subscriptions","organizations_url":"https://api.github.com/users/tpetazzoni/orgs","repos_url":"https://api.github.com/users/tpetazzoni/repos","events_url":"https://api.github.com/users/tpetazzoni/events{/privacy}","received_events_url":"https://api.github.com/users/tpetazzoni/received_events","type":"User","site_admin":false},"repo":{"id":56628907,"name":"tegrarcm","full_name":"tpetazzoni/tegrarcm","owner":{"login":"tpetazzoni","id":1089203,"avatar_url":"https://avatars.githubusercontent.com/u/1089203?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetazzoni","html_url":"https://github.com/tpetazzoni","followers_url":"https://api.github.com/users/tpetazzoni/followers","following_url":"https://api.github.com/users/tpetazzoni/following{/other_user}","gists_url":"https://api.github.com/users/tpetazzoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetazzoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetazzoni/subscriptions","organizations_url":"https://api.github.com/users/tpetazzoni/orgs","repos_url":"https://api.github.com/users/tpetazzoni/repos","events_url":"https://api.github.com/users/tpetazzoni/events{/privacy}","received_events_url":"https://api.github.com/users/tpetazzoni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpetazzoni/tegrarcm","description":"Tegra ReCovery Mode tool; communicates with Tegra's boot ROM to download code over USB","fork":true,"url":"https://api.github.com/repos/tpetazzoni/tegrarcm","forks_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/forks","keys_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/teams","hooks_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/hooks","issue_events_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/issues/events{/number}","events_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/events","assignees_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/assignees{/user}","branches_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/branches{/branch}","tags_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/tags","blobs_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/statuses/{sha}","languages_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/languages","stargazers_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/stargazers","contributors_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/contributors","subscribers_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/subscribers","subscription_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/subscription","commits_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/contents/{+path}","compare_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/merges","archive_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/downloads","issues_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/issues{/number}","pulls_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/pulls{/number}","milestones_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/milestones{/number}","notifications_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/labels{/name}","releases_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/releases{/id}","deployments_url":"https://api.github.com/repos/tpetazzoni/tegrarcm/deployments","created_at":"2016-04-19T20:17:57Z","updated_at":"2016-04-19T20:17:58Z","pushed_at":"2016-04-19T20:18:18Z","git_url":"git://github.com/tpetazzoni/tegrarcm.git","ssh_url":"git@github.com:tpetazzoni/tegrarcm.git","clone_url":"https://github.com/tpetazzoni/tegrarcm.git","svn_url":"https://github.com/tpetazzoni/tegrarcm","homepage":null,"size":5977,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NVIDIA:master","ref":"master","sha":"ffd53122f08af6c08d2b38ab6b64be8d6e9dddbb","user":{"login":"NVIDIA","id":1728152,"avatar_url":"https://avatars.githubusercontent.com/u/1728152?v=3","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"repo":{"id":12443688,"name":"tegrarcm","full_name":"NVIDIA/tegrarcm","owner":{"login":"NVIDIA","id":1728152,"avatar_url":"https://avatars.githubusercontent.com/u/1728152?v=3","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NVIDIA/tegrarcm","description":"Tegra ReCovery Mode tool; communicates with Tegra's boot ROM to download code over USB","fork":false,"url":"https://api.github.com/repos/NVIDIA/tegrarcm","forks_url":"https://api.github.com/repos/NVIDIA/tegrarcm/forks","keys_url":"https://api.github.com/repos/NVIDIA/tegrarcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NVIDIA/tegrarcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NVIDIA/tegrarcm/teams","hooks_url":"https://api.github.com/repos/NVIDIA/tegrarcm/hooks","issue_events_url":"https://api.github.com/repos/NVIDIA/tegrarcm/issues/events{/number}","events_url":"https://api.github.com/repos/NVIDIA/tegrarcm/events","assignees_url":"https://api.github.com/repos/NVIDIA/tegrarcm/assignees{/user}","branches_url":"https://api.github.com/repos/NVIDIA/tegrarcm/branches{/branch}","tags_url":"https://api.github.com/repos/NVIDIA/tegrarcm/tags","blobs_url":"https://api.github.com/repos/NVIDIA/tegrarcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NVIDIA/tegrarcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NVIDIA/tegrarcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/NVIDIA/tegrarcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NVIDIA/tegrarcm/statuses/{sha}","languages_url":"https://api.github.com/repos/NVIDIA/tegrarcm/languages","stargazers_url":"https://api.github.com/repos/NVIDIA/tegrarcm/stargazers","contributors_url":"https://api.github.com/repos/NVIDIA/tegrarcm/contributors","subscribers_url":"https://api.github.com/repos/NVIDIA/tegrarcm/subscribers","subscription_url":"https://api.github.com/repos/NVIDIA/tegrarcm/subscription","commits_url":"https://api.github.com/repos/NVIDIA/tegrarcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/NVIDIA/tegrarcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/NVIDIA/tegrarcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/NVIDIA/tegrarcm/issues/comments{/number}","contents_url":"https://api.github.com/repos/NVIDIA/tegrarcm/contents/{+path}","compare_url":"https://api.github.com/repos/NVIDIA/tegrarcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NVIDIA/tegrarcm/merges","archive_url":"https://api.github.com/repos/NVIDIA/tegrarcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NVIDIA/tegrarcm/downloads","issues_url":"https://api.github.com/repos/NVIDIA/tegrarcm/issues{/number}","pulls_url":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls{/number}","milestones_url":"https://api.github.com/repos/NVIDIA/tegrarcm/milestones{/number}","notifications_url":"https://api.github.com/repos/NVIDIA/tegrarcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NVIDIA/tegrarcm/labels{/name}","releases_url":"https://api.github.com/repos/NVIDIA/tegrarcm/releases{/id}","deployments_url":"https://api.github.com/repos/NVIDIA/tegrarcm/deployments","created_at":"2013-08-28T20:20:13Z","updated_at":"2016-03-16T16:36:45Z","pushed_at":"2016-03-17T12:30:25Z","git_url":"git://github.com/NVIDIA/tegrarcm.git","ssh_url":"git@github.com:NVIDIA/tegrarcm.git","clone_url":"https://github.com/NVIDIA/tegrarcm.git","svn_url":"https://github.com/NVIDIA/tegrarcm","homepage":null,"size":5977,"stargazers_count":9,"watchers_count":9,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/2"},"html":{"href":"https://github.com/NVIDIA/tegrarcm/pull/2"},"issue":{"href":"https://api.github.com/repos/NVIDIA/tegrarcm/issues/2"},"comments":{"href":"https://api.github.com/repos/NVIDIA/tegrarcm/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NVIDIA/tegrarcm/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/NVIDIA/tegrarcm/statuses/5ea6b3859ebe16ff47856b58262b14463e119c13"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":12,"changed_files":3}}