{"action":"created","issue":{"url":"https://api.github.com/repos/davezuko/react-redux-starter-kit/issues/371","labels_url":"https://api.github.com/repos/davezuko/react-redux-starter-kit/issues/371/labels{/name}","comments_url":"https://api.github.com/repos/davezuko/react-redux-starter-kit/issues/371/comments","events_url":"https://api.github.com/repos/davezuko/react-redux-starter-kit/issues/371/events","html_url":"https://github.com/davezuko/react-redux-starter-kit/pull/371","id":124343325,"number":371,"title":"Modified compiler_public_path to undefined","user":{"login":"yosqueoy","id":156944,"avatar_url":"https://avatars.githubusercontent.com/u/156944?v=3","gravatar_id":"","url":"https://api.github.com/users/yosqueoy","html_url":"https://github.com/yosqueoy","followers_url":"https://api.github.com/users/yosqueoy/followers","following_url":"https://api.github.com/users/yosqueoy/following{/other_user}","gists_url":"https://api.github.com/users/yosqueoy/gists{/gist_id}","starred_url":"https://api.github.com/users/yosqueoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosqueoy/subscriptions","organizations_url":"https://api.github.com/users/yosqueoy/orgs","repos_url":"https://api.github.com/users/yosqueoy/repos","events_url":"https://api.github.com/users/yosqueoy/events{/privacy}","received_events_url":"https://api.github.com/users/yosqueoy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-30T12:48:37Z","updated_at":"2016-01-02T00:35:04Z","closed_at":"2016-01-02T00:35:04Z","pull_request":{"url":"https://api.github.com/repos/davezuko/react-redux-starter-kit/pulls/371","html_url":"https://github.com/davezuko/react-redux-starter-kit/pull/371","diff_url":"https://github.com/davezuko/react-redux-starter-kit/pull/371.diff","patch_url":"https://github.com/davezuko/react-redux-starter-kit/pull/371.patch"},"body":"I suggest to change the default value of compiler_public_path from '/' to undefined. Current value doesn't work when proxy sets prefix.\r\n\r\nCurrent version creates the line below. The src is an absolute path, so it will not work if prefix like /deploy is set by proxy. \r\n```\r\n<script src=\"/app.c3e1585f9dcb449f54f3.js\"></script>\r\n```\r\nProxy expects http://<host>/deploy/app.c3e1585f9dcb449f54f3.js, but the src is  http://<host>/app.c3e1585f9dcb449f54f3.js.\r\n\r\nAfter changing compiler_public_path to undefined, the line becomes a relative path, which works well with proxy prefix. \r\n```\r\n<script src=\"app.c3e1585f9dcb449f54f3.js\"></script>\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/davezuko/react-redux-starter-kit/issues/comments/168352941","html_url":"https://github.com/davezuko/react-redux-starter-kit/pull/371#issuecomment-168352941","issue_url":"https://api.github.com/repos/davezuko/react-redux-starter-kit/issues/371","id":168352941,"user":{"login":"yosqueoy","id":156944,"avatar_url":"https://avatars.githubusercontent.com/u/156944?v=3","gravatar_id":"","url":"https://api.github.com/users/yosqueoy","html_url":"https://github.com/yosqueoy","followers_url":"https://api.github.com/users/yosqueoy/followers","following_url":"https://api.github.com/users/yosqueoy/following{/other_user}","gists_url":"https://api.github.com/users/yosqueoy/gists{/gist_id}","starred_url":"https://api.github.com/users/yosqueoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosqueoy/subscriptions","organizations_url":"https://api.github.com/users/yosqueoy/orgs","repos_url":"https://api.github.com/users/yosqueoy/repos","events_url":"https://api.github.com/users/yosqueoy/events{/privacy}","received_events_url":"https://api.github.com/users/yosqueoy/received_events","type":"User","site_admin":false},"created_at":"2016-01-02T00:35:04Z","updated_at":"2016-01-02T00:35:04Z","body":"Thanks, #370 fixed my issue. Empty string is perfectly fine and that has the same effect as undefined because webpack internally uses publicPath option as below.\r\n```\r\nvar publicPath = outputOptions.publicPath || \"\";\r\n```\r\nhttps://github.com/webpack/webpack/blob/9f440e30ecac00bfc27b91d372a969d3414d194c/lib/TemplatedPathPlugin.js"}}