{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/55884800","id":55884800,"diff_hunk":"@@ -61,38 +67,47 @@ pub fn doc(manifest_path: &Path,\n }\n \n #[cfg(not(any(target_os = \"windows\", target_os = \"macos\")))]\n-fn open_docs(path: &Path) {\n+fn open_docs(path: &Path) -> Result<(), ()> {\n+    // trying $BROWSER\n+    match env::var(\"BROWSER\").map(|name| Command::new(name).arg(path).status()) {","path":"src/cargo/ops/cargo_doc.rs","position":27,"original_position":27,"commit_id":"3950bc9685ccb3e84878efbcd7fbe6f0cdfd4bd8","original_commit_id":"3950bc9685ccb3e84878efbcd7fbe6f0cdfd4bd8","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"Out of curiosity, is this a standard method of specifying a program to open something with?","created_at":"2016-03-11T20:33:47Z","updated_at":"2016-03-11T20:33:47Z","html_url":"https://github.com/rust-lang/cargo/pull/2468#discussion_r55884800","pull_request_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2468","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/55884800"},"html":{"href":"https://github.com/rust-lang/cargo/pull/2468#discussion_r55884800"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2468"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/2468","id":62537868,"html_url":"https://github.com/rust-lang/cargo/pull/2468","diff_url":"https://github.com/rust-lang/cargo/pull/2468.diff","patch_url":"https://github.com/rust-lang/cargo/pull/2468.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/2468","number":2468,"state":"open","locked":false,"title":"Add warning if no browser","user":{"login":"TheNeikos","id":1631166,"avatar_url":"https://avatars.githubusercontent.com/u/1631166?v=3","gravatar_id":"","url":"https://api.github.com/users/TheNeikos","html_url":"https://github.com/TheNeikos","followers_url":"https://api.github.com/users/TheNeikos/followers","following_url":"https://api.github.com/users/TheNeikos/following{/other_user}","gists_url":"https://api.github.com/users/TheNeikos/gists{/gist_id}","starred_url":"https://api.github.com/users/TheNeikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheNeikos/subscriptions","organizations_url":"https://api.github.com/users/TheNeikos/orgs","repos_url":"https://api.github.com/users/TheNeikos/repos","events_url":"https://api.github.com/users/TheNeikos/events{/privacy}","received_events_url":"https://api.github.com/users/TheNeikos/received_events","type":"User","site_admin":false},"body":"Closes #2371 \r\n\r\nI am unsure if `println!` is the correct way to print warnings at this stage, since it is not a hard error thus returning `Err` seems a bit too strong.","created_at":"2016-03-11T12:41:48Z","updated_at":"2016-03-11T20:33:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"290ead173dde4643430c6ddc12558b0e97895e6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2468/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2468/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/2468/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/3950bc9685ccb3e84878efbcd7fbe6f0cdfd4bd8","head":{"label":"TheNeikos:add-warning_if_no_browser","ref":"add-warning_if_no_browser","sha":"3950bc9685ccb3e84878efbcd7fbe6f0cdfd4bd8","user":{"login":"TheNeikos","id":1631166,"avatar_url":"https://avatars.githubusercontent.com/u/1631166?v=3","gravatar_id":"","url":"https://api.github.com/users/TheNeikos","html_url":"https://github.com/TheNeikos","followers_url":"https://api.github.com/users/TheNeikos/followers","following_url":"https://api.github.com/users/TheNeikos/following{/other_user}","gists_url":"https://api.github.com/users/TheNeikos/gists{/gist_id}","starred_url":"https://api.github.com/users/TheNeikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheNeikos/subscriptions","organizations_url":"https://api.github.com/users/TheNeikos/orgs","repos_url":"https://api.github.com/users/TheNeikos/repos","events_url":"https://api.github.com/users/TheNeikos/events{/privacy}","received_events_url":"https://api.github.com/users/TheNeikos/received_events","type":"User","site_admin":false},"repo":{"id":53570958,"name":"cargo","full_name":"TheNeikos/cargo","owner":{"login":"TheNeikos","id":1631166,"avatar_url":"https://avatars.githubusercontent.com/u/1631166?v=3","gravatar_id":"","url":"https://api.github.com/users/TheNeikos","html_url":"https://github.com/TheNeikos","followers_url":"https://api.github.com/users/TheNeikos/followers","following_url":"https://api.github.com/users/TheNeikos/following{/other_user}","gists_url":"https://api.github.com/users/TheNeikos/gists{/gist_id}","starred_url":"https://api.github.com/users/TheNeikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheNeikos/subscriptions","organizations_url":"https://api.github.com/users/TheNeikos/orgs","repos_url":"https://api.github.com/users/TheNeikos/repos","events_url":"https://api.github.com/users/TheNeikos/events{/privacy}","received_events_url":"https://api.github.com/users/TheNeikos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheNeikos/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/TheNeikos/cargo","forks_url":"https://api.github.com/repos/TheNeikos/cargo/forks","keys_url":"https://api.github.com/repos/TheNeikos/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheNeikos/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheNeikos/cargo/teams","hooks_url":"https://api.github.com/repos/TheNeikos/cargo/hooks","issue_events_url":"https://api.github.com/repos/TheNeikos/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/TheNeikos/cargo/events","assignees_url":"https://api.github.com/repos/TheNeikos/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/TheNeikos/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/TheNeikos/cargo/tags","blobs_url":"https://api.github.com/repos/TheNeikos/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheNeikos/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheNeikos/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheNeikos/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheNeikos/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/TheNeikos/cargo/languages","stargazers_url":"https://api.github.com/repos/TheNeikos/cargo/stargazers","contributors_url":"https://api.github.com/repos/TheNeikos/cargo/contributors","subscribers_url":"https://api.github.com/repos/TheNeikos/cargo/subscribers","subscription_url":"https://api.github.com/repos/TheNeikos/cargo/subscription","commits_url":"https://api.github.com/repos/TheNeikos/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheNeikos/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheNeikos/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheNeikos/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheNeikos/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/TheNeikos/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheNeikos/cargo/merges","archive_url":"https://api.github.com/repos/TheNeikos/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheNeikos/cargo/downloads","issues_url":"https://api.github.com/repos/TheNeikos/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/TheNeikos/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/TheNeikos/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/TheNeikos/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheNeikos/cargo/labels{/name}","releases_url":"https://api.github.com/repos/TheNeikos/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/TheNeikos/cargo/deployments","created_at":"2016-03-10T09:12:53Z","updated_at":"2016-03-10T09:12:56Z","pushed_at":"2016-03-11T17:45:26Z","git_url":"git://github.com/TheNeikos/cargo.git","ssh_url":"git@github.com:TheNeikos/cargo.git","clone_url":"https://github.com/TheNeikos/cargo.git","svn_url":"https://github.com/TheNeikos/cargo","homepage":"http://crates.io/","size":9630,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"d6e148dcd17bb747ad39c510618a97867ac9bbab","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2016-03-11T17:53:12Z","pushed_at":"2016-03-11T20:20:02Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"http://crates.io/","size":49610,"stargazers_count":1532,"watchers_count":1532,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":355,"mirror_url":null,"open_issues_count":250,"forks":355,"open_issues":250,"watchers":1532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2468"},"html":{"href":"https://github.com/rust-lang/cargo/pull/2468"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2468"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2468/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2468/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2468/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/3950bc9685ccb3e84878efbcd7fbe6f0cdfd4bd8"}}}}