{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/66753871","id":66753871,"diff_hunk":"@@ -52,7 +52,7 @@ bool CharArrayFromFormatV(char* out, int outsize, const char* format, va_list ar\n {\n     int writtenCount;\n \n-#ifdef _MSC_VER\n+#if defined(_MSC_VER) || !defined(__MINGW64__)","path":"src/common/string_util.cpp","position":14,"original_position":14,"commit_id":"1645eee8f44e260e4c37b54fa80f25d6f50882a8","original_commit_id":"1645eee8f44e260e4c37b54fa80f25d6f50882a8","user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"body":"is the negation (`!`) in `defined(__MINGW64__)` intentional? Why?\r\nIsn't this a check for Windows platforms? Shouldn't MINGW64 qualify as such?\r\n- doesn't this change behaviour for other / existing platforms (namely OSX and Linux)?","created_at":"2016-06-13T08:15:49Z","updated_at":"2016-06-13T08:15:49Z","html_url":"https://github.com/citra-emu/citra/pull/1906#discussion_r66753871","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/1906","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/66753871"},"html":{"href":"https://github.com/citra-emu/citra/pull/1906#discussion_r66753871"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1906"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/1906","id":73511468,"html_url":"https://github.com/citra-emu/citra/pull/1906","diff_url":"https://github.com/citra-emu/citra/pull/1906.diff","patch_url":"https://github.com/citra-emu/citra/pull/1906.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/1906","number":1906,"state":"open","locked":false,"title":"Add \"MinGW\" precompile","user":{"login":"yami-hack","id":11190624,"avatar_url":"https://avatars.githubusercontent.com/u/11190624?v=3","gravatar_id":"","url":"https://api.github.com/users/yami-hack","html_url":"https://github.com/yami-hack","followers_url":"https://api.github.com/users/yami-hack/followers","following_url":"https://api.github.com/users/yami-hack/following{/other_user}","gists_url":"https://api.github.com/users/yami-hack/gists{/gist_id}","starred_url":"https://api.github.com/users/yami-hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yami-hack/subscriptions","organizations_url":"https://api.github.com/users/yami-hack/orgs","repos_url":"https://api.github.com/users/yami-hack/repos","events_url":"https://api.github.com/users/yami-hack/events{/privacy}","received_events_url":"https://api.github.com/users/yami-hack/received_events","type":"User","site_admin":false},"body":"Compiler for mingw64,I don't seem to be able to do more.in TDM-GCC,\r\n1,may need to turn off icov support,construct a libpng library,some errors are external module problems.\r\n2,need Qt64(mingw64)\r\n3,need a SDL2-devel-2.0.4-mingw(need to modify the \"CMakeLists.txt\" to support SDL2-devel-2.0.4-mingw)\r\nSigned-off-by: yami-hack <yami-hack@foxmail.com>","created_at":"2016-06-12T23:57:45Z","updated_at":"2016-06-13T08:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f59b516411db017da936df51c04b01cdba8384a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/1906/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/1906/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/1906/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/1645eee8f44e260e4c37b54fa80f25d6f50882a8","head":{"label":"yami-hack:MinGw64","ref":"MinGw64","sha":"1645eee8f44e260e4c37b54fa80f25d6f50882a8","user":{"login":"yami-hack","id":11190624,"avatar_url":"https://avatars.githubusercontent.com/u/11190624?v=3","gravatar_id":"","url":"https://api.github.com/users/yami-hack","html_url":"https://github.com/yami-hack","followers_url":"https://api.github.com/users/yami-hack/followers","following_url":"https://api.github.com/users/yami-hack/following{/other_user}","gists_url":"https://api.github.com/users/yami-hack/gists{/gist_id}","starred_url":"https://api.github.com/users/yami-hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yami-hack/subscriptions","organizations_url":"https://api.github.com/users/yami-hack/orgs","repos_url":"https://api.github.com/users/yami-hack/repos","events_url":"https://api.github.com/users/yami-hack/events{/privacy}","received_events_url":"https://api.github.com/users/yami-hack/received_events","type":"User","site_admin":false},"repo":{"id":60344370,"name":"citra","full_name":"yami-hack/citra","owner":{"login":"yami-hack","id":11190624,"avatar_url":"https://avatars.githubusercontent.com/u/11190624?v=3","gravatar_id":"","url":"https://api.github.com/users/yami-hack","html_url":"https://github.com/yami-hack","followers_url":"https://api.github.com/users/yami-hack/followers","following_url":"https://api.github.com/users/yami-hack/following{/other_user}","gists_url":"https://api.github.com/users/yami-hack/gists{/gist_id}","starred_url":"https://api.github.com/users/yami-hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yami-hack/subscriptions","organizations_url":"https://api.github.com/users/yami-hack/orgs","repos_url":"https://api.github.com/users/yami-hack/repos","events_url":"https://api.github.com/users/yami-hack/events{/privacy}","received_events_url":"https://api.github.com/users/yami-hack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yami-hack/citra","description":"Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/yami-hack/citra","forks_url":"https://api.github.com/repos/yami-hack/citra/forks","keys_url":"https://api.github.com/repos/yami-hack/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yami-hack/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yami-hack/citra/teams","hooks_url":"https://api.github.com/repos/yami-hack/citra/hooks","issue_events_url":"https://api.github.com/repos/yami-hack/citra/issues/events{/number}","events_url":"https://api.github.com/repos/yami-hack/citra/events","assignees_url":"https://api.github.com/repos/yami-hack/citra/assignees{/user}","branches_url":"https://api.github.com/repos/yami-hack/citra/branches{/branch}","tags_url":"https://api.github.com/repos/yami-hack/citra/tags","blobs_url":"https://api.github.com/repos/yami-hack/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yami-hack/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yami-hack/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/yami-hack/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yami-hack/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/yami-hack/citra/languages","stargazers_url":"https://api.github.com/repos/yami-hack/citra/stargazers","contributors_url":"https://api.github.com/repos/yami-hack/citra/contributors","subscribers_url":"https://api.github.com/repos/yami-hack/citra/subscribers","subscription_url":"https://api.github.com/repos/yami-hack/citra/subscription","commits_url":"https://api.github.com/repos/yami-hack/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/yami-hack/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/yami-hack/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/yami-hack/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/yami-hack/citra/contents/{+path}","compare_url":"https://api.github.com/repos/yami-hack/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yami-hack/citra/merges","archive_url":"https://api.github.com/repos/yami-hack/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yami-hack/citra/downloads","issues_url":"https://api.github.com/repos/yami-hack/citra/issues{/number}","pulls_url":"https://api.github.com/repos/yami-hack/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/yami-hack/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/yami-hack/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yami-hack/citra/labels{/name}","releases_url":"https://api.github.com/repos/yami-hack/citra/releases{/id}","deployments_url":"https://api.github.com/repos/yami-hack/citra/deployments","created_at":"2016-06-03T11:58:06Z","updated_at":"2016-06-03T11:58:08Z","pushed_at":"2016-06-13T08:07:38Z","git_url":"git://github.com/yami-hack/citra.git","ssh_url":"git@github.com:yami-hack/citra.git","clone_url":"https://github.com/yami-hack/citra.git","svn_url":"https://github.com/yami-hack/citra","homepage":"https://citra-emu.org","size":12910,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"origin/master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"78f2b85fe6df35e3501f6dbd81ceea536fcdb8a1","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2016-06-13T06:09:51Z","pushed_at":"2016-06-13T08:07:38Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":20656,"stargazers_count":1944,"watchers_count":1944,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":463,"mirror_url":null,"open_issues_count":193,"forks":463,"open_issues":193,"watchers":1944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1906"},"html":{"href":"https://github.com/citra-emu/citra/pull/1906"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1906"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1906/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1906/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1906/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/1645eee8f44e260e4c37b54fa80f25d6f50882a8"}}}}
{"actor":{"display_login":"JayFoxRox"}}