{"action":"created","issue":{"url":"https://api.github.com/repos/rockdaboot/libpsl/issues/42","repository_url":"https://api.github.com/repos/rockdaboot/libpsl","labels_url":"https://api.github.com/repos/rockdaboot/libpsl/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/rockdaboot/libpsl/issues/42/comments","events_url":"https://api.github.com/repos/rockdaboot/libpsl/issues/42/events","html_url":"https://github.com/rockdaboot/libpsl/issues/42","id":122361079,"number":42,"title":"DAFSA needs Runtime Conversions","user":{"login":"darnir","id":1660085,"avatar_url":"https://avatars.githubusercontent.com/u/1660085?v=3","gravatar_id":"","url":"https://api.github.com/users/darnir","html_url":"https://github.com/darnir","followers_url":"https://api.github.com/users/darnir/followers","following_url":"https://api.github.com/users/darnir/following{/other_user}","gists_url":"https://api.github.com/users/darnir/gists{/gist_id}","starred_url":"https://api.github.com/users/darnir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darnir/subscriptions","organizations_url":"https://api.github.com/users/darnir/orgs","repos_url":"https://api.github.com/users/darnir/repos","events_url":"https://api.github.com/users/darnir/events{/privacy}","received_events_url":"https://api.github.com/users/darnir/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2015-12-15T20:37:48Z","updated_at":"2016-11-04T11:50:10Z","closed_at":"2015-12-26T13:23:07Z","body":"I just saw the commit cd5a11 which states that DAFSA requires runtime conversions. In light of this, can we have DAFSA as a compile time option and retain the old library code as well? For systems where you want only builtin data with no runtime conversions.\n\nWe already have all the code, it's only a matter of separating it out into #ifdef blocks\n"},"comment":{"url":"https://api.github.com/repos/rockdaboot/libpsl/issues/comments/258412058","html_url":"https://github.com/rockdaboot/libpsl/issues/42#issuecomment-258412058","issue_url":"https://api.github.com/repos/rockdaboot/libpsl/issues/42","id":258412058,"user":{"login":"liljenzin","id":14140290,"avatar_url":"https://avatars.githubusercontent.com/u/14140290?v=3","gravatar_id":"","url":"https://api.github.com/users/liljenzin","html_url":"https://github.com/liljenzin","followers_url":"https://api.github.com/users/liljenzin/followers","following_url":"https://api.github.com/users/liljenzin/following{/other_user}","gists_url":"https://api.github.com/users/liljenzin/gists{/gist_id}","starred_url":"https://api.github.com/users/liljenzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liljenzin/subscriptions","organizations_url":"https://api.github.com/users/liljenzin/orgs","repos_url":"https://api.github.com/users/liljenzin/repos","events_url":"https://api.github.com/users/liljenzin/events{/privacy}","received_events_url":"https://api.github.com/users/liljenzin/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T11:50:10Z","updated_at":"2016-11-04T11:50:10Z","body":"I have created a pull request providing UTF-8 support.\r\n\r\nGiven the input with national characters:\r\n```\r\nwww.å.se, 0\r\nwww.ä.se, 0\r\n```\r\n\r\nThe following dafsa will be generated:\r\n```\r\nL00: 0x81  # -> L01\r\nL01: 0x77  # match \"w\"\r\nL02: 0x77  # match \"w\"\r\nL03: 0x77  # match \"w\"\r\nL04: 0x2E  # match \".\"\r\nL05: 0x1F  # match multibyte prefix\r\nL06: 0xC3  # match \"C\" (Shifted UTF byte 1/2)\r\nL07: 0x02  # -> L09\r\nL08: 0x82  # -> L10\r\nL09: 0xE5  # match \"e\" (Shifted UTF byte 2/2)\r\nL10: 0x82  # -> L12\r\nL11: 0x64  # match \"d\" (Shifted UTF byte 2/2)\r\nL12: 0x2E  # match \".\"\r\nL13: 0x73  # match \"s\"\r\nL14: 0x65  # match \"e\"\r\nL15: 0x80  # return 0\r\n\r\n```\r\nThe special byte value 0x1F was not used in the original format and therefore multibyte characters will always mismatch if an old parser is used, otherwise the new format is fully compatible with an old parser and pure ASCII strings should match as before.\r\n\r\nA new parser supports the old format automatically as the new format is an extension to the old format."}}
{"actor":{"display_login":"liljenzin"}}