{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/11711","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/11711/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11711/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/11711/events","html_url":"https://github.com/openshift/origin/pull/11711","id":186614322,"number":11711,"title":"Merging jenkins plugin test templates into one","user":{"login":"jupierce","id":19783215,"avatar_url":"https://avatars.githubusercontent.com/u/19783215?v=3","gravatar_id":"","url":"https://api.github.com/users/jupierce","html_url":"https://github.com/jupierce","followers_url":"https://api.github.com/users/jupierce/followers","following_url":"https://api.github.com/users/jupierce/following{/other_user}","gists_url":"https://api.github.com/users/jupierce/gists{/gist_id}","starred_url":"https://api.github.com/users/jupierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupierce/subscriptions","organizations_url":"https://api.github.com/users/jupierce/orgs","repos_url":"https://api.github.com/users/jupierce/repos","events_url":"https://api.github.com/users/jupierce/events{/privacy}","received_events_url":"https://api.github.com/users/jupierce/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-01T18:46:30Z","updated_at":"2016-11-01T19:16:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11711","html_url":"https://github.com/openshift/origin/pull/11711","diff_url":"https://github.com/openshift/origin/pull/11711.diff","patch_url":"https://github.com/openshift/origin/pull/11711.patch"},"body":"When running locally on a developer's system, the previous Jenkins plugin test would conditionally fork and load: \r\njenkins-ephemeral-template-test-new-plugin.json\r\nor \r\njenkins-ephemeral-template-no-oauth.json\r\n\r\ndepending on whether the developer had built an image using the OpenShift Jenkins plugin PR-Testing instructions. \r\n\r\nThis implementation required that both templates be maintained -- more importantly, failure to do so was undetectable by CI testing. This problem already manifested once when the new-plugin template was not updated to specify the \"jenkins\" service account. \r\n\r\nInstructing the extended tests to target the local image will also now require an environment variable to be specified before running the tests: USE_SNAPSHOT_JENKINS_IMAGE=1 . This makes explicit the developer's desire to target the local (versus official) jenkins image. A corresponding PR in openshift/jenkins-plugin will be opened to update the README.\r\n\r\n@bparees @gabemontero ptal\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/257665402","html_url":"https://github.com/openshift/origin/pull/11711#issuecomment-257665402","issue_url":"https://api.github.com/repos/openshift/origin/issues/11711","id":257665402,"user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T19:16:53Z","updated_at":"2016-11-01T19:16:53Z","body":"On Tue, Nov 1, 2016 at 3:04 PM, Ben Parees <notifications@github.com> wrote:\n\n> *@bparees* commented on this pull request.\n> ------------------------------\n>\n> In test/extended/image_ecosystem/plugin.go\n> <https://github.com/openshift/origin/pull/11711>:\n>\n> > @@ -414,18 +417,46 @@ var _ = g.Describe(\"[image_ecosystem][jenkins][Slow] openshift pipeline plugin\",\n>  \t\tg.By(\"kick off the build for the jenkins ephermeral and application templates\")\n>  \t\ttag := []string{\"openshift/jenkins-plugin-snapshot-test:latest\"}\n>  \t\thexIDs, err := exutil.DumpAndReturnTagging(tag)\n> -\t\tvar jenkinsEphemeralPath string\n> -\t\tvar testingSnapshot bool\n> -\t\tif len(hexIDs) > 0 && err == nil {\n> -\t\t\t// found an openshift pipeline plugin test image, must be testing a proposed change to the plugin\n> -\t\t\tjenkinsEphemeralPath = exutil.FixturePath(\"testdata\", \"jenkins-ephemeral-template-test-new-plugin.json\")\n> -\t\t\ttestingSnapshot = true\n> +\n> +\t\t// If the user has expressed an interest in local plugin testing by setting the\n> +\t\t// SNAPSHOT_JENKINS_IMAGE environment variable, try to use the local image. Inform them\n> +\t\t// either about which image is being used in case their test fails.\n> +\t\tsnapshotImagePresent := len(hexIDs) > 0 && err == nil\n> +\t\tuseSnapshotImage := os.Getenv(useLocalPluginSnapshotEnvVarName) != \"\" && snapshotImagePresent\n> +\n> +\t\t//TODO disabling oauth until we can update getAdminPassword path to handle oauth (perhaps borrow from oauth integration tests)\n> +\t\tnewAppArgs := []string{exutil.FixturePath(\"testdata\", \"jenkins-ephemeral-template-no-oauth.json\")}\n>\n> we can make ENABLE_OAUTH a parameter (with a default of true) in the\n> jenkins-ephemeral(and jenkins-persistent) official templates if we wanted\n> to do this, to make it easier.\n>\nTrue, but I thought when discussed in the past we liked the env var\napporach over template parameter for other reasons.  Would this scenario be\nsufficient to change are thoughts here?\n\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/openshift/origin/pull/11711>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ADbadDcC7NY0pZK0rwFfPZaKFrK__rLlks5q540ygaJpZM4KmcB0>\n> .\n>\n"}}
{"actor":{"display_login":"gabemontero"}}