{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/58508928","id":58508928,"diff_hunk":"@@ -134,6 +137,7 @@ public void sendResponse(RestResponse response) {\n             if (!addedReleaseListener && content instanceof Releasable) {\n                 ((Releasable) content).close();\n             }\n+            transport.inFlightRequestsBreaker.addWithoutBreaking(-reservedBytes);","path":"core/src/main/java/org/elasticsearch/http/netty/NettyHttpChannel.java","position":33,"original_position":33,"commit_id":"e606ea5cb0874bc6ba262bd4ab5e403b52d1fe14","original_commit_id":"e606ea5cb0874bc6ba262bd4ab5e403b52d1fe14","user":{"login":"bleskes","id":1006375,"avatar_url":"https://avatars.githubusercontent.com/u/1006375?v=3","gravatar_id":"","url":"https://api.github.com/users/bleskes","html_url":"https://github.com/bleskes","followers_url":"https://api.github.com/users/bleskes/followers","following_url":"https://api.github.com/users/bleskes/following{/other_user}","gists_url":"https://api.github.com/users/bleskes/gists{/gist_id}","starred_url":"https://api.github.com/users/bleskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleskes/subscriptions","organizations_url":"https://api.github.com/users/bleskes/orgs","repos_url":"https://api.github.com/users/bleskes/repos","events_url":"https://api.github.com/users/bleskes/events{/privacy}","received_events_url":"https://api.github.com/users/bleskes/received_events","type":"User","site_admin":false},"body":"can we make this implement AutoClosable, call the close method from here to do all the clean up and make sure it's only closed once?","created_at":"2016-04-05T09:35:10Z","updated_at":"2016-04-05T09:35:10Z","html_url":"https://github.com/elastic/elasticsearch/pull/17133#discussion_r58508928","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/58508928"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/17133#discussion_r58508928"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133","id":63039150,"html_url":"https://github.com/elastic/elasticsearch/pull/17133","diff_url":"https://github.com/elastic/elasticsearch/pull/17133.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/17133.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/17133","number":17133,"state":"open","locked":false,"title":"Limit request size","user":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"body":"With this PR we add the possibility to limit the size of requests on multiple levels:\r\n\r\n* All in-flight requests on HTTP level, configured by `http.breaker.request.limit` (default 128 MB)\r\n* All in-flight requests on transport level, configured by `transport.breaker.request.limit` (default 128 MB)\r\n* Individual outgoing requests on transport level, configured by `transport.outgoing.request.limit`\r\n\r\nIf a limit is breached on transport level, we throw `CircuitBreakingException`, if a limit is breached on HTTP level we return HTTP 413 (request entity too large).\r\n\r\nCloses #16011","created_at":"2016-03-16T10:04:21Z","updated_at":"2016-04-05T09:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87d79eb8c2be176ad4e2668a776d064704b52a85","assignee":{"login":"bleskes","id":1006375,"avatar_url":"https://avatars.githubusercontent.com/u/1006375?v=3","gravatar_id":"","url":"https://api.github.com/users/bleskes","html_url":"https://github.com/bleskes","followers_url":"https://api.github.com/users/bleskes/followers","following_url":"https://api.github.com/users/bleskes/following{/other_user}","gists_url":"https://api.github.com/users/bleskes/gists{/gist_id}","starred_url":"https://api.github.com/users/bleskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleskes/subscriptions","organizations_url":"https://api.github.com/users/bleskes/orgs","repos_url":"https://api.github.com/users/bleskes/repos","events_url":"https://api.github.com/users/bleskes/events{/privacy}","received_events_url":"https://api.github.com/users/bleskes/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/17133/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/e606ea5cb0874bc6ba262bd4ab5e403b52d1fe14","head":{"label":"danielmitterdorfer:bulk-size-limit","ref":"bulk-size-limit","sha":"e606ea5cb0874bc6ba262bd4ab5e403b52d1fe14","user":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"repo":{"id":45385894,"name":"elasticsearch","full_name":"danielmitterdorfer/elasticsearch","owner":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars.githubusercontent.com/u/1699576?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielmitterdorfer/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch","forks_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/forks","keys_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/teams","hooks_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/events","assignees_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/tags","blobs_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/subscription","commits_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/merges","archive_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/downloads","issues_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/danielmitterdorfer/elasticsearch/deployments","created_at":"2015-11-02T09:51:30Z","updated_at":"2015-11-02T09:52:06Z","pushed_at":"2016-04-04T14:18:52Z","git_url":"git://github.com/danielmitterdorfer/elasticsearch.git","ssh_url":"git@github.com:danielmitterdorfer/elasticsearch.git","clone_url":"https://github.com/danielmitterdorfer/elasticsearch.git","svn_url":"https://github.com/danielmitterdorfer/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":206129,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"6b00b4b8dcb6f73e728bc68c529c554491d6564d","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-04-05T08:12:10Z","pushed_at":"2016-04-05T09:21:08Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":302894,"stargazers_count":15822,"watchers_count":15822,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5298,"mirror_url":null,"open_issues_count":1105,"forks":5298,"open_issues":1105,"watchers":15822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/17133"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/17133"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/17133/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/17133/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/e606ea5cb0874bc6ba262bd4ab5e403b52d1fe14"}}}}