{"action":"opened","number":766,"pull_request":{"url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/766","id":94553341,"html_url":"https://github.com/marcom-unimelb/unimelb-design-system/pull/766","diff_url":"https://github.com/marcom-unimelb/unimelb-design-system/pull/766.diff","patch_url":"https://github.com/marcom-unimelb/unimelb-design-system/pull/766.patch","issue_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/766","number":766,"state":"open","locked":false,"title":"Review management of static assets","user":{"login":"axelboc","id":2936402,"avatar_url":"https://avatars.githubusercontent.com/u/2936402?v=3","gravatar_id":"","url":"https://api.github.com/users/axelboc","html_url":"https://github.com/axelboc","followers_url":"https://api.github.com/users/axelboc/followers","following_url":"https://api.github.com/users/axelboc/following{/other_user}","gists_url":"https://api.github.com/users/axelboc/gists{/gist_id}","starred_url":"https://api.github.com/users/axelboc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelboc/subscriptions","organizations_url":"https://api.github.com/users/axelboc/orgs","repos_url":"https://api.github.com/users/axelboc/repos","events_url":"https://api.github.com/users/axelboc/events{/privacy}","received_events_url":"https://api.github.com/users/axelboc/received_events","type":"User","site_admin":false},"body":"Previously, assets were being loaded from CDN even in development. Static assets are now managed as follows:\n\n- Require assets in JS with `require(./relative/path/to/asset)`\n- Require assets in CSS with `url(./relative/path/to/asset)`\n- Do not globally require static assets from `<target-name>/target.js`\n- Let webpack's `file-loader` fill in the public path for each asset: `http://dev.url:port/assets/path/to/asset` in dev, and `https://cdn.url/shared/assets/path/to/asset` in prod.\n\nThe compiled assets must be synced/uploaded to the `shared/assets` folder of the S3 bucket. The folder structure must match that of the `build` folder. Perhaps this can be done automatically with slingshot so as to always keep the assets in sync? Perhaps the production asset paths should include the DS version - e.g. `https://cdn.url/v5.0/assets/path/to/asset` and the assets uploaded inside each version's folder on S3?","created_at":"2016-11-21T04:37:01Z","updated_at":"2016-11-21T04:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/766/commits","review_comments_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/766/comments","review_comment_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/766/comments","statuses_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/statuses/db8d3db10a02f9bb1df58fe9f17377816774dbb1","head":{"label":"marcom-unimelb:refactor-assets-loading","ref":"refactor-assets-loading","sha":"db8d3db10a02f9bb1df58fe9f17377816774dbb1","user":{"login":"marcom-unimelb","id":352236,"avatar_url":"https://avatars.githubusercontent.com/u/352236?v=3","gravatar_id":"","url":"https://api.github.com/users/marcom-unimelb","html_url":"https://github.com/marcom-unimelb","followers_url":"https://api.github.com/users/marcom-unimelb/followers","following_url":"https://api.github.com/users/marcom-unimelb/following{/other_user}","gists_url":"https://api.github.com/users/marcom-unimelb/gists{/gist_id}","starred_url":"https://api.github.com/users/marcom-unimelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcom-unimelb/subscriptions","organizations_url":"https://api.github.com/users/marcom-unimelb/orgs","repos_url":"https://api.github.com/users/marcom-unimelb/repos","events_url":"https://api.github.com/users/marcom-unimelb/events{/privacy}","received_events_url":"https://api.github.com/users/marcom-unimelb/received_events","type":"Organization","site_admin":false},"repo":{"id":16901948,"name":"unimelb-design-system","full_name":"marcom-unimelb/unimelb-design-system","owner":{"login":"marcom-unimelb","id":352236,"avatar_url":"https://avatars.githubusercontent.com/u/352236?v=3","gravatar_id":"","url":"https://api.github.com/users/marcom-unimelb","html_url":"https://github.com/marcom-unimelb","followers_url":"https://api.github.com/users/marcom-unimelb/followers","following_url":"https://api.github.com/users/marcom-unimelb/following{/other_user}","gists_url":"https://api.github.com/users/marcom-unimelb/gists{/gist_id}","starred_url":"https://api.github.com/users/marcom-unimelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcom-unimelb/subscriptions","organizations_url":"https://api.github.com/users/marcom-unimelb/orgs","repos_url":"https://api.github.com/users/marcom-unimelb/repos","events_url":"https://api.github.com/users/marcom-unimelb/events{/privacy}","received_events_url":"https://api.github.com/users/marcom-unimelb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marcom-unimelb/unimelb-design-system","description":"A complete design system for the University of Melbourne","fork":false,"url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system","forks_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/forks","keys_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/teams","hooks_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/hooks","issue_events_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/events{/number}","events_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/events","assignees_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/assignees{/user}","branches_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/branches{/branch}","tags_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/tags","blobs_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/languages","stargazers_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/stargazers","contributors_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/contributors","subscribers_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/subscribers","subscription_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/subscription","commits_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/contents/{+path}","compare_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/merges","archive_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/downloads","issues_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues{/number}","pulls_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/labels{/name}","releases_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/releases{/id}","deployments_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/deployments","created_at":"2014-02-17T04:35:38Z","updated_at":"2016-11-17T20:16:46Z","pushed_at":"2016-11-21T04:37:01Z","git_url":"git://github.com/marcom-unimelb/unimelb-design-system.git","ssh_url":"git@github.com:marcom-unimelb/unimelb-design-system.git","clone_url":"https://github.com/marcom-unimelb/unimelb-design-system.git","svn_url":"https://github.com/marcom-unimelb/unimelb-design-system","homepage":"https://web.unimelb.edu.au","size":83919,"stargazers_count":20,"watchers_count":20,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":57,"forks":9,"open_issues":57,"watchers":20,"default_branch":"master"}},"base":{"label":"marcom-unimelb:master","ref":"master","sha":"a7d8f0aefa67922a5cd1830795a04d9bc61a09cd","user":{"login":"marcom-unimelb","id":352236,"avatar_url":"https://avatars.githubusercontent.com/u/352236?v=3","gravatar_id":"","url":"https://api.github.com/users/marcom-unimelb","html_url":"https://github.com/marcom-unimelb","followers_url":"https://api.github.com/users/marcom-unimelb/followers","following_url":"https://api.github.com/users/marcom-unimelb/following{/other_user}","gists_url":"https://api.github.com/users/marcom-unimelb/gists{/gist_id}","starred_url":"https://api.github.com/users/marcom-unimelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcom-unimelb/subscriptions","organizations_url":"https://api.github.com/users/marcom-unimelb/orgs","repos_url":"https://api.github.com/users/marcom-unimelb/repos","events_url":"https://api.github.com/users/marcom-unimelb/events{/privacy}","received_events_url":"https://api.github.com/users/marcom-unimelb/received_events","type":"Organization","site_admin":false},"repo":{"id":16901948,"name":"unimelb-design-system","full_name":"marcom-unimelb/unimelb-design-system","owner":{"login":"marcom-unimelb","id":352236,"avatar_url":"https://avatars.githubusercontent.com/u/352236?v=3","gravatar_id":"","url":"https://api.github.com/users/marcom-unimelb","html_url":"https://github.com/marcom-unimelb","followers_url":"https://api.github.com/users/marcom-unimelb/followers","following_url":"https://api.github.com/users/marcom-unimelb/following{/other_user}","gists_url":"https://api.github.com/users/marcom-unimelb/gists{/gist_id}","starred_url":"https://api.github.com/users/marcom-unimelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcom-unimelb/subscriptions","organizations_url":"https://api.github.com/users/marcom-unimelb/orgs","repos_url":"https://api.github.com/users/marcom-unimelb/repos","events_url":"https://api.github.com/users/marcom-unimelb/events{/privacy}","received_events_url":"https://api.github.com/users/marcom-unimelb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marcom-unimelb/unimelb-design-system","description":"A complete design system for the University of Melbourne","fork":false,"url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system","forks_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/forks","keys_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/teams","hooks_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/hooks","issue_events_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/events{/number}","events_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/events","assignees_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/assignees{/user}","branches_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/branches{/branch}","tags_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/tags","blobs_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/languages","stargazers_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/stargazers","contributors_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/contributors","subscribers_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/subscribers","subscription_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/subscription","commits_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/contents/{+path}","compare_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/merges","archive_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/downloads","issues_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues{/number}","pulls_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/labels{/name}","releases_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/releases{/id}","deployments_url":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/deployments","created_at":"2014-02-17T04:35:38Z","updated_at":"2016-11-17T20:16:46Z","pushed_at":"2016-11-21T04:37:01Z","git_url":"git://github.com/marcom-unimelb/unimelb-design-system.git","ssh_url":"git@github.com:marcom-unimelb/unimelb-design-system.git","clone_url":"https://github.com/marcom-unimelb/unimelb-design-system.git","svn_url":"https://github.com/marcom-unimelb/unimelb-design-system","homepage":"https://web.unimelb.edu.au","size":83919,"stargazers_count":20,"watchers_count":20,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":57,"forks":9,"open_issues":57,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/766"},"html":{"href":"https://github.com/marcom-unimelb/unimelb-design-system/pull/766"},"issue":{"href":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/766"},"comments":{"href":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/marcom-unimelb/unimelb-design-system/statuses/db8d3db10a02f9bb1df58fe9f17377816774dbb1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":26,"additions":212,"deletions":1058,"changed_files":68}}
{"actor":{"display_login":"axelboc"}}