{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/75360291","id":75360291,"diff_hunk":"@@ -0,0 +1,189 @@\n+/*\n+ * Copyright (C) 2014-2015 LinkedIn Corp. All rights reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use\n+ * this file except in compliance with the License. You may obtain a copy of the\n+ * License at  http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed\n+ * under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+ * CONDITIONS OF ANY KIND, either express or implied.\n+ */\n+package gobblin.runtime.job_catalog;\n+\n+import java.io.IOException;\n+import java.net.URI;\n+import java.util.Properties;\n+\n+import org.apache.hadoop.fs.Path;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import com.google.common.annotations.VisibleForTesting;\n+import com.google.common.base.Optional;\n+import com.google.common.base.Preconditions;\n+import com.typesafe.config.Config;\n+\n+import gobblin.configuration.ConfigurationKeys;\n+import gobblin.runtime.api.JobSpec;\n+import gobblin.runtime.api.JobSpecNotFoundException;\n+import gobblin.runtime.api.MutableJobCatalog;\n+import gobblin.runtime.util.FSJobCatalogHelper;\n+import gobblin.util.ConfigUtils;\n+import gobblin.util.PathUtils;\n+import gobblin.util.filesystem.PathAlterationDetector;\n+import gobblin.util.filesystem.PathAlterationListenerAdaptor;\n+import gobblin.util.filesystem.PathAlterationObserver;\n+\n+\n+/**\n+ * The job Catalog for file system to persist the job configuration information.\n+ * This implementation has no support for caching.\n+ */\n+public class FSJobCatalog extends ImmutableFSJobCatalog implements MutableJobCatalog {\n+\n+  /**\n+   * Listeners of JobCatalog, Like GobblinInstaceDriver.\n+   * Distinguished it from JobSpec Listeners.\n+   */\n+\n+  private static final Logger LOGGER = LoggerFactory.getLogger(FSJobCatalog.class);\n+\n+  // A monitor for changes to job conf files for general FS\n+  // This embedded monitor is monitoring job configuration files instead of JobSpec Object.\n+  private final PathAlterationDetector pathAlterationDetector;","path":"gobblin-runtime/src/main/java/gobblin/runtime/job_catalog/FSJobCatalog.java","position":54,"original_position":54,"commit_id":"588b180e992c175166b6562e22113a872d8b4c23","original_commit_id":"588b180e992c175166b6562e22113a872d8b4c23","user":{"login":"ibuenros","id":1364112,"avatar_url":"https://avatars.githubusercontent.com/u/1364112?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuenros","html_url":"https://github.com/ibuenros","followers_url":"https://api.github.com/users/ibuenros/followers","following_url":"https://api.github.com/users/ibuenros/following{/other_user}","gists_url":"https://api.github.com/users/ibuenros/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuenros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuenros/subscriptions","organizations_url":"https://api.github.com/users/ibuenros/orgs","repos_url":"https://api.github.com/users/ibuenros/repos","events_url":"https://api.github.com/users/ibuenros/events{/privacy}","received_events_url":"https://api.github.com/users/ibuenros/received_events","type":"User","site_admin":false},"body":"Why do you need this here instead of superclass?","created_at":"2016-08-18T18:16:13Z","updated_at":"2016-08-18T18:16:13Z","html_url":"https://github.com/linkedin/gobblin/pull/1212#discussion_r75360291","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1212","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/75360291"},"html":{"href":"https://github.com/linkedin/gobblin/pull/1212#discussion_r75360291"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1212"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/1212","id":81726305,"html_url":"https://github.com/linkedin/gobblin/pull/1212","diff_url":"https://github.com/linkedin/gobblin/pull/1212.diff","patch_url":"https://github.com/linkedin/gobblin/pull/1212.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/1212","number":1212,"state":"open","locked":false,"title":"Refactor: FSJobCatalog V1 & V2","user":{"login":"autumnust","id":5044213,"avatar_url":"https://avatars.githubusercontent.com/u/5044213?v=3","gravatar_id":"","url":"https://api.github.com/users/autumnust","html_url":"https://github.com/autumnust","followers_url":"https://api.github.com/users/autumnust/followers","following_url":"https://api.github.com/users/autumnust/following{/other_user}","gists_url":"https://api.github.com/users/autumnust/gists{/gist_id}","starred_url":"https://api.github.com/users/autumnust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autumnust/subscriptions","organizations_url":"https://api.github.com/users/autumnust/orgs","repos_url":"https://api.github.com/users/autumnust/repos","events_url":"https://api.github.com/users/autumnust/events{/privacy}","received_events_url":"https://api.github.com/users/autumnust/received_events","type":"User","site_admin":false},"body":"Verison 2 of FSjobcatalog based on refactored SchedulerUtils.(Moving some of the functions into FSjobCatalogLoadingHelper )\r\n\r\nClose the original PR. \r\n\r\nThis one is cleaner to review. Please take a look at @ibuenros , Thanks. ","created_at":"2016-08-17T22:11:19Z","updated_at":"2016-08-18T18:16:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d53bba197345a941e21b6dce718fe9282cfd5c3c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1212/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1212/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/1212/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/588b180e992c175166b6562e22113a872d8b4c23","head":{"label":"autumnust:v2fsjobcatlog","ref":"v2fsjobcatlog","sha":"588b180e992c175166b6562e22113a872d8b4c23","user":{"login":"autumnust","id":5044213,"avatar_url":"https://avatars.githubusercontent.com/u/5044213?v=3","gravatar_id":"","url":"https://api.github.com/users/autumnust","html_url":"https://github.com/autumnust","followers_url":"https://api.github.com/users/autumnust/followers","following_url":"https://api.github.com/users/autumnust/following{/other_user}","gists_url":"https://api.github.com/users/autumnust/gists{/gist_id}","starred_url":"https://api.github.com/users/autumnust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autumnust/subscriptions","organizations_url":"https://api.github.com/users/autumnust/orgs","repos_url":"https://api.github.com/users/autumnust/repos","events_url":"https://api.github.com/users/autumnust/events{/privacy}","received_events_url":"https://api.github.com/users/autumnust/received_events","type":"User","site_admin":false},"repo":{"id":60211282,"name":"gobblin","full_name":"autumnust/gobblin","owner":{"login":"autumnust","id":5044213,"avatar_url":"https://avatars.githubusercontent.com/u/5044213?v=3","gravatar_id":"","url":"https://api.github.com/users/autumnust","html_url":"https://github.com/autumnust","followers_url":"https://api.github.com/users/autumnust/followers","following_url":"https://api.github.com/users/autumnust/following{/other_user}","gists_url":"https://api.github.com/users/autumnust/gists{/gist_id}","starred_url":"https://api.github.com/users/autumnust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autumnust/subscriptions","organizations_url":"https://api.github.com/users/autumnust/orgs","repos_url":"https://api.github.com/users/autumnust/repos","events_url":"https://api.github.com/users/autumnust/events{/privacy}","received_events_url":"https://api.github.com/users/autumnust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/autumnust/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":true,"url":"https://api.github.com/repos/autumnust/gobblin","forks_url":"https://api.github.com/repos/autumnust/gobblin/forks","keys_url":"https://api.github.com/repos/autumnust/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autumnust/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autumnust/gobblin/teams","hooks_url":"https://api.github.com/repos/autumnust/gobblin/hooks","issue_events_url":"https://api.github.com/repos/autumnust/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/autumnust/gobblin/events","assignees_url":"https://api.github.com/repos/autumnust/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/autumnust/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/autumnust/gobblin/tags","blobs_url":"https://api.github.com/repos/autumnust/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autumnust/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autumnust/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/autumnust/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autumnust/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/autumnust/gobblin/languages","stargazers_url":"https://api.github.com/repos/autumnust/gobblin/stargazers","contributors_url":"https://api.github.com/repos/autumnust/gobblin/contributors","subscribers_url":"https://api.github.com/repos/autumnust/gobblin/subscribers","subscription_url":"https://api.github.com/repos/autumnust/gobblin/subscription","commits_url":"https://api.github.com/repos/autumnust/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/autumnust/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/autumnust/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/autumnust/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/autumnust/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/autumnust/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autumnust/gobblin/merges","archive_url":"https://api.github.com/repos/autumnust/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autumnust/gobblin/downloads","issues_url":"https://api.github.com/repos/autumnust/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/autumnust/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/autumnust/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/autumnust/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autumnust/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/autumnust/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/autumnust/gobblin/deployments","created_at":"2016-06-01T21:14:50Z","updated_at":"2016-06-01T21:14:55Z","pushed_at":"2016-08-18T18:08:52Z","git_url":"git://github.com/autumnust/gobblin.git","ssh_url":"git@github.com:autumnust/gobblin.git","clone_url":"https://github.com/autumnust/gobblin.git","svn_url":"https://github.com/autumnust/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":94049,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"13a37da4d404ecd906368434aac0cab5e944c8b3","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2016-08-18T14:47:50Z","pushed_at":"2016-08-18T18:08:53Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":176372,"stargazers_count":674,"watchers_count":674,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":269,"mirror_url":null,"open_issues_count":114,"forks":269,"open_issues":114,"watchers":674,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1212"},"html":{"href":"https://github.com/linkedin/gobblin/pull/1212"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/1212"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/1212/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1212/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1212/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/588b180e992c175166b6562e22113a872d8b4c23"}}}}
{"actor":{"display_login":"ibuenros"}}