{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/81606292","pull_request_review_id":2573958,"id":81606292,"diff_hunk":"@@ -0,0 +1,85 @@\n+﻿// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System.Reflection;\n+using Xunit;\n+\n+namespace System.IO.IsolatedStorage\n+{\n+    public class ContainsUnknownFilesTests : IsoStorageTest\n+    {\n+        private static MethodInfo s_containsUnknownFilesMethod;\n+\n+        static ContainsUnknownFilesTests()\n+        {\n+            s_containsUnknownFilesMethod = typeof(IsolatedStorageFile).GetMethod(\"ContainsUnknownFiles\", BindingFlags.NonPublic | BindingFlags.Instance);\n+        }\n+\n+        [Theory MemberData(\"ValidStores\")]\n+        public void ContainsUnknownFiles_CleanStore(PresetScopes scope)\n+        {\n+            TestHelper.WipeStores();","path":"src/System.IO.IsolatedStorage/tests/System/IO/IsolatedStorage/ContainsUnknownFilesTests.cs","position":22,"original_position":22,"commit_id":"4dccea6d1fdd4ecd76bd39864644222d15607c0f","original_commit_id":"4dccea6d1fdd4ecd76bd39864644222d15607c0f","user":{"login":"JeremyKuhne","id":8184940,"avatar_url":"https://avatars.githubusercontent.com/u/8184940?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false},"body":"Most tests don't care. I want to leave the overall state clean at the end of tests (fixture is the only way to do this without writing custom runners) but not wipe everything every single test / test class.","created_at":"2016-10-03T18:07:12Z","updated_at":"2016-10-03T18:07:12Z","html_url":"https://github.com/dotnet/corefx/pull/12261#discussion_r81606292","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/12261","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/81606292"},"html":{"href":"https://github.com/dotnet/corefx/pull/12261#discussion_r81606292"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12261"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/12261","id":87577763,"html_url":"https://github.com/dotnet/corefx/pull/12261","diff_url":"https://github.com/dotnet/corefx/pull/12261.diff","patch_url":"https://github.com/dotnet/corefx/pull/12261.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/12261","number":12261,"state":"open","locked":false,"title":"Tests and Fixes for IsoStorage","user":{"login":"JeremyKuhne","id":8184940,"avatar_url":"https://avatars.githubusercontent.com/u/8184940?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false},"body":"-Implement more tests and establish patterns\r\n-Fixes IsolatedStorageFileStream construction\r\n-Fixes root folder generation\r\n\r\n@ericstj, @ianhays, @weshaggard \r\n\r\nI have a lot more tests to write, but I want to get this step through as it does some important stuff for FileStream wrapping that I want to get feedback on (the 1.0 impl was fundamentally broken- see the code comments). Thanks.","created_at":"2016-09-30T22:47:10Z","updated_at":"2016-10-03T18:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dce639077119d497ea3e24b7db70037c94a25f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/12261/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/12261/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12261/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/4dccea6d1fdd4ecd76bd39864644222d15607c0f","head":{"label":"JeremyKuhne:moreisotests","ref":"moreisotests","sha":"4dccea6d1fdd4ecd76bd39864644222d15607c0f","user":{"login":"JeremyKuhne","id":8184940,"avatar_url":"https://avatars.githubusercontent.com/u/8184940?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false},"repo":{"id":30339123,"name":"corefx","full_name":"JeremyKuhne/corefx","owner":{"login":"JeremyKuhne","id":8184940,"avatar_url":"https://avatars.githubusercontent.com/u/8184940?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JeremyKuhne/corefx","description":"This repo contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/JeremyKuhne/corefx","forks_url":"https://api.github.com/repos/JeremyKuhne/corefx/forks","keys_url":"https://api.github.com/repos/JeremyKuhne/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeremyKuhne/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeremyKuhne/corefx/teams","hooks_url":"https://api.github.com/repos/JeremyKuhne/corefx/hooks","issue_events_url":"https://api.github.com/repos/JeremyKuhne/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/JeremyKuhne/corefx/events","assignees_url":"https://api.github.com/repos/JeremyKuhne/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/JeremyKuhne/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/JeremyKuhne/corefx/tags","blobs_url":"https://api.github.com/repos/JeremyKuhne/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeremyKuhne/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeremyKuhne/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeremyKuhne/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeremyKuhne/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/JeremyKuhne/corefx/languages","stargazers_url":"https://api.github.com/repos/JeremyKuhne/corefx/stargazers","contributors_url":"https://api.github.com/repos/JeremyKuhne/corefx/contributors","subscribers_url":"https://api.github.com/repos/JeremyKuhne/corefx/subscribers","subscription_url":"https://api.github.com/repos/JeremyKuhne/corefx/subscription","commits_url":"https://api.github.com/repos/JeremyKuhne/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeremyKuhne/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeremyKuhne/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeremyKuhne/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/JeremyKuhne/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/JeremyKuhne/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeremyKuhne/corefx/merges","archive_url":"https://api.github.com/repos/JeremyKuhne/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeremyKuhne/corefx/downloads","issues_url":"https://api.github.com/repos/JeremyKuhne/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/JeremyKuhne/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/JeremyKuhne/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/JeremyKuhne/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeremyKuhne/corefx/labels{/name}","releases_url":"https://api.github.com/repos/JeremyKuhne/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/JeremyKuhne/corefx/deployments","created_at":"2015-02-05T05:16:58Z","updated_at":"2016-01-14T21:00:40Z","pushed_at":"2016-10-01T00:06:01Z","git_url":"git://github.com/JeremyKuhne/corefx.git","ssh_url":"git@github.com:JeremyKuhne/corefx.git","clone_url":"https://github.com/JeremyKuhne/corefx.git","svn_url":"https://github.com/JeremyKuhne/corefx","homepage":"","size":99707,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5155f8e6032850e12bebd9c27a745c7c931020f9","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-10-03T12:42:32Z","pushed_at":"2016-10-03T18:02:32Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":146247,"stargazers_count":10597,"watchers_count":10597,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2648,"mirror_url":null,"open_issues_count":1535,"forks":2648,"open_issues":1535,"watchers":10597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12261"},"html":{"href":"https://github.com/dotnet/corefx/pull/12261"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12261"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12261/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12261/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12261/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/4dccea6d1fdd4ecd76bd39864644222d15607c0f"}}}}
{"actor":{"display_login":"JeremyKuhne"}}