{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8601","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8601/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8601/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8601/events","html_url":"https://github.com/nodejs/node/pull/8601","id":177566878,"number":8601,"title":"Raise a warning when listening for usafe signals","user":{"login":"quibusus","id":965671,"avatar_url":"https://avatars.githubusercontent.com/u/965671?v=3","gravatar_id":"","url":"https://api.github.com/users/quibusus","html_url":"https://github.com/quibusus","followers_url":"https://api.github.com/users/quibusus/followers","following_url":"https://api.github.com/users/quibusus/following{/other_user}","gists_url":"https://api.github.com/users/quibusus/gists{/gist_id}","starred_url":"https://api.github.com/users/quibusus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quibusus/subscriptions","organizations_url":"https://api.github.com/users/quibusus/orgs","repos_url":"https://api.github.com/users/quibusus/repos","events_url":"https://api.github.com/users/quibusus/events{/privacy}","received_events_url":"https://api.github.com/users/quibusus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"bfdadc"},{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v7.x","name":"dont-land-on-v7.x","color":"fbca04"},{"url":"https://api.github.com/repos/nodejs/node/labels/process","name":"process","color":"00aaff"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-17T09:47:08Z","updated_at":"2016-09-25T09:29:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8601","html_url":"https://github.com/nodejs/node/pull/8601","diff_url":"https://github.com/nodejs/node/pull/8601.diff","patch_url":"https://github.com/nodejs/node/pull/8601.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x ] `make -j4 test` (UNIX)\r\n- [x ] tests and/or benchmarks are included\r\n- [nodejs/node#8410] documentation is changed or added \r\n- [ x] commit message follows commit guidelines\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\nWe might want to emit a warning for signals that users shouldn’t listen on (as listed in the docs warning in nodejs/node#8410)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/249411930","html_url":"https://github.com/nodejs/node/pull/8601#issuecomment-249411930","issue_url":"https://api.github.com/repos/nodejs/node/issues/8601","id":249411930,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2016-09-25T09:29:28Z","updated_at":"2016-09-25T09:29:28Z","body":"> If I understand correctly, this is safe if you use `EventEmitter#once`? I don't think there is a good way to detect that unfortunately.\r\n\r\nIt isn’t, and the current code *does* warn when `#once` is being used, too."}}
{"actor":{"display_login":"addaleax"}}