{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/149","repository_url":"https://api.github.com/repos/Azure/acs-engine","labels_url":"https://api.github.com/repos/Azure/acs-engine/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/149/comments","events_url":"https://api.github.com/repos/Azure/acs-engine/issues/149/events","html_url":"https://github.com/Azure/acs-engine/pull/149","id":195891789,"number":149,"title":"Fix #116 - Name the `kubelet` container when starting","user":{"login":"jpoon","id":85374,"avatar_url":"https://avatars.githubusercontent.com/u/85374?v=3","gravatar_id":"","url":"https://api.github.com/users/jpoon","html_url":"https://github.com/jpoon","followers_url":"https://api.github.com/users/jpoon/followers","following_url":"https://api.github.com/users/jpoon/following{/other_user}","gists_url":"https://api.github.com/users/jpoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpoon/subscriptions","organizations_url":"https://api.github.com/users/jpoon/orgs","repos_url":"https://api.github.com/users/jpoon/repos","events_url":"https://api.github.com/users/jpoon/events{/privacy}","received_events_url":"https://api.github.com/users/jpoon/received_events","type":"User","site_admin":false},"labels":[{"id":482553557,"url":"https://api.github.com/repos/Azure/acs-engine/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-15T19:20:58Z","updated_at":"2016-12-15T22:54:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/149","html_url":"https://github.com/Azure/acs-engine/pull/149","diff_url":"https://github.com/Azure/acs-engine/pull/149.diff","patch_url":"https://github.com/Azure/acs-engine/pull/149.patch"},"body":"Fixes #116 by naming the container. Sorry about breaking it before @colemickens. This time around, I deployed, tested, and validated this change on my own cluster and it all works fine. "},"comment":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/comments/267468569","html_url":"https://github.com/Azure/acs-engine/pull/149#issuecomment-267468569","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/149","id":267468569,"user":{"login":"jpoon","id":85374,"avatar_url":"https://avatars.githubusercontent.com/u/85374?v=3","gravatar_id":"","url":"https://api.github.com/users/jpoon","html_url":"https://github.com/jpoon","followers_url":"https://api.github.com/users/jpoon/followers","following_url":"https://api.github.com/users/jpoon/following{/other_user}","gists_url":"https://api.github.com/users/jpoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpoon/subscriptions","organizations_url":"https://api.github.com/users/jpoon/orgs","repos_url":"https://api.github.com/users/jpoon/repos","events_url":"https://api.github.com/users/jpoon/events{/privacy}","received_events_url":"https://api.github.com/users/jpoon/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T22:54:12Z","updated_at":"2016-12-15T22:54:12Z","body":"I'd slightly prefer the `ExecStop` method as it's a tad more graceful giving kubelet a couple seconds to shutdown before killing the process. Researching the 143 error, it seems expected as the exit code implies the application was killed with a SIGTERM.\r\n\r\nThe end result of both cases is the same and as the impact is fairly minimal in both regard, let me know if you want me to update the PR deleting the `ExecStop` altogether. "}}
{"actor":{"display_login":"jpoon"}}