{"push_id":1420536221,"size":103,"distinct_size":0,"ref":"refs/heads/master","head":"2f73982c215b6573bfa59e5a89471aedbd7c211a","before":"3a558aa2bc8ce3834ee79ff3346bcf5d7debbbd0","commits":[{"sha":"2bf7c30049558c2503f20e9810fdf4727650fe99","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Should except `:distinct` rather than `:order` for `exists?`\n\nRecords fetching order is very important for performance if `limit` is\npresented. Should not except the order in the case.\n\nAnd `exists?` replaces select list to `1 AS one` therefore `:distinct`\nis useless (`DISTINCT 1 AS one`). And PostgreSQL raises the following\nerror if `:distinct` and `:order` are used in the same time.\n\n```\nERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list\n```","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/2bf7c30049558c2503f20e9810fdf4727650fe99"},{"sha":"0ec967aa6655d62c92f72acb8d556a5b3f70762d","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Respect new records for `CollectionProxy#uniq`\n\nCurrently if `CollectionProxy` has more than one new record,\n`CollectionProxy#uniq` result is incorrect.\n\nAnd `CollectionProxy#uniq` was aliased to `distinct` in a1bb6c8b06db.\nBut the `uniq` method and the `SELECT DISTINCT` method are different\nmethods. The doc in `CollectionProxy` is for the `SELECT DISTINCT`\nmethod, not for the `uniq` method.\n\nTherefore, reverting the alias in `CollectionProxy` to fix the\ninconsistency and to have the both methods.","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/0ec967aa6655d62c92f72acb8d556a5b3f70762d"},{"sha":"b388ca41d8b26f027a43e96c5ad0950a6bf2f5d7","author":{"name":"Artem Rashev","email":"036c063760921dd6c720c3afeb9602bc31043cef@gmail.com"},"message":"Fixed CONTENT_LENGTH header in ActionController::TestRequest\n\nCONENT_LENGTH setted by string length, which is equal to number of\ncharacters in string but StringIO.length is byte sequence and\nwhen payload contains non-ASCII characters, stream's length will be\ndifferent. That's why real byte length should be used for CONTENT_LENGTH\nheader.\n\nAdd unit test for CONTENT_LENGTH header fix\n\nIt just passes non-ascii symbols as parameters and verifies that\n\"CONTENT_LENGTH\" header has content bytes count as value.","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/b388ca41d8b26f027a43e96c5ad0950a6bf2f5d7"},{"sha":"7c1b14f04158102f68610128ae230941e85263a3","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Refactor `NullRelation#calculate`\n\nBefore:\n\n```ruby\n    def calculate(operation, _column_name)\n      if [:count, :sum].include? operation\n        group_values.any? ? Hash.new : 0\n      elsif [:average, :minimum, :maximum].include?(operation) && group_values.any?\n        Hash.new\n      else\n        nil\n      end\n    end\n```\n\nAfter:\n\n```ruby\n    def calculate(operation, _column_name)\n      case operation\n      when :count, :sum\n        group_values.any? ? Hash.new : 0\n      when :average, :minimum, :maximum\n        group_values.any? ? Hash.new : nil\n      end\n    end\n```","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/7c1b14f04158102f68610128ae230941e85263a3"},{"sha":"6e692e6e5bb90fbaf1524429139daa9bd1c4f990","author":{"name":"Sean Griffin","email":"745a5948f3a29be7b294faa8063f9998c214afbb@seantheprogrammer.com"},"message":"Merge pull request #27054 from kamipo/null_relation_calculate\n\nRefactor `NullRelation#calculate`","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/6e692e6e5bb90fbaf1524429139daa9bd1c4f990"},{"sha":"326147045262c49d0389c5a275570cb913a1a03b","author":{"name":"Kir Shatrov","email":"be0e345f4bbe70da8dad69f79b03e798a3cd4fd1@me.com"},"message":"Fix testing isolation\n\nAS::Testing::Isolation has two ways to isolate the process:\nforking and subprocessing. The second way is used on JRuby and other\nplatforms that don't support forking.\n\nThe way how subprocessing works is that we prepare a command to run a\nnew process:\n\n```\n/opt/rubies/2.3.0/bin/ruby -I{skipped_load_path} test/initializable_test.rb '' -nInitializableTests::Basic#test_Initializer_provides_context's_class_name\n```\n\nAs you see, there's unescaped quote at the end of the line.\nIt leads to:\n\n```\nsh: -c: line 0: unexpected EOF while looking for matching `''\nsh: -c: line 1: syntax error: unexpected end of file\n```\n\nThis fixes tests on MRI + NO_FORK variable and on JRuby :tada:","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/326147045262c49d0389c5a275570cb913a1a03b"},{"sha":"0a8b212db76441df29a572580f1dab596d28d73d","author":{"name":"Jon Moss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@jonathanmoss.me"},"message":"Support AC::Parameters for PG HStore\n\nAs reported via #26904, there is a regression in how values for\nPostgres' HStore column type are being processed, beginning in Rails 5.\nCurrently, the way that Active Record checks whether or not values need\nto be serialized and put into the correct storage format is whether or\nnot it is a `Hash` object. Since `ActionController::Parameters` no\nlonger inherits from `Hash` in Rails 5, this conditional now returns\nfalse. To remedy this, we are now checking to see whether the `value`\nparameters being passed in responds to a certain method, and then\ncalling the `serialize` method, except this time with a real Hash\nobject. Keeping things DRY!\n\nFixes #26904.","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/0a8b212db76441df29a572580f1dab596d28d73d"},{"sha":"bce3d1f8c01a125ef56d82967cb23daa258bb58d","author":{"name":"Jon Moss","email":"2eeef3d59d27c3e6e88c30bec376fd27d674a502@users.noreply.github.com"},"message":"Merge pull request #27058 from maclover7/jm-fix-26904\n\nSupport AC::Parameters for PG HStore","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/bce3d1f8c01a125ef56d82967cb23daa258bb58d"},{"sha":"c2c6b7be23126834b01273bfa95f90dac06513f6","author":{"name":"Guillermo Iguaran","email":"d646716c9f186b7dabede70ff3a4ad11f2687bb5@gmail.com"},"message":"Merge pull request #27056 from kirs/fix-testing-isolation\n\nFix testing isolation","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/c2c6b7be23126834b01273bfa95f90dac06513f6"},{"sha":"3b2346ea1393ad5deb049ae071116773c602ddc0","author":{"name":"Yves Senn","email":"45b0750c2c8f66ea58d01da52f1a0ee0448093b8@gmail.com"},"message":"docs, add `update_all` example with SQL fragment. [ci skip]\n\nThe relation method `update_all` allows you to pass a SQL fragment. The\nfunctionality is already mentioned in the prose but the examples section\ndoes not cover it.","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/3b2346ea1393ad5deb049ae071116773c602ddc0"},{"sha":"8e239fa712a03853ae661935f0c8c8af4bc13a6f","author":{"name":"Koichi ITO","email":"710d7b1878652604e93043a95716c999b31b8376@gmail.com"},"message":"Run tests by Ruby 2.2.6 and 2.3.2","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/8e239fa712a03853ae661935f0c8c8af4bc13a6f"},{"sha":"226b8451130ecd4448f7870da8321c87676ad3d6","author":{"name":"Jonathan Hyman","email":"f2c80f66d771b080a2015a92cca9a9a2e0762269@post.harvard.edu"},"message":"Removes 'raw: true' from MemCacheStore#read_multi, per https://github.com/rails/rails/issues/27066.","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/226b8451130ecd4448f7870da8321c87676ad3d6"},{"sha":"c061236cc7e03ec6c8f71f1b166251cc63377417","author":{"name":"Maxime Boisvert","email":"8d027b51f83fb40ae952c5dc019733fd3a5d6b62@shopify.com"},"message":"Use named parameters instead of `assert_valid_keys`","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/c061236cc7e03ec6c8f71f1b166251cc63377417"},{"sha":"780aaf1f10f48f9303ba342709a3f646b11d5855","author":{"name":"Jon Moss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@jonathanmoss.me"},"message":"Enable JRuby testing for Action Mailer\n\nAll tests passing locally for me:\n\n```\n195 runs, 441 assertions, 0 failures, 0 errors, 0 skips\n```","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/780aaf1f10f48f9303ba342709a3f646b11d5855"},{"sha":"1dcfe9823543f1baec4a2f08674ff8c82e632067","author":{"name":"Rafael França","email":"34336d1352eb57c00d6c738f78075df0d11314db@gmail.com"},"message":"Merge pull request #27074 from maclover7/jm-jruby-actionmailer\n\nEnable JRuby testing for Action Mailer","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/1dcfe9823543f1baec4a2f08674ff8c82e632067"},{"sha":"84c58ced4611a855f1a0c0d3b54389b95a27b858","author":{"name":"Rafael França","email":"34336d1352eb57c00d6c738f78075df0d11314db@gmail.com"},"message":"Merge pull request #27064 from koic/bump_ruby_versions\n\nRun tests by Ruby 2.2.6 and 2.3.2","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/84c58ced4611a855f1a0c0d3b54389b95a27b858"},{"sha":"27210f1dd2031f03ad13dbb4001838de217514f4","author":{"name":"Rafael França","email":"34336d1352eb57c00d6c738f78075df0d11314db@gmail.com"},"message":"Merge pull request #27072 from maxboisvert/use_named_parameters_in_assert_enqueued_with\n\nUse named parameters instead of `assert_valid_keys` in active_job/test_helper","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/27210f1dd2031f03ad13dbb4001838de217514f4"},{"sha":"9140c11fcb2e418fe833aaf02a2e5fb10dcf9f30","author":{"name":"Jon Moss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@jonathanmoss.me"},"message":"Enable JRuby testing for Active Job\n\nAll tests pass for me locally.","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/9140c11fcb2e418fe833aaf02a2e5fb10dcf9f30"},{"sha":"2694a74c88bb7923dbfe4ce3e1b64a6f23dab0ef","author":{"name":"Jon Moss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@jonathanmoss.me"},"message":"Make JRUBY_OPTS a global Travis environment variable","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/2694a74c88bb7923dbfe4ce3e1b64a6f23dab0ef"},{"sha":"7f86429a825b46960e9f2212ab040e952ea43613","author":{"name":"Rafael França","email":"34336d1352eb57c00d6c738f78075df0d11314db@gmail.com"},"message":"Merge pull request #27075 from maclover7/jm-jruby-activejob\n\nEnable JRuby testing for Active Job","distinct":false,"url":"https://api.github.com/repos/mtsmfm/railstest/commits/7f86429a825b46960e9f2212ab040e952ea43613"}]}
{"actor":{"display_login":"mtsmfm"}}