{"action":"created","comment":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/84774794","pull_request_review_id":5531319,"id":84774794,"diff_hunk":"@@ -32,10 +32,34 @@\n \n \tattempt_devour(L, eat_types, mouth_size)\n \n-/*\n-/mob/living/verb/devourverb(var/mob/living/victim)//For situations where species inherent verbs isnt suitable\n-\tset category = \"Abilities\"\n-\tset name = \"Devour Creature\"\n-\tset desc = \"Attempt to eat a nearby creature, swallowing it whole if small enough, or eating it piece by piece otherwise\"\n-\tattempt_devour(victim, eat_types, mouth_size)\n-*/\n\\ No newline at end of file\n+/mob/living/verb/set_walk_speed()\n+\tset category = \"IC\"\n+\tset name = \"Adjust walk speed\"\n+\tset desc = \"Allows you to adjust your walking speed to a slower value than normal, or reset it. Does not make you faster.\"\n+\n+\n+\t//First a quick block of code to calculate our normal/best movedelay\n+\tvar/delay = config.walk_speed + movement_delay()\n+\tvar/speed = 1 / (delay/10)\n+\tvar/newspeed\n+\tvar/list/options = list(\"No limit\",speed*0.95,speed*0.9,speed*0.85,speed*0.8,speed*0.7,speed*0.6,speed*0.5, \"Custom\")\n+\n+\n+\tvar/response = input(src, \"Your current walking speed is [speed] tiles per second. This menu allows you to limit it to a lower value, by applying a multiplier to that. Please choose a value, select custom to enter your own, or No limit to set your walk speed to the maximum. This menu will not make you move any faster than usual, it is only for allowing you to move at a slower pace than normal, for roleplay purposes. Values set here will not affect your sprinting speed\", \"Limit Walking speed\") as null|anything in options\n+\tif (response == \"No limit\")\n+\t\tsrc << \"Movement speed has now been set to normal, limits removed.\"\n+\t\tsrc.min_walk_delay = 0\n+\t\treturn\n+\telse if (response == \"Custom\")\n+\t\tresponse = input(src, \"Please enter the exact speed you want to walk at, in tiles per second. This value must be less than [speed] and greater than zero\", \"Limit Walking speed\") as num\n+\t\tnewspeed = response\n+\telse","path":"code/modules/mob/living/living_powers.dm","position":33,"original_position":33,"commit_id":"8600e555048ca45b6f46e3c04ac095a8c4b58294","original_commit_id":"919a2f3422651fc8e7f4b46b503b08a7c8a30f2f","user":{"login":"NanakoAC","id":18094775,"avatar_url":"https://avatars.githubusercontent.com/u/18094775?v=3","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"body":"fixing","created_at":"2016-10-24T20:22:24Z","updated_at":"2016-10-24T20:22:24Z","html_url":"https://github.com/Aurorastation/Aurora.3/pull/1030#discussion_r84774794","pull_request_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030","_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/84774794"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/1030#discussion_r84774794"},"pull_request":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030"}}},"pull_request":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030","id":87605151,"html_url":"https://github.com/Aurorastation/Aurora.3/pull/1030","diff_url":"https://github.com/Aurorastation/Aurora.3/pull/1030.diff","patch_url":"https://github.com/Aurorastation/Aurora.3/pull/1030.patch","issue_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/1030","number":1030,"state":"open","locked":false,"title":"Sprinting, Stamina and Temporary Modifiers","user":{"login":"NanakoAC","id":18094775,"avatar_url":"https://avatars.githubusercontent.com/u/18094775?v=3","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"body":"First draft of a major new feature, in need of feedback and playtesting.\r\nNot quite perfected yet\r\n\r\nIMPORTANT\r\nIn order to work as intended, this also requires some changes to the walk speed and human move delay in config files. I'm currently using:\r\nWALK_SPEED  4\r\nHUMAN_DELAY 2.5\r\n\r\nThese are both found in game_options.txt\r\n\r\nIn addition, Tickcompensation has been disabled. As per a discussion with skull, he believed it was already disabled, but it actually was active. The fact that he believed it wasn't is evidence of its worthlessness as a feature, and i think movement is smoother without it.\r\n\r\nAs per the description, Tickcomp 'attempts' to smooth out movement. I contend that it utterly fails in this attempt. All it does is add a small, flat value to every movement step, and it serves no purpose but to slow down movement without any smoothing. We may be well served trying to improve it to use some lag-dependant variable like tick usage in future. But for now it breaks the sprinting system by damping high speeds too much.\r\n\r\n**Main changes:**\r\n\r\nWalk speed increased to match what we currently know as 'run', and made the default movement mode.\r\n\r\nRun mode has been changed into a limited high speed sprinting mode. Sprinting works slightly differently for each species, and is intended to be balanced asymmetrically:\r\n\r\nHumans have the largest stamina pool, and can run for longest. We evolved as endurance hunters\r\nUnathi have the smallest stamina pool, but the fastest sprint speed. Their sprint is a shortranged burst evolved for surprising prey\r\nTajarans have very poor sprinting., sprinting is a waste of energy and they evolved to maintain a steady pace and conserve energy in their wintery homeworld.\r\nSkrell are intellectuals and have evolved a reduced need for physical prowess, theyre slightly better than tajarans but still subpar\r\nVaurca sprinting for now is just slightly faster than humans, may need some creative input.\r\nIPCs, being created by and in the image of humans, have almost the same sprinting speed. As machines they have no stamina, but they will overheat and consume power rapidly while sprinting.\r\nDiona remain poderous, they have the slowest sprint speed of all, and their sprinting consumes stored light energy and radiation,  rather than stamina\r\n\r\nWhenever anyone reaches their limit, they will automatically drop to walk speed, and usually collapse in pain or some approximation of it. IPCs are punished far more by this, they take a full minute to initialise emergency backup power\r\n\r\nFor most organic species, the limit isn't the end o the stamina pool. When stamina runs out they'll start taking suffocation damage up to a point and then collapse.\r\n\r\nIn addition, when in sprint mode, the run button flashes a colour, gradiating between green/yellow/orange/red to indicate remaining stamina. Sprinting while its red will hurt. \r\nThe best way i could find to do this, since overlay images can't really be updated, is repeatedly removing and re-adding the overlay at the new colour while sprinting. This is quite a performance intensive process, but i think its acceptable given the limited nature of sprinting\r\n\r\nAlso added a walkspeed limiting, allowing the user to precisely select or input a limit for their walking speed. This allows fast people to slow down, or for people to roleplay slowness, limping and injury. Check IC tab or altclick run/walk button\r\n\r\nThis PR also adds the first iteration of my new Modifiers code, a system designed to add temporary, reversible changes to anything. Its used so far to add three effects for chemicals which would have been hard to do robustly without such a system.\r\n\r\nThe effects added for it, give some move/sprintspeed and stamina interactions to several chemicals - inaprovaline, synaptizine, hyperzine, alcohol, and caffienated drinks of all varieties. The effects within a category (EG, stimulants from caffiene and hyperzine) don't stack with each other, only the strongest application of that effect is applied","created_at":"2016-10-01T15:24:38Z","updated_at":"2016-10-24T20:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6c261c563d3652b4cac5d8060fa7d5867974fc4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030/commits","review_comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030/comments","review_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/1030/comments","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/8600e555048ca45b6f46e3c04ac095a8c4b58294","head":{"label":"NanakoAC:Sprinting","ref":"Sprinting","sha":"8600e555048ca45b6f46e3c04ac095a8c4b58294","user":{"login":"NanakoAC","id":18094775,"avatar_url":"https://avatars.githubusercontent.com/u/18094775?v=3","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"repo":{"id":59347611,"name":"Aurora.3","full_name":"NanakoAC/Aurora.3","owner":{"login":"NanakoAC","id":18094775,"avatar_url":"https://avatars.githubusercontent.com/u/18094775?v=3","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NanakoAC/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/NanakoAC/Aurora.3","forks_url":"https://api.github.com/repos/NanakoAC/Aurora.3/forks","keys_url":"https://api.github.com/repos/NanakoAC/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NanakoAC/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NanakoAC/Aurora.3/teams","hooks_url":"https://api.github.com/repos/NanakoAC/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/NanakoAC/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/NanakoAC/Aurora.3/events","assignees_url":"https://api.github.com/repos/NanakoAC/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/NanakoAC/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/NanakoAC/Aurora.3/tags","blobs_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NanakoAC/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/NanakoAC/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/NanakoAC/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/NanakoAC/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/NanakoAC/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/NanakoAC/Aurora.3/subscription","commits_url":"https://api.github.com/repos/NanakoAC/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NanakoAC/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NanakoAC/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NanakoAC/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/NanakoAC/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NanakoAC/Aurora.3/merges","archive_url":"https://api.github.com/repos/NanakoAC/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NanakoAC/Aurora.3/downloads","issues_url":"https://api.github.com/repos/NanakoAC/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/NanakoAC/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/NanakoAC/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/NanakoAC/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NanakoAC/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/NanakoAC/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/NanakoAC/Aurora.3/deployments","created_at":"2016-05-21T07:31:49Z","updated_at":"2016-05-21T07:31:59Z","pushed_at":"2016-10-24T19:18:35Z","git_url":"git://github.com/NanakoAC/Aurora.3.git","ssh_url":"git@github.com:NanakoAC/Aurora.3.git","clone_url":"https://github.com/NanakoAC/Aurora.3.git","svn_url":"https://github.com/NanakoAC/Aurora.3","homepage":"http://aurorastation.org/","size":547678,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Aurorastation:development","ref":"development","sha":"a3f051693d67f4cc8a193ab5db38e3231febeae2","user":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars.githubusercontent.com/u/6915762?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"repo":{"id":42579199,"name":"Aurora.3","full_name":"Aurorastation/Aurora.3","owner":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars.githubusercontent.com/u/6915762?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aurorastation/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/Aurorastation/Aurora.3","forks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/forks","keys_url":"https://api.github.com/repos/Aurorastation/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aurorastation/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aurorastation/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/events","assignees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Aurorastation/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Aurorastation/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Aurorastation/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aurorastation/Aurora.3/merges","archive_url":"https://api.github.com/repos/Aurorastation/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aurorastation/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Aurorastation/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Aurorastation/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aurorastation/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Aurorastation/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/deployments","created_at":"2015-09-16T09:56:37Z","updated_at":"2016-10-24T09:13:24Z","pushed_at":"2016-10-24T20:16:29Z","git_url":"git://github.com/Aurorastation/Aurora.3.git","ssh_url":"git@github.com:Aurorastation/Aurora.3.git","clone_url":"https://github.com/Aurorastation/Aurora.3.git","svn_url":"https://github.com/Aurorastation/Aurora.3","homepage":"http://aurorastation.org/","size":586031,"stargazers_count":7,"watchers_count":7,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":190,"forks":38,"open_issues":190,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/1030"},"issue":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/1030"},"comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/1030/comments"},"review_comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030/comments"},"review_comment":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/1030/commits"},"statuses":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/8600e555048ca45b6f46e3c04ac095a8c4b58294"}}}}
{"actor":{"display_login":"NanakoAC"}}