{"action":"closed","number":71,"pull_request":{"url":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/71","id":87804770,"html_url":"https://github.com/ubuntudesign/maas.io/pull/71","diff_url":"https://github.com/ubuntudesign/maas.io/pull/71.diff","patch_url":"https://github.com/ubuntudesign/maas.io/pull/71.patch","issue_url":"https://api.github.com/repos/ubuntudesign/maas.io/issues/71","number":71,"state":"closed","locked":false,"title":"Only strip .html for internal links in navigation","user":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/CanonicalLtd/maas-docs/issues/131\r\n\r\nAs per the issue, we were stripping .html extensions for external links too, breaking them.\r\n\r\nThis adds conditionals to only strip the extension if the link doesn't contain `//` - i.e. is internal.\r\n\r\nQA\r\n---\r\n\r\n``` bash\r\nmake docs setup develop\r\n```\r\n\r\nBrowse to <http://127.0.0.1:8000/docs/en/>, click \"API Documentation\" in the nav and check it works. Now go back and click around the internal pages in the nav and check they all work too.","created_at":"2016-10-03T22:36:56Z","updated_at":"2016-10-03T22:59:36Z","closed_at":"2016-10-03T22:59:36Z","merged_at":"2016-10-03T22:59:36Z","merge_commit_sha":"b9199f0dd479e6dcc570a3722275c3cf7942fd8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/71/commits","review_comments_url":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/71/comments","review_comment_url":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubuntudesign/maas.io/issues/71/comments","statuses_url":"https://api.github.com/repos/ubuntudesign/maas.io/statuses/26482a9a06b8c98d55547a8b756a9a81ccec27a7","head":{"label":"nottrobin:link-fix","ref":"link-fix","sha":"26482a9a06b8c98d55547a8b756a9a81ccec27a7","user":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"repo":{"id":47325438,"name":"maas.io","full_name":"nottrobin/maas.io","owner":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nottrobin/maas.io","description":"Site for maas.ubuntu.com","fork":true,"url":"https://api.github.com/repos/nottrobin/maas.io","forks_url":"https://api.github.com/repos/nottrobin/maas.io/forks","keys_url":"https://api.github.com/repos/nottrobin/maas.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nottrobin/maas.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nottrobin/maas.io/teams","hooks_url":"https://api.github.com/repos/nottrobin/maas.io/hooks","issue_events_url":"https://api.github.com/repos/nottrobin/maas.io/issues/events{/number}","events_url":"https://api.github.com/repos/nottrobin/maas.io/events","assignees_url":"https://api.github.com/repos/nottrobin/maas.io/assignees{/user}","branches_url":"https://api.github.com/repos/nottrobin/maas.io/branches{/branch}","tags_url":"https://api.github.com/repos/nottrobin/maas.io/tags","blobs_url":"https://api.github.com/repos/nottrobin/maas.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nottrobin/maas.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nottrobin/maas.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/nottrobin/maas.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nottrobin/maas.io/statuses/{sha}","languages_url":"https://api.github.com/repos/nottrobin/maas.io/languages","stargazers_url":"https://api.github.com/repos/nottrobin/maas.io/stargazers","contributors_url":"https://api.github.com/repos/nottrobin/maas.io/contributors","subscribers_url":"https://api.github.com/repos/nottrobin/maas.io/subscribers","subscription_url":"https://api.github.com/repos/nottrobin/maas.io/subscription","commits_url":"https://api.github.com/repos/nottrobin/maas.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/nottrobin/maas.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/nottrobin/maas.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/nottrobin/maas.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/nottrobin/maas.io/contents/{+path}","compare_url":"https://api.github.com/repos/nottrobin/maas.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nottrobin/maas.io/merges","archive_url":"https://api.github.com/repos/nottrobin/maas.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nottrobin/maas.io/downloads","issues_url":"https://api.github.com/repos/nottrobin/maas.io/issues{/number}","pulls_url":"https://api.github.com/repos/nottrobin/maas.io/pulls{/number}","milestones_url":"https://api.github.com/repos/nottrobin/maas.io/milestones{/number}","notifications_url":"https://api.github.com/repos/nottrobin/maas.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nottrobin/maas.io/labels{/name}","releases_url":"https://api.github.com/repos/nottrobin/maas.io/releases{/id}","deployments_url":"https://api.github.com/repos/nottrobin/maas.io/deployments","created_at":"2015-12-03T10:39:08Z","updated_at":"2015-12-03T10:39:09Z","pushed_at":"2016-10-03T22:34:47Z","git_url":"git://github.com/nottrobin/maas.io.git","ssh_url":"git@github.com:nottrobin/maas.io.git","clone_url":"https://github.com/nottrobin/maas.io.git","svn_url":"https://github.com/nottrobin/maas.io","homepage":null,"size":38682,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubuntudesign:master","ref":"master","sha":"915dca8856947666ed0fd2c25cd66831bf45ab5e","user":{"login":"ubuntudesign","id":8777739,"avatar_url":"https://avatars.githubusercontent.com/u/8777739?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntudesign","html_url":"https://github.com/ubuntudesign","followers_url":"https://api.github.com/users/ubuntudesign/followers","following_url":"https://api.github.com/users/ubuntudesign/following{/other_user}","gists_url":"https://api.github.com/users/ubuntudesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntudesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntudesign/subscriptions","organizations_url":"https://api.github.com/users/ubuntudesign/orgs","repos_url":"https://api.github.com/users/ubuntudesign/repos","events_url":"https://api.github.com/users/ubuntudesign/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntudesign/received_events","type":"Organization","site_admin":false},"repo":{"id":33983952,"name":"maas.io","full_name":"ubuntudesign/maas.io","owner":{"login":"ubuntudesign","id":8777739,"avatar_url":"https://avatars.githubusercontent.com/u/8777739?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntudesign","html_url":"https://github.com/ubuntudesign","followers_url":"https://api.github.com/users/ubuntudesign/followers","following_url":"https://api.github.com/users/ubuntudesign/following{/other_user}","gists_url":"https://api.github.com/users/ubuntudesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntudesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntudesign/subscriptions","organizations_url":"https://api.github.com/users/ubuntudesign/orgs","repos_url":"https://api.github.com/users/ubuntudesign/repos","events_url":"https://api.github.com/users/ubuntudesign/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntudesign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubuntudesign/maas.io","description":"Site for maas.io","fork":false,"url":"https://api.github.com/repos/ubuntudesign/maas.io","forks_url":"https://api.github.com/repos/ubuntudesign/maas.io/forks","keys_url":"https://api.github.com/repos/ubuntudesign/maas.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubuntudesign/maas.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubuntudesign/maas.io/teams","hooks_url":"https://api.github.com/repos/ubuntudesign/maas.io/hooks","issue_events_url":"https://api.github.com/repos/ubuntudesign/maas.io/issues/events{/number}","events_url":"https://api.github.com/repos/ubuntudesign/maas.io/events","assignees_url":"https://api.github.com/repos/ubuntudesign/maas.io/assignees{/user}","branches_url":"https://api.github.com/repos/ubuntudesign/maas.io/branches{/branch}","tags_url":"https://api.github.com/repos/ubuntudesign/maas.io/tags","blobs_url":"https://api.github.com/repos/ubuntudesign/maas.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubuntudesign/maas.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubuntudesign/maas.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubuntudesign/maas.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubuntudesign/maas.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ubuntudesign/maas.io/languages","stargazers_url":"https://api.github.com/repos/ubuntudesign/maas.io/stargazers","contributors_url":"https://api.github.com/repos/ubuntudesign/maas.io/contributors","subscribers_url":"https://api.github.com/repos/ubuntudesign/maas.io/subscribers","subscription_url":"https://api.github.com/repos/ubuntudesign/maas.io/subscription","commits_url":"https://api.github.com/repos/ubuntudesign/maas.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubuntudesign/maas.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubuntudesign/maas.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubuntudesign/maas.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubuntudesign/maas.io/contents/{+path}","compare_url":"https://api.github.com/repos/ubuntudesign/maas.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubuntudesign/maas.io/merges","archive_url":"https://api.github.com/repos/ubuntudesign/maas.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubuntudesign/maas.io/downloads","issues_url":"https://api.github.com/repos/ubuntudesign/maas.io/issues{/number}","pulls_url":"https://api.github.com/repos/ubuntudesign/maas.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ubuntudesign/maas.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ubuntudesign/maas.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubuntudesign/maas.io/labels{/name}","releases_url":"https://api.github.com/repos/ubuntudesign/maas.io/releases{/id}","deployments_url":"https://api.github.com/repos/ubuntudesign/maas.io/deployments","created_at":"2015-04-15T09:04:18Z","updated_at":"2016-08-31T15:53:44Z","pushed_at":"2016-10-03T22:59:36Z","git_url":"git://github.com/ubuntudesign/maas.io.git","ssh_url":"git@github.com:ubuntudesign/maas.io.git","clone_url":"https://github.com/ubuntudesign/maas.io.git","svn_url":"https://github.com/ubuntudesign/maas.io","homepage":"","size":38482,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/71"},"html":{"href":"https://github.com/ubuntudesign/maas.io/pull/71"},"issue":{"href":"https://api.github.com/repos/ubuntudesign/maas.io/issues/71"},"comments":{"href":"https://api.github.com/repos/ubuntudesign/maas.io/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubuntudesign/maas.io/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/ubuntudesign/maas.io/statuses/26482a9a06b8c98d55547a8b756a9a81ccec27a7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nottrobin","id":519935,"avatar_url":"https://avatars.githubusercontent.com/u/519935?v=3","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":11,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"nottrobin"}}