{"action":"closed","number":2118,"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/2118","id":88191854,"html_url":"https://github.com/youtube/vitess/pull/2118","diff_url":"https://github.com/youtube/vitess/pull/2118.diff","patch_url":"https://github.com/youtube/vitess/pull/2118.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/2118","number":2118,"state":"closed","locked":false,"title":"2pc: TabletServer workflows","user":{"login":"sougou","id":589370,"avatar_url":"https://avatars.githubusercontent.com/u/589370?v=3","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},"body":"All previously mentioned tabletserver workflow issues\r\nare addressed now.\r\n* A master->non-master transition immediately rolls back all\r\ntransactions including the prepared ones. This addresses the case\r\nwhere MySQL was externally reparented.\r\n* A master->shutdown transition waits till all transactions are\r\nresolved. This addresses the reparent caused by the resharding\r\nworkflow. We don't want to shut down with unresolved transactions.\r\nThis code path is also used for normal reparents, where this behavior\r\nis also acceptable.\r\n* There is no race condition between state transition code and other\r\ntransactional commands. When we transition between two serving types,\r\nwe don't allow any requests until the transactions are rolled back.\r\nDuring shutdown, we allow transactional statements, but the transition\r\ncode only waits for transactions to be resolved. So, there's no race\r\nin either situation.","created_at":"2016-10-06T03:02:37Z","updated_at":"2016-10-06T03:15:38Z","closed_at":"2016-10-06T03:15:38Z","merged_at":"2016-10-06T03:15:38Z","merge_commit_sha":"f78c8301c7a430a4dd3d6a3d5488f159e57f5184","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/2118/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/2118/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/2118/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/1db21d4327f1253bbd02f2fe7dfeb8aa6ab7a5dc","head":{"label":"sougou:2pc","ref":"2pc","sha":"1db21d4327f1253bbd02f2fe7dfeb8aa6ab7a5dc","user":{"login":"sougou","id":589370,"avatar_url":"https://avatars.githubusercontent.com/u/589370?v=3","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},"repo":{"id":53018095,"name":"vitess","full_name":"sougou/vitess","owner":{"login":"sougou","id":589370,"avatar_url":"https://avatars.githubusercontent.com/u/589370?v=3","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sougou/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":true,"url":"https://api.github.com/repos/sougou/vitess","forks_url":"https://api.github.com/repos/sougou/vitess/forks","keys_url":"https://api.github.com/repos/sougou/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sougou/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sougou/vitess/teams","hooks_url":"https://api.github.com/repos/sougou/vitess/hooks","issue_events_url":"https://api.github.com/repos/sougou/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/sougou/vitess/events","assignees_url":"https://api.github.com/repos/sougou/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/sougou/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/sougou/vitess/tags","blobs_url":"https://api.github.com/repos/sougou/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sougou/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sougou/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/sougou/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sougou/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/sougou/vitess/languages","stargazers_url":"https://api.github.com/repos/sougou/vitess/stargazers","contributors_url":"https://api.github.com/repos/sougou/vitess/contributors","subscribers_url":"https://api.github.com/repos/sougou/vitess/subscribers","subscription_url":"https://api.github.com/repos/sougou/vitess/subscription","commits_url":"https://api.github.com/repos/sougou/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/sougou/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/sougou/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/sougou/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/sougou/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/sougou/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sougou/vitess/merges","archive_url":"https://api.github.com/repos/sougou/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sougou/vitess/downloads","issues_url":"https://api.github.com/repos/sougou/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/sougou/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/sougou/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/sougou/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sougou/vitess/labels{/name}","releases_url":"https://api.github.com/repos/sougou/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/sougou/vitess/deployments","created_at":"2016-03-03T03:38:39Z","updated_at":"2016-03-03T03:38:43Z","pushed_at":"2016-10-06T03:02:12Z","git_url":"git://github.com/sougou/vitess.git","ssh_url":"git@github.com:sougou/vitess.git","clone_url":"https://github.com/sougou/vitess.git","svn_url":"https://github.com/sougou/vitess","homepage":null,"size":64655,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"ba9270ca8e6421e3d0cc828c271a144e22270c41","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/youtube/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2016-10-05T18:45:03Z","pushed_at":"2016-10-06T03:15:40Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":"http://vitess.io","size":92865,"stargazers_count":3916,"watchers_count":3916,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":507,"mirror_url":null,"open_issues_count":21,"forks":507,"open_issues":21,"watchers":3916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/2118"},"html":{"href":"https://github.com/youtube/vitess/pull/2118"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/2118"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/2118/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/2118/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/2118/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/1db21d4327f1253bbd02f2fe7dfeb8aa6ab7a5dc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sougou","id":589370,"avatar_url":"https://avatars.githubusercontent.com/u/589370?v=3","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":307,"deletions":10,"changed_files":10}}
{"actor":{"display_login":"sougou"}}