{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/56640238","id":56640238,"diff_hunk":"@@ -56,27 +57,26 @@\n # body for __init__.py file in package directory, which takes care of making sure the package can be distributed\n # across multiple directories\n PKG_INIT_BODY = \"\"\"\n-from pkgutil import extend_path\n-\n-# extend path so Python knows this is not the only place to look for modules in this package\n-__path__ = extend_path(__path__, __name__)\n+import pkg_resources\n+pkg_resources.declare_namespace(__name__)\n \"\"\"\n \n # more extensive __init__.py specific to easybuild.easyblocks package;\n # this is required because of the way in which the easyblock Python modules are organised in the easybuild-easyblocks\n # repository, i.e. in first-letter subdirectories\n EASYBLOCKS_PKG_INIT_BODY = \"\"\"\n-from pkgutil import extend_path\n+import pkg_resources\n+import pkgutil\n \n # extend path so Python finds our easyblocks in the subdirectories where they are located\n subdirs = [chr(l) for l in range(ord('a'), ord('z') + 1)] + ['0']\n for subdir in subdirs:\n-    __path__ = extend_path(__path__, '%s.%s' % (__name__, subdir))\n+    __path__ = pkgutil.extend_path(__path__, '%s.%s' % (__name__, subdir))\n \n # extend path so Python knows this is not the only place to look for modules in this package\n-__path__ = extend_path(__path__, __name__)\n+pkg_resources.declare_namespace(__name__)","path":"easybuild/tools/include.py","position":36,"original_position":36,"commit_id":"a47806b8878154071e09f8e686723ee7a947faa9","original_commit_id":"a47806b8878154071e09f8e686723ee7a947faa9","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"no, `__name__` is correct","created_at":"2016-03-18T10:56:44Z","updated_at":"2016-03-18T10:56:44Z","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1593#discussion_r56640238","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/56640238"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1593#discussion_r56640238"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593","id":58531559,"html_url":"https://github.com/hpcugent/easybuild-framework/pull/1593","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/1593.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/1593.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1593","number":1593,"state":"closed","locked":false,"title":"easybuild is a namespace package (2nd attempt) (REVIEW)","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"another attempt at #1591 (after that was reverted in #1592)\r\n\r\nPR tester has been enhanced, and should now see the problem reported in #1592 that warranted a rollback of #1591...\r\n\r\ndocumentation on namespace packages is available at https://pythonhosted.org/setuptools/pkg_resources.html#namespace-package-support","created_at":"2016-02-06T22:01:07Z","updated_at":"2016-03-18T10:56:44Z","closed_at":"2016-03-10T10:49:55Z","merged_at":"2016-03-10T10:49:55Z","merge_commit_sha":"3cadeb2ce7ecc32cc019622eda73e649f697c0e3","assignee":null,"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/34","html_url":"https://github.com/hpcugent/easybuild-framework/milestones/v2.7.0","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/34/labels","id":1534739,"number":34,"title":"v2.7.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":76,"state":"open","created_at":"2016-01-22T15:25:29Z","updated_at":"2016-03-17T21:35:48Z","due_on":"2016-03-15T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1593/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/a47806b8878154071e09f8e686723ee7a947faa9","head":{"label":"boegel:easybuild_namespace","ref":"easybuild_namespace","sha":"a47806b8878154071e09f8e686723ee7a947faa9","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"repo":{"id":4125402,"name":"easybuild-framework","full_name":"boegel/easybuild-framework","owner":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boegel/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/boegel/easybuild-framework","forks_url":"https://api.github.com/repos/boegel/easybuild-framework/forks","keys_url":"https://api.github.com/repos/boegel/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boegel/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boegel/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/boegel/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/boegel/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/boegel/easybuild-framework/events","assignees_url":"https://api.github.com/repos/boegel/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/boegel/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/boegel/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/boegel/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boegel/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boegel/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/boegel/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boegel/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/boegel/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/boegel/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/boegel/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/boegel/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/boegel/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/boegel/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/boegel/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/boegel/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/boegel/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/boegel/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/boegel/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boegel/easybuild-framework/merges","archive_url":"https://api.github.com/repos/boegel/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boegel/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/boegel/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/boegel/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/boegel/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/boegel/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boegel/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/boegel/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/boegel/easybuild-framework/deployments","created_at":"2012-04-24T14:16:06Z","updated_at":"2015-03-06T20:05:49Z","pushed_at":"2016-03-17T21:35:51Z","git_url":"git://github.com/boegel/easybuild-framework.git","ssh_url":"git@github.com:boegel/easybuild-framework.git","clone_url":"https://github.com/boegel/easybuild-framework.git","svn_url":"https://github.com/boegel/easybuild-framework","homepage":"","size":12988,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"c839e5dcbed90e027ad5e5296ddbcf2cb4903dac","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"hpcugent/easybuild-framework","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-framework","forks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-framework/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/deployments","created_at":"2012-03-08T17:07:43Z","updated_at":"2016-02-07T14:25:11Z","pushed_at":"2016-03-17T21:35:48Z","git_url":"git://github.com/hpcugent/easybuild-framework.git","ssh_url":"git@github.com:hpcugent/easybuild-framework.git","clone_url":"https://github.com/hpcugent/easybuild-framework.git","svn_url":"https://github.com/hpcugent/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":13894,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":309,"forks":88,"open_issues":309,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1593"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1593"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1593/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1593/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/a47806b8878154071e09f8e686723ee7a947faa9"}}}}