{"push_id":1334731791,"size":2,"distinct_size":2,"ref":"refs/heads/indigo","head":"562332df73781c1e56ce9123542334cc1d91b143","before":"2589ed28251268a9657f4cc037373b063cca9958","commits":[{"sha":"6c2d65452bd5fe62723988a1a570789921900d59","author":{"name":"Lukas Bulwahn","email":"af256f5dadcacc5a2ec2b6cf048e1ef0839b027d@oss.bmw-carit.de"},"message":"address gcc6 build error\n\nWith gcc6, compiling fails with `stdlib.h: No such file or directory`,\nas including '-isystem /usr/include' breaks with gcc6, cf.,\nhttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.\n\nThis commit addresses this issue for this package in the same way\nit was addressed in various other ROS packages. A list of related\ncommits and pull requests is at:\n\n  https://github.com/ros/rosdistro/issues/12783\n\nSigned-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>","distinct":true,"url":"https://api.github.com/repos/bulwahn/image_pipeline/commits/6c2d65452bd5fe62723988a1a570789921900d59"},{"sha":"562332df73781c1e56ce9123542334cc1d91b143","author":{"name":"Lukas Bulwahn","email":"af256f5dadcacc5a2ec2b6cf048e1ef0839b027d@oss.bmw-carit.de"},"message":"explicitly cast to std::vector<double> to make gcc6 happy\n\nWith gcc6, compiling image_publisher fails with this error:\n```\n/[...]/image_publisher/src/nodelet/image_publisher_nodelet.cpp: In member function 'virtual void image_publisher::ImagePublisherNodelet::onInit()':\n/[...]/image_publisher/src/nodelet/image_publisher_nodelet.cpp:180:43: error: ambiguous overload for 'operator=' (operand types are 'sensor_msgs::CameraInfo_<std::allocator<void> >::_D_type {aka std::vector<double>}' and 'boost::assign_detail::generic_list<int>')\n     camera_info_.D = list_of(0)(0)(0)(0)(0);\n```\n\nAfter adding an initial explicit type cast for the assignment,\ncompiling fails further with:\n```\n| /[...]/image_publisher/src/nodelet/image_publisher_nodelet.cpp: In member function 'virtual void image_publisher::ImagePublisherNodelet::onInit()':\n| /[...]/image_publisher/src/nodelet/image_publisher_nodelet.cpp:180:65: error: call of overloaded 'vector(boost::assign_detail::generic_list<int>&)' is ambiguous\n|      camera_info_.D = std::vector<double> (list_of(0)(0)(0)(0)(0));\n```\n\nVarious sources on the internet [1, 2, 3] point to use the\n`convert_to_container` method; hence, this commit follows those\nsuggestions and with that image_publisher compiles with gcc6.\n\n[1] http://stackoverflow.com/questions/16211410/ambiguity-when-using-boostassignlist-of-to-construct-a-stdvector\n[2] http://stackoverflow.com/questions/12352692/ambiguous-call-with-list-of-in-vs2010/12362548#12362548\n[3] http://stackoverflow.com/questions/13285272/using-boostassignlist-of?rq=1\n\nSigned-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>","distinct":true,"url":"https://api.github.com/repos/bulwahn/image_pipeline/commits/562332df73781c1e56ce9123542334cc1d91b143"}]}
{"actor":{"display_login":"bulwahn"}}