{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/mist/issues/841","repository_url":"https://api.github.com/repos/ethereum/mist","labels_url":"https://api.github.com/repos/ethereum/mist/issues/841/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/mist/issues/841/comments","events_url":"https://api.github.com/repos/ethereum/mist/issues/841/events","html_url":"https://github.com/ethereum/mist/pull/841","id":160681790,"number":841,"title":"Fixes the node start IPC connection","user":{"login":"frozeman","id":232662,"avatar_url":"https://avatars.githubusercontent.com/u/232662?v=3","gravatar_id":"","url":"https://api.github.com/users/frozeman","html_url":"https://github.com/frozeman","followers_url":"https://api.github.com/users/frozeman/followers","following_url":"https://api.github.com/users/frozeman/following{/other_user}","gists_url":"https://api.github.com/users/frozeman/gists{/gist_id}","starred_url":"https://api.github.com/users/frozeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozeman/subscriptions","organizations_url":"https://api.github.com/users/frozeman/orgs","repos_url":"https://api.github.com/users/frozeman/repos","events_url":"https://api.github.com/users/frozeman/events{/privacy}","received_events_url":"https://api.github.com/users/frozeman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/mist/labels/please%20review","name":"please review","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"hiddentao","id":266594,"avatar_url":"https://avatars.githubusercontent.com/u/266594?v=3","gravatar_id":"","url":"https://api.github.com/users/hiddentao","html_url":"https://github.com/hiddentao","followers_url":"https://api.github.com/users/hiddentao/followers","following_url":"https://api.github.com/users/hiddentao/following{/other_user}","gists_url":"https://api.github.com/users/hiddentao/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddentao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddentao/subscriptions","organizations_url":"https://api.github.com/users/hiddentao/orgs","repos_url":"https://api.github.com/users/hiddentao/repos","events_url":"https://api.github.com/users/hiddentao/events{/privacy}","received_events_url":"https://api.github.com/users/hiddentao/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ethereum/mist/milestones/7","html_url":"https://github.com/ethereum/mist/milestones/0.7.6","labels_url":"https://api.github.com/repos/ethereum/mist/milestones/7/labels","id":1830965,"number":7,"title":"0.7.6","description":"Small bug fixes and improvements for 0.7.5","creator":{"login":"alexvandesande","id":112898,"avatar_url":"https://avatars.githubusercontent.com/u/112898?v=3","gravatar_id":"","url":"https://api.github.com/users/alexvandesande","html_url":"https://github.com/alexvandesande","followers_url":"https://api.github.com/users/alexvandesande/followers","following_url":"https://api.github.com/users/alexvandesande/following{/other_user}","gists_url":"https://api.github.com/users/alexvandesande/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvandesande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvandesande/subscriptions","organizations_url":"https://api.github.com/users/alexvandesande/orgs","repos_url":"https://api.github.com/users/alexvandesande/repos","events_url":"https://api.github.com/users/alexvandesande/events{/privacy}","received_events_url":"https://api.github.com/users/alexvandesande/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2016-06-15T22:10:15Z","updated_at":"2016-06-21T16:10:36Z","due_on":"2016-06-22T22:00:00Z","closed_at":null},"comments":12,"created_at":"2016-06-16T14:52:59Z","updated_at":"2016-06-22T15:37:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/mist/pulls/841","html_url":"https://github.com/ethereum/mist/pull/841","diff_url":"https://github.com/ethereum/mist/pull/841.diff","patch_url":"https://github.com/ethereum/mist/pull/841.patch"},"body":"This PR is adding a loop to test an IPC connection. When a connection timeout is set, it tries to connect every 200ms to the connection, if not it fails.\r\n\r\nThis speeds up the connection process, as we don't have to wait arbitrary 4 seconds anymore (which weren't enough for `eth`)\r\n\r\n\r\n@hiddentao This PR works, but if you set a wrong IPC path it doesn't quit gracefully, instead i delivers an uncaught exception. Could you please look into this.\r\nSimply let the `eth` node start (Change the `node` files content in `~/Library/App..Support/Mist/node` to `eth`) \r\nBefore change the pic path in the `getIPCPath.js` to some other path.\r\n\r\nYou will see it fails, but not gracefully, as the error seems to travers through and doesn't get catched.\r\n\r\nThis error is created in the socket.js line 84\r\n\r\n```js\r\n[2016-06-16 16:44:28.827] [INFO] Sockets/node-ipc - Connect to {\"path\":\"/Users/frozeman/Library/Ethereum/gethdddd.ipc\"}\r\n[2016-06-16 16:44:38.965] [ERROR] Sockets/node-ipc - { Error: connect ENOENT /Users/frozeman/Library/Ethereum/gethdddd.ipc\r\n    at Object.exports._errnoException (util.js:949:11)\r\n    at exports._exceptionWithHostPort (util.js:972:20)\r\n    at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1080:14)\r\n  code: 'ENOENT',\r\n  errno: 'ENOENT',\r\n  syscall: 'connect',\r\n  address: '/Users/frozeman/Library/Ethereum/gethdddd.ipc' }\r\nError: connect ENOENT /Users/frozeman/Library/Ethereum/gethdddd.ipc\r\n    at Object.exports._errnoException (util.js:949:11)\r\n    at exports._exceptionWithHostPort (util.js:972:20)\r\n    at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1080:14)\r\n[2016-06-16 16:44:38.967] [ERROR] main - UNCAUGHT EXCEPTION { Error: connect ENOENT /Users/frozeman/Library/Ethereum/gethdddd.ipc\r\n    at Object.exports._errnoException (util.js:949:11)\r\n    at exports._exceptionWithHostPort (util.js:972:20)\r\n    at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1080:14)\r\n  code: 'ENOENT',\r\n  errno: 'ENOENT',\r\n  syscall: 'connect',\r\n  address: '/Users/frozeman/Library/Ethereum/gethdddd.ipc' }\r\nError: connect ENOENT /Users/frozeman/Library/Ethereum/gethdddd.ipc\r\n    at Object.exports._errnoException (util.js:949:11)\r\n    at exports._exceptionWithHostPort (util.js:972:20)\r\n    at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1080:14)\r\n```"},"comment":{"url":"https://api.github.com/repos/ethereum/mist/issues/comments/227783971","html_url":"https://github.com/ethereum/mist/pull/841#issuecomment-227783971","issue_url":"https://api.github.com/repos/ethereum/mist/issues/841","id":227783971,"user":{"login":"luclu","id":10135872,"avatar_url":"https://avatars.githubusercontent.com/u/10135872?v=3","gravatar_id":"","url":"https://api.github.com/users/luclu","html_url":"https://github.com/luclu","followers_url":"https://api.github.com/users/luclu/followers","following_url":"https://api.github.com/users/luclu/following{/other_user}","gists_url":"https://api.github.com/users/luclu/gists{/gist_id}","starred_url":"https://api.github.com/users/luclu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luclu/subscriptions","organizations_url":"https://api.github.com/users/luclu/orgs","repos_url":"https://api.github.com/users/luclu/repos","events_url":"https://api.github.com/users/luclu/events{/privacy}","received_events_url":"https://api.github.com/users/luclu/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T15:37:37Z","updated_at":"2016-06-22T15:37:37Z","body":"Seems to work well - under windows 7 and OSX.\r\nTest starting, switching networks/nodes, detaching.\r\n**But** I needed to remove eth's config folder.\r\n﻿﻿"}}
{"actor":{"display_login":"luclu"}}