{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/comments/54827663","id":54827663,"diff_hunk":"@@ -99,21 +99,31 @@\n     });\n \n     suite('focused styles', function() {\n-      test('underline and label are colored when input is focused', function(done) {\n+      test('label is colored when input is focused', function(done) {\n         var input = fixture('label-and-value');\n-        var line = Polymer.dom(input.root).querySelector('.underline');\n         var label = Polymer.dom(input.root).querySelector('label');\n \n-        assert.isFalse(line.classList.contains('is-highlighted'), 'line is not highlighted when input is not focused');\n-        assert.isFalse(label.classList.contains('label-is-highlighted'), 'label is not highlighted when input is not focused');\n+        assert.isFalse(input.focused);\n+\n+        // Nothing is coloured and the focus underline isn't showing\n+        assert.equal(window.getComputedStyle(label).color, 'rgb(115, 115, 115)');\n+        assert.equal(window.getComputedStyle(label, ':after').visibility,\n+            'hidden');\n \n         MockInteractions.focus(input.$.input);\n \n-        requestAnimationFrame(function() {\n-          assert.isTrue(line.classList.contains('is-highlighted'), 'line is highlighted when input is focused');\n-          assert.isTrue(label.classList.contains('label-is-highlighted'), 'label is highlighted when input is focused');\n+        // Wait for the animation to finish\n+        setTimeout(function() {","path":"test/styles.html","position":43,"original_position":43,"commit_id":"399c1641451b5cb53cba04d77713253f3923db84","original_commit_id":"399c1641451b5cb53cba04d77713253f3923db84","user":{"login":"bicknellr","id":406614,"avatar_url":"https://avatars.githubusercontent.com/u/406614?v=3","gravatar_id":"","url":"https://api.github.com/users/bicknellr","html_url":"https://github.com/bicknellr","followers_url":"https://api.github.com/users/bicknellr/followers","following_url":"https://api.github.com/users/bicknellr/following{/other_user}","gists_url":"https://api.github.com/users/bicknellr/gists{/gist_id}","starred_url":"https://api.github.com/users/bicknellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bicknellr/subscriptions","organizations_url":"https://api.github.com/users/bicknellr/orgs","repos_url":"https://api.github.com/users/bicknellr/repos","events_url":"https://api.github.com/users/bicknellr/events{/privacy}","received_events_url":"https://api.github.com/users/bicknellr/received_events","type":"User","site_admin":false},"body":"Does it with a timeout? / Do we have any rule about when to use one or the other?","created_at":"2016-03-03T02:21:41Z","updated_at":"2016-03-03T02:21:41Z","html_url":"https://github.com/PolymerElements/paper-text-field/pull/4#discussion_r54827663","pull_request_url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/comments/54827663"},"html":{"href":"https://github.com/PolymerElements/paper-text-field/pull/4#discussion_r54827663"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4","id":61339705,"html_url":"https://github.com/PolymerElements/paper-text-field/pull/4","diff_url":"https://github.com/PolymerElements/paper-text-field/pull/4.diff","patch_url":"https://github.com/PolymerElements/paper-text-field/pull/4.patch","issue_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/4","number":4,"state":"open","locked":false,"title":"Use the MDL DOM and styles","user":{"login":"notwaldorf","id":1369170,"avatar_url":"https://avatars.githubusercontent.com/u/1369170?v=3","gravatar_id":"","url":"https://api.github.com/users/notwaldorf","html_url":"https://github.com/notwaldorf","followers_url":"https://api.github.com/users/notwaldorf/followers","following_url":"https://api.github.com/users/notwaldorf/following{/other_user}","gists_url":"https://api.github.com/users/notwaldorf/gists{/gist_id}","starred_url":"https://api.github.com/users/notwaldorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notwaldorf/subscriptions","organizations_url":"https://api.github.com/users/notwaldorf/orgs","repos_url":"https://api.github.com/users/notwaldorf/repos","events_url":"https://api.github.com/users/notwaldorf/events{/privacy}","received_events_url":"https://api.github.com/users/notwaldorf/received_events","type":"User","site_admin":false},"body":"MDL has a waaaay smaller DOM for its paper inputs than we do, so let's use theirs. \r\n\r\n/cc @addyosmani \r\n\r\nAlso, lookie, it looks the same:\r\n<img width=\"331\" alt=\"screen shot 2016-03-03 at 11 57 05 am\" src=\"https://cloud.githubusercontent.com/assets/1369170/13481130/13539ff4-e137-11e5-943e-842a857c48a9.png\">\r\n","created_at":"2016-03-02T01:49:48Z","updated_at":"2016-03-03T02:21:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13c8e70e86afa428dc444a3334068c75774cdf7d","assignee":{"login":"bicknellr","id":406614,"avatar_url":"https://avatars.githubusercontent.com/u/406614?v=3","gravatar_id":"","url":"https://api.github.com/users/bicknellr","html_url":"https://github.com/bicknellr","followers_url":"https://api.github.com/users/bicknellr/followers","following_url":"https://api.github.com/users/bicknellr/following{/other_user}","gists_url":"https://api.github.com/users/bicknellr/gists{/gist_id}","starred_url":"https://api.github.com/users/bicknellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bicknellr/subscriptions","organizations_url":"https://api.github.com/users/bicknellr/orgs","repos_url":"https://api.github.com/users/bicknellr/repos","events_url":"https://api.github.com/users/bicknellr/events{/privacy}","received_events_url":"https://api.github.com/users/bicknellr/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/4/comments","statuses_url":"https://api.github.com/repos/PolymerElements/paper-text-field/statuses/399c1641451b5cb53cba04d77713253f3923db84","head":{"label":"PolymerElements:simplify-css","ref":"simplify-css","sha":"399c1641451b5cb53cba04d77713253f3923db84","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":49292679,"name":"paper-text-field","full_name":"PolymerElements/paper-text-field","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-text-field","description":"WIP redesign of the Material Design input fields.","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-text-field","forks_url":"https://api.github.com/repos/PolymerElements/paper-text-field/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-text-field/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-text-field/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-text-field/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-text-field/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-text-field/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-text-field/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-text-field/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-text-field/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-text-field/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-text-field/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-text-field/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-text-field/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-text-field/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-text-field/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-text-field/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-text-field/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-text-field/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-text-field/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-text-field/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-text-field/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-text-field/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-text-field/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-text-field/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-text-field/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-text-field/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/paper-text-field/deployments","created_at":"2016-01-08T19:45:16Z","updated_at":"2016-01-28T20:02:05Z","pushed_at":"2016-03-03T01:50:18Z","git_url":"git://github.com/PolymerElements/paper-text-field.git","ssh_url":"git@github.com:PolymerElements/paper-text-field.git","clone_url":"https://github.com/PolymerElements/paper-text-field.git","svn_url":"https://github.com/PolymerElements/paper-text-field","homepage":null,"size":32,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"efcf436007106915c2f997924e142ab9edd134ca","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":49292679,"name":"paper-text-field","full_name":"PolymerElements/paper-text-field","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-text-field","description":"WIP redesign of the Material Design input fields.","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-text-field","forks_url":"https://api.github.com/repos/PolymerElements/paper-text-field/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-text-field/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-text-field/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-text-field/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-text-field/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-text-field/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-text-field/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-text-field/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-text-field/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-text-field/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-text-field/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-text-field/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-text-field/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-text-field/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-text-field/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-text-field/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-text-field/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-text-field/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-text-field/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-text-field/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-text-field/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-text-field/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-text-field/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-text-field/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-text-field/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-text-field/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-text-field/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-text-field/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/paper-text-field/deployments","created_at":"2016-01-08T19:45:16Z","updated_at":"2016-01-28T20:02:05Z","pushed_at":"2016-03-03T01:50:18Z","git_url":"git://github.com/PolymerElements/paper-text-field.git","ssh_url":"git@github.com:PolymerElements/paper-text-field.git","clone_url":"https://github.com/PolymerElements/paper-text-field.git","svn_url":"https://github.com/PolymerElements/paper-text-field","homepage":null,"size":32,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4"},"html":{"href":"https://github.com/PolymerElements/paper-text-field/pull/4"},"issue":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/4"},"comments":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/paper-text-field/statuses/399c1641451b5cb53cba04d77713253f3923db84"}}}}