{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/9208","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/9208/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/9208/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/9208/events","html_url":"https://github.com/dotnet/roslyn/pull/9208","id":136544647,"number":9208,"title":"don't assume all reference spans in an inline rename session are projected into the current view","user":{"login":"brettfo","id":926281,"avatar_url":"https://avatars.githubusercontent.com/u/926281?v=3","gravatar_id":"","url":"https://api.github.com/users/brettfo","html_url":"https://github.com/brettfo","followers_url":"https://api.github.com/users/brettfo/followers","following_url":"https://api.github.com/users/brettfo/following{/other_user}","gists_url":"https://api.github.com/users/brettfo/gists{/gist_id}","starred_url":"https://api.github.com/users/brettfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettfo/subscriptions","organizations_url":"https://api.github.com/users/brettfo/orgs","repos_url":"https://api.github.com/users/brettfo/repos","events_url":"https://api.github.com/users/brettfo/events{/privacy}","received_events_url":"https://api.github.com/users/brettfo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-25T23:25:24Z","updated_at":"2016-03-01T01:10:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/9208","html_url":"https://github.com/dotnet/roslyn/pull/9208","diff_url":"https://github.com/dotnet/roslyn/pull/9208.diff","patch_url":"https://github.com/dotnet/roslyn/pull/9208.patch"},"body":"_This is the same as #8646 but against `stabilization`._\r\n\r\nThe Razor directives `@model` and `@inherits` have reference spans in the underlying generated file that aren't projected to the current Razor view and inline rename makes an incorrect assumption that all reference spans are projected.\r\n\r\nThis removes that assumption.\r\n\r\nAlso included in this PR is a temporary workaround for `@model` projections getting out of sync with the backing buffer that disables live-preview in Razor files during inline rename.  Below is the out-of-sync behavior that can lead to a crash:\r\n\r\n![model](https://cloud.githubusercontent.com/assets/926281/13019862/bc2e90a4-d186-11e5-968d-e353b37f8a8c.gif)\r\n\r\nThe new no-live-update behavior is previewed below.  In an offline discussion this behavior was considered acceptable as a workaround for the crash/out-of-sync-projections because the user only notices it if both .cs and .cshtml files are visible at the same time (Razor currently doesn't support invoking cross-file reference inline rename directly from the .cshtml editor anyways.)\r\n\r\n![no-live-update](https://cloud.githubusercontent.com/assets/926281/13019779/3806f28a-d186-11e5-93ba-58d2d93e92f7.gif)\r\n\r\nPartially fixes #6821 and internal bug 182787.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/190477124","html_url":"https://github.com/dotnet/roslyn/pull/9208#issuecomment-190477124","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/9208","id":190477124,"user":{"login":"brettfo","id":926281,"avatar_url":"https://avatars.githubusercontent.com/u/926281?v=3","gravatar_id":"","url":"https://api.github.com/users/brettfo","html_url":"https://github.com/brettfo","followers_url":"https://api.github.com/users/brettfo/followers","following_url":"https://api.github.com/users/brettfo/following{/other_user}","gists_url":"https://api.github.com/users/brettfo/gists{/gist_id}","starred_url":"https://api.github.com/users/brettfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettfo/subscriptions","organizations_url":"https://api.github.com/users/brettfo/orgs","repos_url":"https://api.github.com/users/brettfo/repos","events_url":"https://api.github.com/users/brettfo/events{/privacy}","received_events_url":"https://api.github.com/users/brettfo/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T01:10:59Z","updated_at":"2016-03-01T01:10:59Z","body":"Not sure when the ETA queue will be back up, but I've address the test failures we were seeing in previous iterations of this.\r\n\r\nThis PR was originally #8646 so re-tagging appropriate parties here for (re?) review:\r\n@dotnet/roslyn-ide \r\n@toddgrunn"}}