{"action":"created","comment":{"url":"https://api.github.com/repos/cpputest/cpputest/pulls/comments/71078028","id":71078028,"diff_hunk":"@@ -36,10 +36,12 @@ class MockCheckedExpectedCall : public MockExpectedCall\n \n public:\n     MockCheckedExpectedCall();\n+    MockCheckedExpectedCall(unsigned int numCalls);\n     virtual ~MockCheckedExpectedCall();\n \n     virtual MockExpectedCall& withName(const SimpleString& name) _override;\n-    virtual MockExpectedCall& withCallOrder(unsigned int callOrder) _override;\n+    virtual MockExpectedCall& withCallOrder(unsigned int callOrder) _override { return withCallOrder(callOrder, callOrder); }","path":"include/CppUTestExt/MockCheckedExpectedCall.h","position":9,"original_position":9,"commit_id":"5ac48adf61450f71cf5269cf26d711262ee3ff53","original_commit_id":"5ac48adf61450f71cf5269cf26d711262ee3ff53","user":{"login":"basvodde","id":509919,"avatar_url":"https://avatars.githubusercontent.com/u/509919?v=3","gravatar_id":"","url":"https://api.github.com/users/basvodde","html_url":"https://github.com/basvodde","followers_url":"https://api.github.com/users/basvodde/followers","following_url":"https://api.github.com/users/basvodde/following{/other_user}","gists_url":"https://api.github.com/users/basvodde/gists{/gist_id}","starred_url":"https://api.github.com/users/basvodde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvodde/subscriptions","organizations_url":"https://api.github.com/users/basvodde/orgs","repos_url":"https://api.github.com/users/basvodde/repos","events_url":"https://api.github.com/users/basvodde/events{/privacy}","received_events_url":"https://api.github.com/users/basvodde/received_events","type":"User","site_admin":false},"body":"Can you avoid inline implementations, as they have caused problems in the past (on some platform)","created_at":"2016-07-17T07:37:10Z","updated_at":"2016-07-17T07:37:10Z","html_url":"https://github.com/cpputest/cpputest/pull/1023#discussion_r71078028","pull_request_url":"https://api.github.com/repos/cpputest/cpputest/pulls/1023","_links":{"self":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/comments/71078028"},"html":{"href":"https://github.com/cpputest/cpputest/pull/1023#discussion_r71078028"},"pull_request":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/1023"}}},"pull_request":{"url":"https://api.github.com/repos/cpputest/cpputest/pulls/1023","id":77527325,"html_url":"https://github.com/cpputest/cpputest/pull/1023","diff_url":"https://github.com/cpputest/cpputest/pull/1023.diff","patch_url":"https://github.com/cpputest/cpputest/pull/1023.patch","issue_url":"https://api.github.com/repos/cpputest/cpputest/issues/1023","number":1023,"state":"open","locked":false,"title":"Expected calls matching several actual calls - (3) Implementation of \"multi-matching\" expectedCalls.","user":{"login":"jgonzalezdr","id":6639296,"avatar_url":"https://avatars.githubusercontent.com/u/6639296?v=3","gravatar_id":"","url":"https://api.github.com/users/jgonzalezdr","html_url":"https://github.com/jgonzalezdr","followers_url":"https://api.github.com/users/jgonzalezdr/followers","following_url":"https://api.github.com/users/jgonzalezdr/following{/other_user}","gists_url":"https://api.github.com/users/jgonzalezdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jgonzalezdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgonzalezdr/subscriptions","organizations_url":"https://api.github.com/users/jgonzalezdr/orgs","repos_url":"https://api.github.com/users/jgonzalezdr/repos","events_url":"https://api.github.com/users/jgonzalezdr/events{/privacy}","received_events_url":"https://api.github.com/users/jgonzalezdr/received_events","type":"User","site_admin":false},"body":"This PR adds at least the initial implementation of multi-matching expected calls, but only for a fixed number of expected calls.\r\n\r\nThe basic idea is simple: An actual call is not considered to be made until _checkExpectations()_ is called on it (i.e. another actual call has been created or _checkExpectations()_ is called on the mock support), therefore _callWasMade()_ is not called on the matching expected call until there is only a single one selected (i.e. the one which fulfills the actual call). When this occurs, the corresponding count of matched actual calls on the expected call is increased.\r\n\r\nThe drawback of this is that actual calls order is not registered properly, so for the meantime\r\nfailure messages just show the expectations that were fulfilled in\r\ndeclaration order, as it has no sense anymore to order them by call\r\norder. This will be corrected in subsequent PRs.","created_at":"2016-07-14T21:15:38Z","updated_at":"2016-07-17T07:37:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6a7dc1dbaffe8860b85f0ec89b31626d9773075","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cpputest/cpputest/pulls/1023/commits","review_comments_url":"https://api.github.com/repos/cpputest/cpputest/pulls/1023/comments","review_comment_url":"https://api.github.com/repos/cpputest/cpputest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cpputest/cpputest/issues/1023/comments","statuses_url":"https://api.github.com/repos/cpputest/cpputest/statuses/5ac48adf61450f71cf5269cf26d711262ee3ff53","head":{"label":"jgonzalezdr:expected-calls-multimatch-7","ref":"expected-calls-multimatch-7","sha":"5ac48adf61450f71cf5269cf26d711262ee3ff53","user":{"login":"jgonzalezdr","id":6639296,"avatar_url":"https://avatars.githubusercontent.com/u/6639296?v=3","gravatar_id":"","url":"https://api.github.com/users/jgonzalezdr","html_url":"https://github.com/jgonzalezdr","followers_url":"https://api.github.com/users/jgonzalezdr/followers","following_url":"https://api.github.com/users/jgonzalezdr/following{/other_user}","gists_url":"https://api.github.com/users/jgonzalezdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jgonzalezdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgonzalezdr/subscriptions","organizations_url":"https://api.github.com/users/jgonzalezdr/orgs","repos_url":"https://api.github.com/users/jgonzalezdr/repos","events_url":"https://api.github.com/users/jgonzalezdr/events{/privacy}","received_events_url":"https://api.github.com/users/jgonzalezdr/received_events","type":"User","site_admin":false},"repo":{"id":35048835,"name":"cpputest","full_name":"jgonzalezdr/cpputest","owner":{"login":"jgonzalezdr","id":6639296,"avatar_url":"https://avatars.githubusercontent.com/u/6639296?v=3","gravatar_id":"","url":"https://api.github.com/users/jgonzalezdr","html_url":"https://github.com/jgonzalezdr","followers_url":"https://api.github.com/users/jgonzalezdr/followers","following_url":"https://api.github.com/users/jgonzalezdr/following{/other_user}","gists_url":"https://api.github.com/users/jgonzalezdr/gists{/gist_id}","starred_url":"https://api.github.com/users/jgonzalezdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgonzalezdr/subscriptions","organizations_url":"https://api.github.com/users/jgonzalezdr/orgs","repos_url":"https://api.github.com/users/jgonzalezdr/repos","events_url":"https://api.github.com/users/jgonzalezdr/events{/privacy}","received_events_url":"https://api.github.com/users/jgonzalezdr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgonzalezdr/cpputest","description":"CppUTest unit testing and mocking framework for C/C++","fork":true,"url":"https://api.github.com/repos/jgonzalezdr/cpputest","forks_url":"https://api.github.com/repos/jgonzalezdr/cpputest/forks","keys_url":"https://api.github.com/repos/jgonzalezdr/cpputest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgonzalezdr/cpputest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgonzalezdr/cpputest/teams","hooks_url":"https://api.github.com/repos/jgonzalezdr/cpputest/hooks","issue_events_url":"https://api.github.com/repos/jgonzalezdr/cpputest/issues/events{/number}","events_url":"https://api.github.com/repos/jgonzalezdr/cpputest/events","assignees_url":"https://api.github.com/repos/jgonzalezdr/cpputest/assignees{/user}","branches_url":"https://api.github.com/repos/jgonzalezdr/cpputest/branches{/branch}","tags_url":"https://api.github.com/repos/jgonzalezdr/cpputest/tags","blobs_url":"https://api.github.com/repos/jgonzalezdr/cpputest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgonzalezdr/cpputest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgonzalezdr/cpputest/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgonzalezdr/cpputest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgonzalezdr/cpputest/statuses/{sha}","languages_url":"https://api.github.com/repos/jgonzalezdr/cpputest/languages","stargazers_url":"https://api.github.com/repos/jgonzalezdr/cpputest/stargazers","contributors_url":"https://api.github.com/repos/jgonzalezdr/cpputest/contributors","subscribers_url":"https://api.github.com/repos/jgonzalezdr/cpputest/subscribers","subscription_url":"https://api.github.com/repos/jgonzalezdr/cpputest/subscription","commits_url":"https://api.github.com/repos/jgonzalezdr/cpputest/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgonzalezdr/cpputest/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgonzalezdr/cpputest/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgonzalezdr/cpputest/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgonzalezdr/cpputest/contents/{+path}","compare_url":"https://api.github.com/repos/jgonzalezdr/cpputest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgonzalezdr/cpputest/merges","archive_url":"https://api.github.com/repos/jgonzalezdr/cpputest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgonzalezdr/cpputest/downloads","issues_url":"https://api.github.com/repos/jgonzalezdr/cpputest/issues{/number}","pulls_url":"https://api.github.com/repos/jgonzalezdr/cpputest/pulls{/number}","milestones_url":"https://api.github.com/repos/jgonzalezdr/cpputest/milestones{/number}","notifications_url":"https://api.github.com/repos/jgonzalezdr/cpputest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgonzalezdr/cpputest/labels{/name}","releases_url":"https://api.github.com/repos/jgonzalezdr/cpputest/releases{/id}","deployments_url":"https://api.github.com/repos/jgonzalezdr/cpputest/deployments","created_at":"2015-05-04T17:27:24Z","updated_at":"2016-07-11T08:38:47Z","pushed_at":"2016-07-17T07:20:16Z","git_url":"git://github.com/jgonzalezdr/cpputest.git","ssh_url":"git@github.com:jgonzalezdr/cpputest.git","clone_url":"https://github.com/jgonzalezdr/cpputest.git","svn_url":"https://github.com/jgonzalezdr/cpputest","homepage":"http://cpputest.github.com","size":10074,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cpputest:master","ref":"master","sha":"33376c201252cf172948fae0104ffe6133f28593","user":{"login":"cpputest","id":2120339,"avatar_url":"https://avatars.githubusercontent.com/u/2120339?v=3","gravatar_id":"","url":"https://api.github.com/users/cpputest","html_url":"https://github.com/cpputest","followers_url":"https://api.github.com/users/cpputest/followers","following_url":"https://api.github.com/users/cpputest/following{/other_user}","gists_url":"https://api.github.com/users/cpputest/gists{/gist_id}","starred_url":"https://api.github.com/users/cpputest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpputest/subscriptions","organizations_url":"https://api.github.com/users/cpputest/orgs","repos_url":"https://api.github.com/users/cpputest/repos","events_url":"https://api.github.com/users/cpputest/events{/privacy}","received_events_url":"https://api.github.com/users/cpputest/received_events","type":"Organization","site_admin":false},"repo":{"id":5269602,"name":"cpputest","full_name":"cpputest/cpputest","owner":{"login":"cpputest","id":2120339,"avatar_url":"https://avatars.githubusercontent.com/u/2120339?v=3","gravatar_id":"","url":"https://api.github.com/users/cpputest","html_url":"https://github.com/cpputest","followers_url":"https://api.github.com/users/cpputest/followers","following_url":"https://api.github.com/users/cpputest/following{/other_user}","gists_url":"https://api.github.com/users/cpputest/gists{/gist_id}","starred_url":"https://api.github.com/users/cpputest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpputest/subscriptions","organizations_url":"https://api.github.com/users/cpputest/orgs","repos_url":"https://api.github.com/users/cpputest/repos","events_url":"https://api.github.com/users/cpputest/events{/privacy}","received_events_url":"https://api.github.com/users/cpputest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cpputest/cpputest","description":"CppUTest unit testing and mocking framework for C/C++","fork":false,"url":"https://api.github.com/repos/cpputest/cpputest","forks_url":"https://api.github.com/repos/cpputest/cpputest/forks","keys_url":"https://api.github.com/repos/cpputest/cpputest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpputest/cpputest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpputest/cpputest/teams","hooks_url":"https://api.github.com/repos/cpputest/cpputest/hooks","issue_events_url":"https://api.github.com/repos/cpputest/cpputest/issues/events{/number}","events_url":"https://api.github.com/repos/cpputest/cpputest/events","assignees_url":"https://api.github.com/repos/cpputest/cpputest/assignees{/user}","branches_url":"https://api.github.com/repos/cpputest/cpputest/branches{/branch}","tags_url":"https://api.github.com/repos/cpputest/cpputest/tags","blobs_url":"https://api.github.com/repos/cpputest/cpputest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpputest/cpputest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpputest/cpputest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpputest/cpputest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpputest/cpputest/statuses/{sha}","languages_url":"https://api.github.com/repos/cpputest/cpputest/languages","stargazers_url":"https://api.github.com/repos/cpputest/cpputest/stargazers","contributors_url":"https://api.github.com/repos/cpputest/cpputest/contributors","subscribers_url":"https://api.github.com/repos/cpputest/cpputest/subscribers","subscription_url":"https://api.github.com/repos/cpputest/cpputest/subscription","commits_url":"https://api.github.com/repos/cpputest/cpputest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpputest/cpputest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpputest/cpputest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpputest/cpputest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpputest/cpputest/contents/{+path}","compare_url":"https://api.github.com/repos/cpputest/cpputest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpputest/cpputest/merges","archive_url":"https://api.github.com/repos/cpputest/cpputest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpputest/cpputest/downloads","issues_url":"https://api.github.com/repos/cpputest/cpputest/issues{/number}","pulls_url":"https://api.github.com/repos/cpputest/cpputest/pulls{/number}","milestones_url":"https://api.github.com/repos/cpputest/cpputest/milestones{/number}","notifications_url":"https://api.github.com/repos/cpputest/cpputest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpputest/cpputest/labels{/name}","releases_url":"https://api.github.com/repos/cpputest/cpputest/releases{/id}","deployments_url":"https://api.github.com/repos/cpputest/cpputest/deployments","created_at":"2012-08-02T07:32:25Z","updated_at":"2016-07-15T11:06:41Z","pushed_at":"2016-07-15T09:38:07Z","git_url":"git://github.com/cpputest/cpputest.git","ssh_url":"git@github.com:cpputest/cpputest.git","clone_url":"https://github.com/cpputest/cpputest.git","svn_url":"https://github.com/cpputest/cpputest","homepage":"http://cpputest.github.com","size":12435,"stargazers_count":334,"watchers_count":334,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":190,"mirror_url":null,"open_issues_count":140,"forks":190,"open_issues":140,"watchers":334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/1023"},"html":{"href":"https://github.com/cpputest/cpputest/pull/1023"},"issue":{"href":"https://api.github.com/repos/cpputest/cpputest/issues/1023"},"comments":{"href":"https://api.github.com/repos/cpputest/cpputest/issues/1023/comments"},"review_comments":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/1023/comments"},"review_comment":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/1023/commits"},"statuses":{"href":"https://api.github.com/repos/cpputest/cpputest/statuses/5ac48adf61450f71cf5269cf26d711262ee3ff53"}}}}
{"actor":{"display_login":"basvodde"}}