{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/244","id":90436982,"html_url":"https://github.com/grpc-ecosystem/grpc-gateway/pull/244","diff_url":"https://github.com/grpc-ecosystem/grpc-gateway/pull/244.diff","patch_url":"https://github.com/grpc-ecosystem/grpc-gateway/pull/244.patch","issue_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/issues/244","number":244,"state":"closed","locked":false,"title":"Error output should have lowercase attribute names","user":{"login":"nathanborror","id":37658,"avatar_url":"https://avatars.githubusercontent.com/u/37658?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanborror","html_url":"https://github.com/nathanborror","followers_url":"https://api.github.com/users/nathanborror/followers","following_url":"https://api.github.com/users/nathanborror/following{/other_user}","gists_url":"https://api.github.com/users/nathanborror/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanborror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanborror/subscriptions","organizations_url":"https://api.github.com/users/nathanborror/orgs","repos_url":"https://api.github.com/users/nathanborror/repos","events_url":"https://api.github.com/users/nathanborror/events{/privacy}","received_events_url":"https://api.github.com/users/nathanborror/received_events","type":"User","site_admin":false},"body":"The current error output is titlecase (`{\"Error\": \"...\", \"Code\": \"...\"}`) when it should be lowercase (`{\"error\": \"...\", \"code\": \"...\"}`). This appears to be due to `errorBody` implementing `proto.Message` interface but lacking protobuf tags needed to marshal correctly. When I patch [errorBody][1] with the following I end up with correct behavior:\r\n\r\n```go\r\ntype errorBody struct {\r\n\tError string `protobuf:\"bytes,1,name=error\" json:\"error\"`\r\n\tCode  int    `protobuf:\"bytes,2,name=code\" json:\"code\"`\r\n}\r\n```\r\n[1]:https://github.com/grpc-ecosystem/grpc-gateway/blob/master/runtime/errors.go#L65\r\n","created_at":"2016-10-21T20:16:45Z","updated_at":"2016-10-25T04:45:27Z","closed_at":"2016-10-25T04:45:27Z","merged_at":"2016-10-25T04:45:27Z","merge_commit_sha":"325488925d6af252d18cc5ade7032127bc898ac7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/244/commits","review_comments_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/244/comments","review_comment_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/issues/244/comments","statuses_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/statuses/de331a0ff9cea576a5643feda008459af0b2a31b","head":{"label":"nathanborror:master","ref":"master","sha":"de331a0ff9cea576a5643feda008459af0b2a31b","user":{"login":"nathanborror","id":37658,"avatar_url":"https://avatars.githubusercontent.com/u/37658?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanborror","html_url":"https://github.com/nathanborror","followers_url":"https://api.github.com/users/nathanborror/followers","following_url":"https://api.github.com/users/nathanborror/following{/other_user}","gists_url":"https://api.github.com/users/nathanborror/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanborror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanborror/subscriptions","organizations_url":"https://api.github.com/users/nathanborror/orgs","repos_url":"https://api.github.com/users/nathanborror/repos","events_url":"https://api.github.com/users/nathanborror/events{/privacy}","received_events_url":"https://api.github.com/users/nathanborror/received_events","type":"User","site_admin":false},"repo":{"id":71593332,"name":"grpc-gateway","full_name":"nathanborror/grpc-gateway","owner":{"login":"nathanborror","id":37658,"avatar_url":"https://avatars.githubusercontent.com/u/37658?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanborror","html_url":"https://github.com/nathanborror","followers_url":"https://api.github.com/users/nathanborror/followers","following_url":"https://api.github.com/users/nathanborror/following{/other_user}","gists_url":"https://api.github.com/users/nathanborror/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanborror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanborror/subscriptions","organizations_url":"https://api.github.com/users/nathanborror/orgs","repos_url":"https://api.github.com/users/nathanborror/repos","events_url":"https://api.github.com/users/nathanborror/events{/privacy}","received_events_url":"https://api.github.com/users/nathanborror/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanborror/grpc-gateway","description":"gRPC to JSON proxy generator","fork":true,"url":"https://api.github.com/repos/nathanborror/grpc-gateway","forks_url":"https://api.github.com/repos/nathanborror/grpc-gateway/forks","keys_url":"https://api.github.com/repos/nathanborror/grpc-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanborror/grpc-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanborror/grpc-gateway/teams","hooks_url":"https://api.github.com/repos/nathanborror/grpc-gateway/hooks","issue_events_url":"https://api.github.com/repos/nathanborror/grpc-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/nathanborror/grpc-gateway/events","assignees_url":"https://api.github.com/repos/nathanborror/grpc-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/nathanborror/grpc-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/nathanborror/grpc-gateway/tags","blobs_url":"https://api.github.com/repos/nathanborror/grpc-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanborror/grpc-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanborror/grpc-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanborror/grpc-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanborror/grpc-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanborror/grpc-gateway/languages","stargazers_url":"https://api.github.com/repos/nathanborror/grpc-gateway/stargazers","contributors_url":"https://api.github.com/repos/nathanborror/grpc-gateway/contributors","subscribers_url":"https://api.github.com/repos/nathanborror/grpc-gateway/subscribers","subscription_url":"https://api.github.com/repos/nathanborror/grpc-gateway/subscription","commits_url":"https://api.github.com/repos/nathanborror/grpc-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanborror/grpc-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanborror/grpc-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanborror/grpc-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanborror/grpc-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/nathanborror/grpc-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanborror/grpc-gateway/merges","archive_url":"https://api.github.com/repos/nathanborror/grpc-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanborror/grpc-gateway/downloads","issues_url":"https://api.github.com/repos/nathanborror/grpc-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/nathanborror/grpc-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanborror/grpc-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanborror/grpc-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanborror/grpc-gateway/labels{/name}","releases_url":"https://api.github.com/repos/nathanborror/grpc-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/nathanborror/grpc-gateway/deployments","created_at":"2016-10-21T20:12:51Z","updated_at":"2016-10-21T20:12:53Z","pushed_at":"2016-10-21T20:15:30Z","git_url":"git://github.com/nathanborror/grpc-gateway.git","ssh_url":"git@github.com:nathanborror/grpc-gateway.git","clone_url":"https://github.com/nathanborror/grpc-gateway.git","svn_url":"https://github.com/nathanborror/grpc-gateway","homepage":null,"size":792,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc-ecosystem:master","ref":"master","sha":"1185a73676418404924d2bcd707a2a40ee7176eb","user":{"login":"grpc-ecosystem","id":19352526,"avatar_url":"https://avatars.githubusercontent.com/u/19352526?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc-ecosystem","html_url":"https://github.com/grpc-ecosystem","followers_url":"https://api.github.com/users/grpc-ecosystem/followers","following_url":"https://api.github.com/users/grpc-ecosystem/following{/other_user}","gists_url":"https://api.github.com/users/grpc-ecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc-ecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc-ecosystem/subscriptions","organizations_url":"https://api.github.com/users/grpc-ecosystem/orgs","repos_url":"https://api.github.com/users/grpc-ecosystem/repos","events_url":"https://api.github.com/users/grpc-ecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/grpc-ecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":33352201,"name":"grpc-gateway","full_name":"grpc-ecosystem/grpc-gateway","owner":{"login":"grpc-ecosystem","id":19352526,"avatar_url":"https://avatars.githubusercontent.com/u/19352526?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc-ecosystem","html_url":"https://github.com/grpc-ecosystem","followers_url":"https://api.github.com/users/grpc-ecosystem/followers","following_url":"https://api.github.com/users/grpc-ecosystem/following{/other_user}","gists_url":"https://api.github.com/users/grpc-ecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc-ecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc-ecosystem/subscriptions","organizations_url":"https://api.github.com/users/grpc-ecosystem/orgs","repos_url":"https://api.github.com/users/grpc-ecosystem/repos","events_url":"https://api.github.com/users/grpc-ecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/grpc-ecosystem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc-ecosystem/grpc-gateway","description":"gRPC to JSON proxy generator","fork":false,"url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway","forks_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/forks","keys_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/teams","hooks_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/hooks","issue_events_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/events","assignees_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/tags","blobs_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/languages","stargazers_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/stargazers","contributors_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/contributors","subscribers_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/subscribers","subscription_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/subscription","commits_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/merges","archive_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/downloads","issues_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/labels{/name}","releases_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/deployments","created_at":"2015-04-03T07:25:13Z","updated_at":"2016-10-25T02:21:59Z","pushed_at":"2016-10-25T04:45:27Z","git_url":"git://github.com/grpc-ecosystem/grpc-gateway.git","ssh_url":"git@github.com:grpc-ecosystem/grpc-gateway.git","clone_url":"https://github.com/grpc-ecosystem/grpc-gateway.git","svn_url":"https://github.com/grpc-ecosystem/grpc-gateway","homepage":null,"size":857,"stargazers_count":943,"watchers_count":943,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":42,"forks":122,"open_issues":42,"watchers":943,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/244"},"html":{"href":"https://github.com/grpc-ecosystem/grpc-gateway/pull/244"},"issue":{"href":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/issues/244"},"comments":{"href":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/grpc-ecosystem/grpc-gateway/statuses/de331a0ff9cea576a5643feda008459af0b2a31b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yugui","id":8161,"avatar_url":"https://avatars.githubusercontent.com/u/8161?v=3","gravatar_id":"","url":"https://api.github.com/users/yugui","html_url":"https://github.com/yugui","followers_url":"https://api.github.com/users/yugui/followers","following_url":"https://api.github.com/users/yugui/following{/other_user}","gists_url":"https://api.github.com/users/yugui/gists{/gist_id}","starred_url":"https://api.github.com/users/yugui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugui/subscriptions","organizations_url":"https://api.github.com/users/yugui/orgs","repos_url":"https://api.github.com/users/yugui/repos","events_url":"https://api.github.com/users/yugui/events{/privacy}","received_events_url":"https://api.github.com/users/yugui/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"yugui"}}