{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/18384","repository_url":"https://api.github.com/repos/JuliaLang/julia","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/18384/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/18384/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/18384/events","html_url":"https://github.com/JuliaLang/julia/issues/18384","id":175380818,"number":18384,"title":"Remove conv2 from Base?","user":{"login":"tlnagy","id":1661487,"avatar_url":"https://avatars.githubusercontent.com/u/1661487?v=3","gravatar_id":"","url":"https://api.github.com/users/tlnagy","html_url":"https://github.com/tlnagy","followers_url":"https://api.github.com/users/tlnagy/followers","following_url":"https://api.github.com/users/tlnagy/following{/other_user}","gists_url":"https://api.github.com/users/tlnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/tlnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlnagy/subscriptions","organizations_url":"https://api.github.com/users/tlnagy/orgs","repos_url":"https://api.github.com/users/tlnagy/repos","events_url":"https://api.github.com/users/tlnagy/events{/privacy}","received_events_url":"https://api.github.com/users/tlnagy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JuliaLang/julia/labels/breaking","name":"breaking","color":"800000"},{"url":"https://api.github.com/repos/JuliaLang/julia/labels/Hacktoberfest","name":"Hacktoberfest","color":"d93f0b"},{"url":"https://api.github.com/repos/JuliaLang/julia/labels/intro%20issue","name":"intro issue","color":"0052cc"},{"url":"https://api.github.com/repos/JuliaLang/julia/labels/up%20for%20grabs","name":"up for grabs","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/20","html_url":"https://github.com/JuliaLang/julia/milestones/0.6.0","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/20/labels","id":1298021,"number":20,"title":"0.6.0","description":"","creator":{"login":"JeffBezanson","id":744556,"avatar_url":"https://avatars.githubusercontent.com/u/744556?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffBezanson","html_url":"https://github.com/JeffBezanson","followers_url":"https://api.github.com/users/JeffBezanson/followers","following_url":"https://api.github.com/users/JeffBezanson/following{/other_user}","gists_url":"https://api.github.com/users/JeffBezanson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBezanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBezanson/subscriptions","organizations_url":"https://api.github.com/users/JeffBezanson/orgs","repos_url":"https://api.github.com/users/JeffBezanson/repos","events_url":"https://api.github.com/users/JeffBezanson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBezanson/received_events","type":"User","site_admin":false},"open_issues":205,"closed_issues":31,"state":"open","created_at":"2015-09-09T16:35:16Z","updated_at":"2016-10-12T15:47:55Z","due_on":"2017-01-31T00:00:00Z","closed_at":null},"comments":29,"created_at":"2016-09-07T00:01:30Z","updated_at":"2016-10-12T16:25:14Z","closed_at":null,"body":"Julia's `conv2` is much slower than Matlab's (~100x):\r\n\r\nJulia v0.5-rc3\r\n```julia\r\njulia> img = rand(1024,1024);\r\n\r\njulia> @benchmark conv2(img, [-1 0 1; -2 0 2; -1 0 1.])\r\nBenchmarkTools.Trial:\r\n  samples:          8\r\n  evals/sample:     1\r\n  time tolerance:   5.00%\r\n  memory tolerance: 1.00%\r\n  memory estimate:  136.54 mb\r\n  allocs estimate:  235\r\n  minimum time:     613.07 ms (0.99% GC)\r\n  median time:      664.07 ms (8.41% GC)\r\n  mean time:        669.47 ms (8.98% GC)\r\n  maximum time:     749.12 ms (17.76% GC)\r\n\r\njulia> versioninfo()\r\nJulia Version 0.5.0-rc3+0\r\nCommit e6f843b (2016-08-22 23:43 UTC)\r\nPlatform Info:\r\n  System: Darwin (x86_64-apple-darwin13.4.0)\r\n  CPU: Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz\r\n  WORD_SIZE: 64\r\n  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)\r\n  LAPACK: libopenblas64_\r\n  LIBM: libopenlibm\r\n  LLVM: libLLVM-3.7.1 (ORCJIT, haswell)\r\n```\r\n\r\nMatlab 2015b\r\n```matlab\r\n>> img = rand(1024, 1024);\r\n>> tic(); conv2(img, [-1 0 1; -2 0 2; -1 0 1.]); toc();\r\nElapsed time is 0.005330 seconds.\r\n```"},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/253263706","html_url":"https://github.com/JuliaLang/julia/issues/18384#issuecomment-253263706","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/18384","id":253263706,"user":{"login":"JeffBezanson","id":744556,"avatar_url":"https://avatars.githubusercontent.com/u/744556?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffBezanson","html_url":"https://github.com/JeffBezanson","followers_url":"https://api.github.com/users/JeffBezanson/followers","following_url":"https://api.github.com/users/JeffBezanson/following{/other_user}","gists_url":"https://api.github.com/users/JeffBezanson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBezanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBezanson/subscriptions","organizations_url":"https://api.github.com/users/JeffBezanson/orgs","repos_url":"https://api.github.com/users/JeffBezanson/repos","events_url":"https://api.github.com/users/JeffBezanson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBezanson/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T16:25:14Z","updated_at":"2016-10-12T16:25:14Z","body":"Ok, let's plan to remove dsp.jl from Base:\r\n\r\n- filt and filt! can point directly to the DSP package\r\n- \"basically the same\" is not \"exactly the same\". Does DSP.jl need to add a `conv` function?\r\n- Deconvolution.jl seems to contain exactly one function, which is great, but makes me wonder whether it makes sense to add to it. Maybe that package should be called WienerDeconvolution.jl?\r\n- Can we add a wrapper in ImageFiltering.jl that behaves like `conv2`?\r\n- xcorr can point directly to StatsBase\r\n"}}
{"actor":{"display_login":"JeffBezanson"}}