{"action":"created","comment":{"url":"https://api.github.com/repos/basilfx/phinx/pulls/comments/87336121","pull_request_review_id":7952233,"id":87336121,"diff_hunk":"@@ -857,6 +864,9 @@ public function getSqlType($type, $limit = null)\n             case static::PHINX_TYPE_FLOAT:\n                 return array('name' => 'float');\n                 break;\n+            case static::PHINX_TYPE_DOUBLE:","path":"src/Phinx/Db/Adapter/MysqlAdapter.php","position":68,"original_position":48,"commit_id":"05524cb65bac1c1e2e414e43d8158f6a8cddebf3","original_commit_id":"8904d29516018cd72611aba9333c4548f556e065","user":{"login":"basilfx","id":815976,"avatar_url":"https://avatars.githubusercontent.com/u/815976?v=3","gravatar_id":"","url":"https://api.github.com/users/basilfx","html_url":"https://github.com/basilfx","followers_url":"https://api.github.com/users/basilfx/followers","following_url":"https://api.github.com/users/basilfx/following{/other_user}","gists_url":"https://api.github.com/users/basilfx/gists{/gist_id}","starred_url":"https://api.github.com/users/basilfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basilfx/subscriptions","organizations_url":"https://api.github.com/users/basilfx/orgs","repos_url":"https://api.github.com/users/basilfx/repos","events_url":"https://api.github.com/users/basilfx/events{/privacy}","received_events_url":"https://api.github.com/users/basilfx/received_events","type":"User","site_admin":false},"body":"I think this would be better in a separate PR.","created_at":"2016-11-10T06:39:53Z","updated_at":"2016-11-10T06:41:13Z","html_url":"https://github.com/basilfx/phinx/pull/1#discussion_r87336121","pull_request_url":"https://api.github.com/repos/basilfx/phinx/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/basilfx/phinx/pulls/comments/87336121"},"html":{"href":"https://github.com/basilfx/phinx/pull/1#discussion_r87336121"},"pull_request":{"href":"https://api.github.com/repos/basilfx/phinx/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/basilfx/phinx/pulls/1","id":91506743,"html_url":"https://github.com/basilfx/phinx/pull/1","diff_url":"https://github.com/basilfx/phinx/pull/1.diff","patch_url":"https://github.com/basilfx/phinx/pull/1.patch","issue_url":"https://api.github.com/repos/basilfx/phinx/issues/1","number":1,"state":"open","locked":false,"title":"indexes for mysql schema dump","user":{"login":"jwh315","id":2006555,"avatar_url":"https://avatars.githubusercontent.com/u/2006555?v=3","gravatar_id":"","url":"https://api.github.com/users/jwh315","html_url":"https://github.com/jwh315","followers_url":"https://api.github.com/users/jwh315/followers","following_url":"https://api.github.com/users/jwh315/following{/other_user}","gists_url":"https://api.github.com/users/jwh315/gists{/gist_id}","starred_url":"https://api.github.com/users/jwh315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwh315/subscriptions","organizations_url":"https://api.github.com/users/jwh315/orgs","repos_url":"https://api.github.com/users/jwh315/repos","events_url":"https://api.github.com/users/jwh315/events{/privacy}","received_events_url":"https://api.github.com/users/jwh315/received_events","type":"User","site_admin":false},"body":"I ran across your schema dump/load feature for phinx a few weeks ago.  I really love your implementation but really needed indexes.  I was able to get the indexes put into the mysql adapter pretty easily.  \n\nI have a pretty decent size dev database (over 700 tables) at my company, that has an array of ridiculous design inconsistencies from years of development.  The indexing seems to be recreating tables 100% from their original state, so I am fairly confident that I have covered most edge cases related to indexing and phinx.\n\nNot sure if you would be interested in merging this branch into yours, or if you would need more from my end before doing so.\n\nEither way, thanks for the effort putting this schema dumper together, it has saved me several hours worth of work.\n","created_at":"2016-10-30T00:31:55Z","updated_at":"2016-11-10T06:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93e53fe3db3d205c5ed7bbc5196b95fa2851b9cb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/basilfx/phinx/pulls/1/commits","review_comments_url":"https://api.github.com/repos/basilfx/phinx/pulls/1/comments","review_comment_url":"https://api.github.com/repos/basilfx/phinx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basilfx/phinx/issues/1/comments","statuses_url":"https://api.github.com/repos/basilfx/phinx/statuses/05524cb65bac1c1e2e414e43d8158f6a8cddebf3","head":{"label":"jwh315:0.7.x-dev","ref":"0.7.x-dev","sha":"05524cb65bac1c1e2e414e43d8158f6a8cddebf3","user":{"login":"jwh315","id":2006555,"avatar_url":"https://avatars.githubusercontent.com/u/2006555?v=3","gravatar_id":"","url":"https://api.github.com/users/jwh315","html_url":"https://github.com/jwh315","followers_url":"https://api.github.com/users/jwh315/followers","following_url":"https://api.github.com/users/jwh315/following{/other_user}","gists_url":"https://api.github.com/users/jwh315/gists{/gist_id}","starred_url":"https://api.github.com/users/jwh315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwh315/subscriptions","organizations_url":"https://api.github.com/users/jwh315/orgs","repos_url":"https://api.github.com/users/jwh315/repos","events_url":"https://api.github.com/users/jwh315/events{/privacy}","received_events_url":"https://api.github.com/users/jwh315/received_events","type":"User","site_admin":false},"repo":{"id":72266937,"name":"phinx","full_name":"jwh315/phinx","owner":{"login":"jwh315","id":2006555,"avatar_url":"https://avatars.githubusercontent.com/u/2006555?v=3","gravatar_id":"","url":"https://api.github.com/users/jwh315","html_url":"https://github.com/jwh315","followers_url":"https://api.github.com/users/jwh315/followers","following_url":"https://api.github.com/users/jwh315/following{/other_user}","gists_url":"https://api.github.com/users/jwh315/gists{/gist_id}","starred_url":"https://api.github.com/users/jwh315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwh315/subscriptions","organizations_url":"https://api.github.com/users/jwh315/orgs","repos_url":"https://api.github.com/users/jwh315/repos","events_url":"https://api.github.com/users/jwh315/events{/privacy}","received_events_url":"https://api.github.com/users/jwh315/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwh315/phinx","description":"PHP Database Migrations for Everyone","fork":true,"url":"https://api.github.com/repos/jwh315/phinx","forks_url":"https://api.github.com/repos/jwh315/phinx/forks","keys_url":"https://api.github.com/repos/jwh315/phinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwh315/phinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwh315/phinx/teams","hooks_url":"https://api.github.com/repos/jwh315/phinx/hooks","issue_events_url":"https://api.github.com/repos/jwh315/phinx/issues/events{/number}","events_url":"https://api.github.com/repos/jwh315/phinx/events","assignees_url":"https://api.github.com/repos/jwh315/phinx/assignees{/user}","branches_url":"https://api.github.com/repos/jwh315/phinx/branches{/branch}","tags_url":"https://api.github.com/repos/jwh315/phinx/tags","blobs_url":"https://api.github.com/repos/jwh315/phinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwh315/phinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwh315/phinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwh315/phinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwh315/phinx/statuses/{sha}","languages_url":"https://api.github.com/repos/jwh315/phinx/languages","stargazers_url":"https://api.github.com/repos/jwh315/phinx/stargazers","contributors_url":"https://api.github.com/repos/jwh315/phinx/contributors","subscribers_url":"https://api.github.com/repos/jwh315/phinx/subscribers","subscription_url":"https://api.github.com/repos/jwh315/phinx/subscription","commits_url":"https://api.github.com/repos/jwh315/phinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwh315/phinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwh315/phinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwh315/phinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwh315/phinx/contents/{+path}","compare_url":"https://api.github.com/repos/jwh315/phinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwh315/phinx/merges","archive_url":"https://api.github.com/repos/jwh315/phinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwh315/phinx/downloads","issues_url":"https://api.github.com/repos/jwh315/phinx/issues{/number}","pulls_url":"https://api.github.com/repos/jwh315/phinx/pulls{/number}","milestones_url":"https://api.github.com/repos/jwh315/phinx/milestones{/number}","notifications_url":"https://api.github.com/repos/jwh315/phinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwh315/phinx/labels{/name}","releases_url":"https://api.github.com/repos/jwh315/phinx/releases{/id}","deployments_url":"https://api.github.com/repos/jwh315/phinx/deployments","created_at":"2016-10-29T05:31:47Z","updated_at":"2016-10-29T05:31:48Z","pushed_at":"2016-10-30T00:15:58Z","git_url":"git://github.com/jwh315/phinx.git","ssh_url":"git@github.com:jwh315/phinx.git","clone_url":"https://github.com/jwh315/phinx.git","svn_url":"https://github.com/jwh315/phinx","homepage":"https://phinx.org","size":3800,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.6.x-dev"}},"base":{"label":"basilfx:0.7.x-dev","ref":"0.7.x-dev","sha":"2edf86092de87c0478126cfe02c7c406fba8aa96","user":{"login":"basilfx","id":815976,"avatar_url":"https://avatars.githubusercontent.com/u/815976?v=3","gravatar_id":"","url":"https://api.github.com/users/basilfx","html_url":"https://github.com/basilfx","followers_url":"https://api.github.com/users/basilfx/followers","following_url":"https://api.github.com/users/basilfx/following{/other_user}","gists_url":"https://api.github.com/users/basilfx/gists{/gist_id}","starred_url":"https://api.github.com/users/basilfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basilfx/subscriptions","organizations_url":"https://api.github.com/users/basilfx/orgs","repos_url":"https://api.github.com/users/basilfx/repos","events_url":"https://api.github.com/users/basilfx/events{/privacy}","received_events_url":"https://api.github.com/users/basilfx/received_events","type":"User","site_admin":false},"repo":{"id":61277772,"name":"phinx","full_name":"basilfx/phinx","owner":{"login":"basilfx","id":815976,"avatar_url":"https://avatars.githubusercontent.com/u/815976?v=3","gravatar_id":"","url":"https://api.github.com/users/basilfx","html_url":"https://github.com/basilfx","followers_url":"https://api.github.com/users/basilfx/followers","following_url":"https://api.github.com/users/basilfx/following{/other_user}","gists_url":"https://api.github.com/users/basilfx/gists{/gist_id}","starred_url":"https://api.github.com/users/basilfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basilfx/subscriptions","organizations_url":"https://api.github.com/users/basilfx/orgs","repos_url":"https://api.github.com/users/basilfx/repos","events_url":"https://api.github.com/users/basilfx/events{/privacy}","received_events_url":"https://api.github.com/users/basilfx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basilfx/phinx","description":"PHP Database Migrations for Everyone","fork":true,"url":"https://api.github.com/repos/basilfx/phinx","forks_url":"https://api.github.com/repos/basilfx/phinx/forks","keys_url":"https://api.github.com/repos/basilfx/phinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basilfx/phinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basilfx/phinx/teams","hooks_url":"https://api.github.com/repos/basilfx/phinx/hooks","issue_events_url":"https://api.github.com/repos/basilfx/phinx/issues/events{/number}","events_url":"https://api.github.com/repos/basilfx/phinx/events","assignees_url":"https://api.github.com/repos/basilfx/phinx/assignees{/user}","branches_url":"https://api.github.com/repos/basilfx/phinx/branches{/branch}","tags_url":"https://api.github.com/repos/basilfx/phinx/tags","blobs_url":"https://api.github.com/repos/basilfx/phinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basilfx/phinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basilfx/phinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/basilfx/phinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basilfx/phinx/statuses/{sha}","languages_url":"https://api.github.com/repos/basilfx/phinx/languages","stargazers_url":"https://api.github.com/repos/basilfx/phinx/stargazers","contributors_url":"https://api.github.com/repos/basilfx/phinx/contributors","subscribers_url":"https://api.github.com/repos/basilfx/phinx/subscribers","subscription_url":"https://api.github.com/repos/basilfx/phinx/subscription","commits_url":"https://api.github.com/repos/basilfx/phinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/basilfx/phinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/basilfx/phinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/basilfx/phinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/basilfx/phinx/contents/{+path}","compare_url":"https://api.github.com/repos/basilfx/phinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basilfx/phinx/merges","archive_url":"https://api.github.com/repos/basilfx/phinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basilfx/phinx/downloads","issues_url":"https://api.github.com/repos/basilfx/phinx/issues{/number}","pulls_url":"https://api.github.com/repos/basilfx/phinx/pulls{/number}","milestones_url":"https://api.github.com/repos/basilfx/phinx/milestones{/number}","notifications_url":"https://api.github.com/repos/basilfx/phinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basilfx/phinx/labels{/name}","releases_url":"https://api.github.com/repos/basilfx/phinx/releases{/id}","deployments_url":"https://api.github.com/repos/basilfx/phinx/deployments","created_at":"2016-06-16T08:56:23Z","updated_at":"2016-06-16T08:56:24Z","pushed_at":"2016-10-30T00:31:55Z","git_url":"git://github.com/basilfx/phinx.git","ssh_url":"git@github.com:basilfx/phinx.git","clone_url":"https://github.com/basilfx/phinx.git","svn_url":"https://github.com/basilfx/phinx","homepage":"https://phinx.org","size":3803,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"0.6.x-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/basilfx/phinx/pulls/1"},"html":{"href":"https://github.com/basilfx/phinx/pull/1"},"issue":{"href":"https://api.github.com/repos/basilfx/phinx/issues/1"},"comments":{"href":"https://api.github.com/repos/basilfx/phinx/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/basilfx/phinx/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/basilfx/phinx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basilfx/phinx/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/basilfx/phinx/statuses/05524cb65bac1c1e2e414e43d8158f6a8cddebf3"}}}}
{"actor":{"display_login":"basilfx"}}