{"action":"closed","number":666,"pull_request":{"url":"https://api.github.com/repos/eclipse/rdf4j/pulls/666","id":95095709,"html_url":"https://github.com/eclipse/rdf4j/pull/666","diff_url":"https://github.com/eclipse/rdf4j/pull/666.diff","patch_url":"https://github.com/eclipse/rdf4j/pull/666.patch","issue_url":"https://api.github.com/repos/eclipse/rdf4j/issues/666","number":666,"state":"closed","locked":false,"title":"issue #449 : Add support for BCP47, and use by default","user":{"login":"ansell","id":82365,"avatar_url":"https://avatars.githubusercontent.com/u/82365?v=3","gravatar_id":"","url":"https://api.github.com/users/ansell","html_url":"https://github.com/ansell","followers_url":"https://api.github.com/users/ansell/followers","following_url":"https://api.github.com/users/ansell/following{/other_user}","gists_url":"https://api.github.com/users/ansell/gists{/gist_id}","starred_url":"https://api.github.com/users/ansell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansell/subscriptions","organizations_url":"https://api.github.com/users/ansell/orgs","repos_url":"https://api.github.com/users/ansell/repos","events_url":"https://api.github.com/users/ansell/events{/privacy}","received_events_url":"https://api.github.com/users/ansell/received_events","type":"User","site_admin":false},"body":"This PR addresses GitHub issue: #449 to support BCP47.\r\n\r\nBriefly describe the changes proposed in this PR:\r\n\r\n* Adds implementation of BCP47 based on Java-7+ Locale\r\n* Switches BasicParserSettings to use BCP47 by default, per our reliance on RDF-1.1\r\n\r\nRFC3066 is now only used if it is specifically setup in parser settings, or referenced directly.\r\n\r\nThe use of BCP47 is required for RDF-1.1, where RFC3066 was required for RDF-1.0. Since we have changed to RDF-1.1, we need to change the default language tag handler to match.\r\n\r\nI still want to add some regression tests related to issue #665 and other language tag case-sensitivity issues to verify and preserve the new BCP47 behaviour unless we change the regression test, but the core implementation of BCP47 ```new Locale.Builder().setLanguageTag(languageTag).build().toLanguageTag()```, is done.\r\n\r\nSigned-off-by: Peter Ansell <p_ansell@yahoo.com>","created_at":"2016-11-23T23:29:17Z","updated_at":"2016-11-25T05:42:28Z","closed_at":"2016-11-25T05:42:28Z","merged_at":"2016-11-25T05:42:28Z","merge_commit_sha":"67497c19822c08b8ad142ca4ed3d283cb92c14ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/rdf4j/pulls/666/commits","review_comments_url":"https://api.github.com/repos/eclipse/rdf4j/pulls/666/comments","review_comment_url":"https://api.github.com/repos/eclipse/rdf4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/rdf4j/issues/666/comments","statuses_url":"https://api.github.com/repos/eclipse/rdf4j/statuses/d787b8f59da58e5039d56b26a008c1f1466e63ae","head":{"label":"ansell:issues/#449-bcp47-languagetags","ref":"issues/#449-bcp47-languagetags","sha":"d787b8f59da58e5039d56b26a008c1f1466e63ae","user":{"login":"ansell","id":82365,"avatar_url":"https://avatars.githubusercontent.com/u/82365?v=3","gravatar_id":"","url":"https://api.github.com/users/ansell","html_url":"https://github.com/ansell","followers_url":"https://api.github.com/users/ansell/followers","following_url":"https://api.github.com/users/ansell/following{/other_user}","gists_url":"https://api.github.com/users/ansell/gists{/gist_id}","starred_url":"https://api.github.com/users/ansell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansell/subscriptions","organizations_url":"https://api.github.com/users/ansell/orgs","repos_url":"https://api.github.com/users/ansell/repos","events_url":"https://api.github.com/users/ansell/events{/privacy}","received_events_url":"https://api.github.com/users/ansell/received_events","type":"User","site_admin":false},"repo":{"id":49758237,"name":"rdf4j","full_name":"ansell/rdf4j","owner":{"login":"ansell","id":82365,"avatar_url":"https://avatars.githubusercontent.com/u/82365?v=3","gravatar_id":"","url":"https://api.github.com/users/ansell","html_url":"https://github.com/ansell","followers_url":"https://api.github.com/users/ansell/followers","following_url":"https://api.github.com/users/ansell/following{/other_user}","gists_url":"https://api.github.com/users/ansell/gists{/gist_id}","starred_url":"https://api.github.com/users/ansell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansell/subscriptions","organizations_url":"https://api.github.com/users/ansell/orgs","repos_url":"https://api.github.com/users/ansell/repos","events_url":"https://api.github.com/users/ansell/events{/privacy}","received_events_url":"https://api.github.com/users/ansell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ansell/rdf4j","description":"RDF4J Project","fork":true,"url":"https://api.github.com/repos/ansell/rdf4j","forks_url":"https://api.github.com/repos/ansell/rdf4j/forks","keys_url":"https://api.github.com/repos/ansell/rdf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansell/rdf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansell/rdf4j/teams","hooks_url":"https://api.github.com/repos/ansell/rdf4j/hooks","issue_events_url":"https://api.github.com/repos/ansell/rdf4j/issues/events{/number}","events_url":"https://api.github.com/repos/ansell/rdf4j/events","assignees_url":"https://api.github.com/repos/ansell/rdf4j/assignees{/user}","branches_url":"https://api.github.com/repos/ansell/rdf4j/branches{/branch}","tags_url":"https://api.github.com/repos/ansell/rdf4j/tags","blobs_url":"https://api.github.com/repos/ansell/rdf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansell/rdf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansell/rdf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansell/rdf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansell/rdf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/ansell/rdf4j/languages","stargazers_url":"https://api.github.com/repos/ansell/rdf4j/stargazers","contributors_url":"https://api.github.com/repos/ansell/rdf4j/contributors","subscribers_url":"https://api.github.com/repos/ansell/rdf4j/subscribers","subscription_url":"https://api.github.com/repos/ansell/rdf4j/subscription","commits_url":"https://api.github.com/repos/ansell/rdf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansell/rdf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansell/rdf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansell/rdf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansell/rdf4j/contents/{+path}","compare_url":"https://api.github.com/repos/ansell/rdf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansell/rdf4j/merges","archive_url":"https://api.github.com/repos/ansell/rdf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansell/rdf4j/downloads","issues_url":"https://api.github.com/repos/ansell/rdf4j/issues{/number}","pulls_url":"https://api.github.com/repos/ansell/rdf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/ansell/rdf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/ansell/rdf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansell/rdf4j/labels{/name}","releases_url":"https://api.github.com/repos/ansell/rdf4j/releases{/id}","deployments_url":"https://api.github.com/repos/ansell/rdf4j/deployments","created_at":"2016-01-16T03:53:42Z","updated_at":"2016-01-16T03:53:48Z","pushed_at":"2016-11-25T01:27:02Z","git_url":"git://github.com/ansell/rdf4j.git","ssh_url":"git@github.com:ansell/rdf4j.git","clone_url":"https://github.com/ansell/rdf4j.git","svn_url":"https://github.com/ansell/rdf4j","homepage":null,"size":9900,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"0bdc5893a5b4182ac53ae49e09a8ac7e43f668f6","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":49670957,"name":"rdf4j","full_name":"eclipse/rdf4j","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/rdf4j","description":"RDF4J Project","fork":false,"url":"https://api.github.com/repos/eclipse/rdf4j","forks_url":"https://api.github.com/repos/eclipse/rdf4j/forks","keys_url":"https://api.github.com/repos/eclipse/rdf4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/rdf4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/rdf4j/teams","hooks_url":"https://api.github.com/repos/eclipse/rdf4j/hooks","issue_events_url":"https://api.github.com/repos/eclipse/rdf4j/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/rdf4j/events","assignees_url":"https://api.github.com/repos/eclipse/rdf4j/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/rdf4j/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/rdf4j/tags","blobs_url":"https://api.github.com/repos/eclipse/rdf4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/rdf4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/rdf4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/rdf4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/rdf4j/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/rdf4j/languages","stargazers_url":"https://api.github.com/repos/eclipse/rdf4j/stargazers","contributors_url":"https://api.github.com/repos/eclipse/rdf4j/contributors","subscribers_url":"https://api.github.com/repos/eclipse/rdf4j/subscribers","subscription_url":"https://api.github.com/repos/eclipse/rdf4j/subscription","commits_url":"https://api.github.com/repos/eclipse/rdf4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/rdf4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/rdf4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/rdf4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/rdf4j/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/rdf4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/rdf4j/merges","archive_url":"https://api.github.com/repos/eclipse/rdf4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/rdf4j/downloads","issues_url":"https://api.github.com/repos/eclipse/rdf4j/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/rdf4j/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/rdf4j/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/rdf4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/rdf4j/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/rdf4j/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/rdf4j/deployments","created_at":"2016-01-14T19:47:32Z","updated_at":"2016-11-19T00:06:53Z","pushed_at":"2016-11-25T05:42:28Z","git_url":"git://github.com/eclipse/rdf4j.git","ssh_url":"git@github.com:eclipse/rdf4j.git","clone_url":"https://github.com/eclipse/rdf4j.git","svn_url":"https://github.com/eclipse/rdf4j","homepage":null,"size":10427,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":269,"forks":19,"open_issues":269,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/rdf4j/pulls/666"},"html":{"href":"https://github.com/eclipse/rdf4j/pull/666"},"issue":{"href":"https://api.github.com/repos/eclipse/rdf4j/issues/666"},"comments":{"href":"https://api.github.com/repos/eclipse/rdf4j/issues/666/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/rdf4j/pulls/666/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/rdf4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/rdf4j/pulls/666/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/rdf4j/statuses/d787b8f59da58e5039d56b26a008c1f1466e63ae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeenbroekstra","id":728776,"avatar_url":"https://avatars.githubusercontent.com/u/728776?v=3","gravatar_id":"","url":"https://api.github.com/users/jeenbroekstra","html_url":"https://github.com/jeenbroekstra","followers_url":"https://api.github.com/users/jeenbroekstra/followers","following_url":"https://api.github.com/users/jeenbroekstra/following{/other_user}","gists_url":"https://api.github.com/users/jeenbroekstra/gists{/gist_id}","starred_url":"https://api.github.com/users/jeenbroekstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeenbroekstra/subscriptions","organizations_url":"https://api.github.com/users/jeenbroekstra/orgs","repos_url":"https://api.github.com/users/jeenbroekstra/repos","events_url":"https://api.github.com/users/jeenbroekstra/events{/privacy}","received_events_url":"https://api.github.com/users/jeenbroekstra/received_events","type":"User","site_admin":false},"comments":0,"review_comments":11,"commits":5,"additions":201,"deletions":33,"changed_files":6}}
{"actor":{"display_login":"jeenbroekstra"}}