{"action":"created","comment":{"url":"https://api.github.com/repos/msmbuilder/osprey/pulls/comments/57765848","id":57765848,"diff_hunk":"@@ -30,17 +30,18 @@ def __init__(self):\n     def n_dims(self):\n         return len(self.variables)\n \n-    def add_jump(self, name, min, max, step):\n+    def add_jump(self, name, min, max, step, type=float):\n         \"\"\" An integer/float valued dimension bounded between\n         range(min,max,step). Note that the right endpoint of the interval\n-        includes `max`. This is a wrapper around the add_enum.\n+        includes `max`. This is a wrapper around the add_enum. It assumes\n+        that the jump is float but can also use ints. \n         \"\"\"\n         try:\n-            min, max, step = map(float, (min, max, step))\n+            min, max, step = map(type, (min, max, step))\n         except:\n             raise ValueError('Variable %s must be either an int or a float'\n                              % name)\n-        choices = np.arange(min, max + 1, step)\n+        choices = np.arange(min, max, step)","path":"osprey/search_space.py","position":19,"original_position":19,"commit_id":"66ea06fac33344076d4c51e65f0cb58bd6ef0a86","original_commit_id":"66ea06fac33344076d4c51e65f0cb58bd6ef0a86","user":{"login":"msultan","id":3597136,"avatar_url":"https://avatars.githubusercontent.com/u/3597136?v=3","gravatar_id":"","url":"https://api.github.com/users/msultan","html_url":"https://github.com/msultan","followers_url":"https://api.github.com/users/msultan/followers","following_url":"https://api.github.com/users/msultan/following{/other_user}","gists_url":"https://api.github.com/users/msultan/gists{/gist_id}","starred_url":"https://api.github.com/users/msultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msultan/subscriptions","organizations_url":"https://api.github.com/users/msultan/orgs","repos_url":"https://api.github.com/users/msultan/repos","events_url":"https://api.github.com/users/msultan/events{/privacy}","received_events_url":"https://api.github.com/users/msultan/received_events","type":"User","site_admin":false},"body":"+1 ","created_at":"2016-03-29T17:39:05Z","updated_at":"2016-03-29T17:39:05Z","html_url":"https://github.com/msmbuilder/osprey/pull/130#discussion_r57765848","pull_request_url":"https://api.github.com/repos/msmbuilder/osprey/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/msmbuilder/osprey/pulls/comments/57765848"},"html":{"href":"https://github.com/msmbuilder/osprey/pull/130#discussion_r57765848"},"pull_request":{"href":"https://api.github.com/repos/msmbuilder/osprey/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/msmbuilder/osprey/pulls/130","id":64503029,"html_url":"https://github.com/msmbuilder/osprey/pull/130","diff_url":"https://github.com/msmbuilder/osprey/pull/130.diff","patch_url":"https://github.com/msmbuilder/osprey/pull/130.patch","issue_url":"https://api.github.com/repos/msmbuilder/osprey/issues/130","number":130,"state":"open","locked":false,"title":"fix jump bug","user":{"login":"msultan","id":3597136,"avatar_url":"https://avatars.githubusercontent.com/u/3597136?v=3","gravatar_id":"","url":"https://api.github.com/users/msultan","html_url":"https://github.com/msultan","followers_url":"https://api.github.com/users/msultan/followers","following_url":"https://api.github.com/users/msultan/following{/other_user}","gists_url":"https://api.github.com/users/msultan/gists{/gist_id}","starred_url":"https://api.github.com/users/msultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msultan/subscriptions","organizations_url":"https://api.github.com/users/msultan/orgs","repos_url":"https://api.github.com/users/msultan/repos","events_url":"https://api.github.com/users/msultan/events{/privacy}","received_events_url":"https://api.github.com/users/msultan/received_events","type":"User","site_admin":false},"body":"should fix #129. Also added functionality to accept a type so that the output is in the same format as required by the estimators","created_at":"2016-03-29T17:32:05Z","updated_at":"2016-03-29T17:39:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a3a9e000881151d8ac71c5abd8e947de9a6b183","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/msmbuilder/osprey/pulls/130/commits","review_comments_url":"https://api.github.com/repos/msmbuilder/osprey/pulls/130/comments","review_comment_url":"https://api.github.com/repos/msmbuilder/osprey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/msmbuilder/osprey/issues/130/comments","statuses_url":"https://api.github.com/repos/msmbuilder/osprey/statuses/66ea06fac33344076d4c51e65f0cb58bd6ef0a86","head":{"label":"msultan:fix_jump","ref":"fix_jump","sha":"66ea06fac33344076d4c51e65f0cb58bd6ef0a86","user":{"login":"msultan","id":3597136,"avatar_url":"https://avatars.githubusercontent.com/u/3597136?v=3","gravatar_id":"","url":"https://api.github.com/users/msultan","html_url":"https://github.com/msultan","followers_url":"https://api.github.com/users/msultan/followers","following_url":"https://api.github.com/users/msultan/following{/other_user}","gists_url":"https://api.github.com/users/msultan/gists{/gist_id}","starred_url":"https://api.github.com/users/msultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msultan/subscriptions","organizations_url":"https://api.github.com/users/msultan/orgs","repos_url":"https://api.github.com/users/msultan/repos","events_url":"https://api.github.com/users/msultan/events{/privacy}","received_events_url":"https://api.github.com/users/msultan/received_events","type":"User","site_admin":false},"repo":{"id":26004694,"name":"osprey","full_name":"msultan/osprey","owner":{"login":"msultan","id":3597136,"avatar_url":"https://avatars.githubusercontent.com/u/3597136?v=3","gravatar_id":"","url":"https://api.github.com/users/msultan","html_url":"https://github.com/msultan","followers_url":"https://api.github.com/users/msultan/followers","following_url":"https://api.github.com/users/msultan/following{/other_user}","gists_url":"https://api.github.com/users/msultan/gists{/gist_id}","starred_url":"https://api.github.com/users/msultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msultan/subscriptions","organizations_url":"https://api.github.com/users/msultan/orgs","repos_url":"https://api.github.com/users/msultan/repos","events_url":"https://api.github.com/users/msultan/events{/privacy}","received_events_url":"https://api.github.com/users/msultan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msultan/osprey","description":"osprey is the plumbing for machine learning hyperparameter optimization.","fork":true,"url":"https://api.github.com/repos/msultan/osprey","forks_url":"https://api.github.com/repos/msultan/osprey/forks","keys_url":"https://api.github.com/repos/msultan/osprey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msultan/osprey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msultan/osprey/teams","hooks_url":"https://api.github.com/repos/msultan/osprey/hooks","issue_events_url":"https://api.github.com/repos/msultan/osprey/issues/events{/number}","events_url":"https://api.github.com/repos/msultan/osprey/events","assignees_url":"https://api.github.com/repos/msultan/osprey/assignees{/user}","branches_url":"https://api.github.com/repos/msultan/osprey/branches{/branch}","tags_url":"https://api.github.com/repos/msultan/osprey/tags","blobs_url":"https://api.github.com/repos/msultan/osprey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msultan/osprey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msultan/osprey/git/refs{/sha}","trees_url":"https://api.github.com/repos/msultan/osprey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msultan/osprey/statuses/{sha}","languages_url":"https://api.github.com/repos/msultan/osprey/languages","stargazers_url":"https://api.github.com/repos/msultan/osprey/stargazers","contributors_url":"https://api.github.com/repos/msultan/osprey/contributors","subscribers_url":"https://api.github.com/repos/msultan/osprey/subscribers","subscription_url":"https://api.github.com/repos/msultan/osprey/subscription","commits_url":"https://api.github.com/repos/msultan/osprey/commits{/sha}","git_commits_url":"https://api.github.com/repos/msultan/osprey/git/commits{/sha}","comments_url":"https://api.github.com/repos/msultan/osprey/comments{/number}","issue_comment_url":"https://api.github.com/repos/msultan/osprey/issues/comments{/number}","contents_url":"https://api.github.com/repos/msultan/osprey/contents/{+path}","compare_url":"https://api.github.com/repos/msultan/osprey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msultan/osprey/merges","archive_url":"https://api.github.com/repos/msultan/osprey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msultan/osprey/downloads","issues_url":"https://api.github.com/repos/msultan/osprey/issues{/number}","pulls_url":"https://api.github.com/repos/msultan/osprey/pulls{/number}","milestones_url":"https://api.github.com/repos/msultan/osprey/milestones{/number}","notifications_url":"https://api.github.com/repos/msultan/osprey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msultan/osprey/labels{/name}","releases_url":"https://api.github.com/repos/msultan/osprey/releases{/id}","deployments_url":"https://api.github.com/repos/msultan/osprey/deployments","created_at":"2014-10-31T06:23:28Z","updated_at":"2016-03-04T22:30:00Z","pushed_at":"2016-03-29T17:30:56Z","git_url":"git://github.com/msultan/osprey.git","ssh_url":"git@github.com:msultan/osprey.git","clone_url":"https://github.com/msultan/osprey.git","svn_url":"https://github.com/msultan/osprey","homepage":"https://github.com/rmcgibbo/osprey","size":351,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"msmbuilder:master","ref":"master","sha":"936e8171d646fd49b1e91b83282e3044ae284053","user":{"login":"msmbuilder","id":10036752,"avatar_url":"https://avatars.githubusercontent.com/u/10036752?v=3","gravatar_id":"","url":"https://api.github.com/users/msmbuilder","html_url":"https://github.com/msmbuilder","followers_url":"https://api.github.com/users/msmbuilder/followers","following_url":"https://api.github.com/users/msmbuilder/following{/other_user}","gists_url":"https://api.github.com/users/msmbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/msmbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmbuilder/subscriptions","organizations_url":"https://api.github.com/users/msmbuilder/orgs","repos_url":"https://api.github.com/users/msmbuilder/repos","events_url":"https://api.github.com/users/msmbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/msmbuilder/received_events","type":"Organization","site_admin":false},"repo":{"id":25709474,"name":"osprey","full_name":"msmbuilder/osprey","owner":{"login":"msmbuilder","id":10036752,"avatar_url":"https://avatars.githubusercontent.com/u/10036752?v=3","gravatar_id":"","url":"https://api.github.com/users/msmbuilder","html_url":"https://github.com/msmbuilder","followers_url":"https://api.github.com/users/msmbuilder/followers","following_url":"https://api.github.com/users/msmbuilder/following{/other_user}","gists_url":"https://api.github.com/users/msmbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/msmbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmbuilder/subscriptions","organizations_url":"https://api.github.com/users/msmbuilder/orgs","repos_url":"https://api.github.com/users/msmbuilder/repos","events_url":"https://api.github.com/users/msmbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/msmbuilder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/msmbuilder/osprey","description":"osprey is the plumbing for machine learning hyperparameter optimization.","fork":false,"url":"https://api.github.com/repos/msmbuilder/osprey","forks_url":"https://api.github.com/repos/msmbuilder/osprey/forks","keys_url":"https://api.github.com/repos/msmbuilder/osprey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msmbuilder/osprey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msmbuilder/osprey/teams","hooks_url":"https://api.github.com/repos/msmbuilder/osprey/hooks","issue_events_url":"https://api.github.com/repos/msmbuilder/osprey/issues/events{/number}","events_url":"https://api.github.com/repos/msmbuilder/osprey/events","assignees_url":"https://api.github.com/repos/msmbuilder/osprey/assignees{/user}","branches_url":"https://api.github.com/repos/msmbuilder/osprey/branches{/branch}","tags_url":"https://api.github.com/repos/msmbuilder/osprey/tags","blobs_url":"https://api.github.com/repos/msmbuilder/osprey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msmbuilder/osprey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msmbuilder/osprey/git/refs{/sha}","trees_url":"https://api.github.com/repos/msmbuilder/osprey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msmbuilder/osprey/statuses/{sha}","languages_url":"https://api.github.com/repos/msmbuilder/osprey/languages","stargazers_url":"https://api.github.com/repos/msmbuilder/osprey/stargazers","contributors_url":"https://api.github.com/repos/msmbuilder/osprey/contributors","subscribers_url":"https://api.github.com/repos/msmbuilder/osprey/subscribers","subscription_url":"https://api.github.com/repos/msmbuilder/osprey/subscription","commits_url":"https://api.github.com/repos/msmbuilder/osprey/commits{/sha}","git_commits_url":"https://api.github.com/repos/msmbuilder/osprey/git/commits{/sha}","comments_url":"https://api.github.com/repos/msmbuilder/osprey/comments{/number}","issue_comment_url":"https://api.github.com/repos/msmbuilder/osprey/issues/comments{/number}","contents_url":"https://api.github.com/repos/msmbuilder/osprey/contents/{+path}","compare_url":"https://api.github.com/repos/msmbuilder/osprey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msmbuilder/osprey/merges","archive_url":"https://api.github.com/repos/msmbuilder/osprey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msmbuilder/osprey/downloads","issues_url":"https://api.github.com/repos/msmbuilder/osprey/issues{/number}","pulls_url":"https://api.github.com/repos/msmbuilder/osprey/pulls{/number}","milestones_url":"https://api.github.com/repos/msmbuilder/osprey/milestones{/number}","notifications_url":"https://api.github.com/repos/msmbuilder/osprey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msmbuilder/osprey/labels{/name}","releases_url":"https://api.github.com/repos/msmbuilder/osprey/releases{/id}","deployments_url":"https://api.github.com/repos/msmbuilder/osprey/deployments","created_at":"2014-10-24T21:39:16Z","updated_at":"2016-03-25T15:30:55Z","pushed_at":"2016-03-29T17:32:06Z","git_url":"git://github.com/msmbuilder/osprey.git","ssh_url":"git@github.com:msmbuilder/osprey.git","clone_url":"https://github.com/msmbuilder/osprey.git","svn_url":"https://github.com/msmbuilder/osprey","homepage":"http://osprey.rtfd.org","size":374,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":10,"forks":10,"open_issues":10,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/msmbuilder/osprey/pulls/130"},"html":{"href":"https://github.com/msmbuilder/osprey/pull/130"},"issue":{"href":"https://api.github.com/repos/msmbuilder/osprey/issues/130"},"comments":{"href":"https://api.github.com/repos/msmbuilder/osprey/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/msmbuilder/osprey/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/msmbuilder/osprey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/msmbuilder/osprey/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/msmbuilder/osprey/statuses/66ea06fac33344076d4c51e65f0cb58bd6ef0a86"}}}}