{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/dr-elephant/pulls/comments/73101794","id":73101794,"diff_hunk":"@@ -179,7 +176,10 @@ public void run() {\n         logger.info(String.format(\"Analyzing %s\", analysisName));\n         AppResult result = _analyticJob.getAnalysis();\n         result.save();\n-        logger.info(String.format(\"Analysis of %s took %sms\", analysisName, System.currentTimeMillis() - analysisStartTimeMillis));\n+        long processingTime = System.currentTimeMillis() - analysisStartTimeMillis;\n+        logger.info(String.format(\"Analysis of %s took %sms\", analysisName, processingTime));\n+        MetricsController.setJobProcessingTime(processingTime);","path":"app/com/linkedin/drelephant/ElephantRunner.java","position":24,"original_position":24,"commit_id":"187bc5e87645c61370d936ceb4cfdf3f96ec9a3c","original_commit_id":"187bc5e87645c61370d936ceb4cfdf3f96ec9a3c","user":{"login":"paulbramsen","id":4658911,"avatar_url":"https://avatars.githubusercontent.com/u/4658911?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbramsen","html_url":"https://github.com/paulbramsen","followers_url":"https://api.github.com/users/paulbramsen/followers","following_url":"https://api.github.com/users/paulbramsen/following{/other_user}","gists_url":"https://api.github.com/users/paulbramsen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbramsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbramsen/subscriptions","organizations_url":"https://api.github.com/users/paulbramsen/orgs","repos_url":"https://api.github.com/users/paulbramsen/repos","events_url":"https://api.github.com/users/paulbramsen/events{/privacy}","received_events_url":"https://api.github.com/users/paulbramsen/received_events","type":"User","site_admin":false},"body":"We could do that. However with the fast fetcher this time is pretty small (milliseconds) and this metric is mostly to alert if it goes way up. It takes a long time with the regular fetcher due to each task requiring a separate HTTP request.\r\n@shankar37 If you want I'll add the normalized version too. I have an idea for how to do it cleanly.","created_at":"2016-08-02T06:45:51Z","updated_at":"2016-08-02T06:45:51Z","html_url":"https://github.com/linkedin/dr-elephant/pull/126#discussion_r73101794","pull_request_url":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/linkedin/dr-elephant/pulls/comments/73101794"},"html":{"href":"https://github.com/linkedin/dr-elephant/pull/126#discussion_r73101794"},"pull_request":{"href":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126","id":79683008,"html_url":"https://github.com/linkedin/dr-elephant/pull/126","diff_url":"https://github.com/linkedin/dr-elephant/pull/126.diff","patch_url":"https://github.com/linkedin/dr-elephant/pull/126.patch","issue_url":"https://api.github.com/repos/linkedin/dr-elephant/issues/126","number":126,"state":"open","locked":false,"title":"Improved metrics","user":{"login":"paulbramsen","id":4658911,"avatar_url":"https://avatars.githubusercontent.com/u/4658911?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbramsen","html_url":"https://github.com/paulbramsen","followers_url":"https://api.github.com/users/paulbramsen/followers","following_url":"https://api.github.com/users/paulbramsen/following{/other_user}","gists_url":"https://api.github.com/users/paulbramsen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbramsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbramsen/subscriptions","organizations_url":"https://api.github.com/users/paulbramsen/orgs","repos_url":"https://api.github.com/users/paulbramsen/repos","events_url":"https://api.github.com/users/paulbramsen/events{/privacy}","received_events_url":"https://api.github.com/users/paulbramsen/received_events","type":"User","site_admin":false},"body":"Fix the broken histogram metrics. Add new metrics for number of jobs finished in the last 24 hours and job processing time.\r\n\r\nI tested this on CDH 5.3 with MapReduce 2.5.0 and Spark 1.5.2.\r\n@krishnap","created_at":"2016-08-02T06:37:22Z","updated_at":"2016-08-02T06:45:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16b3229909f05712e47a4f832966bd35c5b8bcf8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126/commits","review_comments_url":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126/comments","review_comment_url":"https://api.github.com/repos/linkedin/dr-elephant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/dr-elephant/issues/126/comments","statuses_url":"https://api.github.com/repos/linkedin/dr-elephant/statuses/187bc5e87645c61370d936ceb4cfdf3f96ec9a3c","head":{"label":"paulbramsen:paulbramsen/feature/improved_metrics","ref":"paulbramsen/feature/improved_metrics","sha":"187bc5e87645c61370d936ceb4cfdf3f96ec9a3c","user":{"login":"paulbramsen","id":4658911,"avatar_url":"https://avatars.githubusercontent.com/u/4658911?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbramsen","html_url":"https://github.com/paulbramsen","followers_url":"https://api.github.com/users/paulbramsen/followers","following_url":"https://api.github.com/users/paulbramsen/following{/other_user}","gists_url":"https://api.github.com/users/paulbramsen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbramsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbramsen/subscriptions","organizations_url":"https://api.github.com/users/paulbramsen/orgs","repos_url":"https://api.github.com/users/paulbramsen/repos","events_url":"https://api.github.com/users/paulbramsen/events{/privacy}","received_events_url":"https://api.github.com/users/paulbramsen/received_events","type":"User","site_admin":false},"repo":{"id":61317368,"name":"dr-elephant","full_name":"paulbramsen/dr-elephant","owner":{"login":"paulbramsen","id":4658911,"avatar_url":"https://avatars.githubusercontent.com/u/4658911?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbramsen","html_url":"https://github.com/paulbramsen","followers_url":"https://api.github.com/users/paulbramsen/followers","following_url":"https://api.github.com/users/paulbramsen/following{/other_user}","gists_url":"https://api.github.com/users/paulbramsen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbramsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbramsen/subscriptions","organizations_url":"https://api.github.com/users/paulbramsen/orgs","repos_url":"https://api.github.com/users/paulbramsen/repos","events_url":"https://api.github.com/users/paulbramsen/events{/privacy}","received_events_url":"https://api.github.com/users/paulbramsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulbramsen/dr-elephant","description":"Performance monitoring and tuning tool for Apache Hadoop","fork":true,"url":"https://api.github.com/repos/paulbramsen/dr-elephant","forks_url":"https://api.github.com/repos/paulbramsen/dr-elephant/forks","keys_url":"https://api.github.com/repos/paulbramsen/dr-elephant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulbramsen/dr-elephant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulbramsen/dr-elephant/teams","hooks_url":"https://api.github.com/repos/paulbramsen/dr-elephant/hooks","issue_events_url":"https://api.github.com/repos/paulbramsen/dr-elephant/issues/events{/number}","events_url":"https://api.github.com/repos/paulbramsen/dr-elephant/events","assignees_url":"https://api.github.com/repos/paulbramsen/dr-elephant/assignees{/user}","branches_url":"https://api.github.com/repos/paulbramsen/dr-elephant/branches{/branch}","tags_url":"https://api.github.com/repos/paulbramsen/dr-elephant/tags","blobs_url":"https://api.github.com/repos/paulbramsen/dr-elephant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulbramsen/dr-elephant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulbramsen/dr-elephant/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulbramsen/dr-elephant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulbramsen/dr-elephant/statuses/{sha}","languages_url":"https://api.github.com/repos/paulbramsen/dr-elephant/languages","stargazers_url":"https://api.github.com/repos/paulbramsen/dr-elephant/stargazers","contributors_url":"https://api.github.com/repos/paulbramsen/dr-elephant/contributors","subscribers_url":"https://api.github.com/repos/paulbramsen/dr-elephant/subscribers","subscription_url":"https://api.github.com/repos/paulbramsen/dr-elephant/subscription","commits_url":"https://api.github.com/repos/paulbramsen/dr-elephant/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulbramsen/dr-elephant/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulbramsen/dr-elephant/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulbramsen/dr-elephant/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulbramsen/dr-elephant/contents/{+path}","compare_url":"https://api.github.com/repos/paulbramsen/dr-elephant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulbramsen/dr-elephant/merges","archive_url":"https://api.github.com/repos/paulbramsen/dr-elephant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulbramsen/dr-elephant/downloads","issues_url":"https://api.github.com/repos/paulbramsen/dr-elephant/issues{/number}","pulls_url":"https://api.github.com/repos/paulbramsen/dr-elephant/pulls{/number}","milestones_url":"https://api.github.com/repos/paulbramsen/dr-elephant/milestones{/number}","notifications_url":"https://api.github.com/repos/paulbramsen/dr-elephant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulbramsen/dr-elephant/labels{/name}","releases_url":"https://api.github.com/repos/paulbramsen/dr-elephant/releases{/id}","deployments_url":"https://api.github.com/repos/paulbramsen/dr-elephant/deployments","created_at":"2016-06-16T18:41:26Z","updated_at":"2016-06-16T18:41:28Z","pushed_at":"2016-08-02T06:35:43Z","git_url":"git://github.com/paulbramsen/dr-elephant.git","ssh_url":"git@github.com:paulbramsen/dr-elephant.git","clone_url":"https://github.com/paulbramsen/dr-elephant.git","svn_url":"https://github.com/paulbramsen/dr-elephant","homepage":"","size":9615,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"71a69e7131071a37118e3af5324abad4ce6ee531","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":52983941,"name":"dr-elephant","full_name":"linkedin/dr-elephant","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/dr-elephant","description":"Performance monitoring and tuning tool for Apache Hadoop","fork":false,"url":"https://api.github.com/repos/linkedin/dr-elephant","forks_url":"https://api.github.com/repos/linkedin/dr-elephant/forks","keys_url":"https://api.github.com/repos/linkedin/dr-elephant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/dr-elephant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/dr-elephant/teams","hooks_url":"https://api.github.com/repos/linkedin/dr-elephant/hooks","issue_events_url":"https://api.github.com/repos/linkedin/dr-elephant/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/dr-elephant/events","assignees_url":"https://api.github.com/repos/linkedin/dr-elephant/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/dr-elephant/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/dr-elephant/tags","blobs_url":"https://api.github.com/repos/linkedin/dr-elephant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/dr-elephant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/dr-elephant/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/dr-elephant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/dr-elephant/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/dr-elephant/languages","stargazers_url":"https://api.github.com/repos/linkedin/dr-elephant/stargazers","contributors_url":"https://api.github.com/repos/linkedin/dr-elephant/contributors","subscribers_url":"https://api.github.com/repos/linkedin/dr-elephant/subscribers","subscription_url":"https://api.github.com/repos/linkedin/dr-elephant/subscription","commits_url":"https://api.github.com/repos/linkedin/dr-elephant/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/dr-elephant/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/dr-elephant/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/dr-elephant/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/dr-elephant/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/dr-elephant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/dr-elephant/merges","archive_url":"https://api.github.com/repos/linkedin/dr-elephant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/dr-elephant/downloads","issues_url":"https://api.github.com/repos/linkedin/dr-elephant/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/dr-elephant/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/dr-elephant/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/dr-elephant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/dr-elephant/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/dr-elephant/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/dr-elephant/deployments","created_at":"2016-03-02T17:51:13Z","updated_at":"2016-08-02T05:10:04Z","pushed_at":"2016-08-02T06:43:52Z","git_url":"git://github.com/linkedin/dr-elephant.git","ssh_url":"git@github.com:linkedin/dr-elephant.git","clone_url":"https://github.com/linkedin/dr-elephant.git","svn_url":"https://github.com/linkedin/dr-elephant","homepage":"","size":10130,"stargazers_count":275,"watchers_count":275,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":22,"forks":115,"open_issues":22,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126"},"html":{"href":"https://github.com/linkedin/dr-elephant/pull/126"},"issue":{"href":"https://api.github.com/repos/linkedin/dr-elephant/issues/126"},"comments":{"href":"https://api.github.com/repos/linkedin/dr-elephant/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/dr-elephant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/dr-elephant/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/dr-elephant/statuses/187bc5e87645c61370d936ceb4cfdf3f96ec9a3c"}}}}
{"actor":{"display_login":"paulbramsen"}}