{"action":"created","issue":{"url":"https://api.github.com/repos/emilk/loguru/issues/23","repository_url":"https://api.github.com/repos/emilk/loguru","labels_url":"https://api.github.com/repos/emilk/loguru/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/emilk/loguru/issues/23/comments","events_url":"https://api.github.com/repos/emilk/loguru/issues/23/events","html_url":"https://github.com/emilk/loguru/pull/23","id":196084074,"number":23,"title":"Implement a new feature","user":{"login":"scinart","id":4526363,"avatar_url":"https://avatars.githubusercontent.com/u/4526363?v=3","gravatar_id":"","url":"https://api.github.com/users/scinart","html_url":"https://github.com/scinart","followers_url":"https://api.github.com/users/scinart/followers","following_url":"https://api.github.com/users/scinart/following{/other_user}","gists_url":"https://api.github.com/users/scinart/gists{/gist_id}","starred_url":"https://api.github.com/users/scinart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scinart/subscriptions","organizations_url":"https://api.github.com/users/scinart/orgs","repos_url":"https://api.github.com/users/scinart/repos","events_url":"https://api.github.com/users/scinart/events{/privacy}","received_events_url":"https://api.github.com/users/scinart/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-16T15:27:45Z","updated_at":"2016-12-22T08:47:31Z","closed_at":"2016-12-22T08:47:25Z","pull_request":{"url":"https://api.github.com/repos/emilk/loguru/pulls/23","html_url":"https://github.com/emilk/loguru/pull/23","diff_url":"https://github.com/emilk/loguru/pull/23.diff","patch_url":"https://github.com/emilk/loguru/pull/23.patch"},"body":"A macro ``LOGURU_WITH_FILEABS`` is added.\r\n\r\nwhen ``LOGURU_WITH_FILEABS`` is defined, a check of file change will be performed on every call to ``file_log``. If the file is moved, or inode changes, file is reopened using the same ``FileMode`` as is done by ``add_file``.\r\n\r\n``file_log`` is made sequential using pthread lock since every call of ``file_log`` may reopen the file and invalidate the file descriptor. Hence calling ``file_log`` from multiple threads is OK.\r\n\r\nSuch a scheme is useful if you have a daemon program that moves the log file every 24 hours and expects new file to be created.\r\n\r\nIf one thread calls remove_callback while others are logging into this file, an error will probably occur. But I will let it be since I guess the very problem exists in the original design."},"comment":{"url":"https://api.github.com/repos/emilk/loguru/issues/comments/268749278","html_url":"https://github.com/emilk/loguru/pull/23#issuecomment-268749278","issue_url":"https://api.github.com/repos/emilk/loguru/issues/23","id":268749278,"user":{"login":"emilk","id":1148717,"avatar_url":"https://avatars.githubusercontent.com/u/1148717?v=3","gravatar_id":"","url":"https://api.github.com/users/emilk","html_url":"https://github.com/emilk","followers_url":"https://api.github.com/users/emilk/followers","following_url":"https://api.github.com/users/emilk/following{/other_user}","gists_url":"https://api.github.com/users/emilk/gists{/gist_id}","starred_url":"https://api.github.com/users/emilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilk/subscriptions","organizations_url":"https://api.github.com/users/emilk/orgs","repos_url":"https://api.github.com/users/emilk/repos","events_url":"https://api.github.com/users/emilk/events{/privacy}","received_events_url":"https://api.github.com/users/emilk/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T08:47:31Z","updated_at":"2016-12-22T08:47:31Z","body":"LGTM - thank's for your contribution!"}}
{"actor":{"display_login":"emilk"}}