{"action":"created","issue":{"url":"https://api.github.com/repos/TryGhost/Ghost/issues/7254","repository_url":"https://api.github.com/repos/TryGhost/Ghost","labels_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7254/labels{/name}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7254/comments","events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7254/events","html_url":"https://github.com/TryGhost/Ghost/pull/7254","id":172811008,"number":7254,"title":"[WIP] Refactors tests to use promises","user":{"login":"jeffjewiss","id":354604,"avatar_url":"https://avatars.githubusercontent.com/u/354604?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffjewiss","html_url":"https://github.com/jeffjewiss","followers_url":"https://api.github.com/users/jeffjewiss/followers","following_url":"https://api.github.com/users/jeffjewiss/following{/other_user}","gists_url":"https://api.github.com/users/jeffjewiss/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffjewiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffjewiss/subscriptions","organizations_url":"https://api.github.com/users/jeffjewiss/orgs","repos_url":"https://api.github.com/users/jeffjewiss/repos","events_url":"https://api.github.com/users/jeffjewiss/events{/privacy}","received_events_url":"https://api.github.com/users/jeffjewiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-23T21:26:24Z","updated_at":"2016-10-12T09:12:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/7254","html_url":"https://github.com/TryGhost/Ghost/pull/7254","diff_url":"https://github.com/TryGhost/Ghost/pull/7254.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/7254.patch"},"body":"These changes are in reference to #7166. I was hoping to get some feedback to ensure this is the desired direction before moving forward with updating more of the tests.\r\n\r\nFor the most part I just removed the `done()` callback and `.catch();`, but I also had to update 2 tests as they failed when removing the callbacks, which makes me suspect they weren't functioning as intended anyway.\r\n\r\nPlease let me know if this is going in the right direction and I can continue updating more of the tests, unless someone else has already taken on this work.\r\n\r\nCheers!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments/253160752","html_url":"https://github.com/TryGhost/Ghost/pull/7254#issuecomment-253160752","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/7254","id":253160752,"user":{"login":"jeffjewiss","id":354604,"avatar_url":"https://avatars.githubusercontent.com/u/354604?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffjewiss","html_url":"https://github.com/jeffjewiss","followers_url":"https://api.github.com/users/jeffjewiss/followers","following_url":"https://api.github.com/users/jeffjewiss/following{/other_user}","gists_url":"https://api.github.com/users/jeffjewiss/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffjewiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffjewiss/subscriptions","organizations_url":"https://api.github.com/users/jeffjewiss/orgs","repos_url":"https://api.github.com/users/jeffjewiss/repos","events_url":"https://api.github.com/users/jeffjewiss/events{/privacy}","received_events_url":"https://api.github.com/users/jeffjewiss/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T09:12:49Z","updated_at":"2016-10-12T09:12:49Z","body":"Hi @ErisDS, I think I've removed as many callbacks as possible without altering how the tests are written. This PR should be ready for review now, and I'm assuming I'll need to squash the commits too, but I'd prefer to do that after review if that's alright. Thanks!"}}
{"actor":{"display_login":"jeffjewiss"}}