{"action":"created","comment":{"url":"https://api.github.com/repos/moment/moment/pulls/comments/89429486","pull_request_review_id":9974754,"id":89429486,"diff_hunk":"@@ -16,8 +17,8 @@ export function startOf (units) {\n         case 'isoWeek':\n         case 'day':\n         case 'date':\n-            this.hours(0);\n-            /* falls through */\n+            setTime(this, 0, 0, 0, 0);\n+            break;\n         case 'hour':\n             this.minutes(0);","path":"src/lib/moment/start-end-of.js","position":15,"original_position":15,"commit_id":"e9134d731dd723616831e41ec0bfda14486e3562","original_commit_id":"e9134d731dd723616831e41ec0bfda14486e3562","user":{"login":"icambron","id":244988,"avatar_url":"https://avatars.githubusercontent.com/u/244988?v=3","gravatar_id":"","url":"https://api.github.com/users/icambron","html_url":"https://github.com/icambron","followers_url":"https://api.github.com/users/icambron/followers","following_url":"https://api.github.com/users/icambron/following{/other_user}","gists_url":"https://api.github.com/users/icambron/gists{/gist_id}","starred_url":"https://api.github.com/users/icambron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icambron/subscriptions","organizations_url":"https://api.github.com/users/icambron/orgs","repos_url":"https://api.github.com/users/icambron/repos","events_url":"https://api.github.com/users/icambron/events{/privacy}","received_events_url":"https://api.github.com/users/icambron/received_events","type":"User","site_admin":false},"body":"Seems like the `hour` case should be `this.setTime(this, this.hour(), 0, 0, 0)`, etc","created_at":"2016-11-24T02:59:55Z","updated_at":"2016-11-24T02:59:55Z","html_url":"https://github.com/moment/moment/pull/3620#discussion_r89429486","pull_request_url":"https://api.github.com/repos/moment/moment/pulls/3620","_links":{"self":{"href":"https://api.github.com/repos/moment/moment/pulls/comments/89429486"},"html":{"href":"https://github.com/moment/moment/pull/3620#discussion_r89429486"},"pull_request":{"href":"https://api.github.com/repos/moment/moment/pulls/3620"}}},"pull_request":{"url":"https://api.github.com/repos/moment/moment/pulls/3620","id":95014143,"html_url":"https://github.com/moment/moment/pull/3620","diff_url":"https://github.com/moment/moment/pull/3620.diff","patch_url":"https://github.com/moment/moment/pull/3620.patch","issue_url":"https://api.github.com/repos/moment/moment/issues/3620","number":3620,"state":"open","locked":false,"title":"create setTime function","user":{"login":"aymericbouzy","id":8168981,"avatar_url":"https://avatars.githubusercontent.com/u/8168981?v=3","gravatar_id":"","url":"https://api.github.com/users/aymericbouzy","html_url":"https://github.com/aymericbouzy","followers_url":"https://api.github.com/users/aymericbouzy/followers","following_url":"https://api.github.com/users/aymericbouzy/following{/other_user}","gists_url":"https://api.github.com/users/aymericbouzy/gists{/gist_id}","starred_url":"https://api.github.com/users/aymericbouzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymericbouzy/subscriptions","organizations_url":"https://api.github.com/users/aymericbouzy/orgs","repos_url":"https://api.github.com/users/aymericbouzy/repos","events_url":"https://api.github.com/users/aymericbouzy/events{/privacy}","received_events_url":"https://api.github.com/users/aymericbouzy/received_events","type":"User","site_admin":false},"body":"This increases the performance of startOf / endOf by a factor of about 90 for `'day'`.\r\n\r\nNB : This is my first PR, i'm not sure what I should do, especially regarding proving my call about this performance gain. I see there is a benchmark folder, but I don't know what to do about it. I have run grunt tests successfully on my computer.","created_at":"2016-11-23T14:33:44Z","updated_at":"2016-11-24T02:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f08d536e3b60bda7501a14cb8faaf7cb351a2e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/moment/moment/pulls/3620/commits","review_comments_url":"https://api.github.com/repos/moment/moment/pulls/3620/comments","review_comment_url":"https://api.github.com/repos/moment/moment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moment/moment/issues/3620/comments","statuses_url":"https://api.github.com/repos/moment/moment/statuses/e9134d731dd723616831e41ec0bfda14486e3562","head":{"label":"aymericbouzy:performance-start-end-of","ref":"performance-start-end-of","sha":"e9134d731dd723616831e41ec0bfda14486e3562","user":{"login":"aymericbouzy","id":8168981,"avatar_url":"https://avatars.githubusercontent.com/u/8168981?v=3","gravatar_id":"","url":"https://api.github.com/users/aymericbouzy","html_url":"https://github.com/aymericbouzy","followers_url":"https://api.github.com/users/aymericbouzy/followers","following_url":"https://api.github.com/users/aymericbouzy/following{/other_user}","gists_url":"https://api.github.com/users/aymericbouzy/gists{/gist_id}","starred_url":"https://api.github.com/users/aymericbouzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymericbouzy/subscriptions","organizations_url":"https://api.github.com/users/aymericbouzy/orgs","repos_url":"https://api.github.com/users/aymericbouzy/repos","events_url":"https://api.github.com/users/aymericbouzy/events{/privacy}","received_events_url":"https://api.github.com/users/aymericbouzy/received_events","type":"User","site_admin":false},"repo":{"id":74565054,"name":"moment","full_name":"aymericbouzy/moment","owner":{"login":"aymericbouzy","id":8168981,"avatar_url":"https://avatars.githubusercontent.com/u/8168981?v=3","gravatar_id":"","url":"https://api.github.com/users/aymericbouzy","html_url":"https://github.com/aymericbouzy","followers_url":"https://api.github.com/users/aymericbouzy/followers","following_url":"https://api.github.com/users/aymericbouzy/following{/other_user}","gists_url":"https://api.github.com/users/aymericbouzy/gists{/gist_id}","starred_url":"https://api.github.com/users/aymericbouzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymericbouzy/subscriptions","organizations_url":"https://api.github.com/users/aymericbouzy/orgs","repos_url":"https://api.github.com/users/aymericbouzy/repos","events_url":"https://api.github.com/users/aymericbouzy/events{/privacy}","received_events_url":"https://api.github.com/users/aymericbouzy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aymericbouzy/moment","description":"Parse, validate, manipulate, and display dates in javascript.","fork":true,"url":"https://api.github.com/repos/aymericbouzy/moment","forks_url":"https://api.github.com/repos/aymericbouzy/moment/forks","keys_url":"https://api.github.com/repos/aymericbouzy/moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aymericbouzy/moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aymericbouzy/moment/teams","hooks_url":"https://api.github.com/repos/aymericbouzy/moment/hooks","issue_events_url":"https://api.github.com/repos/aymericbouzy/moment/issues/events{/number}","events_url":"https://api.github.com/repos/aymericbouzy/moment/events","assignees_url":"https://api.github.com/repos/aymericbouzy/moment/assignees{/user}","branches_url":"https://api.github.com/repos/aymericbouzy/moment/branches{/branch}","tags_url":"https://api.github.com/repos/aymericbouzy/moment/tags","blobs_url":"https://api.github.com/repos/aymericbouzy/moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aymericbouzy/moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aymericbouzy/moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/aymericbouzy/moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aymericbouzy/moment/statuses/{sha}","languages_url":"https://api.github.com/repos/aymericbouzy/moment/languages","stargazers_url":"https://api.github.com/repos/aymericbouzy/moment/stargazers","contributors_url":"https://api.github.com/repos/aymericbouzy/moment/contributors","subscribers_url":"https://api.github.com/repos/aymericbouzy/moment/subscribers","subscription_url":"https://api.github.com/repos/aymericbouzy/moment/subscription","commits_url":"https://api.github.com/repos/aymericbouzy/moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/aymericbouzy/moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/aymericbouzy/moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/aymericbouzy/moment/issues/comments{/number}","contents_url":"https://api.github.com/repos/aymericbouzy/moment/contents/{+path}","compare_url":"https://api.github.com/repos/aymericbouzy/moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aymericbouzy/moment/merges","archive_url":"https://api.github.com/repos/aymericbouzy/moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aymericbouzy/moment/downloads","issues_url":"https://api.github.com/repos/aymericbouzy/moment/issues{/number}","pulls_url":"https://api.github.com/repos/aymericbouzy/moment/pulls{/number}","milestones_url":"https://api.github.com/repos/aymericbouzy/moment/milestones{/number}","notifications_url":"https://api.github.com/repos/aymericbouzy/moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aymericbouzy/moment/labels{/name}","releases_url":"https://api.github.com/repos/aymericbouzy/moment/releases{/id}","deployments_url":"https://api.github.com/repos/aymericbouzy/moment/deployments","created_at":"2016-11-23T10:16:05Z","updated_at":"2016-11-23T10:16:12Z","pushed_at":"2016-11-23T14:33:43Z","git_url":"git://github.com/aymericbouzy/moment.git","ssh_url":"git@github.com:aymericbouzy/moment.git","clone_url":"https://github.com/aymericbouzy/moment.git","svn_url":"https://github.com/aymericbouzy/moment","homepage":"momentjs.com","size":12577,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"moment:develop","ref":"develop","sha":"4710a7935cb347d8b2cf50f5befccfea8180619d","user":{"login":"moment","id":4129662,"avatar_url":"https://avatars.githubusercontent.com/u/4129662?v=3","gravatar_id":"","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"repo":{"id":1424470,"name":"moment","full_name":"moment/moment","owner":{"login":"moment","id":4129662,"avatar_url":"https://avatars.githubusercontent.com/u/4129662?v=3","gravatar_id":"","url":"https://api.github.com/users/moment","html_url":"https://github.com/moment","followers_url":"https://api.github.com/users/moment/followers","following_url":"https://api.github.com/users/moment/following{/other_user}","gists_url":"https://api.github.com/users/moment/gists{/gist_id}","starred_url":"https://api.github.com/users/moment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moment/subscriptions","organizations_url":"https://api.github.com/users/moment/orgs","repos_url":"https://api.github.com/users/moment/repos","events_url":"https://api.github.com/users/moment/events{/privacy}","received_events_url":"https://api.github.com/users/moment/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moment/moment","description":"Parse, validate, manipulate, and display dates in javascript.","fork":false,"url":"https://api.github.com/repos/moment/moment","forks_url":"https://api.github.com/repos/moment/moment/forks","keys_url":"https://api.github.com/repos/moment/moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moment/moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moment/moment/teams","hooks_url":"https://api.github.com/repos/moment/moment/hooks","issue_events_url":"https://api.github.com/repos/moment/moment/issues/events{/number}","events_url":"https://api.github.com/repos/moment/moment/events","assignees_url":"https://api.github.com/repos/moment/moment/assignees{/user}","branches_url":"https://api.github.com/repos/moment/moment/branches{/branch}","tags_url":"https://api.github.com/repos/moment/moment/tags","blobs_url":"https://api.github.com/repos/moment/moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moment/moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moment/moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/moment/moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moment/moment/statuses/{sha}","languages_url":"https://api.github.com/repos/moment/moment/languages","stargazers_url":"https://api.github.com/repos/moment/moment/stargazers","contributors_url":"https://api.github.com/repos/moment/moment/contributors","subscribers_url":"https://api.github.com/repos/moment/moment/subscribers","subscription_url":"https://api.github.com/repos/moment/moment/subscription","commits_url":"https://api.github.com/repos/moment/moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/moment/moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/moment/moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/moment/moment/issues/comments{/number}","contents_url":"https://api.github.com/repos/moment/moment/contents/{+path}","compare_url":"https://api.github.com/repos/moment/moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moment/moment/merges","archive_url":"https://api.github.com/repos/moment/moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moment/moment/downloads","issues_url":"https://api.github.com/repos/moment/moment/issues{/number}","pulls_url":"https://api.github.com/repos/moment/moment/pulls{/number}","milestones_url":"https://api.github.com/repos/moment/moment/milestones{/number}","notifications_url":"https://api.github.com/repos/moment/moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moment/moment/labels{/name}","releases_url":"https://api.github.com/repos/moment/moment/releases{/id}","deployments_url":"https://api.github.com/repos/moment/moment/deployments","created_at":"2011-03-01T02:46:06Z","updated_at":"2016-11-24T02:19:56Z","pushed_at":"2016-11-23T14:33:44Z","git_url":"git://github.com/moment/moment.git","ssh_url":"git@github.com:moment/moment.git","clone_url":"https://github.com/moment/moment.git","svn_url":"https://github.com/moment/moment","homepage":"momentjs.com","size":19481,"stargazers_count":28780,"watchers_count":28780,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4109,"mirror_url":null,"open_issues_count":187,"forks":4109,"open_issues":187,"watchers":28780,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/moment/moment/pulls/3620"},"html":{"href":"https://github.com/moment/moment/pull/3620"},"issue":{"href":"https://api.github.com/repos/moment/moment/issues/3620"},"comments":{"href":"https://api.github.com/repos/moment/moment/issues/3620/comments"},"review_comments":{"href":"https://api.github.com/repos/moment/moment/pulls/3620/comments"},"review_comment":{"href":"https://api.github.com/repos/moment/moment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moment/moment/pulls/3620/commits"},"statuses":{"href":"https://api.github.com/repos/moment/moment/statuses/e9134d731dd723616831e41ec0bfda14486e3562"}}}}
{"actor":{"display_login":"icambron"}}