{"action":"closed","number":1720,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/1720","id":63237760,"html_url":"https://github.com/apple/swift/pull/1720","diff_url":"https://github.com/apple/swift/pull/1720.diff","patch_url":"https://github.com/apple/swift/pull/1720.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/1720","number":1720,"state":"closed","locked":false,"title":"runtime: improve portability and simplify aliases","user":{"login":"compnerd","id":63311,"avatar_url":"https://avatars.githubusercontent.com/u/63311?v=3","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\n<!-- Description about pull request. -->\r\n\r\n#### Resolved bug number: ([SR-](https://bugs.swift.org/browse/SR-))\r\n<!-- If this pull request resolves any bugs from Swift bug tracker -->\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n **Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\nclang and gcc provide a preprocessor macro called `__USER_LABEL_PREFIX__` which\r\nprovides the user label prefix for the specific target that the translation unit\r\nis being built for.  Rather than trying to reconstruct the logic in place via\r\nvarious checks, fallback to the compiler to provide this information.  Although\r\nthis limits the compilers (MSVC does not provide this preprocessor macro\r\ndefinition), the only supported compiler ATM is clang, and it has provided this\r\ndefinition for some time now.\r\n\r\nThis addresses the FIXME that was associated with the user label prefix being\r\napplied under specific cases.\r\n\r\nNFC.","created_at":"2016-03-17T15:07:54Z","updated_at":"2016-03-17T21:55:04Z","closed_at":"2016-03-17T21:55:04Z","merged_at":"2016-03-17T21:55:04Z","merge_commit_sha":"7b045c53ef6927275bb37fc44fb43a829cad256c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/1720/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/1720/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/1720/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/13a2ef3b4b4e1912c74449bf5cea0f2b9fee7ab9","head":{"label":"compnerd:underscore","ref":"underscore","sha":"13a2ef3b4b4e1912c74449bf5cea0f2b9fee7ab9","user":{"login":"compnerd","id":63311,"avatar_url":"https://avatars.githubusercontent.com/u/63311?v=3","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"repo":{"id":47945459,"name":"apple-swift","full_name":"compnerd/apple-swift","owner":{"login":"compnerd","id":63311,"avatar_url":"https://avatars.githubusercontent.com/u/63311?v=3","gravatar_id":"","url":"https://api.github.com/users/compnerd","html_url":"https://github.com/compnerd","followers_url":"https://api.github.com/users/compnerd/followers","following_url":"https://api.github.com/users/compnerd/following{/other_user}","gists_url":"https://api.github.com/users/compnerd/gists{/gist_id}","starred_url":"https://api.github.com/users/compnerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compnerd/subscriptions","organizations_url":"https://api.github.com/users/compnerd/orgs","repos_url":"https://api.github.com/users/compnerd/repos","events_url":"https://api.github.com/users/compnerd/events{/privacy}","received_events_url":"https://api.github.com/users/compnerd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/compnerd/apple-swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/compnerd/apple-swift","forks_url":"https://api.github.com/repos/compnerd/apple-swift/forks","keys_url":"https://api.github.com/repos/compnerd/apple-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compnerd/apple-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compnerd/apple-swift/teams","hooks_url":"https://api.github.com/repos/compnerd/apple-swift/hooks","issue_events_url":"https://api.github.com/repos/compnerd/apple-swift/issues/events{/number}","events_url":"https://api.github.com/repos/compnerd/apple-swift/events","assignees_url":"https://api.github.com/repos/compnerd/apple-swift/assignees{/user}","branches_url":"https://api.github.com/repos/compnerd/apple-swift/branches{/branch}","tags_url":"https://api.github.com/repos/compnerd/apple-swift/tags","blobs_url":"https://api.github.com/repos/compnerd/apple-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compnerd/apple-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compnerd/apple-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/compnerd/apple-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compnerd/apple-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/compnerd/apple-swift/languages","stargazers_url":"https://api.github.com/repos/compnerd/apple-swift/stargazers","contributors_url":"https://api.github.com/repos/compnerd/apple-swift/contributors","subscribers_url":"https://api.github.com/repos/compnerd/apple-swift/subscribers","subscription_url":"https://api.github.com/repos/compnerd/apple-swift/subscription","commits_url":"https://api.github.com/repos/compnerd/apple-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/compnerd/apple-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/compnerd/apple-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/compnerd/apple-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/compnerd/apple-swift/contents/{+path}","compare_url":"https://api.github.com/repos/compnerd/apple-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compnerd/apple-swift/merges","archive_url":"https://api.github.com/repos/compnerd/apple-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compnerd/apple-swift/downloads","issues_url":"https://api.github.com/repos/compnerd/apple-swift/issues{/number}","pulls_url":"https://api.github.com/repos/compnerd/apple-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/compnerd/apple-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/compnerd/apple-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compnerd/apple-swift/labels{/name}","releases_url":"https://api.github.com/repos/compnerd/apple-swift/releases{/id}","deployments_url":"https://api.github.com/repos/compnerd/apple-swift/deployments","created_at":"2015-12-14T01:38:31Z","updated_at":"2016-03-08T18:32:13Z","pushed_at":"2016-03-17T21:25:59Z","git_url":"git://github.com/compnerd/apple-swift.git","ssh_url":"git@github.com:compnerd/apple-swift.git","clone_url":"https://github.com/compnerd/apple-swift.git","svn_url":"https://github.com/compnerd/apple-swift","homepage":"https://swift.org/","size":79959,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"1603b0f15352f849ddbc3d9b0de1417bd09b5444","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-03-17T19:40:10Z","pushed_at":"2016-03-17T21:55:04Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":109746,"stargazers_count":27699,"watchers_count":27699,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3626,"mirror_url":null,"open_issues_count":59,"forks":3626,"open_issues":59,"watchers":27699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/1720"},"html":{"href":"https://github.com/apple/swift/pull/1720"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/1720"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/1720/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/1720/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/1720/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/13a2ef3b4b4e1912c74449bf5cea0f2b9fee7ab9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jckarter","id":147281,"avatar_url":"https://avatars.githubusercontent.com/u/147281?v=3","gravatar_id":"","url":"https://api.github.com/users/jckarter","html_url":"https://github.com/jckarter","followers_url":"https://api.github.com/users/jckarter/followers","following_url":"https://api.github.com/users/jckarter/following{/other_user}","gists_url":"https://api.github.com/users/jckarter/gists{/gist_id}","starred_url":"https://api.github.com/users/jckarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jckarter/subscriptions","organizations_url":"https://api.github.com/users/jckarter/orgs","repos_url":"https://api.github.com/users/jckarter/repos","events_url":"https://api.github.com/users/jckarter/events{/privacy}","received_events_url":"https://api.github.com/users/jckarter/received_events","type":"User","site_admin":false},"comments":7,"review_comments":5,"commits":1,"additions":30,"deletions":26,"changed_files":1}}