{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/52846604","id":52846604,"diff_hunk":"@@ -244,5 +242,28 @@ tests config =\n             (concat $ lines (resultOutput r))\n \n     tc :: FilePath -> TestM a -> TestTree\n-    tc name m\n-        = testCase name (runTestM config name Nothing m)\n+    tc = testCase config\n+\n+-- | Tests that require shared libraries.\n+sharedLibTests :: SuiteConfig -> [TestTree]\n+sharedLibTests config =\n+  tail [ undefined","path":"Cabal/tests/PackageTests/Tests.hs","position":65,"original_position":65,"commit_id":"f211508dbb7ff672d1e7388b074d4cf2f59682a1","original_commit_id":"f211508dbb7ff672d1e7388b074d4cf2f59682a1","user":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"body":"I copied the pattern from the top of the file. I meant to ask if I understood it correctly but forgot.","created_at":"2016-02-14T18:23:00Z","updated_at":"2016-02-14T18:23:00Z","html_url":"https://github.com/haskell/cabal/pull/3146#discussion_r52846604","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/3146","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/52846604"},"html":{"href":"https://github.com/haskell/cabal/pull/3146#discussion_r52846604"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3146"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/3146","id":59290953,"html_url":"https://github.com/haskell/cabal/pull/3146","diff_url":"https://github.com/haskell/cabal/pull/3146.diff","patch_url":"https://github.com/haskell/cabal/pull/3146.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/3146","number":3146,"state":"closed","locked":false,"title":"Add flag to disable Cabal package tests that use shared libraries","user":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"body":"The flag `--skip-shared-library-tests` allows the tests to run when shared libraries are unavailable, such as during the AppVeyor build.\r\n\r\nThis is a step towards #3112.  I wanted to minimize the changes to existing tests but also make it easy to see what tests are being skipped.  I'm not sure if this is the best solution.\r\n","created_at":"2016-02-14T09:08:04Z","updated_at":"2016-02-14T18:23:00Z","closed_at":"2016-02-14T18:19:54Z","merged_at":"2016-02-14T18:19:54Z","merge_commit_sha":"5e4185b6352bd6556509ab7f87e0aed43cb05e9a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/3146/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/3146/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/3146/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/f211508dbb7ff672d1e7388b074d4cf2f59682a1","head":{"label":"grayjay:disable-shared-library-tests","ref":"disable-shared-library-tests","sha":"f211508dbb7ff672d1e7388b074d4cf2f59682a1","user":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"repo":{"id":37628967,"name":"cabal","full_name":"grayjay/cabal","owner":{"login":"grayjay","id":4276753,"avatar_url":"https://avatars.githubusercontent.com/u/4276753?v=3","gravatar_id":"","url":"https://api.github.com/users/grayjay","html_url":"https://github.com/grayjay","followers_url":"https://api.github.com/users/grayjay/followers","following_url":"https://api.github.com/users/grayjay/following{/other_user}","gists_url":"https://api.github.com/users/grayjay/gists{/gist_id}","starred_url":"https://api.github.com/users/grayjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayjay/subscriptions","organizations_url":"https://api.github.com/users/grayjay/orgs","repos_url":"https://api.github.com/users/grayjay/repos","events_url":"https://api.github.com/users/grayjay/events{/privacy}","received_events_url":"https://api.github.com/users/grayjay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grayjay/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/grayjay/cabal","forks_url":"https://api.github.com/repos/grayjay/cabal/forks","keys_url":"https://api.github.com/repos/grayjay/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grayjay/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grayjay/cabal/teams","hooks_url":"https://api.github.com/repos/grayjay/cabal/hooks","issue_events_url":"https://api.github.com/repos/grayjay/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/grayjay/cabal/events","assignees_url":"https://api.github.com/repos/grayjay/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/grayjay/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/grayjay/cabal/tags","blobs_url":"https://api.github.com/repos/grayjay/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grayjay/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grayjay/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/grayjay/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grayjay/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/grayjay/cabal/languages","stargazers_url":"https://api.github.com/repos/grayjay/cabal/stargazers","contributors_url":"https://api.github.com/repos/grayjay/cabal/contributors","subscribers_url":"https://api.github.com/repos/grayjay/cabal/subscribers","subscription_url":"https://api.github.com/repos/grayjay/cabal/subscription","commits_url":"https://api.github.com/repos/grayjay/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/grayjay/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/grayjay/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/grayjay/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/grayjay/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/grayjay/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grayjay/cabal/merges","archive_url":"https://api.github.com/repos/grayjay/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grayjay/cabal/downloads","issues_url":"https://api.github.com/repos/grayjay/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/grayjay/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/grayjay/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/grayjay/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grayjay/cabal/labels{/name}","releases_url":"https://api.github.com/repos/grayjay/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/grayjay/cabal/deployments","created_at":"2015-06-18T00:45:24Z","updated_at":"2016-02-09T01:06:51Z","pushed_at":"2016-02-14T09:52:43Z","git_url":"git://github.com/grayjay/cabal.git","ssh_url":"git@github.com:grayjay/cabal.git","clone_url":"https://github.com/grayjay/cabal.git","svn_url":"https://github.com/grayjay/cabal","homepage":"http://haskell.org/cabal","size":28071,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"af246b1a6d9692febef82654ed13ee11478ff669","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-02-12T15:24:37Z","pushed_at":"2016-02-14T18:19:55Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":32098,"stargazers_count":579,"watchers_count":579,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":310,"mirror_url":null,"open_issues_count":692,"forks":310,"open_issues":692,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3146"},"html":{"href":"https://github.com/haskell/cabal/pull/3146"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/3146"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/3146/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3146/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3146/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/f211508dbb7ff672d1e7388b074d4cf2f59682a1"}}}}