{"action":"opened","number":429,"pull_request":{"url":"https://api.github.com/repos/xeolabs/scenejs/pulls/429","id":55401775,"html_url":"https://github.com/xeolabs/scenejs/pull/429","diff_url":"https://github.com/xeolabs/scenejs/pull/429.diff","patch_url":"https://github.com/xeolabs/scenejs/pull/429.patch","issue_url":"https://api.github.com/repos/xeolabs/scenejs/issues/429","number":429,"state":"open","locked":false,"title":"Fix bug in modelXFormStack.pop()","user":{"login":"tsherif","id":476017,"avatar_url":"https://avatars.githubusercontent.com/u/476017?v=3","gravatar_id":"","url":"https://api.github.com/users/tsherif","html_url":"https://github.com/tsherif","followers_url":"https://api.github.com/users/tsherif/followers","following_url":"https://api.github.com/users/tsherif/following{/other_user}","gists_url":"https://api.github.com/users/tsherif/gists{/gist_id}","starred_url":"https://api.github.com/users/tsherif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsherif/subscriptions","organizations_url":"https://api.github.com/users/tsherif/orgs","repos_url":"https://api.github.com/users/tsherif/repos","events_url":"https://api.github.com/users/tsherif/events{/privacy}","received_events_url":"https://api.github.com/users/tsherif/received_events","type":"User","site_admin":false},"body":"Fixes a bug introduced in 6f43c28. The `modelXFormStack.pop()` method shouldn't destroy the parent-child relationships in the transform hierarchy (the asymmetry between `push` and `pop` is a little confusing). I did add a line, however, to make sure the transformStack doesn't hold on to core references, in case they get destroyed later.\r\n\r\nThis actually fixes the [transform hierarchy example](http://scenejs.org/examples/index.html#transforms_modelling_hierarchy), which I didn't realize was broken.\r\n\r\nThis might fix the bug that was being addressed in PR #421.\r\n","created_at":"2016-01-07T22:47:34Z","updated_at":"2016-01-07T22:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xeolabs/scenejs/pulls/429/commits","review_comments_url":"https://api.github.com/repos/xeolabs/scenejs/pulls/429/comments","review_comment_url":"https://api.github.com/repos/xeolabs/scenejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xeolabs/scenejs/issues/429/comments","statuses_url":"https://api.github.com/repos/xeolabs/scenejs/statuses/6370aad26c68a906aad35a035344ebc34488cc55","head":{"label":"tsherif:xform-stack-fix","ref":"xform-stack-fix","sha":"6370aad26c68a906aad35a035344ebc34488cc55","user":{"login":"tsherif","id":476017,"avatar_url":"https://avatars.githubusercontent.com/u/476017?v=3","gravatar_id":"","url":"https://api.github.com/users/tsherif","html_url":"https://github.com/tsherif","followers_url":"https://api.github.com/users/tsherif/followers","following_url":"https://api.github.com/users/tsherif/following{/other_user}","gists_url":"https://api.github.com/users/tsherif/gists{/gist_id}","starred_url":"https://api.github.com/users/tsherif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsherif/subscriptions","organizations_url":"https://api.github.com/users/tsherif/orgs","repos_url":"https://api.github.com/users/tsherif/repos","events_url":"https://api.github.com/users/tsherif/events{/privacy}","received_events_url":"https://api.github.com/users/tsherif/received_events","type":"User","site_admin":false},"repo":{"id":28345647,"name":"scenejs","full_name":"tsherif/scenejs","owner":{"login":"tsherif","id":476017,"avatar_url":"https://avatars.githubusercontent.com/u/476017?v=3","gravatar_id":"","url":"https://api.github.com/users/tsherif","html_url":"https://github.com/tsherif","followers_url":"https://api.github.com/users/tsherif/followers","following_url":"https://api.github.com/users/tsherif/following{/other_user}","gists_url":"https://api.github.com/users/tsherif/gists{/gist_id}","starred_url":"https://api.github.com/users/tsherif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsherif/subscriptions","organizations_url":"https://api.github.com/users/tsherif/orgs","repos_url":"https://api.github.com/users/tsherif/repos","events_url":"https://api.github.com/users/tsherif/events{/privacy}","received_events_url":"https://api.github.com/users/tsherif/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsherif/scenejs","description":"An extensible WebGL-based engine for high-detail 3D visualisation","fork":true,"url":"https://api.github.com/repos/tsherif/scenejs","forks_url":"https://api.github.com/repos/tsherif/scenejs/forks","keys_url":"https://api.github.com/repos/tsherif/scenejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsherif/scenejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsherif/scenejs/teams","hooks_url":"https://api.github.com/repos/tsherif/scenejs/hooks","issue_events_url":"https://api.github.com/repos/tsherif/scenejs/issues/events{/number}","events_url":"https://api.github.com/repos/tsherif/scenejs/events","assignees_url":"https://api.github.com/repos/tsherif/scenejs/assignees{/user}","branches_url":"https://api.github.com/repos/tsherif/scenejs/branches{/branch}","tags_url":"https://api.github.com/repos/tsherif/scenejs/tags","blobs_url":"https://api.github.com/repos/tsherif/scenejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsherif/scenejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsherif/scenejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsherif/scenejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsherif/scenejs/statuses/{sha}","languages_url":"https://api.github.com/repos/tsherif/scenejs/languages","stargazers_url":"https://api.github.com/repos/tsherif/scenejs/stargazers","contributors_url":"https://api.github.com/repos/tsherif/scenejs/contributors","subscribers_url":"https://api.github.com/repos/tsherif/scenejs/subscribers","subscription_url":"https://api.github.com/repos/tsherif/scenejs/subscription","commits_url":"https://api.github.com/repos/tsherif/scenejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsherif/scenejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsherif/scenejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsherif/scenejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsherif/scenejs/contents/{+path}","compare_url":"https://api.github.com/repos/tsherif/scenejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsherif/scenejs/merges","archive_url":"https://api.github.com/repos/tsherif/scenejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsherif/scenejs/downloads","issues_url":"https://api.github.com/repos/tsherif/scenejs/issues{/number}","pulls_url":"https://api.github.com/repos/tsherif/scenejs/pulls{/number}","milestones_url":"https://api.github.com/repos/tsherif/scenejs/milestones{/number}","notifications_url":"https://api.github.com/repos/tsherif/scenejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsherif/scenejs/labels{/name}","releases_url":"https://api.github.com/repos/tsherif/scenejs/releases{/id}","created_at":"2014-12-22T15:56:23Z","updated_at":"2014-12-22T15:56:26Z","pushed_at":"2016-01-07T22:42:40Z","git_url":"git://github.com/tsherif/scenejs.git","ssh_url":"git@github.com:tsherif/scenejs.git","clone_url":"https://github.com/tsherif/scenejs.git","svn_url":"https://github.com/tsherif/scenejs","homepage":"http://scenejs.org","size":433763,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xeolabs:master","ref":"master","sha":"d55d84352af571833706633c252a8f9cd2d54f48","user":{"login":"xeolabs","id":83100,"avatar_url":"https://avatars.githubusercontent.com/u/83100?v=3","gravatar_id":"","url":"https://api.github.com/users/xeolabs","html_url":"https://github.com/xeolabs","followers_url":"https://api.github.com/users/xeolabs/followers","following_url":"https://api.github.com/users/xeolabs/following{/other_user}","gists_url":"https://api.github.com/users/xeolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/xeolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeolabs/subscriptions","organizations_url":"https://api.github.com/users/xeolabs/orgs","repos_url":"https://api.github.com/users/xeolabs/repos","events_url":"https://api.github.com/users/xeolabs/events{/privacy}","received_events_url":"https://api.github.com/users/xeolabs/received_events","type":"User","site_admin":false},"repo":{"id":332509,"name":"scenejs","full_name":"xeolabs/scenejs","owner":{"login":"xeolabs","id":83100,"avatar_url":"https://avatars.githubusercontent.com/u/83100?v=3","gravatar_id":"","url":"https://api.github.com/users/xeolabs","html_url":"https://github.com/xeolabs","followers_url":"https://api.github.com/users/xeolabs/followers","following_url":"https://api.github.com/users/xeolabs/following{/other_user}","gists_url":"https://api.github.com/users/xeolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/xeolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeolabs/subscriptions","organizations_url":"https://api.github.com/users/xeolabs/orgs","repos_url":"https://api.github.com/users/xeolabs/repos","events_url":"https://api.github.com/users/xeolabs/events{/privacy}","received_events_url":"https://api.github.com/users/xeolabs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xeolabs/scenejs","description":"An extensible WebGL-based engine for high-detail 3D visualisation","fork":false,"url":"https://api.github.com/repos/xeolabs/scenejs","forks_url":"https://api.github.com/repos/xeolabs/scenejs/forks","keys_url":"https://api.github.com/repos/xeolabs/scenejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xeolabs/scenejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xeolabs/scenejs/teams","hooks_url":"https://api.github.com/repos/xeolabs/scenejs/hooks","issue_events_url":"https://api.github.com/repos/xeolabs/scenejs/issues/events{/number}","events_url":"https://api.github.com/repos/xeolabs/scenejs/events","assignees_url":"https://api.github.com/repos/xeolabs/scenejs/assignees{/user}","branches_url":"https://api.github.com/repos/xeolabs/scenejs/branches{/branch}","tags_url":"https://api.github.com/repos/xeolabs/scenejs/tags","blobs_url":"https://api.github.com/repos/xeolabs/scenejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xeolabs/scenejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xeolabs/scenejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/xeolabs/scenejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xeolabs/scenejs/statuses/{sha}","languages_url":"https://api.github.com/repos/xeolabs/scenejs/languages","stargazers_url":"https://api.github.com/repos/xeolabs/scenejs/stargazers","contributors_url":"https://api.github.com/repos/xeolabs/scenejs/contributors","subscribers_url":"https://api.github.com/repos/xeolabs/scenejs/subscribers","subscription_url":"https://api.github.com/repos/xeolabs/scenejs/subscription","commits_url":"https://api.github.com/repos/xeolabs/scenejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/xeolabs/scenejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/xeolabs/scenejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/xeolabs/scenejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/xeolabs/scenejs/contents/{+path}","compare_url":"https://api.github.com/repos/xeolabs/scenejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xeolabs/scenejs/merges","archive_url":"https://api.github.com/repos/xeolabs/scenejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xeolabs/scenejs/downloads","issues_url":"https://api.github.com/repos/xeolabs/scenejs/issues{/number}","pulls_url":"https://api.github.com/repos/xeolabs/scenejs/pulls{/number}","milestones_url":"https://api.github.com/repos/xeolabs/scenejs/milestones{/number}","notifications_url":"https://api.github.com/repos/xeolabs/scenejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xeolabs/scenejs/labels{/name}","releases_url":"https://api.github.com/repos/xeolabs/scenejs/releases{/id}","created_at":"2009-10-09T20:34:35Z","updated_at":"2016-01-07T01:13:33Z","pushed_at":"2015-12-27T11:49:33Z","git_url":"git://github.com/xeolabs/scenejs.git","ssh_url":"git@github.com:xeolabs/scenejs.git","clone_url":"https://github.com/xeolabs/scenejs.git","svn_url":"https://github.com/xeolabs/scenejs","homepage":"http://scenejs.org","size":444464,"stargazers_count":421,"watchers_count":421,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":90,"forks":95,"open_issues":90,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xeolabs/scenejs/pulls/429"},"html":{"href":"https://github.com/xeolabs/scenejs/pull/429"},"issue":{"href":"https://api.github.com/repos/xeolabs/scenejs/issues/429"},"comments":{"href":"https://api.github.com/repos/xeolabs/scenejs/issues/429/comments"},"review_comments":{"href":"https://api.github.com/repos/xeolabs/scenejs/pulls/429/comments"},"review_comment":{"href":"https://api.github.com/repos/xeolabs/scenejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xeolabs/scenejs/pulls/429/commits"},"statuses":{"href":"https://api.github.com/repos/xeolabs/scenejs/statuses/6370aad26c68a906aad35a035344ebc34488cc55"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":2,"deletions":4,"changed_files":1}}