{"action":"created","issue":{"url":"https://api.github.com/repos/Esri/arcgis-osm-editor/issues/138","repository_url":"https://api.github.com/repos/Esri/arcgis-osm-editor","labels_url":"https://api.github.com/repos/Esri/arcgis-osm-editor/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/Esri/arcgis-osm-editor/issues/138/comments","events_url":"https://api.github.com/repos/Esri/arcgis-osm-editor/issues/138/events","html_url":"https://github.com/Esri/arcgis-osm-editor/issues/138","id":163441036,"number":138,"title":"Potential issue with ways and relations processing in new OSM File Loader (Load only) tool","user":{"login":"mboeringa","id":7635726,"avatar_url":"https://avatars.githubusercontent.com/u/7635726?v=3","gravatar_id":"","url":"https://api.github.com/users/mboeringa","html_url":"https://github.com/mboeringa","followers_url":"https://api.github.com/users/mboeringa/followers","following_url":"https://api.github.com/users/mboeringa/following{/other_user}","gists_url":"https://api.github.com/users/mboeringa/gists{/gist_id}","starred_url":"https://api.github.com/users/mboeringa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboeringa/subscriptions","organizations_url":"https://api.github.com/users/mboeringa/orgs","repos_url":"https://api.github.com/users/mboeringa/repos","events_url":"https://api.github.com/users/mboeringa/events{/privacy}","received_events_url":"https://api.github.com/users/mboeringa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-07-01T17:32:21Z","updated_at":"2016-07-08T19:08:27Z","closed_at":"2016-07-08T19:08:27Z","body":"Hi @ThomasEmge ,\r\n\r\nI hope I am not bothering you to much with yet another potential issue, but I think there may be an important issue with the ways and relations processing in the new **OSM File Loader (Load only)** tool.\r\n\r\nAs I am currently unable to use my ArcGIS Renderer for OpenStreetMap with the new **OSM File Loader (Load only)** output due to a field naming conflict between the old **Load OSM File** tool and the new tool, I haven't yet properly evaluated the output of the new tool.\r\n\r\nHowever, as a first test, I decided to download a section of Berlin with the Bode Museum (http://www.openstreetmap.org/relation/4211594), that we have been using to tackle the OpenStreetMap Simple 3D building relations in the solved issue #72.\r\n\r\nOnce I loaded the data with the new OSM File Loader, and selected buildings only using:\r\n\r\n`\r\nosm_building IS NOT NULL AND osm_building NOT IN ('no','')`\r\n\r\nI noticed an issue though, there seemed to be an overlapping polygon feature at the same location as the Bode Museum's multipolygon relation. Subsequently, I discovered that this feature, which uses the Bode Museum's way outline, falsely carries the attributes of another way object. It shows up as a building feature with the tag:\r\n\r\n**building=commercial**\r\n\r\nHowever, there is no commercial building at this location, just the Bode Museum. Checking the individual ways, including the outline way of the Bode Museum on the OpenStreetMap website (http://www.openstreetmap.org/way/313659705), that does not carry any tags of its own, it became clear these tags must be coming from somewhere else, another feature. This is also confirmed by the wrong OSMID on the feature, which lists as **w14582095**. Checking this feature out on the OpenStreetMap website, it turned out to be another building quite some distance away from the Bode Museum. See this image, the lower left downward pointing arrow denoting the true  **w14582095** commercial building, the upper right one pointing to the Bode Museum:\r\n\r\n![way14582095_true_location_osm_website](https://cloud.githubusercontent.com/assets/7635726/16527451/3f39777c-3fb7-11e6-96db-760ffe802752.jpg)\r\n\r\nIt appears there may be some issues with the indexes or dictionaries keeping track of the objects, maybe a similar issue as the one in #117?\r\n\r\nAnyway, the following images show more detail and explain the issue in more detail. I have also included a ZIP from the Berlin OSM file I used, so you can test and see if you come up the same result.\r\n\r\nAs a start, the following image shows the Bode Museum multipolygon relation as it is visible on the OpenStreetMap website. Notice the relation ID of **4211594**:\r\n\r\n![relation4211594_bode_museum_osm_website](https://cloud.githubusercontent.com/assets/7635726/16528910/fc92f48a-3fbf-11e6-8cb6-39f87ee724a3.jpg)\r\n\r\nThe second image shows the multipolygon relation as loaded by the \"old\" **Load OSM File** tool. Notice in the identify window that it has the proper OSMID as on the OpenStreetMap website. This looks good:\r\n\r\n![way4211594_bode_museum_load_osm_file](https://cloud.githubusercontent.com/assets/7635726/16527449/3f3832e0-3fb7-11e6-9be2-d2f2574336bd.jpg)\r\n\r\nNext up is the same multipolygon relation as loaded by the \"new\" **OSM File Loader (Load only)** tool. Notice this is also OK, and displaying the proper OSMID and properties / tags:\r\n\r\n![relation4211594_bode_museum_osm_file_loader](https://cloud.githubusercontent.com/assets/7635726/16527447/3f2b377a-3fb7-11e6-9916-4f391a6235d4.jpg)\r\n\r\nNow the issue though: by using the following selection statement:\r\n\r\n`osm_building IS NOT NULL AND osm_building NOT IN ('no','') AND OSMID = 'w14582095'`\r\n\r\na building polygon representing the outline of the Bode Museum is selected. This has wrong polygon / way information associated with it. Remember that I checked the way outline of the Bode Museum on the OpenStreetMap website, and it did not have this information associated with it. Notice the OSMID displayed is **14582095**. By using this OSMID on the OSM website, I was able to identify the feature where these wrong tags came from, see the first image I posted of the secondary building some distance away from the Bode Museum.\r\n\r\nYou can also directly select it using this link:\r\n\r\nhttp://www.openstreetmap.org/way/14582095#map=19/52.51053/13.37911\r\n\r\n![way14582095_identified_osm_file_loader](https://cloud.githubusercontent.com/assets/7635726/16527448/3f2c1af0-3fb7-11e6-8bd8-5336e59c1e69.jpg)\r\n\r\n*** EDIT: *** forgot the ZIP with the osm XML file, here it is:\r\n\r\n[OSM_Berlin.zip](https://github.com/Esri/arcgis-osm-editor/files/343903/OSM_Berlin.zip)\r\n"},"comment":{"url":"https://api.github.com/repos/Esri/arcgis-osm-editor/issues/comments/231446866","html_url":"https://github.com/Esri/arcgis-osm-editor/issues/138#issuecomment-231446866","issue_url":"https://api.github.com/repos/Esri/arcgis-osm-editor/issues/138","id":231446866,"user":{"login":"mboeringa","id":7635726,"avatar_url":"https://avatars.githubusercontent.com/u/7635726?v=3","gravatar_id":"","url":"https://api.github.com/users/mboeringa","html_url":"https://github.com/mboeringa","followers_url":"https://api.github.com/users/mboeringa/followers","following_url":"https://api.github.com/users/mboeringa/following{/other_user}","gists_url":"https://api.github.com/users/mboeringa/gists{/gist_id}","starred_url":"https://api.github.com/users/mboeringa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboeringa/subscriptions","organizations_url":"https://api.github.com/users/mboeringa/orgs","repos_url":"https://api.github.com/users/mboeringa/repos","events_url":"https://api.github.com/users/mboeringa/events{/privacy}","received_events_url":"https://api.github.com/users/mboeringa/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T19:08:27Z","updated_at":"2016-07-08T19:08:27Z","body":"> I just updated the download location. The commit and the setup build had indeed a different date.\r\n\r\nThanks, that looks much better! Just the Bode Museum multipolygon relation left as building:\r\n\r\n![relation4211594_bode_museum_osm_file_loader_release8](https://cloud.githubusercontent.com/assets/7635726/16698719/f4db81ea-454f-11e6-9e74-104d87796575.jpg)\r\n\r\nAnd with that, I think I can close this for now. I will keep an eye on other issues though in further testing.\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"mboeringa"}}