{"action":"created","comment":{"url":"https://api.github.com/repos/ably/ably-ios/pulls/comments/53950681","id":53950681,"diff_hunk":"@@ -1297,6 +1299,66 @@ class RealtimeClientChannel: QuickSpec {\n \n             }\n \n+            context(\"crypto\") {\n+                it(\"if configured for encryption, channels encrypt and decrypt messages' data\") {","path":"ablySpec/RealtimeClientChannel.swift","position":25,"original_position":25,"commit_id":"a3c420821fcd7fd9583a388b652a477f5c575e3e","original_commit_id":"a3c420821fcd7fd9583a388b652a477f5c575e3e","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"body":"I like this test, however I am concerned that at no point are we actually checking that the message is encrypted i.e. if you removed the cipher options completely this test would still pass.  A simple way to make sure this test is actually checking for encrypted messages is to add another subscriber that has encryption disabled and check that the messages are received with an encrypted payload i.e. `data` should be different and `encoding` should indicate it's an encrypted payload","created_at":"2016-02-24T15:05:12Z","updated_at":"2016-02-24T15:05:12Z","html_url":"https://github.com/ably/ably-ios/pull/231#discussion_r53950681","pull_request_url":"https://api.github.com/repos/ably/ably-ios/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/comments/53950681"},"html":{"href":"https://github.com/ably/ably-ios/pull/231#discussion_r53950681"},"pull_request":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/ably/ably-ios/pulls/231","id":59919948,"html_url":"https://github.com/ably/ably-ios/pull/231","diff_url":"https://github.com/ably/ably-ios/pull/231.diff","patch_url":"https://github.com/ably/ably-ios/pull/231.patch","issue_url":"https://api.github.com/repos/ably/ably-ios/issues/231","number":231,"state":"open","locked":false,"title":"Adjust Crypto, CipherParams and ChannelOptions to spec.","user":{"login":"tcard","id":727422,"avatar_url":"https://avatars.githubusercontent.com/u/727422?v=3","gravatar_id":"","url":"https://api.github.com/users/tcard","html_url":"https://github.com/tcard","followers_url":"https://api.github.com/users/tcard/followers","following_url":"https://api.github.com/users/tcard/following{/other_user}","gists_url":"https://api.github.com/users/tcard/gists{/gist_id}","starred_url":"https://api.github.com/users/tcard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcard/subscriptions","organizations_url":"https://api.github.com/users/tcard/orgs","repos_url":"https://api.github.com/users/tcard/repos","events_url":"https://api.github.com/users/tcard/events{/privacy}","received_events_url":"https://api.github.com/users/tcard/received_events","type":"User","site_admin":false},"body":"https://github.com/ably/ably-ios/pull/211#discussion_r53042652\r\n\r\nI've kept the IV param in Crypto.getDefaultParams for the reasons mentioned in the discussion.","created_at":"2016-02-19T08:49:02Z","updated_at":"2016-02-24T15:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c68351bee7c49dc2e1a75d80e9c6eb55f3a01e8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ably/ably-ios/pulls/231/commits","review_comments_url":"https://api.github.com/repos/ably/ably-ios/pulls/231/comments","review_comment_url":"https://api.github.com/repos/ably/ably-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ably/ably-ios/issues/231/comments","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/a3c420821fcd7fd9583a388b652a477f5c575e3e","head":{"label":"ably:fix-crypto-api","ref":"fix-crypto-api","sha":"a3c420821fcd7fd9583a388b652a477f5c575e3e","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":27377471,"name":"ably-ios","full_name":"ably/ably-ios","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-ios","description":"iOS Objective-C client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-ios","forks_url":"https://api.github.com/repos/ably/ably-ios/forks","keys_url":"https://api.github.com/repos/ably/ably-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-ios/teams","hooks_url":"https://api.github.com/repos/ably/ably-ios/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-ios/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-ios/events","assignees_url":"https://api.github.com/repos/ably/ably-ios/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-ios/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-ios/tags","blobs_url":"https://api.github.com/repos/ably/ably-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-ios/languages","stargazers_url":"https://api.github.com/repos/ably/ably-ios/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-ios/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-ios/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-ios/subscription","commits_url":"https://api.github.com/repos/ably/ably-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-ios/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-ios/merges","archive_url":"https://api.github.com/repos/ably/ably-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-ios/downloads","issues_url":"https://api.github.com/repos/ably/ably-ios/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-ios/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-ios/releases{/id}","deployments_url":"https://api.github.com/repos/ably/ably-ios/deployments","created_at":"2014-12-01T12:00:37Z","updated_at":"2016-01-12T18:38:23Z","pushed_at":"2016-02-24T14:48:38Z","git_url":"git://github.com/ably/ably-ios.git","ssh_url":"git@github.com:ably/ably-ios.git","clone_url":"https://github.com/ably/ably-ios.git","svn_url":"https://github.com/ably/ably-ios","homepage":null,"size":1968,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":32,"forks":2,"open_issues":32,"watchers":1,"default_branch":"master"}},"base":{"label":"ably:master","ref":"master","sha":"b1865477b3646f256334269d2c9b73b9a615e061","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":27377471,"name":"ably-ios","full_name":"ably/ably-ios","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-ios","description":"iOS Objective-C client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-ios","forks_url":"https://api.github.com/repos/ably/ably-ios/forks","keys_url":"https://api.github.com/repos/ably/ably-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-ios/teams","hooks_url":"https://api.github.com/repos/ably/ably-ios/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-ios/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-ios/events","assignees_url":"https://api.github.com/repos/ably/ably-ios/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-ios/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-ios/tags","blobs_url":"https://api.github.com/repos/ably/ably-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-ios/languages","stargazers_url":"https://api.github.com/repos/ably/ably-ios/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-ios/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-ios/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-ios/subscription","commits_url":"https://api.github.com/repos/ably/ably-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-ios/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-ios/merges","archive_url":"https://api.github.com/repos/ably/ably-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-ios/downloads","issues_url":"https://api.github.com/repos/ably/ably-ios/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-ios/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-ios/releases{/id}","deployments_url":"https://api.github.com/repos/ably/ably-ios/deployments","created_at":"2014-12-01T12:00:37Z","updated_at":"2016-01-12T18:38:23Z","pushed_at":"2016-02-24T14:48:38Z","git_url":"git://github.com/ably/ably-ios.git","ssh_url":"git@github.com:ably/ably-ios.git","clone_url":"https://github.com/ably/ably-ios.git","svn_url":"https://github.com/ably/ably-ios","homepage":null,"size":1968,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":32,"forks":2,"open_issues":32,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/231"},"html":{"href":"https://github.com/ably/ably-ios/pull/231"},"issue":{"href":"https://api.github.com/repos/ably/ably-ios/issues/231"},"comments":{"href":"https://api.github.com/repos/ably/ably-ios/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/ably/ably-ios/statuses/a3c420821fcd7fd9583a388b652a477f5c575e3e"}}}}