{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/93295459","pull_request_review_id":13819978,"id":93295459,"diff_hunk":"@@ -695,9 +695,19 @@ private InodeLockList lockDescendantsInternal(InodeDirectory inodeDirectory,\n       LockMode lockMode, InodeLockList inodeGroup) {\n     for (Inode<?> child : inodeDirectory.getChildren()) {\n       if (lockMode == LockMode.READ) {\n-        inodeGroup.lockRead(child);\n+        try {\n+          inodeGroup.lockReadAndCheckParent(child, inodeDirectory);\n+        } catch (InvalidPathException e) {\n+          // Inode is no longer a descendant, continue.\n+          continue;\n+        }\n       } else {\n-        inodeGroup.lockWrite(child);\n+        try {\n+          inodeGroup.lockWriteAndCheckParent(child, inodeDirectory);\n+        } catch (InvalidPathException e) {\n+          // Inode is no longer a descendant, continue.","path":"core/server/src/main/java/alluxio/master/file/meta/InodeTree.java","position":52,"original_position":52,"commit_id":"0c4354c135cc05ae42959e4bd0a345f78e6999f8","original_commit_id":"0c4354c135cc05ae42959e4bd0a345f78e6999f8","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"body":"Updated, thanks.","created_at":"2016-12-20T18:24:24Z","updated_at":"2016-12-20T18:24:24Z","html_url":"https://github.com/Alluxio/alluxio/pull/4452#discussion_r93295459","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/93295459"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/4452#discussion_r93295459"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452","id":98389971,"html_url":"https://github.com/Alluxio/alluxio/pull/4452","diff_url":"https://github.com/Alluxio/alluxio/pull/4452.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/4452.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/4452","number":4452,"state":"open","locked":false,"title":"[ALLUXIO-2453] Concurrent rename","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-2453","created_at":"2016-12-16T19:30:25Z","updated_at":"2016-12-20T18:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ccfbebcf1c69b6a93e79dae904ef45faf8dd3e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/4452/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/0c4354c135cc05ae42959e4bd0a345f78e6999f8","head":{"label":"calvinjia:concurrent-rename","ref":"concurrent-rename","sha":"0c4354c135cc05ae42959e4bd0a345f78e6999f8","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"repo":{"id":9278135,"name":"tachyon","full_name":"calvinjia/tachyon","owner":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calvinjia/tachyon","description":"Tachyon","fork":true,"url":"https://api.github.com/repos/calvinjia/tachyon","forks_url":"https://api.github.com/repos/calvinjia/tachyon/forks","keys_url":"https://api.github.com/repos/calvinjia/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calvinjia/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calvinjia/tachyon/teams","hooks_url":"https://api.github.com/repos/calvinjia/tachyon/hooks","issue_events_url":"https://api.github.com/repos/calvinjia/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/calvinjia/tachyon/events","assignees_url":"https://api.github.com/repos/calvinjia/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/calvinjia/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/calvinjia/tachyon/tags","blobs_url":"https://api.github.com/repos/calvinjia/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calvinjia/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calvinjia/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/calvinjia/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calvinjia/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/calvinjia/tachyon/languages","stargazers_url":"https://api.github.com/repos/calvinjia/tachyon/stargazers","contributors_url":"https://api.github.com/repos/calvinjia/tachyon/contributors","subscribers_url":"https://api.github.com/repos/calvinjia/tachyon/subscribers","subscription_url":"https://api.github.com/repos/calvinjia/tachyon/subscription","commits_url":"https://api.github.com/repos/calvinjia/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/calvinjia/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/calvinjia/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/calvinjia/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/calvinjia/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/calvinjia/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calvinjia/tachyon/merges","archive_url":"https://api.github.com/repos/calvinjia/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calvinjia/tachyon/downloads","issues_url":"https://api.github.com/repos/calvinjia/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/calvinjia/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/calvinjia/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/calvinjia/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calvinjia/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/calvinjia/tachyon/releases{/id}","deployments_url":"https://api.github.com/repos/calvinjia/tachyon/deployments","created_at":"2013-04-07T14:56:38Z","updated_at":"2016-10-24T17:48:26Z","pushed_at":"2016-12-20T07:39:29Z","git_url":"git://github.com/calvinjia/tachyon.git","ssh_url":"git@github.com:calvinjia/tachyon.git","clone_url":"https://github.com/calvinjia/tachyon.git","svn_url":"https://github.com/calvinjia/tachyon","homepage":null,"size":64644,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"85818866b26b48139e036340103031d1a55f04bc","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, A Virtual Distributed Storage at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-12-20T15:37:43Z","pushed_at":"2016-12-20T18:14:32Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":64062,"stargazers_count":2769,"watchers_count":2769,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1258,"mirror_url":null,"open_issues_count":23,"forks":1258,"open_issues":23,"watchers":2769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/4452"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/4452"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/4452/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/4452/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/0c4354c135cc05ae42959e4bd0a345f78e6999f8"}}}}
{"actor":{"display_login":"calvinjia"}}