{"action":"created","issue":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/2743","repository_url":"https://api.github.com/repos/musescore/MuseScore","labels_url":"https://api.github.com/repos/musescore/MuseScore/issues/2743/labels{/name}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/2743/comments","events_url":"https://api.github.com/repos/musescore/MuseScore/issues/2743/events","html_url":"https://github.com/musescore/MuseScore/pull/2743","id":165310313,"number":2743,"title":"remove intToDirection converter for QVariant","user":{"login":"heuchi","id":2162327,"avatar_url":"https://avatars.githubusercontent.com/u/2162327?v=3","gravatar_id":"","url":"https://api.github.com/users/heuchi","html_url":"https://github.com/heuchi","followers_url":"https://api.github.com/users/heuchi/followers","following_url":"https://api.github.com/users/heuchi/following{/other_user}","gists_url":"https://api.github.com/users/heuchi/gists{/gist_id}","starred_url":"https://api.github.com/users/heuchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuchi/subscriptions","organizations_url":"https://api.github.com/users/heuchi/orgs","repos_url":"https://api.github.com/users/heuchi/repos","events_url":"https://api.github.com/users/heuchi/events{/privacy}","received_events_url":"https://api.github.com/users/heuchi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-13T12:39:26Z","updated_at":"2016-07-13T12:43:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/2743","html_url":"https://github.com/musescore/MuseScore/pull/2743","diff_url":"https://github.com/musescore/MuseScore/pull/2743.diff","patch_url":"https://github.com/musescore/MuseScore/pull/2743.patch"},"body":"Since @wschweer did not like the converter from int to Direction, I removed it and corrected the explicit conversion from Direction to int in the calls to undoChangeProperty(). I tested the flip commands on notes, beams, tuplets and articulation. All seems to work fine. I also had a local test branch with added canConvert<Direction> calls, that all passed."},"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/232343517","html_url":"https://github.com/musescore/MuseScore/pull/2743#issuecomment-232343517","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/2743","id":232343517,"user":{"login":"lasconic","id":234271,"avatar_url":"https://avatars.githubusercontent.com/u/234271?v=3","gravatar_id":"","url":"https://api.github.com/users/lasconic","html_url":"https://github.com/lasconic","followers_url":"https://api.github.com/users/lasconic/followers","following_url":"https://api.github.com/users/lasconic/following{/other_user}","gists_url":"https://api.github.com/users/lasconic/gists{/gist_id}","starred_url":"https://api.github.com/users/lasconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasconic/subscriptions","organizations_url":"https://api.github.com/users/lasconic/orgs","repos_url":"https://api.github.com/users/lasconic/repos","events_url":"https://api.github.com/users/lasconic/events{/privacy}","received_events_url":"https://api.github.com/users/lasconic/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T12:43:55Z","updated_at":"2016-07-13T12:43:55Z","body":"Thanks. After a short discussion with @wschweer, I understand that the way we use enums and class enums in MuseScore is still in flux. \r\n\r\nDirection was an experiment in order to find a way to use enums such that\r\n\r\n* the enum is accessible from plugins\r\n* We don't use cast, or anything that the compiler can't catch\r\n* QVariant<->Enum conversion without registerConverter\r\n* converting to/from text in write() and read properties, \r\n* uniform handling in inspector and style\r\n\r\nCons\r\nits possible to create the wrong types without getting any compiler warning...\r\n"}}
{"actor":{"display_login":"lasconic"}}