{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman-installer/issues/205","repository_url":"https://api.github.com/repos/theforeman/foreman-installer","labels_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/205/comments","events_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/205/events","html_url":"https://github.com/theforeman/foreman-installer/pull/205","id":186312524,"number":205,"title":"refs #16207 - generate custom.yaml symlink during build phase","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"labels":[{"id":322162673,"url":"https://api.github.com/repos/theforeman/foreman-installer/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":322162674,"url":"https://api.github.com/repos/theforeman/foreman-installer/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-31T15:25:12Z","updated_at":"2016-10-31T15:35:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/205","html_url":"https://github.com/theforeman/foreman-installer/pull/205","diff_url":"https://github.com/theforeman/foreman-installer/pull/205.diff","patch_url":"https://github.com/theforeman/foreman-installer/pull/205.patch"},"body":"Ensures the build phase of the Rakefile can be run with a different\r\nprefix to the installation phase, for use in package builds where the\r\ninstallation phase prefix is not the standard directory. Matches how\r\nconfiguration files all have paths set in the build phase.\r\n\r\n---\r\n\r\n`rake clean build PREFIX=/ SYSCONFDIR=/etc && rake install PREFIX=/tmp/installer` on develop currently generates:\r\n\r\n    -rw-rw-r--. 1 dcleal dcleal 736 Oct 31 15:18 /tmp/installer/etc/foreman-installer/custom-hiera.yaml\r\n    lrwxrwxrwx. 1 dcleal dcleal  54 Oct 31 15:18 /tmp/installer/share/foreman-installer/config/foreman.hiera/custom.yaml -> /tmp/installer/etc/foreman-installer/custom-hiera.yaml\r\n\r\nbut with this patch it generates a symlink pointing to the directory provided at build time:\r\n\r\n    -rw-rw-r--. 1 dcleal dcleal 736 Oct 31 15:17 /tmp/installer/etc/foreman-installer/custom-hiera.yaml\r\n    lrwxrwxrwx. 1 dcleal dcleal  40 Oct 31 15:17 /tmp/installer/share/foreman-installer/config/foreman.hiera/custom.yaml -> /etc/foreman-installer/custom-hiera.yaml\r\n"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman-installer/issues/comments/257327520","html_url":"https://github.com/theforeman/foreman-installer/pull/205#issuecomment-257327520","issue_url":"https://api.github.com/repos/theforeman/foreman-installer/issues/205","id":257327520,"user":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T15:35:32Z","updated_at":"2016-10-31T15:35:32Z","body":"The first version looks correct to me, why wouldn't you want the symlink to be correct according to the environment set during install?\r\n"}}
{"actor":{"display_login":"stbenjam"}}