{"action":"created","issue":{"url":"https://api.github.com/repos/redding/dk/issues/26","repository_url":"https://api.github.com/repos/redding/dk","labels_url":"https://api.github.com/repos/redding/dk/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/redding/dk/issues/26/comments","events_url":"https://api.github.com/repos/redding/dk/issues/26/events","html_url":"https://github.com/redding/dk/pull/26","id":164190191,"number":26,"title":"have Runner use Config's ssh opts; have Task fall back to Runner ssh opts","user":{"login":"kellyredding","id":82110,"avatar_url":"https://avatars.githubusercontent.com/u/82110?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyredding","html_url":"https://github.com/kellyredding","followers_url":"https://api.github.com/users/kellyredding/followers","following_url":"https://api.github.com/users/kellyredding/following{/other_user}","gists_url":"https://api.github.com/users/kellyredding/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyredding/subscriptions","organizations_url":"https://api.github.com/users/kellyredding/orgs","repos_url":"https://api.github.com/users/kellyredding/repos","events_url":"https://api.github.com/users/kellyredding/events{/privacy}","received_events_url":"https://api.github.com/users/kellyredding/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-06T22:33:44Z","updated_at":"2016-07-06T22:39:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/redding/dk/pulls/26","html_url":"https://github.com/redding/dk/pull/26","diff_url":"https://github.com/redding/dk/pull/26.diff","patch_url":"https://github.com/redding/dk/pull/26.patch"},"body":"This ties together all of the ssh options and handling and allows\r\nfor using the ssh opts that have been configured.  This includes\r\na bunch of small stuff:\r\n\r\n* the config runners use the config's ssh opts\r\n* commonized handling of ssh hosts/args between the Config and\r\n  Runner.  This allows you to set ssh hosts/args in Tasks like\r\n  you would in the Config.\r\n* the Task now has a `ssh_hosts` DSL method for configuring a\r\n  default hosts value to apply to all `ssh` cmds made from the\r\n  Task.  If no, hosts are given, the ssh cmd will lookup its hosts\r\n  from this setting.  If this is set with a proc, that proc will\r\n  be instance eval'd on the task, meaning you can set hosts values\r\n  to a task param value or based on specific task logic.  This\r\n  setting will try to lookup a set of named hosts on the config,\r\n  You can now also specify a custom named hosts when making the\r\n  ssh cmd.\r\n* the remote cmd now complains if initialized with no hosts.  This\r\n  helps protect you from making ssh cmds that don't run on any\r\n  hosts.  The exception should alert the user that this has is\r\n  occurring.\r\n* The README has been updated to include the new Task API changes.\r\n\r\nThis is all part of getting the ssh handling fully in place.\r\n\r\n@jcredding ready for review.  Are you cool with how this has all come together?  Do you have a clear understanding of how the ssh hosts/args can be configured/specified?\r\n"},"comment":{"url":"https://api.github.com/repos/redding/dk/issues/comments/230928800","html_url":"https://github.com/redding/dk/pull/26#issuecomment-230928800","issue_url":"https://api.github.com/repos/redding/dk/issues/26","id":230928800,"user":{"login":"kellyredding","id":82110,"avatar_url":"https://avatars.githubusercontent.com/u/82110?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyredding","html_url":"https://github.com/kellyredding","followers_url":"https://api.github.com/users/kellyredding/followers","following_url":"https://api.github.com/users/kellyredding/following{/other_user}","gists_url":"https://api.github.com/users/kellyredding/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyredding/subscriptions","organizations_url":"https://api.github.com/users/kellyredding/orgs","repos_url":"https://api.github.com/users/kellyredding/repos","events_url":"https://api.github.com/users/kellyredding/events{/privacy}","received_events_url":"https://api.github.com/users/kellyredding/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T22:39:49Z","updated_at":"2016-07-06T22:39:49Z","body":"@jcredding also check me on the README changes.  Does all that make sense and does the implementation support the README content?"}}
{"actor":{"display_login":"kellyredding"}}