{"action":"created","issue":{"url":"https://api.github.com/repos/Johnhhorton/node-nmap/issues/20","repository_url":"https://api.github.com/repos/Johnhhorton/node-nmap","labels_url":"https://api.github.com/repos/Johnhhorton/node-nmap/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/Johnhhorton/node-nmap/issues/20/comments","events_url":"https://api.github.com/repos/Johnhhorton/node-nmap/issues/20/events","html_url":"https://github.com/Johnhhorton/node-nmap/issues/20","id":166810934,"number":20,"title":"A bug in killChild","user":{"login":"dharmax","id":3120846,"avatar_url":"https://avatars.githubusercontent.com/u/3120846?v=3","gravatar_id":"","url":"https://api.github.com/users/dharmax","html_url":"https://github.com/dharmax","followers_url":"https://api.github.com/users/dharmax/followers","following_url":"https://api.github.com/users/dharmax/following{/other_user}","gists_url":"https://api.github.com/users/dharmax/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmax/subscriptions","organizations_url":"https://api.github.com/users/dharmax/orgs","repos_url":"https://api.github.com/users/dharmax/repos","events_url":"https://api.github.com/users/dharmax/events{/privacy}","received_events_url":"https://api.github.com/users/dharmax/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-21T12:50:13Z","updated_at":"2016-07-25T14:10:53Z","closed_at":"2016-07-25T14:10:52Z","body":"index.ts, lines 83 +\r\n`  }\r\n        private killChild(){\r\n            this.cancelled = true;\r\n            this.child.kill();\r\n}`\r\ni don't know why it gets there, maybe because it starts before it finished a previous scan, but it crashes  on this.child = undefined. \r\nperhaps it would be better to write:\r\n`   this.child && this.child.kill();`\r\n\r\nBtw, is this module maintain? reliable?"},"comment":{"url":"https://api.github.com/repos/Johnhhorton/node-nmap/issues/comments/234964106","html_url":"https://github.com/Johnhhorton/node-nmap/issues/20#issuecomment-234964106","issue_url":"https://api.github.com/repos/Johnhhorton/node-nmap/issues/20","id":234964106,"user":{"login":"dharmax","id":3120846,"avatar_url":"https://avatars.githubusercontent.com/u/3120846?v=3","gravatar_id":"","url":"https://api.github.com/users/dharmax","html_url":"https://github.com/dharmax","followers_url":"https://api.github.com/users/dharmax/followers","following_url":"https://api.github.com/users/dharmax/following{/other_user}","gists_url":"https://api.github.com/users/dharmax/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmax/subscriptions","organizations_url":"https://api.github.com/users/dharmax/orgs","repos_url":"https://api.github.com/users/dharmax/repos","events_url":"https://api.github.com/users/dharmax/events{/privacy}","received_events_url":"https://api.github.com/users/dharmax/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T14:10:52Z","updated_at":"2016-07-25T14:10:52Z","body":"> Hey guys, I'll look into this bug. @dharmax are you attempting to run simultaneous scans?\r\n\r\ni do a scan, cancel it and attempt to do a new scan.\r\n\r\n> I've also been toying with the idea of creating an alternate module that relies on Node's core APIs rather than NMAP. Is that something anyone would be interested in? It'd definitely be more performant.\r\n\r\nYes, i believe the performance and behavior might be much better, but will it be able to discover all the information nmap does?"}}
{"actor":{"display_login":"dharmax"}}