{"action":"created","issue":{"url":"https://api.github.com/repos/decred/dcrwallet/issues/326","repository_url":"https://api.github.com/repos/decred/dcrwallet","labels_url":"https://api.github.com/repos/decred/dcrwallet/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/decred/dcrwallet/issues/326/comments","events_url":"https://api.github.com/repos/decred/dcrwallet/issues/326/events","html_url":"https://github.com/decred/dcrwallet/pull/326","id":172282261,"number":326,"title":"RFP-10 Milestone 1","user":{"login":"chappjc","id":9373513,"avatar_url":"https://avatars.githubusercontent.com/u/9373513?v=3","gravatar_id":"","url":"https://api.github.com/users/chappjc","html_url":"https://github.com/chappjc","followers_url":"https://api.github.com/users/chappjc/followers","following_url":"https://api.github.com/users/chappjc/following{/other_user}","gists_url":"https://api.github.com/users/chappjc/gists{/gist_id}","starred_url":"https://api.github.com/users/chappjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chappjc/subscriptions","organizations_url":"https://api.github.com/users/chappjc/orgs","repos_url":"https://api.github.com/users/chappjc/repos","events_url":"https://api.github.com/users/chappjc/events{/privacy}","received_events_url":"https://api.github.com/users/chappjc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-20T17:48:21Z","updated_at":"2016-08-22T18:01:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/326","html_url":"https://github.com/decred/dcrwallet/pull/326","diff_url":"https://github.com/decred/dcrwallet/pull/326.diff","patch_url":"https://github.com/decred/dcrwallet/pull/326.patch"},"body":"This PR needs review, from myself and upstream developers.  Please wait until I give the OK, as I want to go through and give some more thought to some of the tests.\r\n\r\nIncluded in this PR are the test functions listed under milestone 1 of RFP-10, refactoring of rpctestharness, and updates to test functions for future milestones.  The **milestone 1 tests** include:\r\n\r\n- [x]  getnewaddress\r\n- [x]  validateaddress\r\n- [x]  walletpassphrase\r\n- [x]  getbalance\r\n- [x]  listaccounts\r\n- [x]  listunspent\r\n\r\nTests for milestones 2 and 3 (completion _not required_ for this PR) include:\r\n- [x]  sendtoaddfress (m2)\r\n- [x]  sendfrom (m2)\r\n- [ ]  purchaseticket (m3), needs work\r\n\r\nA summary of TODOs (mainly questions) from commit messages in this PR:\r\n\r\n- Consider additional harnesses to avoid multiple leftover accounts, and potentially unmined tx.\r\n- In dcrrpcclient, fix documentation bug for ListUnspent, as it specifies the wrong value for max conf (999999 vs. 9999999).\r\n- What is with the 10 second (now 2 second) delay in testSendFrom?\r\n- Comments and docs, better multi-harness system, P2SH type validateaddress test (IsScript func).\r\n- For testWalletPassphrase\r\n  - Test that a restricted operation fails/passes?\r\n  - Test WoW unlock error?\r\n- For testGetBalance:\r\n  - Mine a block and check anything\r\n  - I think there is a bug in Store.balanceFullScan() in tx.go, where the check is minConf == 0 instead of minConf < 1.  This allows minconf=-1 to pass but the unconfirmed transaction output handling section of balanceFullScan does not execute.\r\n- Expand testListAccounts for minconf=1 since this is very different computation, although we're really testing the RPC interface rather than the underlying computations.\r\n- Add a ListAccounts test before and after create an account?\r\n"},"comment":{"url":"https://api.github.com/repos/decred/dcrwallet/issues/comments/241497198","html_url":"https://github.com/decred/dcrwallet/pull/326#issuecomment-241497198","issue_url":"https://api.github.com/repos/decred/dcrwallet/issues/326","id":241497198,"user":{"login":"chappjc","id":9373513,"avatar_url":"https://avatars.githubusercontent.com/u/9373513?v=3","gravatar_id":"","url":"https://api.github.com/users/chappjc","html_url":"https://github.com/chappjc","followers_url":"https://api.github.com/users/chappjc/followers","following_url":"https://api.github.com/users/chappjc/following{/other_user}","gists_url":"https://api.github.com/users/chappjc/gists{/gist_id}","starred_url":"https://api.github.com/users/chappjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chappjc/subscriptions","organizations_url":"https://api.github.com/users/chappjc/orgs","repos_url":"https://api.github.com/users/chappjc/repos","events_url":"https://api.github.com/users/chappjc/events{/privacy}","received_events_url":"https://api.github.com/users/chappjc/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T18:01:49Z","updated_at":"2016-08-22T18:01:49Z","body":"@alexlyp Thanks for the feedback.  I'll have another commit tonight.\r\n\r\nRegarding the t.Log(), it only displays with the `-v` flag passed to `go test`.  Still, it is a lot of extra unpolished logging statements, so I understand if removing them is still recommended."}}
{"actor":{"display_login":"chappjc"}}