{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments/92985922","pull_request_review_id":13506198,"id":92985922,"diff_hunk":"@@ -94,8 +95,11 @@ public void finish() {\n \n     @Override\n     public synchronized void finish(long finishMicros) {\n-        this.finishMicros = finishMicros;\n-        this.mockTracer.appendFinishedSpan(this);\n+        if (!finished) {","path":"opentracing-mock/src/main/java/io/opentracing/mock/MockSpan.java","position":14,"original_position":14,"commit_id":"88aba7b8b7ccd48053a61256e00cc3ef9f339b13","original_commit_id":"c93866b4f67cc2259c982d44d1ceb81e38f18f0f","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"I agree with you. PR updated to throw exception on multiple `finish` calls.","created_at":"2016-12-19T08:29:09Z","updated_at":"2016-12-19T08:29:09Z","html_url":"https://github.com/opentracing/opentracing-java/pull/72#discussion_r92985922","pull_request_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments/92985922"},"html":{"href":"https://github.com/opentracing/opentracing-java/pull/72#discussion_r92985922"},"pull_request":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72","id":97764363,"html_url":"https://github.com/opentracing/opentracing-java/pull/72","diff_url":"https://github.com/opentracing/opentracing-java/pull/72.diff","patch_url":"https://github.com/opentracing/opentracing-java/pull/72.patch","issue_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/72","number":72,"state":"open","locked":false,"title":"MockSpan make finish operation idempotent","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"@bensigelman could you please review?","created_at":"2016-12-13T14:46:17Z","updated_at":"2016-12-19T08:29:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea9410587908c35f96b476851797ea181d83e04e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72/commits","review_comments_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72/comments","review_comment_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/72/comments","statuses_url":"https://api.github.com/repos/opentracing/opentracing-java/statuses/88aba7b8b7ccd48053a61256e00cc3ef9f339b13","head":{"label":"pavolloffay:mockspam-idempotent-finish","ref":"mockspam-idempotent-finish","sha":"88aba7b8b7ccd48053a61256e00cc3ef9f339b13","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"repo":{"id":75400766,"name":"opentracing-java","full_name":"pavolloffay/opentracing-java","owner":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavolloffay/opentracing-java","description":"Java implementation of the OpenTracing API","fork":true,"url":"https://api.github.com/repos/pavolloffay/opentracing-java","forks_url":"https://api.github.com/repos/pavolloffay/opentracing-java/forks","keys_url":"https://api.github.com/repos/pavolloffay/opentracing-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavolloffay/opentracing-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavolloffay/opentracing-java/teams","hooks_url":"https://api.github.com/repos/pavolloffay/opentracing-java/hooks","issue_events_url":"https://api.github.com/repos/pavolloffay/opentracing-java/issues/events{/number}","events_url":"https://api.github.com/repos/pavolloffay/opentracing-java/events","assignees_url":"https://api.github.com/repos/pavolloffay/opentracing-java/assignees{/user}","branches_url":"https://api.github.com/repos/pavolloffay/opentracing-java/branches{/branch}","tags_url":"https://api.github.com/repos/pavolloffay/opentracing-java/tags","blobs_url":"https://api.github.com/repos/pavolloffay/opentracing-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavolloffay/opentracing-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavolloffay/opentracing-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavolloffay/opentracing-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavolloffay/opentracing-java/statuses/{sha}","languages_url":"https://api.github.com/repos/pavolloffay/opentracing-java/languages","stargazers_url":"https://api.github.com/repos/pavolloffay/opentracing-java/stargazers","contributors_url":"https://api.github.com/repos/pavolloffay/opentracing-java/contributors","subscribers_url":"https://api.github.com/repos/pavolloffay/opentracing-java/subscribers","subscription_url":"https://api.github.com/repos/pavolloffay/opentracing-java/subscription","commits_url":"https://api.github.com/repos/pavolloffay/opentracing-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavolloffay/opentracing-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavolloffay/opentracing-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavolloffay/opentracing-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavolloffay/opentracing-java/contents/{+path}","compare_url":"https://api.github.com/repos/pavolloffay/opentracing-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavolloffay/opentracing-java/merges","archive_url":"https://api.github.com/repos/pavolloffay/opentracing-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavolloffay/opentracing-java/downloads","issues_url":"https://api.github.com/repos/pavolloffay/opentracing-java/issues{/number}","pulls_url":"https://api.github.com/repos/pavolloffay/opentracing-java/pulls{/number}","milestones_url":"https://api.github.com/repos/pavolloffay/opentracing-java/milestones{/number}","notifications_url":"https://api.github.com/repos/pavolloffay/opentracing-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavolloffay/opentracing-java/labels{/name}","releases_url":"https://api.github.com/repos/pavolloffay/opentracing-java/releases{/id}","deployments_url":"https://api.github.com/repos/pavolloffay/opentracing-java/deployments","created_at":"2016-12-02T14:05:29Z","updated_at":"2016-12-02T14:05:30Z","pushed_at":"2016-12-19T08:28:13Z","git_url":"git://github.com/pavolloffay/opentracing-java.git","ssh_url":"git@github.com:pavolloffay/opentracing-java.git","clone_url":"https://github.com/pavolloffay/opentracing-java.git","svn_url":"https://github.com/pavolloffay/opentracing-java","homepage":"http://opentracing.io","size":308,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentracing:master","ref":"master","sha":"2e8526a78dc0019ade28ab61ffc26ad18bf1cd47","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":48295629,"name":"opentracing-java","full_name":"opentracing/opentracing-java","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/opentracing-java","description":"OpenTracing API for Java","fork":false,"url":"https://api.github.com/repos/opentracing/opentracing-java","forks_url":"https://api.github.com/repos/opentracing/opentracing-java/forks","keys_url":"https://api.github.com/repos/opentracing/opentracing-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/opentracing-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/opentracing-java/teams","hooks_url":"https://api.github.com/repos/opentracing/opentracing-java/hooks","issue_events_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/opentracing-java/events","assignees_url":"https://api.github.com/repos/opentracing/opentracing-java/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/opentracing-java/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/opentracing-java/tags","blobs_url":"https://api.github.com/repos/opentracing/opentracing-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/opentracing-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/opentracing-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/opentracing-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/opentracing-java/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/opentracing-java/languages","stargazers_url":"https://api.github.com/repos/opentracing/opentracing-java/stargazers","contributors_url":"https://api.github.com/repos/opentracing/opentracing-java/contributors","subscribers_url":"https://api.github.com/repos/opentracing/opentracing-java/subscribers","subscription_url":"https://api.github.com/repos/opentracing/opentracing-java/subscription","commits_url":"https://api.github.com/repos/opentracing/opentracing-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/opentracing-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/opentracing-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/opentracing-java/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/opentracing-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/opentracing-java/merges","archive_url":"https://api.github.com/repos/opentracing/opentracing-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/opentracing-java/downloads","issues_url":"https://api.github.com/repos/opentracing/opentracing-java/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/opentracing-java/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/opentracing-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/opentracing-java/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/opentracing-java/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/opentracing-java/deployments","created_at":"2015-12-19T20:07:30Z","updated_at":"2016-12-17T18:33:44Z","pushed_at":"2016-12-19T08:28:14Z","git_url":"git://github.com/opentracing/opentracing-java.git","ssh_url":"git@github.com:opentracing/opentracing-java.git","clone_url":"https://github.com/opentracing/opentracing-java.git","svn_url":"https://github.com/opentracing/opentracing-java","homepage":"http://opentracing.io","size":311,"stargazers_count":132,"watchers_count":132,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":18,"forks":32,"open_issues":18,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72"},"html":{"href":"https://github.com/opentracing/opentracing-java/pull/72"},"issue":{"href":"https://api.github.com/repos/opentracing/opentracing-java/issues/72"},"comments":{"href":"https://api.github.com/repos/opentracing/opentracing-java/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing/opentracing-java/statuses/88aba7b8b7ccd48053a61256e00cc3ef9f339b13"}}}}
{"actor":{"display_login":"pavolloffay"}}