{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/78509084","id":78509084,"diff_hunk":"@@ -70,17 +63,18 @@ def test_launchctl(self):\n         '''\n         # Expected Functionality\n         self.assertTrue(\n-            self.run_function('service.launchctl', ['error', 'bootstrap', 64]))\n+            self.run_function('service.launchctl',\n+                              ['error', 'bootstrap', '64']))\n         self.assertEqual(\n             self.run_function('service.launchctl',\n-                              ['error', 'bootstrap', 64],\n+                              ['error', 'bootstrap', '64'],","path":"tests/integration/modules/mac_service.py","position":59,"original_position":60,"commit_id":"28442b32f87ea8b874267d9a70713073611d3d7c","original_commit_id":"1c83b37fe60f3f97dc08aa9946b3a749e9dd9cfb","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"This is a legit bug in the `cmdmod` module. I have corrected it in #36254. Therefore, we can go ahead and merge this since the bug it has exposed is now resolved.","created_at":"2016-09-13T07:31:34Z","updated_at":"2016-09-13T07:31:34Z","html_url":"https://github.com/saltstack/salt/pull/36176#discussion_r78509084","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/36176","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/78509084"},"html":{"href":"https://github.com/saltstack/salt/pull/36176#discussion_r78509084"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36176"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/36176","id":84570135,"html_url":"https://github.com/saltstack/salt/pull/36176","diff_url":"https://github.com/saltstack/salt/pull/36176.diff","patch_url":"https://github.com/saltstack/salt/pull/36176.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/36176","number":36176,"state":"open","locked":false,"title":"Fix test_launchctl test in mac_service","user":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars.githubusercontent.com/u/9383935?v=3","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nQuote the integers being passed to the service.launchctl command\r\nUse skipIf decorator instead of skipTest in the setUp function so checks aren't run on every test.\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://github.com/saltstack/qa/issues/236\r\n\r\n### Previous Behavior\r\ntest_launchctl test would fail\r\n\r\n### New Behavior\r\ntest_launchctl now completes successfully\r\n\r\n### Tests written?\r\nNA","created_at":"2016-09-08T23:15:57Z","updated_at":"2016-09-13T07:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4200dddf8c04e7d457fbae705c5368e30fd2ac48","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/36176/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/36176/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/36176/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/28442b32f87ea8b874267d9a70713073611d3d7c","head":{"label":"twangboy:mac_service_tests","ref":"mac_service_tests","sha":"28442b32f87ea8b874267d9a70713073611d3d7c","user":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars.githubusercontent.com/u/9383935?v=3","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"repo":{"id":52046096,"name":"salt","full_name":"twangboy/salt","owner":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars.githubusercontent.com/u/9383935?v=3","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twangboy/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":true,"url":"https://api.github.com/repos/twangboy/salt","forks_url":"https://api.github.com/repos/twangboy/salt/forks","keys_url":"https://api.github.com/repos/twangboy/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twangboy/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twangboy/salt/teams","hooks_url":"https://api.github.com/repos/twangboy/salt/hooks","issue_events_url":"https://api.github.com/repos/twangboy/salt/issues/events{/number}","events_url":"https://api.github.com/repos/twangboy/salt/events","assignees_url":"https://api.github.com/repos/twangboy/salt/assignees{/user}","branches_url":"https://api.github.com/repos/twangboy/salt/branches{/branch}","tags_url":"https://api.github.com/repos/twangboy/salt/tags","blobs_url":"https://api.github.com/repos/twangboy/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twangboy/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twangboy/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/twangboy/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twangboy/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/twangboy/salt/languages","stargazers_url":"https://api.github.com/repos/twangboy/salt/stargazers","contributors_url":"https://api.github.com/repos/twangboy/salt/contributors","subscribers_url":"https://api.github.com/repos/twangboy/salt/subscribers","subscription_url":"https://api.github.com/repos/twangboy/salt/subscription","commits_url":"https://api.github.com/repos/twangboy/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/twangboy/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/twangboy/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/twangboy/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/twangboy/salt/contents/{+path}","compare_url":"https://api.github.com/repos/twangboy/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twangboy/salt/merges","archive_url":"https://api.github.com/repos/twangboy/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twangboy/salt/downloads","issues_url":"https://api.github.com/repos/twangboy/salt/issues{/number}","pulls_url":"https://api.github.com/repos/twangboy/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/twangboy/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/twangboy/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twangboy/salt/labels{/name}","releases_url":"https://api.github.com/repos/twangboy/salt/releases{/id}","deployments_url":"https://api.github.com/repos/twangboy/salt/deployments","created_at":"2016-02-18T23:18:37Z","updated_at":"2016-02-18T23:18:49Z","pushed_at":"2016-09-12T18:17:56Z","git_url":"git://github.com/twangboy/salt.git","ssh_url":"git@github.com:twangboy/salt.git","clone_url":"https://github.com/twangboy/salt.git","svn_url":"https://github.com/twangboy/salt","homepage":"https://repo.saltstack.com/","size":141480,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:carbon","ref":"carbon","sha":"1a7996125ab3b60840a9816d50da6e2172b0e6f6","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-09-13T07:22:17Z","pushed_at":"2016-09-13T07:30:26Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":217248,"stargazers_count":6871,"watchers_count":6871,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3122,"mirror_url":null,"open_issues_count":3848,"forks":3122,"open_issues":3848,"watchers":6871,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36176"},"html":{"href":"https://github.com/saltstack/salt/pull/36176"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/36176"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/36176/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36176/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/36176/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/28442b32f87ea8b874267d9a70713073611d3d7c"}}}}
{"actor":{"display_login":"cachedout"}}