{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments/64496029","id":64496029,"diff_hunk":"@@ -96,3 +101,14 @@\n     (while (< (count (jruby-core/registered-instances pool-context))\n               num-jrubies)\n       (Thread/sleep 100))))\n+\n+(defn wait-for-jrubies-from-pool-context\n+  \"Wait for all jrubies to land in the pool\"\n+  [pool-context]\n+  (let [num-jrubies (-> pool-context\n+                        :pool-state\n+                        deref\n+                        :size)]\n+    (while (< (count (jruby-core/registered-instances pool-context))\n+              num-jrubies)\n+      (Thread/sleep 100))))","path":"test/unit/puppetlabs/services/jruby/jruby_testutils.clj","position":33,"original_position":33,"commit_id":"02fdb3c8f379f471989acb484418e0620f1ba975","original_commit_id":"02fdb3c8f379f471989acb484418e0620f1ba975","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"Since the instantiation of the JRuby instances should be much faster in this repo, we could probably get away with just having a `Thread/yield` here, and maybe reduce test runtime by a smidge?","created_at":"2016-05-25T00:00:16Z","updated_at":"2016-05-25T00:00:16Z","html_url":"https://github.com/puppetlabs/jruby-utils/pull/9#discussion_r64496029","pull_request_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments/64496029"},"html":{"href":"https://github.com/puppetlabs/jruby-utils/pull/9#discussion_r64496029"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9","id":71309435,"html_url":"https://github.com/puppetlabs/jruby-utils/pull/9","diff_url":"https://github.com/puppetlabs/jruby-utils/pull/9.diff","patch_url":"https://github.com/puppetlabs/jruby-utils/pull/9.patch","issue_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/9","number":9,"state":"open","locked":false,"title":"(TK-370) Add pool manager service","user":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"body":"Add a pool manager service that handles creating and flushing a pool. We have\r\nsome concerns about whether multiple threads creating JRubyInstances at once\r\nmay cause problems due to JRuby's global state. Adding this service provides\r\nus the ability to coordinate the initialization and shutdown of JRubyInstances\r\nshould our concerns about thread safety prove founded.\r\n\r\nUpdate the JRuby service to use this pool manager service. In the future, we\r\nwill remove the JRuby TK service and this library will only provide the pool\r\nmanager service.\r\n\r\nAlso remove some unused dependencies from various namespaces.","created_at":"2016-05-24T23:29:17Z","updated_at":"2016-05-25T00:00:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f02a4fa51f963d84051c8318c6933d46d09f61f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/9/comments","statuses_url":"https://api.github.com/repos/puppetlabs/jruby-utils/statuses/02fdb3c8f379f471989acb484418e0620f1ba975","head":{"label":"rlinehan:TK-370-jruby-pool-manager-service","ref":"TK-370-jruby-pool-manager-service","sha":"02fdb3c8f379f471989acb484418e0620f1ba975","user":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"repo":{"id":54999540,"name":"jruby-utils","full_name":"rlinehan/jruby-utils","owner":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rlinehan/jruby-utils","description":"Tools for working with JRuby from Clojure","fork":true,"url":"https://api.github.com/repos/rlinehan/jruby-utils","forks_url":"https://api.github.com/repos/rlinehan/jruby-utils/forks","keys_url":"https://api.github.com/repos/rlinehan/jruby-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlinehan/jruby-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlinehan/jruby-utils/teams","hooks_url":"https://api.github.com/repos/rlinehan/jruby-utils/hooks","issue_events_url":"https://api.github.com/repos/rlinehan/jruby-utils/issues/events{/number}","events_url":"https://api.github.com/repos/rlinehan/jruby-utils/events","assignees_url":"https://api.github.com/repos/rlinehan/jruby-utils/assignees{/user}","branches_url":"https://api.github.com/repos/rlinehan/jruby-utils/branches{/branch}","tags_url":"https://api.github.com/repos/rlinehan/jruby-utils/tags","blobs_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlinehan/jruby-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/rlinehan/jruby-utils/languages","stargazers_url":"https://api.github.com/repos/rlinehan/jruby-utils/stargazers","contributors_url":"https://api.github.com/repos/rlinehan/jruby-utils/contributors","subscribers_url":"https://api.github.com/repos/rlinehan/jruby-utils/subscribers","subscription_url":"https://api.github.com/repos/rlinehan/jruby-utils/subscription","commits_url":"https://api.github.com/repos/rlinehan/jruby-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlinehan/jruby-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlinehan/jruby-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlinehan/jruby-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlinehan/jruby-utils/contents/{+path}","compare_url":"https://api.github.com/repos/rlinehan/jruby-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlinehan/jruby-utils/merges","archive_url":"https://api.github.com/repos/rlinehan/jruby-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlinehan/jruby-utils/downloads","issues_url":"https://api.github.com/repos/rlinehan/jruby-utils/issues{/number}","pulls_url":"https://api.github.com/repos/rlinehan/jruby-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/rlinehan/jruby-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/rlinehan/jruby-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlinehan/jruby-utils/labels{/name}","releases_url":"https://api.github.com/repos/rlinehan/jruby-utils/releases{/id}","deployments_url":"https://api.github.com/repos/rlinehan/jruby-utils/deployments","created_at":"2016-03-29T18:16:10Z","updated_at":"2016-04-19T22:15:52Z","pushed_at":"2016-05-24T23:28:11Z","git_url":"git://github.com/rlinehan/jruby-utils.git","ssh_url":"git@github.com:rlinehan/jruby-utils.git","clone_url":"https://github.com/rlinehan/jruby-utils.git","svn_url":"https://github.com/rlinehan/jruby-utils","homepage":null,"size":3698,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"47e065a0735ffedbcaeb42d39c6b52fc819bc2f0","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":54928848,"name":"jruby-utils","full_name":"puppetlabs/jruby-utils","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/jruby-utils","description":"Tools for working with JRuby from Clojure","fork":false,"url":"https://api.github.com/repos/puppetlabs/jruby-utils","forks_url":"https://api.github.com/repos/puppetlabs/jruby-utils/forks","keys_url":"https://api.github.com/repos/puppetlabs/jruby-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/jruby-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/jruby-utils/teams","hooks_url":"https://api.github.com/repos/puppetlabs/jruby-utils/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/jruby-utils/events","assignees_url":"https://api.github.com/repos/puppetlabs/jruby-utils/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/jruby-utils/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/jruby-utils/tags","blobs_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/jruby-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/jruby-utils/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/jruby-utils/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/jruby-utils/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/jruby-utils/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/jruby-utils/subscription","commits_url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/jruby-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/jruby-utils/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/jruby-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/jruby-utils/merges","archive_url":"https://api.github.com/repos/puppetlabs/jruby-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/jruby-utils/downloads","issues_url":"https://api.github.com/repos/puppetlabs/jruby-utils/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/jruby-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/jruby-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/jruby-utils/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/jruby-utils/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/jruby-utils/deployments","created_at":"2016-03-28T22:45:23Z","updated_at":"2016-03-31T01:03:48Z","pushed_at":"2016-05-24T23:29:17Z","git_url":"git://github.com/puppetlabs/jruby-utils.git","ssh_url":"git@github.com:puppetlabs/jruby-utils.git","clone_url":"https://github.com/puppetlabs/jruby-utils.git","svn_url":"https://github.com/puppetlabs/jruby-utils","homepage":null,"size":3673,"stargazers_count":1,"watchers_count":1,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9"},"html":{"href":"https://github.com/puppetlabs/jruby-utils/pull/9"},"issue":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/9"},"comments":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/jruby-utils/statuses/02fdb3c8f379f471989acb484418e0620f1ba975"}}}}
{"actor":{"display_login":"cprice404"}}