{"action":"opened","number":150,"pull_request":{"url":"https://api.github.com/repos/thefrontside/emberx-select/pulls/150","id":85155582,"html_url":"https://github.com/thefrontside/emberx-select/pull/150","diff_url":"https://github.com/thefrontside/emberx-select/pull/150.diff","patch_url":"https://github.com/thefrontside/emberx-select/pull/150.patch","issue_url":"https://api.github.com/repos/thefrontside/emberx-select/issues/150","number":150,"state":"open","locked":false,"title":"don't share `options` arrays between x-select instances","user":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"body":"In Ember, `.extend` is shorthand for defining properties on the\nprototype. Anything put on the prototype will be shared by all of its\ninstances.\n\nFor example:\n\n```javascript\nconst Test = Ember.Object.extend({\n  results: []\n});\n\nconst test1 = Test.create();\nconst test2 = Test.create();\n\ntest1.get('results').push(1);\ntest1.get('results'); // [1]\ntest2.get('results'); // [1]\n```\n\n`x-select` instances were sharing `options` between instances. While\nthis didn't manifest itself in any user-facing bugs, it will in the\nfuture in subtle ways.\n\nThis PR changes `options` to be a computed property so that each\ninstance gets its own `options` array.","created_at":"2016-09-14T02:03:02Z","updated_at":"2016-09-14T02:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thefrontside/emberx-select/pulls/150/commits","review_comments_url":"https://api.github.com/repos/thefrontside/emberx-select/pulls/150/comments","review_comment_url":"https://api.github.com/repos/thefrontside/emberx-select/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thefrontside/emberx-select/issues/150/comments","statuses_url":"https://api.github.com/repos/thefrontside/emberx-select/statuses/9e523d00af92e4ebe17e2a348475eb3a079c93ed","head":{"label":"fivetanley:dont-share-options-between-instances","ref":"dont-share-options-between-instances","sha":"9e523d00af92e4ebe17e2a348475eb3a079c93ed","user":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"repo":{"id":49017128,"name":"emberx-select","full_name":"fivetanley/emberx-select","owner":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fivetanley/emberx-select","description":"Select component for Ember based on the native html select element. ","fork":true,"url":"https://api.github.com/repos/fivetanley/emberx-select","forks_url":"https://api.github.com/repos/fivetanley/emberx-select/forks","keys_url":"https://api.github.com/repos/fivetanley/emberx-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fivetanley/emberx-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fivetanley/emberx-select/teams","hooks_url":"https://api.github.com/repos/fivetanley/emberx-select/hooks","issue_events_url":"https://api.github.com/repos/fivetanley/emberx-select/issues/events{/number}","events_url":"https://api.github.com/repos/fivetanley/emberx-select/events","assignees_url":"https://api.github.com/repos/fivetanley/emberx-select/assignees{/user}","branches_url":"https://api.github.com/repos/fivetanley/emberx-select/branches{/branch}","tags_url":"https://api.github.com/repos/fivetanley/emberx-select/tags","blobs_url":"https://api.github.com/repos/fivetanley/emberx-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fivetanley/emberx-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fivetanley/emberx-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/fivetanley/emberx-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fivetanley/emberx-select/statuses/{sha}","languages_url":"https://api.github.com/repos/fivetanley/emberx-select/languages","stargazers_url":"https://api.github.com/repos/fivetanley/emberx-select/stargazers","contributors_url":"https://api.github.com/repos/fivetanley/emberx-select/contributors","subscribers_url":"https://api.github.com/repos/fivetanley/emberx-select/subscribers","subscription_url":"https://api.github.com/repos/fivetanley/emberx-select/subscription","commits_url":"https://api.github.com/repos/fivetanley/emberx-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/fivetanley/emberx-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/fivetanley/emberx-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/fivetanley/emberx-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/fivetanley/emberx-select/contents/{+path}","compare_url":"https://api.github.com/repos/fivetanley/emberx-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fivetanley/emberx-select/merges","archive_url":"https://api.github.com/repos/fivetanley/emberx-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fivetanley/emberx-select/downloads","issues_url":"https://api.github.com/repos/fivetanley/emberx-select/issues{/number}","pulls_url":"https://api.github.com/repos/fivetanley/emberx-select/pulls{/number}","milestones_url":"https://api.github.com/repos/fivetanley/emberx-select/milestones{/number}","notifications_url":"https://api.github.com/repos/fivetanley/emberx-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fivetanley/emberx-select/labels{/name}","releases_url":"https://api.github.com/repos/fivetanley/emberx-select/releases{/id}","deployments_url":"https://api.github.com/repos/fivetanley/emberx-select/deployments","created_at":"2016-01-04T19:06:47Z","updated_at":"2016-08-04T14:19:04Z","pushed_at":"2016-09-14T02:02:57Z","git_url":"git://github.com/fivetanley/emberx-select.git","ssh_url":"git@github.com:fivetanley/emberx-select.git","clone_url":"https://github.com/fivetanley/emberx-select.git","svn_url":"https://github.com/fivetanley/emberx-select","homepage":"http://thefrontside.github.io/emberx-select","size":721,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thefrontside:master","ref":"master","sha":"0c40221cffb178a6916b39bd3f06b41ffce6688c","user":{"login":"thefrontside","id":223096,"avatar_url":"https://avatars.githubusercontent.com/u/223096?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontside","html_url":"https://github.com/thefrontside","followers_url":"https://api.github.com/users/thefrontside/followers","following_url":"https://api.github.com/users/thefrontside/following{/other_user}","gists_url":"https://api.github.com/users/thefrontside/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontside/subscriptions","organizations_url":"https://api.github.com/users/thefrontside/orgs","repos_url":"https://api.github.com/users/thefrontside/repos","events_url":"https://api.github.com/users/thefrontside/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontside/received_events","type":"Organization","site_admin":false},"repo":{"id":30879325,"name":"emberx-select","full_name":"thefrontside/emberx-select","owner":{"login":"thefrontside","id":223096,"avatar_url":"https://avatars.githubusercontent.com/u/223096?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontside","html_url":"https://github.com/thefrontside","followers_url":"https://api.github.com/users/thefrontside/followers","following_url":"https://api.github.com/users/thefrontside/following{/other_user}","gists_url":"https://api.github.com/users/thefrontside/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontside/subscriptions","organizations_url":"https://api.github.com/users/thefrontside/orgs","repos_url":"https://api.github.com/users/thefrontside/repos","events_url":"https://api.github.com/users/thefrontside/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontside/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thefrontside/emberx-select","description":"Select component for Ember based on the native html select element. ","fork":false,"url":"https://api.github.com/repos/thefrontside/emberx-select","forks_url":"https://api.github.com/repos/thefrontside/emberx-select/forks","keys_url":"https://api.github.com/repos/thefrontside/emberx-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefrontside/emberx-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefrontside/emberx-select/teams","hooks_url":"https://api.github.com/repos/thefrontside/emberx-select/hooks","issue_events_url":"https://api.github.com/repos/thefrontside/emberx-select/issues/events{/number}","events_url":"https://api.github.com/repos/thefrontside/emberx-select/events","assignees_url":"https://api.github.com/repos/thefrontside/emberx-select/assignees{/user}","branches_url":"https://api.github.com/repos/thefrontside/emberx-select/branches{/branch}","tags_url":"https://api.github.com/repos/thefrontside/emberx-select/tags","blobs_url":"https://api.github.com/repos/thefrontside/emberx-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefrontside/emberx-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefrontside/emberx-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefrontside/emberx-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefrontside/emberx-select/statuses/{sha}","languages_url":"https://api.github.com/repos/thefrontside/emberx-select/languages","stargazers_url":"https://api.github.com/repos/thefrontside/emberx-select/stargazers","contributors_url":"https://api.github.com/repos/thefrontside/emberx-select/contributors","subscribers_url":"https://api.github.com/repos/thefrontside/emberx-select/subscribers","subscription_url":"https://api.github.com/repos/thefrontside/emberx-select/subscription","commits_url":"https://api.github.com/repos/thefrontside/emberx-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefrontside/emberx-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefrontside/emberx-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefrontside/emberx-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefrontside/emberx-select/contents/{+path}","compare_url":"https://api.github.com/repos/thefrontside/emberx-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefrontside/emberx-select/merges","archive_url":"https://api.github.com/repos/thefrontside/emberx-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefrontside/emberx-select/downloads","issues_url":"https://api.github.com/repos/thefrontside/emberx-select/issues{/number}","pulls_url":"https://api.github.com/repos/thefrontside/emberx-select/pulls{/number}","milestones_url":"https://api.github.com/repos/thefrontside/emberx-select/milestones{/number}","notifications_url":"https://api.github.com/repos/thefrontside/emberx-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefrontside/emberx-select/labels{/name}","releases_url":"https://api.github.com/repos/thefrontside/emberx-select/releases{/id}","deployments_url":"https://api.github.com/repos/thefrontside/emberx-select/deployments","created_at":"2015-02-16T17:25:43Z","updated_at":"2016-09-11T14:01:21Z","pushed_at":"2016-09-14T02:03:02Z","git_url":"git://github.com/thefrontside/emberx-select.git","ssh_url":"git@github.com:thefrontside/emberx-select.git","clone_url":"https://github.com/thefrontside/emberx-select.git","svn_url":"https://github.com/thefrontside/emberx-select","homepage":"http://thefrontside.github.io/emberx-select","size":977,"stargazers_count":174,"watchers_count":174,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":8,"forks":57,"open_issues":8,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thefrontside/emberx-select/pulls/150"},"html":{"href":"https://github.com/thefrontside/emberx-select/pull/150"},"issue":{"href":"https://api.github.com/repos/thefrontside/emberx-select/issues/150"},"comments":{"href":"https://api.github.com/repos/thefrontside/emberx-select/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/thefrontside/emberx-select/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/thefrontside/emberx-select/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thefrontside/emberx-select/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/thefrontside/emberx-select/statuses/9e523d00af92e4ebe17e2a348475eb3a079c93ed"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"fivetanley"}}