{"action":"created","issue":{"url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/193","repository_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos","labels_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/193/comments","events_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/193/events","html_url":"https://github.com/SuperHouse/esp-open-rtos/pull/193","id":171874494,"number":193,"title":"sysparam: remove IRAM declarations.","user":{"login":"ourairquality","id":20396158,"avatar_url":"https://avatars.githubusercontent.com/u/20396158?v=3","gravatar_id":"","url":"https://api.github.com/users/ourairquality","html_url":"https://github.com/ourairquality","followers_url":"https://api.github.com/users/ourairquality/followers","following_url":"https://api.github.com/users/ourairquality/following{/other_user}","gists_url":"https://api.github.com/users/ourairquality/gists{/gist_id}","starred_url":"https://api.github.com/users/ourairquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ourairquality/subscriptions","organizations_url":"https://api.github.com/users/ourairquality/orgs","repos_url":"https://api.github.com/users/ourairquality/repos","events_url":"https://api.github.com/users/ourairquality/events{/privacy}","received_events_url":"https://api.github.com/users/ourairquality/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-18T10:59:30Z","updated_at":"2016-08-19T01:29:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/pulls/193","html_url":"https://github.com/SuperHouse/esp-open-rtos/pull/193","diff_url":"https://github.com/SuperHouse/esp-open-rtos/pull/193.diff","patch_url":"https://github.com/SuperHouse/esp-open-rtos/pull/193.patch"},"body":"Not sure why some of the functions had IRAM declarations, it appears unnecessary. These were in the flash write path but well above the critical section, and writes are expected to be a cold path, so perhaps it would be better to save some RAM."},"comment":{"url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/comments/240904242","html_url":"https://github.com/SuperHouse/esp-open-rtos/pull/193#issuecomment-240904242","issue_url":"https://api.github.com/repos/SuperHouse/esp-open-rtos/issues/193","id":240904242,"user":{"login":"foogod","id":3247763,"avatar_url":"https://avatars.githubusercontent.com/u/3247763?v=3","gravatar_id":"","url":"https://api.github.com/users/foogod","html_url":"https://github.com/foogod","followers_url":"https://api.github.com/users/foogod/followers","following_url":"https://api.github.com/users/foogod/following{/other_user}","gists_url":"https://api.github.com/users/foogod/gists{/gist_id}","starred_url":"https://api.github.com/users/foogod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foogod/subscriptions","organizations_url":"https://api.github.com/users/foogod/orgs","repos_url":"https://api.github.com/users/foogod/repos","events_url":"https://api.github.com/users/foogod/events{/privacy}","received_events_url":"https://api.github.com/users/foogod/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T01:29:05Z","updated_at":"2016-08-19T01:29:05Z","body":"These were set IRAM as a performance optimization.  Since (I believe) flash writes completely blow away the IROM cache, switching back and forth between IROM and flash IO routines repeatedly can potentially be quite a performance hit.  The `_write_and_verify` process can potentially involve quite a number of these calls depending on the size of the data being written.\r\n\r\nThese routines are not very large.  I would expect the savings to be on the order of a couple of tens of bytes..  At the very least, I would recommend we do some performance tests to see whether the speed impact is significant or not first."}}
{"actor":{"display_login":"foogod"}}