{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments/75351120","id":75351120,"diff_hunk":"@@ -262,267 +276,263 @@ function Bigtable(options) {\n     return new Bigtable(options);\n   }\n \n-  if (!options.cluster) {\n-    throw new Error('A cluster must be provided to interact with Bigtable.');\n-  }\n-\n-  if (!options.zone) {\n-    throw new Error('A zone must be provided to interact with Bigtable.');\n-  }\n-\n-  options = extend({}, options, {\n-    zone: options.zone.name || options.zone\n-  });\n-\n-  this.clusterName = format(\n-    'projects/{projectId}/zones/{zone}/clusters/{cluster}',\n-    options\n-  );\n-\n   var config = {\n     baseUrl: 'bigtable.googleapis.com',\n     service: 'bigtable',\n-    apiVersion: 'v1',\n+    apiVersion: 'v2',\n     protoServices: {\n-      BigtableService: googleProtoFiles.bigtable.v1,\n-      BigtableTableService: {\n-        path: googleProtoFiles.bigtable.admin,\n-        service: 'bigtable.admin.table'\n+      Bigtable: googleProtoFiles('bigtable/v2/bigtable.proto'),\n+      BigtableTableAdmin: {\n+        baseUrl: 'bigtableadmin.googleapis.com',\n+        path: googleProtoFiles('bigtable/admin/v2/bigtable_table_admin.proto'),\n+        service: 'bigtable.admin'\n+      },\n+      BigtableInstanceAdmin: {\n+        baseUrl: 'bigtableadmin.googleapis.com',\n+        path: googleProtoFiles(\n+          'bigtable/admin/v2/bigtable_instance_admin.proto'\n+        ),\n+        service: 'bigtable.admin'\n+      },\n+      Operations: {\n+        baseUrl: 'bigtableadmin.googleapis.com',\n+        path: googleProtoFiles('longrunning/operations.proto'),\n+        service: 'longrunning',\n+        apiVersion: 'v1'\n       }\n     },\n     scopes: [\n       'https://www.googleapis.com/auth/bigtable.admin',\n-      'https://www.googleapis.com/auth/bigtable.data'\n+      'https://www.googleapis.com/auth/bigtable.data',\n+      'https://www.googleapis.com/auth/cloud-platform'\n     ],\n     userAgent: PKG.name + '/' + PKG.version\n   };\n \n   common.GrpcService.call(this, config, options);\n+\n+  this.projectName = 'projects/' + this.projectId;\n }\n \n util.inherits(Bigtable, common.GrpcService);\n \n /**\n- * Formats the full table name into a user friendly version.\n- *\n- * @private\n- *\n- * @param {string} name - The formatted Table name.\n- * @return {string}\n- *\n- * @example\n- * Bigtable.formatTableName_('projects/p/zones/z/clusters/c/tables/my-table');\n- * // => 'my-table'\n- */\n-Bigtable.formatTableName_ = function(name) {\n-  if (name.indexOf('/') === -1) {\n-    return name;\n-  }\n-\n-  var parts = name.split('/');\n-  return parts[parts.length - 1];\n-};\n-\n-/**\n- * Create a table on your Bigtable cluster.\n+ * Creates a Compute Instance.\n  *\n- * @resource [Designing Your Schema]{@link https://cloud.google.com/bigtable/docs/schema-design}\n- * @resource [Splitting Keys]{@link https://cloud.google.com/bigtable/docs/managing-tables#splits}\n+ * @resource [Creating a Compute Instance]{@link https://cloud.google.com/bigtable/docs/creating-compute-instance}\n  *\n- * @throws {error} If a name is not provided.\n- *\n- * @param {string} name - The name of the table.\n- * @param {object=} options - Table creation options.\n- * @param {object|string[]} options.families - Column families to be created\n- *     within the table.\n- * @param {string} options.operation - Operation used for table that has already\n- *    been queued to be created.\n- * @param {string[]} options.splits - Initial\n- *    [split keys](https://cloud.google.com/bigtable/docs/managing-tables#splits).\n+ * @param {string} name - The unique name of the instance.\n+ * @param {object} options - Instance creation options.\n+ * @param {string} options.displayName - The descriptive name for this instance\n+ *     as it appears in UIs.\n+ * @param {object[]} options.clusters - The clusters to be created within the","path":"packages/bigtable/src/index.js","position":209,"original_position":209,"commit_id":"2c45106fd4a541aa9aaf6c9f748168294c852947","original_commit_id":"2c45106fd4a541aa9aaf6c9f748168294c852947","user":{"login":"stephenplusplus","id":723048,"avatar_url":"https://avatars.githubusercontent.com/u/723048?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"body":"Can you alphabetize the `options`?","created_at":"2016-08-18T17:26:39Z","updated_at":"2016-08-18T17:26:39Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439#discussion_r75351120","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments/75351120"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439#discussion_r75351120"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439","id":77846939,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439","number":1439,"state":"open","locked":false,"title":"bigtable: v2 support","user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"body":"Moving Bigtable to v2!\r\n---\r\n\r\n##### TODOS:\r\n\r\n- [x] New APIs\r\n  - [x] Instance\r\n  - [x] Cluster\r\n  - [x] grpc Operations\r\n- [x] Old API Updates\r\n  - [x] ReadRows\r\n- [x] Refactor request options for existing APIs (where applicable)\r\n- [ ] Tests\r\n  - [x] Linted\r\n  - [ ] Unit\r\n    - [ ] Update outdated tests\r\n    - [ ] Add tests for new APIs\r\n  - [x] System\r\n- [x] Documentation\r\n  - [x] Add docs for new APIs\r\n  - [x] Update old docs to reflect param changes, etc.\r\n\r\n===\r\n\r\n[Docs Demo](http://callmehiphop.github.io/gcloud-node/#/docs/bigtable/master/bigtable)","created_at":"2016-07-18T17:34:54Z","updated_at":"2016-08-18T17:26:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c38fa3c0c327d40a4bf6ee66cf041df974878d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/2c45106fd4a541aa9aaf6c9f748168294c852947","head":{"label":"callmehiphop:bigtable-v2","ref":"bigtable-v2","sha":"2c45106fd4a541aa9aaf6c9f748168294c852947","user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"repo":{"id":39030018,"name":"gcloud-node","full_name":"callmehiphop/gcloud-node","owner":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/callmehiphop/gcloud-node","description":"Google Cloud Client Library for Node.js","fork":true,"url":"https://api.github.com/repos/callmehiphop/gcloud-node","forks_url":"https://api.github.com/repos/callmehiphop/gcloud-node/forks","keys_url":"https://api.github.com/repos/callmehiphop/gcloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callmehiphop/gcloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callmehiphop/gcloud-node/teams","hooks_url":"https://api.github.com/repos/callmehiphop/gcloud-node/hooks","issue_events_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/callmehiphop/gcloud-node/events","assignees_url":"https://api.github.com/repos/callmehiphop/gcloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/callmehiphop/gcloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/callmehiphop/gcloud-node/tags","blobs_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callmehiphop/gcloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/callmehiphop/gcloud-node/languages","stargazers_url":"https://api.github.com/repos/callmehiphop/gcloud-node/stargazers","contributors_url":"https://api.github.com/repos/callmehiphop/gcloud-node/contributors","subscribers_url":"https://api.github.com/repos/callmehiphop/gcloud-node/subscribers","subscription_url":"https://api.github.com/repos/callmehiphop/gcloud-node/subscription","commits_url":"https://api.github.com/repos/callmehiphop/gcloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/callmehiphop/gcloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/callmehiphop/gcloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/callmehiphop/gcloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/callmehiphop/gcloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callmehiphop/gcloud-node/merges","archive_url":"https://api.github.com/repos/callmehiphop/gcloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callmehiphop/gcloud-node/downloads","issues_url":"https://api.github.com/repos/callmehiphop/gcloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/callmehiphop/gcloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/callmehiphop/gcloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/callmehiphop/gcloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callmehiphop/gcloud-node/labels{/name}","releases_url":"https://api.github.com/repos/callmehiphop/gcloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/callmehiphop/gcloud-node/deployments","created_at":"2015-07-13T18:32:45Z","updated_at":"2016-06-24T15:31:14Z","pushed_at":"2016-08-17T20:57:57Z","git_url":"git://github.com/callmehiphop/gcloud-node.git","ssh_url":"git@github.com:callmehiphop/gcloud-node.git","clone_url":"https://github.com/callmehiphop/gcloud-node.git","svn_url":"https://github.com/callmehiphop/gcloud-node","homepage":"https://googlecloudplatform.github.io/gcloud-node/","size":16197,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"3cfc68c20e29df85a16eae1de96da8dde232207c","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19483273,"name":"gcloud-node","full_name":"GoogleCloudPlatform/gcloud-node","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-node","description":"Google Cloud Client Library for Node.js","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/deployments","created_at":"2014-05-06T06:18:00Z","updated_at":"2016-08-17T01:19:48Z","pushed_at":"2016-08-18T16:20:21Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-node.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-node.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-node.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-node","homepage":"https://googlecloudplatform.github.io/gcloud-node/","size":17846,"stargazers_count":865,"watchers_count":865,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":200,"mirror_url":null,"open_issues_count":68,"forks":200,"open_issues":68,"watchers":865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1439"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1439/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1439/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/statuses/2c45106fd4a541aa9aaf6c9f748168294c852947"}}}}
{"actor":{"display_login":"stephenplusplus"}}