{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/87078302","pull_request_review_id":7705155,"id":87078302,"diff_hunk":"@@ -52,6 +56,23 @@ func (sb *sandbox) setupDefaultGW() error {\n \t\teplen = len(sb.containerID)\n \t}\n \n+\tsbLabels := sb.Labels()\n+\n+\tif sbLabels[netlabel.PortMap] != nil {\n+\t\tcreateOptions = append(createOptions, CreateOptionPortMapping(sbLabels[netlabel.PortMap].([]types.PortBinding)))\n+\t}\n+\n+\tif sbLabels[netlabel.ExposedPorts] != nil {\n+\t\tcreateOptions = append(createOptions, CreateOptionExposedPorts(sbLabels[netlabel.ExposedPorts].([]types.TransportPort)))\n+\t}\n+\n+\tepOption := options.Generic{\n+\t\twindriver.DisableICC: true,\n+\t\twindriver.DisableDNS: true,","path":"default_gateway.go","position":36,"original_position":36,"commit_id":"2083b3364fa392914cd9f2e25a9be80d5eb86e3e","original_commit_id":"2083b3364fa392914cd9f2e25a9be80d5eb86e3e","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"Are these set for default_gw endpoints for all the platforms ? We should avoid that. Please add a `getPlatformOptions` function in platform specific files and get these info only for windows platform.","created_at":"2016-11-08T20:38:02Z","updated_at":"2016-11-08T20:50:02Z","html_url":"https://github.com/docker/libnetwork/pull/1541#discussion_r87078302","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/1541","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/87078302"},"html":{"href":"https://github.com/docker/libnetwork/pull/1541#discussion_r87078302"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1541"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/1541","id":92701691,"html_url":"https://github.com/docker/libnetwork/pull/1541","diff_url":"https://github.com/docker/libnetwork/pull/1541.diff","patch_url":"https://github.com/docker/libnetwork/pull/1541.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/1541","number":1541,"state":"open","locked":false,"title":"Default GW support for overlay networks","user":{"login":"msabansal","id":14339337,"avatar_url":"https://avatars.githubusercontent.com/u/14339337?v=3","gravatar_id":"","url":"https://api.github.com/users/msabansal","html_url":"https://github.com/msabansal","followers_url":"https://api.github.com/users/msabansal/followers","following_url":"https://api.github.com/users/msabansal/following{/other_user}","gists_url":"https://api.github.com/users/msabansal/gists{/gist_id}","starred_url":"https://api.github.com/users/msabansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabansal/subscriptions","organizations_url":"https://api.github.com/users/msabansal/orgs","repos_url":"https://api.github.com/users/msabansal/repos","events_url":"https://api.github.com/users/msabansal/events{/privacy}","received_events_url":"https://api.github.com/users/msabansal/received_events","type":"User","site_admin":false},"body":"Support for Default gateways with overlay network for windows.\r\n\r\nWindows CI results:\r\n\r\nPS C:\\Windows\\system32> C:\\Tools\\HNSCI.ps1 -remoteMachine 10.123.177.230\r\nDescribing HNS Network and Endpoint tests\r\n   Context Validate NAT Networks\r\n    [+] Should be able to build IIS Image 2.99s\r\n    [+] Should Publish all ports 5.26s\r\n    [+] Should Publish specific port 3.1s\r\n    [+] Should be able to ping external host 2.06s\r\n    [+] Validate hair pinning works 31.12s\r\n    [+] Validate service discovery 6.52s\r\n    [+] Should work with transparent network after service restart 8.4s\r\n   Context Validate Transparent Networks\r\n    [+] Should able to create single Transparent network. 7.14s\r\n    [+] Should able to create multiple Transparent network. 10.44s\r\n    [+] Should be able to ping external host 9s\r\n    [+] Should able to communicate across containers. 14.09s\r\n    [+] Should able to communicate across containers with non zero vlan. 14.37s\r\n   Context Validate L2Bridge Networks\r\n    [+] Should able to communicate across containers. 27.37s\r\n\r\nSigned-off-by: msabansal <sabansal@microsoft.com>","created_at":"2016-11-08T01:56:56Z","updated_at":"2016-11-08T20:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29274aedc38b06766816d25a783cc5cf34d9b2f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/1541/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/1541/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/1541/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/2083b3364fa392914cd9f2e25a9be80d5eb86e3e","head":{"label":"msabansal:defaultgw","ref":"defaultgw","sha":"2083b3364fa392914cd9f2e25a9be80d5eb86e3e","user":{"login":"msabansal","id":14339337,"avatar_url":"https://avatars.githubusercontent.com/u/14339337?v=3","gravatar_id":"","url":"https://api.github.com/users/msabansal","html_url":"https://github.com/msabansal","followers_url":"https://api.github.com/users/msabansal/followers","following_url":"https://api.github.com/users/msabansal/following{/other_user}","gists_url":"https://api.github.com/users/msabansal/gists{/gist_id}","starred_url":"https://api.github.com/users/msabansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabansal/subscriptions","organizations_url":"https://api.github.com/users/msabansal/orgs","repos_url":"https://api.github.com/users/msabansal/repos","events_url":"https://api.github.com/users/msabansal/events{/privacy}","received_events_url":"https://api.github.com/users/msabansal/received_events","type":"User","site_admin":false},"repo":{"id":50701804,"name":"libnetwork","full_name":"msabansal/libnetwork","owner":{"login":"msabansal","id":14339337,"avatar_url":"https://avatars.githubusercontent.com/u/14339337?v=3","gravatar_id":"","url":"https://api.github.com/users/msabansal","html_url":"https://github.com/msabansal","followers_url":"https://api.github.com/users/msabansal/followers","following_url":"https://api.github.com/users/msabansal/following{/other_user}","gists_url":"https://api.github.com/users/msabansal/gists{/gist_id}","starred_url":"https://api.github.com/users/msabansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msabansal/subscriptions","organizations_url":"https://api.github.com/users/msabansal/orgs","repos_url":"https://api.github.com/users/msabansal/repos","events_url":"https://api.github.com/users/msabansal/events{/privacy}","received_events_url":"https://api.github.com/users/msabansal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msabansal/libnetwork","description":"Docker Networking","fork":true,"url":"https://api.github.com/repos/msabansal/libnetwork","forks_url":"https://api.github.com/repos/msabansal/libnetwork/forks","keys_url":"https://api.github.com/repos/msabansal/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msabansal/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msabansal/libnetwork/teams","hooks_url":"https://api.github.com/repos/msabansal/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/msabansal/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/msabansal/libnetwork/events","assignees_url":"https://api.github.com/repos/msabansal/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/msabansal/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/msabansal/libnetwork/tags","blobs_url":"https://api.github.com/repos/msabansal/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msabansal/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msabansal/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/msabansal/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msabansal/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/msabansal/libnetwork/languages","stargazers_url":"https://api.github.com/repos/msabansal/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/msabansal/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/msabansal/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/msabansal/libnetwork/subscription","commits_url":"https://api.github.com/repos/msabansal/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/msabansal/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/msabansal/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/msabansal/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/msabansal/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/msabansal/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msabansal/libnetwork/merges","archive_url":"https://api.github.com/repos/msabansal/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msabansal/libnetwork/downloads","issues_url":"https://api.github.com/repos/msabansal/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/msabansal/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/msabansal/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/msabansal/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msabansal/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/msabansal/libnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/msabansal/libnetwork/deployments","created_at":"2016-01-30T01:03:37Z","updated_at":"2016-01-30T01:03:40Z","pushed_at":"2016-11-08T20:16:50Z","git_url":"git://github.com/msabansal/libnetwork.git","ssh_url":"git@github.com:msabansal/libnetwork.git","clone_url":"https://github.com/msabansal/libnetwork.git","svn_url":"https://github.com/msabansal/libnetwork","homepage":"","size":10222,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"15f8a90a60eeee3a39a14ca8ae2b71696cf43b55","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"Docker Networking","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/docker/libnetwork/deployments","created_at":"2015-02-20T01:20:15Z","updated_at":"2016-11-05T03:14:42Z","pushed_at":"2016-11-08T20:16:50Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":15191,"stargazers_count":781,"watchers_count":781,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":242,"forks":390,"open_issues":242,"watchers":781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1541"},"html":{"href":"https://github.com/docker/libnetwork/pull/1541"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/1541"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/1541/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1541/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1541/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/2083b3364fa392914cd9f2e25a9be80d5eb86e3e"}}}}
{"actor":{"display_login":"mavenugo"}}