{"push_id":1180467050,"size":90,"distinct_size":86,"ref":"refs/heads/lazy-reset","head":"03159859462b09db0531af52551d99290e2711a9","before":"2efb9d2713342ac26f1ee29c9626e6d2b5fd83a8","commits":[{"sha":"c483a0f928c60f63e8b08c438e5da795629a9f0a","author":{"name":"GeLo","email":"6f9b62c6d48e99b68730a20dbfed323faff58477@gmail.com"},"message":"[Form] Consider a violation even if the form is not submitted","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/c483a0f928c60f63e8b08c438e5da795629a9f0a"},{"sha":"92a7f10de5e866243843ae75dbeb353f00f37614","author":{"name":"Christian Flothmann","email":"aba769945e5ab0e948be3a2c0061fe5823865200@xabbuh.de"},"message":"[FrameworkBundle] templating can be fully disabled","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/92a7f10de5e866243843ae75dbeb353f00f37614"},{"sha":"fc3cb0b94cf7b91756ff84360e13e8dc3cfdb50b","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #19120 [FrameworkBundle] templating can be fully disabled (xabbuh)\n\nThis PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes #19120).\n\nDiscussion\n----------\n\n[FrameworkBundle] templating can be fully disabled\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 3.1\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #19052\n| License       | MIT\n| Doc PR        |\n\nCommits\n-------\n\n92a7f10 [FrameworkBundle] templating can be fully disabled","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/fc3cb0b94cf7b91756ff84360e13e8dc3cfdb50b"},{"sha":"c6db6f3d50167a9467a7609d49bb28a637a8e000","author":{"name":"Jáchym Toušek","email":"9603bb76a7e246ec9cfc1a15bd89803f05fc578d@gmail.com"},"message":"[Form] Add exception to FormRenderer about non-unique block names","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/c6db6f3d50167a9467a7609d49bb28a637a8e000"},{"sha":"b05014c2e9a161b1d78bcc746a8e946226e5a461","author":{"name":"Iltar van der Berg","email":"b3d550587ad53e0f9a63c9922b92a24c9d8f707a@hostnet.nl"},"message":"Avoid phpunit 5.4 warnings on getMock","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/b05014c2e9a161b1d78bcc746a8e946226e5a461"},{"sha":"d54cd02d0692a5ca96cce37b7a361d960c5807ad","author":{"name":"Nicolas Grekas","email":"ec5ccb19bcd9237073a700927cff7f3ddf333fd9@gmail.com"},"message":"[Process] Fix pipes cleaning on Windows","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/d54cd02d0692a5ca96cce37b7a361d960c5807ad"},{"sha":"a65fe45ec99b8a51d5d11d0f2361ac3df389570a","author":{"name":"Nicolas Grekas","email":"ec5ccb19bcd9237073a700927cff7f3ddf333fd9@gmail.com"},"message":"bug #19128 Avoid phpunit 5.4 warnings on getMock (2.7+) (iltar)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\nAvoid phpunit 5.4 warnings on getMock (2.7+)\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #19125\n| License       | MIT\n| Doc PR        | ~\n\nAvoids calling `getMock()` in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point.\n\nCommits\n-------\n\nb05014c Avoid phpunit 5.4 warnings on getMock","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/a65fe45ec99b8a51d5d11d0f2361ac3df389570a"},{"sha":"ec19a527be89fb0bfa04ae3301d694d9556c4e8b","author":{"name":"Romain Neutron","email":"b50746e40e959152fe58ef51fe3b178ec5cabf45@gmail.com"},"message":"bug #19118 [Process] Fix pipes cleaning on Windows (nicolas-grekas)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[Process] Fix pipes cleaning on Windows\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #19089\n| License       | MIT\n| Doc PR        | -\n\nCommits\n-------\n\nd54cd02 [Process] Fix pipes cleaning on Windows","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/ec19a527be89fb0bfa04ae3301d694d9556c4e8b"},{"sha":"bbb75faa15c995b4b11ccf71a53618c570bb58eb","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #19127 [Form] Add exception to FormRenderer about non-unique block names (enumag)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[Form] Add exception to FormRenderer about non-unique block names\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #17874\n| License       | MIT\n| Doc PR        |\n\nCommits\n-------\n\nc6db6f3 [Form] Add exception to FormRenderer about non-unique block names","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/bbb75faa15c995b4b11ccf71a53618c570bb58eb"},{"sha":"f28eb9a6172d44217186c11b78841fd3efcbb6f4","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #18935 [Form] Consider a violation even if the form is not submitted (egeloen)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[Form] Consider a violation even if the form is not submitted\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | yes (only for the behavior)\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #11493\n| License       | MIT\n| Doc PR        |\n\nHey!\n\nI'm currently implementing an API using the form component in order to validate the payload sent (in conjonction with the FOSRestBundle). Unfortunatelly, we dig into an issue about the PATCH request which don't map some of our validation rules to the form. Basically, the violations are lost in the middle of the process.\n\n### Use case\n\nWe have an entity with the following fields \"type\", \"image\" & \"video\". The field \"type\"can be either \"default\", \"image\" or \"video\" and then accordingly we use the appropriate field (none for the \"default\" type, video for the \"video\" type and image for the \"image\" type. Then, in our form, we change the validation groups according to our entity type in order to make the \"image\" field mandatory if the type is \"image\" and the same for the video field if the type is \"video\".\n\n### Current behavior\n\nThe current behavior (since 2.5) seems to not propages a violation to a form if this form is not submitted but in our use case, changing the field \"type\" via a PATCH request triggers some new validation which should be reported to end user (inform that a field (video or image) is missing in the PATCH request).\n\n### Expected behavior\n\nThe current behavior was introduced in #10567 but IMO, this update is a bug as suggested by @webmozart in https://github.com/symfony/symfony/issues/11493#issuecomment-59549054 Instead, the form component should still map validation errors to the form even if the field was not submitted. If the initial data is not valid, then your initial data was buggy from the beginning but the form should not accept it and instead of silently ignoring the errors, end users should be informed and fix it.\n\nWDYT?\n\nCommits\n-------\n\nc483a0f [Form] Consider a violation even if the form is not submitted","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/f28eb9a6172d44217186c11b78841fd3efcbb6f4"},{"sha":"9d8a5e5a043a5ec6be68cc1dd1aaa46c7d7ef315","author":{"name":"David Badura","email":"6612e1d14793989be7a95821de5cfbe204cc6f62@i22.de"},"message":"fix post_max_size_message translation","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/9d8a5e5a043a5ec6be68cc1dd1aaa46c7d7ef315"},{"sha":"953a3835a244fdfdaa55262f11f059c9d489cdd5","author":{"name":"guiled","email":"77716954b5e5de4e32959940ad6460e8c6557ffb@gmail.com"},"message":"No more exception for malformed input name","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/953a3835a244fdfdaa55262f11f059c9d489cdd5"},{"sha":"e204913a6762944dd4bc8d29fee953f4ba84b2b5","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"finished previous commit","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/e204913a6762944dd4bc8d29fee953f4ba84b2b5"},{"sha":"eaca0bb0fad490c559f7ce38af3ff6783a2f6ecc","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #19138 [DomCrawler] No more exception on field name with strange format (guiled, fabpot)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[DomCrawler] No more exception on field name with strange format\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #18569, #18570\n| License       | MIT\n| Doc PR        | n/a\n\nCommits\n-------\n\ne204913 finished previous commit\n953a383 No more exception for malformed input name","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/eaca0bb0fad490c559f7ce38af3ff6783a2f6ecc"},{"sha":"3871e1a95056ce8278e6b86d3e8005836ecab954","author":{"name":"Richard Quadling","email":"0445252de55efe71b065e8a22cb35f1d147aa7d9@GMail.com"},"message":"Differentiate between the first time a progress bar is displayed and subsequent times","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/3871e1a95056ce8278e6b86d3e8005836ecab954"},{"sha":"f6e5298f02849ca96777db03d1eb74acb6c4d1a9","author":{"name":"Bernhard Schussek","email":"dd72215d244a2608ed17499889c1596b5bda01f7@gmail.com"},"message":"[DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/f6e5298f02849ca96777db03d1eb74acb6c4d1a9"},{"sha":"80057b07e0a33cc42abcb0ee0f42ca2bbfdf4dad","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #18924 [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure (webmozart)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nThis PR is porting an optimization done for `loadChoicesForValues()` in 64c80a679148cd6d4f11d326fc1b0d4144772420 to `loadValuesForChoices()`.\n\nCommits\n-------\n\nf6e5298 [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/80057b07e0a33cc42abcb0ee0f42ca2bbfdf4dad"},{"sha":"a8f6f857484a4c029c2bb1cf396e004c88b8a541","author":{"name":"Sebastiaan Stok","email":"33747dcaa8c45ea0f6bdf979cf10b6f6666723f7@rollerscapes.net"},"message":"Fixed SymfonyQuestionHelper multi-choice with defaults","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/a8f6f857484a4c029c2bb1cf396e004c88b8a541"},{"sha":"dadf570c7b2c092dd364af5c927fc1733d9a044b","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #19100 [Console] Fixed SymfonyQuestionHelper multi-choice with defaults (sstok)\n\nThis PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #19100).\n\nDiscussion\n----------\n\n[Console] Fixed SymfonyQuestionHelper multi-choice with defaults\n\n|Q            |A  |\n|---          |---|\n|Bug Fix?     |yes|\n|New Feature? |no |\n|BC Breaks?   |no |\n|Deprecations?|no |\n|Tests Pass?  |yes|\n|Fixed Tickets|   |\n|License      |MIT|\n|Doc PR       |   |\n\nWhen you use the SymfonyStyle with a multi-choice question and multiple defaults.\nYou get an notice because the key is used as-is `0,1` instead of splitting the value.\n\nThis pull-request changes the SymfonyQuestionHelper to checks if the Choice is a multi-choice\nand displays the selected values correctly `[blue, yellow]`.\n\nNote: Tests are missing, but both the SymfonyStyle and SymfonyQuestionHelper classes\nhave almost no tests. Making it really hard 😇 hopefully #19097 will make this easier :+1:\n\nCommits\n-------\n\na8f6f85 Fixed SymfonyQuestionHelper multi-choice with defaults","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/dadf570c7b2c092dd364af5c927fc1733d9a044b"},{"sha":"e8901b166971957673d0c7a763363d94789a109a","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #19061 [FORM] fix post_max_size_message translation (alt. 2) (David Badura)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[FORM] fix post_max_size_message translation (alt. 2)\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #15479, #18543\n| License       | MIT\n| Doc PR        | -\n\nCommits\n-------\n\n9d8a5e5 fix post_max_size_message translation","distinct":true,"url":"https://api.github.com/repos/nicolas-grekas/symfony/commits/e8901b166971957673d0c7a763363d94789a109a"}]}
{"actor":{"display_login":"nicolas-grekas"}}