{"action":"created","issue":{"url":"https://api.github.com/repos/omnifaces/omnifaces/issues/217","repository_url":"https://api.github.com/repos/omnifaces/omnifaces","labels_url":"https://api.github.com/repos/omnifaces/omnifaces/issues/217/labels{/name}","comments_url":"https://api.github.com/repos/omnifaces/omnifaces/issues/217/comments","events_url":"https://api.github.com/repos/omnifaces/omnifaces/issues/217/events","html_url":"https://github.com/omnifaces/omnifaces/pull/217","id":139895725,"number":217,"title":"Performance issue with Converter,","user":{"login":"alero","id":449773,"avatar_url":"https://avatars.githubusercontent.com/u/449773?v=3","gravatar_id":"","url":"https://api.github.com/users/alero","html_url":"https://github.com/alero","followers_url":"https://api.github.com/users/alero/followers","following_url":"https://api.github.com/users/alero/following{/other_user}","gists_url":"https://api.github.com/users/alero/gists{/gist_id}","starred_url":"https://api.github.com/users/alero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alero/subscriptions","organizations_url":"https://api.github.com/users/alero/orgs","repos_url":"https://api.github.com/users/alero/repos","events_url":"https://api.github.com/users/alero/events{/privacy}","received_events_url":"https://api.github.com/users/alero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-10T14:05:04Z","updated_at":"2016-03-11T12:50:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/omnifaces/omnifaces/pulls/217","html_url":"https://github.com/omnifaces/omnifaces/pull/217","diff_url":"https://github.com/omnifaces/omnifaces/pull/217.diff","patch_url":"https://github.com/omnifaces/omnifaces/pull/217.patch"},"body":"New version stores the converter as a singleton only once for the ConverterManager\r\nMakes the solution work for pages with 1000+ converters (tested with 3000 converters)\r\n\r\nIn my application a page has 3000 converters and with old solution It took 300ms or more to just create the Converters. With this solution it takes 1ms or less as each converter is treated as a singleton and is as fast as the access to the local Map once created and injected."},"comment":{"url":"https://api.github.com/repos/omnifaces/omnifaces/issues/comments/195352446","html_url":"https://github.com/omnifaces/omnifaces/pull/217#issuecomment-195352446","issue_url":"https://api.github.com/repos/omnifaces/omnifaces/issues/217","id":195352446,"user":{"login":"alero","id":449773,"avatar_url":"https://avatars.githubusercontent.com/u/449773?v=3","gravatar_id":"","url":"https://api.github.com/users/alero","html_url":"https://github.com/alero","followers_url":"https://api.github.com/users/alero/followers","following_url":"https://api.github.com/users/alero/following{/other_user}","gists_url":"https://api.github.com/users/alero/gists{/gist_id}","starred_url":"https://api.github.com/users/alero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alero/subscriptions","organizations_url":"https://api.github.com/users/alero/orgs","repos_url":"https://api.github.com/users/alero/repos","events_url":"https://api.github.com/users/alero/events{/privacy}","received_events_url":"https://api.github.com/users/alero/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T12:50:35Z","updated_at":"2016-03-11T12:50:35Z","body":"The second commit changed the errorhandling when registering classes for converter as List for example was passing through the method throwing errors, now it just stays quiet"}}