{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/59585796","id":59585796,"diff_hunk":"@@ -1631,4 +1631,30 @@\n       end\n     end\n   end\n+\n+  describe \"field_in_sql?\" do\n+    it \"should returns false for model.virtualfield\" do\n+      field = \"ManageIQ::Providers::InfraManager::Vm-archived\"\n+      expression = {\"=\" => {\"field\" => field, \"value\" => \"true\"}}\n+      expect(described_class.new(expression).field_in_sql?(field)).to eq(false)","path":"spec/models/miq_expression_spec.rb","position":null,"original_position":9,"commit_id":"9f7bf2a5351dd6aa0e8ea0b0a56d9a54cd067705","original_commit_id":"8976712b628887a974a513092edf1e4a2d8f4c1b","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"body":"Rats! This stuff is so confusing. So these tests are giving us great design feedback :thumbsup:","created_at":"2016-04-13T17:04:03Z","updated_at":"2016-04-13T17:04:03Z","html_url":"https://github.com/ManageIQ/manageiq/pull/7928#discussion_r59585796","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/59585796"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7928#discussion_r59585796"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928","id":66318000,"html_url":"https://github.com/ManageIQ/manageiq/pull/7928","diff_url":"https://github.com/ManageIQ/manageiq/pull/7928.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7928.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7928","number":7928,"state":"open","locked":false,"title":"Added test coverage for MiqExpression#field_in_sql?","user":{"login":"yrudman","id":6556758,"avatar_url":"https://avatars.githubusercontent.com/u/6556758?v=3","gravatar_id":"","url":"https://api.github.com/users/yrudman","html_url":"https://github.com/yrudman","followers_url":"https://api.github.com/users/yrudman/followers","following_url":"https://api.github.com/users/yrudman/following{/other_user}","gists_url":"https://api.github.com/users/yrudman/gists{/gist_id}","starred_url":"https://api.github.com/users/yrudman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrudman/subscriptions","organizations_url":"https://api.github.com/users/yrudman/orgs","repos_url":"https://api.github.com/users/yrudman/repos","events_url":"https://api.github.com/users/yrudman/events{/privacy}","received_events_url":"https://api.github.com/users/yrudman/received_events","type":"User","site_admin":false},"body":"Added test coverage for field_in_sql?() in MiqExpression\r\n\r\n/cc @imtayadeway @gtanzillo @jrafanie \r\n@miq-bot add-label test, core","created_at":"2016-04-13T13:09:18Z","updated_at":"2016-04-13T17:04:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ca6e4d5734f5d0e0dc68f5d8c00ee72d0ab8915","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7928/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/9f7bf2a5351dd6aa0e8ea0b0a56d9a54cd067705","head":{"label":"yrudman:more-specs-tp-miq-expression","ref":"more-specs-tp-miq-expression","sha":"9f7bf2a5351dd6aa0e8ea0b0a56d9a54cd067705","user":{"login":"yrudman","id":6556758,"avatar_url":"https://avatars.githubusercontent.com/u/6556758?v=3","gravatar_id":"","url":"https://api.github.com/users/yrudman","html_url":"https://github.com/yrudman","followers_url":"https://api.github.com/users/yrudman/followers","following_url":"https://api.github.com/users/yrudman/following{/other_user}","gists_url":"https://api.github.com/users/yrudman/gists{/gist_id}","starred_url":"https://api.github.com/users/yrudman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrudman/subscriptions","organizations_url":"https://api.github.com/users/yrudman/orgs","repos_url":"https://api.github.com/users/yrudman/repos","events_url":"https://api.github.com/users/yrudman/events{/privacy}","received_events_url":"https://api.github.com/users/yrudman/received_events","type":"User","site_admin":false},"repo":{"id":50465345,"name":"manageiq","full_name":"yrudman/manageiq","owner":{"login":"yrudman","id":6556758,"avatar_url":"https://avatars.githubusercontent.com/u/6556758?v=3","gravatar_id":"","url":"https://api.github.com/users/yrudman","html_url":"https://github.com/yrudman","followers_url":"https://api.github.com/users/yrudman/followers","following_url":"https://api.github.com/users/yrudman/following{/other_user}","gists_url":"https://api.github.com/users/yrudman/gists{/gist_id}","starred_url":"https://api.github.com/users/yrudman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrudman/subscriptions","organizations_url":"https://api.github.com/users/yrudman/orgs","repos_url":"https://api.github.com/users/yrudman/repos","events_url":"https://api.github.com/users/yrudman/events{/privacy}","received_events_url":"https://api.github.com/users/yrudman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yrudman/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/yrudman/manageiq","forks_url":"https://api.github.com/repos/yrudman/manageiq/forks","keys_url":"https://api.github.com/repos/yrudman/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yrudman/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yrudman/manageiq/teams","hooks_url":"https://api.github.com/repos/yrudman/manageiq/hooks","issue_events_url":"https://api.github.com/repos/yrudman/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/yrudman/manageiq/events","assignees_url":"https://api.github.com/repos/yrudman/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/yrudman/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/yrudman/manageiq/tags","blobs_url":"https://api.github.com/repos/yrudman/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yrudman/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yrudman/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/yrudman/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yrudman/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/yrudman/manageiq/languages","stargazers_url":"https://api.github.com/repos/yrudman/manageiq/stargazers","contributors_url":"https://api.github.com/repos/yrudman/manageiq/contributors","subscribers_url":"https://api.github.com/repos/yrudman/manageiq/subscribers","subscription_url":"https://api.github.com/repos/yrudman/manageiq/subscription","commits_url":"https://api.github.com/repos/yrudman/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/yrudman/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/yrudman/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/yrudman/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/yrudman/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/yrudman/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yrudman/manageiq/merges","archive_url":"https://api.github.com/repos/yrudman/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yrudman/manageiq/downloads","issues_url":"https://api.github.com/repos/yrudman/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/yrudman/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/yrudman/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/yrudman/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yrudman/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/yrudman/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/yrudman/manageiq/deployments","created_at":"2016-01-26T22:55:59Z","updated_at":"2016-01-26T22:56:16Z","pushed_at":"2016-04-13T17:02:09Z","git_url":"git://github.com/yrudman/manageiq.git","ssh_url":"git@github.com:yrudman/manageiq.git","clone_url":"https://github.com/yrudman/manageiq.git","svn_url":"https://github.com/yrudman/manageiq","homepage":"manageiq.org","size":117547,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"0d63f799c4268abff0cf19f7591658a35faaf429","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-04-13T14:44:53Z","pushed_at":"2016-04-13T17:02:10Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":155284,"stargazers_count":253,"watchers_count":253,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":268,"mirror_url":null,"open_issues_count":651,"forks":268,"open_issues":651,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7928"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7928"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7928/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7928/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/9f7bf2a5351dd6aa0e8ea0b0a56d9a54cd067705"}}}}