{"action":"created","issue":{"url":"https://api.github.com/repos/getlantern/ops-panel/issues/10","repository_url":"https://api.github.com/repos/getlantern/ops-panel","labels_url":"https://api.github.com/repos/getlantern/ops-panel/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/getlantern/ops-panel/issues/10/comments","events_url":"https://api.github.com/repos/getlantern/ops-panel/issues/10/events","html_url":"https://github.com/getlantern/ops-panel/pull/10","id":172129672,"number":10,"title":"Grab client IP when behind proxy, Heroku or CDN","user":{"login":"uaalto","id":12701448,"avatar_url":"https://avatars.githubusercontent.com/u/12701448?v=3","gravatar_id":"","url":"https://api.github.com/users/uaalto","html_url":"https://github.com/uaalto","followers_url":"https://api.github.com/users/uaalto/followers","following_url":"https://api.github.com/users/uaalto/following{/other_user}","gists_url":"https://api.github.com/users/uaalto/gists{/gist_id}","starred_url":"https://api.github.com/users/uaalto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uaalto/subscriptions","organizations_url":"https://api.github.com/users/uaalto/orgs","repos_url":"https://api.github.com/users/uaalto/repos","events_url":"https://api.github.com/users/uaalto/events{/privacy}","received_events_url":"https://api.github.com/users/uaalto/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-19T13:20:02Z","updated_at":"2016-10-17T16:49:29Z","closed_at":"2016-10-17T16:49:29Z","pull_request":{"url":"https://api.github.com/repos/getlantern/ops-panel/pulls/10","html_url":"https://github.com/getlantern/ops-panel/pull/10","diff_url":"https://github.com/getlantern/ops-panel/pull/10.diff","patch_url":"https://github.com/getlantern/ops-panel/pull/10.patch"},"body":"I tested this as best as I could without deploying anywhere. "},"comment":{"url":"https://api.github.com/repos/getlantern/ops-panel/issues/comments/254264677","html_url":"https://github.com/getlantern/ops-panel/pull/10#issuecomment-254264677","issue_url":"https://api.github.com/repos/getlantern/ops-panel/issues/10","id":254264677,"user":{"login":"aranhoide","id":2204867,"avatar_url":"https://avatars.githubusercontent.com/u/2204867?v=3","gravatar_id":"","url":"https://api.github.com/users/aranhoide","html_url":"https://github.com/aranhoide","followers_url":"https://api.github.com/users/aranhoide/followers","following_url":"https://api.github.com/users/aranhoide/following{/other_user}","gists_url":"https://api.github.com/users/aranhoide/gists{/gist_id}","starred_url":"https://api.github.com/users/aranhoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aranhoide/subscriptions","organizations_url":"https://api.github.com/users/aranhoide/orgs","repos_url":"https://api.github.com/users/aranhoide/repos","events_url":"https://api.github.com/users/aranhoide/events{/privacy}","received_events_url":"https://api.github.com/users/aranhoide/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T16:49:29Z","updated_at":"2016-10-17T16:49:29Z","body":"@uaalto: sorry, I hadn't seen this PR until now!\r\n\r\nI think the logic from the config server is more complicated than is required here.  This endpoint is protected by authentication and there's not much danger in potential attackers whitelisting many IPs; most harm would come from them authenticating their real one.\r\n\r\nSo I think we can just use the last of an x-forwarded-for if it's there, or the remote IP otherwise.  I'll make a PR to do that. "}}
{"actor":{"display_login":"aranhoide"}}