{"action":"closed","number":621,"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing-android/pulls/621","id":67072827,"html_url":"https://github.com/syncthing/syncthing-android/pull/621","diff_url":"https://github.com/syncthing/syncthing-android/pull/621.diff","patch_url":"https://github.com/syncthing/syncthing-android/pull/621.patch","issue_url":"https://api.github.com/repos/syncthing/syncthing-android/issues/621","number":621,"state":"closed","locked":false,"title":"Add checks for null-SSID (fix for #620)","user":{"login":"capi","id":254852,"avatar_url":"https://avatars.githubusercontent.com/u/254852?v=3","gravatar_id":"","url":"https://api.github.com/users/capi","html_url":"https://github.com/capi","followers_url":"https://api.github.com/users/capi/followers","following_url":"https://api.github.com/users/capi/following{/other_user}","gists_url":"https://api.github.com/users/capi/gists{/gist_id}","starred_url":"https://api.github.com/users/capi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capi/subscriptions","organizations_url":"https://api.github.com/users/capi/orgs","repos_url":"https://api.github.com/users/capi/repos","events_url":"https://api.github.com/users/capi/events{/privacy}","received_events_url":"https://api.github.com/users/capi/received_events","type":"User","site_admin":false},"body":"This is a simple safety check for null when accessing and displaying SSIDs in `WifiSsidPreference`. I still think that there is something going on inside CM regarding maybe missing permissions, because I cannot think of a valid case where a stored WiFi network has no SSID.\r\n\r\nThe check in `SyncthingService` is already null-safe.","created_at":"2016-04-19T19:10:30Z","updated_at":"2016-04-19T22:31:38Z","closed_at":"2016-04-19T22:31:37Z","merged_at":"2016-04-19T22:31:37Z","merge_commit_sha":"24edfc8364a37c17b03ab7658af579995a110cea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syncthing/syncthing-android/pulls/621/commits","review_comments_url":"https://api.github.com/repos/syncthing/syncthing-android/pulls/621/comments","review_comment_url":"https://api.github.com/repos/syncthing/syncthing-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syncthing/syncthing-android/issues/621/comments","statuses_url":"https://api.github.com/repos/syncthing/syncthing-android/statuses/284d9bd7d3c4166e1ff4d6b1b79b37b3cbe2645e","head":{"label":"capi:fix-620","ref":"fix-620","sha":"284d9bd7d3c4166e1ff4d6b1b79b37b3cbe2645e","user":{"login":"capi","id":254852,"avatar_url":"https://avatars.githubusercontent.com/u/254852?v=3","gravatar_id":"","url":"https://api.github.com/users/capi","html_url":"https://github.com/capi","followers_url":"https://api.github.com/users/capi/followers","following_url":"https://api.github.com/users/capi/following{/other_user}","gists_url":"https://api.github.com/users/capi/gists{/gist_id}","starred_url":"https://api.github.com/users/capi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capi/subscriptions","organizations_url":"https://api.github.com/users/capi/orgs","repos_url":"https://api.github.com/users/capi/repos","events_url":"https://api.github.com/users/capi/events{/privacy}","received_events_url":"https://api.github.com/users/capi/received_events","type":"User","site_admin":false},"repo":{"id":46195082,"name":"syncthing-android","full_name":"capi/syncthing-android","owner":{"login":"capi","id":254852,"avatar_url":"https://avatars.githubusercontent.com/u/254852?v=3","gravatar_id":"","url":"https://api.github.com/users/capi","html_url":"https://github.com/capi","followers_url":"https://api.github.com/users/capi/followers","following_url":"https://api.github.com/users/capi/following{/other_user}","gists_url":"https://api.github.com/users/capi/gists{/gist_id}","starred_url":"https://api.github.com/users/capi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capi/subscriptions","organizations_url":"https://api.github.com/users/capi/orgs","repos_url":"https://api.github.com/users/capi/repos","events_url":"https://api.github.com/users/capi/events{/privacy}","received_events_url":"https://api.github.com/users/capi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/capi/syncthing-android","description":"Wrapper of syncthing for Android.","fork":true,"url":"https://api.github.com/repos/capi/syncthing-android","forks_url":"https://api.github.com/repos/capi/syncthing-android/forks","keys_url":"https://api.github.com/repos/capi/syncthing-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capi/syncthing-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capi/syncthing-android/teams","hooks_url":"https://api.github.com/repos/capi/syncthing-android/hooks","issue_events_url":"https://api.github.com/repos/capi/syncthing-android/issues/events{/number}","events_url":"https://api.github.com/repos/capi/syncthing-android/events","assignees_url":"https://api.github.com/repos/capi/syncthing-android/assignees{/user}","branches_url":"https://api.github.com/repos/capi/syncthing-android/branches{/branch}","tags_url":"https://api.github.com/repos/capi/syncthing-android/tags","blobs_url":"https://api.github.com/repos/capi/syncthing-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capi/syncthing-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capi/syncthing-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/capi/syncthing-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capi/syncthing-android/statuses/{sha}","languages_url":"https://api.github.com/repos/capi/syncthing-android/languages","stargazers_url":"https://api.github.com/repos/capi/syncthing-android/stargazers","contributors_url":"https://api.github.com/repos/capi/syncthing-android/contributors","subscribers_url":"https://api.github.com/repos/capi/syncthing-android/subscribers","subscription_url":"https://api.github.com/repos/capi/syncthing-android/subscription","commits_url":"https://api.github.com/repos/capi/syncthing-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/capi/syncthing-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/capi/syncthing-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/capi/syncthing-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/capi/syncthing-android/contents/{+path}","compare_url":"https://api.github.com/repos/capi/syncthing-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capi/syncthing-android/merges","archive_url":"https://api.github.com/repos/capi/syncthing-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capi/syncthing-android/downloads","issues_url":"https://api.github.com/repos/capi/syncthing-android/issues{/number}","pulls_url":"https://api.github.com/repos/capi/syncthing-android/pulls{/number}","milestones_url":"https://api.github.com/repos/capi/syncthing-android/milestones{/number}","notifications_url":"https://api.github.com/repos/capi/syncthing-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capi/syncthing-android/labels{/name}","releases_url":"https://api.github.com/repos/capi/syncthing-android/releases{/id}","deployments_url":"https://api.github.com/repos/capi/syncthing-android/deployments","created_at":"2015-11-14T22:44:35Z","updated_at":"2016-01-23T20:14:11Z","pushed_at":"2016-04-19T20:39:38Z","git_url":"git://github.com/capi/syncthing-android.git","ssh_url":"git@github.com:capi/syncthing-android.git","clone_url":"https://github.com/capi/syncthing-android.git","svn_url":"https://github.com/capi/syncthing-android","homepage":"https://syncthing.net/","size":6937,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syncthing:master","ref":"master","sha":"e2b9a8b8137852c719e45dbca93aaa56890d1841","user":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"repo":{"id":17089728,"name":"syncthing-android","full_name":"syncthing/syncthing-android","owner":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncthing/syncthing-android","description":"Wrapper of syncthing for Android.","fork":false,"url":"https://api.github.com/repos/syncthing/syncthing-android","forks_url":"https://api.github.com/repos/syncthing/syncthing-android/forks","keys_url":"https://api.github.com/repos/syncthing/syncthing-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncthing/syncthing-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncthing/syncthing-android/teams","hooks_url":"https://api.github.com/repos/syncthing/syncthing-android/hooks","issue_events_url":"https://api.github.com/repos/syncthing/syncthing-android/issues/events{/number}","events_url":"https://api.github.com/repos/syncthing/syncthing-android/events","assignees_url":"https://api.github.com/repos/syncthing/syncthing-android/assignees{/user}","branches_url":"https://api.github.com/repos/syncthing/syncthing-android/branches{/branch}","tags_url":"https://api.github.com/repos/syncthing/syncthing-android/tags","blobs_url":"https://api.github.com/repos/syncthing/syncthing-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncthing/syncthing-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncthing/syncthing-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncthing/syncthing-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncthing/syncthing-android/statuses/{sha}","languages_url":"https://api.github.com/repos/syncthing/syncthing-android/languages","stargazers_url":"https://api.github.com/repos/syncthing/syncthing-android/stargazers","contributors_url":"https://api.github.com/repos/syncthing/syncthing-android/contributors","subscribers_url":"https://api.github.com/repos/syncthing/syncthing-android/subscribers","subscription_url":"https://api.github.com/repos/syncthing/syncthing-android/subscription","commits_url":"https://api.github.com/repos/syncthing/syncthing-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncthing/syncthing-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncthing/syncthing-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncthing/syncthing-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/syncthing/syncthing-android/contents/{+path}","compare_url":"https://api.github.com/repos/syncthing/syncthing-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncthing/syncthing-android/merges","archive_url":"https://api.github.com/repos/syncthing/syncthing-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncthing/syncthing-android/downloads","issues_url":"https://api.github.com/repos/syncthing/syncthing-android/issues{/number}","pulls_url":"https://api.github.com/repos/syncthing/syncthing-android/pulls{/number}","milestones_url":"https://api.github.com/repos/syncthing/syncthing-android/milestones{/number}","notifications_url":"https://api.github.com/repos/syncthing/syncthing-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncthing/syncthing-android/labels{/name}","releases_url":"https://api.github.com/repos/syncthing/syncthing-android/releases{/id}","deployments_url":"https://api.github.com/repos/syncthing/syncthing-android/deployments","created_at":"2014-02-22T17:15:19Z","updated_at":"2016-04-19T19:36:06Z","pushed_at":"2016-04-19T22:31:37Z","git_url":"git://github.com/syncthing/syncthing-android.git","ssh_url":"git@github.com:syncthing/syncthing-android.git","clone_url":"https://github.com/syncthing/syncthing-android.git","svn_url":"https://github.com/syncthing/syncthing-android","homepage":"https://syncthing.net/","size":7219,"stargazers_count":511,"watchers_count":511,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":54,"forks":85,"open_issues":54,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing-android/pulls/621"},"html":{"href":"https://github.com/syncthing/syncthing-android/pull/621"},"issue":{"href":"https://api.github.com/repos/syncthing/syncthing-android/issues/621"},"comments":{"href":"https://api.github.com/repos/syncthing/syncthing-android/issues/621/comments"},"review_comments":{"href":"https://api.github.com/repos/syncthing/syncthing-android/pulls/621/comments"},"review_comment":{"href":"https://api.github.com/repos/syncthing/syncthing-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syncthing/syncthing-android/pulls/621/commits"},"statuses":{"href":"https://api.github.com/repos/syncthing/syncthing-android/statuses/284d9bd7d3c4166e1ff4d6b1b79b37b3cbe2645e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Nutomic","id":1044450,"avatar_url":"https://avatars.githubusercontent.com/u/1044450?v=3","gravatar_id":"","url":"https://api.github.com/users/Nutomic","html_url":"https://github.com/Nutomic","followers_url":"https://api.github.com/users/Nutomic/followers","following_url":"https://api.github.com/users/Nutomic/following{/other_user}","gists_url":"https://api.github.com/users/Nutomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Nutomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nutomic/subscriptions","organizations_url":"https://api.github.com/users/Nutomic/orgs","repos_url":"https://api.github.com/users/Nutomic/repos","events_url":"https://api.github.com/users/Nutomic/events{/privacy}","received_events_url":"https://api.github.com/users/Nutomic/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"commits":1,"additions":8,"deletions":3,"changed_files":1}}