{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/57632048","id":57632048,"diff_hunk":"@@ -850,25 +850,18 @@ def removeDiskByFile(backingFile, deleteBacking = false)\n   def getScsiCandU\n     devs = getProp(\"config.hardware\")[\"config\"][\"hardware\"][\"device\"]\n     ctrlrHash = {}\n-    devs.each do |dev|\n-      next unless (key = dev[\"key\"])\n-      next unless dev[\"deviceInfo\"]\n-      next unless (label = dev[\"deviceInfo\"][\"label\"])\n-      ctrlrHash[key] = 0 if label =~ /^SCSI\\s[Cc]ontroller\\s.*$/\n-    end\n+\n+    scsi_dev = devs.detect {|x| x.xsiType == 'ParaVirtualSCSIController' } || {}","path":"gems/pending/VMwareWebService/MiqVimVm.rb","position":11,"original_position":11,"commit_id":"ef5c7921245d22905ae2f39ae88078152c916cee","original_commit_id":"ef5c7921245d22905ae2f39ae88078152c916cee","user":{"login":"syncrou","id":697347,"avatar_url":"https://avatars.githubusercontent.com/u/697347?v=3","gravatar_id":"","url":"https://api.github.com/users/syncrou","html_url":"https://github.com/syncrou","followers_url":"https://api.github.com/users/syncrou/followers","following_url":"https://api.github.com/users/syncrou/following{/other_user}","gists_url":"https://api.github.com/users/syncrou/gists{/gist_id}","starred_url":"https://api.github.com/users/syncrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncrou/subscriptions","organizations_url":"https://api.github.com/users/syncrou/orgs","repos_url":"https://api.github.com/users/syncrou/repos","events_url":"https://api.github.com/users/syncrou/events{/privacy}","received_events_url":"https://api.github.com/users/syncrou/received_events","type":"User","site_admin":false},"body":"@agrare - Sounds good - I'll get those added.","created_at":"2016-03-28T20:54:42Z","updated_at":"2016-03-28T20:54:42Z","html_url":"https://github.com/ManageIQ/manageiq/pull/7554#discussion_r57632048","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/57632048"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7554#discussion_r57632048"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554","id":64372626,"html_url":"https://github.com/ManageIQ/manageiq/pull/7554","diff_url":"https://github.com/ManageIQ/manageiq/pull/7554.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7554.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7554","number":7554,"state":"open","locked":false,"title":"Check for a specific xsiType when adding a disk to a VMware instance","user":{"login":"syncrou","id":697347,"avatar_url":"https://avatars.githubusercontent.com/u/697347?v=3","gravatar_id":"","url":"https://api.github.com/users/syncrou","html_url":"https://github.com/syncrou","followers_url":"https://api.github.com/users/syncrou/followers","following_url":"https://api.github.com/users/syncrou/following{/other_user}","gists_url":"https://api.github.com/users/syncrou/gists{/gist_id}","starred_url":"https://api.github.com/users/syncrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncrou/subscriptions","organizations_url":"https://api.github.com/users/syncrou/orgs","repos_url":"https://api.github.com/users/syncrou/repos","events_url":"https://api.github.com/users/syncrou/events{/privacy}","received_events_url":"https://api.github.com/users/syncrou/received_events","type":"User","site_admin":false},"body":"https://bugzilla.redhat.com/show_bug.cgi?id=1311221\r\n\r\nWhen hot adding a disk we were using a Regex to find the\r\nappropriate SCSI controller.  This change validates the xsiType\r\nas being the correct type and removes the Regex.\r\nThis will remove the problems the Regex\r\ncreated with different localizations.","created_at":"2016-03-28T20:40:28Z","updated_at":"2016-03-28T20:54:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4a726cff37dd52ae338e277462ca04b0a88d489","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7554/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/ef5c7921245d22905ae2f39ae88078152c916cee","head":{"label":"syncrou:add_disk_fix","ref":"add_disk_fix","sha":"ef5c7921245d22905ae2f39ae88078152c916cee","user":{"login":"syncrou","id":697347,"avatar_url":"https://avatars.githubusercontent.com/u/697347?v=3","gravatar_id":"","url":"https://api.github.com/users/syncrou","html_url":"https://github.com/syncrou","followers_url":"https://api.github.com/users/syncrou/followers","following_url":"https://api.github.com/users/syncrou/following{/other_user}","gists_url":"https://api.github.com/users/syncrou/gists{/gist_id}","starred_url":"https://api.github.com/users/syncrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncrou/subscriptions","organizations_url":"https://api.github.com/users/syncrou/orgs","repos_url":"https://api.github.com/users/syncrou/repos","events_url":"https://api.github.com/users/syncrou/events{/privacy}","received_events_url":"https://api.github.com/users/syncrou/received_events","type":"User","site_admin":false},"repo":{"id":43844593,"name":"manageiq","full_name":"syncrou/manageiq","owner":{"login":"syncrou","id":697347,"avatar_url":"https://avatars.githubusercontent.com/u/697347?v=3","gravatar_id":"","url":"https://api.github.com/users/syncrou","html_url":"https://github.com/syncrou","followers_url":"https://api.github.com/users/syncrou/followers","following_url":"https://api.github.com/users/syncrou/following{/other_user}","gists_url":"https://api.github.com/users/syncrou/gists{/gist_id}","starred_url":"https://api.github.com/users/syncrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncrou/subscriptions","organizations_url":"https://api.github.com/users/syncrou/orgs","repos_url":"https://api.github.com/users/syncrou/repos","events_url":"https://api.github.com/users/syncrou/events{/privacy}","received_events_url":"https://api.github.com/users/syncrou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syncrou/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/syncrou/manageiq","forks_url":"https://api.github.com/repos/syncrou/manageiq/forks","keys_url":"https://api.github.com/repos/syncrou/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncrou/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncrou/manageiq/teams","hooks_url":"https://api.github.com/repos/syncrou/manageiq/hooks","issue_events_url":"https://api.github.com/repos/syncrou/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/syncrou/manageiq/events","assignees_url":"https://api.github.com/repos/syncrou/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/syncrou/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/syncrou/manageiq/tags","blobs_url":"https://api.github.com/repos/syncrou/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncrou/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncrou/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncrou/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncrou/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/syncrou/manageiq/languages","stargazers_url":"https://api.github.com/repos/syncrou/manageiq/stargazers","contributors_url":"https://api.github.com/repos/syncrou/manageiq/contributors","subscribers_url":"https://api.github.com/repos/syncrou/manageiq/subscribers","subscription_url":"https://api.github.com/repos/syncrou/manageiq/subscription","commits_url":"https://api.github.com/repos/syncrou/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncrou/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncrou/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncrou/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/syncrou/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/syncrou/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncrou/manageiq/merges","archive_url":"https://api.github.com/repos/syncrou/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncrou/manageiq/downloads","issues_url":"https://api.github.com/repos/syncrou/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/syncrou/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/syncrou/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/syncrou/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncrou/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/syncrou/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/syncrou/manageiq/deployments","created_at":"2015-10-07T21:02:46Z","updated_at":"2016-01-14T14:23:25Z","pushed_at":"2016-03-28T20:43:00Z","git_url":"git://github.com/syncrou/manageiq.git","ssh_url":"git@github.com:syncrou/manageiq.git","clone_url":"https://github.com/syncrou/manageiq.git","svn_url":"https://github.com/syncrou/manageiq","homepage":"manageiq.org","size":111842,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"06e30505a007ca39c4bd943b8305c553636c7586","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-03-28T18:53:33Z","pushed_at":"2016-03-28T20:52:37Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":151194,"stargazers_count":245,"watchers_count":245,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":623,"forks":262,"open_issues":623,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7554"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7554"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7554/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7554/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/ef5c7921245d22905ae2f39ae88078152c916cee"}}}}