{"action":"closed","number":1048,"pull_request":{"url":"https://api.github.com/repos/dmlc/xgboost/pulls/1048","id":64245651,"html_url":"https://github.com/dmlc/xgboost/pull/1048","diff_url":"https://github.com/dmlc/xgboost/pull/1048.diff","patch_url":"https://github.com/dmlc/xgboost/pull/1048.patch","issue_url":"https://api.github.com/repos/dmlc/xgboost/issues/1048","number":1048,"state":"closed","locked":false,"title":"XGBoosterCreate api unified to use const DMatrixHandle[] argument","user":{"login":"WojciechMigda","id":3889167,"avatar_url":"https://avatars.githubusercontent.com/u/3889167?v=3","gravatar_id":"","url":"https://api.github.com/users/WojciechMigda","html_url":"https://github.com/WojciechMigda","followers_url":"https://api.github.com/users/WojciechMigda/followers","following_url":"https://api.github.com/users/WojciechMigda/following{/other_user}","gists_url":"https://api.github.com/users/WojciechMigda/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechMigda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechMigda/subscriptions","organizations_url":"https://api.github.com/users/WojciechMigda/orgs","repos_url":"https://api.github.com/users/WojciechMigda/repos","events_url":"https://api.github.com/users/WojciechMigda/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechMigda/received_events","type":"User","site_admin":false},"body":"first, there's a mismatch between declaration and definition (`void *` in the header), secondly, `DMatrixHandle` array can be `const`.","created_at":"2016-03-26T18:45:47Z","updated_at":"2016-03-31T03:56:10Z","closed_at":"2016-03-31T03:56:10Z","merged_at":"2016-03-31T03:56:10Z","merge_commit_sha":"babf1d78400ecddf4f3c13b32876d72724038904","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/xgboost/pulls/1048/commits","review_comments_url":"https://api.github.com/repos/dmlc/xgboost/pulls/1048/comments","review_comment_url":"https://api.github.com/repos/dmlc/xgboost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/xgboost/issues/1048/comments","statuses_url":"https://api.github.com/repos/dmlc/xgboost/statuses/30a306b974186935acc721c3acfe65b3ddf90dcd","head":{"label":"WojciechMigda:xgboostercreate-api-fix","ref":"xgboostercreate-api-fix","sha":"30a306b974186935acc721c3acfe65b3ddf90dcd","user":{"login":"WojciechMigda","id":3889167,"avatar_url":"https://avatars.githubusercontent.com/u/3889167?v=3","gravatar_id":"","url":"https://api.github.com/users/WojciechMigda","html_url":"https://github.com/WojciechMigda","followers_url":"https://api.github.com/users/WojciechMigda/followers","following_url":"https://api.github.com/users/WojciechMigda/following{/other_user}","gists_url":"https://api.github.com/users/WojciechMigda/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechMigda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechMigda/subscriptions","organizations_url":"https://api.github.com/users/WojciechMigda/orgs","repos_url":"https://api.github.com/users/WojciechMigda/repos","events_url":"https://api.github.com/users/WojciechMigda/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechMigda/received_events","type":"User","site_admin":false},"repo":{"id":54786525,"name":"xgboost","full_name":"WojciechMigda/xgboost","owner":{"login":"WojciechMigda","id":3889167,"avatar_url":"https://avatars.githubusercontent.com/u/3889167?v=3","gravatar_id":"","url":"https://api.github.com/users/WojciechMigda","html_url":"https://github.com/WojciechMigda","followers_url":"https://api.github.com/users/WojciechMigda/followers","following_url":"https://api.github.com/users/WojciechMigda/following{/other_user}","gists_url":"https://api.github.com/users/WojciechMigda/gists{/gist_id}","starred_url":"https://api.github.com/users/WojciechMigda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojciechMigda/subscriptions","organizations_url":"https://api.github.com/users/WojciechMigda/orgs","repos_url":"https://api.github.com/users/WojciechMigda/repos","events_url":"https://api.github.com/users/WojciechMigda/events{/privacy}","received_events_url":"https://api.github.com/users/WojciechMigda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WojciechMigda/xgboost","description":"Scalable, Portable and Distributed Gradient Boosting (GBDT, GBRT or GBM) Library,  for Python, R, Java, Scala, C++ and more. Runs on single machine, Hadoop, Spark, Flink and DataFlow","fork":true,"url":"https://api.github.com/repos/WojciechMigda/xgboost","forks_url":"https://api.github.com/repos/WojciechMigda/xgboost/forks","keys_url":"https://api.github.com/repos/WojciechMigda/xgboost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WojciechMigda/xgboost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WojciechMigda/xgboost/teams","hooks_url":"https://api.github.com/repos/WojciechMigda/xgboost/hooks","issue_events_url":"https://api.github.com/repos/WojciechMigda/xgboost/issues/events{/number}","events_url":"https://api.github.com/repos/WojciechMigda/xgboost/events","assignees_url":"https://api.github.com/repos/WojciechMigda/xgboost/assignees{/user}","branches_url":"https://api.github.com/repos/WojciechMigda/xgboost/branches{/branch}","tags_url":"https://api.github.com/repos/WojciechMigda/xgboost/tags","blobs_url":"https://api.github.com/repos/WojciechMigda/xgboost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WojciechMigda/xgboost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WojciechMigda/xgboost/git/refs{/sha}","trees_url":"https://api.github.com/repos/WojciechMigda/xgboost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WojciechMigda/xgboost/statuses/{sha}","languages_url":"https://api.github.com/repos/WojciechMigda/xgboost/languages","stargazers_url":"https://api.github.com/repos/WojciechMigda/xgboost/stargazers","contributors_url":"https://api.github.com/repos/WojciechMigda/xgboost/contributors","subscribers_url":"https://api.github.com/repos/WojciechMigda/xgboost/subscribers","subscription_url":"https://api.github.com/repos/WojciechMigda/xgboost/subscription","commits_url":"https://api.github.com/repos/WojciechMigda/xgboost/commits{/sha}","git_commits_url":"https://api.github.com/repos/WojciechMigda/xgboost/git/commits{/sha}","comments_url":"https://api.github.com/repos/WojciechMigda/xgboost/comments{/number}","issue_comment_url":"https://api.github.com/repos/WojciechMigda/xgboost/issues/comments{/number}","contents_url":"https://api.github.com/repos/WojciechMigda/xgboost/contents/{+path}","compare_url":"https://api.github.com/repos/WojciechMigda/xgboost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WojciechMigda/xgboost/merges","archive_url":"https://api.github.com/repos/WojciechMigda/xgboost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WojciechMigda/xgboost/downloads","issues_url":"https://api.github.com/repos/WojciechMigda/xgboost/issues{/number}","pulls_url":"https://api.github.com/repos/WojciechMigda/xgboost/pulls{/number}","milestones_url":"https://api.github.com/repos/WojciechMigda/xgboost/milestones{/number}","notifications_url":"https://api.github.com/repos/WojciechMigda/xgboost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WojciechMigda/xgboost/labels{/name}","releases_url":"https://api.github.com/repos/WojciechMigda/xgboost/releases{/id}","deployments_url":"https://api.github.com/repos/WojciechMigda/xgboost/deployments","created_at":"2016-03-26T15:53:56Z","updated_at":"2016-03-26T15:53:58Z","pushed_at":"2016-03-30T09:25:22Z","git_url":"git://github.com/WojciechMigda/xgboost.git","ssh_url":"git@github.com:WojciechMigda/xgboost.git","clone_url":"https://github.com/WojciechMigda/xgboost.git","svn_url":"https://github.com/WojciechMigda/xgboost","homepage":"","size":5400,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"tco-int"}},"base":{"label":"dmlc:master","ref":"master","sha":"6eda06256e9aa37e48d25eefa6c314111645b628","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":16587283,"name":"xgboost","full_name":"dmlc/xgboost","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/xgboost","description":"Scalable, Portable and Distributed Gradient Boosting (GBDT, GBRT or GBM) Library,  for Python, R, Java, Scala, C++ and more. Runs on single machine, Hadoop, Spark, Flink and DataFlow","fork":false,"url":"https://api.github.com/repos/dmlc/xgboost","forks_url":"https://api.github.com/repos/dmlc/xgboost/forks","keys_url":"https://api.github.com/repos/dmlc/xgboost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/xgboost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/xgboost/teams","hooks_url":"https://api.github.com/repos/dmlc/xgboost/hooks","issue_events_url":"https://api.github.com/repos/dmlc/xgboost/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/xgboost/events","assignees_url":"https://api.github.com/repos/dmlc/xgboost/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/xgboost/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/xgboost/tags","blobs_url":"https://api.github.com/repos/dmlc/xgboost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/xgboost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/xgboost/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/xgboost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/xgboost/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/xgboost/languages","stargazers_url":"https://api.github.com/repos/dmlc/xgboost/stargazers","contributors_url":"https://api.github.com/repos/dmlc/xgboost/contributors","subscribers_url":"https://api.github.com/repos/dmlc/xgboost/subscribers","subscription_url":"https://api.github.com/repos/dmlc/xgboost/subscription","commits_url":"https://api.github.com/repos/dmlc/xgboost/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/xgboost/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/xgboost/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/xgboost/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/xgboost/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/xgboost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/xgboost/merges","archive_url":"https://api.github.com/repos/dmlc/xgboost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/xgboost/downloads","issues_url":"https://api.github.com/repos/dmlc/xgboost/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/xgboost/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/xgboost/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/xgboost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/xgboost/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/xgboost/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/xgboost/deployments","created_at":"2014-02-06T17:28:03Z","updated_at":"2016-03-31T03:03:03Z","pushed_at":"2016-03-31T03:56:10Z","git_url":"git://github.com/dmlc/xgboost.git","ssh_url":"git@github.com:dmlc/xgboost.git","clone_url":"https://github.com/dmlc/xgboost.git","svn_url":"https://github.com/dmlc/xgboost","homepage":"","size":19824,"stargazers_count":2936,"watchers_count":2936,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1649,"mirror_url":null,"open_issues_count":122,"forks":1649,"open_issues":122,"watchers":2936,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/1048"},"html":{"href":"https://github.com/dmlc/xgboost/pull/1048"},"issue":{"href":"https://api.github.com/repos/dmlc/xgboost/issues/1048"},"comments":{"href":"https://api.github.com/repos/dmlc/xgboost/issues/1048/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/1048/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/xgboost/pulls/1048/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/xgboost/statuses/30a306b974186935acc721c3acfe65b3ddf90dcd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tqchen","id":2577440,"avatar_url":"https://avatars.githubusercontent.com/u/2577440?v=3","gravatar_id":"","url":"https://api.github.com/users/tqchen","html_url":"https://github.com/tqchen","followers_url":"https://api.github.com/users/tqchen/followers","following_url":"https://api.github.com/users/tqchen/following{/other_user}","gists_url":"https://api.github.com/users/tqchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tqchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tqchen/subscriptions","organizations_url":"https://api.github.com/users/tqchen/orgs","repos_url":"https://api.github.com/users/tqchen/repos","events_url":"https://api.github.com/users/tqchen/events{/privacy}","received_events_url":"https://api.github.com/users/tqchen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":2}}