{"action":"created","comment":{"url":"https://api.github.com/repos/automl/SMAC3/pulls/comments/81337678","pull_request_review_id":2324849,"id":81337678,"diff_hunk":"@@ -76,34 +77,34 @@ def test_init_EIPS_as_arguments(self):\n                 ['cost', 'runtime'], types)\n             eips = EIPS(umrfwi)\n             rh2EPM = RunHistory2EPM4EIPS(self.scenario, 2)\n-            smbo = SMBO(self.scenario, model=umrfwi, acquisition_function=eips,\n-                        runhistory2epm=rh2EPM)\n+            smbo = smbo = SMAC(self.scenario, model=umrfwi, acquisition_function=eips,","path":"test/test_smbo/test_smbo.py","position":null,"original_position":44,"commit_id":"f3277eda4d3f3a1c294fdecd6105f3b7e885096e","original_commit_id":"a084645656b45753b24b52af6977aff7542d023b","user":{"login":"mlindauer","id":5947529,"avatar_url":"https://avatars.githubusercontent.com/u/5947529?v=3","gravatar_id":"","url":"https://api.github.com/users/mlindauer","html_url":"https://github.com/mlindauer","followers_url":"https://api.github.com/users/mlindauer/followers","following_url":"https://api.github.com/users/mlindauer/following{/other_user}","gists_url":"https://api.github.com/users/mlindauer/gists{/gist_id}","starred_url":"https://api.github.com/users/mlindauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlindauer/subscriptions","organizations_url":"https://api.github.com/users/mlindauer/orgs","repos_url":"https://api.github.com/users/mlindauer/repos","events_url":"https://api.github.com/users/mlindauer/events{/privacy}","received_events_url":"https://api.github.com/users/mlindauer/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2016-09-30T13:25:18Z","updated_at":"2016-09-30T13:25:18Z","html_url":"https://github.com/automl/SMAC3/pull/60#discussion_r81337678","pull_request_url":"https://api.github.com/repos/automl/SMAC3/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/automl/SMAC3/pulls/comments/81337678"},"html":{"href":"https://github.com/automl/SMAC3/pull/60#discussion_r81337678"},"pull_request":{"href":"https://api.github.com/repos/automl/SMAC3/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/automl/SMAC3/pulls/60","id":86307543,"html_url":"https://github.com/automl/SMAC3/pull/60","diff_url":"https://github.com/automl/SMAC3/pull/60.diff","patch_url":"https://github.com/automl/SMAC3/pull/60.patch","issue_url":"https://api.github.com/repos/automl/SMAC3/issues/60","number":60,"state":"open","locked":false,"title":"Fix#55","user":{"login":"mlindauer","id":5947529,"avatar_url":"https://avatars.githubusercontent.com/u/5947529?v=3","gravatar_id":"","url":"https://api.github.com/users/mlindauer","html_url":"https://github.com/mlindauer","followers_url":"https://api.github.com/users/mlindauer/followers","following_url":"https://api.github.com/users/mlindauer/following{/other_user}","gists_url":"https://api.github.com/users/mlindauer/gists{/gist_id}","starred_url":"https://api.github.com/users/mlindauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlindauer/subscriptions","organizations_url":"https://api.github.com/users/mlindauer/orgs","repos_url":"https://api.github.com/users/mlindauer/repos","events_url":"https://api.github.com/users/mlindauer/events{/privacy}","received_events_url":"https://api.github.com/users/mlindauer/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nrestructured the SMAC code; the main changes is that I added facades to abstract away some complexity. Right now, I have two facades\r\n\r\n* standard SMAC over command line\r\n* a scipy similar facade (see examples/rosenbrock2.py for an example to use this new facade)\r\n\r\n@mfeurer and @KEggensperger : could you two please have a look at the changes and whether you agree on them.\r\n\r\nI'm aware that a lot of unit tests are probably broken right now.  I would like to have first some feedback on the changes before I start to fix the unit tests.\r\n\r\nBest,\r\nMarius","created_at":"2016-09-22T09:52:02Z","updated_at":"2016-09-30T13:25:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fbaa0ce7bcd3dacfb51ad8aee3ea8a3cf75e2a8","assignee":{"login":"mfeurer","id":5320498,"avatar_url":"https://avatars.githubusercontent.com/u/5320498?v=3","gravatar_id":"","url":"https://api.github.com/users/mfeurer","html_url":"https://github.com/mfeurer","followers_url":"https://api.github.com/users/mfeurer/followers","following_url":"https://api.github.com/users/mfeurer/following{/other_user}","gists_url":"https://api.github.com/users/mfeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/mfeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfeurer/subscriptions","organizations_url":"https://api.github.com/users/mfeurer/orgs","repos_url":"https://api.github.com/users/mfeurer/repos","events_url":"https://api.github.com/users/mfeurer/events{/privacy}","received_events_url":"https://api.github.com/users/mfeurer/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfeurer","id":5320498,"avatar_url":"https://avatars.githubusercontent.com/u/5320498?v=3","gravatar_id":"","url":"https://api.github.com/users/mfeurer","html_url":"https://github.com/mfeurer","followers_url":"https://api.github.com/users/mfeurer/followers","following_url":"https://api.github.com/users/mfeurer/following{/other_user}","gists_url":"https://api.github.com/users/mfeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/mfeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfeurer/subscriptions","organizations_url":"https://api.github.com/users/mfeurer/orgs","repos_url":"https://api.github.com/users/mfeurer/repos","events_url":"https://api.github.com/users/mfeurer/events{/privacy}","received_events_url":"https://api.github.com/users/mfeurer/received_events","type":"User","site_admin":false},{"login":"KEggensperger","id":5969254,"avatar_url":"https://avatars.githubusercontent.com/u/5969254?v=3","gravatar_id":"","url":"https://api.github.com/users/KEggensperger","html_url":"https://github.com/KEggensperger","followers_url":"https://api.github.com/users/KEggensperger/followers","following_url":"https://api.github.com/users/KEggensperger/following{/other_user}","gists_url":"https://api.github.com/users/KEggensperger/gists{/gist_id}","starred_url":"https://api.github.com/users/KEggensperger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KEggensperger/subscriptions","organizations_url":"https://api.github.com/users/KEggensperger/orgs","repos_url":"https://api.github.com/users/KEggensperger/repos","events_url":"https://api.github.com/users/KEggensperger/events{/privacy}","received_events_url":"https://api.github.com/users/KEggensperger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/automl/SMAC3/pulls/60/commits","review_comments_url":"https://api.github.com/repos/automl/SMAC3/pulls/60/comments","review_comment_url":"https://api.github.com/repos/automl/SMAC3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/automl/SMAC3/issues/60/comments","statuses_url":"https://api.github.com/repos/automl/SMAC3/statuses/f3277eda4d3f3a1c294fdecd6105f3b7e885096e","head":{"label":"automl:fix#55","ref":"fix#55","sha":"f3277eda4d3f3a1c294fdecd6105f3b7e885096e","user":{"login":"automl","id":6469053,"avatar_url":"https://avatars.githubusercontent.com/u/6469053?v=3","gravatar_id":"","url":"https://api.github.com/users/automl","html_url":"https://github.com/automl","followers_url":"https://api.github.com/users/automl/followers","following_url":"https://api.github.com/users/automl/following{/other_user}","gists_url":"https://api.github.com/users/automl/gists{/gist_id}","starred_url":"https://api.github.com/users/automl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/automl/subscriptions","organizations_url":"https://api.github.com/users/automl/orgs","repos_url":"https://api.github.com/users/automl/repos","events_url":"https://api.github.com/users/automl/events{/privacy}","received_events_url":"https://api.github.com/users/automl/received_events","type":"Organization","site_admin":false},"repo":{"id":65900469,"name":"SMAC3","full_name":"automl/SMAC3","owner":{"login":"automl","id":6469053,"avatar_url":"https://avatars.githubusercontent.com/u/6469053?v=3","gravatar_id":"","url":"https://api.github.com/users/automl","html_url":"https://github.com/automl","followers_url":"https://api.github.com/users/automl/followers","following_url":"https://api.github.com/users/automl/following{/other_user}","gists_url":"https://api.github.com/users/automl/gists{/gist_id}","starred_url":"https://api.github.com/users/automl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/automl/subscriptions","organizations_url":"https://api.github.com/users/automl/orgs","repos_url":"https://api.github.com/users/automl/repos","events_url":"https://api.github.com/users/automl/events{/privacy}","received_events_url":"https://api.github.com/users/automl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/automl/SMAC3","description":"Sequential Model-based Algorithm Configuration","fork":false,"url":"https://api.github.com/repos/automl/SMAC3","forks_url":"https://api.github.com/repos/automl/SMAC3/forks","keys_url":"https://api.github.com/repos/automl/SMAC3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/automl/SMAC3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/automl/SMAC3/teams","hooks_url":"https://api.github.com/repos/automl/SMAC3/hooks","issue_events_url":"https://api.github.com/repos/automl/SMAC3/issues/events{/number}","events_url":"https://api.github.com/repos/automl/SMAC3/events","assignees_url":"https://api.github.com/repos/automl/SMAC3/assignees{/user}","branches_url":"https://api.github.com/repos/automl/SMAC3/branches{/branch}","tags_url":"https://api.github.com/repos/automl/SMAC3/tags","blobs_url":"https://api.github.com/repos/automl/SMAC3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/automl/SMAC3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/automl/SMAC3/git/refs{/sha}","trees_url":"https://api.github.com/repos/automl/SMAC3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/automl/SMAC3/statuses/{sha}","languages_url":"https://api.github.com/repos/automl/SMAC3/languages","stargazers_url":"https://api.github.com/repos/automl/SMAC3/stargazers","contributors_url":"https://api.github.com/repos/automl/SMAC3/contributors","subscribers_url":"https://api.github.com/repos/automl/SMAC3/subscribers","subscription_url":"https://api.github.com/repos/automl/SMAC3/subscription","commits_url":"https://api.github.com/repos/automl/SMAC3/commits{/sha}","git_commits_url":"https://api.github.com/repos/automl/SMAC3/git/commits{/sha}","comments_url":"https://api.github.com/repos/automl/SMAC3/comments{/number}","issue_comment_url":"https://api.github.com/repos/automl/SMAC3/issues/comments{/number}","contents_url":"https://api.github.com/repos/automl/SMAC3/contents/{+path}","compare_url":"https://api.github.com/repos/automl/SMAC3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/automl/SMAC3/merges","archive_url":"https://api.github.com/repos/automl/SMAC3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/automl/SMAC3/downloads","issues_url":"https://api.github.com/repos/automl/SMAC3/issues{/number}","pulls_url":"https://api.github.com/repos/automl/SMAC3/pulls{/number}","milestones_url":"https://api.github.com/repos/automl/SMAC3/milestones{/number}","notifications_url":"https://api.github.com/repos/automl/SMAC3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/automl/SMAC3/labels{/name}","releases_url":"https://api.github.com/repos/automl/SMAC3/releases{/id}","deployments_url":"https://api.github.com/repos/automl/SMAC3/deployments","created_at":"2016-08-17T10:58:05Z","updated_at":"2016-09-26T20:21:18Z","pushed_at":"2016-09-30T13:25:16Z","git_url":"git://github.com/automl/SMAC3.git","ssh_url":"git@github.com:automl/SMAC3.git","clone_url":"https://github.com/automl/SMAC3.git","svn_url":"https://github.com/automl/SMAC3","homepage":"http://www.ml4aad.org/smac/","size":11860,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":6,"default_branch":"master"}},"base":{"label":"automl:development","ref":"development","sha":"475abe68dc2005670366c39693fbbd96c02bc663","user":{"login":"automl","id":6469053,"avatar_url":"https://avatars.githubusercontent.com/u/6469053?v=3","gravatar_id":"","url":"https://api.github.com/users/automl","html_url":"https://github.com/automl","followers_url":"https://api.github.com/users/automl/followers","following_url":"https://api.github.com/users/automl/following{/other_user}","gists_url":"https://api.github.com/users/automl/gists{/gist_id}","starred_url":"https://api.github.com/users/automl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/automl/subscriptions","organizations_url":"https://api.github.com/users/automl/orgs","repos_url":"https://api.github.com/users/automl/repos","events_url":"https://api.github.com/users/automl/events{/privacy}","received_events_url":"https://api.github.com/users/automl/received_events","type":"Organization","site_admin":false},"repo":{"id":65900469,"name":"SMAC3","full_name":"automl/SMAC3","owner":{"login":"automl","id":6469053,"avatar_url":"https://avatars.githubusercontent.com/u/6469053?v=3","gravatar_id":"","url":"https://api.github.com/users/automl","html_url":"https://github.com/automl","followers_url":"https://api.github.com/users/automl/followers","following_url":"https://api.github.com/users/automl/following{/other_user}","gists_url":"https://api.github.com/users/automl/gists{/gist_id}","starred_url":"https://api.github.com/users/automl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/automl/subscriptions","organizations_url":"https://api.github.com/users/automl/orgs","repos_url":"https://api.github.com/users/automl/repos","events_url":"https://api.github.com/users/automl/events{/privacy}","received_events_url":"https://api.github.com/users/automl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/automl/SMAC3","description":"Sequential Model-based Algorithm Configuration","fork":false,"url":"https://api.github.com/repos/automl/SMAC3","forks_url":"https://api.github.com/repos/automl/SMAC3/forks","keys_url":"https://api.github.com/repos/automl/SMAC3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/automl/SMAC3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/automl/SMAC3/teams","hooks_url":"https://api.github.com/repos/automl/SMAC3/hooks","issue_events_url":"https://api.github.com/repos/automl/SMAC3/issues/events{/number}","events_url":"https://api.github.com/repos/automl/SMAC3/events","assignees_url":"https://api.github.com/repos/automl/SMAC3/assignees{/user}","branches_url":"https://api.github.com/repos/automl/SMAC3/branches{/branch}","tags_url":"https://api.github.com/repos/automl/SMAC3/tags","blobs_url":"https://api.github.com/repos/automl/SMAC3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/automl/SMAC3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/automl/SMAC3/git/refs{/sha}","trees_url":"https://api.github.com/repos/automl/SMAC3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/automl/SMAC3/statuses/{sha}","languages_url":"https://api.github.com/repos/automl/SMAC3/languages","stargazers_url":"https://api.github.com/repos/automl/SMAC3/stargazers","contributors_url":"https://api.github.com/repos/automl/SMAC3/contributors","subscribers_url":"https://api.github.com/repos/automl/SMAC3/subscribers","subscription_url":"https://api.github.com/repos/automl/SMAC3/subscription","commits_url":"https://api.github.com/repos/automl/SMAC3/commits{/sha}","git_commits_url":"https://api.github.com/repos/automl/SMAC3/git/commits{/sha}","comments_url":"https://api.github.com/repos/automl/SMAC3/comments{/number}","issue_comment_url":"https://api.github.com/repos/automl/SMAC3/issues/comments{/number}","contents_url":"https://api.github.com/repos/automl/SMAC3/contents/{+path}","compare_url":"https://api.github.com/repos/automl/SMAC3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/automl/SMAC3/merges","archive_url":"https://api.github.com/repos/automl/SMAC3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/automl/SMAC3/downloads","issues_url":"https://api.github.com/repos/automl/SMAC3/issues{/number}","pulls_url":"https://api.github.com/repos/automl/SMAC3/pulls{/number}","milestones_url":"https://api.github.com/repos/automl/SMAC3/milestones{/number}","notifications_url":"https://api.github.com/repos/automl/SMAC3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/automl/SMAC3/labels{/name}","releases_url":"https://api.github.com/repos/automl/SMAC3/releases{/id}","deployments_url":"https://api.github.com/repos/automl/SMAC3/deployments","created_at":"2016-08-17T10:58:05Z","updated_at":"2016-09-26T20:21:18Z","pushed_at":"2016-09-30T13:25:16Z","git_url":"git://github.com/automl/SMAC3.git","ssh_url":"git@github.com:automl/SMAC3.git","clone_url":"https://github.com/automl/SMAC3.git","svn_url":"https://github.com/automl/SMAC3","homepage":"http://www.ml4aad.org/smac/","size":11860,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/automl/SMAC3/pulls/60"},"html":{"href":"https://github.com/automl/SMAC3/pull/60"},"issue":{"href":"https://api.github.com/repos/automl/SMAC3/issues/60"},"comments":{"href":"https://api.github.com/repos/automl/SMAC3/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/automl/SMAC3/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/automl/SMAC3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/automl/SMAC3/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/automl/SMAC3/statuses/f3277eda4d3f3a1c294fdecd6105f3b7e885096e"}}}}
{"actor":{"display_login":"mlindauer"}}