{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/bro/broctl/pulls/4","id":64173423,"html_url":"https://github.com/bro/broctl/pull/4","diff_url":"https://github.com/bro/broctl/pull/4.diff","patch_url":"https://github.com/bro/broctl/pull/4.patch","issue_url":"https://api.github.com/repos/bro/broctl/issues/4","number":4,"state":"closed","locked":false,"title":"Fix leaking resources from never closing out the Broccoli connection","user":{"login":"aeppert","id":80466,"avatar_url":"https://avatars.githubusercontent.com/u/80466?v=3","gravatar_id":"","url":"https://api.github.com/users/aeppert","html_url":"https://github.com/aeppert","followers_url":"https://api.github.com/users/aeppert/followers","following_url":"https://api.github.com/users/aeppert/following{/other_user}","gists_url":"https://api.github.com/users/aeppert/gists{/gist_id}","starred_url":"https://api.github.com/users/aeppert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeppert/subscriptions","organizations_url":"https://api.github.com/users/aeppert/orgs","repos_url":"https://api.github.com/users/aeppert/repos","events_url":"https://api.github.com/users/aeppert/events{/privacy}","received_events_url":"https://api.github.com/users/aeppert/received_events","type":"User","site_admin":false},"body":"connDelete() is never called in broctl, which is generally not an issue if it is being used via the command line. However, given the Python interface for calling into broctl, if a service is written around broctl and any parallel events are sent (peerstatus, netstats, etc.) then a TCP connection will be maintained given a connDelete() is not called. After a fairly certain interval, resources become an issue and things fail.","created_at":"2016-03-25T15:29:56Z","updated_at":"2016-03-31T20:15:23Z","closed_at":"2016-03-31T20:15:23Z","merged_at":"2016-03-31T20:15:23Z","merge_commit_sha":"86ee3b8dc23853b5dcb6a2d9ace52facaeaac41c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bro/broctl/pulls/4/commits","review_comments_url":"https://api.github.com/repos/bro/broctl/pulls/4/comments","review_comment_url":"https://api.github.com/repos/bro/broctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bro/broctl/issues/4/comments","statuses_url":"https://api.github.com/repos/bro/broctl/statuses/86ee3b8dc23853b5dcb6a2d9ace52facaeaac41c","head":{"label":"aeppert:patch-1","ref":"patch-1","sha":"86ee3b8dc23853b5dcb6a2d9ace52facaeaac41c","user":{"login":"aeppert","id":80466,"avatar_url":"https://avatars.githubusercontent.com/u/80466?v=3","gravatar_id":"","url":"https://api.github.com/users/aeppert","html_url":"https://github.com/aeppert","followers_url":"https://api.github.com/users/aeppert/followers","following_url":"https://api.github.com/users/aeppert/following{/other_user}","gists_url":"https://api.github.com/users/aeppert/gists{/gist_id}","starred_url":"https://api.github.com/users/aeppert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeppert/subscriptions","organizations_url":"https://api.github.com/users/aeppert/orgs","repos_url":"https://api.github.com/users/aeppert/repos","events_url":"https://api.github.com/users/aeppert/events{/privacy}","received_events_url":"https://api.github.com/users/aeppert/received_events","type":"User","site_admin":false},"repo":{"id":48753239,"name":"broctl","full_name":"aeppert/broctl","owner":{"login":"aeppert","id":80466,"avatar_url":"https://avatars.githubusercontent.com/u/80466?v=3","gravatar_id":"","url":"https://api.github.com/users/aeppert","html_url":"https://github.com/aeppert","followers_url":"https://api.github.com/users/aeppert/followers","following_url":"https://api.github.com/users/aeppert/following{/other_user}","gists_url":"https://api.github.com/users/aeppert/gists{/gist_id}","starred_url":"https://api.github.com/users/aeppert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeppert/subscriptions","organizations_url":"https://api.github.com/users/aeppert/orgs","repos_url":"https://api.github.com/users/aeppert/repos","events_url":"https://api.github.com/users/aeppert/events{/privacy}","received_events_url":"https://api.github.com/users/aeppert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aeppert/broctl","description":"Official mirror of git.bro.org/broctl.git","fork":true,"url":"https://api.github.com/repos/aeppert/broctl","forks_url":"https://api.github.com/repos/aeppert/broctl/forks","keys_url":"https://api.github.com/repos/aeppert/broctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeppert/broctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeppert/broctl/teams","hooks_url":"https://api.github.com/repos/aeppert/broctl/hooks","issue_events_url":"https://api.github.com/repos/aeppert/broctl/issues/events{/number}","events_url":"https://api.github.com/repos/aeppert/broctl/events","assignees_url":"https://api.github.com/repos/aeppert/broctl/assignees{/user}","branches_url":"https://api.github.com/repos/aeppert/broctl/branches{/branch}","tags_url":"https://api.github.com/repos/aeppert/broctl/tags","blobs_url":"https://api.github.com/repos/aeppert/broctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeppert/broctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeppert/broctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeppert/broctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeppert/broctl/statuses/{sha}","languages_url":"https://api.github.com/repos/aeppert/broctl/languages","stargazers_url":"https://api.github.com/repos/aeppert/broctl/stargazers","contributors_url":"https://api.github.com/repos/aeppert/broctl/contributors","subscribers_url":"https://api.github.com/repos/aeppert/broctl/subscribers","subscription_url":"https://api.github.com/repos/aeppert/broctl/subscription","commits_url":"https://api.github.com/repos/aeppert/broctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeppert/broctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeppert/broctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeppert/broctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeppert/broctl/contents/{+path}","compare_url":"https://api.github.com/repos/aeppert/broctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeppert/broctl/merges","archive_url":"https://api.github.com/repos/aeppert/broctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeppert/broctl/downloads","issues_url":"https://api.github.com/repos/aeppert/broctl/issues{/number}","pulls_url":"https://api.github.com/repos/aeppert/broctl/pulls{/number}","milestones_url":"https://api.github.com/repos/aeppert/broctl/milestones{/number}","notifications_url":"https://api.github.com/repos/aeppert/broctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeppert/broctl/labels{/name}","releases_url":"https://api.github.com/repos/aeppert/broctl/releases{/id}","deployments_url":"https://api.github.com/repos/aeppert/broctl/deployments","created_at":"2015-12-29T15:17:47Z","updated_at":"2015-12-29T15:17:48Z","pushed_at":"2016-03-25T15:29:48Z","git_url":"git://github.com/aeppert/broctl.git","ssh_url":"git@github.com:aeppert/broctl.git","clone_url":"https://github.com/aeppert/broctl.git","svn_url":"https://github.com/aeppert/broctl","homepage":"http://www.bro.org","size":2735,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bro:master","ref":"master","sha":"583f3a3ff1847cf96a87f865d5cf0f36fae9dd67","user":{"login":"bro","id":1194067,"avatar_url":"https://avatars.githubusercontent.com/u/1194067?v=3","gravatar_id":"","url":"https://api.github.com/users/bro","html_url":"https://github.com/bro","followers_url":"https://api.github.com/users/bro/followers","following_url":"https://api.github.com/users/bro/following{/other_user}","gists_url":"https://api.github.com/users/bro/gists{/gist_id}","starred_url":"https://api.github.com/users/bro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bro/subscriptions","organizations_url":"https://api.github.com/users/bro/orgs","repos_url":"https://api.github.com/users/bro/repos","events_url":"https://api.github.com/users/bro/events{/privacy}","received_events_url":"https://api.github.com/users/bro/received_events","type":"Organization","site_admin":false},"repo":{"id":4932340,"name":"broctl","full_name":"bro/broctl","owner":{"login":"bro","id":1194067,"avatar_url":"https://avatars.githubusercontent.com/u/1194067?v=3","gravatar_id":"","url":"https://api.github.com/users/bro","html_url":"https://github.com/bro","followers_url":"https://api.github.com/users/bro/followers","following_url":"https://api.github.com/users/bro/following{/other_user}","gists_url":"https://api.github.com/users/bro/gists{/gist_id}","starred_url":"https://api.github.com/users/bro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bro/subscriptions","organizations_url":"https://api.github.com/users/bro/orgs","repos_url":"https://api.github.com/users/bro/repos","events_url":"https://api.github.com/users/bro/events{/privacy}","received_events_url":"https://api.github.com/users/bro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bro/broctl","description":"Official mirror of git.bro.org/broctl.git","fork":false,"url":"https://api.github.com/repos/bro/broctl","forks_url":"https://api.github.com/repos/bro/broctl/forks","keys_url":"https://api.github.com/repos/bro/broctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bro/broctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bro/broctl/teams","hooks_url":"https://api.github.com/repos/bro/broctl/hooks","issue_events_url":"https://api.github.com/repos/bro/broctl/issues/events{/number}","events_url":"https://api.github.com/repos/bro/broctl/events","assignees_url":"https://api.github.com/repos/bro/broctl/assignees{/user}","branches_url":"https://api.github.com/repos/bro/broctl/branches{/branch}","tags_url":"https://api.github.com/repos/bro/broctl/tags","blobs_url":"https://api.github.com/repos/bro/broctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bro/broctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bro/broctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bro/broctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bro/broctl/statuses/{sha}","languages_url":"https://api.github.com/repos/bro/broctl/languages","stargazers_url":"https://api.github.com/repos/bro/broctl/stargazers","contributors_url":"https://api.github.com/repos/bro/broctl/contributors","subscribers_url":"https://api.github.com/repos/bro/broctl/subscribers","subscription_url":"https://api.github.com/repos/bro/broctl/subscription","commits_url":"https://api.github.com/repos/bro/broctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bro/broctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bro/broctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bro/broctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bro/broctl/contents/{+path}","compare_url":"https://api.github.com/repos/bro/broctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bro/broctl/merges","archive_url":"https://api.github.com/repos/bro/broctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bro/broctl/downloads","issues_url":"https://api.github.com/repos/bro/broctl/issues{/number}","pulls_url":"https://api.github.com/repos/bro/broctl/pulls{/number}","milestones_url":"https://api.github.com/repos/bro/broctl/milestones{/number}","notifications_url":"https://api.github.com/repos/bro/broctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bro/broctl/labels{/name}","releases_url":"https://api.github.com/repos/bro/broctl/releases{/id}","deployments_url":"https://api.github.com/repos/bro/broctl/deployments","created_at":"2012-07-06T23:21:47Z","updated_at":"2016-01-11T21:28:17Z","pushed_at":"2016-03-31T20:15:23Z","git_url":"git://github.com/bro/broctl.git","ssh_url":"git@github.com:bro/broctl.git","clone_url":"https://github.com/bro/broctl.git","svn_url":"https://github.com/bro/broctl","homepage":"http://www.bro.org","size":2806,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":0,"forks":8,"open_issues":0,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bro/broctl/pulls/4"},"html":{"href":"https://github.com/bro/broctl/pull/4"},"issue":{"href":"https://api.github.com/repos/bro/broctl/issues/4"},"comments":{"href":"https://api.github.com/repos/bro/broctl/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/bro/broctl/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/bro/broctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bro/broctl/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/bro/broctl/statuses/86ee3b8dc23853b5dcb6a2d9ace52facaeaac41c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bro-bot","id":1934173,"avatar_url":"https://avatars.githubusercontent.com/u/1934173?v=3","gravatar_id":"","url":"https://api.github.com/users/bro-bot","html_url":"https://github.com/bro-bot","followers_url":"https://api.github.com/users/bro-bot/followers","following_url":"https://api.github.com/users/bro-bot/following{/other_user}","gists_url":"https://api.github.com/users/bro-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/bro-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bro-bot/subscriptions","organizations_url":"https://api.github.com/users/bro-bot/orgs","repos_url":"https://api.github.com/users/bro-bot/repos","events_url":"https://api.github.com/users/bro-bot/events{/privacy}","received_events_url":"https://api.github.com/users/bro-bot/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}