{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/90761941","pull_request_review_id":11281194,"id":90761941,"diff_hunk":"@@ -116,13 +113,12 @@ function run_test_2() {\n \n \n function run_test_3() {\n-  var file, options;\n \n   const data = '\\u2026\\u2026';    // 3 bytes * 2 = 6 bytes in UTF-8\n \n-  options = { start: 10,\n+  const options = { start: 10,\n               flags: 'r+' };","path":"test/parallel/test-file-write-stream3.js","position":84,"original_position":84,"commit_id":"eccb0aae6bf19762e854fbc2777b9b990e2af096","original_commit_id":"eccb0aae6bf19762e854fbc2777b9b990e2af096","user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"body":"Can you line this up so that start and flags line up like they did before (ie need to indent flags to align with new position of start)","created_at":"2016-12-03T18:15:22Z","updated_at":"2016-12-03T18:15:53Z","html_url":"https://github.com/nodejs/node/pull/10035#discussion_r90761941","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/10035","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/90761941"},"html":{"href":"https://github.com/nodejs/node/pull/10035#discussion_r90761941"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/10035"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10035","id":96137996,"html_url":"https://github.com/nodejs/node/pull/10035","diff_url":"https://github.com/nodejs/node/pull/10035.diff","patch_url":"https://github.com/nodejs/node/pull/10035.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10035","number":10035,"state":"open","locked":false,"title":"test: test-file-write-stream3.js refactor","user":{"login":"flekmatik","id":4591928,"avatar_url":"https://avatars.githubusercontent.com/u/4591928?v=3","gravatar_id":"","url":"https://api.github.com/users/flekmatik","html_url":"https://github.com/flekmatik","followers_url":"https://api.github.com/users/flekmatik/followers","following_url":"https://api.github.com/users/flekmatik/following{/other_user}","gists_url":"https://api.github.com/users/flekmatik/gists{/gist_id}","starred_url":"https://api.github.com/users/flekmatik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flekmatik/subscriptions","organizations_url":"https://api.github.com/users/flekmatik/orgs","repos_url":"https://api.github.com/users/flekmatik/repos","events_url":"https://api.github.com/users/flekmatik/events{/privacy}","received_events_url":"https://api.github.com/users/flekmatik/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nTest refactor only\r\n\r\n##### Description of change\r\nUsing const and strictEqual in test/parallel/test-file-write-stream3.js","created_at":"2016-12-01T17:52:36Z","updated_at":"2016-12-03T18:15:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3919d74fc7b53e8d40f1869932e2536353a3b006","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10035/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10035/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10035/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/eccb0aae6bf19762e854fbc2777b9b990e2af096","head":{"label":"flekmatik:c-a-l_file-write-stream3","ref":"c-a-l_file-write-stream3","sha":"eccb0aae6bf19762e854fbc2777b9b990e2af096","user":{"login":"flekmatik","id":4591928,"avatar_url":"https://avatars.githubusercontent.com/u/4591928?v=3","gravatar_id":"","url":"https://api.github.com/users/flekmatik","html_url":"https://github.com/flekmatik","followers_url":"https://api.github.com/users/flekmatik/followers","following_url":"https://api.github.com/users/flekmatik/following{/other_user}","gists_url":"https://api.github.com/users/flekmatik/gists{/gist_id}","starred_url":"https://api.github.com/users/flekmatik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flekmatik/subscriptions","organizations_url":"https://api.github.com/users/flekmatik/orgs","repos_url":"https://api.github.com/users/flekmatik/repos","events_url":"https://api.github.com/users/flekmatik/events{/privacy}","received_events_url":"https://api.github.com/users/flekmatik/received_events","type":"User","site_admin":false},"repo":{"id":75305480,"name":"node","full_name":"flekmatik/node","owner":{"login":"flekmatik","id":4591928,"avatar_url":"https://avatars.githubusercontent.com/u/4591928?v=3","gravatar_id":"","url":"https://api.github.com/users/flekmatik","html_url":"https://github.com/flekmatik","followers_url":"https://api.github.com/users/flekmatik/followers","following_url":"https://api.github.com/users/flekmatik/following{/other_user}","gists_url":"https://api.github.com/users/flekmatik/gists{/gist_id}","starred_url":"https://api.github.com/users/flekmatik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flekmatik/subscriptions","organizations_url":"https://api.github.com/users/flekmatik/orgs","repos_url":"https://api.github.com/users/flekmatik/repos","events_url":"https://api.github.com/users/flekmatik/events{/privacy}","received_events_url":"https://api.github.com/users/flekmatik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flekmatik/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/flekmatik/node","forks_url":"https://api.github.com/repos/flekmatik/node/forks","keys_url":"https://api.github.com/repos/flekmatik/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flekmatik/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flekmatik/node/teams","hooks_url":"https://api.github.com/repos/flekmatik/node/hooks","issue_events_url":"https://api.github.com/repos/flekmatik/node/issues/events{/number}","events_url":"https://api.github.com/repos/flekmatik/node/events","assignees_url":"https://api.github.com/repos/flekmatik/node/assignees{/user}","branches_url":"https://api.github.com/repos/flekmatik/node/branches{/branch}","tags_url":"https://api.github.com/repos/flekmatik/node/tags","blobs_url":"https://api.github.com/repos/flekmatik/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flekmatik/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flekmatik/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/flekmatik/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flekmatik/node/statuses/{sha}","languages_url":"https://api.github.com/repos/flekmatik/node/languages","stargazers_url":"https://api.github.com/repos/flekmatik/node/stargazers","contributors_url":"https://api.github.com/repos/flekmatik/node/contributors","subscribers_url":"https://api.github.com/repos/flekmatik/node/subscribers","subscription_url":"https://api.github.com/repos/flekmatik/node/subscription","commits_url":"https://api.github.com/repos/flekmatik/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/flekmatik/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/flekmatik/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/flekmatik/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/flekmatik/node/contents/{+path}","compare_url":"https://api.github.com/repos/flekmatik/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flekmatik/node/merges","archive_url":"https://api.github.com/repos/flekmatik/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flekmatik/node/downloads","issues_url":"https://api.github.com/repos/flekmatik/node/issues{/number}","pulls_url":"https://api.github.com/repos/flekmatik/node/pulls{/number}","milestones_url":"https://api.github.com/repos/flekmatik/node/milestones{/number}","notifications_url":"https://api.github.com/repos/flekmatik/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flekmatik/node/labels{/name}","releases_url":"https://api.github.com/repos/flekmatik/node/releases{/id}","deployments_url":"https://api.github.com/repos/flekmatik/node/deployments","created_at":"2016-12-01T15:25:29Z","updated_at":"2016-12-01T15:25:58Z","pushed_at":"2016-12-01T17:19:42Z","git_url":"git://github.com/flekmatik/node.git","ssh_url":"git@github.com:flekmatik/node.git","clone_url":"https://github.com/flekmatik/node.git","svn_url":"https://github.com/flekmatik/node","homepage":"https://nodejs.org","size":247149,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"cf719152b01a68bc65f80842799b4c6be0299d78","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-03T17:20:05Z","pushed_at":"2016-12-03T18:00:36Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":374122,"stargazers_count":29526,"watchers_count":29526,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5261,"mirror_url":null,"open_issues_count":1164,"forks":5261,"open_issues":1164,"watchers":29526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10035"},"html":{"href":"https://github.com/nodejs/node/pull/10035"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10035"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10035/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10035/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10035/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/eccb0aae6bf19762e854fbc2777b9b990e2af096"}}}}
{"actor":{"display_login":"mhdawson"}}