{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/92915986","pull_request_review_id":13441196,"id":92915986,"diff_hunk":"@@ -1943,9 +1945,15 @@ namespace OutputReportTabular {\n \t\t\t\t\tdisplayEconomicResultSummary = true;\n \t\t\t\t\tWriteTabularFiles = true;\n \t\t\t\t\tnameFound = true;\n-\t\t\t\t} else if ( SameString( AlphArray( iReport ), \"EnergyMeters\" ) ) {\n+\t\t\t\t} else if (SameString(AlphArray(iReport), \"EnergyMeters\")) {\n \t\t\t\t\tWriteTabularFiles = true;\n \t\t\t\t\tnameFound = true;\n+\t\t\t\t} else if (SameString(AlphArray(iReport), \"EIO\")) {","path":"src/EnergyPlus/OutputReportTabular.cc","position":24,"original_position":24,"commit_id":"1b9d26fb57fa0e9be0d555a37cf127611d9ca8a9","original_commit_id":"1b9d26fb57fa0e9be0d555a37cf127611d9ca8a9","user":{"login":"mbadams5","id":2001544,"avatar_url":"https://avatars.githubusercontent.com/u/2001544?v=3","gravatar_id":"","url":"https://api.github.com/users/mbadams5","html_url":"https://github.com/mbadams5","followers_url":"https://api.github.com/users/mbadams5/followers","following_url":"https://api.github.com/users/mbadams5/following{/other_user}","gists_url":"https://api.github.com/users/mbadams5/gists{/gist_id}","starred_url":"https://api.github.com/users/mbadams5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbadams5/subscriptions","organizations_url":"https://api.github.com/users/mbadams5/orgs","repos_url":"https://api.github.com/users/mbadams5/repos","events_url":"https://api.github.com/users/mbadams5/events{/privacy}","received_events_url":"https://api.github.com/users/mbadams5/received_events","type":"User","site_admin":false},"body":"Is \"EIO\" supposed to be in the list of choices in the IDD?","created_at":"2016-12-17T05:36:12Z","updated_at":"2016-12-17T05:50:12Z","html_url":"https://github.com/NREL/EnergyPlus/pull/5928#discussion_r92915986","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/92915986"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5928#discussion_r92915986"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928","id":92019428,"html_url":"https://github.com/NREL/EnergyPlus/pull/5928","diff_url":"https://github.com/NREL/EnergyPlus/pull/5928.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5928.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5928","number":5928,"state":"open","locked":false,"title":"Add EIO tables to new Tabular summary report","user":{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},"body":"In process of addressing #5272 decided to create a tabular report (usually a HTML file) that contains all the content of the EIO file. This would allow the SQL file to contain all the data from the EIO file. \r\n\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n\r\n","created_at":"2016-11-02T17:36:57Z","updated_at":"2016-12-17T05:50:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c70e1ea8b7eb8d0ba8b1aa79838ccdf7e22c379","assignee":{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},"assignees":[{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5928/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/1b9d26fb57fa0e9be0d555a37cf127611d9ca8a9","head":{"label":"NREL:AddEio2Table","ref":"AddEio2Table","sha":"1b9d26fb57fa0e9be0d555a37cf127611d9ca8a9","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-12-12T14:21:42Z","pushed_at":"2016-12-17T01:19:54Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":291308,"stargazers_count":135,"watchers_count":135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":457,"forks":92,"open_issues":457,"watchers":135,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"13dda486859602d126825012be0914d2847d0053","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-12-12T14:21:42Z","pushed_at":"2016-12-17T01:19:54Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":291308,"stargazers_count":135,"watchers_count":135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":457,"forks":92,"open_issues":457,"watchers":135,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5928"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5928"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5928/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5928/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/1b9d26fb57fa0e9be0d555a37cf127611d9ca8a9"}}}}
{"actor":{"display_login":"mbadams5"}}