{"action":"created","comment":{"url":"https://api.github.com/repos/openstax/accounts/pulls/comments/73716431","id":73716431,"diff_hunk":"@@ -141,6 +141,15 @@ def with_error_pages\n   end\n end\n \n+def with_show_exceptions_true","path":"spec/support/feature_helpers.rb","position":4,"original_position":4,"commit_id":"c6dc8403bd06a14dfd9d9d1889d83d5e0bc2bbc9","original_commit_id":"c6dc8403bd06a14dfd9d9d1889d83d5e0bc2bbc9","user":{"login":"Dantemss","id":1017808,"avatar_url":"https://avatars.githubusercontent.com/u/1017808?v=3","gravatar_id":"","url":"https://api.github.com/users/Dantemss","html_url":"https://github.com/Dantemss","followers_url":"https://api.github.com/users/Dantemss/followers","following_url":"https://api.github.com/users/Dantemss/following{/other_user}","gists_url":"https://api.github.com/users/Dantemss/gists{/gist_id}","starred_url":"https://api.github.com/users/Dantemss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dantemss/subscriptions","organizations_url":"https://api.github.com/users/Dantemss/orgs","repos_url":"https://api.github.com/users/Dantemss/repos","events_url":"https://api.github.com/users/Dantemss/events{/privacy}","received_events_url":"https://api.github.com/users/Dantemss/received_events","type":"User","site_admin":false},"body":"Unused code?","created_at":"2016-08-05T15:58:42Z","updated_at":"2016-08-05T15:58:42Z","html_url":"https://github.com/openstax/accounts/pull/335#discussion_r73716431","pull_request_url":"https://api.github.com/repos/openstax/accounts/pulls/335","_links":{"self":{"href":"https://api.github.com/repos/openstax/accounts/pulls/comments/73716431"},"html":{"href":"https://github.com/openstax/accounts/pull/335#discussion_r73716431"},"pull_request":{"href":"https://api.github.com/repos/openstax/accounts/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/openstax/accounts/pulls/335","id":79762077,"html_url":"https://github.com/openstax/accounts/pull/335","diff_url":"https://github.com/openstax/accounts/pull/335.diff","patch_url":"https://github.com/openstax/accounts/pull/335.patch","issue_url":"https://api.github.com/repos/openstax/accounts/issues/335","number":335,"state":"open","locked":false,"title":"Bug fix in CreateUser routine and better test coverage","user":{"login":"BryanEliDimas","id":6620941,"avatar_url":"https://avatars.githubusercontent.com/u/6620941?v=3","gravatar_id":"","url":"https://api.github.com/users/BryanEliDimas","html_url":"https://github.com/BryanEliDimas","followers_url":"https://api.github.com/users/BryanEliDimas/followers","following_url":"https://api.github.com/users/BryanEliDimas/following{/other_user}","gists_url":"https://api.github.com/users/BryanEliDimas/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanEliDimas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanEliDimas/subscriptions","organizations_url":"https://api.github.com/users/BryanEliDimas/orgs","repos_url":"https://api.github.com/users/BryanEliDimas/repos","events_url":"https://api.github.com/users/BryanEliDimas/events{/privacy}","received_events_url":"https://api.github.com/users/BryanEliDimas/received_events","type":"User","site_admin":false},"body":"This PR is an attempt make better specs and to make sure that routine CreateUser does what it's supposed to do.\r\n\r\nPreviously:\r\n- CreateUser routine would still be able to return errors even when `ensure_no_errors` was `true`. \r\n- There was no test coverage to make sure that non-admins cannot access admin features.\r\n\r\nNow:\r\n- When `ensure_no_errors` is `true` in routine CreateUser, an exception is returned instead when validations fail and we cannot generate or determine a valid input (as we currently do for `username` and `first_name` and `last_name`.\r\n- There is better test coverage in `spec/features/log_out_inactive_admins.rb`\r\n- To do the fixes above, I was forced to change the settings for `rescue_from` which are in an initializer. Previous behavior was that it would raise exception when `Rails.application.config.consider_all_requests_local` was true. Now, it raises exception only in development environment `Rails.env.development?`","created_at":"2016-08-02T16:01:36Z","updated_at":"2016-08-05T15:58:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb31e58bb9b0e738b0cf1958f3deb1ac5dddcc1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openstax/accounts/pulls/335/commits","review_comments_url":"https://api.github.com/repos/openstax/accounts/pulls/335/comments","review_comment_url":"https://api.github.com/repos/openstax/accounts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstax/accounts/issues/335/comments","statuses_url":"https://api.github.com/repos/openstax/accounts/statuses/c6dc8403bd06a14dfd9d9d1889d83d5e0bc2bbc9","head":{"label":"openstax:bryans_small_improvements_to_my_first_PRs","ref":"bryans_small_improvements_to_my_first_PRs","sha":"c6dc8403bd06a14dfd9d9d1889d83d5e0bc2bbc9","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":11300066,"name":"accounts","full_name":"openstax/accounts","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/accounts","description":"OpenStax centralized authentication and accounts service","fork":false,"url":"https://api.github.com/repos/openstax/accounts","forks_url":"https://api.github.com/repos/openstax/accounts/forks","keys_url":"https://api.github.com/repos/openstax/accounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/accounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/accounts/teams","hooks_url":"https://api.github.com/repos/openstax/accounts/hooks","issue_events_url":"https://api.github.com/repos/openstax/accounts/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/accounts/events","assignees_url":"https://api.github.com/repos/openstax/accounts/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/accounts/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/accounts/tags","blobs_url":"https://api.github.com/repos/openstax/accounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/accounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/accounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/accounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/accounts/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/accounts/languages","stargazers_url":"https://api.github.com/repos/openstax/accounts/stargazers","contributors_url":"https://api.github.com/repos/openstax/accounts/contributors","subscribers_url":"https://api.github.com/repos/openstax/accounts/subscribers","subscription_url":"https://api.github.com/repos/openstax/accounts/subscription","commits_url":"https://api.github.com/repos/openstax/accounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/accounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/accounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/accounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/accounts/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/accounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/accounts/merges","archive_url":"https://api.github.com/repos/openstax/accounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/accounts/downloads","issues_url":"https://api.github.com/repos/openstax/accounts/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/accounts/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/accounts/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/accounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/accounts/labels{/name}","releases_url":"https://api.github.com/repos/openstax/accounts/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/accounts/deployments","created_at":"2013-07-10T02:36:07Z","updated_at":"2016-04-09T11:24:58Z","pushed_at":"2016-08-05T15:26:14Z","git_url":"git://github.com/openstax/accounts.git","ssh_url":"git@github.com:openstax/accounts.git","clone_url":"https://github.com/openstax/accounts.git","svn_url":"https://github.com/openstax/accounts","homepage":"","size":2125,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":29,"forks":5,"open_issues":29,"watchers":5,"default_branch":"master"}},"base":{"label":"openstax:master","ref":"master","sha":"ce1b67157cbf49b4125ce221b4991b430c9c6504","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":11300066,"name":"accounts","full_name":"openstax/accounts","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/accounts","description":"OpenStax centralized authentication and accounts service","fork":false,"url":"https://api.github.com/repos/openstax/accounts","forks_url":"https://api.github.com/repos/openstax/accounts/forks","keys_url":"https://api.github.com/repos/openstax/accounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/accounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/accounts/teams","hooks_url":"https://api.github.com/repos/openstax/accounts/hooks","issue_events_url":"https://api.github.com/repos/openstax/accounts/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/accounts/events","assignees_url":"https://api.github.com/repos/openstax/accounts/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/accounts/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/accounts/tags","blobs_url":"https://api.github.com/repos/openstax/accounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/accounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/accounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/accounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/accounts/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/accounts/languages","stargazers_url":"https://api.github.com/repos/openstax/accounts/stargazers","contributors_url":"https://api.github.com/repos/openstax/accounts/contributors","subscribers_url":"https://api.github.com/repos/openstax/accounts/subscribers","subscription_url":"https://api.github.com/repos/openstax/accounts/subscription","commits_url":"https://api.github.com/repos/openstax/accounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/accounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/accounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/accounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/accounts/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/accounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/accounts/merges","archive_url":"https://api.github.com/repos/openstax/accounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/accounts/downloads","issues_url":"https://api.github.com/repos/openstax/accounts/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/accounts/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/accounts/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/accounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/accounts/labels{/name}","releases_url":"https://api.github.com/repos/openstax/accounts/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/accounts/deployments","created_at":"2013-07-10T02:36:07Z","updated_at":"2016-04-09T11:24:58Z","pushed_at":"2016-08-05T15:26:14Z","git_url":"git://github.com/openstax/accounts.git","ssh_url":"git@github.com:openstax/accounts.git","clone_url":"https://github.com/openstax/accounts.git","svn_url":"https://github.com/openstax/accounts","homepage":"","size":2125,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":29,"forks":5,"open_issues":29,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstax/accounts/pulls/335"},"html":{"href":"https://github.com/openstax/accounts/pull/335"},"issue":{"href":"https://api.github.com/repos/openstax/accounts/issues/335"},"comments":{"href":"https://api.github.com/repos/openstax/accounts/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/openstax/accounts/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/openstax/accounts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstax/accounts/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/openstax/accounts/statuses/c6dc8403bd06a14dfd9d9d1889d83d5e0bc2bbc9"}}}}
{"actor":{"display_login":"Dantemss"}}