{"action":"created","comment":{"url":"https://api.github.com/repos/joblib/joblib/pulls/comments/50373138","id":50373138,"diff_hunk":"@@ -329,44 +338,49 @@ def load_build(self):\n         dispatch[pickle.BUILD] = load_build\n \n \n-class ZipNumpyUnpickler(NumpyUnpickler):\n-    \"\"\"A subclass of our Unpickler to unpickle on the fly from\n-    compressed storage.\"\"\"\n-\n-    def __init__(self, filename, file_handle):\n-        NumpyUnpickler.__init__(self, filename,\n-                                file_handle,\n-                                mmap_mode=None)\n-\n-    def _open_pickle(self, file_handle):\n-        return BytesIO(read_zfile(file_handle))\n+def _dump(value, f, protocol):","path":"joblib/numpy_pickle.py","position":594,"original_position":594,"commit_id":"0ebacbd333311f1e2118fa09465aa7dbfaab76c1","original_commit_id":"cb40533655c00991dd3a28757041a436b37c31b7","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"body":"Doesn't seem that necessary to have a helper function that can be written on one-line.","created_at":"2016-01-21T08:47:30Z","updated_at":"2016-01-21T08:47:30Z","html_url":"https://github.com/joblib/joblib/pull/260#discussion_r50373138","pull_request_url":"https://api.github.com/repos/joblib/joblib/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments/50373138"},"html":{"href":"https://github.com/joblib/joblib/pull/260#discussion_r50373138"},"pull_request":{"href":"https://api.github.com/repos/joblib/joblib/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/joblib/joblib/pulls/260","id":48600298,"html_url":"https://github.com/joblib/joblib/pull/260","diff_url":"https://github.com/joblib/joblib/pull/260.diff","patch_url":"https://github.com/joblib/joblib/pull/260.patch","issue_url":"https://api.github.com/repos/joblib/joblib/issues/260","number":260,"state":"open","locked":false,"title":"[MRG] Numpy pickle to single file","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars.githubusercontent.com/u/1375137?v=3","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"I gave a try to gzip.GzipFile to dump numpy object. This PR is a POC of such usage and also contains a fairly large refactoring of numpy_pickle.\r\n\r\nIn terms of performance, I reused the bench script from #255. With Numpy 1.10, there's no memory copy but the read/write is slightly slower (31s dump, 5.5s read). It also makes the code more 'readable'.\r\nI had to comment out the test regarding the compatibility between pickles.\r\n\r\nWaiting for the CI's","created_at":"2015-10-23T16:22:17Z","updated_at":"2016-01-21T08:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5feabfff8aea64a1b6cc2fcfa03fbdede8413d84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joblib/joblib/pulls/260/commits","review_comments_url":"https://api.github.com/repos/joblib/joblib/pulls/260/comments","review_comment_url":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joblib/joblib/issues/260/comments","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/0ebacbd333311f1e2118fa09465aa7dbfaab76c1","head":{"label":"aabadie:gzip_pickling","ref":"gzip_pickling","sha":"0ebacbd333311f1e2118fa09465aa7dbfaab76c1","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars.githubusercontent.com/u/1375137?v=3","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"repo":{"id":41858733,"name":"joblib","full_name":"aabadie/joblib","owner":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars.githubusercontent.com/u/1375137?v=3","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aabadie/joblib","description":"Python function as pipeline jobs.","fork":true,"url":"https://api.github.com/repos/aabadie/joblib","forks_url":"https://api.github.com/repos/aabadie/joblib/forks","keys_url":"https://api.github.com/repos/aabadie/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aabadie/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aabadie/joblib/teams","hooks_url":"https://api.github.com/repos/aabadie/joblib/hooks","issue_events_url":"https://api.github.com/repos/aabadie/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/aabadie/joblib/events","assignees_url":"https://api.github.com/repos/aabadie/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/aabadie/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/aabadie/joblib/tags","blobs_url":"https://api.github.com/repos/aabadie/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aabadie/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aabadie/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/aabadie/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aabadie/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/aabadie/joblib/languages","stargazers_url":"https://api.github.com/repos/aabadie/joblib/stargazers","contributors_url":"https://api.github.com/repos/aabadie/joblib/contributors","subscribers_url":"https://api.github.com/repos/aabadie/joblib/subscribers","subscription_url":"https://api.github.com/repos/aabadie/joblib/subscription","commits_url":"https://api.github.com/repos/aabadie/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/aabadie/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/aabadie/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/aabadie/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/aabadie/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/aabadie/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aabadie/joblib/merges","archive_url":"https://api.github.com/repos/aabadie/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aabadie/joblib/downloads","issues_url":"https://api.github.com/repos/aabadie/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/aabadie/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/aabadie/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/aabadie/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aabadie/joblib/labels{/name}","releases_url":"https://api.github.com/repos/aabadie/joblib/releases{/id}","created_at":"2015-09-03T12:33:21Z","updated_at":"2016-01-14T12:17:38Z","pushed_at":"2016-01-21T08:31:17Z","git_url":"git://github.com/aabadie/joblib.git","ssh_url":"git@github.com:aabadie/joblib.git","clone_url":"https://github.com/aabadie/joblib.git","svn_url":"https://github.com/aabadie/joblib","homepage":"http://packages.python.org/joblib/","size":2493,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"joblib:master","ref":"master","sha":"b72877b349e5edd0985584e09d4cc2a0d227fae6","user":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"repo":{"id":654608,"name":"joblib","full_name":"joblib/joblib","owner":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joblib/joblib","description":"Python function as pipeline jobs.","fork":false,"url":"https://api.github.com/repos/joblib/joblib","forks_url":"https://api.github.com/repos/joblib/joblib/forks","keys_url":"https://api.github.com/repos/joblib/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joblib/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joblib/joblib/teams","hooks_url":"https://api.github.com/repos/joblib/joblib/hooks","issue_events_url":"https://api.github.com/repos/joblib/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/joblib/joblib/events","assignees_url":"https://api.github.com/repos/joblib/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/joblib/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/joblib/joblib/tags","blobs_url":"https://api.github.com/repos/joblib/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joblib/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joblib/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/joblib/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/joblib/joblib/languages","stargazers_url":"https://api.github.com/repos/joblib/joblib/stargazers","contributors_url":"https://api.github.com/repos/joblib/joblib/contributors","subscribers_url":"https://api.github.com/repos/joblib/joblib/subscribers","subscription_url":"https://api.github.com/repos/joblib/joblib/subscription","commits_url":"https://api.github.com/repos/joblib/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/joblib/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/joblib/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/joblib/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/joblib/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/joblib/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joblib/joblib/merges","archive_url":"https://api.github.com/repos/joblib/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joblib/joblib/downloads","issues_url":"https://api.github.com/repos/joblib/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/joblib/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/joblib/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/joblib/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joblib/joblib/labels{/name}","releases_url":"https://api.github.com/repos/joblib/joblib/releases{/id}","created_at":"2010-05-07T06:48:26Z","updated_at":"2016-01-20T13:42:50Z","pushed_at":"2016-01-21T08:31:17Z","git_url":"git://github.com/joblib/joblib.git","ssh_url":"git@github.com:joblib/joblib.git","clone_url":"https://github.com/joblib/joblib.git","svn_url":"https://github.com/joblib/joblib","homepage":"http://packages.python.org/joblib/","size":3557,"stargazers_count":616,"watchers_count":616,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":81,"forks":101,"open_issues":81,"watchers":616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/260"},"html":{"href":"https://github.com/joblib/joblib/pull/260"},"issue":{"href":"https://api.github.com/repos/joblib/joblib/issues/260"},"comments":{"href":"https://api.github.com/repos/joblib/joblib/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/joblib/joblib/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joblib/joblib/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/joblib/joblib/statuses/0ebacbd333311f1e2118fa09465aa7dbfaab76c1"}}}}