{"action":"created","issue":{"url":"https://api.github.com/repos/yahoo/elide/issues/266","repository_url":"https://api.github.com/repos/yahoo/elide","labels_url":"https://api.github.com/repos/yahoo/elide/issues/266/labels{/name}","comments_url":"https://api.github.com/repos/yahoo/elide/issues/266/comments","events_url":"https://api.github.com/repos/yahoo/elide/issues/266/events","html_url":"https://github.com/yahoo/elide/pull/266","id":161111077,"number":266,"title":"Add support for page totals and JSON-API page meta data","user":{"login":"mjvanleeuwen","id":8966901,"avatar_url":"https://avatars.githubusercontent.com/u/8966901?v=3","gravatar_id":"","url":"https://api.github.com/users/mjvanleeuwen","html_url":"https://github.com/mjvanleeuwen","followers_url":"https://api.github.com/users/mjvanleeuwen/followers","following_url":"https://api.github.com/users/mjvanleeuwen/following{/other_user}","gists_url":"https://api.github.com/users/mjvanleeuwen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjvanleeuwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjvanleeuwen/subscriptions","organizations_url":"https://api.github.com/users/mjvanleeuwen/orgs","repos_url":"https://api.github.com/users/mjvanleeuwen/repos","events_url":"https://api.github.com/users/mjvanleeuwen/events{/privacy}","received_events_url":"https://api.github.com/users/mjvanleeuwen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-20T03:33:02Z","updated_at":"2016-07-12T15:59:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yahoo/elide/pulls/266","html_url":"https://github.com/yahoo/elide/pull/266","diff_url":"https://github.com/yahoo/elide/pull/266.diff","patch_url":"https://github.com/yahoo/elide/pull/266.patch"},"body":"For enhancement proposal https://github.com/yahoo/elide/issues/264.\r\n\r\nThe page meta data will be returned in the JSON-API response if the page size/limit/number/offset query parameters have been specified.\r\n\r\nIf the query parameter \"page[totals]=true\" is also specified, the page totals will be determined and included in the returned page meta data."},"comment":{"url":"https://api.github.com/repos/yahoo/elide/issues/comments/232094296","html_url":"https://github.com/yahoo/elide/pull/266#issuecomment-232094296","issue_url":"https://api.github.com/repos/yahoo/elide/issues/266","id":232094296,"user":{"login":"DeathByTape","id":732305,"avatar_url":"https://avatars.githubusercontent.com/u/732305?v=3","gravatar_id":"","url":"https://api.github.com/users/DeathByTape","html_url":"https://github.com/DeathByTape","followers_url":"https://api.github.com/users/DeathByTape/followers","following_url":"https://api.github.com/users/DeathByTape/following{/other_user}","gists_url":"https://api.github.com/users/DeathByTape/gists{/gist_id}","starred_url":"https://api.github.com/users/DeathByTape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeathByTape/subscriptions","organizations_url":"https://api.github.com/users/DeathByTape/orgs","repos_url":"https://api.github.com/users/DeathByTape/repos","events_url":"https://api.github.com/users/DeathByTape/events{/privacy}","received_events_url":"https://api.github.com/users/DeathByTape/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T15:59:54Z","updated_at":"2016-07-12T15:59:54Z","body":"The squash is almost perfect, but you merged back into this branch. I would recommend replacing this branch with just those three commits. One easy way to do this is:\r\n\r\n```\r\n$ git checkout YOUR_SQUASHED_BRANCH_WITH_ONLY_THOSE_THREE_COMMITS\r\n$ git branch -D add_page_totals_and_meta_page # This will delete your local branch\r\n$ git checkout -b add_page_totals_and_meta_page # This will create a new branch from the one you're currently on and call it 'add_page_totals_and_meta_page'\r\n$ git push <YOUR_REMOTE> add_page_totals_and_meta_page --force\r\n```\r\n\r\nThis should replace this branch and this PR will only have those 3 commits! :)\r\n\r\nOnce that is done, I don't see any blocks. @clayreimann does this looks good to you too?"}}
{"actor":{"display_login":"DeathByTape"}}