{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/79306728","id":79306728,"diff_hunk":"@@ -95,6 +95,16 @@ for eltya in (Float32, Float64, Complex64, Complex128, Int)\n         @test v == f[:vectors]\n     end\n end\n+\n+#test eigenvalue computations with NaNs\n+for eltya in (NaN16, NaN32, NaN)\n+    @test_throws(ArgumentError, eig(fill(eltya, 1, 1)))\n+    @test_throws(ArgumentError, eig(fill(eltya, 2, 2)))\n+    test_matrix = rand(3,3)","path":"test/linalg/eigen.jl","position":9,"original_position":9,"commit_id":"76c40e848d454ee7f31224bc56fdf15214139c97","original_commit_id":"76c40e848d454ee7f31224bc56fdf15214139c97","user":{"login":"mcognetta","id":6856636,"avatar_url":"https://avatars.githubusercontent.com/u/6856636?v=3","gravatar_id":"","url":"https://api.github.com/users/mcognetta","html_url":"https://github.com/mcognetta","followers_url":"https://api.github.com/users/mcognetta/followers","following_url":"https://api.github.com/users/mcognetta/following{/other_user}","gists_url":"https://api.github.com/users/mcognetta/gists{/gist_id}","starred_url":"https://api.github.com/users/mcognetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcognetta/subscriptions","organizations_url":"https://api.github.com/users/mcognetta/orgs","repos_url":"https://api.github.com/users/mcognetta/repos","events_url":"https://api.github.com/users/mcognetta/events{/privacy}","received_events_url":"https://api.github.com/users/mcognetta/received_events","type":"User","site_admin":false},"body":"Yes, I did not consider this behavior. Thanks.","created_at":"2016-09-18T14:16:29Z","updated_at":"2016-09-18T14:16:29Z","html_url":"https://github.com/JuliaLang/julia/pull/18526#discussion_r79306728","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18526","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/79306728"},"html":{"href":"https://github.com/JuliaLang/julia/pull/18526#discussion_r79306728"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18526"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/18526","id":85440387,"html_url":"https://github.com/JuliaLang/julia/pull/18526","diff_url":"https://github.com/JuliaLang/julia/pull/18526.diff","patch_url":"https://github.com/JuliaLang/julia/pull/18526.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/18526","number":18526,"state":"open","locked":false,"title":"18267 1x1 NaN matrix eigenvalue","user":{"login":"mcognetta","id":6856636,"avatar_url":"https://avatars.githubusercontent.com/u/6856636?v=3","gravatar_id":"","url":"https://api.github.com/users/mcognetta","html_url":"https://github.com/mcognetta","followers_url":"https://api.github.com/users/mcognetta/followers","following_url":"https://api.github.com/users/mcognetta/following{/other_user}","gists_url":"https://api.github.com/users/mcognetta/gists{/gist_id}","starred_url":"https://api.github.com/users/mcognetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcognetta/subscriptions","organizations_url":"https://api.github.com/users/mcognetta/orgs","repos_url":"https://api.github.com/users/mcognetta/repos","events_url":"https://api.github.com/users/mcognetta/events{/privacy}","received_events_url":"https://api.github.com/users/mcognetta/received_events","type":"User","site_admin":false},"body":"Added a check when computing the eigenvalue of a matrix for if the matrix is a 1x1 matrix with NaN elements. Previously this case incorrectly returned a value (not NaN) while the 2x2 and larger dimensional cases threw an error.\r\n\r\nThis is my first contribution to Julia, so any help or feedback is greatly appreciated.\r\n\r\nhttps://github.com/JuliaLang/julia/issues/18267","created_at":"2016-09-15T16:51:21Z","updated_at":"2016-09-18T14:16:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a72b022601d9d7b030d79f28642c7ce1b108c38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18526/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18526/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/18526/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/76c40e848d454ee7f31224bc56fdf15214139c97","head":{"label":"mcognetta:18267_null_matrix_eigenvalue","ref":"18267_null_matrix_eigenvalue","sha":"76c40e848d454ee7f31224bc56fdf15214139c97","user":{"login":"mcognetta","id":6856636,"avatar_url":"https://avatars.githubusercontent.com/u/6856636?v=3","gravatar_id":"","url":"https://api.github.com/users/mcognetta","html_url":"https://github.com/mcognetta","followers_url":"https://api.github.com/users/mcognetta/followers","following_url":"https://api.github.com/users/mcognetta/following{/other_user}","gists_url":"https://api.github.com/users/mcognetta/gists{/gist_id}","starred_url":"https://api.github.com/users/mcognetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcognetta/subscriptions","organizations_url":"https://api.github.com/users/mcognetta/orgs","repos_url":"https://api.github.com/users/mcognetta/repos","events_url":"https://api.github.com/users/mcognetta/events{/privacy}","received_events_url":"https://api.github.com/users/mcognetta/received_events","type":"User","site_admin":false},"repo":{"id":68284276,"name":"julia","full_name":"mcognetta/julia","owner":{"login":"mcognetta","id":6856636,"avatar_url":"https://avatars.githubusercontent.com/u/6856636?v=3","gravatar_id":"","url":"https://api.github.com/users/mcognetta","html_url":"https://github.com/mcognetta","followers_url":"https://api.github.com/users/mcognetta/followers","following_url":"https://api.github.com/users/mcognetta/following{/other_user}","gists_url":"https://api.github.com/users/mcognetta/gists{/gist_id}","starred_url":"https://api.github.com/users/mcognetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcognetta/subscriptions","organizations_url":"https://api.github.com/users/mcognetta/orgs","repos_url":"https://api.github.com/users/mcognetta/repos","events_url":"https://api.github.com/users/mcognetta/events{/privacy}","received_events_url":"https://api.github.com/users/mcognetta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcognetta/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/mcognetta/julia","forks_url":"https://api.github.com/repos/mcognetta/julia/forks","keys_url":"https://api.github.com/repos/mcognetta/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcognetta/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcognetta/julia/teams","hooks_url":"https://api.github.com/repos/mcognetta/julia/hooks","issue_events_url":"https://api.github.com/repos/mcognetta/julia/issues/events{/number}","events_url":"https://api.github.com/repos/mcognetta/julia/events","assignees_url":"https://api.github.com/repos/mcognetta/julia/assignees{/user}","branches_url":"https://api.github.com/repos/mcognetta/julia/branches{/branch}","tags_url":"https://api.github.com/repos/mcognetta/julia/tags","blobs_url":"https://api.github.com/repos/mcognetta/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcognetta/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcognetta/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcognetta/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcognetta/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/mcognetta/julia/languages","stargazers_url":"https://api.github.com/repos/mcognetta/julia/stargazers","contributors_url":"https://api.github.com/repos/mcognetta/julia/contributors","subscribers_url":"https://api.github.com/repos/mcognetta/julia/subscribers","subscription_url":"https://api.github.com/repos/mcognetta/julia/subscription","commits_url":"https://api.github.com/repos/mcognetta/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcognetta/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcognetta/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcognetta/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcognetta/julia/contents/{+path}","compare_url":"https://api.github.com/repos/mcognetta/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcognetta/julia/merges","archive_url":"https://api.github.com/repos/mcognetta/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcognetta/julia/downloads","issues_url":"https://api.github.com/repos/mcognetta/julia/issues{/number}","pulls_url":"https://api.github.com/repos/mcognetta/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/mcognetta/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/mcognetta/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcognetta/julia/labels{/name}","releases_url":"https://api.github.com/repos/mcognetta/julia/releases{/id}","deployments_url":"https://api.github.com/repos/mcognetta/julia/deployments","created_at":"2016-09-15T10:13:57Z","updated_at":"2016-09-15T10:14:06Z","pushed_at":"2016-09-18T13:57:55Z","git_url":"git://github.com/mcognetta/julia.git","ssh_url":"git@github.com:mcognetta/julia.git","clone_url":"https://github.com/mcognetta/julia.git","svn_url":"https://github.com/mcognetta/julia","homepage":"http://julialang.org/","size":98554,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"d52a24750631c048d26c7ac762ed1327bac67d8d","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-09-18T02:50:40Z","pushed_at":"2016-09-18T13:57:56Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":422345,"stargazers_count":7512,"watchers_count":7512,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1757,"mirror_url":null,"open_issues_count":1984,"forks":1757,"open_issues":1984,"watchers":7512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18526"},"html":{"href":"https://github.com/JuliaLang/julia/pull/18526"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/18526"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/18526/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18526/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18526/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/76c40e848d454ee7f31224bc56fdf15214139c97"}}}}
{"actor":{"display_login":"mcognetta"}}