{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/72867036","id":72867036,"diff_hunk":"@@ -189,429 +148,256 @@ set \"__TestRootDir=%__RootBinDir%\\tests\"\n set \"__TestBinDir=%__TestRootDir%\\%__BuildOS%.%__BuildArch%.%__BuildType%\"\n set \"__TestIntermediatesDir=%__RootBinDir%\\tests\\obj\\%__BuildOS%.%__BuildArch%.%__BuildType%\"\n set \"__CrossComponentBinDir=%__BinDir%\"\n+set \"__CrossCompIntermediatesDir=%__IntermediatesDir%\\crossgen\"\n+\n if NOT \"%__CrossArch%\" == \"\" set __CrossComponentBinDir=%__CrossComponentBinDir%\\%__CrossArch%\n+set \"__CrossGenCoreLibLog=%__LogsDir%\\CrossgenCoreLib_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n+set \"__CrossgenExe=%__CrossComponentBinDir%\\crossgen.exe\"\n \n :: Generate path to be set for CMAKE_INSTALL_PREFIX to contain forward slash\n set \"__CMakeBinDir=%__BinDir%\"\n set \"__CMakeBinDir=%__CMakeBinDir:\\=/%\"\n \n-:: Configure environment if we are doing a clean build.\n-if not defined __CleanBuild goto SkipCleanBuild\n-echo %__MsgPrefix%Doing a clean build\n-\n-:: MSBuild projects would need a rebuild\n-set __msbuildCleanBuildArgs=/t:rebuild\n-\n-:: Cleanup the previous output for the selected configuration\n-if exist \"%__BinDir%\"               rd /s /q \"%__BinDir%\"\n-if exist \"%__IntermediatesDir%\"     rd /s /q \"%__IntermediatesDir%\"\n-if exist \"%__LogsDir%\"              del /f /q \"%__LogsDir%\\*_%__BuildOS%__%__BuildArch%__%__BuildType%.*\"\n-if exist \"%__ProjectDir%\\Tools\"     rd /s /q \"%__ProjectDir%\\Tools\"\n-\n-:SkipCleanBuild\n-\n if not exist \"%__BinDir%\"           md \"%__BinDir%\"\n if not exist \"%__IntermediatesDir%\" md \"%__IntermediatesDir%\"\n if not exist \"%__LogsDir%\"          md \"%__LogsDir%\"\n \n-:: CMake isn't a requirement when building CoreLib only\n-if defined __CoreLibOnly goto CheckVS\n-\n-echo %__MsgPrefix%Checking prerequisites\n-\n-:: Validate that PowerShell is accessibile.\n-for %%X in (powershell.exe) do (set __PSDir=%%~$PATH:X)\n-if not defined __PSDir goto :NoPS\n+echo %__MsgPrefix%Commencing CoreCLR Repo build\n \n-:: Validate Powershell version\n-set \"PS_VERSION_LOG=%__LogsDir%\\ps-version.log\"\n-powershell -NoProfile -ExecutionPolicy unrestricted -Command \"$PSVersionTable.PSVersion.Major\" > %PS_VERSION_LOG%\n-set /P PS_VERSION=< %PS_VERSION_LOG%\n-if %PS_VERSION% LEQ 2 (\n-  goto :OldPS\n-)\n+:: Set the remaining variables based upon the determined build configuration\n \n+echo %__MsgPrefix%Checking prerequisites\n :: Eval the output from probe-win1.ps1\n for /f \"delims=\" %%a in ('powershell -NoProfile -ExecutionPolicy RemoteSigned \"& \"\"%__SourceDir%\\pal\\tools\\probe-win.ps1\"\"\"') do %%a\n \n-:CheckVS\n-\n-set __VSProductVersion=\n-if /i \"%__VSVersion%\" == \"vs2015\" set __VSProductVersion=140\n-\n-:: Check presence of VS\n-if not defined VS%__VSProductVersion%COMNTOOLS goto NoVS\n-\n-set __VSToolsRoot=!VS%__VSProductVersion%COMNTOOLS!\n-if %__VSToolsRoot:~-1%==\\ set \"__VSToolsRoot=%__VSToolsRoot:~0,-1%\"\n-\n-:: Does VS really exist?\n-if not exist \"%__VSToolsRoot%\\..\\IDE\\devenv.exe\"      goto NoVS\n-if not exist \"%__VSToolsRoot%\\..\\..\\VC\\vcvarsall.bat\" goto NoVS\n-if not exist \"%__VSToolsRoot%\\VsDevCmd.bat\"           goto NoVS\n-\n-:MSBuild14\n-set _msbuildexe=\"%ProgramFiles(x86)%\\MSBuild\\14.0\\Bin\\MSBuild.exe\"\n-:CheckMSBuild14\n-if not exist %_msbuildexe% set _msbuildexe=\"%ProgramFiles%\\MSBuild\\14.0\\Bin\\MSBuild.exe\"\n-if not exist %_msbuildexe% echo %__MsgPrefix%Error: Could not find MSBuild.exe.  Please see https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/developer-guide.md for build instructions. && exit /b 1\n-\n-:: Note: We've disabled node reuse because it causes file locking issues.\n-::       The issue is that we extend the build with our own targets which\n-::       means that that rebuilding cannot successfully delete the task\n-::       assembly. \n-set __msbuildCommonArgs=/nologo /nodeReuse:false %__msbuildCleanBuildArgs% %unprocessedBuildArgs% %__OfficialBuildIdArg%\n-\n-if not defined __BuildSequential (\n-    set __msbuildCommonArgs=%__msbuildCommonArgs% /maxcpucount\n-)\n-if defined __SkipRestore (\n-    set __msbuildCommonArgs=%__msbuildCommonArgs% /p:RestoreDuringBuild=false\n-) \n-\n-\n REM =========================================================================================\n REM ===\n-REM === Restore Build Tools\n+REM === Start the build steps\n REM ===\n REM =========================================================================================\n-call %__ThisScriptPath%init-tools.cmd  \n-if errorlevel 1 (\n-  echo ERROR: Could not restore build tools.\n-  exit /b 1\n-)\n+\n+@call %~dp0run.cmd build -generateHeaderWindows -NativeVersionHeaderFile=\"%__RootBinDir%\\obj\\_version.h\" %__RunArgs% %__UnprocessedBuildArgs% \n \n REM =========================================================================================\n REM ===\n-REM === Start the build steps\n+REM === Build the CLR VM\n REM ===\n REM =========================================================================================\n \n-:: Generate _version.h\n-if exist \"%__RootBinDir%\\obj\\_version.h\" del \"%__RootBinDir%\\obj\\_version.h\"\n-%_msbuildexe% \"%__ProjectFilesDir%\\build.proj\" /t:GenerateVersionHeader /v:minimal /p:NativeVersionHeaderFile=\"%__RootBinDir%\\obj\\_version.h\" /p:GenerateVersionHeader=true %__OfficialBuildIdArg%\n-if defined __CoreLibOnly goto PerformCoreLibBuild\n+if %__BuildNative% EQU 1 ( \n+    echo %__MsgPrefix%Commencing build of native components for %__BuildOS%.%__BuildArch%.%__BuildType%\n \n-if defined __SkipNativeBuild (\n-    echo %__MsgPrefix%Skipping native components build\n-    goto SkipNativeBuild\n-)\n-\n-echo %__MsgPrefix%Commencing build of native components for %__BuildOS%.%__BuildArch%.%__BuildType%\n-\n-REM Use setlocal to restrict environment changes form vcvarsall.bat and more to just this native components build section.\n-setlocal EnableDelayedExpansion EnableExtensions\n+\tset nativePlatfromArgs=-platform=%__BuildArch%\n+    if /i \"%__BuildArch%\" == \"arm64\" ( set nativePlatfromArgs=-useEnv )\n \n-if /i \"%__BuildArch%\" == \"arm64\" ( \n-rem arm64 builds currently use private toolset which has not been released yet\n-REM TODO, remove once the toolset is open.\n-call :PrivateToolSet\n+    set __MsbuildLog=/flp:Verbosity=normal;LogFile=\"%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n+    set __MsbuildWrn=/flp1:WarningsOnly;LogFile=\"%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"\n+    set __MsbuildErr=/flp2:ErrorsOnly;LogFile=\"%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.err\"\n \n-goto GenVSSolution\n-)\n+    if /i \"%__BuildArch%\" == \"arm64\" ( \n+        rem arm64 builds currently use private toolset which has not been released yet\n+        REM TODO, remove once the toolset is open.\n+        call :PrivateToolSet\n+        goto GenVSSolution\n+    )\n \n-:: Set the environment for the native build\n-set __VCBuildArch=x86_amd64\n-if /i \"%__BuildArch%\" == \"x86\" (set __VCBuildArch=x86)\n-echo %__MsgPrefix%Using environment: \"%__VSToolsRoot%\\..\\..\\VC\\vcvarsall.bat\" %__VCBuildArch%\n-call                                 \"%__VSToolsRoot%\\..\\..\\VC\\vcvarsall.bat\" %__VCBuildArch%\n-@if defined __echo @echo on\n-\n-if not defined VSINSTALLDIR (\n-    echo %__MsgPrefix%Error: VSINSTALLDIR variable not defined.\n-    exit /b 1\n-)\n-if not exist \"%VSINSTALLDIR%DIA SDK\" goto NoDIA\n+    :: Set the environment for the native build\n+    set __VCBuildArch=x86_amd64\n+    if /i \"%__BuildArch%\" == \"x86\" ( set __VCBuildArch=x86 )\n+    echo %__MsgPrefix%Using environment: \"%__VSToolsRoot%\\..\\..\\VC\\vcvarsall.bat\" !__VCBuildArch!\n+    call                                 \"%__VSToolsRoot%\\..\\..\\VC\\vcvarsall.bat\" !__VCBuildArch!\n+\t@if defined __echo @echo on\n \n+    if not defined VSINSTALLDIR (\n+        echo %__MsgPrefix%Error: VSINSTALLDIR variable not defined.\n+        exit /b 1\n+    )\n+    if not exist \"!VSINSTALLDIR!DIA SDK\" goto NoDIA\n :GenVSSolution\n+    if defined __SkipConfigure goto SkipConfigure\n \n-if defined __SkipConfigure goto SkipConfigure\n-\n-echo %__MsgPrefix%Regenerating the Visual Studio solution\n-\n-pushd \"%__IntermediatesDir%\"\n-call \"%__SourceDir%\\pal\\tools\\gen-buildsys-win.bat\" \"%__ProjectDir%\" %__VSVersion% %__BuildArch% %__BuildJit32%\n-@if defined __echo @echo on\n-popd\n+    echo %__MsgPrefix%Regenerating the Visual Studio solution\n \n+    pushd \"%__IntermediatesDir%\"\n+    call \"%__SourceDir%\\pal\\tools\\gen-buildsys-win.bat\" \"%__ProjectDir%\" %__VSVersion% %__BuildArch% %__BuildJit32%\n+\t@if defined __echo @echo on\n+    popd\n :SkipConfigure\n+    if defined __ConfigureOnly goto SkipNativeBuild\n \n-if not exist \"%__IntermediatesDir%\\install.vcxproj\" (\n-    echo %__MsgPrefix%Error: failed to generate native component build project!\n-    exit /b 1\n-)\n-\n-REM =========================================================================================\n-REM ===\n-REM === Build the CLR VM\n-REM ===\n-REM =========================================================================================\n-\n-if defined __ConfigureOnly goto SkipNativeBuild\n-\n-echo %__MsgPrefix%Invoking msbuild\n-\n-set \"__BuildLog=%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n-set \"__BuildWrn=%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"\n-set \"__BuildErr=%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.err\"\n-set __msbuildLogArgs=^\n-/fileloggerparameters:Verbosity=normal;LogFile=\"%__BuildLog%\" ^\n-/fileloggerparameters1:WarningsOnly;LogFile=\"%__BuildWrn%\" ^\n-/fileloggerparameters2:ErrorsOnly;LogFile=\"%__BuildErr%\" ^\n-/consoleloggerparameters:Summary ^\n-/verbosity:minimal\n-\n-set __msbuildArgs=\"%__IntermediatesDir%\\install.vcxproj\" %__msbuildCommonArgs% %__msbuildLogArgs% /p:Configuration=%__BuildType%\n+    if not exist \"%__IntermediatesDir%\\install.vcxproj\" (\n+        echo %__MsgPrefix%Error: failed to generate native component build project!\n+        exit /b 1\n+    )\n \n-if /i \"%__BuildArch%\" == \"arm64\" (  \n-    REM TODO, remove once we have msbuild support for this platform.\n-    set __msbuildArgs=%__msbuildArgs% /p:UseEnv=true\n-) else (\n-    set __msbuildArgs=%__msbuildArgs% /p:Platform=%__BuildArch%\n-)\n+    @call %~dp0run.cmd build -Project=%__IntermediatesDir%\\install.vcxproj -MsBuildLog=!__MsbuildLog! -MsBuildWrn=!__MsbuildWrn! -MsBuildErr=!__MsbuildErr! -configuration=%__BuildType% %nativePlatfromArgs% %__RunArgs% %__UnprocessedBuildArgs%\n \n-%_msbuildexe% %__msbuildArgs%\n-if errorlevel 1 (\n-    echo %__MsgPrefix%Error: native component build failed. Refer to the build log files for details:\n-    echo     %__BuildLog%\n-    echo     %__BuildWrn%\n-    echo     %__BuildErr%\n-    exit /b 1\n+    if %errorlevel% == 1 (\n+        echo %__MsgPrefix%Error: native component build failed. Refer to the build log files for details:\n+        echo     \"%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n+        echo     \"%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"\n+        echo     \"%__LogsDir%\\CoreCLR_%__BuildOS%__%__BuildArch%__%__BuildType%.err\"\n+        exit /b 1\n+    )   \n )\n-\n :SkipNativeBuild\n \n-REM endlocal to rid us of environment changes from vcvarsall.bat\n-endlocal\n-\n REM =========================================================================================\n REM ===\n REM === Build Cross-Architecture Native Components (if applicable)\n REM ===\n REM =========================================================================================\n \n REM cross-arch build only enabled for arm64\n-if \"%__CrossArch%\" == \"\" goto SkipCrossCompBuild\n-\n-echo %__MsgPrefix%Commencing build of cross architecture native components for %__BuildOS%.%__BuildArch%.%__BuildType%\n-\n-REM Use setlocal to restrict environment changes form vcvarsall.bat and more to just this native components build section.\n-setlocal EnableDelayedExpansion EnableExtensions\n-\n-:: Set the environment for the native build\n-set __VCBuildArch=x86_amd64\n-if /i \"%__CrossArch%\" == \"x86\" (set __VCBuildArch=x86)\n-call \"%__VSToolsRoot%\\..\\..\\VC\\vcvarsall.bat\" %__VCBuildArch%\n-@if defined __echo @echo on\n-\n-set __CrossCompIntermediatesDir=%__IntermediatesDir%\\crossgen\n-if not exist \"%__CrossCompIntermediatesDir%\" md \"%__CrossCompIntermediatesDir%\"\n-\n-pushd \"%__CrossCompIntermediatesDir%\"\n-\n-set __CMakeBinDir=%__CrossComponentBinDir%\n-set \"__CMakeBinDir=%__CMakeBinDir:\\=/%\"\n-set __ExtraCmakeArgs=\"-DCLR_CROSS_COMPONENTS_BUILD=1\" \"-DCLR_CMAKE_TARGET_ARCH=%__BuildArch%\"\n-call \"%__SourceDir%\\pal\\tools\\gen-buildsys-win.bat\" \"%__ProjectDir%\" %__VSVersion% %__CrossArch% %__ExtraCmakeArgs%\n-@if defined __echo @echo on\n-popd\n-\n-if not exist \"%__CrossCompIntermediatesDir%\\install.vcxproj\" (\n-    echo %__MsgPrefix%Error: failed to generate cross-arch components build project!\n-    exit /b 1\n-)\n \n-if defined __ConfigureOnly goto SkipCrossCompBuild\n+if /i \"%__BuildArch%\"==\"arm64\" (\n+\n+    echo %__MsgPrefix%Commencing build of cross architecture native components for %__BuildOS%.%__BuildArch%.%__BuildType%\n+\n+    :: Set the environment for the native build\n+    set __VCBuildArch=x86_amd64\n+    if /i \"%__CrossArch%\" == \"x86\" ( set __VCBuildArch=x86 )\n+    @call \"%__VSToolsRoot%\\..\\..\\VC\\vcvarsall.bat\" !__VCBuildArch!\n+    @if defined __echo @echo on\n+\n+    if not exist \"%__CrossCompIntermediatesDir%\" md \"%__CrossCompIntermediatesDir%\"\n+    if defined __SkipConfigure goto SkipConfigureCrossBuild\n+\n+    pushd \"%__CrossCompIntermediatesDir%\"\n+    set __CMakeBinDir=%__CrossComponentBinDir%\n+    set \"__CMakeBinDir=%__CMakeBinDir:\\=/%\"\n+    set __ExtraCmakeArgs=\"-DCLR_CROSS_COMPONENTS_BUILD=1\" \"-DCLR_CMAKE_TARGET_ARCH=%__BuildArch%\"\n+    call \"%__SourceDir%\\pal\\tools\\gen-buildsys-win.bat\" \"%__ProjectDir%\" %__VSVersion% %__CrossArch% %__ExtraCmakeArgs%\n+    @if defined __echo @echo on\n+    popd\n+:SkipConfigureCrossBuild\n+    if not exist \"%__CrossCompIntermediatesDir%\\install.vcxproj\" (\n+        echo %__MsgPrefix%Error: failed to generate cross-arch components build project!\n+        exit /b 1\n+    )\n \n-echo %__MsgPrefix%Invoking msbuild\n+    if defined __ConfigureOnly goto SkipCrossCompBuild\n \n-set \"__BuildLog=%__LogsDir%\\CrossComp_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n-set \"__BuildWrn=%__LogsDir%\\CrossComp_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"\n-set \"__BuildErr=%__LogsDir%\\CrossComp_%__BuildOS%__%__BuildArch%__%__BuildType%.err\"\n-set __msbuildLogArgs=^\n-/fileloggerparameters:Verbosity=normal;LogFile=\"%__BuildLog%\" ^\n-/fileloggerparameters1:WarningsOnly;LogFile=\"%__BuildWrn%\" ^\n-/fileloggerparameters2:ErrorsOnly;LogFile=\"%__BuildErr%\" ^\n-/consoleloggerparameters:Summary ^\n-/verbosity:minimal\n+    echo %__MsgPrefix%Invoking msbuild\n \n-set __msbuildArgs=\"%__CrossCompIntermediatesDir%\\install.vcxproj\" %__msbuildCommonArgs% %__msbuildLogArgs% /p:Configuration=%__BuildType% /p:Platform=%__CrossArch%\n+    set __MsbuildLog=/flp:Verbosity=normal;LogFile=\"%__LogsDir%\\Cross_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n+\tset __MsbuildWrn=/flp1:WarningsOnly;LogFile=\"%__LogsDir%\\Cross_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"\n+\tset __MsbuildErr=/flp2:ErrorsOnly;LogFile=\"%__LogsDir%\\Cross_%__BuildOS%__%__BuildArch%__%__BuildType%.err\"\n \n-%_msbuildexe% %__msbuildArgs%\n-if errorlevel 1 (\n-    echo %__MsgPrefix%Error: cross-arch components build failed. Refer to the build log files for details:\n-    echo     %__BuildLog%\n-    echo     %__BuildWrn%\n-    echo     %__BuildErr%\n-    exit /b 1\n+    @call %~dp0run.cmd build -Project=%__CrossCompIntermediatesDir%\\install.vcxproj -configuration=%__BuildType% -platform=%__CrossArch% -MsBuildLog=!__MsbuildLog! -MsBuildWrn=!__MsbuildWrn! -MsBuildErr=!__MsbuildErr! %__RunArgs% %__UnprocessedBuildArgs%\n+    if %errorlevel% == 1 (\n+        echo %__MsgPrefix%Error: cross-arch components build failed. Refer to the build log files for details:\n+        echo     \"%__LogsDir%\\Cross_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n+        echo     \"%__LogsDir%\\Cross_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"\n+        echo     \"%__LogsDir%\\Cross_%__BuildOS%__%__BuildArch%__%__BuildType%.err\"\n+        exit /b 1\n+    )    \n )\n \n-REM endlocal to rid us of environment changes from vcvarsall.bat\n-endlocal\n-\n :SkipCrossCompBuild\n-\n REM =========================================================================================\n REM ===\n REM === CoreLib and NuGet package build section.\n REM ===\n REM =========================================================================================\n \n-:PerformCoreLibBuild\n-\n-REM setlocal to prepare for vsdevcmd.bat\n-setlocal EnableDelayedExpansion EnableExtensions\n-\n-rem Explicitly set Platform causes conflicts in CoreLib project files. Clear it to allow building from VS x64 Native Tools Command Prompt\n-set Platform=\n-\n-:: Set the environment for the managed build\n-echo %__MsgPrefix%Using environment: \"%__VSToolsRoot%\\VsDevCmd.bat\"\n-call                                 \"%__VSToolsRoot%\\VsDevCmd.bat\"\n-\n-if defined __SkipCoreLibBuild (\n-    echo %__MsgPrefix%Skipping System.Private.CoreLib build\n-    goto SkipCoreLibBuild\n-)\n-\n-echo %__MsgPrefix%Commencing build of System.Private.CoreLib for %__BuildOS%.%__BuildArch%.%__BuildType%\n-\n-set \"__BuildLog=%__LogsDir%\\System.Private.CoreLib_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n-set \"__BuildWrn=%__LogsDir%\\System.Private.CoreLib_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"\n-set \"__BuildErr=%__LogsDir%\\System.Private.CoreLib_%__BuildOS%__%__BuildArch%__%__BuildType%.err\"\n-set __msbuildLogArgs=^\n-/fileloggerparameters:Verbosity=normal;LogFile=\"%__BuildLog%\" ^\n-/fileloggerparameters1:WarningsOnly;LogFile=\"%__BuildWrn%\" ^\n-/fileloggerparameters2:ErrorsOnly;LogFile=\"%__BuildErr%\" ^\n-/consoleloggerparameters:Summary ^\n-/verbosity:minimal\n-\n-set __msbuildArgs=\"%__ProjectFilesDir%\\build.proj\" %__msbuildCommonArgs% %__msbuildLogArgs% %__SignTypeReal%\n-\n-set __BuildNugetPackage=true\n-if defined __CoreLibOnly       set __BuildNugetPackage=false\n-if /i \"%__BuildArch%\" ==\"arm64\" set __BuildNugetPackage=false\n-if %__BuildNugetPackage%==false set __msbuildArgs=%__msbuildArgs% /p:BuildNugetPackage=false\n-\n-%_msbuildexe% %__msbuildArgs%\n-if errorlevel 1 (\n-    echo %__MsgPrefix%Error: System.Private.CoreLib build failed. Refer to the build log files for details:\n-    echo     %__BuildLog%\n-    echo     %__BuildWrn%\n-    echo     %__BuildErr%\n-    type     %__BuildErr%\n-    exit /b 1\n+if %__BuildCoreLib% EQU 1 (  \n+\t\n+\techo %__MsgPrefix%Commencing build of System.Private.CoreLib for %__BuildOS%.%__BuildArch%.%__BuildType%\n+    rem Explicitly set Platform causes conflicts in CoreLib project files. Clear it to allow building from VS x64 Native Tools Command Prompt\n+    set Platform=\n+\n+    :: Set the environment for the managed build\n+    echo %__MsgPrefix%Using environment: \"%__VSToolsRoot%\\VsDevCmd.bat\"\n+    call                                 \"%__VSToolsRoot%\\VsDevCmd.bat\"\n+\n+    set __MsbuildLog=/flp:Verbosity=normal;LogFile=\"%__LogsDir%\\System.Private.CoreLib_%__BuildOS%__%__BuildArch%__%__BuildType%.log\"\n+\tset __MsbuildWrn=/flp1:WarningsOnly;LogFile=\"%__LogsDir%\\System.Private.CoreLib_%__BuildOS%__%__BuildArch%__%__BuildType%.wrn\"","path":"build.cmd","position":597,"original_position":597,"commit_id":"65bd4e1f2c73add6c1a771593ef9e0485ac3de5e","original_commit_id":"65bd4e1f2c73add6c1a771593ef9e0485ac3de5e","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"nit: some of these lines are indented and some are not.","created_at":"2016-07-29T21:59:43Z","updated_at":"2016-07-29T21:59:43Z","html_url":"https://github.com/dotnet/coreclr/pull/6400#discussion_r72867036","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6400","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/72867036"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6400#discussion_r72867036"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6400"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6400","id":78408796,"html_url":"https://github.com/dotnet/coreclr/pull/6400","diff_url":"https://github.com/dotnet/coreclr/pull/6400.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6400.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6400","number":6400,"state":"open","locked":false,"title":"Use run tool in coreclr dev workflow.","user":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"body":"These changes alter the dev workflow that's been in use so far. This is a first step to move towards consuming the run tool to synchronize the dev workflow across the dotnet repos. For more information, please refer to this documentation [here](https://github.com/dotnet/buildtools/blob/master/Documentation/RunCommand.md)\r\n\r\ncc @maririos @markwilkie @weshaggard @gkhanna79 @jashook @wtgodbe @jaredpar @sokket @joshfree \r\n\r\nThe PRs are expected to FAIL, since the groovy script gets updated only after merge. True validation can happen only after groovy change is pushed along with the scripts. I have performed local testing on Ubuntu16.04 and Windows10 of each of the codepaths the scripts can execute.","created_at":"2016-07-22T00:28:11Z","updated_at":"2016-07-29T21:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcc5c8db21805e6437b51c99a1ba991784e8ebf7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6400/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6400/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6400/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/65bd4e1f2c73add6c1a771593ef9e0485ac3de5e","head":{"label":"Priya91:useruntool","ref":"useruntool","sha":"65bd4e1f2c73add6c1a771593ef9e0485ac3de5e","user":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"repo":{"id":30321833,"name":"coreclr","full_name":"Priya91/coreclr","owner":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Priya91/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/Priya91/coreclr","forks_url":"https://api.github.com/repos/Priya91/coreclr/forks","keys_url":"https://api.github.com/repos/Priya91/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Priya91/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Priya91/coreclr/teams","hooks_url":"https://api.github.com/repos/Priya91/coreclr/hooks","issue_events_url":"https://api.github.com/repos/Priya91/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/Priya91/coreclr/events","assignees_url":"https://api.github.com/repos/Priya91/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/Priya91/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/Priya91/coreclr/tags","blobs_url":"https://api.github.com/repos/Priya91/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Priya91/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Priya91/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Priya91/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Priya91/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/Priya91/coreclr/languages","stargazers_url":"https://api.github.com/repos/Priya91/coreclr/stargazers","contributors_url":"https://api.github.com/repos/Priya91/coreclr/contributors","subscribers_url":"https://api.github.com/repos/Priya91/coreclr/subscribers","subscription_url":"https://api.github.com/repos/Priya91/coreclr/subscription","commits_url":"https://api.github.com/repos/Priya91/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Priya91/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Priya91/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Priya91/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Priya91/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/Priya91/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Priya91/coreclr/merges","archive_url":"https://api.github.com/repos/Priya91/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Priya91/coreclr/downloads","issues_url":"https://api.github.com/repos/Priya91/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/Priya91/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/Priya91/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/Priya91/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Priya91/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/Priya91/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/Priya91/coreclr/deployments","created_at":"2015-02-04T21:22:00Z","updated_at":"2015-02-04T21:22:19Z","pushed_at":"2016-07-29T20:51:54Z","git_url":"git://github.com/Priya91/coreclr.git","ssh_url":"git@github.com:Priya91/coreclr.git","clone_url":"https://github.com/Priya91/coreclr.git","svn_url":"https://github.com/Priya91/coreclr","homepage":"","size":93808,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c1a5ed7d94dbf52775719271a22a3b88d2ce98f8","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-07-29T20:57:45Z","pushed_at":"2016-07-29T21:42:53Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":104778,"stargazers_count":6732,"watchers_count":6732,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1573,"mirror_url":null,"open_issues_count":914,"forks":1573,"open_issues":914,"watchers":6732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6400"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6400"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6400"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6400/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6400/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6400/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/65bd4e1f2c73add6c1a771593ef9e0485ac3de5e"}}}}
{"actor":{"display_login":"weshaggard"}}