{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/comments/50621873","id":50621873,"diff_hunk":"@@ -1150,6 +1142,30 @@ public void run() {\n             jmxRemotePeerBean = null;\n         }\n     }\n+    \n+    private void stopObserver() {\n+        if (null != observer) {","path":"src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java","position":41,"original_position":41,"commit_id":"da8bd6638b22487984ef5a3ebb198c1c004a7093","original_commit_id":"da8bd6638b22487984ef5a3ebb198c1c004a7093","user":{"login":"fpj","id":572920,"avatar_url":"https://avatars.githubusercontent.com/u/572920?v=3","gravatar_id":"","url":"https://api.github.com/users/fpj","html_url":"https://github.com/fpj","followers_url":"https://api.github.com/users/fpj/followers","following_url":"https://api.github.com/users/fpj/following{/other_user}","gists_url":"https://api.github.com/users/fpj/gists{/gist_id}","starred_url":"https://api.github.com/users/fpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpj/subscriptions","organizations_url":"https://api.github.com/users/fpj/orgs","repos_url":"https://api.github.com/users/fpj/repos","events_url":"https://api.github.com/users/fpj/events{/privacy}","received_events_url":"https://api.github.com/users/fpj/received_events","type":"User","site_admin":false},"body":"minor: can we make this uniform and have \"x != null\"?","created_at":"2016-01-23T16:24:30Z","updated_at":"2016-01-23T16:24:30Z","html_url":"https://github.com/apache/zookeeper/pull/52#discussion_r50621873","pull_request_url":"https://api.github.com/repos/apache/zookeeper/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments/50621873"},"html":{"href":"https://github.com/apache/zookeeper/pull/52#discussion_r50621873"},"pull_request":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/apache/zookeeper/pulls/52","id":56298586,"html_url":"https://github.com/apache/zookeeper/pull/52","diff_url":"https://github.com/apache/zookeeper/pull/52.diff","patch_url":"https://github.com/apache/zookeeper/pull/52.patch","issue_url":"https://api.github.com/repos/apache/zookeeper/issues/52","number":52,"state":"open","locked":false,"title":"ZOOKEEPER-2247 Zookeeper service becomes unavailable when leader fail…","user":{"login":"arshadmohammad","id":5720433,"avatar_url":"https://avatars.githubusercontent.com/u/5720433?v=3","gravatar_id":"","url":"https://api.github.com/users/arshadmohammad","html_url":"https://github.com/arshadmohammad","followers_url":"https://api.github.com/users/arshadmohammad/followers","following_url":"https://api.github.com/users/arshadmohammad/following{/other_user}","gists_url":"https://api.github.com/users/arshadmohammad/gists{/gist_id}","starred_url":"https://api.github.com/users/arshadmohammad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arshadmohammad/subscriptions","organizations_url":"https://api.github.com/users/arshadmohammad/orgs","repos_url":"https://api.github.com/users/arshadmohammad/repos","events_url":"https://api.github.com/users/arshadmohammad/events{/privacy}","received_events_url":"https://api.github.com/users/arshadmohammad/received_events","type":"User","site_admin":false},"body":"…s to write transaction log","created_at":"2016-01-18T03:26:50Z","updated_at":"2016-01-23T16:24:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28603112d44ccc46ccc440d25e5a06cab69ae1fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/zookeeper/pulls/52/commits","review_comments_url":"https://api.github.com/repos/apache/zookeeper/pulls/52/comments","review_comment_url":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zookeeper/issues/52/comments","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/da8bd6638b22487984ef5a3ebb198c1c004a7093","head":{"label":"arshadmohammad:ZOOKEEPER-2247","ref":"ZOOKEEPER-2247","sha":"da8bd6638b22487984ef5a3ebb198c1c004a7093","user":{"login":"arshadmohammad","id":5720433,"avatar_url":"https://avatars.githubusercontent.com/u/5720433?v=3","gravatar_id":"","url":"https://api.github.com/users/arshadmohammad","html_url":"https://github.com/arshadmohammad","followers_url":"https://api.github.com/users/arshadmohammad/followers","following_url":"https://api.github.com/users/arshadmohammad/following{/other_user}","gists_url":"https://api.github.com/users/arshadmohammad/gists{/gist_id}","starred_url":"https://api.github.com/users/arshadmohammad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arshadmohammad/subscriptions","organizations_url":"https://api.github.com/users/arshadmohammad/orgs","repos_url":"https://api.github.com/users/arshadmohammad/repos","events_url":"https://api.github.com/users/arshadmohammad/events{/privacy}","received_events_url":"https://api.github.com/users/arshadmohammad/received_events","type":"User","site_admin":false},"repo":{"id":49848645,"name":"zookeeper","full_name":"arshadmohammad/zookeeper","owner":{"login":"arshadmohammad","id":5720433,"avatar_url":"https://avatars.githubusercontent.com/u/5720433?v=3","gravatar_id":"","url":"https://api.github.com/users/arshadmohammad","html_url":"https://github.com/arshadmohammad","followers_url":"https://api.github.com/users/arshadmohammad/followers","following_url":"https://api.github.com/users/arshadmohammad/following{/other_user}","gists_url":"https://api.github.com/users/arshadmohammad/gists{/gist_id}","starred_url":"https://api.github.com/users/arshadmohammad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arshadmohammad/subscriptions","organizations_url":"https://api.github.com/users/arshadmohammad/orgs","repos_url":"https://api.github.com/users/arshadmohammad/repos","events_url":"https://api.github.com/users/arshadmohammad/events{/privacy}","received_events_url":"https://api.github.com/users/arshadmohammad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arshadmohammad/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":true,"url":"https://api.github.com/repos/arshadmohammad/zookeeper","forks_url":"https://api.github.com/repos/arshadmohammad/zookeeper/forks","keys_url":"https://api.github.com/repos/arshadmohammad/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arshadmohammad/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arshadmohammad/zookeeper/teams","hooks_url":"https://api.github.com/repos/arshadmohammad/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/arshadmohammad/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/arshadmohammad/zookeeper/events","assignees_url":"https://api.github.com/repos/arshadmohammad/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/arshadmohammad/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/arshadmohammad/zookeeper/tags","blobs_url":"https://api.github.com/repos/arshadmohammad/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arshadmohammad/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arshadmohammad/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/arshadmohammad/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arshadmohammad/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/arshadmohammad/zookeeper/languages","stargazers_url":"https://api.github.com/repos/arshadmohammad/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/arshadmohammad/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/arshadmohammad/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/arshadmohammad/zookeeper/subscription","commits_url":"https://api.github.com/repos/arshadmohammad/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/arshadmohammad/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/arshadmohammad/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/arshadmohammad/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/arshadmohammad/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/arshadmohammad/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arshadmohammad/zookeeper/merges","archive_url":"https://api.github.com/repos/arshadmohammad/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arshadmohammad/zookeeper/downloads","issues_url":"https://api.github.com/repos/arshadmohammad/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/arshadmohammad/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/arshadmohammad/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/arshadmohammad/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arshadmohammad/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/arshadmohammad/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/arshadmohammad/zookeeper/deployments","created_at":"2016-01-18T03:05:06Z","updated_at":"2016-01-18T03:05:10Z","pushed_at":"2016-01-20T17:44:26Z","git_url":"git://github.com/arshadmohammad/zookeeper.git","ssh_url":"git@github.com:arshadmohammad/zookeeper.git","clone_url":"https://github.com/arshadmohammad/zookeeper.git","svn_url":"https://github.com/arshadmohammad/zookeeper","homepage":null,"size":23980,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"92707a6a84a7965df2d7d8ead0acb721b6e62878","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":160999,"name":"zookeeper","full_name":"apache/zookeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":false,"url":"https://api.github.com/repos/apache/zookeeper","forks_url":"https://api.github.com/repos/apache/zookeeper/forks","keys_url":"https://api.github.com/repos/apache/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zookeeper/teams","hooks_url":"https://api.github.com/repos/apache/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zookeeper/events","assignees_url":"https://api.github.com/repos/apache/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zookeeper/tags","blobs_url":"https://api.github.com/repos/apache/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zookeeper/languages","stargazers_url":"https://api.github.com/repos/apache/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/zookeeper/subscription","commits_url":"https://api.github.com/repos/apache/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zookeeper/merges","archive_url":"https://api.github.com/repos/apache/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zookeeper/downloads","issues_url":"https://api.github.com/repos/apache/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zookeeper/deployments","created_at":"2009-03-27T15:41:56Z","updated_at":"2016-01-23T06:37:13Z","pushed_at":"2016-01-23T05:08:10Z","git_url":"git://github.com/apache/zookeeper.git","ssh_url":"git@github.com:apache/zookeeper.git","clone_url":"https://github.com/apache/zookeeper.git","svn_url":"https://github.com/apache/zookeeper","homepage":null,"size":43069,"stargazers_count":1412,"watchers_count":1412,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1043,"mirror_url":"git://git.apache.org/zookeeper.git","open_issues_count":38,"forks":1043,"open_issues":38,"watchers":1412,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/52"},"html":{"href":"https://github.com/apache/zookeeper/pull/52"},"issue":{"href":"https://api.github.com/repos/apache/zookeeper/issues/52"},"comments":{"href":"https://api.github.com/repos/apache/zookeeper/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zookeeper/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zookeeper/statuses/da8bd6638b22487984ef5a3ebb198c1c004a7093"}}}}