{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7285","repository_url":"https://api.github.com/repos/Homebrew/homebrew-core","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7285/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7285/comments","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7285/events","html_url":"https://github.com/Homebrew/homebrew-core/pull/7285","id":191867129,"number":7285,"title":"sdl_image: Add option to statically link libraries","user":{"login":"tsparber","id":1390036,"avatar_url":"https://avatars.githubusercontent.com/u/1390036?v=3","gravatar_id":"","url":"https://api.github.com/users/tsparber","html_url":"https://github.com/tsparber","followers_url":"https://api.github.com/users/tsparber/followers","following_url":"https://api.github.com/users/tsparber/following{/other_user}","gists_url":"https://api.github.com/users/tsparber/gists{/gist_id}","starred_url":"https://api.github.com/users/tsparber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsparber/subscriptions","organizations_url":"https://api.github.com/users/tsparber/orgs","repos_url":"https://api.github.com/users/tsparber/repos","events_url":"https://api.github.com/users/tsparber/events{/privacy}","received_events_url":"https://api.github.com/users/tsparber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-27T15:27:22Z","updated_at":"2016-11-28T09:26:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7285","html_url":"https://github.com/Homebrew/homebrew-core/pull/7285","diff_url":"https://github.com/Homebrew/homebrew-core/pull/7285.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/7285.patch"},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [ ] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n  No, as the tests are missing.\r\n-----\r\n\r\nThis PR adds a new option to `sdl_image` to build without dynamically loading dylibs (using `dlopen`) for png, jpg, tiff and webp files.\r\nThis is very useful when packaging `sdl_image` for example in [`pygame`](https://bitbucket.org/pygame/pygame/issues/300/os-x-wheels-dmg-and-zip-builds-with-travis#comment-32409453) using `delocate`. As this makes all required libraries visible using `otool -L` and prevents `sdl` from searching for these libraries at runtime.\r\n\r\nExample output after building with `--without-shared`:\r\n```\r\n$ otool -L /usr/local/Cellar/sdl_image/1.2.12_4/lib/libSDL_image.dylib\r\n/usr/local/Cellar/sdl_image/1.2.12_4/lib/libSDL_image.dylib:\r\n\t/usr/local/opt/sdl_image/lib/libSDL_image-1.2.0.dylib (compatibility version 9.0.0, current version 9.4.0)\r\n\t/usr/local/opt/libpng/lib/libpng16.16.dylib (compatibility version 43.0.0, current version 43.0.0)\r\n\t/usr/local/opt/jpeg/lib/libjpeg.8.dylib (compatibility version 13.0.0, current version 13.0.0)\r\n\t/usr/local/opt/libtiff/lib/libtiff.5.dylib (compatibility version 8.0.0, current version 8.5.0)\r\n\t/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.8)\r\n\t/usr/local/opt/webp/lib/libwebp.6.dylib (compatibility version 7.0.0, current version 7.1.0)\r\n\t/usr/local/opt/sdl/lib/libSDL-1.2.0.dylib (compatibility version 12.0.0, current version 12.4.0)\r\n\t/System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 22.0.0)\r\n\t/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.0.0)\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments/263222193","html_url":"https://github.com/Homebrew/homebrew-core/pull/7285#issuecomment-263222193","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7285","id":263222193,"user":{"login":"tsparber","id":1390036,"avatar_url":"https://avatars.githubusercontent.com/u/1390036?v=3","gravatar_id":"","url":"https://api.github.com/users/tsparber","html_url":"https://github.com/tsparber","followers_url":"https://api.github.com/users/tsparber/followers","following_url":"https://api.github.com/users/tsparber/following{/other_user}","gists_url":"https://api.github.com/users/tsparber/gists{/gist_id}","starred_url":"https://api.github.com/users/tsparber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsparber/subscriptions","organizations_url":"https://api.github.com/users/tsparber/orgs","repos_url":"https://api.github.com/users/tsparber/repos","events_url":"https://api.github.com/users/tsparber/events{/privacy}","received_events_url":"https://api.github.com/users/tsparber/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T09:26:35Z","updated_at":"2016-11-28T09:26:35Z","body":"I think to there is no real disadvantage.\r\nWithout this option the user is able to decide later to install/uninstall the required libraries to load/not load the respective formats. This can also be achieved by recompiling (which homebrew already makes quite simple).\r\n\r\nUpdating to make it default...\r\n"}}
{"actor":{"display_login":"tsparber"}}