{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/68757837","id":68757837,"diff_hunk":"@@ -1655,30 +1683,40 @@ def make_flash_bem(subject, overwrite=False, show=True, subjects_dir=None,\n         Show surfaces to visually inspect all three BEM surfaces (recommended).\n     subjects_dir : string, or None\n         Path to SUBJECTS_DIR if it is not set in the environment.\n+    flash_path : str | None\n+        Path to the flash images. If None (default), mri/flash/parameter_maps\n+        within the subject reconstruction is used.\n+\n+        .. versionadded:: 0.13.0\n+\n     verbose : bool, str, int, or None\n         If not None, override default verbose level (see mne.verbose).\n \n     Notes\n     -----\n-    This program assumes that FreeSurfer and MNE are installed and\n-    sourced properly.\n+    This program assumes that FreeSurfer is installed and sourced properly.\n \n     This function extracts the BEM surfaces (outer skull, inner skull, and\n     outer skin) from multiecho FLASH MRI data with spin angles of 5 and 30\n     degrees, in mgz format.\n \n-    This function assumes that the flash images are available in the\n-    folder mri/bem/flash within the freesurfer subject reconstruction.\n-\n     See Also\n     --------\n     convert_flash_mris\n     \"\"\"\n     from .viz.misc import plot_bem\n+    from .surface import write_surface, read_tri\n+\n+    is_test = os.environ.get('MNE_SKIP_FLASH_CALL', False)  # to enable testing","path":"mne/bem.py","position":105,"original_position":105,"commit_id":"1723797bd6c408920dce1e090fec038358c52a16","original_commit_id":"1723797bd6c408920dce1e090fec038358c52a16","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"...then this is a bit of a misnomer. This should be more like `skip_fs_flash_call` or something","created_at":"2016-06-28T13:40:40Z","updated_at":"2016-06-28T13:40:40Z","html_url":"https://github.com/mne-tools/mne-python/pull/3273#discussion_r68757837","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/68757837"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3273#discussion_r68757837"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273","id":72002455,"html_url":"https://github.com/mne-tools/mne-python/pull/3273","diff_url":"https://github.com/mne-tools/mne-python/pull/3273.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3273.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3273","number":3273,"state":"open","locked":false,"title":"[MRG] convert surface using python.","user":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/mne-tools/mne-python/issues/3107\r\ncloses https://github.com/mne-tools/mne-python/issues/3281\r\nFor most parts I had no idea what I was doing, but it seems to give similar results.","created_at":"2016-05-31T11:54:18Z","updated_at":"2016-06-28T13:40:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d449468dd75e2c1df5fed5b5ac63922b1c06a606","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3273/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/1723797bd6c408920dce1e090fec038358c52a16","head":{"label":"jaeilepp:convert-surface","ref":"convert-surface","sha":"1723797bd6c408920dce1e090fec038358c52a16","user":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"repo":{"id":35097627,"name":"mne-python","full_name":"jaeilepp/mne-python","owner":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaeilepp/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/jaeilepp/mne-python","forks_url":"https://api.github.com/repos/jaeilepp/mne-python/forks","keys_url":"https://api.github.com/repos/jaeilepp/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaeilepp/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaeilepp/mne-python/teams","hooks_url":"https://api.github.com/repos/jaeilepp/mne-python/hooks","issue_events_url":"https://api.github.com/repos/jaeilepp/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/jaeilepp/mne-python/events","assignees_url":"https://api.github.com/repos/jaeilepp/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/jaeilepp/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/jaeilepp/mne-python/tags","blobs_url":"https://api.github.com/repos/jaeilepp/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaeilepp/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaeilepp/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaeilepp/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaeilepp/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jaeilepp/mne-python/languages","stargazers_url":"https://api.github.com/repos/jaeilepp/mne-python/stargazers","contributors_url":"https://api.github.com/repos/jaeilepp/mne-python/contributors","subscribers_url":"https://api.github.com/repos/jaeilepp/mne-python/subscribers","subscription_url":"https://api.github.com/repos/jaeilepp/mne-python/subscription","commits_url":"https://api.github.com/repos/jaeilepp/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaeilepp/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaeilepp/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaeilepp/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaeilepp/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/jaeilepp/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaeilepp/mne-python/merges","archive_url":"https://api.github.com/repos/jaeilepp/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaeilepp/mne-python/downloads","issues_url":"https://api.github.com/repos/jaeilepp/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/jaeilepp/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jaeilepp/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jaeilepp/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaeilepp/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/jaeilepp/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/jaeilepp/mne-python/deployments","created_at":"2015-05-05T12:24:30Z","updated_at":"2016-02-29T07:08:15Z","pushed_at":"2016-06-28T13:34:24Z","git_url":"git://github.com/jaeilepp/mne-python.git","ssh_url":"git@github.com:jaeilepp/mne-python.git","clone_url":"https://github.com/jaeilepp/mne-python.git","svn_url":"https://github.com/jaeilepp/mne-python","homepage":"http://martinos.org/mne/","size":87348,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"ea83b849f8f0582fcb40822bfef511fba5d102a7","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-06-26T02:34:24Z","pushed_at":"2016-06-28T13:34:25Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":178925,"stargazers_count":211,"watchers_count":211,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":200,"forks":203,"open_issues":200,"watchers":211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3273"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3273"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3273/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3273/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/1723797bd6c408920dce1e090fec038358c52a16"}}}}
{"actor":{"display_login":"Eric89GXL"}}