{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/64411372","id":64411372,"diff_hunk":"@@ -666,7 +670,9 @@ enum RibKind<'a> {\n     // methods. Allow references to ty params that impl or trait\n     // binds. Disallow any other upvars (including other ty params that are\n     // upvars).\n-    MethodRibKind,\n+    //\n+    // The boolean value represents the fact that this method is static or not.\n+    MethodRibKind(bool),","path":"src/librustc_resolve/lib.rs","position":58,"original_position":58,"commit_id":"fa338ee8f4d7e63d2ad735c347dbf5b2f63ea0f4","original_commit_id":"fa338ee8f4d7e63d2ad735c347dbf5b2f63ea0f4","user":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"body":"(its good you put the comment here. You *might* consider the alternatives I outlined above, to make the types self-documenting.)","created_at":"2016-05-24T15:14:22Z","updated_at":"2016-05-24T15:14:22Z","html_url":"https://github.com/rust-lang/rust/pull/33615#discussion_r64411372","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/33615","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/64411372"},"html":{"href":"https://github.com/rust-lang/rust/pull/33615#discussion_r64411372"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/33615"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/33615","id":70012867,"html_url":"https://github.com/rust-lang/rust/pull/33615","diff_url":"https://github.com/rust-lang/rust/pull/33615.diff","patch_url":"https://github.com/rust-lang/rust/pull/33615.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/33615","number":33615,"state":"open","locked":false,"title":"Don't suggest using fields in a static method","user":{"login":"GuillaumeGomez","id":3050060,"avatar_url":"https://avatars.githubusercontent.com/u/3050060?v=3","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"body":"Fixes #33613.\r\n\r\ncc @LeoTestard ","created_at":"2016-05-13T15:20:09Z","updated_at":"2016-05-24T15:14:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce83a8fe8b6239200667f83bc2d90d7f983b0128","assignee":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/33615/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/33615/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/33615/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/fa338ee8f4d7e63d2ad735c347dbf5b2f63ea0f4","head":{"label":"GuillaumeGomez:field_static_method","ref":"field_static_method","sha":"fa338ee8f4d7e63d2ad735c347dbf5b2f63ea0f4","user":{"login":"GuillaumeGomez","id":3050060,"avatar_url":"https://avatars.githubusercontent.com/u/3050060?v=3","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"repo":{"id":32751288,"name":"rust","full_name":"GuillaumeGomez/rust","owner":{"login":"GuillaumeGomez","id":3050060,"avatar_url":"https://avatars.githubusercontent.com/u/3050060?v=3","gravatar_id":"","url":"https://api.github.com/users/GuillaumeGomez","html_url":"https://github.com/GuillaumeGomez","followers_url":"https://api.github.com/users/GuillaumeGomez/followers","following_url":"https://api.github.com/users/GuillaumeGomez/following{/other_user}","gists_url":"https://api.github.com/users/GuillaumeGomez/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillaumeGomez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillaumeGomez/subscriptions","organizations_url":"https://api.github.com/users/GuillaumeGomez/orgs","repos_url":"https://api.github.com/users/GuillaumeGomez/repos","events_url":"https://api.github.com/users/GuillaumeGomez/events{/privacy}","received_events_url":"https://api.github.com/users/GuillaumeGomez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GuillaumeGomez/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/GuillaumeGomez/rust","forks_url":"https://api.github.com/repos/GuillaumeGomez/rust/forks","keys_url":"https://api.github.com/repos/GuillaumeGomez/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GuillaumeGomez/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GuillaumeGomez/rust/teams","hooks_url":"https://api.github.com/repos/GuillaumeGomez/rust/hooks","issue_events_url":"https://api.github.com/repos/GuillaumeGomez/rust/issues/events{/number}","events_url":"https://api.github.com/repos/GuillaumeGomez/rust/events","assignees_url":"https://api.github.com/repos/GuillaumeGomez/rust/assignees{/user}","branches_url":"https://api.github.com/repos/GuillaumeGomez/rust/branches{/branch}","tags_url":"https://api.github.com/repos/GuillaumeGomez/rust/tags","blobs_url":"https://api.github.com/repos/GuillaumeGomez/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GuillaumeGomez/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GuillaumeGomez/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/GuillaumeGomez/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GuillaumeGomez/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/GuillaumeGomez/rust/languages","stargazers_url":"https://api.github.com/repos/GuillaumeGomez/rust/stargazers","contributors_url":"https://api.github.com/repos/GuillaumeGomez/rust/contributors","subscribers_url":"https://api.github.com/repos/GuillaumeGomez/rust/subscribers","subscription_url":"https://api.github.com/repos/GuillaumeGomez/rust/subscription","commits_url":"https://api.github.com/repos/GuillaumeGomez/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/GuillaumeGomez/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/GuillaumeGomez/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/GuillaumeGomez/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/GuillaumeGomez/rust/contents/{+path}","compare_url":"https://api.github.com/repos/GuillaumeGomez/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GuillaumeGomez/rust/merges","archive_url":"https://api.github.com/repos/GuillaumeGomez/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GuillaumeGomez/rust/downloads","issues_url":"https://api.github.com/repos/GuillaumeGomez/rust/issues{/number}","pulls_url":"https://api.github.com/repos/GuillaumeGomez/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/GuillaumeGomez/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/GuillaumeGomez/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GuillaumeGomez/rust/labels{/name}","releases_url":"https://api.github.com/repos/GuillaumeGomez/rust/releases{/id}","deployments_url":"https://api.github.com/repos/GuillaumeGomez/rust/deployments","created_at":"2015-03-23T18:35:10Z","updated_at":"2016-01-14T21:53:52Z","pushed_at":"2016-05-24T10:58:20Z","git_url":"git://github.com/GuillaumeGomez/rust.git","ssh_url":"git@github.com:GuillaumeGomez/rust.git","clone_url":"https://github.com/GuillaumeGomez/rust.git","svn_url":"https://github.com/GuillaumeGomez/rust","homepage":"http://www.rust-lang.org","size":299321,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"0352866da7098bdcc868fbc37246b48778ecf74a","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-05-24T14:24:46Z","pushed_at":"2016-05-24T15:05:48Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":495632,"stargazers_count":16783,"watchers_count":16783,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3198,"mirror_url":null,"open_issues_count":2544,"forks":3198,"open_issues":2544,"watchers":16783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/33615"},"html":{"href":"https://github.com/rust-lang/rust/pull/33615"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/33615"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/33615/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/33615/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/33615/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/fa338ee8f4d7e63d2ad735c347dbf5b2f63ea0f4"}}}}
{"actor":{"display_login":"pnkfelix"}}