{"action":"created","issue":{"url":"https://api.github.com/repos/sakovias/axlsx_styler/issues/15","repository_url":"https://api.github.com/repos/sakovias/axlsx_styler","labels_url":"https://api.github.com/repos/sakovias/axlsx_styler/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/sakovias/axlsx_styler/issues/15/comments","events_url":"https://api.github.com/repos/sakovias/axlsx_styler/issues/15/events","html_url":"https://github.com/sakovias/axlsx_styler/pull/15","id":172368602,"number":15,"title":"Add style merging","user":{"login":"westonganger","id":3414795,"avatar_url":"https://avatars.githubusercontent.com/u/3414795?v=3","gravatar_id":"","url":"https://api.github.com/users/westonganger","html_url":"https://github.com/westonganger","followers_url":"https://api.github.com/users/westonganger/followers","following_url":"https://api.github.com/users/westonganger/following{/other_user}","gists_url":"https://api.github.com/users/westonganger/gists{/gist_id}","starred_url":"https://api.github.com/users/westonganger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonganger/subscriptions","organizations_url":"https://api.github.com/users/westonganger/orgs","repos_url":"https://api.github.com/users/westonganger/repos","events_url":"https://api.github.com/users/westonganger/events{/privacy}","received_events_url":"https://api.github.com/users/westonganger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-22T04:41:20Z","updated_at":"2016-09-04T02:59:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sakovias/axlsx_styler/pulls/15","html_url":"https://github.com/sakovias/axlsx_styler/pull/15","diff_url":"https://github.com/sakovias/axlsx_styler/pull/15.diff","patch_url":"https://github.com/sakovias/axlsx_styler/pull/15.patch"},"body":"Addresses issue #14\r\n\r\nIt now only safely patches `Axlsx::Styles.add_style` to implement a style cache. Style index had to be moved from the Workbook to Styles because you cant access the workbook from the `add_styles` method. Tests are all passing but new ones added for this probably aren't super meaningful yet."},"comment":{"url":"https://api.github.com/repos/sakovias/axlsx_styler/issues/comments/244581472","html_url":"https://github.com/sakovias/axlsx_styler/pull/15#issuecomment-244581472","issue_url":"https://api.github.com/repos/sakovias/axlsx_styler/issues/15","id":244581472,"user":{"login":"westonganger","id":3414795,"avatar_url":"https://avatars.githubusercontent.com/u/3414795?v=3","gravatar_id":"","url":"https://api.github.com/users/westonganger","html_url":"https://github.com/westonganger","followers_url":"https://api.github.com/users/westonganger/followers","following_url":"https://api.github.com/users/westonganger/following{/other_user}","gists_url":"https://api.github.com/users/westonganger/gists{/gist_id}","starred_url":"https://api.github.com/users/westonganger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonganger/subscriptions","organizations_url":"https://api.github.com/users/westonganger/orgs","repos_url":"https://api.github.com/users/westonganger/repos","events_url":"https://api.github.com/users/westonganger/events{/privacy}","received_events_url":"https://api.github.com/users/westonganger/received_events","type":"User","site_admin":false},"created_at":"2016-09-04T02:59:21Z","updated_at":"2016-09-04T02:59:21Z","body":"Okay so I fixed the style merging in the latest commit. I had forgotten to add the cell styles from the index to the raw_styles before applying it to the cell. \r\n\r\nAs for the borders issue, I noticed that for `test_merge_styles_1` that the problem was fixed when I switched from:\r\n`sheet.add_styles 'B2:D4', borders: { style: :thin, color: '000000' }`\r\nto this:\r\n`sheet.add_border 'B2:D4', { style: :thin, color: '000000' }`\r\n\r\nI would appreciate your insight as to why the first statement is failing."}}
{"actor":{"display_login":"westonganger"}}