{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/chronos/pulls/comments/89330072","pull_request_review_id":9875461,"id":89330072,"diff_hunk":"@@ -111,6 +111,13 @@ class TimerHandler\n   // Check to see if these two timestamps are within NETWORK_DELAY of each other\n   bool near_time(uint32_t a, uint32_t b);\n \n+  // For a given TimerPair, return:\n+  // - the active timer if it doesn't match the cluster view id; else\n+  // - the informational timer if it exists and doesn't match the cluster view id; else\n+  // - NULL\n+  // If a timer is returned, active_timer is set to true if it was the active\n+  // timer of the TimerPair\n+  Timer* get_out_of_date_timer(const TimerPair &pair, const std::string &cluster_view_id, bool &active_timer);","path":"include/timer_handler.h","position":10,"original_position":10,"commit_id":"b773258219923143d86b3dbdb40fd54910c11581","original_commit_id":"b773258219923143d86b3dbdb40fd54910c11581","user":{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars.githubusercontent.com/u/5425325?v=3","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false},"body":"We'd normally put the & with the variable type, not the variable name","created_at":"2016-11-23T14:49:09Z","updated_at":"2016-11-23T14:58:40Z","html_url":"https://github.com/Metaswitch/chronos/pull/316#discussion_r89330072","pull_request_url":"https://api.github.com/repos/Metaswitch/chronos/pulls/316","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/chronos/pulls/comments/89330072"},"html":{"href":"https://github.com/Metaswitch/chronos/pull/316#discussion_r89330072"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/chronos/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/chronos/pulls/316","id":94969395,"html_url":"https://github.com/Metaswitch/chronos/pull/316","diff_url":"https://github.com/Metaswitch/chronos/pull/316.diff","patch_url":"https://github.com/Metaswitch/chronos/pull/316.patch","issue_url":"https://api.github.com/repos/Metaswitch/chronos/issues/316","number":316,"state":"open","locked":false,"title":"[Reviewer: Ellie] Don't update info timer if there's an out of date active timer","user":{"login":"sebrexmetaswitch","id":4903681,"avatar_url":"https://avatars.githubusercontent.com/u/4903681?v=3","gravatar_id":"","url":"https://api.github.com/users/sebrexmetaswitch","html_url":"https://github.com/sebrexmetaswitch","followers_url":"https://api.github.com/users/sebrexmetaswitch/followers","following_url":"https://api.github.com/users/sebrexmetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/sebrexmetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/sebrexmetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebrexmetaswitch/subscriptions","organizations_url":"https://api.github.com/users/sebrexmetaswitch/orgs","repos_url":"https://api.github.com/users/sebrexmetaswitch/repos","events_url":"https://api.github.com/users/sebrexmetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/sebrexmetaswitch/received_events","type":"User","site_admin":false},"body":"When selecting a timer for updating the replica tracker, always choose an\r\nout-of-date active timer in preference to any informational timer.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/metaswitch/chronos/316)\n<!-- Reviewable:end -->\n","created_at":"2016-11-23T09:40:12Z","updated_at":"2016-11-23T14:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0a64a13a904a35a6e4d35a506bdcd963c4051b8","assignee":{"login":"sebrexmetaswitch","id":4903681,"avatar_url":"https://avatars.githubusercontent.com/u/4903681?v=3","gravatar_id":"","url":"https://api.github.com/users/sebrexmetaswitch","html_url":"https://github.com/sebrexmetaswitch","followers_url":"https://api.github.com/users/sebrexmetaswitch/followers","following_url":"https://api.github.com/users/sebrexmetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/sebrexmetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/sebrexmetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebrexmetaswitch/subscriptions","organizations_url":"https://api.github.com/users/sebrexmetaswitch/orgs","repos_url":"https://api.github.com/users/sebrexmetaswitch/repos","events_url":"https://api.github.com/users/sebrexmetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/sebrexmetaswitch/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebrexmetaswitch","id":4903681,"avatar_url":"https://avatars.githubusercontent.com/u/4903681?v=3","gravatar_id":"","url":"https://api.github.com/users/sebrexmetaswitch","html_url":"https://github.com/sebrexmetaswitch","followers_url":"https://api.github.com/users/sebrexmetaswitch/followers","following_url":"https://api.github.com/users/sebrexmetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/sebrexmetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/sebrexmetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebrexmetaswitch/subscriptions","organizations_url":"https://api.github.com/users/sebrexmetaswitch/orgs","repos_url":"https://api.github.com/users/sebrexmetaswitch/repos","events_url":"https://api.github.com/users/sebrexmetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/sebrexmetaswitch/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/chronos/pulls/316/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/chronos/pulls/316/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/chronos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/chronos/issues/316/comments","statuses_url":"https://api.github.com/repos/Metaswitch/chronos/statuses/b773258219923143d86b3dbdb40fd54910c11581","head":{"label":"Metaswitch:issue_314","ref":"issue_314","sha":"b773258219923143d86b3dbdb40fd54910c11581","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":16410307,"name":"chronos","full_name":"Metaswitch/chronos","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/chronos","description":"A distributed, redundant, reliable timer service.","fork":false,"url":"https://api.github.com/repos/Metaswitch/chronos","forks_url":"https://api.github.com/repos/Metaswitch/chronos/forks","keys_url":"https://api.github.com/repos/Metaswitch/chronos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/chronos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/chronos/teams","hooks_url":"https://api.github.com/repos/Metaswitch/chronos/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/chronos/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/chronos/events","assignees_url":"https://api.github.com/repos/Metaswitch/chronos/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/chronos/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/chronos/tags","blobs_url":"https://api.github.com/repos/Metaswitch/chronos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/chronos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/chronos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/chronos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/chronos/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/chronos/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/chronos/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/chronos/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/chronos/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/chronos/subscription","commits_url":"https://api.github.com/repos/Metaswitch/chronos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/chronos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/chronos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/chronos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/chronos/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/chronos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/chronos/merges","archive_url":"https://api.github.com/repos/Metaswitch/chronos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/chronos/downloads","issues_url":"https://api.github.com/repos/Metaswitch/chronos/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/chronos/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/chronos/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/chronos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/chronos/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/chronos/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/chronos/deployments","created_at":"2014-01-31T14:36:31Z","updated_at":"2016-11-19T15:31:10Z","pushed_at":"2016-11-23T14:23:14Z","git_url":"git://github.com/Metaswitch/chronos.git","ssh_url":"git@github.com:Metaswitch/chronos.git","clone_url":"https://github.com/Metaswitch/chronos.git","svn_url":"https://github.com/Metaswitch/chronos","homepage":null,"size":1582,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":8,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"365c398501c59a2fd7fa7c8b4fe5068263345f36","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":16410307,"name":"chronos","full_name":"Metaswitch/chronos","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/chronos","description":"A distributed, redundant, reliable timer service.","fork":false,"url":"https://api.github.com/repos/Metaswitch/chronos","forks_url":"https://api.github.com/repos/Metaswitch/chronos/forks","keys_url":"https://api.github.com/repos/Metaswitch/chronos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/chronos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/chronos/teams","hooks_url":"https://api.github.com/repos/Metaswitch/chronos/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/chronos/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/chronos/events","assignees_url":"https://api.github.com/repos/Metaswitch/chronos/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/chronos/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/chronos/tags","blobs_url":"https://api.github.com/repos/Metaswitch/chronos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/chronos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/chronos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/chronos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/chronos/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/chronos/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/chronos/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/chronos/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/chronos/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/chronos/subscription","commits_url":"https://api.github.com/repos/Metaswitch/chronos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/chronos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/chronos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/chronos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/chronos/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/chronos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/chronos/merges","archive_url":"https://api.github.com/repos/Metaswitch/chronos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/chronos/downloads","issues_url":"https://api.github.com/repos/Metaswitch/chronos/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/chronos/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/chronos/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/chronos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/chronos/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/chronos/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/chronos/deployments","created_at":"2014-01-31T14:36:31Z","updated_at":"2016-11-19T15:31:10Z","pushed_at":"2016-11-23T14:23:14Z","git_url":"git://github.com/Metaswitch/chronos.git","ssh_url":"git@github.com:Metaswitch/chronos.git","clone_url":"https://github.com/Metaswitch/chronos.git","svn_url":"https://github.com/Metaswitch/chronos","homepage":null,"size":1582,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":8,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/chronos/pulls/316"},"html":{"href":"https://github.com/Metaswitch/chronos/pull/316"},"issue":{"href":"https://api.github.com/repos/Metaswitch/chronos/issues/316"},"comments":{"href":"https://api.github.com/repos/Metaswitch/chronos/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/chronos/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/chronos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/chronos/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/chronos/statuses/b773258219923143d86b3dbdb40fd54910c11581"}}}}
{"actor":{"display_login":"eleanor-merry"}}