{"action":"opened","number":342,"pull_request":{"url":"https://api.github.com/repos/aurelia/binding/pulls/342","id":62288023,"html_url":"https://github.com/aurelia/binding/pull/342","diff_url":"https://github.com/aurelia/binding/pull/342.diff","patch_url":"https://github.com/aurelia/binding/pull/342.patch","issue_url":"https://api.github.com/repos/aurelia/binding/issues/342","number":342,"state":"open","locked":false,"title":"[WIP] feat(logging): warn when property can't be defined","user":{"login":"gingerik","id":2738701,"avatar_url":"https://avatars.githubusercontent.com/u/2738701?v=3","gravatar_id":"","url":"https://api.github.com/users/gingerik","html_url":"https://github.com/gingerik","followers_url":"https://api.github.com/users/gingerik/followers","following_url":"https://api.github.com/users/gingerik/following{/other_user}","gists_url":"https://api.github.com/users/gingerik/gists{/gist_id}","starred_url":"https://api.github.com/users/gingerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingerik/subscriptions","organizations_url":"https://api.github.com/users/gingerik/orgs","repos_url":"https://api.github.com/users/gingerik/repos","events_url":"https://api.github.com/users/gingerik/events{/privacy}","received_events_url":"https://api.github.com/users/gingerik/received_events","type":"User","site_admin":false},"body":"First of all, this PR is not complete.\r\n\r\nFor some types of objects I wish not to allow adding properties after initialization (using `Object.preventExtensions()`). However, this also prevents Aurelia from observing these properties, as defining the required extra properties using `Object.defineProperty` fails. Currently, this is being ignored silently. This purpose of this PR is to add logging to the situations where this might occur.\r\nI've you find this PR useful, I can add loggers for the other `Object.defineProperty` occurrences as well.\r\n\r\nBy the way, I actually find `Reflect.defineProperty` to be a more elegant solution than try & catching. But as this requires an extra polyfill in aurelia-polyfills, I hereby first mention it as a suggestion.","created_at":"2016-03-09T20:09:19Z","updated_at":"2016-03-09T20:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/binding/pulls/342/commits","review_comments_url":"https://api.github.com/repos/aurelia/binding/pulls/342/comments","review_comment_url":"https://api.github.com/repos/aurelia/binding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/binding/issues/342/comments","statuses_url":"https://api.github.com/repos/aurelia/binding/statuses/d5dc30ebbbeb1cfc2a8c14f75c217191d25edcf8","head":{"label":"gingerik:log-failed-binding","ref":"log-failed-binding","sha":"d5dc30ebbbeb1cfc2a8c14f75c217191d25edcf8","user":{"login":"gingerik","id":2738701,"avatar_url":"https://avatars.githubusercontent.com/u/2738701?v=3","gravatar_id":"","url":"https://api.github.com/users/gingerik","html_url":"https://github.com/gingerik","followers_url":"https://api.github.com/users/gingerik/followers","following_url":"https://api.github.com/users/gingerik/following{/other_user}","gists_url":"https://api.github.com/users/gingerik/gists{/gist_id}","starred_url":"https://api.github.com/users/gingerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingerik/subscriptions","organizations_url":"https://api.github.com/users/gingerik/orgs","repos_url":"https://api.github.com/users/gingerik/repos","events_url":"https://api.github.com/users/gingerik/events{/privacy}","received_events_url":"https://api.github.com/users/gingerik/received_events","type":"User","site_admin":false},"repo":{"id":52154198,"name":"binding","full_name":"gingerik/binding","owner":{"login":"gingerik","id":2738701,"avatar_url":"https://avatars.githubusercontent.com/u/2738701?v=3","gravatar_id":"","url":"https://api.github.com/users/gingerik","html_url":"https://github.com/gingerik","followers_url":"https://api.github.com/users/gingerik/followers","following_url":"https://api.github.com/users/gingerik/following{/other_user}","gists_url":"https://api.github.com/users/gingerik/gists{/gist_id}","starred_url":"https://api.github.com/users/gingerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingerik/subscriptions","organizations_url":"https://api.github.com/users/gingerik/orgs","repos_url":"https://api.github.com/users/gingerik/repos","events_url":"https://api.github.com/users/gingerik/events{/privacy}","received_events_url":"https://api.github.com/users/gingerik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gingerik/binding","description":"A modern databinding library for JavaScript and HTML.","fork":true,"url":"https://api.github.com/repos/gingerik/binding","forks_url":"https://api.github.com/repos/gingerik/binding/forks","keys_url":"https://api.github.com/repos/gingerik/binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gingerik/binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gingerik/binding/teams","hooks_url":"https://api.github.com/repos/gingerik/binding/hooks","issue_events_url":"https://api.github.com/repos/gingerik/binding/issues/events{/number}","events_url":"https://api.github.com/repos/gingerik/binding/events","assignees_url":"https://api.github.com/repos/gingerik/binding/assignees{/user}","branches_url":"https://api.github.com/repos/gingerik/binding/branches{/branch}","tags_url":"https://api.github.com/repos/gingerik/binding/tags","blobs_url":"https://api.github.com/repos/gingerik/binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gingerik/binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gingerik/binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/gingerik/binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gingerik/binding/statuses/{sha}","languages_url":"https://api.github.com/repos/gingerik/binding/languages","stargazers_url":"https://api.github.com/repos/gingerik/binding/stargazers","contributors_url":"https://api.github.com/repos/gingerik/binding/contributors","subscribers_url":"https://api.github.com/repos/gingerik/binding/subscribers","subscription_url":"https://api.github.com/repos/gingerik/binding/subscription","commits_url":"https://api.github.com/repos/gingerik/binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/gingerik/binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/gingerik/binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/gingerik/binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/gingerik/binding/contents/{+path}","compare_url":"https://api.github.com/repos/gingerik/binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gingerik/binding/merges","archive_url":"https://api.github.com/repos/gingerik/binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gingerik/binding/downloads","issues_url":"https://api.github.com/repos/gingerik/binding/issues{/number}","pulls_url":"https://api.github.com/repos/gingerik/binding/pulls{/number}","milestones_url":"https://api.github.com/repos/gingerik/binding/milestones{/number}","notifications_url":"https://api.github.com/repos/gingerik/binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gingerik/binding/labels{/name}","releases_url":"https://api.github.com/repos/gingerik/binding/releases{/id}","deployments_url":"https://api.github.com/repos/gingerik/binding/deployments","created_at":"2016-02-20T13:17:25Z","updated_at":"2016-02-20T13:17:26Z","pushed_at":"2016-03-09T19:56:01Z","git_url":"git://github.com/gingerik/binding.git","ssh_url":"git@github.com:gingerik/binding.git","clone_url":"https://github.com/gingerik/binding.git","svn_url":"https://github.com/gingerik/binding","homepage":null,"size":2885,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"b0735323b2feae78e981181f3a67b4cce26225e9","user":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27744828,"name":"binding","full_name":"aurelia/binding","owner":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/binding","description":"A modern databinding library for JavaScript and HTML.","fork":false,"url":"https://api.github.com/repos/aurelia/binding","forks_url":"https://api.github.com/repos/aurelia/binding/forks","keys_url":"https://api.github.com/repos/aurelia/binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/binding/teams","hooks_url":"https://api.github.com/repos/aurelia/binding/hooks","issue_events_url":"https://api.github.com/repos/aurelia/binding/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/binding/events","assignees_url":"https://api.github.com/repos/aurelia/binding/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/binding/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/binding/tags","blobs_url":"https://api.github.com/repos/aurelia/binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/binding/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/binding/languages","stargazers_url":"https://api.github.com/repos/aurelia/binding/stargazers","contributors_url":"https://api.github.com/repos/aurelia/binding/contributors","subscribers_url":"https://api.github.com/repos/aurelia/binding/subscribers","subscription_url":"https://api.github.com/repos/aurelia/binding/subscription","commits_url":"https://api.github.com/repos/aurelia/binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/binding/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/binding/merges","archive_url":"https://api.github.com/repos/aurelia/binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/binding/downloads","issues_url":"https://api.github.com/repos/aurelia/binding/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/binding/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/binding/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/binding/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/binding/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/binding/deployments","created_at":"2014-12-09T02:00:32Z","updated_at":"2016-03-08T11:53:44Z","pushed_at":"2016-03-09T16:04:03Z","git_url":"git://github.com/aurelia/binding.git","ssh_url":"git@github.com:aurelia/binding.git","clone_url":"https://github.com/aurelia/binding.git","svn_url":"https://github.com/aurelia/binding","homepage":null,"size":3053,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":27,"forks":52,"open_issues":27,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/binding/pulls/342"},"html":{"href":"https://github.com/aurelia/binding/pull/342"},"issue":{"href":"https://api.github.com/repos/aurelia/binding/issues/342"},"comments":{"href":"https://api.github.com/repos/aurelia/binding/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/binding/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/binding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/binding/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/binding/statuses/d5dc30ebbbeb1cfc2a8c14f75c217191d25edcf8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":5,"changed_files":4}}