{"action":"closed","number":4211,"pull_request":{"url":"https://api.github.com/repos/atom/electron/pulls/4211","id":56989917,"html_url":"https://github.com/atom/electron/pull/4211","diff_url":"https://github.com/atom/electron/pull/4211.diff","patch_url":"https://github.com/atom/electron/pull/4211.patch","issue_url":"https://api.github.com/repos/atom/electron/issues/4211","number":4211,"state":"closed","locked":false,"title":"Add app.dock.setIcon to change icon of dock","user":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"body":"It's related with #4084 and It's my first contribute that add a new feature so please let me know if something went wrong. I couldn't find any test for `app.dock` APIs. is it right?","created_at":"2016-01-23T23:32:56Z","updated_at":"2016-01-24T14:36:28Z","closed_at":"2016-01-24T14:36:28Z","merged_at":"2016-01-24T14:36:28Z","merge_commit_sha":"4d6f022ec03e200d75e093eb4af6a978d7e26edb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/electron/pulls/4211/commits","review_comments_url":"https://api.github.com/repos/atom/electron/pulls/4211/comments","review_comment_url":"https://api.github.com/repos/atom/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/electron/issues/4211/comments","statuses_url":"https://api.github.com/repos/atom/electron/statuses/7229d2462a7df262c5c3f54e88c4b5472daffa18","head":{"label":"ragingwind:dock-seticon","ref":"dock-seticon","sha":"7229d2462a7df262c5c3f54e88c4b5472daffa18","user":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"repo":{"id":50021461,"name":"electron","full_name":"ragingwind/electron","owner":{"login":"ragingwind","id":124117,"avatar_url":"https://avatars.githubusercontent.com/u/124117?v=3","gravatar_id":"","url":"https://api.github.com/users/ragingwind","html_url":"https://github.com/ragingwind","followers_url":"https://api.github.com/users/ragingwind/followers","following_url":"https://api.github.com/users/ragingwind/following{/other_user}","gists_url":"https://api.github.com/users/ragingwind/gists{/gist_id}","starred_url":"https://api.github.com/users/ragingwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragingwind/subscriptions","organizations_url":"https://api.github.com/users/ragingwind/orgs","repos_url":"https://api.github.com/users/ragingwind/repos","events_url":"https://api.github.com/users/ragingwind/events{/privacy}","received_events_url":"https://api.github.com/users/ragingwind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ragingwind/electron","description":"Build cross platform desktop apps with web technologies","fork":true,"url":"https://api.github.com/repos/ragingwind/electron","forks_url":"https://api.github.com/repos/ragingwind/electron/forks","keys_url":"https://api.github.com/repos/ragingwind/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ragingwind/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ragingwind/electron/teams","hooks_url":"https://api.github.com/repos/ragingwind/electron/hooks","issue_events_url":"https://api.github.com/repos/ragingwind/electron/issues/events{/number}","events_url":"https://api.github.com/repos/ragingwind/electron/events","assignees_url":"https://api.github.com/repos/ragingwind/electron/assignees{/user}","branches_url":"https://api.github.com/repos/ragingwind/electron/branches{/branch}","tags_url":"https://api.github.com/repos/ragingwind/electron/tags","blobs_url":"https://api.github.com/repos/ragingwind/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ragingwind/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ragingwind/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/ragingwind/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ragingwind/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/ragingwind/electron/languages","stargazers_url":"https://api.github.com/repos/ragingwind/electron/stargazers","contributors_url":"https://api.github.com/repos/ragingwind/electron/contributors","subscribers_url":"https://api.github.com/repos/ragingwind/electron/subscribers","subscription_url":"https://api.github.com/repos/ragingwind/electron/subscription","commits_url":"https://api.github.com/repos/ragingwind/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/ragingwind/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/ragingwind/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/ragingwind/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/ragingwind/electron/contents/{+path}","compare_url":"https://api.github.com/repos/ragingwind/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ragingwind/electron/merges","archive_url":"https://api.github.com/repos/ragingwind/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ragingwind/electron/downloads","issues_url":"https://api.github.com/repos/ragingwind/electron/issues{/number}","pulls_url":"https://api.github.com/repos/ragingwind/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/ragingwind/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/ragingwind/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ragingwind/electron/labels{/name}","releases_url":"https://api.github.com/repos/ragingwind/electron/releases{/id}","deployments_url":"https://api.github.com/repos/ragingwind/electron/deployments","created_at":"2016-01-20T10:05:00Z","updated_at":"2016-01-20T10:05:04Z","pushed_at":"2016-01-23T23:30:29Z","git_url":"git://github.com/ragingwind/electron.git","ssh_url":"git@github.com:ragingwind/electron.git","clone_url":"https://github.com/ragingwind/electron.git","svn_url":"https://github.com/ragingwind/electron","homepage":"http://electron.atom.io","size":13176,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"31624995bce7f8ee918608e1a23d25ffb93f9b48","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"atom/electron","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/atom/electron","forks_url":"https://api.github.com/repos/atom/electron/forks","keys_url":"https://api.github.com/repos/atom/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/electron/teams","hooks_url":"https://api.github.com/repos/atom/electron/hooks","issue_events_url":"https://api.github.com/repos/atom/electron/issues/events{/number}","events_url":"https://api.github.com/repos/atom/electron/events","assignees_url":"https://api.github.com/repos/atom/electron/assignees{/user}","branches_url":"https://api.github.com/repos/atom/electron/branches{/branch}","tags_url":"https://api.github.com/repos/atom/electron/tags","blobs_url":"https://api.github.com/repos/atom/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/electron/languages","stargazers_url":"https://api.github.com/repos/atom/electron/stargazers","contributors_url":"https://api.github.com/repos/atom/electron/contributors","subscribers_url":"https://api.github.com/repos/atom/electron/subscribers","subscription_url":"https://api.github.com/repos/atom/electron/subscription","commits_url":"https://api.github.com/repos/atom/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/electron/contents/{+path}","compare_url":"https://api.github.com/repos/atom/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/electron/merges","archive_url":"https://api.github.com/repos/atom/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/electron/downloads","issues_url":"https://api.github.com/repos/atom/electron/issues{/number}","pulls_url":"https://api.github.com/repos/atom/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/electron/labels{/name}","releases_url":"https://api.github.com/repos/atom/electron/releases{/id}","deployments_url":"https://api.github.com/repos/atom/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2016-01-24T14:04:41Z","pushed_at":"2016-01-24T14:36:28Z","git_url":"git://github.com/atom/electron.git","ssh_url":"git@github.com:atom/electron.git","clone_url":"https://github.com/atom/electron.git","svn_url":"https://github.com/atom/electron","homepage":"http://electron.atom.io","size":17013,"stargazers_count":22770,"watchers_count":22770,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2210,"mirror_url":null,"open_issues_count":245,"forks":2210,"open_issues":245,"watchers":22770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/4211"},"html":{"href":"https://github.com/atom/electron/pull/4211"},"issue":{"href":"https://api.github.com/repos/atom/electron/issues/4211"},"comments":{"href":"https://api.github.com/repos/atom/electron/issues/4211/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/electron/pulls/4211/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/electron/pulls/4211/commits"},"statuses":{"href":"https://api.github.com/repos/atom/electron/statuses/7229d2462a7df262c5c3f54e88c4b5472daffa18"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"comments":1,"review_comments":0,"commits":1,"additions":23,"deletions":1,"changed_files":5}}