{"action":"created","comment":{"url":"https://api.github.com/repos/zenoss/inspector/pulls/comments/71906747","id":71906747,"diff_hunk":"@@ -53,22 +67,38 @@ def main():\n             service.enabled = nameValuePair[1] == \"enabled\" or nameValuePair[1] == \"static\"\n \n     # Verify the service states CC expects\n-    dnsmasqInstalled = dockerInstalled = ntpInstalled = servicedInstalled = False\n+    dnsmasqInstalled = dockerInstalled = ntpInstalled = servicedInstalled = corosyncInstalled = pacemakerInstalled = False\n     for service in services:\n         if service.name.startswith(\"dnsmasq\"):\n             dnsmasqInstalled = True\n             service.validateEnabledAndActive()\n-        elif service.name.startswith(\"docker\"):\n-            dockerInstalled = True\n-            service.validateEnabledAndActive()\n         elif service.name.startswith(\"firewalld\"):\n             service.validateDisabledAndStopped()\n         elif service.name.startswith(\"ntp\"):\n             ntpInstalled = True\n             service.validateEnabledAndActive()\n+        elif not isHA:\n+            if service.name.startswith(\"docker\"):\n+                dockerInstalled = True\n+                service.validateEnabledAndActive()\n+            elif service.name.startswith(\"serviced\"):\n+                servicedInstalled = True\n+                service.validateEnabledAndActive()\n+        #\n+        # Every check below assumes we're in an HA environment.\n+        elif service.name.startswith(\"corosync\"):\n+            corosyncInstalled = True\n+            service.validateEnabledAndActive()\n+        elif service.name.startswith(\"pacemaker\"):\n+            pacemakerInstalled = True\n+            service.validateEnabledAndActive()\n+        elif service.name.startswith(\"docker\"):\n+            dockerInstalled = True\n+            service.validateDisabledAndStopped()\n         elif service.name.startswith(\"serviced\"):\n             servicedInstalled = True\n-            service.validateEnabledAndActive()\n+            service.validateDisabledAndStopped()\n+","path":"scripts/service-status.py","position":78,"original_position":78,"commit_id":"ce628e2ba1a6619a24a3a9c51df9a8ed63866186","original_commit_id":"ce628e2ba1a6619a24a3a9c51df9a8ed63866186","user":{"login":"tgjonestx","id":2204589,"avatar_url":"https://avatars.githubusercontent.com/u/2204589?v=3","gravatar_id":"","url":"https://api.github.com/users/tgjonestx","html_url":"https://github.com/tgjonestx","followers_url":"https://api.github.com/users/tgjonestx/followers","following_url":"https://api.github.com/users/tgjonestx/following{/other_user}","gists_url":"https://api.github.com/users/tgjonestx/gists{/gist_id}","starred_url":"https://api.github.com/users/tgjonestx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgjonestx/subscriptions","organizations_url":"https://api.github.com/users/tgjonestx/orgs","repos_url":"https://api.github.com/users/tgjonestx/repos","events_url":"https://api.github.com/users/tgjonestx/events{/privacy}","received_events_url":"https://api.github.com/users/tgjonestx/received_events","type":"User","site_admin":false},"body":"Yes.  In an HA environment, PCS controls starting and stopping whatever system services are managed by PCS.","created_at":"2016-07-22T16:28:40Z","updated_at":"2016-07-22T16:28:40Z","html_url":"https://github.com/zenoss/inspector/pull/44#discussion_r71906747","pull_request_url":"https://api.github.com/repos/zenoss/inspector/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/zenoss/inspector/pulls/comments/71906747"},"html":{"href":"https://github.com/zenoss/inspector/pull/44#discussion_r71906747"},"pull_request":{"href":"https://api.github.com/repos/zenoss/inspector/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/zenoss/inspector/pulls/44","id":77552717,"html_url":"https://github.com/zenoss/inspector/pull/44","diff_url":"https://github.com/zenoss/inspector/pull/44.diff","patch_url":"https://github.com/zenoss/inspector/pull/44.patch","issue_url":"https://api.github.com/repos/zenoss/inspector/issues/44","number":44,"state":"open","locked":false,"title":"Additions to collect and check HA info","user":{"login":"tgjonestx","id":2204589,"avatar_url":"https://avatars.githubusercontent.com/u/2204589?v=3","gravatar_id":"","url":"https://api.github.com/users/tgjonestx","html_url":"https://github.com/tgjonestx","followers_url":"https://api.github.com/users/tgjonestx/followers","following_url":"https://api.github.com/users/tgjonestx/following{/other_user}","gists_url":"https://api.github.com/users/tgjonestx/gists{/gist_id}","starred_url":"https://api.github.com/users/tgjonestx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgjonestx/subscriptions","organizations_url":"https://api.github.com/users/tgjonestx/orgs","repos_url":"https://api.github.com/users/tgjonestx/repos","events_url":"https://api.github.com/users/tgjonestx/events{/privacy}","received_events_url":"https://api.github.com/users/tgjonestx/received_events","type":"User","site_admin":false},"body":"Fixes INSP-3","created_at":"2016-07-15T01:50:48Z","updated_at":"2016-07-22T16:28:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e950d03d9e91b13ef6133f240275bd614650fe5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zenoss/inspector/pulls/44/commits","review_comments_url":"https://api.github.com/repos/zenoss/inspector/pulls/44/comments","review_comment_url":"https://api.github.com/repos/zenoss/inspector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenoss/inspector/issues/44/comments","statuses_url":"https://api.github.com/repos/zenoss/inspector/statuses/ce628e2ba1a6619a24a3a9c51df9a8ed63866186","head":{"label":"zenoss:feature/INSP-3","ref":"feature/INSP-3","sha":"ce628e2ba1a6619a24a3a9c51df9a8ed63866186","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":23436765,"name":"inspector","full_name":"zenoss/inspector","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/inspector","description":"","fork":false,"url":"https://api.github.com/repos/zenoss/inspector","forks_url":"https://api.github.com/repos/zenoss/inspector/forks","keys_url":"https://api.github.com/repos/zenoss/inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/inspector/teams","hooks_url":"https://api.github.com/repos/zenoss/inspector/hooks","issue_events_url":"https://api.github.com/repos/zenoss/inspector/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/inspector/events","assignees_url":"https://api.github.com/repos/zenoss/inspector/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/inspector/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/inspector/tags","blobs_url":"https://api.github.com/repos/zenoss/inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/inspector/languages","stargazers_url":"https://api.github.com/repos/zenoss/inspector/stargazers","contributors_url":"https://api.github.com/repos/zenoss/inspector/contributors","subscribers_url":"https://api.github.com/repos/zenoss/inspector/subscribers","subscription_url":"https://api.github.com/repos/zenoss/inspector/subscription","commits_url":"https://api.github.com/repos/zenoss/inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/inspector/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/inspector/merges","archive_url":"https://api.github.com/repos/zenoss/inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/inspector/downloads","issues_url":"https://api.github.com/repos/zenoss/inspector/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/inspector/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/inspector/releases{/id}","deployments_url":"https://api.github.com/repos/zenoss/inspector/deployments","created_at":"2014-08-28T17:26:00Z","updated_at":"2016-03-28T07:36:05Z","pushed_at":"2016-07-20T23:02:32Z","git_url":"git://github.com/zenoss/inspector.git","ssh_url":"git@github.com:zenoss/inspector.git","clone_url":"https://github.com/zenoss/inspector.git","svn_url":"https://github.com/zenoss/inspector","homepage":"","size":318,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"zenoss:master","ref":"master","sha":"ba3528fdec7c57e866ae2e84c944bbd335747765","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":23436765,"name":"inspector","full_name":"zenoss/inspector","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/inspector","description":"","fork":false,"url":"https://api.github.com/repos/zenoss/inspector","forks_url":"https://api.github.com/repos/zenoss/inspector/forks","keys_url":"https://api.github.com/repos/zenoss/inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/inspector/teams","hooks_url":"https://api.github.com/repos/zenoss/inspector/hooks","issue_events_url":"https://api.github.com/repos/zenoss/inspector/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/inspector/events","assignees_url":"https://api.github.com/repos/zenoss/inspector/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/inspector/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/inspector/tags","blobs_url":"https://api.github.com/repos/zenoss/inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/inspector/languages","stargazers_url":"https://api.github.com/repos/zenoss/inspector/stargazers","contributors_url":"https://api.github.com/repos/zenoss/inspector/contributors","subscribers_url":"https://api.github.com/repos/zenoss/inspector/subscribers","subscription_url":"https://api.github.com/repos/zenoss/inspector/subscription","commits_url":"https://api.github.com/repos/zenoss/inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/inspector/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/inspector/merges","archive_url":"https://api.github.com/repos/zenoss/inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/inspector/downloads","issues_url":"https://api.github.com/repos/zenoss/inspector/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/inspector/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/inspector/releases{/id}","deployments_url":"https://api.github.com/repos/zenoss/inspector/deployments","created_at":"2014-08-28T17:26:00Z","updated_at":"2016-03-28T07:36:05Z","pushed_at":"2016-07-20T23:02:32Z","git_url":"git://github.com/zenoss/inspector.git","ssh_url":"git@github.com:zenoss/inspector.git","clone_url":"https://github.com/zenoss/inspector.git","svn_url":"https://github.com/zenoss/inspector","homepage":"","size":318,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zenoss/inspector/pulls/44"},"html":{"href":"https://github.com/zenoss/inspector/pull/44"},"issue":{"href":"https://api.github.com/repos/zenoss/inspector/issues/44"},"comments":{"href":"https://api.github.com/repos/zenoss/inspector/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/zenoss/inspector/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/zenoss/inspector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenoss/inspector/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/zenoss/inspector/statuses/ce628e2ba1a6619a24a3a9c51df9a8ed63866186"}}}}
{"actor":{"display_login":"tgjonestx"}}