{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/536","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/536/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/536/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/536/events","html_url":"https://github.com/greenplum-db/gpdb/pull/536","id":141413092,"number":536,"title":"Moved S3 gtest to gpAux/extensions and update gtest framework.","user":{"login":"hardikar","id":2496677,"avatar_url":"https://avatars.githubusercontent.com/u/2496677?v=3","gravatar_id":"","url":"https://api.github.com/users/hardikar","html_url":"https://github.com/hardikar","followers_url":"https://api.github.com/users/hardikar/followers","following_url":"https://api.github.com/users/hardikar/following{/other_user}","gists_url":"https://api.github.com/users/hardikar/gists{/gist_id}","starred_url":"https://api.github.com/users/hardikar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardikar/subscriptions","organizations_url":"https://api.github.com/users/hardikar/orgs","repos_url":"https://api.github.com/users/hardikar/repos","events_url":"https://api.github.com/users/hardikar/events{/privacy}","received_events_url":"https://api.github.com/users/hardikar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2016-03-16T21:54:11Z","updated_at":"2016-03-21T20:19:22Z","closed_at":"2016-03-19T00:10:37Z","pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/536","html_url":"https://github.com/greenplum-db/gpdb/pull/536","diff_url":"https://github.com/greenplum-db/gpdb/pull/536.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/536.patch"},"body":"Gtest is a testing framework that can be used by multiple modules and not only by the gps3ext module. With this in mind, we propose to move the gtest sources to gpAux/extensions/ where other libraries can link to it. Since we intend for this framework to be used in other places within GPDB, we ported the entire gtest framework in. We also updated gps3ext makefiles to use the correct gtest directory.\r\n\r\nTesting:\r\n./configure and make works correctly and builds GPDB.\r\ncd gpAux/extensions/gps3ext && make && make -f Makefile.test compiles and runs correctly.\r\n\r\nAuthors: Nikos Armenatzoglou and Shreedhar Hardikar."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/199458938","html_url":"https://github.com/greenplum-db/gpdb/pull/536#issuecomment-199458938","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/536","id":199458938,"user":{"login":"vraghavan78","id":12649877,"avatar_url":"https://avatars.githubusercontent.com/u/12649877?v=3","gravatar_id":"","url":"https://api.github.com/users/vraghavan78","html_url":"https://github.com/vraghavan78","followers_url":"https://api.github.com/users/vraghavan78/followers","following_url":"https://api.github.com/users/vraghavan78/following{/other_user}","gists_url":"https://api.github.com/users/vraghavan78/gists{/gist_id}","starred_url":"https://api.github.com/users/vraghavan78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraghavan78/subscriptions","organizations_url":"https://api.github.com/users/vraghavan78/orgs","repos_url":"https://api.github.com/users/vraghavan78/repos","events_url":"https://api.github.com/users/vraghavan78/events{/privacy}","received_events_url":"https://api.github.com/users/vraghavan78/received_events","type":"User","site_admin":false},"created_at":"2016-03-21T20:19:22Z","updated_at":"2016-03-21T20:19:22Z","body":"I agree with @gcaragea completely banning frameworks and utilities needed for a functionality before a complete end-to-end prototype does not foster incremental innovation. This will only lead to long living private branches which open other can of worms.\r\n\r\nAs long, new work does not hinder upstream merges too much we should march on with confidence but with mindfulness!"}}