{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/89669818","pull_request_review_id":10213654,"id":89669818,"diff_hunk":"@@ -218,7 +218,7 @@ case $host in\n     platform_cflags=\"-fPIC -DPIC\"\n     platform_cxxflags=\"$platform_cflags\"\n     platform_os=\"linux\"\n-    platform_arch=\"x86_64\"\n+    platform_arch=\"x86-64\"","path":"tools/depends/configure.ac","position":null,"original_position":16,"commit_id":"7f9d748591f15eaeff53fc09066aa6ba4904f739","original_commit_id":"2103e34796c369133e99a45262f00b0ad8153466","user":{"login":"peak3d","id":22704999,"avatar_url":"https://avatars.githubusercontent.com/u/22704999?v=3","gravatar_id":"","url":"https://api.github.com/users/peak3d","html_url":"https://github.com/peak3d","followers_url":"https://api.github.com/users/peak3d/followers","following_url":"https://api.github.com/users/peak3d/following{/other_user}","gists_url":"https://api.github.com/users/peak3d/gists{/gist_id}","starred_url":"https://api.github.com/users/peak3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peak3d/subscriptions","organizations_url":"https://api.github.com/users/peak3d/orgs","repos_url":"https://api.github.com/users/peak3d/repos","events_url":"https://api.github.com/users/peak3d/events{/privacy}","received_events_url":"https://api.github.com/users/peak3d/received_events","type":"User","site_admin":false},"body":"was a mistake :-) This happens if one do things too late at night","created_at":"2016-11-26T10:50:09Z","updated_at":"2016-11-26T10:50:09Z","html_url":"https://github.com/xbmc/xbmc/pull/10983#discussion_r89669818","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10983","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/89669818"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10983#discussion_r89669818"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10983"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10983","id":95259061,"html_url":"https://github.com/xbmc/xbmc/pull/10983","diff_url":"https://github.com/xbmc/xbmc/pull/10983.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10983.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10983","number":10983,"state":"open","locked":false,"title":"[cmake] split arch / cpu","user":{"login":"peak3d","id":22704999,"avatar_url":"https://avatars.githubusercontent.com/u/22704999?v=3","gravatar_id":"","url":"https://api.github.com/users/peak3d","html_url":"https://github.com/peak3d","followers_url":"https://api.github.com/users/peak3d/followers","following_url":"https://api.github.com/users/peak3d/following{/other_user}","gists_url":"https://api.github.com/users/peak3d/gists{/gist_id}","starred_url":"https://api.github.com/users/peak3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peak3d/subscriptions","organizations_url":"https://api.github.com/users/peak3d/orgs","repos_url":"https://api.github.com/users/peak3d/repos","events_url":"https://api.github.com/users/peak3d/events{/privacy}","received_events_url":"https://api.github.com/users/peak3d/received_events","type":"User","site_admin":false},"body":"CMake / depends: introduce a clear split between ARCH and CPU\r\n\r\n## Description\r\nThis PR allows the definition of ARCH and CPU in the kodi depends and cmake step to be able building optimized versions for a specific machine.\r\nCurrently all is done using a single environment value \"CPU\" wich tries to make magic things during the build steps (sometimes hardcoded CPU's and architectures).\r\n\r\n## Motivation and Context\r\nMotivation: Create an optimized build for my armv7-a arch and cortex-a5 cpu and be also able to create generic builds if no special architecture / cpu is targetted.\r\nContext: Allow options to define these values at the configure step of depends and transport make them available to the cmake step\r\n\r\n## Notes\r\n- the complete build is done with a generic architecture [X86_64 / arm / aarch64 ...], the parameters --with-arch and --with-cpu are only used for tuning.\r\n- The buildstep folder arm64-v8a was renamed to arm64 because v8a is not a general architecture.\r\n- I didn't modify the hardcoded CPU settings in configure.ac for rpi, because I'm not familiar with them.\r\n\r\n## How Has This Been Tested?\r\n- Specific builds for odroids armv7 / aarch64 / linux / android\r\n- Jenkins build for all platforms\r\n\r\n## Types of change\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n","created_at":"2016-11-25T07:13:20Z","updated_at":"2016-11-26T10:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"652880d98fbc994a58d787f8afb39d54a6b35520","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10983/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10983/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10983/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/7f9d748591f15eaeff53fc09066aa6ba4904f739","head":{"label":"peak3d:arch_cpu","ref":"arch_cpu","sha":"7f9d748591f15eaeff53fc09066aa6ba4904f739","user":{"login":"peak3d","id":22704999,"avatar_url":"https://avatars.githubusercontent.com/u/22704999?v=3","gravatar_id":"","url":"https://api.github.com/users/peak3d","html_url":"https://github.com/peak3d","followers_url":"https://api.github.com/users/peak3d/followers","following_url":"https://api.github.com/users/peak3d/following{/other_user}","gists_url":"https://api.github.com/users/peak3d/gists{/gist_id}","starred_url":"https://api.github.com/users/peak3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peak3d/subscriptions","organizations_url":"https://api.github.com/users/peak3d/orgs","repos_url":"https://api.github.com/users/peak3d/repos","events_url":"https://api.github.com/users/peak3d/events{/privacy}","received_events_url":"https://api.github.com/users/peak3d/received_events","type":"User","site_admin":false},"repo":{"id":36955169,"name":"xbmc","full_name":"peak3d/xbmc","owner":{"login":"peak3d","id":22704999,"avatar_url":"https://avatars.githubusercontent.com/u/22704999?v=3","gravatar_id":"","url":"https://api.github.com/users/peak3d","html_url":"https://github.com/peak3d","followers_url":"https://api.github.com/users/peak3d/followers","following_url":"https://api.github.com/users/peak3d/following{/other_user}","gists_url":"https://api.github.com/users/peak3d/gists{/gist_id}","starred_url":"https://api.github.com/users/peak3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peak3d/subscriptions","organizations_url":"https://api.github.com/users/peak3d/orgs","repos_url":"https://api.github.com/users/peak3d/repos","events_url":"https://api.github.com/users/peak3d/events{/privacy}","received_events_url":"https://api.github.com/users/peak3d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peak3d/xbmc","description":"ODROID Modifed Kodi (except master)","fork":true,"url":"https://api.github.com/repos/peak3d/xbmc","forks_url":"https://api.github.com/repos/peak3d/xbmc/forks","keys_url":"https://api.github.com/repos/peak3d/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peak3d/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peak3d/xbmc/teams","hooks_url":"https://api.github.com/repos/peak3d/xbmc/hooks","issue_events_url":"https://api.github.com/repos/peak3d/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/peak3d/xbmc/events","assignees_url":"https://api.github.com/repos/peak3d/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/peak3d/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/peak3d/xbmc/tags","blobs_url":"https://api.github.com/repos/peak3d/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peak3d/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peak3d/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/peak3d/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peak3d/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/peak3d/xbmc/languages","stargazers_url":"https://api.github.com/repos/peak3d/xbmc/stargazers","contributors_url":"https://api.github.com/repos/peak3d/xbmc/contributors","subscribers_url":"https://api.github.com/repos/peak3d/xbmc/subscribers","subscription_url":"https://api.github.com/repos/peak3d/xbmc/subscription","commits_url":"https://api.github.com/repos/peak3d/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/peak3d/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/peak3d/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/peak3d/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/peak3d/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/peak3d/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peak3d/xbmc/merges","archive_url":"https://api.github.com/repos/peak3d/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peak3d/xbmc/downloads","issues_url":"https://api.github.com/repos/peak3d/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/peak3d/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/peak3d/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/peak3d/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peak3d/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/peak3d/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/peak3d/xbmc/deployments","created_at":"2015-06-05T21:01:07Z","updated_at":"2016-10-08T11:27:32Z","pushed_at":"2016-11-26T10:01:50Z","git_url":"git://github.com/peak3d/xbmc.git","ssh_url":"git@github.com:peak3d/xbmc.git","clone_url":"https://github.com/peak3d/xbmc.git","svn_url":"https://github.com/peak3d/xbmc","homepage":"http://forum.odroid.com","size":558861,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"d54279c915d17718dd7f64e802855d92711fc483","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-11-26T08:43:39Z","pushed_at":"2016-11-26T10:01:54Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1782496,"stargazers_count":5215,"watchers_count":5215,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3755,"mirror_url":null,"open_issues_count":212,"forks":3755,"open_issues":212,"watchers":5215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10983"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10983"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10983"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10983/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10983/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10983/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/7f9d748591f15eaeff53fc09066aa6ba4904f739"}}}}
{"actor":{"display_login":"peak3d"}}