{"action":"created","comment":{"url":"https://api.github.com/repos/angular/tsickle/pulls/comments/78862145","id":78862145,"diff_hunk":"@@ -2,8 +2,16 @@ import * as path from 'path';\n \n // Postprocess generated JS.\n export function pathToModuleName(context: string, fileName: string): string {\n+  fileName = fileName.replace(/\\.js$/, '');\n+\n   if (fileName[0] === '.') {\n+    // './foo' or '../foo'.\n+    // Resolve the path against the dirname of the current module.\n     fileName = path.join(path.dirname(context), fileName);\n   }\n-  return fileName.replace(/\\.js$/, '').replace(/\\//g, '.');\n+  // Replace characters not supported by goog.module.\n+  let moduleName =","path":"src/cli_support.ts","position":13,"original_position":13,"commit_id":"81f573ad8cd365f88aa4c3d88a5e89aef47ab629","original_commit_id":"81f573ad8cd365f88aa4c3d88a5e89aef47ab629","user":{"login":"evmar","id":3847,"avatar_url":"https://avatars.githubusercontent.com/u/3847?v=3","gravatar_id":"","url":"https://api.github.com/users/evmar","html_url":"https://github.com/evmar","followers_url":"https://api.github.com/users/evmar/followers","following_url":"https://api.github.com/users/evmar/following{/other_user}","gists_url":"https://api.github.com/users/evmar/gists{/gist_id}","starred_url":"https://api.github.com/users/evmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evmar/subscriptions","organizations_url":"https://api.github.com/users/evmar/orgs","repos_url":"https://api.github.com/users/evmar/repos","events_url":"https://api.github.com/users/evmar/events{/privacy}","received_events_url":"https://api.github.com/users/evmar/received_events","type":"User","site_admin":false},"body":"I dunno.  :~(  I figure this worked for @jjudd so maybe we should just merge it unless there are problems.","created_at":"2016-09-14T23:17:31Z","updated_at":"2016-09-14T23:17:31Z","html_url":"https://github.com/angular/tsickle/pull/207#discussion_r78862145","pull_request_url":"https://api.github.com/repos/angular/tsickle/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments/78862145"},"html":{"href":"https://github.com/angular/tsickle/pull/207#discussion_r78862145"},"pull_request":{"href":"https://api.github.com/repos/angular/tsickle/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/angular/tsickle/pulls/207","id":85321473,"html_url":"https://github.com/angular/tsickle/pull/207","diff_url":"https://github.com/angular/tsickle/pull/207.diff","patch_url":"https://github.com/angular/tsickle/pull/207.patch","issue_url":"https://api.github.com/repos/angular/tsickle/issues/207","number":207,"state":"open","locked":false,"title":"Replace illegal characters when converting to goog.module","user":{"login":"evmar","id":3847,"avatar_url":"https://avatars.githubusercontent.com/u/3847?v=3","gravatar_id":"","url":"https://api.github.com/users/evmar","html_url":"https://github.com/evmar","followers_url":"https://api.github.com/users/evmar/followers","following_url":"https://api.github.com/users/evmar/following{/other_user}","gists_url":"https://api.github.com/users/evmar/gists{/gist_id}","starred_url":"https://api.github.com/users/evmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evmar/subscriptions","organizations_url":"https://api.github.com/users/evmar/orgs","repos_url":"https://api.github.com/users/evmar/repos","events_url":"https://api.github.com/users/evmar/events{/privacy}","received_events_url":"https://api.github.com/users/evmar/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-14T23:08:01Z","updated_at":"2016-09-14T23:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7697adaa6e45325fabb1c8c6c9e976d194825924","assignee":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/tsickle/pulls/207/commits","review_comments_url":"https://api.github.com/repos/angular/tsickle/pulls/207/comments","review_comment_url":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/tsickle/issues/207/comments","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/81f573ad8cd365f88aa4c3d88a5e89aef47ab629","head":{"label":"angular:illegal-chars","ref":"illegal-chars","sha":"81f573ad8cd365f88aa4c3d88a5e89aef47ab629","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Annotator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2016-09-13T15:16:02Z","pushed_at":"2016-09-14T23:08:01Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":645,"stargazers_count":73,"watchers_count":73,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":39,"forks":12,"open_issues":39,"watchers":73,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"c2d525ae57f3e69cd4a6be26a89554531775d5f0","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Annotator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2016-09-13T15:16:02Z","pushed_at":"2016-09-14T23:08:01Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":645,"stargazers_count":73,"watchers_count":73,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":39,"forks":12,"open_issues":39,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/207"},"html":{"href":"https://github.com/angular/tsickle/pull/207"},"issue":{"href":"https://api.github.com/repos/angular/tsickle/issues/207"},"comments":{"href":"https://api.github.com/repos/angular/tsickle/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/tsickle/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/tsickle/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/angular/tsickle/statuses/81f573ad8cd365f88aa4c3d88a5e89aef47ab629"}}}}
{"actor":{"display_login":"evmar"}}