{"action":"created","comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/49761755","id":49761755,"diff_hunk":"@@ -665,14 +665,29 @@ void Nnet::Check() const {\n     const NetworkNode &node = nodes_[n];\n     std::string node_name = node_names_[n];\n     KALDI_ASSERT(GetNodeIndex(node_name) == n);\n+    int32 node_index_reserved = GetNodeIndex(node_name +\n+                                             \"_STATE_PREVIOUS_MINIBATCH\");\n+    if (node_index_reserved != -1 && \n+        (!IsInputNode(node_index_reserved) || !IsOutputNode(n) ||\n+      node_name == \"output\"))\n+      KALDI_ERR << \" The name \\\"\" << node_name << \"\\\" with suffix \\\"\"","path":"src/nnet3/nnet-nnet.cc","position":9,"original_position":9,"commit_id":"e9b0c566216ed42560a220c1702b03c048e4404e","original_commit_id":"577f2678d47acfde8939cad9144717510e95390b","user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"body":"I don't like the fact that this type of code, which relates to a specific use of the core nnet code, is mixed up in the 'core' parts of the framework.  None of this stuff should affect the core parts of the framework at all.  If you want to check this kind of thing, you can create a function that checks that the names have been correctly assigned, and call it from the code that deals with this type of framework.  See the function IsSimpleNnet as an example-- only the code that cares that the nnet has this particular configuration, checks it.","created_at":"2016-01-14T18:11:25Z","updated_at":"2016-01-14T18:11:25Z","html_url":"https://github.com/kaldi-asr/kaldi/pull/432#discussion_r49761755","pull_request_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432","_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/49761755"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/432#discussion_r49761755"},"pull_request":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432","id":55026828,"html_url":"https://github.com/kaldi-asr/kaldi/pull/432","diff_url":"https://github.com/kaldi-asr/kaldi/pull/432.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/432.patch","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/432","number":432,"state":"open","locked":false,"title":"WIP: state preserving LSTM","user":{"login":"freewym","id":3506322,"avatar_url":"https://avatars.githubusercontent.com/u/3506322?v=3","gravatar_id":"","url":"https://api.github.com/users/freewym","html_url":"https://github.com/freewym","followers_url":"https://api.github.com/users/freewym/followers","following_url":"https://api.github.com/users/freewym/following{/other_user}","gists_url":"https://api.github.com/users/freewym/gists{/gist_id}","starred_url":"https://api.github.com/users/freewym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freewym/subscriptions","organizations_url":"https://api.github.com/users/freewym/orgs","repos_url":"https://api.github.com/users/freewym/repos","events_url":"https://api.github.com/users/freewym/events{/privacy}","received_events_url":"https://api.github.com/users/freewym/received_events","type":"User","site_admin":false},"body":"Still contains some code for debug (lines ended with \"//debug\") and diagnosis (e.g, Timer).","created_at":"2016-01-04T21:50:00Z","updated_at":"2016-01-14T18:11:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e192bd864897fce9690a2f82486dbed376bd99f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432/commits","review_comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432/comments","review_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/432/comments","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/e9b0c566216ed42560a220c1702b03c048e4404e","head":{"label":"freewym:splstm","ref":"splstm","sha":"e9b0c566216ed42560a220c1702b03c048e4404e","user":{"login":"freewym","id":3506322,"avatar_url":"https://avatars.githubusercontent.com/u/3506322?v=3","gravatar_id":"","url":"https://api.github.com/users/freewym","html_url":"https://github.com/freewym","followers_url":"https://api.github.com/users/freewym/followers","following_url":"https://api.github.com/users/freewym/following{/other_user}","gists_url":"https://api.github.com/users/freewym/gists{/gist_id}","starred_url":"https://api.github.com/users/freewym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freewym/subscriptions","organizations_url":"https://api.github.com/users/freewym/orgs","repos_url":"https://api.github.com/users/freewym/repos","events_url":"https://api.github.com/users/freewym/events{/privacy}","received_events_url":"https://api.github.com/users/freewym/received_events","type":"User","site_admin":false},"repo":{"id":41891891,"name":"kaldi","full_name":"freewym/kaldi","owner":{"login":"freewym","id":3506322,"avatar_url":"https://avatars.githubusercontent.com/u/3506322?v=3","gravatar_id":"","url":"https://api.github.com/users/freewym","html_url":"https://github.com/freewym","followers_url":"https://api.github.com/users/freewym/followers","following_url":"https://api.github.com/users/freewym/following{/other_user}","gists_url":"https://api.github.com/users/freewym/gists{/gist_id}","starred_url":"https://api.github.com/users/freewym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freewym/subscriptions","organizations_url":"https://api.github.com/users/freewym/orgs","repos_url":"https://api.github.com/users/freewym/repos","events_url":"https://api.github.com/users/freewym/events{/privacy}","received_events_url":"https://api.github.com/users/freewym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freewym/kaldi","description":"This is now the official location of the Kaldi project.","fork":true,"url":"https://api.github.com/repos/freewym/kaldi","forks_url":"https://api.github.com/repos/freewym/kaldi/forks","keys_url":"https://api.github.com/repos/freewym/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freewym/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freewym/kaldi/teams","hooks_url":"https://api.github.com/repos/freewym/kaldi/hooks","issue_events_url":"https://api.github.com/repos/freewym/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/freewym/kaldi/events","assignees_url":"https://api.github.com/repos/freewym/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/freewym/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/freewym/kaldi/tags","blobs_url":"https://api.github.com/repos/freewym/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freewym/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freewym/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/freewym/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freewym/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/freewym/kaldi/languages","stargazers_url":"https://api.github.com/repos/freewym/kaldi/stargazers","contributors_url":"https://api.github.com/repos/freewym/kaldi/contributors","subscribers_url":"https://api.github.com/repos/freewym/kaldi/subscribers","subscription_url":"https://api.github.com/repos/freewym/kaldi/subscription","commits_url":"https://api.github.com/repos/freewym/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/freewym/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/freewym/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/freewym/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/freewym/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/freewym/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freewym/kaldi/merges","archive_url":"https://api.github.com/repos/freewym/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freewym/kaldi/downloads","issues_url":"https://api.github.com/repos/freewym/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/freewym/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/freewym/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/freewym/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freewym/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/freewym/kaldi/releases{/id}","created_at":"2015-09-04T01:18:16Z","updated_at":"2016-01-12T19:28:02Z","pushed_at":"2016-01-12T22:32:38Z","git_url":"git://github.com/freewym/kaldi.git","ssh_url":"git@github.com:freewym/kaldi.git","clone_url":"https://github.com/freewym/kaldi.git","svn_url":"https://github.com/freewym/kaldi","homepage":"http://kaldi-asr.org","size":76198,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kaldi-asr:master","ref":"master","sha":"b4780574cf18f29fb9851826d0645370e08d6121","user":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"repo":{"id":34275045,"name":"kaldi","full_name":"kaldi-asr/kaldi","owner":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaldi-asr/kaldi","description":"This is now the official location of the Kaldi project.","fork":false,"url":"https://api.github.com/repos/kaldi-asr/kaldi","forks_url":"https://api.github.com/repos/kaldi-asr/kaldi/forks","keys_url":"https://api.github.com/repos/kaldi-asr/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaldi-asr/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaldi-asr/kaldi/teams","hooks_url":"https://api.github.com/repos/kaldi-asr/kaldi/hooks","issue_events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/events","assignees_url":"https://api.github.com/repos/kaldi-asr/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/kaldi-asr/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/tags","blobs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/kaldi-asr/kaldi/languages","stargazers_url":"https://api.github.com/repos/kaldi-asr/kaldi/stargazers","contributors_url":"https://api.github.com/repos/kaldi-asr/kaldi/contributors","subscribers_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscribers","subscription_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscription","commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaldi-asr/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/kaldi-asr/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaldi-asr/kaldi/merges","archive_url":"https://api.github.com/repos/kaldi-asr/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaldi-asr/kaldi/downloads","issues_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/kaldi-asr/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/kaldi-asr/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/kaldi-asr/kaldi/releases{/id}","created_at":"2015-04-20T17:23:16Z","updated_at":"2016-01-14T08:35:10Z","pushed_at":"2016-01-13T12:46:00Z","git_url":"git://github.com/kaldi-asr/kaldi.git","ssh_url":"git@github.com:kaldi-asr/kaldi.git","clone_url":"https://github.com/kaldi-asr/kaldi.git","svn_url":"https://github.com/kaldi-asr/kaldi","homepage":"http://kaldi-asr.org","size":86732,"stargazers_count":364,"watchers_count":364,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":25,"forks":238,"open_issues":25,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/432"},"issue":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/432"},"comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/e9b0c566216ed42560a220c1702b03c048e4404e"}}}}