{"action":"closed","number":1908,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1908","id":94406289,"html_url":"https://github.com/ripple/rippled/pull/1908","diff_url":"https://github.com/ripple/rippled/pull/1908.diff","patch_url":"https://github.com/ripple/rippled/pull/1908.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1908","number":1908,"state":"closed","locked":false,"title":"Add server/connection tests (RIPD-1336)","user":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"body":"Migrate tests in uniport-test.js to cpp/jtx. Handle exceptions in\r\nWSClient and JSONRPClient constructors. Use shorter timeout\r\nfor HTTP and WS Peers when client is localhost. Add missing call to\r\nstart_timer in HTTP Peer. Add incomplete WS Upgrade request test\r\nto prove that server timeout is working.","created_at":"2016-11-18T17:46:31Z","updated_at":"2016-12-25T23:52:09Z","closed_at":"2016-12-25T23:52:09Z","merged_at":null,"merge_commit_sha":"d240dfa57c27a78a01b9c6141d6b3db3f402555d","assignee":{"login":"bachase","id":14430,"avatar_url":"https://avatars.githubusercontent.com/u/14430?v=3","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},"assignees":[{"login":"bachase","id":14430,"avatar_url":"https://avatars.githubusercontent.com/u/14430?v=3","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},{"login":"miguelportilla","id":1524671,"avatar_url":"https://avatars.githubusercontent.com/u/1524671?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelportilla","html_url":"https://github.com/miguelportilla","followers_url":"https://api.github.com/users/miguelportilla/followers","following_url":"https://api.github.com/users/miguelportilla/following{/other_user}","gists_url":"https://api.github.com/users/miguelportilla/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelportilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelportilla/subscriptions","organizations_url":"https://api.github.com/users/miguelportilla/orgs","repos_url":"https://api.github.com/users/miguelportilla/repos","events_url":"https://api.github.com/users/miguelportilla/events{/privacy}","received_events_url":"https://api.github.com/users/miguelportilla/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1908/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1908/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1908/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/be4dc9d74c49d54d692c2a356abe41d1a0407723","head":{"label":"mellery451:uniport_test","ref":"uniport_test","sha":"be4dc9d74c49d54d692c2a356abe41d1a0407723","user":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"repo":{"id":63169724,"name":"rippled","full_name":"mellery451/rippled","owner":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mellery451/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/mellery451/rippled","forks_url":"https://api.github.com/repos/mellery451/rippled/forks","keys_url":"https://api.github.com/repos/mellery451/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mellery451/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mellery451/rippled/teams","hooks_url":"https://api.github.com/repos/mellery451/rippled/hooks","issue_events_url":"https://api.github.com/repos/mellery451/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/mellery451/rippled/events","assignees_url":"https://api.github.com/repos/mellery451/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/mellery451/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/mellery451/rippled/tags","blobs_url":"https://api.github.com/repos/mellery451/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mellery451/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mellery451/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/mellery451/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mellery451/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/mellery451/rippled/languages","stargazers_url":"https://api.github.com/repos/mellery451/rippled/stargazers","contributors_url":"https://api.github.com/repos/mellery451/rippled/contributors","subscribers_url":"https://api.github.com/repos/mellery451/rippled/subscribers","subscription_url":"https://api.github.com/repos/mellery451/rippled/subscription","commits_url":"https://api.github.com/repos/mellery451/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/mellery451/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/mellery451/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/mellery451/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/mellery451/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/mellery451/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mellery451/rippled/merges","archive_url":"https://api.github.com/repos/mellery451/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mellery451/rippled/downloads","issues_url":"https://api.github.com/repos/mellery451/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/mellery451/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/mellery451/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/mellery451/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mellery451/rippled/labels{/name}","releases_url":"https://api.github.com/repos/mellery451/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/mellery451/rippled/deployments","created_at":"2016-07-12T15:29:01Z","updated_at":"2016-07-12T15:29:12Z","pushed_at":"2016-12-23T17:10:33Z","git_url":"git://github.com/mellery451/rippled.git","ssh_url":"git@github.com:mellery451/rippled.git","clone_url":"https://github.com/mellery451/rippled.git","svn_url":"https://github.com/mellery451/rippled","homepage":"https://ripple.com","size":79576,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"7fc780dd70faef819eace27a12de35dd1363c069","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the Ripple Consensus Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2016-12-25T10:49:05Z","pushed_at":"2016-12-25T23:49:58Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":79511,"stargazers_count":1191,"watchers_count":1191,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":376,"mirror_url":null,"open_issues_count":138,"forks":376,"open_issues":138,"watchers":1191,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1908"},"html":{"href":"https://github.com/ripple/rippled/pull/1908"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1908"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1908/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1908/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1908/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/be4dc9d74c49d54d692c2a356abe41d1a0407723"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":23,"maintainer_can_modify":false,"commits":4,"additions":500,"deletions":103,"changed_files":6}}
{"actor":{"display_login":"nbougalis"}}