{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/comments/69114496","id":69114496,"diff_hunk":"@@ -178,172 +178,6 @@ TestServer.start(config)\n     )\n \n     test(\n-      'Unverified account becomes verified from sign-in verification',\n-      function (t) {\n-        var email = server.uniqueEmail()\n-        var password = 'allyourbasearebelongtous'\n-        var client = null\n-        var uid\n-        var code\n-        return Client.create(config.publicUrl, email, password)\n-          .then(\n-            function (x) {\n-              client = x\n-              t.ok(client.authAt, 'authAt was set')\n-            }\n-          )\n-          .then(\n-            function () {\n-              return client.emailStatus()\n-            }\n-          )\n-          .then(\n-            function (status) {\n-              t.equal(status.verified, false, 'new account is unverified')\n-              t.equal(client.emailVerified, false, 'new account email unverified')\n-            }\n-          )\n-          .then(\n-            function () {\n-              return server.mailbox.waitForEmail(email)\n-            }\n-          )\n-          .then(\n-            function (emailData) {\n-              t.equal(emailData.subject, 'Verify your Firefox Account')\n-            }\n-          )\n-          .then(\n-            function () {\n-              return client.login({keys:true})\n-            }\n-          )\n-          .then(\n-            function () {\n-              return server.mailbox.waitForEmail(email)\n-            }\n-          )\n-          .then(\n-            function (emailData) {\n-              uid = emailData.headers['x-uid']\n-              code = emailData.headers['x-verify-code']\n-              t.equal(emailData.subject, 'Confirm new sign-in to Firefox')\n-              t.ok(uid, 'sent uid')\n-              t.ok(code, 'sent verify code')\n-            }\n-          )\n-          .then(\n-            function () {\n-              return client.emailStatus()\n-            }\n-          )\n-          .then(\n-            function (status) {\n-              t.equal(status.verified, false, 'account is not verified, unverified sign-in')\n-            }\n-          )\n-          .then(\n-            function () {\n-              return client.verifyEmail(code)\n-            }\n-          )\n-          .then(\n-            function () {\n-              return client.emailStatus()\n-            }\n-          )\n-          .then(\n-            function (status) {\n-              t.equal(status.verified, true, 'account is verified by confirming email')\n-            }\n-          )\n-      }\n-    )\n-\n-    test(\n-      'Account verification links still work after session verification',","path":"test/remote/account_signin_verification_tests.js","position":87,"original_position":87,"commit_id":"14216d470bd1c1c21b5e988219af52f8cfa42325","original_commit_id":"14216d470bd1c1c21b5e988219af52f8cfa42325","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"The 2nd email in this case is sent via \"recovery_email/resend_code\", not a new \"account/create\". A 2nd call to \"account/create\" with the same email/password will generate a new account, the original link will be broken.","created_at":"2016-06-30T11:14:21Z","updated_at":"2016-06-30T11:14:21Z","html_url":"https://github.com/mozilla/fxa-auth-server/pull/1317#discussion_r69114496","pull_request_url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/comments/69114496"},"html":{"href":"https://github.com/mozilla/fxa-auth-server/pull/1317#discussion_r69114496"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317","id":75750392,"html_url":"https://github.com/mozilla/fxa-auth-server/pull/1317","diff_url":"https://github.com/mozilla/fxa-auth-server/pull/1317.diff","patch_url":"https://github.com/mozilla/fxa-auth-server/pull/1317.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1317","number":1317,"state":"open","locked":false,"title":" fix(signin): Fixes multiple emails sent on login","user":{"login":"vbudhram","id":1295288,"avatar_url":"https://avatars.githubusercontent.com/u/1295288?v=3","gravatar_id":"","url":"https://api.github.com/users/vbudhram","html_url":"https://github.com/vbudhram","followers_url":"https://api.github.com/users/vbudhram/followers","following_url":"https://api.github.com/users/vbudhram/following{/other_user}","gists_url":"https://api.github.com/users/vbudhram/gists{/gist_id}","starred_url":"https://api.github.com/users/vbudhram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbudhram/subscriptions","organizations_url":"https://api.github.com/users/vbudhram/orgs","repos_url":"https://api.github.com/users/vbudhram/repos","events_url":"https://api.github.com/users/vbudhram/events{/privacy}","received_events_url":"https://api.github.com/users/vbudhram/received_events","type":"User","site_admin":false},"body":"Based on our IRC chat, here is a table defining the expected emails (inorder) when logging in with the different states of the auth-server.\r\n\r\n|    |      Sign-in Confirmation On      |  Sign-in Confirmation Off |\r\n|----------|:-------------:|------:|\r\n|Unverified Account |  Verify your Firefox Account, Account Verified | Verify your Firefox Account, New sign-in to Firefox, Account Verified |\r\n|Verified Account |  Confirm sign-in to Firefox | New sign-in to Firefox |\r\n\r\n@shane-tomlinson @rfk These seem reasonable? r?\r\n\r\nFixes #1314 ","created_at":"2016-06-30T02:11:50Z","updated_at":"2016-06-30T11:14:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc71146e42e586f3c2b0703bd68c94683b3f8a68","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones/61","html_url":"https://github.com/mozilla/fxa-auth-server/milestones/FxA-83:%20signin%20confirmation","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones/61/labels","id":1699495,"number":61,"title":"FxA-83: signin confirmation","description":"https://mozilla.aha.io/features/FXA-83","creator":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":7,"state":"open","created_at":"2016-04-12T04:41:47Z","updated_at":"2016-06-30T03:18:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1317/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-auth-server/statuses/14216d470bd1c1c21b5e988219af52f8cfa42325","head":{"label":"mozilla:issue-1314-multiple-emails-on-login","ref":"issue-1314-multiple-emails-on-login","sha":"14216d470bd1c1c21b5e988219af52f8cfa42325","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":10041891,"name":"fxa-auth-server","full_name":"mozilla/fxa-auth-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-auth-server","description":"The Firefox Accounts authentication server.","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-auth-server","forks_url":"https://api.github.com/repos/mozilla/fxa-auth-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-auth-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-auth-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-auth-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-auth-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-auth-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-auth-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-auth-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-auth-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-auth-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-auth-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-auth-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-auth-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-auth-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-auth-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-auth-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-auth-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-auth-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-auth-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-auth-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-auth-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-auth-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-auth-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/deployments","created_at":"2013-05-13T21:42:48Z","updated_at":"2016-06-29T21:26:50Z","pushed_at":"2016-06-30T10:46:19Z","git_url":"git://github.com/mozilla/fxa-auth-server.git","ssh_url":"git@github.com:mozilla/fxa-auth-server.git","clone_url":"https://github.com/mozilla/fxa-auth-server.git","svn_url":"https://github.com/mozilla/fxa-auth-server","homepage":"https://wiki.mozilla.org/Identity/Firefox_Accounts","size":5717,"stargazers_count":236,"watchers_count":236,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":43,"forks":61,"open_issues":43,"watchers":236,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"282271b9554cfd28c86c3ba1e37ccd02c7aee7d0","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":10041891,"name":"fxa-auth-server","full_name":"mozilla/fxa-auth-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-auth-server","description":"The Firefox Accounts authentication server.","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-auth-server","forks_url":"https://api.github.com/repos/mozilla/fxa-auth-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-auth-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-auth-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-auth-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-auth-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-auth-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-auth-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-auth-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-auth-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-auth-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-auth-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-auth-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-auth-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-auth-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-auth-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-auth-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-auth-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-auth-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-auth-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-auth-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-auth-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-auth-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-auth-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-auth-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/deployments","created_at":"2013-05-13T21:42:48Z","updated_at":"2016-06-29T21:26:50Z","pushed_at":"2016-06-30T10:46:19Z","git_url":"git://github.com/mozilla/fxa-auth-server.git","ssh_url":"git@github.com:mozilla/fxa-auth-server.git","clone_url":"https://github.com/mozilla/fxa-auth-server.git","svn_url":"https://github.com/mozilla/fxa-auth-server","homepage":"https://wiki.mozilla.org/Identity/Firefox_Accounts","size":5717,"stargazers_count":236,"watchers_count":236,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":43,"forks":61,"open_issues":43,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317"},"html":{"href":"https://github.com/mozilla/fxa-auth-server/pull/1317"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1317"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1317/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/pulls/1317/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-auth-server/statuses/14216d470bd1c1c21b5e988219af52f8cfa42325"}}}}
{"actor":{"display_login":"shane-tomlinson"}}