{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/SKART1/jadb/pulls/1","id":87600457,"html_url":"https://github.com/SKART1/jadb/pull/1","diff_url":"https://github.com/SKART1/jadb/pull/1.diff","patch_url":"https://github.com/SKART1/jadb/pull/1.patch","issue_url":"https://api.github.com/repos/SKART1/jadb/issues/1","number":1,"state":"open","locked":false,"title":"Imp 38 getopt refactor","user":{"login":"vidstige","id":655605,"avatar_url":"https://avatars.githubusercontent.com/u/655605?v=3","gravatar_id":"","url":"https://api.github.com/users/vidstige","html_url":"https://github.com/vidstige","followers_url":"https://api.github.com/users/vidstige/followers","following_url":"https://api.github.com/users/vidstige/following{/other_user}","gists_url":"https://api.github.com/users/vidstige/gists{/gist_id}","starred_url":"https://api.github.com/users/vidstige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidstige/subscriptions","organizations_url":"https://api.github.com/users/vidstige/orgs","repos_url":"https://api.github.com/users/vidstige/repos","events_url":"https://api.github.com/users/vidstige/events{/privacy}","received_events_url":"https://api.github.com/users/vidstige/received_events","type":"User","site_admin":false},"body":"Hi,\r\nthis pr got supermessy for some reason. But please see 5111d0d for how to test `getprop` properly. Feel free to cherry-pick that commit to your branch! After that you should be able to hack away and create a sweet test. :+1:\r\n\r\nAlso I think the `getprop` function should not be _inside_ the `JadbDevice` class but rather _use_ it. Compare it to e.g. `PackageManager` that takes a `JadbDevice` in constructor, do something simliar for `getprop`","created_at":"2016-10-01T12:15:38Z","updated_at":"2016-10-01T12:15:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SKART1/jadb/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SKART1/jadb/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SKART1/jadb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SKART1/jadb/issues/1/comments","statuses_url":"https://api.github.com/repos/SKART1/jadb/statuses/5111d0d2d4b5c8a19e42a243d1f94925c2a09458","head":{"label":"vidstige:IMP-38-getopt-refactor","ref":"IMP-38-getopt-refactor","sha":"5111d0d2d4b5c8a19e42a243d1f94925c2a09458","user":{"login":"vidstige","id":655605,"avatar_url":"https://avatars.githubusercontent.com/u/655605?v=3","gravatar_id":"","url":"https://api.github.com/users/vidstige","html_url":"https://github.com/vidstige","followers_url":"https://api.github.com/users/vidstige/followers","following_url":"https://api.github.com/users/vidstige/following{/other_user}","gists_url":"https://api.github.com/users/vidstige/gists{/gist_id}","starred_url":"https://api.github.com/users/vidstige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidstige/subscriptions","organizations_url":"https://api.github.com/users/vidstige/orgs","repos_url":"https://api.github.com/users/vidstige/repos","events_url":"https://api.github.com/users/vidstige/events{/privacy}","received_events_url":"https://api.github.com/users/vidstige/received_events","type":"User","site_admin":false},"repo":{"id":11668234,"name":"jadb","full_name":"vidstige/jadb","owner":{"login":"vidstige","id":655605,"avatar_url":"https://avatars.githubusercontent.com/u/655605?v=3","gravatar_id":"","url":"https://api.github.com/users/vidstige","html_url":"https://github.com/vidstige","followers_url":"https://api.github.com/users/vidstige/followers","following_url":"https://api.github.com/users/vidstige/following{/other_user}","gists_url":"https://api.github.com/users/vidstige/gists{/gist_id}","starred_url":"https://api.github.com/users/vidstige/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidstige/subscriptions","organizations_url":"https://api.github.com/users/vidstige/orgs","repos_url":"https://api.github.com/users/vidstige/repos","events_url":"https://api.github.com/users/vidstige/events{/privacy}","received_events_url":"https://api.github.com/users/vidstige/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vidstige/jadb","description":"ADB Client in pure Java.","fork":false,"url":"https://api.github.com/repos/vidstige/jadb","forks_url":"https://api.github.com/repos/vidstige/jadb/forks","keys_url":"https://api.github.com/repos/vidstige/jadb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vidstige/jadb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vidstige/jadb/teams","hooks_url":"https://api.github.com/repos/vidstige/jadb/hooks","issue_events_url":"https://api.github.com/repos/vidstige/jadb/issues/events{/number}","events_url":"https://api.github.com/repos/vidstige/jadb/events","assignees_url":"https://api.github.com/repos/vidstige/jadb/assignees{/user}","branches_url":"https://api.github.com/repos/vidstige/jadb/branches{/branch}","tags_url":"https://api.github.com/repos/vidstige/jadb/tags","blobs_url":"https://api.github.com/repos/vidstige/jadb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vidstige/jadb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vidstige/jadb/git/refs{/sha}","trees_url":"https://api.github.com/repos/vidstige/jadb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vidstige/jadb/statuses/{sha}","languages_url":"https://api.github.com/repos/vidstige/jadb/languages","stargazers_url":"https://api.github.com/repos/vidstige/jadb/stargazers","contributors_url":"https://api.github.com/repos/vidstige/jadb/contributors","subscribers_url":"https://api.github.com/repos/vidstige/jadb/subscribers","subscription_url":"https://api.github.com/repos/vidstige/jadb/subscription","commits_url":"https://api.github.com/repos/vidstige/jadb/commits{/sha}","git_commits_url":"https://api.github.com/repos/vidstige/jadb/git/commits{/sha}","comments_url":"https://api.github.com/repos/vidstige/jadb/comments{/number}","issue_comment_url":"https://api.github.com/repos/vidstige/jadb/issues/comments{/number}","contents_url":"https://api.github.com/repos/vidstige/jadb/contents/{+path}","compare_url":"https://api.github.com/repos/vidstige/jadb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vidstige/jadb/merges","archive_url":"https://api.github.com/repos/vidstige/jadb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vidstige/jadb/downloads","issues_url":"https://api.github.com/repos/vidstige/jadb/issues{/number}","pulls_url":"https://api.github.com/repos/vidstige/jadb/pulls{/number}","milestones_url":"https://api.github.com/repos/vidstige/jadb/milestones{/number}","notifications_url":"https://api.github.com/repos/vidstige/jadb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vidstige/jadb/labels{/name}","releases_url":"https://api.github.com/repos/vidstige/jadb/releases{/id}","deployments_url":"https://api.github.com/repos/vidstige/jadb/deployments","created_at":"2013-07-25T18:45:02Z","updated_at":"2016-09-25T12:38:43Z","pushed_at":"2016-10-01T12:11:33Z","git_url":"git://github.com/vidstige/jadb.git","ssh_url":"git@github.com:vidstige/jadb.git","clone_url":"https://github.com/vidstige/jadb.git","svn_url":"https://github.com/vidstige/jadb","homepage":"","size":599,"stargazers_count":88,"watchers_count":88,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":3,"forks":28,"open_issues":3,"watchers":88,"default_branch":"master"}},"base":{"label":"SKART1:master","ref":"master","sha":"415bf7321cf9d12bef54ebfcc7645f97d14b8f08","user":{"login":"SKART1","id":3259560,"avatar_url":"https://avatars.githubusercontent.com/u/3259560?v=3","gravatar_id":"","url":"https://api.github.com/users/SKART1","html_url":"https://github.com/SKART1","followers_url":"https://api.github.com/users/SKART1/followers","following_url":"https://api.github.com/users/SKART1/following{/other_user}","gists_url":"https://api.github.com/users/SKART1/gists{/gist_id}","starred_url":"https://api.github.com/users/SKART1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SKART1/subscriptions","organizations_url":"https://api.github.com/users/SKART1/orgs","repos_url":"https://api.github.com/users/SKART1/repos","events_url":"https://api.github.com/users/SKART1/events{/privacy}","received_events_url":"https://api.github.com/users/SKART1/received_events","type":"User","site_admin":false},"repo":{"id":58212880,"name":"jadb","full_name":"SKART1/jadb","owner":{"login":"SKART1","id":3259560,"avatar_url":"https://avatars.githubusercontent.com/u/3259560?v=3","gravatar_id":"","url":"https://api.github.com/users/SKART1","html_url":"https://github.com/SKART1","followers_url":"https://api.github.com/users/SKART1/followers","following_url":"https://api.github.com/users/SKART1/following{/other_user}","gists_url":"https://api.github.com/users/SKART1/gists{/gist_id}","starred_url":"https://api.github.com/users/SKART1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SKART1/subscriptions","organizations_url":"https://api.github.com/users/SKART1/orgs","repos_url":"https://api.github.com/users/SKART1/repos","events_url":"https://api.github.com/users/SKART1/events{/privacy}","received_events_url":"https://api.github.com/users/SKART1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SKART1/jadb","description":"ADB Client in pure Java.","fork":true,"url":"https://api.github.com/repos/SKART1/jadb","forks_url":"https://api.github.com/repos/SKART1/jadb/forks","keys_url":"https://api.github.com/repos/SKART1/jadb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SKART1/jadb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SKART1/jadb/teams","hooks_url":"https://api.github.com/repos/SKART1/jadb/hooks","issue_events_url":"https://api.github.com/repos/SKART1/jadb/issues/events{/number}","events_url":"https://api.github.com/repos/SKART1/jadb/events","assignees_url":"https://api.github.com/repos/SKART1/jadb/assignees{/user}","branches_url":"https://api.github.com/repos/SKART1/jadb/branches{/branch}","tags_url":"https://api.github.com/repos/SKART1/jadb/tags","blobs_url":"https://api.github.com/repos/SKART1/jadb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SKART1/jadb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SKART1/jadb/git/refs{/sha}","trees_url":"https://api.github.com/repos/SKART1/jadb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SKART1/jadb/statuses/{sha}","languages_url":"https://api.github.com/repos/SKART1/jadb/languages","stargazers_url":"https://api.github.com/repos/SKART1/jadb/stargazers","contributors_url":"https://api.github.com/repos/SKART1/jadb/contributors","subscribers_url":"https://api.github.com/repos/SKART1/jadb/subscribers","subscription_url":"https://api.github.com/repos/SKART1/jadb/subscription","commits_url":"https://api.github.com/repos/SKART1/jadb/commits{/sha}","git_commits_url":"https://api.github.com/repos/SKART1/jadb/git/commits{/sha}","comments_url":"https://api.github.com/repos/SKART1/jadb/comments{/number}","issue_comment_url":"https://api.github.com/repos/SKART1/jadb/issues/comments{/number}","contents_url":"https://api.github.com/repos/SKART1/jadb/contents/{+path}","compare_url":"https://api.github.com/repos/SKART1/jadb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SKART1/jadb/merges","archive_url":"https://api.github.com/repos/SKART1/jadb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SKART1/jadb/downloads","issues_url":"https://api.github.com/repos/SKART1/jadb/issues{/number}","pulls_url":"https://api.github.com/repos/SKART1/jadb/pulls{/number}","milestones_url":"https://api.github.com/repos/SKART1/jadb/milestones{/number}","notifications_url":"https://api.github.com/repos/SKART1/jadb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SKART1/jadb/labels{/name}","releases_url":"https://api.github.com/repos/SKART1/jadb/releases{/id}","deployments_url":"https://api.github.com/repos/SKART1/jadb/deployments","created_at":"2016-05-06T14:28:13Z","updated_at":"2016-05-06T14:28:14Z","pushed_at":"2016-09-30T15:34:03Z","git_url":"git://github.com/SKART1/jadb.git","ssh_url":"git@github.com:SKART1/jadb.git","clone_url":"https://github.com/SKART1/jadb.git","svn_url":"https://github.com/SKART1/jadb","homepage":"","size":544,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SKART1/jadb/pulls/1"},"html":{"href":"https://github.com/SKART1/jadb/pull/1"},"issue":{"href":"https://api.github.com/repos/SKART1/jadb/issues/1"},"comments":{"href":"https://api.github.com/repos/SKART1/jadb/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SKART1/jadb/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SKART1/jadb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SKART1/jadb/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SKART1/jadb/statuses/5111d0d2d4b5c8a19e42a243d1f94925c2a09458"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":32,"additions":532,"deletions":279,"changed_files":29}}
{"actor":{"display_login":"vidstige"}}