{"action":"created","comment":{"url":"https://api.github.com/repos/tessel/t2-cli/pulls/comments/53865833","id":53865833,"diff_hunk":"@@ -157,36 +157,42 @@ exports['Tessel.prototype.deployScript'] = {\n \n     this.tarBundle.restore();\n \n-    createTemporaryDeployCode().then(function() {\n+    createTemporaryDeployCode().then(() => {\n       deploy.tarBundle({\n-        target: deployFolder\n-      }).then((bundle) => {\n-        /*\n-          $ t2 run app.js\n-          INFO Looking for your Tessel...\n-          INFO Connected to arnold over LAN\n-          INFO Writing app.js to RAM on arnold (2.048 kB)...\n-          INFO Deployed.\n-          INFO Running app.js...\n-          testing deploy\n-          INFO Stopping script...\n-      */\n-        test.equal(bundle.length, 2048);\n-        deleteTemporaryDeployCode().then(function() {\n+          target: deployFolder\n+        }).then(bundle => {","path":"test/unit/deploy.js","position":22,"original_position":22,"commit_id":"86922eed1a93ef4206b4af37c14b8609a824ea69","original_commit_id":"7c1bb7972879cad2476e3afaf0d541ce1d784496","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"body":"I don't follow this, can you do a fixup after this patch is done?","created_at":"2016-02-23T23:00:09Z","updated_at":"2016-02-23T23:00:09Z","html_url":"https://github.com/tessel/t2-cli/pull/594#discussion_r53865833","pull_request_url":"https://api.github.com/repos/tessel/t2-cli/pulls/594","_links":{"self":{"href":"https://api.github.com/repos/tessel/t2-cli/pulls/comments/53865833"},"html":{"href":"https://github.com/tessel/t2-cli/pull/594#discussion_r53865833"},"pull_request":{"href":"https://api.github.com/repos/tessel/t2-cli/pulls/594"}}},"pull_request":{"url":"https://api.github.com/repos/tessel/t2-cli/pulls/594","id":60110111,"html_url":"https://github.com/tessel/t2-cli/pull/594","diff_url":"https://github.com/tessel/t2-cli/pull/594.diff","patch_url":"https://github.com/tessel/t2-cli/pull/594.patch","issue_url":"https://api.github.com/repos/tessel/t2-cli/issues/594","number":594,"state":"open","locked":false,"title":"Eliminate use of test.fail; enforce test.done on all errors and failures. Related to gh-592","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-21T23:42:44Z","updated_at":"2016-02-23T23:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16899ea3879049fc3d4f5df9de928b8ed600a4ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tessel/t2-cli/pulls/594/commits","review_comments_url":"https://api.github.com/repos/tessel/t2-cli/pulls/594/comments","review_comment_url":"https://api.github.com/repos/tessel/t2-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tessel/t2-cli/issues/594/comments","statuses_url":"https://api.github.com/repos/tessel/t2-cli/statuses/86922eed1a93ef4206b4af37c14b8609a824ea69","head":{"label":"rwaldron:592","ref":"592","sha":"86922eed1a93ef4206b4af37c14b8609a824ea69","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"repo":{"id":34642706,"name":"t2-cli","full_name":"rwaldron/t2-cli","owner":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwaldron/t2-cli","description":"Command line interface to Tessel 2.","fork":true,"url":"https://api.github.com/repos/rwaldron/t2-cli","forks_url":"https://api.github.com/repos/rwaldron/t2-cli/forks","keys_url":"https://api.github.com/repos/rwaldron/t2-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwaldron/t2-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwaldron/t2-cli/teams","hooks_url":"https://api.github.com/repos/rwaldron/t2-cli/hooks","issue_events_url":"https://api.github.com/repos/rwaldron/t2-cli/issues/events{/number}","events_url":"https://api.github.com/repos/rwaldron/t2-cli/events","assignees_url":"https://api.github.com/repos/rwaldron/t2-cli/assignees{/user}","branches_url":"https://api.github.com/repos/rwaldron/t2-cli/branches{/branch}","tags_url":"https://api.github.com/repos/rwaldron/t2-cli/tags","blobs_url":"https://api.github.com/repos/rwaldron/t2-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwaldron/t2-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwaldron/t2-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwaldron/t2-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwaldron/t2-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/rwaldron/t2-cli/languages","stargazers_url":"https://api.github.com/repos/rwaldron/t2-cli/stargazers","contributors_url":"https://api.github.com/repos/rwaldron/t2-cli/contributors","subscribers_url":"https://api.github.com/repos/rwaldron/t2-cli/subscribers","subscription_url":"https://api.github.com/repos/rwaldron/t2-cli/subscription","commits_url":"https://api.github.com/repos/rwaldron/t2-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwaldron/t2-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwaldron/t2-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwaldron/t2-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwaldron/t2-cli/contents/{+path}","compare_url":"https://api.github.com/repos/rwaldron/t2-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwaldron/t2-cli/merges","archive_url":"https://api.github.com/repos/rwaldron/t2-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwaldron/t2-cli/downloads","issues_url":"https://api.github.com/repos/rwaldron/t2-cli/issues{/number}","pulls_url":"https://api.github.com/repos/rwaldron/t2-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/rwaldron/t2-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/rwaldron/t2-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwaldron/t2-cli/labels{/name}","releases_url":"https://api.github.com/repos/rwaldron/t2-cli/releases{/id}","deployments_url":"https://api.github.com/repos/rwaldron/t2-cli/deployments","created_at":"2015-04-27T02:53:48Z","updated_at":"2015-09-28T19:20:17Z","pushed_at":"2016-02-23T19:45:20Z","git_url":"git://github.com/rwaldron/t2-cli.git","ssh_url":"git@github.com:rwaldron/t2-cli.git","clone_url":"https://github.com/rwaldron/t2-cli.git","svn_url":"https://github.com/rwaldron/t2-cli","homepage":"","size":1036,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tessel:master","ref":"master","sha":"716530c5e15c069e274e9abed35a30c6f3bfe07d","user":{"login":"tessel","id":5573563,"avatar_url":"https://avatars.githubusercontent.com/u/5573563?v=3","gravatar_id":"","url":"https://api.github.com/users/tessel","html_url":"https://github.com/tessel","followers_url":"https://api.github.com/users/tessel/followers","following_url":"https://api.github.com/users/tessel/following{/other_user}","gists_url":"https://api.github.com/users/tessel/gists{/gist_id}","starred_url":"https://api.github.com/users/tessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessel/subscriptions","organizations_url":"https://api.github.com/users/tessel/orgs","repos_url":"https://api.github.com/users/tessel/repos","events_url":"https://api.github.com/users/tessel/events{/privacy}","received_events_url":"https://api.github.com/users/tessel/received_events","type":"Organization","site_admin":false},"repo":{"id":30388450,"name":"t2-cli","full_name":"tessel/t2-cli","owner":{"login":"tessel","id":5573563,"avatar_url":"https://avatars.githubusercontent.com/u/5573563?v=3","gravatar_id":"","url":"https://api.github.com/users/tessel","html_url":"https://github.com/tessel","followers_url":"https://api.github.com/users/tessel/followers","following_url":"https://api.github.com/users/tessel/following{/other_user}","gists_url":"https://api.github.com/users/tessel/gists{/gist_id}","starred_url":"https://api.github.com/users/tessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tessel/subscriptions","organizations_url":"https://api.github.com/users/tessel/orgs","repos_url":"https://api.github.com/users/tessel/repos","events_url":"https://api.github.com/users/tessel/events{/privacy}","received_events_url":"https://api.github.com/users/tessel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tessel/t2-cli","description":"Command line interface to Tessel 2.","fork":false,"url":"https://api.github.com/repos/tessel/t2-cli","forks_url":"https://api.github.com/repos/tessel/t2-cli/forks","keys_url":"https://api.github.com/repos/tessel/t2-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tessel/t2-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tessel/t2-cli/teams","hooks_url":"https://api.github.com/repos/tessel/t2-cli/hooks","issue_events_url":"https://api.github.com/repos/tessel/t2-cli/issues/events{/number}","events_url":"https://api.github.com/repos/tessel/t2-cli/events","assignees_url":"https://api.github.com/repos/tessel/t2-cli/assignees{/user}","branches_url":"https://api.github.com/repos/tessel/t2-cli/branches{/branch}","tags_url":"https://api.github.com/repos/tessel/t2-cli/tags","blobs_url":"https://api.github.com/repos/tessel/t2-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tessel/t2-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tessel/t2-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/tessel/t2-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tessel/t2-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/tessel/t2-cli/languages","stargazers_url":"https://api.github.com/repos/tessel/t2-cli/stargazers","contributors_url":"https://api.github.com/repos/tessel/t2-cli/contributors","subscribers_url":"https://api.github.com/repos/tessel/t2-cli/subscribers","subscription_url":"https://api.github.com/repos/tessel/t2-cli/subscription","commits_url":"https://api.github.com/repos/tessel/t2-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/tessel/t2-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/tessel/t2-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/tessel/t2-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/tessel/t2-cli/contents/{+path}","compare_url":"https://api.github.com/repos/tessel/t2-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tessel/t2-cli/merges","archive_url":"https://api.github.com/repos/tessel/t2-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tessel/t2-cli/downloads","issues_url":"https://api.github.com/repos/tessel/t2-cli/issues{/number}","pulls_url":"https://api.github.com/repos/tessel/t2-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/tessel/t2-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/tessel/t2-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tessel/t2-cli/labels{/name}","releases_url":"https://api.github.com/repos/tessel/t2-cli/releases{/id}","deployments_url":"https://api.github.com/repos/tessel/t2-cli/deployments","created_at":"2015-02-06T01:27:53Z","updated_at":"2016-02-08T22:14:14Z","pushed_at":"2016-02-23T22:54:03Z","git_url":"git://github.com/tessel/t2-cli.git","ssh_url":"git@github.com:tessel/t2-cli.git","clone_url":"https://github.com/tessel/t2-cli.git","svn_url":"https://github.com/tessel/t2-cli","homepage":"","size":1323,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":62,"forks":17,"open_issues":62,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tessel/t2-cli/pulls/594"},"html":{"href":"https://github.com/tessel/t2-cli/pull/594"},"issue":{"href":"https://api.github.com/repos/tessel/t2-cli/issues/594"},"comments":{"href":"https://api.github.com/repos/tessel/t2-cli/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/tessel/t2-cli/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/tessel/t2-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tessel/t2-cli/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/tessel/t2-cli/statuses/86922eed1a93ef4206b4af37c14b8609a824ea69"}}}}