{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/74277752","id":74277752,"diff_hunk":"@@ -225,4 +231,27 @@ public String componentType() {\n         return null;\n     }\n \n+    public List<Property> properties() {\n+        List<Property> properties = new ArrayList<>();\n+\n+        if (binaryAnnotations != null) {\n+            Set<String> services = new HashSet<>();\n+\n+            for (BinaryAnnotation binaryAnnotation : binaryAnnotations) {\n+                Property property = new Property(binaryAnnotation.getKey(), binaryAnnotation.getValue());\n+\n+                Endpoint endpoint = binaryAnnotation.getEndpoint();\n+                if (endpoint != null &&\n+                        !services.contains(endpoint.getServiceName())) {\n+\n+                    properties.add(new Property(\"service\", endpoint.getServiceName(), PropertyType.Text));\n+                    services.add(endpoint.getServiceName());\n+                }","path":"server/api/src/main/java/org/hawkular/apm/server/api/model/zipkin/Span.java","position":37,"original_position":37,"commit_id":"9d5a7aecd1ea1acf61f060611f92324b81cfe880","original_commit_id":"9d5a7aecd1ea1acf61f060611f92324b81cfe880","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"One thing I don't understand about the zipkin model is why the endpoint is contained within the annotation, so may be repeated multiple times within the same span, but with different values (i.e. service names).\r\n\r\nThis would seem to imply that the annotations could be associated with different endpoints - not sure if this is actually the case.\r\n\r\nBut just wondering if we should initially just assume only one service? and if multiple provided then generate a trace message?\r\n\r\nJust thinking out loud, so not necessarily suggesting a change, but not sure how this should be handled if multiple services are actually provided. The properties can handle multiple values, but not sure how to deal with it at a high level (i.e. in the UI, etc).\r\n","created_at":"2016-08-10T16:19:11Z","updated_at":"2016-08-10T16:19:11Z","html_url":"https://github.com/hawkular/hawkular-apm/pull/503#discussion_r74277752","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/74277752"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/503#discussion_r74277752"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503","id":80053327,"html_url":"https://github.com/hawkular/hawkular-apm/pull/503","diff_url":"https://github.com/hawkular/hawkular-apm/pull/503.diff","patch_url":"https://github.com/hawkular/hawkular-apm/pull/503.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/503","number":503,"state":"open","locked":false,"title":"HWKAPM-531 | Transfer appropriate binary properties into properties field of derived information","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/HWKAPM-531","created_at":"2016-08-04T10:15:36Z","updated_at":"2016-08-10T16:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7602a4aa53cda6b2f90946502c1425d5ce0903e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/503/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/9d5a7aecd1ea1acf61f060611f92324b81cfe880","head":{"label":"pavolloffay:HWKAPM-531-Transfer-appropriate-binary-properties-into-properties-field-of-derived-information","ref":"HWKAPM-531-Transfer-appropriate-binary-properties-into-properties-field-of-derived-information","sha":"9d5a7aecd1ea1acf61f060611f92324b81cfe880","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"repo":{"id":54576177,"name":"hawkular-apm","full_name":"pavolloffay/hawkular-apm","owner":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavolloffay/hawkular-apm","description":"Business Transaction Management for Hawkular","fork":true,"url":"https://api.github.com/repos/pavolloffay/hawkular-apm","forks_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/forks","keys_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/events","assignees_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/merges","archive_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/pavolloffay/hawkular-apm/deployments","created_at":"2016-03-23T16:34:43Z","updated_at":"2016-07-15T10:12:23Z","pushed_at":"2016-08-07T11:36:46Z","git_url":"git://github.com/pavolloffay/hawkular-apm.git","ssh_url":"git@github.com:pavolloffay/hawkular-apm.git","clone_url":"https://github.com/pavolloffay/hawkular-apm.git","svn_url":"https://github.com/pavolloffay/hawkular-apm","homepage":"","size":5672,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"9b6af139b023c17bcb47229ec57b61d229fc15a0","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":34446334,"name":"hawkular-apm","full_name":"hawkular/hawkular-apm","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-apm","description":"Application Performance Management for Hawkular","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-apm","forks_url":"https://api.github.com/repos/hawkular/hawkular-apm/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-apm/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-apm/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-apm/deployments","created_at":"2015-04-23T09:17:50Z","updated_at":"2016-08-01T00:58:50Z","pushed_at":"2016-08-10T15:55:39Z","git_url":"git://github.com/hawkular/hawkular-apm.git","ssh_url":"git@github.com:hawkular/hawkular-apm.git","clone_url":"https://github.com/hawkular/hawkular-apm.git","svn_url":"https://github.com/hawkular/hawkular-apm","homepage":"","size":5690,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/503"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/503"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/9d5a7aecd1ea1acf61f060611f92324b81cfe880"}}}}
{"actor":{"display_login":"objectiser"}}