{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/7962","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/7962/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/7962/comments","events_url":"https://api.github.com/repos/angular/angular/issues/7962/events","html_url":"https://github.com/angular/angular/pull/7962","id":146843132,"number":7962,"title":"refactor(Location): out of router and into platform/common","user":{"login":"NathanWalker","id":457187,"avatar_url":"https://avatars.githubusercontent.com/u/457187?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanWalker","html_url":"https://github.com/NathanWalker","followers_url":"https://api.github.com/users/NathanWalker/followers","following_url":"https://api.github.com/users/NathanWalker/following{/other_user}","gists_url":"https://api.github.com/users/NathanWalker/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanWalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanWalker/subscriptions","organizations_url":"https://api.github.com/users/NathanWalker/orgs","repos_url":"https://api.github.com/users/NathanWalker/repos","events_url":"https://api.github.com/users/NathanWalker/events{/privacy}","received_events_url":"https://api.github.com/users/NathanWalker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/angular/angular/labels/pr_action:%20cleanup","name":"pr_action: cleanup","color":"e11d21"},{"url":"https://api.github.com/repos/angular/angular/labels/pr_state:%20LGTM","name":"pr_state: LGTM","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2016-04-08T07:36:33Z","updated_at":"2016-04-12T00:45:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/7962","html_url":"https://github.com/angular/angular/pull/7962","diff_url":"https://github.com/angular/angular/pull/7962.diff","patch_url":"https://github.com/angular/angular/pull/7962.patch"},"body":"- [x] update documentation to reflect changes\r\n- [x] discuss barrels/decide final placement for several auxiliary location classes.\r\n- [x] update `public_api_spec.ts` with new api changes\r\n- [x] squash and update commit message to reflect breaking changes\r\n\r\n@mhevery I don't want this to affect the hard work going into making the ~ 10 KB goal for core.\r\n\r\nI could foresee `Location`, `LocationStrategy`, `HashLocationStrategy`, `PathLocationStrategy`, `APP_BASE_HREF` going into `angular2/common`.\r\n\r\nPlease review when possible and let me know your thoughts."},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/208647513","html_url":"https://github.com/angular/angular/pull/7962#issuecomment-208647513","issue_url":"https://api.github.com/repos/angular/angular/issues/7962","id":208647513,"user":{"login":"NathanWalker","id":457187,"avatar_url":"https://avatars.githubusercontent.com/u/457187?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanWalker","html_url":"https://github.com/NathanWalker","followers_url":"https://api.github.com/users/NathanWalker/followers","following_url":"https://api.github.com/users/NathanWalker/following{/other_user}","gists_url":"https://api.github.com/users/NathanWalker/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanWalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanWalker/subscriptions","organizations_url":"https://api.github.com/users/NathanWalker/orgs","repos_url":"https://api.github.com/users/NathanWalker/repos","events_url":"https://api.github.com/users/NathanWalker/events{/privacy}","received_events_url":"https://api.github.com/users/NathanWalker/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T00:45:50Z","updated_at":"2016-04-12T00:45:50Z","body":"Just for ref (mentioned in commit msg):\r\n\r\n`Location` and other related providers have been moved out of `router` and into `platform/common`. `BrowserPlatformLocation` is not meant to be used directly however advanced configurations may use it via the following import change.\r\n\r\nBefore:\r\n\r\n```\r\nimport {\r\n  PlatformLocation,\r\n  Location,\r\n  LocationStrategy,\r\n  HashLocationStrategy,\r\n  PathLocationStrategy,\r\n  APP_BASE_HREF}\r\nfrom 'angular2/router';\r\n\r\nimport {BrowserPlatformLocation} from 'angular2/src/router/location/browser_platform_location';\r\n```\r\n\r\nAfter:\r\n\r\n```\r\nimport {\r\n  PlatformLocation,\r\n  Location,\r\n  LocationStrategy,\r\n  HashLocationStrategy,\r\n  PathLocationStrategy,\r\n  APP_BASE_HREF}\r\nfrom 'angular2/platform/common';\r\n\r\nimport {BrowserPlatformLocation} from 'angular2/src/platform/browser/location/browser_platform_location';\r\n```\r\n"}}