{"action":"created","issue":{"url":"https://api.github.com/repos/pinterest/riffed/issues/25","repository_url":"https://api.github.com/repos/pinterest/riffed","labels_url":"https://api.github.com/repos/pinterest/riffed/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/pinterest/riffed/issues/25/comments","events_url":"https://api.github.com/repos/pinterest/riffed/issues/25/events","html_url":"https://github.com/pinterest/riffed/pull/25","id":154271169,"number":25,"title":"Clean up client","user":{"login":"scohen","id":55809,"avatar_url":"https://avatars.githubusercontent.com/u/55809?v=3","gravatar_id":"","url":"https://api.github.com/users/scohen","html_url":"https://github.com/scohen","followers_url":"https://api.github.com/users/scohen/followers","following_url":"https://api.github.com/users/scohen/following{/other_user}","gists_url":"https://api.github.com/users/scohen/gists{/gist_id}","starred_url":"https://api.github.com/users/scohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scohen/subscriptions","organizations_url":"https://api.github.com/users/scohen/orgs","repos_url":"https://api.github.com/users/scohen/repos","events_url":"https://api.github.com/users/scohen/events{/privacy}","received_events_url":"https://api.github.com/users/scohen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-11T15:23:08Z","updated_at":"2016-05-11T16:15:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pinterest/riffed/pulls/25","html_url":"https://github.com/pinterest/riffed/pull/25","diff_url":"https://github.com/pinterest/riffed/pull/25.diff","patch_url":"https://github.com/pinterest/riffed/pull/25.patch"},"body":"This fixes a bug present in the erlang thrift client since at least 0.9.3, but is fixed in the forthcoming 0.10.\r\nThe client doesn't properly detect sockets that have been closed and as a result, leaks ports. Riffed would reconnect, but without cleaning up the port (which it shouldn't have to do). Since the mainline branch of riffed works with 0.9.3, I think this is a prudent fix.\r\n\r\n@jparise @pguillory "},"comment":{"url":"https://api.github.com/repos/pinterest/riffed/issues/comments/218510074","html_url":"https://github.com/pinterest/riffed/pull/25#issuecomment-218510074","issue_url":"https://api.github.com/repos/pinterest/riffed/issues/25","id":218510074,"user":{"login":"jparise","id":10311,"avatar_url":"https://avatars.githubusercontent.com/u/10311?v=3","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T16:15:51Z","updated_at":"2016-05-11T16:15:51Z","body":"Great! 👍 "}}