{"action":"created","issue":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-go/issues/48","repository_url":"https://api.github.com/repos/OpenBazaar/openbazaar-go","labels_url":"https://api.github.com/repos/OpenBazaar/openbazaar-go/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-go/issues/48/comments","events_url":"https://api.github.com/repos/OpenBazaar/openbazaar-go/issues/48/events","html_url":"https://github.com/OpenBazaar/openbazaar-go/issues/48","id":168669064,"number":48,"title":"Misc contracts.proto comments","user":{"login":"JustinDrake","id":731743,"avatar_url":"https://avatars.githubusercontent.com/u/731743?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinDrake","html_url":"https://github.com/JustinDrake","followers_url":"https://api.github.com/users/JustinDrake/followers","following_url":"https://api.github.com/users/JustinDrake/following{/other_user}","gists_url":"https://api.github.com/users/JustinDrake/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinDrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinDrake/subscriptions","organizations_url":"https://api.github.com/users/JustinDrake/orgs","repos_url":"https://api.github.com/users/JustinDrake/repos","events_url":"https://api.github.com/users/JustinDrake/events{/privacy}","received_events_url":"https://api.github.com/users/JustinDrake/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-01T15:08:43Z","updated_at":"2016-08-01T17:12:24Z","closed_at":null,"body":"1. `double price` -> Prefer using integers for prices, especially given JavaScript and Go handle floats differently.\r\n2. `string slug` -> What is a slug? Maybe add a descriptive comment\r\n3. Why do `Coupon`s have a `hash`?\r\n4. `Tax tax` -> Should this be `repeated Tax tax`?\r\n5. `string moderator` -> Should this be more structured, e.g. `ID moderator`?\r\n6. Why is the `Metadata` separated out from the `Item`? It's confusing for the listing data to be spread out. Can these two be merged?\r\n7. Why does `Image` have a `fileName`? I don't see how this is helpful.\r\n8. I suggest adding a `description` to `Image`. Different images can show different aspects of a listing, and image descriptions can provide context.\r\n9. `string condition` -> Having constraints on the `condition` makes it manageable (e.g. the current the five options `New`, `Good`, `Excellent`, `Poor`, `Refurbished` add consistency throughout)\r\n10. `ID vendorID` -> Can the naming be simplified to `ID vendor`? Same with `ID buyerID`.\r\n11. `Shouldn't be included in the seeded listing.` (referring to `inventoryCount`) -> Why not make this public?\r\n12. `Price pricePerUnit` -> Can the naming be simplified to `Price price`?\r\n13. `string estimatedDelivery` -> Generally freetext strings produce messy listings that are hard for machines to parse/understand. Should this be a timestamp, i.e. `uint64 estimatedDelivery`?\r\n14. `string chaincode` -> What is `chaincode`? Should it be `chainCode`?\r\n15. `Method method` -> This seems redundant given we have `string moderator` right below. (No moderator chosen means direct payment.)\r\n16. Why do we have `bytes listingHash` but `string hash` for `Image` and `Coupon`?\r\n17. It's a bit confusing that `Listing` and `Order` both have `Item`, but those are very different."},"comment":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-go/issues/comments/236644361","html_url":"https://github.com/OpenBazaar/openbazaar-go/issues/48#issuecomment-236644361","issue_url":"https://api.github.com/repos/OpenBazaar/openbazaar-go/issues/48","id":236644361,"user":{"login":"jjeffryes","id":1584275,"avatar_url":"https://avatars.githubusercontent.com/u/1584275?v=3","gravatar_id":"","url":"https://api.github.com/users/jjeffryes","html_url":"https://github.com/jjeffryes","followers_url":"https://api.github.com/users/jjeffryes/followers","following_url":"https://api.github.com/users/jjeffryes/following{/other_user}","gists_url":"https://api.github.com/users/jjeffryes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeffryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeffryes/subscriptions","organizations_url":"https://api.github.com/users/jjeffryes/orgs","repos_url":"https://api.github.com/users/jjeffryes/repos","events_url":"https://api.github.com/users/jjeffryes/events{/privacy}","received_events_url":"https://api.github.com/users/jjeffryes/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T17:12:24Z","updated_at":"2016-08-01T17:12:24Z","body":"8: adding a description to images, we've discussed this in the past, it would be useful, but would also complicate adding images to a listing. We'd probably need to change the design for that. @morebrownies?\r\n\r\n9: constraining the condition value to a pre-set list would be useful if we were searching on it, currently we don't have plans to do so. It might be useful for future-proofing. "}}
{"actor":{"display_login":"jjeffryes"}}