{"action":"created","comment":{"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/comments/49320335","id":49320335,"diff_hunk":"@@ -0,0 +1,66 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\"\n+         xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+         xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+    <parent>\n+        <artifactId>terracotta-core-root</artifactId>\n+        <groupId>org.terracotta.internal</groupId>\n+        <version>5.0.0-SNAPSHOT</version>\n+    </parent>\n+    <modelVersion>4.0.0</modelVersion>\n+\n+    <artifactId>terracotta</artifactId>","path":"terracotta/pom.xml","position":12,"original_position":12,"commit_id":"9c10d2a7ef5a903c94fba30a108998b88570e3aa","original_commit_id":"9c10d2a7ef5a903c94fba30a108998b88570e3aa","user":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"body":"Why do we need this new module?\r\nJust for the dependency resolution?\r\nHow can this not be achieved by using the only dependency declared here as the kit main dependency?","created_at":"2016-01-11T13:29:08Z","updated_at":"2016-01-11T13:29:08Z","html_url":"https://github.com/Terracotta-OSS/terracotta-core/pull/22#discussion_r49320335","pull_request_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/comments/49320335"},"html":{"href":"https://github.com/Terracotta-OSS/terracotta-core/pull/22#discussion_r49320335"},"pull_request":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22","id":55459369,"html_url":"https://github.com/Terracotta-OSS/terracotta-core/pull/22","diff_url":"https://github.com/Terracotta-OSS/terracotta-core/pull/22.diff","patch_url":"https://github.com/Terracotta-OSS/terracotta-core/pull/22.patch","issue_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/issues/22","number":22,"state":"open","locked":false,"title":"Fix #21 - [TAB-6591] First cut of terracotta-kit","user":{"login":"ramsai1729","id":1333257,"avatar_url":"https://avatars.githubusercontent.com/u/1333257?v=3","gravatar_id":"","url":"https://api.github.com/users/ramsai1729","html_url":"https://github.com/ramsai1729","followers_url":"https://api.github.com/users/ramsai1729/followers","following_url":"https://api.github.com/users/ramsai1729/following{/other_user}","gists_url":"https://api.github.com/users/ramsai1729/gists{/gist_id}","starred_url":"https://api.github.com/users/ramsai1729/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramsai1729/subscriptions","organizations_url":"https://api.github.com/users/ramsai1729/orgs","repos_url":"https://api.github.com/users/ramsai1729/repos","events_url":"https://api.github.com/users/ramsai1729/events{/privacy}","received_events_url":"https://api.github.com/users/ramsai1729/received_events","type":"User","site_admin":false},"body":"#### Changes\r\n* a terracotta-kit with structure mentioned in the issue #21 \r\n* Changes to class loading to support the new server structure \r\n\r\n#### Few things to note\r\n* need a license to start a server, we need to discuss further and fix this \r\n* new class loading changes triggered using system property \"using-terracotta-kit\"  ","created_at":"2016-01-08T13:04:57Z","updated_at":"2016-01-11T13:29:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c92a3c43e8f623538cc8bfaff332e46a1e014323","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/issues/22/comments","statuses_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/statuses/9c10d2a7ef5a903c94fba30a108998b88570e3aa","head":{"label":"ramsai1729:terracotta-kit","ref":"terracotta-kit","sha":"9c10d2a7ef5a903c94fba30a108998b88570e3aa","user":{"login":"ramsai1729","id":1333257,"avatar_url":"https://avatars.githubusercontent.com/u/1333257?v=3","gravatar_id":"","url":"https://api.github.com/users/ramsai1729","html_url":"https://github.com/ramsai1729","followers_url":"https://api.github.com/users/ramsai1729/followers","following_url":"https://api.github.com/users/ramsai1729/following{/other_user}","gists_url":"https://api.github.com/users/ramsai1729/gists{/gist_id}","starred_url":"https://api.github.com/users/ramsai1729/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramsai1729/subscriptions","organizations_url":"https://api.github.com/users/ramsai1729/orgs","repos_url":"https://api.github.com/users/ramsai1729/repos","events_url":"https://api.github.com/users/ramsai1729/events{/privacy}","received_events_url":"https://api.github.com/users/ramsai1729/received_events","type":"User","site_admin":false},"repo":{"id":47310181,"name":"terracotta-core","full_name":"ramsai1729/terracotta-core","owner":{"login":"ramsai1729","id":1333257,"avatar_url":"https://avatars.githubusercontent.com/u/1333257?v=3","gravatar_id":"","url":"https://api.github.com/users/ramsai1729","html_url":"https://github.com/ramsai1729","followers_url":"https://api.github.com/users/ramsai1729/followers","following_url":"https://api.github.com/users/ramsai1729/following{/other_user}","gists_url":"https://api.github.com/users/ramsai1729/gists{/gist_id}","starred_url":"https://api.github.com/users/ramsai1729/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramsai1729/subscriptions","organizations_url":"https://api.github.com/users/ramsai1729/orgs","repos_url":"https://api.github.com/users/ramsai1729/repos","events_url":"https://api.github.com/users/ramsai1729/events{/privacy}","received_events_url":"https://api.github.com/users/ramsai1729/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramsai1729/terracotta-core","description":"","fork":true,"url":"https://api.github.com/repos/ramsai1729/terracotta-core","forks_url":"https://api.github.com/repos/ramsai1729/terracotta-core/forks","keys_url":"https://api.github.com/repos/ramsai1729/terracotta-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramsai1729/terracotta-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramsai1729/terracotta-core/teams","hooks_url":"https://api.github.com/repos/ramsai1729/terracotta-core/hooks","issue_events_url":"https://api.github.com/repos/ramsai1729/terracotta-core/issues/events{/number}","events_url":"https://api.github.com/repos/ramsai1729/terracotta-core/events","assignees_url":"https://api.github.com/repos/ramsai1729/terracotta-core/assignees{/user}","branches_url":"https://api.github.com/repos/ramsai1729/terracotta-core/branches{/branch}","tags_url":"https://api.github.com/repos/ramsai1729/terracotta-core/tags","blobs_url":"https://api.github.com/repos/ramsai1729/terracotta-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramsai1729/terracotta-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramsai1729/terracotta-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramsai1729/terracotta-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramsai1729/terracotta-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ramsai1729/terracotta-core/languages","stargazers_url":"https://api.github.com/repos/ramsai1729/terracotta-core/stargazers","contributors_url":"https://api.github.com/repos/ramsai1729/terracotta-core/contributors","subscribers_url":"https://api.github.com/repos/ramsai1729/terracotta-core/subscribers","subscription_url":"https://api.github.com/repos/ramsai1729/terracotta-core/subscription","commits_url":"https://api.github.com/repos/ramsai1729/terracotta-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramsai1729/terracotta-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramsai1729/terracotta-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramsai1729/terracotta-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramsai1729/terracotta-core/contents/{+path}","compare_url":"https://api.github.com/repos/ramsai1729/terracotta-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramsai1729/terracotta-core/merges","archive_url":"https://api.github.com/repos/ramsai1729/terracotta-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramsai1729/terracotta-core/downloads","issues_url":"https://api.github.com/repos/ramsai1729/terracotta-core/issues{/number}","pulls_url":"https://api.github.com/repos/ramsai1729/terracotta-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ramsai1729/terracotta-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ramsai1729/terracotta-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramsai1729/terracotta-core/labels{/name}","releases_url":"https://api.github.com/repos/ramsai1729/terracotta-core/releases{/id}","created_at":"2015-12-03T05:26:40Z","updated_at":"2015-12-03T05:26:50Z","pushed_at":"2016-01-11T11:22:17Z","git_url":"git://github.com/ramsai1729/terracotta-core.git","ssh_url":"git@github.com:ramsai1729/terracotta-core.git","clone_url":"https://github.com/ramsai1729/terracotta-core.git","svn_url":"https://github.com/ramsai1729/terracotta-core","homepage":null,"size":45396,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Terracotta-OSS:master","ref":"master","sha":"6fcdcb4c6840b0514225eb1d702a3173d16d4141","user":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars.githubusercontent.com/u/4680389?v=3","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"repo":{"id":46975885,"name":"terracotta-core","full_name":"Terracotta-OSS/terracotta-core","owner":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars.githubusercontent.com/u/4680389?v=3","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Terracotta-OSS/terracotta-core","description":"","fork":false,"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core","forks_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/forks","keys_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/teams","hooks_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/hooks","issue_events_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/issues/events{/number}","events_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/events","assignees_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/assignees{/user}","branches_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/branches{/branch}","tags_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/tags","blobs_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/languages","stargazers_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/stargazers","contributors_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/contributors","subscribers_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/subscribers","subscription_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/subscription","commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/contents/{+path}","compare_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/merges","archive_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/downloads","issues_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/issues{/number}","pulls_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/labels{/name}","releases_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/releases{/id}","created_at":"2015-11-27T11:04:35Z","updated_at":"2015-11-27T11:07:01Z","pushed_at":"2016-01-11T11:22:17Z","git_url":"git://github.com/Terracotta-OSS/terracotta-core.git","ssh_url":"git@github.com:Terracotta-OSS/terracotta-core.git","clone_url":"https://github.com/Terracotta-OSS/terracotta-core.git","svn_url":"https://github.com/Terracotta-OSS/terracotta-core","homepage":null,"size":45387,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22"},"html":{"href":"https://github.com/Terracotta-OSS/terracotta-core/pull/22"},"issue":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/issues/22"},"comments":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-core/statuses/9c10d2a7ef5a903c94fba30a108998b88570e3aa"}}}}