{"action":"opened","number":1839,"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/1839","id":78719567,"html_url":"https://github.com/google/protobuf/pull/1839","diff_url":"https://github.com/google/protobuf/pull/1839.diff","patch_url":"https://github.com/google/protobuf/pull/1839.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/1839","number":1839,"state":"open","locked":false,"title":"Remove redundant symbol","user":{"login":"koubaa","id":11414628,"avatar_url":"https://avatars.githubusercontent.com/u/11414628?v=3","gravatar_id":"","url":"https://api.github.com/users/koubaa","html_url":"https://github.com/koubaa","followers_url":"https://api.github.com/users/koubaa/followers","following_url":"https://api.github.com/users/koubaa/following{/other_user}","gists_url":"https://api.github.com/users/koubaa/gists{/gist_id}","starred_url":"https://api.github.com/users/koubaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koubaa/subscriptions","organizations_url":"https://api.github.com/users/koubaa/orgs","repos_url":"https://api.github.com/users/koubaa/repos","events_url":"https://api.github.com/users/koubaa/events{/privacy}","received_events_url":"https://api.github.com/users/koubaa/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nMy organization is trying to begin using protobufs.  This PR is for a compilation issue that appears to be a bug in MSVC.  We include a header file (foo.h) that contains the lines:\r\n\r\nclass Element;\r\ntypedef class Element Element;\r\n\r\nWe are not at liberty to change this file and find a compilation error at the line which this PR changes.   The compiler error is as follows:\r\n\r\n>Protobuf\\3.0.0.b4\\cpp\\include\\google/protobuf/repeated_field.h(284): error C2027: use of undefined type 'Element'\r\n1>          path\\to\\foo.h(630) : see declaration of 'Element'\r\n1>          Protobuf\\3.0.0.b4\\cpp\\include\\google/protobuf/repeated_field.h(279) : while compiling class template member function 'void google::protobuf::RepeatedField<Element>::InternalDeallocate(google::protobuf::RepeatedField<Element>::Rep *,int)'\r\n1>          with\r\n1>          [\r\n1>              Element=google::protobuf::int32\r\n1>          ]\r\n1>          Protobuf\\3.0.0.b4\\cpp\\include\\google/protobuf/repeated_field.h(1298) : see reference to function template instantiation 'void google::protobuf::RepeatedField<Element>::InternalDeallocate(google::protobuf::RepeatedField<Element>::Rep *,int)' being compiled\r\n1>          with\r\n1>          [\r\n1>              Element=google::protobuf::int32\r\n1>          ]\r\n1>          caerep.property.pb.h(128) : see reference to class template instantiation 'google::protobuf::RepeatedField<Element>' being compiled\r\n1>          with\r\n1>          [\r\n1>              Element=google::protobuf::int32\r\n1>          ]\r\n1>Protobuf\\3.0.0.b4\\cpp\\include\\google/protobuf/repeated_field.h(284): error C2273: 'function-style cast' : illegal as right side of '->' operator\r\n\r\n","created_at":"2016-07-25T17:24:54Z","updated_at":"2016-07-25T17:24:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/1839/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/1839/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/1839/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/7cb01be7b52a1b79037edc23c05f9a8acf65c35e","head":{"label":"koubaa:element_type_fix","ref":"element_type_fix","sha":"7cb01be7b52a1b79037edc23c05f9a8acf65c35e","user":{"login":"koubaa","id":11414628,"avatar_url":"https://avatars.githubusercontent.com/u/11414628?v=3","gravatar_id":"","url":"https://api.github.com/users/koubaa","html_url":"https://github.com/koubaa","followers_url":"https://api.github.com/users/koubaa/followers","following_url":"https://api.github.com/users/koubaa/following{/other_user}","gists_url":"https://api.github.com/users/koubaa/gists{/gist_id}","starred_url":"https://api.github.com/users/koubaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koubaa/subscriptions","organizations_url":"https://api.github.com/users/koubaa/orgs","repos_url":"https://api.github.com/users/koubaa/repos","events_url":"https://api.github.com/users/koubaa/events{/privacy}","received_events_url":"https://api.github.com/users/koubaa/received_events","type":"User","site_admin":false},"repo":{"id":63967430,"name":"protobuf","full_name":"koubaa/protobuf","owner":{"login":"koubaa","id":11414628,"avatar_url":"https://avatars.githubusercontent.com/u/11414628?v=3","gravatar_id":"","url":"https://api.github.com/users/koubaa","html_url":"https://github.com/koubaa","followers_url":"https://api.github.com/users/koubaa/followers","following_url":"https://api.github.com/users/koubaa/following{/other_user}","gists_url":"https://api.github.com/users/koubaa/gists{/gist_id}","starred_url":"https://api.github.com/users/koubaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koubaa/subscriptions","organizations_url":"https://api.github.com/users/koubaa/orgs","repos_url":"https://api.github.com/users/koubaa/repos","events_url":"https://api.github.com/users/koubaa/events{/privacy}","received_events_url":"https://api.github.com/users/koubaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koubaa/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/koubaa/protobuf","forks_url":"https://api.github.com/repos/koubaa/protobuf/forks","keys_url":"https://api.github.com/repos/koubaa/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koubaa/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koubaa/protobuf/teams","hooks_url":"https://api.github.com/repos/koubaa/protobuf/hooks","issue_events_url":"https://api.github.com/repos/koubaa/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/koubaa/protobuf/events","assignees_url":"https://api.github.com/repos/koubaa/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/koubaa/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/koubaa/protobuf/tags","blobs_url":"https://api.github.com/repos/koubaa/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koubaa/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koubaa/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/koubaa/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koubaa/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/koubaa/protobuf/languages","stargazers_url":"https://api.github.com/repos/koubaa/protobuf/stargazers","contributors_url":"https://api.github.com/repos/koubaa/protobuf/contributors","subscribers_url":"https://api.github.com/repos/koubaa/protobuf/subscribers","subscription_url":"https://api.github.com/repos/koubaa/protobuf/subscription","commits_url":"https://api.github.com/repos/koubaa/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/koubaa/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/koubaa/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/koubaa/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/koubaa/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/koubaa/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koubaa/protobuf/merges","archive_url":"https://api.github.com/repos/koubaa/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koubaa/protobuf/downloads","issues_url":"https://api.github.com/repos/koubaa/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/koubaa/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/koubaa/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/koubaa/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koubaa/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/koubaa/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/koubaa/protobuf/deployments","created_at":"2016-07-22T16:23:17Z","updated_at":"2016-07-22T16:23:28Z","pushed_at":"2016-07-25T17:20:10Z","git_url":"git://github.com/koubaa/protobuf.git","ssh_url":"git@github.com:koubaa/protobuf.git","clone_url":"https://github.com/koubaa/protobuf.git","svn_url":"https://github.com/koubaa/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":34256,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"b6cd9dd759a2a3f53b8260431566aab82f7f83ac","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/google/protobuf/deployments","created_at":"2014-08-26T15:52:15Z","updated_at":"2016-07-25T17:11:27Z","pushed_at":"2016-07-25T17:19:17Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":61858,"stargazers_count":10357,"watchers_count":10357,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3127,"mirror_url":null,"open_issues_count":432,"forks":3127,"open_issues":432,"watchers":10357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/1839"},"html":{"href":"https://github.com/google/protobuf/pull/1839"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/1839"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/1839/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/1839/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/1839/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/7cb01be7b52a1b79037edc23c05f9a8acf65c35e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"koubaa"}}