{"action":"created","comment":{"url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/comments/91418531","pull_request_review_id":11926967,"id":91418531,"diff_hunk":"@@ -797,11 +798,18 @@ trait StagedExp extends Staged with ScalaOpsPkgExp with BooleanOpsExpOpt with St\n             if P then (if Q then R) --> if (P && Q) then R\n         if P then (for x in Q do R) --> for x in Q do (if P then R)\n */\n+    // NOTE(trans): we need to use List[T]() instead of List().","path":"test-src/epfl/test14-scratch/TestQueries.scala","position":191,"original_position":191,"commit_id":"4909fe8cc25431c0f2820c222d1e66c5a6e4d4ab","original_commit_id":"4909fe8cc25431c0f2820c222d1e66c5a6e4d4ab","user":{"login":"dkoeplin","id":5581940,"avatar_url":"https://avatars.githubusercontent.com/u/5581940?v=3","gravatar_id":"","url":"https://api.github.com/users/dkoeplin","html_url":"https://github.com/dkoeplin","followers_url":"https://api.github.com/users/dkoeplin/followers","following_url":"https://api.github.com/users/dkoeplin/following{/other_user}","gists_url":"https://api.github.com/users/dkoeplin/gists{/gist_id}","starred_url":"https://api.github.com/users/dkoeplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkoeplin/subscriptions","organizations_url":"https://api.github.com/users/dkoeplin/orgs","repos_url":"https://api.github.com/users/dkoeplin/repos","events_url":"https://api.github.com/users/dkoeplin/events{/privacy}","received_events_url":"https://api.github.com/users/dkoeplin/received_events","type":"User","site_admin":false},"body":"This is a really strangely written test. The unapply methods have type parameters, which I first assumed wouldn't do anything because of type erasure, but it turns out they're required but the compiler can't make the jump that type B from the unapply method is equal to type T of the input? Why did this work before?","created_at":"2016-12-08T00:21:24Z","updated_at":"2016-12-08T00:21:24Z","html_url":"https://github.com/TiarkRompf/virtualization-lms-core/pull/117#discussion_r91418531","pull_request_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/comments/91418531"},"html":{"href":"https://github.com/TiarkRompf/virtualization-lms-core/pull/117#discussion_r91418531"},"pull_request":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117","id":96212787,"html_url":"https://github.com/TiarkRompf/virtualization-lms-core/pull/117","diff_url":"https://github.com/TiarkRompf/virtualization-lms-core/pull/117.diff","patch_url":"https://github.com/TiarkRompf/virtualization-lms-core/pull/117.patch","issue_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/issues/117","number":117,"state":"open","locked":false,"title":"Macro Virtualized","user":{"login":"dkoeplin","id":5581940,"avatar_url":"https://avatars.githubusercontent.com/u/5581940?v=3","gravatar_id":"","url":"https://api.github.com/users/dkoeplin","html_url":"https://github.com/dkoeplin","followers_url":"https://api.github.com/users/dkoeplin/followers","following_url":"https://api.github.com/users/dkoeplin/following{/other_user}","gists_url":"https://api.github.com/users/dkoeplin/gists{/gist_id}","starred_url":"https://api.github.com/users/dkoeplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkoeplin/subscriptions","organizations_url":"https://api.github.com/users/dkoeplin/orgs","repos_url":"https://api.github.com/users/dkoeplin/repos","events_url":"https://api.github.com/users/dkoeplin/events{/privacy}","received_events_url":"https://api.github.com/users/dkoeplin/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-02T02:54:04Z","updated_at":"2016-12-08T00:21:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"dkoeplin","id":5581940,"avatar_url":"https://avatars.githubusercontent.com/u/5581940?v=3","gravatar_id":"","url":"https://api.github.com/users/dkoeplin","html_url":"https://github.com/dkoeplin","followers_url":"https://api.github.com/users/dkoeplin/followers","following_url":"https://api.github.com/users/dkoeplin/following{/other_user}","gists_url":"https://api.github.com/users/dkoeplin/gists{/gist_id}","starred_url":"https://api.github.com/users/dkoeplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkoeplin/subscriptions","organizations_url":"https://api.github.com/users/dkoeplin/orgs","repos_url":"https://api.github.com/users/dkoeplin/repos","events_url":"https://api.github.com/users/dkoeplin/events{/privacy}","received_events_url":"https://api.github.com/users/dkoeplin/received_events","type":"User","site_admin":false},"assignees":[{"login":"dkoeplin","id":5581940,"avatar_url":"https://avatars.githubusercontent.com/u/5581940?v=3","gravatar_id":"","url":"https://api.github.com/users/dkoeplin","html_url":"https://github.com/dkoeplin","followers_url":"https://api.github.com/users/dkoeplin/followers","following_url":"https://api.github.com/users/dkoeplin/following{/other_user}","gists_url":"https://api.github.com/users/dkoeplin/gists{/gist_id}","starred_url":"https://api.github.com/users/dkoeplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkoeplin/subscriptions","organizations_url":"https://api.github.com/users/dkoeplin/orgs","repos_url":"https://api.github.com/users/dkoeplin/repos","events_url":"https://api.github.com/users/dkoeplin/events{/privacy}","received_events_url":"https://api.github.com/users/dkoeplin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117/commits","review_comments_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117/comments","review_comment_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/issues/117/comments","statuses_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/statuses/4909fe8cc25431c0f2820c222d1e66c5a6e4d4ab","head":{"label":"DeliteEPFL:macrovirt","ref":"macrovirt","sha":"4909fe8cc25431c0f2820c222d1e66c5a6e4d4ab","user":{"login":"DeliteEPFL","id":15256853,"avatar_url":"https://avatars.githubusercontent.com/u/15256853?v=3","gravatar_id":"","url":"https://api.github.com/users/DeliteEPFL","html_url":"https://github.com/DeliteEPFL","followers_url":"https://api.github.com/users/DeliteEPFL/followers","following_url":"https://api.github.com/users/DeliteEPFL/following{/other_user}","gists_url":"https://api.github.com/users/DeliteEPFL/gists{/gist_id}","starred_url":"https://api.github.com/users/DeliteEPFL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeliteEPFL/subscriptions","organizations_url":"https://api.github.com/users/DeliteEPFL/orgs","repos_url":"https://api.github.com/users/DeliteEPFL/repos","events_url":"https://api.github.com/users/DeliteEPFL/events{/privacy}","received_events_url":"https://api.github.com/users/DeliteEPFL/received_events","type":"Organization","site_admin":false},"repo":{"id":44784099,"name":"virtualization-lms-core","full_name":"DeliteEPFL/virtualization-lms-core","owner":{"login":"DeliteEPFL","id":15256853,"avatar_url":"https://avatars.githubusercontent.com/u/15256853?v=3","gravatar_id":"","url":"https://api.github.com/users/DeliteEPFL","html_url":"https://github.com/DeliteEPFL","followers_url":"https://api.github.com/users/DeliteEPFL/followers","following_url":"https://api.github.com/users/DeliteEPFL/following{/other_user}","gists_url":"https://api.github.com/users/DeliteEPFL/gists{/gist_id}","starred_url":"https://api.github.com/users/DeliteEPFL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeliteEPFL/subscriptions","organizations_url":"https://api.github.com/users/DeliteEPFL/orgs","repos_url":"https://api.github.com/users/DeliteEPFL/repos","events_url":"https://api.github.com/users/DeliteEPFL/events{/privacy}","received_events_url":"https://api.github.com/users/DeliteEPFL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DeliteEPFL/virtualization-lms-core","description":"A Framework for Runtime Code Generation and Compiled DSLs","fork":true,"url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core","forks_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/forks","keys_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/teams","hooks_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/hooks","issue_events_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/issues/events{/number}","events_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/events","assignees_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/assignees{/user}","branches_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/branches{/branch}","tags_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/tags","blobs_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/languages","stargazers_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/stargazers","contributors_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/contributors","subscribers_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/subscribers","subscription_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/subscription","commits_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/contents/{+path}","compare_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/merges","archive_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/downloads","issues_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/issues{/number}","pulls_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/labels{/name}","releases_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/releases{/id}","deployments_url":"https://api.github.com/repos/DeliteEPFL/virtualization-lms-core/deployments","created_at":"2015-10-23T01:44:46Z","updated_at":"2016-01-28T17:57:11Z","pushed_at":"2016-03-08T19:40:50Z","git_url":"git://github.com/DeliteEPFL/virtualization-lms-core.git","ssh_url":"git@github.com:DeliteEPFL/virtualization-lms-core.git","clone_url":"https://github.com/DeliteEPFL/virtualization-lms-core.git","svn_url":"https://github.com/DeliteEPFL/virtualization-lms-core","homepage":"http://scala-lms.github.com","size":5301,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"macrovirt"}},"base":{"label":"TiarkRompf:macrovirt","ref":"macrovirt","sha":"e35626b29f5b7a2cc82e8a80cf9f124c26725b9e","user":{"login":"TiarkRompf","id":365911,"avatar_url":"https://avatars.githubusercontent.com/u/365911?v=3","gravatar_id":"","url":"https://api.github.com/users/TiarkRompf","html_url":"https://github.com/TiarkRompf","followers_url":"https://api.github.com/users/TiarkRompf/followers","following_url":"https://api.github.com/users/TiarkRompf/following{/other_user}","gists_url":"https://api.github.com/users/TiarkRompf/gists{/gist_id}","starred_url":"https://api.github.com/users/TiarkRompf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TiarkRompf/subscriptions","organizations_url":"https://api.github.com/users/TiarkRompf/orgs","repos_url":"https://api.github.com/users/TiarkRompf/repos","events_url":"https://api.github.com/users/TiarkRompf/events{/privacy}","received_events_url":"https://api.github.com/users/TiarkRompf/received_events","type":"User","site_admin":false},"repo":{"id":849923,"name":"virtualization-lms-core","full_name":"TiarkRompf/virtualization-lms-core","owner":{"login":"TiarkRompf","id":365911,"avatar_url":"https://avatars.githubusercontent.com/u/365911?v=3","gravatar_id":"","url":"https://api.github.com/users/TiarkRompf","html_url":"https://github.com/TiarkRompf","followers_url":"https://api.github.com/users/TiarkRompf/followers","following_url":"https://api.github.com/users/TiarkRompf/following{/other_user}","gists_url":"https://api.github.com/users/TiarkRompf/gists{/gist_id}","starred_url":"https://api.github.com/users/TiarkRompf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TiarkRompf/subscriptions","organizations_url":"https://api.github.com/users/TiarkRompf/orgs","repos_url":"https://api.github.com/users/TiarkRompf/repos","events_url":"https://api.github.com/users/TiarkRompf/events{/privacy}","received_events_url":"https://api.github.com/users/TiarkRompf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TiarkRompf/virtualization-lms-core","description":"A Framework for Runtime Code Generation and Compiled DSLs","fork":false,"url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core","forks_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/forks","keys_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/teams","hooks_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/hooks","issue_events_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/issues/events{/number}","events_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/events","assignees_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/assignees{/user}","branches_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/branches{/branch}","tags_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/tags","blobs_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/statuses/{sha}","languages_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/languages","stargazers_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/stargazers","contributors_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/contributors","subscribers_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/subscribers","subscription_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/subscription","commits_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/contents/{+path}","compare_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/merges","archive_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/downloads","issues_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/issues{/number}","pulls_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls{/number}","milestones_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/milestones{/number}","notifications_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/labels{/name}","releases_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/releases{/id}","deployments_url":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/deployments","created_at":"2010-08-19T21:56:53Z","updated_at":"2016-12-01T02:05:08Z","pushed_at":"2016-12-03T04:45:53Z","git_url":"git://github.com/TiarkRompf/virtualization-lms-core.git","ssh_url":"git@github.com:TiarkRompf/virtualization-lms-core.git","clone_url":"https://github.com/TiarkRompf/virtualization-lms-core.git","svn_url":"https://github.com/TiarkRompf/virtualization-lms-core","homepage":"http://scala-lms.github.com","size":9042,"stargazers_count":168,"watchers_count":168,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":28,"forks":67,"open_issues":28,"watchers":168,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117"},"html":{"href":"https://github.com/TiarkRompf/virtualization-lms-core/pull/117"},"issue":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/issues/117"},"comments":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/TiarkRompf/virtualization-lms-core/statuses/4909fe8cc25431c0f2820c222d1e66c5a6e4d4ab"}}}}
{"actor":{"display_login":"dkoeplin"}}