{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/49226682","id":49226682,"diff_hunk":"@@ -835,32 +835,73 @@ func (n *network) updateSvcRecord(ep *endpoint, localEps []*endpoint, isAdd bool\n \tsr, ok := c.svcDb[n.ID()]\n \tif !ok {\n \t\tc.svcDb[n.ID()] = svcInfo{\n-\t\t\tsvcMap: make(map[string]net.IP),\n+\t\t\tsvcMap: make(map[string][]net.IP),\n \t\t\tipMap:  make(map[string]string),\n \t\t}\n \t\tsr = c.svcDb[n.ID()]\n \t}","path":"network.go","position":18,"original_position":18,"commit_id":"031572309962a98e6306909e1695628cee1bb16f","original_commit_id":"031572309962a98e6306909e1695628cee1bb16f","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"ok. will do.","created_at":"2016-01-08T19:23:35Z","updated_at":"2016-01-08T19:23:35Z","html_url":"https://github.com/docker/libnetwork/pull/859#discussion_r49226682","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/859","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/49226682"},"html":{"href":"https://github.com/docker/libnetwork/pull/859#discussion_r49226682"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/859"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/859","id":55424069,"html_url":"https://github.com/docker/libnetwork/pull/859","diff_url":"https://github.com/docker/libnetwork/pull/859.diff","patch_url":"https://github.com/docker/libnetwork/pull/859.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/859","number":859,"state":"open","locked":false,"title":"Global alias support","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"@mrjana @sanimej PTAL. \r\n\r\nupdated with Integration Tests including shared global alias.\r\n\r\nSigned-off-by: Madhu Venugopal <madhu@docker.com>","created_at":"2016-01-08T04:35:38Z","updated_at":"2016-01-08T19:23:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4473eec04dcfccc9ac844239aa4b04f4844a2c6d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/859/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/859/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/859/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/031572309962a98e6306909e1695628cee1bb16f","head":{"label":"mavenugo:globalalias","ref":"globalalias","sha":"031572309962a98e6306909e1695628cee1bb16f","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"repo":{"id":34572010,"name":"libnetwork","full_name":"mavenugo/libnetwork","owner":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mavenugo/libnetwork","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/mavenugo/libnetwork","forks_url":"https://api.github.com/repos/mavenugo/libnetwork/forks","keys_url":"https://api.github.com/repos/mavenugo/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavenugo/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavenugo/libnetwork/teams","hooks_url":"https://api.github.com/repos/mavenugo/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/mavenugo/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/mavenugo/libnetwork/events","assignees_url":"https://api.github.com/repos/mavenugo/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/mavenugo/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/mavenugo/libnetwork/tags","blobs_url":"https://api.github.com/repos/mavenugo/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavenugo/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavenugo/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavenugo/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavenugo/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/mavenugo/libnetwork/languages","stargazers_url":"https://api.github.com/repos/mavenugo/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/mavenugo/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/mavenugo/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/mavenugo/libnetwork/subscription","commits_url":"https://api.github.com/repos/mavenugo/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavenugo/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavenugo/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavenugo/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavenugo/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/mavenugo/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavenugo/libnetwork/merges","archive_url":"https://api.github.com/repos/mavenugo/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavenugo/libnetwork/downloads","issues_url":"https://api.github.com/repos/mavenugo/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/mavenugo/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/mavenugo/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/mavenugo/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavenugo/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/mavenugo/libnetwork/releases{/id}","created_at":"2015-04-25T14:39:45Z","updated_at":"2015-05-07T18:56:18Z","pushed_at":"2016-01-08T13:27:48Z","git_url":"git://github.com/mavenugo/libnetwork.git","ssh_url":"git@github.com:mavenugo/libnetwork.git","clone_url":"https://github.com/mavenugo/libnetwork.git","svn_url":"https://github.com/mavenugo/libnetwork","homepage":"","size":7225,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"02b8962f4fb95af14832548b61a57fa6a14a4d9c","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"Docker Networking","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","created_at":"2015-02-20T01:20:15Z","updated_at":"2016-01-07T07:36:42Z","pushed_at":"2016-01-08T16:26:44Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":10742,"stargazers_count":561,"watchers_count":561,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":136,"forks":243,"open_issues":136,"watchers":561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/859"},"html":{"href":"https://github.com/docker/libnetwork/pull/859"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/859"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/031572309962a98e6306909e1695628cee1bb16f"}}}}