{"action":"created","issue":{"url":"https://api.github.com/repos/JadeCore/JadeCore/issues/62","repository_url":"https://api.github.com/repos/JadeCore/JadeCore","labels_url":"https://api.github.com/repos/JadeCore/JadeCore/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/JadeCore/JadeCore/issues/62/comments","events_url":"https://api.github.com/repos/JadeCore/JadeCore/issues/62/events","html_url":"https://github.com/JadeCore/JadeCore/pull/62","id":183579498,"number":62,"title":"Fixed VS2013 32bit","user":{"login":"wowharley","id":22310506,"avatar_url":"https://avatars.githubusercontent.com/u/22310506?v=3","gravatar_id":"","url":"https://api.github.com/users/wowharley","html_url":"https://github.com/wowharley","followers_url":"https://api.github.com/users/wowharley/followers","following_url":"https://api.github.com/users/wowharley/following{/other_user}","gists_url":"https://api.github.com/users/wowharley/gists{/gist_id}","starred_url":"https://api.github.com/users/wowharley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wowharley/subscriptions","organizations_url":"https://api.github.com/users/wowharley/orgs","repos_url":"https://api.github.com/users/wowharley/repos","events_url":"https://api.github.com/users/wowharley/events{/privacy}","received_events_url":"https://api.github.com/users/wowharley/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-18T03:08:11Z","updated_at":"2016-10-18T11:29:33Z","closed_at":"2016-10-18T03:41:08Z","pull_request":{"url":"https://api.github.com/repos/JadeCore/JadeCore/pulls/62","html_url":"https://github.com/JadeCore/JadeCore/pull/62","diff_url":"https://github.com/JadeCore/JadeCore/pull/62.diff","patch_url":"https://github.com/JadeCore/JadeCore/pull/62.patch"},"body":"I compile in both 64bit and 32bit in windows 10 VS2013\r\n\r\ncame accross this compile error in 32bit\r\n\r\n2>  instance_siege_of_orgrimmar.cpp\r\n2>C:\\Users\\wowharley\\Desktop\\JadeCore548\\src\\server\\scripts\\Pandaria\\Raids\\SiegeOfOrgrimmar\\instance_siege_of_orgrimmar.cpp(216): error C4263: 'uint64 instance_SiegeOfOrgrimmar::instance_SiegeOfOrgrimmar_InstanceMapScript::GetData64(uint32)' : member function does not override any base class virtual member function\r\n2>C:\\Users\\wowharley\\Desktop\\JadeCore548\\src\\server\\scripts\\Pandaria\\Raids\\SiegeOfOrgrimmar\\instance_siege_of_orgrimmar.cpp(296): error C4264: 'uint64 ZoneScript::GetData64(uint32) const' : no override available for virtual member function from base 'ZoneScript'; function is hidden\r\n2>          C:\\Users\\wowharley\\Desktop\\JadeCore548\\src\\server\\game\\Maps\\ZoneScript.h(45) : see declaration of 'ZoneScript::GetData64'\r\n2>          C:\\Users\\wowharley\\Desktop\\JadeCore548\\src\\server\\game\\Maps\\ZoneScript.h(28) : see declaration of 'ZoneScript'\r\n\r\nPR fixed the 32bit compile, modifying \r\n\r\nuint64 GetData64(uint32 type) \r\nto\r\nuint64 GetData64(uint32 type) const"},"comment":{"url":"https://api.github.com/repos/JadeCore/JadeCore/issues/comments/254480655","html_url":"https://github.com/JadeCore/JadeCore/pull/62#issuecomment-254480655","issue_url":"https://api.github.com/repos/JadeCore/JadeCore/issues/62","id":254480655,"user":{"login":"SkyFire","id":32227,"avatar_url":"https://avatars.githubusercontent.com/u/32227?v=3","gravatar_id":"","url":"https://api.github.com/users/SkyFire","html_url":"https://github.com/SkyFire","followers_url":"https://api.github.com/users/SkyFire/followers","following_url":"https://api.github.com/users/SkyFire/following{/other_user}","gists_url":"https://api.github.com/users/SkyFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyFire/subscriptions","organizations_url":"https://api.github.com/users/SkyFire/orgs","repos_url":"https://api.github.com/users/SkyFire/repos","events_url":"https://api.github.com/users/SkyFire/events{/privacy}","received_events_url":"https://api.github.com/users/SkyFire/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T11:29:33Z","updated_at":"2016-10-18T11:29:33Z","body":"You can compile gcc in windows before you push. It's not that hard to do.\r\nhttps://gcc.gnu.org/install/binaries.html\r\nThis will eliminate pushing a broken build.\r\n"}}
{"actor":{"display_login":"SkyFire"}}