{"action":"created","comment":{"url":"https://api.github.com/repos/discourse/discourse/pulls/comments/73927470","id":73927470,"diff_hunk":"@@ -128,7 +129,7 @@ export default Ember.Component.extend(StringBuffer, {\n     // highlight the last topic viewed\n     if (this.session.get('lastTopicIdViewed') === this.get('topic.id')) {\n       this.session.set('lastTopicIdViewed', null);\n-      this.highlight();\n+      this.highlight(true);","path":"app/assets/javascripts/discourse/components/topic-list-item.js.es6","position":19,"original_position":19,"commit_id":"d8165d7cee84c1568678c7acde6f91af63908169","original_commit_id":"d8165d7cee84c1568678c7acde6f91af63908169","user":{"login":"eviltrout","id":17538,"avatar_url":"https://avatars.githubusercontent.com/u/17538?v=3","gravatar_id":"","url":"https://api.github.com/users/eviltrout","html_url":"https://github.com/eviltrout","followers_url":"https://api.github.com/users/eviltrout/followers","following_url":"https://api.github.com/users/eviltrout/following{/other_user}","gists_url":"https://api.github.com/users/eviltrout/gists{/gist_id}","starred_url":"https://api.github.com/users/eviltrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviltrout/subscriptions","organizations_url":"https://api.github.com/users/eviltrout/orgs","repos_url":"https://api.github.com/users/eviltrout/repos","events_url":"https://api.github.com/users/eviltrout/events{/privacy}","received_events_url":"https://api.github.com/users/eviltrout/received_events","type":"User","site_admin":false},"body":"I've grown to dislike booleans like this as parameters. Without looking at the signature it's not obvious what the `true` is for.\r\n\r\nI think it would be better to add an opts object like:\r\n\r\n`this.highlight({ isLastViewedTopic: true });`\r\n\r\n(as an aside, if the function was like `setGreen(true)` I'd have no problem with it. It's obvious it means that it's `green` in that case!)","created_at":"2016-08-08T18:26:03Z","updated_at":"2016-08-08T18:26:03Z","html_url":"https://github.com/discourse/discourse/pull/4370#discussion_r73927470","pull_request_url":"https://api.github.com/repos/discourse/discourse/pulls/4370","_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments/73927470"},"html":{"href":"https://github.com/discourse/discourse/pull/4370#discussion_r73927470"},"pull_request":{"href":"https://api.github.com/repos/discourse/discourse/pulls/4370"}}},"pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/4370","id":80342965,"html_url":"https://github.com/discourse/discourse/pull/4370","diff_url":"https://github.com/discourse/discourse/pull/4370.diff","patch_url":"https://github.com/discourse/discourse/pull/4370.patch","issue_url":"https://api.github.com/repos/discourse/discourse/issues/4370","number":4370,"state":"open","locked":false,"title":"FEATURE: Allow keyboard shortcuts for topic list to start from last viewed topic","user":{"login":"cpradio","id":2060315,"avatar_url":"https://avatars.githubusercontent.com/u/2060315?v=3","gravatar_id":"","url":"https://api.github.com/users/cpradio","html_url":"https://github.com/cpradio","followers_url":"https://api.github.com/users/cpradio/followers","following_url":"https://api.github.com/users/cpradio/following{/other_user}","gists_url":"https://api.github.com/users/cpradio/gists{/gist_id}","starred_url":"https://api.github.com/users/cpradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpradio/subscriptions","organizations_url":"https://api.github.com/users/cpradio/orgs","repos_url":"https://api.github.com/users/cpradio/repos","events_url":"https://api.github.com/users/cpradio/events{/privacy}","received_events_url":"https://api.github.com/users/cpradio/received_events","type":"User","site_admin":false},"body":"Relevant Discussion\r\nhttps://meta.discourse.org/t/keyboard-navigation-shortcuts-dont-remember-topic-list-position-on-return/48138?u=cpradio","created_at":"2016-08-06T15:31:06Z","updated_at":"2016-08-08T18:26:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"564ea6232f760907039b7aae2226e2e6c4ab143c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse/pulls/4370/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse/pulls/4370/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/4370/comments","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/d8165d7cee84c1568678c7acde6f91af63908169","head":{"label":"cpradio:keyboard-enhancements","ref":"keyboard-enhancements","sha":"d8165d7cee84c1568678c7acde6f91af63908169","user":{"login":"cpradio","id":2060315,"avatar_url":"https://avatars.githubusercontent.com/u/2060315?v=3","gravatar_id":"","url":"https://api.github.com/users/cpradio","html_url":"https://github.com/cpradio","followers_url":"https://api.github.com/users/cpradio/followers","following_url":"https://api.github.com/users/cpradio/following{/other_user}","gists_url":"https://api.github.com/users/cpradio/gists{/gist_id}","starred_url":"https://api.github.com/users/cpradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpradio/subscriptions","organizations_url":"https://api.github.com/users/cpradio/orgs","repos_url":"https://api.github.com/users/cpradio/repos","events_url":"https://api.github.com/users/cpradio/events{/privacy}","received_events_url":"https://api.github.com/users/cpradio/received_events","type":"User","site_admin":false},"repo":{"id":36930351,"name":"discourse","full_name":"cpradio/discourse","owner":{"login":"cpradio","id":2060315,"avatar_url":"https://avatars.githubusercontent.com/u/2060315?v=3","gravatar_id":"","url":"https://api.github.com/users/cpradio","html_url":"https://github.com/cpradio","followers_url":"https://api.github.com/users/cpradio/followers","following_url":"https://api.github.com/users/cpradio/following{/other_user}","gists_url":"https://api.github.com/users/cpradio/gists{/gist_id}","starred_url":"https://api.github.com/users/cpradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpradio/subscriptions","organizations_url":"https://api.github.com/users/cpradio/orgs","repos_url":"https://api.github.com/users/cpradio/repos","events_url":"https://api.github.com/users/cpradio/events{/privacy}","received_events_url":"https://api.github.com/users/cpradio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpradio/discourse","description":"A platform for community discussion. Free, open, simple.","fork":true,"url":"https://api.github.com/repos/cpradio/discourse","forks_url":"https://api.github.com/repos/cpradio/discourse/forks","keys_url":"https://api.github.com/repos/cpradio/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpradio/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpradio/discourse/teams","hooks_url":"https://api.github.com/repos/cpradio/discourse/hooks","issue_events_url":"https://api.github.com/repos/cpradio/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/cpradio/discourse/events","assignees_url":"https://api.github.com/repos/cpradio/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/cpradio/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/cpradio/discourse/tags","blobs_url":"https://api.github.com/repos/cpradio/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpradio/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpradio/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpradio/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpradio/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/cpradio/discourse/languages","stargazers_url":"https://api.github.com/repos/cpradio/discourse/stargazers","contributors_url":"https://api.github.com/repos/cpradio/discourse/contributors","subscribers_url":"https://api.github.com/repos/cpradio/discourse/subscribers","subscription_url":"https://api.github.com/repos/cpradio/discourse/subscription","commits_url":"https://api.github.com/repos/cpradio/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpradio/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpradio/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpradio/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpradio/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/cpradio/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpradio/discourse/merges","archive_url":"https://api.github.com/repos/cpradio/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpradio/discourse/downloads","issues_url":"https://api.github.com/repos/cpradio/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/cpradio/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/cpradio/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/cpradio/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpradio/discourse/labels{/name}","releases_url":"https://api.github.com/repos/cpradio/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/cpradio/discourse/deployments","created_at":"2015-06-05T11:57:54Z","updated_at":"2015-06-05T11:58:04Z","pushed_at":"2016-08-06T15:30:33Z","git_url":"git://github.com/cpradio/discourse.git","ssh_url":"git@github.com:cpradio/discourse.git","clone_url":"https://github.com/cpradio/discourse.git","svn_url":"https://github.com/cpradio/discourse","homepage":"http://www.discourse.org","size":134662,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"823a699d41974affe42adbd562cc9fbfd5a56ef1","user":{"login":"discourse","id":3220138,"avatar_url":"https://avatars.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"name":"discourse","full_name":"discourse/discourse","owner":{"login":"discourse","id":3220138,"avatar_url":"https://avatars.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2016-08-08T17:20:25Z","pushed_at":"2016-08-08T18:06:05Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"http://www.discourse.org","size":195809,"stargazers_count":18935,"watchers_count":18935,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5026,"mirror_url":null,"open_issues_count":15,"forks":5026,"open_issues":15,"watchers":18935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/4370"},"html":{"href":"https://github.com/discourse/discourse/pull/4370"},"issue":{"href":"https://api.github.com/repos/discourse/discourse/issues/4370"},"comments":{"href":"https://api.github.com/repos/discourse/discourse/issues/4370/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse/pulls/4370/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse/pulls/4370/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse/statuses/d8165d7cee84c1568678c7acde6f91af63908169"}}}}
{"actor":{"display_login":"eviltrout"}}