{"action":"closed","number":2298,"pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2298","id":84525942,"html_url":"https://github.com/scikit-image/scikit-image/pull/2298","diff_url":"https://github.com/scikit-image/scikit-image/pull/2298.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/2298.patch","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2298","number":2298,"state":"closed","locked":false,"title":"[MRG+1] TST: prefer assert_ from numpy.testing over assert","user":{"login":"grlee77","id":6528957,"avatar_url":"https://avatars.githubusercontent.com/u/6528957?v=3","gravatar_id":"","url":"https://api.github.com/users/grlee77","html_url":"https://github.com/grlee77","followers_url":"https://api.github.com/users/grlee77/followers","following_url":"https://api.github.com/users/grlee77/following{/other_user}","gists_url":"https://api.github.com/users/grlee77/gists{/gist_id}","starred_url":"https://api.github.com/users/grlee77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grlee77/subscriptions","organizations_url":"https://api.github.com/users/grlee77/orgs","repos_url":"https://api.github.com/users/grlee77/repos","events_url":"https://api.github.com/users/grlee77/events{/privacy}","received_events_url":"https://api.github.com/users/grlee77/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR just replaces all instances of `assert` with the `assert_` function from `numpy.testing`.  This came up in discussion with @soupault in #2241.  A few PEP8 fixes were performed as well.\r\n\r\nI have only made these changes within the `restoration` module for the following reasons\r\n\r\n- changing for all modules at once is likely to cause many PRs to need a rebase\r\n- to gauge interest prior to spending time on other modules\r\n","created_at":"2016-09-08T18:10:16Z","updated_at":"2016-09-10T08:40:49Z","closed_at":"2016-09-10T08:40:49Z","merged_at":"2016-09-10T08:40:49Z","merge_commit_sha":"2f71b5787662ce7589bb878c55359cd076f84c83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2298/commits","review_comments_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2298/comments","review_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2298/comments","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/2196dae7733ed2f5422589da87727ae8de4c46e2","head":{"label":"grlee77:assert_fixes","ref":"assert_fixes","sha":"2196dae7733ed2f5422589da87727ae8de4c46e2","user":{"login":"grlee77","id":6528957,"avatar_url":"https://avatars.githubusercontent.com/u/6528957?v=3","gravatar_id":"","url":"https://api.github.com/users/grlee77","html_url":"https://github.com/grlee77","followers_url":"https://api.github.com/users/grlee77/followers","following_url":"https://api.github.com/users/grlee77/following{/other_user}","gists_url":"https://api.github.com/users/grlee77/gists{/gist_id}","starred_url":"https://api.github.com/users/grlee77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grlee77/subscriptions","organizations_url":"https://api.github.com/users/grlee77/orgs","repos_url":"https://api.github.com/users/grlee77/repos","events_url":"https://api.github.com/users/grlee77/events{/privacy}","received_events_url":"https://api.github.com/users/grlee77/received_events","type":"User","site_admin":false},"repo":{"id":23844497,"name":"scikit-image","full_name":"grlee77/scikit-image","owner":{"login":"grlee77","id":6528957,"avatar_url":"https://avatars.githubusercontent.com/u/6528957?v=3","gravatar_id":"","url":"https://api.github.com/users/grlee77","html_url":"https://github.com/grlee77","followers_url":"https://api.github.com/users/grlee77/followers","following_url":"https://api.github.com/users/grlee77/following{/other_user}","gists_url":"https://api.github.com/users/grlee77/gists{/gist_id}","starred_url":"https://api.github.com/users/grlee77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grlee77/subscriptions","organizations_url":"https://api.github.com/users/grlee77/orgs","repos_url":"https://api.github.com/users/grlee77/repos","events_url":"https://api.github.com/users/grlee77/events{/privacy}","received_events_url":"https://api.github.com/users/grlee77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grlee77/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":true,"url":"https://api.github.com/repos/grlee77/scikit-image","forks_url":"https://api.github.com/repos/grlee77/scikit-image/forks","keys_url":"https://api.github.com/repos/grlee77/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grlee77/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grlee77/scikit-image/teams","hooks_url":"https://api.github.com/repos/grlee77/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/grlee77/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/grlee77/scikit-image/events","assignees_url":"https://api.github.com/repos/grlee77/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/grlee77/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/grlee77/scikit-image/tags","blobs_url":"https://api.github.com/repos/grlee77/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grlee77/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grlee77/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/grlee77/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grlee77/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/grlee77/scikit-image/languages","stargazers_url":"https://api.github.com/repos/grlee77/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/grlee77/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/grlee77/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/grlee77/scikit-image/subscription","commits_url":"https://api.github.com/repos/grlee77/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/grlee77/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/grlee77/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/grlee77/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/grlee77/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/grlee77/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grlee77/scikit-image/merges","archive_url":"https://api.github.com/repos/grlee77/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grlee77/scikit-image/downloads","issues_url":"https://api.github.com/repos/grlee77/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/grlee77/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/grlee77/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/grlee77/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grlee77/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/grlee77/scikit-image/releases{/id}","deployments_url":"https://api.github.com/repos/grlee77/scikit-image/deployments","created_at":"2014-09-09T18:00:05Z","updated_at":"2016-01-23T18:29:42Z","pushed_at":"2016-09-08T17:59:09Z","git_url":"git://github.com/grlee77/scikit-image.git","ssh_url":"git@github.com:grlee77/scikit-image.git","clone_url":"https://github.com/grlee77/scikit-image.git","svn_url":"https://github.com/grlee77/scikit-image","homepage":"http://scikit-image.org","size":41394,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-image:master","ref":"master","sha":"b1a020790cb4f0b5cad3fc4249b0e834e05d4cbe","user":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"repo":{"id":2014929,"name":"scikit-image","full_name":"scikit-image/scikit-image","owner":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-image/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":false,"url":"https://api.github.com/repos/scikit-image/scikit-image","forks_url":"https://api.github.com/repos/scikit-image/scikit-image/forks","keys_url":"https://api.github.com/repos/scikit-image/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-image/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-image/scikit-image/teams","hooks_url":"https://api.github.com/repos/scikit-image/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-image/scikit-image/events","assignees_url":"https://api.github.com/repos/scikit-image/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-image/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-image/scikit-image/tags","blobs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-image/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-image/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-image/scikit-image/languages","stargazers_url":"https://api.github.com/repos/scikit-image/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/scikit-image/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/scikit-image/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/scikit-image/scikit-image/subscription","commits_url":"https://api.github.com/repos/scikit-image/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-image/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-image/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-image/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-image/scikit-image/merges","archive_url":"https://api.github.com/repos/scikit-image/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-image/scikit-image/downloads","issues_url":"https://api.github.com/repos/scikit-image/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-image/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/scikit-image/scikit-image/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-image/scikit-image/deployments","created_at":"2011-07-07T22:07:20Z","updated_at":"2016-09-08T17:02:57Z","pushed_at":"2016-09-10T08:40:51Z","git_url":"git://github.com/scikit-image/scikit-image.git","ssh_url":"git@github.com:scikit-image/scikit-image.git","clone_url":"https://github.com/scikit-image/scikit-image.git","svn_url":"https://github.com/scikit-image/scikit-image","homepage":"http://scikit-image.org","size":75288,"stargazers_count":1237,"watchers_count":1237,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":630,"mirror_url":null,"open_issues_count":309,"forks":630,"open_issues":309,"watchers":1237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2298"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/2298"},"issue":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/2298"},"comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/2298/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2298/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2298/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-image/scikit-image/statuses/2196dae7733ed2f5422589da87727ae8de4c46e2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"soupault","id":1315589,"avatar_url":"https://avatars.githubusercontent.com/u/1315589?v=3","gravatar_id":"","url":"https://api.github.com/users/soupault","html_url":"https://github.com/soupault","followers_url":"https://api.github.com/users/soupault/followers","following_url":"https://api.github.com/users/soupault/following{/other_user}","gists_url":"https://api.github.com/users/soupault/gists{/gist_id}","starred_url":"https://api.github.com/users/soupault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soupault/subscriptions","organizations_url":"https://api.github.com/users/soupault/orgs","repos_url":"https://api.github.com/users/soupault/repos","events_url":"https://api.github.com/users/soupault/events{/privacy}","received_events_url":"https://api.github.com/users/soupault/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":93,"deletions":84,"changed_files":2}}
{"actor":{"display_login":"soupault"}}