{"action":"created","issue":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/689","repository_url":"https://api.github.com/repos/rpherbig/dr-scripts","labels_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/689/labels{/name}","comments_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/689/comments","events_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/689/events","html_url":"https://github.com/rpherbig/dr-scripts/pull/689","id":173893919,"number":689,"title":"Cyclic Spells During Research","user":{"login":"drboldwin","id":20247624,"avatar_url":"https://avatars.githubusercontent.com/u/20247624?v=3","gravatar_id":"","url":"https://api.github.com/users/drboldwin","html_url":"https://github.com/drboldwin","followers_url":"https://api.github.com/users/drboldwin/followers","following_url":"https://api.github.com/users/drboldwin/following{/other_user}","gists_url":"https://api.github.com/users/drboldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/drboldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drboldwin/subscriptions","organizations_url":"https://api.github.com/users/drboldwin/orgs","repos_url":"https://api.github.com/users/drboldwin/repos","events_url":"https://api.github.com/users/drboldwin/events{/privacy}","received_events_url":"https://api.github.com/users/drboldwin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rpherbig/dr-scripts/labels/crossing-training","name":"crossing-training","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/milestones/6","html_url":"https://github.com/rpherbig/dr-scripts/milestones/v7","labels_url":"https://api.github.com/repos/rpherbig/dr-scripts/milestones/6/labels","id":1794395,"number":6,"title":"v7","description":"","creator":{"login":"rpherbig","id":1181607,"avatar_url":"https://avatars.githubusercontent.com/u/1181607?v=3","gravatar_id":"","url":"https://api.github.com/users/rpherbig","html_url":"https://github.com/rpherbig","followers_url":"https://api.github.com/users/rpherbig/followers","following_url":"https://api.github.com/users/rpherbig/following{/other_user}","gists_url":"https://api.github.com/users/rpherbig/gists{/gist_id}","starred_url":"https://api.github.com/users/rpherbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpherbig/subscriptions","organizations_url":"https://api.github.com/users/rpherbig/orgs","repos_url":"https://api.github.com/users/rpherbig/repos","events_url":"https://api.github.com/users/rpherbig/events{/privacy}","received_events_url":"https://api.github.com/users/rpherbig/received_events","type":"User","site_admin":false},"open_issues":98,"closed_issues":81,"state":"open","created_at":"2016-05-29T11:36:30Z","updated_at":"2016-08-30T17:15:13Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-08-29T23:08:35Z","updated_at":"2016-08-30T19:31:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/pulls/689","html_url":"https://github.com/rpherbig/dr-scripts/pull/689","diff_url":"https://github.com/rpherbig/dr-scripts/pull/689.diff","patch_url":"https://github.com/rpherbig/dr-scripts/pull/689.patch"},"body":"Also a small update to Training_manager to handle releasing cyclic spells during transitions from crossing_training to hunting_buddy"},"comment":{"url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/comments/243552647","html_url":"https://github.com/rpherbig/dr-scripts/pull/689#issuecomment-243552647","issue_url":"https://api.github.com/repos/rpherbig/dr-scripts/issues/689","id":243552647,"user":{"login":"drboldwin","id":20247624,"avatar_url":"https://avatars.githubusercontent.com/u/20247624?v=3","gravatar_id":"","url":"https://api.github.com/users/drboldwin","html_url":"https://github.com/drboldwin","followers_url":"https://api.github.com/users/drboldwin/followers","following_url":"https://api.github.com/users/drboldwin/following{/other_user}","gists_url":"https://api.github.com/users/drboldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/drboldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drboldwin/subscriptions","organizations_url":"https://api.github.com/users/drboldwin/orgs","repos_url":"https://api.github.com/users/drboldwin/repos","events_url":"https://api.github.com/users/drboldwin/events{/privacy}","received_events_url":"https://api.github.com/users/drboldwin/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T19:31:11Z","updated_at":"2016-08-30T19:31:11Z","body":"Some of these will be addressed when we finish up the Universal Cyclic Release as seen here:\r\n\r\nhttps://github.com/rpherbig/dr-scripts/issues/674\r\n\r\nIt will take care of the defining of cyclics in training-manager.lic as well as the hardcoded aspect in crossing-training.lic and should be pushed before this is so that we can adjust accordingly.\r\n\r\n> This appears to work for non-cyclic spells too. Is that intentional? If so, should any of the naming change?\r\n\r\nIt does though it was not my intent.  I guess I just didn't account for non-cyclic since the only spells listed under research_training_spells should be cyclic spells anyways.  I was unsure of how to go about first picking the lower ability and then determining if it was cyclic and then going back and picking a different ability if it wasn't.  If this logic is put in then we could avoid listing the spells separately completely and base it off of training_spells as you had previously mentioned.\r\n\r\n> This appears to be a list of skills, and I feel 'crossing' is not communicating any information. I recommend naming it cyclic_research_skills.\r\n\r\nAgreed here - crossing has no actual bearing to it - I was simply copying the structure used for listing skills to train in crossing which was crossing_training so I called it crossing_cyclic_research_spells.  With the expanding of hometowns and whatnot this seems even more unnecessary. "}}
{"actor":{"display_login":"drboldwin"}}