{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1220","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1220/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1220/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1220/events","html_url":"https://github.com/greenplum-db/gpdb/pull/1220","id":183767837,"number":1220,"title":"Preventing gpstart if there is an unknown configuration parameter in postgresql.conf.","user":{"login":"foyzur","id":1253020,"avatar_url":"https://avatars.githubusercontent.com/u/1253020?v=3","gravatar_id":"","url":"https://api.github.com/users/foyzur","html_url":"https://github.com/foyzur","followers_url":"https://api.github.com/users/foyzur/followers","following_url":"https://api.github.com/users/foyzur/following{/other_user}","gists_url":"https://api.github.com/users/foyzur/gists{/gist_id}","starred_url":"https://api.github.com/users/foyzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foyzur/subscriptions","organizations_url":"https://api.github.com/users/foyzur/orgs","repos_url":"https://api.github.com/users/foyzur/repos","events_url":"https://api.github.com/users/foyzur/events{/privacy}","received_events_url":"https://api.github.com/users/foyzur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-18T18:34:41Z","updated_at":"2016-10-20T08:48:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1220","html_url":"https://github.com/greenplum-db/gpdb/pull/1220","diff_url":"https://github.com/greenplum-db/gpdb/pull/1220.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1220.patch"},"body":"If there is an unknown configuration parameter in postgresql.conf,\r\ncurrently we silently print a log message and skip reading any\r\nconfiguration parameter from postgresql.conf. This does not prevent\r\ndatabase startup. As some of our gucs depend on explicitly mentioned\r\nvalues on certain platforms (e.g., gp_vmem_protect_limit is set to 8GB\r\nexplicitly in postgresql.conf, and without explicit mention, it defaults\r\nto 0 on darwin platforms), this can result in assertion failure and\r\nconfusing dtm errors as QEs fail to start with 0 vmem protect limit (and\r\npotentially other invalid guc values).\r\n\r\nThis change prevent database startup if there is any unknown\r\nconfiguration parameter.\r\n\r\nThis is relevant to Github issue #1201. However, for issue #1201 we will\r\nneed another fix to correct bugbuster test so that it doesn't put\r\nunrecognized parameter in the postgresql.conf."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/255046706","html_url":"https://github.com/greenplum-db/gpdb/pull/1220#issuecomment-255046706","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1220","id":255046706,"user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T08:48:58Z","updated_at":"2016-10-20T08:48:58Z","body":"+1 on moving to the code from upstream 8.3, failing on incorrect GUC makes perfect sense and it will make further merging with upstream easier."}}
{"actor":{"display_login":"danielgustafsson"}}