{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/78584787","id":78584787,"diff_hunk":"@@ -58,14 +59,28 @@ func (d *Dispatcher) Upgrade(vch *vm.VirtualMachine, conf *config.VirtualContain\n \t\treturn err\n \t}\n \td.session.Datastore = ds\n+\tif !conf.HostCertificate.IsNil() {\n+\t\td.VICAdminProto = \"https\"\n+\t\td.DockerPort = fmt.Sprintf(\"%d\", opts.DefaultTLSHTTPPort)\n+\t} else {\n+\t\td.VICAdminProto = \"http\"\n+\t\td.DockerPort = fmt.Sprintf(\"%d\", opts.DefaultHTTPPort)\n+\t}\n+\n+\tif err = d.uploadImages(settings.ImageFiles); err != nil {\n+\t\treturn errors.Errorf(\"Uploading images failed with %s. Exiting...\", err)\n+\t}\n+\tconf.BootstrapImagePath = fmt.Sprintf(\"[%s] %s/%s\", conf.ImageStores[0].Host, d.vmPathName, settings.BootstrapISO)\n \n \tsnapshotName := fmt.Sprintf(\"upgrade for %s\", conf.Version.BuildNumber)","path":"lib/install/management/upgrade.go","position":25,"original_position":25,"commit_id":"7da4ac10d0afa02fd8221465eff7b54649aaf9a9","original_commit_id":"7da4ac10d0afa02fd8221465eff7b54649aaf9a9","user":{"login":"andrewtchin","id":1649165,"avatar_url":"https://avatars.githubusercontent.com/u/1649165?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtchin","html_url":"https://github.com/andrewtchin","followers_url":"https://api.github.com/users/andrewtchin/followers","following_url":"https://api.github.com/users/andrewtchin/following{/other_user}","gists_url":"https://api.github.com/users/andrewtchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtchin/subscriptions","organizations_url":"https://api.github.com/users/andrewtchin/orgs","repos_url":"https://api.github.com/users/andrewtchin/repos","events_url":"https://api.github.com/users/andrewtchin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtchin/received_events","type":"User","site_admin":false},"body":"can this use the const?","created_at":"2016-09-13T15:35:14Z","updated_at":"2016-09-13T15:35:14Z","html_url":"https://github.com/vmware/vic/pull/2301#discussion_r78584787","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2301","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/78584787"},"html":{"href":"https://github.com/vmware/vic/pull/2301#discussion_r78584787"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2301"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2301","id":84936355,"html_url":"https://github.com/vmware/vic/pull/2301","diff_url":"https://github.com/vmware/vic/pull/2301.diff","patch_url":"https://github.com/vmware/vic/pull/2301.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2301","number":2301,"state":"open","locked":false,"title":"Upgrade configuration","user":{"login":"emlin","id":1091772,"avatar_url":"https://avatars.githubusercontent.com/u/1091772?v=3","gravatar_id":"","url":"https://api.github.com/users/emlin","html_url":"https://github.com/emlin","followers_url":"https://api.github.com/users/emlin/followers","following_url":"https://api.github.com/users/emlin/following{/other_user}","gists_url":"https://api.github.com/users/emlin/gists{/gist_id}","starred_url":"https://api.github.com/users/emlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlin/subscriptions","organizations_url":"https://api.github.com/users/emlin/orgs","repos_url":"https://api.github.com/users/emlin/repos","events_url":"https://api.github.com/users/emlin/events{/privacy}","received_events_url":"https://api.github.com/users/emlin/received_events","type":"User","site_admin":false},"body":"Fixes #2172 \r\n\r\nCheck required options are there, and change configuration version.\r\n\r\nIn the meanwhile, update upgrade process to align with design doc changes.","created_at":"2016-09-12T20:13:06Z","updated_at":"2016-09-13T15:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7cea1e650f00769a6ee00242a5c5b742b3eed91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2301/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2301/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2301/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/7da4ac10d0afa02fd8221465eff7b54649aaf9a9","head":{"label":"emlin:2172","ref":"2172","sha":"7da4ac10d0afa02fd8221465eff7b54649aaf9a9","user":{"login":"emlin","id":1091772,"avatar_url":"https://avatars.githubusercontent.com/u/1091772?v=3","gravatar_id":"","url":"https://api.github.com/users/emlin","html_url":"https://github.com/emlin","followers_url":"https://api.github.com/users/emlin/followers","following_url":"https://api.github.com/users/emlin/following{/other_user}","gists_url":"https://api.github.com/users/emlin/gists{/gist_id}","starred_url":"https://api.github.com/users/emlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlin/subscriptions","organizations_url":"https://api.github.com/users/emlin/orgs","repos_url":"https://api.github.com/users/emlin/repos","events_url":"https://api.github.com/users/emlin/events{/privacy}","received_events_url":"https://api.github.com/users/emlin/received_events","type":"User","site_admin":false},"repo":{"id":55440951,"name":"vic","full_name":"emlin/vic","owner":{"login":"emlin","id":1091772,"avatar_url":"https://avatars.githubusercontent.com/u/1091772?v=3","gravatar_id":"","url":"https://api.github.com/users/emlin","html_url":"https://github.com/emlin","followers_url":"https://api.github.com/users/emlin/followers","following_url":"https://api.github.com/users/emlin/following{/other_user}","gists_url":"https://api.github.com/users/emlin/gists{/gist_id}","starred_url":"https://api.github.com/users/emlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlin/subscriptions","organizations_url":"https://api.github.com/users/emlin/orgs","repos_url":"https://api.github.com/users/emlin/repos","events_url":"https://api.github.com/users/emlin/events{/privacy}","received_events_url":"https://api.github.com/users/emlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emlin/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/emlin/vic","forks_url":"https://api.github.com/repos/emlin/vic/forks","keys_url":"https://api.github.com/repos/emlin/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emlin/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emlin/vic/teams","hooks_url":"https://api.github.com/repos/emlin/vic/hooks","issue_events_url":"https://api.github.com/repos/emlin/vic/issues/events{/number}","events_url":"https://api.github.com/repos/emlin/vic/events","assignees_url":"https://api.github.com/repos/emlin/vic/assignees{/user}","branches_url":"https://api.github.com/repos/emlin/vic/branches{/branch}","tags_url":"https://api.github.com/repos/emlin/vic/tags","blobs_url":"https://api.github.com/repos/emlin/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emlin/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emlin/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/emlin/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emlin/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/emlin/vic/languages","stargazers_url":"https://api.github.com/repos/emlin/vic/stargazers","contributors_url":"https://api.github.com/repos/emlin/vic/contributors","subscribers_url":"https://api.github.com/repos/emlin/vic/subscribers","subscription_url":"https://api.github.com/repos/emlin/vic/subscription","commits_url":"https://api.github.com/repos/emlin/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/emlin/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/emlin/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/emlin/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/emlin/vic/contents/{+path}","compare_url":"https://api.github.com/repos/emlin/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emlin/vic/merges","archive_url":"https://api.github.com/repos/emlin/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emlin/vic/downloads","issues_url":"https://api.github.com/repos/emlin/vic/issues{/number}","pulls_url":"https://api.github.com/repos/emlin/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/emlin/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/emlin/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emlin/vic/labels{/name}","releases_url":"https://api.github.com/repos/emlin/vic/releases{/id}","deployments_url":"https://api.github.com/repos/emlin/vic/deployments","created_at":"2016-04-04T20:04:54Z","updated_at":"2016-04-04T20:04:55Z","pushed_at":"2016-09-12T20:28:47Z","git_url":"git://github.com/emlin/vic.git","ssh_url":"git@github.com:emlin/vic.git","clone_url":"https://github.com/emlin/vic.git","svn_url":"https://github.com/emlin/vic","homepage":null,"size":34873,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"c689df9d822b9ff612914b40676f48d94d28ca44","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-09-13T11:55:50Z","pushed_at":"2016-09-12T22:01:05Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":79461,"stargazers_count":131,"watchers_count":131,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":499,"forks":47,"open_issues":499,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2301"},"html":{"href":"https://github.com/vmware/vic/pull/2301"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2301"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2301/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2301/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2301/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/7da4ac10d0afa02fd8221465eff7b54649aaf9a9"}}}}
{"actor":{"display_login":"andrewtchin"}}