{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/64995102","id":64995102,"diff_hunk":"@@ -22,3 +22,9 @@ The `AdminExtension` class is deprecated. Use `AbstractAdminExtension` instead.\n \n The Twig extension method that fallback to a default template when the specified one does not exist.\n You can no longer rely on that and should always specify templates that exist.\n+\n+## Deprecated AbstractAdmin methods\n+- `buildBreacrumbs` is deprecated, and no replacement is given, it will become an internal method.\n+- `getBreadcrumbs` is deprecated in favor of the homonym method of the `sonata.admin.breadcrumbs_builder` service.","path":"UPGRADE-3.x.md","position":7,"original_position":7,"commit_id":"7472f5f34ecbf3667c02e547dd55739a6112bcb8","original_commit_id":"7472f5f34ecbf3667c02e547dd55739a6112bcb8","user":{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false},"body":"is `homonym` correct? never heard it 😄 ","created_at":"2016-05-28T22:27:34Z","updated_at":"2016-05-28T22:27:34Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3872#discussion_r64995102","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/64995102"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3872#discussion_r64995102"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872","id":71295035,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3872","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3872.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3872.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3872","number":3872,"state":"open","locked":false,"title":"Use breadcrumbs builder directly","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"See #3833 \r\n\r\n### Changelog\r\n\r\n```markdown\r\n### Deprecated\r\n- `AbstractAdmin::getBreadcrumbs`, in favor of `BreadcrumbsBuilder::getBreadcrumbs`\r\n- `AbstractAdmin::buildBreadcrumbs`, will be removed\r\n- `AbstractAdmin::$breadcrumbs`, will be removed\r\n```\r\n\r\n### Subject\r\n\r\nThe ultimate goal of this PR is to remove everything breadcrumbs-related from the `AbstractAdmin` class\r\n\r\n### To do\r\n\r\n- [x] Deprecate the `buildBreadcrumbs` and `getBreadcrumbs` methods of `AbstractAdmin`, make sure they aren't use anymore in templates, or by the breadcrumbs builder\r\n- [x] Deprecate `breadcrumbsBuilder` accessors of `AbstractAdmin`. Create a service for the breadcrumbs builder and use that instead\r\n- [x] Refactor AdminExtractor so that it still finds missing translations for the breadcrumbs\r\n","created_at":"2016-05-24T21:21:47Z","updated_at":"2016-05-28T22:27:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59866da6ca2e16074e235dc2d45d012b7c5d19f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3872/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/7472f5f34ecbf3667c02e547dd55739a6112bcb8","head":{"label":"greg0ire:use_breadcrumbs_builder_directly","ref":"use_breadcrumbs_builder_directly","sha":"7472f5f34ecbf3667c02e547dd55739a6112bcb8","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"repo":{"id":19613045,"name":"SonataAdminBundle","full_name":"greg0ire/SonataAdminBundle","owner":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greg0ire/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/greg0ire/SonataAdminBundle","forks_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/greg0ire/SonataAdminBundle/deployments","created_at":"2014-05-09T14:02:34Z","updated_at":"2014-06-09T11:24:36Z","pushed_at":"2016-05-27T21:10:51Z","git_url":"git://github.com/greg0ire/SonataAdminBundle.git","ssh_url":"git@github.com:greg0ire/SonataAdminBundle.git","clone_url":"https://github.com/greg0ire/SonataAdminBundle.git","svn_url":"https://github.com/greg0ire/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":18104,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"36faf7c6d092fc3fdb803cdc124729538a1243a6","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-05-24T08:38:14Z","pushed_at":"2016-05-28T17:21:58Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":22551,"stargazers_count":1381,"watchers_count":1381,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":984,"mirror_url":null,"open_issues_count":371,"forks":984,"open_issues":371,"watchers":1381,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3872"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3872"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3872/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3872/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/7472f5f34ecbf3667c02e547dd55739a6112bcb8"}}}}
{"actor":{"display_login":"OskarStark"}}