{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/comments/92807851","pull_request_review_id":13329499,"id":92807851,"diff_hunk":"@@ -636,12 +636,43 @@ impl Node {\n             (ExpectCloseNode { expect_id, client_auth, message_id }, Section(_), Section(_)) => {\n                 self.handle_expect_close_node_request(expect_id, client_auth, message_id)\n             }\n-            (ConnectionInfo(conn_info), src @ Client { .. }, dst @ ManagedNode(_)) => {\n-                self.handle_connection_info_from_client(conn_info, src, dst)\n-            }\n-            (ConnectionInfo(conn_info), ManagedNode(src_name), dst @ Client { .. }) |\n-            (ConnectionInfo(conn_info), ManagedNode(src_name), dst @ ManagedNode(_)) => {\n-                self.handle_connection_info_from_node(conn_info, src_name, dst)\n+            (ConnectionInfoRequest { encrypted_connection_info,\n+                                     nonce_bytes,\n+                                     public_id,\n+                                     message_id },\n+             src @ Client { .. },\n+             dst @ ManagedNode(_)) |\n+            (ConnectionInfoRequest { encrypted_connection_info,\n+                                     nonce_bytes,\n+                                     public_id,\n+                                     message_id },\n+             src @ ManagedNode(_),\n+             dst @ ManagedNode(_)) => {\n+                self.handle_connection_info_request(encrypted_connection_info,\n+                                                    nonce_bytes,\n+                                                    public_id,\n+                                                    message_id,\n+                                                    src,\n+                                                    dst)\n+            }\n+            (ConnectionInfoResponse { encrypted_connection_info,\n+                                      nonce_bytes,\n+                                      public_id,\n+                                      message_id },\n+             ManagedNode(src_name),\n+             dst @ Client { .. }) |\n+            (ConnectionInfoResponse { encrypted_connection_info,\n+                                      nonce_bytes,\n+                                      public_id,\n+                                      message_id },\n+             ManagedNode(src_name),\n+             dst @ ManagedNode(_)) => {\n+                self.handle_connection_info_response(encrypted_connection_info,\n+                                                     nonce_bytes,\n+                                                     public_id,\n+                                                     message_id,\n+                                                     src_name,\n+                                                     dst)","path":"src/states/node.rs","position":57,"original_position":57,"commit_id":"731ad3761745965d96368e94beb261c7ecdbc717","original_commit_id":"731ad3761745965d96368e94beb261c7ecdbc717","user":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"body":"Not important, but I wonder whether with names like `enc_conn_info`, `pub_id`, `msg_id` and `nonce` we could save some vertical space here and make this a bit easier on the eye.","created_at":"2016-12-16T13:03:02Z","updated_at":"2016-12-16T13:03:02Z","html_url":"https://github.com/maidsafe/routing/pull/1278#discussion_r92807851","pull_request_url":"https://api.github.com/repos/maidsafe/routing/pulls/1278","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments/92807851"},"html":{"href":"https://github.com/maidsafe/routing/pull/1278#discussion_r92807851"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1278"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1278","id":98321125,"html_url":"https://github.com/maidsafe/routing/pull/1278","diff_url":"https://github.com/maidsafe/routing/pull/1278.diff","patch_url":"https://github.com/maidsafe/routing/pull/1278.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1278","number":1278,"state":"open","locked":false,"title":"MAID-1876: Changed connection info flow into request and response","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-16T11:41:42Z","updated_at":"2016-12-16T13:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"830c47e54565c4deddeeb22d8c0f8a622c299575","assignee":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"assignees":[{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/1278/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/1278/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1278/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/731ad3761745965d96368e94beb261c7ecdbc717","head":{"label":"Fraser999:MAID-1876","ref":"MAID-1876","sha":"731ad3761745965d96368e94beb261c7ecdbc717","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"repo":{"id":32315702,"name":"routing","full_name":"Fraser999/routing","owner":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fraser999/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/Fraser999/routing","forks_url":"https://api.github.com/repos/Fraser999/routing/forks","keys_url":"https://api.github.com/repos/Fraser999/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fraser999/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fraser999/routing/teams","hooks_url":"https://api.github.com/repos/Fraser999/routing/hooks","issue_events_url":"https://api.github.com/repos/Fraser999/routing/issues/events{/number}","events_url":"https://api.github.com/repos/Fraser999/routing/events","assignees_url":"https://api.github.com/repos/Fraser999/routing/assignees{/user}","branches_url":"https://api.github.com/repos/Fraser999/routing/branches{/branch}","tags_url":"https://api.github.com/repos/Fraser999/routing/tags","blobs_url":"https://api.github.com/repos/Fraser999/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fraser999/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fraser999/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fraser999/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fraser999/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/Fraser999/routing/languages","stargazers_url":"https://api.github.com/repos/Fraser999/routing/stargazers","contributors_url":"https://api.github.com/repos/Fraser999/routing/contributors","subscribers_url":"https://api.github.com/repos/Fraser999/routing/subscribers","subscription_url":"https://api.github.com/repos/Fraser999/routing/subscription","commits_url":"https://api.github.com/repos/Fraser999/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fraser999/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fraser999/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fraser999/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fraser999/routing/contents/{+path}","compare_url":"https://api.github.com/repos/Fraser999/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fraser999/routing/merges","archive_url":"https://api.github.com/repos/Fraser999/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fraser999/routing/downloads","issues_url":"https://api.github.com/repos/Fraser999/routing/issues{/number}","pulls_url":"https://api.github.com/repos/Fraser999/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/Fraser999/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/Fraser999/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fraser999/routing/labels{/name}","releases_url":"https://api.github.com/repos/Fraser999/routing/releases{/id}","deployments_url":"https://api.github.com/repos/Fraser999/routing/deployments","created_at":"2015-03-16T09:53:56Z","updated_at":"2016-01-11T11:52:43Z","pushed_at":"2016-12-16T11:41:54Z","git_url":"git://github.com/Fraser999/routing.git","ssh_url":"git@github.com:Fraser999/routing.git","clone_url":"https://github.com/Fraser999/routing.git","svn_url":"https://github.com/Fraser999/routing","homepage":null,"size":8542,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"e8713e6cf65e71ece4af003da3148ee360318b54","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/routing/deployments","created_at":"2015-02-24T16:52:53Z","updated_at":"2016-12-12T21:15:22Z","pushed_at":"2016-12-16T12:57:43Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":108710,"stargazers_count":109,"watchers_count":109,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":11,"forks":40,"open_issues":11,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1278"},"html":{"href":"https://github.com/maidsafe/routing/pull/1278"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1278"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1278/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1278/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1278/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/731ad3761745965d96368e94beb261c7ecdbc717"}}}}
{"actor":{"display_login":"afck"}}