{"action":"closed","number":1413,"pull_request":{"url":"https://api.github.com/repos/eclipse/vert.x/pulls/1413","id":69265136,"html_url":"https://github.com/eclipse/vert.x/pull/1413","diff_url":"https://github.com/eclipse/vert.x/pull/1413.diff","patch_url":"https://github.com/eclipse/vert.x/pull/1413.patch","issue_url":"https://api.github.com/repos/eclipse/vert.x/issues/1413","number":1413,"state":"closed","locked":false,"title":"Issues/#1361 add another unit test","user":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"body":"Issues/#1361 add another unit test:\r\n\r\nThe unit test previously tested if localhost is resolved or not (which shows the issue we had), however I prefer to have a test where the dns resolution really fails it is being done.\r\nThe unit test is quite simple, the one general thing I had to change in the TLS test implementation is to support clientVerifyHost(false).\r\n","created_at":"2016-05-08T09:52:09Z","updated_at":"2016-05-09T19:46:09Z","closed_at":"2016-05-09T19:46:08Z","merged_at":"2016-05-09T19:46:08Z","merge_commit_sha":"62289e09b3c4516d183dec5706a5ac390711d3a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/vert.x/pulls/1413/commits","review_comments_url":"https://api.github.com/repos/eclipse/vert.x/pulls/1413/comments","review_comment_url":"https://api.github.com/repos/eclipse/vert.x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/vert.x/issues/1413/comments","statuses_url":"https://api.github.com/repos/eclipse/vert.x/statuses/0f8fc13602cc3cc6098b74474c4cc7c8031211be","head":{"label":"alexlehm:issues/#1361-add_unit_test","ref":"issues/#1361-add_unit_test","sha":"0f8fc13602cc3cc6098b74474c4cc7c8031211be","user":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"repo":{"id":18156124,"name":"vert.x","full_name":"alexlehm/vert.x","owner":{"login":"alexlehm","id":156144,"avatar_url":"https://avatars.githubusercontent.com/u/156144?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlehm","html_url":"https://github.com/alexlehm","followers_url":"https://api.github.com/users/alexlehm/followers","following_url":"https://api.github.com/users/alexlehm/following{/other_user}","gists_url":"https://api.github.com/users/alexlehm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlehm/subscriptions","organizations_url":"https://api.github.com/users/alexlehm/orgs","repos_url":"https://api.github.com/users/alexlehm/repos","events_url":"https://api.github.com/users/alexlehm/events{/privacy}","received_events_url":"https://api.github.com/users/alexlehm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexlehm/vert.x","description":"vert.x - The scalable polyglot application platform for the JVM","fork":true,"url":"https://api.github.com/repos/alexlehm/vert.x","forks_url":"https://api.github.com/repos/alexlehm/vert.x/forks","keys_url":"https://api.github.com/repos/alexlehm/vert.x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexlehm/vert.x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexlehm/vert.x/teams","hooks_url":"https://api.github.com/repos/alexlehm/vert.x/hooks","issue_events_url":"https://api.github.com/repos/alexlehm/vert.x/issues/events{/number}","events_url":"https://api.github.com/repos/alexlehm/vert.x/events","assignees_url":"https://api.github.com/repos/alexlehm/vert.x/assignees{/user}","branches_url":"https://api.github.com/repos/alexlehm/vert.x/branches{/branch}","tags_url":"https://api.github.com/repos/alexlehm/vert.x/tags","blobs_url":"https://api.github.com/repos/alexlehm/vert.x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexlehm/vert.x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexlehm/vert.x/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexlehm/vert.x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexlehm/vert.x/statuses/{sha}","languages_url":"https://api.github.com/repos/alexlehm/vert.x/languages","stargazers_url":"https://api.github.com/repos/alexlehm/vert.x/stargazers","contributors_url":"https://api.github.com/repos/alexlehm/vert.x/contributors","subscribers_url":"https://api.github.com/repos/alexlehm/vert.x/subscribers","subscription_url":"https://api.github.com/repos/alexlehm/vert.x/subscription","commits_url":"https://api.github.com/repos/alexlehm/vert.x/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexlehm/vert.x/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexlehm/vert.x/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexlehm/vert.x/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexlehm/vert.x/contents/{+path}","compare_url":"https://api.github.com/repos/alexlehm/vert.x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexlehm/vert.x/merges","archive_url":"https://api.github.com/repos/alexlehm/vert.x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexlehm/vert.x/downloads","issues_url":"https://api.github.com/repos/alexlehm/vert.x/issues{/number}","pulls_url":"https://api.github.com/repos/alexlehm/vert.x/pulls{/number}","milestones_url":"https://api.github.com/repos/alexlehm/vert.x/milestones{/number}","notifications_url":"https://api.github.com/repos/alexlehm/vert.x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexlehm/vert.x/labels{/name}","releases_url":"https://api.github.com/repos/alexlehm/vert.x/releases{/id}","deployments_url":"https://api.github.com/repos/alexlehm/vert.x/deployments","created_at":"2014-03-26T22:24:48Z","updated_at":"2016-04-17T15:56:48Z","pushed_at":"2016-05-08T10:29:35Z","git_url":"git://github.com/alexlehm/vert.x.git","ssh_url":"git@github.com:alexlehm/vert.x.git","clone_url":"https://github.com/alexlehm/vert.x.git","svn_url":"https://github.com/alexlehm/vert.x","homepage":"http://vertx.io","size":94833,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"28ae4ddf8ff713884e522acfbb9e0787d0ffb9c2","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":1911523,"name":"vert.x","full_name":"eclipse/vert.x","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/vert.x","description":"Vert.x is a tool-kit for building reactive applications on the JVM","fork":false,"url":"https://api.github.com/repos/eclipse/vert.x","forks_url":"https://api.github.com/repos/eclipse/vert.x/forks","keys_url":"https://api.github.com/repos/eclipse/vert.x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/vert.x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/vert.x/teams","hooks_url":"https://api.github.com/repos/eclipse/vert.x/hooks","issue_events_url":"https://api.github.com/repos/eclipse/vert.x/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/vert.x/events","assignees_url":"https://api.github.com/repos/eclipse/vert.x/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/vert.x/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/vert.x/tags","blobs_url":"https://api.github.com/repos/eclipse/vert.x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/vert.x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/vert.x/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/vert.x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/vert.x/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/vert.x/languages","stargazers_url":"https://api.github.com/repos/eclipse/vert.x/stargazers","contributors_url":"https://api.github.com/repos/eclipse/vert.x/contributors","subscribers_url":"https://api.github.com/repos/eclipse/vert.x/subscribers","subscription_url":"https://api.github.com/repos/eclipse/vert.x/subscription","commits_url":"https://api.github.com/repos/eclipse/vert.x/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/vert.x/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/vert.x/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/vert.x/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/vert.x/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/vert.x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/vert.x/merges","archive_url":"https://api.github.com/repos/eclipse/vert.x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/vert.x/downloads","issues_url":"https://api.github.com/repos/eclipse/vert.x/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/vert.x/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/vert.x/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/vert.x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/vert.x/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/vert.x/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/vert.x/deployments","created_at":"2011-06-17T14:54:55Z","updated_at":"2016-05-09T13:38:20Z","pushed_at":"2016-05-09T19:46:09Z","git_url":"git://github.com/eclipse/vert.x.git","ssh_url":"git@github.com:eclipse/vert.x.git","clone_url":"https://github.com/eclipse/vert.x.git","svn_url":"https://github.com/eclipse/vert.x","homepage":"http://vertx.io","size":365555,"stargazers_count":4755,"watchers_count":4755,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":928,"mirror_url":null,"open_issues_count":79,"forks":928,"open_issues":79,"watchers":4755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1413"},"html":{"href":"https://github.com/eclipse/vert.x/pull/1413"},"issue":{"href":"https://api.github.com/repos/eclipse/vert.x/issues/1413"},"comments":{"href":"https://api.github.com/repos/eclipse/vert.x/issues/1413/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1413/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1413/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/vert.x/statuses/0f8fc13602cc3cc6098b74474c4cc7c8031211be"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vietj","id":225674,"avatar_url":"https://avatars.githubusercontent.com/u/225674?v=3","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":49,"deletions":12,"changed_files":5}}