{"action":"created","issue":{"url":"https://api.github.com/repos/PBGUX/bower-designsystem/issues/15","repository_url":"https://api.github.com/repos/PBGUX/bower-designsystem","labels_url":"https://api.github.com/repos/PBGUX/bower-designsystem/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/PBGUX/bower-designsystem/issues/15/comments","events_url":"https://api.github.com/repos/PBGUX/bower-designsystem/issues/15/events","html_url":"https://github.com/PBGUX/bower-designsystem/issues/15","id":196073844,"number":15,"title":"Gap after footer due to wrong padding","user":{"login":"azanov","id":927098,"avatar_url":"https://avatars.githubusercontent.com/u/927098?v=3","gravatar_id":"","url":"https://api.github.com/users/azanov","html_url":"https://github.com/azanov","followers_url":"https://api.github.com/users/azanov/followers","following_url":"https://api.github.com/users/azanov/following{/other_user}","gists_url":"https://api.github.com/users/azanov/gists{/gist_id}","starred_url":"https://api.github.com/users/azanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azanov/subscriptions","organizations_url":"https://api.github.com/users/azanov/orgs","repos_url":"https://api.github.com/users/azanov/repos","events_url":"https://api.github.com/users/azanov/events{/privacy}","received_events_url":"https://api.github.com/users/azanov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-16T14:40:55Z","updated_at":"2016-12-16T18:01:56Z","closed_at":null,"body":"In v3.1, there's a gap after the footer:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/927098/21266081/c99a785a-c3a4-11e6-9e3e-8122d535c6ba.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/927098/21266098/d6c21416-c3a4-11e6-82ec-e513fc299d20.png)\r\n\r\nThis happens because of wrong padding set on the footer tag:\r\n\r\n```\r\nfooter {\r\n  ...\r\n  padding: 7px 0;\r\n  ...\r\n}\r\n```\r\n\r\nYou can fix it by setting the footer padding to `0` and updating the `padding-top` on `footer .container > div` to `18px` (just an approx. value which looks well):\r\n\r\n```\r\nfooter {\r\n  ...\r\n  padding: 0;\r\n\r\n  ...\r\n\r\n  .container, .container-fluid {\r\n\r\n     ...\r\n     > div {\r\n       padding: 18px 20px 16px 0; // 76px high, DS 3\r\n     }\r\n     ...\r\n\r\n  }\r\n}\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/PBGUX/bower-designsystem/issues/comments/267656888","html_url":"https://github.com/PBGUX/bower-designsystem/issues/15#issuecomment-267656888","issue_url":"https://api.github.com/repos/PBGUX/bower-designsystem/issues/15","id":267656888,"user":{"login":"smlombardi","id":835148,"avatar_url":"https://avatars.githubusercontent.com/u/835148?v=3","gravatar_id":"","url":"https://api.github.com/users/smlombardi","html_url":"https://github.com/smlombardi","followers_url":"https://api.github.com/users/smlombardi/followers","following_url":"https://api.github.com/users/smlombardi/following{/other_user}","gists_url":"https://api.github.com/users/smlombardi/gists{/gist_id}","starred_url":"https://api.github.com/users/smlombardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlombardi/subscriptions","organizations_url":"https://api.github.com/users/smlombardi/orgs","repos_url":"https://api.github.com/users/smlombardi/repos","events_url":"https://api.github.com/users/smlombardi/events{/privacy}","received_events_url":"https://api.github.com/users/smlombardi/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T18:01:56Z","updated_at":"2016-12-16T18:01:56Z","body":"I do not see this, on any Mac browser nor on IE11 or IE Edge on Windows 10.\r\n\r\n![screen shot 2016-12-16 at 1 00 50 pm](https://cloud.githubusercontent.com/assets/835148/21273054/d12940ac-c38f-11e6-812a-d6f7aab239bd.png)\r\n"}}
{"actor":{"display_login":"smlombardi"}}