{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37604","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37604/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37604/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37604/events","html_url":"https://github.com/kubernetes/kubernetes/pull/37604","id":192185216,"number":37604,"title":"make drain retry forever and use a new graceful period","user":{"login":"ymqytw","id":2589105,"avatar_url":"https://avatars.githubusercontent.com/u/2589105?v=3","gravatar_id":"","url":"https://api.github.com/users/ymqytw","html_url":"https://github.com/ymqytw","followers_url":"https://api.github.com/users/ymqytw/followers","following_url":"https://api.github.com/users/ymqytw/following{/other_user}","gists_url":"https://api.github.com/users/ymqytw/gists{/gist_id}","starred_url":"https://api.github.com/users/ymqytw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymqytw/subscriptions","organizations_url":"https://api.github.com/users/ymqytw/orgs","repos_url":"https://api.github.com/users/ymqytw/repos","events_url":"https://api.github.com/users/ymqytw/events{/privacy}","received_events_url":"https://api.github.com/users/ymqytw/received_events","type":"User","site_admin":false},"labels":[{"id":242155350,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cherrypick-candidate","name":"cherrypick-candidate","color":"fef2c0","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":152,"closed_issues":866,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-11-29T23:11:15Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"comments":9,"created_at":"2016-11-29T04:28:22Z","updated_at":"2016-11-29T23:13:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37604","html_url":"https://github.com/kubernetes/kubernetes/pull/37604","diff_url":"https://github.com/kubernetes/kubernetes/pull/37604.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37604.patch"},"body":"Implemented the 1st approach according to https://github.com/kubernetes/kubernetes/issues/37460#issuecomment-263437516\r\n1) Make drain retry forever if the error is always Too Many Requests (429) generated by Pod Disruption Budget.\r\n2) Use a new graceful period per #37460\r\n3) Update the message printed out when successfully deleting or evicting a pod.\r\n\r\nfixes #37460\r\n\r\ncc: @davidopp @erictune\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/37604)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/263731012","html_url":"https://github.com/kubernetes/kubernetes/pull/37604#issuecomment-263731012","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37604","id":263731012,"user":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T23:13:42Z","updated_at":"2016-11-29T23:13:42Z","body":"LGTM\r\n"}}
{"actor":{"display_login":"davidopp"}}