{"action":"created","comment":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/comments/93832880","pull_request_review_id":14367433,"id":93832880,"diff_hunk":"@@ -38,3 +38,31 @@ fn two_threads() {\n fn many_threads() {\n     send_shared_oneshot_and_wait_on_multiple_threads(1000);\n }\n+\n+#[test]\n+fn drop_on_one_task_ok() {","path":"tests/shared.rs","position":18,"original_position":18,"commit_id":"6468b266c674d71d4209d985312522b57f7a0776","original_commit_id":"6468b266c674d71d4209d985312522b57f7a0776","user":{"login":"dwrensha","id":495768,"avatar_url":"https://avatars.githubusercontent.com/u/495768?v=3","gravatar_id":"","url":"https://api.github.com/users/dwrensha","html_url":"https://github.com/dwrensha","followers_url":"https://api.github.com/users/dwrensha/followers","following_url":"https://api.github.com/users/dwrensha/following{/other_user}","gists_url":"https://api.github.com/users/dwrensha/gists{/gist_id}","starred_url":"https://api.github.com/users/dwrensha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwrensha/subscriptions","organizations_url":"https://api.github.com/users/dwrensha/orgs","repos_url":"https://api.github.com/users/dwrensha/repos","events_url":"https://api.github.com/users/dwrensha/events{/privacy}","received_events_url":"https://api.github.com/users/dwrensha/received_events","type":"User","site_admin":false},"body":"This test case passes for me even *before* applying the rest of this commit, so I doubt that it is providing the coverage that we want.","created_at":"2016-12-25T19:11:02Z","updated_at":"2016-12-25T19:11:02Z","html_url":"https://github.com/alexcrichton/futures-rs/pull/305#discussion_r93832880","pull_request_url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/comments/93832880"},"html":{"href":"https://github.com/alexcrichton/futures-rs/pull/305#discussion_r93832880"},"pull_request":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305","id":99327738,"html_url":"https://github.com/alexcrichton/futures-rs/pull/305","diff_url":"https://github.com/alexcrichton/futures-rs/pull/305.diff","patch_url":"https://github.com/alexcrichton/futures-rs/pull/305.patch","issue_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/305","number":305,"state":"open","locked":false,"title":"Fix a race in Shared where it blocks forever","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"A `Shared` represents multiple handles to an original future, which can have\r\nmany tasks waiting on it. The original future, however, can only have at most\r\none task waiting on it. If a `Shared` handle is dropped which belongs to the\r\ntask that's blocking on the inner future, then once the inner future is done\r\nwe're not guaranteed to ever be able to wake up again.\r\n\r\nTo solve this case for now this commit adds a destructor to the `Shared` future\r\nwhich wakes up all waiting tasks on destruction. This has the downside of a\r\n\"thundering stampede\" problem but we can't be certain which task should be woken\r\nup, so we just wake up all of them.\r\n\r\nCloses #304","created_at":"2016-12-25T19:01:38Z","updated_at":"2016-12-25T19:11:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"983d84673d547018dcdc86e9c32c8723573f37d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305/commits","review_comments_url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305/comments","review_comment_url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/305/comments","statuses_url":"https://api.github.com/repos/alexcrichton/futures-rs/statuses/6468b266c674d71d4209d985312522b57f7a0776","head":{"label":"alexcrichton:fix-shared-block","ref":"fix-shared-block","sha":"6468b266c674d71d4209d985312522b57f7a0776","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":55077261,"name":"futures-rs","full_name":"alexcrichton/futures-rs","owner":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/futures-rs","description":"Zero-cost futures and streams in Rust","fork":false,"url":"https://api.github.com/repos/alexcrichton/futures-rs","forks_url":"https://api.github.com/repos/alexcrichton/futures-rs/forks","keys_url":"https://api.github.com/repos/alexcrichton/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/futures-rs/teams","hooks_url":"https://api.github.com/repos/alexcrichton/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/futures-rs/events","assignees_url":"https://api.github.com/repos/alexcrichton/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/futures-rs/tags","blobs_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/futures-rs/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/futures-rs/subscription","commits_url":"https://api.github.com/repos/alexcrichton/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/futures-rs/merges","archive_url":"https://api.github.com/repos/alexcrichton/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/futures-rs/downloads","issues_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/alexcrichton/futures-rs/deployments","created_at":"2016-03-30T16:03:08Z","updated_at":"2016-12-25T17:24:16Z","pushed_at":"2016-12-25T19:01:38Z","git_url":"git://github.com/alexcrichton/futures-rs.git","ssh_url":"git@github.com:alexcrichton/futures-rs.git","clone_url":"https://github.com/alexcrichton/futures-rs.git","svn_url":"https://github.com/alexcrichton/futures-rs","homepage":"http://alexcrichton.com/futures-rs","size":2748,"stargazers_count":1254,"watchers_count":1254,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":51,"forks":97,"open_issues":51,"watchers":1254,"default_branch":"master"}},"base":{"label":"alexcrichton:master","ref":"master","sha":"0163721a8637f40fe90baff4cf83619b3c39fb84","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":55077261,"name":"futures-rs","full_name":"alexcrichton/futures-rs","owner":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/futures-rs","description":"Zero-cost futures and streams in Rust","fork":false,"url":"https://api.github.com/repos/alexcrichton/futures-rs","forks_url":"https://api.github.com/repos/alexcrichton/futures-rs/forks","keys_url":"https://api.github.com/repos/alexcrichton/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/futures-rs/teams","hooks_url":"https://api.github.com/repos/alexcrichton/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/futures-rs/events","assignees_url":"https://api.github.com/repos/alexcrichton/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/futures-rs/tags","blobs_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/futures-rs/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/futures-rs/subscription","commits_url":"https://api.github.com/repos/alexcrichton/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/futures-rs/merges","archive_url":"https://api.github.com/repos/alexcrichton/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/futures-rs/downloads","issues_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/alexcrichton/futures-rs/deployments","created_at":"2016-03-30T16:03:08Z","updated_at":"2016-12-25T17:24:16Z","pushed_at":"2016-12-25T19:01:38Z","git_url":"git://github.com/alexcrichton/futures-rs.git","ssh_url":"git@github.com:alexcrichton/futures-rs.git","clone_url":"https://github.com/alexcrichton/futures-rs.git","svn_url":"https://github.com/alexcrichton/futures-rs","homepage":"http://alexcrichton.com/futures-rs","size":2748,"stargazers_count":1254,"watchers_count":1254,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":51,"forks":97,"open_issues":51,"watchers":1254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305"},"html":{"href":"https://github.com/alexcrichton/futures-rs/pull/305"},"issue":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/issues/305"},"comments":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/alexcrichton/futures-rs/statuses/6468b266c674d71d4209d985312522b57f7a0776"}}}}
{"actor":{"display_login":"dwrensha"}}