{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/48751214","id":48751214,"diff_hunk":"@@ -88,12 +88,14 @@ def self.set_target_xcconfig(pod_bundle, target, config)\n               if existing.real_path.to_path.start_with?(pod_bundle.sandbox.root.to_path << '/')\n                 set_base_configuration_reference.call\n               elsif !xcconfig_includes_target_xcconfig?(config.base_configuration_reference, path)\n-                UI.warn 'CocoaPods did not set the base configuration of your ' \\\n-                'project because your project already has a custom ' \\\n-                'config set. In order for CocoaPods integration to work at ' \\\n-                'all, please either set the base configurations of the target ' \\\n-                \"`#{target.name}` to `#{path}` or include the `#{path}` in your \" \\\n-                \"build configuration (#{UI.path(existing.real_path)}).\"\n+                unless File.exist?(path) && File.exist?(existing.real_path) && !FileUtils.compare_file(path, existing.real_path)","path":"lib/cocoapods/installer/user_project_integrator/target_integrator/xcconfig_integrator.rb","position":10,"original_position":10,"commit_id":"39d7ea7976a57dd34729539b2f924b0f56770a7d","original_commit_id":"39d7ea7976a57dd34729539b2f924b0f56770a7d","user":{"login":"jedlewison","id":2030036,"avatar_url":"https://avatars.githubusercontent.com/u/2030036?v=3","gravatar_id":"","url":"https://api.github.com/users/jedlewison","html_url":"https://github.com/jedlewison","followers_url":"https://api.github.com/users/jedlewison/followers","following_url":"https://api.github.com/users/jedlewison/following{/other_user}","gists_url":"https://api.github.com/users/jedlewison/gists{/gist_id}","starred_url":"https://api.github.com/users/jedlewison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedlewison/subscriptions","organizations_url":"https://api.github.com/users/jedlewison/orgs","repos_url":"https://api.github.com/users/jedlewison/repos","events_url":"https://api.github.com/users/jedlewison/events{/privacy}","received_events_url":"https://api.github.com/users/jedlewison/received_events","type":"User","site_admin":false},"body":"Thanks, will do.","created_at":"2016-01-04T16:48:18Z","updated_at":"2016-01-04T16:48:18Z","html_url":"https://github.com/CocoaPods/CocoaPods/pull/4722#discussion_r48751214","pull_request_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/48751214"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/4722#discussion_r48751214"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722"}}},"pull_request":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722","id":54948387,"html_url":"https://github.com/CocoaPods/CocoaPods/pull/4722","diff_url":"https://github.com/CocoaPods/CocoaPods/pull/4722.diff","patch_url":"https://github.com/CocoaPods/CocoaPods/pull/4722.patch","issue_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4722","number":4722,"state":"open","locked":false,"title":"Don't warn about setting base config when existing is identical to new one","user":{"login":"jedlewison","id":2030036,"avatar_url":"https://avatars.githubusercontent.com/u/2030036?v=3","gravatar_id":"","url":"https://api.github.com/users/jedlewison","html_url":"https://github.com/jedlewison","followers_url":"https://api.github.com/users/jedlewison/followers","following_url":"https://api.github.com/users/jedlewison/following{/other_user}","gists_url":"https://api.github.com/users/jedlewison/gists{/gist_id}","starred_url":"https://api.github.com/users/jedlewison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedlewison/subscriptions","organizations_url":"https://api.github.com/users/jedlewison/orgs","repos_url":"https://api.github.com/users/jedlewison/repos","events_url":"https://api.github.com/users/jedlewison/events{/privacy}","received_events_url":"https://api.github.com/users/jedlewison/received_events","type":"User","site_admin":false},"body":"Issue here is the scenario where a project gets added to a new workspace temporarily and has its pods built in a new directory. In that case, the location of the newly generated config file may differ from the existing one, but the config is actually identical. So when the config files are the same, it seems reasonable to silence the ominous \"CocoaPods may not work at all\" message since it definitely works.\r\n\r\nIf there's a different or better way to handle this edge case, that'd be great too — I'm not experienced with Ruby so I easily could have missed something else.","created_at":"2016-01-04T07:09:48Z","updated_at":"2016-01-04T16:48:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ea92867b2397aa8cbefab54c7184b363e1df4d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722/commits","review_comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722/comments","review_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4722/comments","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/39d7ea7976a57dd34729539b2f924b0f56770a7d","head":{"label":"jedlewison:master","ref":"master","sha":"39d7ea7976a57dd34729539b2f924b0f56770a7d","user":{"login":"jedlewison","id":2030036,"avatar_url":"https://avatars.githubusercontent.com/u/2030036?v=3","gravatar_id":"","url":"https://api.github.com/users/jedlewison","html_url":"https://github.com/jedlewison","followers_url":"https://api.github.com/users/jedlewison/followers","following_url":"https://api.github.com/users/jedlewison/following{/other_user}","gists_url":"https://api.github.com/users/jedlewison/gists{/gist_id}","starred_url":"https://api.github.com/users/jedlewison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedlewison/subscriptions","organizations_url":"https://api.github.com/users/jedlewison/orgs","repos_url":"https://api.github.com/users/jedlewison/repos","events_url":"https://api.github.com/users/jedlewison/events{/privacy}","received_events_url":"https://api.github.com/users/jedlewison/received_events","type":"User","site_admin":false},"repo":{"id":48979816,"name":"CocoaPods","full_name":"jedlewison/CocoaPods","owner":{"login":"jedlewison","id":2030036,"avatar_url":"https://avatars.githubusercontent.com/u/2030036?v=3","gravatar_id":"","url":"https://api.github.com/users/jedlewison","html_url":"https://github.com/jedlewison","followers_url":"https://api.github.com/users/jedlewison/followers","following_url":"https://api.github.com/users/jedlewison/following{/other_user}","gists_url":"https://api.github.com/users/jedlewison/gists{/gist_id}","starred_url":"https://api.github.com/users/jedlewison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedlewison/subscriptions","organizations_url":"https://api.github.com/users/jedlewison/orgs","repos_url":"https://api.github.com/users/jedlewison/repos","events_url":"https://api.github.com/users/jedlewison/events{/privacy}","received_events_url":"https://api.github.com/users/jedlewison/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jedlewison/CocoaPods","description":"The Cocoa Dependency Manager.","fork":true,"url":"https://api.github.com/repos/jedlewison/CocoaPods","forks_url":"https://api.github.com/repos/jedlewison/CocoaPods/forks","keys_url":"https://api.github.com/repos/jedlewison/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jedlewison/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jedlewison/CocoaPods/teams","hooks_url":"https://api.github.com/repos/jedlewison/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/jedlewison/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/jedlewison/CocoaPods/events","assignees_url":"https://api.github.com/repos/jedlewison/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/jedlewison/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/jedlewison/CocoaPods/tags","blobs_url":"https://api.github.com/repos/jedlewison/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jedlewison/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jedlewison/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/jedlewison/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jedlewison/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/jedlewison/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/jedlewison/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/jedlewison/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/jedlewison/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/jedlewison/CocoaPods/subscription","commits_url":"https://api.github.com/repos/jedlewison/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/jedlewison/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/jedlewison/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/jedlewison/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/jedlewison/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/jedlewison/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jedlewison/CocoaPods/merges","archive_url":"https://api.github.com/repos/jedlewison/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jedlewison/CocoaPods/downloads","issues_url":"https://api.github.com/repos/jedlewison/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/jedlewison/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/jedlewison/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/jedlewison/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jedlewison/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/jedlewison/CocoaPods/releases{/id}","created_at":"2016-01-04T06:50:19Z","updated_at":"2016-01-04T06:50:22Z","pushed_at":"2016-01-04T08:53:45Z","git_url":"git://github.com/jedlewison/CocoaPods.git","ssh_url":"git@github.com:jedlewison/CocoaPods.git","clone_url":"https://github.com/jedlewison/CocoaPods.git","svn_url":"https://github.com/jedlewison/CocoaPods","homepage":"https://cocoapods.org/","size":47717,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaPods:master","ref":"master","sha":"ebc5e9a59da869eed26afcc12a877273dae7e71d","user":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"repo":{"id":2203645,"name":"CocoaPods","full_name":"CocoaPods/CocoaPods","owner":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CocoaPods/CocoaPods","description":"The Cocoa Dependency Manager.","fork":false,"url":"https://api.github.com/repos/CocoaPods/CocoaPods","forks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/forks","keys_url":"https://api.github.com/repos/CocoaPods/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaPods/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaPods/CocoaPods/teams","hooks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/events","assignees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaPods/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/tags","blobs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaPods/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscription","commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaPods/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaPods/CocoaPods/merges","archive_url":"https://api.github.com/repos/CocoaPods/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaPods/CocoaPods/downloads","issues_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaPods/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/CocoaPods/CocoaPods/releases{/id}","created_at":"2011-08-14T00:10:53Z","updated_at":"2016-01-04T14:21:56Z","pushed_at":"2016-01-04T13:25:17Z","git_url":"git://github.com/CocoaPods/CocoaPods.git","ssh_url":"git@github.com:CocoaPods/CocoaPods.git","clone_url":"https://github.com/CocoaPods/CocoaPods.git","svn_url":"https://github.com/CocoaPods/CocoaPods","homepage":"https://cocoapods.org/","size":59437,"stargazers_count":7028,"watchers_count":7028,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1321,"mirror_url":null,"open_issues_count":165,"forks":1321,"open_issues":165,"watchers":7028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/4722"},"issue":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4722"},"comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4722/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4722/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/39d7ea7976a57dd34729539b2f924b0f56770a7d"}}}}