{"action":"created","comment":{"url":"https://api.github.com/repos/incuna/django-orderable/pulls/comments/89286553","pull_request_review_id":9832385,"id":89286553,"diff_hunk":"@@ -34,25 +37,25 @@ def get_unique_fields(self):\n                 return ['%s_id' % f for f in unique_fields]\n         return []\n \n-    def get_filtered_manager(self):\n-        manager = self.__class__.objects\n+    def get_filtered_manager(self) -> OrderableQueryset:\n+        manager = self.__class__.objects  # type: ignore self.__class__ is 'type' not 'Orderable'","path":"orderable/models.py","position":27,"original_position":27,"commit_id":"63788d35029c5034589721436f1d4bbc6a085a52","original_commit_id":"63788d35029c5034589721436f1d4bbc6a085a52","user":{"login":"todd-dembrey","id":6338661,"avatar_url":"https://avatars.githubusercontent.com/u/6338661?v=3","gravatar_id":"","url":"https://api.github.com/users/todd-dembrey","html_url":"https://github.com/todd-dembrey","followers_url":"https://api.github.com/users/todd-dembrey/followers","following_url":"https://api.github.com/users/todd-dembrey/following{/other_user}","gists_url":"https://api.github.com/users/todd-dembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/todd-dembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todd-dembrey/subscriptions","organizations_url":"https://api.github.com/users/todd-dembrey/orgs","repos_url":"https://api.github.com/users/todd-dembrey/repos","events_url":"https://api.github.com/users/todd-dembrey/events{/privacy}","received_events_url":"https://api.github.com/users/todd-dembrey/received_events","type":"User","site_admin":false},"body":"I think this should be `type(self).objects` to avoid the error on reflection","created_at":"2016-11-23T10:16:35Z","updated_at":"2016-11-23T10:16:35Z","html_url":"https://github.com/incuna/django-orderable/pull/45#discussion_r89286553","pull_request_url":"https://api.github.com/repos/incuna/django-orderable/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/incuna/django-orderable/pulls/comments/89286553"},"html":{"href":"https://github.com/incuna/django-orderable/pull/45#discussion_r89286553"},"pull_request":{"href":"https://api.github.com/repos/incuna/django-orderable/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/incuna/django-orderable/pulls/45","id":94974767,"html_url":"https://github.com/incuna/django-orderable/pull/45","diff_url":"https://github.com/incuna/django-orderable/pull/45.diff","patch_url":"https://github.com/incuna/django-orderable/pull/45.patch","issue_url":"https://api.github.com/repos/incuna/django-orderable/issues/45","number":45,"state":"open","locked":false,"title":"Typing","user":{"login":"todd-dembrey","id":6338661,"avatar_url":"https://avatars.githubusercontent.com/u/6338661?v=3","gravatar_id":"","url":"https://api.github.com/users/todd-dembrey","html_url":"https://github.com/todd-dembrey","followers_url":"https://api.github.com/users/todd-dembrey/followers","following_url":"https://api.github.com/users/todd-dembrey/following{/other_user}","gists_url":"https://api.github.com/users/todd-dembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/todd-dembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todd-dembrey/subscriptions","organizations_url":"https://api.github.com/users/todd-dembrey/orgs","repos_url":"https://api.github.com/users/todd-dembrey/repos","events_url":"https://api.github.com/users/todd-dembrey/events{/privacy}","received_events_url":"https://api.github.com/users/todd-dembrey/received_events","type":"User","site_admin":false},"body":"Whats cool and shiny in python? Typing! To the band wagon!\r\n\r\nI think it is worth creating the PR for information. Though I don't feel it adds much value to the project, it was interesting to do. \r\n\r\nThe Django core doesn't support typing currently so I have had to ignore imports to prevent a load of spurious errors about stub files. ","created_at":"2016-11-23T10:16:07Z","updated_at":"2016-11-23T10:16:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"257a90e86972a9fa445e73c1fbc94d5ef0df4b91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/incuna/django-orderable/pulls/45/commits","review_comments_url":"https://api.github.com/repos/incuna/django-orderable/pulls/45/comments","review_comment_url":"https://api.github.com/repos/incuna/django-orderable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/incuna/django-orderable/issues/45/comments","statuses_url":"https://api.github.com/repos/incuna/django-orderable/statuses/63788d35029c5034589721436f1d4bbc6a085a52","head":{"label":"todd-dembrey:typing","ref":"typing","sha":"63788d35029c5034589721436f1d4bbc6a085a52","user":{"login":"todd-dembrey","id":6338661,"avatar_url":"https://avatars.githubusercontent.com/u/6338661?v=3","gravatar_id":"","url":"https://api.github.com/users/todd-dembrey","html_url":"https://github.com/todd-dembrey","followers_url":"https://api.github.com/users/todd-dembrey/followers","following_url":"https://api.github.com/users/todd-dembrey/following{/other_user}","gists_url":"https://api.github.com/users/todd-dembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/todd-dembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todd-dembrey/subscriptions","organizations_url":"https://api.github.com/users/todd-dembrey/orgs","repos_url":"https://api.github.com/users/todd-dembrey/repos","events_url":"https://api.github.com/users/todd-dembrey/events{/privacy}","received_events_url":"https://api.github.com/users/todd-dembrey/received_events","type":"User","site_admin":false},"repo":{"id":74507777,"name":"django-orderable","full_name":"todd-dembrey/django-orderable","owner":{"login":"todd-dembrey","id":6338661,"avatar_url":"https://avatars.githubusercontent.com/u/6338661?v=3","gravatar_id":"","url":"https://api.github.com/users/todd-dembrey","html_url":"https://github.com/todd-dembrey","followers_url":"https://api.github.com/users/todd-dembrey/followers","following_url":"https://api.github.com/users/todd-dembrey/following{/other_user}","gists_url":"https://api.github.com/users/todd-dembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/todd-dembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todd-dembrey/subscriptions","organizations_url":"https://api.github.com/users/todd-dembrey/orgs","repos_url":"https://api.github.com/users/todd-dembrey/repos","events_url":"https://api.github.com/users/todd-dembrey/events{/privacy}","received_events_url":"https://api.github.com/users/todd-dembrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/todd-dembrey/django-orderable","description":"Add manual sort order to Django objects via an abstract base class and admin classes","fork":true,"url":"https://api.github.com/repos/todd-dembrey/django-orderable","forks_url":"https://api.github.com/repos/todd-dembrey/django-orderable/forks","keys_url":"https://api.github.com/repos/todd-dembrey/django-orderable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/todd-dembrey/django-orderable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/todd-dembrey/django-orderable/teams","hooks_url":"https://api.github.com/repos/todd-dembrey/django-orderable/hooks","issue_events_url":"https://api.github.com/repos/todd-dembrey/django-orderable/issues/events{/number}","events_url":"https://api.github.com/repos/todd-dembrey/django-orderable/events","assignees_url":"https://api.github.com/repos/todd-dembrey/django-orderable/assignees{/user}","branches_url":"https://api.github.com/repos/todd-dembrey/django-orderable/branches{/branch}","tags_url":"https://api.github.com/repos/todd-dembrey/django-orderable/tags","blobs_url":"https://api.github.com/repos/todd-dembrey/django-orderable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/todd-dembrey/django-orderable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/todd-dembrey/django-orderable/git/refs{/sha}","trees_url":"https://api.github.com/repos/todd-dembrey/django-orderable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/todd-dembrey/django-orderable/statuses/{sha}","languages_url":"https://api.github.com/repos/todd-dembrey/django-orderable/languages","stargazers_url":"https://api.github.com/repos/todd-dembrey/django-orderable/stargazers","contributors_url":"https://api.github.com/repos/todd-dembrey/django-orderable/contributors","subscribers_url":"https://api.github.com/repos/todd-dembrey/django-orderable/subscribers","subscription_url":"https://api.github.com/repos/todd-dembrey/django-orderable/subscription","commits_url":"https://api.github.com/repos/todd-dembrey/django-orderable/commits{/sha}","git_commits_url":"https://api.github.com/repos/todd-dembrey/django-orderable/git/commits{/sha}","comments_url":"https://api.github.com/repos/todd-dembrey/django-orderable/comments{/number}","issue_comment_url":"https://api.github.com/repos/todd-dembrey/django-orderable/issues/comments{/number}","contents_url":"https://api.github.com/repos/todd-dembrey/django-orderable/contents/{+path}","compare_url":"https://api.github.com/repos/todd-dembrey/django-orderable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/todd-dembrey/django-orderable/merges","archive_url":"https://api.github.com/repos/todd-dembrey/django-orderable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/todd-dembrey/django-orderable/downloads","issues_url":"https://api.github.com/repos/todd-dembrey/django-orderable/issues{/number}","pulls_url":"https://api.github.com/repos/todd-dembrey/django-orderable/pulls{/number}","milestones_url":"https://api.github.com/repos/todd-dembrey/django-orderable/milestones{/number}","notifications_url":"https://api.github.com/repos/todd-dembrey/django-orderable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/todd-dembrey/django-orderable/labels{/name}","releases_url":"https://api.github.com/repos/todd-dembrey/django-orderable/releases{/id}","deployments_url":"https://api.github.com/repos/todd-dembrey/django-orderable/deployments","created_at":"2016-11-22T19:50:35Z","updated_at":"2016-11-22T19:50:36Z","pushed_at":"2016-11-22T22:45:53Z","git_url":"git://github.com/todd-dembrey/django-orderable.git","ssh_url":"git@github.com:todd-dembrey/django-orderable.git","clone_url":"https://github.com/todd-dembrey/django-orderable.git","svn_url":"https://github.com/todd-dembrey/django-orderable","homepage":"","size":114,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"incuna:master","ref":"master","sha":"a74ed5219593bda1fdbc398efc6bef4a31a2f1e4","user":{"login":"incuna","id":55510,"avatar_url":"https://avatars.githubusercontent.com/u/55510?v=3","gravatar_id":"","url":"https://api.github.com/users/incuna","html_url":"https://github.com/incuna","followers_url":"https://api.github.com/users/incuna/followers","following_url":"https://api.github.com/users/incuna/following{/other_user}","gists_url":"https://api.github.com/users/incuna/gists{/gist_id}","starred_url":"https://api.github.com/users/incuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incuna/subscriptions","organizations_url":"https://api.github.com/users/incuna/orgs","repos_url":"https://api.github.com/users/incuna/repos","events_url":"https://api.github.com/users/incuna/events{/privacy}","received_events_url":"https://api.github.com/users/incuna/received_events","type":"Organization","site_admin":false},"repo":{"id":4192553,"name":"django-orderable","full_name":"incuna/django-orderable","owner":{"login":"incuna","id":55510,"avatar_url":"https://avatars.githubusercontent.com/u/55510?v=3","gravatar_id":"","url":"https://api.github.com/users/incuna","html_url":"https://github.com/incuna","followers_url":"https://api.github.com/users/incuna/followers","following_url":"https://api.github.com/users/incuna/following{/other_user}","gists_url":"https://api.github.com/users/incuna/gists{/gist_id}","starred_url":"https://api.github.com/users/incuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incuna/subscriptions","organizations_url":"https://api.github.com/users/incuna/orgs","repos_url":"https://api.github.com/users/incuna/repos","events_url":"https://api.github.com/users/incuna/events{/privacy}","received_events_url":"https://api.github.com/users/incuna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/incuna/django-orderable","description":"Add manual sort order to Django objects via an abstract base class and admin classes","fork":false,"url":"https://api.github.com/repos/incuna/django-orderable","forks_url":"https://api.github.com/repos/incuna/django-orderable/forks","keys_url":"https://api.github.com/repos/incuna/django-orderable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/incuna/django-orderable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/incuna/django-orderable/teams","hooks_url":"https://api.github.com/repos/incuna/django-orderable/hooks","issue_events_url":"https://api.github.com/repos/incuna/django-orderable/issues/events{/number}","events_url":"https://api.github.com/repos/incuna/django-orderable/events","assignees_url":"https://api.github.com/repos/incuna/django-orderable/assignees{/user}","branches_url":"https://api.github.com/repos/incuna/django-orderable/branches{/branch}","tags_url":"https://api.github.com/repos/incuna/django-orderable/tags","blobs_url":"https://api.github.com/repos/incuna/django-orderable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/incuna/django-orderable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/incuna/django-orderable/git/refs{/sha}","trees_url":"https://api.github.com/repos/incuna/django-orderable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/incuna/django-orderable/statuses/{sha}","languages_url":"https://api.github.com/repos/incuna/django-orderable/languages","stargazers_url":"https://api.github.com/repos/incuna/django-orderable/stargazers","contributors_url":"https://api.github.com/repos/incuna/django-orderable/contributors","subscribers_url":"https://api.github.com/repos/incuna/django-orderable/subscribers","subscription_url":"https://api.github.com/repos/incuna/django-orderable/subscription","commits_url":"https://api.github.com/repos/incuna/django-orderable/commits{/sha}","git_commits_url":"https://api.github.com/repos/incuna/django-orderable/git/commits{/sha}","comments_url":"https://api.github.com/repos/incuna/django-orderable/comments{/number}","issue_comment_url":"https://api.github.com/repos/incuna/django-orderable/issues/comments{/number}","contents_url":"https://api.github.com/repos/incuna/django-orderable/contents/{+path}","compare_url":"https://api.github.com/repos/incuna/django-orderable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/incuna/django-orderable/merges","archive_url":"https://api.github.com/repos/incuna/django-orderable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/incuna/django-orderable/downloads","issues_url":"https://api.github.com/repos/incuna/django-orderable/issues{/number}","pulls_url":"https://api.github.com/repos/incuna/django-orderable/pulls{/number}","milestones_url":"https://api.github.com/repos/incuna/django-orderable/milestones{/number}","notifications_url":"https://api.github.com/repos/incuna/django-orderable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/incuna/django-orderable/labels{/name}","releases_url":"https://api.github.com/repos/incuna/django-orderable/releases{/id}","deployments_url":"https://api.github.com/repos/incuna/django-orderable/deployments","created_at":"2012-05-01T13:38:15Z","updated_at":"2016-10-27T09:23:11Z","pushed_at":"2016-11-23T10:16:07Z","git_url":"git://github.com/incuna/django-orderable.git","ssh_url":"git@github.com:incuna/django-orderable.git","clone_url":"https://github.com/incuna/django-orderable.git","svn_url":"https://github.com/incuna/django-orderable","homepage":"","size":116,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/incuna/django-orderable/pulls/45"},"html":{"href":"https://github.com/incuna/django-orderable/pull/45"},"issue":{"href":"https://api.github.com/repos/incuna/django-orderable/issues/45"},"comments":{"href":"https://api.github.com/repos/incuna/django-orderable/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/incuna/django-orderable/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/incuna/django-orderable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/incuna/django-orderable/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/incuna/django-orderable/statuses/63788d35029c5034589721436f1d4bbc6a085a52"}}}}
{"actor":{"display_login":"todd-dembrey"}}