{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1089","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1089/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1089/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1089/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1089","id":197357413,"number":1089,"title":"Add reading of rating tag for MP3, MP4, and FLAC","user":{"login":"LindyBalboa","id":20605205,"avatar_url":"https://avatars.githubusercontent.com/u/20605205?v=3","gravatar_id":"","url":"https://api.github.com/users/LindyBalboa","html_url":"https://github.com/LindyBalboa","followers_url":"https://api.github.com/users/LindyBalboa/followers","following_url":"https://api.github.com/users/LindyBalboa/following{/other_user}","gists_url":"https://api.github.com/users/LindyBalboa/gists{/gist_id}","starred_url":"https://api.github.com/users/LindyBalboa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindyBalboa/subscriptions","organizations_url":"https://api.github.com/users/LindyBalboa/orgs","repos_url":"https://api.github.com/users/LindyBalboa/repos","events_url":"https://api.github.com/users/LindyBalboa/events{/privacy}","received_events_url":"https://api.github.com/users/LindyBalboa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-23T11:52:20Z","updated_at":"2016-12-24T00:12:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1089","html_url":"https://github.com/mixxxdj/mixxx/pull/1089","diff_url":"https://github.com/mixxxdj/mixxx/pull/1089.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1089.patch"},"body":"So this is partly addressed in the open PR #924 but it seems to have stagnated so I have decided to jump on it. Current state is that for mp3 the rating is taken from a POPM tag with email \"mixxx@mixxx.org\" or the first available if there is none from mixxx. MP4 and FLAC both use a plain 0-100 integer scale. \r\n\r\nValues are then parsed into a 0-5 value before being added to the metadata object. For POPM, the same standard as Windows Media Player/Explorer is followed. \r\n\r\nTo do:\r\n-add support for APE tags I'm not familiar with it and don't use it. I can't seem to find the key for the rating tag. Does anyone know this off hand?\r\n-add writing from database to file. Need some discussion here. As MP4, FLAC, and APE do no use POPM, there isn't the email feature. So I feel it would actually make little sense to use a designated email for mixxx. Some users claim that they need different rating option for different applications/people, but honestly I use a mixed library; format isn't so important to me. Like I said, discussion needed.\r\n-add the option to not overwrite existing ratings in the database\r\n-add the option to turn writing the rating to the file tag on or off\r\n\r\nI'm not quite sure where in the code the writing part would be controlled. If someone could point me in the right direction I'm sure I can figure it out, but if someone wants to contribute that, that would be great too."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/269059145","html_url":"https://github.com/mixxxdj/mixxx/pull/1089#issuecomment-269059145","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1089","id":269059145,"user":{"login":"uklotzde","id":1474154,"avatar_url":"https://avatars.githubusercontent.com/u/1474154?v=3","gravatar_id":"","url":"https://api.github.com/users/uklotzde","html_url":"https://github.com/uklotzde","followers_url":"https://api.github.com/users/uklotzde/followers","following_url":"https://api.github.com/users/uklotzde/following{/other_user}","gists_url":"https://api.github.com/users/uklotzde/gists{/gist_id}","starred_url":"https://api.github.com/users/uklotzde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uklotzde/subscriptions","organizations_url":"https://api.github.com/users/uklotzde/orgs","repos_url":"https://api.github.com/users/uklotzde/repos","events_url":"https://api.github.com/users/uklotzde/events{/privacy}","received_events_url":"https://api.github.com/users/uklotzde/received_events","type":"User","site_admin":false},"created_at":"2016-12-24T00:12:07Z","updated_at":"2016-12-24T00:12:07Z","body":"Please replace all tabs with 4 spaces:\r\n(https://www.mixxx.org/wiki/doku.php/coding_guidelines)"}}
{"actor":{"display_login":"uklotzde"}}