{"action":"created","issue":{"url":"https://api.github.com/repos/sublimehq/Packages/issues/96","repository_url":"https://api.github.com/repos/sublimehq/Packages","labels_url":"https://api.github.com/repos/sublimehq/Packages/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/sublimehq/Packages/issues/96/comments","events_url":"https://api.github.com/repos/sublimehq/Packages/issues/96/events","html_url":"https://github.com/sublimehq/Packages/pull/96","id":103951784,"number":96,"title":"Improve JavaScript language grammars","user":{"login":"ccampbell","id":259316,"avatar_url":"https://avatars.githubusercontent.com/u/259316?v=3","gravatar_id":"","url":"https://api.github.com/users/ccampbell","html_url":"https://github.com/ccampbell","followers_url":"https://api.github.com/users/ccampbell/followers","following_url":"https://api.github.com/users/ccampbell/following{/other_user}","gists_url":"https://api.github.com/users/ccampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/ccampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccampbell/subscriptions","organizations_url":"https://api.github.com/users/ccampbell/orgs","repos_url":"https://api.github.com/users/ccampbell/repos","events_url":"https://api.github.com/users/ccampbell/events{/privacy}","received_events_url":"https://api.github.com/users/ccampbell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sublimehq/Packages/labels/significant","name":"significant","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-08-30T21:22:53Z","updated_at":"2016-02-12T03:37:02Z","closed_at":"2016-02-12T03:37:02Z","pull_request":{"url":"https://api.github.com/repos/sublimehq/Packages/pulls/96","html_url":"https://github.com/sublimehq/Packages/pull/96","diff_url":"https://github.com/sublimehq/Packages/pull/96.diff","patch_url":"https://github.com/sublimehq/Packages/pull/96.patch"},"body":"This is related to #63 and integrating the Javascript Next grammars in 82b58838389969208d7391fe3ede52e6a78fb851.\r\n\r\nThe changes in Javascript Next introduced a bunch of regressions from the Javascript grammars in Sublime Text 2 and Sublime Text 3 stable.  The aggressive green function calls were just one of them.\r\n\r\nThis Pull Request attempts to fix some of the things that were broken. I'm aware there are differences between language grammars and themes, but in this case I think these things should work without needing to modify existing themes.\r\n\r\n--\r\n\r\n**BEFORE**\r\n\r\n![jhcn](https://cloud.githubusercontent.com/assets/259316/9569896/449ff7d2-4f48-11e5-9940-0133e639803b.png)\r\n\r\n**AFTER**\r\n\r\n![mosj](https://cloud.githubusercontent.com/assets/259316/9569900/4f280c80-4f48-11e5-9db1-ae3f85863d7c.png)\r\n\r\n@jskinner @benvie @babel I don't know the proper forum for these changes cause right now there are 3 different people independently maintaining different versions of Javascript Next language grammars. It would probably make sense to standardize one version."},"comment":{"url":"https://api.github.com/repos/sublimehq/Packages/issues/comments/183168552","html_url":"https://github.com/sublimehq/Packages/pull/96#issuecomment-183168552","issue_url":"https://api.github.com/repos/sublimehq/Packages/issues/96","id":183168552,"user":{"login":"wbond","id":41734,"avatar_url":"https://avatars.githubusercontent.com/u/41734?v=3","gravatar_id":"","url":"https://api.github.com/users/wbond","html_url":"https://github.com/wbond","followers_url":"https://api.github.com/users/wbond/followers","following_url":"https://api.github.com/users/wbond/following{/other_user}","gists_url":"https://api.github.com/users/wbond/gists{/gist_id}","starred_url":"https://api.github.com/users/wbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbond/subscriptions","organizations_url":"https://api.github.com/users/wbond/orgs","repos_url":"https://api.github.com/users/wbond/repos","events_url":"https://api.github.com/users/wbond/events{/privacy}","received_events_url":"https://api.github.com/users/wbond/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T03:37:02Z","updated_at":"2016-02-12T03:37:02Z","body":"I rebased these on top of master, added tests and made a number of fixed.\r\n\r\nThe major item to mention here is that I got rid of the special case for `$(` and `$.`. Instead, we now have:\r\n\r\n - `variable.other.dollar` for any variable starting with `$`\r\n - `punctuation.dollar` for the `$` at the beginning of such a variable\r\n - `meta.object-literal.key.dollar` for a non-string object key that starts with `$`\r\n - `punctuation.dollar` for the `$` at the beginning of such a variable\r\n - `variable.other.dollar.only` for a var that is just `$`\r\n\r\nThis should allow color scheme developers to target how they want. I've noticed some want to highlight the `$` specifically in the context of a longer var, some want to treat jQuery specially and others want all `$` vars to be colored for the sake of identifying \"element\" vars.\r\n\r\nI'm obviously open to discussion if people think things should be tweaked more, but let's open a new issue for that."}}