{"action":"created","comment":{"url":"https://api.github.com/repos/klee/klee/pulls/comments/60249828","id":60249828,"diff_hunk":"@@ -1544,36 +1559,48 @@ void Executor::executeInstruction(ExecutionState &state, KInstruction *ki) {\n #else\n           BasicBlock *caseSuccessor = si->getSuccessor(i);\n #endif\n-          std::map<BasicBlock*, ref<Expr> >::iterator it =\n-            targets.insert(std::make_pair(caseSuccessor,\n-                           ConstantExpr::alloc(0, Expr::Bool))).first;\n \n-          it->second = OrExpr::create(match, it->second);\n+          // TODO add conditional\n+          std::pair<std::map<BasicBlock *, ref<Expr> >::iterator, bool> res =\n+              targets.insert(std::make_pair(\n+                  caseSuccessor, ConstantExpr::alloc(0, Expr::Bool)));\n+\n+          res.first->second = OrExpr::create(match, res.first->second);","path":"lib/Core/Executor.cpp","position":64,"original_position":46,"commit_id":"788027432b458d20146e090980a0f499ca99378d","original_commit_id":"788027432b458d20146e090980a0f499ca99378d","user":{"login":"delcypher","id":511795,"avatar_url":"https://avatars.githubusercontent.com/u/511795?v=3","gravatar_id":"","url":"https://api.github.com/users/delcypher","html_url":"https://github.com/delcypher","followers_url":"https://api.github.com/users/delcypher/followers","following_url":"https://api.github.com/users/delcypher/following{/other_user}","gists_url":"https://api.github.com/users/delcypher/gists{/gist_id}","starred_url":"https://api.github.com/users/delcypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delcypher/subscriptions","organizations_url":"https://api.github.com/users/delcypher/orgs","repos_url":"https://api.github.com/users/delcypher/repos","events_url":"https://api.github.com/users/delcypher/events{/privacy}","received_events_url":"https://api.github.com/users/delcypher/received_events","type":"User","site_admin":false},"body":"@MartinNowack Ah I see. That makes sense now. This is worthy of a comment I think!","created_at":"2016-04-19T15:12:11Z","updated_at":"2016-04-19T15:12:11Z","html_url":"https://github.com/klee/klee/pull/362#discussion_r60249828","pull_request_url":"https://api.github.com/repos/klee/klee/pulls/362","_links":{"self":{"href":"https://api.github.com/repos/klee/klee/pulls/comments/60249828"},"html":{"href":"https://github.com/klee/klee/pull/362#discussion_r60249828"},"pull_request":{"href":"https://api.github.com/repos/klee/klee/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/klee/klee/pulls/362","id":63743873,"html_url":"https://github.com/klee/klee/pull/362","diff_url":"https://github.com/klee/klee/pull/362.diff","patch_url":"https://github.com/klee/klee/pull/362.patch","issue_url":"https://api.github.com/repos/klee/klee/issues/362","number":362,"state":"open","locked":false,"title":"Deterministic state addition/removing","user":{"login":"MartinNowack","id":2443641,"avatar_url":"https://avatars.githubusercontent.com/u/2443641?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowack","html_url":"https://github.com/MartinNowack","followers_url":"https://api.github.com/users/MartinNowack/followers","following_url":"https://api.github.com/users/MartinNowack/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowack/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowack/subscriptions","organizations_url":"https://api.github.com/users/MartinNowack/orgs","repos_url":"https://api.github.com/users/MartinNowack/repos","events_url":"https://api.github.com/users/MartinNowack/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowack/received_events","type":"User","site_admin":false},"body":"Respect the order of the added states by putting them in a vector instead of a set.","created_at":"2016-03-22T15:54:03Z","updated_at":"2016-04-19T15:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a51f54c440b02d389eea52ead81b9f0f38ae6adb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/klee/klee/pulls/362/commits","review_comments_url":"https://api.github.com/repos/klee/klee/pulls/362/comments","review_comment_url":"https://api.github.com/repos/klee/klee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/klee/klee/issues/362/comments","statuses_url":"https://api.github.com/repos/klee/klee/statuses/788027432b458d20146e090980a0f499ca99378d","head":{"label":"MartinNowack:feat_determ_state_selection","ref":"feat_determ_state_selection","sha":"788027432b458d20146e090980a0f499ca99378d","user":{"login":"MartinNowack","id":2443641,"avatar_url":"https://avatars.githubusercontent.com/u/2443641?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowack","html_url":"https://github.com/MartinNowack","followers_url":"https://api.github.com/users/MartinNowack/followers","following_url":"https://api.github.com/users/MartinNowack/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowack/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowack/subscriptions","organizations_url":"https://api.github.com/users/MartinNowack/orgs","repos_url":"https://api.github.com/users/MartinNowack/repos","events_url":"https://api.github.com/users/MartinNowack/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowack/received_events","type":"User","site_admin":false},"repo":{"id":12087405,"name":"klee","full_name":"MartinNowack/klee","owner":{"login":"MartinNowack","id":2443641,"avatar_url":"https://avatars.githubusercontent.com/u/2443641?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowack","html_url":"https://github.com/MartinNowack","followers_url":"https://api.github.com/users/MartinNowack/followers","following_url":"https://api.github.com/users/MartinNowack/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowack/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowack/subscriptions","organizations_url":"https://api.github.com/users/MartinNowack/orgs","repos_url":"https://api.github.com/users/MartinNowack/repos","events_url":"https://api.github.com/users/MartinNowack/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MartinNowack/klee","description":"KLEE Symbolic Virtual Machine","fork":true,"url":"https://api.github.com/repos/MartinNowack/klee","forks_url":"https://api.github.com/repos/MartinNowack/klee/forks","keys_url":"https://api.github.com/repos/MartinNowack/klee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MartinNowack/klee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MartinNowack/klee/teams","hooks_url":"https://api.github.com/repos/MartinNowack/klee/hooks","issue_events_url":"https://api.github.com/repos/MartinNowack/klee/issues/events{/number}","events_url":"https://api.github.com/repos/MartinNowack/klee/events","assignees_url":"https://api.github.com/repos/MartinNowack/klee/assignees{/user}","branches_url":"https://api.github.com/repos/MartinNowack/klee/branches{/branch}","tags_url":"https://api.github.com/repos/MartinNowack/klee/tags","blobs_url":"https://api.github.com/repos/MartinNowack/klee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MartinNowack/klee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MartinNowack/klee/git/refs{/sha}","trees_url":"https://api.github.com/repos/MartinNowack/klee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MartinNowack/klee/statuses/{sha}","languages_url":"https://api.github.com/repos/MartinNowack/klee/languages","stargazers_url":"https://api.github.com/repos/MartinNowack/klee/stargazers","contributors_url":"https://api.github.com/repos/MartinNowack/klee/contributors","subscribers_url":"https://api.github.com/repos/MartinNowack/klee/subscribers","subscription_url":"https://api.github.com/repos/MartinNowack/klee/subscription","commits_url":"https://api.github.com/repos/MartinNowack/klee/commits{/sha}","git_commits_url":"https://api.github.com/repos/MartinNowack/klee/git/commits{/sha}","comments_url":"https://api.github.com/repos/MartinNowack/klee/comments{/number}","issue_comment_url":"https://api.github.com/repos/MartinNowack/klee/issues/comments{/number}","contents_url":"https://api.github.com/repos/MartinNowack/klee/contents/{+path}","compare_url":"https://api.github.com/repos/MartinNowack/klee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MartinNowack/klee/merges","archive_url":"https://api.github.com/repos/MartinNowack/klee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MartinNowack/klee/downloads","issues_url":"https://api.github.com/repos/MartinNowack/klee/issues{/number}","pulls_url":"https://api.github.com/repos/MartinNowack/klee/pulls{/number}","milestones_url":"https://api.github.com/repos/MartinNowack/klee/milestones{/number}","notifications_url":"https://api.github.com/repos/MartinNowack/klee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MartinNowack/klee/labels{/name}","releases_url":"https://api.github.com/repos/MartinNowack/klee/releases{/id}","deployments_url":"https://api.github.com/repos/MartinNowack/klee/deployments","created_at":"2013-08-13T17:00:13Z","updated_at":"2016-01-20T08:13:36Z","pushed_at":"2016-04-19T14:45:33Z","git_url":"git://github.com/MartinNowack/klee.git","ssh_url":"git@github.com:MartinNowack/klee.git","clone_url":"https://github.com/MartinNowack/klee.git","svn_url":"https://github.com/MartinNowack/klee","homepage":null,"size":4219,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"klee:master","ref":"master","sha":"fd96a7a39d59deb0ce7a2b983a300dc00714198c","user":{"login":"klee","id":6224192,"avatar_url":"https://avatars.githubusercontent.com/u/6224192?v=3","gravatar_id":"","url":"https://api.github.com/users/klee","html_url":"https://github.com/klee","followers_url":"https://api.github.com/users/klee/followers","following_url":"https://api.github.com/users/klee/following{/other_user}","gists_url":"https://api.github.com/users/klee/gists{/gist_id}","starred_url":"https://api.github.com/users/klee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klee/subscriptions","organizations_url":"https://api.github.com/users/klee/orgs","repos_url":"https://api.github.com/users/klee/repos","events_url":"https://api.github.com/users/klee/events{/privacy}","received_events_url":"https://api.github.com/users/klee/received_events","type":"Organization","site_admin":false},"repo":{"id":11568417,"name":"klee","full_name":"klee/klee","owner":{"login":"klee","id":6224192,"avatar_url":"https://avatars.githubusercontent.com/u/6224192?v=3","gravatar_id":"","url":"https://api.github.com/users/klee","html_url":"https://github.com/klee","followers_url":"https://api.github.com/users/klee/followers","following_url":"https://api.github.com/users/klee/following{/other_user}","gists_url":"https://api.github.com/users/klee/gists{/gist_id}","starred_url":"https://api.github.com/users/klee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klee/subscriptions","organizations_url":"https://api.github.com/users/klee/orgs","repos_url":"https://api.github.com/users/klee/repos","events_url":"https://api.github.com/users/klee/events{/privacy}","received_events_url":"https://api.github.com/users/klee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/klee/klee","description":"KLEE Symbolic Virtual Machine","fork":false,"url":"https://api.github.com/repos/klee/klee","forks_url":"https://api.github.com/repos/klee/klee/forks","keys_url":"https://api.github.com/repos/klee/klee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klee/klee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klee/klee/teams","hooks_url":"https://api.github.com/repos/klee/klee/hooks","issue_events_url":"https://api.github.com/repos/klee/klee/issues/events{/number}","events_url":"https://api.github.com/repos/klee/klee/events","assignees_url":"https://api.github.com/repos/klee/klee/assignees{/user}","branches_url":"https://api.github.com/repos/klee/klee/branches{/branch}","tags_url":"https://api.github.com/repos/klee/klee/tags","blobs_url":"https://api.github.com/repos/klee/klee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klee/klee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klee/klee/git/refs{/sha}","trees_url":"https://api.github.com/repos/klee/klee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klee/klee/statuses/{sha}","languages_url":"https://api.github.com/repos/klee/klee/languages","stargazers_url":"https://api.github.com/repos/klee/klee/stargazers","contributors_url":"https://api.github.com/repos/klee/klee/contributors","subscribers_url":"https://api.github.com/repos/klee/klee/subscribers","subscription_url":"https://api.github.com/repos/klee/klee/subscription","commits_url":"https://api.github.com/repos/klee/klee/commits{/sha}","git_commits_url":"https://api.github.com/repos/klee/klee/git/commits{/sha}","comments_url":"https://api.github.com/repos/klee/klee/comments{/number}","issue_comment_url":"https://api.github.com/repos/klee/klee/issues/comments{/number}","contents_url":"https://api.github.com/repos/klee/klee/contents/{+path}","compare_url":"https://api.github.com/repos/klee/klee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klee/klee/merges","archive_url":"https://api.github.com/repos/klee/klee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klee/klee/downloads","issues_url":"https://api.github.com/repos/klee/klee/issues{/number}","pulls_url":"https://api.github.com/repos/klee/klee/pulls{/number}","milestones_url":"https://api.github.com/repos/klee/klee/milestones{/number}","notifications_url":"https://api.github.com/repos/klee/klee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klee/klee/labels{/name}","releases_url":"https://api.github.com/repos/klee/klee/releases{/id}","deployments_url":"https://api.github.com/repos/klee/klee/deployments","created_at":"2013-07-21T22:03:03Z","updated_at":"2016-04-19T10:12:25Z","pushed_at":"2016-04-19T14:45:31Z","git_url":"git://github.com/klee/klee.git","ssh_url":"git@github.com:klee/klee.git","clone_url":"https://github.com/klee/klee.git","svn_url":"https://github.com/klee/klee","homepage":"http://klee.llvm.org","size":5117,"stargazers_count":317,"watchers_count":317,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":87,"forks":159,"open_issues":87,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/klee/klee/pulls/362"},"html":{"href":"https://github.com/klee/klee/pull/362"},"issue":{"href":"https://api.github.com/repos/klee/klee/issues/362"},"comments":{"href":"https://api.github.com/repos/klee/klee/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/klee/klee/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/klee/klee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/klee/klee/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/klee/klee/statuses/788027432b458d20146e090980a0f499ca99378d"}}}}