{"action":"created","comment":{"url":"https://api.github.com/repos/dtan4/terraforming/pulls/comments/70011272","id":70011272,"diff_hunk":"@@ -16,23 +16,23 @@ def initialize(client)\n       end\n \n       def tf\n-        apply_template(@client, \"tf/iam_instance_profile\")\n+        apply_template(@client, 'tf/iam_instance_profile')\n       end\n \n       def tfstate\n         iam_instance_profiles.inject({}) do |resources, profile|\n           attributes = {\n-            \"arn\" => profile.arn,\n-            \"id\" => profile.instance_profile_name,\n-            \"name\" => profile.instance_profile_name,\n-            \"path\" => profile.path,\n-            \"roles.#\" => profile.roles.length.to_s,\n+            'arn' => profile.arn,\n+            'id' => profile.instance_profile_name,\n+            'name' => profile.instance_profile_name,\n+            'path' => profile.path,\n+            'roles.#' => profile.roles.length.to_s,","path":"lib/terraforming/resource/iam_instance_profile.rb","position":20,"original_position":20,"commit_id":"f08f8b5b777771921f111aed671c7760e8e4d48d","original_commit_id":"f08f8b5b777771921f111aed671c7760e8e4d48d","user":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"body":"__[rubocop]__\n* Avoid comma after the last item of a hash. [:ref](https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas)","created_at":"2016-07-08T00:38:24Z","updated_at":"2016-07-08T00:38:24Z","html_url":"https://github.com/dtan4/terraforming/pull/236#discussion_r70011272","pull_request_url":"https://api.github.com/repos/dtan4/terraforming/pulls/236","_links":{"self":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/comments/70011272"},"html":{"href":"https://github.com/dtan4/terraforming/pull/236#discussion_r70011272"},"pull_request":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/dtan4/terraforming/pulls/236","id":74702344,"html_url":"https://github.com/dtan4/terraforming/pull/236","diff_url":"https://github.com/dtan4/terraforming/pull/236.diff","patch_url":"https://github.com/dtan4/terraforming/pull/236.patch","issue_url":"https://api.github.com/repos/dtan4/terraforming/issues/236","number":236,"state":"open","locked":false,"title":"add pagination to iam_ resources","user":{"login":"philsnow","id":297781,"avatar_url":"https://avatars.githubusercontent.com/u/297781?v=3","gravatar_id":"","url":"https://api.github.com/users/philsnow","html_url":"https://github.com/philsnow","followers_url":"https://api.github.com/users/philsnow/followers","following_url":"https://api.github.com/users/philsnow/following{/other_user}","gists_url":"https://api.github.com/users/philsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/philsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsnow/subscriptions","organizations_url":"https://api.github.com/users/philsnow/orgs","repos_url":"https://api.github.com/users/philsnow/repos","events_url":"https://api.github.com/users/philsnow/events{/privacy}","received_events_url":"https://api.github.com/users/philsnow/received_events","type":"User","site_admin":false},"body":"The resources API has a super clean way of enumerating without tons of\r\nboilerplate `while resp.is_truncated` loops.\r\n\r\nI only did this for a few resource types because I wanted to check in with @dtan4 about using the resources API and didn't want to do the same work x20 if it's not mergeable.","created_at":"2016-06-21T23:25:19Z","updated_at":"2016-07-08T00:38:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dde7eb8cf971aff863a0a47c7905c2fda0020f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dtan4/terraforming/pulls/236/commits","review_comments_url":"https://api.github.com/repos/dtan4/terraforming/pulls/236/comments","review_comment_url":"https://api.github.com/repos/dtan4/terraforming/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dtan4/terraforming/issues/236/comments","statuses_url":"https://api.github.com/repos/dtan4/terraforming/statuses/f08f8b5b777771921f111aed671c7760e8e4d48d","head":{"label":"philsnow:philsnow/pagination","ref":"philsnow/pagination","sha":"f08f8b5b777771921f111aed671c7760e8e4d48d","user":{"login":"philsnow","id":297781,"avatar_url":"https://avatars.githubusercontent.com/u/297781?v=3","gravatar_id":"","url":"https://api.github.com/users/philsnow","html_url":"https://github.com/philsnow","followers_url":"https://api.github.com/users/philsnow/followers","following_url":"https://api.github.com/users/philsnow/following{/other_user}","gists_url":"https://api.github.com/users/philsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/philsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsnow/subscriptions","organizations_url":"https://api.github.com/users/philsnow/orgs","repos_url":"https://api.github.com/users/philsnow/repos","events_url":"https://api.github.com/users/philsnow/events{/privacy}","received_events_url":"https://api.github.com/users/philsnow/received_events","type":"User","site_admin":false},"repo":{"id":61673864,"name":"terraforming","full_name":"philsnow/terraforming","owner":{"login":"philsnow","id":297781,"avatar_url":"https://avatars.githubusercontent.com/u/297781?v=3","gravatar_id":"","url":"https://api.github.com/users/philsnow","html_url":"https://github.com/philsnow","followers_url":"https://api.github.com/users/philsnow/followers","following_url":"https://api.github.com/users/philsnow/following{/other_user}","gists_url":"https://api.github.com/users/philsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/philsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsnow/subscriptions","organizations_url":"https://api.github.com/users/philsnow/orgs","repos_url":"https://api.github.com/users/philsnow/repos","events_url":"https://api.github.com/users/philsnow/events{/privacy}","received_events_url":"https://api.github.com/users/philsnow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philsnow/terraforming","description":"Export existing AWS resources to Terraform style (tf, tfstate)","fork":true,"url":"https://api.github.com/repos/philsnow/terraforming","forks_url":"https://api.github.com/repos/philsnow/terraforming/forks","keys_url":"https://api.github.com/repos/philsnow/terraforming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philsnow/terraforming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philsnow/terraforming/teams","hooks_url":"https://api.github.com/repos/philsnow/terraforming/hooks","issue_events_url":"https://api.github.com/repos/philsnow/terraforming/issues/events{/number}","events_url":"https://api.github.com/repos/philsnow/terraforming/events","assignees_url":"https://api.github.com/repos/philsnow/terraforming/assignees{/user}","branches_url":"https://api.github.com/repos/philsnow/terraforming/branches{/branch}","tags_url":"https://api.github.com/repos/philsnow/terraforming/tags","blobs_url":"https://api.github.com/repos/philsnow/terraforming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philsnow/terraforming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philsnow/terraforming/git/refs{/sha}","trees_url":"https://api.github.com/repos/philsnow/terraforming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philsnow/terraforming/statuses/{sha}","languages_url":"https://api.github.com/repos/philsnow/terraforming/languages","stargazers_url":"https://api.github.com/repos/philsnow/terraforming/stargazers","contributors_url":"https://api.github.com/repos/philsnow/terraforming/contributors","subscribers_url":"https://api.github.com/repos/philsnow/terraforming/subscribers","subscription_url":"https://api.github.com/repos/philsnow/terraforming/subscription","commits_url":"https://api.github.com/repos/philsnow/terraforming/commits{/sha}","git_commits_url":"https://api.github.com/repos/philsnow/terraforming/git/commits{/sha}","comments_url":"https://api.github.com/repos/philsnow/terraforming/comments{/number}","issue_comment_url":"https://api.github.com/repos/philsnow/terraforming/issues/comments{/number}","contents_url":"https://api.github.com/repos/philsnow/terraforming/contents/{+path}","compare_url":"https://api.github.com/repos/philsnow/terraforming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philsnow/terraforming/merges","archive_url":"https://api.github.com/repos/philsnow/terraforming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philsnow/terraforming/downloads","issues_url":"https://api.github.com/repos/philsnow/terraforming/issues{/number}","pulls_url":"https://api.github.com/repos/philsnow/terraforming/pulls{/number}","milestones_url":"https://api.github.com/repos/philsnow/terraforming/milestones{/number}","notifications_url":"https://api.github.com/repos/philsnow/terraforming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philsnow/terraforming/labels{/name}","releases_url":"https://api.github.com/repos/philsnow/terraforming/releases{/id}","deployments_url":"https://api.github.com/repos/philsnow/terraforming/deployments","created_at":"2016-06-21T23:22:45Z","updated_at":"2016-06-21T23:22:46Z","pushed_at":"2016-07-08T00:29:53Z","git_url":"git://github.com/philsnow/terraforming.git","ssh_url":"git@github.com:philsnow/terraforming.git","clone_url":"https://github.com/philsnow/terraforming.git","svn_url":"https://github.com/philsnow/terraforming","homepage":"http://terraforming.dtan4.net/","size":789,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dtan4:master","ref":"master","sha":"e049e0077d5671f4bcca1a5a1050b37422748eda","user":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"repo":{"id":32841259,"name":"terraforming","full_name":"dtan4/terraforming","owner":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtan4/terraforming","description":"Export existing AWS resources to Terraform style (tf, tfstate)","fork":false,"url":"https://api.github.com/repos/dtan4/terraforming","forks_url":"https://api.github.com/repos/dtan4/terraforming/forks","keys_url":"https://api.github.com/repos/dtan4/terraforming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtan4/terraforming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtan4/terraforming/teams","hooks_url":"https://api.github.com/repos/dtan4/terraforming/hooks","issue_events_url":"https://api.github.com/repos/dtan4/terraforming/issues/events{/number}","events_url":"https://api.github.com/repos/dtan4/terraforming/events","assignees_url":"https://api.github.com/repos/dtan4/terraforming/assignees{/user}","branches_url":"https://api.github.com/repos/dtan4/terraforming/branches{/branch}","tags_url":"https://api.github.com/repos/dtan4/terraforming/tags","blobs_url":"https://api.github.com/repos/dtan4/terraforming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtan4/terraforming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtan4/terraforming/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtan4/terraforming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtan4/terraforming/statuses/{sha}","languages_url":"https://api.github.com/repos/dtan4/terraforming/languages","stargazers_url":"https://api.github.com/repos/dtan4/terraforming/stargazers","contributors_url":"https://api.github.com/repos/dtan4/terraforming/contributors","subscribers_url":"https://api.github.com/repos/dtan4/terraforming/subscribers","subscription_url":"https://api.github.com/repos/dtan4/terraforming/subscription","commits_url":"https://api.github.com/repos/dtan4/terraforming/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtan4/terraforming/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtan4/terraforming/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtan4/terraforming/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtan4/terraforming/contents/{+path}","compare_url":"https://api.github.com/repos/dtan4/terraforming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtan4/terraforming/merges","archive_url":"https://api.github.com/repos/dtan4/terraforming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtan4/terraforming/downloads","issues_url":"https://api.github.com/repos/dtan4/terraforming/issues{/number}","pulls_url":"https://api.github.com/repos/dtan4/terraforming/pulls{/number}","milestones_url":"https://api.github.com/repos/dtan4/terraforming/milestones{/number}","notifications_url":"https://api.github.com/repos/dtan4/terraforming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtan4/terraforming/labels{/name}","releases_url":"https://api.github.com/repos/dtan4/terraforming/releases{/id}","deployments_url":"https://api.github.com/repos/dtan4/terraforming/deployments","created_at":"2015-03-25T03:50:06Z","updated_at":"2016-07-07T10:28:18Z","pushed_at":"2016-07-08T00:29:54Z","git_url":"git://github.com/dtan4/terraforming.git","ssh_url":"git@github.com:dtan4/terraforming.git","clone_url":"https://github.com/dtan4/terraforming.git","svn_url":"https://github.com/dtan4/terraforming","homepage":"http://terraforming.dtan4.net/","size":850,"stargazers_count":619,"watchers_count":619,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":34,"forks":95,"open_issues":34,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236"},"html":{"href":"https://github.com/dtan4/terraforming/pull/236"},"issue":{"href":"https://api.github.com/repos/dtan4/terraforming/issues/236"},"comments":{"href":"https://api.github.com/repos/dtan4/terraforming/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/dtan4/terraforming/statuses/f08f8b5b777771921f111aed671c7760e8e4d48d"}}}}
{"actor":{"display_login":"dtan4"}}