{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments/93816550","pull_request_review_id":14352953,"id":93816550,"diff_hunk":"@@ -425,13 +436,17 @@ int SPIDevObj::setBusFrequency(DevHandle &h, SPI_FREQUENCY freq_hz)\n \n int SPIDevObj::_setBusFrequency(SPI_FREQUENCY freq_hz)\n {\n-#if defined(__DF_RPI)\n+#if defined(__DF_RPI) || defined(__DF_BEBOP)\n \n \t/* implement sensor interface via rpi spi */\n \t// RPI rounds down freq_hz to powers of 2\n \t// Speeds available: 0.5, 1, 2, 4, 8, 16, and 32 MHz","path":"framework/src/SPIDevObj.cpp","position":124,"original_position":124,"commit_id":"1ac804509a80b0bb9ba26ad691e85f0e7d9e20f4","original_commit_id":"1ac804509a80b0bb9ba26ad691e85f0e7d9e20f4","user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars.githubusercontent.com/u/1419688?v=3","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"body":"The comment is now outdated, or even was before.","created_at":"2016-12-24T12:11:32Z","updated_at":"2016-12-24T12:11:53Z","html_url":"https://github.com/PX4/DriverFramework/pull/167#discussion_r93816550","pull_request_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments/93816550"},"html":{"href":"https://github.com/PX4/DriverFramework/pull/167#discussion_r93816550"},"pull_request":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/DriverFramework/pulls/167","id":99015598,"html_url":"https://github.com/PX4/DriverFramework/pull/167","diff_url":"https://github.com/PX4/DriverFramework/pull/167.diff","patch_url":"https://github.com/PX4/DriverFramework/pull/167.patch","issue_url":"https://api.github.com/repos/PX4/DriverFramework/issues/167","number":167,"state":"open","locked":false,"title":"WIP: Driver for Bebop 2 ultrasonic rangefinder","user":{"login":"eyeam3","id":1187162,"avatar_url":"https://avatars.githubusercontent.com/u/1187162?v=3","gravatar_id":"","url":"https://api.github.com/users/eyeam3","html_url":"https://github.com/eyeam3","followers_url":"https://api.github.com/users/eyeam3/followers","following_url":"https://api.github.com/users/eyeam3/following{/other_user}","gists_url":"https://api.github.com/users/eyeam3/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeam3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeam3/subscriptions","organizations_url":"https://api.github.com/users/eyeam3/orgs","repos_url":"https://api.github.com/users/eyeam3/repos","events_url":"https://api.github.com/users/eyeam3/events{/privacy}","received_events_url":"https://api.github.com/users/eyeam3/received_events","type":"User","site_admin":false},"body":"This PR adds a driver for the ultrasonic rangefinder on Parrot Bebop 2. It includes a basic IIO implementation and the sensor interfacing.\r\n\r\nThe driver is basically finished but marked as WIP because it was not tested in flight due to integration issues in the PX4 firmware. See PX4/Firmware#6126.","created_at":"2016-12-21T22:23:04Z","updated_at":"2016-12-24T12:11:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4514b2ad112eb8bd4e7a600c36c7aa876f488c0e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/167/commits","review_comments_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/167/comments","review_comment_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/DriverFramework/issues/167/comments","statuses_url":"https://api.github.com/repos/PX4/DriverFramework/statuses/1ac804509a80b0bb9ba26ad691e85f0e7d9e20f4","head":{"label":"eyeam3:driver_bebop_rangefinder","ref":"driver_bebop_rangefinder","sha":"1ac804509a80b0bb9ba26ad691e85f0e7d9e20f4","user":{"login":"eyeam3","id":1187162,"avatar_url":"https://avatars.githubusercontent.com/u/1187162?v=3","gravatar_id":"","url":"https://api.github.com/users/eyeam3","html_url":"https://github.com/eyeam3","followers_url":"https://api.github.com/users/eyeam3/followers","following_url":"https://api.github.com/users/eyeam3/following{/other_user}","gists_url":"https://api.github.com/users/eyeam3/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeam3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeam3/subscriptions","organizations_url":"https://api.github.com/users/eyeam3/orgs","repos_url":"https://api.github.com/users/eyeam3/repos","events_url":"https://api.github.com/users/eyeam3/events{/privacy}","received_events_url":"https://api.github.com/users/eyeam3/received_events","type":"User","site_admin":false},"repo":{"id":61476418,"name":"DriverFramework","full_name":"eyeam3/DriverFramework","owner":{"login":"eyeam3","id":1187162,"avatar_url":"https://avatars.githubusercontent.com/u/1187162?v=3","gravatar_id":"","url":"https://api.github.com/users/eyeam3","html_url":"https://github.com/eyeam3","followers_url":"https://api.github.com/users/eyeam3/followers","following_url":"https://api.github.com/users/eyeam3/following{/other_user}","gists_url":"https://api.github.com/users/eyeam3/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeam3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeam3/subscriptions","organizations_url":"https://api.github.com/users/eyeam3/orgs","repos_url":"https://api.github.com/users/eyeam3/repos","events_url":"https://api.github.com/users/eyeam3/events{/privacy}","received_events_url":"https://api.github.com/users/eyeam3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eyeam3/DriverFramework","description":"Operating system and flight stack agnostic driver framework for POSIX (Linux, NuttX, Mac OS, QNX, VxWorks).","fork":true,"url":"https://api.github.com/repos/eyeam3/DriverFramework","forks_url":"https://api.github.com/repos/eyeam3/DriverFramework/forks","keys_url":"https://api.github.com/repos/eyeam3/DriverFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eyeam3/DriverFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eyeam3/DriverFramework/teams","hooks_url":"https://api.github.com/repos/eyeam3/DriverFramework/hooks","issue_events_url":"https://api.github.com/repos/eyeam3/DriverFramework/issues/events{/number}","events_url":"https://api.github.com/repos/eyeam3/DriverFramework/events","assignees_url":"https://api.github.com/repos/eyeam3/DriverFramework/assignees{/user}","branches_url":"https://api.github.com/repos/eyeam3/DriverFramework/branches{/branch}","tags_url":"https://api.github.com/repos/eyeam3/DriverFramework/tags","blobs_url":"https://api.github.com/repos/eyeam3/DriverFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eyeam3/DriverFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eyeam3/DriverFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/eyeam3/DriverFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eyeam3/DriverFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/eyeam3/DriverFramework/languages","stargazers_url":"https://api.github.com/repos/eyeam3/DriverFramework/stargazers","contributors_url":"https://api.github.com/repos/eyeam3/DriverFramework/contributors","subscribers_url":"https://api.github.com/repos/eyeam3/DriverFramework/subscribers","subscription_url":"https://api.github.com/repos/eyeam3/DriverFramework/subscription","commits_url":"https://api.github.com/repos/eyeam3/DriverFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/eyeam3/DriverFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/eyeam3/DriverFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/eyeam3/DriverFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/eyeam3/DriverFramework/contents/{+path}","compare_url":"https://api.github.com/repos/eyeam3/DriverFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eyeam3/DriverFramework/merges","archive_url":"https://api.github.com/repos/eyeam3/DriverFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eyeam3/DriverFramework/downloads","issues_url":"https://api.github.com/repos/eyeam3/DriverFramework/issues{/number}","pulls_url":"https://api.github.com/repos/eyeam3/DriverFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/eyeam3/DriverFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/eyeam3/DriverFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eyeam3/DriverFramework/labels{/name}","releases_url":"https://api.github.com/repos/eyeam3/DriverFramework/releases{/id}","deployments_url":"https://api.github.com/repos/eyeam3/DriverFramework/deployments","created_at":"2016-06-19T11:10:00Z","updated_at":"2016-06-19T11:10:01Z","pushed_at":"2016-12-21T22:20:29Z","git_url":"git://github.com/eyeam3/DriverFramework.git","ssh_url":"git@github.com:eyeam3/DriverFramework.git","clone_url":"https://github.com/eyeam3/DriverFramework.git","svn_url":"https://github.com/eyeam3/DriverFramework","homepage":"","size":776,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"60599774544343fb0a51913bcbb38fe0188ac1c4","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":45463028,"name":"DriverFramework","full_name":"PX4/DriverFramework","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/DriverFramework","description":"Operating system and flight stack agnostic driver framework for POSIX (Linux, NuttX, Mac OS, QNX, VxWorks).","fork":false,"url":"https://api.github.com/repos/PX4/DriverFramework","forks_url":"https://api.github.com/repos/PX4/DriverFramework/forks","keys_url":"https://api.github.com/repos/PX4/DriverFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/DriverFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/DriverFramework/teams","hooks_url":"https://api.github.com/repos/PX4/DriverFramework/hooks","issue_events_url":"https://api.github.com/repos/PX4/DriverFramework/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/DriverFramework/events","assignees_url":"https://api.github.com/repos/PX4/DriverFramework/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/DriverFramework/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/DriverFramework/tags","blobs_url":"https://api.github.com/repos/PX4/DriverFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/DriverFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/DriverFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/DriverFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/DriverFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/DriverFramework/languages","stargazers_url":"https://api.github.com/repos/PX4/DriverFramework/stargazers","contributors_url":"https://api.github.com/repos/PX4/DriverFramework/contributors","subscribers_url":"https://api.github.com/repos/PX4/DriverFramework/subscribers","subscription_url":"https://api.github.com/repos/PX4/DriverFramework/subscription","commits_url":"https://api.github.com/repos/PX4/DriverFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/DriverFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/DriverFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/DriverFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/DriverFramework/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/DriverFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/DriverFramework/merges","archive_url":"https://api.github.com/repos/PX4/DriverFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/DriverFramework/downloads","issues_url":"https://api.github.com/repos/PX4/DriverFramework/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/DriverFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/DriverFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/DriverFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/DriverFramework/labels{/name}","releases_url":"https://api.github.com/repos/PX4/DriverFramework/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/DriverFramework/deployments","created_at":"2015-11-03T11:49:29Z","updated_at":"2016-11-05T11:33:11Z","pushed_at":"2016-12-24T12:10:58Z","git_url":"git://github.com/PX4/DriverFramework.git","ssh_url":"git@github.com:PX4/DriverFramework.git","clone_url":"https://github.com/PX4/DriverFramework.git","svn_url":"https://github.com/PX4/DriverFramework","homepage":"","size":765,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":15,"forks":47,"open_issues":15,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/167"},"html":{"href":"https://github.com/PX4/DriverFramework/pull/167"},"issue":{"href":"https://api.github.com/repos/PX4/DriverFramework/issues/167"},"comments":{"href":"https://api.github.com/repos/PX4/DriverFramework/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/DriverFramework/statuses/1ac804509a80b0bb9ba26ad691e85f0e7d9e20f4"}}}}
{"actor":{"display_login":"julianoes"}}