{"action":"created","comment":{"url":"https://api.github.com/repos/fusor/fusor/pulls/comments/61751423","id":61751423,"diff_hunk":"@@ -184,6 +191,25 @@ def apply_deployment_parameter_overrides(hostgroup, deployment, product_type, pu\n         # unclear which one the deployment attribute is associated with\n         # :name => , :value => deployment.rhev_storage_type,\n \n+        # Self-hosted and standard have two different ways they want the cpu type\n+        # https://github.com/oVirt/ovirt-hosted-engine-setup/blob/master/src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py#L50\n+        self_hosted_cpu_map = {\n+          'Intel Broadwell Family' => 'model_Broadwell',\n+          'Intel Conroe Family' => 'model_Conroe',\n+          'Intel Penryn Family' => 'model_Penryn',\n+          'Intel Nehalem Family' => 'model_Nehalem',\n+          'Intel Westmere Family' => 'model_Westmere',\n+          'Intel SandyBridge Family' => 'model_SandyBridge',\n+          'Intel Haswell' => 'model_Haswell',\n+          'AMD Opteron G1' => 'model_Opteron_G1',\n+          'AMD Opteron G2' => 'model_Opteron_G2',\n+          'AMD Opteron G3' => 'model_Opteron_G3',\n+          'AMD Opteron G4' => 'model_Opteron_G4',\n+          'AMD Opteron G5' => 'model_Opteron_G5',\n+          # 'IBM POWER 8' => 'UNSUPPORTED',\n+        }\n+\n+        # TODO(fabianvf): Add overrides for rhev-self-hosted","path":"server/app/lib/actions/fusor/configure_host_groups.rb","position":38,"original_position":38,"commit_id":"1ede17c7112986839bd3de0765ad9c7667c97481","original_commit_id":"1ede17c7112986839bd3de0765ad9c7667c97481","user":{"login":"fabianvf","id":2431974,"avatar_url":"https://avatars.githubusercontent.com/u/2431974?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianvf","html_url":"https://github.com/fabianvf","followers_url":"https://api.github.com/users/fabianvf/followers","following_url":"https://api.github.com/users/fabianvf/following{/other_user}","gists_url":"https://api.github.com/users/fabianvf/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianvf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianvf/subscriptions","organizations_url":"https://api.github.com/users/fabianvf/orgs","repos_url":"https://api.github.com/users/fabianvf/repos","events_url":"https://api.github.com/users/fabianvf/events{/privacy}","received_events_url":"https://api.github.com/users/fabianvf/received_events","type":"User","site_admin":false},"body":"Remove TODOs that are done","created_at":"2016-05-02T15:08:20Z","updated_at":"2016-05-02T15:08:20Z","html_url":"https://github.com/fusor/fusor/pull/801#discussion_r61751423","pull_request_url":"https://api.github.com/repos/fusor/fusor/pulls/801","_links":{"self":{"href":"https://api.github.com/repos/fusor/fusor/pulls/comments/61751423"},"html":{"href":"https://github.com/fusor/fusor/pull/801#discussion_r61751423"},"pull_request":{"href":"https://api.github.com/repos/fusor/fusor/pulls/801"}}},"pull_request":{"url":"https://api.github.com/repos/fusor/fusor/pulls/801","id":68571137,"html_url":"https://github.com/fusor/fusor/pull/801","diff_url":"https://github.com/fusor/fusor/pull/801.diff","patch_url":"https://github.com/fusor/fusor/pull/801.patch","issue_url":"https://api.github.com/repos/fusor/fusor/issues/801","number":801,"state":"open","locked":false,"title":"Add Rhev-self-hosted","user":{"login":"fabianvf","id":2431974,"avatar_url":"https://avatars.githubusercontent.com/u/2431974?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianvf","html_url":"https://github.com/fabianvf","followers_url":"https://api.github.com/users/fabianvf/followers","following_url":"https://api.github.com/users/fabianvf/following{/other_user}","gists_url":"https://api.github.com/users/fabianvf/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianvf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianvf/subscriptions","organizations_url":"https://api.github.com/users/fabianvf/orgs","repos_url":"https://api.github.com/users/fabianvf/repos","events_url":"https://api.github.com/users/fabianvf/events{/privacy}","received_events_url":"https://api.github.com/users/fabianvf/received_events","type":"User","site_admin":false},"body":"* restructure RHEV deploy logic\r\n* update partition logic to accept partition tables specified in the fusor.yaml\r\n* enable self-hosted ui components\r\n* create a host record used by the self-hosted engine\r\n* use host.ip instead of host.facts['ipaddress']\r\n* add self-hosted storage variables\r\n* add self-hosted parameter overrides and puppetclasses\r\n* add utility method for generating mac addresses\r\n* Add some explicit failures/exceptions for puppet related errors\r\n* various other changes related to self-hosted feature\r\n\r\nRelated PRs: \r\n - https://gitlab.sat.lab.tlv.redhat.com/rhci/puppet-ovirt/merge_requests/16\r\n - https://github.com/fusor/fusor-installer/pull/57","created_at":"2016-05-02T14:56:59Z","updated_at":"2016-05-02T15:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f4b37a7ce5a6be42281e3a6b2fa91fd6d63527d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fusor/fusor/pulls/801/commits","review_comments_url":"https://api.github.com/repos/fusor/fusor/pulls/801/comments","review_comment_url":"https://api.github.com/repos/fusor/fusor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fusor/fusor/issues/801/comments","statuses_url":"https://api.github.com/repos/fusor/fusor/statuses/1ede17c7112986839bd3de0765ad9c7667c97481","head":{"label":"fabianvf:self-hosted-merge","ref":"self-hosted-merge","sha":"1ede17c7112986839bd3de0765ad9c7667c97481","user":{"login":"fabianvf","id":2431974,"avatar_url":"https://avatars.githubusercontent.com/u/2431974?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianvf","html_url":"https://github.com/fabianvf","followers_url":"https://api.github.com/users/fabianvf/followers","following_url":"https://api.github.com/users/fabianvf/following{/other_user}","gists_url":"https://api.github.com/users/fabianvf/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianvf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianvf/subscriptions","organizations_url":"https://api.github.com/users/fabianvf/orgs","repos_url":"https://api.github.com/users/fabianvf/repos","events_url":"https://api.github.com/users/fabianvf/events{/privacy}","received_events_url":"https://api.github.com/users/fabianvf/received_events","type":"User","site_admin":false},"repo":{"id":50210173,"name":"fusor","full_name":"fabianvf/fusor","owner":{"login":"fabianvf","id":2431974,"avatar_url":"https://avatars.githubusercontent.com/u/2431974?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianvf","html_url":"https://github.com/fabianvf","followers_url":"https://api.github.com/users/fabianvf/followers","following_url":"https://api.github.com/users/fabianvf/following{/other_user}","gists_url":"https://api.github.com/users/fabianvf/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianvf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianvf/subscriptions","organizations_url":"https://api.github.com/users/fabianvf/orgs","repos_url":"https://api.github.com/users/fabianvf/repos","events_url":"https://api.github.com/users/fabianvf/events{/privacy}","received_events_url":"https://api.github.com/users/fabianvf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabianvf/fusor","description":"","fork":true,"url":"https://api.github.com/repos/fabianvf/fusor","forks_url":"https://api.github.com/repos/fabianvf/fusor/forks","keys_url":"https://api.github.com/repos/fabianvf/fusor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabianvf/fusor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabianvf/fusor/teams","hooks_url":"https://api.github.com/repos/fabianvf/fusor/hooks","issue_events_url":"https://api.github.com/repos/fabianvf/fusor/issues/events{/number}","events_url":"https://api.github.com/repos/fabianvf/fusor/events","assignees_url":"https://api.github.com/repos/fabianvf/fusor/assignees{/user}","branches_url":"https://api.github.com/repos/fabianvf/fusor/branches{/branch}","tags_url":"https://api.github.com/repos/fabianvf/fusor/tags","blobs_url":"https://api.github.com/repos/fabianvf/fusor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabianvf/fusor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabianvf/fusor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabianvf/fusor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabianvf/fusor/statuses/{sha}","languages_url":"https://api.github.com/repos/fabianvf/fusor/languages","stargazers_url":"https://api.github.com/repos/fabianvf/fusor/stargazers","contributors_url":"https://api.github.com/repos/fabianvf/fusor/contributors","subscribers_url":"https://api.github.com/repos/fabianvf/fusor/subscribers","subscription_url":"https://api.github.com/repos/fabianvf/fusor/subscription","commits_url":"https://api.github.com/repos/fabianvf/fusor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabianvf/fusor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabianvf/fusor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabianvf/fusor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabianvf/fusor/contents/{+path}","compare_url":"https://api.github.com/repos/fabianvf/fusor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabianvf/fusor/merges","archive_url":"https://api.github.com/repos/fabianvf/fusor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabianvf/fusor/downloads","issues_url":"https://api.github.com/repos/fabianvf/fusor/issues{/number}","pulls_url":"https://api.github.com/repos/fabianvf/fusor/pulls{/number}","milestones_url":"https://api.github.com/repos/fabianvf/fusor/milestones{/number}","notifications_url":"https://api.github.com/repos/fabianvf/fusor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabianvf/fusor/labels{/name}","releases_url":"https://api.github.com/repos/fabianvf/fusor/releases{/id}","deployments_url":"https://api.github.com/repos/fabianvf/fusor/deployments","created_at":"2016-01-22T22:01:03Z","updated_at":"2016-01-22T22:01:05Z","pushed_at":"2016-05-02T14:27:45Z","git_url":"git://github.com/fabianvf/fusor.git","ssh_url":"git@github.com:fabianvf/fusor.git","clone_url":"https://github.com/fabianvf/fusor.git","svn_url":"https://github.com/fabianvf/fusor","homepage":null,"size":34547,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fusor:master","ref":"master","sha":"1be401cc205fe00f74f9724d39cac693e147112b","user":{"login":"fusor","id":9267379,"avatar_url":"https://avatars.githubusercontent.com/u/9267379?v=3","gravatar_id":"","url":"https://api.github.com/users/fusor","html_url":"https://github.com/fusor","followers_url":"https://api.github.com/users/fusor/followers","following_url":"https://api.github.com/users/fusor/following{/other_user}","gists_url":"https://api.github.com/users/fusor/gists{/gist_id}","starred_url":"https://api.github.com/users/fusor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusor/subscriptions","organizations_url":"https://api.github.com/users/fusor/orgs","repos_url":"https://api.github.com/users/fusor/repos","events_url":"https://api.github.com/users/fusor/events{/privacy}","received_events_url":"https://api.github.com/users/fusor/received_events","type":"Organization","site_admin":false},"repo":{"id":25686301,"name":"fusor","full_name":"fusor/fusor","owner":{"login":"fusor","id":9267379,"avatar_url":"https://avatars.githubusercontent.com/u/9267379?v=3","gravatar_id":"","url":"https://api.github.com/users/fusor","html_url":"https://github.com/fusor","followers_url":"https://api.github.com/users/fusor/followers","following_url":"https://api.github.com/users/fusor/following{/other_user}","gists_url":"https://api.github.com/users/fusor/gists{/gist_id}","starred_url":"https://api.github.com/users/fusor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusor/subscriptions","organizations_url":"https://api.github.com/users/fusor/orgs","repos_url":"https://api.github.com/users/fusor/repos","events_url":"https://api.github.com/users/fusor/events{/privacy}","received_events_url":"https://api.github.com/users/fusor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fusor/fusor","description":"","fork":false,"url":"https://api.github.com/repos/fusor/fusor","forks_url":"https://api.github.com/repos/fusor/fusor/forks","keys_url":"https://api.github.com/repos/fusor/fusor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fusor/fusor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fusor/fusor/teams","hooks_url":"https://api.github.com/repos/fusor/fusor/hooks","issue_events_url":"https://api.github.com/repos/fusor/fusor/issues/events{/number}","events_url":"https://api.github.com/repos/fusor/fusor/events","assignees_url":"https://api.github.com/repos/fusor/fusor/assignees{/user}","branches_url":"https://api.github.com/repos/fusor/fusor/branches{/branch}","tags_url":"https://api.github.com/repos/fusor/fusor/tags","blobs_url":"https://api.github.com/repos/fusor/fusor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fusor/fusor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fusor/fusor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fusor/fusor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fusor/fusor/statuses/{sha}","languages_url":"https://api.github.com/repos/fusor/fusor/languages","stargazers_url":"https://api.github.com/repos/fusor/fusor/stargazers","contributors_url":"https://api.github.com/repos/fusor/fusor/contributors","subscribers_url":"https://api.github.com/repos/fusor/fusor/subscribers","subscription_url":"https://api.github.com/repos/fusor/fusor/subscription","commits_url":"https://api.github.com/repos/fusor/fusor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fusor/fusor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fusor/fusor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fusor/fusor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fusor/fusor/contents/{+path}","compare_url":"https://api.github.com/repos/fusor/fusor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fusor/fusor/merges","archive_url":"https://api.github.com/repos/fusor/fusor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fusor/fusor/downloads","issues_url":"https://api.github.com/repos/fusor/fusor/issues{/number}","pulls_url":"https://api.github.com/repos/fusor/fusor/pulls{/number}","milestones_url":"https://api.github.com/repos/fusor/fusor/milestones{/number}","notifications_url":"https://api.github.com/repos/fusor/fusor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fusor/fusor/labels{/name}","releases_url":"https://api.github.com/repos/fusor/fusor/releases{/id}","deployments_url":"https://api.github.com/repos/fusor/fusor/deployments","created_at":"2014-10-24T11:57:40Z","updated_at":"2016-04-22T01:21:14Z","pushed_at":"2016-05-02T14:56:59Z","git_url":"git://github.com/fusor/fusor.git","ssh_url":"git@github.com:fusor/fusor.git","clone_url":"https://github.com/fusor/fusor.git","svn_url":"https://github.com/fusor/fusor","homepage":null,"size":36701,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":5,"forks":23,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fusor/fusor/pulls/801"},"html":{"href":"https://github.com/fusor/fusor/pull/801"},"issue":{"href":"https://api.github.com/repos/fusor/fusor/issues/801"},"comments":{"href":"https://api.github.com/repos/fusor/fusor/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/fusor/fusor/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/fusor/fusor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fusor/fusor/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/fusor/fusor/statuses/1ede17c7112986839bd3de0765ad9c7667c97481"}}}}