{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/13428","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/13428/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13428/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/13428/events","html_url":"https://github.com/edx/edx-platform/pull/13428","id":175865244,"number":13428,"title":"Replace discussion topic selector with a native dropdown","user":{"login":"bjacobel","id":407639,"avatar_url":"https://avatars.githubusercontent.com/u/407639?v=3","gravatar_id":"","url":"https://api.github.com/users/bjacobel","html_url":"https://github.com/bjacobel","followers_url":"https://api.github.com/users/bjacobel/followers","following_url":"https://api.github.com/users/bjacobel/following{/other_user}","gists_url":"https://api.github.com/users/bjacobel/gists{/gist_id}","starred_url":"https://api.github.com/users/bjacobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjacobel/subscriptions","organizations_url":"https://api.github.com/users/bjacobel/orgs","repos_url":"https://api.github.com/users/bjacobel/repos","events_url":"https://api.github.com/users/bjacobel/events{/privacy}","received_events_url":"https://api.github.com/users/bjacobel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-08T21:09:38Z","updated_at":"2016-09-14T16:52:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13428","html_url":"https://github.com/edx/edx-platform/pull/13428","diff_url":"https://github.com/edx/edx-platform/pull/13428.diff","patch_url":"https://github.com/edx/edx-platform/pull/13428.patch"},"body":"### Description\r\n \r\n[TNL-5165](https://openedx.atlassian.net/browse/TNL-5165)\r\n\r\nWhat's new:\r\n- Filtering of discussion topics is gone completely.\r\n- If your course has a topic named \"General\", the new post form will preselect that topic. Otherwise, the first topic (alphabetically) of the first topic group (alphabetically) will be selected.\r\n- Topic dropdown is now a native dropdown, no longer a custom element. Styling matches the existing cohort selector dropdown (we plan to update both of these dropdown styles to match Pattern Library once Teams and courseware support it).\r\n\r\n![](https://i.bjacobel.com/20160912-dnun1.png)\r\n![](https://i.bjacobel.com/20160912-4dubd.png)\r\n\r\n### Sandbox\r\n- [x] https://bjacobel.sandbox.edx.org\r\n\r\n### Testing\r\n- [ ] i18n\r\n- [ ] RTL\r\n- [ ] safecommit violation code review process\r\n- [ ] Unit, integration, acceptance tests as appropriate\r\n- [ ] Analytics\r\n- [ ] Performance\r\n- [ ] Database migrations are backwards-compatible\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @alisan617 \r\n- [x] Code review: @andy-armstrong \r\n- [x] Doc Review: @catong \r\n- [ ] Accessibility review: @edx/edx-accessibility \r\n- [x] Product review: @marcotuts \r\n\r\nFYI: Tag anyone who might be interested in this PR here.\r\n\r\n### Post-review\r\n- [ ] Rebase and squash commits #"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/247079195","html_url":"https://github.com/edx/edx-platform/pull/13428#issuecomment-247079195","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13428","id":247079195,"user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T16:52:23Z","updated_at":"2016-09-14T16:52:23Z","body":"👍  thanks for addressing my feedback.\r\n\r\nI remember there was a discussion about the border around the Title input looking off. What was the conclusion there? It would be great to fix this in one of these PRs as it looks ugly currently.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/5985072/18521429/11d18efc-7a7a-11e6-845b-584119b41acf.png)\r\n\r\n"}}
{"actor":{"display_login":"andy-armstrong"}}