{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48988935","id":48988935,"diff_hunk":"@@ -2,7 +2,8 @@ class ChargebackRateDetail < ActiveRecord::Base\n   belongs_to :chargeback_rate\n   belongs_to :detail_measure, :class_name => \"ChargebackRateDetailMeasure\", :foreign_key => :chargeback_rate_detail_measure_id\n \n-  validates_numericality_of :rate\n+  validates :rate, :numericality => true","path":"app/models/chargeback_rate_detail.rb","position":5,"original_position":5,"commit_id":"b891ae6562cfc9517b6a98116687d5a892eaaeec","original_commit_id":"b891ae6562cfc9517b6a98116687d5a892eaaeec","user":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"body":"As this is just rails functionality, I would tend towards not testing it. \r\nBut I'm not sure how the general project opinion is, so I can of course do, if this is common practice","created_at":"2016-01-06T18:14:54Z","updated_at":"2016-01-06T18:14:54Z","html_url":"https://github.com/ManageIQ/manageiq/pull/6062#discussion_r48988935","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48988935"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6062#discussion_r48988935"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062","id":55218406,"html_url":"https://github.com/ManageIQ/manageiq/pull/6062","diff_url":"https://github.com/ManageIQ/manageiq/pull/6062.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/6062.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6062","number":6062,"state":"open","locked":false,"title":"Verify presence of required fields for chargeback rates","user":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"body":"in case the group parameter is not present an exception is raised when displaying\r\nthe rates in the UI\r\n\r\nfixes https://bugzilla.redhat.com/show_bug.cgi?id=1284454","created_at":"2016-01-06T14:32:06Z","updated_at":"2016-01-06T18:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dec4f9eb11323749bb592d81f397e017194e99e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6062/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/b891ae6562cfc9517b6a98116687d5a892eaaeec","head":{"label":"durandom:verify_presence_of_required_fields_for_chargeback_rates","ref":"verify_presence_of_required_fields_for_chargeback_rates","sha":"b891ae6562cfc9517b6a98116687d5a892eaaeec","user":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"repo":{"id":48989151,"name":"manageiq","full_name":"durandom/manageiq","owner":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/durandom/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/durandom/manageiq","forks_url":"https://api.github.com/repos/durandom/manageiq/forks","keys_url":"https://api.github.com/repos/durandom/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/durandom/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/durandom/manageiq/teams","hooks_url":"https://api.github.com/repos/durandom/manageiq/hooks","issue_events_url":"https://api.github.com/repos/durandom/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/durandom/manageiq/events","assignees_url":"https://api.github.com/repos/durandom/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/durandom/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/durandom/manageiq/tags","blobs_url":"https://api.github.com/repos/durandom/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/durandom/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/durandom/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/durandom/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/durandom/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/durandom/manageiq/languages","stargazers_url":"https://api.github.com/repos/durandom/manageiq/stargazers","contributors_url":"https://api.github.com/repos/durandom/manageiq/contributors","subscribers_url":"https://api.github.com/repos/durandom/manageiq/subscribers","subscription_url":"https://api.github.com/repos/durandom/manageiq/subscription","commits_url":"https://api.github.com/repos/durandom/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/durandom/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/durandom/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/durandom/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/durandom/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/durandom/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/durandom/manageiq/merges","archive_url":"https://api.github.com/repos/durandom/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/durandom/manageiq/downloads","issues_url":"https://api.github.com/repos/durandom/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/durandom/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/durandom/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/durandom/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/durandom/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/durandom/manageiq/releases{/id}","created_at":"2016-01-04T10:05:53Z","updated_at":"2016-01-04T10:06:10Z","pushed_at":"2016-01-06T17:18:18Z","git_url":"git://github.com/durandom/manageiq.git","ssh_url":"git@github.com:durandom/manageiq.git","clone_url":"https://github.com/durandom/manageiq.git","svn_url":"https://github.com/durandom/manageiq","homepage":"manageiq.org","size":100280,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"574dc9a2483d8a032e486d96ce3a0bdd8674f64c","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-01-05T14:23:54Z","pushed_at":"2016-01-06T17:50:39Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":134728,"stargazers_count":188,"watchers_count":188,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":489,"forks":200,"open_issues":489,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6062"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6062"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6062/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6062/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/b891ae6562cfc9517b6a98116687d5a892eaaeec"}}}}