{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/autograph/pulls/comments/53643692","id":53643692,"diff_hunk":"@@ -0,0 +1,97 @@\n+// This Source Code Form is subject to the terms of the Mozilla Public\n+// License, v. 2.0. If a copy of the MPL was not distributed with this\n+// file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+//\n+// Contributor: Julien Vehent jvehent@mozilla.com [:ulfr]\n+\n+package main\n+\n+import (\n+\t\"encoding/asn1\"\n+\t\"encoding/base64\"\n+\t\"fmt\"\n+\t\"math/big\"\n+\t\"strings\"\n+)\n+\n+func encode(sig *ecdsaSignature, format string) (str string, err error) {\n+\tif len(format) < 4 {","path":"encoders.go","position":18,"original_position":18,"commit_id":"3ff677ff3a1408cd730fe072b6962dc4999b6637","original_commit_id":"3ff677ff3a1408cd730fe072b6962dc4999b6637","user":{"login":"jvehent","id":415617,"avatar_url":"https://avatars.githubusercontent.com/u/415617?v=3","gravatar_id":"","url":"https://api.github.com/users/jvehent","html_url":"https://github.com/jvehent","followers_url":"https://api.github.com/users/jvehent/followers","following_url":"https://api.github.com/users/jvehent/following{/other_user}","gists_url":"https://api.github.com/users/jvehent/gists{/gist_id}","starred_url":"https://api.github.com/users/jvehent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvehent/subscriptions","organizations_url":"https://api.github.com/users/jvehent/orgs","repos_url":"https://api.github.com/users/jvehent/repos","events_url":"https://api.github.com/users/jvehent/events{/privacy}","received_events_url":"https://api.github.com/users/jvehent/received_events","type":"User","site_admin":false},"body":"Agreed. I blame jetlag :p I'm replacing this with a simple `if format == \"\" { }`","created_at":"2016-02-22T15:50:01Z","updated_at":"2016-02-22T15:50:01Z","html_url":"https://github.com/mozilla-services/autograph/pull/26#discussion_r53643692","pull_request_url":"https://api.github.com/repos/mozilla-services/autograph/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autograph/pulls/comments/53643692"},"html":{"href":"https://github.com/mozilla-services/autograph/pull/26#discussion_r53643692"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/autograph/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/autograph/pulls/26","id":60022640,"html_url":"https://github.com/mozilla-services/autograph/pull/26","diff_url":"https://github.com/mozilla-services/autograph/pull/26.diff","patch_url":"https://github.com/mozilla-services/autograph/pull/26.patch","issue_url":"https://api.github.com/repos/mozilla-services/autograph/issues/26","number":26,"state":"open","locked":false,"title":"Various fixes following kinto workweek feedback","user":{"login":"jvehent","id":415617,"avatar_url":"https://avatars.githubusercontent.com/u/415617?v=3","gravatar_id":"","url":"https://api.github.com/users/jvehent","html_url":"https://github.com/jvehent","followers_url":"https://api.github.com/users/jvehent/followers","following_url":"https://api.github.com/users/jvehent/following{/other_user}","gists_url":"https://api.github.com/users/jvehent/gists{/gist_id}","starred_url":"https://api.github.com/users/jvehent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvehent/subscriptions","organizations_url":"https://api.github.com/users/jvehent/orgs","repos_url":"https://api.github.com/users/jvehent/repos","events_url":"https://api.github.com/users/jvehent/events{/privacy}","received_events_url":"https://api.github.com/users/jvehent/received_events","type":"User","site_admin":false},"body":"work in progress, I have one more change to the signature response format to add `x5u` values (#21), but the rest is there and should be good to review.\r\n\r\nr? @ncloudioj & @almet whenever you get a chance","created_at":"2016-02-19T23:26:56Z","updated_at":"2016-02-22T15:50:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6f1d9dd3ffc2149aa02babc55182364ead053ee","assignee":{"login":"jvehent","id":415617,"avatar_url":"https://avatars.githubusercontent.com/u/415617?v=3","gravatar_id":"","url":"https://api.github.com/users/jvehent","html_url":"https://github.com/jvehent","followers_url":"https://api.github.com/users/jvehent/followers","following_url":"https://api.github.com/users/jvehent/following{/other_user}","gists_url":"https://api.github.com/users/jvehent/gists{/gist_id}","starred_url":"https://api.github.com/users/jvehent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvehent/subscriptions","organizations_url":"https://api.github.com/users/jvehent/orgs","repos_url":"https://api.github.com/users/jvehent/repos","events_url":"https://api.github.com/users/jvehent/events{/privacy}","received_events_url":"https://api.github.com/users/jvehent/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/autograph/pulls/26/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/autograph/pulls/26/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/autograph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/autograph/issues/26/comments","statuses_url":"https://api.github.com/repos/mozilla-services/autograph/statuses/3ff677ff3a1408cd730fe072b6962dc4999b6637","head":{"label":"mozilla-services:workweekfixes","ref":"workweekfixes","sha":"3ff677ff3a1408cd730fe072b6962dc4999b6637","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":49082801,"name":"autograph","full_name":"mozilla-services/autograph","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autograph","description":"Digital signature micro-services API","fork":false,"url":"https://api.github.com/repos/mozilla-services/autograph","forks_url":"https://api.github.com/repos/mozilla-services/autograph/forks","keys_url":"https://api.github.com/repos/mozilla-services/autograph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autograph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autograph/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autograph/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autograph/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autograph/events","assignees_url":"https://api.github.com/repos/mozilla-services/autograph/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autograph/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autograph/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autograph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autograph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autograph/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autograph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autograph/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autograph/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autograph/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autograph/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autograph/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autograph/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autograph/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autograph/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autograph/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autograph/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autograph/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autograph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autograph/merges","archive_url":"https://api.github.com/repos/mozilla-services/autograph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autograph/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autograph/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autograph/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autograph/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autograph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autograph/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autograph/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/autograph/deployments","created_at":"2016-01-05T17:55:26Z","updated_at":"2016-02-22T13:56:31Z","pushed_at":"2016-02-19T23:55:52Z","git_url":"git://github.com/mozilla-services/autograph.git","ssh_url":"git@github.com:mozilla-services/autograph.git","clone_url":"https://github.com/mozilla-services/autograph.git","svn_url":"https://github.com/mozilla-services/autograph","homepage":"","size":533,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"217ea66c11a923de0a451bf824ff41b2c4baf0c4","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":49082801,"name":"autograph","full_name":"mozilla-services/autograph","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autograph","description":"Digital signature micro-services API","fork":false,"url":"https://api.github.com/repos/mozilla-services/autograph","forks_url":"https://api.github.com/repos/mozilla-services/autograph/forks","keys_url":"https://api.github.com/repos/mozilla-services/autograph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autograph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autograph/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autograph/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autograph/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autograph/events","assignees_url":"https://api.github.com/repos/mozilla-services/autograph/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autograph/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autograph/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autograph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autograph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autograph/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autograph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autograph/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autograph/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autograph/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autograph/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autograph/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autograph/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autograph/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autograph/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autograph/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autograph/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autograph/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autograph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autograph/merges","archive_url":"https://api.github.com/repos/mozilla-services/autograph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autograph/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autograph/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autograph/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autograph/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autograph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autograph/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autograph/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/autograph/deployments","created_at":"2016-01-05T17:55:26Z","updated_at":"2016-02-22T13:56:31Z","pushed_at":"2016-02-19T23:55:52Z","git_url":"git://github.com/mozilla-services/autograph.git","ssh_url":"git@github.com:mozilla-services/autograph.git","clone_url":"https://github.com/mozilla-services/autograph.git","svn_url":"https://github.com/mozilla-services/autograph","homepage":"","size":533,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autograph/pulls/26"},"html":{"href":"https://github.com/mozilla-services/autograph/pull/26"},"issue":{"href":"https://api.github.com/repos/mozilla-services/autograph/issues/26"},"comments":{"href":"https://api.github.com/repos/mozilla-services/autograph/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/autograph/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/autograph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/autograph/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/autograph/statuses/3ff677ff3a1408cd730fe072b6962dc4999b6637"}}}}