{"action":"created","comment":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/94267554","pull_request_review_id":14798748,"id":94267554,"diff_hunk":"@@ -775,14 +781,22 @@ void BaseDaemon::initialize(Application& self)\n \t\t  * Делаем это после buildLoggers, чтобы не менять текущую директорию раньше.\n \t\t  * Это важно, если конфиги расположены в текущей директории.\n \t\t  */\n-\t\tPoco::File opt_cores = \"/opt/cores\";\n-\n-\t\tstd::string core_path = config().getString(\"core_path\",\n-\t\t\topt_cores.exists() && opt_cores.isDirectory()\n-\t\t\t\t? \"/opt/cores/\"\n-\t\t\t\t: (!log_path.empty()\n-\t\t\t\t\t? log_path\n-\t\t\t\t\t: \"/opt/\"));\n+\n+\t\tstd::string core_path = config().getString(\"core_path\", \"\");\n+\t\tif (core_path.empty())\n+\t\t\tcore_path = getDefaultCorePath();\n+\n+\t\ttry {\n+\t\t\tcreateDirectory(core_path, false);\n+\t\t} catch (...) { }","path":"libs/libdaemon/src/BaseDaemon.cpp","position":56,"original_position":56,"commit_id":"e94073363b8291058f32456e33828abf546cad65","original_commit_id":"e94073363b8291058f32456e33828abf546cad65","user":{"login":"alexey-milovidov","id":18581488,"avatar_url":"https://avatars.githubusercontent.com/u/18581488?v=3","gravatar_id":"","url":"https://api.github.com/users/alexey-milovidov","html_url":"https://github.com/alexey-milovidov","followers_url":"https://api.github.com/users/alexey-milovidov/followers","following_url":"https://api.github.com/users/alexey-milovidov/following{/other_user}","gists_url":"https://api.github.com/users/alexey-milovidov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-milovidov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-milovidov/subscriptions","organizations_url":"https://api.github.com/users/alexey-milovidov/orgs","repos_url":"https://api.github.com/users/alexey-milovidov/repos","events_url":"https://api.github.com/users/alexey-milovidov/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-milovidov/received_events","type":"User","site_admin":false},"body":"Silent catching of all exceptions is prohibited in style.","created_at":"2016-12-31T02:11:10Z","updated_at":"2016-12-31T02:20:28Z","html_url":"https://github.com/yandex/ClickHouse/pull/295#discussion_r94267554","pull_request_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/94267554"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/295#discussion_r94267554"},"pull_request":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/295","id":99740624,"html_url":"https://github.com/yandex/ClickHouse/pull/295","diff_url":"https://github.com/yandex/ClickHouse/pull/295.diff","patch_url":"https://github.com/yandex/ClickHouse/pull/295.patch","issue_url":"https://api.github.com/repos/yandex/ClickHouse/issues/295","number":295,"state":"open","locked":false,"title":"Better user-group creating in postinst, BaseDaemon::getDefaultCorePath [#METR-23811]","user":{"login":"proller","id":1752192,"avatar_url":"https://avatars.githubusercontent.com/u/1752192?v=3","gravatar_id":"","url":"https://api.github.com/users/proller","html_url":"https://github.com/proller","followers_url":"https://api.github.com/users/proller/followers","following_url":"https://api.github.com/users/proller/following{/other_user}","gists_url":"https://api.github.com/users/proller/gists{/gist_id}","starred_url":"https://api.github.com/users/proller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proller/subscriptions","organizations_url":"https://api.github.com/users/proller/orgs","repos_url":"https://api.github.com/users/proller/repos","events_url":"https://api.github.com/users/proller/events{/privacy}","received_events_url":"https://api.github.com/users/proller/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-30T10:43:04Z","updated_at":"2016-12-31T02:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b734c722b637dd874bf3f97fcdd9b793cee431a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/295/commits","review_comments_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/295/comments","review_comment_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/issues/295/comments","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/e94073363b8291058f32456e33828abf546cad65","head":{"label":"proller:METR-23811","ref":"METR-23811","sha":"e94073363b8291058f32456e33828abf546cad65","user":{"login":"proller","id":1752192,"avatar_url":"https://avatars.githubusercontent.com/u/1752192?v=3","gravatar_id":"","url":"https://api.github.com/users/proller","html_url":"https://github.com/proller","followers_url":"https://api.github.com/users/proller/followers","following_url":"https://api.github.com/users/proller/following{/other_user}","gists_url":"https://api.github.com/users/proller/gists{/gist_id}","starred_url":"https://api.github.com/users/proller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proller/subscriptions","organizations_url":"https://api.github.com/users/proller/orgs","repos_url":"https://api.github.com/users/proller/repos","events_url":"https://api.github.com/users/proller/events{/privacy}","received_events_url":"https://api.github.com/users/proller/received_events","type":"User","site_admin":false},"repo":{"id":73570956,"name":"ClickHouse","full_name":"proller/ClickHouse","owner":{"login":"proller","id":1752192,"avatar_url":"https://avatars.githubusercontent.com/u/1752192?v=3","gravatar_id":"","url":"https://api.github.com/users/proller","html_url":"https://github.com/proller","followers_url":"https://api.github.com/users/proller/followers","following_url":"https://api.github.com/users/proller/following{/other_user}","gists_url":"https://api.github.com/users/proller/gists{/gist_id}","starred_url":"https://api.github.com/users/proller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proller/subscriptions","organizations_url":"https://api.github.com/users/proller/orgs","repos_url":"https://api.github.com/users/proller/repos","events_url":"https://api.github.com/users/proller/events{/privacy}","received_events_url":"https://api.github.com/users/proller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/proller/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":true,"url":"https://api.github.com/repos/proller/ClickHouse","forks_url":"https://api.github.com/repos/proller/ClickHouse/forks","keys_url":"https://api.github.com/repos/proller/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proller/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proller/ClickHouse/teams","hooks_url":"https://api.github.com/repos/proller/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/proller/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/proller/ClickHouse/events","assignees_url":"https://api.github.com/repos/proller/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/proller/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/proller/ClickHouse/tags","blobs_url":"https://api.github.com/repos/proller/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proller/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proller/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/proller/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proller/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/proller/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/proller/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/proller/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/proller/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/proller/ClickHouse/subscription","commits_url":"https://api.github.com/repos/proller/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/proller/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/proller/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/proller/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/proller/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/proller/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proller/ClickHouse/merges","archive_url":"https://api.github.com/repos/proller/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proller/ClickHouse/downloads","issues_url":"https://api.github.com/repos/proller/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/proller/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/proller/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/proller/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proller/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/proller/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/proller/ClickHouse/deployments","created_at":"2016-11-12T18:34:14Z","updated_at":"2016-11-12T18:34:20Z","pushed_at":"2016-12-31T02:14:56Z","git_url":"git://github.com/proller/ClickHouse.git","ssh_url":"git@github.com:proller/ClickHouse.git","clone_url":"https://github.com/proller/ClickHouse.git","svn_url":"https://github.com/proller/ClickHouse","homepage":null,"size":36782,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yandex:master","ref":"master","sha":"4dee097ba80240e2c8852e152b1bd740ea3e7995","user":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"repo":{"id":60246359,"name":"ClickHouse","full_name":"yandex/ClickHouse","owner":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":false,"url":"https://api.github.com/repos/yandex/ClickHouse","forks_url":"https://api.github.com/repos/yandex/ClickHouse/forks","keys_url":"https://api.github.com/repos/yandex/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex/ClickHouse/teams","hooks_url":"https://api.github.com/repos/yandex/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/yandex/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/yandex/ClickHouse/events","assignees_url":"https://api.github.com/repos/yandex/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/yandex/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/yandex/ClickHouse/tags","blobs_url":"https://api.github.com/repos/yandex/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/yandex/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/yandex/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/yandex/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/yandex/ClickHouse/subscription","commits_url":"https://api.github.com/repos/yandex/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/yandex/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/yandex/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex/ClickHouse/merges","archive_url":"https://api.github.com/repos/yandex/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex/ClickHouse/downloads","issues_url":"https://api.github.com/repos/yandex/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/yandex/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/yandex/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/yandex/ClickHouse/deployments","created_at":"2016-06-02T08:28:18Z","updated_at":"2016-12-31T00:57:57Z","pushed_at":"2016-12-31T02:05:56Z","git_url":"git://github.com/yandex/ClickHouse.git","ssh_url":"git@github.com:yandex/ClickHouse.git","clone_url":"https://github.com/yandex/ClickHouse.git","svn_url":"https://github.com/yandex/ClickHouse","homepage":null,"size":36805,"stargazers_count":1877,"watchers_count":1877,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":80,"forks":218,"open_issues":80,"watchers":1877,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/295"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/295"},"issue":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/295"},"comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/yandex/ClickHouse/statuses/e94073363b8291058f32456e33828abf546cad65"}}}}
{"actor":{"display_login":"alexey-milovidov"}}