{"action":"created","issue":{"url":"https://api.github.com/repos/sirjuddington/SLADE/issues/483","repository_url":"https://api.github.com/repos/sirjuddington/SLADE","labels_url":"https://api.github.com/repos/sirjuddington/SLADE/issues/483/labels{/name}","comments_url":"https://api.github.com/repos/sirjuddington/SLADE/issues/483/comments","events_url":"https://api.github.com/repos/sirjuddington/SLADE/issues/483/events","html_url":"https://github.com/sirjuddington/SLADE/pull/483","id":142022063,"number":483,"title":"Papercuts 6","user":{"login":"eevee","id":94112,"avatar_url":"https://avatars.githubusercontent.com/u/94112?v=3","gravatar_id":"","url":"https://api.github.com/users/eevee","html_url":"https://github.com/eevee","followers_url":"https://api.github.com/users/eevee/followers","following_url":"https://api.github.com/users/eevee/following{/other_user}","gists_url":"https://api.github.com/users/eevee/gists{/gist_id}","starred_url":"https://api.github.com/users/eevee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevee/subscriptions","organizations_url":"https://api.github.com/users/eevee/orgs","repos_url":"https://api.github.com/users/eevee/repos","events_url":"https://api.github.com/users/eevee/events{/privacy}","received_events_url":"https://api.github.com/users/eevee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-19T03:11:02Z","updated_at":"2016-03-20T09:31:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sirjuddington/SLADE/pulls/483","html_url":"https://github.com/sirjuddington/SLADE/pull/483","diff_url":"https://github.com/sirjuddington/SLADE/pull/483.diff","patch_url":"https://github.com/sirjuddington/SLADE/pull/483.patch"},"body":"Fixed some things I stumbled upon while mapping for DUMP 2.\r\n\r\nThe only not-quite-trivial change is the \"enclosed void\" one.  I hammered on it for a bit and couldn't come up with any pathological cases that broke catastrophically."},"comment":{"url":"https://api.github.com/repos/sirjuddington/SLADE/issues/comments/198881688","html_url":"https://github.com/sirjuddington/SLADE/pull/483#issuecomment-198881688","issue_url":"https://api.github.com/repos/sirjuddington/SLADE/issues/483","id":198881688,"user":{"login":"sirjuddington","id":2484576,"avatar_url":"https://avatars.githubusercontent.com/u/2484576?v=3","gravatar_id":"","url":"https://api.github.com/users/sirjuddington","html_url":"https://github.com/sirjuddington","followers_url":"https://api.github.com/users/sirjuddington/followers","following_url":"https://api.github.com/users/sirjuddington/following{/other_user}","gists_url":"https://api.github.com/users/sirjuddington/gists{/gist_id}","starred_url":"https://api.github.com/users/sirjuddington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirjuddington/subscriptions","organizations_url":"https://api.github.com/users/sirjuddington/orgs","repos_url":"https://api.github.com/users/sirjuddington/repos","events_url":"https://api.github.com/users/sirjuddington/events{/privacy}","received_events_url":"https://api.github.com/users/sirjuddington/received_events","type":"User","site_admin":false},"created_at":"2016-03-20T09:31:14Z","updated_at":"2016-03-20T09:31:14Z","body":"Only one I'm concerned about is f0687a6, the setModified shouldn't be going at the top of the function(s), but still be before any change is made. As it is here a line will be set 'modified' even if you are just setting a side or vertex property. It'll also end up with setModified called twice if it gets down to MapObject::setXXXProperty, which shouldn't matter but might."}}