{"action":"created","issue":{"url":"https://api.github.com/repos/steve228uk/Downpour/issues/1","repository_url":"https://api.github.com/repos/steve228uk/Downpour","labels_url":"https://api.github.com/repos/steve228uk/Downpour/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/steve228uk/Downpour/issues/1/comments","events_url":"https://api.github.com/repos/steve228uk/Downpour/issues/1/events","html_url":"https://github.com/steve228uk/Downpour/pull/1","id":197548761,"number":1,"title":"Add missing tests and update to Swift 3","user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=3","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-26T07:19:22Z","updated_at":"2016-12-26T07:30:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/steve228uk/Downpour/pulls/1","html_url":"https://github.com/steve228uk/Downpour/pull/1","diff_url":"https://github.com/steve228uk/Downpour/pull/1.diff","patch_url":"https://github.com/steve228uk/Downpour/pull/1.patch"},"body":"This PR adds tests, this was the first step migrating Fetch app to Swift 3.0, I was about to migrate Downpour to Swift 3.0 but wanted some tests first so I can ensure I didn't break anything.\r\n\r\nSpent more time across all of this already so haven't got any further, but here's the first PR (hopefully of many).\r\n\r\nIn the first commit, I switched the source layout to be compatible with Swift Package Manager along with adding a `Package.swift` file. This provides the following:\r\n\r\n- Ability to generate an Xcode project easily (to aid using the Xcode Swift version migrator).  (see notes below). This also allows running tests from Xcode project directly.\r\n\r\n    ```shell\r\n    $ swift package generate-xcodeproj\r\n    ```\r\n\r\n- Ability to run the tests (see notes below)\r\n\r\n    ```shell\r\n     $ swift test\r\n     Compile Swift Module 'Downpour' (3 sources)\r\n     Compile Swift Module 'DownpourTests' (1 sources)\r\n    ...\r\n    Test Suite 'All tests' passed at 2016-12-26 07:28:46.196.\r\n    \t Executed 15 tests, with 0 failures (0 unexpected) in 0.009 (0.011) seconds\r\n    ```\r\n\r\nIn the second commit I've added some tests for the project, these are basically extracted from an existing closed source app I had for Put.io. I think I shared the source with you @steve228uk for `PIOShowFilenameMatcher` with the tests before some time Fetch app got these features.\r\n\r\nThen finally, I've updated the README fixing some markdown syntax errors and updating the installation instructions.\r\n\r\n~~**NOTE**: *Since the project currently uses Swift 2, the generated Xcode project will need updating before it will build/run tests. You must go to the projects build settings and set \"Use Legacy Swift Language Version\" `SWIFT_VERSION` to make the project build and testable. This means that `swift test` would also fail at the moment until the source is updated for Swift 3 (will do shortly).*~~\r\n\r\n**UPDATE:** This pull request has now been updated to update to Swift 3.\r\n"},"comment":{"url":"https://api.github.com/repos/steve228uk/Downpour/issues/comments/269176642","html_url":"https://github.com/steve228uk/Downpour/pull/1#issuecomment-269176642","issue_url":"https://api.github.com/repos/steve228uk/Downpour/issues/1","id":269176642,"user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=3","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"created_at":"2016-12-26T07:30:06Z","updated_at":"2016-12-26T07:30:06Z","body":"@steve228uk If you'd like to have the tests run on CI, then please add Travis CI integration. I can handle adding .travis.yml configuration to run tests either in this PR or in a subsequent one if you would like."}}
{"actor":{"display_login":"kylef"}}