{"action":"created","comment":{"url":"https://api.github.com/repos/firehol/firehol/pulls/comments/58306715","id":58306715,"diff_hunk":"@@ -55,10 +52,65 @@ if ENABLE_VNETBUILD\n scripts += vnetbuild\n endif\n \n+\n+if FILENAME_VERSIONS\n+\n+install-exec-hook:\n+if ENABLE_FIREHOL\n+\tcd $(DESTDIR)$(sbindir) && \\\n+\t\tmv -f firehol firehol-@PACKAGE_VERSION@ && \\\n+\t\t$(LN_S) firehol-@PACKAGE_VERSION@ firehol\n+endif\n+if ENABLE_FIREQOS\n+\tcd $(DESTDIR)$(sbindir) && \\\n+\t\tmv -f fireqos fireqos-@PACKAGE_VERSION@ && \\\n+\t\t$(LN_S) fireqos-@PACKAGE_VERSION@ fireqos\n+endif\n+if ENABLE_LINK_BALANCER\n+\tcd $(DESTDIR)$(sbindir) && \\\n+\t\tmv -f link-balancer link-balancer-@PACKAGE_VERSION@ && \\\n+\t\t$(LN_S) link-balancer-@PACKAGE_VERSION@ link-balancer\n+endif\n+if ENABLE_UPDATE_IPSETS\n+\tcd $(DESTDIR)$(sbindir) && \\\n+\t\tmv -f update-ipsets update-ipsets-@PACKAGE_VERSION@ && \\\n+\t\t$(LN_S) update-ipsets-@PACKAGE_VERSION@ update-ipsets\n+endif\n+if ENABLE_VNETBUILD\n+\tcd $(DESTDIR)$(sbindir) && \\\n+\t\tmv -f vnetbuild vnetbuild-@PACKAGE_VERSION@ && \\\n+\t\t$(LN_S) vnetbuild-@PACKAGE_VERSION@ vnetbuild\n+endif","path":"sbin/Makefile.am","position":63,"original_position":63,"commit_id":"def3233070414172d206a563350ed37cd7bc3f7b","original_commit_id":"def3233070414172d206a563350ed37cd7bc3f7b","user":{"login":"philwhineray","id":1271051,"avatar_url":"https://avatars.githubusercontent.com/u/1271051?v=3","gravatar_id":"","url":"https://api.github.com/users/philwhineray","html_url":"https://github.com/philwhineray","followers_url":"https://api.github.com/users/philwhineray/followers","following_url":"https://api.github.com/users/philwhineray/following{/other_user}","gists_url":"https://api.github.com/users/philwhineray/gists{/gist_id}","starred_url":"https://api.github.com/users/philwhineray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwhineray/subscriptions","organizations_url":"https://api.github.com/users/philwhineray/orgs","repos_url":"https://api.github.com/users/philwhineray/repos","events_url":"https://api.github.com/users/philwhineray/events{/privacy}","received_events_url":"https://api.github.com/users/philwhineray/received_events","type":"User","site_admin":false},"body":"I just figured out you meant to write `readlink` so yes, that would work to find the location regardless. I retract the small script as a requirement.\r\n\r\nIt does leave open the question of how the location of `readlink` is specified if we are not processing the whole script though, in order to be able to read the firehol.config\r\n\r\nOr have I misunderstood? i.e. will this satisfy everyone:\r\n\r\n1. scripts `firehol.in` etc. are processed by configure to expand paths, then installed to /usr/libexex/whatever-versioned/scriptname\r\n\r\n2. links to /sbin made for these\r\n\r\n3. firehol.config is introduced alongside the scripts. It holds variables for the paths for the configured directories such as /etc /var etc. and is read based on the location of the script using `readlink` as already proposed.\r\n\r\nMaybe that is exactly what you are proposing anyway @alonbl ? If so, do you also agree @ktsaou ? I will get it implemented that way.","created_at":"2016-04-03T08:51:56Z","updated_at":"2016-04-03T08:51:56Z","html_url":"https://github.com/firehol/firehol/pull/128#discussion_r58306715","pull_request_url":"https://api.github.com/repos/firehol/firehol/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/firehol/firehol/pulls/comments/58306715"},"html":{"href":"https://github.com/firehol/firehol/pull/128#discussion_r58306715"},"pull_request":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/firehol/firehol/pulls/128","id":64244745,"html_url":"https://github.com/firehol/firehol/pull/128","diff_url":"https://github.com/firehol/firehol/pull/128.diff","patch_url":"https://github.com/firehol/firehol/pull/128.patch","issue_url":"https://api.github.com/repos/firehol/firehol/issues/128","number":128,"state":"open","locked":false,"title":"Move fully to autotools","user":{"login":"philwhineray","id":1271051,"avatar_url":"https://avatars.githubusercontent.com/u/1271051?v=3","gravatar_id":"","url":"https://api.github.com/users/philwhineray","html_url":"https://github.com/philwhineray","followers_url":"https://api.github.com/users/philwhineray/followers","following_url":"https://api.github.com/users/philwhineray/following{/other_user}","gists_url":"https://api.github.com/users/philwhineray/gists{/gist_id}","starred_url":"https://api.github.com/users/philwhineray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwhineray/subscriptions","organizations_url":"https://api.github.com/users/philwhineray/orgs","repos_url":"https://api.github.com/users/philwhineray/repos","events_url":"https://api.github.com/users/philwhineray/events{/privacy}","received_events_url":"https://api.github.com/users/philwhineray/received_events","type":"User","site_admin":false},"body":"This pull request contains the @alonbl commit plus a whole series of others, to move all the scripts over to a common method requiring even developers to do a configure and make. It reduces the code size somewhat and ensures a consistent experience.","created_at":"2016-03-26T18:09:48Z","updated_at":"2016-04-03T08:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"778e32a18babe917879fed01b9b0fb93b1a8022d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/firehol/firehol/pulls/128/commits","review_comments_url":"https://api.github.com/repos/firehol/firehol/pulls/128/comments","review_comment_url":"https://api.github.com/repos/firehol/firehol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firehol/firehol/issues/128/comments","statuses_url":"https://api.github.com/repos/firehol/firehol/statuses/def3233070414172d206a563350ed37cd7bc3f7b","head":{"label":"firehol:alonbl-build","ref":"alonbl-build","sha":"def3233070414172d206a563350ed37cd7bc3f7b","user":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"repo":{"id":12880290,"name":"firehol","full_name":"firehol/firehol","owner":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firehol/firehol","description":"A firewall for humans...","fork":false,"url":"https://api.github.com/repos/firehol/firehol","forks_url":"https://api.github.com/repos/firehol/firehol/forks","keys_url":"https://api.github.com/repos/firehol/firehol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firehol/firehol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firehol/firehol/teams","hooks_url":"https://api.github.com/repos/firehol/firehol/hooks","issue_events_url":"https://api.github.com/repos/firehol/firehol/issues/events{/number}","events_url":"https://api.github.com/repos/firehol/firehol/events","assignees_url":"https://api.github.com/repos/firehol/firehol/assignees{/user}","branches_url":"https://api.github.com/repos/firehol/firehol/branches{/branch}","tags_url":"https://api.github.com/repos/firehol/firehol/tags","blobs_url":"https://api.github.com/repos/firehol/firehol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firehol/firehol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firehol/firehol/git/refs{/sha}","trees_url":"https://api.github.com/repos/firehol/firehol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firehol/firehol/statuses/{sha}","languages_url":"https://api.github.com/repos/firehol/firehol/languages","stargazers_url":"https://api.github.com/repos/firehol/firehol/stargazers","contributors_url":"https://api.github.com/repos/firehol/firehol/contributors","subscribers_url":"https://api.github.com/repos/firehol/firehol/subscribers","subscription_url":"https://api.github.com/repos/firehol/firehol/subscription","commits_url":"https://api.github.com/repos/firehol/firehol/commits{/sha}","git_commits_url":"https://api.github.com/repos/firehol/firehol/git/commits{/sha}","comments_url":"https://api.github.com/repos/firehol/firehol/comments{/number}","issue_comment_url":"https://api.github.com/repos/firehol/firehol/issues/comments{/number}","contents_url":"https://api.github.com/repos/firehol/firehol/contents/{+path}","compare_url":"https://api.github.com/repos/firehol/firehol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firehol/firehol/merges","archive_url":"https://api.github.com/repos/firehol/firehol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firehol/firehol/downloads","issues_url":"https://api.github.com/repos/firehol/firehol/issues{/number}","pulls_url":"https://api.github.com/repos/firehol/firehol/pulls{/number}","milestones_url":"https://api.github.com/repos/firehol/firehol/milestones{/number}","notifications_url":"https://api.github.com/repos/firehol/firehol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firehol/firehol/labels{/name}","releases_url":"https://api.github.com/repos/firehol/firehol/releases{/id}","deployments_url":"https://api.github.com/repos/firehol/firehol/deployments","created_at":"2013-09-16T22:23:26Z","updated_at":"2016-04-03T07:06:28Z","pushed_at":"2016-04-02T19:56:34Z","git_url":"git://github.com/firehol/firehol.git","ssh_url":"git@github.com:firehol/firehol.git","clone_url":"https://github.com/firehol/firehol.git","svn_url":"https://github.com/firehol/firehol","homepage":null,"size":4519,"stargazers_count":179,"watchers_count":179,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":53,"forks":17,"open_issues":53,"watchers":179,"default_branch":"master"}},"base":{"label":"firehol:master","ref":"master","sha":"8f18fa7e36c60fc21683e9bcf1e7e3286d1b7627","user":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"repo":{"id":12880290,"name":"firehol","full_name":"firehol/firehol","owner":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firehol/firehol","description":"A firewall for humans...","fork":false,"url":"https://api.github.com/repos/firehol/firehol","forks_url":"https://api.github.com/repos/firehol/firehol/forks","keys_url":"https://api.github.com/repos/firehol/firehol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firehol/firehol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firehol/firehol/teams","hooks_url":"https://api.github.com/repos/firehol/firehol/hooks","issue_events_url":"https://api.github.com/repos/firehol/firehol/issues/events{/number}","events_url":"https://api.github.com/repos/firehol/firehol/events","assignees_url":"https://api.github.com/repos/firehol/firehol/assignees{/user}","branches_url":"https://api.github.com/repos/firehol/firehol/branches{/branch}","tags_url":"https://api.github.com/repos/firehol/firehol/tags","blobs_url":"https://api.github.com/repos/firehol/firehol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firehol/firehol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firehol/firehol/git/refs{/sha}","trees_url":"https://api.github.com/repos/firehol/firehol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firehol/firehol/statuses/{sha}","languages_url":"https://api.github.com/repos/firehol/firehol/languages","stargazers_url":"https://api.github.com/repos/firehol/firehol/stargazers","contributors_url":"https://api.github.com/repos/firehol/firehol/contributors","subscribers_url":"https://api.github.com/repos/firehol/firehol/subscribers","subscription_url":"https://api.github.com/repos/firehol/firehol/subscription","commits_url":"https://api.github.com/repos/firehol/firehol/commits{/sha}","git_commits_url":"https://api.github.com/repos/firehol/firehol/git/commits{/sha}","comments_url":"https://api.github.com/repos/firehol/firehol/comments{/number}","issue_comment_url":"https://api.github.com/repos/firehol/firehol/issues/comments{/number}","contents_url":"https://api.github.com/repos/firehol/firehol/contents/{+path}","compare_url":"https://api.github.com/repos/firehol/firehol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firehol/firehol/merges","archive_url":"https://api.github.com/repos/firehol/firehol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firehol/firehol/downloads","issues_url":"https://api.github.com/repos/firehol/firehol/issues{/number}","pulls_url":"https://api.github.com/repos/firehol/firehol/pulls{/number}","milestones_url":"https://api.github.com/repos/firehol/firehol/milestones{/number}","notifications_url":"https://api.github.com/repos/firehol/firehol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firehol/firehol/labels{/name}","releases_url":"https://api.github.com/repos/firehol/firehol/releases{/id}","deployments_url":"https://api.github.com/repos/firehol/firehol/deployments","created_at":"2013-09-16T22:23:26Z","updated_at":"2016-04-03T07:06:28Z","pushed_at":"2016-04-02T19:56:34Z","git_url":"git://github.com/firehol/firehol.git","ssh_url":"git@github.com:firehol/firehol.git","clone_url":"https://github.com/firehol/firehol.git","svn_url":"https://github.com/firehol/firehol","homepage":null,"size":4519,"stargazers_count":179,"watchers_count":179,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":53,"forks":17,"open_issues":53,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128"},"html":{"href":"https://github.com/firehol/firehol/pull/128"},"issue":{"href":"https://api.github.com/repos/firehol/firehol/issues/128"},"comments":{"href":"https://api.github.com/repos/firehol/firehol/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/firehol/firehol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/firehol/firehol/statuses/def3233070414172d206a563350ed37cd7bc3f7b"}}}}