{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3159","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3159/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3159/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3159/events","html_url":"https://github.com/RobotLocomotion/drake/pull/3159","id":171474975,"number":3159,"title":"Introduce Vector1 names for Cars vectors","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rpoyner-tri","id":17582368,"avatar_url":"https://avatars.githubusercontent.com/u/17582368?v=3","gravatar_id":"","url":"https://api.github.com/users/rpoyner-tri","html_url":"https://github.com/rpoyner-tri","followers_url":"https://api.github.com/users/rpoyner-tri/followers","following_url":"https://api.github.com/users/rpoyner-tri/following{/other_user}","gists_url":"https://api.github.com/users/rpoyner-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/rpoyner-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpoyner-tri/subscriptions","organizations_url":"https://api.github.com/users/rpoyner-tri/orgs","repos_url":"https://api.github.com/users/rpoyner-tri/repos","events_url":"https://api.github.com/users/rpoyner-tri/events{/privacy}","received_events_url":"https://api.github.com/users/rpoyner-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"rpoyner-tri","id":17582368,"avatar_url":"https://avatars.githubusercontent.com/u/17582368?v=3","gravatar_id":"","url":"https://api.github.com/users/rpoyner-tri","html_url":"https://github.com/rpoyner-tri","followers_url":"https://api.github.com/users/rpoyner-tri/followers","following_url":"https://api.github.com/users/rpoyner-tri/following{/other_user}","gists_url":"https://api.github.com/users/rpoyner-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/rpoyner-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpoyner-tri/subscriptions","organizations_url":"https://api.github.com/users/rpoyner-tri/orgs","repos_url":"https://api.github.com/users/rpoyner-tri/repos","events_url":"https://api.github.com/users/rpoyner-tri/events{/privacy}","received_events_url":"https://api.github.com/users/rpoyner-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-16T17:40:50Z","updated_at":"2016-08-16T18:52:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/3159","html_url":"https://github.com/RobotLocomotion/drake/pull/3159","diff_url":"https://github.com/RobotLocomotion/drake/pull/3159.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/3159.patch"},"body":"Two boring changes, in preparation for Cars porting to Vector2 and eventually System2:\r\n- Introduce Vector1 names for Cars vectors in preparation for porting to Vector2.\r\n- Add DRAKE_BUILD as an optional user override.\r\n\r\nNote that this PR explicitly undoes some IWYU boilerplate, in order to minimize the include graph during the API transition.  (Without tooling to auto-fix and maintain IWYU, it's not worth curating by hand right now, in this case, in my opinion.)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/3159)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/240201279","html_url":"https://github.com/RobotLocomotion/drake/pull/3159#issuecomment-240201279","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3159","id":240201279,"user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T18:52:47Z","updated_at":"2016-08-16T18:52:47Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[drake/examples/Cars/run_demo_multi_car.sh, line 26 \\[r1\\]](https://reviewable.io:443/reviews/robotlocomotion/drake/3159#-KPJeYc06BINjES-aCrI:-KPJgIrE7J2yuV0mWOqM:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/7e5faedc3ada264073bb357c531809e0bc956692/drake/examples/Cars/run_demo_multi_car.sh#L26)):*\n<details><summary><i>Previously, rpoyner-tri (Rick Poyner (rico)) wrote…</i></summary>\n> i think you mean ${FOO:-$BLAH/thing}, rather than ${FOO:$BLAH/thing} . See https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html\n</details>\nDone.\n\n---\n\n*[drake/examples/Cars/simple_car_demo.sh, line 24 \\[r1\\]](https://reviewable.io:443/reviews/robotlocomotion/drake/3159#-KPJewSOKha7YXsraeqH:-KPJgJRkhH0cOSuJGIqy:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/7e5faedc3ada264073bb357c531809e0bc956692/drake/examples/Cars/simple_car_demo.sh#L24)):*\n<details><summary><i>Previously, rpoyner-tri (Rick Poyner (rico)) wrote…</i></summary>\n> same defect as in my prior comment.\n</details>\nDone.\n\n---\n\n*[drake/examples/Cars/system1_cars_vectors.h, line 6 \\[r1\\]](https://reviewable.io:443/reviews/robotlocomotion/drake/3159#-KPJfCwPEUIo5RVjX4gU:-KPJgPzzuxv0pFUYyUuE:bcptlxi) ([raw file](https://github.com/robotlocomotion/drake/blob/7e5faedc3ada264073bb357c531809e0bc956692/drake/examples/Cars/system1_cars_vectors.h#L6)):*\n<details><summary><i>Previously, rpoyner-tri (Rick Poyner (rico)) wrote…</i></summary>\n> this  include seems superfluous, unless the other header files are defective?\n</details>\nWell, `drake::Vector` is a _Concept_, not a base class, so technically neither this file for the specific gen files need it.  However, this is a convenient place to ensure that the free functions and type goop in `vector.h` make it everywhere they need to for Vector1 users.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/3159)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jwnimmer-tri"}}