{"action":"created","issue":{"url":"https://api.github.com/repos/ponylang/rfcs/issues/34","repository_url":"https://api.github.com/repos/ponylang/rfcs","labels_url":"https://api.github.com/repos/ponylang/rfcs/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/ponylang/rfcs/issues/34/comments","events_url":"https://api.github.com/repos/ponylang/rfcs/issues/34/events","html_url":"https://github.com/ponylang/rfcs/pull/34","id":177876287,"number":34,"title":"Buffered read_until method.","user":{"login":"lisael","id":893463,"avatar_url":"https://avatars.githubusercontent.com/u/893463?v=3","gravatar_id":"","url":"https://api.github.com/users/lisael","html_url":"https://github.com/lisael","followers_url":"https://api.github.com/users/lisael/followers","following_url":"https://api.github.com/users/lisael/following{/other_user}","gists_url":"https://api.github.com/users/lisael/gists{/gist_id}","starred_url":"https://api.github.com/users/lisael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisael/subscriptions","organizations_url":"https://api.github.com/users/lisael/orgs","repos_url":"https://api.github.com/users/lisael/repos","events_url":"https://api.github.com/users/lisael/events{/privacy}","received_events_url":"https://api.github.com/users/lisael/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-09-19T19:36:25Z","updated_at":"2016-09-19T21:32:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ponylang/rfcs/pulls/34","html_url":"https://github.com/ponylang/rfcs/pull/34","diff_url":"https://github.com/ponylang/rfcs/pull/34.diff","patch_url":"https://github.com/ponylang/rfcs/pull/34.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ponylang/rfcs/issues/comments/248133617","html_url":"https://github.com/ponylang/rfcs/pull/34#issuecomment-248133617","issue_url":"https://api.github.com/repos/ponylang/rfcs/issues/34","id":248133617,"user":{"login":"lisael","id":893463,"avatar_url":"https://avatars.githubusercontent.com/u/893463?v=3","gravatar_id":"","url":"https://api.github.com/users/lisael","html_url":"https://github.com/lisael","followers_url":"https://api.github.com/users/lisael/followers","following_url":"https://api.github.com/users/lisael/following{/other_user}","gists_url":"https://api.github.com/users/lisael/gists{/gist_id}","starred_url":"https://api.github.com/users/lisael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisael/subscriptions","organizations_url":"https://api.github.com/users/lisael/orgs","repos_url":"https://api.github.com/users/lisael/repos","events_url":"https://api.github.com/users/lisael/events{/privacy}","received_events_url":"https://api.github.com/users/lisael/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T21:32:03Z","updated_at":"2016-09-19T21:32:03Z","body":"I had the same UX question, in my first version, the parameter was `eager: Bool = false`. It seemed to me like a double-negation so I edited.\r\n\r\nConcerning `line` and consistency you clearly have a point. Although, because of `line` behaviour that just swallows 1 **or** 2 bytes –you'll never know–, `read_until` can't be consistent if it doesn't just swallows the separator too, in which case we don't need the parameter at all.\r\n\r\nWhat I understand is that `line` has to have this behaviour to permit a consistent code across platforms, abstracting the line separator.\r\n\r\nOTOH, it seems odd to me to change the data that the user provided, but maybe you're both right, it's simpler to ditch the separator. (I have  YAGNI tendences :) ).\r\n\r\n@SeanTAllen I needed this to parse PG protocol messages https://www.postgresql.org/docs/current/static/protocol-message-formats.html . For some of them like ParameterStatus, read_until(0) would help.\r\n\r\nI update the proposal with this example and soft wrapping :). I'm not sure about the UX for now."}}
{"actor":{"display_login":"lisael"}}