{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/hhvm/issues/7113","repository_url":"https://api.github.com/repos/facebook/hhvm","labels_url":"https://api.github.com/repos/facebook/hhvm/issues/7113/labels{/name}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/7113/comments","events_url":"https://api.github.com/repos/facebook/hhvm/issues/7113/events","html_url":"https://github.com/facebook/hhvm/pull/7113","id":157320283,"number":7113,"title":"Align thread locals to 16 bytes.","user":{"login":"gdbentley","id":4721933,"avatar_url":"https://avatars.githubusercontent.com/u/4721933?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbentley","html_url":"https://github.com/gdbentley","followers_url":"https://api.github.com/users/gdbentley/followers","following_url":"https://api.github.com/users/gdbentley/following{/other_user}","gists_url":"https://api.github.com/users/gdbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbentley/subscriptions","organizations_url":"https://api.github.com/users/gdbentley/orgs","repos_url":"https://api.github.com/users/gdbentley/repos","events_url":"https://api.github.com/users/gdbentley/events{/privacy}","received_events_url":"https://api.github.com/users/gdbentley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/hhvm/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-05-28T04:43:30Z","updated_at":"2016-06-01T15:56:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/7113","html_url":"https://github.com/facebook/hhvm/pull/7113","diff_url":"https://github.com/facebook/hhvm/pull/7113.diff","patch_url":"https://github.com/facebook/hhvm/pull/7113.patch"},"body":"Commit 8863fc1 changed the order of linking libraries. This change puts whole-archive libraries back at the start of the link line (before ordinarily linked libraries). For some reason, the change had caused a thread local variable to be accessed at the wrong offset in StringData::release resulting in a segfault."},"comment":{"url":"https://api.github.com/repos/facebook/hhvm/issues/comments/223039129","html_url":"https://github.com/facebook/hhvm/pull/7113#issuecomment-223039129","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/7113","id":223039129,"user":{"login":"gdbentley","id":4721933,"avatar_url":"https://avatars.githubusercontent.com/u/4721933?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbentley","html_url":"https://github.com/gdbentley","followers_url":"https://api.github.com/users/gdbentley/followers","following_url":"https://api.github.com/users/gdbentley/following{/other_user}","gists_url":"https://api.github.com/users/gdbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbentley/subscriptions","organizations_url":"https://api.github.com/users/gdbentley/orgs","repos_url":"https://api.github.com/users/gdbentley/repos","events_url":"https://api.github.com/users/gdbentley/events{/privacy}","received_events_url":"https://api.github.com/users/gdbentley/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T15:56:55Z","updated_at":"2016-06-01T15:56:55Z","body":"@jwatzman gcc produced the movdqa. I'm not sure that it was incorrect to do so though. I'm not familiar enough with the C++ specification to be sure. If the MemoryUsageStats object were allocated starting at a 16 byte alignment (which it would have been for an ordinary global or a local), then the offset for m_usage would have been 16 byte aligned."}}
{"actor":{"display_login":"gdbentley"}}