{"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit/pulls/comments/61692199","id":61692199,"diff_hunk":"@@ -0,0 +1,62 @@\n+﻿using NUnit.Framework.Interfaces;\n+using System;\n+using System.Collections;\n+using System.Collections.Generic;\n+using System.ComponentModel;\n+using System.IO;\n+using System.Linq;\n+using System.Text;\n+using System.Threading.Tasks;\n+\n+namespace NUnit.Framework\n+{\n+    /// <summary>\n+    /// DataSource housing the test data\n+    /// </summary>\n+    public abstract class DataSource\n+    {\n+        private int rowsToRead = 0;\n+\n+        /// <summary>\n+        /// The number of rows to read from the source.\n+        /// </summary>\n+        /// <remarks>The default is 0 which corresponds to all rows. If a number greater than zero is specified, it reads that number of rows or until the end of the source, which ever is first.</remarks>\n+        public int RowsToRead\n+        {\n+            get\n+            {\n+                return rowsToRead;\n+            }\n+            set\n+            {\n+                if (value < 0)\n+                    throw new Exception(\"Cannot set Rows to Read less than zero\");","path":"src/NUnitFramework/framework/DataSource.cs","position":33,"original_position":33,"commit_id":"e7c24a3020bc650d2a560a219fb982d52317eff4","original_commit_id":"e7c24a3020bc650d2a560a219fb982d52317eff4","user":{"login":"rprouse","id":493828,"avatar_url":"https://avatars.githubusercontent.com/u/493828?v=3","gravatar_id":"","url":"https://api.github.com/users/rprouse","html_url":"https://github.com/rprouse","followers_url":"https://api.github.com/users/rprouse/followers","following_url":"https://api.github.com/users/rprouse/following{/other_user}","gists_url":"https://api.github.com/users/rprouse/gists{/gist_id}","starred_url":"https://api.github.com/users/rprouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rprouse/subscriptions","organizations_url":"https://api.github.com/users/rprouse/orgs","repos_url":"https://api.github.com/users/rprouse/repos","events_url":"https://api.github.com/users/rprouse/events{/privacy}","received_events_url":"https://api.github.com/users/rprouse/received_events","type":"User","site_admin":false},"body":"This should probably be an `ArgumentException`","created_at":"2016-05-01T20:08:27Z","updated_at":"2016-05-01T20:08:27Z","html_url":"https://github.com/nunit/nunit/pull/843#discussion_r61692199","pull_request_url":"https://api.github.com/repos/nunit/nunit/pulls/843","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments/61692199"},"html":{"href":"https://github.com/nunit/nunit/pull/843#discussion_r61692199"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit/pulls/843"}}},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/843","id":45860628,"html_url":"https://github.com/nunit/nunit/pull/843","diff_url":"https://github.com/nunit/nunit/pull/843.diff","patch_url":"https://github.com/nunit/nunit/pull/843.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/843","number":843,"state":"open","locked":false,"title":"Issue 706 - New attribute for test fixtures/cases supporting external data sources","user":{"login":"acco32","id":7876672,"avatar_url":"https://avatars.githubusercontent.com/u/7876672?v=3","gravatar_id":"","url":"https://api.github.com/users/acco32","html_url":"https://github.com/acco32","followers_url":"https://api.github.com/users/acco32/followers","following_url":"https://api.github.com/users/acco32/following{/other_user}","gists_url":"https://api.github.com/users/acco32/gists{/gist_id}","starred_url":"https://api.github.com/users/acco32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acco32/subscriptions","organizations_url":"https://api.github.com/users/acco32/orgs","repos_url":"https://api.github.com/users/acco32/repos","events_url":"https://api.github.com/users/acco32/events{/privacy}","received_events_url":"https://api.github.com/users/acco32/received_events","type":"User","site_admin":false},"body":"***Do not merge***\r\n\r\nJust a checkpoint review. Some items I still need to deal with are removing the test files once the suite (fixture) is run. The only remaining piece is to add the database connection string implementation. I thought this would be a good place to stop and get some feedback. Thanks in advance.\r\n\r\nFixes #706","created_at":"2015-09-24T05:28:52Z","updated_at":"2016-05-01T20:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f331cb415e9954a6d1207c0be02635b2c2173e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/843/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/843/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/843/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/e7c24a3020bc650d2a560a219fb982d52317eff4","head":{"label":"acco32:issue-706","ref":"issue-706","sha":"e7c24a3020bc650d2a560a219fb982d52317eff4","user":{"login":"acco32","id":7876672,"avatar_url":"https://avatars.githubusercontent.com/u/7876672?v=3","gravatar_id":"","url":"https://api.github.com/users/acco32","html_url":"https://github.com/acco32","followers_url":"https://api.github.com/users/acco32/followers","following_url":"https://api.github.com/users/acco32/following{/other_user}","gists_url":"https://api.github.com/users/acco32/gists{/gist_id}","starred_url":"https://api.github.com/users/acco32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acco32/subscriptions","organizations_url":"https://api.github.com/users/acco32/orgs","repos_url":"https://api.github.com/users/acco32/repos","events_url":"https://api.github.com/users/acco32/events{/privacy}","received_events_url":"https://api.github.com/users/acco32/received_events","type":"User","site_admin":false},"repo":{"id":38518609,"name":"nunit","full_name":"acco32/nunit","owner":{"login":"acco32","id":7876672,"avatar_url":"https://avatars.githubusercontent.com/u/7876672?v=3","gravatar_id":"","url":"https://api.github.com/users/acco32","html_url":"https://github.com/acco32","followers_url":"https://api.github.com/users/acco32/followers","following_url":"https://api.github.com/users/acco32/following{/other_user}","gists_url":"https://api.github.com/users/acco32/gists{/gist_id}","starred_url":"https://api.github.com/users/acco32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acco32/subscriptions","organizations_url":"https://api.github.com/users/acco32/orgs","repos_url":"https://api.github.com/users/acco32/repos","events_url":"https://api.github.com/users/acco32/events{/privacy}","received_events_url":"https://api.github.com/users/acco32/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acco32/nunit","description":"NUnit 3.0 framework, engine and console runner","fork":true,"url":"https://api.github.com/repos/acco32/nunit","forks_url":"https://api.github.com/repos/acco32/nunit/forks","keys_url":"https://api.github.com/repos/acco32/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acco32/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acco32/nunit/teams","hooks_url":"https://api.github.com/repos/acco32/nunit/hooks","issue_events_url":"https://api.github.com/repos/acco32/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/acco32/nunit/events","assignees_url":"https://api.github.com/repos/acco32/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/acco32/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/acco32/nunit/tags","blobs_url":"https://api.github.com/repos/acco32/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acco32/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acco32/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/acco32/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acco32/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/acco32/nunit/languages","stargazers_url":"https://api.github.com/repos/acco32/nunit/stargazers","contributors_url":"https://api.github.com/repos/acco32/nunit/contributors","subscribers_url":"https://api.github.com/repos/acco32/nunit/subscribers","subscription_url":"https://api.github.com/repos/acco32/nunit/subscription","commits_url":"https://api.github.com/repos/acco32/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/acco32/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/acco32/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/acco32/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/acco32/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/acco32/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acco32/nunit/merges","archive_url":"https://api.github.com/repos/acco32/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acco32/nunit/downloads","issues_url":"https://api.github.com/repos/acco32/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/acco32/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/acco32/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/acco32/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acco32/nunit/labels{/name}","releases_url":"https://api.github.com/repos/acco32/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/acco32/nunit/deployments","created_at":"2015-07-04T02:29:11Z","updated_at":"2016-01-18T17:46:05Z","pushed_at":"2016-04-30T20:39:52Z","git_url":"git://github.com/acco32/nunit.git","ssh_url":"git@github.com:acco32/nunit.git","clone_url":"https://github.com/acco32/nunit.git","svn_url":"https://github.com/acco32/nunit","homepage":"http://www.nunit.org/","size":31858,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"44d4fd89ba8b652d6d897415f55946afd864ad8c","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?v=3","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?v=3","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 framework, engine and console runner","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2016-04-29T14:38:11Z","pushed_at":"2016-05-01T19:05:17Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":36885,"stargazers_count":618,"watchers_count":618,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"open_issues_count":230,"forks":242,"open_issues":230,"watchers":618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/843"},"html":{"href":"https://github.com/nunit/nunit/pull/843"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/843"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/e7c24a3020bc650d2a560a219fb982d52317eff4"}}}}