{"push_id":1162704659,"size":124,"distinct_size":124,"ref":"refs/heads/4.1","head":"5e86325a8cb3bbe78440662290980c597c1a2d67","before":"cf07f984b16d95719a9ece8c39ed6c11d8c57829","commits":[{"sha":"9ed2f01853d82940b42c795eb541046872c3086b","author":{"name":"Scott Mitchell","email":"376e7fb274235a95251d04d8b0a11832d8c1ba7e@apple.com"},"message":"Revert \"Returns after encoding each message not do check following instance types\"\n\nMotivation:\nThis reverts commit 3405aee2abf990d1f6078eb27da1b0035ab34769. This commit introduces a bug and the encoder no longer encodes FullMemcacheMessage objects correctly.\n\nModifications:\n- Revert commit\n\nResult:\nFixes https://github.com/netty/netty/issues/5197","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/9ed2f01853d82940b42c795eb541046872c3086b"},{"sha":"9b9819c17804fa83155cc6cdf11eb2e64feb2d1a","author":{"name":"Fabian Lange","email":"e96b029d7fa6302af431a2a522304c7f57bf63a2@gmail.com"},"message":"Rewrite misleading Note in FingerprintTrustManagerFactory javadoc\n\nMotivation:\n\nThe current note reads as if this class is dangerous and advises the reader to \"understand what this class does\".\n\nModifications:\n\nRewrite the Javadoc note to describe what fingerprint checks are and what problems remain.\n\nResult:\n\nClearer description which no longer causes the impression this class is dangerous.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/9b9819c17804fa83155cc6cdf11eb2e64feb2d1a"},{"sha":"0557927b655d8ae66933170657e4aad160f8c56e","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"Updating allowNullOrigin to return 'null' instead of '*'.\n\nMotivation:\nCurrently the way a 'null' origin, a request that most often indicated\nthat the request is coming from a file on the local file system, is\nhandled is incorrect. We are currently returning a wildcard origin '*'\nbut should be returning 'null' for the 'Access-Control-Allow-Origin'\nwhich is valid according to the specification [1].\n\nModifications:\nUpdated CorsHandler to add a 'null' origin instead of the '*' origin in\nthe case the request origin is 'null.\n\nResult:\nAll test pass and the CORS example as does the cors.html example if you\ntry to serve it by opening the file directly in a web browser.\n\n[1]\nhttps://www.w3.org/TR/cors/#access-control-allow-origin-response-header","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/0557927b655d8ae66933170657e4aad160f8c56e"},{"sha":"d0cfe24972cd44609a1b1e97aca641a35445134c","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"Clarifying the that a null String is returned by using @{code}","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/d0cfe24972cd44609a1b1e97aca641a35445134c"},{"sha":"a974fff07d9c3c5ff08d3f120f629abe618e2ab6","author":{"name":"Xiaoyan Lin","email":"42fc9537e1e28d23ccf8af2751cbd6b6c197cf4d@gmail.com"},"message":"Add regression tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse\n\nMotivation:\n\nIt's better to have some tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse to avoid regression like #5197.\n\nModifications:\n\nAdd tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse.\n\nResult:\n\nThere are some basic tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/a974fff07d9c3c5ff08d3f120f629abe618e2ab6"},{"sha":"ce1ae0eb8bfec1fc77a2c1c67b34ac1ea1eb327c","author":{"name":"Xiaoyan Lin","email":"42fc9537e1e28d23ccf8af2751cbd6b6c197cf4d@gmail.com"},"message":"Handle the backslash with double quote in JsonObjectDecoder\n\nMotivation:\n\nThe double quote may be escaped in a JSON string, but JsonObjectDecoder doesn't handle it. Resolves #5157.\n\nModifications:\n\nDon't end a JSON string when processing an escaped double quote.\n\nResult:\n\nJsonObjectDecoder can handle backslash and double quote in a JSON string correctly.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/ce1ae0eb8bfec1fc77a2c1c67b34ac1ea1eb327c"},{"sha":"ef13d19b8b5d876463d4365b76d3046410a7811a","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"[#5202] Correctly throw ErrorDataDecoderException when invalid encoded form parameters are present.\n\nMotivation:\n\nAt the moment we let the IllegalArgumentException escape when parsing form parameters. This is not expected.\n\nModifications:\n\nCorrectly catch IllegalArgumentException and rethrow as ErrorDataDecoderException.\n\nResult:\n\nThrow correct exception.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/ef13d19b8b5d876463d4365b76d3046410a7811a"},{"sha":"06436efaa1b118eac3526d8f77d9e159d0292959","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"[#5190] Ensure memory is not leaked when readEndOfLine(...) throws an exception.\n\nMotivation:\n\nWe need to ensure we not retain the buffer until readEndOfLine(...) completes as otherwise we may leak memory in the case of an exception.\n\nModifications:\n\nOnly call retain after readEndOfLine(...) returns.\n\nResult:\n\nNo more leak in case of exception while decoding redis messages.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/06436efaa1b118eac3526d8f77d9e159d0292959"},{"sha":"2b6525856868ab1788db957ff8af8eb22b42c774","author":{"name":"Scott Mitchell","email":"376e7fb274235a95251d04d8b0a11832d8c1ba7e@apple.com"},"message":"FlowControlHandlerTest invalid condition\n\nMotivation:\nFlowControlHandlerTest attempts to validate the expected contents of the underlying queue in FlowControlHandler. However the condition which triggers the check is too early and the queue contents may not yet contain all expected objects. For example a CountDownLatch is counted down in a handler's channelRead which is  after the FlowControlHandler in the pipeline. At this point if there is a thread context switch the queue may not yet contain all the expected objects and checking the queue contents is not valid.\n\nModifications:\n- Remove checking the queues contents in FLowControlHandlerTest and instead only check the empty condition at the end of the tests\n\nResult:\nFlowControlHandlerTest won't fail due to invalid checks of the contents of the queue.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/2b6525856868ab1788db957ff8af8eb22b42c774"},{"sha":"c745ac0e16ffdbc60b6e96fe01947a1da773be78","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"[#3297] Fix race while resolve remote address that can cause NPE\n\nMotivation:\n\nWe may produce a NPE due a race that can happen while check if a resolution was done and failed.\n\nModifications:\n\nCorrectly first check if the resultion is done before try to detect if it failed and so remove the race that can produce a NPE.\n\nResult:\n\nNo more race possible while resolve address during connect.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/c745ac0e16ffdbc60b6e96fe01947a1da773be78"},{"sha":"b2bb72b2de7d2a04899c971242b5808390232265","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"[#5171] Ensure NioDatagramChannelConfig can be instanced on android\n\nMotivation:\n\nNioDatagramChannelConfig currently uses NetworkChannel in its static { } block and so fails to init on android which not has this class.\n\nModifications:\n\nUse reflection to load the NetworkChannel.class\n\nResult:\n\nBe able to use NIO Datagram on android as well.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/b2bb72b2de7d2a04899c971242b5808390232265"},{"sha":"9f5eb7d698477fdabdeadeb66403360984e33954","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"Add CharSequence operations to ByteBuf\n\nMotivation:\n\nOften users either need to read or write CharSequences to a ByteBuf. We should add methods for this to ByteBuf as we can do some optimizations for this depending on the implementation.\n\nModifications:\n\nAdd setCharSequence, writeCharSequence, getCharSequence and readCharSequence\n\nResult:\n\nEasier reading / writing of CharSequence with ByteBuf.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/9f5eb7d698477fdabdeadeb66403360984e33954"},{"sha":"b17ee6066fd1f204a65ead2ff8f88cba20473dda","author":{"name":"Scott Mitchell","email":"376e7fb274235a95251d04d8b0a11832d8c1ba7e@apple.com"},"message":"HTTP/2 Log Cleanup\n\nMotivation:\nThe format of some log lines used the printf style formatting instead of the logger {} formatting for variables. This would lead to printing out the literal printf tokens instead of substituting the value.\n\nModifications:\n- Fix the format string for log statements which use printf style formatting\n\nResult:\nLogs actually capture the value of the variables instead of fixed string tokens.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/b17ee6066fd1f204a65ead2ff8f88cba20473dda"},{"sha":"2472d8c3cff4fc199276c623b153e5942e50f6d7","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"[#5216] Correctly increment deallocationsHuge when call PoolArena.free\n\nMotivation:\n\nWe called deallocationsHuge.decrement() but it needs to be increment()\n\nModifications:\n\nReplace decrement() with increment()\n\nResult:\n\nCorrect metrics.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/2472d8c3cff4fc199276c623b153e5942e50f6d7"},{"sha":"b39c53ce17c1bfadf59e8417c684c01090074efa","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"[#5218] Zero out private key copied to ByteBuf before release.\n\nMotivation:\n\nWe should zero-out the private key as soon as possible when we not need it anymore.\n\nModifications:\n\nzero out the private key before release the buffer.\n\nResult:\n\nLimit the time the private key resist in memory.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/b39c53ce17c1bfadf59e8417c684c01090074efa"},{"sha":"9229ed98e2eb3159abe3195459e0ffc78200d358","author":{"name":"Norman Maurer","email":"aea02ec796b8c3b5db26f08a9fb9d35935be1996@apple.com"},"message":"[#5088] Add annotation which marks packages/interfaces/classes as unstable\n\nMotivation:\n\nSome codecs should be considered unstable as these are relative new. For this purpose we should introduce an annotation which these codecs should us to be marked as unstable in terms of API.\n\nModifications:\n\n- Add UnstableApi annotation and use it on codecs that are not stable\n- Move http2.hpack to http2.internal.hpack as it is internal.\n\nResult:\n\nBetter document unstable APIs.","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/9229ed98e2eb3159abe3195459e0ffc78200d358"},{"sha":"ffd2450e1154ede31b4b1d7e20c887a9e60f2d00","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"Add logging configuration to pom.xml\n\nMotivation:\nCurrently the default log level when running tests is debug. When\nrunning the build on the CI server it might be nice to avoid this debug\nlevel and allow for the level to be configured.\n\nModifications:\nAdded a logback-test.xml configuration that has been added to the\ncommon module. This allows for the logLevel to be configured.\nThe default level will still be debug.\n\nResult:\nThe log level can now be configured from the command line:\n$ mvn test -DlogLevel=error","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/ffd2450e1154ede31b4b1d7e20c887a9e60f2d00"},{"sha":"f2ed3e6ce8039d142e4c047fcc9cf09409105243","author":{"name":"Scott Mitchell","email":"376e7fb274235a95251d04d8b0a11832d8c1ba7e@apple.com"},"message":"DefaultPromise LateListener Logic Issues\n\nMotivation:\nThe LateListener logic is prone to infinite loops and relies on being processed in the EventExecutor's thread for synchronization, but this EventExecutor may not be constant. An infinite loop can occur if the EventExecutor's execute method does not introduce a context switch in LateListener.run. The EventExecutor can be changed by classes which inherit from DefaultPromise. For example the DefaultChannelPromise will return w/e EventLoop the channel is registered to, but this EventLoop can change (re-registration).\n\nModifications:\n- Remove the LateListener concept and instead use a single Object to maintain the listeners while still preserving notification order\n- Make the result member variable an atomic variable so it can be outside the synchronized(this) blocks\n- Cleanup/simplify existing state management code\n\nResult:\nFixes https://github.com/netty/netty/issues/5185","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/f2ed3e6ce8039d142e4c047fcc9cf09409105243"},{"sha":"9ce84dcb21168c45fe6714d3673c9253f35e5cd2","author":{"name":"Moses Nakamura","email":"027e942e2a8d9c3b29816dfa40893330d419351a@twitter.com"},"message":"Http2 to Http1.1 converter on new Http2 server API\n\nMotivation:\n\nhttp/2 and http/1.1 have similar protocols, and it's useful to be able\nto implement a single server against a single interface. There's an\ninjection from http/1.1 messages to http/2 ones, so it makes sense to\nmake folks program against http/1.1 and upgrade them under the hood.\n\nModifications:\n\nadded a MessageToMessageCodec<Http2StreamFrame, HttpObject> which turns\nevery kind of Http2StreamFrame domain object into an HttpObject domain\nobject, and then back again on the way out.  This one is specialized for\nservers, but it should be straightforward to make a symmetric one for\nclients, or else extend this one.\n\nResult:\n\nfixes #5199, and it's now simple to make your Http2MultiplexCodec speak\nHttp1.1","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/9ce84dcb21168c45fe6714d3673c9253f35e5cd2"},{"sha":"d580245afc77f11e4b82a7f3320f5619b555c2ec","author":{"name":"Scott Mitchell","email":"376e7fb274235a95251d04d8b0a11832d8c1ba7e@apple.com"},"message":"DefaultHttp2Connection.close Reentrant Modification\n\nMotivation:\nThe DefaultHttp2Conneciton.close method accounts for active streams being iterated and attempts to avoid reentrant modifications of the underlying stream map by using iterators to remove from the stream map. However there are a few issues:\n\n- While iterating over the stream map we don't prevent iterations over the active stream collection\n- Removing a single stream may actually remove > 1 streams due to closed non-leaf streams being preserved in the priority tree which may result in NPE\n\nPreserving closed non-leaf streams in the priority tree is no longer necessary with our current allocation algorithms, and so this feature (and related complexity) can be removed.\n\nModifications:\n- DefaultHttp2Connection.close should prevent others from iterating over the active streams and reentrant modification scenarios which may result from this\n- DefaultHttp2Connection should not keep closed stream in the priority tree\n  - Remove all associated code in DefaultHttp2RemoteFlowController which accounts for this case including the ReducedState object\n  - This includes fixing writability changes which depended on ReducedState\n- Update unit tests\n\nResult:\nFixes https://github.com/netty/netty/issues/5198","distinct":true,"url":"https://api.github.com/repos/CodingFabian/netty/commits/d580245afc77f11e4b82a7f3320f5619b555c2ec"}]}
{"actor":{"display_login":"CodingFabian"}}