{"action":"created","comment":{"url":"https://api.github.com/repos/openthread/openthread/pulls/comments/87023095","pull_request_review_id":7651340,"id":87023095,"diff_hunk":"@@ -831,6 +856,11 @@ void ActiveDataset::StartLeader(void)\n         dataset.mPanId = mNetif.GetMac().GetPanId();\n         dataset.mIsPanIdSet = true;\n \n+        // Security Policy\n+        dataset.mSecurityPolicy.mRotationTime = KeyManager::kDefaultKeyRotationTime;","path":"src/core/thread/meshcop_dataset_manager.cpp","position":75,"original_position":75,"commit_id":"7a9a563f53707fb8e8298a5063f3bf659efd928d","original_commit_id":"7a9a563f53707fb8e8298a5063f3bf659efd928d","user":{"login":"jwhui","id":16142208,"avatar_url":"https://avatars.githubusercontent.com/u/16142208?v=3","gravatar_id":"","url":"https://api.github.com/users/jwhui","html_url":"https://github.com/jwhui","followers_url":"https://api.github.com/users/jwhui/followers","following_url":"https://api.github.com/users/jwhui/following{/other_user}","gists_url":"https://api.github.com/users/jwhui/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhui/subscriptions","organizations_url":"https://api.github.com/users/jwhui/orgs","repos_url":"https://api.github.com/users/jwhui/repos","events_url":"https://api.github.com/users/jwhui/events{/privacy}","received_events_url":"https://api.github.com/users/jwhui/received_events","type":"User","site_admin":false},"body":"Replace `KeyManager::kDefaultKeyRotationTime` with `mKeyRotationTime`?","created_at":"2016-11-08T16:13:12Z","updated_at":"2016-11-08T16:15:22Z","html_url":"https://github.com/openthread/openthread/pull/948#discussion_r87023095","pull_request_url":"https://api.github.com/repos/openthread/openthread/pulls/948","_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments/87023095"},"html":{"href":"https://github.com/openthread/openthread/pull/948#discussion_r87023095"},"pull_request":{"href":"https://api.github.com/repos/openthread/openthread/pulls/948"}}},"pull_request":{"url":"https://api.github.com/repos/openthread/openthread/pulls/948","id":92746629,"html_url":"https://github.com/openthread/openthread/pull/948","diff_url":"https://github.com/openthread/openthread/pull/948.diff","patch_url":"https://github.com/openthread/openthread/pull/948.patch","issue_url":"https://api.github.com/repos/openthread/openthread/issues/948","number":948,"state":"open","locked":false,"title":"Security Policy feature enhancement.","user":{"login":"chshu","id":20312411,"avatar_url":"https://avatars.githubusercontent.com/u/20312411?v=3","gravatar_id":"","url":"https://api.github.com/users/chshu","html_url":"https://github.com/chshu","followers_url":"https://api.github.com/users/chshu/followers","following_url":"https://api.github.com/users/chshu/following{/other_user}","gists_url":"https://api.github.com/users/chshu/gists{/gist_id}","starred_url":"https://api.github.com/users/chshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chshu/subscriptions","organizations_url":"https://api.github.com/users/chshu/orgs","repos_url":"https://api.github.com/users/chshu/repos","events_url":"https://api.github.com/users/chshu/events{/privacy}","received_events_url":"https://api.github.com/users/chshu/received_events","type":"User","site_admin":false},"body":"* Initialize the Security Policy Tlv in Active Dataset\r\n\r\n* Apply Security Policy configuration from Active Dataset\r\n\r\n* Do not include NetworkMasterKey Tlv in MGMT_GET.rsp if Security Policy 'O' bit is disabled\r\n\r\n* THCI: add startNativeCommissioner() and sendBeacons() support\r\n\r\nIt helps to pass Certification test Leader_5_8_4:\r\n[Leader_5_8_4.zip](https://github.com/openthread/openthread/files/577798/Leader_5_8_4.zip)\r\n","created_at":"2016-11-08T09:59:46Z","updated_at":"2016-11-08T16:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa4fede7d6dc49573b2681b9b734e9c16e63cc40","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openthread/openthread/pulls/948/commits","review_comments_url":"https://api.github.com/repos/openthread/openthread/pulls/948/comments","review_comment_url":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openthread/openthread/issues/948/comments","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/7a9a563f53707fb8e8298a5063f3bf659efd928d","head":{"label":"chshu:pr/security_policy","ref":"pr/security_policy","sha":"7a9a563f53707fb8e8298a5063f3bf659efd928d","user":{"login":"chshu","id":20312411,"avatar_url":"https://avatars.githubusercontent.com/u/20312411?v=3","gravatar_id":"","url":"https://api.github.com/users/chshu","html_url":"https://github.com/chshu","followers_url":"https://api.github.com/users/chshu/followers","following_url":"https://api.github.com/users/chshu/following{/other_user}","gists_url":"https://api.github.com/users/chshu/gists{/gist_id}","starred_url":"https://api.github.com/users/chshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chshu/subscriptions","organizations_url":"https://api.github.com/users/chshu/orgs","repos_url":"https://api.github.com/users/chshu/repos","events_url":"https://api.github.com/users/chshu/events{/privacy}","received_events_url":"https://api.github.com/users/chshu/received_events","type":"User","site_admin":false},"repo":{"id":64193194,"name":"openthread","full_name":"chshu/openthread","owner":{"login":"chshu","id":20312411,"avatar_url":"https://avatars.githubusercontent.com/u/20312411?v=3","gravatar_id":"","url":"https://api.github.com/users/chshu","html_url":"https://github.com/chshu","followers_url":"https://api.github.com/users/chshu/followers","following_url":"https://api.github.com/users/chshu/following{/other_user}","gists_url":"https://api.github.com/users/chshu/gists{/gist_id}","starred_url":"https://api.github.com/users/chshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chshu/subscriptions","organizations_url":"https://api.github.com/users/chshu/orgs","repos_url":"https://api.github.com/users/chshu/repos","events_url":"https://api.github.com/users/chshu/events{/privacy}","received_events_url":"https://api.github.com/users/chshu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chshu/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":true,"url":"https://api.github.com/repos/chshu/openthread","forks_url":"https://api.github.com/repos/chshu/openthread/forks","keys_url":"https://api.github.com/repos/chshu/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chshu/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chshu/openthread/teams","hooks_url":"https://api.github.com/repos/chshu/openthread/hooks","issue_events_url":"https://api.github.com/repos/chshu/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/chshu/openthread/events","assignees_url":"https://api.github.com/repos/chshu/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/chshu/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/chshu/openthread/tags","blobs_url":"https://api.github.com/repos/chshu/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chshu/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chshu/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/chshu/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chshu/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/chshu/openthread/languages","stargazers_url":"https://api.github.com/repos/chshu/openthread/stargazers","contributors_url":"https://api.github.com/repos/chshu/openthread/contributors","subscribers_url":"https://api.github.com/repos/chshu/openthread/subscribers","subscription_url":"https://api.github.com/repos/chshu/openthread/subscription","commits_url":"https://api.github.com/repos/chshu/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/chshu/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/chshu/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/chshu/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/chshu/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/chshu/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chshu/openthread/merges","archive_url":"https://api.github.com/repos/chshu/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chshu/openthread/downloads","issues_url":"https://api.github.com/repos/chshu/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/chshu/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/chshu/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/chshu/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chshu/openthread/labels{/name}","releases_url":"https://api.github.com/repos/chshu/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/chshu/openthread/deployments","created_at":"2016-07-26T05:41:22Z","updated_at":"2016-07-26T05:41:24Z","pushed_at":"2016-11-08T10:55:04Z","git_url":"git://github.com/chshu/openthread.git","ssh_url":"git@github.com:chshu/openthread.git","clone_url":"https://github.com/chshu/openthread.git","svn_url":"https://github.com/chshu/openthread","homepage":"","size":26521,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openthread:master","ref":"master","sha":"266232e2a41ea2204ba64b3973c56660bf67f81b","user":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"repo":{"id":55808787,"name":"openthread","full_name":"openthread/openthread","owner":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openthread/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":false,"url":"https://api.github.com/repos/openthread/openthread","forks_url":"https://api.github.com/repos/openthread/openthread/forks","keys_url":"https://api.github.com/repos/openthread/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openthread/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openthread/openthread/teams","hooks_url":"https://api.github.com/repos/openthread/openthread/hooks","issue_events_url":"https://api.github.com/repos/openthread/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/openthread/openthread/events","assignees_url":"https://api.github.com/repos/openthread/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/openthread/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/openthread/openthread/tags","blobs_url":"https://api.github.com/repos/openthread/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openthread/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openthread/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/openthread/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/openthread/openthread/languages","stargazers_url":"https://api.github.com/repos/openthread/openthread/stargazers","contributors_url":"https://api.github.com/repos/openthread/openthread/contributors","subscribers_url":"https://api.github.com/repos/openthread/openthread/subscribers","subscription_url":"https://api.github.com/repos/openthread/openthread/subscription","commits_url":"https://api.github.com/repos/openthread/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/openthread/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/openthread/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/openthread/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/openthread/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/openthread/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openthread/openthread/merges","archive_url":"https://api.github.com/repos/openthread/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openthread/openthread/downloads","issues_url":"https://api.github.com/repos/openthread/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/openthread/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/openthread/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/openthread/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openthread/openthread/labels{/name}","releases_url":"https://api.github.com/repos/openthread/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/openthread/openthread/deployments","created_at":"2016-04-08T20:47:41Z","updated_at":"2016-11-08T07:47:21Z","pushed_at":"2016-11-08T16:01:45Z","git_url":"git://github.com/openthread/openthread.git","ssh_url":"git@github.com:openthread/openthread.git","clone_url":"https://github.com/openthread/openthread.git","svn_url":"https://github.com/openthread/openthread","homepage":"","size":564690,"stargazers_count":1016,"watchers_count":1016,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":230,"mirror_url":null,"open_issues_count":47,"forks":230,"open_issues":47,"watchers":1016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/948"},"html":{"href":"https://github.com/openthread/openthread/pull/948"},"issue":{"href":"https://api.github.com/repos/openthread/openthread/issues/948"},"comments":{"href":"https://api.github.com/repos/openthread/openthread/issues/948/comments"},"review_comments":{"href":"https://api.github.com/repos/openthread/openthread/pulls/948/comments"},"review_comment":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openthread/openthread/pulls/948/commits"},"statuses":{"href":"https://api.github.com/repos/openthread/openthread/statuses/7a9a563f53707fb8e8298a5063f3bf659efd928d"}}}}
{"actor":{"display_login":"jwhui"}}