{"action":"created","comment":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments/52226865","id":52226865,"diff_hunk":"@@ -152,6 +145,59 @@ class EditBuffer;\n  *\n  */\n \n+\n+\n+class ObjectMOBuffer\n+{\n+private:\n+\n+    // Used to draw the objects where the color correspond to the object's ID, in order to find the correct object when hovering\n+    Cairo::RefPtr<Cairo::ImageSurface> objectMap;\n+    // If more than 254 objects has to be handled, objectMap2 contains the \"upper part\" of the 16 bit int value. objectMap2 will be NULL otherwise.\n+    Cairo::RefPtr<Cairo::ImageSurface> objectMap2;\n+    ObjectMode objectMode;\n+\n+protected:\n+\n+    // To avoid duplicated information, we points to a EditDataProvider that contains the current EditSubscriber\n+    // instead of pointing to the EditSubscriber directly\n+    EditDataProvider* dataProvider;\n+\n+    void createBuffer(int width, int height);\n+    void resize(int newWidth, int newHeight, EditSubscriber* newSubscriber);","path":"rtgui/edit.h","position":64,"original_position":64,"commit_id":"4665b88788528e1792aae5be435b421abb7ad1f4","original_commit_id":"4665b88788528e1792aae5be435b421abb7ad1f4","user":{"login":"adamreichold","id":12997846,"avatar_url":"https://avatars.githubusercontent.com/u/12997846?v=3","gravatar_id":"","url":"https://api.github.com/users/adamreichold","html_url":"https://github.com/adamreichold","followers_url":"https://api.github.com/users/adamreichold/followers","following_url":"https://api.github.com/users/adamreichold/following{/other_user}","gists_url":"https://api.github.com/users/adamreichold/gists{/gist_id}","starred_url":"https://api.github.com/users/adamreichold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamreichold/subscriptions","organizations_url":"https://api.github.com/users/adamreichold/orgs","repos_url":"https://api.github.com/users/adamreichold/repos","events_url":"https://api.github.com/users/adamreichold/events{/privacy}","received_events_url":"https://api.github.com/users/adamreichold/received_events","type":"User","site_admin":false},"body":"The third parameter looks like it wants a separate method. Even if a size and subscriber change often happen together, it looks dubious IMHO.","created_at":"2016-02-08T21:18:25Z","updated_at":"2016-02-08T21:18:25Z","html_url":"https://github.com/Beep6581/RawTherapee/pull/3142#discussion_r52226865","pull_request_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142","_links":{"self":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments/52226865"},"html":{"href":"https://github.com/Beep6581/RawTherapee/pull/3142#discussion_r52226865"},"pull_request":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142"}}},"pull_request":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142","id":58660256,"html_url":"https://github.com/Beep6581/RawTherapee/pull/3142","diff_url":"https://github.com/Beep6581/RawTherapee/pull/3142.diff","patch_url":"https://github.com/Beep6581/RawTherapee/pull/3142.patch","issue_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3142","number":3142,"state":"open","locked":false,"title":"Modified Preview Canvas","user":{"login":"adamreichold","id":12997846,"avatar_url":"https://avatars.githubusercontent.com/u/12997846?v=3","gravatar_id":"","url":"https://api.github.com/users/adamreichold","html_url":"https://github.com/adamreichold","followers_url":"https://api.github.com/users/adamreichold/followers","following_url":"https://api.github.com/users/adamreichold/following{/other_user}","gists_url":"https://api.github.com/users/adamreichold/gists{/gist_id}","starred_url":"https://api.github.com/users/adamreichold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamreichold/subscriptions","organizations_url":"https://api.github.com/users/adamreichold/orgs","repos_url":"https://api.github.com/users/adamreichold/repos","events_url":"https://api.github.com/users/adamreichold/events{/privacy}","received_events_url":"https://api.github.com/users/adamreichold/received_events","type":"User","site_admin":false},"body":"- Now the Preview can show free space around the image (the image's\r\ncorner will coincide with the center of the preview area)\r\n- Editing objects can now be manipulated in this free space\r\n- The editing mechanism has been split : it was completely handled in\r\nrtengine before, now rtengine still handle the pipette's data provider,\r\nbut rtgui now handle the objects data provider.\r\n- Bugfix: when using coarse rotate in the Editor panel, the Gradient\r\nwidgets are now correctly displayed","created_at":"2016-02-08T20:09:53Z","updated_at":"2016-02-08T21:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f45b572304de64facf09064f4c03f14457c66d99","assignee":{"login":"adamreichold","id":12997846,"avatar_url":"https://avatars.githubusercontent.com/u/12997846?v=3","gravatar_id":"","url":"https://api.github.com/users/adamreichold","html_url":"https://github.com/adamreichold","followers_url":"https://api.github.com/users/adamreichold/followers","following_url":"https://api.github.com/users/adamreichold/following{/other_user}","gists_url":"https://api.github.com/users/adamreichold/gists{/gist_id}","starred_url":"https://api.github.com/users/adamreichold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamreichold/subscriptions","organizations_url":"https://api.github.com/users/adamreichold/orgs","repos_url":"https://api.github.com/users/adamreichold/repos","events_url":"https://api.github.com/users/adamreichold/events{/privacy}","received_events_url":"https://api.github.com/users/adamreichold/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142/commits","review_comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142/comments","review_comment_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3142/comments","statuses_url":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/4665b88788528e1792aae5be435b421abb7ad1f4","head":{"label":"Beep6581:NewPreviewCanvas","ref":"NewPreviewCanvas","sha":"4665b88788528e1792aae5be435b421abb7ad1f4","user":{"login":"Beep6581","id":5844619,"avatar_url":"https://avatars.githubusercontent.com/u/5844619?v=3","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"repo":{"id":40539005,"name":"RawTherapee","full_name":"Beep6581/RawTherapee","owner":{"login":"Beep6581","id":5844619,"avatar_url":"https://avatars.githubusercontent.com/u/5844619?v=3","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Beep6581/RawTherapee","description":"A powerful cross-platform raw photo processing program","fork":false,"url":"https://api.github.com/repos/Beep6581/RawTherapee","forks_url":"https://api.github.com/repos/Beep6581/RawTherapee/forks","keys_url":"https://api.github.com/repos/Beep6581/RawTherapee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beep6581/RawTherapee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beep6581/RawTherapee/teams","hooks_url":"https://api.github.com/repos/Beep6581/RawTherapee/hooks","issue_events_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/events{/number}","events_url":"https://api.github.com/repos/Beep6581/RawTherapee/events","assignees_url":"https://api.github.com/repos/Beep6581/RawTherapee/assignees{/user}","branches_url":"https://api.github.com/repos/Beep6581/RawTherapee/branches{/branch}","tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/tags","blobs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/{sha}","languages_url":"https://api.github.com/repos/Beep6581/RawTherapee/languages","stargazers_url":"https://api.github.com/repos/Beep6581/RawTherapee/stargazers","contributors_url":"https://api.github.com/repos/Beep6581/RawTherapee/contributors","subscribers_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscribers","subscription_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscription","commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beep6581/RawTherapee/contents/{+path}","compare_url":"https://api.github.com/repos/Beep6581/RawTherapee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beep6581/RawTherapee/merges","archive_url":"https://api.github.com/repos/Beep6581/RawTherapee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beep6581/RawTherapee/downloads","issues_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues{/number}","pulls_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls{/number}","milestones_url":"https://api.github.com/repos/Beep6581/RawTherapee/milestones{/number}","notifications_url":"https://api.github.com/repos/Beep6581/RawTherapee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/labels{/name}","releases_url":"https://api.github.com/repos/Beep6581/RawTherapee/releases{/id}","deployments_url":"https://api.github.com/repos/Beep6581/RawTherapee/deployments","created_at":"2015-08-11T11:54:01Z","updated_at":"2016-02-01T10:40:59Z","pushed_at":"2016-02-08T20:09:53Z","git_url":"git://github.com/Beep6581/RawTherapee.git","ssh_url":"git@github.com:Beep6581/RawTherapee.git","clone_url":"https://github.com/Beep6581/RawTherapee.git","svn_url":"https://github.com/Beep6581/RawTherapee","homepage":"http://rawtherapee.com/","size":94344,"stargazers_count":154,"watchers_count":154,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":527,"forks":27,"open_issues":527,"watchers":154,"default_branch":"master"}},"base":{"label":"Beep6581:master","ref":"master","sha":"23ea31cd7867dc18b7827032a8b6759fcc4b10b6","user":{"login":"Beep6581","id":5844619,"avatar_url":"https://avatars.githubusercontent.com/u/5844619?v=3","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"repo":{"id":40539005,"name":"RawTherapee","full_name":"Beep6581/RawTherapee","owner":{"login":"Beep6581","id":5844619,"avatar_url":"https://avatars.githubusercontent.com/u/5844619?v=3","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Beep6581/RawTherapee","description":"A powerful cross-platform raw photo processing program","fork":false,"url":"https://api.github.com/repos/Beep6581/RawTherapee","forks_url":"https://api.github.com/repos/Beep6581/RawTherapee/forks","keys_url":"https://api.github.com/repos/Beep6581/RawTherapee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beep6581/RawTherapee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beep6581/RawTherapee/teams","hooks_url":"https://api.github.com/repos/Beep6581/RawTherapee/hooks","issue_events_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/events{/number}","events_url":"https://api.github.com/repos/Beep6581/RawTherapee/events","assignees_url":"https://api.github.com/repos/Beep6581/RawTherapee/assignees{/user}","branches_url":"https://api.github.com/repos/Beep6581/RawTherapee/branches{/branch}","tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/tags","blobs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/{sha}","languages_url":"https://api.github.com/repos/Beep6581/RawTherapee/languages","stargazers_url":"https://api.github.com/repos/Beep6581/RawTherapee/stargazers","contributors_url":"https://api.github.com/repos/Beep6581/RawTherapee/contributors","subscribers_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscribers","subscription_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscription","commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beep6581/RawTherapee/contents/{+path}","compare_url":"https://api.github.com/repos/Beep6581/RawTherapee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beep6581/RawTherapee/merges","archive_url":"https://api.github.com/repos/Beep6581/RawTherapee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beep6581/RawTherapee/downloads","issues_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues{/number}","pulls_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls{/number}","milestones_url":"https://api.github.com/repos/Beep6581/RawTherapee/milestones{/number}","notifications_url":"https://api.github.com/repos/Beep6581/RawTherapee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/labels{/name}","releases_url":"https://api.github.com/repos/Beep6581/RawTherapee/releases{/id}","deployments_url":"https://api.github.com/repos/Beep6581/RawTherapee/deployments","created_at":"2015-08-11T11:54:01Z","updated_at":"2016-02-01T10:40:59Z","pushed_at":"2016-02-08T20:09:53Z","git_url":"git://github.com/Beep6581/RawTherapee.git","ssh_url":"git@github.com:Beep6581/RawTherapee.git","clone_url":"https://github.com/Beep6581/RawTherapee.git","svn_url":"https://github.com/Beep6581/RawTherapee","homepage":"http://rawtherapee.com/","size":94344,"stargazers_count":154,"watchers_count":154,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":527,"forks":27,"open_issues":527,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142"},"html":{"href":"https://github.com/Beep6581/RawTherapee/pull/3142"},"issue":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3142"},"comments":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3142/comments"},"review_comments":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142/comments"},"review_comment":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3142/commits"},"statuses":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/4665b88788528e1792aae5be435b421abb7ad1f4"}}}}