{"action":"opened","issue":{"url":"https://api.github.com/repos/openwrt/packages/issues/2910","repository_url":"https://api.github.com/repos/openwrt/packages","labels_url":"https://api.github.com/repos/openwrt/packages/issues/2910/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/packages/issues/2910/comments","events_url":"https://api.github.com/repos/openwrt/packages/issues/2910/events","html_url":"https://github.com/openwrt/packages/issues/2910","id":163070233,"number":2910,"title":"stoken package is broken","user":{"login":"dlenski","id":128716,"avatar_url":"https://avatars.githubusercontent.com/u/128716?v=3","gravatar_id":"","url":"https://api.github.com/users/dlenski","html_url":"https://github.com/dlenski","followers_url":"https://api.github.com/users/dlenski/followers","following_url":"https://api.github.com/users/dlenski/following{/other_user}","gists_url":"https://api.github.com/users/dlenski/gists{/gist_id}","starred_url":"https://api.github.com/users/dlenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlenski/subscriptions","organizations_url":"https://api.github.com/users/dlenski/orgs","repos_url":"https://api.github.com/users/dlenski/repos","events_url":"https://api.github.com/users/dlenski/events{/privacy}","received_events_url":"https://api.github.com/users/dlenski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-06-30T02:50:34Z","updated_at":"2016-06-30T02:50:34Z","closed_at":null,"body":"The stoken package is broken because it installs the `stoken` shell script wrapper rather than the actual executable, which ends up in `.libs/stoken` in the build directory:\r\n\r\n```diff\r\ndiff --git a/utils/stoken/Makefile b/utils/stoken/Makefile\r\nindex 7fcbdad..b20e18e 100644\r\n--- a/utils/stoken/Makefile\r\n+++ b/utils/stoken/Makefile\r\n@@ -65,7 +65,7 @@ endef\r\n \r\n define Package/stoken/install\r\n        $(INSTALL_DIR) $(1)/usr/bin\r\n-       $(INSTALL_BIN) $(PKG_BUILD_DIR)/stoken $(1)/usr/bin/\r\n+       $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/stoken $(1)/usr/bin/\r\n endef\r\n \r\n define Package/libstoken/install\r\n```\r\n\r\nThis can be seen in any of the OpenWRT 15.05 builds of this package (e.g https://downloads.openwrt.org/chaos_calmer/15.05/bcm53xx/generic/packages/packages/libstoken_0.8-1_bcm53xx.ipk, which I was trying to install). The `stoken` file in the package is a wrapper script which begins with the following (accurate!) warning:\r\n\r\n```sh\r\n# This wrapper script should never be moved out of the build directory.\r\n# If it is, it will not operate correctly.\r\n```"}}
{"actor":{"display_login":"dlenski"}}