{"action":"created","issue":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2613","repository_url":"https://api.github.com/repos/sandstorm-io/sandstorm","labels_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2613/labels{/name}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2613/comments","events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2613/events","html_url":"https://github.com/sandstorm-io/sandstorm/issues/2613","id":180469482,"number":2613,"title":"Inverse the sorting of permissions an roles in sandstorm-pkgdef.capnp","user":{"login":"alexander-vidoni","id":22469842,"avatar_url":"https://avatars.githubusercontent.com/u/22469842?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-vidoni","html_url":"https://github.com/alexander-vidoni","followers_url":"https://api.github.com/users/alexander-vidoni/followers","following_url":"https://api.github.com/users/alexander-vidoni/following{/other_user}","gists_url":"https://api.github.com/users/alexander-vidoni/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-vidoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-vidoni/subscriptions","organizations_url":"https://api.github.com/users/alexander-vidoni/orgs","repos_url":"https://api.github.com/users/alexander-vidoni/repos","events_url":"https://api.github.com/users/alexander-vidoni/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-vidoni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-01T17:38:10Z","updated_at":"2016-10-01T20:39:14Z","closed_at":null,"body":"In *sandstorm-pkgdef.capnp* the sample permission array is sorted from *high* permissions to *low* permissions and the roles follow in the same order.\r\n\r\nWhen you open the ShareAccess dialog in the top menue you find the roles in the same order as they are specified in the config file (sandstorm-pkgdef.capnp).\r\n\r\nThe problem:\r\n\r\nIf you want to share a grain and you are in a hurry it is too easy to create a link or an email link with the most prvileged role. \r\n\r\nSolution:\r\n\r\nList the permission and roles (in sandstorm-pkgdef.capnp) in *ascending* order. \r\nIf you do so, you only could grant the lowest privilege by mistake than the highest.\r\n\r\nThanks for reading.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/comments/250936243","html_url":"https://github.com/sandstorm-io/sandstorm/issues/2613#issuecomment-250936243","issue_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2613","id":250936243,"user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars.githubusercontent.com/u/4001805?v=3","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"created_at":"2016-10-01T20:39:14Z","updated_at":"2016-10-01T20:39:14Z","body":"Hi Alexander,\r\n\r\nApps can actually specify which role should be the default in the sharing dialog by setting `default = true` on one of the roles. But I agree with @ocdtrekkie that it's not entirely clear what the default role should be. With Etherpad I intentionally chose \"edit\" as the default because that's almost always what I want in practice.\r\n\r\nNote that you cannot reorder the roles after an app has been published -- doing so will break compatibility with existing shares, since the role granted by a share is stored by numeric index."}}
{"actor":{"display_login":"kentonv"}}