{"action":"created","issue":{"url":"https://api.github.com/repos/graphql/express-graphql/issues/119","repository_url":"https://api.github.com/repos/graphql/express-graphql","labels_url":"https://api.github.com/repos/graphql/express-graphql/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/graphql/express-graphql/issues/119/comments","events_url":"https://api.github.com/repos/graphql/express-graphql/issues/119/events","html_url":"https://github.com/graphql/express-graphql/pull/119","id":174676116,"number":119,"title":"Re-enable express etag support","user":{"login":"brandondoran","id":1189930,"avatar_url":"https://avatars.githubusercontent.com/u/1189930?v=3","gravatar_id":"","url":"https://api.github.com/users/brandondoran","html_url":"https://github.com/brandondoran","followers_url":"https://api.github.com/users/brandondoran/followers","following_url":"https://api.github.com/users/brandondoran/following{/other_user}","gists_url":"https://api.github.com/users/brandondoran/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondoran/subscriptions","organizations_url":"https://api.github.com/users/brandondoran/orgs","repos_url":"https://api.github.com/users/brandondoran/repos","events_url":"https://api.github.com/users/brandondoran/events{/privacy}","received_events_url":"https://api.github.com/users/brandondoran/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/graphql/express-graphql/labels/CLA%20Signed","name":"CLA Signed","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-02T04:02:48Z","updated_at":"2016-09-02T04:59:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graphql/express-graphql/pulls/119","html_url":"https://github.com/graphql/express-graphql/pull/119","diff_url":"https://github.com/graphql/express-graphql/pull/119.diff","patch_url":"https://github.com/graphql/express-graphql/pull/119.patch"},"body":"The express `response.send` provides some extra functionality, such as adding an ETag header. https://github.com/graphql/express-graphql/commit/48e6659945477bd706fe22173f450c16eddd5bf5 removed `.send` in favor of `.end` in order to support connect. This PR adds a helper function, `sendResponse`, which calls `response.send` if that method exists (i.e. the server is express), otherwise fallback to `response.end`.\r\n\r\nIn order to test that the correct method is called, I added sinon as a devDependency and a single test that uses a spy to verify that `send` is called when the server is express. \r\n\r\nThis fixes #115"},"comment":{"url":"https://api.github.com/repos/graphql/express-graphql/issues/comments/244283520","html_url":"https://github.com/graphql/express-graphql/pull/119#issuecomment-244283520","issue_url":"https://api.github.com/repos/graphql/express-graphql/issues/119","id":244283520,"user":{"login":"facebook-github-bot-9","id":8398713,"avatar_url":"https://avatars.githubusercontent.com/u/8398713?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot-9","html_url":"https://github.com/facebook-github-bot-9","followers_url":"https://api.github.com/users/facebook-github-bot-9/followers","following_url":"https://api.github.com/users/facebook-github-bot-9/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot-9/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot-9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot-9/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot-9/orgs","repos_url":"https://api.github.com/users/facebook-github-bot-9/repos","events_url":"https://api.github.com/users/facebook-github-bot-9/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot-9/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T04:59:10Z","updated_at":"2016-09-02T04:59:10Z","body":"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!"}}
{"actor":{"display_login":"facebook-github-bot-9"}}