{"action":"created","issue":{"url":"https://api.github.com/repos/giuspen/cherrytree/issues/116","repository_url":"https://api.github.com/repos/giuspen/cherrytree","labels_url":"https://api.github.com/repos/giuspen/cherrytree/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/giuspen/cherrytree/issues/116/comments","events_url":"https://api.github.com/repos/giuspen/cherrytree/issues/116/events","html_url":"https://github.com/giuspen/cherrytree/pull/116","id":140455512,"number":116,"title":"Basic implementation of line height settings.","user":{"login":"bfloch","id":2116566,"avatar_url":"https://avatars.githubusercontent.com/u/2116566?v=3","gravatar_id":"","url":"https://api.github.com/users/bfloch","html_url":"https://github.com/bfloch","followers_url":"https://api.github.com/users/bfloch/followers","following_url":"https://api.github.com/users/bfloch/following{/other_user}","gists_url":"https://api.github.com/users/bfloch/gists{/gist_id}","starred_url":"https://api.github.com/users/bfloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfloch/subscriptions","organizations_url":"https://api.github.com/users/bfloch/orgs","repos_url":"https://api.github.com/users/bfloch/repos","events_url":"https://api.github.com/users/bfloch/events{/privacy}","received_events_url":"https://api.github.com/users/bfloch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-13T06:34:18Z","updated_at":"2016-03-13T09:55:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/giuspen/cherrytree/pulls/116","html_url":"https://github.com/giuspen/cherrytree/pull/116","diff_url":"https://github.com/giuspen/cherrytree/pull/116.diff","patch_url":"https://github.com/giuspen/cherrytree/pull/116.patch"},"body":"This adds an unique option to the settings/config which drives GtkSourceView/GtkTextView.set_pixels_above_lines and set_pixels_below_lines.\r\n\r\nSolves one TODO on your list and this request: [www.giuspen.com/topic/line-height-setting/](http://www.giuspen.com/topic/line-height-setting/)\r\n\r\nA proper implementation could be relative line-height based on the font height, but I felt that this basic implementation works well enough.\r\n\r\n**Please note**: This adds an offset to the line numbers (which seems to be an SourceView issue as the above spacing is not being added to the numbers/gutter), but the numbers still match.\r\nThe only alternative I see is only adding the space below, but then the line highlight would be off, which I personally find more distracting."},"comment":{"url":"https://api.github.com/repos/giuspen/cherrytree/issues/comments/195926018","html_url":"https://github.com/giuspen/cherrytree/pull/116#issuecomment-195926018","issue_url":"https://api.github.com/repos/giuspen/cherrytree/issues/116","id":195926018,"user":{"login":"giuspen","id":6842059,"avatar_url":"https://avatars.githubusercontent.com/u/6842059?v=3","gravatar_id":"","url":"https://api.github.com/users/giuspen","html_url":"https://github.com/giuspen","followers_url":"https://api.github.com/users/giuspen/followers","following_url":"https://api.github.com/users/giuspen/following{/other_user}","gists_url":"https://api.github.com/users/giuspen/gists{/gist_id}","starred_url":"https://api.github.com/users/giuspen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuspen/subscriptions","organizations_url":"https://api.github.com/users/giuspen/orgs","repos_url":"https://api.github.com/users/giuspen/repos","events_url":"https://api.github.com/users/giuspen/events{/privacy}","received_events_url":"https://api.github.com/users/giuspen/received_events","type":"User","site_admin":false},"created_at":"2016-03-13T09:55:53Z","updated_at":"2016-03-13T09:55:53Z","body":"Thank you for your work, I'm going to merge it in a couple of days, just\nafter releasing 0.36.7\n\nOn 13 March 2016 at 06:38, StateOffGames <notifications@github.com> wrote:\n\n> Also worth mentioning, this does not affect code boxes.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/giuspen/cherrytree/pull/116#issuecomment-195892505>.\n>\n"}}