{"push_id":1314681513,"size":23,"distinct_size":1,"ref":"refs/heads/xplat","head":"3544aed53005e0cf425bbf1029a298ef7fdace7d","before":"7aa57161a22fe64b6226cf5da06e02538c92427a","commits":[{"sha":"750c3e646277855d3e99062f14064eee63bc069c","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Enable Exec child process failure test\n\nThis was disable for a long time due to #566, but that has been long fixed\nby taking an update to CoreFX packages that had the fix for the root\ncause.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/750c3e646277855d3e99062f14064eee63bc069c"},{"sha":"5769095057127fbd28829fcb2665c0e085a2447a","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Generalize expected `cp` error\n\nOn Mac OS X 10.11.6 (at least), errors from `cp` about nonexistent files\ndon't say \"cannot stat\". Generalizing the search.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/5769095057127fbd28829fcb2665c0e085a2447a"},{"sha":"10b096c0094d8e100baba40ae7a949ebced255a7","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Merge pull request #1034 from rainersigwald/reenable-exec-test-for-#566\n\nReenable exec test for #566","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/10b096c0094d8e100baba40ae7a949ebced255a7"},{"sha":"a93cdba37949babce47db75e844e3631a98bb1a6","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Test assembly name -> MyAssembly\n\nThis was changed in master but mismerged with changes to do Path.Combine\nin xplat. Updating everything to use the new name.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/a93cdba37949babce47db75e844e3631a98bb1a6"},{"sha":"383d7c46ff1d74a10cba827f9de3b31efef53c9e","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Check registry for SDKs on Windows\n\nPretty sure the intent of the OS condition here was to only use the\nregistry on Windows, even though it said the opposite.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/383d7c46ff1d74a10cba827f9de3b31efef53c9e"},{"sha":"a03d9d0184ce901dabc2f0a0c7e82d446003eab8","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Specific asserts in ResolveSDKFromRegistryAndDisk\n\nThis method was filled with Assert.True invocations, which made debugging\nit pretty painful (every assertion would fail the same way). Switching to\nmore specific assertions to get clearer errors.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/a03d9d0184ce901dabc2f0a0c7e82d446003eab8"},{"sha":"e06dbb083c07a92dec5d28c9923de5061d7285ef","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Correct platform in ResolveSDKFromRegistryAndDisk\n\nIn the master branch this comparison is\n\n```\nAssert.True(targetPlatforms[key].Path.Equals(Path.Combine(_fakeStructureRoot, \"MyPlatform\\\\2.0\\\\\"), StringComparison.OrdinalIgnoreCase));\n```\n\nBut in xplat we had `MyAssembly` instead.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/e06dbb083c07a92dec5d28c9923de5061d7285ef"},{"sha":"e7569569c76a04c210c686f834350adc6853f271","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Add trailing slash in ResolveSDKFromRegistryAndDisk\n\nA trailing slash is added in most of the comparisons in this method but\nwas missed here, causing this assert to fail.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/e7569569c76a04c210c686f834350adc6853f271"},{"sha":"3f07b9129df3722d4e96d19430bbc6ef7e508423","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Enable ResolveSDKFromRegistryAndDisk tests\n\nThese tests were failing in xplat on the desktop framework. Enabling them\nto reduce diffs in #799.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/3f07b9129df3722d4e96d19430bbc6ef7e508423"},{"sha":"5fd86cfd6e0a1eb6a4138a120d806c15828901d4","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Merge pull request #1047 from rainersigwald/xplat-ResolveSDKFromRegistryAndDisk\n\nFix ResolveSDKFromRegistryAndDisk test on xplat","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/5fd86cfd6e0a1eb6a4138a120d806c15828901d4"},{"sha":"76c374355873526d9ff227d068d2cf91c92248f5","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Use full path in SpecificVersionFalse test\n\nIn master, this assert is:\n\n```\nAssert.Equal(@\"c:\\WINNT\\Microsoft.NET\\Framework\\v2.0.MyVersion\\System.XML.dll\", t.ResolvedFiles[0].ItemSpec);\n```\n\nBut in xplat, it was checking only against the directory, not the file\nitself. Progress toward #799.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/76c374355873526d9ff227d068d2cf91c92248f5"},{"sha":"e0ff3880472f877c1862db67f690db1915bcfc2e","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Enable GetGoodSDKs tests for #799","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/e0ff3880472f877c1862db67f690db1915bcfc2e"},{"sha":"5832505239269e004743a214232d8bf7139fee2d","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Correct case in reflection for StrongName\n\nThis static property was changed to use reflection in 3b92da61, but the\nmethod name was the wrong case, so it always failed to find the method,\ncausing `AxTlbBaseTask_Tests.KeyContainer` to fail.\n\nFixing the reflection allows turning the test back on to make some more\nprogress on #799.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/5832505239269e004743a214232d8bf7139fee2d"},{"sha":"bb32c468e2a2fd652de7f3915a187e86abf6354c","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Don't crash in NeedSeparateAppDomain when no file\n\nTo go cross-platform, we moved from XmlTextReader to XmlReader, since only\nthe latter is supported in .NET Core. This introduced a subtle difference\nin behavior: XmlTextReader doesn't throw on construction when given a\nnonexistent file (it throws on the first .Read()), but XmlReader.Create\ndoes throw immediately. That meant that the old error handling for\nnonexistent file (unconditionally call `reader.Close()` in the `finally`\nblock) was no longer valid, because `reader` might be null--because the\nstatement where it gets assigned was what threw.\n\nThe solution is simple: only `Close` the reader if it's not null.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/bb32c468e2a2fd652de7f3915a187e86abf6354c"},{"sha":"7a038816e3f01bddcb6f93f570e129bdbe5f158a","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Disable UnsupportedTextType only on netcore","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/7a038816e3f01bddcb6f93f570e129bdbe5f158a"},{"sha":"dec72ee8ee38be476bea1224b6d2f2cbe57f9166","author":{"name":"Jeff Kluge","email":"1fb0b67ddb6632c6e78315608f3f7187af995d8b@microsoft.com"},"message":"Update ref API for Microsoft.Build.Tasks.Core (#1041)\n\n- New property bool UseSymboliclinksIfPossible","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/dec72ee8ee38be476bea1224b6d2f2cbe57f9166"},{"sha":"dc8e152cc8bfc138036931f7d36379342ba96515","author":{"name":"Jeff Kluge","email":"1fb0b67ddb6632c6e78315608f3f7187af995d8b@microsoft.com"},"message":"Fix bad dependency in Microsoft.Build.Tasks.Core package to System.Resources.Reader (#1070)\n\nSystem.Resources.Reader should be 4.0.0 which it is for the other packages.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/dc8e152cc8bfc138036931f7d36379342ba96515"},{"sha":"b8096d3f55c4af54ca160e23f918991f1d207c8c","author":{"name":"Nick Guerrera","email":"d253de2e036efd4bc2b8127fbae43e811a1813a5@microsoft.com"},"message":"Port cross-targeting target changes to xplat (#1067)\n\nCherry-pick 93f8c8a50b1586e27cb93ed92f6910df4fcba29f:\r\n\r\nAdd common targets and extensibility x-targeting targets\r\n\r\n1. Move build,clean,rebuild targets and dispatch helper up from SDK targets\r\n2. Pull in nuget restore targets\r\n3. Pull in package-provided targets","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/b8096d3f55c4af54ca160e23f918991f1d207c8c"},{"sha":"fe67d5fa9486bbac13ca609e1fed54ca7be2a248","author":{"name":"dotnet-bot","email":"f84cdf622175726c596bcedcda3805233e2ca5f8@microsoft.com"},"message":"Automated commit of revision number value 00040.","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/fe67d5fa9486bbac13ca609e1fed54ca7be2a248"},{"sha":"9a0504227204b9d8a837ef482acb16d852df0166","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Merge pull request #1052 from rainersigwald/enable-xplat-tests\n\nLast batch of xplat full framework tests for #799","distinct":false,"url":"https://api.github.com/repos/cdmihai/msbuild/commits/9a0504227204b9d8a837ef482acb16d852df0166"}]}
{"actor":{"display_login":"cdmihai"}}