{"action":"created","comment":{"url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments/52977654","id":52977654,"diff_hunk":"@@ -347,4 +392,18 @@ class MyCustomApplicationLoader extends ApplicationLoader {\n     (new GuiceApplicationLoader).load(newContext)\n   }\n }\n-```\n\\ No newline at end of file\n+```\n+\n+#### Play 2.3\n+\n+```scala\n+import play.api._\n+import com.typesafe.conductr.bundlelib.play.Env\n+\n+object Global extends GlobalSettings {\n+  val totalConfiguration = super.configuration ++ Configuration(Env.asConfig)","path":"README.md","position":105,"original_position":105,"commit_id":"232031b039ff54dfa9c7e32d0d754189c5f43ca4","original_commit_id":"232031b039ff54dfa9c7e32d0d754189c5f43ca4","user":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"body":"Would that be ok with you?","created_at":"2016-02-16T07:59:31Z","updated_at":"2016-02-16T07:59:31Z","html_url":"https://github.com/typesafehub/conductr-lib/pull/77#discussion_r52977654","pull_request_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments/52977654"},"html":{"href":"https://github.com/typesafehub/conductr-lib/pull/77#discussion_r52977654"},"pull_request":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77","id":59446886,"html_url":"https://github.com/typesafehub/conductr-lib/pull/77","diff_url":"https://github.com/typesafehub/conductr-lib/pull/77.diff","patch_url":"https://github.com/typesafehub/conductr-lib/pull/77.patch","issue_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/77","number":77,"state":"open","locked":false,"title":"Migrate Play 2.5 to DI","user":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"body":"Play 2.5 uses DI and so our corresponding API has moved to that convention. Of note is that you now inject your ServiceLocator and StatusService components. A nice side-benefit is that we now provide a CacheLike object for injection so that a singleton cache may be used.\r\n\r\nFiles were also tidied up in order to remove warnings and to keep IntelliJ happy.\r\n\r\nTODO: The equivalent Java 8 based api within the play25 projects. As per Play.WS, these are complete re-writes i.e. the Java API does not call on the Scala API. To this end, the Java 8 dependencies have been set up (java-conductr-bundle-lib).","created_at":"2016-02-16T05:58:29Z","updated_at":"2016-02-16T07:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9346fcd5603c0d481e696e67fe4d2a30eef4190","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77/commits","review_comments_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77/comments","review_comment_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/77/comments","statuses_url":"https://api.github.com/repos/typesafehub/conductr-lib/statuses/232031b039ff54dfa9c7e32d0d754189c5f43ca4","head":{"label":"huntc:play25","ref":"play25","sha":"232031b039ff54dfa9c7e32d0d754189c5f43ca4","user":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"repo":{"id":37562792,"name":"conductr-lib","full_name":"huntc/conductr-lib","owner":{"login":"huntc","id":694893,"avatar_url":"https://avatars.githubusercontent.com/u/694893?v=3","gravatar_id":"","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huntc/conductr-lib","description":null,"fork":true,"url":"https://api.github.com/repos/huntc/conductr-lib","forks_url":"https://api.github.com/repos/huntc/conductr-lib/forks","keys_url":"https://api.github.com/repos/huntc/conductr-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huntc/conductr-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huntc/conductr-lib/teams","hooks_url":"https://api.github.com/repos/huntc/conductr-lib/hooks","issue_events_url":"https://api.github.com/repos/huntc/conductr-lib/issues/events{/number}","events_url":"https://api.github.com/repos/huntc/conductr-lib/events","assignees_url":"https://api.github.com/repos/huntc/conductr-lib/assignees{/user}","branches_url":"https://api.github.com/repos/huntc/conductr-lib/branches{/branch}","tags_url":"https://api.github.com/repos/huntc/conductr-lib/tags","blobs_url":"https://api.github.com/repos/huntc/conductr-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huntc/conductr-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huntc/conductr-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/huntc/conductr-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huntc/conductr-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/huntc/conductr-lib/languages","stargazers_url":"https://api.github.com/repos/huntc/conductr-lib/stargazers","contributors_url":"https://api.github.com/repos/huntc/conductr-lib/contributors","subscribers_url":"https://api.github.com/repos/huntc/conductr-lib/subscribers","subscription_url":"https://api.github.com/repos/huntc/conductr-lib/subscription","commits_url":"https://api.github.com/repos/huntc/conductr-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/huntc/conductr-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/huntc/conductr-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/huntc/conductr-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/huntc/conductr-lib/contents/{+path}","compare_url":"https://api.github.com/repos/huntc/conductr-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huntc/conductr-lib/merges","archive_url":"https://api.github.com/repos/huntc/conductr-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huntc/conductr-lib/downloads","issues_url":"https://api.github.com/repos/huntc/conductr-lib/issues{/number}","pulls_url":"https://api.github.com/repos/huntc/conductr-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/huntc/conductr-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/huntc/conductr-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huntc/conductr-lib/labels{/name}","releases_url":"https://api.github.com/repos/huntc/conductr-lib/releases{/id}","deployments_url":"https://api.github.com/repos/huntc/conductr-lib/deployments","created_at":"2015-06-17T00:13:29Z","updated_at":"2016-01-18T00:42:26Z","pushed_at":"2016-02-16T05:57:23Z","git_url":"git://github.com/huntc/conductr-lib.git","ssh_url":"git@github.com:huntc/conductr-lib.git","clone_url":"https://github.com/huntc/conductr-lib.git","svn_url":"https://github.com/huntc/conductr-lib","homepage":null,"size":389,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"641484bcfb221034740c5f28834f4a710362c1c2","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":30228350,"name":"conductr-lib","full_name":"typesafehub/conductr-lib","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/conductr-lib","description":null,"fork":false,"url":"https://api.github.com/repos/typesafehub/conductr-lib","forks_url":"https://api.github.com/repos/typesafehub/conductr-lib/forks","keys_url":"https://api.github.com/repos/typesafehub/conductr-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/conductr-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/conductr-lib/teams","hooks_url":"https://api.github.com/repos/typesafehub/conductr-lib/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/conductr-lib/events","assignees_url":"https://api.github.com/repos/typesafehub/conductr-lib/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/conductr-lib/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/conductr-lib/tags","blobs_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/conductr-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/conductr-lib/languages","stargazers_url":"https://api.github.com/repos/typesafehub/conductr-lib/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/conductr-lib/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/conductr-lib/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/conductr-lib/subscription","commits_url":"https://api.github.com/repos/typesafehub/conductr-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/conductr-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/conductr-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesafehub/conductr-lib/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/conductr-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/conductr-lib/merges","archive_url":"https://api.github.com/repos/typesafehub/conductr-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/conductr-lib/downloads","issues_url":"https://api.github.com/repos/typesafehub/conductr-lib/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/conductr-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/conductr-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/conductr-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/conductr-lib/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/conductr-lib/releases{/id}","deployments_url":"https://api.github.com/repos/typesafehub/conductr-lib/deployments","created_at":"2015-02-03T06:16:58Z","updated_at":"2016-02-10T18:38:21Z","pushed_at":"2016-02-16T05:58:29Z","git_url":"git://github.com/typesafehub/conductr-lib.git","ssh_url":"git@github.com:typesafehub/conductr-lib.git","clone_url":"https://github.com/typesafehub/conductr-lib.git","svn_url":"https://github.com/typesafehub/conductr-lib","homepage":null,"size":386,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77"},"html":{"href":"https://github.com/typesafehub/conductr-lib/pull/77"},"issue":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/issues/77"},"comments":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/conductr-lib/statuses/232031b039ff54dfa9c7e32d0d754189c5f43ca4"}}}}