{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6391","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6391/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6391/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6391/events","html_url":"https://github.com/Automattic/wp-calypso/pull/6391","id":162813540,"number":6391,"title":"Framework: createSelector: allow 2nd arg to be array of selectors","user":{"login":"mcsf","id":150562,"avatar_url":"https://avatars.githubusercontent.com/u/150562?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsf","html_url":"https://github.com/mcsf","followers_url":"https://api.github.com/users/mcsf/followers","following_url":"https://api.github.com/users/mcsf/following{/other_user}","gists_url":"https://api.github.com/users/mcsf/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsf/subscriptions","organizations_url":"https://api.github.com/users/mcsf/orgs","repos_url":"https://api.github.com/users/mcsf/repos","events_url":"https://api.github.com/users/mcsf/events{/privacy}","received_events_url":"https://api.github.com/users/mcsf/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"mcsf","id":150562,"avatar_url":"https://avatars.githubusercontent.com/u/150562?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsf","html_url":"https://github.com/mcsf","followers_url":"https://api.github.com/users/mcsf/followers","following_url":"https://api.github.com/users/mcsf/following{/other_user}","gists_url":"https://api.github.com/users/mcsf/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsf/subscriptions","organizations_url":"https://api.github.com/users/mcsf/orgs","repos_url":"https://api.github.com/users/mcsf/repos","events_url":"https://api.github.com/users/mcsf/events{/privacy}","received_events_url":"https://api.github.com/users/mcsf/received_events","type":"User","site_admin":false},"assignees":[{"login":"mcsf","id":150562,"avatar_url":"https://avatars.githubusercontent.com/u/150562?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsf","html_url":"https://github.com/mcsf","followers_url":"https://api.github.com/users/mcsf/followers","following_url":"https://api.github.com/users/mcsf/following{/other_user}","gists_url":"https://api.github.com/users/mcsf/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsf/subscriptions","organizations_url":"https://api.github.com/users/mcsf/orgs","repos_url":"https://api.github.com/users/mcsf/repos","events_url":"https://api.github.com/users/mcsf/events{/privacy}","received_events_url":"https://api.github.com/users/mcsf/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/90","html_url":"https://github.com/Automattic/wp-calypso/milestones/GuidedTours%20M3:%20Multitours","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/90/labels","id":1768696,"number":90,"title":"GuidedTours M3: Multitours","description":"Multiple tours, contextual tour triggers.","creator":{"login":"ehg","id":215074,"avatar_url":"https://avatars.githubusercontent.com/u/215074?v=3","gravatar_id":"","url":"https://api.github.com/users/ehg","html_url":"https://github.com/ehg","followers_url":"https://api.github.com/users/ehg/followers","following_url":"https://api.github.com/users/ehg/following{/other_user}","gists_url":"https://api.github.com/users/ehg/gists{/gist_id}","starred_url":"https://api.github.com/users/ehg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehg/subscriptions","organizations_url":"https://api.github.com/users/ehg/orgs","repos_url":"https://api.github.com/users/ehg/repos","events_url":"https://api.github.com/users/ehg/events{/privacy}","received_events_url":"https://api.github.com/users/ehg/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":4,"state":"open","created_at":"2016-05-16T13:38:13Z","updated_at":"2016-06-28T23:58:48Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-06-28T23:58:48Z","updated_at":"2016-06-29T00:43:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6391","html_url":"https://github.com/Automattic/wp-calypso/pull/6391","diff_url":"https://github.com/Automattic/wp-calypso/pull/6391.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/6391.patch"},"body":"This PR allows consumers of `createSelector` that depend on multiple selectors to simplify their invocation of `createSelector` from:\r\n\r\n```js\r\ncreateSelector(\r\n\tstate => foo( state ) && bar( state ),\r\n\tstate => [\r\n\t\tfoo( state ),\r\n\t\tbar( state ),\r\n\t\tbaz( state ),\r\n\t]\r\n);\r\n```\r\n\r\nto:\r\n\r\n```js\r\ncreateSelector(\r\n\tstate => foo( state ) && bar( state ),\r\n\t[ foo, bar, baz ]\r\n);\r\n```\r\n\r\n### To do\r\n- [x] Tests\r\n- [x] Doc block\r\n\r\nTest live: https://calypso.live/?branch=add/create-selector-dependants-array"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/229225647","html_url":"https://github.com/Automattic/wp-calypso/pull/6391#issuecomment-229225647","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6391","id":229225647,"user":{"login":"mcsf","id":150562,"avatar_url":"https://avatars.githubusercontent.com/u/150562?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsf","html_url":"https://github.com/mcsf","followers_url":"https://api.github.com/users/mcsf/followers","following_url":"https://api.github.com/users/mcsf/following{/other_user}","gists_url":"https://api.github.com/users/mcsf/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsf/subscriptions","organizations_url":"https://api.github.com/users/mcsf/orgs","repos_url":"https://api.github.com/users/mcsf/repos","events_url":"https://api.github.com/users/mcsf/events{/privacy}","received_events_url":"https://api.github.com/users/mcsf/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T00:43:04Z","updated_at":"2016-06-29T00:43:04Z","body":"I have doubts on whether the new tests are correctly described and whether they make sense, and whether it is confusing to have these two with such similar descriptions:\r\n\r\n> ✓ should accept an array of dependent state values\r\n> ✓ should accept an array of dependent selectors"}}
{"actor":{"display_login":"mcsf"}}