{"action":"opened","number":9487,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/9487","id":80872805,"html_url":"https://github.com/mrdoob/three.js/pull/9487","diff_url":"https://github.com/mrdoob/three.js/pull/9487.diff","patch_url":"https://github.com/mrdoob/three.js/pull/9487.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/9487","number":9487,"state":"open","locked":false,"title":"Editor: Fixed texture load issues.","user":{"login":"tschw","id":3916357,"avatar_url":"https://avatars.githubusercontent.com/u/3916357?v=3","gravatar_id":"","url":"https://api.github.com/users/tschw","html_url":"https://github.com/tschw","followers_url":"https://api.github.com/users/tschw/followers","following_url":"https://api.github.com/users/tschw/following{/other_user}","gists_url":"https://api.github.com/users/tschw/gists{/gist_id}","starred_url":"https://api.github.com/users/tschw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschw/subscriptions","organizations_url":"https://api.github.com/users/tschw/orgs","repos_url":"https://api.github.com/users/tschw/repos","events_url":"https://api.github.com/users/tschw/events{/privacy}","received_events_url":"https://api.github.com/users/tschw/received_events","type":"User","site_admin":false},"body":"Apparently, the file input element won't fire a change event unless reset. Because of this, the editor won't allow loading the same texture after it has been loaded before, which makes the control irresponsive in some cases.\r\n\r\nReproduction:\r\n- Load a model\r\n- Load a texture, but don't enable it\r\n- Add a light source\r\n- Switch back to the model \r\n\r\nAt this point the texture is forgotten (which is fine, since it's only remembered in the GUI components) but it can't be reloaded because the invisible file input control won't see the change.\r\n\r\nThis patch adds a form element around the file input control to properly reset it when an image has been loaded. This way, the same image can be loaded multiple times. It also prevents textures that don't exist from being enabled in the editor, because it doesn't make sense.","created_at":"2016-08-10T21:42:15Z","updated_at":"2016-08-10T21:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9487/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9487/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/9487/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/6df92639821921ad0a48e9b57ca21f747f3d7d8f","head":{"label":"tschw:editor_fix","ref":"editor_fix","sha":"6df92639821921ad0a48e9b57ca21f747f3d7d8f","user":{"login":"tschw","id":3916357,"avatar_url":"https://avatars.githubusercontent.com/u/3916357?v=3","gravatar_id":"","url":"https://api.github.com/users/tschw","html_url":"https://github.com/tschw","followers_url":"https://api.github.com/users/tschw/followers","following_url":"https://api.github.com/users/tschw/following{/other_user}","gists_url":"https://api.github.com/users/tschw/gists{/gist_id}","starred_url":"https://api.github.com/users/tschw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschw/subscriptions","organizations_url":"https://api.github.com/users/tschw/orgs","repos_url":"https://api.github.com/users/tschw/repos","events_url":"https://api.github.com/users/tschw/events{/privacy}","received_events_url":"https://api.github.com/users/tschw/received_events","type":"User","site_admin":false},"repo":{"id":35382835,"name":"three.js","full_name":"tschw/three.js","owner":{"login":"tschw","id":3916357,"avatar_url":"https://avatars.githubusercontent.com/u/3916357?v=3","gravatar_id":"","url":"https://api.github.com/users/tschw","html_url":"https://github.com/tschw","followers_url":"https://api.github.com/users/tschw/followers","following_url":"https://api.github.com/users/tschw/following{/other_user}","gists_url":"https://api.github.com/users/tschw/gists{/gist_id}","starred_url":"https://api.github.com/users/tschw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschw/subscriptions","organizations_url":"https://api.github.com/users/tschw/orgs","repos_url":"https://api.github.com/users/tschw/repos","events_url":"https://api.github.com/users/tschw/events{/privacy}","received_events_url":"https://api.github.com/users/tschw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tschw/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/tschw/three.js","forks_url":"https://api.github.com/repos/tschw/three.js/forks","keys_url":"https://api.github.com/repos/tschw/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tschw/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tschw/three.js/teams","hooks_url":"https://api.github.com/repos/tschw/three.js/hooks","issue_events_url":"https://api.github.com/repos/tschw/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/tschw/three.js/events","assignees_url":"https://api.github.com/repos/tschw/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/tschw/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/tschw/three.js/tags","blobs_url":"https://api.github.com/repos/tschw/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tschw/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tschw/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/tschw/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tschw/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/tschw/three.js/languages","stargazers_url":"https://api.github.com/repos/tschw/three.js/stargazers","contributors_url":"https://api.github.com/repos/tschw/three.js/contributors","subscribers_url":"https://api.github.com/repos/tschw/three.js/subscribers","subscription_url":"https://api.github.com/repos/tschw/three.js/subscription","commits_url":"https://api.github.com/repos/tschw/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/tschw/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/tschw/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/tschw/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/tschw/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/tschw/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tschw/three.js/merges","archive_url":"https://api.github.com/repos/tschw/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tschw/three.js/downloads","issues_url":"https://api.github.com/repos/tschw/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/tschw/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/tschw/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/tschw/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tschw/three.js/labels{/name}","releases_url":"https://api.github.com/repos/tschw/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/tschw/three.js/deployments","created_at":"2015-05-10T18:30:04Z","updated_at":"2015-05-10T18:30:12Z","pushed_at":"2016-08-10T21:41:36Z","git_url":"git://github.com/tschw/three.js.git","ssh_url":"git@github.com:tschw/three.js.git","clone_url":"https://github.com/tschw/three.js.git","svn_url":"https://github.com/tschw/three.js","homepage":"http://threejs.org/","size":378693,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"da9f70c7891435ddc40bdabf38baaf92ad389889","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-08-10T21:17:33Z","pushed_at":"2016-08-10T21:42:15Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":611622,"stargazers_count":26773,"watchers_count":26773,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9128,"mirror_url":null,"open_issues_count":784,"forks":9128,"open_issues":784,"watchers":26773,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9487"},"html":{"href":"https://github.com/mrdoob/three.js/pull/9487"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9487"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9487/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9487/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9487/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/6df92639821921ad0a48e9b57ca21f747f3d7d8f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"tschw"}}