{"action":"closed","number":154,"pull_request":{"url":"https://api.github.com/repos/python-rope/rope/pulls/154","id":65714593,"html_url":"https://github.com/python-rope/rope/pull/154","diff_url":"https://github.com/python-rope/rope/pull/154.diff","patch_url":"https://github.com/python-rope/rope/pull/154.patch","issue_url":"https://api.github.com/repos/python-rope/rope/issues/154","number":154,"state":"closed","locked":false,"title":"Increase scrutiny on import filter to avoid removing unrelated imports","user":{"login":"soupytwist","id":1455827,"avatar_url":"https://avatars.githubusercontent.com/u/1455827?v=3","gravatar_id":"","url":"https://api.github.com/users/soupytwist","html_url":"https://github.com/soupytwist","followers_url":"https://api.github.com/users/soupytwist/followers","following_url":"https://api.github.com/users/soupytwist/following{/other_user}","gists_url":"https://api.github.com/users/soupytwist/gists{/gist_id}","starred_url":"https://api.github.com/users/soupytwist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soupytwist/subscriptions","organizations_url":"https://api.github.com/users/soupytwist/orgs","repos_url":"https://api.github.com/users/soupytwist/repos","events_url":"https://api.github.com/users/soupytwist/events{/privacy}","received_events_url":"https://api.github.com/users/soupytwist/received_events","type":"User","site_admin":false},"body":"This is an improvement to further specify that any import which would be\r\nexamined is one of the following forms (when moving pkg.module.SomeClass):\r\n\r\n```python\r\nfrom pkg import module\r\nfrom pkg.module import any_name\r\nimport pkg.module\r\n```\r\n\r\npreviously this would have also possibly matched\r\n\r\n```python\r\nfrom pkg import unrelated_module\r\n```\r\n\r\neven though this module is not affected.","created_at":"2016-04-07T23:11:13Z","updated_at":"2016-04-29T22:10:44Z","closed_at":"2016-04-29T22:10:44Z","merged_at":null,"merge_commit_sha":"4b1dbbd92bbd8e5c7bcfc9d9caf82f7c7761c7a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/python-rope/rope/pulls/154/commits","review_comments_url":"https://api.github.com/repos/python-rope/rope/pulls/154/comments","review_comment_url":"https://api.github.com/repos/python-rope/rope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-rope/rope/issues/154/comments","statuses_url":"https://api.github.com/repos/python-rope/rope/statuses/19e4cdfd152521c90c6a8c93ebb74896bd7e7974","head":{"label":"soupytwist:move-global-imports","ref":"move-global-imports","sha":"19e4cdfd152521c90c6a8c93ebb74896bd7e7974","user":{"login":"soupytwist","id":1455827,"avatar_url":"https://avatars.githubusercontent.com/u/1455827?v=3","gravatar_id":"","url":"https://api.github.com/users/soupytwist","html_url":"https://github.com/soupytwist","followers_url":"https://api.github.com/users/soupytwist/followers","following_url":"https://api.github.com/users/soupytwist/following{/other_user}","gists_url":"https://api.github.com/users/soupytwist/gists{/gist_id}","starred_url":"https://api.github.com/users/soupytwist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soupytwist/subscriptions","organizations_url":"https://api.github.com/users/soupytwist/orgs","repos_url":"https://api.github.com/users/soupytwist/repos","events_url":"https://api.github.com/users/soupytwist/events{/privacy}","received_events_url":"https://api.github.com/users/soupytwist/received_events","type":"User","site_admin":false},"repo":{"id":46522395,"name":"rope","full_name":"soupytwist/rope","owner":{"login":"soupytwist","id":1455827,"avatar_url":"https://avatars.githubusercontent.com/u/1455827?v=3","gravatar_id":"","url":"https://api.github.com/users/soupytwist","html_url":"https://github.com/soupytwist","followers_url":"https://api.github.com/users/soupytwist/followers","following_url":"https://api.github.com/users/soupytwist/following{/other_user}","gists_url":"https://api.github.com/users/soupytwist/gists{/gist_id}","starred_url":"https://api.github.com/users/soupytwist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soupytwist/subscriptions","organizations_url":"https://api.github.com/users/soupytwist/orgs","repos_url":"https://api.github.com/users/soupytwist/repos","events_url":"https://api.github.com/users/soupytwist/events{/privacy}","received_events_url":"https://api.github.com/users/soupytwist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soupytwist/rope","description":"a python refactoring library","fork":true,"url":"https://api.github.com/repos/soupytwist/rope","forks_url":"https://api.github.com/repos/soupytwist/rope/forks","keys_url":"https://api.github.com/repos/soupytwist/rope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soupytwist/rope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soupytwist/rope/teams","hooks_url":"https://api.github.com/repos/soupytwist/rope/hooks","issue_events_url":"https://api.github.com/repos/soupytwist/rope/issues/events{/number}","events_url":"https://api.github.com/repos/soupytwist/rope/events","assignees_url":"https://api.github.com/repos/soupytwist/rope/assignees{/user}","branches_url":"https://api.github.com/repos/soupytwist/rope/branches{/branch}","tags_url":"https://api.github.com/repos/soupytwist/rope/tags","blobs_url":"https://api.github.com/repos/soupytwist/rope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soupytwist/rope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soupytwist/rope/git/refs{/sha}","trees_url":"https://api.github.com/repos/soupytwist/rope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soupytwist/rope/statuses/{sha}","languages_url":"https://api.github.com/repos/soupytwist/rope/languages","stargazers_url":"https://api.github.com/repos/soupytwist/rope/stargazers","contributors_url":"https://api.github.com/repos/soupytwist/rope/contributors","subscribers_url":"https://api.github.com/repos/soupytwist/rope/subscribers","subscription_url":"https://api.github.com/repos/soupytwist/rope/subscription","commits_url":"https://api.github.com/repos/soupytwist/rope/commits{/sha}","git_commits_url":"https://api.github.com/repos/soupytwist/rope/git/commits{/sha}","comments_url":"https://api.github.com/repos/soupytwist/rope/comments{/number}","issue_comment_url":"https://api.github.com/repos/soupytwist/rope/issues/comments{/number}","contents_url":"https://api.github.com/repos/soupytwist/rope/contents/{+path}","compare_url":"https://api.github.com/repos/soupytwist/rope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soupytwist/rope/merges","archive_url":"https://api.github.com/repos/soupytwist/rope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soupytwist/rope/downloads","issues_url":"https://api.github.com/repos/soupytwist/rope/issues{/number}","pulls_url":"https://api.github.com/repos/soupytwist/rope/pulls{/number}","milestones_url":"https://api.github.com/repos/soupytwist/rope/milestones{/number}","notifications_url":"https://api.github.com/repos/soupytwist/rope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soupytwist/rope/labels{/name}","releases_url":"https://api.github.com/repos/soupytwist/rope/releases{/id}","deployments_url":"https://api.github.com/repos/soupytwist/rope/deployments","created_at":"2015-11-19T21:46:56Z","updated_at":"2016-01-15T19:39:00Z","pushed_at":"2016-04-29T20:04:41Z","git_url":"git://github.com/soupytwist/rope.git","ssh_url":"git@github.com:soupytwist/rope.git","clone_url":"https://github.com/soupytwist/rope.git","svn_url":"https://github.com/soupytwist/rope","homepage":"","size":18172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-rope:master","ref":"master","sha":"014a5a661780d5e083a1ef5bdff8783c499deb1b","user":{"login":"python-rope","id":6073454,"avatar_url":"https://avatars.githubusercontent.com/u/6073454?v=3","gravatar_id":"","url":"https://api.github.com/users/python-rope","html_url":"https://github.com/python-rope","followers_url":"https://api.github.com/users/python-rope/followers","following_url":"https://api.github.com/users/python-rope/following{/other_user}","gists_url":"https://api.github.com/users/python-rope/gists{/gist_id}","starred_url":"https://api.github.com/users/python-rope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-rope/subscriptions","organizations_url":"https://api.github.com/users/python-rope/orgs","repos_url":"https://api.github.com/users/python-rope/repos","events_url":"https://api.github.com/users/python-rope/events{/privacy}","received_events_url":"https://api.github.com/users/python-rope/received_events","type":"Organization","site_admin":false},"repo":{"id":14823414,"name":"rope","full_name":"python-rope/rope","owner":{"login":"python-rope","id":6073454,"avatar_url":"https://avatars.githubusercontent.com/u/6073454?v=3","gravatar_id":"","url":"https://api.github.com/users/python-rope","html_url":"https://github.com/python-rope","followers_url":"https://api.github.com/users/python-rope/followers","following_url":"https://api.github.com/users/python-rope/following{/other_user}","gists_url":"https://api.github.com/users/python-rope/gists{/gist_id}","starred_url":"https://api.github.com/users/python-rope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-rope/subscriptions","organizations_url":"https://api.github.com/users/python-rope/orgs","repos_url":"https://api.github.com/users/python-rope/repos","events_url":"https://api.github.com/users/python-rope/events{/privacy}","received_events_url":"https://api.github.com/users/python-rope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-rope/rope","description":"a python refactoring library","fork":false,"url":"https://api.github.com/repos/python-rope/rope","forks_url":"https://api.github.com/repos/python-rope/rope/forks","keys_url":"https://api.github.com/repos/python-rope/rope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-rope/rope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-rope/rope/teams","hooks_url":"https://api.github.com/repos/python-rope/rope/hooks","issue_events_url":"https://api.github.com/repos/python-rope/rope/issues/events{/number}","events_url":"https://api.github.com/repos/python-rope/rope/events","assignees_url":"https://api.github.com/repos/python-rope/rope/assignees{/user}","branches_url":"https://api.github.com/repos/python-rope/rope/branches{/branch}","tags_url":"https://api.github.com/repos/python-rope/rope/tags","blobs_url":"https://api.github.com/repos/python-rope/rope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-rope/rope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-rope/rope/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-rope/rope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-rope/rope/statuses/{sha}","languages_url":"https://api.github.com/repos/python-rope/rope/languages","stargazers_url":"https://api.github.com/repos/python-rope/rope/stargazers","contributors_url":"https://api.github.com/repos/python-rope/rope/contributors","subscribers_url":"https://api.github.com/repos/python-rope/rope/subscribers","subscription_url":"https://api.github.com/repos/python-rope/rope/subscription","commits_url":"https://api.github.com/repos/python-rope/rope/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-rope/rope/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-rope/rope/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-rope/rope/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-rope/rope/contents/{+path}","compare_url":"https://api.github.com/repos/python-rope/rope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-rope/rope/merges","archive_url":"https://api.github.com/repos/python-rope/rope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-rope/rope/downloads","issues_url":"https://api.github.com/repos/python-rope/rope/issues{/number}","pulls_url":"https://api.github.com/repos/python-rope/rope/pulls{/number}","milestones_url":"https://api.github.com/repos/python-rope/rope/milestones{/number}","notifications_url":"https://api.github.com/repos/python-rope/rope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-rope/rope/labels{/name}","releases_url":"https://api.github.com/repos/python-rope/rope/releases{/id}","deployments_url":"https://api.github.com/repos/python-rope/rope/deployments","created_at":"2013-11-30T15:30:20Z","updated_at":"2016-04-27T07:08:44Z","pushed_at":"2016-04-29T22:10:30Z","git_url":"git://github.com/python-rope/rope.git","ssh_url":"git@github.com:python-rope/rope.git","clone_url":"https://github.com/python-rope/rope.git","svn_url":"https://github.com/python-rope/rope","homepage":"","size":19054,"stargazers_count":244,"watchers_count":244,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":42,"forks":51,"open_issues":42,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-rope/rope/pulls/154"},"html":{"href":"https://github.com/python-rope/rope/pull/154"},"issue":{"href":"https://api.github.com/repos/python-rope/rope/issues/154"},"comments":{"href":"https://api.github.com/repos/python-rope/rope/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/python-rope/rope/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/python-rope/rope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-rope/rope/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/python-rope/rope/statuses/19e4cdfd152521c90c6a8c93ebb74896bd7e7974"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}