{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/66759971","id":66759971,"diff_hunk":"@@ -75,4 +75,27 @@ public function evaluate($functions, $values)\n \n         return $results;\n     }\n+\n+    public function dump()\n+    {\n+        return sprintf('<Dumping a \"%s\" instance is not supported yet>', get_class($this));","path":"src/Symfony/Component/ExpressionLanguage/Node/Node.php","position":7,"original_position":7,"commit_id":"6a8080dddf9271d4d3f3b16101f15b6d2716fca7","original_commit_id":"6a8080dddf9271d4d3f3b16101f15b6d2716fca7","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better to just throw an exception here? As the dumped expression is not usable anyway.","created_at":"2016-06-13T09:06:31Z","updated_at":"2016-06-13T09:06:31Z","html_url":"https://github.com/symfony/symfony/pull/19013#discussion_r66759971","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/19013","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/66759971"},"html":{"href":"https://github.com/symfony/symfony/pull/19013#discussion_r66759971"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19013"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19013","id":73252838,"html_url":"https://github.com/symfony/symfony/pull/19013","diff_url":"https://github.com/symfony/symfony/pull/19013.diff","patch_url":"https://github.com/symfony/symfony/pull/19013.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19013","number":19013,"state":"open","locked":false,"title":"[ExpressionLanguage] Added a way to dump the AST","user":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | \r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nBecause it's convenient and it makes easier to inline results of sub/smaller part of the main expression.\r\n","created_at":"2016-06-09T17:21:44Z","updated_at":"2016-06-13T09:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1558e8c64cff8417280b137f83d32a88cfeeb35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19013/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19013/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19013/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/6a8080dddf9271d4d3f3b16101f15b6d2716fca7","head":{"label":"lyrixx:el-dump","ref":"el-dump","sha":"6a8080dddf9271d4d3f3b16101f15b6d2716fca7","user":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"repo":{"id":3148495,"name":"symfony","full_name":"lyrixx/symfony","owner":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lyrixx/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/lyrixx/symfony","forks_url":"https://api.github.com/repos/lyrixx/symfony/forks","keys_url":"https://api.github.com/repos/lyrixx/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyrixx/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyrixx/symfony/teams","hooks_url":"https://api.github.com/repos/lyrixx/symfony/hooks","issue_events_url":"https://api.github.com/repos/lyrixx/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/lyrixx/symfony/events","assignees_url":"https://api.github.com/repos/lyrixx/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/lyrixx/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/lyrixx/symfony/tags","blobs_url":"https://api.github.com/repos/lyrixx/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyrixx/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyrixx/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyrixx/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyrixx/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/lyrixx/symfony/languages","stargazers_url":"https://api.github.com/repos/lyrixx/symfony/stargazers","contributors_url":"https://api.github.com/repos/lyrixx/symfony/contributors","subscribers_url":"https://api.github.com/repos/lyrixx/symfony/subscribers","subscription_url":"https://api.github.com/repos/lyrixx/symfony/subscription","commits_url":"https://api.github.com/repos/lyrixx/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyrixx/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyrixx/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyrixx/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyrixx/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/lyrixx/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyrixx/symfony/merges","archive_url":"https://api.github.com/repos/lyrixx/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyrixx/symfony/downloads","issues_url":"https://api.github.com/repos/lyrixx/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/lyrixx/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/lyrixx/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/lyrixx/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyrixx/symfony/labels{/name}","releases_url":"https://api.github.com/repos/lyrixx/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/lyrixx/symfony/deployments","created_at":"2012-01-10T20:46:58Z","updated_at":"2015-02-12T12:35:28Z","pushed_at":"2016-06-13T08:56:01Z","git_url":"git://github.com/lyrixx/symfony.git","ssh_url":"git@github.com:lyrixx/symfony.git","clone_url":"https://github.com/lyrixx/symfony.git","svn_url":"https://github.com/lyrixx/symfony","homepage":"symfony.com","size":72274,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"e7077605bb23def0a6baa51768c2630c20f04709","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-06-13T06:12:42Z","pushed_at":"2016-06-13T08:56:22Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":133245,"stargazers_count":12496,"watchers_count":12496,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4878,"mirror_url":null,"open_issues_count":746,"forks":4878,"open_issues":746,"watchers":12496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19013"},"html":{"href":"https://github.com/symfony/symfony/pull/19013"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19013"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19013/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19013/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19013/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/6a8080dddf9271d4d3f3b16101f15b6d2716fca7"}}}}
{"actor":{"display_login":"fabpot"}}