{"action":"created","issue":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1204","repository_url":"https://api.github.com/repos/rockstor/rockstor-core","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1204/labels{/name}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1204/comments","events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1204/events","html_url":"https://github.com/rockstor/rockstor-core/issues/1204","id":138804363,"number":1204,"title":"Check only installed AND active rock-ons for port-conflicts. NOT available Rock-Ons.","user":{"login":"henfri","id":5280909,"avatar_url":"https://avatars.githubusercontent.com/u/5280909?v=3","gravatar_id":"","url":"https://api.github.com/users/henfri","html_url":"https://github.com/henfri","followers_url":"https://api.github.com/users/henfri/followers","following_url":"https://api.github.com/users/henfri/following{/other_user}","gists_url":"https://api.github.com/users/henfri/gists{/gist_id}","starred_url":"https://api.github.com/users/henfri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henfri/subscriptions","organizations_url":"https://api.github.com/users/henfri/orgs","repos_url":"https://api.github.com/users/henfri/repos","events_url":"https://api.github.com/users/henfri/events{/privacy}","received_events_url":"https://api.github.com/users/henfri/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rockstor/rockstor-core/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/rockstor/rockstor-core/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":{"login":"schakrava","id":1123552,"avatar_url":"https://avatars.githubusercontent.com/u/1123552?v=3","gravatar_id":"","url":"https://api.github.com/users/schakrava","html_url":"https://github.com/schakrava","followers_url":"https://api.github.com/users/schakrava/followers","following_url":"https://api.github.com/users/schakrava/following{/other_user}","gists_url":"https://api.github.com/users/schakrava/gists{/gist_id}","starred_url":"https://api.github.com/users/schakrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schakrava/subscriptions","organizations_url":"https://api.github.com/users/schakrava/orgs","repos_url":"https://api.github.com/users/schakrava/repos","events_url":"https://api.github.com/users/schakrava/events{/privacy}","received_events_url":"https://api.github.com/users/schakrava/received_events","type":"User","site_admin":false},"assignees":[{"login":"schakrava","id":1123552,"avatar_url":"https://avatars.githubusercontent.com/u/1123552?v=3","gravatar_id":"","url":"https://api.github.com/users/schakrava","html_url":"https://github.com/schakrava","followers_url":"https://api.github.com/users/schakrava/followers","following_url":"https://api.github.com/users/schakrava/following{/other_user}","gists_url":"https://api.github.com/users/schakrava/gists{/gist_id}","starred_url":"https://api.github.com/users/schakrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schakrava/subscriptions","organizations_url":"https://api.github.com/users/schakrava/orgs","repos_url":"https://api.github.com/users/schakrava/repos","events_url":"https://api.github.com/users/schakrava/events{/privacy}","received_events_url":"https://api.github.com/users/schakrava/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/rockstor/rockstor-core/milestones/15","html_url":"https://github.com/rockstor/rockstor-core/milestones/Looney%20Bean","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/milestones/15/labels","id":1601342,"number":15,"title":"Looney Bean","description":"","creator":{"login":"schakrava","id":1123552,"avatar_url":"https://avatars.githubusercontent.com/u/1123552?v=3","gravatar_id":"","url":"https://api.github.com/users/schakrava","html_url":"https://github.com/schakrava","followers_url":"https://api.github.com/users/schakrava/followers","following_url":"https://api.github.com/users/schakrava/following{/other_user}","gists_url":"https://api.github.com/users/schakrava/gists{/gist_id}","starred_url":"https://api.github.com/users/schakrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schakrava/subscriptions","organizations_url":"https://api.github.com/users/schakrava/orgs","repos_url":"https://api.github.com/users/schakrava/repos","events_url":"https://api.github.com/users/schakrava/events{/privacy}","received_events_url":"https://api.github.com/users/schakrava/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":37,"state":"open","created_at":"2016-02-23T23:32:08Z","updated_at":"2016-07-14T20:49:45Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-03-06T15:49:55Z","updated_at":"2016-07-14T20:49:45Z","closed_at":"2016-07-14T20:49:45Z","body":"(from https://forum.rockstor.com/t/bug-check-of-used-ports-for-rock-ons-should-be-done-for-active-rock-ons-only/1183)\r\nHello,\r\n\r\nI have tried to update the plex Rock-On by adding a plex_new.json to /opt/rockstor/rockon-metastore.\r\nUnfortunately, the fact that there are now two Plex Rock-Ons causes this problem:\r\n`Rock-on port(32400) is dedicated to another Rock-On(Plex) and cannot be changed. Choose a different name`. This happens when trying to install the new Rock-On.\r\n\r\nI don't see the problem here. This check is not needed my view. Instead of checking whether another *available* (but not neccessarily installed AND active) Rock-On does use this a port already, it should only be checked if an active Rock-On is using (i.e. mapping to the Host) the port of the Rock-On that is currently being installed.\r\n\r\nProposal:\r\nCheck only installed AND active rock-ons for port-conflicts. NOT available Rock-Ons."},"comment":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments/232788134","html_url":"https://github.com/rockstor/rockstor-core/issues/1204#issuecomment-232788134","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1204","id":232788134,"user":{"login":"schakrava","id":1123552,"avatar_url":"https://avatars.githubusercontent.com/u/1123552?v=3","gravatar_id":"","url":"https://api.github.com/users/schakrava","html_url":"https://github.com/schakrava","followers_url":"https://api.github.com/users/schakrava/followers","following_url":"https://api.github.com/users/schakrava/following{/other_user}","gists_url":"https://api.github.com/users/schakrava/gists{/gist_id}","starred_url":"https://api.github.com/users/schakrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schakrava/subscriptions","organizations_url":"https://api.github.com/users/schakrava/orgs","repos_url":"https://api.github.com/users/schakrava/repos","events_url":"https://api.github.com/users/schakrava/events{/privacy}","received_events_url":"https://api.github.com/users/schakrava/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T20:49:45Z","updated_at":"2016-07-14T20:49:45Z","body":"Thanks for the proposal @henfri, completely agreed. Turns out I've actually implemented this exact fix in https://github.com/rockstor/rockstor-core/commit/a6d47c4707a002deb673d0587adba326c822a70d"}}
{"actor":{"display_login":"schakrava"}}