{"action":"created","issue":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/220","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/220/comments","events_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/220/events","html_url":"https://github.com/vert-x3/vertx-web/issues/220","id":110990397,"number":220,"title":"Bump handlebars to 2.2.3","user":{"login":"johnoliver","id":1615532,"avatar_url":"https://avatars.githubusercontent.com/u/1615532?v=3","gravatar_id":"","url":"https://api.github.com/users/johnoliver","html_url":"https://github.com/johnoliver","followers_url":"https://api.github.com/users/johnoliver/followers","following_url":"https://api.github.com/users/johnoliver/following{/other_user}","gists_url":"https://api.github.com/users/johnoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/johnoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnoliver/subscriptions","organizations_url":"https://api.github.com/users/johnoliver/orgs","repos_url":"https://api.github.com/users/johnoliver/repos","events_url":"https://api.github.com/users/johnoliver/events{/privacy}","received_events_url":"https://api.github.com/users/johnoliver/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vert-x3/vertx-web/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/vert-x3/vertx-web/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/vert-x3/vertx-web/labels/Planned","name":"Planned","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"pmlopes","id":849467,"avatar_url":"https://avatars.githubusercontent.com/u/849467?v=3","gravatar_id":"","url":"https://api.github.com/users/pmlopes","html_url":"https://github.com/pmlopes","followers_url":"https://api.github.com/users/pmlopes/followers","following_url":"https://api.github.com/users/pmlopes/following{/other_user}","gists_url":"https://api.github.com/users/pmlopes/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlopes/subscriptions","organizations_url":"https://api.github.com/users/pmlopes/orgs","repos_url":"https://api.github.com/users/pmlopes/repos","events_url":"https://api.github.com/users/pmlopes/events{/privacy}","received_events_url":"https://api.github.com/users/pmlopes/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-10-12T14:52:31Z","updated_at":"2016-01-15T11:27:34Z","closed_at":null,"body":"We are currently very behind on our handlebars version (1.3.0). \r\n\r\nThe upgrade will also force supporting a prefix on the CachingTemplateEngine, due to the lack of a prefix it is currently impossible to serve up partials from a location that is unknown at project compile time."},"comment":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/comments/171938012","html_url":"https://github.com/vert-x3/vertx-web/issues/220#issuecomment-171938012","issue_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/220","id":171938012,"user":{"login":"slayful","id":1950206,"avatar_url":"https://avatars.githubusercontent.com/u/1950206?v=3","gravatar_id":"","url":"https://api.github.com/users/slayful","html_url":"https://github.com/slayful","followers_url":"https://api.github.com/users/slayful/followers","following_url":"https://api.github.com/users/slayful/following{/other_user}","gists_url":"https://api.github.com/users/slayful/gists{/gist_id}","starred_url":"https://api.github.com/users/slayful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayful/subscriptions","organizations_url":"https://api.github.com/users/slayful/orgs","repos_url":"https://api.github.com/users/slayful/repos","events_url":"https://api.github.com/users/slayful/events{/privacy}","received_events_url":"https://api.github.com/users/slayful/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T11:27:34Z","updated_at":"2016-01-15T11:27:34Z","body":"Hey guys, I've bumped the Handlebars version to the newest one 4.0.3 and the existing tests for Handlebars are passing after adding a basic implementation for the new methods: https://github.com/slayful/vertx-web/tree/bump-handlebars\r\n\r\nI've looked into how the prefix (template directory) is currently passed into the rendering engine and it's done by the TemplateHandlerImpl for which the user can specify the template directory on creation.\r\n\r\nSo refactoring how prefixes are used does not seem to be necessary to bump the Handlebars.\r\n\r\nBut if you believe that specifying the template directory (prefix) should be moved to the TemplateEngine then you can check out the early draft in: https://github.com/slayful/vertx-web/tree/bump-handlebars-refactor-prefixes\r\n\r\nAny suggestions?"}}