{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/73238076","id":73238076,"diff_hunk":"@@ -324,6 +324,25 @@ define stringreplace\n \t$(build_depsbindir)/stringreplace $$(strings -t x - $1 | grep '$2' | awk '{print $$1;}') '$3' 255 \"$(call cygpath_w,$1)\"\n endef\n \n+JL_HEADERS := \\","path":"Makefile","position":4,"original_position":4,"commit_id":"c5a370ad4dcfac991d9f73069de7e25a865dfd34","original_commit_id":"c5a370ad4dcfac991d9f73069de7e25a865dfd34","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"body":"My prior feedback is now collapsed, but I still don't like this form where `JL_HEADERS` needs to be kept up to date. A shorter exclusions list of things that are currently included in `src/support/*.h` but aren't needed would be more maintainable.","created_at":"2016-08-02T21:09:01Z","updated_at":"2016-08-02T21:09:01Z","html_url":"https://github.com/JuliaLang/julia/pull/17745#discussion_r73238076","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/17745","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/73238076"},"html":{"href":"https://github.com/JuliaLang/julia/pull/17745#discussion_r73238076"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17745"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/17745","id":79649371,"html_url":"https://github.com/JuliaLang/julia/pull/17745","diff_url":"https://github.com/JuliaLang/julia/pull/17745.diff","patch_url":"https://github.com/JuliaLang/julia/pull/17745.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/17745","number":17745,"state":"open","locked":false,"title":"Install only headers required by julia.h","user":{"login":"petercolberg","id":5453048,"avatar_url":"https://avatars.githubusercontent.com/u/5453048?v=3","gravatar_id":"","url":"https://api.github.com/users/petercolberg","html_url":"https://github.com/petercolberg","followers_url":"https://api.github.com/users/petercolberg/followers","following_url":"https://api.github.com/users/petercolberg/following{/other_user}","gists_url":"https://api.github.com/users/petercolberg/gists{/gist_id}","starred_url":"https://api.github.com/users/petercolberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petercolberg/subscriptions","organizations_url":"https://api.github.com/users/petercolberg/orgs","repos_url":"https://api.github.com/users/petercolberg/repos","events_url":"https://api.github.com/users/petercolberg/events{/privacy}","received_events_url":"https://api.github.com/users/petercolberg/received_events","type":"User","site_admin":false},"body":"Closes #17657","created_at":"2016-08-01T22:43:31Z","updated_at":"2016-08-02T21:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fcd1ba29c476aaa88e27c39ba646f224d7bf5fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/17745/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/17745/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/17745/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/c5a370ad4dcfac991d9f73069de7e25a865dfd34","head":{"label":"petercolberg:headers-libjulia","ref":"headers-libjulia","sha":"c5a370ad4dcfac991d9f73069de7e25a865dfd34","user":{"login":"petercolberg","id":5453048,"avatar_url":"https://avatars.githubusercontent.com/u/5453048?v=3","gravatar_id":"","url":"https://api.github.com/users/petercolberg","html_url":"https://github.com/petercolberg","followers_url":"https://api.github.com/users/petercolberg/followers","following_url":"https://api.github.com/users/petercolberg/following{/other_user}","gists_url":"https://api.github.com/users/petercolberg/gists{/gist_id}","starred_url":"https://api.github.com/users/petercolberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petercolberg/subscriptions","organizations_url":"https://api.github.com/users/petercolberg/orgs","repos_url":"https://api.github.com/users/petercolberg/repos","events_url":"https://api.github.com/users/petercolberg/events{/privacy}","received_events_url":"https://api.github.com/users/petercolberg/received_events","type":"User","site_admin":false},"repo":{"id":64402466,"name":"julia","full_name":"petercolberg/julia","owner":{"login":"petercolberg","id":5453048,"avatar_url":"https://avatars.githubusercontent.com/u/5453048?v=3","gravatar_id":"","url":"https://api.github.com/users/petercolberg","html_url":"https://github.com/petercolberg","followers_url":"https://api.github.com/users/petercolberg/followers","following_url":"https://api.github.com/users/petercolberg/following{/other_user}","gists_url":"https://api.github.com/users/petercolberg/gists{/gist_id}","starred_url":"https://api.github.com/users/petercolberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petercolberg/subscriptions","organizations_url":"https://api.github.com/users/petercolberg/orgs","repos_url":"https://api.github.com/users/petercolberg/repos","events_url":"https://api.github.com/users/petercolberg/events{/privacy}","received_events_url":"https://api.github.com/users/petercolberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petercolberg/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/petercolberg/julia","forks_url":"https://api.github.com/repos/petercolberg/julia/forks","keys_url":"https://api.github.com/repos/petercolberg/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petercolberg/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petercolberg/julia/teams","hooks_url":"https://api.github.com/repos/petercolberg/julia/hooks","issue_events_url":"https://api.github.com/repos/petercolberg/julia/issues/events{/number}","events_url":"https://api.github.com/repos/petercolberg/julia/events","assignees_url":"https://api.github.com/repos/petercolberg/julia/assignees{/user}","branches_url":"https://api.github.com/repos/petercolberg/julia/branches{/branch}","tags_url":"https://api.github.com/repos/petercolberg/julia/tags","blobs_url":"https://api.github.com/repos/petercolberg/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petercolberg/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petercolberg/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/petercolberg/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petercolberg/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/petercolberg/julia/languages","stargazers_url":"https://api.github.com/repos/petercolberg/julia/stargazers","contributors_url":"https://api.github.com/repos/petercolberg/julia/contributors","subscribers_url":"https://api.github.com/repos/petercolberg/julia/subscribers","subscription_url":"https://api.github.com/repos/petercolberg/julia/subscription","commits_url":"https://api.github.com/repos/petercolberg/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/petercolberg/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/petercolberg/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/petercolberg/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/petercolberg/julia/contents/{+path}","compare_url":"https://api.github.com/repos/petercolberg/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petercolberg/julia/merges","archive_url":"https://api.github.com/repos/petercolberg/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petercolberg/julia/downloads","issues_url":"https://api.github.com/repos/petercolberg/julia/issues{/number}","pulls_url":"https://api.github.com/repos/petercolberg/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/petercolberg/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/petercolberg/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petercolberg/julia/labels{/name}","releases_url":"https://api.github.com/repos/petercolberg/julia/releases{/id}","deployments_url":"https://api.github.com/repos/petercolberg/julia/deployments","created_at":"2016-07-28T14:30:40Z","updated_at":"2016-07-28T14:31:07Z","pushed_at":"2016-08-02T00:12:40Z","git_url":"git://github.com/petercolberg/julia.git","ssh_url":"git@github.com:petercolberg/julia.git","clone_url":"https://github.com/petercolberg/julia.git","svn_url":"https://github.com/petercolberg/julia","homepage":"http://julialang.org/","size":96369,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"643bac816a8b034aed780a507dfed4bf3f87698e","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-08-02T15:15:05Z","pushed_at":"2016-08-02T21:00:02Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":408471,"stargazers_count":7318,"watchers_count":7318,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1701,"mirror_url":null,"open_issues_count":1859,"forks":1701,"open_issues":1859,"watchers":7318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17745"},"html":{"href":"https://github.com/JuliaLang/julia/pull/17745"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/17745"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/17745/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17745/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/17745/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/c5a370ad4dcfac991d9f73069de7e25a865dfd34"}}}}
{"actor":{"display_login":"tkelman"}}