{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/93077181","pull_request_review_id":13598710,"id":93077181,"diff_hunk":"@@ -476,12 +479,23 @@ func (c *controller) ID() string {\n \n func (c *controller) BuiltinDrivers() []string {\n \tdrivers := []string{}\n-\tfor _, i := range getInitializers(c.cfg.Daemon.Experimental) {\n-\t\tif i.ntype == \"remote\" {\n-\t\t\tcontinue\n+\tc.drvRegistry.WalkDrivers(func(name string, driver driverapi.Driver, capability driverapi.Capability) bool {\n+\t\tif driver.IsBuiltIn() {\n+\t\t\tdrivers = append(drivers, name)\n \t\t}\n-\t\tdrivers = append(drivers, i.ntype)\n-\t}\n+\t\treturn false","path":"controller.go","position":23,"original_position":23,"commit_id":"d25f9d1c1381658c6841240df3b9880fc217c16f","original_commit_id":"d25f9d1c1381658c6841240df3b9880fc217c16f","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"the function is defined in such a way that if a callback function returns a `true`, the walk will be terminated. In our case, we dont want to break the walk and hence we always return false.","created_at":"2016-12-19T17:18:15Z","updated_at":"2016-12-19T17:18:15Z","html_url":"https://github.com/docker/libnetwork/pull/1596#discussion_r93077181","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/1596","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/93077181"},"html":{"href":"https://github.com/docker/libnetwork/pull/1596#discussion_r93077181"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1596"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/1596","id":98506760,"html_url":"https://github.com/docker/libnetwork/pull/1596","diff_url":"https://github.com/docker/libnetwork/pull/1596.diff","patch_url":"https://github.com/docker/libnetwork/pull/1596.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/1596","number":1596,"state":"open","locked":false,"title":"Let drvRegistry to override remote plugin","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"\r\nAddresses https://github.com/docker/docker/issues/29473\r\n\r\ndrvRegistry isnt aware if a plugin is v1 or v2. Plugin-v2 provides a way\r\nfor user to disable and remove plugins. But unfortunately, there isnt\r\nany api to advertise the removal to drvRegistry. Hence there is no way\r\nto handle \"docker plugin rm\" of installed plugin. In order to support\r\nthe case of \"docker plugin install x\" followed by \"docker plugin rm x\"\r\nfollowed by reinstalling of plugin \"docker plugin install x\",\r\ndrvRegistry must allow overriding any existing plugin with the same\r\nname. The protection in plugin infra will prevent willful override of\r\nexisting plugin.","created_at":"2016-12-19T04:46:42Z","updated_at":"2016-12-19T17:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9da88f7248cbfd5856c220e98d9345ab3e9fce4f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/1596/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/1596/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/1596/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/d25f9d1c1381658c6841240df3b9880fc217c16f","head":{"label":"mavenugo:br-plugin","ref":"br-plugin","sha":"d25f9d1c1381658c6841240df3b9880fc217c16f","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"repo":{"id":34572010,"name":"libnetwork","full_name":"mavenugo/libnetwork","owner":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mavenugo/libnetwork","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/mavenugo/libnetwork","forks_url":"https://api.github.com/repos/mavenugo/libnetwork/forks","keys_url":"https://api.github.com/repos/mavenugo/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavenugo/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavenugo/libnetwork/teams","hooks_url":"https://api.github.com/repos/mavenugo/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/mavenugo/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/mavenugo/libnetwork/events","assignees_url":"https://api.github.com/repos/mavenugo/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/mavenugo/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/mavenugo/libnetwork/tags","blobs_url":"https://api.github.com/repos/mavenugo/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavenugo/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavenugo/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavenugo/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavenugo/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/mavenugo/libnetwork/languages","stargazers_url":"https://api.github.com/repos/mavenugo/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/mavenugo/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/mavenugo/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/mavenugo/libnetwork/subscription","commits_url":"https://api.github.com/repos/mavenugo/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavenugo/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavenugo/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavenugo/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavenugo/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/mavenugo/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavenugo/libnetwork/merges","archive_url":"https://api.github.com/repos/mavenugo/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavenugo/libnetwork/downloads","issues_url":"https://api.github.com/repos/mavenugo/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/mavenugo/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/mavenugo/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/mavenugo/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavenugo/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/mavenugo/libnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/mavenugo/libnetwork/deployments","created_at":"2015-04-25T14:39:45Z","updated_at":"2016-02-11T15:00:40Z","pushed_at":"2016-12-19T13:17:55Z","git_url":"git://github.com/mavenugo/libnetwork.git","ssh_url":"git@github.com:mavenugo/libnetwork.git","clone_url":"https://github.com/mavenugo/libnetwork.git","svn_url":"https://github.com/mavenugo/libnetwork","homepage":"","size":10286,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9a064ee3bb9c604db39ae2a29862b6e603a43aeb","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"Docker Networking","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/docker/libnetwork/deployments","created_at":"2015-02-20T01:20:15Z","updated_at":"2016-12-17T08:43:53Z","pushed_at":"2016-12-19T13:17:57Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":10402,"stargazers_count":804,"watchers_count":804,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":400,"mirror_url":null,"open_issues_count":250,"forks":400,"open_issues":250,"watchers":804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1596"},"html":{"href":"https://github.com/docker/libnetwork/pull/1596"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/1596"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/1596/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1596/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/1596/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/d25f9d1c1381658c6841240df3b9880fc217c16f"}}}}
{"actor":{"display_login":"mavenugo"}}