{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/94267071","pull_request_review_id":14798331,"id":94267071,"diff_hunk":"@@ -164,37 +168,58 @@ bool EffectChainManager::saveEffectChains() {\n     return true;\n }\n \n-bool EffectChainManager::loadEffectChains() {\n-    //qDebug() << debugString() << \"loadEffectChains\";\n+QList<std::pair<EffectChainPointer, QDomElement>> EffectChainManager::loadEffectChains() {\n+    // StandardEffectRack::addEffectChainSlot uses both the EffectChainPointer\n+    // and the saved state from the XML to initialize the respective\n+    // EffectChain/Effect/EffectParameter/EffectButtonParameter Slots\n+    QList<std::pair<EffectChainPointer, QDomElement>> loadedChains;\n \n     QDir settingsPath(m_pConfig->getSettingsPath());\n     QFile file(settingsPath.absoluteFilePath(\"effects.xml\"));\n+    QDomDocument doc;\n \n     if (!file.open(QIODevice::ReadOnly)) {\n-        return false;\n+        EffectChainPointer pEmptyChain;\n+        QDomElement emptyChainElement = doc.createElement(\"EffectChain\");\n+        for (int i = 0; i < 4; ++i) {","path":"src/effects/effectchainmanager.cpp","position":67,"original_position":67,"commit_id":"cb9c889ecc16c598508ab50392943947b96f21c6","original_commit_id":"cb9c889ecc16c598508ab50392943947b96f21c6","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"body":"I agree. Where?","created_at":"2016-12-31T01:33:17Z","updated_at":"2016-12-31T01:33:17Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1092#discussion_r94267071","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/94267071"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1092#discussion_r94267071"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092","id":99418632,"html_url":"https://github.com/mixxxdj/mixxx/pull/1092","diff_url":"https://github.com/mixxxdj/mixxx/pull/1092.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1092.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1092","number":1092,"state":"open","locked":false,"title":"persistent effects","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"body":"Save state of effect chains to `effects.xml` in user settings directory on shutdown and reload state of effects chains from that file on startup. This paves the way for exporting & importing effect chain presets.\r\n\r\nShould the state of effect metaknobs and/or chain superknobs be saved as well?","created_at":"2016-12-27T08:29:41Z","updated_at":"2016-12-31T01:33:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d4d18cecd10e7f5518de17fadeb61349b7c692b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1092/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/cb9c889ecc16c598508ab50392943947b96f21c6","head":{"label":"Be-ing:effect_xml","ref":"effect_xml","sha":"cb9c889ecc16c598508ab50392943947b96f21c6","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"repo":{"id":36947294,"name":"mixxx","full_name":"Be-ing/mixxx","owner":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Be-ing/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/Be-ing/mixxx","forks_url":"https://api.github.com/repos/Be-ing/mixxx/forks","keys_url":"https://api.github.com/repos/Be-ing/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Be-ing/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Be-ing/mixxx/teams","hooks_url":"https://api.github.com/repos/Be-ing/mixxx/hooks","issue_events_url":"https://api.github.com/repos/Be-ing/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/Be-ing/mixxx/events","assignees_url":"https://api.github.com/repos/Be-ing/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/Be-ing/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/Be-ing/mixxx/tags","blobs_url":"https://api.github.com/repos/Be-ing/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Be-ing/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Be-ing/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Be-ing/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Be-ing/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/Be-ing/mixxx/languages","stargazers_url":"https://api.github.com/repos/Be-ing/mixxx/stargazers","contributors_url":"https://api.github.com/repos/Be-ing/mixxx/contributors","subscribers_url":"https://api.github.com/repos/Be-ing/mixxx/subscribers","subscription_url":"https://api.github.com/repos/Be-ing/mixxx/subscription","commits_url":"https://api.github.com/repos/Be-ing/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Be-ing/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Be-ing/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Be-ing/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Be-ing/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/Be-ing/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Be-ing/mixxx/merges","archive_url":"https://api.github.com/repos/Be-ing/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Be-ing/mixxx/downloads","issues_url":"https://api.github.com/repos/Be-ing/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/Be-ing/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/Be-ing/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/Be-ing/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Be-ing/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/Be-ing/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/Be-ing/mixxx/deployments","created_at":"2015-06-05T18:00:37Z","updated_at":"2016-12-19T02:57:20Z","pushed_at":"2016-12-30T18:05:08Z","git_url":"git://github.com/Be-ing/mixxx.git","ssh_url":"git@github.com:Be-ing/mixxx.git","clone_url":"https://github.com/Be-ing/mixxx.git","svn_url":"https://github.com/Be-ing/mixxx","homepage":"http://mixxx.org","size":261289,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"personal"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"0a6173e7566bf3e851a02e964ff2c7cdf0b7d4c4","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-12-30T18:30:07Z","pushed_at":"2016-12-30T19:59:24Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":261005,"stargazers_count":645,"watchers_count":645,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":80,"forks":380,"open_issues":80,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1092"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1092"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1092/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1092/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/cb9c889ecc16c598508ab50392943947b96f21c6"}}}}
{"actor":{"display_login":"Be-ing"}}