{"action":"created","issue":{"url":"https://api.github.com/repos/uber/deck.gl/issues/39","repository_url":"https://api.github.com/repos/uber/deck.gl","labels_url":"https://api.github.com/repos/uber/deck.gl/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/uber/deck.gl/issues/39/comments","events_url":"https://api.github.com/repos/uber/deck.gl/issues/39/events","html_url":"https://github.com/uber/deck.gl/pull/39","id":163415613,"number":39,"title":"Fix Layer#checkProp to only error on undefined/null","user":{"login":"austinhyde","id":694995,"avatar_url":"https://avatars.githubusercontent.com/u/694995?v=3","gravatar_id":"","url":"https://api.github.com/users/austinhyde","html_url":"https://github.com/austinhyde","followers_url":"https://api.github.com/users/austinhyde/followers","following_url":"https://api.github.com/users/austinhyde/following{/other_user}","gists_url":"https://api.github.com/users/austinhyde/gists{/gist_id}","starred_url":"https://api.github.com/users/austinhyde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinhyde/subscriptions","organizations_url":"https://api.github.com/users/austinhyde/orgs","repos_url":"https://api.github.com/users/austinhyde/repos","events_url":"https://api.github.com/users/austinhyde/events{/privacy}","received_events_url":"https://api.github.com/users/austinhyde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-01T15:08:36Z","updated_at":"2016-07-01T18:13:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/deck.gl/pulls/39","html_url":"https://github.com/uber/deck.gl/pull/39","diff_url":"https://github.com/uber/deck.gl/pull/39.diff","patch_url":"https://github.com/uber/deck.gl/pull/39.patch"},"body":"Fixes #31 \r\n\r\nI added unit tests confirming this behavior, but there's still a test failure on\r\n\r\n```\r\n⨯ Viewport projection matrix\r\n  not ok 7 TypeError: viewport.getZoomedViewProjectionMatrix is not a function\r\n    ---\r\n      operator: error\r\n      expected: \r\n      actual:   {}\r\n      at: Test.exports.Test.run (/Users/Hyde/src/deck.gl/node_modules/tape-catch/index.js:29:10)\r\n      stack:\r\n        TypeError: viewport.getZoomedViewProjectionMatrix is not a function\r\n          at Test._cb (viewport-spec.js:55:39)\r\n```\r\n\r\nI'm not sure the best solution to this, so I just left it as-is."},"comment":{"url":"https://api.github.com/repos/uber/deck.gl/issues/comments/230013551","html_url":"https://github.com/uber/deck.gl/pull/39#issuecomment-230013551","issue_url":"https://api.github.com/repos/uber/deck.gl/issues/39","id":230013551,"user":{"login":"ibgreen","id":7025232,"avatar_url":"https://avatars.githubusercontent.com/u/7025232?v=3","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T18:13:06Z","updated_at":"2016-07-01T18:13:06Z","body":"@austinhyde \r\nLooks great\r\nLove the fact that you added unit tests! \r\nI think the breaking function has just changed name to `getProjectionMatrix()`. You can make the change, or leave it and I'll fix it later.\r\nI added some inline nits, but they are not blockers, I am fine to merge this as is. \r\nLet's chat offline if you need a new version published."}}
{"actor":{"display_login":"ibgreen"}}