{"action":"created","comment":{"url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/comments/70351143","id":70351143,"diff_hunk":"@@ -0,0 +1,119 @@\n+{\n+    \"_id\": \"getty_WA0682-001\",\n+    \"source_name\": \"getty\", ","path":"schema.js","position":3,"original_position":3,"commit_id":"a89e577cff43ae607b7e5eeda600d0a39a5f0d8e","original_commit_id":"a89e577cff43ae607b7e5eeda600d0a39a5f0d8e","user":{"login":"parkan","id":204986,"avatar_url":"https://avatars.githubusercontent.com/u/204986?v=3","gravatar_id":"","url":"https://api.github.com/users/parkan","html_url":"https://github.com/parkan","followers_url":"https://api.github.com/users/parkan/followers","following_url":"https://api.github.com/users/parkan/following{/other_user}","gists_url":"https://api.github.com/users/parkan/gists{/gist_id}","starred_url":"https://api.github.com/users/parkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkan/subscriptions","organizations_url":"https://api.github.com/users/parkan/orgs","repos_url":"https://api.github.com/users/parkan/repos","events_url":"https://api.github.com/users/parkan/events{/privacy}","received_events_url":"https://api.github.com/users/parkan/received_events","type":"User","site_admin":false},"body":"I don't think we need a link inside each object, and maybe this field shouldn't be inside the `data` at all, move it up into `meta`? ","created_at":"2016-07-11T22:46:52Z","updated_at":"2016-07-11T22:46:52Z","html_url":"https://github.com/mediachain/mediachain-indexer/pull/19#discussion_r70351143","pull_request_url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/comments/70351143"},"html":{"href":"https://github.com/mediachain/mediachain-indexer/pull/19#discussion_r70351143"},"pull_request":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19","id":77032710,"html_url":"https://github.com/mediachain/mediachain-indexer/pull/19","diff_url":"https://github.com/mediachain/mediachain-indexer/pull/19.diff","patch_url":"https://github.com/mediachain/mediachain-indexer/pull/19.patch","issue_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/19","number":19,"state":"open","locked":false,"title":"Schema Discussion.","user":{"login":"autoencoder","id":19392619,"avatar_url":"https://avatars.githubusercontent.com/u/19392619?v=3","gravatar_id":"","url":"https://api.github.com/users/autoencoder","html_url":"https://github.com/autoencoder","followers_url":"https://api.github.com/users/autoencoder/followers","following_url":"https://api.github.com/users/autoencoder/following{/other_user}","gists_url":"https://api.github.com/users/autoencoder/gists{/gist_id}","starred_url":"https://api.github.com/users/autoencoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autoencoder/subscriptions","organizations_url":"https://api.github.com/users/autoencoder/orgs","repos_url":"https://api.github.com/users/autoencoder/repos","events_url":"https://api.github.com/users/autoencoder/events{/privacy}","received_events_url":"https://api.github.com/users/autoencoder/received_events","type":"User","site_admin":false},"body":"This represents the inner `data` section of the artefact schema that will be output to the front-end via the Indexer API. This may slightly differ from the artefact schema stored in the blockchain, in that it may have some additional fields added to it, e.g. `sightings_list` (?)\r\n\r\nQuestions from previous discussions:\r\n\r\n- Having both basic string versions + more complex versions for some fields, to make it easier on apps trying to use this metadata, e.g. having both `'author_name':'Picasso and Bob''` and `'author':[{'name':'Picasso', 'role':'author'},{'name':'Bob','role':'author'}]`\r\n- Having all string-like fields always be lists of strings instead of a bare string, as DPLA does.\r\n- `null` to indicate missing values.\r\n- Support for multi-layer nesting of enriching modifications?\r\n- Citing of multiple raw sources that are fused together?\r\n- There's an assumption that the raw input is JSON -- instead of e.g. XML, raw HTML, text files, callback-wrapped JSON, CSRF guarded JSON?\r\n\r\nOther questions:\r\n- [Indexer-API] Move `sightings_list` and other potentially huge fields to other API endpoints? Or, allow pagination on some sub-fields e.g. `sightings_list` - similar to the facebook API? \r\n\r\nDecisions so far:\r\n- [ ] Add \"official_permalink\" field (Only allow a single permalink here?)\r\n- [ ] Add \"source_url\" field(s)\r\n","created_at":"2016-07-11T22:17:43Z","updated_at":"2016-07-11T22:46:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a587c1ad32f19fb229aa31070e49d11f5abfb43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19/commits","review_comments_url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19/comments","review_comment_url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/19/comments","statuses_url":"https://api.github.com/repos/mediachain/mediachain-indexer/statuses/a89e577cff43ae607b7e5eeda600d0a39a5f0d8e","head":{"label":"mediachain:schema","ref":"schema","sha":"a89e577cff43ae607b7e5eeda600d0a39a5f0d8e","user":{"login":"mediachain","id":16711838,"avatar_url":"https://avatars.githubusercontent.com/u/16711838?v=3","gravatar_id":"","url":"https://api.github.com/users/mediachain","html_url":"https://github.com/mediachain","followers_url":"https://api.github.com/users/mediachain/followers","following_url":"https://api.github.com/users/mediachain/following{/other_user}","gists_url":"https://api.github.com/users/mediachain/gists{/gist_id}","starred_url":"https://api.github.com/users/mediachain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediachain/subscriptions","organizations_url":"https://api.github.com/users/mediachain/orgs","repos_url":"https://api.github.com/users/mediachain/repos","events_url":"https://api.github.com/users/mediachain/events{/privacy}","received_events_url":"https://api.github.com/users/mediachain/received_events","type":"Organization","site_admin":false},"repo":{"id":59593897,"name":"mediachain-indexer","full_name":"mediachain/mediachain-indexer","owner":{"login":"mediachain","id":16711838,"avatar_url":"https://avatars.githubusercontent.com/u/16711838?v=3","gravatar_id":"","url":"https://api.github.com/users/mediachain","html_url":"https://github.com/mediachain","followers_url":"https://api.github.com/users/mediachain/followers","following_url":"https://api.github.com/users/mediachain/following{/other_user}","gists_url":"https://api.github.com/users/mediachain/gists{/gist_id}","starred_url":"https://api.github.com/users/mediachain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediachain/subscriptions","organizations_url":"https://api.github.com/users/mediachain/orgs","repos_url":"https://api.github.com/users/mediachain/repos","events_url":"https://api.github.com/users/mediachain/events{/privacy}","received_events_url":"https://api.github.com/users/mediachain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mediachain/mediachain-indexer","description":"search, dedupe, and media ingestion for mediachain","fork":false,"url":"https://api.github.com/repos/mediachain/mediachain-indexer","forks_url":"https://api.github.com/repos/mediachain/mediachain-indexer/forks","keys_url":"https://api.github.com/repos/mediachain/mediachain-indexer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mediachain/mediachain-indexer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mediachain/mediachain-indexer/teams","hooks_url":"https://api.github.com/repos/mediachain/mediachain-indexer/hooks","issue_events_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/events{/number}","events_url":"https://api.github.com/repos/mediachain/mediachain-indexer/events","assignees_url":"https://api.github.com/repos/mediachain/mediachain-indexer/assignees{/user}","branches_url":"https://api.github.com/repos/mediachain/mediachain-indexer/branches{/branch}","tags_url":"https://api.github.com/repos/mediachain/mediachain-indexer/tags","blobs_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mediachain/mediachain-indexer/statuses/{sha}","languages_url":"https://api.github.com/repos/mediachain/mediachain-indexer/languages","stargazers_url":"https://api.github.com/repos/mediachain/mediachain-indexer/stargazers","contributors_url":"https://api.github.com/repos/mediachain/mediachain-indexer/contributors","subscribers_url":"https://api.github.com/repos/mediachain/mediachain-indexer/subscribers","subscription_url":"https://api.github.com/repos/mediachain/mediachain-indexer/subscription","commits_url":"https://api.github.com/repos/mediachain/mediachain-indexer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mediachain/mediachain-indexer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mediachain/mediachain-indexer/contents/{+path}","compare_url":"https://api.github.com/repos/mediachain/mediachain-indexer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mediachain/mediachain-indexer/merges","archive_url":"https://api.github.com/repos/mediachain/mediachain-indexer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mediachain/mediachain-indexer/downloads","issues_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues{/number}","pulls_url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls{/number}","milestones_url":"https://api.github.com/repos/mediachain/mediachain-indexer/milestones{/number}","notifications_url":"https://api.github.com/repos/mediachain/mediachain-indexer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mediachain/mediachain-indexer/labels{/name}","releases_url":"https://api.github.com/repos/mediachain/mediachain-indexer/releases{/id}","deployments_url":"https://api.github.com/repos/mediachain/mediachain-indexer/deployments","created_at":"2016-05-24T17:24:49Z","updated_at":"2016-05-31T16:14:52Z","pushed_at":"2016-07-11T22:17:43Z","git_url":"git://github.com/mediachain/mediachain-indexer.git","ssh_url":"git@github.com:mediachain/mediachain-indexer.git","clone_url":"https://github.com/mediachain/mediachain-indexer.git","svn_url":"https://github.com/mediachain/mediachain-indexer","homepage":"","size":291,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"mediachain:master","ref":"master","sha":"c6857847e2f06d1ab884f8c42f80e9cfb8d3cb06","user":{"login":"mediachain","id":16711838,"avatar_url":"https://avatars.githubusercontent.com/u/16711838?v=3","gravatar_id":"","url":"https://api.github.com/users/mediachain","html_url":"https://github.com/mediachain","followers_url":"https://api.github.com/users/mediachain/followers","following_url":"https://api.github.com/users/mediachain/following{/other_user}","gists_url":"https://api.github.com/users/mediachain/gists{/gist_id}","starred_url":"https://api.github.com/users/mediachain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediachain/subscriptions","organizations_url":"https://api.github.com/users/mediachain/orgs","repos_url":"https://api.github.com/users/mediachain/repos","events_url":"https://api.github.com/users/mediachain/events{/privacy}","received_events_url":"https://api.github.com/users/mediachain/received_events","type":"Organization","site_admin":false},"repo":{"id":59593897,"name":"mediachain-indexer","full_name":"mediachain/mediachain-indexer","owner":{"login":"mediachain","id":16711838,"avatar_url":"https://avatars.githubusercontent.com/u/16711838?v=3","gravatar_id":"","url":"https://api.github.com/users/mediachain","html_url":"https://github.com/mediachain","followers_url":"https://api.github.com/users/mediachain/followers","following_url":"https://api.github.com/users/mediachain/following{/other_user}","gists_url":"https://api.github.com/users/mediachain/gists{/gist_id}","starred_url":"https://api.github.com/users/mediachain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediachain/subscriptions","organizations_url":"https://api.github.com/users/mediachain/orgs","repos_url":"https://api.github.com/users/mediachain/repos","events_url":"https://api.github.com/users/mediachain/events{/privacy}","received_events_url":"https://api.github.com/users/mediachain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mediachain/mediachain-indexer","description":"search, dedupe, and media ingestion for mediachain","fork":false,"url":"https://api.github.com/repos/mediachain/mediachain-indexer","forks_url":"https://api.github.com/repos/mediachain/mediachain-indexer/forks","keys_url":"https://api.github.com/repos/mediachain/mediachain-indexer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mediachain/mediachain-indexer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mediachain/mediachain-indexer/teams","hooks_url":"https://api.github.com/repos/mediachain/mediachain-indexer/hooks","issue_events_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/events{/number}","events_url":"https://api.github.com/repos/mediachain/mediachain-indexer/events","assignees_url":"https://api.github.com/repos/mediachain/mediachain-indexer/assignees{/user}","branches_url":"https://api.github.com/repos/mediachain/mediachain-indexer/branches{/branch}","tags_url":"https://api.github.com/repos/mediachain/mediachain-indexer/tags","blobs_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mediachain/mediachain-indexer/statuses/{sha}","languages_url":"https://api.github.com/repos/mediachain/mediachain-indexer/languages","stargazers_url":"https://api.github.com/repos/mediachain/mediachain-indexer/stargazers","contributors_url":"https://api.github.com/repos/mediachain/mediachain-indexer/contributors","subscribers_url":"https://api.github.com/repos/mediachain/mediachain-indexer/subscribers","subscription_url":"https://api.github.com/repos/mediachain/mediachain-indexer/subscription","commits_url":"https://api.github.com/repos/mediachain/mediachain-indexer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mediachain/mediachain-indexer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mediachain/mediachain-indexer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mediachain/mediachain-indexer/contents/{+path}","compare_url":"https://api.github.com/repos/mediachain/mediachain-indexer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mediachain/mediachain-indexer/merges","archive_url":"https://api.github.com/repos/mediachain/mediachain-indexer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mediachain/mediachain-indexer/downloads","issues_url":"https://api.github.com/repos/mediachain/mediachain-indexer/issues{/number}","pulls_url":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls{/number}","milestones_url":"https://api.github.com/repos/mediachain/mediachain-indexer/milestones{/number}","notifications_url":"https://api.github.com/repos/mediachain/mediachain-indexer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mediachain/mediachain-indexer/labels{/name}","releases_url":"https://api.github.com/repos/mediachain/mediachain-indexer/releases{/id}","deployments_url":"https://api.github.com/repos/mediachain/mediachain-indexer/deployments","created_at":"2016-05-24T17:24:49Z","updated_at":"2016-05-31T16:14:52Z","pushed_at":"2016-07-11T22:17:43Z","git_url":"git://github.com/mediachain/mediachain-indexer.git","ssh_url":"git@github.com:mediachain/mediachain-indexer.git","clone_url":"https://github.com/mediachain/mediachain-indexer.git","svn_url":"https://github.com/mediachain/mediachain-indexer","homepage":"","size":291,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19"},"html":{"href":"https://github.com/mediachain/mediachain-indexer/pull/19"},"issue":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/19"},"comments":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/mediachain/mediachain-indexer/statuses/a89e577cff43ae607b7e5eeda600d0a39a5f0d8e"}}}}
{"actor":{"display_login":"parkan"}}