{"action":"created","comment":{"url":"https://api.github.com/repos/api-platform/core/pulls/comments/87843087","pull_request_review_id":8437829,"id":87843087,"diff_hunk":"@@ -93,7 +93,7 @@ private function handleConfig(ContainerBuilder $container, array $config, array\n         $container->setParameter('api_platform.error_formats', $errorFormats);\n         $container->setParameter('api_platform.eager_loading.enabled', $config['eager_loading']['enabled']);\n         $container->setParameter('api_platform.eager_loading.max_joins', $config['eager_loading']['max_joins']);\n-        $container->setParameter('api_platform.eager_loading.eager_only', $config['eager_loading']['eager_only']);\n+        $container->setParameter('api_platform.eager_loading.force', $config['eager_loading']['force']);","path":"src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php","position":5,"original_position":5,"commit_id":"3c9214a57a095b892e37a506f71b744a6ff7c04f","original_commit_id":"3c9214a57a095b892e37a506f71b744a6ff7c04f","user":{"login":"soyuka","id":1321971,"avatar_url":"https://avatars.githubusercontent.com/u/1321971?v=3","gravatar_id":"","url":"https://api.github.com/users/soyuka","html_url":"https://github.com/soyuka","followers_url":"https://api.github.com/users/soyuka/followers","following_url":"https://api.github.com/users/soyuka/following{/other_user}","gists_url":"https://api.github.com/users/soyuka/gists{/gist_id}","starred_url":"https://api.github.com/users/soyuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soyuka/subscriptions","organizations_url":"https://api.github.com/users/soyuka/orgs","repos_url":"https://api.github.com/users/soyuka/repos","events_url":"https://api.github.com/users/soyuka/events{/privacy}","received_events_url":"https://api.github.com/users/soyuka/received_events","type":"User","site_admin":false},"body":"Why not force_eager here? I agree it's cleaner, but @dunglas talked about DX and having the same name for both configurations.","created_at":"2016-11-14T16:55:48Z","updated_at":"2016-11-14T16:55:48Z","html_url":"https://github.com/api-platform/core/pull/845#discussion_r87843087","pull_request_url":"https://api.github.com/repos/api-platform/core/pulls/845","_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments/87843087"},"html":{"href":"https://github.com/api-platform/core/pull/845#discussion_r87843087"},"pull_request":{"href":"https://api.github.com/repos/api-platform/core/pulls/845"}}},"pull_request":{"url":"https://api.github.com/repos/api-platform/core/pulls/845","id":93574300,"html_url":"https://github.com/api-platform/core/pull/845","diff_url":"https://github.com/api-platform/core/pull/845.diff","patch_url":"https://github.com/api-platform/core/pull/845.patch","issue_url":"https://api.github.com/repos/api-platform/core/issues/845","number":845,"state":"open","locked":false,"title":"Force eager by default","user":{"login":"meyerbaptiste","id":4034907,"avatar_url":"https://avatars.githubusercontent.com/u/4034907?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerbaptiste","html_url":"https://github.com/meyerbaptiste","followers_url":"https://api.github.com/users/meyerbaptiste/followers","following_url":"https://api.github.com/users/meyerbaptiste/following{/other_user}","gists_url":"https://api.github.com/users/meyerbaptiste/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerbaptiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerbaptiste/subscriptions","organizations_url":"https://api.github.com/users/meyerbaptiste/orgs","repos_url":"https://api.github.com/users/meyerbaptiste/repos","events_url":"https://api.github.com/users/meyerbaptiste/events{/privacy}","received_events_url":"https://api.github.com/users/meyerbaptiste/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | N/A\r\n| License       | MIT\r\n| Doc PR        | N/A\r\n\r\nThis PR forces eager by default and adds the ability to configure it in the attributes of a resource.\r\n","created_at":"2016-11-14T14:20:41Z","updated_at":"2016-11-14T16:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1baa301d34017e28e6f802087d40a6fb8cd3065e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/api-platform/core/pulls/845/commits","review_comments_url":"https://api.github.com/repos/api-platform/core/pulls/845/comments","review_comment_url":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/api-platform/core/issues/845/comments","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/3c9214a57a095b892e37a506f71b744a6ff7c04f","head":{"label":"meyerbaptiste:disable_eager_only_by_default","ref":"disable_eager_only_by_default","sha":"3c9214a57a095b892e37a506f71b744a6ff7c04f","user":{"login":"meyerbaptiste","id":4034907,"avatar_url":"https://avatars.githubusercontent.com/u/4034907?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerbaptiste","html_url":"https://github.com/meyerbaptiste","followers_url":"https://api.github.com/users/meyerbaptiste/followers","following_url":"https://api.github.com/users/meyerbaptiste/following{/other_user}","gists_url":"https://api.github.com/users/meyerbaptiste/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerbaptiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerbaptiste/subscriptions","organizations_url":"https://api.github.com/users/meyerbaptiste/orgs","repos_url":"https://api.github.com/users/meyerbaptiste/repos","events_url":"https://api.github.com/users/meyerbaptiste/events{/privacy}","received_events_url":"https://api.github.com/users/meyerbaptiste/received_events","type":"User","site_admin":false},"repo":{"id":68818371,"name":"core","full_name":"meyerbaptiste/core","owner":{"login":"meyerbaptiste","id":4034907,"avatar_url":"https://avatars.githubusercontent.com/u/4034907?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerbaptiste","html_url":"https://github.com/meyerbaptiste","followers_url":"https://api.github.com/users/meyerbaptiste/followers","following_url":"https://api.github.com/users/meyerbaptiste/following{/other_user}","gists_url":"https://api.github.com/users/meyerbaptiste/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerbaptiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerbaptiste/subscriptions","organizations_url":"https://api.github.com/users/meyerbaptiste/orgs","repos_url":"https://api.github.com/users/meyerbaptiste/repos","events_url":"https://api.github.com/users/meyerbaptiste/events{/privacy}","received_events_url":"https://api.github.com/users/meyerbaptiste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meyerbaptiste/core","description":"The Hypermedia REST API component of API Platform: JSON-LD and Hydra support, works with Symfony too","fork":true,"url":"https://api.github.com/repos/meyerbaptiste/core","forks_url":"https://api.github.com/repos/meyerbaptiste/core/forks","keys_url":"https://api.github.com/repos/meyerbaptiste/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meyerbaptiste/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meyerbaptiste/core/teams","hooks_url":"https://api.github.com/repos/meyerbaptiste/core/hooks","issue_events_url":"https://api.github.com/repos/meyerbaptiste/core/issues/events{/number}","events_url":"https://api.github.com/repos/meyerbaptiste/core/events","assignees_url":"https://api.github.com/repos/meyerbaptiste/core/assignees{/user}","branches_url":"https://api.github.com/repos/meyerbaptiste/core/branches{/branch}","tags_url":"https://api.github.com/repos/meyerbaptiste/core/tags","blobs_url":"https://api.github.com/repos/meyerbaptiste/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meyerbaptiste/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meyerbaptiste/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/meyerbaptiste/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meyerbaptiste/core/statuses/{sha}","languages_url":"https://api.github.com/repos/meyerbaptiste/core/languages","stargazers_url":"https://api.github.com/repos/meyerbaptiste/core/stargazers","contributors_url":"https://api.github.com/repos/meyerbaptiste/core/contributors","subscribers_url":"https://api.github.com/repos/meyerbaptiste/core/subscribers","subscription_url":"https://api.github.com/repos/meyerbaptiste/core/subscription","commits_url":"https://api.github.com/repos/meyerbaptiste/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/meyerbaptiste/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/meyerbaptiste/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/meyerbaptiste/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/meyerbaptiste/core/contents/{+path}","compare_url":"https://api.github.com/repos/meyerbaptiste/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meyerbaptiste/core/merges","archive_url":"https://api.github.com/repos/meyerbaptiste/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meyerbaptiste/core/downloads","issues_url":"https://api.github.com/repos/meyerbaptiste/core/issues{/number}","pulls_url":"https://api.github.com/repos/meyerbaptiste/core/pulls{/number}","milestones_url":"https://api.github.com/repos/meyerbaptiste/core/milestones{/number}","notifications_url":"https://api.github.com/repos/meyerbaptiste/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meyerbaptiste/core/labels{/name}","releases_url":"https://api.github.com/repos/meyerbaptiste/core/releases{/id}","deployments_url":"https://api.github.com/repos/meyerbaptiste/core/deployments","created_at":"2016-09-21T13:14:50Z","updated_at":"2016-09-21T13:14:52Z","pushed_at":"2016-11-14T16:31:51Z","git_url":"git://github.com/meyerbaptiste/core.git","ssh_url":"git@github.com:meyerbaptiste/core.git","clone_url":"https://github.com/meyerbaptiste/core.git","svn_url":"https://github.com/meyerbaptiste/core","homepage":"https://api-platform.com","size":3852,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"api-platform:master","ref":"master","sha":"0e686c9a1266178819f28899f317666905e339aa","user":{"login":"api-platform","id":13420081,"avatar_url":"https://avatars.githubusercontent.com/u/13420081?v=3","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":29501260,"name":"core","full_name":"api-platform/core","owner":{"login":"api-platform","id":13420081,"avatar_url":"https://avatars.githubusercontent.com/u/13420081?v=3","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/api-platform/core","description":"The Hypermedia REST API component of API Platform: JSON-LD and Hydra support, works with Symfony too","fork":false,"url":"https://api.github.com/repos/api-platform/core","forks_url":"https://api.github.com/repos/api-platform/core/forks","keys_url":"https://api.github.com/repos/api-platform/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/api-platform/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/api-platform/core/teams","hooks_url":"https://api.github.com/repos/api-platform/core/hooks","issue_events_url":"https://api.github.com/repos/api-platform/core/issues/events{/number}","events_url":"https://api.github.com/repos/api-platform/core/events","assignees_url":"https://api.github.com/repos/api-platform/core/assignees{/user}","branches_url":"https://api.github.com/repos/api-platform/core/branches{/branch}","tags_url":"https://api.github.com/repos/api-platform/core/tags","blobs_url":"https://api.github.com/repos/api-platform/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/api-platform/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/api-platform/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/api-platform/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/{sha}","languages_url":"https://api.github.com/repos/api-platform/core/languages","stargazers_url":"https://api.github.com/repos/api-platform/core/stargazers","contributors_url":"https://api.github.com/repos/api-platform/core/contributors","subscribers_url":"https://api.github.com/repos/api-platform/core/subscribers","subscription_url":"https://api.github.com/repos/api-platform/core/subscription","commits_url":"https://api.github.com/repos/api-platform/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/api-platform/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/api-platform/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/api-platform/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/api-platform/core/contents/{+path}","compare_url":"https://api.github.com/repos/api-platform/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/api-platform/core/merges","archive_url":"https://api.github.com/repos/api-platform/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/api-platform/core/downloads","issues_url":"https://api.github.com/repos/api-platform/core/issues{/number}","pulls_url":"https://api.github.com/repos/api-platform/core/pulls{/number}","milestones_url":"https://api.github.com/repos/api-platform/core/milestones{/number}","notifications_url":"https://api.github.com/repos/api-platform/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/api-platform/core/labels{/name}","releases_url":"https://api.github.com/repos/api-platform/core/releases{/id}","deployments_url":"https://api.github.com/repos/api-platform/core/deployments","created_at":"2015-01-19T23:05:56Z","updated_at":"2016-11-09T15:41:34Z","pushed_at":"2016-11-14T16:31:51Z","git_url":"git://github.com/api-platform/core.git","ssh_url":"git@github.com:api-platform/core.git","clone_url":"https://github.com/api-platform/core.git","svn_url":"https://github.com/api-platform/core","homepage":"https://api-platform.com","size":4632,"stargazers_count":358,"watchers_count":358,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":57,"forks":100,"open_issues":57,"watchers":358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/845"},"html":{"href":"https://github.com/api-platform/core/pull/845"},"issue":{"href":"https://api.github.com/repos/api-platform/core/issues/845"},"comments":{"href":"https://api.github.com/repos/api-platform/core/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/api-platform/core/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/api-platform/core/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/api-platform/core/statuses/3c9214a57a095b892e37a506f71b744a6ff7c04f"}}}}
{"actor":{"display_login":"soyuka"}}