{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy-helpers/issues/235","repository_url":"https://api.github.com/repos/astropy/astropy-helpers","labels_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/235/comments","events_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/235/events","html_url":"https://github.com/astropy/astropy-helpers/pull/235","id":154940361,"number":235,"title":"Add \"generated\" to list of directories build_sphinx -l removes","user":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-16T00:09:18Z","updated_at":"2016-05-20T18:09:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/235","html_url":"https://github.com/astropy/astropy-helpers/pull/235","diff_url":"https://github.com/astropy/astropy-helpers/pull/235.diff","patch_url":"https://github.com/astropy/astropy-helpers/pull/235.patch"},"body":"Does just what it says.  This is intended to go with astropy/astropy#4924, and together they will make it so that ``python setup.py build_sphinx -l`` properly cleans out all the build products of the new sphinx gallery extension that's used in astropy.\r\n\r\nIt also creates a de facto expectation that other sphinx extensions that generate something should put their products in ``generated`` (or ``api``, although that's sort of a special case)."},"comment":{"url":"https://api.github.com/repos/astropy/astropy-helpers/issues/comments/220678526","html_url":"https://github.com/astropy/astropy-helpers/pull/235#issuecomment-220678526","issue_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/235","id":220678526,"user":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T18:09:27Z","updated_at":"2016-05-20T18:09:27Z","body":"@Cadair - I tried to figure out a way to have this access the ``conf.py`` in sphinx to make the \"generated\" definition a bit more flexible... But it's just not possible because ``finalize_options`` always gets run before any sphinx context is created.\r\n\r\nSo the question is: are you ok with this as-is, or would you like me to add a check for a file along the lines of ``docs/api/dontdelete``?  Or a command-line option to specify all the generated doc directories? (which you could put in sunpy's ``setup.cfg``)\r\n"}}
{"actor":{"display_login":"eteq"}}