{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4371","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4371/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4371/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4371/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/4371","id":184492764,"number":4371,"title":"gettextize: Remove \"Debug\" check","user":{"login":"JosJuice","id":6716818,"avatar_url":"https://avatars.githubusercontent.com/u/6716818?v=3","gravatar_id":"","url":"https://api.github.com/users/JosJuice","html_url":"https://github.com/JosJuice","followers_url":"https://api.github.com/users/JosJuice/followers","following_url":"https://api.github.com/users/JosJuice/following{/other_user}","gists_url":"https://api.github.com/users/JosJuice/gists{/gist_id}","starred_url":"https://api.github.com/users/JosJuice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosJuice/subscriptions","organizations_url":"https://api.github.com/users/JosJuice/orgs","repos_url":"https://api.github.com/users/JosJuice/repos","events_url":"https://api.github.com/users/JosJuice/events{/privacy}","received_events_url":"https://api.github.com/users/JosJuice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-21T14:02:05Z","updated_at":"2016-10-22T21:40:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4371","html_url":"https://github.com/dolphin-emu/dolphin/pull/4371","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4371.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4371.patch"},"body":"If the strings for the debugger shouldn't be included in translations, we simply shouldn't use any translation macro for those strings, instead of having a special check to exclude debugger-related code from being searched for translatable strings.\r\n\r\nThe \"Debug\" check is a hack that essentially nobody has been aware of (including me). For instance, PR #4339 made a lot of strings translatable just because they were moved to a file that doesn't have \"Debug\" in its path, and as far as I know, nobody noticed that change until the newly translatable strings were live on Transifex.\r\n\r\nI'm not sure if we should merge this PR as-is or if we want to remove the translation macros from debugger strings first. Any thoughts? Do we want the debugger to be fully localized?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4371)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/255555637","html_url":"https://github.com/dolphin-emu/dolphin/pull/4371#issuecomment-255555637","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4371","id":255555637,"user":{"login":"aldelaro5","id":8932978,"avatar_url":"https://avatars.githubusercontent.com/u/8932978?v=3","gravatar_id":"","url":"https://api.github.com/users/aldelaro5","html_url":"https://github.com/aldelaro5","followers_url":"https://api.github.com/users/aldelaro5/followers","following_url":"https://api.github.com/users/aldelaro5/following{/other_user}","gists_url":"https://api.github.com/users/aldelaro5/gists{/gist_id}","starred_url":"https://api.github.com/users/aldelaro5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldelaro5/subscriptions","organizations_url":"https://api.github.com/users/aldelaro5/orgs","repos_url":"https://api.github.com/users/aldelaro5/repos","events_url":"https://api.github.com/users/aldelaro5/events{/privacy}","received_events_url":"https://api.github.com/users/aldelaro5/received_events","type":"User","site_admin":false},"created_at":"2016-10-22T21:40:29Z","updated_at":"2016-10-22T21:40:29Z","body":"IMO, the debugger isn't usefull for just debugging the actuall emulator, but for reverse enginering, game mechanics researches and glitch hunting.  Granted, these use cases are fairly uncomon, but considering the amount of updates and the increasing stability it got recently, it seems much more presentable for these use cases and therefore, would benefit from translations.\r\n\r\nI actually put several strings translatable on purpose because I knew that in other langauges (like French which I do speak natively), several debugging terms are called differently."}}
{"actor":{"display_login":"aldelaro5"}}