{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/comments/87799640","pull_request_review_id":8396022,"id":87799640,"diff_hunk":"@@ -628,8 +628,16 @@ check_wipe_block_dev_sig() {\n canonicalize_block_devs() {\n   local devs=$1 dev\n   local devs_abs dev_abs\n+  local dest_dev\n \n   for dev in ${devs}; do\n+    # If the device name is a symlink, follow it and use the target\n+    if [ -h \"$dev\" ];then\n+      if ! dest_dev=$(readlink -e $dev);then\n+        Fatal \"$dest_dev failed to resolve linked device path $dev\"","path":"docker-storage-setup.sh","position":10,"original_position":10,"commit_id":"abaf9dd6fc4a7e70a5f558a43441906fb9857163","original_commit_id":"abaf9dd6fc4a7e70a5f558a43441906fb9857163","user":{"login":"rhvgoyal","id":9487534,"avatar_url":"https://avatars.githubusercontent.com/u/9487534?v=3","gravatar_id":"","url":"https://api.github.com/users/rhvgoyal","html_url":"https://github.com/rhvgoyal","followers_url":"https://api.github.com/users/rhvgoyal/followers","following_url":"https://api.github.com/users/rhvgoyal/following{/other_user}","gists_url":"https://api.github.com/users/rhvgoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rhvgoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhvgoyal/subscriptions","organizations_url":"https://api.github.com/users/rhvgoyal/orgs","repos_url":"https://api.github.com/users/rhvgoyal/repos","events_url":"https://api.github.com/users/rhvgoyal/events{/privacy}","received_events_url":"https://api.github.com/users/rhvgoyal/received_events","type":"User","site_admin":false},"body":"When error happens $dest_dev will be empty string. Right? So it will not help using dest_dev in error message. So how about just keeping it simple as.\r\n\r\n`Fatal \"Failed to resolve symbolic link $dev\"`","created_at":"2016-11-14T13:28:31Z","updated_at":"2016-11-14T13:28:31Z","html_url":"https://github.com/projectatomic/docker-storage-setup/pull/168#discussion_r87799640","pull_request_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/comments/87799640"},"html":{"href":"https://github.com/projectatomic/docker-storage-setup/pull/168#discussion_r87799640"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168","id":93062082,"html_url":"https://github.com/projectatomic/docker-storage-setup/pull/168","diff_url":"https://github.com/projectatomic/docker-storage-setup/pull/168.diff","patch_url":"https://github.com/projectatomic/docker-storage-setup/pull/168.patch","issue_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/168","number":168,"state":"open","locked":false,"title":"Follow device symlinks in DEVS","user":{"login":"ianabc","id":1831640,"avatar_url":"https://avatars.githubusercontent.com/u/1831640?v=3","gravatar_id":"","url":"https://api.github.com/users/ianabc","html_url":"https://github.com/ianabc","followers_url":"https://api.github.com/users/ianabc/followers","following_url":"https://api.github.com/users/ianabc/following{/other_user}","gists_url":"https://api.github.com/users/ianabc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianabc/subscriptions","organizations_url":"https://api.github.com/users/ianabc/orgs","repos_url":"https://api.github.com/users/ianabc/repos","events_url":"https://api.github.com/users/ianabc/events{/privacy}","received_events_url":"https://api.github.com/users/ianabc/received_events","type":"User","site_admin":false},"body":"This patch just checks if the content of DEVS is a symlink and if it is, follows it.\r\n\r\nI'm adding this to avoid problems I've had with devices being renamed when they are reattached in openstack (but the problem is more general).","created_at":"2016-11-09T23:55:03Z","updated_at":"2016-11-14T13:28:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73475bf0dfaac20128021003315792ae3e06fa48","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168/commits","review_comments_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168/comments","review_comment_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/168/comments","statuses_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/statuses/abaf9dd6fc4a7e70a5f558a43441906fb9857163","head":{"label":"ianabc:master","ref":"master","sha":"abaf9dd6fc4a7e70a5f558a43441906fb9857163","user":{"login":"ianabc","id":1831640,"avatar_url":"https://avatars.githubusercontent.com/u/1831640?v=3","gravatar_id":"","url":"https://api.github.com/users/ianabc","html_url":"https://github.com/ianabc","followers_url":"https://api.github.com/users/ianabc/followers","following_url":"https://api.github.com/users/ianabc/following{/other_user}","gists_url":"https://api.github.com/users/ianabc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianabc/subscriptions","organizations_url":"https://api.github.com/users/ianabc/orgs","repos_url":"https://api.github.com/users/ianabc/repos","events_url":"https://api.github.com/users/ianabc/events{/privacy}","received_events_url":"https://api.github.com/users/ianabc/received_events","type":"User","site_admin":false},"repo":{"id":73330645,"name":"docker-storage-setup","full_name":"ianabc/docker-storage-setup","owner":{"login":"ianabc","id":1831640,"avatar_url":"https://avatars.githubusercontent.com/u/1831640?v=3","gravatar_id":"","url":"https://api.github.com/users/ianabc","html_url":"https://github.com/ianabc","followers_url":"https://api.github.com/users/ianabc/followers","following_url":"https://api.github.com/users/ianabc/following{/other_user}","gists_url":"https://api.github.com/users/ianabc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianabc/subscriptions","organizations_url":"https://api.github.com/users/ianabc/orgs","repos_url":"https://api.github.com/users/ianabc/repos","events_url":"https://api.github.com/users/ianabc/events{/privacy}","received_events_url":"https://api.github.com/users/ianabc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianabc/docker-storage-setup","description":"A simple service to config docker storage","fork":true,"url":"https://api.github.com/repos/ianabc/docker-storage-setup","forks_url":"https://api.github.com/repos/ianabc/docker-storage-setup/forks","keys_url":"https://api.github.com/repos/ianabc/docker-storage-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianabc/docker-storage-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianabc/docker-storage-setup/teams","hooks_url":"https://api.github.com/repos/ianabc/docker-storage-setup/hooks","issue_events_url":"https://api.github.com/repos/ianabc/docker-storage-setup/issues/events{/number}","events_url":"https://api.github.com/repos/ianabc/docker-storage-setup/events","assignees_url":"https://api.github.com/repos/ianabc/docker-storage-setup/assignees{/user}","branches_url":"https://api.github.com/repos/ianabc/docker-storage-setup/branches{/branch}","tags_url":"https://api.github.com/repos/ianabc/docker-storage-setup/tags","blobs_url":"https://api.github.com/repos/ianabc/docker-storage-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianabc/docker-storage-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianabc/docker-storage-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianabc/docker-storage-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianabc/docker-storage-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/ianabc/docker-storage-setup/languages","stargazers_url":"https://api.github.com/repos/ianabc/docker-storage-setup/stargazers","contributors_url":"https://api.github.com/repos/ianabc/docker-storage-setup/contributors","subscribers_url":"https://api.github.com/repos/ianabc/docker-storage-setup/subscribers","subscription_url":"https://api.github.com/repos/ianabc/docker-storage-setup/subscription","commits_url":"https://api.github.com/repos/ianabc/docker-storage-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianabc/docker-storage-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianabc/docker-storage-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianabc/docker-storage-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianabc/docker-storage-setup/contents/{+path}","compare_url":"https://api.github.com/repos/ianabc/docker-storage-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianabc/docker-storage-setup/merges","archive_url":"https://api.github.com/repos/ianabc/docker-storage-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianabc/docker-storage-setup/downloads","issues_url":"https://api.github.com/repos/ianabc/docker-storage-setup/issues{/number}","pulls_url":"https://api.github.com/repos/ianabc/docker-storage-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/ianabc/docker-storage-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/ianabc/docker-storage-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianabc/docker-storage-setup/labels{/name}","releases_url":"https://api.github.com/repos/ianabc/docker-storage-setup/releases{/id}","deployments_url":"https://api.github.com/repos/ianabc/docker-storage-setup/deployments","created_at":"2016-11-09T23:44:54Z","updated_at":"2016-11-09T23:44:55Z","pushed_at":"2016-11-12T20:21:19Z","git_url":"git://github.com/ianabc/docker-storage-setup.git","ssh_url":"git@github.com:ianabc/docker-storage-setup.git","clone_url":"https://github.com/ianabc/docker-storage-setup.git","svn_url":"https://github.com/ianabc/docker-storage-setup","homepage":null,"size":215,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"c9faba1908b8e77f7c7c443f26e3b3cb1450d1a0","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":25310367,"name":"docker-storage-setup","full_name":"projectatomic/docker-storage-setup","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/docker-storage-setup","description":"A simple service to config docker storage","fork":false,"url":"https://api.github.com/repos/projectatomic/docker-storage-setup","forks_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/forks","keys_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/teams","hooks_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/events","assignees_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/tags","blobs_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/languages","stargazers_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/subscription","commits_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/merges","archive_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/downloads","issues_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/docker-storage-setup/deployments","created_at":"2014-10-16T16:11:13Z","updated_at":"2016-11-09T02:17:02Z","pushed_at":"2016-11-12T20:21:19Z","git_url":"git://github.com/projectatomic/docker-storage-setup.git","ssh_url":"git@github.com:projectatomic/docker-storage-setup.git","clone_url":"https://github.com/projectatomic/docker-storage-setup.git","svn_url":"https://github.com/projectatomic/docker-storage-setup","homepage":null,"size":291,"stargazers_count":70,"watchers_count":70,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":34,"forks":53,"open_issues":34,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168"},"html":{"href":"https://github.com/projectatomic/docker-storage-setup/pull/168"},"issue":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/168"},"comments":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/docker-storage-setup/statuses/abaf9dd6fc4a7e70a5f558a43441906fb9857163"}}}}
{"actor":{"display_login":"rhvgoyal"}}