{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/ambry/issues/310","repository_url":"https://api.github.com/repos/linkedin/ambry","labels_url":"https://api.github.com/repos/linkedin/ambry/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/310/comments","events_url":"https://api.github.com/repos/linkedin/ambry/issues/310/events","html_url":"https://github.com/linkedin/ambry/pull/310","id":155070946,"number":310,"title":"Fixing the way Selector handles SSL connection handshakes","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-16T16:50:02Z","updated_at":"2016-05-18T16:09:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/310","html_url":"https://github.com/linkedin/ambry/pull/310","diff_url":"https://github.com/linkedin/ambry/pull/310.diff","patch_url":"https://github.com/linkedin/ambry/pull/310.patch"},"body":"Currently, for connections over SSL, the ambry selector returns an established connection after a poll even before the handshake is completed. This is not very useful as the caller will then have to repeatedly check outside of the selector poll on whether the handshake is complete, which is not ideal.\r\n\r\nThis patch fixes this issue.\r\nThe selector will only return a connection after the connection is established and the handshake is complete. If the handshake does not complete for any reason, then it should be treated as a connection establishment failure. This way the callers of the selector can be agnostic to SSL, and can interact with the selector in a completely non-blocking way.\r\n\r\nSLA: 10 mins\r\nReviewers: Priyesh, Ming\r\n"},"comment":{"url":"https://api.github.com/repos/linkedin/ambry/issues/comments/220076707","html_url":"https://github.com/linkedin/ambry/pull/310#issuecomment-220076707","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/310","id":220076707,"user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T16:09:07Z","updated_at":"2016-05-18T16:09:07Z","body":"@pnarayanan : done addressing all your comments."}}