{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/92696174","pull_request_review_id":13216748,"id":92696174,"diff_hunk":"@@ -954,6 +954,13 @@ ExecHashJoinNewBatch(HashJoinState *hjstate)\n \t\t\thashtable->stats->batchstats[curbatch].innerfilesize =\n \t\t\t\tExecWorkFile_Tell64(hashtable->batches[curbatch]->innerside.workfile);\n \t\t}\n+#ifdef FAULT_INJECTOR\n+\t\tFaultInjector_InjectFaultIfSet(\n+\t\t\t\tWorkfileHashJoinFailure,\n+\t\t\t\tDDLNotSpecified,\n+\t\t\t\t\"\",  // databaseName\n+\t\t\t\t\"\"); // tableName\n+#endif","path":"src/backend/executor/nodeHashjoin.c","position":10,"original_position":10,"commit_id":"d242590567512ecc1fc70b97c00fd5d2b0fdadcf","original_commit_id":"cea5a8c221fd911a6e070eb335a661c2e0d0e95b","user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"body":"This can instead use the `SIMPLE_FAULT_INJECTOR(WorkfileHashJoinFailure);` construction which IMO is more readable.","created_at":"2016-12-15T20:44:28Z","updated_at":"2016-12-15T20:44:49Z","html_url":"https://github.com/greenplum-db/gpdb/pull/1449#discussion_r92696174","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/92696174"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1449#discussion_r92696174"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449","id":98218870,"html_url":"https://github.com/greenplum-db/gpdb/pull/1449","diff_url":"https://github.com/greenplum-db/gpdb/pull/1449.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1449.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1449","number":1449,"state":"open","locked":false,"title":"Refactor BFZ stuff to not rely depend on gfile.","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"body":"This greatly simplifies the error handling and resource cleanup of Bfz\r\nfiles. Now closing and unlinking the bfz files on error is handled by\r\nthe resource owner mechanism.\r\n\r\nThis brings the BufFile and BFZ codepaths of so-called \"workfiles\", in\r\nexecWorkFile.c, much closer to each other. Both now rely on the same\r\nmechanism for resource cleanup.\r\n\r\nThis fixes a crash in the test case that's memorized in the included\r\nregression test.\r\n\r\nAnalysis and test case by Karthikeyan Jambu Rajaraman.","created_at":"2016-12-15T19:52:47Z","updated_at":"2016-12-15T21:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"824e27196a5696735612989e19e1e60c42cd3f20","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1449/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/d242590567512ecc1fc70b97c00fd5d2b0fdadcf","head":{"label":"hlinnaka:bfz-refactor","ref":"bfz-refactor","sha":"d242590567512ecc1fc70b97c00fd5d2b0fdadcf","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"repo":{"id":45393662,"name":"gpdb","full_name":"hlinnaka/gpdb","owner":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlinnaka/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/hlinnaka/gpdb","forks_url":"https://api.github.com/repos/hlinnaka/gpdb/forks","keys_url":"https://api.github.com/repos/hlinnaka/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlinnaka/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlinnaka/gpdb/teams","hooks_url":"https://api.github.com/repos/hlinnaka/gpdb/hooks","issue_events_url":"https://api.github.com/repos/hlinnaka/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/hlinnaka/gpdb/events","assignees_url":"https://api.github.com/repos/hlinnaka/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/hlinnaka/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/hlinnaka/gpdb/tags","blobs_url":"https://api.github.com/repos/hlinnaka/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlinnaka/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlinnaka/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlinnaka/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlinnaka/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/hlinnaka/gpdb/languages","stargazers_url":"https://api.github.com/repos/hlinnaka/gpdb/stargazers","contributors_url":"https://api.github.com/repos/hlinnaka/gpdb/contributors","subscribers_url":"https://api.github.com/repos/hlinnaka/gpdb/subscribers","subscription_url":"https://api.github.com/repos/hlinnaka/gpdb/subscription","commits_url":"https://api.github.com/repos/hlinnaka/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlinnaka/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlinnaka/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlinnaka/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/hlinnaka/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/hlinnaka/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlinnaka/gpdb/merges","archive_url":"https://api.github.com/repos/hlinnaka/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlinnaka/gpdb/downloads","issues_url":"https://api.github.com/repos/hlinnaka/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/hlinnaka/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/hlinnaka/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/hlinnaka/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlinnaka/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/hlinnaka/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/hlinnaka/gpdb/deployments","created_at":"2015-11-02T12:40:55Z","updated_at":"2016-09-27T20:48:01Z","pushed_at":"2016-12-15T20:44:49Z","git_url":"git://github.com/hlinnaka/gpdb.git","ssh_url":"git@github.com:hlinnaka/gpdb.git","clone_url":"https://github.com/hlinnaka/gpdb.git","svn_url":"https://github.com/hlinnaka/gpdb","homepage":"http://greenplum.org","size":223029,"stargazers_count":3,"watchers_count":3,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"161661798faa6356562bc1316d46eecab1b0338e","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-12-15T10:38:29Z","pushed_at":"2016-12-15T20:44:49Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":182552,"stargazers_count":1729,"watchers_count":1729,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":507,"mirror_url":null,"open_issues_count":120,"forks":507,"open_issues":120,"watchers":1729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1449"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1449"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1449/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1449/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/d242590567512ecc1fc70b97c00fd5d2b0fdadcf"}}}}
{"actor":{"display_login":"danielgustafsson"}}