{"action":"created","comment":{"url":"https://api.github.com/repos/llgcode/draw2d/pulls/comments/93399188","pull_request_review_id":13924425,"id":93399188,"diff_hunk":"@@ -52,6 +52,10 @@ type GraphicContext interface {\n \tGetFontData() FontData\n \t// GetFontName gets the current FontData as a string\n \tGetFontName() string\n+\t// SetGlyphCache changes the glyph cache backend used by the GraphicContext\n+\tSetGlyphCache(cache GlyphCache)","path":"gc.go","position":5,"original_position":5,"commit_id":"138c71d1c059da1a5959f46c8e06d207d9066e4e","original_commit_id":"138c71d1c059da1a5959f46c8e06d207d9066e4e","user":{"login":"llgcode","id":524083,"avatar_url":"https://avatars.githubusercontent.com/u/524083?v=3","gravatar_id":"","url":"https://api.github.com/users/llgcode","html_url":"https://github.com/llgcode","followers_url":"https://api.github.com/users/llgcode/followers","following_url":"https://api.github.com/users/llgcode/following{/other_user}","gists_url":"https://api.github.com/users/llgcode/gists{/gist_id}","starred_url":"https://api.github.com/users/llgcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llgcode/subscriptions","organizations_url":"https://api.github.com/users/llgcode/orgs","repos_url":"https://api.github.com/users/llgcode/repos","events_url":"https://api.github.com/users/llgcode/events{/privacy}","received_events_url":"https://api.github.com/users/llgcode/received_events","type":"User","site_admin":false},"body":"I think this function don't have to be in the Gc interface. It is useful only in some implementation of Gc not all.","created_at":"2016-12-21T09:07:58Z","updated_at":"2016-12-21T09:07:58Z","html_url":"https://github.com/llgcode/draw2d/pull/128#discussion_r93399188","pull_request_url":"https://api.github.com/repos/llgcode/draw2d/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/llgcode/draw2d/pulls/comments/93399188"},"html":{"href":"https://github.com/llgcode/draw2d/pull/128#discussion_r93399188"},"pull_request":{"href":"https://api.github.com/repos/llgcode/draw2d/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/llgcode/draw2d/pulls/128","id":98455380,"html_url":"https://github.com/llgcode/draw2d/pull/128","diff_url":"https://github.com/llgcode/draw2d/pull/128.diff","patch_url":"https://github.com/llgcode/draw2d/pull/128.patch","issue_url":"https://api.github.com/repos/llgcode/draw2d/issues/128","number":128,"state":"open","locked":false,"title":"Implement a proper GlyphCache interface","user":{"login":"redstarcoder","id":22847904,"avatar_url":"https://avatars.githubusercontent.com/u/22847904?v=3","gravatar_id":"","url":"https://api.github.com/users/redstarcoder","html_url":"https://github.com/redstarcoder","followers_url":"https://api.github.com/users/redstarcoder/followers","following_url":"https://api.github.com/users/redstarcoder/following{/other_user}","gists_url":"https://api.github.com/users/redstarcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/redstarcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstarcoder/subscriptions","organizations_url":"https://api.github.com/users/redstarcoder/orgs","repos_url":"https://api.github.com/users/redstarcoder/repos","events_url":"https://api.github.com/users/redstarcoder/events{/privacy}","received_events_url":"https://api.github.com/users/redstarcoder/received_events","type":"User","site_admin":false},"body":"This is related to #121 and I think #126. This is untested. This allows `glyphCache` to be replaced and restored.","created_at":"2016-12-17T20:48:00Z","updated_at":"2016-12-21T09:07:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c71fff59e63f668c6a0a9fe59426e13b43a4ce49","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/llgcode/draw2d/pulls/128/commits","review_comments_url":"https://api.github.com/repos/llgcode/draw2d/pulls/128/comments","review_comment_url":"https://api.github.com/repos/llgcode/draw2d/pulls/comments{/number}","comments_url":"https://api.github.com/repos/llgcode/draw2d/issues/128/comments","statuses_url":"https://api.github.com/repos/llgcode/draw2d/statuses/138c71d1c059da1a5959f46c8e06d207d9066e4e","head":{"label":"redstarcoder:glyphcacheinterface","ref":"glyphcacheinterface","sha":"138c71d1c059da1a5959f46c8e06d207d9066e4e","user":{"login":"redstarcoder","id":22847904,"avatar_url":"https://avatars.githubusercontent.com/u/22847904?v=3","gravatar_id":"","url":"https://api.github.com/users/redstarcoder","html_url":"https://github.com/redstarcoder","followers_url":"https://api.github.com/users/redstarcoder/followers","following_url":"https://api.github.com/users/redstarcoder/following{/other_user}","gists_url":"https://api.github.com/users/redstarcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/redstarcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstarcoder/subscriptions","organizations_url":"https://api.github.com/users/redstarcoder/orgs","repos_url":"https://api.github.com/users/redstarcoder/repos","events_url":"https://api.github.com/users/redstarcoder/events{/privacy}","received_events_url":"https://api.github.com/users/redstarcoder/received_events","type":"User","site_admin":false},"repo":{"id":70990547,"name":"draw2d","full_name":"redstarcoder/draw2d","owner":{"login":"redstarcoder","id":22847904,"avatar_url":"https://avatars.githubusercontent.com/u/22847904?v=3","gravatar_id":"","url":"https://api.github.com/users/redstarcoder","html_url":"https://github.com/redstarcoder","followers_url":"https://api.github.com/users/redstarcoder/followers","following_url":"https://api.github.com/users/redstarcoder/following{/other_user}","gists_url":"https://api.github.com/users/redstarcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/redstarcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redstarcoder/subscriptions","organizations_url":"https://api.github.com/users/redstarcoder/orgs","repos_url":"https://api.github.com/users/redstarcoder/repos","events_url":"https://api.github.com/users/redstarcoder/events{/privacy}","received_events_url":"https://api.github.com/users/redstarcoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/redstarcoder/draw2d","description":"draw2d","fork":true,"url":"https://api.github.com/repos/redstarcoder/draw2d","forks_url":"https://api.github.com/repos/redstarcoder/draw2d/forks","keys_url":"https://api.github.com/repos/redstarcoder/draw2d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redstarcoder/draw2d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redstarcoder/draw2d/teams","hooks_url":"https://api.github.com/repos/redstarcoder/draw2d/hooks","issue_events_url":"https://api.github.com/repos/redstarcoder/draw2d/issues/events{/number}","events_url":"https://api.github.com/repos/redstarcoder/draw2d/events","assignees_url":"https://api.github.com/repos/redstarcoder/draw2d/assignees{/user}","branches_url":"https://api.github.com/repos/redstarcoder/draw2d/branches{/branch}","tags_url":"https://api.github.com/repos/redstarcoder/draw2d/tags","blobs_url":"https://api.github.com/repos/redstarcoder/draw2d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redstarcoder/draw2d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redstarcoder/draw2d/git/refs{/sha}","trees_url":"https://api.github.com/repos/redstarcoder/draw2d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redstarcoder/draw2d/statuses/{sha}","languages_url":"https://api.github.com/repos/redstarcoder/draw2d/languages","stargazers_url":"https://api.github.com/repos/redstarcoder/draw2d/stargazers","contributors_url":"https://api.github.com/repos/redstarcoder/draw2d/contributors","subscribers_url":"https://api.github.com/repos/redstarcoder/draw2d/subscribers","subscription_url":"https://api.github.com/repos/redstarcoder/draw2d/subscription","commits_url":"https://api.github.com/repos/redstarcoder/draw2d/commits{/sha}","git_commits_url":"https://api.github.com/repos/redstarcoder/draw2d/git/commits{/sha}","comments_url":"https://api.github.com/repos/redstarcoder/draw2d/comments{/number}","issue_comment_url":"https://api.github.com/repos/redstarcoder/draw2d/issues/comments{/number}","contents_url":"https://api.github.com/repos/redstarcoder/draw2d/contents/{+path}","compare_url":"https://api.github.com/repos/redstarcoder/draw2d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redstarcoder/draw2d/merges","archive_url":"https://api.github.com/repos/redstarcoder/draw2d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redstarcoder/draw2d/downloads","issues_url":"https://api.github.com/repos/redstarcoder/draw2d/issues{/number}","pulls_url":"https://api.github.com/repos/redstarcoder/draw2d/pulls{/number}","milestones_url":"https://api.github.com/repos/redstarcoder/draw2d/milestones{/number}","notifications_url":"https://api.github.com/repos/redstarcoder/draw2d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redstarcoder/draw2d/labels{/name}","releases_url":"https://api.github.com/repos/redstarcoder/draw2d/releases{/id}","deployments_url":"https://api.github.com/repos/redstarcoder/draw2d/deployments","created_at":"2016-10-15T13:50:49Z","updated_at":"2016-10-15T13:50:51Z","pushed_at":"2016-12-20T23:20:27Z","git_url":"git://github.com/redstarcoder/draw2d.git","ssh_url":"git@github.com:redstarcoder/draw2d.git","clone_url":"https://github.com/redstarcoder/draw2d.git","svn_url":"https://github.com/redstarcoder/draw2d","homepage":"","size":9949,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"llgcode:master","ref":"master","sha":"1286d3b2030ac9952e59c5ef29ef3cc24a8e83d5","user":{"login":"llgcode","id":524083,"avatar_url":"https://avatars.githubusercontent.com/u/524083?v=3","gravatar_id":"","url":"https://api.github.com/users/llgcode","html_url":"https://github.com/llgcode","followers_url":"https://api.github.com/users/llgcode/followers","following_url":"https://api.github.com/users/llgcode/following{/other_user}","gists_url":"https://api.github.com/users/llgcode/gists{/gist_id}","starred_url":"https://api.github.com/users/llgcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llgcode/subscriptions","organizations_url":"https://api.github.com/users/llgcode/orgs","repos_url":"https://api.github.com/users/llgcode/repos","events_url":"https://api.github.com/users/llgcode/events{/privacy}","received_events_url":"https://api.github.com/users/llgcode/received_events","type":"User","site_admin":false},"repo":{"id":32141743,"name":"draw2d","full_name":"llgcode/draw2d","owner":{"login":"llgcode","id":524083,"avatar_url":"https://avatars.githubusercontent.com/u/524083?v=3","gravatar_id":"","url":"https://api.github.com/users/llgcode","html_url":"https://github.com/llgcode","followers_url":"https://api.github.com/users/llgcode/followers","following_url":"https://api.github.com/users/llgcode/following{/other_user}","gists_url":"https://api.github.com/users/llgcode/gists{/gist_id}","starred_url":"https://api.github.com/users/llgcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llgcode/subscriptions","organizations_url":"https://api.github.com/users/llgcode/orgs","repos_url":"https://api.github.com/users/llgcode/repos","events_url":"https://api.github.com/users/llgcode/events{/privacy}","received_events_url":"https://api.github.com/users/llgcode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/llgcode/draw2d","description":"draw2d","fork":false,"url":"https://api.github.com/repos/llgcode/draw2d","forks_url":"https://api.github.com/repos/llgcode/draw2d/forks","keys_url":"https://api.github.com/repos/llgcode/draw2d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/llgcode/draw2d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/llgcode/draw2d/teams","hooks_url":"https://api.github.com/repos/llgcode/draw2d/hooks","issue_events_url":"https://api.github.com/repos/llgcode/draw2d/issues/events{/number}","events_url":"https://api.github.com/repos/llgcode/draw2d/events","assignees_url":"https://api.github.com/repos/llgcode/draw2d/assignees{/user}","branches_url":"https://api.github.com/repos/llgcode/draw2d/branches{/branch}","tags_url":"https://api.github.com/repos/llgcode/draw2d/tags","blobs_url":"https://api.github.com/repos/llgcode/draw2d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/llgcode/draw2d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/llgcode/draw2d/git/refs{/sha}","trees_url":"https://api.github.com/repos/llgcode/draw2d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/llgcode/draw2d/statuses/{sha}","languages_url":"https://api.github.com/repos/llgcode/draw2d/languages","stargazers_url":"https://api.github.com/repos/llgcode/draw2d/stargazers","contributors_url":"https://api.github.com/repos/llgcode/draw2d/contributors","subscribers_url":"https://api.github.com/repos/llgcode/draw2d/subscribers","subscription_url":"https://api.github.com/repos/llgcode/draw2d/subscription","commits_url":"https://api.github.com/repos/llgcode/draw2d/commits{/sha}","git_commits_url":"https://api.github.com/repos/llgcode/draw2d/git/commits{/sha}","comments_url":"https://api.github.com/repos/llgcode/draw2d/comments{/number}","issue_comment_url":"https://api.github.com/repos/llgcode/draw2d/issues/comments{/number}","contents_url":"https://api.github.com/repos/llgcode/draw2d/contents/{+path}","compare_url":"https://api.github.com/repos/llgcode/draw2d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/llgcode/draw2d/merges","archive_url":"https://api.github.com/repos/llgcode/draw2d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/llgcode/draw2d/downloads","issues_url":"https://api.github.com/repos/llgcode/draw2d/issues{/number}","pulls_url":"https://api.github.com/repos/llgcode/draw2d/pulls{/number}","milestones_url":"https://api.github.com/repos/llgcode/draw2d/milestones{/number}","notifications_url":"https://api.github.com/repos/llgcode/draw2d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/llgcode/draw2d/labels{/name}","releases_url":"https://api.github.com/repos/llgcode/draw2d/releases{/id}","deployments_url":"https://api.github.com/repos/llgcode/draw2d/deployments","created_at":"2015-03-13T08:07:25Z","updated_at":"2016-12-13T10:51:45Z","pushed_at":"2016-12-20T23:20:28Z","git_url":"git://github.com/llgcode/draw2d.git","ssh_url":"git@github.com:llgcode/draw2d.git","clone_url":"https://github.com/llgcode/draw2d.git","svn_url":"https://github.com/llgcode/draw2d","homepage":"","size":9950,"stargazers_count":271,"watchers_count":271,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":29,"forks":30,"open_issues":29,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/llgcode/draw2d/pulls/128"},"html":{"href":"https://github.com/llgcode/draw2d/pull/128"},"issue":{"href":"https://api.github.com/repos/llgcode/draw2d/issues/128"},"comments":{"href":"https://api.github.com/repos/llgcode/draw2d/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/llgcode/draw2d/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/llgcode/draw2d/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/llgcode/draw2d/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/llgcode/draw2d/statuses/138c71d1c059da1a5959f46c8e06d207d9066e4e"}}}}
{"actor":{"display_login":"llgcode"}}