{"action":"created","issue":{"url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/187","repository_url":"https://api.github.com/repos/lytics/ember-data-model-fragments","labels_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/187/comments","events_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/187/events","html_url":"https://github.com/lytics/ember-data-model-fragments/pull/187","id":142511900,"number":187,"title":"WIP - Convert to Ember-CLI Addon ","user":{"login":"workmanw","id":825487,"avatar_url":"https://avatars.githubusercontent.com/u/825487?v=3","gravatar_id":"","url":"https://api.github.com/users/workmanw","html_url":"https://github.com/workmanw","followers_url":"https://api.github.com/users/workmanw/followers","following_url":"https://api.github.com/users/workmanw/following{/other_user}","gists_url":"https://api.github.com/users/workmanw/gists{/gist_id}","starred_url":"https://api.github.com/users/workmanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workmanw/subscriptions","organizations_url":"https://api.github.com/users/workmanw/orgs","repos_url":"https://api.github.com/users/workmanw/repos","events_url":"https://api.github.com/users/workmanw/events{/privacy}","received_events_url":"https://api.github.com/users/workmanw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-22T00:37:38Z","updated_at":"2016-03-22T21:25:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lytics/ember-data-model-fragments/pulls/187","html_url":"https://github.com/lytics/ember-data-model-fragments/pull/187","diff_url":"https://github.com/lytics/ember-data-model-fragments/pull/187.diff","patch_url":"https://github.com/lytics/ember-data-model-fragments/pull/187.patch"},"body":"Originally written by @jakesjews in #186: \r\n\r\n> There is still a bit of cleanup to do but I wanted to get this out in the open. So far this seems to be working when I pull it into my company's applications. The tests are all passing locally but most of them are making deprecated calls to application.\\_\\_container\\_\\_. I've only really used mocha for testing ember apps so if anyone who's better at QUnit has some suggestions that would be very helpful.\r\n\r\nTODO:\r\n- [x] Replace deprecated calls to application.\\_\\_container\\_\\_ in the tests [@workmanw]\r\n- [x] Restore `expectNoDeprecation` [@workmanw]\r\n- [ ] Replace moduleForAcceptance usage in unit tests (if possible)\r\n- [ ] @workmanw code review, check merged commits, test in Batterii.\r\n- [ ] Fix debug version number display [@jakesjews] \r\n- [ ] Updating README.md\r\n- [ ] Do we need the `ember-new-computed` polyfill?"},"comment":{"url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/comments/200036432","html_url":"https://github.com/lytics/ember-data-model-fragments/pull/187#issuecomment-200036432","issue_url":"https://api.github.com/repos/lytics/ember-data-model-fragments/issues/187","id":200036432,"user":{"login":"jakesjews","id":481412,"avatar_url":"https://avatars.githubusercontent.com/u/481412?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesjews","html_url":"https://github.com/jakesjews","followers_url":"https://api.github.com/users/jakesjews/followers","following_url":"https://api.github.com/users/jakesjews/following{/other_user}","gists_url":"https://api.github.com/users/jakesjews/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesjews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesjews/subscriptions","organizations_url":"https://api.github.com/users/jakesjews/orgs","repos_url":"https://api.github.com/users/jakesjews/repos","events_url":"https://api.github.com/users/jakesjews/events{/privacy}","received_events_url":"https://api.github.com/users/jakesjews/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T21:25:32Z","updated_at":"2016-03-22T21:25:32Z","body":"@workmanw I threw that in after trying it in our app so it probably does need to be moved. I think its ok to remove it since we're targeting newer ember versions."}}