{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/shim/issues/53","repository_url":"https://api.github.com/repos/dojo/shim","labels_url":"https://api.github.com/repos/dojo/shim/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/dojo/shim/issues/53/comments","events_url":"https://api.github.com/repos/dojo/shim/issues/53/events","html_url":"https://github.com/dojo/shim/pull/53","id":190145092,"number":53,"title":"Fixing an issue with the promise shim","user":{"login":"rorticus","id":2008858,"avatar_url":"https://avatars.githubusercontent.com/u/2008858?v=3","gravatar_id":"","url":"https://api.github.com/users/rorticus","html_url":"https://github.com/rorticus","followers_url":"https://api.github.com/users/rorticus/followers","following_url":"https://api.github.com/users/rorticus/following{/other_user}","gists_url":"https://api.github.com/users/rorticus/gists{/gist_id}","starred_url":"https://api.github.com/users/rorticus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rorticus/subscriptions","organizations_url":"https://api.github.com/users/rorticus/orgs","repos_url":"https://api.github.com/users/rorticus/repos","events_url":"https://api.github.com/users/rorticus/events{/privacy}","received_events_url":"https://api.github.com/users/rorticus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-17T19:47:24Z","updated_at":"2016-11-17T19:52:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dojo/shim/pulls/53","html_url":"https://github.com/dojo/shim/pull/53","diff_url":"https://github.com/dojo/shim/pull/53.diff","patch_url":"https://github.com/dojo/shim/pull/53.patch"},"body":"**Type:** bug\r\n\r\n**Description:** \r\n\r\nA fix for a problem with `Promise.all`. The arguments accept a `Thenable`, but the actual code was checking specifically for a `Promise` type later on. This meant that you couldn't actually pass in a `Thenable` that wasn't a `Promise`.\r\n\r\nPlease review this checklist before submitting your PR:\r\n\r\n* [ ] There is a related issue\r\n* [x] All contributors have signed a CLA\r\n* [x] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [x] The code passes the CI tests\r\n* [ ] Unit or Functional tests are included in the PR\r\n* [x] The PR increases or maintains the overall unit test coverage percentage\r\n* [x] The code is ready to be merged\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dojo/shim/issues/comments/261350722","html_url":"https://github.com/dojo/shim/pull/53#issuecomment-261350722","issue_url":"https://api.github.com/repos/dojo/shim/issues/53","id":261350722,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T19:52:15Z","updated_at":"2016-11-17T19:52:15Z","body":"## [Current coverage](https://codecov.io/gh/dojo/shim/pull/53?src=pr) is 97.95% (diff: 100%)\n> Merging [#53](https://codecov.io/gh/dojo/shim/pull/53?src=pr) into [master](https://codecov.io/gh/dojo/shim/branch/master?src=pr) will not change coverage\n\n```diff\n@@             master        #53   diff @@\n==========================================\n  Files            29         29          \n  Lines          1074       1074          \n  Methods          21         21          \n  Messages          0          0          \n  Branches        195        195          \n==========================================\n  Hits           1052       1052          \n  Misses           21         21          \n  Partials          1          1          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [5ad0f8c...51e7721](https://codecov.io/gh/dojo/shim/compare/5ad0f8c53266cdcd1ec268f9a314958f1c80fc71...51e77212d7bf8c3ba2a5ddf0e4b6d8571c75a5c6?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}