{"action":"created","comment":{"url":"https://api.github.com/repos/jayway/awaitility/pulls/comments/58983159","id":58983159,"diff_hunk":"@@ -54,6 +54,15 @@\n     <build>\n         <plugins>\n             <plugin>\n+                <groupId>org.apache.maven.plugins</groupId>","path":"awaitility-groovy/pom.xml","position":null,"original_position":4,"commit_id":"dc438c35883b2bb082fe33b13a8a23a815e0e9fe","original_commit_id":"4628ea38ce54457d1a6bfbaf924e3e227885dcec","user":{"login":"johanhaleby","id":187029,"avatar_url":"https://avatars.githubusercontent.com/u/187029?v=3","gravatar_id":"","url":"https://api.github.com/users/johanhaleby","html_url":"https://github.com/johanhaleby","followers_url":"https://api.github.com/users/johanhaleby/followers","following_url":"https://api.github.com/users/johanhaleby/following{/other_user}","gists_url":"https://api.github.com/users/johanhaleby/gists{/gist_id}","starred_url":"https://api.github.com/users/johanhaleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanhaleby/subscriptions","organizations_url":"https://api.github.com/users/johanhaleby/orgs","repos_url":"https://api.github.com/users/johanhaleby/repos","events_url":"https://api.github.com/users/johanhaleby/events{/privacy}","received_events_url":"https://api.github.com/users/johanhaleby/received_events","type":"User","site_admin":false},"body":"What's the reason for adding these settings to the surefire plugin? Are they required for end users as well!?","created_at":"2016-04-08T05:59:48Z","updated_at":"2016-04-08T05:59:48Z","html_url":"https://github.com/jayway/awaitility/pull/46#discussion_r58983159","pull_request_url":"https://api.github.com/repos/jayway/awaitility/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/jayway/awaitility/pulls/comments/58983159"},"html":{"href":"https://github.com/jayway/awaitility/pull/46#discussion_r58983159"},"pull_request":{"href":"https://api.github.com/repos/jayway/awaitility/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/jayway/awaitility/pulls/46","id":65700412,"html_url":"https://github.com/jayway/awaitility/pull/46","diff_url":"https://github.com/jayway/awaitility/pull/46.diff","patch_url":"https://github.com/jayway/awaitility/pull/46.patch","issue_url":"https://api.github.com/repos/jayway/awaitility/issues/46","number":46,"state":"open","locked":false,"title":"Groovy extension module","user":{"login":"tschulte","id":203910,"avatar_url":"https://avatars.githubusercontent.com/u/203910?v=3","gravatar_id":"","url":"https://api.github.com/users/tschulte","html_url":"https://github.com/tschulte","followers_url":"https://api.github.com/users/tschulte/followers","following_url":"https://api.github.com/users/tschulte/following{/other_user}","gists_url":"https://api.github.com/users/tschulte/gists{/gist_id}","starred_url":"https://api.github.com/users/tschulte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschulte/subscriptions","organizations_url":"https://api.github.com/users/tschulte/orgs","repos_url":"https://api.github.com/users/tschulte/repos","events_url":"https://api.github.com/users/tschulte/events{/privacy}","received_events_url":"https://api.github.com/users/tschulte/received_events","type":"User","site_admin":false},"body":"Both AwaitilitySupport (meant to be used as @Mixin) and\r\nAwaitilityTrait (meant to be implemented) have one big flaw. When not used\r\nfor one test class, these test cases might or might not fail, depending on\r\nexecution order.\r\n\r\nThe AwaitilityExtensionModule will automatically add a new method\r\nuntil(Closure) to the ConditionFactory. So with groovy 2 and above, there\r\nis effectively no need any more to use AwaitilitySupport, AwaitilityTrait\r\nor AwaitilityGroovyBridge. All you need to do is add awaitility-groovy\r\nto your classpath and you are good.\r\n\r\nThe first implementation overloading until(Closure) did not work. I think this has the same reason as described in http://stackoverflow.com/questions/26037514/groovy-method-overloading-selection-of-method-prefers-interfaces-over-subclasse. Therefore I chose to overwrite the until(Runnable) method and dispatching to the method until(Condition). This method is private, but that is no problem (for now -- but I don't know if this will stay this way) for Groovy.\r\n\r\nWhat do you think?","created_at":"2016-04-07T21:10:36Z","updated_at":"2016-04-08T05:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35829f04b3f8f26dd8f20413f7ba632d0214a2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jayway/awaitility/pulls/46/commits","review_comments_url":"https://api.github.com/repos/jayway/awaitility/pulls/46/comments","review_comment_url":"https://api.github.com/repos/jayway/awaitility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jayway/awaitility/issues/46/comments","statuses_url":"https://api.github.com/repos/jayway/awaitility/statuses/dc438c35883b2bb082fe33b13a8a23a815e0e9fe","head":{"label":"tschulte:groovy-extension-module","ref":"groovy-extension-module","sha":"dc438c35883b2bb082fe33b13a8a23a815e0e9fe","user":{"login":"tschulte","id":203910,"avatar_url":"https://avatars.githubusercontent.com/u/203910?v=3","gravatar_id":"","url":"https://api.github.com/users/tschulte","html_url":"https://github.com/tschulte","followers_url":"https://api.github.com/users/tschulte/followers","following_url":"https://api.github.com/users/tschulte/following{/other_user}","gists_url":"https://api.github.com/users/tschulte/gists{/gist_id}","starred_url":"https://api.github.com/users/tschulte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschulte/subscriptions","organizations_url":"https://api.github.com/users/tschulte/orgs","repos_url":"https://api.github.com/users/tschulte/repos","events_url":"https://api.github.com/users/tschulte/events{/privacy}","received_events_url":"https://api.github.com/users/tschulte/received_events","type":"User","site_admin":false},"repo":{"id":55697921,"name":"awaitility","full_name":"tschulte/awaitility","owner":{"login":"tschulte","id":203910,"avatar_url":"https://avatars.githubusercontent.com/u/203910?v=3","gravatar_id":"","url":"https://api.github.com/users/tschulte","html_url":"https://github.com/tschulte","followers_url":"https://api.github.com/users/tschulte/followers","following_url":"https://api.github.com/users/tschulte/following{/other_user}","gists_url":"https://api.github.com/users/tschulte/gists{/gist_id}","starred_url":"https://api.github.com/users/tschulte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschulte/subscriptions","organizations_url":"https://api.github.com/users/tschulte/orgs","repos_url":"https://api.github.com/users/tschulte/repos","events_url":"https://api.github.com/users/tschulte/events{/privacy}","received_events_url":"https://api.github.com/users/tschulte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tschulte/awaitility","description":"Awaitility is a small Java DSL for synchronizing asynchronous operations","fork":true,"url":"https://api.github.com/repos/tschulte/awaitility","forks_url":"https://api.github.com/repos/tschulte/awaitility/forks","keys_url":"https://api.github.com/repos/tschulte/awaitility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tschulte/awaitility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tschulte/awaitility/teams","hooks_url":"https://api.github.com/repos/tschulte/awaitility/hooks","issue_events_url":"https://api.github.com/repos/tschulte/awaitility/issues/events{/number}","events_url":"https://api.github.com/repos/tschulte/awaitility/events","assignees_url":"https://api.github.com/repos/tschulte/awaitility/assignees{/user}","branches_url":"https://api.github.com/repos/tschulte/awaitility/branches{/branch}","tags_url":"https://api.github.com/repos/tschulte/awaitility/tags","blobs_url":"https://api.github.com/repos/tschulte/awaitility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tschulte/awaitility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tschulte/awaitility/git/refs{/sha}","trees_url":"https://api.github.com/repos/tschulte/awaitility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tschulte/awaitility/statuses/{sha}","languages_url":"https://api.github.com/repos/tschulte/awaitility/languages","stargazers_url":"https://api.github.com/repos/tschulte/awaitility/stargazers","contributors_url":"https://api.github.com/repos/tschulte/awaitility/contributors","subscribers_url":"https://api.github.com/repos/tschulte/awaitility/subscribers","subscription_url":"https://api.github.com/repos/tschulte/awaitility/subscription","commits_url":"https://api.github.com/repos/tschulte/awaitility/commits{/sha}","git_commits_url":"https://api.github.com/repos/tschulte/awaitility/git/commits{/sha}","comments_url":"https://api.github.com/repos/tschulte/awaitility/comments{/number}","issue_comment_url":"https://api.github.com/repos/tschulte/awaitility/issues/comments{/number}","contents_url":"https://api.github.com/repos/tschulte/awaitility/contents/{+path}","compare_url":"https://api.github.com/repos/tschulte/awaitility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tschulte/awaitility/merges","archive_url":"https://api.github.com/repos/tschulte/awaitility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tschulte/awaitility/downloads","issues_url":"https://api.github.com/repos/tschulte/awaitility/issues{/number}","pulls_url":"https://api.github.com/repos/tschulte/awaitility/pulls{/number}","milestones_url":"https://api.github.com/repos/tschulte/awaitility/milestones{/number}","notifications_url":"https://api.github.com/repos/tschulte/awaitility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tschulte/awaitility/labels{/name}","releases_url":"https://api.github.com/repos/tschulte/awaitility/releases{/id}","deployments_url":"https://api.github.com/repos/tschulte/awaitility/deployments","created_at":"2016-04-07T13:44:00Z","updated_at":"2016-04-07T13:44:01Z","pushed_at":"2016-04-07T20:49:35Z","git_url":"git://github.com/tschulte/awaitility.git","ssh_url":"git@github.com:tschulte/awaitility.git","clone_url":"https://github.com/tschulte/awaitility.git","svn_url":"https://github.com/tschulte/awaitility","homepage":"","size":717,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jayway:master","ref":"master","sha":"ba53766e285e237b0945aa5fbca824defa93cfe6","user":{"login":"jayway","id":89926,"avatar_url":"https://avatars.githubusercontent.com/u/89926?v=3","gravatar_id":"","url":"https://api.github.com/users/jayway","html_url":"https://github.com/jayway","followers_url":"https://api.github.com/users/jayway/followers","following_url":"https://api.github.com/users/jayway/following{/other_user}","gists_url":"https://api.github.com/users/jayway/gists{/gist_id}","starred_url":"https://api.github.com/users/jayway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayway/subscriptions","organizations_url":"https://api.github.com/users/jayway/orgs","repos_url":"https://api.github.com/users/jayway/repos","events_url":"https://api.github.com/users/jayway/events{/privacy}","received_events_url":"https://api.github.com/users/jayway/received_events","type":"Organization","site_admin":false},"repo":{"id":483924,"name":"awaitility","full_name":"jayway/awaitility","owner":{"login":"jayway","id":89926,"avatar_url":"https://avatars.githubusercontent.com/u/89926?v=3","gravatar_id":"","url":"https://api.github.com/users/jayway","html_url":"https://github.com/jayway","followers_url":"https://api.github.com/users/jayway/followers","following_url":"https://api.github.com/users/jayway/following{/other_user}","gists_url":"https://api.github.com/users/jayway/gists{/gist_id}","starred_url":"https://api.github.com/users/jayway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayway/subscriptions","organizations_url":"https://api.github.com/users/jayway/orgs","repos_url":"https://api.github.com/users/jayway/repos","events_url":"https://api.github.com/users/jayway/events{/privacy}","received_events_url":"https://api.github.com/users/jayway/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jayway/awaitility","description":"Awaitility is a small Java DSL for synchronizing asynchronous operations","fork":false,"url":"https://api.github.com/repos/jayway/awaitility","forks_url":"https://api.github.com/repos/jayway/awaitility/forks","keys_url":"https://api.github.com/repos/jayway/awaitility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayway/awaitility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayway/awaitility/teams","hooks_url":"https://api.github.com/repos/jayway/awaitility/hooks","issue_events_url":"https://api.github.com/repos/jayway/awaitility/issues/events{/number}","events_url":"https://api.github.com/repos/jayway/awaitility/events","assignees_url":"https://api.github.com/repos/jayway/awaitility/assignees{/user}","branches_url":"https://api.github.com/repos/jayway/awaitility/branches{/branch}","tags_url":"https://api.github.com/repos/jayway/awaitility/tags","blobs_url":"https://api.github.com/repos/jayway/awaitility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayway/awaitility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayway/awaitility/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayway/awaitility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayway/awaitility/statuses/{sha}","languages_url":"https://api.github.com/repos/jayway/awaitility/languages","stargazers_url":"https://api.github.com/repos/jayway/awaitility/stargazers","contributors_url":"https://api.github.com/repos/jayway/awaitility/contributors","subscribers_url":"https://api.github.com/repos/jayway/awaitility/subscribers","subscription_url":"https://api.github.com/repos/jayway/awaitility/subscription","commits_url":"https://api.github.com/repos/jayway/awaitility/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayway/awaitility/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayway/awaitility/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayway/awaitility/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayway/awaitility/contents/{+path}","compare_url":"https://api.github.com/repos/jayway/awaitility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayway/awaitility/merges","archive_url":"https://api.github.com/repos/jayway/awaitility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayway/awaitility/downloads","issues_url":"https://api.github.com/repos/jayway/awaitility/issues{/number}","pulls_url":"https://api.github.com/repos/jayway/awaitility/pulls{/number}","milestones_url":"https://api.github.com/repos/jayway/awaitility/milestones{/number}","notifications_url":"https://api.github.com/repos/jayway/awaitility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayway/awaitility/labels{/name}","releases_url":"https://api.github.com/repos/jayway/awaitility/releases{/id}","deployments_url":"https://api.github.com/repos/jayway/awaitility/deployments","created_at":"2010-01-22T15:12:52Z","updated_at":"2016-04-07T13:43:57Z","pushed_at":"2016-04-08T04:13:56Z","git_url":"git://github.com/jayway/awaitility.git","ssh_url":"git@github.com:jayway/awaitility.git","clone_url":"https://github.com/jayway/awaitility.git","svn_url":"https://github.com/jayway/awaitility","homepage":"","size":699,"stargazers_count":278,"watchers_count":278,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":7,"forks":35,"open_issues":7,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jayway/awaitility/pulls/46"},"html":{"href":"https://github.com/jayway/awaitility/pull/46"},"issue":{"href":"https://api.github.com/repos/jayway/awaitility/issues/46"},"comments":{"href":"https://api.github.com/repos/jayway/awaitility/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/jayway/awaitility/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/jayway/awaitility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jayway/awaitility/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/jayway/awaitility/statuses/dc438c35883b2bb082fe33b13a8a23a815e0e9fe"}}}}