{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/235","repository_url":"https://api.github.com/repos/vaadin/vaadin-date-picker","labels_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/235/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/235/events","html_url":"https://github.com/vaadin/vaadin-date-picker/pull/235","id":176609774,"number":235,"title":"Add selectable dates limitation feature","user":{"login":"samiheikki","id":8615573,"avatar_url":"https://avatars.githubusercontent.com/u/8615573?v=3","gravatar_id":"","url":"https://api.github.com/users/samiheikki","html_url":"https://github.com/samiheikki","followers_url":"https://api.github.com/users/samiheikki/followers","following_url":"https://api.github.com/users/samiheikki/following{/other_user}","gists_url":"https://api.github.com/users/samiheikki/gists{/gist_id}","starred_url":"https://api.github.com/users/samiheikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiheikki/subscriptions","organizations_url":"https://api.github.com/users/samiheikki/orgs","repos_url":"https://api.github.com/users/samiheikki/repos","events_url":"https://api.github.com/users/samiheikki/events{/privacy}","received_events_url":"https://api.github.com/users/samiheikki/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"tehapo","id":368220,"avatar_url":"https://avatars.githubusercontent.com/u/368220?v=3","gravatar_id":"","url":"https://api.github.com/users/tehapo","html_url":"https://github.com/tehapo","followers_url":"https://api.github.com/users/tehapo/followers","following_url":"https://api.github.com/users/tehapo/following{/other_user}","gists_url":"https://api.github.com/users/tehapo/gists{/gist_id}","starred_url":"https://api.github.com/users/tehapo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehapo/subscriptions","organizations_url":"https://api.github.com/users/tehapo/orgs","repos_url":"https://api.github.com/users/tehapo/repos","events_url":"https://api.github.com/users/tehapo/events{/privacy}","received_events_url":"https://api.github.com/users/tehapo/received_events","type":"User","site_admin":false},"assignees":[{"login":"tehapo","id":368220,"avatar_url":"https://avatars.githubusercontent.com/u/368220?v=3","gravatar_id":"","url":"https://api.github.com/users/tehapo","html_url":"https://github.com/tehapo","followers_url":"https://api.github.com/users/tehapo/followers","following_url":"https://api.github.com/users/tehapo/following{/other_user}","gists_url":"https://api.github.com/users/tehapo/gists{/gist_id}","starred_url":"https://api.github.com/users/tehapo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehapo/subscriptions","organizations_url":"https://api.github.com/users/tehapo/orgs","repos_url":"https://api.github.com/users/tehapo/repos","events_url":"https://api.github.com/users/tehapo/events{/privacy}","received_events_url":"https://api.github.com/users/tehapo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-09-13T10:54:47Z","updated_at":"2016-09-14T07:21:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/pulls/235","html_url":"https://github.com/vaadin/vaadin-date-picker/pull/235","diff_url":"https://github.com/vaadin/vaadin-date-picker/pull/235.diff","patch_url":"https://github.com/vaadin/vaadin-date-picker/pull/235.patch"},"body":"Fixes #197\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-date-picker/235)\n<!-- Reviewable:end -->"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/comments/246927747","html_url":"https://github.com/vaadin/vaadin-date-picker/pull/235#issuecomment-246927747","issue_url":"https://api.github.com/repos/vaadin/vaadin-date-picker/issues/235","id":246927747,"user":{"login":"tehapo","id":368220,"avatar_url":"https://avatars.githubusercontent.com/u/368220?v=3","gravatar_id":"","url":"https://api.github.com/users/tehapo","html_url":"https://github.com/tehapo","followers_url":"https://api.github.com/users/tehapo/followers","following_url":"https://api.github.com/users/tehapo/following{/other_user}","gists_url":"https://api.github.com/users/tehapo/gists{/gist_id}","starred_url":"https://api.github.com/users/tehapo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehapo/subscriptions","organizations_url":"https://api.github.com/users/tehapo/orgs","repos_url":"https://api.github.com/users/tehapo/repos","events_url":"https://api.github.com/users/tehapo/events{/privacy}","received_events_url":"https://api.github.com/users/tehapo/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T07:21:31Z","updated_at":"2016-09-14T07:21:31Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[vaadin-date-picker-behavior.html, line 451 at r2](https://reviewable.io:443/reviews/vaadin/vaadin-date-picker/235#-KRbXrO-waE6uFLlpUOB:-KRbZG2dQSs10SDbwz09:bz6c886) ([raw file](https://github.com/vaadin/vaadin-date-picker/blob/826a4e43b960b31cd54ad0e2728b1021fd24383c/vaadin-date-picker-behavior.html#L451)):*\n<details><summary><i>Previously, tomivirkki (Tomi Virkki) wrote…</i></summary>\n> Similar checks occur in multiple (3) locations. It might be justifiable to have the `_dateAllowed` method in all layers separately but in that case I'd rather minimize the code repetition to a one-liner:\n> `return (!min || date >= min) && (!max || date <= max);`\n</details>\n:+1:\nGood point @tomivirkki. I'll take my <img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> back. :laughing: \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/vaadin-date-picker/235)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tehapo"}}