{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/janjiss/rom_factory/pulls/1","id":85680922,"html_url":"https://github.com/janjiss/rom_factory/pull/1","diff_url":"https://github.com/janjiss/rom_factory/pull/1.diff","patch_url":"https://github.com/janjiss/rom_factory/pull/1.patch","issue_url":"https://api.github.com/repos/janjiss/rom_factory/issues/1","number":1,"state":"open","locked":false,"title":"Rename _name to name","user":{"login":"wilsonsilva","id":645203,"avatar_url":"https://avatars.githubusercontent.com/u/645203?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonsilva","html_url":"https://github.com/wilsonsilva","followers_url":"https://api.github.com/users/wilsonsilva/followers","following_url":"https://api.github.com/users/wilsonsilva/following{/other_user}","gists_url":"https://api.github.com/users/wilsonsilva/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonsilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonsilva/subscriptions","organizations_url":"https://api.github.com/users/wilsonsilva/orgs","repos_url":"https://api.github.com/users/wilsonsilva/repos","events_url":"https://api.github.com/users/wilsonsilva/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonsilva/received_events","type":"User","site_admin":false},"body":"I'm in the proccess of replacing ActiveRecord with ROM in my [grape-embryo](https://github.com/wilsonsilva/grape-embryo) repo. That project has table named `people`, with a column called `name`.\r\n\r\nSetting up a factory using RomFactory fails in this scenario because `RomFactory::Builder` has its own `name` attribute. That `name` is replaced when `define_methods_from_relation` is executed.\r\n\r\n```\r\n  1) Embryo::Operations::People::DeletePerson#call when the person exists deletes a person\r\n     Failure/Error: let!(:person) { RomFactory::Builder.create(:person) }\r\n     \r\n     ArgumentError:\r\n       Factory person does not exist\r\n     # ./spec/embryo/operations/people/delete_person_spec.rb:10:in `block (4 levels) in <top (required)>'\r\n     # ./spec/spec_helper.rb:39:in `block (3 levels) in <top (required)>'\r\n     # ./spec/spec_helper.rb:38:in `block (2 levels) in <top (required)>'\r\n```\r\n\r\nI renamed `name` to `_name` to avoid these collisions.","created_at":"2016-09-17T17:35:45Z","updated_at":"2016-09-17T17:35:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dea9e9fee695179fac5118554a4383ea48d46c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/janjiss/rom_factory/pulls/1/commits","review_comments_url":"https://api.github.com/repos/janjiss/rom_factory/pulls/1/comments","review_comment_url":"https://api.github.com/repos/janjiss/rom_factory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/janjiss/rom_factory/issues/1/comments","statuses_url":"https://api.github.com/repos/janjiss/rom_factory/statuses/78dde198b440b9c85a3a367a8844edb0063d438b","head":{"label":"wilsonsilva:add-compatibility-with-name-attr","ref":"add-compatibility-with-name-attr","sha":"78dde198b440b9c85a3a367a8844edb0063d438b","user":{"login":"wilsonsilva","id":645203,"avatar_url":"https://avatars.githubusercontent.com/u/645203?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonsilva","html_url":"https://github.com/wilsonsilva","followers_url":"https://api.github.com/users/wilsonsilva/followers","following_url":"https://api.github.com/users/wilsonsilva/following{/other_user}","gists_url":"https://api.github.com/users/wilsonsilva/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonsilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonsilva/subscriptions","organizations_url":"https://api.github.com/users/wilsonsilva/orgs","repos_url":"https://api.github.com/users/wilsonsilva/repos","events_url":"https://api.github.com/users/wilsonsilva/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonsilva/received_events","type":"User","site_admin":false},"repo":{"id":68465891,"name":"rom_factory","full_name":"wilsonsilva/rom_factory","owner":{"login":"wilsonsilva","id":645203,"avatar_url":"https://avatars.githubusercontent.com/u/645203?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonsilva","html_url":"https://github.com/wilsonsilva","followers_url":"https://api.github.com/users/wilsonsilva/followers","following_url":"https://api.github.com/users/wilsonsilva/following{/other_user}","gists_url":"https://api.github.com/users/wilsonsilva/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonsilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonsilva/subscriptions","organizations_url":"https://api.github.com/users/wilsonsilva/orgs","repos_url":"https://api.github.com/users/wilsonsilva/repos","events_url":"https://api.github.com/users/wilsonsilva/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonsilva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilsonsilva/rom_factory","description":null,"fork":true,"url":"https://api.github.com/repos/wilsonsilva/rom_factory","forks_url":"https://api.github.com/repos/wilsonsilva/rom_factory/forks","keys_url":"https://api.github.com/repos/wilsonsilva/rom_factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilsonsilva/rom_factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilsonsilva/rom_factory/teams","hooks_url":"https://api.github.com/repos/wilsonsilva/rom_factory/hooks","issue_events_url":"https://api.github.com/repos/wilsonsilva/rom_factory/issues/events{/number}","events_url":"https://api.github.com/repos/wilsonsilva/rom_factory/events","assignees_url":"https://api.github.com/repos/wilsonsilva/rom_factory/assignees{/user}","branches_url":"https://api.github.com/repos/wilsonsilva/rom_factory/branches{/branch}","tags_url":"https://api.github.com/repos/wilsonsilva/rom_factory/tags","blobs_url":"https://api.github.com/repos/wilsonsilva/rom_factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilsonsilva/rom_factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilsonsilva/rom_factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilsonsilva/rom_factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilsonsilva/rom_factory/statuses/{sha}","languages_url":"https://api.github.com/repos/wilsonsilva/rom_factory/languages","stargazers_url":"https://api.github.com/repos/wilsonsilva/rom_factory/stargazers","contributors_url":"https://api.github.com/repos/wilsonsilva/rom_factory/contributors","subscribers_url":"https://api.github.com/repos/wilsonsilva/rom_factory/subscribers","subscription_url":"https://api.github.com/repos/wilsonsilva/rom_factory/subscription","commits_url":"https://api.github.com/repos/wilsonsilva/rom_factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilsonsilva/rom_factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilsonsilva/rom_factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilsonsilva/rom_factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilsonsilva/rom_factory/contents/{+path}","compare_url":"https://api.github.com/repos/wilsonsilva/rom_factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilsonsilva/rom_factory/merges","archive_url":"https://api.github.com/repos/wilsonsilva/rom_factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilsonsilva/rom_factory/downloads","issues_url":"https://api.github.com/repos/wilsonsilva/rom_factory/issues{/number}","pulls_url":"https://api.github.com/repos/wilsonsilva/rom_factory/pulls{/number}","milestones_url":"https://api.github.com/repos/wilsonsilva/rom_factory/milestones{/number}","notifications_url":"https://api.github.com/repos/wilsonsilva/rom_factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilsonsilva/rom_factory/labels{/name}","releases_url":"https://api.github.com/repos/wilsonsilva/rom_factory/releases{/id}","deployments_url":"https://api.github.com/repos/wilsonsilva/rom_factory/deployments","created_at":"2016-09-17T17:04:29Z","updated_at":"2016-09-17T17:04:30Z","pushed_at":"2016-09-17T17:24:29Z","git_url":"git://github.com/wilsonsilva/rom_factory.git","ssh_url":"git@github.com:wilsonsilva/rom_factory.git","clone_url":"https://github.com/wilsonsilva/rom_factory.git","svn_url":"https://github.com/wilsonsilva/rom_factory","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"janjiss:master","ref":"master","sha":"7840b1edd394bd008b7d0f7baa25aaee6ce30964","user":{"login":"janjiss","id":600203,"avatar_url":"https://avatars.githubusercontent.com/u/600203?v=3","gravatar_id":"","url":"https://api.github.com/users/janjiss","html_url":"https://github.com/janjiss","followers_url":"https://api.github.com/users/janjiss/followers","following_url":"https://api.github.com/users/janjiss/following{/other_user}","gists_url":"https://api.github.com/users/janjiss/gists{/gist_id}","starred_url":"https://api.github.com/users/janjiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janjiss/subscriptions","organizations_url":"https://api.github.com/users/janjiss/orgs","repos_url":"https://api.github.com/users/janjiss/repos","events_url":"https://api.github.com/users/janjiss/events{/privacy}","received_events_url":"https://api.github.com/users/janjiss/received_events","type":"User","site_admin":false},"repo":{"id":66728008,"name":"rom_factory","full_name":"janjiss/rom_factory","owner":{"login":"janjiss","id":600203,"avatar_url":"https://avatars.githubusercontent.com/u/600203?v=3","gravatar_id":"","url":"https://api.github.com/users/janjiss","html_url":"https://github.com/janjiss","followers_url":"https://api.github.com/users/janjiss/followers","following_url":"https://api.github.com/users/janjiss/following{/other_user}","gists_url":"https://api.github.com/users/janjiss/gists{/gist_id}","starred_url":"https://api.github.com/users/janjiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janjiss/subscriptions","organizations_url":"https://api.github.com/users/janjiss/orgs","repos_url":"https://api.github.com/users/janjiss/repos","events_url":"https://api.github.com/users/janjiss/events{/privacy}","received_events_url":"https://api.github.com/users/janjiss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janjiss/rom_factory","description":null,"fork":false,"url":"https://api.github.com/repos/janjiss/rom_factory","forks_url":"https://api.github.com/repos/janjiss/rom_factory/forks","keys_url":"https://api.github.com/repos/janjiss/rom_factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janjiss/rom_factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janjiss/rom_factory/teams","hooks_url":"https://api.github.com/repos/janjiss/rom_factory/hooks","issue_events_url":"https://api.github.com/repos/janjiss/rom_factory/issues/events{/number}","events_url":"https://api.github.com/repos/janjiss/rom_factory/events","assignees_url":"https://api.github.com/repos/janjiss/rom_factory/assignees{/user}","branches_url":"https://api.github.com/repos/janjiss/rom_factory/branches{/branch}","tags_url":"https://api.github.com/repos/janjiss/rom_factory/tags","blobs_url":"https://api.github.com/repos/janjiss/rom_factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janjiss/rom_factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janjiss/rom_factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/janjiss/rom_factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janjiss/rom_factory/statuses/{sha}","languages_url":"https://api.github.com/repos/janjiss/rom_factory/languages","stargazers_url":"https://api.github.com/repos/janjiss/rom_factory/stargazers","contributors_url":"https://api.github.com/repos/janjiss/rom_factory/contributors","subscribers_url":"https://api.github.com/repos/janjiss/rom_factory/subscribers","subscription_url":"https://api.github.com/repos/janjiss/rom_factory/subscription","commits_url":"https://api.github.com/repos/janjiss/rom_factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/janjiss/rom_factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/janjiss/rom_factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/janjiss/rom_factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/janjiss/rom_factory/contents/{+path}","compare_url":"https://api.github.com/repos/janjiss/rom_factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janjiss/rom_factory/merges","archive_url":"https://api.github.com/repos/janjiss/rom_factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janjiss/rom_factory/downloads","issues_url":"https://api.github.com/repos/janjiss/rom_factory/issues{/number}","pulls_url":"https://api.github.com/repos/janjiss/rom_factory/pulls{/number}","milestones_url":"https://api.github.com/repos/janjiss/rom_factory/milestones{/number}","notifications_url":"https://api.github.com/repos/janjiss/rom_factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janjiss/rom_factory/labels{/name}","releases_url":"https://api.github.com/repos/janjiss/rom_factory/releases{/id}","deployments_url":"https://api.github.com/repos/janjiss/rom_factory/deployments","created_at":"2016-08-27T17:51:41Z","updated_at":"2016-08-29T12:26:06Z","pushed_at":"2016-09-17T17:35:46Z","git_url":"git://github.com/janjiss/rom_factory.git","ssh_url":"git@github.com:janjiss/rom_factory.git","clone_url":"https://github.com/janjiss/rom_factory.git","svn_url":"https://github.com/janjiss/rom_factory","homepage":null,"size":34,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/janjiss/rom_factory/pulls/1"},"html":{"href":"https://github.com/janjiss/rom_factory/pull/1"},"issue":{"href":"https://api.github.com/repos/janjiss/rom_factory/issues/1"},"comments":{"href":"https://api.github.com/repos/janjiss/rom_factory/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/janjiss/rom_factory/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/janjiss/rom_factory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/janjiss/rom_factory/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/janjiss/rom_factory/statuses/78dde198b440b9c85a3a367a8844edb0063d438b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"wilsonsilva"}}