{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/67828310","id":67828310,"diff_hunk":"@@ -6,7 +6,9 @@ override BUILDDIR := $(abspath $(BUILDDIR))\n \n STAMPSDIR := $(BUILDDIR)/stamps\n TOOLSDIR := $(BUILDDIR)/tools\n-BINDIR := $(BUILDDIR)/bin\n+TARGETDIR := $(BUILDDIR)/target","path":"makelib/variables.mk","position":null,"original_position":5,"commit_id":"6924dd783e498eed2d00daa5507cafbba84e63ee","original_commit_id":"41aa1656f4b53e384702ee40f628b62747a80162","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"I was wondering if the target directory can contain an arch in its name, something like `$(BUILDDIR)/target-$(RKT_ACI_ARCH)` or `$(BUILDDIR)/target-$(GOARCH)`.","created_at":"2016-06-21T08:37:55Z","updated_at":"2016-06-21T08:37:56Z","html_url":"https://github.com/coreos/rkt/pull/2758#discussion_r67828310","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2758","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/67828310"},"html":{"href":"https://github.com/coreos/rkt/pull/2758#discussion_r67828310"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2758"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2758","id":72938788,"html_url":"https://github.com/coreos/rkt/pull/2758","diff_url":"https://github.com/coreos/rkt/pull/2758.diff","patch_url":"https://github.com/coreos/rkt/pull/2758.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2758","number":2758,"state":"open","locked":false,"title":"Add ARM64 support","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"body":"This series adds arm64 support to rkt.  It also includes some minor build enhancements.  I can split the series into multiple PRs if it would make review easier.\r\n\r\nI tested cross building stage1 flavors 'coreos' and 'fly'.  The rkt binary and ACI images generated can run successfully on CoreOS running on qemu-system-aarch64.\r\n\r\nOn my system (ubuntu 15.10), cross building stage1 flavor 'kvm' failed: ```configure: error: ** No development headers for openssl found```.  I'll look into getting and environment with the needed cross build dependencies.\r\n\r\nThis PR includes the gimme script submitted upstream at https://github.com/travis-ci/gimme/pull/45. If that is merged we can remove the gimme.local here.\r\n\r\ncc: @crawford ","created_at":"2016-06-07T20:03:23Z","updated_at":"2016-06-21T08:37:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce4353e28b22dc4c5fe9334ffe12aa946c453583","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/41","html_url":"https://github.com/coreos/rkt/milestones/v1.9.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/41/labels","id":1782386,"number":41,"title":"v1.9.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":29,"state":"open","created_at":"2016-05-23T10:26:08Z","updated_at":"2016-06-21T08:10:50Z","due_on":"2016-06-22T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2758/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2758/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2758/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/6924dd783e498eed2d00daa5507cafbba84e63ee","head":{"label":"glevand:for-merge-arm64-support","ref":"for-merge-arm64-support","sha":"6924dd783e498eed2d00daa5507cafbba84e63ee","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"repo":{"id":35896173,"name":"coreos--rkt","full_name":"glevand/coreos--rkt","owner":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glevand/coreos--rkt","description":"CoreOS arm64 port","fork":true,"url":"https://api.github.com/repos/glevand/coreos--rkt","forks_url":"https://api.github.com/repos/glevand/coreos--rkt/forks","keys_url":"https://api.github.com/repos/glevand/coreos--rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glevand/coreos--rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glevand/coreos--rkt/teams","hooks_url":"https://api.github.com/repos/glevand/coreos--rkt/hooks","issue_events_url":"https://api.github.com/repos/glevand/coreos--rkt/issues/events{/number}","events_url":"https://api.github.com/repos/glevand/coreos--rkt/events","assignees_url":"https://api.github.com/repos/glevand/coreos--rkt/assignees{/user}","branches_url":"https://api.github.com/repos/glevand/coreos--rkt/branches{/branch}","tags_url":"https://api.github.com/repos/glevand/coreos--rkt/tags","blobs_url":"https://api.github.com/repos/glevand/coreos--rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glevand/coreos--rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glevand/coreos--rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/glevand/coreos--rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glevand/coreos--rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/glevand/coreos--rkt/languages","stargazers_url":"https://api.github.com/repos/glevand/coreos--rkt/stargazers","contributors_url":"https://api.github.com/repos/glevand/coreos--rkt/contributors","subscribers_url":"https://api.github.com/repos/glevand/coreos--rkt/subscribers","subscription_url":"https://api.github.com/repos/glevand/coreos--rkt/subscription","commits_url":"https://api.github.com/repos/glevand/coreos--rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/glevand/coreos--rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/glevand/coreos--rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/glevand/coreos--rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/glevand/coreos--rkt/contents/{+path}","compare_url":"https://api.github.com/repos/glevand/coreos--rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glevand/coreos--rkt/merges","archive_url":"https://api.github.com/repos/glevand/coreos--rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glevand/coreos--rkt/downloads","issues_url":"https://api.github.com/repos/glevand/coreos--rkt/issues{/number}","pulls_url":"https://api.github.com/repos/glevand/coreos--rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/glevand/coreos--rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/glevand/coreos--rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glevand/coreos--rkt/labels{/name}","releases_url":"https://api.github.com/repos/glevand/coreos--rkt/releases{/id}","deployments_url":"https://api.github.com/repos/glevand/coreos--rkt/deployments","created_at":"2015-05-19T17:00:26Z","updated_at":"2016-02-26T02:19:24Z","pushed_at":"2016-06-20T19:20:17Z","git_url":"git://github.com/glevand/coreos--rkt.git","ssh_url":"git@github.com:glevand/coreos--rkt.git","clone_url":"https://github.com/glevand/coreos--rkt.git","svn_url":"https://github.com/glevand/coreos--rkt","homepage":"","size":21782,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"a6a0240dfe941e3d2d31e49210c74f3a30a55850","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-06-21T04:57:25Z","pushed_at":"2016-06-21T08:18:42Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":28308,"stargazers_count":5620,"watchers_count":5620,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":529,"mirror_url":null,"open_issues_count":339,"forks":529,"open_issues":339,"watchers":5620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2758"},"html":{"href":"https://github.com/coreos/rkt/pull/2758"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2758"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2758/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2758/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2758/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/6924dd783e498eed2d00daa5507cafbba84e63ee"}}}}
{"actor":{"display_login":"krnowak"}}