{"action":"closed","number":3976,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3976","id":58572585,"html_url":"https://github.com/D-Programming-Language/phobos/pull/3976","diff_url":"https://github.com/D-Programming-Language/phobos/pull/3976.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/3976.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3976","number":3976,"state":"closed","locked":false,"title":"Fix NaN payload unittest in errorfunction","user":{"login":"smolt","id":919827,"avatar_url":"https://avatars.githubusercontent.com/u/919827?v=3","gravatar_id":"","url":"https://api.github.com/users/smolt","html_url":"https://github.com/smolt","followers_url":"https://api.github.com/users/smolt/followers","following_url":"https://api.github.com/users/smolt/following{/other_user}","gists_url":"https://api.github.com/users/smolt/gists{/gist_id}","starred_url":"https://api.github.com/users/smolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolt/subscriptions","organizations_url":"https://api.github.com/users/smolt/orgs","repos_url":"https://api.github.com/users/smolt/repos","events_url":"https://api.github.com/users/smolt/events{/privacy}","received_events_url":"https://api.github.com/users/smolt/received_events","type":"User","site_admin":false},"body":"This is a mod that allows std.internal.math.errorfunction unittest to pass on several other platforms.\r\nFor some platforms, math on a NaN may change the sign.  Replaced with test that ignores signbit for NaN.\r\n\r\nIs this the appropriate?  We are discussing it here: ldc-developers/phobos#25.","created_at":"2016-02-08T05:37:44Z","updated_at":"2016-03-24T09:07:01Z","closed_at":"2016-03-24T09:07:01Z","merged_at":"2016-03-24T09:07:01Z","merge_commit_sha":"708c5d8e6ddd9245f793e4b8761382672225f271","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3976/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3976/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3976/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/b938a746281a862a69eebb8e22374393d0bb77e4","head":{"label":"smolt:erf-nan-payload-unittest","ref":"erf-nan-payload-unittest","sha":"b938a746281a862a69eebb8e22374393d0bb77e4","user":{"login":"smolt","id":919827,"avatar_url":"https://avatars.githubusercontent.com/u/919827?v=3","gravatar_id":"","url":"https://api.github.com/users/smolt","html_url":"https://github.com/smolt","followers_url":"https://api.github.com/users/smolt/followers","following_url":"https://api.github.com/users/smolt/following{/other_user}","gists_url":"https://api.github.com/users/smolt/gists{/gist_id}","starred_url":"https://api.github.com/users/smolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolt/subscriptions","organizations_url":"https://api.github.com/users/smolt/orgs","repos_url":"https://api.github.com/users/smolt/repos","events_url":"https://api.github.com/users/smolt/events{/privacy}","received_events_url":"https://api.github.com/users/smolt/received_events","type":"User","site_admin":false},"repo":{"id":18126939,"name":"phobos","full_name":"smolt/phobos","owner":{"login":"smolt","id":919827,"avatar_url":"https://avatars.githubusercontent.com/u/919827?v=3","gravatar_id":"","url":"https://api.github.com/users/smolt","html_url":"https://github.com/smolt","followers_url":"https://api.github.com/users/smolt/followers","following_url":"https://api.github.com/users/smolt/following{/other_user}","gists_url":"https://api.github.com/users/smolt/gists{/gist_id}","starred_url":"https://api.github.com/users/smolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smolt/subscriptions","organizations_url":"https://api.github.com/users/smolt/orgs","repos_url":"https://api.github.com/users/smolt/repos","events_url":"https://api.github.com/users/smolt/events{/privacy}","received_events_url":"https://api.github.com/users/smolt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smolt/phobos","description":"LDC-specific changes to the D standard library.","fork":true,"url":"https://api.github.com/repos/smolt/phobos","forks_url":"https://api.github.com/repos/smolt/phobos/forks","keys_url":"https://api.github.com/repos/smolt/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smolt/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smolt/phobos/teams","hooks_url":"https://api.github.com/repos/smolt/phobos/hooks","issue_events_url":"https://api.github.com/repos/smolt/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/smolt/phobos/events","assignees_url":"https://api.github.com/repos/smolt/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/smolt/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/smolt/phobos/tags","blobs_url":"https://api.github.com/repos/smolt/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smolt/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smolt/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/smolt/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smolt/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/smolt/phobos/languages","stargazers_url":"https://api.github.com/repos/smolt/phobos/stargazers","contributors_url":"https://api.github.com/repos/smolt/phobos/contributors","subscribers_url":"https://api.github.com/repos/smolt/phobos/subscribers","subscription_url":"https://api.github.com/repos/smolt/phobos/subscription","commits_url":"https://api.github.com/repos/smolt/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/smolt/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/smolt/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/smolt/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/smolt/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/smolt/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smolt/phobos/merges","archive_url":"https://api.github.com/repos/smolt/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smolt/phobos/downloads","issues_url":"https://api.github.com/repos/smolt/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/smolt/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/smolt/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/smolt/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smolt/phobos/labels{/name}","releases_url":"https://api.github.com/repos/smolt/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/smolt/phobos/deployments","created_at":"2014-03-26T04:35:21Z","updated_at":"2015-02-11T03:15:37Z","pushed_at":"2016-03-19T23:28:28Z","git_url":"git://github.com/smolt/phobos.git","ssh_url":"git@github.com:smolt/phobos.git","clone_url":"https://github.com/smolt/phobos.git","svn_url":"https://github.com/smolt/phobos","homepage":"","size":51782,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ios"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"f63523b1a8ab9e7988953b89ed1463f88a865428","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/D-Programming-Language/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-03-23T23:31:45Z","pushed_at":"2016-03-24T09:07:01Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":70146,"stargazers_count":689,"watchers_count":689,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":467,"mirror_url":null,"open_issues_count":100,"forks":467,"open_issues":100,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3976"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/3976"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3976"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3976/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3976/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3976/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/b938a746281a862a69eebb8e22374393d0bb77e4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"comments":19,"review_comments":1,"commits":2,"additions":7,"deletions":3,"changed_files":2}}