{"action":"created","issue":{"url":"https://api.github.com/repos/nhoffman/bioy/issues/56","repository_url":"https://api.github.com/repos/nhoffman/bioy","labels_url":"https://api.github.com/repos/nhoffman/bioy/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/nhoffman/bioy/issues/56/comments","events_url":"https://api.github.com/repos/nhoffman/bioy/issues/56/events","html_url":"https://github.com/nhoffman/bioy/pull/56","id":143011130,"number":56,"title":"054 ref rank","user":{"login":"tyleraland","id":1838500,"avatar_url":"https://avatars.githubusercontent.com/u/1838500?v=3","gravatar_id":"","url":"https://api.github.com/users/tyleraland","html_url":"https://github.com/tyleraland","followers_url":"https://api.github.com/users/tyleraland/followers","following_url":"https://api.github.com/users/tyleraland/following{/other_user}","gists_url":"https://api.github.com/users/tyleraland/gists{/gist_id}","starred_url":"https://api.github.com/users/tyleraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyleraland/subscriptions","organizations_url":"https://api.github.com/users/tyleraland/orgs","repos_url":"https://api.github.com/users/tyleraland/repos","events_url":"https://api.github.com/users/tyleraland/events{/privacy}","received_events_url":"https://api.github.com/users/tyleraland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-23T16:31:53Z","updated_at":"2016-03-24T20:31:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nhoffman/bioy/pulls/56","html_url":"https://github.com/nhoffman/bioy/pull/56","diff_url":"https://github.com/nhoffman/bioy/pull/56.diff","patch_url":"https://github.com/nhoffman/bioy/pull/56.patch"},"body":"\"include-ref-rank\" argument, pulls in rank-level taxonomic ID and name from taxonomy and includes it in every details row.\r\n\r\nCan be used like:\r\n`\r\n--include-ref-rank species --include-ref-rank species_group --include-ref-rank genus\r\n`\r\nto include information from multiple ranks\r\n\r\nTODO: Tests?"},"comment":{"url":"https://api.github.com/repos/nhoffman/bioy/issues/comments/201006178","html_url":"https://github.com/nhoffman/bioy/pull/56#issuecomment-201006178","issue_url":"https://api.github.com/repos/nhoffman/bioy/issues/56","id":201006178,"user":{"login":"tyleraland","id":1838500,"avatar_url":"https://avatars.githubusercontent.com/u/1838500?v=3","gravatar_id":"","url":"https://api.github.com/users/tyleraland","html_url":"https://github.com/tyleraland","followers_url":"https://api.github.com/users/tyleraland/followers","following_url":"https://api.github.com/users/tyleraland/following{/other_user}","gists_url":"https://api.github.com/users/tyleraland/gists{/gist_id}","starred_url":"https://api.github.com/users/tyleraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyleraland/subscriptions","organizations_url":"https://api.github.com/users/tyleraland/orgs","repos_url":"https://api.github.com/users/tyleraland/repos","events_url":"https://api.github.com/users/tyleraland/events{/privacy}","received_events_url":"https://api.github.com/users/tyleraland/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T20:31:42Z","updated_at":"2016-03-24T20:31:42Z","body":"I'm not really sure what's worth testing.\r\n\r\nI could test for the obvious, that if I pass in \"--include-ref-rank $RANK\" that \"$RANK_id,$RANK_name\" are in the output file (for one or two particular ranks), but this doesn't seem particularly useful to me.\r\n\r\nI could test for failure -- If I ask for \"--include-ref-rank unknown\", then it will expectedly fail.  Alternatively, I could write it so that it fails gracefully and then test for that, although I think it makes more sense to fail noisily if the desired rank is not in the taxonomy.\r\n\r\nUnless one feels stongly that one of these tests should be implemented, I think merging it without writing tests is most appropriate, given our usual development style."}}