{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/rkt/issues/2889","repository_url":"https://api.github.com/repos/coreos/rkt","labels_url":"https://api.github.com/repos/coreos/rkt/issues/2889/labels{/name}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2889/comments","events_url":"https://api.github.com/repos/coreos/rkt/issues/2889/events","html_url":"https://github.com/coreos/rkt/pull/2889","id":164527527,"number":2889,"title":"rkt: add command to export a pod to an aci","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/coreos/rkt/labels/area/usability","name":"area/usability","color":"bfe5bf"},{"url":"https://api.github.com/repos/coreos/rkt/labels/component/stage0","name":"component/stage0","color":"0052cc"},{"url":"https://api.github.com/repos/coreos/rkt/labels/component/store","name":"component/store","color":"0052cc"},{"url":"https://api.github.com/repos/coreos/rkt/labels/kind/design","name":"kind/design","color":"c7def8"},{"url":"https://api.github.com/repos/coreos/rkt/labels/kind/enhancement","name":"kind/enhancement","color":"c7def8"},{"url":"https://api.github.com/repos/coreos/rkt/labels/needs/review","name":"needs/review","color":"fef2c0"},{"url":"https://api.github.com/repos/coreos/rkt/labels/priority/P2","name":"priority/P2","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/43","html_url":"https://github.com/coreos/rkt/milestones/v1.11.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/43/labels","id":1815915,"number":43,"title":"v1.11.0","description":"","creator":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":5,"state":"open","created_at":"2016-06-08T15:21:51Z","updated_at":"2016-07-11T20:20:07Z","due_on":"2016-07-20T22:00:00Z","closed_at":null},"comments":5,"created_at":"2016-07-08T13:11:00Z","updated_at":"2016-07-12T02:50:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2889","html_url":"https://github.com/coreos/rkt/pull/2889","diff_url":"https://github.com/coreos/rkt/pull/2889.diff","patch_url":"https://github.com/coreos/rkt/pull/2889.patch"},"body":"Adds a new `export` command to rkt which generates an aci from a\r\npod; saving any changes made to the pod.\r\n\r\nUsage is `rkt export POD_UUID my.aci`\r\n\r\nThis is currently restricted to only working with exited pods with a\r\nsingle app.\r\n\r\nFixes #1197"},"comment":{"url":"https://api.github.com/repos/coreos/rkt/issues/comments/231923782","html_url":"https://github.com/coreos/rkt/pull/2889#issuecomment-231923782","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2889","id":231923782,"user":{"login":"tjdett","id":437845,"avatar_url":"https://avatars.githubusercontent.com/u/437845?v=3","gravatar_id":"","url":"https://api.github.com/users/tjdett","html_url":"https://github.com/tjdett","followers_url":"https://api.github.com/users/tjdett/followers","following_url":"https://api.github.com/users/tjdett/following{/other_user}","gists_url":"https://api.github.com/users/tjdett/gists{/gist_id}","starred_url":"https://api.github.com/users/tjdett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjdett/subscriptions","organizations_url":"https://api.github.com/users/tjdett/orgs","repos_url":"https://api.github.com/users/tjdett/repos","events_url":"https://api.github.com/users/tjdett/events{/privacy}","received_events_url":"https://api.github.com/users/tjdett/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T02:50:10Z","updated_at":"2016-07-12T02:50:10Z","body":"I think capturing files masked by mounts is the definitely the correct behaviour.\r\n\r\nReal example: mounting `/var/log` as a volume. Say you have `/var/log/nginx` in the rootfs, then following coreos/rkt#2315 it should be copied to the new empty volume. This allows shared data volumes  to be pre-populated.\r\n\r\nIn a `rkt run` → `rkt export` → `rkt run` sequence, an app that takes advantage of this behaviour would break when running the exported image unless the masked files are captured.\r\n\r\nMore abstractly, if you're using `rkt export` in the ways mentioned in #1197 then you're essentially using `rkt run` to apply a _`Image → Image`_ operation against an existing _`Image`_. If that operation doesn't touch a specific part of the rootfs, then the expected behaviour would be for it to still be there in the resulting rootfs."}}
{"actor":{"display_login":"tjdett"}}