{"action":"created","issue":{"url":"https://api.github.com/repos/ethz-asl/libpointmatcher/issues/150","repository_url":"https://api.github.com/repos/ethz-asl/libpointmatcher","labels_url":"https://api.github.com/repos/ethz-asl/libpointmatcher/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/ethz-asl/libpointmatcher/issues/150/comments","events_url":"https://api.github.com/repos/ethz-asl/libpointmatcher/issues/150/events","html_url":"https://github.com/ethz-asl/libpointmatcher/pull/150","id":141647520,"number":150,"title":"Minor fixes","user":{"login":"oleg-alexandrov","id":1325676,"avatar_url":"https://avatars.githubusercontent.com/u/1325676?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-alexandrov","html_url":"https://github.com/oleg-alexandrov","followers_url":"https://api.github.com/users/oleg-alexandrov/followers","following_url":"https://api.github.com/users/oleg-alexandrov/following{/other_user}","gists_url":"https://api.github.com/users/oleg-alexandrov/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-alexandrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-alexandrov/subscriptions","organizations_url":"https://api.github.com/users/oleg-alexandrov/orgs","repos_url":"https://api.github.com/users/oleg-alexandrov/repos","events_url":"https://api.github.com/users/oleg-alexandrov/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-alexandrov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-17T17:15:14Z","updated_at":"2016-03-17T18:05:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethz-asl/libpointmatcher/pulls/150","html_url":"https://github.com/ethz-asl/libpointmatcher/pull/150","diff_url":"https://github.com/ethz-asl/libpointmatcher/pull/150.diff","patch_url":"https://github.com/ethz-asl/libpointmatcher/pull/150.patch"},"body":"I clarified the similarity transform, per Francois. And I found what I think is a bug. A typo prevented an input variable from being passed to a class, instead, the class member was assigned to itself. The compiler was complaining. "},"comment":{"url":"https://api.github.com/repos/ethz-asl/libpointmatcher/issues/comments/198007041","html_url":"https://github.com/ethz-asl/libpointmatcher/pull/150#issuecomment-198007041","issue_url":"https://api.github.com/repos/ethz-asl/libpointmatcher/issues/150","id":198007041,"user":{"login":"pomerlef","id":502089,"avatar_url":"https://avatars.githubusercontent.com/u/502089?v=3","gravatar_id":"","url":"https://api.github.com/users/pomerlef","html_url":"https://github.com/pomerlef","followers_url":"https://api.github.com/users/pomerlef/followers","following_url":"https://api.github.com/users/pomerlef/following{/other_user}","gists_url":"https://api.github.com/users/pomerlef/gists{/gist_id}","starred_url":"https://api.github.com/users/pomerlef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomerlef/subscriptions","organizations_url":"https://api.github.com/users/pomerlef/orgs","repos_url":"https://api.github.com/users/pomerlef/repos","events_url":"https://api.github.com/users/pomerlef/events{/privacy}","received_events_url":"https://api.github.com/users/pomerlef/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T18:05:51Z","updated_at":"2016-03-17T18:05:51Z","body":"Strange, that part of the code is very old, but there was clearly a typo there. The message is not clear as whether the patch fix or not the problem. Do I need to investigate this?\r\n\r\nAs for the convention for using the same input and class member, I agree that it can be confusing. In theory, we use that mainly when the constructor just copies the inputs to the member as they are the same concept and discarded right away. I know that some conventions use a suffix to make to tag members like `m_variableName`, but I find that heavy. If there is a doubt in the function call, I tend to use `this->variableName`. I'm not sure if some conventions tag input variable instead."}}