{"action":"created","issue":{"url":"https://api.github.com/repos/TheCognizantFoundry/react-loader/issues/47","repository_url":"https://api.github.com/repos/TheCognizantFoundry/react-loader","labels_url":"https://api.github.com/repos/TheCognizantFoundry/react-loader/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/TheCognizantFoundry/react-loader/issues/47/comments","events_url":"https://api.github.com/repos/TheCognizantFoundry/react-loader/issues/47/events","html_url":"https://github.com/TheCognizantFoundry/react-loader/pull/47","id":157375243,"number":47,"title":"Added support for delay prop.","user":{"login":"mariusk","id":218612,"avatar_url":"https://avatars.githubusercontent.com/u/218612?v=3","gravatar_id":"","url":"https://api.github.com/users/mariusk","html_url":"https://github.com/mariusk","followers_url":"https://api.github.com/users/mariusk/followers","following_url":"https://api.github.com/users/mariusk/following{/other_user}","gists_url":"https://api.github.com/users/mariusk/gists{/gist_id}","starred_url":"https://api.github.com/users/mariusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariusk/subscriptions","organizations_url":"https://api.github.com/users/mariusk/orgs","repos_url":"https://api.github.com/users/mariusk/repos","events_url":"https://api.github.com/users/mariusk/events{/privacy}","received_events_url":"https://api.github.com/users/mariusk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-05-29T08:20:14Z","updated_at":"2016-11-17T08:49:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TheCognizantFoundry/react-loader/pulls/47","html_url":"https://github.com/TheCognizantFoundry/react-loader/pull/47","diff_url":"https://github.com/TheCognizantFoundry/react-loader/pull/47.diff","patch_url":"https://github.com/TheCognizantFoundry/react-loader/pull/47.patch"},"body":"#### Supports delay property to delay showing spinner\n\nVery often a spinner is used for loading remote content, typically after filling in a form (e.g. login or similar). This PR adds support for a `delay` property which delays how soon a spinner would replace the content beneath it.\n#### Where should the reviewer start?\n\nAt the beginning! Really, it's a small module and small change.\n#### How should this be manually tested?\n\nThe only way to test currently is to add a delay prop to the Loader module. For instance a delay of 300 would mean that a spinner would not be shown unless the operation takes more than 300 milliseconds. If it does, the spinner would show normally after 300 milliseconds have passed.\n\nSince it is a small change and I have limited experience with phantomjs, I did not add the necessary async mojo to the tests to be able to verify the correct operation. FWIW, this PR does not break any of the existing tests either.\n"},"comment":{"url":"https://api.github.com/repos/TheCognizantFoundry/react-loader/issues/comments/261189178","html_url":"https://github.com/TheCognizantFoundry/react-loader/pull/47#issuecomment-261189178","issue_url":"https://api.github.com/repos/TheCognizantFoundry/react-loader/issues/47","id":261189178,"user":{"login":"VanDavv","id":5244214,"avatar_url":"https://avatars.githubusercontent.com/u/5244214?v=3","gravatar_id":"","url":"https://api.github.com/users/VanDavv","html_url":"https://github.com/VanDavv","followers_url":"https://api.github.com/users/VanDavv/followers","following_url":"https://api.github.com/users/VanDavv/following{/other_user}","gists_url":"https://api.github.com/users/VanDavv/gists{/gist_id}","starred_url":"https://api.github.com/users/VanDavv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VanDavv/subscriptions","organizations_url":"https://api.github.com/users/VanDavv/orgs","repos_url":"https://api.github.com/users/VanDavv/repos","events_url":"https://api.github.com/users/VanDavv/events{/privacy}","received_events_url":"https://api.github.com/users/VanDavv/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T08:49:47Z","updated_at":"2016-11-17T08:49:47Z","body":"@mhuggins delay is an usefull option, not specific usecase IMO. I'd love to see this PR accepted"}}
{"actor":{"display_login":"VanDavv"}}