{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/Snyk/resolve-deps/pulls/14","id":59629579,"html_url":"https://github.com/Snyk/resolve-deps/pull/14","diff_url":"https://github.com/Snyk/resolve-deps/pull/14.diff","patch_url":"https://github.com/Snyk/resolve-deps/pull/14.patch","issue_url":"https://api.github.com/repos/Snyk/resolve-deps/issues/14","number":14,"state":"closed","locked":false,"title":"fix: move to external try-require package","user":{"login":"remy","id":13700,"avatar_url":"https://avatars.githubusercontent.com/u/13700?v=3","gravatar_id":"","url":"https://api.github.com/users/remy","html_url":"https://github.com/remy","followers_url":"https://api.github.com/users/remy/followers","following_url":"https://api.github.com/users/remy/following{/other_user}","gists_url":"https://api.github.com/users/remy/gists{/gist_id}","starred_url":"https://api.github.com/users/remy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remy/subscriptions","organizations_url":"https://api.github.com/users/remy/orgs","repos_url":"https://api.github.com/users/remy/repos","events_url":"https://api.github.com/users/remy/events{/privacy}","received_events_url":"https://api.github.com/users/remy/received_events","type":"User","site_admin":false},"body":"- [x] Reviewed by @grnd \r\n\r\n#### What's this PR do?\r\n\r\nExtracted the try-require module and use the external module\r\n\r\n#### Where should the reviewer start?\r\n\r\nDiffs - mostly removing code, and then changing require statement.\r\n\r\n#### Any background context you want to provide?\r\n\r\nsnyk cli uses it's own copy of try-require, so I've stripped it out so both packages can use the same code (to avoid duplication and errors). This is related to the npm-shrinkwrap work.","created_at":"2016-02-17T11:20:30Z","updated_at":"2016-02-17T11:22:01Z","closed_at":"2016-02-17T11:22:01Z","merged_at":"2016-02-17T11:22:01Z","merge_commit_sha":"dcf648e11aae60c3dbbaac7eaea97fca9fe4f044","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Snyk/resolve-deps/pulls/14/commits","review_comments_url":"https://api.github.com/repos/Snyk/resolve-deps/pulls/14/comments","review_comment_url":"https://api.github.com/repos/Snyk/resolve-deps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Snyk/resolve-deps/issues/14/comments","statuses_url":"https://api.github.com/repos/Snyk/resolve-deps/statuses/98634ec1315cd9b06a5bc10a98bc719345699b2f","head":{"label":"Snyk:fix/use-ext-try-require","ref":"fix/use-ext-try-require","sha":"98634ec1315cd9b06a5bc10a98bc719345699b2f","user":{"login":"Snyk","id":12959162,"avatar_url":"https://avatars.githubusercontent.com/u/12959162?v=3","gravatar_id":"","url":"https://api.github.com/users/Snyk","html_url":"https://github.com/Snyk","followers_url":"https://api.github.com/users/Snyk/followers","following_url":"https://api.github.com/users/Snyk/following{/other_user}","gists_url":"https://api.github.com/users/Snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snyk/subscriptions","organizations_url":"https://api.github.com/users/Snyk/orgs","repos_url":"https://api.github.com/users/Snyk/repos","events_url":"https://api.github.com/users/Snyk/events{/privacy}","received_events_url":"https://api.github.com/users/Snyk/received_events","type":"Organization","site_admin":false},"repo":{"id":50108618,"name":"resolve-deps","full_name":"Snyk/resolve-deps","owner":{"login":"Snyk","id":12959162,"avatar_url":"https://avatars.githubusercontent.com/u/12959162?v=3","gravatar_id":"","url":"https://api.github.com/users/Snyk","html_url":"https://github.com/Snyk","followers_url":"https://api.github.com/users/Snyk/followers","following_url":"https://api.github.com/users/Snyk/following{/other_user}","gists_url":"https://api.github.com/users/Snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snyk/subscriptions","organizations_url":"https://api.github.com/users/Snyk/orgs","repos_url":"https://api.github.com/users/Snyk/repos","events_url":"https://api.github.com/users/Snyk/events{/privacy}","received_events_url":"https://api.github.com/users/Snyk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Snyk/resolve-deps","description":"Resolves a node package tree with combined support for both npm@2 and npm@3","fork":false,"url":"https://api.github.com/repos/Snyk/resolve-deps","forks_url":"https://api.github.com/repos/Snyk/resolve-deps/forks","keys_url":"https://api.github.com/repos/Snyk/resolve-deps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Snyk/resolve-deps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Snyk/resolve-deps/teams","hooks_url":"https://api.github.com/repos/Snyk/resolve-deps/hooks","issue_events_url":"https://api.github.com/repos/Snyk/resolve-deps/issues/events{/number}","events_url":"https://api.github.com/repos/Snyk/resolve-deps/events","assignees_url":"https://api.github.com/repos/Snyk/resolve-deps/assignees{/user}","branches_url":"https://api.github.com/repos/Snyk/resolve-deps/branches{/branch}","tags_url":"https://api.github.com/repos/Snyk/resolve-deps/tags","blobs_url":"https://api.github.com/repos/Snyk/resolve-deps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Snyk/resolve-deps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Snyk/resolve-deps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Snyk/resolve-deps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Snyk/resolve-deps/statuses/{sha}","languages_url":"https://api.github.com/repos/Snyk/resolve-deps/languages","stargazers_url":"https://api.github.com/repos/Snyk/resolve-deps/stargazers","contributors_url":"https://api.github.com/repos/Snyk/resolve-deps/contributors","subscribers_url":"https://api.github.com/repos/Snyk/resolve-deps/subscribers","subscription_url":"https://api.github.com/repos/Snyk/resolve-deps/subscription","commits_url":"https://api.github.com/repos/Snyk/resolve-deps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Snyk/resolve-deps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Snyk/resolve-deps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Snyk/resolve-deps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Snyk/resolve-deps/contents/{+path}","compare_url":"https://api.github.com/repos/Snyk/resolve-deps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Snyk/resolve-deps/merges","archive_url":"https://api.github.com/repos/Snyk/resolve-deps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Snyk/resolve-deps/downloads","issues_url":"https://api.github.com/repos/Snyk/resolve-deps/issues{/number}","pulls_url":"https://api.github.com/repos/Snyk/resolve-deps/pulls{/number}","milestones_url":"https://api.github.com/repos/Snyk/resolve-deps/milestones{/number}","notifications_url":"https://api.github.com/repos/Snyk/resolve-deps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Snyk/resolve-deps/labels{/name}","releases_url":"https://api.github.com/repos/Snyk/resolve-deps/releases{/id}","deployments_url":"https://api.github.com/repos/Snyk/resolve-deps/deployments","created_at":"2016-01-21T13:15:29Z","updated_at":"2016-01-22T13:29:56Z","pushed_at":"2016-02-17T11:22:01Z","git_url":"git://github.com/Snyk/resolve-deps.git","ssh_url":"git@github.com:Snyk/resolve-deps.git","clone_url":"https://github.com/Snyk/resolve-deps.git","svn_url":"https://github.com/Snyk/resolve-deps","homepage":null,"size":265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Snyk:develop","ref":"develop","sha":"7352e1dfae7a260e5ea2a062a8d11e4b9ba99668","user":{"login":"Snyk","id":12959162,"avatar_url":"https://avatars.githubusercontent.com/u/12959162?v=3","gravatar_id":"","url":"https://api.github.com/users/Snyk","html_url":"https://github.com/Snyk","followers_url":"https://api.github.com/users/Snyk/followers","following_url":"https://api.github.com/users/Snyk/following{/other_user}","gists_url":"https://api.github.com/users/Snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snyk/subscriptions","organizations_url":"https://api.github.com/users/Snyk/orgs","repos_url":"https://api.github.com/users/Snyk/repos","events_url":"https://api.github.com/users/Snyk/events{/privacy}","received_events_url":"https://api.github.com/users/Snyk/received_events","type":"Organization","site_admin":false},"repo":{"id":50108618,"name":"resolve-deps","full_name":"Snyk/resolve-deps","owner":{"login":"Snyk","id":12959162,"avatar_url":"https://avatars.githubusercontent.com/u/12959162?v=3","gravatar_id":"","url":"https://api.github.com/users/Snyk","html_url":"https://github.com/Snyk","followers_url":"https://api.github.com/users/Snyk/followers","following_url":"https://api.github.com/users/Snyk/following{/other_user}","gists_url":"https://api.github.com/users/Snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snyk/subscriptions","organizations_url":"https://api.github.com/users/Snyk/orgs","repos_url":"https://api.github.com/users/Snyk/repos","events_url":"https://api.github.com/users/Snyk/events{/privacy}","received_events_url":"https://api.github.com/users/Snyk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Snyk/resolve-deps","description":"Resolves a node package tree with combined support for both npm@2 and npm@3","fork":false,"url":"https://api.github.com/repos/Snyk/resolve-deps","forks_url":"https://api.github.com/repos/Snyk/resolve-deps/forks","keys_url":"https://api.github.com/repos/Snyk/resolve-deps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Snyk/resolve-deps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Snyk/resolve-deps/teams","hooks_url":"https://api.github.com/repos/Snyk/resolve-deps/hooks","issue_events_url":"https://api.github.com/repos/Snyk/resolve-deps/issues/events{/number}","events_url":"https://api.github.com/repos/Snyk/resolve-deps/events","assignees_url":"https://api.github.com/repos/Snyk/resolve-deps/assignees{/user}","branches_url":"https://api.github.com/repos/Snyk/resolve-deps/branches{/branch}","tags_url":"https://api.github.com/repos/Snyk/resolve-deps/tags","blobs_url":"https://api.github.com/repos/Snyk/resolve-deps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Snyk/resolve-deps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Snyk/resolve-deps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Snyk/resolve-deps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Snyk/resolve-deps/statuses/{sha}","languages_url":"https://api.github.com/repos/Snyk/resolve-deps/languages","stargazers_url":"https://api.github.com/repos/Snyk/resolve-deps/stargazers","contributors_url":"https://api.github.com/repos/Snyk/resolve-deps/contributors","subscribers_url":"https://api.github.com/repos/Snyk/resolve-deps/subscribers","subscription_url":"https://api.github.com/repos/Snyk/resolve-deps/subscription","commits_url":"https://api.github.com/repos/Snyk/resolve-deps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Snyk/resolve-deps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Snyk/resolve-deps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Snyk/resolve-deps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Snyk/resolve-deps/contents/{+path}","compare_url":"https://api.github.com/repos/Snyk/resolve-deps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Snyk/resolve-deps/merges","archive_url":"https://api.github.com/repos/Snyk/resolve-deps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Snyk/resolve-deps/downloads","issues_url":"https://api.github.com/repos/Snyk/resolve-deps/issues{/number}","pulls_url":"https://api.github.com/repos/Snyk/resolve-deps/pulls{/number}","milestones_url":"https://api.github.com/repos/Snyk/resolve-deps/milestones{/number}","notifications_url":"https://api.github.com/repos/Snyk/resolve-deps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Snyk/resolve-deps/labels{/name}","releases_url":"https://api.github.com/repos/Snyk/resolve-deps/releases{/id}","deployments_url":"https://api.github.com/repos/Snyk/resolve-deps/deployments","created_at":"2016-01-21T13:15:29Z","updated_at":"2016-01-22T13:29:56Z","pushed_at":"2016-02-17T11:22:01Z","git_url":"git://github.com/Snyk/resolve-deps.git","ssh_url":"git@github.com:Snyk/resolve-deps.git","clone_url":"https://github.com/Snyk/resolve-deps.git","svn_url":"https://github.com/Snyk/resolve-deps","homepage":null,"size":265,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Snyk/resolve-deps/pulls/14"},"html":{"href":"https://github.com/Snyk/resolve-deps/pull/14"},"issue":{"href":"https://api.github.com/repos/Snyk/resolve-deps/issues/14"},"comments":{"href":"https://api.github.com/repos/Snyk/resolve-deps/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/Snyk/resolve-deps/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/Snyk/resolve-deps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Snyk/resolve-deps/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/Snyk/resolve-deps/statuses/98634ec1315cd9b06a5bc10a98bc719345699b2f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"grnd","id":231295,"avatar_url":"https://avatars.githubusercontent.com/u/231295?v=3","gravatar_id":"","url":"https://api.github.com/users/grnd","html_url":"https://github.com/grnd","followers_url":"https://api.github.com/users/grnd/followers","following_url":"https://api.github.com/users/grnd/following{/other_user}","gists_url":"https://api.github.com/users/grnd/gists{/gist_id}","starred_url":"https://api.github.com/users/grnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grnd/subscriptions","organizations_url":"https://api.github.com/users/grnd/orgs","repos_url":"https://api.github.com/users/grnd/repos","events_url":"https://api.github.com/users/grnd/events{/privacy}","received_events_url":"https://api.github.com/users/grnd/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":115,"changed_files":4}}