{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/63054150","id":63054150,"diff_hunk":"@@ -1972,6 +1974,31 @@ mgmt_storage_device_cmd_callback(void *data, char *arg, int len)\n   return NULL;\n }\n \n+static void *\n+mgmt_lifecycle_msg_callback(void *, char *data, int len)\n+{\n+  APIHook *hook = lifecycle_hooks->get(TS_LIFECYCLE_MSG_HOOK);\n+  TSPluginMsg msg;\n+  MgmtInt op;\n+  MgmtMarshallString tag;\n+  MgmtMarshallData payload;\n+  static const MgmtMarshallType fields[] = {MGMT_MARSHALL_INT, MGMT_MARSHALL_STRING, MGMT_MARSHALL_DATA};\n+\n+  if (mgmt_message_parse(data, len, fields, countof(fields), &op, &tag, &payload) == -1) {\n+    Error(\"[mgmt_lifecyle_msg_callback] RPC message parsing error.\");","path":"proxy/Main.cc","position":31,"original_position":31,"commit_id":"1c8d9c64a8c2780407461e6a9efe29428d1f431d","original_commit_id":"1c8d9c64a8c2780407461e6a9efe29428d1f431d","user":{"login":"jpeach","id":9917,"avatar_url":"https://avatars.githubusercontent.com/u/9917?v=3","gravatar_id":"","url":"https://api.github.com/users/jpeach","html_url":"https://github.com/jpeach","followers_url":"https://api.github.com/users/jpeach/followers","following_url":"https://api.github.com/users/jpeach/following{/other_user}","gists_url":"https://api.github.com/users/jpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeach/subscriptions","organizations_url":"https://api.github.com/users/jpeach/orgs","repos_url":"https://api.github.com/users/jpeach/repos","events_url":"https://api.github.com/users/jpeach/events{/privacy}","received_events_url":"https://api.github.com/users/jpeach/received_events","type":"User","site_admin":false},"body":"Please avoid function names in user-level error messages (it can just be emitted with ``show_location``). Suggest \"Failed to parse plugin message\".","created_at":"2016-05-12T16:43:03Z","updated_at":"2016-05-12T16:43:03Z","html_url":"https://github.com/apache/trafficserver/pull/628#discussion_r63054150","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/628","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/63054150"},"html":{"href":"https://github.com/apache/trafficserver/pull/628#discussion_r63054150"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/628"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/628","id":69754838,"html_url":"https://github.com/apache/trafficserver/pull/628","diff_url":"https://github.com/apache/trafficserver/pull/628.diff","patch_url":"https://github.com/apache/trafficserver/pull/628.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/628","number":628,"state":"open","locked":false,"title":"TS-4032: Enable command line based message passing to plugins.","user":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"body":"This is the second round after #343 . I made the RPC unpacking changes HRP recommended. Why they didn't compile before but do now, I have no idea and I have not the energy to figure it out.","created_at":"2016-05-11T22:46:51Z","updated_at":"2016-05-12T16:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b166d48a8ccddd51419405a0ddc3ecb639345af","assignee":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/628/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/628/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/628/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/1c8d9c64a8c2780407461e6a9efe29428d1f431d","head":{"label":"SolidWallOfCode:ts-4032","ref":"ts-4032","sha":"1c8d9c64a8c2780407461e6a9efe29428d1f431d","user":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"repo":{"id":3744058,"name":"trafficserver","full_name":"SolidWallOfCode/trafficserver","owner":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SolidWallOfCode/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/SolidWallOfCode/trafficserver","forks_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/forks","keys_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/teams","hooks_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/events","assignees_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/tags","blobs_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/languages","stargazers_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/subscription","commits_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/merges","archive_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/downloads","issues_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/SolidWallOfCode/trafficserver/deployments","created_at":"2012-03-16T23:25:24Z","updated_at":"2015-05-06T19:22:33Z","pushed_at":"2016-05-11T22:44:30Z","git_url":"git://github.com/SolidWallOfCode/trafficserver.git","ssh_url":"git@github.com:SolidWallOfCode/trafficserver.git","clone_url":"https://github.com/SolidWallOfCode/trafficserver.git","svn_url":"https://github.com/SolidWallOfCode/trafficserver","homepage":null,"size":53365,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"71731c0171cd8feb3b8679ebbd285f0ec1723d51","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2016-05-11T06:36:10Z","pushed_at":"2016-05-12T16:19:22Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":62812,"stargazers_count":412,"watchers_count":412,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":321,"mirror_url":null,"open_issues_count":25,"forks":321,"open_issues":25,"watchers":412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/628"},"html":{"href":"https://github.com/apache/trafficserver/pull/628"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/628"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/628/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/628/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/628/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/1c8d9c64a8c2780407461e6a9efe29428d1f431d"}}}}