{"action":"created","comment":{"url":"https://api.github.com/repos/namely/broadway/pulls/comments/59264742","id":59264742,"diff_hunk":"@@ -31,3 +38,33 @@ func (m *Manifest) Execute(vars map[string]string) string {\n \t}\n \treturn b.String()\n }\n+\n+// SetManifestRoot ensures a folder exists, then sets ManifestRoot to that\n+// folder.\n+func SetManifestRoot(newRoot string) error {","path":"deployment/manifest.go","position":33,"original_position":33,"commit_id":"ad2888b004adc18807276d38e181a12d108af1a9","original_commit_id":"ad2888b004adc18807276d38e181a12d108af1a9","user":{"login":"therealplato","id":764725,"avatar_url":"https://avatars.githubusercontent.com/u/764725?v=3","gravatar_id":"","url":"https://api.github.com/users/therealplato","html_url":"https://github.com/therealplato","followers_url":"https://api.github.com/users/therealplato/followers","following_url":"https://api.github.com/users/therealplato/following{/other_user}","gists_url":"https://api.github.com/users/therealplato/gists{/gist_id}","starred_url":"https://api.github.com/users/therealplato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealplato/subscriptions","organizations_url":"https://api.github.com/users/therealplato/orgs","repos_url":"https://api.github.com/users/therealplato/repos","events_url":"https://api.github.com/users/therealplato/events{/privacy}","received_events_url":"https://api.github.com/users/therealplato/received_events","type":"User","site_admin":false},"body":"i moved this out of playbook.go while refactoring, i think it can now be removed since e.g. tests can manipulate `env.ManifestsPath`","created_at":"2016-04-11T19:23:03Z","updated_at":"2016-04-11T19:23:03Z","html_url":"https://github.com/namely/broadway/pull/49#discussion_r59264742","pull_request_url":"https://api.github.com/repos/namely/broadway/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/namely/broadway/pulls/comments/59264742"},"html":{"href":"https://github.com/namely/broadway/pull/49#discussion_r59264742"},"pull_request":{"href":"https://api.github.com/repos/namely/broadway/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/namely/broadway/pulls/49","id":66041229,"html_url":"https://github.com/namely/broadway/pull/49","diff_url":"https://github.com/namely/broadway/pull/49.diff","patch_url":"https://github.com/namely/broadway/pull/49.patch","issue_url":"https://api.github.com/repos/namely/broadway/issues/49","number":49,"state":"open","locked":false,"title":"Fix/instance varcreation","user":{"login":"therealplato","id":764725,"avatar_url":"https://avatars.githubusercontent.com/u/764725?v=3","gravatar_id":"","url":"https://api.github.com/users/therealplato","html_url":"https://github.com/therealplato","followers_url":"https://api.github.com/users/therealplato/followers","following_url":"https://api.github.com/users/therealplato/following{/other_user}","gists_url":"https://api.github.com/users/therealplato/gists{/gist_id}","starred_url":"https://api.github.com/users/therealplato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealplato/subscriptions","organizations_url":"https://api.github.com/users/therealplato/orgs","repos_url":"https://api.github.com/users/therealplato/repos","events_url":"https://api.github.com/users/therealplato/events{/privacy}","received_events_url":"https://api.github.com/users/therealplato/received_events","type":"User","site_admin":false},"body":"This PR adds `vars` validation for instance creation and setting vars for an existing instance. Both will fail if you pass in a var that is not present in the instance's playbook.\r\n\r\nOther changes: \r\n\r\n* Instance creation now fails if the referenced `PlaybookID` is missing\r\n* `BROADWAY_MANIFESTS_PATH` and `BROADWAY_PLAYBOOKS_PATH` env vars have been added\r\n* Hardcoded manifest and playbook folder locations have been replaced with these env vars\r\n* The `test` container sets these env vars set to `examples/manifests` and `examples/playbooks` respectively\r\n* All tests that need to manipulate instances now use `PlaybookID: \"helloplaybook\"`\r\n* `helloplaybook` has been added to the examples folder, it declares two vars: `bird` and `word`\r\n\r\n\r\n","created_at":"2016-04-11T18:39:06Z","updated_at":"2016-04-11T19:23:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60800b48837c49375a26d3a59490b1edf8357dae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/namely/broadway/pulls/49/commits","review_comments_url":"https://api.github.com/repos/namely/broadway/pulls/49/comments","review_comment_url":"https://api.github.com/repos/namely/broadway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/namely/broadway/issues/49/comments","statuses_url":"https://api.github.com/repos/namely/broadway/statuses/ad2888b004adc18807276d38e181a12d108af1a9","head":{"label":"therealplato:fix/instance-varcreation","ref":"fix/instance-varcreation","sha":"ad2888b004adc18807276d38e181a12d108af1a9","user":{"login":"therealplato","id":764725,"avatar_url":"https://avatars.githubusercontent.com/u/764725?v=3","gravatar_id":"","url":"https://api.github.com/users/therealplato","html_url":"https://github.com/therealplato","followers_url":"https://api.github.com/users/therealplato/followers","following_url":"https://api.github.com/users/therealplato/following{/other_user}","gists_url":"https://api.github.com/users/therealplato/gists{/gist_id}","starred_url":"https://api.github.com/users/therealplato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealplato/subscriptions","organizations_url":"https://api.github.com/users/therealplato/orgs","repos_url":"https://api.github.com/users/therealplato/repos","events_url":"https://api.github.com/users/therealplato/events{/privacy}","received_events_url":"https://api.github.com/users/therealplato/received_events","type":"User","site_admin":false},"repo":{"id":53442542,"name":"broadway","full_name":"therealplato/broadway","owner":{"login":"therealplato","id":764725,"avatar_url":"https://avatars.githubusercontent.com/u/764725?v=3","gravatar_id":"","url":"https://api.github.com/users/therealplato","html_url":"https://github.com/therealplato","followers_url":"https://api.github.com/users/therealplato/followers","following_url":"https://api.github.com/users/therealplato/following{/other_user}","gists_url":"https://api.github.com/users/therealplato/gists{/gist_id}","starred_url":"https://api.github.com/users/therealplato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealplato/subscriptions","organizations_url":"https://api.github.com/users/therealplato/orgs","repos_url":"https://api.github.com/users/therealplato/repos","events_url":"https://api.github.com/users/therealplato/events{/privacy}","received_events_url":"https://api.github.com/users/therealplato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/therealplato/broadway","description":"Broadway ","fork":true,"url":"https://api.github.com/repos/therealplato/broadway","forks_url":"https://api.github.com/repos/therealplato/broadway/forks","keys_url":"https://api.github.com/repos/therealplato/broadway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/therealplato/broadway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/therealplato/broadway/teams","hooks_url":"https://api.github.com/repos/therealplato/broadway/hooks","issue_events_url":"https://api.github.com/repos/therealplato/broadway/issues/events{/number}","events_url":"https://api.github.com/repos/therealplato/broadway/events","assignees_url":"https://api.github.com/repos/therealplato/broadway/assignees{/user}","branches_url":"https://api.github.com/repos/therealplato/broadway/branches{/branch}","tags_url":"https://api.github.com/repos/therealplato/broadway/tags","blobs_url":"https://api.github.com/repos/therealplato/broadway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/therealplato/broadway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/therealplato/broadway/git/refs{/sha}","trees_url":"https://api.github.com/repos/therealplato/broadway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/therealplato/broadway/statuses/{sha}","languages_url":"https://api.github.com/repos/therealplato/broadway/languages","stargazers_url":"https://api.github.com/repos/therealplato/broadway/stargazers","contributors_url":"https://api.github.com/repos/therealplato/broadway/contributors","subscribers_url":"https://api.github.com/repos/therealplato/broadway/subscribers","subscription_url":"https://api.github.com/repos/therealplato/broadway/subscription","commits_url":"https://api.github.com/repos/therealplato/broadway/commits{/sha}","git_commits_url":"https://api.github.com/repos/therealplato/broadway/git/commits{/sha}","comments_url":"https://api.github.com/repos/therealplato/broadway/comments{/number}","issue_comment_url":"https://api.github.com/repos/therealplato/broadway/issues/comments{/number}","contents_url":"https://api.github.com/repos/therealplato/broadway/contents/{+path}","compare_url":"https://api.github.com/repos/therealplato/broadway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/therealplato/broadway/merges","archive_url":"https://api.github.com/repos/therealplato/broadway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/therealplato/broadway/downloads","issues_url":"https://api.github.com/repos/therealplato/broadway/issues{/number}","pulls_url":"https://api.github.com/repos/therealplato/broadway/pulls{/number}","milestones_url":"https://api.github.com/repos/therealplato/broadway/milestones{/number}","notifications_url":"https://api.github.com/repos/therealplato/broadway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/therealplato/broadway/labels{/name}","releases_url":"https://api.github.com/repos/therealplato/broadway/releases{/id}","deployments_url":"https://api.github.com/repos/therealplato/broadway/deployments","created_at":"2016-03-08T20:23:06Z","updated_at":"2016-03-08T20:23:06Z","pushed_at":"2016-04-11T18:29:11Z","git_url":"git://github.com/therealplato/broadway.git","ssh_url":"git@github.com:therealplato/broadway.git","clone_url":"https://github.com/therealplato/broadway.git","svn_url":"https://github.com/therealplato/broadway","homepage":null,"size":1658,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"namely:master","ref":"master","sha":"93289afa534947a5fa3ff183d75bd0d5820708e1","user":{"login":"namely","id":1004321,"avatar_url":"https://avatars.githubusercontent.com/u/1004321?v=3","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"repo":{"id":53081805,"name":"broadway","full_name":"namely/broadway","owner":{"login":"namely","id":1004321,"avatar_url":"https://avatars.githubusercontent.com/u/1004321?v=3","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/namely/broadway","description":"Broadway ","fork":false,"url":"https://api.github.com/repos/namely/broadway","forks_url":"https://api.github.com/repos/namely/broadway/forks","keys_url":"https://api.github.com/repos/namely/broadway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/namely/broadway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/namely/broadway/teams","hooks_url":"https://api.github.com/repos/namely/broadway/hooks","issue_events_url":"https://api.github.com/repos/namely/broadway/issues/events{/number}","events_url":"https://api.github.com/repos/namely/broadway/events","assignees_url":"https://api.github.com/repos/namely/broadway/assignees{/user}","branches_url":"https://api.github.com/repos/namely/broadway/branches{/branch}","tags_url":"https://api.github.com/repos/namely/broadway/tags","blobs_url":"https://api.github.com/repos/namely/broadway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/namely/broadway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/namely/broadway/git/refs{/sha}","trees_url":"https://api.github.com/repos/namely/broadway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/namely/broadway/statuses/{sha}","languages_url":"https://api.github.com/repos/namely/broadway/languages","stargazers_url":"https://api.github.com/repos/namely/broadway/stargazers","contributors_url":"https://api.github.com/repos/namely/broadway/contributors","subscribers_url":"https://api.github.com/repos/namely/broadway/subscribers","subscription_url":"https://api.github.com/repos/namely/broadway/subscription","commits_url":"https://api.github.com/repos/namely/broadway/commits{/sha}","git_commits_url":"https://api.github.com/repos/namely/broadway/git/commits{/sha}","comments_url":"https://api.github.com/repos/namely/broadway/comments{/number}","issue_comment_url":"https://api.github.com/repos/namely/broadway/issues/comments{/number}","contents_url":"https://api.github.com/repos/namely/broadway/contents/{+path}","compare_url":"https://api.github.com/repos/namely/broadway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/namely/broadway/merges","archive_url":"https://api.github.com/repos/namely/broadway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/namely/broadway/downloads","issues_url":"https://api.github.com/repos/namely/broadway/issues{/number}","pulls_url":"https://api.github.com/repos/namely/broadway/pulls{/number}","milestones_url":"https://api.github.com/repos/namely/broadway/milestones{/number}","notifications_url":"https://api.github.com/repos/namely/broadway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/namely/broadway/labels{/name}","releases_url":"https://api.github.com/repos/namely/broadway/releases{/id}","deployments_url":"https://api.github.com/repos/namely/broadway/deployments","created_at":"2016-03-03T20:42:56Z","updated_at":"2016-04-09T01:09:20Z","pushed_at":"2016-04-11T18:39:06Z","git_url":"git://github.com/namely/broadway.git","ssh_url":"git@github.com:namely/broadway.git","clone_url":"https://github.com/namely/broadway.git","svn_url":"https://github.com/namely/broadway","homepage":null,"size":2970,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/namely/broadway/pulls/49"},"html":{"href":"https://github.com/namely/broadway/pull/49"},"issue":{"href":"https://api.github.com/repos/namely/broadway/issues/49"},"comments":{"href":"https://api.github.com/repos/namely/broadway/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/namely/broadway/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/namely/broadway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/namely/broadway/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/namely/broadway/statuses/ad2888b004adc18807276d38e181a12d108af1a9"}}}}