{"action":"closed","number":97,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/97","id":74457947,"html_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/97","diff_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/97.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/97.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/97","number":97,"state":"closed","locked":false,"title":"Add support for attribute compression","user":{"login":"lasalvavida","id":2489570,"avatar_url":"https://avatars.githubusercontent.com/u/2489570?v=3","gravatar_id":"","url":"https://api.github.com/users/lasalvavida","html_url":"https://github.com/lasalvavida","followers_url":"https://api.github.com/users/lasalvavida/followers","following_url":"https://api.github.com/users/lasalvavida/following{/other_user}","gists_url":"https://api.github.com/users/lasalvavida/gists{/gist_id}","starred_url":"https://api.github.com/users/lasalvavida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasalvavida/subscriptions","organizations_url":"https://api.github.com/users/lasalvavida/orgs","repos_url":"https://api.github.com/users/lasalvavida/repos","events_url":"https://api.github.com/users/lasalvavida/events{/privacy}","received_events_url":"https://api.github.com/users/lasalvavida/received_events","type":"User","site_admin":false},"body":"Currently this relies on Cesium resolving the built-in shader functions, so it won't work in other glTF engines. \r\n\r\nChanging the `includeBuiltIns` flag to true will fully resolve the shader source in the pipeline, making it compatible with other engines, but then if you use the model in Cesium you will get shader errors since it tries to add the functions in and they already exist. \r\n@pjcozzi Is that a bug in Cesium?","created_at":"2016-06-20T15:00:39Z","updated_at":"2016-06-30T21:10:06Z","closed_at":"2016-06-30T21:10:06Z","merged_at":"2016-06-30T21:10:06Z","merge_commit_sha":"96ec5d2a0f8b040ed9e97c4c626611f3c8c46640","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/97/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/97/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/97/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/6ce49f72a899d3eb195a03b48165b48f212d0b35","head":{"label":"AnalyticalGraphicsInc:oct-encoding","ref":"oct-encoding","sha":"6ce49f72a899d3eb195a03b48165b48f212d0b35","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":46226879,"name":"gltf-pipeline","full_name":"AnalyticalGraphicsInc/gltf-pipeline","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","description":"Content pipeline tools for optimizing glTF assets. :globe_with_meridians:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/deployments","created_at":"2015-11-15T17:00:20Z","updated_at":"2016-06-28T14:40:59Z","pushed_at":"2016-06-30T21:10:06Z","git_url":"git://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/gltf-pipeline.git","clone_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","svn_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","homepage":"","size":7896,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":19,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"f63383130b9769838eff6666675dbff4b0ebac6c","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":46226879,"name":"gltf-pipeline","full_name":"AnalyticalGraphicsInc/gltf-pipeline","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","description":"Content pipeline tools for optimizing glTF assets. :globe_with_meridians:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/deployments","created_at":"2015-11-15T17:00:20Z","updated_at":"2016-06-28T14:40:59Z","pushed_at":"2016-06-30T21:10:06Z","git_url":"git://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/gltf-pipeline.git","clone_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","svn_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","homepage":"","size":7896,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/97"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/97"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/97"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/6ce49f72a899d3eb195a03b48165b48f212d0b35"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"comments":40,"review_comments":12,"commits":27,"additions":706,"deletions":25,"changed_files":11}}
{"actor":{"display_login":"pjcozzi"}}