{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/1","id":95224988,"html_url":"https://github.com/savoirfairelinux/ring-daemon/pull/1","diff_url":"https://github.com/savoirfairelinux/ring-daemon/pull/1.diff","patch_url":"https://github.com/savoirfairelinux/ring-daemon/pull/1.patch","issue_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/issues/1","number":1,"state":"closed","locked":false,"title":"ajout de notre solution","user":{"login":"zinspierre","id":8974021,"avatar_url":"https://avatars.githubusercontent.com/u/8974021?v=3","gravatar_id":"","url":"https://api.github.com/users/zinspierre","html_url":"https://github.com/zinspierre","followers_url":"https://api.github.com/users/zinspierre/followers","following_url":"https://api.github.com/users/zinspierre/following{/other_user}","gists_url":"https://api.github.com/users/zinspierre/gists{/gist_id}","starred_url":"https://api.github.com/users/zinspierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinspierre/subscriptions","organizations_url":"https://api.github.com/users/zinspierre/orgs","repos_url":"https://api.github.com/users/zinspierre/repos","events_url":"https://api.github.com/users/zinspierre/events{/privacy}","received_events_url":"https://api.github.com/users/zinspierre/received_events","type":"User","site_admin":false},"body":"Polytechnique Montreal cours LOG8430\r\nSolution de refactoring pour : \r\n\r\n- Manager::joinParticipant() : mise en place du patron de conception State, ajout des classes représentant les états des appels\r\nCallState_ : classe de base abstraite\r\nIncomingCall, HoldCall, CurrentCall, InactiveCall, ConnectingCall, RingingCall, HungupCall, BusyCall, OverCall, FailureCall\r\nLa métode getState() sera virtuelle pure pour CallState_ et permettra de retourner l'état de l'appel. \r\nLa méthode configureConference() va configurer la conférence. Cela va simplifier et permettre de retirer du code de Manager::JoinParticipant().\r\n\r\n- Call::getStateStr() : découpage de la fonction pour réduire sa complexité cyclomatique. \r\nEt ajout des fonctions onInactiveState() et onActiveState(). Changement sur les retours de ces fonctions pour qu'elles soient adaptées à notre patron de conception State.\r\n\r\nNotre solution est ajoutée avec le moins de modifications dans le code déjà existant. Les classes enum CallState sont conservées et encore utilisées. Nos nouvelles classes sont uniquement utilisées pour les fonctions citées plus haut, afin de mettre en place le patron state.\r\n\r\n","created_at":"2016-11-24T20:20:40Z","updated_at":"2016-11-26T20:12:56Z","closed_at":"2016-11-26T20:12:56Z","merged_at":null,"merge_commit_sha":"1539a5eba47cf4366379d5986c0494836e8035bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/1/commits","review_comments_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/1/comments","review_comment_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/issues/1/comments","statuses_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/statuses/ed1bd246c44db883b7eb295a145403e815f4cebb","head":{"label":"zinspierre:polymtl_log8430","ref":"polymtl_log8430","sha":"ed1bd246c44db883b7eb295a145403e815f4cebb","user":{"login":"zinspierre","id":8974021,"avatar_url":"https://avatars.githubusercontent.com/u/8974021?v=3","gravatar_id":"","url":"https://api.github.com/users/zinspierre","html_url":"https://github.com/zinspierre","followers_url":"https://api.github.com/users/zinspierre/followers","following_url":"https://api.github.com/users/zinspierre/following{/other_user}","gists_url":"https://api.github.com/users/zinspierre/gists{/gist_id}","starred_url":"https://api.github.com/users/zinspierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinspierre/subscriptions","organizations_url":"https://api.github.com/users/zinspierre/orgs","repos_url":"https://api.github.com/users/zinspierre/repos","events_url":"https://api.github.com/users/zinspierre/events{/privacy}","received_events_url":"https://api.github.com/users/zinspierre/received_events","type":"User","site_admin":false},"repo":{"id":74699929,"name":"ring-daemon","full_name":"zinspierre/ring-daemon","owner":{"login":"zinspierre","id":8974021,"avatar_url":"https://avatars.githubusercontent.com/u/8974021?v=3","gravatar_id":"","url":"https://api.github.com/users/zinspierre","html_url":"https://github.com/zinspierre","followers_url":"https://api.github.com/users/zinspierre/followers","following_url":"https://api.github.com/users/zinspierre/following{/other_user}","gists_url":"https://api.github.com/users/zinspierre/gists{/gist_id}","starred_url":"https://api.github.com/users/zinspierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinspierre/subscriptions","organizations_url":"https://api.github.com/users/zinspierre/orgs","repos_url":"https://api.github.com/users/zinspierre/repos","events_url":"https://api.github.com/users/zinspierre/events{/privacy}","received_events_url":"https://api.github.com/users/zinspierre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zinspierre/ring-daemon","description":"Mirror of Gerrit Ring Core Library and Daemon","fork":true,"url":"https://api.github.com/repos/zinspierre/ring-daemon","forks_url":"https://api.github.com/repos/zinspierre/ring-daemon/forks","keys_url":"https://api.github.com/repos/zinspierre/ring-daemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zinspierre/ring-daemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zinspierre/ring-daemon/teams","hooks_url":"https://api.github.com/repos/zinspierre/ring-daemon/hooks","issue_events_url":"https://api.github.com/repos/zinspierre/ring-daemon/issues/events{/number}","events_url":"https://api.github.com/repos/zinspierre/ring-daemon/events","assignees_url":"https://api.github.com/repos/zinspierre/ring-daemon/assignees{/user}","branches_url":"https://api.github.com/repos/zinspierre/ring-daemon/branches{/branch}","tags_url":"https://api.github.com/repos/zinspierre/ring-daemon/tags","blobs_url":"https://api.github.com/repos/zinspierre/ring-daemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zinspierre/ring-daemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zinspierre/ring-daemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/zinspierre/ring-daemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zinspierre/ring-daemon/statuses/{sha}","languages_url":"https://api.github.com/repos/zinspierre/ring-daemon/languages","stargazers_url":"https://api.github.com/repos/zinspierre/ring-daemon/stargazers","contributors_url":"https://api.github.com/repos/zinspierre/ring-daemon/contributors","subscribers_url":"https://api.github.com/repos/zinspierre/ring-daemon/subscribers","subscription_url":"https://api.github.com/repos/zinspierre/ring-daemon/subscription","commits_url":"https://api.github.com/repos/zinspierre/ring-daemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/zinspierre/ring-daemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/zinspierre/ring-daemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/zinspierre/ring-daemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/zinspierre/ring-daemon/contents/{+path}","compare_url":"https://api.github.com/repos/zinspierre/ring-daemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zinspierre/ring-daemon/merges","archive_url":"https://api.github.com/repos/zinspierre/ring-daemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zinspierre/ring-daemon/downloads","issues_url":"https://api.github.com/repos/zinspierre/ring-daemon/issues{/number}","pulls_url":"https://api.github.com/repos/zinspierre/ring-daemon/pulls{/number}","milestones_url":"https://api.github.com/repos/zinspierre/ring-daemon/milestones{/number}","notifications_url":"https://api.github.com/repos/zinspierre/ring-daemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zinspierre/ring-daemon/labels{/name}","releases_url":"https://api.github.com/repos/zinspierre/ring-daemon/releases{/id}","deployments_url":"https://api.github.com/repos/zinspierre/ring-daemon/deployments","created_at":"2016-11-24T19:25:55Z","updated_at":"2016-11-24T19:26:01Z","pushed_at":"2016-11-24T19:55:43Z","git_url":"git://github.com/zinspierre/ring-daemon.git","ssh_url":"git@github.com:zinspierre/ring-daemon.git","clone_url":"https://github.com/zinspierre/ring-daemon.git","svn_url":"https://github.com/zinspierre/ring-daemon","homepage":null,"size":83676,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"savoirfairelinux:master","ref":"master","sha":"2b1172219887458af73d7606deb51a5de5ac7933","user":{"login":"savoirfairelinux","id":2735545,"avatar_url":"https://avatars.githubusercontent.com/u/2735545?v=3","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"repo":{"id":45633910,"name":"ring-daemon","full_name":"savoirfairelinux/ring-daemon","owner":{"login":"savoirfairelinux","id":2735545,"avatar_url":"https://avatars.githubusercontent.com/u/2735545?v=3","gravatar_id":"","url":"https://api.github.com/users/savoirfairelinux","html_url":"https://github.com/savoirfairelinux","followers_url":"https://api.github.com/users/savoirfairelinux/followers","following_url":"https://api.github.com/users/savoirfairelinux/following{/other_user}","gists_url":"https://api.github.com/users/savoirfairelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/savoirfairelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savoirfairelinux/subscriptions","organizations_url":"https://api.github.com/users/savoirfairelinux/orgs","repos_url":"https://api.github.com/users/savoirfairelinux/repos","events_url":"https://api.github.com/users/savoirfairelinux/events{/privacy}","received_events_url":"https://api.github.com/users/savoirfairelinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/savoirfairelinux/ring-daemon","description":"Mirror of Gerrit Ring Core Library and Daemon","fork":false,"url":"https://api.github.com/repos/savoirfairelinux/ring-daemon","forks_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/forks","keys_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/teams","hooks_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/hooks","issue_events_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/issues/events{/number}","events_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/events","assignees_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/assignees{/user}","branches_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/branches{/branch}","tags_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/tags","blobs_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/statuses/{sha}","languages_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/languages","stargazers_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/stargazers","contributors_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/contributors","subscribers_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/subscribers","subscription_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/subscription","commits_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/contents/{+path}","compare_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/merges","archive_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/downloads","issues_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/issues{/number}","pulls_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls{/number}","milestones_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/milestones{/number}","notifications_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/labels{/name}","releases_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/releases{/id}","deployments_url":"https://api.github.com/repos/savoirfairelinux/ring-daemon/deployments","created_at":"2015-11-05T19:22:49Z","updated_at":"2016-11-24T21:27:06Z","pushed_at":"2016-11-26T19:21:14Z","git_url":"git://github.com/savoirfairelinux/ring-daemon.git","ssh_url":"git@github.com:savoirfairelinux/ring-daemon.git","clone_url":"https://github.com/savoirfairelinux/ring-daemon.git","svn_url":"https://github.com/savoirfairelinux/ring-daemon","homepage":null,"size":100223,"stargazers_count":61,"watchers_count":61,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":0,"forks":11,"open_issues":0,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/1"},"html":{"href":"https://github.com/savoirfairelinux/ring-daemon/pull/1"},"issue":{"href":"https://api.github.com/repos/savoirfairelinux/ring-daemon/issues/1"},"comments":{"href":"https://api.github.com/repos/savoirfairelinux/ring-daemon/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/savoirfairelinux/ring-daemon/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/savoirfairelinux/ring-daemon/statuses/ed1bd246c44db883b7eb295a145403e815f4cebb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":285,"deletions":88,"changed_files":4}}
{"actor":{"display_login":"zinspierre"}}