{"action":"created","issue":{"url":"https://api.github.com/repos/Bareflank/hypervisor/issues/208","repository_url":"https://api.github.com/repos/Bareflank/hypervisor","labels_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/208/comments","events_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/208/events","html_url":"https://github.com/Bareflank/hypervisor/issues/208","id":176458611,"number":208,"title":"Destructors marked override","user":{"login":"RicoAntonioFelix","id":6290785,"avatar_url":"https://avatars.githubusercontent.com/u/6290785?v=3","gravatar_id":"","url":"https://api.github.com/users/RicoAntonioFelix","html_url":"https://github.com/RicoAntonioFelix","followers_url":"https://api.github.com/users/RicoAntonioFelix/followers","following_url":"https://api.github.com/users/RicoAntonioFelix/following{/other_user}","gists_url":"https://api.github.com/users/RicoAntonioFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/RicoAntonioFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RicoAntonioFelix/subscriptions","organizations_url":"https://api.github.com/users/RicoAntonioFelix/orgs","repos_url":"https://api.github.com/users/RicoAntonioFelix/repos","events_url":"https://api.github.com/users/RicoAntonioFelix/events{/privacy}","received_events_url":"https://api.github.com/users/RicoAntonioFelix/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-09-12T19:10:04Z","updated_at":"2016-09-21T08:45:04Z","closed_at":"2016-09-12T19:57:30Z","body":"With regard to [this](https://github.com/isocpp/CppCoreGuidelines/issues/721) issue \"`C.128: Should destructors be marked \"override\"?`\"\r\n\r\nAnd the [comment](https://github.com/isocpp/CppCoreGuidelines/issues/721#issuecomment-246453707) from @gdr-at-ms\r\n\r\n[hypervisor](https://github.com/Bareflank/hypervisor)'s repo should be updated... One such instance can be found [here](https://github.com/Bareflank/hypervisor/blob/master/bfvmm/include/memory_manager/page_table_x64.h#L47)"},"comment":{"url":"https://api.github.com/repos/Bareflank/hypervisor/issues/comments/248549147","html_url":"https://github.com/Bareflank/hypervisor/issues/208#issuecomment-248549147","issue_url":"https://api.github.com/repos/Bareflank/hypervisor/issues/208","id":248549147,"user":{"login":"alexfh","id":2892960,"avatar_url":"https://avatars.githubusercontent.com/u/2892960?v=3","gravatar_id":"","url":"https://api.github.com/users/alexfh","html_url":"https://github.com/alexfh","followers_url":"https://api.github.com/users/alexfh/followers","following_url":"https://api.github.com/users/alexfh/following{/other_user}","gists_url":"https://api.github.com/users/alexfh/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfh/subscriptions","organizations_url":"https://api.github.com/users/alexfh/orgs","repos_url":"https://api.github.com/users/alexfh/repos","events_url":"https://api.github.com/users/alexfh/events{/privacy}","received_events_url":"https://api.github.com/users/alexfh/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T08:45:03Z","updated_at":"2016-09-21T08:45:03Z","body":"@gdr-at-ms is wrong wrt. \"You never override a destructor -- virtual destructors are \"chained\".\" The \"chained\" aspect is completely orthogonal to the overriding. \r\n\r\nAccording to [class.virtual]p6:\r\n\"Even though destructors are not inherited, a destructor in a derived class overrides a base class destructor declared virtual; see 12.4 and 12.5.\"\r\n\r\nThus, the use of the 'override' keyword on destructors is in line with the intention of the standard."}}
{"actor":{"display_login":"alexfh"}}