{"action":"closed","number":811,"pull_request":{"url":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/811","id":93630580,"html_url":"https://github.com/MetaMask/metamask-plugin/pull/811","diff_url":"https://github.com/MetaMask/metamask-plugin/pull/811.diff","patch_url":"https://github.com/MetaMask/metamask-plugin/pull/811.patch","issue_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/811","number":811,"state":"closed","locked":false,"title":"Fix error display in confirmation screen","user":{"login":"Zanibas","id":1840057,"avatar_url":"https://avatars.githubusercontent.com/u/1840057?v=3","gravatar_id":"","url":"https://api.github.com/users/Zanibas","html_url":"https://github.com/Zanibas","followers_url":"https://api.github.com/users/Zanibas/followers","following_url":"https://api.github.com/users/Zanibas/following{/other_user}","gists_url":"https://api.github.com/users/Zanibas/gists{/gist_id}","starred_url":"https://api.github.com/users/Zanibas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zanibas/subscriptions","organizations_url":"https://api.github.com/users/Zanibas/orgs","repos_url":"https://api.github.com/users/Zanibas/repos","events_url":"https://api.github.com/users/Zanibas/events{/privacy}","received_events_url":"https://api.github.com/users/Zanibas/received_events","type":"User","site_admin":false},"body":"Fixes the elusive #756....perhaps. We'll need testing to be sure, but I'm pushing a PR early just to start discussion.\r\n\r\nBasically, what's happening is that if a full error is pushed into our provider engine through callbacks, provider engine will provide an error within an error when attempting to display the error in MetaMask.\r\n\r\nThis is rectified by conditionally by either printing error.message, or plain error if that doesn't exist (and is most likely a plain string).\r\n\r\n@flyswatter how can we test this? I would need a faulty contract like in the thread to reproduce and confirm.","created_at":"2016-11-14T19:26:44Z","updated_at":"2016-11-15T03:39:17Z","closed_at":"2016-11-15T03:39:17Z","merged_at":"2016-11-15T03:39:17Z","merge_commit_sha":"68d5b459ed406fd8d5e460e3208250530b21aa43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/811/commits","review_comments_url":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/811/comments","review_comment_url":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/811/comments","statuses_url":"https://api.github.com/repos/MetaMask/metamask-plugin/statuses/acf02c929036953306037a660c75adc905631706","head":{"label":"MetaMask:deadly-fix","ref":"deadly-fix","sha":"acf02c929036953306037a660c75adc905631706","user":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"repo":{"id":42009758,"name":"metamask-plugin","full_name":"MetaMask/metamask-plugin","owner":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaMask/metamask-plugin","description":":globe_with_meridians: :electric_plug: metamask chrome extension","fork":false,"url":"https://api.github.com/repos/MetaMask/metamask-plugin","forks_url":"https://api.github.com/repos/MetaMask/metamask-plugin/forks","keys_url":"https://api.github.com/repos/MetaMask/metamask-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaMask/metamask-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaMask/metamask-plugin/teams","hooks_url":"https://api.github.com/repos/MetaMask/metamask-plugin/hooks","issue_events_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/MetaMask/metamask-plugin/events","assignees_url":"https://api.github.com/repos/MetaMask/metamask-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/MetaMask/metamask-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/MetaMask/metamask-plugin/tags","blobs_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaMask/metamask-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaMask/metamask-plugin/languages","stargazers_url":"https://api.github.com/repos/MetaMask/metamask-plugin/stargazers","contributors_url":"https://api.github.com/repos/MetaMask/metamask-plugin/contributors","subscribers_url":"https://api.github.com/repos/MetaMask/metamask-plugin/subscribers","subscription_url":"https://api.github.com/repos/MetaMask/metamask-plugin/subscription","commits_url":"https://api.github.com/repos/MetaMask/metamask-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaMask/metamask-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetaMask/metamask-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/MetaMask/metamask-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaMask/metamask-plugin/merges","archive_url":"https://api.github.com/repos/MetaMask/metamask-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaMask/metamask-plugin/downloads","issues_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaMask/metamask-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaMask/metamask-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaMask/metamask-plugin/labels{/name}","releases_url":"https://api.github.com/repos/MetaMask/metamask-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/MetaMask/metamask-plugin/deployments","created_at":"2015-09-06T16:34:48Z","updated_at":"2016-11-14T08:03:27Z","pushed_at":"2016-11-15T03:39:17Z","git_url":"git://github.com/MetaMask/metamask-plugin.git","ssh_url":"git@github.com:MetaMask/metamask-plugin.git","clone_url":"https://github.com/MetaMask/metamask-plugin.git","svn_url":"https://github.com/MetaMask/metamask-plugin","homepage":"https://metamask.io/","size":12679,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":106,"forks":15,"open_issues":106,"watchers":35,"default_branch":"master"}},"base":{"label":"MetaMask:master","ref":"master","sha":"115fdc36fefd33e4bf4a9e551dd6267d3d75f2c5","user":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"repo":{"id":42009758,"name":"metamask-plugin","full_name":"MetaMask/metamask-plugin","owner":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars.githubusercontent.com/u/11744586?v=3","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaMask/metamask-plugin","description":":globe_with_meridians: :electric_plug: metamask chrome extension","fork":false,"url":"https://api.github.com/repos/MetaMask/metamask-plugin","forks_url":"https://api.github.com/repos/MetaMask/metamask-plugin/forks","keys_url":"https://api.github.com/repos/MetaMask/metamask-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaMask/metamask-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaMask/metamask-plugin/teams","hooks_url":"https://api.github.com/repos/MetaMask/metamask-plugin/hooks","issue_events_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/MetaMask/metamask-plugin/events","assignees_url":"https://api.github.com/repos/MetaMask/metamask-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/MetaMask/metamask-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/MetaMask/metamask-plugin/tags","blobs_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaMask/metamask-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaMask/metamask-plugin/languages","stargazers_url":"https://api.github.com/repos/MetaMask/metamask-plugin/stargazers","contributors_url":"https://api.github.com/repos/MetaMask/metamask-plugin/contributors","subscribers_url":"https://api.github.com/repos/MetaMask/metamask-plugin/subscribers","subscription_url":"https://api.github.com/repos/MetaMask/metamask-plugin/subscription","commits_url":"https://api.github.com/repos/MetaMask/metamask-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaMask/metamask-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaMask/metamask-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetaMask/metamask-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/MetaMask/metamask-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaMask/metamask-plugin/merges","archive_url":"https://api.github.com/repos/MetaMask/metamask-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaMask/metamask-plugin/downloads","issues_url":"https://api.github.com/repos/MetaMask/metamask-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaMask/metamask-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaMask/metamask-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaMask/metamask-plugin/labels{/name}","releases_url":"https://api.github.com/repos/MetaMask/metamask-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/MetaMask/metamask-plugin/deployments","created_at":"2015-09-06T16:34:48Z","updated_at":"2016-11-14T08:03:27Z","pushed_at":"2016-11-15T03:39:17Z","git_url":"git://github.com/MetaMask/metamask-plugin.git","ssh_url":"git@github.com:MetaMask/metamask-plugin.git","clone_url":"https://github.com/MetaMask/metamask-plugin.git","svn_url":"https://github.com/MetaMask/metamask-plugin","homepage":"https://metamask.io/","size":12679,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":106,"forks":15,"open_issues":106,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/811"},"html":{"href":"https://github.com/MetaMask/metamask-plugin/pull/811"},"issue":{"href":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/811"},"comments":{"href":"https://api.github.com/repos/MetaMask/metamask-plugin/issues/811/comments"},"review_comments":{"href":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/811/comments"},"review_comment":{"href":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MetaMask/metamask-plugin/pulls/811/commits"},"statuses":{"href":"https://api.github.com/repos/MetaMask/metamask-plugin/statuses/acf02c929036953306037a660c75adc905631706"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kumavis","id":1474978,"avatar_url":"https://avatars.githubusercontent.com/u/1474978?v=3","gravatar_id":"","url":"https://api.github.com/users/kumavis","html_url":"https://github.com/kumavis","followers_url":"https://api.github.com/users/kumavis/followers","following_url":"https://api.github.com/users/kumavis/following{/other_user}","gists_url":"https://api.github.com/users/kumavis/gists{/gist_id}","starred_url":"https://api.github.com/users/kumavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumavis/subscriptions","organizations_url":"https://api.github.com/users/kumavis/orgs","repos_url":"https://api.github.com/users/kumavis/repos","events_url":"https://api.github.com/users/kumavis/events{/privacy}","received_events_url":"https://api.github.com/users/kumavis/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":4,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"kumavis"}}