{"action":"opened","number":4909,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4909","id":79442855,"html_url":"https://github.com/zfsonlinux/zfs/pull/4909","diff_url":"https://github.com/zfsonlinux/zfs/pull/4909.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/4909.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4909","number":4909,"state":"open","locked":false,"title":"Silence for Fedora 24 warnings","user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"body":"@ironMann @tuxoko the following two patches resolve compiler warnings we're seeing with Fedora 24.  I'm not thrilled with having to make either of changes but what are your thoughts.\r\n\r\nRegarding fbf64cb gcc was complaining that one of the conditions in a macro always evaluted true.  This was the correct behavior but to make gcc happy I added the calling convention used elsewhere in the code for BP_SET_BIRTH() and set physical to 0.\r\n\r\nAs for b891169 I'm reasonably certain gcc is flat out wrong about this bounds check.  There is no overflow here, it would be great if you could verify this.  It feels almost like an off by one error since if you tweak the ZDB_OT_NAME macro to use `DMU_OT_NUMTYPES-1` gcc is happy (even though that's wrong).  I opted to disable this specific warning just for this function but I'd love a better solution.  Any ideas?","created_at":"2016-07-30T00:55:39Z","updated_at":"2016-07-30T00:55:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4909/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4909/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4909/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/fbf64cbc4aa6c9ee6b796440c5a6e2eeb80853c6","head":{"label":"behlendorf:issue-4907","ref":"issue-4907","sha":"fbf64cbc4aa6c9ee6b796440c5a6e2eeb80853c6","user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"repo":{"id":2003466,"name":"zfs","full_name":"behlendorf/zfs","owner":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behlendorf/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/behlendorf/zfs","forks_url":"https://api.github.com/repos/behlendorf/zfs/forks","keys_url":"https://api.github.com/repos/behlendorf/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behlendorf/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behlendorf/zfs/teams","hooks_url":"https://api.github.com/repos/behlendorf/zfs/hooks","issue_events_url":"https://api.github.com/repos/behlendorf/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/behlendorf/zfs/events","assignees_url":"https://api.github.com/repos/behlendorf/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/behlendorf/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/behlendorf/zfs/tags","blobs_url":"https://api.github.com/repos/behlendorf/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behlendorf/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behlendorf/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/behlendorf/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behlendorf/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/behlendorf/zfs/languages","stargazers_url":"https://api.github.com/repos/behlendorf/zfs/stargazers","contributors_url":"https://api.github.com/repos/behlendorf/zfs/contributors","subscribers_url":"https://api.github.com/repos/behlendorf/zfs/subscribers","subscription_url":"https://api.github.com/repos/behlendorf/zfs/subscription","commits_url":"https://api.github.com/repos/behlendorf/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/behlendorf/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/behlendorf/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/behlendorf/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/behlendorf/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/behlendorf/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behlendorf/zfs/merges","archive_url":"https://api.github.com/repos/behlendorf/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behlendorf/zfs/downloads","issues_url":"https://api.github.com/repos/behlendorf/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/behlendorf/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/behlendorf/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/behlendorf/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behlendorf/zfs/labels{/name}","releases_url":"https://api.github.com/repos/behlendorf/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/behlendorf/zfs/deployments","created_at":"2011-07-05T22:51:43Z","updated_at":"2016-07-28T15:27:28Z","pushed_at":"2016-07-30T00:41:53Z","git_url":"git://github.com/behlendorf/zfs.git","ssh_url":"git@github.com:behlendorf/zfs.git","clone_url":"https://github.com/behlendorf/zfs.git","svn_url":"https://github.com/behlendorf/zfs","homepage":"http://zfsonlinux.org/","size":31927,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":42,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"df053d67a9c07a9763a4c04468083644eb9aa234","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-07-29T21:41:13Z","pushed_at":"2016-07-30T00:55:39Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":56894,"stargazers_count":1959,"watchers_count":1959,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":488,"mirror_url":null,"open_issues_count":995,"forks":488,"open_issues":995,"watchers":1959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4909"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/4909"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4909"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4909/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4909/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4909/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/fbf64cbc4aa6c9ee6b796440c5a6e2eeb80853c6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":12,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"behlendorf"}}