{"action":"closed","number":10834,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/10834","id":98558494,"html_url":"https://github.com/hashicorp/terraform/pull/10834","diff_url":"https://github.com/hashicorp/terraform/pull/10834.diff","patch_url":"https://github.com/hashicorp/terraform/pull/10834.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/10834","number":10834,"state":"closed","locked":false,"title":"provider/azurerm: fix network_interface.ip_configuration hash for load balancers","user":{"login":"pmcatominey","id":918856,"avatar_url":"https://avatars.githubusercontent.com/u/918856?v=3","gravatar_id":"","url":"https://api.github.com/users/pmcatominey","html_url":"https://github.com/pmcatominey","followers_url":"https://api.github.com/users/pmcatominey/followers","following_url":"https://api.github.com/users/pmcatominey/following{/other_user}","gists_url":"https://api.github.com/users/pmcatominey/gists{/gist_id}","starred_url":"https://api.github.com/users/pmcatominey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmcatominey/subscriptions","organizations_url":"https://api.github.com/users/pmcatominey/orgs","repos_url":"https://api.github.com/users/pmcatominey/repos","events_url":"https://api.github.com/users/pmcatominey/events{/privacy}","received_events_url":"https://api.github.com/users/pmcatominey/received_events","type":"User","site_admin":false},"body":"The subsets for backend address pools and inbound nat rules weren't being hashed\r\nproperly as part of the ip_configuration hash which caused multiple\r\nip_configurations to be expanded and sent to the API with conflicting names\r\n\r\nFixes #9878\r\nFixes #10561\r\n\r\n```\r\nTF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMNetworkInterface -timeout 120m\r\n=== RUN   TestAccAzureRMNetworkInterface_basic\r\n--- PASS: TestAccAzureRMNetworkInterface_basic (160.24s)\r\n=== RUN   TestAccAzureRMNetworkInterface_disappears\r\n--- PASS: TestAccAzureRMNetworkInterface_disappears (157.00s)\r\n=== RUN   TestAccAzureRMNetworkInterface_enableIPForwarding\r\n--- PASS: TestAccAzureRMNetworkInterface_enableIPForwarding (156.86s)\r\n=== RUN   TestAccAzureRMNetworkInterface_multipleLoadBalancers\r\n--- PASS: TestAccAzureRMNetworkInterface_multipleLoadBalancers (185.87s)\r\n=== RUN   TestAccAzureRMNetworkInterface_withTags\r\n--- PASS: TestAccAzureRMNetworkInterface_withTags (1212.92s)\r\nPASS\r\nok  \tgithub.com/hashicorp/terraform/builtin/providers/azurerm\t1872.960s\r\n```","created_at":"2016-12-19T12:40:00Z","updated_at":"2016-12-19T13:21:52Z","closed_at":"2016-12-19T13:21:52Z","merged_at":"2016-12-19T13:21:52Z","merge_commit_sha":"b4e0b8a9f5d5867031bf9edb67250dd7b542e3a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/10834/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/10834/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/10834/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/243000fc85f3f161ff1f05bff51ff0deaed0d7eb","head":{"label":"BedeGaming:azurerm-nic-lb","ref":"azurerm-nic-lb","sha":"243000fc85f3f161ff1f05bff51ff0deaed0d7eb","user":{"login":"BedeGaming","id":1881183,"avatar_url":"https://avatars.githubusercontent.com/u/1881183?v=3","gravatar_id":"","url":"https://api.github.com/users/BedeGaming","html_url":"https://github.com/BedeGaming","followers_url":"https://api.github.com/users/BedeGaming/followers","following_url":"https://api.github.com/users/BedeGaming/following{/other_user}","gists_url":"https://api.github.com/users/BedeGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/BedeGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BedeGaming/subscriptions","organizations_url":"https://api.github.com/users/BedeGaming/orgs","repos_url":"https://api.github.com/users/BedeGaming/repos","events_url":"https://api.github.com/users/BedeGaming/events{/privacy}","received_events_url":"https://api.github.com/users/BedeGaming/received_events","type":"Organization","site_admin":false},"repo":{"id":62554026,"name":"terraform","full_name":"BedeGaming/terraform","owner":{"login":"BedeGaming","id":1881183,"avatar_url":"https://avatars.githubusercontent.com/u/1881183?v=3","gravatar_id":"","url":"https://api.github.com/users/BedeGaming","html_url":"https://github.com/BedeGaming","followers_url":"https://api.github.com/users/BedeGaming/followers","following_url":"https://api.github.com/users/BedeGaming/following{/other_user}","gists_url":"https://api.github.com/users/BedeGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/BedeGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BedeGaming/subscriptions","organizations_url":"https://api.github.com/users/BedeGaming/orgs","repos_url":"https://api.github.com/users/BedeGaming/repos","events_url":"https://api.github.com/users/BedeGaming/events{/privacy}","received_events_url":"https://api.github.com/users/BedeGaming/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BedeGaming/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":true,"url":"https://api.github.com/repos/BedeGaming/terraform","forks_url":"https://api.github.com/repos/BedeGaming/terraform/forks","keys_url":"https://api.github.com/repos/BedeGaming/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BedeGaming/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BedeGaming/terraform/teams","hooks_url":"https://api.github.com/repos/BedeGaming/terraform/hooks","issue_events_url":"https://api.github.com/repos/BedeGaming/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/BedeGaming/terraform/events","assignees_url":"https://api.github.com/repos/BedeGaming/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/BedeGaming/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/BedeGaming/terraform/tags","blobs_url":"https://api.github.com/repos/BedeGaming/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BedeGaming/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BedeGaming/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/BedeGaming/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BedeGaming/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/BedeGaming/terraform/languages","stargazers_url":"https://api.github.com/repos/BedeGaming/terraform/stargazers","contributors_url":"https://api.github.com/repos/BedeGaming/terraform/contributors","subscribers_url":"https://api.github.com/repos/BedeGaming/terraform/subscribers","subscription_url":"https://api.github.com/repos/BedeGaming/terraform/subscription","commits_url":"https://api.github.com/repos/BedeGaming/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/BedeGaming/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/BedeGaming/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/BedeGaming/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/BedeGaming/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/BedeGaming/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BedeGaming/terraform/merges","archive_url":"https://api.github.com/repos/BedeGaming/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BedeGaming/terraform/downloads","issues_url":"https://api.github.com/repos/BedeGaming/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/BedeGaming/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/BedeGaming/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/BedeGaming/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BedeGaming/terraform/labels{/name}","releases_url":"https://api.github.com/repos/BedeGaming/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/BedeGaming/terraform/deployments","created_at":"2016-07-04T10:31:22Z","updated_at":"2016-07-04T10:31:29Z","pushed_at":"2016-12-19T12:34:00Z","git_url":"git://github.com/BedeGaming/terraform.git","ssh_url":"git@github.com:BedeGaming/terraform.git","clone_url":"https://github.com/BedeGaming/terraform.git","svn_url":"https://github.com/BedeGaming/terraform","homepage":"https://www.terraform.io/","size":68531,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"504407c1cb329305a5734e48aeb28fdcdd6290ad","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform/deployments","created_at":"2014-03-13T22:25:48Z","updated_at":"2016-12-19T13:18:04Z","pushed_at":"2016-12-19T13:21:51Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"https://www.terraform.io/","size":69588,"stargazers_count":6526,"watchers_count":6526,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2319,"mirror_url":null,"open_issues_count":1546,"forks":2319,"open_issues":1546,"watchers":6526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/10834"},"html":{"href":"https://github.com/hashicorp/terraform/pull/10834"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/10834"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/10834/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/10834/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/10834/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/243000fc85f3f161ff1f05bff51ff0deaed0d7eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stack72","id":227823,"avatar_url":"https://avatars.githubusercontent.com/u/227823?v=3","gravatar_id":"","url":"https://api.github.com/users/stack72","html_url":"https://github.com/stack72","followers_url":"https://api.github.com/users/stack72/followers","following_url":"https://api.github.com/users/stack72/following{/other_user}","gists_url":"https://api.github.com/users/stack72/gists{/gist_id}","starred_url":"https://api.github.com/users/stack72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack72/subscriptions","organizations_url":"https://api.github.com/users/stack72/orgs","repos_url":"https://api.github.com/users/stack72/repos","events_url":"https://api.github.com/users/stack72/events{/privacy}","received_events_url":"https://api.github.com/users/stack72/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":156,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"stack72"}}