{"action":"closed","number":209,"pull_request":{"url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/209","id":80689839,"html_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/209","diff_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/209.diff","patch_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/209.patch","issue_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/209","number":209,"state":"closed","locked":false,"title":"Fix record discard/delete & subscribe race","user":{"login":"ronag","id":3065230,"avatar_url":"https://avatars.githubusercontent.com/u/3065230?v=3","gravatar_id":"","url":"https://api.github.com/users/ronag","html_url":"https://github.com/ronag","followers_url":"https://api.github.com/users/ronag/followers","following_url":"https://api.github.com/users/ronag/following{/other_user}","gists_url":"https://api.github.com/users/ronag/gists{/gist_id}","starred_url":"https://api.github.com/users/ronag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronag/subscriptions","organizations_url":"https://api.github.com/users/ronag/orgs","repos_url":"https://api.github.com/users/ronag/repos","events_url":"https://api.github.com/users/ronag/events{/privacy}","received_events_url":"https://api.github.com/users/ronag/received_events","type":"User","site_admin":false},"body":"This is my try at fixing the discard/delete and subscribe data-races. https://github.com/deepstreamIO/deepstream.io-client-js/issues/204\r\n\r\nThe basic idea is that the record can revive itself AFTER successful discard/delete, using the pending queue for the time between re-subscription and revival.\r\n\r\nThis ensures that there CAN BE ONLY ONE active record instance for the client avoiding the:\r\n\r\n```\r\nUNSOLICITED_MESSAGE\r\nUNSOLICITED_MESSAGE\r\nACK_TIMEOUT\r\nRESPONSE_TIMEOUT\r\nMULTIPLE_SUBSCRIBTIONS\r\n```\r\n\r\nerror cycle","created_at":"2016-08-09T20:35:53Z","updated_at":"2016-09-01T22:35:05Z","closed_at":"2016-09-01T22:35:05Z","merged_at":null,"merge_commit_sha":"7c296f5f73a77428c4e9673667b7d41a53c0db5e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/209/commits","review_comments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/209/comments","review_comment_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/209/comments","statuses_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/statuses/462440b7d0d1e70038606727dd01fe749e7e2385","head":{"label":"nxtedition:fix/#204","ref":"fix/#204","sha":"462440b7d0d1e70038606727dd01fe749e7e2385","user":{"login":"nxtedition","id":16840296,"avatar_url":"https://avatars.githubusercontent.com/u/16840296?v=3","gravatar_id":"","url":"https://api.github.com/users/nxtedition","html_url":"https://github.com/nxtedition","followers_url":"https://api.github.com/users/nxtedition/followers","following_url":"https://api.github.com/users/nxtedition/following{/other_user}","gists_url":"https://api.github.com/users/nxtedition/gists{/gist_id}","starred_url":"https://api.github.com/users/nxtedition/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nxtedition/subscriptions","organizations_url":"https://api.github.com/users/nxtedition/orgs","repos_url":"https://api.github.com/users/nxtedition/repos","events_url":"https://api.github.com/users/nxtedition/events{/privacy}","received_events_url":"https://api.github.com/users/nxtedition/received_events","type":"Organization","site_admin":false},"repo":{"id":60109021,"name":"deepstream.io-client-js","full_name":"nxtedition/deepstream.io-client-js","owner":{"login":"nxtedition","id":16840296,"avatar_url":"https://avatars.githubusercontent.com/u/16840296?v=3","gravatar_id":"","url":"https://api.github.com/users/nxtedition","html_url":"https://github.com/nxtedition","followers_url":"https://api.github.com/users/nxtedition/followers","following_url":"https://api.github.com/users/nxtedition/following{/other_user}","gists_url":"https://api.github.com/users/nxtedition/gists{/gist_id}","starred_url":"https://api.github.com/users/nxtedition/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nxtedition/subscriptions","organizations_url":"https://api.github.com/users/nxtedition/orgs","repos_url":"https://api.github.com/users/nxtedition/repos","events_url":"https://api.github.com/users/nxtedition/events{/privacy}","received_events_url":"https://api.github.com/users/nxtedition/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nxtedition/deepstream.io-client-js","description":"The Browser / Node Client for deepstream.io","fork":true,"url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js","forks_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/forks","keys_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/teams","hooks_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/hooks","issue_events_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/events","assignees_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/tags","blobs_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/languages","stargazers_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/stargazers","contributors_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/contributors","subscribers_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/subscribers","subscription_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/subscription","commits_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/merges","archive_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/downloads","issues_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/labels{/name}","releases_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/nxtedition/deepstream.io-client-js/deployments","created_at":"2016-05-31T17:18:52Z","updated_at":"2016-05-31T17:18:54Z","pushed_at":"2016-08-31T15:19:15Z","git_url":"git://github.com/nxtedition/deepstream.io-client-js.git","ssh_url":"git@github.com:nxtedition/deepstream.io-client-js.git","clone_url":"https://github.com/nxtedition/deepstream.io-client-js.git","svn_url":"https://github.com/nxtedition/deepstream.io-client-js","homepage":null,"size":1236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deepstreamIO:master","ref":"master","sha":"f8341becc7542bf0b3c08d2153e311e2b62d7227","user":{"login":"deepstreamIO","id":9024218,"avatar_url":"https://avatars.githubusercontent.com/u/9024218?v=3","gravatar_id":"","url":"https://api.github.com/users/deepstreamIO","html_url":"https://github.com/deepstreamIO","followers_url":"https://api.github.com/users/deepstreamIO/followers","following_url":"https://api.github.com/users/deepstreamIO/following{/other_user}","gists_url":"https://api.github.com/users/deepstreamIO/gists{/gist_id}","starred_url":"https://api.github.com/users/deepstreamIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepstreamIO/subscriptions","organizations_url":"https://api.github.com/users/deepstreamIO/orgs","repos_url":"https://api.github.com/users/deepstreamIO/repos","events_url":"https://api.github.com/users/deepstreamIO/events{/privacy}","received_events_url":"https://api.github.com/users/deepstreamIO/received_events","type":"Organization","site_admin":false},"repo":{"id":27365380,"name":"deepstream.io-client-js","full_name":"deepstreamIO/deepstream.io-client-js","owner":{"login":"deepstreamIO","id":9024218,"avatar_url":"https://avatars.githubusercontent.com/u/9024218?v=3","gravatar_id":"","url":"https://api.github.com/users/deepstreamIO","html_url":"https://github.com/deepstreamIO","followers_url":"https://api.github.com/users/deepstreamIO/followers","following_url":"https://api.github.com/users/deepstreamIO/following{/other_user}","gists_url":"https://api.github.com/users/deepstreamIO/gists{/gist_id}","starred_url":"https://api.github.com/users/deepstreamIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepstreamIO/subscriptions","organizations_url":"https://api.github.com/users/deepstreamIO/orgs","repos_url":"https://api.github.com/users/deepstreamIO/repos","events_url":"https://api.github.com/users/deepstreamIO/events{/privacy}","received_events_url":"https://api.github.com/users/deepstreamIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deepstreamIO/deepstream.io-client-js","description":"The Browser / Node.js Client for deepstream.io","fork":false,"url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js","forks_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/forks","keys_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/teams","hooks_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/hooks","issue_events_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/events","assignees_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/tags","blobs_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/languages","stargazers_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/stargazers","contributors_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/contributors","subscribers_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/subscribers","subscription_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/subscription","commits_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/merges","archive_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/downloads","issues_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/labels{/name}","releases_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/deployments","created_at":"2014-12-01T06:09:31Z","updated_at":"2016-08-25T16:17:24Z","pushed_at":"2016-08-31T15:59:00Z","git_url":"git://github.com/deepstreamIO/deepstream.io-client-js.git","ssh_url":"git@github.com:deepstreamIO/deepstream.io-client-js.git","clone_url":"https://github.com/deepstreamIO/deepstream.io-client-js.git","svn_url":"https://github.com/deepstreamIO/deepstream.io-client-js","homepage":"","size":1341,"stargazers_count":114,"watchers_count":114,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":37,"forks":24,"open_issues":37,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/209"},"html":{"href":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/209"},"issue":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/209"},"comments":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/statuses/462440b7d0d1e70038606727dd01fe749e7e2385"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":23,"review_comments":5,"commits":8,"additions":37,"deletions":68,"changed_files":4}}
{"actor":{"display_login":"ronag"}}