{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/4970","labels_url":"https://api.github.com/repos/nodejs/node/issues/4970/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4970/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/4970/events","html_url":"https://github.com/nodejs/node/pull/4970","id":129992481,"number":4970,"title":"test: refactor test-http-destroyed-socket-write2","user":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars.githubusercontent.com/u/1084056?v=3","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8"},{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-01-30T14:36:18Z","updated_at":"2016-01-30T22:18:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4970","html_url":"https://github.com/nodejs/node/pull/4970","diff_url":"https://github.com/nodejs/node/pull/4970.diff","patch_url":"https://github.com/nodejs/node/pull/4970.patch"},"body":"Remove the limit of requests to be sent (128) as in some conditions it\r\nwas reached without the `error` event being fired, causing the\r\ntest to fail.\r\nRemove the initial timeout.\r\nRemove some variables used to check the validity of the test and replace\r\nthem with `common.mustCall` and `common.fail` calls.\r\n\r\nThe error I was getting from time to time in `OS X` was:\r\n```\r\n=== release test-http-destroyed-socket-write2 ===                    \r\nPath: parallel/test-http-destroyed-socket-write2\r\nassert.js:89\r\n  throw new assert.AssertionError({\r\n  ^\r\nAssertionError: false == true\r\n    at test (/Users/sgimeno/node/node/test/parallel/test-http-destroyed-socket-write2.js:89:5)\r\n    at Immediate.write [as _onImmediate] (/Users/sgimeno/node/node/test/parallel/test-http-destroyed-socket-write2.js:29:7)\r\n    at processImmediate [as _immediateCallback] (timers.js:392:17)\r\nCommand: out/Release/node /Users/sgimeno/node/node/test/parallel/test-http-destroyed-socket-write2.js\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/177319531","html_url":"https://github.com/nodejs/node/pull/4970#issuecomment-177319531","issue_url":"https://api.github.com/repos/nodejs/node/issues/4970","id":177319531,"user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2016-01-30T22:18:37Z","updated_at":"2016-01-30T22:18:37Z","body":"I don't think we have AIX in CI yet.\r\n\r\nI kicked off a stress test on Windows 10. https://ci.nodejs.org/job/node-stress-single-test/395/nodes=win10/"}}