{"action":"created","issue":{"url":"https://api.github.com/repos/RetroShare/RetroShare/issues/495","repository_url":"https://api.github.com/repos/RetroShare/RetroShare","labels_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/495/labels{/name}","comments_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/495/comments","events_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/495/events","html_url":"https://github.com/RetroShare/RetroShare/pull/495","id":176457406,"number":495,"title":"Take advantage of C++11, document and clean RS multithreading","user":{"login":"G10h4ck","id":619500,"avatar_url":"https://avatars.githubusercontent.com/u/619500?v=3","gravatar_id":"","url":"https://api.github.com/users/G10h4ck","html_url":"https://github.com/G10h4ck","followers_url":"https://api.github.com/users/G10h4ck/followers","following_url":"https://api.github.com/users/G10h4ck/following{/other_user}","gists_url":"https://api.github.com/users/G10h4ck/gists{/gist_id}","starred_url":"https://api.github.com/users/G10h4ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G10h4ck/subscriptions","organizations_url":"https://api.github.com/users/G10h4ck/orgs","repos_url":"https://api.github.com/users/G10h4ck/repos","events_url":"https://api.github.com/users/G10h4ck/events{/privacy}","received_events_url":"https://api.github.com/users/G10h4ck/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RetroShare/RetroShare/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-12T19:04:49Z","updated_at":"2016-09-28T13:00:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RetroShare/RetroShare/pulls/495","html_url":"https://github.com/RetroShare/RetroShare/pull/495","diff_url":"https://github.com/RetroShare/RetroShare/pull/495.diff","patch_url":"https://github.com/RetroShare/RetroShare/pull/495.patch"},"body":"Please review and test on other platforms like Mac or Windows. According to my research this should work well on all platform (also older), but having it tested would be a plus :) \r\n\r\nA short changelog:\r\nRemoved antipattern abstraction RsSingleJobThread\r\nRename runloop() method to run() in RsThread\r\nPorted few classes ineriting from RsSingleJobThread to RsThread\r\npqiperson: fix misleading multithreading comment and includes\r\np3turtle: remove unused forward declaration\r\nRsThread fix includes\r\nProperly enable C++11 both for Qt4 and Qt5\r\nRsThread use std::atomic<bool> (supported since gcc-4.4) instead of self implemented strange binary semaphores\r\nRemoved RsTickingThread::shutdown() use RsThread::askForStop() instead\r\nRemoved RsTickingThread::fullstop() use RsThread::fullstop() instead"},"comment":{"url":"https://api.github.com/repos/RetroShare/RetroShare/issues/comments/250159500","html_url":"https://github.com/RetroShare/RetroShare/pull/495#issuecomment-250159500","issue_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/495","id":250159500,"user":{"login":"G10h4ck","id":619500,"avatar_url":"https://avatars.githubusercontent.com/u/619500?v=3","gravatar_id":"","url":"https://api.github.com/users/G10h4ck","html_url":"https://github.com/G10h4ck","followers_url":"https://api.github.com/users/G10h4ck/followers","following_url":"https://api.github.com/users/G10h4ck/following{/other_user}","gists_url":"https://api.github.com/users/G10h4ck/gists{/gist_id}","starred_url":"https://api.github.com/users/G10h4ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G10h4ck/subscriptions","organizations_url":"https://api.github.com/users/G10h4ck/orgs","repos_url":"https://api.github.com/users/G10h4ck/repos","events_url":"https://api.github.com/users/G10h4ck/events{/privacy}","received_events_url":"https://api.github.com/users/G10h4ck/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T13:00:43Z","updated_at":"2016-09-28T13:00:43Z","body":"What do you mean?\r\n\r\nIs CONFIG += c++11 responsible of the crash or it is that CONFIG += c++11 is missing in windows parts of .pro files?"}}
{"actor":{"display_login":"G10h4ck"}}