{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/node-convict/issues/165","repository_url":"https://api.github.com/repos/mozilla/node-convict","labels_url":"https://api.github.com/repos/mozilla/node-convict/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/node-convict/issues/165/comments","events_url":"https://api.github.com/repos/mozilla/node-convict/issues/165/events","html_url":"https://github.com/mozilla/node-convict/pull/165","id":178898847,"number":165,"title":"Speculative effort to support RegExp as a first-class format","user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-23T14:57:01Z","updated_at":"2016-09-27T16:07:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/node-convict/pulls/165","html_url":"https://github.com/mozilla/node-convict/pull/165","diff_url":"https://github.com/mozilla/node-convict/pull/165.diff","patch_url":"https://github.com/mozilla/node-convict/pull/165.patch"},"body":"Not sure whether this feature will be welcomed, and I also worry that I've interfered too much with other stuff in making it work.\r\n\r\nHowever, over in the FxA auth server, I'd like to both specify and get back parsed/instantiated `RegExp` objects from our config. Doing the specify bit was straightforward enough, but the getting-back part involved circumventing the explicit `JSON.stringify`-then-`JSON.parse` sanitization step that occurs before returning data.\r\n\r\nDoing that doesn't appear to break any tests, but maybe it would still be a breaking change for some usage that I haven't thought of.\r\n\r\nAnyway here's the change, offered more in hope than in expectation. I've added a test case for the new format and also run it against an [appropriately modified copy of the auth server config](https://github.com/mozilla/fxa-auth-server/blob/a4f59910bb8e3d52405553d2e243ba88299f402e/config/index.js#L491-L495).\r\n\r\nr?"},"comment":{"url":"https://api.github.com/repos/mozilla/node-convict/issues/comments/249913101","html_url":"https://github.com/mozilla/node-convict/pull/165#issuecomment-249913101","issue_url":"https://api.github.com/repos/mozilla/node-convict/issues/165","id":249913101,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T16:07:43Z","updated_at":"2016-09-27T16:07:43Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8074600/badge)](https://coveralls.io/builds/8074600)\n\nCoverage increased (+0.06%) to 92.771% when pulling **2e0ca73fd5c97c2d27a7aff4b1dbd2dd113d92a3 on philbooth/regexp-format** into **0b11e37897940efd8ee22539420b36abd727660a on master**.\n"}}
{"actor":{"display_login":"coveralls"}}