{"action":"created","issue":{"url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/17","repository_url":"https://api.github.com/repos/walkermatt/ol3-popup","labels_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/17/comments","events_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/17/events","html_url":"https://github.com/walkermatt/ol3-popup/issues/17","id":181980057,"number":17,"title":"possible contributions to ol3-popup","user":{"login":"eblondel","id":1324396,"avatar_url":"https://avatars.githubusercontent.com/u/1324396?v=3","gravatar_id":"","url":"https://api.github.com/users/eblondel","html_url":"https://github.com/eblondel","followers_url":"https://api.github.com/users/eblondel/followers","following_url":"https://api.github.com/users/eblondel/following{/other_user}","gists_url":"https://api.github.com/users/eblondel/gists{/gist_id}","starred_url":"https://api.github.com/users/eblondel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eblondel/subscriptions","organizations_url":"https://api.github.com/users/eblondel/orgs","repos_url":"https://api.github.com/users/eblondel/repos","events_url":"https://api.github.com/users/eblondel/events{/privacy}","received_events_url":"https://api.github.com/users/eblondel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-10T10:18:11Z","updated_at":"2016-10-25T18:25:02Z","closed_at":null,"body":"Hello, first of all many thank for this plugin, it helps a lot. We have been using your plugin in our project. However for some needs we had to extent it, successfully, on several aspects, that i here list below:\r\n\r\n\r\n* [x] Support for adding HTMLDivElement as part of content (not only a html string) - **#18** \r\n* [x] add utility method \"isOpened\" \r\n* [ ] Option for tooltip management (to make a tooltip overlay e.g. for vector layers)\r\n* [ ] a mechanism to optimize the popup position and arrow (e.g. at global level, when we open a popup, this one will \"stay\" above the map but displayed below instead of above the event location).\r\n\r\nWe would not like to let this as fork, but rather to contribute it. Let me know if you are interested, in which case i could do it as proper fork in github, and pull request to share with you.\r\n\r\nBest,\r\nEmmanuel\r\n"},"comment":{"url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/comments/256125315","html_url":"https://github.com/walkermatt/ol3-popup/issues/17#issuecomment-256125315","issue_url":"https://api.github.com/repos/walkermatt/ol3-popup/issues/17","id":256125315,"user":{"login":"eblondel","id":1324396,"avatar_url":"https://avatars.githubusercontent.com/u/1324396?v=3","gravatar_id":"","url":"https://api.github.com/users/eblondel","html_url":"https://github.com/eblondel","followers_url":"https://api.github.com/users/eblondel/followers","following_url":"https://api.github.com/users/eblondel/following{/other_user}","gists_url":"https://api.github.com/users/eblondel/gists{/gist_id}","starred_url":"https://api.github.com/users/eblondel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eblondel/subscriptions","organizations_url":"https://api.github.com/users/eblondel/orgs","repos_url":"https://api.github.com/users/eblondel/repos","events_url":"https://api.github.com/users/eblondel/events{/privacy}","received_events_url":"https://api.github.com/users/eblondel/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T18:25:02Z","updated_at":"2016-10-25T18:25:02Z","body":"To be clear, the ol-tooltip class is very similar to ol-popup.. smaller, \nwith a an arrow. and because it is a tooltip, there is no closer \nelement. That's all. And it aims to be triggered on map event.\n\nThere is no additional rule to decide where best to display. This is \nanother thing i did as /option/ to the popup (for a separate PR) that \nallows the popup to be either shown at bottom or top (at now it's fixed \non top) depending on where you are on the map and if there is enough \nspace to display the popup.\n\n\nLe 22/10/2016 à 08:56, Matt Walker a écrit :\n>\n> Using CSS classes sounds sensible. How are you positioning the \n> tooltip, are you paying the mouse coordinate and letting the tooltip \n> decide where best to display?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/walkermatt/ol3-popup/issues/17#issuecomment-255511715>, \n> or mute the thread \n> <https://github.com/notifications/unsubscribe-auth/ABQ1bKx80YZa6KYqnL1QGFCGt3bVGz8Fks5q2bOOgaJpZM4KSaiz>.\n>\n\n"}}
{"actor":{"display_login":"eblondel"}}