{"action":"created","issue":{"url":"https://api.github.com/repos/openprocurement/robot_tests/issues/353","repository_url":"https://api.github.com/repos/openprocurement/robot_tests","labels_url":"https://api.github.com/repos/openprocurement/robot_tests/issues/353/labels{/name}","comments_url":"https://api.github.com/repos/openprocurement/robot_tests/issues/353/comments","events_url":"https://api.github.com/repos/openprocurement/robot_tests/issues/353/events","html_url":"https://github.com/openprocurement/robot_tests/pull/353","id":185902483,"number":353,"title":"Add test cases to verify dateAnswered","user":{"login":"kosaniak","id":20128219,"avatar_url":"https://avatars.githubusercontent.com/u/20128219?v=3","gravatar_id":"","url":"https://api.github.com/users/kosaniak","html_url":"https://github.com/kosaniak","followers_url":"https://api.github.com/users/kosaniak/followers","following_url":"https://api.github.com/users/kosaniak/following{/other_user}","gists_url":"https://api.github.com/users/kosaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/kosaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kosaniak/subscriptions","organizations_url":"https://api.github.com/users/kosaniak/orgs","repos_url":"https://api.github.com/users/kosaniak/repos","events_url":"https://api.github.com/users/kosaniak/events{/privacy}","received_events_url":"https://api.github.com/users/kosaniak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-28T11:40:36Z","updated_at":"2016-10-31T18:04:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openprocurement/robot_tests/pulls/353","html_url":"https://github.com/openprocurement/robot_tests/pull/353","diff_url":"https://github.com/openprocurement/robot_tests/pull/353.diff","patch_url":"https://github.com/openprocurement/robot_tests/pull/353.patch"},"body":"<!-- Reviewable:start -->\n\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/openprocurement/robot_tests/353)\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/openprocurement/robot_tests/issues/comments/257371848","html_url":"https://github.com/openprocurement/robot_tests/pull/353#issuecomment-257371848","issue_url":"https://api.github.com/repos/openprocurement/robot_tests/issues/353","id":257371848,"user":{"login":"selurvedu","id":11262062,"avatar_url":"https://avatars.githubusercontent.com/u/11262062?v=3","gravatar_id":"","url":"https://api.github.com/users/selurvedu","html_url":"https://github.com/selurvedu","followers_url":"https://api.github.com/users/selurvedu/followers","following_url":"https://api.github.com/users/selurvedu/following{/other_user}","gists_url":"https://api.github.com/users/selurvedu/gists{/gist_id}","starred_url":"https://api.github.com/users/selurvedu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selurvedu/subscriptions","organizations_url":"https://api.github.com/users/selurvedu/orgs","repos_url":"https://api.github.com/users/selurvedu/repos","events_url":"https://api.github.com/users/selurvedu/events{/privacy}","received_events_url":"https://api.github.com/users/selurvedu/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T18:04:48Z","updated_at":"2016-10-31T18:04:48Z","body":"\n\n\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[op_robot_tests/tests_files/openProcedure.robot, line 747 at r1](https://reviewable.io:443/reviews/openprocurement/robot_tests/353#-KVN1-23zRQED4PLxJM7:-KVQplWp3tNnru_2TWhr:b-e6dqdw) ([raw file](https://github.com/openprocurement/robot_tests/blob/189dec0bdfbe41461201a5922c28b2cf9563c89b/op_robot_tests/tests_files/openProcedure.robot#L747)):*\n<details><summary><i>Previously, mykhaly (Yurii Mykhalchuk) wrote…</i></summary>\n> 1) Таким чином не відбудеться перевірки, чи дата відображається правильно. Пропоную зберегти локально дату подання відповіді і при перевірці порівнювати зчитану дату зі збереженою з якоюсь точністю (+-1 хвилина або період синхронізації майданчика).\n> 2) І по ходу очікувати на синхронізацію з майданчиком тут немає потреби, бо цей тесткейс завжди буде йти після попереднього, в якому та синхронізація вже відбулася.\n</details>\n1) Скоріше варіант з \"період синхронізації майданчика\", але так, щоб дельта (`delta = server_date - local_date`) була не меншою за нуль, і не більшою за період синхронізації майданчика (`0 ≤ delta ≤ timeout_on_wait`).\n\nBTW, для цього, мабуть, в `compare_date` (`service_keywords.py, L68`) треба поміняти рядок `delta = (left - right).total_seconds()` на `delta = (right - left).total_seconds()`, бо зліва в нас завжди локальна дата, і тоді виклика́ти `compare_date` з аргументом `absolute_delta=False` (лише для цих тесткейсів з `dateAnswered`).\n\nBTW, можна і такий варіант: `-60 ≤ delta ≤ timeout_on_wait`. @mykhaly, як тобі?\n\n2) Може й так, тут і нижче, але є одне але. Якщо якісь тесткейси будуть виключені/не включені, то воно стає потрібним, і не тільки тут. Очікувати більше ніж треба воно все одно не буде завдяки `${LAST_MODIFICATION_DATE}`.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/openprocurement/robot_tests/353)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"selurvedu"}}