{"action":"created","issue":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/1985","repository_url":"https://api.github.com/repos/NativeScript/nativescript-cli","labels_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/1985/labels{/name}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/1985/comments","events_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/1985/events","html_url":"https://github.com/NativeScript/nativescript-cli/pull/1985","id":169932039,"number":1985,"title":"Fixed: Livesync+Debug on Android not working when there are changes in tns-core-modules","user":{"login":"tzraikov","id":3244426,"avatar_url":"https://avatars.githubusercontent.com/u/3244426?v=3","gravatar_id":"","url":"https://api.github.com/users/tzraikov","html_url":"https://github.com/tzraikov","followers_url":"https://api.github.com/users/tzraikov/followers","following_url":"https://api.github.com/users/tzraikov/following{/other_user}","gists_url":"https://api.github.com/users/tzraikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzraikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzraikov/subscriptions","organizations_url":"https://api.github.com/users/tzraikov/orgs","repos_url":"https://api.github.com/users/tzraikov/repos","events_url":"https://api.github.com/users/tzraikov/events{/privacy}","received_events_url":"https://api.github.com/users/tzraikov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-08T14:06:53Z","updated_at":"2016-08-09T14:42:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/pulls/1985","html_url":"https://github.com/NativeScript/nativescript-cli/pull/1985","diff_url":"https://github.com/NativeScript/nativescript-cli/pull/1985.diff","patch_url":"https://github.com/NativeScript/nativescript-cli/pull/1985.patch"},"body":"## The issue:\r\n\r\n1. Create a new {N} project.\r\n2. Open it in Visual Studio Code. Run debug with \"Sync on Android\". This will start livesync and then debug.\r\n3. Make a change in tns-core-modules. \r\n4. Run \"Sync on Android\" again. It will fail. This happens because the prepareProject called by livesync service will clean the android build folder with all apks. It is required by the debug service that is called after livesync.\r\n\r\n## Proposal:\r\n\r\nIn that situation we change only the js file and therefore it is not necessary to clean the whole build folder.  We could check whether the change is in platforms folder of particular module.  It so, we should clean the project. If not, it is safe to skip the clean process. "},"comment":{"url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/comments/238575144","html_url":"https://github.com/NativeScript/nativescript-cli/pull/1985#issuecomment-238575144","issue_url":"https://api.github.com/repos/NativeScript/nativescript-cli/issues/1985","id":238575144,"user":{"login":"tzraikov","id":3244426,"avatar_url":"https://avatars.githubusercontent.com/u/3244426?v=3","gravatar_id":"","url":"https://api.github.com/users/tzraikov","html_url":"https://github.com/tzraikov","followers_url":"https://api.github.com/users/tzraikov/followers","following_url":"https://api.github.com/users/tzraikov/following{/other_user}","gists_url":"https://api.github.com/users/tzraikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzraikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzraikov/subscriptions","organizations_url":"https://api.github.com/users/tzraikov/orgs","repos_url":"https://api.github.com/users/tzraikov/repos","events_url":"https://api.github.com/users/tzraikov/events{/privacy}","received_events_url":"https://api.github.com/users/tzraikov/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T14:42:18Z","updated_at":"2016-08-09T14:42:18Z","body":"@Plamen5kov \r\nYes, as a general suggestion.. tests should be added. However, I don't see a single test related with livesync or debug functionality in our code. Does anyone have an idea how to test those features?"}}
{"actor":{"display_login":"tzraikov"}}