{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/53921394","id":53921394,"diff_hunk":"@@ -524,7 +525,7 @@ public function resolveCallableDependencies(callable $callback, $params = [])\n                     unset($params[$name]);\n                 } elseif (!$associative && isset($params[0]) && $params[0] instanceof $className) {\n                     $args[] = array_shift($params);\n-                } elseif (Yii::$app->has($name) && ($obj = Yii::$app->get($name)) instanceof $className) {\n+                } elseif (Yii::$app instanceof ServiceLocator && Yii::$app->has($name) && ($obj = Yii::$app->get($name)) instanceof $className) {","path":"framework/di/Container.php","position":13,"original_position":13,"commit_id":"46cf13362ba2177aac20e65d99d4eaf110ddeb19","original_commit_id":"46cf13362ba2177aac20e65d99d4eaf110ddeb19","user":{"login":"samdark","id":47294,"avatar_url":"https://avatars.githubusercontent.com/u/47294?v=3","gravatar_id":"","url":"https://api.github.com/users/samdark","html_url":"https://github.com/samdark","followers_url":"https://api.github.com/users/samdark/followers","following_url":"https://api.github.com/users/samdark/following{/other_user}","gists_url":"https://api.github.com/users/samdark/gists{/gist_id}","starred_url":"https://api.github.com/users/samdark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdark/subscriptions","organizations_url":"https://api.github.com/users/samdark/orgs","repos_url":"https://api.github.com/users/samdark/repos","events_url":"https://api.github.com/users/samdark/events{/privacy}","received_events_url":"https://api.github.com/users/samdark/received_events","type":"User","site_admin":false},"body":"If `\\Yii::$app` would hold non-application you'll notice it immediately since nothing would work at all.","created_at":"2016-02-24T10:46:58Z","updated_at":"2016-02-24T10:46:58Z","html_url":"https://github.com/yiisoft/yii2/pull/10931#discussion_r53921394","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/10931","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/53921394"},"html":{"href":"https://github.com/yiisoft/yii2/pull/10931#discussion_r53921394"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10931"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/10931","id":60145533,"html_url":"https://github.com/yiisoft/yii2/pull/10931","diff_url":"https://github.com/yiisoft/yii2/pull/10931.diff","patch_url":"https://github.com/yiisoft/yii2/pull/10931.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/10931","number":10931,"state":"open","locked":false,"title":"Implementation for #10908","user":{"login":"SamMousa","id":547021,"avatar_url":"https://avatars.githubusercontent.com/u/547021?v=3","gravatar_id":"","url":"https://api.github.com/users/SamMousa","html_url":"https://github.com/SamMousa","followers_url":"https://api.github.com/users/SamMousa/followers","following_url":"https://api.github.com/users/SamMousa/following{/other_user}","gists_url":"https://api.github.com/users/SamMousa/gists{/gist_id}","starred_url":"https://api.github.com/users/SamMousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamMousa/subscriptions","organizations_url":"https://api.github.com/users/SamMousa/orgs","repos_url":"https://api.github.com/users/SamMousa/repos","events_url":"https://api.github.com/users/SamMousa/events{/privacy}","received_events_url":"https://api.github.com/users/SamMousa/received_events","type":"User","site_admin":false},"body":"- Implemented DI for callable component configuration.\r\n- Removed dependency on `Yii::$app` from `\\Yii\\Di\\Container`.","created_at":"2016-02-22T09:32:09Z","updated_at":"2016-02-24T10:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dce7291668b11cfa8a23da38b5a14353e2cb8a93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/10931/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/10931/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/10931/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/46cf13362ba2177aac20e65d99d4eaf110ddeb19","head":{"label":"SamMousa:feature-invoke-callable-config","ref":"feature-invoke-callable-config","sha":"46cf13362ba2177aac20e65d99d4eaf110ddeb19","user":{"login":"SamMousa","id":547021,"avatar_url":"https://avatars.githubusercontent.com/u/547021?v=3","gravatar_id":"","url":"https://api.github.com/users/SamMousa","html_url":"https://github.com/SamMousa","followers_url":"https://api.github.com/users/SamMousa/followers","following_url":"https://api.github.com/users/SamMousa/following{/other_user}","gists_url":"https://api.github.com/users/SamMousa/gists{/gist_id}","starred_url":"https://api.github.com/users/SamMousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamMousa/subscriptions","organizations_url":"https://api.github.com/users/SamMousa/orgs","repos_url":"https://api.github.com/users/SamMousa/repos","events_url":"https://api.github.com/users/SamMousa/events{/privacy}","received_events_url":"https://api.github.com/users/SamMousa/received_events","type":"User","site_admin":false},"repo":{"id":31261382,"name":"yii2","full_name":"SamMousa/yii2","owner":{"login":"SamMousa","id":547021,"avatar_url":"https://avatars.githubusercontent.com/u/547021?v=3","gravatar_id":"","url":"https://api.github.com/users/SamMousa","html_url":"https://github.com/SamMousa","followers_url":"https://api.github.com/users/SamMousa/followers","following_url":"https://api.github.com/users/SamMousa/following{/other_user}","gists_url":"https://api.github.com/users/SamMousa/gists{/gist_id}","starred_url":"https://api.github.com/users/SamMousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamMousa/subscriptions","organizations_url":"https://api.github.com/users/SamMousa/orgs","repos_url":"https://api.github.com/users/SamMousa/repos","events_url":"https://api.github.com/users/SamMousa/events{/privacy}","received_events_url":"https://api.github.com/users/SamMousa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamMousa/yii2","description":"Yii 2 framework main development repo","fork":true,"url":"https://api.github.com/repos/SamMousa/yii2","forks_url":"https://api.github.com/repos/SamMousa/yii2/forks","keys_url":"https://api.github.com/repos/SamMousa/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamMousa/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamMousa/yii2/teams","hooks_url":"https://api.github.com/repos/SamMousa/yii2/hooks","issue_events_url":"https://api.github.com/repos/SamMousa/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/SamMousa/yii2/events","assignees_url":"https://api.github.com/repos/SamMousa/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/SamMousa/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/SamMousa/yii2/tags","blobs_url":"https://api.github.com/repos/SamMousa/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamMousa/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamMousa/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamMousa/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamMousa/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/SamMousa/yii2/languages","stargazers_url":"https://api.github.com/repos/SamMousa/yii2/stargazers","contributors_url":"https://api.github.com/repos/SamMousa/yii2/contributors","subscribers_url":"https://api.github.com/repos/SamMousa/yii2/subscribers","subscription_url":"https://api.github.com/repos/SamMousa/yii2/subscription","commits_url":"https://api.github.com/repos/SamMousa/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamMousa/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamMousa/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamMousa/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamMousa/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/SamMousa/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamMousa/yii2/merges","archive_url":"https://api.github.com/repos/SamMousa/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamMousa/yii2/downloads","issues_url":"https://api.github.com/repos/SamMousa/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/SamMousa/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/SamMousa/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/SamMousa/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamMousa/yii2/labels{/name}","releases_url":"https://api.github.com/repos/SamMousa/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/SamMousa/yii2/deployments","created_at":"2015-02-24T13:32:17Z","updated_at":"2016-02-03T12:45:17Z","pushed_at":"2016-02-22T09:35:35Z","git_url":"git://github.com/SamMousa/yii2.git","ssh_url":"git@github.com:SamMousa/yii2.git","clone_url":"https://github.com/SamMousa/yii2.git","svn_url":"https://github.com/SamMousa/yii2","homepage":"http://www.yiiframework.com","size":39249,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"9bffbf8e49b2351419d13b6172d20040a80cb6d0","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2 framework main development repo","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2016-02-24T09:18:41Z","pushed_at":"2016-02-24T09:58:42Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":47775,"stargazers_count":7600,"watchers_count":7600,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4455,"mirror_url":null,"open_issues_count":1009,"forks":4455,"open_issues":1009,"watchers":7600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10931"},"html":{"href":"https://github.com/yiisoft/yii2/pull/10931"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/10931"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/10931/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10931/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10931/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/46cf13362ba2177aac20e65d99d4eaf110ddeb19"}}}}