{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/672","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/672/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/672/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/672/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/672","id":157208425,"number":672,"title":"fix(ui): fix datagrid blank out afyter morph","user":{"login":"jolevesq","id":3472990,"avatar_url":"https://avatars.githubusercontent.com/u/3472990?v=3","gravatar_id":"","url":"https://api.github.com/users/jolevesq","html_url":"https://github.com/jolevesq","followers_url":"https://api.github.com/users/jolevesq/followers","following_url":"https://api.github.com/users/jolevesq/following{/other_user}","gists_url":"https://api.github.com/users/jolevesq/gists{/gist_id}","starred_url":"https://api.github.com/users/jolevesq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolevesq/subscriptions","organizations_url":"https://api.github.com/users/jolevesq/orgs","repos_url":"https://api.github.com/users/jolevesq/repos","events_url":"https://api.github.com/users/jolevesq/events{/privacy}","received_events_url":"https://api.github.com/users/jolevesq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-27T13:37:14Z","updated_at":"2016-05-27T15:54:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/672","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/672","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/672.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/672.patch"},"body":"Closes #372\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/672)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/222183945","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/672#issuecomment-222183945","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/672","id":222183945,"user":{"login":"jolevesq","id":3472990,"avatar_url":"https://avatars.githubusercontent.com/u/3472990?v=3","gravatar_id":"","url":"https://api.github.com/users/jolevesq","html_url":"https://github.com/jolevesq","followers_url":"https://api.github.com/users/jolevesq/followers","following_url":"https://api.github.com/users/jolevesq/following{/other_user}","gists_url":"https://api.github.com/users/jolevesq/gists{/gist_id}","starred_url":"https://api.github.com/users/jolevesq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolevesq/subscriptions","organizations_url":"https://api.github.com/users/jolevesq/orgs","repos_url":"https://api.github.com/users/jolevesq/repos","events_url":"https://api.github.com/users/jolevesq/events{/privacy}","received_events_url":"https://api.github.com/users/jolevesq/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T15:54:46Z","updated_at":"2016-05-27T15:54:46Z","body":"\n\n\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/app/ui/filters/filters-default.directive.js, line 307 \\[r1\\]](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/672#-KImhwEuuGBCfeWUNQXK:-KImuiAGEM3bYey8Zmuv:-1042741412) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/0060ecb7fdd4dea08416d2744fac335417c8addc/src/app/ui/filters/filters-default.directive.js#L307)):*\n<details><summary><i>Previously, AleksueiR (Aleksuei Riabtsev) wrote…</i></summary>\n> This can potentially break if the class name changes or datatables changes how they structure the info line. I looked through their API and there doesn't seem to be a good way to actually edit the info line, so I don't think there is a better way.\n</details>\nI agree, I search a while to find a better way but no luck\n\n---\n\n*[src/app/ui/filters/filters-default.directive.js, line 308 \\[r1\\]](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/672#-KImjy9pqrpbnaZlqKiW:-KImv0Cmvx1_-_oavOVK:312694991) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/0060ecb7fdd4dea08416d2744fac335417c8addc/src/app/ui/filters/filters-default.directive.js#L308)):*\n<details><summary><i>Previously, AleksueiR (Aleksuei Riabtsev) wrote…</i></summary>\n> Both `let`s can be `const`s.\n</details>\nShould i use let when I modify the value and const when I dont?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/672)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jolevesq"}}