{"action":"created","issue":{"url":"https://api.github.com/repos/danger/danger/issues/599","repository_url":"https://api.github.com/repos/danger/danger","labels_url":"https://api.github.com/repos/danger/danger/issues/599/labels{/name}","comments_url":"https://api.github.com/repos/danger/danger/issues/599/comments","events_url":"https://api.github.com/repos/danger/danger/issues/599/events","html_url":"https://github.com/danger/danger/pull/599","id":180015954,"number":599,"title":"Patch/environment manager specs","user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-29T10:52:24Z","updated_at":"2016-09-30T01:14:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/danger/danger/pulls/599","html_url":"https://github.com/danger/danger/pull/599","diff_url":"https://github.com/danger/danger/pull/599.diff","patch_url":"https://github.com/danger/danger/pull/599.patch"},"body":"This PR adds some tests for `EnvironmentManager` class.\r\n\r\nSpecs just quit exceptionally by RSpec JUnit Formatter:\r\n\r\n```\r\n$ bundle exec rspec spec/lib/danger/danger_core/environment_manager_spec.rb:176\r\n\r\nbundler: failed to load command: rspec (/Users/Juan/.gem/ruby/2.2.5/bin/rspec)\r\nNoMethodError: undefined method `xml_dump_' for #<RSpecJUnitFormatter:0x007ff9011e44a0>\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec_junit_formatter-0.2.3/lib/rspec_junit_formatter.rb:29:in `block in xml_dump_examples'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec_junit_formatter-0.2.3/lib/rspec_junit_formatter.rb:28:in `each'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec_junit_formatter-0.2.3/lib/rspec_junit_formatter.rb:28:in `xml_dump_examples'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec_junit_formatter-0.2.3/lib/rspec_junit_formatter.rb:23:in `block in xml_dump'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/builder-3.2.2/lib/builder/xmlbase.rb:175:in `call'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/builder-3.2.2/lib/builder/xmlbase.rb:175:in `_nested_structures'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/builder-3.2.2/lib/builder/xmlbase.rb:68:in `tag!'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/builder-3.2.2/lib/builder/xmlbase.rb:93:in `method_missing'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec_junit_formatter-0.2.3/lib/rspec_junit_formatter.rb:20:in `xml_dump'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec_junit_formatter-0.2.3/lib/rspec_junit_formatter/rspec3.rb:19:in `dump_summary'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:201:in `block in notify'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:200:in `each'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:200:in `notify'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:179:in `block in finish'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:187:in `close_after'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:168:in `finish'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:79:in `ensure in report'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/reporter.rb:79:in `report'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/runner.rb:111:in `run_specs'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/runner.rb:87:in `run'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/runner.rb:71:in `run'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/lib/rspec/core/runner.rb:45:in `invoke'\r\n  /Users/Juan/.gem/ruby/2.2.5/gems/rspec-core-3.5.3/exe/rspec:4:in `<top (required)>'\r\n  /Users/Juan/.gem/ruby/2.2.5/bin/rspec:23:in `load'\r\n  /Users/Juan/.gem/ruby/2.2.5/bin/rspec:23:in `<top (required)>'\r\nCoverage report generated for RSpec to /Users/Juan/dev/danger/coverage. 877 / 2384 LOC (36.79%) covered.\r\n```\r\n\r\nI cannot run the specs `¯\\_(ツ)_/¯`..."},"comment":{"url":"https://api.github.com/repos/danger/danger/issues/comments/250634840","html_url":"https://github.com/danger/danger/pull/599#issuecomment-250634840","issue_url":"https://api.github.com/repos/danger/danger/issues/599","id":250634840,"user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T01:14:49Z","updated_at":"2016-09-30T01:14:49Z","body":"> Ouch! - I wonder if we could do something around that\r\n\r\nMaybe we can raises an error when `reqeust_source` cannot be attained. Later PR?\r\n\r\n> Maybe there's another way to exit, other than exit? :D\r\n\r\nActually, all methods (fail, raise, abort), uses `exit` under the hood. So the problem is mainly I'm not familiar with the test setup. This PR is good to merge."}}
{"actor":{"display_login":"JuanitoFatas"}}