{"action":"created","issue":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos/issues/43","repository_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos","labels_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos/issues/43/comments","events_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos/issues/43/events","html_url":"https://github.com/intelsdi-x/snap-plugin-collector-mesos/pull/43","id":197414418,"number":43,"title":"New plugin api, new ideas","user":{"login":"evilezh","id":5277173,"avatar_url":"https://avatars.githubusercontent.com/u/5277173?v=3","gravatar_id":"","url":"https://api.github.com/users/evilezh","html_url":"https://github.com/evilezh","followers_url":"https://api.github.com/users/evilezh/followers","following_url":"https://api.github.com/users/evilezh/following{/other_user}","gists_url":"https://api.github.com/users/evilezh/gists{/gist_id}","starred_url":"https://api.github.com/users/evilezh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilezh/subscriptions","organizations_url":"https://api.github.com/users/evilezh/orgs","repos_url":"https://api.github.com/users/evilezh/repos","events_url":"https://api.github.com/users/evilezh/events{/privacy}","received_events_url":"https://api.github.com/users/evilezh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-23T19:02:07Z","updated_at":"2016-12-30T19:00:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos/pulls/43","html_url":"https://github.com/intelsdi-x/snap-plugin-collector-mesos/pull/43","diff_url":"https://github.com/intelsdi-x/snap-plugin-collector-mesos/pull/43.diff","patch_url":"https://github.com/intelsdi-x/snap-plugin-collector-mesos/pull/43.patch"},"body":"I did cancel my previous pull request as it would require too many patches and workarounds to make it work at all.\r\n\r\nThis uses new API.\r\nSeveral additional issues was addressed:\r\n- plugin can be loaded any time (before or after mesos-master/agent)\r\n- no need to trigger plugin reload on master change\r\n- it will give any metrics available at any time (not only on plugin load)\r\n- endpoints are now configurable via TASK rather than global configuration of Snap itself\r\n\r\nAs I drop all dynamic namespace/static idea, code becomes much simpler. My main goal was to provide something what works in all cases without extra overhead.\r\n\r\nThis is first version of how I see it. Code needs to remove absolute/not used parts, maybe a bit some optimisation there and here.\r\n\r\nIf you have a time or wish - try it out. I only tested on local mesos master. Will shortly deploy on infra and will see how it goes. \r\n\r\nAs plugin is missing filtering options, I plan to add extra variable in config where people can configure regex, to filter metrics they want or not. We can do either inclusive or exclusive filtering.\r\n\r\nThis should cancel some issues as well. \r\n\r\nI will be able to test on mesos 1.1.0. If someone can do on older version, would be great.\r\n\r\n\r\nAs for writing tests question - I would be very happy if someone else could do that."},"comment":{"url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos/issues/comments/269808936","html_url":"https://github.com/intelsdi-x/snap-plugin-collector-mesos/pull/43#issuecomment-269808936","issue_url":"https://api.github.com/repos/intelsdi-x/snap-plugin-collector-mesos/issues/43","id":269808936,"user":{"login":"evilezh","id":5277173,"avatar_url":"https://avatars.githubusercontent.com/u/5277173?v=3","gravatar_id":"","url":"https://api.github.com/users/evilezh","html_url":"https://github.com/evilezh","followers_url":"https://api.github.com/users/evilezh/followers","following_url":"https://api.github.com/users/evilezh/following{/other_user}","gists_url":"https://api.github.com/users/evilezh/gists{/gist_id}","starred_url":"https://api.github.com/users/evilezh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilezh/subscriptions","organizations_url":"https://api.github.com/users/evilezh/orgs","repos_url":"https://api.github.com/users/evilezh/repos","events_url":"https://api.github.com/users/evilezh/events{/privacy}","received_events_url":"https://api.github.com/users/evilezh/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T19:00:33Z","updated_at":"2016-12-30T19:00:33Z","body":"Added new option `resolve_local_ips`, by default it is enabled.\r\nUsage scenario: \r\nCurrent master detection uses host name we specified in configuration e.g. if i do localhost:5050 for connection, then it will work only if running mesos in local mode. For example, if master redirects to 10.10.10.10 (which is one of our interfaces) - it will not match localhost. with `resolve_local_ips` enabled, leader detection will scan for local ip's on all interfaces and will try to match them as well. That allows to use localhost:5050 for connection without specifying exact interface ip. "}}
{"actor":{"display_login":"evilezh"}}