{"action":"created","comment":{"url":"https://api.github.com/repos/fortressforever/fortressforever/pulls/comments/70002511","id":70002511,"diff_hunk":"@@ -8034,9 +8034,13 @@ void CFFPlayer::UpdateCamera( bool bUnassigned )\n // purpose: update our vector of recent attackers for kill assists\r\n void CFFPlayer::AddRecentAttacker( const CTakeDamageInfo &dmgInfo )\r\n {\r\n-\tCFFPlayer *pAttacker = ToFFPlayer( dmgInfo.GetAttacker() );\r\n+\t// make sure to get the effective scorer incase dmg is from\r\n+\t// a buildable - det, sg, disp, etc\r\n+\tCFFPlayer *pAttacker = ToFFPlayer(dynamic_cast<CMultiplayRules *>(g_pGameRules)->GetDeathScorer( dmgInfo.GetAttacker(), dmgInfo.GetInflictor() ));\r","path":"dlls/ff/ff_player.cpp","position":null,"original_position":7,"commit_id":"f0707b5abcf9bc10c05e10f04f85b756c5589ade","original_commit_id":"f0707b5abcf9bc10c05e10f04f85b756c5589ade","user":{"login":"DexterHaslem","id":370456,"avatar_url":"https://avatars.githubusercontent.com/u/370456?v=3","gravatar_id":"","url":"https://api.github.com/users/DexterHaslem","html_url":"https://github.com/DexterHaslem","followers_url":"https://api.github.com/users/DexterHaslem/followers","following_url":"https://api.github.com/users/DexterHaslem/following{/other_user}","gists_url":"https://api.github.com/users/DexterHaslem/gists{/gist_id}","starred_url":"https://api.github.com/users/DexterHaslem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DexterHaslem/subscriptions","organizations_url":"https://api.github.com/users/DexterHaslem/orgs","repos_url":"https://api.github.com/users/DexterHaslem/repos","events_url":"https://api.github.com/users/DexterHaslem/events{/privacy}","received_events_url":"https://api.github.com/users/DexterHaslem/received_events","type":"User","site_admin":false},"body":"actually,  I was surprised, downcast is needed here\r\n`error C2039: 'GetDeathScorer' : is not a member of 'CGameRules'`","created_at":"2016-07-07T22:59:34Z","updated_at":"2016-07-07T22:59:34Z","html_url":"https://github.com/fortressforever/fortressforever/pull/288#discussion_r70002511","pull_request_url":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/fortressforever/fortressforever/pulls/comments/70002511"},"html":{"href":"https://github.com/fortressforever/fortressforever/pull/288#discussion_r70002511"},"pull_request":{"href":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288","id":76079190,"html_url":"https://github.com/fortressforever/fortressforever/pull/288","diff_url":"https://github.com/fortressforever/fortressforever/pull/288.diff","patch_url":"https://github.com/fortressforever/fortressforever/pull/288.patch","issue_url":"https://api.github.com/repos/fortressforever/fortressforever/issues/288","number":288,"state":"open","locked":false,"title":"Feature/kill assists","user":{"login":"DexterHaslem","id":370456,"avatar_url":"https://avatars.githubusercontent.com/u/370456?v=3","gravatar_id":"","url":"https://api.github.com/users/DexterHaslem","html_url":"https://github.com/DexterHaslem","followers_url":"https://api.github.com/users/DexterHaslem/followers","following_url":"https://api.github.com/users/DexterHaslem/following{/other_user}","gists_url":"https://api.github.com/users/DexterHaslem/gists{/gist_id}","starred_url":"https://api.github.com/users/DexterHaslem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DexterHaslem/subscriptions","organizations_url":"https://api.github.com/users/DexterHaslem/orgs","repos_url":"https://api.github.com/users/DexterHaslem/repos","events_url":"https://api.github.com/users/DexterHaslem/events{/privacy}","received_events_url":"https://api.github.com/users/DexterHaslem/received_events","type":"User","site_admin":false},"body":"soliciting feedback on first pass kill assist. things that have come up:\r\n\r\ncheck damage coming from buildables like sentry, det explosion, etc. - consider GetDeathScorer if needed\r\n\r\ndeath notice alignment is completely screwed up","created_at":"2016-07-03T02:28:31Z","updated_at":"2016-07-07T22:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a70bd4ad749d02901d0f22d86b6e24845f577ab","assignee":{"login":"DexterHaslem","id":370456,"avatar_url":"https://avatars.githubusercontent.com/u/370456?v=3","gravatar_id":"","url":"https://api.github.com/users/DexterHaslem","html_url":"https://github.com/DexterHaslem","followers_url":"https://api.github.com/users/DexterHaslem/followers","following_url":"https://api.github.com/users/DexterHaslem/following{/other_user}","gists_url":"https://api.github.com/users/DexterHaslem/gists{/gist_id}","starred_url":"https://api.github.com/users/DexterHaslem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DexterHaslem/subscriptions","organizations_url":"https://api.github.com/users/DexterHaslem/orgs","repos_url":"https://api.github.com/users/DexterHaslem/repos","events_url":"https://api.github.com/users/DexterHaslem/events{/privacy}","received_events_url":"https://api.github.com/users/DexterHaslem/received_events","type":"User","site_admin":false},"assignees":[{"login":"DexterHaslem","id":370456,"avatar_url":"https://avatars.githubusercontent.com/u/370456?v=3","gravatar_id":"","url":"https://api.github.com/users/DexterHaslem","html_url":"https://github.com/DexterHaslem","followers_url":"https://api.github.com/users/DexterHaslem/followers","following_url":"https://api.github.com/users/DexterHaslem/following{/other_user}","gists_url":"https://api.github.com/users/DexterHaslem/gists{/gist_id}","starred_url":"https://api.github.com/users/DexterHaslem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DexterHaslem/subscriptions","organizations_url":"https://api.github.com/users/DexterHaslem/orgs","repos_url":"https://api.github.com/users/DexterHaslem/repos","events_url":"https://api.github.com/users/DexterHaslem/events{/privacy}","received_events_url":"https://api.github.com/users/DexterHaslem/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288/commits","review_comments_url":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288/comments","review_comment_url":"https://api.github.com/repos/fortressforever/fortressforever/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fortressforever/fortressforever/issues/288/comments","statuses_url":"https://api.github.com/repos/fortressforever/fortressforever/statuses/f0707b5abcf9bc10c05e10f04f85b756c5589ade","head":{"label":"fortressforever:feature/kill-assists","ref":"feature/kill-assists","sha":"f0707b5abcf9bc10c05e10f04f85b756c5589ade","user":{"login":"fortressforever","id":2388970,"avatar_url":"https://avatars.githubusercontent.com/u/2388970?v=3","gravatar_id":"","url":"https://api.github.com/users/fortressforever","html_url":"https://github.com/fortressforever","followers_url":"https://api.github.com/users/fortressforever/followers","following_url":"https://api.github.com/users/fortressforever/following{/other_user}","gists_url":"https://api.github.com/users/fortressforever/gists{/gist_id}","starred_url":"https://api.github.com/users/fortressforever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortressforever/subscriptions","organizations_url":"https://api.github.com/users/fortressforever/orgs","repos_url":"https://api.github.com/users/fortressforever/repos","events_url":"https://api.github.com/users/fortressforever/events{/privacy}","received_events_url":"https://api.github.com/users/fortressforever/received_events","type":"Organization","site_admin":false},"repo":{"id":25147931,"name":"fortressforever","full_name":"fortressforever/fortressforever","owner":{"login":"fortressforever","id":2388970,"avatar_url":"https://avatars.githubusercontent.com/u/2388970?v=3","gravatar_id":"","url":"https://api.github.com/users/fortressforever","html_url":"https://github.com/fortressforever","followers_url":"https://api.github.com/users/fortressforever/followers","following_url":"https://api.github.com/users/fortressforever/following{/other_user}","gists_url":"https://api.github.com/users/fortressforever/gists{/gist_id}","starred_url":"https://api.github.com/users/fortressforever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortressforever/subscriptions","organizations_url":"https://api.github.com/users/fortressforever/orgs","repos_url":"https://api.github.com/users/fortressforever/repos","events_url":"https://api.github.com/users/fortressforever/events{/privacy}","received_events_url":"https://api.github.com/users/fortressforever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fortressforever/fortressforever","description":"A Team Fortress mod on the Source Engine","fork":false,"url":"https://api.github.com/repos/fortressforever/fortressforever","forks_url":"https://api.github.com/repos/fortressforever/fortressforever/forks","keys_url":"https://api.github.com/repos/fortressforever/fortressforever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fortressforever/fortressforever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fortressforever/fortressforever/teams","hooks_url":"https://api.github.com/repos/fortressforever/fortressforever/hooks","issue_events_url":"https://api.github.com/repos/fortressforever/fortressforever/issues/events{/number}","events_url":"https://api.github.com/repos/fortressforever/fortressforever/events","assignees_url":"https://api.github.com/repos/fortressforever/fortressforever/assignees{/user}","branches_url":"https://api.github.com/repos/fortressforever/fortressforever/branches{/branch}","tags_url":"https://api.github.com/repos/fortressforever/fortressforever/tags","blobs_url":"https://api.github.com/repos/fortressforever/fortressforever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fortressforever/fortressforever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fortressforever/fortressforever/git/refs{/sha}","trees_url":"https://api.github.com/repos/fortressforever/fortressforever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fortressforever/fortressforever/statuses/{sha}","languages_url":"https://api.github.com/repos/fortressforever/fortressforever/languages","stargazers_url":"https://api.github.com/repos/fortressforever/fortressforever/stargazers","contributors_url":"https://api.github.com/repos/fortressforever/fortressforever/contributors","subscribers_url":"https://api.github.com/repos/fortressforever/fortressforever/subscribers","subscription_url":"https://api.github.com/repos/fortressforever/fortressforever/subscription","commits_url":"https://api.github.com/repos/fortressforever/fortressforever/commits{/sha}","git_commits_url":"https://api.github.com/repos/fortressforever/fortressforever/git/commits{/sha}","comments_url":"https://api.github.com/repos/fortressforever/fortressforever/comments{/number}","issue_comment_url":"https://api.github.com/repos/fortressforever/fortressforever/issues/comments{/number}","contents_url":"https://api.github.com/repos/fortressforever/fortressforever/contents/{+path}","compare_url":"https://api.github.com/repos/fortressforever/fortressforever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fortressforever/fortressforever/merges","archive_url":"https://api.github.com/repos/fortressforever/fortressforever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fortressforever/fortressforever/downloads","issues_url":"https://api.github.com/repos/fortressforever/fortressforever/issues{/number}","pulls_url":"https://api.github.com/repos/fortressforever/fortressforever/pulls{/number}","milestones_url":"https://api.github.com/repos/fortressforever/fortressforever/milestones{/number}","notifications_url":"https://api.github.com/repos/fortressforever/fortressforever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fortressforever/fortressforever/labels{/name}","releases_url":"https://api.github.com/repos/fortressforever/fortressforever/releases{/id}","deployments_url":"https://api.github.com/repos/fortressforever/fortressforever/deployments","created_at":"2014-10-13T07:21:19Z","updated_at":"2016-06-20T01:14:31Z","pushed_at":"2016-07-07T06:55:49Z","git_url":"git://github.com/fortressforever/fortressforever.git","ssh_url":"git@github.com:fortressforever/fortressforever.git","clone_url":"https://github.com/fortressforever/fortressforever.git","svn_url":"https://github.com/fortressforever/fortressforever","homepage":"http://www.fortress-forever.com","size":73933,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":128,"forks":10,"open_issues":128,"watchers":33,"default_branch":"beta"}},"base":{"label":"fortressforever:beta","ref":"beta","sha":"815ab2b155a59dbb473072462a8d14303684c5d7","user":{"login":"fortressforever","id":2388970,"avatar_url":"https://avatars.githubusercontent.com/u/2388970?v=3","gravatar_id":"","url":"https://api.github.com/users/fortressforever","html_url":"https://github.com/fortressforever","followers_url":"https://api.github.com/users/fortressforever/followers","following_url":"https://api.github.com/users/fortressforever/following{/other_user}","gists_url":"https://api.github.com/users/fortressforever/gists{/gist_id}","starred_url":"https://api.github.com/users/fortressforever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortressforever/subscriptions","organizations_url":"https://api.github.com/users/fortressforever/orgs","repos_url":"https://api.github.com/users/fortressforever/repos","events_url":"https://api.github.com/users/fortressforever/events{/privacy}","received_events_url":"https://api.github.com/users/fortressforever/received_events","type":"Organization","site_admin":false},"repo":{"id":25147931,"name":"fortressforever","full_name":"fortressforever/fortressforever","owner":{"login":"fortressforever","id":2388970,"avatar_url":"https://avatars.githubusercontent.com/u/2388970?v=3","gravatar_id":"","url":"https://api.github.com/users/fortressforever","html_url":"https://github.com/fortressforever","followers_url":"https://api.github.com/users/fortressforever/followers","following_url":"https://api.github.com/users/fortressforever/following{/other_user}","gists_url":"https://api.github.com/users/fortressforever/gists{/gist_id}","starred_url":"https://api.github.com/users/fortressforever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortressforever/subscriptions","organizations_url":"https://api.github.com/users/fortressforever/orgs","repos_url":"https://api.github.com/users/fortressforever/repos","events_url":"https://api.github.com/users/fortressforever/events{/privacy}","received_events_url":"https://api.github.com/users/fortressforever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fortressforever/fortressforever","description":"A Team Fortress mod on the Source Engine","fork":false,"url":"https://api.github.com/repos/fortressforever/fortressforever","forks_url":"https://api.github.com/repos/fortressforever/fortressforever/forks","keys_url":"https://api.github.com/repos/fortressforever/fortressforever/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fortressforever/fortressforever/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fortressforever/fortressforever/teams","hooks_url":"https://api.github.com/repos/fortressforever/fortressforever/hooks","issue_events_url":"https://api.github.com/repos/fortressforever/fortressforever/issues/events{/number}","events_url":"https://api.github.com/repos/fortressforever/fortressforever/events","assignees_url":"https://api.github.com/repos/fortressforever/fortressforever/assignees{/user}","branches_url":"https://api.github.com/repos/fortressforever/fortressforever/branches{/branch}","tags_url":"https://api.github.com/repos/fortressforever/fortressforever/tags","blobs_url":"https://api.github.com/repos/fortressforever/fortressforever/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fortressforever/fortressforever/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fortressforever/fortressforever/git/refs{/sha}","trees_url":"https://api.github.com/repos/fortressforever/fortressforever/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fortressforever/fortressforever/statuses/{sha}","languages_url":"https://api.github.com/repos/fortressforever/fortressforever/languages","stargazers_url":"https://api.github.com/repos/fortressforever/fortressforever/stargazers","contributors_url":"https://api.github.com/repos/fortressforever/fortressforever/contributors","subscribers_url":"https://api.github.com/repos/fortressforever/fortressforever/subscribers","subscription_url":"https://api.github.com/repos/fortressforever/fortressforever/subscription","commits_url":"https://api.github.com/repos/fortressforever/fortressforever/commits{/sha}","git_commits_url":"https://api.github.com/repos/fortressforever/fortressforever/git/commits{/sha}","comments_url":"https://api.github.com/repos/fortressforever/fortressforever/comments{/number}","issue_comment_url":"https://api.github.com/repos/fortressforever/fortressforever/issues/comments{/number}","contents_url":"https://api.github.com/repos/fortressforever/fortressforever/contents/{+path}","compare_url":"https://api.github.com/repos/fortressforever/fortressforever/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fortressforever/fortressforever/merges","archive_url":"https://api.github.com/repos/fortressforever/fortressforever/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fortressforever/fortressforever/downloads","issues_url":"https://api.github.com/repos/fortressforever/fortressforever/issues{/number}","pulls_url":"https://api.github.com/repos/fortressforever/fortressforever/pulls{/number}","milestones_url":"https://api.github.com/repos/fortressforever/fortressforever/milestones{/number}","notifications_url":"https://api.github.com/repos/fortressforever/fortressforever/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fortressforever/fortressforever/labels{/name}","releases_url":"https://api.github.com/repos/fortressforever/fortressforever/releases{/id}","deployments_url":"https://api.github.com/repos/fortressforever/fortressforever/deployments","created_at":"2014-10-13T07:21:19Z","updated_at":"2016-06-20T01:14:31Z","pushed_at":"2016-07-07T06:55:49Z","git_url":"git://github.com/fortressforever/fortressforever.git","ssh_url":"git@github.com:fortressforever/fortressforever.git","clone_url":"https://github.com/fortressforever/fortressforever.git","svn_url":"https://github.com/fortressforever/fortressforever","homepage":"http://www.fortress-forever.com","size":73933,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":128,"forks":10,"open_issues":128,"watchers":33,"default_branch":"beta"}},"_links":{"self":{"href":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288"},"html":{"href":"https://github.com/fortressforever/fortressforever/pull/288"},"issue":{"href":"https://api.github.com/repos/fortressforever/fortressforever/issues/288"},"comments":{"href":"https://api.github.com/repos/fortressforever/fortressforever/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/fortressforever/fortressforever/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fortressforever/fortressforever/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/fortressforever/fortressforever/statuses/f0707b5abcf9bc10c05e10f04f85b756c5589ade"}}}}
{"actor":{"display_login":"DexterHaslem"}}