{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/o-video/pulls/comments/66230789","id":66230789,"diff_hunk":"@@ -196,6 +196,7 @@ class VideoJsPlayer extends Video {\n \t\t\tlet filtered = this.brightcoveData.tags.filter(val => val.toLowerCase().indexOf('brand:') !== -1);\n \t\t\tif(filtered.length > 0) {\n \t\t\t\ttry {\n+\t\t\t\t\t\t// when we target the value in the ad server, we only want to target actual brand name, so we strip out \"brand:\" part of the string","path":"src/models/videojs.js","position":null,"original_position":4,"commit_id":"e9f36a76dee34c2a687869c4bc6b2ec5cbabba37","original_commit_id":"e9f36a76dee34c2a687869c4bc6b2ec5cbabba37","user":{"login":"AlbertoElias","id":913117,"avatar_url":"https://avatars.githubusercontent.com/u/913117?v=3","gravatar_id":"","url":"https://api.github.com/users/AlbertoElias","html_url":"https://github.com/AlbertoElias","followers_url":"https://api.github.com/users/AlbertoElias/followers","following_url":"https://api.github.com/users/AlbertoElias/following{/other_user}","gists_url":"https://api.github.com/users/AlbertoElias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbertoElias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbertoElias/subscriptions","organizations_url":"https://api.github.com/users/AlbertoElias/orgs","repos_url":"https://api.github.com/users/AlbertoElias/repos","events_url":"https://api.github.com/users/AlbertoElias/events{/privacy}","received_events_url":"https://api.github.com/users/AlbertoElias/received_events","type":"User","site_admin":false},"body":"indentation","created_at":"2016-06-08T10:25:34Z","updated_at":"2016-06-08T10:25:34Z","html_url":"https://github.com/Financial-Times/o-video/pull/6#discussion_r66230789","pull_request_url":"https://api.github.com/repos/Financial-Times/o-video/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-video/pulls/comments/66230789"},"html":{"href":"https://github.com/Financial-Times/o-video/pull/6#discussion_r66230789"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/o-video/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/o-video/pulls/6","id":72909659,"html_url":"https://github.com/Financial-Times/o-video/pull/6","diff_url":"https://github.com/Financial-Times/o-video/pull/6.diff","patch_url":"https://github.com/Financial-Times/o-video/pull/6.patch","issue_url":"https://api.github.com/repos/Financial-Times/o-video/issues/6","number":6,"state":"open","locked":false,"title":"Add video ad targeting videoid and brand","user":{"login":"VladDubrovskis","id":15323495,"avatar_url":"https://avatars.githubusercontent.com/u/15323495?v=3","gravatar_id":"","url":"https://api.github.com/users/VladDubrovskis","html_url":"https://github.com/VladDubrovskis","followers_url":"https://api.github.com/users/VladDubrovskis/followers","following_url":"https://api.github.com/users/VladDubrovskis/following{/other_user}","gists_url":"https://api.github.com/users/VladDubrovskis/gists{/gist_id}","starred_url":"https://api.github.com/users/VladDubrovskis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladDubrovskis/subscriptions","organizations_url":"https://api.github.com/users/VladDubrovskis/orgs","repos_url":"https://api.github.com/users/VladDubrovskis/repos","events_url":"https://api.github.com/users/VladDubrovskis/events{/privacy}","received_events_url":"https://api.github.com/users/VladDubrovskis/received_events","type":"User","site_admin":false},"body":"/cc @lc512k @AlbertoElias ","created_at":"2016-06-07T16:46:10Z","updated_at":"2016-06-08T10:25:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0e4d7f8abb69d9a3a232448fc9c06ca0ada8ee6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/o-video/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/o-video/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/o-video/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/o-video/issues/6/comments","statuses_url":"https://api.github.com/repos/Financial-Times/o-video/statuses/e9f36a76dee34c2a687869c4bc6b2ec5cbabba37","head":{"label":"Financial-Times:add-video-ad-targeting-videoid-and-brand","ref":"add-video-ad-targeting-videoid-and-brand","sha":"e9f36a76dee34c2a687869c4bc6b2ec5cbabba37","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":45257519,"name":"o-video","full_name":"Financial-Times/o-video","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/o-video","description":"Standard video player and controls","fork":false,"url":"https://api.github.com/repos/Financial-Times/o-video","forks_url":"https://api.github.com/repos/Financial-Times/o-video/forks","keys_url":"https://api.github.com/repos/Financial-Times/o-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/o-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/o-video/teams","hooks_url":"https://api.github.com/repos/Financial-Times/o-video/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/o-video/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/o-video/events","assignees_url":"https://api.github.com/repos/Financial-Times/o-video/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/o-video/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/o-video/tags","blobs_url":"https://api.github.com/repos/Financial-Times/o-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/o-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/o-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/o-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/o-video/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/o-video/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/o-video/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/o-video/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/o-video/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/o-video/subscription","commits_url":"https://api.github.com/repos/Financial-Times/o-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/o-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/o-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/o-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/o-video/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/o-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/o-video/merges","archive_url":"https://api.github.com/repos/Financial-Times/o-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/o-video/downloads","issues_url":"https://api.github.com/repos/Financial-Times/o-video/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/o-video/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/o-video/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/o-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/o-video/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/o-video/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/o-video/deployments","created_at":"2015-10-30T14:57:59Z","updated_at":"2016-06-02T14:31:45Z","pushed_at":"2016-06-08T10:10:19Z","git_url":"git://github.com/Financial-Times/o-video.git","ssh_url":"git@github.com:Financial-Times/o-video.git","clone_url":"https://github.com/Financial-Times/o-video.git","svn_url":"https://github.com/Financial-Times/o-video","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"159e8bccc7b45adcd2e9fa2b5a38e05f4544016f","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":45257519,"name":"o-video","full_name":"Financial-Times/o-video","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/o-video","description":"Standard video player and controls","fork":false,"url":"https://api.github.com/repos/Financial-Times/o-video","forks_url":"https://api.github.com/repos/Financial-Times/o-video/forks","keys_url":"https://api.github.com/repos/Financial-Times/o-video/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/o-video/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/o-video/teams","hooks_url":"https://api.github.com/repos/Financial-Times/o-video/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/o-video/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/o-video/events","assignees_url":"https://api.github.com/repos/Financial-Times/o-video/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/o-video/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/o-video/tags","blobs_url":"https://api.github.com/repos/Financial-Times/o-video/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/o-video/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/o-video/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/o-video/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/o-video/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/o-video/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/o-video/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/o-video/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/o-video/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/o-video/subscription","commits_url":"https://api.github.com/repos/Financial-Times/o-video/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/o-video/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/o-video/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/o-video/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/o-video/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/o-video/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/o-video/merges","archive_url":"https://api.github.com/repos/Financial-Times/o-video/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/o-video/downloads","issues_url":"https://api.github.com/repos/Financial-Times/o-video/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/o-video/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/o-video/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/o-video/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/o-video/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/o-video/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/o-video/deployments","created_at":"2015-10-30T14:57:59Z","updated_at":"2016-06-02T14:31:45Z","pushed_at":"2016-06-08T10:10:19Z","git_url":"git://github.com/Financial-Times/o-video.git","ssh_url":"git@github.com:Financial-Times/o-video.git","clone_url":"https://github.com/Financial-Times/o-video.git","svn_url":"https://github.com/Financial-Times/o-video","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-video/pulls/6"},"html":{"href":"https://github.com/Financial-Times/o-video/pull/6"},"issue":{"href":"https://api.github.com/repos/Financial-Times/o-video/issues/6"},"comments":{"href":"https://api.github.com/repos/Financial-Times/o-video/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/o-video/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/o-video/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/o-video/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/o-video/statuses/e9f36a76dee34c2a687869c4bc6b2ec5cbabba37"}}}}
{"actor":{"display_login":"AlbertoElias"}}