{"action":"created","comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments/64155470","id":64155470,"diff_hunk":"@@ -16,15 +18,27 @@ typedef struct {\n   uint8_t values[0];\n } ws2812_buffer;\n \n-// Init UART1 to be able to stream WS2812 data\n-// We use GPIO2 as output pin\n-static void ws2812_init() {\n+// Init UART1 to be able to stream WS2812 data to GPIO2 pin\n+// If DUAL mode is selected, init UART0 to stream to TXD0 as well\n+// You HAVE to redirect LUA's output somewhere else\n+static void ws2812_init(lua_State* L) {\n+  const int mode = lua_tointeger(L, 1);","path":"app/modules/ws2812.c","position":null,"original_position":20,"commit_id":"3dc03a9a4a24330945bf8368836336c4b67fd968","original_commit_id":"b4fa62a9ef017c4ff58ddf888c50ce0e731f8421","user":{"login":"Alkorin","id":388530,"avatar_url":"https://avatars.githubusercontent.com/u/388530?v=3","gravatar_id":"","url":"https://api.github.com/users/Alkorin","html_url":"https://github.com/Alkorin","followers_url":"https://api.github.com/users/Alkorin/followers","following_url":"https://api.github.com/users/Alkorin/following{/other_user}","gists_url":"https://api.github.com/users/Alkorin/gists{/gist_id}","starred_url":"https://api.github.com/users/Alkorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alkorin/subscriptions","organizations_url":"https://api.github.com/users/Alkorin/orgs","repos_url":"https://api.github.com/users/Alkorin/repos","events_url":"https://api.github.com/users/Alkorin/events{/privacy}","received_events_url":"https://api.github.com/users/Alkorin/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-05-22T20:09:15Z","updated_at":"2016-05-22T20:09:15Z","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1310#discussion_r64155470","pull_request_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310","_links":{"self":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments/64155470"},"html":{"href":"https://github.com/nodemcu/nodemcu-firmware/pull/1310#discussion_r64155470"},"pull_request":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310"}}},"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310","id":70983849,"html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1310","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1310.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1310.patch","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1310","number":1310,"state":"open","locked":false,"title":"[ws2812] Handle two strips in parallel using the two UARTs through GPIO2 and TXD0","user":{"login":"Alkorin","id":388530,"avatar_url":"https://avatars.githubusercontent.com/u/388530?v=3","gravatar_id":"","url":"https://api.github.com/users/Alkorin","html_url":"https://github.com/Alkorin","followers_url":"https://api.github.com/users/Alkorin/followers","following_url":"https://api.github.com/users/Alkorin/following{/other_user}","gists_url":"https://api.github.com/users/Alkorin/gists{/gist_id}","starred_url":"https://api.github.com/users/Alkorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alkorin/subscriptions","organizations_url":"https://api.github.com/users/Alkorin/orgs","repos_url":"https://api.github.com/users/Alkorin/repos","events_url":"https://api.github.com/users/Alkorin/events{/privacy}","received_events_url":"https://api.github.com/users/Alkorin/received_events","type":"User","site_admin":false},"body":"Handle two strips using the two UARTS. The cost to pay is losing access to the LUA console through the serial port (which could still be accessed via a TCP server if needed)","created_at":"2016-05-22T18:05:52Z","updated_at":"2016-05-22T20:09:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50a2ea90d3843e7415abe7e1bb9ba7f0d06fac2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310/commits","review_comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310/comments","review_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1310/comments","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/3dc03a9a4a24330945bf8368836336c4b67fd968","head":{"label":"Alkorin:ws2812-dual","ref":"ws2812-dual","sha":"3dc03a9a4a24330945bf8368836336c4b67fd968","user":{"login":"Alkorin","id":388530,"avatar_url":"https://avatars.githubusercontent.com/u/388530?v=3","gravatar_id":"","url":"https://api.github.com/users/Alkorin","html_url":"https://github.com/Alkorin","followers_url":"https://api.github.com/users/Alkorin/followers","following_url":"https://api.github.com/users/Alkorin/following{/other_user}","gists_url":"https://api.github.com/users/Alkorin/gists{/gist_id}","starred_url":"https://api.github.com/users/Alkorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alkorin/subscriptions","organizations_url":"https://api.github.com/users/Alkorin/orgs","repos_url":"https://api.github.com/users/Alkorin/repos","events_url":"https://api.github.com/users/Alkorin/events{/privacy}","received_events_url":"https://api.github.com/users/Alkorin/received_events","type":"User","site_admin":false},"repo":{"id":45800172,"name":"nodemcu-firmware","full_name":"Alkorin/nodemcu-firmware","owner":{"login":"Alkorin","id":388530,"avatar_url":"https://avatars.githubusercontent.com/u/388530?v=3","gravatar_id":"","url":"https://api.github.com/users/Alkorin","html_url":"https://github.com/Alkorin","followers_url":"https://api.github.com/users/Alkorin/followers","following_url":"https://api.github.com/users/Alkorin/following{/other_user}","gists_url":"https://api.github.com/users/Alkorin/gists{/gist_id}","starred_url":"https://api.github.com/users/Alkorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alkorin/subscriptions","organizations_url":"https://api.github.com/users/Alkorin/orgs","repos_url":"https://api.github.com/users/Alkorin/repos","events_url":"https://api.github.com/users/Alkorin/events{/privacy}","received_events_url":"https://api.github.com/users/Alkorin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alkorin/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":true,"url":"https://api.github.com/repos/Alkorin/nodemcu-firmware","forks_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/Alkorin/nodemcu-firmware/deployments","created_at":"2015-11-08T21:34:29Z","updated_at":"2015-11-08T21:34:34Z","pushed_at":"2016-05-22T20:09:06Z","git_url":"git://github.com/Alkorin/nodemcu-firmware.git","ssh_url":"git@github.com:Alkorin/nodemcu-firmware.git","clone_url":"https://github.com/Alkorin/nodemcu-firmware.git","svn_url":"https://github.com/Alkorin/nodemcu-firmware","homepage":"http://nodemcu.com","size":87818,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodemcu:dev","ref":"dev","sha":"afd974c5e9b942cf1124c9498dc9588ba73679e1","user":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars.githubusercontent.com/u/9865736?v=3","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"repo":{"id":26917568,"name":"nodemcu-firmware","full_name":"nodemcu/nodemcu-firmware","owner":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars.githubusercontent.com/u/9865736?v=3","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nodemcu/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":false,"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","forks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/deployments","created_at":"2014-11-20T15:06:45Z","updated_at":"2016-05-22T11:59:17Z","pushed_at":"2016-05-22T20:09:06Z","git_url":"git://github.com/nodemcu/nodemcu-firmware.git","ssh_url":"git@github.com:nodemcu/nodemcu-firmware.git","clone_url":"https://github.com/nodemcu/nodemcu-firmware.git","svn_url":"https://github.com/nodemcu/nodemcu-firmware","homepage":"http://nodemcu.com","size":104593,"stargazers_count":2232,"watchers_count":2232,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1022,"mirror_url":null,"open_issues_count":122,"forks":1022,"open_issues":122,"watchers":2232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310"},"html":{"href":"https://github.com/nodemcu/nodemcu-firmware/pull/1310"},"issue":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1310"},"comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1310/comments"},"review_comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310/comments"},"review_comment":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1310/commits"},"statuses":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/3dc03a9a4a24330945bf8368836336c4b67fd968"}}}}
{"actor":{"display_login":"Alkorin"}}