{"action":"created","comment":{"url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/comments/67617309","id":67617309,"diff_hunk":"@@ -35,13 +35,24 @@ class tiny_backend : public math_backend {\n  public:\n   // context holds solution-dependent parameters\n   // context should be able to hold any types of structures (like boost::any)\n+  // convolution\n   tiny_backend(conv_params* params,\n                std::function<void(const vec_t&, int)> f1,\n                std::function<void(const vec_t&, vec_t&)> f2,\n                std::function<void(const vec_t&, const vec_t&, vec_t&)> f3,\n-               std::vector<conv_layer_worker_specific_storage>* ptr)\n-      : params_(params), conv_layer_worker_storage_(ptr),\n+               std::vector<conv_layer_worker_specific_storage>* ptr1)\n+      : params_(params), conv_layer_worker_storage_(ptr1),\n         copy_and_pad_input(f1), copy_and_unpad_delta(f2),\n+        backward_activation(f3) {}  \n+\n+  // deconvolution      \n+  tiny_backend(conv_params* params,\n+               std::function<void(const vec_t&, int)> f1,\n+               std::function<void(const vec_t&, vec_t&)> f2,\n+               std::function<void(const vec_t&, const vec_t&, vec_t&)> f3,\n+               std::vector<deconv_layer_worker_specific_storage>* ptr1)\n+      : params_(params), deconv_layer_worker_storage_(ptr1),\n+        copy_and_unpad_output(f1), copy_and_pad_delta(f2),","path":"tiny_cnn/core/tiny_backend.h","position":23,"original_position":23,"commit_id":"13d2c13dfb141ac5f7ba1e44bce8dff1ba9c7fdb","original_commit_id":"13d2c13dfb141ac5f7ba1e44bce8dff1ba9c7fdb","user":{"login":"Wangyida","id":6743242,"avatar_url":"https://avatars.githubusercontent.com/u/6743242?v=3","gravatar_id":"","url":"https://api.github.com/users/Wangyida","html_url":"https://github.com/Wangyida","followers_url":"https://api.github.com/users/Wangyida/followers","following_url":"https://api.github.com/users/Wangyida/following{/other_user}","gists_url":"https://api.github.com/users/Wangyida/gists{/gist_id}","starred_url":"https://api.github.com/users/Wangyida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wangyida/subscriptions","organizations_url":"https://api.github.com/users/Wangyida/orgs","repos_url":"https://api.github.com/users/Wangyida/repos","events_url":"https://api.github.com/users/Wangyida/events{/privacy}","received_events_url":"https://api.github.com/users/Wangyida/received_events","type":"User","site_admin":false},"body":"@edgarriba And here, the most important part. Is it proper to add another backend for deconvolution? I want to get access to different worker storage between convolution and deconvolution because the deconvolutional Class should have its own initiating function. ","created_at":"2016-06-19T13:48:39Z","updated_at":"2016-06-19T13:48:39Z","html_url":"https://github.com/nyanp/tiny-cnn/pull/195#discussion_r67617309","pull_request_url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/comments/67617309"},"html":{"href":"https://github.com/nyanp/tiny-cnn/pull/195#discussion_r67617309"},"pull_request":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195","id":74361374,"html_url":"https://github.com/nyanp/tiny-cnn/pull/195","diff_url":"https://github.com/nyanp/tiny-cnn/pull/195.diff","patch_url":"https://github.com/nyanp/tiny-cnn/pull/195.patch","issue_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/195","number":195,"state":"open","locked":false,"title":"Deconvolution modification for backend using","user":{"login":"Wangyida","id":6743242,"avatar_url":"https://avatars.githubusercontent.com/u/6743242?v=3","gravatar_id":"","url":"https://api.github.com/users/Wangyida","html_url":"https://github.com/Wangyida","followers_url":"https://api.github.com/users/Wangyida/followers","following_url":"https://api.github.com/users/Wangyida/following{/other_user}","gists_url":"https://api.github.com/users/Wangyida/gists{/gist_id}","starred_url":"https://api.github.com/users/Wangyida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wangyida/subscriptions","organizations_url":"https://api.github.com/users/Wangyida/orgs","repos_url":"https://api.github.com/users/Wangyida/repos","events_url":"https://api.github.com/users/Wangyida/events{/privacy}","received_events_url":"https://api.github.com/users/Wangyida/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-19T11:41:31Z","updated_at":"2016-06-19T13:48:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"024afaf528cf0618ed92b759c0561c47a7447bc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195/commits","review_comments_url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195/comments","review_comment_url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/195/comments","statuses_url":"https://api.github.com/repos/nyanp/tiny-cnn/statuses/13d2c13dfb141ac5f7ba1e44bce8dff1ba9c7fdb","head":{"label":"Wangyida:deconv/visual_test","ref":"deconv/visual_test","sha":"13d2c13dfb141ac5f7ba1e44bce8dff1ba9c7fdb","user":{"login":"Wangyida","id":6743242,"avatar_url":"https://avatars.githubusercontent.com/u/6743242?v=3","gravatar_id":"","url":"https://api.github.com/users/Wangyida","html_url":"https://github.com/Wangyida","followers_url":"https://api.github.com/users/Wangyida/followers","following_url":"https://api.github.com/users/Wangyida/following{/other_user}","gists_url":"https://api.github.com/users/Wangyida/gists{/gist_id}","starred_url":"https://api.github.com/users/Wangyida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wangyida/subscriptions","organizations_url":"https://api.github.com/users/Wangyida/orgs","repos_url":"https://api.github.com/users/Wangyida/repos","events_url":"https://api.github.com/users/Wangyida/events{/privacy}","received_events_url":"https://api.github.com/users/Wangyida/received_events","type":"User","site_admin":false},"repo":{"id":59498716,"name":"tiny-cnn","full_name":"Wangyida/tiny-cnn","owner":{"login":"Wangyida","id":6743242,"avatar_url":"https://avatars.githubusercontent.com/u/6743242?v=3","gravatar_id":"","url":"https://api.github.com/users/Wangyida","html_url":"https://github.com/Wangyida","followers_url":"https://api.github.com/users/Wangyida/followers","following_url":"https://api.github.com/users/Wangyida/following{/other_user}","gists_url":"https://api.github.com/users/Wangyida/gists{/gist_id}","starred_url":"https://api.github.com/users/Wangyida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wangyida/subscriptions","organizations_url":"https://api.github.com/users/Wangyida/orgs","repos_url":"https://api.github.com/users/Wangyida/repos","events_url":"https://api.github.com/users/Wangyida/events{/privacy}","received_events_url":"https://api.github.com/users/Wangyida/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wangyida/tiny-cnn","description":"header only, dependency-free deep learning framework in C++11","fork":true,"url":"https://api.github.com/repos/Wangyida/tiny-cnn","forks_url":"https://api.github.com/repos/Wangyida/tiny-cnn/forks","keys_url":"https://api.github.com/repos/Wangyida/tiny-cnn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wangyida/tiny-cnn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wangyida/tiny-cnn/teams","hooks_url":"https://api.github.com/repos/Wangyida/tiny-cnn/hooks","issue_events_url":"https://api.github.com/repos/Wangyida/tiny-cnn/issues/events{/number}","events_url":"https://api.github.com/repos/Wangyida/tiny-cnn/events","assignees_url":"https://api.github.com/repos/Wangyida/tiny-cnn/assignees{/user}","branches_url":"https://api.github.com/repos/Wangyida/tiny-cnn/branches{/branch}","tags_url":"https://api.github.com/repos/Wangyida/tiny-cnn/tags","blobs_url":"https://api.github.com/repos/Wangyida/tiny-cnn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wangyida/tiny-cnn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wangyida/tiny-cnn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wangyida/tiny-cnn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wangyida/tiny-cnn/statuses/{sha}","languages_url":"https://api.github.com/repos/Wangyida/tiny-cnn/languages","stargazers_url":"https://api.github.com/repos/Wangyida/tiny-cnn/stargazers","contributors_url":"https://api.github.com/repos/Wangyida/tiny-cnn/contributors","subscribers_url":"https://api.github.com/repos/Wangyida/tiny-cnn/subscribers","subscription_url":"https://api.github.com/repos/Wangyida/tiny-cnn/subscription","commits_url":"https://api.github.com/repos/Wangyida/tiny-cnn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wangyida/tiny-cnn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wangyida/tiny-cnn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wangyida/tiny-cnn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wangyida/tiny-cnn/contents/{+path}","compare_url":"https://api.github.com/repos/Wangyida/tiny-cnn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wangyida/tiny-cnn/merges","archive_url":"https://api.github.com/repos/Wangyida/tiny-cnn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wangyida/tiny-cnn/downloads","issues_url":"https://api.github.com/repos/Wangyida/tiny-cnn/issues{/number}","pulls_url":"https://api.github.com/repos/Wangyida/tiny-cnn/pulls{/number}","milestones_url":"https://api.github.com/repos/Wangyida/tiny-cnn/milestones{/number}","notifications_url":"https://api.github.com/repos/Wangyida/tiny-cnn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wangyida/tiny-cnn/labels{/name}","releases_url":"https://api.github.com/repos/Wangyida/tiny-cnn/releases{/id}","deployments_url":"https://api.github.com/repos/Wangyida/tiny-cnn/deployments","created_at":"2016-05-23T16:21:59Z","updated_at":"2016-05-23T16:22:01Z","pushed_at":"2016-06-19T11:45:18Z","git_url":"git://github.com/Wangyida/tiny-cnn.git","ssh_url":"git@github.com:Wangyida/tiny-cnn.git","clone_url":"https://github.com/Wangyida/tiny-cnn.git","svn_url":"https://github.com/Wangyida/tiny-cnn","homepage":"","size":15671,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nyanp:feat/generic-computational-graph","ref":"feat/generic-computational-graph","sha":"6c49ce3b40b9dfd969e7b09a02e74cc30ff1842e","user":{"login":"nyanp","id":378738,"avatar_url":"https://avatars.githubusercontent.com/u/378738?v=3","gravatar_id":"","url":"https://api.github.com/users/nyanp","html_url":"https://github.com/nyanp","followers_url":"https://api.github.com/users/nyanp/followers","following_url":"https://api.github.com/users/nyanp/following{/other_user}","gists_url":"https://api.github.com/users/nyanp/gists{/gist_id}","starred_url":"https://api.github.com/users/nyanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyanp/subscriptions","organizations_url":"https://api.github.com/users/nyanp/orgs","repos_url":"https://api.github.com/users/nyanp/repos","events_url":"https://api.github.com/users/nyanp/events{/privacy}","received_events_url":"https://api.github.com/users/nyanp/received_events","type":"User","site_admin":false},"repo":{"id":7205740,"name":"tiny-cnn","full_name":"nyanp/tiny-cnn","owner":{"login":"nyanp","id":378738,"avatar_url":"https://avatars.githubusercontent.com/u/378738?v=3","gravatar_id":"","url":"https://api.github.com/users/nyanp","html_url":"https://github.com/nyanp","followers_url":"https://api.github.com/users/nyanp/followers","following_url":"https://api.github.com/users/nyanp/following{/other_user}","gists_url":"https://api.github.com/users/nyanp/gists{/gist_id}","starred_url":"https://api.github.com/users/nyanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyanp/subscriptions","organizations_url":"https://api.github.com/users/nyanp/orgs","repos_url":"https://api.github.com/users/nyanp/repos","events_url":"https://api.github.com/users/nyanp/events{/privacy}","received_events_url":"https://api.github.com/users/nyanp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyanp/tiny-cnn","description":"header only, dependency-free deep learning framework in C++11","fork":false,"url":"https://api.github.com/repos/nyanp/tiny-cnn","forks_url":"https://api.github.com/repos/nyanp/tiny-cnn/forks","keys_url":"https://api.github.com/repos/nyanp/tiny-cnn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyanp/tiny-cnn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyanp/tiny-cnn/teams","hooks_url":"https://api.github.com/repos/nyanp/tiny-cnn/hooks","issue_events_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/events{/number}","events_url":"https://api.github.com/repos/nyanp/tiny-cnn/events","assignees_url":"https://api.github.com/repos/nyanp/tiny-cnn/assignees{/user}","branches_url":"https://api.github.com/repos/nyanp/tiny-cnn/branches{/branch}","tags_url":"https://api.github.com/repos/nyanp/tiny-cnn/tags","blobs_url":"https://api.github.com/repos/nyanp/tiny-cnn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyanp/tiny-cnn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyanp/tiny-cnn/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyanp/tiny-cnn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyanp/tiny-cnn/statuses/{sha}","languages_url":"https://api.github.com/repos/nyanp/tiny-cnn/languages","stargazers_url":"https://api.github.com/repos/nyanp/tiny-cnn/stargazers","contributors_url":"https://api.github.com/repos/nyanp/tiny-cnn/contributors","subscribers_url":"https://api.github.com/repos/nyanp/tiny-cnn/subscribers","subscription_url":"https://api.github.com/repos/nyanp/tiny-cnn/subscription","commits_url":"https://api.github.com/repos/nyanp/tiny-cnn/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyanp/tiny-cnn/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyanp/tiny-cnn/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyanp/tiny-cnn/contents/{+path}","compare_url":"https://api.github.com/repos/nyanp/tiny-cnn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyanp/tiny-cnn/merges","archive_url":"https://api.github.com/repos/nyanp/tiny-cnn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyanp/tiny-cnn/downloads","issues_url":"https://api.github.com/repos/nyanp/tiny-cnn/issues{/number}","pulls_url":"https://api.github.com/repos/nyanp/tiny-cnn/pulls{/number}","milestones_url":"https://api.github.com/repos/nyanp/tiny-cnn/milestones{/number}","notifications_url":"https://api.github.com/repos/nyanp/tiny-cnn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyanp/tiny-cnn/labels{/name}","releases_url":"https://api.github.com/repos/nyanp/tiny-cnn/releases{/id}","deployments_url":"https://api.github.com/repos/nyanp/tiny-cnn/deployments","created_at":"2012-12-17T14:08:06Z","updated_at":"2016-06-17T11:28:26Z","pushed_at":"2016-06-19T11:45:20Z","git_url":"git://github.com/nyanp/tiny-cnn.git","ssh_url":"git@github.com:nyanp/tiny-cnn.git","clone_url":"https://github.com/nyanp/tiny-cnn.git","svn_url":"https://github.com/nyanp/tiny-cnn","homepage":"","size":16314,"stargazers_count":707,"watchers_count":707,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"open_issues_count":81,"forks":335,"open_issues":81,"watchers":707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195"},"html":{"href":"https://github.com/nyanp/tiny-cnn/pull/195"},"issue":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/issues/195"},"comments":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/nyanp/tiny-cnn/statuses/13d2c13dfb141ac5f7ba1e44bce8dff1ba9c7fdb"}}}}
{"actor":{"display_login":"Wangyida"}}