{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/rr/pulls/comments/87477037","pull_request_review_id":8088349,"id":87477037,"diff_hunk":"@@ -2130,7 +2130,13 @@ static Switchable prepare_ptrace(RecordTask* t,\n     case PTRACE_SYSEMU_SINGLESTEP:\n     case PTRACE_CONT: {\n       RecordTask* tracee = verify_ptrace_target(t, syscall_state, pid);\n+      // If the tracer wants to observe syscall entries, we can't use the\n+      // syscallbuf, because the tracer may want to change syscall numbers\n+      // which the syscallbuf code is not prepared to handle.\n       if (tracee) {\n+        tracee->set_syscallbuf_locked(command == PTRACE_SYSCALL ||\n+                                      command == PTRACE_SYSEMU ||\n+                                      command == PTRACE_SYSEMU_SINGLESTEP);","path":"src/record_syscall.cc","position":null,"original_position":10,"commit_id":"cf167f115ad70027ccf065c021308985d2eda12d","original_commit_id":"0fd842a57e15f65efe4890c7611b45631472e04e","user":{"login":"rocallahan","id":296135,"avatar_url":"https://avatars.githubusercontent.com/u/296135?v=3","gravatar_id":"","url":"https://api.github.com/users/rocallahan","html_url":"https://github.com/rocallahan","followers_url":"https://api.github.com/users/rocallahan/followers","following_url":"https://api.github.com/users/rocallahan/following{/other_user}","gists_url":"https://api.github.com/users/rocallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/rocallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocallahan/subscriptions","organizations_url":"https://api.github.com/users/rocallahan/orgs","repos_url":"https://api.github.com/users/rocallahan/repos","events_url":"https://api.github.com/users/rocallahan/events{/privacy}","received_events_url":"https://api.github.com/users/rocallahan/received_events","type":"User","site_admin":false},"body":"If we're going to do this for `PTRACE_CONT` then we're effectively doing it for all tracees and I think it's simpler and more robust to do this as soon as we attach.\r\n\r\nThen again, do we need to do this for all tracees? Maybe it's more robust if we do, but that would mean disabling syscallbuf for any tracee with any kind of ptrace supervisor (including Wine?) so that might be bad.\r\n\r\nSo I lean towards not doing this for `PTRACE_CONT` unless you make the case that we should.","created_at":"2016-11-10T20:18:02Z","updated_at":"2016-11-10T20:19:40Z","html_url":"https://github.com/mozilla/rr/pull/1885#discussion_r87477037","pull_request_url":"https://api.github.com/repos/mozilla/rr/pulls/1885","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rr/pulls/comments/87477037"},"html":{"href":"https://github.com/mozilla/rr/pull/1885#discussion_r87477037"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1885"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/rr/pulls/1885","id":93218402,"html_url":"https://github.com/mozilla/rr/pull/1885","diff_url":"https://github.com/mozilla/rr/pull/1885.diff","patch_url":"https://github.com/mozilla/rr/pull/1885.patch","issue_url":"https://api.github.com/repos/mozilla/rr/issues/1885","number":1885,"state":"open","locked":false,"title":"Misc improvements to ptrace emulations","user":{"login":"Keno","id":1291671,"avatar_url":"https://avatars.githubusercontent.com/u/1291671?v=3","gravatar_id":"","url":"https://api.github.com/users/Keno","html_url":"https://github.com/Keno","followers_url":"https://api.github.com/users/Keno/followers","following_url":"https://api.github.com/users/Keno/following{/other_user}","gists_url":"https://api.github.com/users/Keno/gists{/gist_id}","starred_url":"https://api.github.com/users/Keno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keno/subscriptions","organizations_url":"https://api.github.com/users/Keno/orgs","repos_url":"https://api.github.com/users/Keno/repos","events_url":"https://api.github.com/users/Keno/events{/privacy}","received_events_url":"https://api.github.com/users/Keno/received_events","type":"User","site_admin":false},"body":"Mostly as discussed on IRC. See individual commit messages for details.","created_at":"2016-11-10T19:50:52Z","updated_at":"2016-11-10T20:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15d5c8827184186a1c10e9e28a8fb1aa8fc4cb49","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/rr/pulls/1885/commits","review_comments_url":"https://api.github.com/repos/mozilla/rr/pulls/1885/comments","review_comment_url":"https://api.github.com/repos/mozilla/rr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/rr/issues/1885/comments","statuses_url":"https://api.github.com/repos/mozilla/rr/statuses/cf167f115ad70027ccf065c021308985d2eda12d","head":{"label":"Keno:kf/ptrace","ref":"kf/ptrace","sha":"cf167f115ad70027ccf065c021308985d2eda12d","user":{"login":"Keno","id":1291671,"avatar_url":"https://avatars.githubusercontent.com/u/1291671?v=3","gravatar_id":"","url":"https://api.github.com/users/Keno","html_url":"https://github.com/Keno","followers_url":"https://api.github.com/users/Keno/followers","following_url":"https://api.github.com/users/Keno/following{/other_user}","gists_url":"https://api.github.com/users/Keno/gists{/gist_id}","starred_url":"https://api.github.com/users/Keno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keno/subscriptions","organizations_url":"https://api.github.com/users/Keno/orgs","repos_url":"https://api.github.com/users/Keno/repos","events_url":"https://api.github.com/users/Keno/events{/privacy}","received_events_url":"https://api.github.com/users/Keno/received_events","type":"User","site_admin":false},"repo":{"id":56412467,"name":"rr","full_name":"Keno/rr","owner":{"login":"Keno","id":1291671,"avatar_url":"https://avatars.githubusercontent.com/u/1291671?v=3","gravatar_id":"","url":"https://api.github.com/users/Keno","html_url":"https://github.com/Keno","followers_url":"https://api.github.com/users/Keno/followers","following_url":"https://api.github.com/users/Keno/following{/other_user}","gists_url":"https://api.github.com/users/Keno/gists{/gist_id}","starred_url":"https://api.github.com/users/Keno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keno/subscriptions","organizations_url":"https://api.github.com/users/Keno/orgs","repos_url":"https://api.github.com/users/Keno/repos","events_url":"https://api.github.com/users/Keno/events{/privacy}","received_events_url":"https://api.github.com/users/Keno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Keno/rr","description":"Record and Replay Framework","fork":true,"url":"https://api.github.com/repos/Keno/rr","forks_url":"https://api.github.com/repos/Keno/rr/forks","keys_url":"https://api.github.com/repos/Keno/rr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keno/rr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keno/rr/teams","hooks_url":"https://api.github.com/repos/Keno/rr/hooks","issue_events_url":"https://api.github.com/repos/Keno/rr/issues/events{/number}","events_url":"https://api.github.com/repos/Keno/rr/events","assignees_url":"https://api.github.com/repos/Keno/rr/assignees{/user}","branches_url":"https://api.github.com/repos/Keno/rr/branches{/branch}","tags_url":"https://api.github.com/repos/Keno/rr/tags","blobs_url":"https://api.github.com/repos/Keno/rr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keno/rr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keno/rr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keno/rr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keno/rr/statuses/{sha}","languages_url":"https://api.github.com/repos/Keno/rr/languages","stargazers_url":"https://api.github.com/repos/Keno/rr/stargazers","contributors_url":"https://api.github.com/repos/Keno/rr/contributors","subscribers_url":"https://api.github.com/repos/Keno/rr/subscribers","subscription_url":"https://api.github.com/repos/Keno/rr/subscription","commits_url":"https://api.github.com/repos/Keno/rr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keno/rr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keno/rr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keno/rr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keno/rr/contents/{+path}","compare_url":"https://api.github.com/repos/Keno/rr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keno/rr/merges","archive_url":"https://api.github.com/repos/Keno/rr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keno/rr/downloads","issues_url":"https://api.github.com/repos/Keno/rr/issues{/number}","pulls_url":"https://api.github.com/repos/Keno/rr/pulls{/number}","milestones_url":"https://api.github.com/repos/Keno/rr/milestones{/number}","notifications_url":"https://api.github.com/repos/Keno/rr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keno/rr/labels{/name}","releases_url":"https://api.github.com/repos/Keno/rr/releases{/id}","deployments_url":"https://api.github.com/repos/Keno/rr/deployments","created_at":"2016-04-17T00:51:17Z","updated_at":"2016-04-17T00:51:19Z","pushed_at":"2016-11-10T19:48:06Z","git_url":"git://github.com/Keno/rr.git","ssh_url":"git@github.com:Keno/rr.git","clone_url":"https://github.com/Keno/rr.git","svn_url":"https://github.com/Keno/rr","homepage":"","size":15220,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"e59d08bb8e6e08b6ccb8ecaeb1f876436e7e82df","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2269868,"name":"rr","full_name":"mozilla/rr","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/rr","description":"Record and Replay Framework","fork":false,"url":"https://api.github.com/repos/mozilla/rr","forks_url":"https://api.github.com/repos/mozilla/rr/forks","keys_url":"https://api.github.com/repos/mozilla/rr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/rr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/rr/teams","hooks_url":"https://api.github.com/repos/mozilla/rr/hooks","issue_events_url":"https://api.github.com/repos/mozilla/rr/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/rr/events","assignees_url":"https://api.github.com/repos/mozilla/rr/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/rr/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/rr/tags","blobs_url":"https://api.github.com/repos/mozilla/rr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/rr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/rr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/rr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/rr/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/rr/languages","stargazers_url":"https://api.github.com/repos/mozilla/rr/stargazers","contributors_url":"https://api.github.com/repos/mozilla/rr/contributors","subscribers_url":"https://api.github.com/repos/mozilla/rr/subscribers","subscription_url":"https://api.github.com/repos/mozilla/rr/subscription","commits_url":"https://api.github.com/repos/mozilla/rr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/rr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/rr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/rr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/rr/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/rr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/rr/merges","archive_url":"https://api.github.com/repos/mozilla/rr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/rr/downloads","issues_url":"https://api.github.com/repos/mozilla/rr/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/rr/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/rr/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/rr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/rr/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/rr/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/rr/deployments","created_at":"2011-08-25T18:59:32Z","updated_at":"2016-11-06T21:27:25Z","pushed_at":"2016-11-10T19:50:52Z","git_url":"git://github.com/mozilla/rr.git","ssh_url":"git@github.com:mozilla/rr.git","clone_url":"https://github.com/mozilla/rr.git","svn_url":"https://github.com/mozilla/rr","homepage":"http://rr-project.org/","size":54461,"stargazers_count":1999,"watchers_count":1999,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":167,"mirror_url":null,"open_issues_count":196,"forks":167,"open_issues":196,"watchers":1999,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1885"},"html":{"href":"https://github.com/mozilla/rr/pull/1885"},"issue":{"href":"https://api.github.com/repos/mozilla/rr/issues/1885"},"comments":{"href":"https://api.github.com/repos/mozilla/rr/issues/1885/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1885/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/rr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1885/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/rr/statuses/cf167f115ad70027ccf065c021308985d2eda12d"}}}}
{"actor":{"display_login":"rocallahan"}}