{"action":"created","issue":{"url":"https://api.github.com/repos/ericpaulbishop/gargoyle/issues/515","repository_url":"https://api.github.com/repos/ericpaulbishop/gargoyle","labels_url":"https://api.github.com/repos/ericpaulbishop/gargoyle/issues/515/labels{/name}","comments_url":"https://api.github.com/repos/ericpaulbishop/gargoyle/issues/515/comments","events_url":"https://api.github.com/repos/ericpaulbishop/gargoyle/issues/515/events","html_url":"https://github.com/ericpaulbishop/gargoyle/pull/515","id":146193423,"number":515,"title":"Bootstrap integration - phase 1","user":{"login":"stopspazzing","id":6192534,"avatar_url":"https://avatars.githubusercontent.com/u/6192534?v=3","gravatar_id":"","url":"https://api.github.com/users/stopspazzing","html_url":"https://github.com/stopspazzing","followers_url":"https://api.github.com/users/stopspazzing/followers","following_url":"https://api.github.com/users/stopspazzing/following{/other_user}","gists_url":"https://api.github.com/users/stopspazzing/gists{/gist_id}","starred_url":"https://api.github.com/users/stopspazzing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stopspazzing/subscriptions","organizations_url":"https://api.github.com/users/stopspazzing/orgs","repos_url":"https://api.github.com/users/stopspazzing/repos","events_url":"https://api.github.com/users/stopspazzing/events{/privacy}","received_events_url":"https://api.github.com/users/stopspazzing/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-04-06T05:47:50Z","updated_at":"2016-06-08T04:54:47Z","closed_at":"2016-06-08T04:54:47Z","pull_request":{"url":"https://api.github.com/repos/ericpaulbishop/gargoyle/pulls/515","html_url":"https://github.com/ericpaulbishop/gargoyle/pull/515","diff_url":"https://github.com/ericpaulbishop/gargoyle/pull/515.diff","patch_url":"https://github.com/ericpaulbishop/gargoyle/pull/515.patch"},"body":"I have successfully integrated bootstrap for a responsive design & layout. More information on the specifics are located [here](https://www.gargoyle-router.com/phpbb/viewtopic.php?f=13&t=7599&p=37203#p37203) and well as my custom bootstrap build, and some images of the new design.\r\n\r\nCaveats:\r\n\r\n- This phase 1 (personally my 4th complete code rework) is just for showing off possibilities and I am looking for as much feedback as possible. Also need people with screen readers to test to make sure everything works, any problems can be easily fixed.\r\n- Device name in [sidebar header](https://github.com/stopspazzing/gargoyle/blob/master/package/gargoyle/src/gargoyle_header_footer.c#L506) under logo isn't working, tried pretty darn hard to get it working. Must be something I'm missing.\r\n- Some of the very LONG pages like basic.sh, need some more tweaks and code cleanup which is no longer needed. Still would like wifi section on basic.sh to be broken into 3 parts.\r\n- Any features used were kept to IE8+ FF3+ All chrome/opera/safari versions for compatibility. Any hidden text will still be read on screen readers. Kept this to only the login screen currently.\r\n- Only javascript added was getting the sidebar to open when clicked on mobile, located at the bottom of the [gargoyle header footer](https://github.com/stopspazzing/gargoyle/blob/master/package/gargoyle/src/gargoyle_header_footer.c#L673) file.\r\n- You CAN flash over this build without having issues on 1.9.x builds. I backed up my settings as a precaution, as I suggest you do the same.\r\n- All *.sh/.css files can be modified on the fly on a running router without issues, so if you want to test changes or tweaks, modify away. Most of the *.js can be except common.js, which likes resetting your settings when modified.\r\n- I'm hoping to get this merged before or with 2.0.x builds. Sooner the input the sooner the changes can be applied.\r\n- [theme.css](https://github.com/stopspazzing/gargoyle/blob/master/package/gargoyle/files/www/themes/Gargoyle/theme.css) is the primary .css file; any changes to it will override everything else. Thinking themes should have a default 'theme.css' file, possibly even a 'theme.js' since some people need to add custom js.\r\n- Yes, technically the sidebar menu is on the right side, and the content is on the left, why? because moving the code around caused it not to display the content on pages. Bootstrap lets you 'switch' columns which is what I am doing to get everything working. A better fix would be to put the sidebar menu before the actual content, but I couldn't get this working.\r\n- Some pages generate content via their .js equivalent file, however, I have yet to modify any ,js files outside the table.js file, so some tables and content looks off. These changes are planned, but currently waiting for feedback before I continue.\r\n- I have some idea's of making the menu look better since I currently think it looks bland.\r\n- There are still comments in the code which I used to debug the sidebar menu, currently just pointers and only can be seen in [source](https://github.com/stopspazzing/gargoyle/blob/master/package/gargoyle/src/gargoyle_header_footer.c#L388)\r\n- Technically you dont need anything other than the [gargoyle](https://github.com/stopspazzing/gargoyle/tree/master/package/gargoyle) package, so if you want to use this on a newer build of gargoyle, just copy folder over. Worse case, only the frontend (aka web interface) won't work, and a simple sysupgrade via terminal to flash to a working build fixes the issue."},"comment":{"url":"https://api.github.com/repos/ericpaulbishop/gargoyle/issues/comments/224486954","html_url":"https://github.com/ericpaulbishop/gargoyle/pull/515#issuecomment-224486954","issue_url":"https://api.github.com/repos/ericpaulbishop/gargoyle/issues/515","id":224486954,"user":{"login":"stopspazzing","id":6192534,"avatar_url":"https://avatars.githubusercontent.com/u/6192534?v=3","gravatar_id":"","url":"https://api.github.com/users/stopspazzing","html_url":"https://github.com/stopspazzing","followers_url":"https://api.github.com/users/stopspazzing/followers","following_url":"https://api.github.com/users/stopspazzing/following{/other_user}","gists_url":"https://api.github.com/users/stopspazzing/gists{/gist_id}","starred_url":"https://api.github.com/users/stopspazzing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stopspazzing/subscriptions","organizations_url":"https://api.github.com/users/stopspazzing/orgs","repos_url":"https://api.github.com/users/stopspazzing/repos","events_url":"https://api.github.com/users/stopspazzing/events{/privacy}","received_events_url":"https://api.github.com/users/stopspazzing/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T04:54:47Z","updated_at":"2016-06-08T04:54:47Z","body":"After some discussion, to clean this up and make it easier to integrate, going to close this PR and use it as a reference only, then create a clean fork, add my changes and stash them, then use that PR to continue work."}}
{"actor":{"display_login":"stopspazzing"}}