{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3959","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3959/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3959/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3959/events","html_url":"https://github.com/RobotLocomotion/drake/pull/3959","id":186308393,"number":3959,"title":"Modifies AutomotiveSimulator to Allow Client Selectable Model Files.","user":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"labels":[{"id":470891318,"url":"https://api.github.com/repos/RobotLocomotion/drake/labels/status:%20curate%20commits%20before%20merging","name":"status: curate commits before merging","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},{"login":"maddog-tri","id":17651181,"avatar_url":"https://avatars.githubusercontent.com/u/17651181?v=3","gravatar_id":"","url":"https://api.github.com/users/maddog-tri","html_url":"https://github.com/maddog-tri","followers_url":"https://api.github.com/users/maddog-tri/followers","following_url":"https://api.github.com/users/maddog-tri/following{/other_user}","gists_url":"https://api.github.com/users/maddog-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/maddog-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddog-tri/subscriptions","organizations_url":"https://api.github.com/users/maddog-tri/orgs","repos_url":"https://api.github.com/users/maddog-tri/repos","events_url":"https://api.github.com/users/maddog-tri/events{/privacy}","received_events_url":"https://api.github.com/users/maddog-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-31T15:10:10Z","updated_at":"2016-11-02T02:09:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/3959","html_url":"https://github.com/RobotLocomotion/drake/pull/3959","diff_url":"https://github.com/RobotLocomotion/drake/pull/3959.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/3959.patch"},"body":"Builds upon #3933. Goes towards spiral 1 of #3919.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/3959)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/257753042","html_url":"https://github.com/RobotLocomotion/drake/pull/3959#issuecomment-257753042","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3959","id":257753042,"user":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T02:09:17Z","updated_at":"2016-11-02T02:09:17Z","body":"@jwnimmer-tri I addressed your comments.\n\n---\n\nReview status: 1 of 4 files reviewed at latest revision, 5 unresolved discussions.\n\n---\n\n*[drake/automotive/automotive_simulator.cc, line 115 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3959#-KVXSKFPiwS2HuEV8zw4:-KVXj3HbTGd2rhu1ry7W:boyexbg) ([raw file](https://github.com/robotlocomotion/drake/blob/6c8240780194c56347085703e6b63da10393b7c4/drake/automotive/automotive_simulator.cc#L115)):*\n<details><summary><i>Previously, jwnimmer-tri (Jeremy Nimmer) wrote…</i></summary>\n> I think `bodies` is unused.\n</details>\nDone. Thanks.\n\n---\n\n*[drake/automotive/automotive_simulator.h, line 54 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3959#-KVXRCLSCv4MRBMc8ruR:-KVXjo9yKwxmQEscdWYa:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/6c8240780194c56347085703e6b63da10393b7c4/drake/automotive/automotive_simulator.h#L54)):*\n<details><summary><i>Previously, jwnimmer-tri (Jeremy Nimmer) wrote…</i></summary>\n> BTW Clarify that the model file is only for visualization, and not for physical simulation?\n</details>\nDone.\n\n---\n\n*[drake/automotive/automotive_simulator.h, line 73 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3959#-KVXQrpHcsNdRBcpLhIz:-KVXk50r_Ssck15KyTuC:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/6c8240780194c56347085703e6b63da10393b7c4/drake/automotive/automotive_simulator.h#L73)):*\n<details><summary><i>Previously, jwnimmer-tri (Jeremy Nimmer) wrote…</i></summary>\n> BTW For the above three parameters, consider merely referring the reader to the TrajectoryCar constructor documentation, instead of brittlely duplicating its content here.\n</details>\nDone.\n\n---\n\n*[drake/automotive/automotive_simulator.h, line 133 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3959#-KVXS3LDCYeuZOHVWMPK:-KVXkeXVadL5TucoKvZq:b-896fix) ([raw file](https://github.com/robotlocomotion/drake/blob/6c8240780194c56347085703e6b63da10393b7c4/drake/automotive/automotive_simulator.h#L133)):*\n<details><summary><i>Previously, jwnimmer-tri (Jeremy Nimmer) wrote…</i></summary>\n> Please be consistent with `sdf_file` vs `sdf_filename` within this file.\n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/3959#-:-KVXkgJaCWJ3Pc0PRzAx:b-ev77i5)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"liangfok"}}