{"action":"created","issue":{"url":"https://api.github.com/repos/dib-lab/khmer/issues/1418","repository_url":"https://api.github.com/repos/dib-lab/khmer","labels_url":"https://api.github.com/repos/dib-lab/khmer/issues/1418/labels{/name}","comments_url":"https://api.github.com/repos/dib-lab/khmer/issues/1418/comments","events_url":"https://api.github.com/repos/dib-lab/khmer/issues/1418/events","html_url":"https://github.com/dib-lab/khmer/pull/1418","id":171192963,"number":1418,"title":"Do not link against `gcov` on OSX when measuring coverage","user":{"login":"betatim","id":1448859,"avatar_url":"https://avatars.githubusercontent.com/u/1448859?v=3","gravatar_id":"","url":"https://api.github.com/users/betatim","html_url":"https://github.com/betatim","followers_url":"https://api.github.com/users/betatim/followers","following_url":"https://api.github.com/users/betatim/following{/other_user}","gists_url":"https://api.github.com/users/betatim/gists{/gist_id}","starred_url":"https://api.github.com/users/betatim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betatim/subscriptions","organizations_url":"https://api.github.com/users/betatim/orgs","repos_url":"https://api.github.com/users/betatim/repos","events_url":"https://api.github.com/users/betatim/events{/privacy}","received_events_url":"https://api.github.com/users/betatim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-08-15T15:23:34Z","updated_at":"2016-08-18T14:37:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dib-lab/khmer/pulls/1418","html_url":"https://github.com/dib-lab/khmer/pull/1418","diff_url":"https://github.com/dib-lab/khmer/pull/1418.diff","patch_url":"https://github.com/dib-lab/khmer/pull/1418.patch"},"body":"On OSX the `gcov` library doesn't exist. Modified the extension builder to strip out `gcov` from the list of libraries on OSX. With this change I am able to run `make diff-cover` on OSX and generate coverage reports 🎉 !\r\n\r\n---\r\n\r\n- [x] Is it mergeable?\r\n- [x] `make test` Did it pass the tests?\r\n- [x] `make clean diff-cover` If it introduces new functionality in\r\n  `scripts/` is it tested?\r\n- [x] `make format diff_pylint_report`, `git reset --hard` (see #1416),  `make doc pydocstyle` Is it well  formatted? `pydocstyle` reports some errors that already existed. Something to fix in a new PR.\r\n- [x] Is it documented in the `ChangeLog`**?\r\n- [x] Is the Copyright year up to date?\r\n- [x] rename `nosetest.xml`\r\n\r\n** should this be mentioned in the ChangeLog or is that for user facing changes only?"},"comment":{"url":"https://api.github.com/repos/dib-lab/khmer/issues/comments/240743236","html_url":"https://github.com/dib-lab/khmer/pull/1418#issuecomment-240743236","issue_url":"https://api.github.com/repos/dib-lab/khmer/issues/1418","id":240743236,"user":{"login":"betatim","id":1448859,"avatar_url":"https://avatars.githubusercontent.com/u/1448859?v=3","gravatar_id":"","url":"https://api.github.com/users/betatim","html_url":"https://github.com/betatim","followers_url":"https://api.github.com/users/betatim/followers","following_url":"https://api.github.com/users/betatim/following{/other_user}","gists_url":"https://api.github.com/users/betatim/gists{/gist_id}","starred_url":"https://api.github.com/users/betatim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betatim/subscriptions","organizations_url":"https://api.github.com/users/betatim/orgs","repos_url":"https://api.github.com/users/betatim/repos","events_url":"https://api.github.com/users/betatim/events{/privacy}","received_events_url":"https://api.github.com/users/betatim/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T14:37:40Z","updated_at":"2016-08-18T14:37:40Z","body":"Opened an issue: gcovr/gcovr#140"}}
{"actor":{"display_login":"betatim"}}