{"action":"created","comment":{"url":"https://api.github.com/repos/bjorn/tiled/pulls/comments/85300087","pull_request_review_id":6020752,"id":85300087,"diff_hunk":"@@ -247,22 +452,33 @@\n </xs:attributeGroup>\n \n <xs:attributeGroup name=\"tile.data.layer\">\n-  <xs:attribute name=\"gid\" type=\"xs:nonNegativeInteger\" use=\"required\"/>\n+  <xs:attribute name=\"gid\" type=\"tileId\" use=\"required\"/>\n </xs:attributeGroup>\n \n <xs:attributeGroup name=\"objectgroup\">\n+  <!--Not sure if missing x,y which are defaulted to 0 and unchangable-->\n   <xs:attribute name=\"name\" type=\"nameT\" use=\"required\"/>\n-  <xs:attribute name=\"width\" type=\"xs:nonNegativeInteger\" use=\"required\"/>\n-  <xs:attribute name=\"height\" type=\"xs:nonNegativeInteger\" use=\"required\"/>\n+  <xs:attribute name=\"width\" type=\"pixelT\" use=\"required\"/>\n+  <xs:attribute name=\"height\" type=\"pixelT\" use=\"required\"/>\n+  <xs:attribute name=\"color\" type=\"hexColourT\" use =\"required\"/>\n+  <xs:attribute name=\"opacity\" type=\"opacityT\" use=\"optional\" default=\"1\"/>\n+  <xs:attribute name=\"visible\" type=\"xs:boolean\" use=\"optional\" default=\"1\"/>\n+  <xs:attribute name=\"offsetx\" type=\"xs:integer\" use=\"optional\" default=\"0\"/>\n+  <xs:attribute name=\"offsety\" type=\"xs:integer\" use=\"optional\" default=\"0\"/>\n+  <xs:attribute name=\"draworder\" type=\"draworderT\" use=\"optional\" default=\"topdown\"/>\n </xs:attributeGroup>\n \n <xs:attributeGroup name=\"object\">\n+  <xs:attribute name=\"id\" type=\"xs:nonNegativeInteger\" use=\"required\"/>","path":"docs/map.xsd","position":437,"original_position":437,"commit_id":"58e44eb0cb7b7adfeb89a7481b5fa9571a1c2676","original_commit_id":"58e44eb0cb7b7adfeb89a7481b5fa9571a1c2676","user":{"login":"bjorn","id":531764,"avatar_url":"https://avatars.githubusercontent.com/u/531764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"body":"While Tiled will always write out the id, it doesn't require them to be present when loading a map, so maybe it should be marked optional?","created_at":"2016-10-27T09:34:52Z","updated_at":"2016-10-27T09:47:21Z","html_url":"https://github.com/bjorn/tiled/pull/1385#discussion_r85300087","pull_request_url":"https://api.github.com/repos/bjorn/tiled/pulls/1385","_links":{"self":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/comments/85300087"},"html":{"href":"https://github.com/bjorn/tiled/pull/1385#discussion_r85300087"},"pull_request":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1385"}}},"pull_request":{"url":"https://api.github.com/repos/bjorn/tiled/pulls/1385","id":90882044,"html_url":"https://github.com/bjorn/tiled/pull/1385","diff_url":"https://github.com/bjorn/tiled/pull/1385.diff","patch_url":"https://github.com/bjorn/tiled/pull/1385.patch","issue_url":"https://api.github.com/repos/bjorn/tiled/issues/1385","number":1385,"state":"open","locked":false,"title":"Updated schema to follow the TMX format page","user":{"login":"assofohdz","id":8222915,"avatar_url":"https://avatars.githubusercontent.com/u/8222915?v=3","gravatar_id":"","url":"https://api.github.com/users/assofohdz","html_url":"https://github.com/assofohdz","followers_url":"https://api.github.com/users/assofohdz/followers","following_url":"https://api.github.com/users/assofohdz/following{/other_user}","gists_url":"https://api.github.com/users/assofohdz/gists{/gist_id}","starred_url":"https://api.github.com/users/assofohdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assofohdz/subscriptions","organizations_url":"https://api.github.com/users/assofohdz/orgs","repos_url":"https://api.github.com/users/assofohdz/repos","events_url":"https://api.github.com/users/assofohdz/events{/privacy}","received_events_url":"https://api.github.com/users/assofohdz/received_events","type":"User","site_admin":false},"body":"It's a beginning towards an updated format. Many things in the XSD depends on the how you use it inside Tiled, which is ambigious in the TMX format page.","created_at":"2016-10-25T20:09:39Z","updated_at":"2016-10-27T09:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a75b1b1a4e4e6fa92d253dd2d446f3ba89bad999","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bjorn/tiled/pulls/1385/commits","review_comments_url":"https://api.github.com/repos/bjorn/tiled/pulls/1385/comments","review_comment_url":"https://api.github.com/repos/bjorn/tiled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bjorn/tiled/issues/1385/comments","statuses_url":"https://api.github.com/repos/bjorn/tiled/statuses/58e44eb0cb7b7adfeb89a7481b5fa9571a1c2676","head":{"label":"assofohdz:master","ref":"master","sha":"58e44eb0cb7b7adfeb89a7481b5fa9571a1c2676","user":{"login":"assofohdz","id":8222915,"avatar_url":"https://avatars.githubusercontent.com/u/8222915?v=3","gravatar_id":"","url":"https://api.github.com/users/assofohdz","html_url":"https://github.com/assofohdz","followers_url":"https://api.github.com/users/assofohdz/followers","following_url":"https://api.github.com/users/assofohdz/following{/other_user}","gists_url":"https://api.github.com/users/assofohdz/gists{/gist_id}","starred_url":"https://api.github.com/users/assofohdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assofohdz/subscriptions","organizations_url":"https://api.github.com/users/assofohdz/orgs","repos_url":"https://api.github.com/users/assofohdz/repos","events_url":"https://api.github.com/users/assofohdz/events{/privacy}","received_events_url":"https://api.github.com/users/assofohdz/received_events","type":"User","site_admin":false},"repo":{"id":71924297,"name":"tiled","full_name":"assofohdz/tiled","owner":{"login":"assofohdz","id":8222915,"avatar_url":"https://avatars.githubusercontent.com/u/8222915?v=3","gravatar_id":"","url":"https://api.github.com/users/assofohdz","html_url":"https://github.com/assofohdz","followers_url":"https://api.github.com/users/assofohdz/followers","following_url":"https://api.github.com/users/assofohdz/following{/other_user}","gists_url":"https://api.github.com/users/assofohdz/gists{/gist_id}","starred_url":"https://api.github.com/users/assofohdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assofohdz/subscriptions","organizations_url":"https://api.github.com/users/assofohdz/orgs","repos_url":"https://api.github.com/users/assofohdz/repos","events_url":"https://api.github.com/users/assofohdz/events{/privacy}","received_events_url":"https://api.github.com/users/assofohdz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/assofohdz/tiled","description":"A generic tile map editor","fork":true,"url":"https://api.github.com/repos/assofohdz/tiled","forks_url":"https://api.github.com/repos/assofohdz/tiled/forks","keys_url":"https://api.github.com/repos/assofohdz/tiled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assofohdz/tiled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assofohdz/tiled/teams","hooks_url":"https://api.github.com/repos/assofohdz/tiled/hooks","issue_events_url":"https://api.github.com/repos/assofohdz/tiled/issues/events{/number}","events_url":"https://api.github.com/repos/assofohdz/tiled/events","assignees_url":"https://api.github.com/repos/assofohdz/tiled/assignees{/user}","branches_url":"https://api.github.com/repos/assofohdz/tiled/branches{/branch}","tags_url":"https://api.github.com/repos/assofohdz/tiled/tags","blobs_url":"https://api.github.com/repos/assofohdz/tiled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assofohdz/tiled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assofohdz/tiled/git/refs{/sha}","trees_url":"https://api.github.com/repos/assofohdz/tiled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assofohdz/tiled/statuses/{sha}","languages_url":"https://api.github.com/repos/assofohdz/tiled/languages","stargazers_url":"https://api.github.com/repos/assofohdz/tiled/stargazers","contributors_url":"https://api.github.com/repos/assofohdz/tiled/contributors","subscribers_url":"https://api.github.com/repos/assofohdz/tiled/subscribers","subscription_url":"https://api.github.com/repos/assofohdz/tiled/subscription","commits_url":"https://api.github.com/repos/assofohdz/tiled/commits{/sha}","git_commits_url":"https://api.github.com/repos/assofohdz/tiled/git/commits{/sha}","comments_url":"https://api.github.com/repos/assofohdz/tiled/comments{/number}","issue_comment_url":"https://api.github.com/repos/assofohdz/tiled/issues/comments{/number}","contents_url":"https://api.github.com/repos/assofohdz/tiled/contents/{+path}","compare_url":"https://api.github.com/repos/assofohdz/tiled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assofohdz/tiled/merges","archive_url":"https://api.github.com/repos/assofohdz/tiled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assofohdz/tiled/downloads","issues_url":"https://api.github.com/repos/assofohdz/tiled/issues{/number}","pulls_url":"https://api.github.com/repos/assofohdz/tiled/pulls{/number}","milestones_url":"https://api.github.com/repos/assofohdz/tiled/milestones{/number}","notifications_url":"https://api.github.com/repos/assofohdz/tiled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assofohdz/tiled/labels{/name}","releases_url":"https://api.github.com/repos/assofohdz/tiled/releases{/id}","deployments_url":"https://api.github.com/repos/assofohdz/tiled/deployments","created_at":"2016-10-25T17:57:16Z","updated_at":"2016-10-25T17:57:18Z","pushed_at":"2016-10-27T06:19:04Z","git_url":"git://github.com/assofohdz/tiled.git","ssh_url":"git@github.com:assofohdz/tiled.git","clone_url":"https://github.com/assofohdz/tiled.git","svn_url":"https://github.com/assofohdz/tiled","homepage":"http://www.mapeditor.org/","size":20757,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bjorn:master","ref":"master","sha":"fb1839b41d4797c87e5bb7183209c044fe244714","user":{"login":"bjorn","id":531764,"avatar_url":"https://avatars.githubusercontent.com/u/531764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"repo":{"id":1418150,"name":"tiled","full_name":"bjorn/tiled","owner":{"login":"bjorn","id":531764,"avatar_url":"https://avatars.githubusercontent.com/u/531764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjorn/tiled","description":"A generic tile map editor","fork":false,"url":"https://api.github.com/repos/bjorn/tiled","forks_url":"https://api.github.com/repos/bjorn/tiled/forks","keys_url":"https://api.github.com/repos/bjorn/tiled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjorn/tiled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjorn/tiled/teams","hooks_url":"https://api.github.com/repos/bjorn/tiled/hooks","issue_events_url":"https://api.github.com/repos/bjorn/tiled/issues/events{/number}","events_url":"https://api.github.com/repos/bjorn/tiled/events","assignees_url":"https://api.github.com/repos/bjorn/tiled/assignees{/user}","branches_url":"https://api.github.com/repos/bjorn/tiled/branches{/branch}","tags_url":"https://api.github.com/repos/bjorn/tiled/tags","blobs_url":"https://api.github.com/repos/bjorn/tiled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjorn/tiled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjorn/tiled/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjorn/tiled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjorn/tiled/statuses/{sha}","languages_url":"https://api.github.com/repos/bjorn/tiled/languages","stargazers_url":"https://api.github.com/repos/bjorn/tiled/stargazers","contributors_url":"https://api.github.com/repos/bjorn/tiled/contributors","subscribers_url":"https://api.github.com/repos/bjorn/tiled/subscribers","subscription_url":"https://api.github.com/repos/bjorn/tiled/subscription","commits_url":"https://api.github.com/repos/bjorn/tiled/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjorn/tiled/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjorn/tiled/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjorn/tiled/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjorn/tiled/contents/{+path}","compare_url":"https://api.github.com/repos/bjorn/tiled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjorn/tiled/merges","archive_url":"https://api.github.com/repos/bjorn/tiled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjorn/tiled/downloads","issues_url":"https://api.github.com/repos/bjorn/tiled/issues{/number}","pulls_url":"https://api.github.com/repos/bjorn/tiled/pulls{/number}","milestones_url":"https://api.github.com/repos/bjorn/tiled/milestones{/number}","notifications_url":"https://api.github.com/repos/bjorn/tiled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjorn/tiled/labels{/name}","releases_url":"https://api.github.com/repos/bjorn/tiled/releases{/id}","deployments_url":"https://api.github.com/repos/bjorn/tiled/deployments","created_at":"2011-02-27T15:18:22Z","updated_at":"2016-10-27T03:07:53Z","pushed_at":"2016-10-27T06:19:06Z","git_url":"git://github.com/bjorn/tiled.git","ssh_url":"git@github.com:bjorn/tiled.git","clone_url":"https://github.com/bjorn/tiled.git","svn_url":"https://github.com/bjorn/tiled","homepage":"http://www.mapeditor.org/","size":65767,"stargazers_count":4195,"watchers_count":4195,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":911,"mirror_url":null,"open_issues_count":335,"forks":911,"open_issues":335,"watchers":4195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1385"},"html":{"href":"https://github.com/bjorn/tiled/pull/1385"},"issue":{"href":"https://api.github.com/repos/bjorn/tiled/issues/1385"},"comments":{"href":"https://api.github.com/repos/bjorn/tiled/issues/1385/comments"},"review_comments":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1385/comments"},"review_comment":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1385/commits"},"statuses":{"href":"https://api.github.com/repos/bjorn/tiled/statuses/58e44eb0cb7b7adfeb89a7481b5fa9571a1c2676"}}}}
{"actor":{"display_login":"bjorn"}}