{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/58271551","id":58271551,"diff_hunk":"@@ -2784,7 +2787,8 @@ static VkBool32 validate_and_capture_pipeline_shader_state(layer_data *my_data,\n }\n \n static VkBool32 validate_compute_pipeline(layer_data *my_data, PIPELINE_NODE *pPipeline) {\n-    VkComputePipelineCreateInfo const *pCreateInfo = &pPipeline->computePipelineCI;\n+    VkComputePipelineCreateInfo const *pCreateInfo =","path":"layers/core_validation.cpp","position":56,"original_position":56,"commit_id":"bc12e4986b8e14f07c075d2e065da7601386b06f","original_commit_id":"bc12e4986b8e14f07c075d2e065da7601386b06f","user":{"login":"chrisforbes","id":128877,"avatar_url":"https://avatars.githubusercontent.com/u/128877?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisforbes","html_url":"https://github.com/chrisforbes","followers_url":"https://api.github.com/users/chrisforbes/followers","following_url":"https://api.github.com/users/chrisforbes/following{/other_user}","gists_url":"https://api.github.com/users/chrisforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisforbes/subscriptions","organizations_url":"https://api.github.com/users/chrisforbes/orgs","repos_url":"https://api.github.com/users/chrisforbes/repos","events_url":"https://api.github.com/users/chrisforbes/events{/privacy}","received_events_url":"https://api.github.com/users/chrisforbes/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2016-04-01T21:41:41Z","updated_at":"2016-04-01T21:41:41Z","html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/244#discussion_r58271551","pull_request_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/58271551"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/244#discussion_r58271551"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244","id":64996530,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/244","diff_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/244.diff","patch_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/244.patch","issue_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/244","number":244,"state":"open","locked":false,"title":"layers: Clean up PIPELINE_NODE using safe_struct","user":{"login":"tobine","id":7526739,"avatar_url":"https://avatars.githubusercontent.com/u/7526739?v=3","gravatar_id":"","url":"https://api.github.com/users/tobine","html_url":"https://github.com/tobine","followers_url":"https://api.github.com/users/tobine/followers","following_url":"https://api.github.com/users/tobine/following{/other_user}","gists_url":"https://api.github.com/users/tobine/gists{/gist_id}","starred_url":"https://api.github.com/users/tobine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobine/subscriptions","organizations_url":"https://api.github.com/users/tobine/orgs","repos_url":"https://api.github.com/users/tobine/repos","events_url":"https://api.github.com/users/tobine/events{/privacy}","received_events_url":"https://api.github.com/users/tobine/received_events","type":"User","site_admin":false},"body":"PIPELINE_NODE was storing ptrs from the app and has some ugly initialization code\r\nfor the gfx pipeline create struct. This commit switches pipeline node to use\r\nsafe_struct wrappers for Gfx and Compute create info.\r\nThere were also some bugs found in the safe_struct wrappers making this migration\r\nso those are cleaned up in this commit as well.","created_at":"2016-04-01T19:54:55Z","updated_at":"2016-04-01T21:41:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a10b295acf754df7e6bf91e365ca992985bc5c3","assignee":{"login":"lentinem","id":9709345,"avatar_url":"https://avatars.githubusercontent.com/u/9709345?v=3","gravatar_id":"","url":"https://api.github.com/users/lentinem","html_url":"https://github.com/lentinem","followers_url":"https://api.github.com/users/lentinem/followers","following_url":"https://api.github.com/users/lentinem/following{/other_user}","gists_url":"https://api.github.com/users/lentinem/gists{/gist_id}","starred_url":"https://api.github.com/users/lentinem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lentinem/subscriptions","organizations_url":"https://api.github.com/users/lentinem/orgs","repos_url":"https://api.github.com/users/lentinem/repos","events_url":"https://api.github.com/users/lentinem/events{/privacy}","received_events_url":"https://api.github.com/users/lentinem/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/244/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/bc12e4986b8e14f07c075d2e065da7601386b06f","head":{"label":"KhronosGroup:tobin_gh192_safe_struct_gfx_pipeline","ref":"tobin_gh192_safe_struct_gfx_pipeline","sha":"bc12e4986b8e14f07c075d2e065da7601386b06f","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-04-01T19:22:52Z","pushed_at":"2016-04-01T21:35:29Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":44983,"stargazers_count":156,"watchers_count":156,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":46,"forks":41,"open_issues":46,"watchers":156,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"3e04b61c5400de5eae22313be467692a21ffde97","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-04-01T19:22:52Z","pushed_at":"2016-04-01T21:35:29Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":44983,"stargazers_count":156,"watchers_count":156,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":46,"forks":41,"open_issues":46,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/244"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/244"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/bc12e4986b8e14f07c075d2e065da7601386b06f"}}}}