{"action":"created","issue":{"url":"https://api.github.com/repos/seperman/deepdiff/issues/32","repository_url":"https://api.github.com/repos/seperman/deepdiff","labels_url":"https://api.github.com/repos/seperman/deepdiff/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/seperman/deepdiff/issues/32/comments","events_url":"https://api.github.com/repos/seperman/deepdiff/issues/32/events","html_url":"https://github.com/seperman/deepdiff/pull/32","id":166377736,"number":32,"title":"Deep-compare custom objects within sets","user":{"login":"victorhahncastell","id":3177019,"avatar_url":"https://avatars.githubusercontent.com/u/3177019?v=3","gravatar_id":"","url":"https://api.github.com/users/victorhahncastell","html_url":"https://github.com/victorhahncastell","followers_url":"https://api.github.com/users/victorhahncastell/followers","following_url":"https://api.github.com/users/victorhahncastell/following{/other_user}","gists_url":"https://api.github.com/users/victorhahncastell/gists{/gist_id}","starred_url":"https://api.github.com/users/victorhahncastell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorhahncastell/subscriptions","organizations_url":"https://api.github.com/users/victorhahncastell/orgs","repos_url":"https://api.github.com/users/victorhahncastell/repos","events_url":"https://api.github.com/users/victorhahncastell/events{/privacy}","received_events_url":"https://api.github.com/users/victorhahncastell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"seperman","id":2314797,"avatar_url":"https://avatars.githubusercontent.com/u/2314797?v=3","gravatar_id":"","url":"https://api.github.com/users/seperman","html_url":"https://github.com/seperman","followers_url":"https://api.github.com/users/seperman/followers","following_url":"https://api.github.com/users/seperman/following{/other_user}","gists_url":"https://api.github.com/users/seperman/gists{/gist_id}","starred_url":"https://api.github.com/users/seperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seperman/subscriptions","organizations_url":"https://api.github.com/users/seperman/orgs","repos_url":"https://api.github.com/users/seperman/repos","events_url":"https://api.github.com/users/seperman/events{/privacy}","received_events_url":"https://api.github.com/users/seperman/received_events","type":"User","site_admin":false},"assignees":[{"login":"seperman","id":2314797,"avatar_url":"https://avatars.githubusercontent.com/u/2314797?v=3","gravatar_id":"","url":"https://api.github.com/users/seperman","html_url":"https://github.com/seperman","followers_url":"https://api.github.com/users/seperman/followers","following_url":"https://api.github.com/users/seperman/following{/other_user}","gists_url":"https://api.github.com/users/seperman/gists{/gist_id}","starred_url":"https://api.github.com/users/seperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seperman/subscriptions","organizations_url":"https://api.github.com/users/seperman/orgs","repos_url":"https://api.github.com/users/seperman/repos","events_url":"https://api.github.com/users/seperman/events{/privacy}","received_events_url":"https://api.github.com/users/seperman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-19T16:39:19Z","updated_at":"2016-07-19T22:57:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/seperman/deepdiff/pulls/32","html_url":"https://github.com/seperman/deepdiff/pull/32","diff_url":"https://github.com/seperman/deepdiff/pull/32.diff","patch_url":"https://github.com/seperman/deepdiff/pull/32.patch"},"body":"Quite a big change for a rather peculiar bug. DeepDiff failed to deep-compare custom objects within a set. As sets are used internally to compare dicts ignoring the order this bug also affected dicts.\r\n\r\nThis PR introduces an additional class, DeepSet, which is essentially a set providing deep comparison.\r\n\r\nDeepSet is not feature complete yet, but does satisfy DeepDiff's requirements (for now).\r\n\r\nA similar, still unfixed bug involves dicts containing equal (but not identical) custom objects as keys. This does not work yet because we also need a DeepDict that supports the [] operator for equal but not identical objects. We'd also need to implement a couple more set features in DeepSet. A test for this is in my fix_diff_dict_keys branch -- I didn't get a chance to implement a fix though, as right not, the feature is not on my personal requirements list."},"comment":{"url":"https://api.github.com/repos/seperman/deepdiff/issues/comments/233791533","html_url":"https://github.com/seperman/deepdiff/pull/32#issuecomment-233791533","issue_url":"https://api.github.com/repos/seperman/deepdiff/issues/32","id":233791533,"user":{"login":"seperman","id":2314797,"avatar_url":"https://avatars.githubusercontent.com/u/2314797?v=3","gravatar_id":"","url":"https://api.github.com/users/seperman","html_url":"https://github.com/seperman","followers_url":"https://api.github.com/users/seperman/followers","following_url":"https://api.github.com/users/seperman/following{/other_user}","gists_url":"https://api.github.com/users/seperman/gists{/gist_id}","starred_url":"https://api.github.com/users/seperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seperman/subscriptions","organizations_url":"https://api.github.com/users/seperman/orgs","repos_url":"https://api.github.com/users/seperman/repos","events_url":"https://api.github.com/users/seperman/events{/privacy}","received_events_url":"https://api.github.com/users/seperman/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T22:57:47Z","updated_at":"2016-07-19T22:57:47Z","body":"@victorhahncastell Wow, that is indeed a big PR. I will look at it asap. Thanks."}}
{"actor":{"display_login":"seperman"}}