{"action":"created","comment":{"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/63280350","id":63280350,"diff_hunk":"@@ -31,32 +31,38 @@ static void init_cpu_id()\n \n int cpu_device_init(void)\n {\n-    /*TODO BAP fix this so we jump to the correct location */\n-    //NVIC_SetVectorTable(NVIC_VectTab_FLASH, _flash_start);\n-    NVIC_PriorityGroupConfig(NVIC_PriorityGroup_4);\n-    init_cpu_id();\n-    return 1;\n+\tNVIC_SetVectorTable(NVIC_VectTab_FLASH, (uint32_t)&_flash_start);\n+\tNVIC_PriorityGroupConfig(NVIC_PriorityGroup_4);\n+\tinit_cpu_id();\n+\treturn 1;\n }\n \n void cpu_device_reset(int bootloader)\n {\n-    /* struct app_handshake_block *handshake = */\n-    /*     (struct app_handshake_block *)HANDSHAKE_ADDR; */\n+\tstruct app_handshake_block *handshake =\n+\t\t(struct app_handshake_block *)HANDSHAKE_ADDR;\n \n-    /* Clear any reset flags that might be present (i.e. watchdog) */\n-    RCC_ClearFlag();\n+\t/* Clear any reset flags that might be present (i.e. watchdog) */\n+\tRCC_ClearFlag();\n \n-    /*TODO BAP enable bootloader */\n-    /* If bootloader mode is requested, Set the flag in the\n-     * handshake area */\n-/*    if (bootloader == 1) {\n-        handshake->loader_magic = LOADER_KEY;\n-    } */\n+\t/*\n+\t * If bootloader mode is requested, Set the flag in the\n+\t * handshake area\n+\t */\n+\tif (bootloader == 1) {\n+\t\thandshake->loader_magic = LOADER_KEY;\n+\t}\n \n-    NVIC_SystemReset();\n+\tNVIC_SystemReset();\n }\n \n const char *cpu_device_get_serialnumber(void)\n {\n     return cpu_id;\n }\n+\n+void assert_failed(uint8_t* file, uint32_t line)\n+{\n+\twhile(1);","path":"platform/rct/hal/cpu_stm32/cpu_device_stm32.c","position":52,"original_position":52,"commit_id":"92a0543a9bbd7ca1a351b6d5f8e937d467d22629","original_commit_id":"92a0543a9bbd7ca1a351b6d5f8e937d467d22629","user":{"login":"Jeff-Ciesielski","id":759677,"avatar_url":"https://avatars.githubusercontent.com/u/759677?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeff-Ciesielski","html_url":"https://github.com/Jeff-Ciesielski","followers_url":"https://api.github.com/users/Jeff-Ciesielski/followers","following_url":"https://api.github.com/users/Jeff-Ciesielski/following{/other_user}","gists_url":"https://api.github.com/users/Jeff-Ciesielski/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeff-Ciesielski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeff-Ciesielski/subscriptions","organizations_url":"https://api.github.com/users/Jeff-Ciesielski/orgs","repos_url":"https://api.github.com/users/Jeff-Ciesielski/repos","events_url":"https://api.github.com/users/Jeff-Ciesielski/events{/privacy}","received_events_url":"https://api.github.com/users/Jeff-Ciesielski/received_events","type":"User","site_admin":false},"body":"It does exactly what I want (and is how I caught the struct init bug).  This is specifically to catch bugs in ST's peripheral library.","created_at":"2016-05-14T18:51:17Z","updated_at":"2016-05-14T18:51:17Z","html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/617#discussion_r63280350","pull_request_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments/63280350"},"html":{"href":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/617#discussion_r63280350"},"pull_request":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617"}}},"pull_request":{"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617","id":70092286,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/617","diff_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/617.diff","patch_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/617.patch","issue_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/617","number":617,"state":"open","locked":false,"title":"P/jeffc/rct bootloader support","user":{"login":"Jeff-Ciesielski","id":759677,"avatar_url":"https://avatars.githubusercontent.com/u/759677?v=3","gravatar_id":"","url":"https://api.github.com/users/Jeff-Ciesielski","html_url":"https://github.com/Jeff-Ciesielski","followers_url":"https://api.github.com/users/Jeff-Ciesielski/followers","following_url":"https://api.github.com/users/Jeff-Ciesielski/following{/other_user}","gists_url":"https://api.github.com/users/Jeff-Ciesielski/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeff-Ciesielski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeff-Ciesielski/subscriptions","organizations_url":"https://api.github.com/users/Jeff-Ciesielski/orgs","repos_url":"https://api.github.com/users/Jeff-Ciesielski/repos","events_url":"https://api.github.com/users/Jeff-Ciesielski/events{/privacy}","received_events_url":"https://api.github.com/users/Jeff-Ciesielski/received_events","type":"User","site_admin":false},"body":"We'll probably want to hold off merging this until the bootloader changes are merged and ihextools is updated in the app. (And everyone involved has flashed a bootloader to their boards, obviously...)","created_at":"2016-05-14T13:39:00Z","updated_at":"2016-05-14T18:51:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abfaf716802e087c0a373af5f8aeef83321e5317","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617/commits","review_comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617/comments","review_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/617/comments","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/92a0543a9bbd7ca1a351b6d5f8e937d467d22629","head":{"label":"autosportlabs:p/jeffc/rct_bootloader_support","ref":"p/jeffc/rct_bootloader_support","sha":"92a0543a9bbd7ca1a351b6d5f8e937d467d22629","user":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10069490,"name":"RaceCapture-Pro_firmware","full_name":"autosportlabs/RaceCapture-Pro_firmware","owner":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","description":"Firmware for RaceCapture-Pro Data Acquisition, control and Telemetry system for motorsports","fork":false,"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware","forks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/forks","keys_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/teams","hooks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/hooks","issue_events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/events","assignees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/tags","blobs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/languages","stargazers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/stargazers","contributors_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contributors","subscribers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscribers","subscription_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscription","commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/merges","archive_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/downloads","issues_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/labels{/name}","releases_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/deployments","created_at":"2013-05-15T02:30:10Z","updated_at":"2016-04-12T00:05:19Z","pushed_at":"2016-05-14T18:46:40Z","git_url":"git://github.com/autosportlabs/RaceCapture-Pro_firmware.git","ssh_url":"git@github.com:autosportlabs/RaceCapture-Pro_firmware.git","clone_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware.git","svn_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","homepage":null,"size":24895,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":154,"forks":12,"open_issues":154,"watchers":17,"default_branch":"master"}},"base":{"label":"autosportlabs:r/2.10.0","ref":"r/2.10.0","sha":"c6d8602c77ba902476a6b63e295a2414f9182435","user":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10069490,"name":"RaceCapture-Pro_firmware","full_name":"autosportlabs/RaceCapture-Pro_firmware","owner":{"login":"autosportlabs","id":1274125,"avatar_url":"https://avatars.githubusercontent.com/u/1274125?v=3","gravatar_id":"","url":"https://api.github.com/users/autosportlabs","html_url":"https://github.com/autosportlabs","followers_url":"https://api.github.com/users/autosportlabs/followers","following_url":"https://api.github.com/users/autosportlabs/following{/other_user}","gists_url":"https://api.github.com/users/autosportlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/autosportlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autosportlabs/subscriptions","organizations_url":"https://api.github.com/users/autosportlabs/orgs","repos_url":"https://api.github.com/users/autosportlabs/repos","events_url":"https://api.github.com/users/autosportlabs/events{/privacy}","received_events_url":"https://api.github.com/users/autosportlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","description":"Firmware for RaceCapture-Pro Data Acquisition, control and Telemetry system for motorsports","fork":false,"url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware","forks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/forks","keys_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/teams","hooks_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/hooks","issue_events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/events","assignees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/tags","blobs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/languages","stargazers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/stargazers","contributors_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contributors","subscribers_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscribers","subscription_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/subscription","commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/merges","archive_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/downloads","issues_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/labels{/name}","releases_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/deployments","created_at":"2013-05-15T02:30:10Z","updated_at":"2016-04-12T00:05:19Z","pushed_at":"2016-05-14T18:46:40Z","git_url":"git://github.com/autosportlabs/RaceCapture-Pro_firmware.git","ssh_url":"git@github.com:autosportlabs/RaceCapture-Pro_firmware.git","clone_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware.git","svn_url":"https://github.com/autosportlabs/RaceCapture-Pro_firmware","homepage":null,"size":24895,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":154,"forks":12,"open_issues":154,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617"},"html":{"href":"https://github.com/autosportlabs/RaceCapture-Pro_firmware/pull/617"},"issue":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/617"},"comments":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/issues/617/comments"},"review_comments":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617/comments"},"review_comment":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/pulls/617/commits"},"statuses":{"href":"https://api.github.com/repos/autosportlabs/RaceCapture-Pro_firmware/statuses/92a0543a9bbd7ca1a351b6d5f8e937d467d22629"}}}}