{"action":"created","issue":{"url":"https://api.github.com/repos/popcornmix/omxplayer/issues/463","repository_url":"https://api.github.com/repos/popcornmix/omxplayer","labels_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/463/comments","events_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/463/events","html_url":"https://github.com/popcornmix/omxplayer/pull/463","id":154853855,"number":463,"title":"Initial alsa support","user":{"login":"fabled","id":389042,"avatar_url":"https://avatars.githubusercontent.com/u/389042?v=3","gravatar_id":"","url":"https://api.github.com/users/fabled","html_url":"https://github.com/fabled","followers_url":"https://api.github.com/users/fabled/followers","following_url":"https://api.github.com/users/fabled/following{/other_user}","gists_url":"https://api.github.com/users/fabled/gists{/gist_id}","starred_url":"https://api.github.com/users/fabled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabled/subscriptions","organizations_url":"https://api.github.com/users/fabled/orgs","repos_url":"https://api.github.com/users/fabled/repos","events_url":"https://api.github.com/users/fabled/events{/privacy}","received_events_url":"https://api.github.com/users/fabled/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2016-05-14T13:31:28Z","updated_at":"2016-08-02T14:41:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/popcornmix/omxplayer/pulls/463","html_url":"https://github.com/popcornmix/omxplayer/pull/463","diff_url":"https://github.com/popcornmix/omxplayer/pull/463.diff","patch_url":"https://github.com/popcornmix/omxplayer/pull/463.patch"},"body":"Standalone, clean and from the scratch written OMX/Alsa driver implementation for omxplayer."},"comment":{"url":"https://api.github.com/repos/popcornmix/omxplayer/issues/comments/236925707","html_url":"https://github.com/popcornmix/omxplayer/pull/463#issuecomment-236925707","issue_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/463","id":236925707,"user":{"login":"popcornmix","id":1053730,"avatar_url":"https://avatars.githubusercontent.com/u/1053730?v=3","gravatar_id":"","url":"https://api.github.com/users/popcornmix","html_url":"https://github.com/popcornmix","followers_url":"https://api.github.com/users/popcornmix/followers","following_url":"https://api.github.com/users/popcornmix/following{/other_user}","gists_url":"https://api.github.com/users/popcornmix/gists{/gist_id}","starred_url":"https://api.github.com/users/popcornmix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popcornmix/subscriptions","organizations_url":"https://api.github.com/users/popcornmix/orgs","repos_url":"https://api.github.com/users/popcornmix/repos","events_url":"https://api.github.com/users/popcornmix/events{/privacy}","received_events_url":"https://api.github.com/users/popcornmix/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T14:41:15Z","updated_at":"2016-08-02T14:41:15Z","body":"The OMX_BUFFERFLAG_EOS packet is zero length in audio_decode.\r\nI think the problem is after ad_process_output_buffer, we do:\r\n```\r\n       if(out->nFilledLen || out->nFlags)\r\n       {\r\n          // there was something to send this time, make sure we try again as there might be more we can do.\r\n          done = 0;\r\n          id->callbacks.processed_buffer(id->callback_state, out, OMX_DirOutput);\r\n          out = NULL;\r\n       }\r\n```\r\n(out->nFilledLen=0, out->nFlags=OMX_BUFFERFLAG_EOS)\r\nI think this code generates a OMX_EventBufferFlag, 121, 1 event, and discards the EOS buffer, so I don't think the arm size audio_render sees the EOS (the event went to audio_decode)."}}
{"actor":{"display_login":"popcornmix"}}