{"action":"created","issue":{"url":"https://api.github.com/repos/resin-io/resin-sdk/issues/239","repository_url":"https://api.github.com/repos/resin-io/resin-sdk","labels_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/239/comments","events_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/239/events","html_url":"https://github.com/resin-io/resin-sdk/pull/239","id":195539600,"number":239,"title":"Make the tests stable","user":{"login":"pimterry","id":1526883,"avatar_url":"https://avatars.githubusercontent.com/u/1526883?v=3","gravatar_id":"","url":"https://api.github.com/users/pimterry","html_url":"https://github.com/pimterry","followers_url":"https://api.github.com/users/pimterry/followers","following_url":"https://api.github.com/users/pimterry/following{/other_user}","gists_url":"https://api.github.com/users/pimterry/gists{/gist_id}","starred_url":"https://api.github.com/users/pimterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimterry/subscriptions","organizations_url":"https://api.github.com/users/pimterry/orgs","repos_url":"https://api.github.com/users/pimterry/repos","events_url":"https://api.github.com/users/pimterry/events{/privacy}","received_events_url":"https://api.github.com/users/pimterry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-12-14T14:07:33Z","updated_at":"2016-12-14T20:23:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/resin-io/resin-sdk/pulls/239","html_url":"https://github.com/resin-io/resin-sdk/pull/239","diff_url":"https://github.com/resin-io/resin-sdk/pull/239.diff","patch_url":"https://github.com/resin-io/resin-sdk/pull/239.patch"},"body":"This fixes #237, building on top of #236.\r\n\r\nThis change is very simple, just fixes a Karma config bug (arguably a Karma bug, see karma-runner/karma#2505), brings in the new resin-request and puts resin-io-modules/resin-request#78 and resin-io-modules/resin-request#79 to use.\r\n\r\nEnd result is that we now output some debug info during the tests about the requests being made, and retry failing requests. The debug output is just so we can debug this better if it does start to go wrong later - it's a bit noisy for now, but we can remove it soon once we're sure this change makes the tests stable."},"comment":{"url":"https://api.github.com/repos/resin-io/resin-sdk/issues/comments/267145611","html_url":"https://github.com/resin-io/resin-sdk/pull/239#issuecomment-267145611","issue_url":"https://api.github.com/repos/resin-io/resin-sdk/issues/239","id":267145611,"user":{"login":"pimterry","id":1526883,"avatar_url":"https://avatars.githubusercontent.com/u/1526883?v=3","gravatar_id":"","url":"https://api.github.com/users/pimterry","html_url":"https://github.com/pimterry","followers_url":"https://api.github.com/users/pimterry/followers","following_url":"https://api.github.com/users/pimterry/following{/other_user}","gists_url":"https://api.github.com/users/pimterry/gists{/gist_id}","starred_url":"https://api.github.com/users/pimterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimterry/subscriptions","organizations_url":"https://api.github.com/users/pimterry/orgs","repos_url":"https://api.github.com/users/pimterry/repos","events_url":"https://api.github.com/users/pimterry/events{/privacy}","received_events_url":"https://api.github.com/users/pimterry/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T20:23:07Z","updated_at":"2016-12-14T20:23:07Z","body":"> UUIDs should be globally unique, and it looks like the tests try to delete a record that's FKed by something else.\r\n\r\nAutogenerated ones will be, but the test explicitly provides fixed UUIDs: https://github.com/resin-io/resin-sdk/blob/af90835dee327bb450239bc768aeea56b09cdc6d/tests/integration.spec.coffee#L1129-L1130. I was assuming that that's why they're conflicting: both create the same device, and end up failing at some point because of the existing FK relationships (not sure where, maybe when you create new a device with an existing UUID but within a different application it explodes? Sounds like it should imo). Does that sound plausible?\r\n\r\nI think we can find a way to isolate these though, at the cost of some extra complexity (assuming the above is right). I'll take a look tomorrow - let me know if I'm totally off track or if this isn't worth fixing."}}
{"actor":{"display_login":"pimterry"}}