{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5995","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5995/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5995/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5995/events","html_url":"https://github.com/ManageIQ/manageiq/pull/5995","id":124002952,"number":5995,"title":"Event scopes","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/gem%20changes","name":"gem changes","color":"6A92BC"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/rails5","name":"rails5","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-28T00:30:26Z","updated_at":"2016-01-04T21:08:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5995","html_url":"https://github.com/ManageIQ/manageiq/pull/5995","diff_url":"https://github.com/ManageIQ/manageiq/pull/5995.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5995.patch"},"body":"High level: Picking off entries that are building sql when they could use scopes\r\n\r\nThis targets event where clause. Instead of returning string sql, it builds it up using a scope.\r\nThere are a few spots that use `OR`, so the `where-or` gem is introduced. @matthewd will delete this once we are on rails 5.\r\n\r\nNeed some help sanity checking these entries.\r\nProbably need to revisit specs around these specific cases.\r\n\r\n\r\n/cc @matthewd you seem to find the spots where I slip on this type of work."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/168809303","html_url":"https://github.com/ManageIQ/manageiq/pull/5995#issuecomment-168809303","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5995","id":168809303,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T21:08:27Z","updated_at":"2016-01-04T21:08:27Z","body":"<rubocop />Checked commit https://github.com/kbrock/manageiq/commit/2b9e2c1bccc0a3597b1be4b4ebb4d8ba830390f2 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0\n12 files checked, 0 offenses detected\nEverything looks good. :cake:\n"}}