{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/61864220","id":61864220,"diff_hunk":"@@ -626,43 +651,46 @@ class BasketFormat(FileFormat):\n     EXTENSIONS = ('.basket', '.bsk')\n     DESCRIPTION = 'Basket file'\n \n-    @classmethod\n-    def read_file(cls, filename, storage_class=None):\n-        from Orange.data import _io, Table, Domain\n-        import sys\n-        if storage_class is None:\n-            storage_class = Table\n+    def read(self):\n+        if self.wrapper is None or self.wrapper is _IDENTITY:\n+            self.wrapper = Table","path":"Orange/data/io.py","position":null,"original_position":242,"commit_id":"ce70666726ae44ffec1d781278871063f3abdc96","original_commit_id":"6d7b148e3f7cd70028dc6d5954b9b6bc5fb16104","user":{"login":"astaric","id":588601,"avatar_url":"https://avatars.githubusercontent.com/u/588601?v=3","gravatar_id":"","url":"https://api.github.com/users/astaric","html_url":"https://github.com/astaric","followers_url":"https://api.github.com/users/astaric/followers","following_url":"https://api.github.com/users/astaric/following{/other_user}","gists_url":"https://api.github.com/users/astaric/gists{/gist_id}","starred_url":"https://api.github.com/users/astaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaric/subscriptions","organizations_url":"https://api.github.com/users/astaric/orgs","repos_url":"https://api.github.com/users/astaric/repos","events_url":"https://api.github.com/users/astaric/events{/privacy}","received_events_url":"https://api.github.com/users/astaric/received_events","type":"User","site_admin":false},"body":"I agree. See ce70666\r\n","created_at":"2016-05-03T10:50:47Z","updated_at":"2016-05-03T10:50:47Z","html_url":"https://github.com/biolab/orange3/pull/1177#discussion_r61864220","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/1177","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/61864220"},"html":{"href":"https://github.com/biolab/orange3/pull/1177#discussion_r61864220"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1177"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/1177","id":66333847,"html_url":"https://github.com/biolab/orange3/pull/1177","diff_url":"https://github.com/biolab/orange3/pull/1177.diff","patch_url":"https://github.com/biolab/orange3/pull/1177.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/1177","number":1177,"state":"open","locked":false,"title":"Refactor data.io","user":{"login":"astaric","id":588601,"avatar_url":"https://avatars.githubusercontent.com/u/588601?v=3","gravatar_id":"","url":"https://api.github.com/users/astaric","html_url":"https://github.com/astaric","followers_url":"https://api.github.com/users/astaric/followers","following_url":"https://api.github.com/users/astaric/following{/other_user}","gists_url":"https://api.github.com/users/astaric/gists{/gist_id}","starred_url":"https://api.github.com/users/astaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaric/subscriptions","organizations_url":"https://api.github.com/users/astaric/orgs","repos_url":"https://api.github.com/users/astaric/repos","events_url":"https://api.github.com/users/astaric/events{/privacy}","received_events_url":"https://api.github.com/users/astaric/received_events","type":"User","site_admin":false},"body":"Current singleton implementation of file readers/writers is hard to extend when additional features are needed (such as selecting sheet for excel files and overwriting header in #1012).\r\n\r\nThis PR replaces\r\n    FileFormat.read(filename)\r\nwith\r\n    FileFormat.get_reader(filename).read()\r\n\r\nThe new way enables us to set additional properties on reader before the read method is called.","created_at":"2016-04-13T14:46:55Z","updated_at":"2016-05-03T10:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b975907d8495b4c6f6938c2ad24e37a888e5af6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/1177/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/1177/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/1177/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/ce70666726ae44ffec1d781278871063f3abdc96","head":{"label":"astaric:override-header","ref":"override-header","sha":"ce70666726ae44ffec1d781278871063f3abdc96","user":{"login":"astaric","id":588601,"avatar_url":"https://avatars.githubusercontent.com/u/588601?v=3","gravatar_id":"","url":"https://api.github.com/users/astaric","html_url":"https://github.com/astaric","followers_url":"https://api.github.com/users/astaric/followers","following_url":"https://api.github.com/users/astaric/following{/other_user}","gists_url":"https://api.github.com/users/astaric/gists{/gist_id}","starred_url":"https://api.github.com/users/astaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaric/subscriptions","organizations_url":"https://api.github.com/users/astaric/orgs","repos_url":"https://api.github.com/users/astaric/repos","events_url":"https://api.github.com/users/astaric/events{/privacy}","received_events_url":"https://api.github.com/users/astaric/received_events","type":"User","site_admin":false},"repo":{"id":8647497,"name":"orange3","full_name":"astaric/orange3","owner":{"login":"astaric","id":588601,"avatar_url":"https://avatars.githubusercontent.com/u/588601?v=3","gravatar_id":"","url":"https://api.github.com/users/astaric","html_url":"https://github.com/astaric","followers_url":"https://api.github.com/users/astaric/followers","following_url":"https://api.github.com/users/astaric/following{/other_user}","gists_url":"https://api.github.com/users/astaric/gists{/gist_id}","starred_url":"https://api.github.com/users/astaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaric/subscriptions","organizations_url":"https://api.github.com/users/astaric/orgs","repos_url":"https://api.github.com/users/astaric/repos","events_url":"https://api.github.com/users/astaric/events{/privacy}","received_events_url":"https://api.github.com/users/astaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astaric/orange3","description":"","fork":true,"url":"https://api.github.com/repos/astaric/orange3","forks_url":"https://api.github.com/repos/astaric/orange3/forks","keys_url":"https://api.github.com/repos/astaric/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astaric/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astaric/orange3/teams","hooks_url":"https://api.github.com/repos/astaric/orange3/hooks","issue_events_url":"https://api.github.com/repos/astaric/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/astaric/orange3/events","assignees_url":"https://api.github.com/repos/astaric/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/astaric/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/astaric/orange3/tags","blobs_url":"https://api.github.com/repos/astaric/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astaric/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astaric/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/astaric/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astaric/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/astaric/orange3/languages","stargazers_url":"https://api.github.com/repos/astaric/orange3/stargazers","contributors_url":"https://api.github.com/repos/astaric/orange3/contributors","subscribers_url":"https://api.github.com/repos/astaric/orange3/subscribers","subscription_url":"https://api.github.com/repos/astaric/orange3/subscription","commits_url":"https://api.github.com/repos/astaric/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/astaric/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/astaric/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/astaric/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/astaric/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/astaric/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astaric/orange3/merges","archive_url":"https://api.github.com/repos/astaric/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astaric/orange3/downloads","issues_url":"https://api.github.com/repos/astaric/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/astaric/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/astaric/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/astaric/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astaric/orange3/labels{/name}","releases_url":"https://api.github.com/repos/astaric/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/astaric/orange3/deployments","created_at":"2013-03-08T09:08:23Z","updated_at":"2014-12-10T12:44:29Z","pushed_at":"2016-05-03T10:49:51Z","git_url":"git://github.com/astaric/orange3.git","ssh_url":"git@github.com:astaric/orange3.git","clone_url":"https://github.com/astaric/orange3.git","svn_url":"https://github.com/astaric/orange3","homepage":null,"size":38777,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"524b77c9fafc60c750e69025a7f65c92a6d43a09","user":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"name":"orange3","full_name":"biolab/orange3","owner":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biolab/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/biolab/orange3/deployments","created_at":"2013-02-22T12:52:56Z","updated_at":"2016-05-01T22:12:06Z","pushed_at":"2016-05-03T10:49:51Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":"","size":76235,"stargazers_count":276,"watchers_count":276,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":53,"forks":122,"open_issues":53,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1177"},"html":{"href":"https://github.com/biolab/orange3/pull/1177"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/1177"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/1177/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1177/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1177/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/ce70666726ae44ffec1d781278871063f3abdc96"}}}}