{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/57426634","id":57426634,"diff_hunk":"@@ -0,0 +1,310 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package etcd3\n+\n+import (\n+\t\"errors\"\n+\t\"path\"\n+\t\"reflect\"\n+\t\"strings\"\n+\n+\t\"github.com/coreos/etcd/clientv3\"\n+\t\"github.com/golang/glog\"\n+\t\"golang.org/x/net/context\"\n+\t\"k8s.io/kubernetes/pkg/api/meta\"\n+\t\"k8s.io/kubernetes/pkg/conversion\"\n+\t\"k8s.io/kubernetes/pkg/runtime\"\n+\t\"k8s.io/kubernetes/pkg/storage\"\n+\t\"k8s.io/kubernetes/pkg/storage/etcd\"\n+\t\"k8s.io/kubernetes/pkg/watch\"\n+)\n+\n+type store struct {\n+\tclient     *clientv3.Client\n+\tcodec      runtime.Codec\n+\tversioner  storage.Versioner\n+\tpathPrefix string\n+}","path":"pkg/storage/etcd3/store.go","position":41,"original_position":41,"commit_id":"b5089be779696ff7f5d6bf9131dff18c03949cb7","original_commit_id":"b5089be779696ff7f5d6bf9131dff18c03949cb7","user":{"login":"mqliang","id":12423751,"avatar_url":"https://avatars.githubusercontent.com/u/12423751?v=3","gravatar_id":"","url":"https://api.github.com/users/mqliang","html_url":"https://github.com/mqliang","followers_url":"https://api.github.com/users/mqliang/followers","following_url":"https://api.github.com/users/mqliang/following{/other_user}","gists_url":"https://api.github.com/users/mqliang/gists{/gist_id}","starred_url":"https://api.github.com/users/mqliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqliang/subscriptions","organizations_url":"https://api.github.com/users/mqliang/orgs","repos_url":"https://api.github.com/users/mqliang/repos","events_url":"https://api.github.com/users/mqliang/events{/privacy}","received_events_url":"https://api.github.com/users/mqliang/received_events","type":"User","site_admin":false},"body":"Quorum-read knob?","created_at":"2016-03-25T08:09:42Z","updated_at":"2016-03-25T08:09:42Z","html_url":"https://github.com/kubernetes/kubernetes/pull/23387#discussion_r57426634","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/57426634"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23387#discussion_r57426634"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387","id":63922080,"html_url":"https://github.com/kubernetes/kubernetes/pull/23387","diff_url":"https://github.com/kubernetes/kubernetes/pull/23387.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23387.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23387","number":23387,"state":"open","locked":false,"title":"storage.Interface KV impl. of etcd v3","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"body":"This is the initial implementation of #22448.\r\n\r\nThe PR consists of two parts:\r\n- add godep of \"clientv3\" and \"integration\" (for testing)\r\n- implement KV methods of storage.Interface using etcd v3 APIs\r\n  - Create, Set, Get, Delete, GetToList, List,\r\n\r\nTODO:\r\n- implement other KV methods\r\n - GuaranteedUpdate (gonna implement in next PR)\r\n\r\nUpdates:\r\n- Creating new package \"etcd3\" for this change. See discuss [here](https://github.com/kubernetes/kubernetes/pull/23387#discussion_r57237577).","created_at":"2016-03-23T17:33:45Z","updated_at":"2016-03-25T08:09:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14c6c90abc07fad0144e9c4107da02de66492b84","assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23387/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b5089be779696ff7f5d6bf9131dff18c03949cb7","head":{"label":"hongchaodeng:e","ref":"e","sha":"b5089be779696ff7f5d6bf9131dff18c03949cb7","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"repo":{"id":45423343,"name":"kubernetes","full_name":"hongchaodeng/kubernetes","owner":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hongchaodeng/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/hongchaodeng/kubernetes","forks_url":"https://api.github.com/repos/hongchaodeng/kubernetes/forks","keys_url":"https://api.github.com/repos/hongchaodeng/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hongchaodeng/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hongchaodeng/kubernetes/teams","hooks_url":"https://api.github.com/repos/hongchaodeng/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hongchaodeng/kubernetes/events","assignees_url":"https://api.github.com/repos/hongchaodeng/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hongchaodeng/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hongchaodeng/kubernetes/tags","blobs_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hongchaodeng/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hongchaodeng/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hongchaodeng/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hongchaodeng/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hongchaodeng/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hongchaodeng/kubernetes/subscription","commits_url":"https://api.github.com/repos/hongchaodeng/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hongchaodeng/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hongchaodeng/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hongchaodeng/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hongchaodeng/kubernetes/merges","archive_url":"https://api.github.com/repos/hongchaodeng/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hongchaodeng/kubernetes/downloads","issues_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hongchaodeng/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hongchaodeng/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hongchaodeng/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hongchaodeng/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hongchaodeng/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hongchaodeng/kubernetes/deployments","created_at":"2015-11-02T21:30:01Z","updated_at":"2016-01-13T18:34:57Z","pushed_at":"2016-03-24T23:42:20Z","git_url":"git://github.com/hongchaodeng/kubernetes.git","ssh_url":"git@github.com:hongchaodeng/kubernetes.git","clone_url":"https://github.com/hongchaodeng/kubernetes.git","svn_url":"https://github.com/hongchaodeng/kubernetes","homepage":"http://kubernetes.io","size":184375,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"47ee746fcc71fb86c64c9bc6221e475e98ee0139","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-03-25T07:59:44Z","pushed_at":"2016-03-25T07:46:31Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":346251,"stargazers_count":13490,"watchers_count":13490,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3904,"mirror_url":null,"open_issues_count":3103,"forks":3904,"open_issues":3103,"watchers":13490,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23387"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23387"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23387/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23387/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b5089be779696ff7f5d6bf9131dff18c03949cb7"}}}}