{"action":"created","comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/60853072","id":60853072,"diff_hunk":"@@ -33,6 +33,7 @@\n * [#3039](https://github.com/bbatsov/rubocop/issues/3039): Accept `match` without a receiver in `Performance/EndWith`. ([@lumeet][])\n * [#3039](https://github.com/bbatsov/rubocop/issues/3039): Accept `match` without a receiver in `Performance/StartWith`. ([@lumeet][])\n * [#3048](https://github.com/bbatsov/rubocop/issues/3048): `Lint/NestedMethodDefinition` shouldn't flag methods defined on Structs. ([@owst][])\n+* [#3049](https://github.com/bbatsov/rubocop/issues/3049): Make Lint/UselessAccessModifier detect conditionally defined methods and correctly handle dynamically defined methods and singleton class methods. ([@owst][])","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"e8208c54281074ed5d9b127ab714bf188f728772","original_commit_id":"e8208c54281074ed5d9b127ab714bf188f728772","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"body":"D'oh every time I forget this, sorry!","created_at":"2016-04-24T22:24:36Z","updated_at":"2016-04-24T22:24:36Z","html_url":"https://github.com/bbatsov/rubocop/pull/3060#discussion_r60853072","pull_request_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060","_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/60853072"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/3060#discussion_r60853072"},"pull_request":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060"}}},"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060","id":67105992,"html_url":"https://github.com/bbatsov/rubocop/pull/3060","diff_url":"https://github.com/bbatsov/rubocop/pull/3060.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/3060.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3060","number":3060,"state":"open","locked":false,"title":"[Fix #3049] Improve Lint/UselessAccessModifier","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"body":"This PR expands `Lint/UselessAccessModifer`:\r\n\r\n- Add detection of conditionally defined methods,\r\n- Add detection of dynamically defined methods,\r\n- Ensure singleton class methods are handled correctly,\r\n- DRY up some repetition in specs.\r\n\r\nBefore submitting a PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] Used the same coding conventions as the rest of the project.\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it)\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [x] Added an entry to the [Changelog](CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../CONTRIBUTING.md#changelog-entry-format).\r\n* [x] All tests are passing.\r\n* [x] The new code doesn't generate RuboCop offenses.\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n\r\n[1]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html","created_at":"2016-04-19T23:19:44Z","updated_at":"2016-04-24T22:24:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8476580efffc90f705ce91c9803dde0ea25f834b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3060/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/e8208c54281074ed5d9b127ab714bf188f728772","head":{"label":"owst:improve_useless_access_modifier","ref":"improve_useless_access_modifier","sha":"e8208c54281074ed5d9b127ab714bf188f728772","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"repo":{"id":50128601,"name":"rubocop","full_name":"owst/rubocop","owner":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/owst/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/owst/rubocop","forks_url":"https://api.github.com/repos/owst/rubocop/forks","keys_url":"https://api.github.com/repos/owst/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owst/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owst/rubocop/teams","hooks_url":"https://api.github.com/repos/owst/rubocop/hooks","issue_events_url":"https://api.github.com/repos/owst/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/owst/rubocop/events","assignees_url":"https://api.github.com/repos/owst/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/owst/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/owst/rubocop/tags","blobs_url":"https://api.github.com/repos/owst/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owst/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owst/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/owst/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owst/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/owst/rubocop/languages","stargazers_url":"https://api.github.com/repos/owst/rubocop/stargazers","contributors_url":"https://api.github.com/repos/owst/rubocop/contributors","subscribers_url":"https://api.github.com/repos/owst/rubocop/subscribers","subscription_url":"https://api.github.com/repos/owst/rubocop/subscription","commits_url":"https://api.github.com/repos/owst/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/owst/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/owst/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/owst/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/owst/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/owst/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owst/rubocop/merges","archive_url":"https://api.github.com/repos/owst/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owst/rubocop/downloads","issues_url":"https://api.github.com/repos/owst/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/owst/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/owst/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/owst/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owst/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/owst/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/owst/rubocop/deployments","created_at":"2016-01-21T18:41:29Z","updated_at":"2016-01-21T18:41:32Z","pushed_at":"2016-04-24T22:20:44Z","git_url":"git://github.com/owst/rubocop.git","ssh_url":"git@github.com:owst/rubocop.git","clone_url":"https://github.com/owst/rubocop.git","svn_url":"https://github.com/owst/rubocop","homepage":"","size":11673,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"603df7f7fe190323c0aecba5e76c161332c01900","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2016-04-24T13:18:43Z","pushed_at":"2016-04-24T16:36:32Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"","size":15089,"stargazers_count":6209,"watchers_count":6209,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":824,"mirror_url":null,"open_issues_count":109,"forks":824,"open_issues":109,"watchers":6209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/3060"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/3060"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/3060/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3060/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/e8208c54281074ed5d9b127ab714bf188f728772"}}}}