{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5897","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5897/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5897/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5897/events","html_url":"https://github.com/nodejs/node/pull/5897","id":143448988,"number":5897,"title":"child_process: general code improvements","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/child_process","name":"child_process","color":"f7c6c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-25T07:55:33Z","updated_at":"2016-03-30T15:02:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5897","html_url":"https://github.com/nodejs/node/pull/5897","diff_url":"https://github.com/nodejs/node/pull/5897.diff","patch_url":"https://github.com/nodejs/node/pull/5897.patch"},"body":"### Pull Request check-list\r\n\r\n- [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [ ] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [ ] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n### Affected core subsystem(s)\r\n\r\nchild_process\r\n\r\n### Description of change\r\n\r\nA number of general code improvements within child_process.\r\n\r\nsemver-major because there are a couple of edits to Error throws / messages"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/203478615","html_url":"https://github.com/nodejs/node/pull/5897#issuecomment-203478615","issue_url":"https://api.github.com/repos/nodejs/node/issues/5897","id":203478615,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T15:02:56Z","updated_at":"2016-03-30T15:02:56Z","body":"A lot of this file feels very clunky. I'm going to take another pass through it because I'm still not happy with the arguments parsing at all."}}