{"action":"created","comment":{"url":"https://api.github.com/repos/zhou13/uastar/pulls/comments/92534011","pull_request_review_id":13051090,"id":92534011,"diff_hunk":"@@ -5,9 +5,9 @@ find_package(CUDA REQUIRED)\n find_package(Boost COMPONENTS program_options system filesystem REQUIRED)\n \n add_definitions(\"-std=c++1y\")\n-set(CUDA_NVCC_FLAGS_DEBUG ${CUDA_NVCC_FLAGS_DEBUG} -lineinfo -gencode arch=compute_35,code=sm_35 --ptxas-options -v )\n-set(CMAKE_CXX_FLAGS_DEBUG \"${CMAKE_CXX_FLAGS_DEBUG} -rdynamic -Wall -DDEBUG -fsanitize=address\")\n-set(CUDA_NVCC_FLAGS_RELEASE ${CUDA_NVCC_FLAGS_RELEASE} -O2 -gencode arch=compute_35,code=sm_35 --ptxas-options -v)\n+set(CUDA_NVCC_FLAGS_DEBUG ${CUDA_NVCC_FLAGS_DEBUG} -lineinfo -gencode arch=compute_30,code=sm_30 --ptxas-options -v )","path":"CMakeLists.txt","position":7,"original_position":7,"commit_id":"060fde7828349a4509a25fd925ce72063ff3eda3","original_commit_id":"060fde7828349a4509a25fd925ce72063ff3eda3","user":{"login":"zhou13","id":576382,"avatar_url":"https://avatars.githubusercontent.com/u/576382?v=3","gravatar_id":"","url":"https://api.github.com/users/zhou13","html_url":"https://github.com/zhou13","followers_url":"https://api.github.com/users/zhou13/followers","following_url":"https://api.github.com/users/zhou13/following{/other_user}","gists_url":"https://api.github.com/users/zhou13/gists{/gist_id}","starred_url":"https://api.github.com/users/zhou13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhou13/subscriptions","organizations_url":"https://api.github.com/users/zhou13/orgs","repos_url":"https://api.github.com/users/zhou13/repos","events_url":"https://api.github.com/users/zhou13/events{/privacy}","received_events_url":"https://api.github.com/users/zhou13/received_events","type":"User","site_admin":false},"body":"If we want to do it perfectly, it is better to add a cmake option to specify the `arch` and `code`.  But I agree that probably 30 is better than 35 and it should be the default.","created_at":"2016-12-15T02:37:59Z","updated_at":"2016-12-15T02:37:59Z","html_url":"https://github.com/zhou13/uastar/pull/2#discussion_r92534011","pull_request_url":"https://api.github.com/repos/zhou13/uastar/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/zhou13/uastar/pulls/comments/92534011"},"html":{"href":"https://github.com/zhou13/uastar/pull/2#discussion_r92534011"},"pull_request":{"href":"https://api.github.com/repos/zhou13/uastar/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/zhou13/uastar/pulls/2","id":98074729,"html_url":"https://github.com/zhou13/uastar/pull/2","diff_url":"https://github.com/zhou13/uastar/pull/2.diff","patch_url":"https://github.com/zhou13/uastar/pull/2.patch","issue_url":"https://api.github.com/repos/zhou13/uastar/issues/2","number":2,"state":"open","locked":false,"title":"Maybe bug(?)","user":{"login":"spinute","id":6639012,"avatar_url":"https://avatars.githubusercontent.com/u/6639012?v=3","gravatar_id":"","url":"https://api.github.com/users/spinute","html_url":"https://github.com/spinute","followers_url":"https://api.github.com/users/spinute/followers","following_url":"https://api.github.com/users/spinute/following{/other_user}","gists_url":"https://api.github.com/users/spinute/gists{/gist_id}","starred_url":"https://api.github.com/users/spinute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinute/subscriptions","organizations_url":"https://api.github.com/users/spinute/orgs","repos_url":"https://api.github.com/users/spinute/repos","events_url":"https://api.github.com/users/spinute/events{/privacy}","received_events_url":"https://api.github.com/users/spinute/received_events","type":"User","site_admin":false},"body":"I tried using your codes, and found that your codes sometimes report inconsistent results (in puzzle domain).\r\n\r\nMy input was such as\r\n* 12 11 9 14 7 2 4 3 0 13 10 5 8 15 1 6\r\n* 0 15 7 9 5 3 11 13 2 4 12 14 8 10 6 1\r\n\r\nAnd, I did a little fix to your codes in order to build and run your codes in AWS environment(I used g2.2xlarge, and NVIDIA CUDA 7.5 Toolkit on Amazon Linux-0ce7aca3-5b96-4ff4-8396-05245687380a-ami-52420645.3(ami-35b36f54)).\r\n\r\nIf possible, would you see my changes in this PR, and point out the mistakes I did if there are.\r\n\r\nLog: When running the code (Results are unreproducible)\r\n\r\n```\r\nuastar$ ./uastar --puzzle -H 4 -W 4 < ../slide_puzzle/benchmarks/uastar/prob002\r\n[0000000] Generating input data ......\r\n[0000000] Initializing CPU data structure ......\r\n[0000511] Initializing GPU data structure ......\r\n[0002168] Solving the problem on a pure CPU platform ......\r\n       \t\tNumber of nodes deduplicated: 1772085\r\n       \t\tNumber of nodes expanded: 3062731\r\n[0018677] Solving the problem with GPU acceleration ......\r\n       \t\tRound 645: Found one solution\r\n       \t\t\t Number of nodes expanded: 9667894\r\n[0019174] Checking the result ......\r\n > Optimal steps from CPU: 60\r\n > Optimal steps from GPU: 66\r\n[0019175] ERROR: Output of the CPU and GPU is not consistent!\r\n```\r\n\r\nLog: When using debug build, by adding flags \"-O0 -G -XCompiler -g\" to NVCC_FLAGS\r\n```\r\nuastar$ ./uastar --puzzle -H 4 -W 4 < ../slide_puzzle/benchmarks/uastar/prob001\r\n[0000000] Generating input data ......\r\n[0000000] Initializing CPU data structure ......\r\n[0000508] Initializing GPU data structure ......\r\n[0002214] Solving the problem on a pure CPU platform ......\r\n       \t\tNumber of nodes deduplicated: 452516\r\n       \t\tNumber of nodes expanded: 806666\r\n[0006227] Solving the problem with GPU acceleration ......\r\nCudaDeviceMem::ToHost copy error 77\r\nuastar$ ./uastar --puzzle -H 4 -W 4 < ../slide_puzzle/benchmarks/uastar/prob000\r\n[0000000] Generating input data ......\r\n[0000000] Initializing CPU data structure ......\r\n[0000511] Initializing GPU data structure ......\r\n[0002232] Solving the problem on a pure CPU platform ......\r\n       \t\tNumber of nodes deduplicated: 1054825\r\n       \t\tNumber of nodes expanded: 1835432\r\n[0011771] Solving the problem with GPU acceleration ......\r\n       \t\tRound 1010: Found one solution\r\nterminate called after throwing an instance of 'std::length_error'\r\n  what():  vector::_M_fill_insert\r\nAborted\r\n```\r\n\r\nI also found that when running your codes under cuda-memcheck, there are some errors reported.\r\n\r\nLog: Error reported by cuda-memcheck(using checkinit tool)\r\n\r\n```\r\n========= Uninitialized __global__ memory read of size 4\r\n=========     at 0x00005408 in /home/ec2-user/uastar/src/puzzle/GPU-kernel.cuh:352:void kExtractExpand<int=4, int=39, int=192, int=133, int=90000089>(unsigned char*, node_t<int=4>*, int*, heap_t*, int*, unsigned int*, unsigned int*, heap_t*, int*, heap_t*, int*, int*)\r\n=========     by thread (66,0,0) in block (15,0,0)\r\n=========     Address 0x72a26513c\r\n=========     Saved host backtrace up to driver entry point\r\n=========     Host Frame:/usr/lib64/libcuda.so.1 (cuLaunchKernel + 0x2cd) [0x15865d]\r\n=========     Host Frame:/usr/local/cuda/lib64/libcudart.so.7.5 [0x146ad]\r\n=========     Host Frame:/usr/local/cuda/lib64/libcudart.so.7.5 (cudaLaunch + 0x143) [0x2ece3]\r\n=========     Host Frame:./uastar [0xc828b]\r\n=========     Host Frame:./uastar [0xc7486]\r\n=========     Host Frame:./uastar [0xc751a]\r\n=========     Host Frame:./uastar (_Z14kExtractExpandILi4ELi39ELi192ELi133ELi90000089EEvPhP6node_tIXT_EEPiP6heap_tS4_PjS7_S6_S4_S6_S4_S4_ + 0x76) [0xd2fa0]\r\n=========     Host Frame:./uastar (_ZN9gpusolver15GPUPuzzleSolverILi4EE5solveEv + 0x2f9) [0xd1681]\r\n=========     Host Frame:./uastar (_ZN6Puzzle8gpuSolveEv + 0x60) [0xc63f8]\r\n=========     Host Frame:./uastar [0x90bdf]\r\n=========     Host Frame:./uastar (main + 0x5e4) [0x913c1]\r\n=========     Host Frame:/lib64/libc.so.6 (__libc_start_main + 0xf5) [0x21b15]\r\n=========     Host Frame:./uastar [0x90659]\r\n...\r\n```","created_at":"2016-12-15T02:13:10Z","updated_at":"2016-12-15T02:41:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8ee362a30ced0563a968254d8af8debdaffa169","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zhou13/uastar/pulls/2/commits","review_comments_url":"https://api.github.com/repos/zhou13/uastar/pulls/2/comments","review_comment_url":"https://api.github.com/repos/zhou13/uastar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zhou13/uastar/issues/2/comments","statuses_url":"https://api.github.com/repos/zhou13/uastar/statuses/060fde7828349a4509a25fd925ce72063ff3eda3","head":{"label":"spinute:master","ref":"master","sha":"060fde7828349a4509a25fd925ce72063ff3eda3","user":{"login":"spinute","id":6639012,"avatar_url":"https://avatars.githubusercontent.com/u/6639012?v=3","gravatar_id":"","url":"https://api.github.com/users/spinute","html_url":"https://github.com/spinute","followers_url":"https://api.github.com/users/spinute/followers","following_url":"https://api.github.com/users/spinute/following{/other_user}","gists_url":"https://api.github.com/users/spinute/gists{/gist_id}","starred_url":"https://api.github.com/users/spinute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinute/subscriptions","organizations_url":"https://api.github.com/users/spinute/orgs","repos_url":"https://api.github.com/users/spinute/repos","events_url":"https://api.github.com/users/spinute/events{/privacy}","received_events_url":"https://api.github.com/users/spinute/received_events","type":"User","site_admin":false},"repo":{"id":75737202,"name":"uastar","full_name":"spinute/uastar","owner":{"login":"spinute","id":6639012,"avatar_url":"https://avatars.githubusercontent.com/u/6639012?v=3","gravatar_id":"","url":"https://api.github.com/users/spinute","html_url":"https://github.com/spinute","followers_url":"https://api.github.com/users/spinute/followers","following_url":"https://api.github.com/users/spinute/following{/other_user}","gists_url":"https://api.github.com/users/spinute/gists{/gist_id}","starred_url":"https://api.github.com/users/spinute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinute/subscriptions","organizations_url":"https://api.github.com/users/spinute/orgs","repos_url":"https://api.github.com/users/spinute/repos","events_url":"https://api.github.com/users/spinute/events{/privacy}","received_events_url":"https://api.github.com/users/spinute/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spinute/uastar","description":"Universal General Propose A* for a GPU platform","fork":true,"url":"https://api.github.com/repos/spinute/uastar","forks_url":"https://api.github.com/repos/spinute/uastar/forks","keys_url":"https://api.github.com/repos/spinute/uastar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinute/uastar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinute/uastar/teams","hooks_url":"https://api.github.com/repos/spinute/uastar/hooks","issue_events_url":"https://api.github.com/repos/spinute/uastar/issues/events{/number}","events_url":"https://api.github.com/repos/spinute/uastar/events","assignees_url":"https://api.github.com/repos/spinute/uastar/assignees{/user}","branches_url":"https://api.github.com/repos/spinute/uastar/branches{/branch}","tags_url":"https://api.github.com/repos/spinute/uastar/tags","blobs_url":"https://api.github.com/repos/spinute/uastar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinute/uastar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinute/uastar/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinute/uastar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinute/uastar/statuses/{sha}","languages_url":"https://api.github.com/repos/spinute/uastar/languages","stargazers_url":"https://api.github.com/repos/spinute/uastar/stargazers","contributors_url":"https://api.github.com/repos/spinute/uastar/contributors","subscribers_url":"https://api.github.com/repos/spinute/uastar/subscribers","subscription_url":"https://api.github.com/repos/spinute/uastar/subscription","commits_url":"https://api.github.com/repos/spinute/uastar/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinute/uastar/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinute/uastar/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinute/uastar/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinute/uastar/contents/{+path}","compare_url":"https://api.github.com/repos/spinute/uastar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinute/uastar/merges","archive_url":"https://api.github.com/repos/spinute/uastar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinute/uastar/downloads","issues_url":"https://api.github.com/repos/spinute/uastar/issues{/number}","pulls_url":"https://api.github.com/repos/spinute/uastar/pulls{/number}","milestones_url":"https://api.github.com/repos/spinute/uastar/milestones{/number}","notifications_url":"https://api.github.com/repos/spinute/uastar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinute/uastar/labels{/name}","releases_url":"https://api.github.com/repos/spinute/uastar/releases{/id}","deployments_url":"https://api.github.com/repos/spinute/uastar/deployments","created_at":"2016-12-06T14:08:02Z","updated_at":"2016-12-06T14:08:04Z","pushed_at":"2016-12-12T16:04:02Z","git_url":"git://github.com/spinute/uastar.git","ssh_url":"git@github.com:spinute/uastar.git","clone_url":"https://github.com/spinute/uastar.git","svn_url":"https://github.com/spinute/uastar","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zhou13:master","ref":"master","sha":"1c071b394972c7ef8ba516c1736bfdffeb852c89","user":{"login":"zhou13","id":576382,"avatar_url":"https://avatars.githubusercontent.com/u/576382?v=3","gravatar_id":"","url":"https://api.github.com/users/zhou13","html_url":"https://github.com/zhou13","followers_url":"https://api.github.com/users/zhou13/followers","following_url":"https://api.github.com/users/zhou13/following{/other_user}","gists_url":"https://api.github.com/users/zhou13/gists{/gist_id}","starred_url":"https://api.github.com/users/zhou13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhou13/subscriptions","organizations_url":"https://api.github.com/users/zhou13/orgs","repos_url":"https://api.github.com/users/zhou13/repos","events_url":"https://api.github.com/users/zhou13/events{/privacy}","received_events_url":"https://api.github.com/users/zhou13/received_events","type":"User","site_admin":false},"repo":{"id":23063921,"name":"uastar","full_name":"zhou13/uastar","owner":{"login":"zhou13","id":576382,"avatar_url":"https://avatars.githubusercontent.com/u/576382?v=3","gravatar_id":"","url":"https://api.github.com/users/zhou13","html_url":"https://github.com/zhou13","followers_url":"https://api.github.com/users/zhou13/followers","following_url":"https://api.github.com/users/zhou13/following{/other_user}","gists_url":"https://api.github.com/users/zhou13/gists{/gist_id}","starred_url":"https://api.github.com/users/zhou13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhou13/subscriptions","organizations_url":"https://api.github.com/users/zhou13/orgs","repos_url":"https://api.github.com/users/zhou13/repos","events_url":"https://api.github.com/users/zhou13/events{/privacy}","received_events_url":"https://api.github.com/users/zhou13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhou13/uastar","description":"Universal General Propose A* for a GPU platform","fork":false,"url":"https://api.github.com/repos/zhou13/uastar","forks_url":"https://api.github.com/repos/zhou13/uastar/forks","keys_url":"https://api.github.com/repos/zhou13/uastar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhou13/uastar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhou13/uastar/teams","hooks_url":"https://api.github.com/repos/zhou13/uastar/hooks","issue_events_url":"https://api.github.com/repos/zhou13/uastar/issues/events{/number}","events_url":"https://api.github.com/repos/zhou13/uastar/events","assignees_url":"https://api.github.com/repos/zhou13/uastar/assignees{/user}","branches_url":"https://api.github.com/repos/zhou13/uastar/branches{/branch}","tags_url":"https://api.github.com/repos/zhou13/uastar/tags","blobs_url":"https://api.github.com/repos/zhou13/uastar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhou13/uastar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhou13/uastar/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhou13/uastar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhou13/uastar/statuses/{sha}","languages_url":"https://api.github.com/repos/zhou13/uastar/languages","stargazers_url":"https://api.github.com/repos/zhou13/uastar/stargazers","contributors_url":"https://api.github.com/repos/zhou13/uastar/contributors","subscribers_url":"https://api.github.com/repos/zhou13/uastar/subscribers","subscription_url":"https://api.github.com/repos/zhou13/uastar/subscription","commits_url":"https://api.github.com/repos/zhou13/uastar/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhou13/uastar/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhou13/uastar/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhou13/uastar/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhou13/uastar/contents/{+path}","compare_url":"https://api.github.com/repos/zhou13/uastar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhou13/uastar/merges","archive_url":"https://api.github.com/repos/zhou13/uastar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhou13/uastar/downloads","issues_url":"https://api.github.com/repos/zhou13/uastar/issues{/number}","pulls_url":"https://api.github.com/repos/zhou13/uastar/pulls{/number}","milestones_url":"https://api.github.com/repos/zhou13/uastar/milestones{/number}","notifications_url":"https://api.github.com/repos/zhou13/uastar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhou13/uastar/labels{/name}","releases_url":"https://api.github.com/repos/zhou13/uastar/releases{/id}","deployments_url":"https://api.github.com/repos/zhou13/uastar/deployments","created_at":"2014-08-18T08:25:17Z","updated_at":"2016-11-29T06:21:07Z","pushed_at":"2016-12-15T02:13:10Z","git_url":"git://github.com/zhou13/uastar.git","ssh_url":"git@github.com:zhou13/uastar.git","clone_url":"https://github.com/zhou13/uastar.git","svn_url":"https://github.com/zhou13/uastar","homepage":null,"size":100,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zhou13/uastar/pulls/2"},"html":{"href":"https://github.com/zhou13/uastar/pull/2"},"issue":{"href":"https://api.github.com/repos/zhou13/uastar/issues/2"},"comments":{"href":"https://api.github.com/repos/zhou13/uastar/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/zhou13/uastar/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/zhou13/uastar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zhou13/uastar/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/zhou13/uastar/statuses/060fde7828349a4509a25fd925ce72063ff3eda3"}}}}
{"actor":{"display_login":"zhou13"}}