{"action":"created","issue":{"url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/84","repository_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules","labels_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/84/comments","events_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/84/events","html_url":"https://github.com/jrl-umi3218/jrl-cmakemodules/issues/84","id":150028149,"number":84,"title":"CMAKE_CXX_FLAGS order","user":{"login":"jmirabel","id":2388209,"avatar_url":"https://avatars.githubusercontent.com/u/2388209?v=3","gravatar_id":"","url":"https://api.github.com/users/jmirabel","html_url":"https://github.com/jmirabel","followers_url":"https://api.github.com/users/jmirabel/followers","following_url":"https://api.github.com/users/jmirabel/following{/other_user}","gists_url":"https://api.github.com/users/jmirabel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmirabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmirabel/subscriptions","organizations_url":"https://api.github.com/users/jmirabel/orgs","repos_url":"https://api.github.com/users/jmirabel/repos","events_url":"https://api.github.com/users/jmirabel/events{/privacy}","received_events_url":"https://api.github.com/users/jmirabel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-21T10:08:46Z","updated_at":"2016-04-22T10:33:33Z","closed_at":null,"body":"Is there a specific reason for the order in https://github.com/jrl-umi3218/jrl-cmakemodules/blob/master/compiler.cmake#L61:\r\n```cmake\r\nSET(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} ${WARNING_CXX_FLAGS}\")\r\n```\r\n\r\nSetting `CMAKE_CXX_FLAGS` in this order means when doing\r\n```bash\r\ncmake -DCMAKE_CXX_FLAGS=\"something\"\r\n```\r\nsome of the flags of command line can be overwritten by flags in variable `WARNING_CXX_FLAGS`. Is this a desired behaviour ? Is there a problem with the following reordering:\r\n```cmake\r\nSET(CMAKE_CXX_FLAGS \"${WARNING_CXX_FLAGS} ${CMAKE_CXX_FLAGS}\")\r\n```\r\n?"},"comment":{"url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/comments/213372021","html_url":"https://github.com/jrl-umi3218/jrl-cmakemodules/issues/84#issuecomment-213372021","issue_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/84","id":213372021,"user":{"login":"bchretien","id":2742231,"avatar_url":"https://avatars.githubusercontent.com/u/2742231?v=3","gravatar_id":"","url":"https://api.github.com/users/bchretien","html_url":"https://github.com/bchretien","followers_url":"https://api.github.com/users/bchretien/followers","following_url":"https://api.github.com/users/bchretien/following{/other_user}","gists_url":"https://api.github.com/users/bchretien/gists{/gist_id}","starred_url":"https://api.github.com/users/bchretien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchretien/subscriptions","organizations_url":"https://api.github.com/users/bchretien/orgs","repos_url":"https://api.github.com/users/bchretien/repos","events_url":"https://api.github.com/users/bchretien/events{/privacy}","received_events_url":"https://api.github.com/users/bchretien/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T10:33:33Z","updated_at":"2016-04-22T10:33:33Z","body":"I don't think so, we just usually append flags. Extra user-defined flags rarely concern warnings, since this is something tackled at the project level."}}