{"action":"created","issue":{"url":"https://api.github.com/repos/ga4gh/mme-apis/issues/110","repository_url":"https://api.github.com/repos/ga4gh/mme-apis","labels_url":"https://api.github.com/repos/ga4gh/mme-apis/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/ga4gh/mme-apis/issues/110/comments","events_url":"https://api.github.com/repos/ga4gh/mme-apis/issues/110/events","html_url":"https://github.com/ga4gh/mme-apis/pull/110","id":75724650,"number":110,"title":"Make test data conform to v1.0 API","user":{"login":"buske","id":4251264,"avatar_url":"https://avatars.githubusercontent.com/u/4251264?v=3","gravatar_id":"","url":"https://api.github.com/users/buske","html_url":"https://github.com/buske","followers_url":"https://api.github.com/users/buske/followers","following_url":"https://api.github.com/users/buske/following{/other_user}","gists_url":"https://api.github.com/users/buske/gists{/gist_id}","starred_url":"https://api.github.com/users/buske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buske/subscriptions","organizations_url":"https://api.github.com/users/buske/orgs","repos_url":"https://api.github.com/users/buske/repos","events_url":"https://api.github.com/users/buske/events{/privacy}","received_events_url":"https://api.github.com/users/buske/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ga4gh/mme-apis/milestones/4","html_url":"https://github.com/ga4gh/mme-apis/milestones/Before%20v1.1","labels_url":"https://api.github.com/repos/ga4gh/mme-apis/milestones/4/labels","id":1078875,"number":4,"title":"Before v1.1","description":"Things that need to be reviewed before starting work on v1.1","creator":{"login":"Relequestual","id":731158,"avatar_url":"https://avatars.githubusercontent.com/u/731158?v=3","gravatar_id":"","url":"https://api.github.com/users/Relequestual","html_url":"https://github.com/Relequestual","followers_url":"https://api.github.com/users/Relequestual/followers","following_url":"https://api.github.com/users/Relequestual/following{/other_user}","gists_url":"https://api.github.com/users/Relequestual/gists{/gist_id}","starred_url":"https://api.github.com/users/Relequestual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Relequestual/subscriptions","organizations_url":"https://api.github.com/users/Relequestual/orgs","repos_url":"https://api.github.com/users/Relequestual/repos","events_url":"https://api.github.com/users/Relequestual/events{/privacy}","received_events_url":"https://api.github.com/users/Relequestual/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":3,"state":"open","created_at":"2015-04-22T13:04:05Z","updated_at":"2015-08-04T15:38:21Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2015-05-12T20:16:59Z","updated_at":"2016-12-01T07:07:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ga4gh/mme-apis/pulls/110","html_url":"https://github.com/ga4gh/mme-apis/pull/110","diff_url":"https://github.com/ga4gh/mme-apis/pull/110.diff","patch_url":"https://github.com/ga4gh/mme-apis/pull/110.patch"},"body":"Summary:\n- Issue #108: resolved several HGVS errors, and updated variant data accordingly\n- Issue #107: added variant referenceBases, alternateBases, and end position\n- Issue #105: made patient objects strictly conform to spec (removed non-spec `label` and `hgvs` fields)\n- Removed obsolete FHS dataset\n"},"comment":{"url":"https://api.github.com/repos/ga4gh/mme-apis/issues/comments/264094987","html_url":"https://github.com/ga4gh/mme-apis/pull/110#issuecomment-264094987","issue_url":"https://api.github.com/repos/ga4gh/mme-apis/issues/110","id":264094987,"user":{"login":"buske","id":4251264,"avatar_url":"https://avatars.githubusercontent.com/u/4251264?v=3","gravatar_id":"","url":"https://api.github.com/users/buske","html_url":"https://github.com/buske","followers_url":"https://api.github.com/users/buske/followers","following_url":"https://api.github.com/users/buske/following{/other_user}","gists_url":"https://api.github.com/users/buske/gists{/gist_id}","starred_url":"https://api.github.com/users/buske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buske/subscriptions","organizations_url":"https://api.github.com/users/buske/orgs","repos_url":"https://api.github.com/users/buske/repos","events_url":"https://api.github.com/users/buske/events{/privacy}","received_events_url":"https://api.github.com/users/buske/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T07:07:18Z","updated_at":"2016-12-01T07:07:18Z","body":"Hmm, even after we tag an API release (e.g. 1.0), we still might make bugfixes and documentation clarifications for that version of the API, since people will keep using it. In git flow, I believe this is represented by creating a release branch, which you maintain even after you tag the initial release for that version. In normal semver, those bugfix releases would get tagged as a patch (e.g. 1.0.1). In our case, the API itself isn't changing in those cases... it makes sense to stay as 1.0, but the documentation and supporting code might need to be updated over time for the v1.0 version of the API. We can tag new versions, or just maintain a `release/v1.0` branch. This reasonable?\r\n\r\nBy base branch I meant the branch the PR was pulling into (it was `master` before)."}}
{"actor":{"display_login":"buske"}}