{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/comments/48994048","id":48994048,"diff_hunk":"@@ -28,12 +29,14 @@ public void JarContainsFiles(params string[] expectedRelativePaths)\n         {\n             foreach (string relativePath in expectedRelativePaths)\n             {\n+                this.testContext.WriteLine(\"JarChecker: checking for file '{0}'\", relativePath);\n+\n                 string[] matchingFiles = Directory.GetFiles(this.unzippedDir, relativePath, SearchOption.TopDirectoryOnly);\n \n                 Assert.IsTrue(matchingFiles.Length < 2, \"Test error: supplied relative path should not match multiple files\");\n-                string fullFilePath = matchingFiles.FirstOrDefault();\n+                Assert.AreEqual(1, matchingFiles.Length, \"Jar does not contain expected file: {0}\", relativePath);\n \n-                Assert.IsTrue(File.Exists(fullFilePath), \"Jar does not contain expected file: {0}\", relativePath);","path":"Tests/PluginGeneratorTests/JarChecker.cs","position":35,"original_position":35,"commit_id":"87c74a61bc76ef1863174a3158afba5207497688","original_commit_id":"87c74a61bc76ef1863174a3158afba5207497688","user":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"body":"This old assertion didn't make any sense: if there were no matching files then File.Exists(...) would have thrown an null-ref exception.","created_at":"2016-01-06T18:57:13Z","updated_at":"2016-01-06T18:57:13Z","html_url":"https://github.com/SonarSource/sonarqube-roslyn-sdk/pull/15#discussion_r48994048","pull_request_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/comments/48994048"},"html":{"href":"https://github.com/SonarSource/sonarqube-roslyn-sdk/pull/15#discussion_r48994048"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15","id":55248449,"html_url":"https://github.com/SonarSource/sonarqube-roslyn-sdk/pull/15","diff_url":"https://github.com/SonarSource/sonarqube-roslyn-sdk/pull/15.diff","patch_url":"https://github.com/SonarSource/sonarqube-roslyn-sdk/pull/15.patch","issue_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/issues/15","number":15,"state":"open","locked":false,"title":"[Technical] Refactored the builder code","user":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"body":"The RulesPluginBuilder now inherits from PluginBuilder which simplifies the API; the static configuration methods are no longer required.\r\n\r\nThis refactoring is a pre-cursor to removing the embedded jars from the product code.","created_at":"2016-01-06T18:47:30Z","updated_at":"2016-01-06T18:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52bf78bdaf2d9e12a4e0e9f4290348dfd5851114","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/issues/15/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/statuses/87c74a61bc76ef1863174a3158afba5207497688","head":{"label":"duncanpMS:technical","ref":"technical","sha":"87c74a61bc76ef1863174a3158afba5207497688","user":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"repo":{"id":47558647,"name":"sonarqube-roslyn-sdk","full_name":"duncanpMS/sonarqube-roslyn-sdk","owner":{"login":"duncanpMS","id":10757559,"avatar_url":"https://avatars.githubusercontent.com/u/10757559?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanpMS","html_url":"https://github.com/duncanpMS","followers_url":"https://api.github.com/users/duncanpMS/followers","following_url":"https://api.github.com/users/duncanpMS/following{/other_user}","gists_url":"https://api.github.com/users/duncanpMS/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanpMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanpMS/subscriptions","organizations_url":"https://api.github.com/users/duncanpMS/orgs","repos_url":"https://api.github.com/users/duncanpMS/repos","events_url":"https://api.github.com/users/duncanpMS/events{/privacy}","received_events_url":"https://api.github.com/users/duncanpMS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duncanpMS/sonarqube-roslyn-sdk","description":"SDK for SonarQube Roslyn Analyzer Plugins ","fork":true,"url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk","forks_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/forks","keys_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/teams","hooks_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/hooks","issue_events_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/events","assignees_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/tags","blobs_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/languages","stargazers_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/stargazers","contributors_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/contributors","subscribers_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/subscribers","subscription_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/subscription","commits_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/merges","archive_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/downloads","issues_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/labels{/name}","releases_url":"https://api.github.com/repos/duncanpMS/sonarqube-roslyn-sdk/releases{/id}","created_at":"2015-12-07T14:56:57Z","updated_at":"2015-12-07T14:56:58Z","pushed_at":"2016-01-06T18:51:25Z","git_url":"git://github.com/duncanpMS/sonarqube-roslyn-sdk.git","ssh_url":"git@github.com:duncanpMS/sonarqube-roslyn-sdk.git","clone_url":"https://github.com/duncanpMS/sonarqube-roslyn-sdk.git","svn_url":"https://github.com/duncanpMS/sonarqube-roslyn-sdk","homepage":null,"size":1137,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"d30f21c51b1f495a598fe0e49189120859b130af","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":46718922,"name":"sonarqube-roslyn-sdk","full_name":"SonarSource/sonarqube-roslyn-sdk","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonarqube-roslyn-sdk","description":"SDK for SonarQube Roslyn Analyzer Plugins ","fork":false,"url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk","forks_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/forks","keys_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/events","assignees_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/merges","archive_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/releases{/id}","created_at":"2015-11-23T12:31:17Z","updated_at":"2015-12-07T14:56:56Z","pushed_at":"2016-01-06T18:51:26Z","git_url":"git://github.com/SonarSource/sonarqube-roslyn-sdk.git","ssh_url":"git@github.com:SonarSource/sonarqube-roslyn-sdk.git","clone_url":"https://github.com/SonarSource/sonarqube-roslyn-sdk.git","svn_url":"https://github.com/SonarSource/sonarqube-roslyn-sdk","homepage":null,"size":1108,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15"},"html":{"href":"https://github.com/SonarSource/sonarqube-roslyn-sdk/pull/15"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/issues/15"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonarqube-roslyn-sdk/statuses/87c74a61bc76ef1863174a3158afba5207497688"}}}}