{"action":"created","comment":{"url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments/56138224","id":56138224,"diff_hunk":"@@ -99,22 +100,35 @@ sealed trait BipartiteAssignment extends Logging with Profiling {\n     foundPath\n   }\n \n+  private def logGraph: Unit = if (log.isTraceEnabled) {","path":"src/main/scala/com/actian/spark_vector/writer/DataStreamPartitionAssignment.scala","position":43,"original_position":43,"commit_id":"f4b1784e1befb63b8853b89053891c3523927143","original_commit_id":"f4b1784e1befb63b8853b89053891c3523927143","user":{"login":"cbarca","id":1218881,"avatar_url":"https://avatars.githubusercontent.com/u/1218881?v=3","gravatar_id":"","url":"https://api.github.com/users/cbarca","html_url":"https://github.com/cbarca","followers_url":"https://api.github.com/users/cbarca/followers","following_url":"https://api.github.com/users/cbarca/following{/other_user}","gists_url":"https://api.github.com/users/cbarca/gists{/gist_id}","starred_url":"https://api.github.com/users/cbarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbarca/subscriptions","organizations_url":"https://api.github.com/users/cbarca/orgs","repos_url":"https://api.github.com/users/cbarca/repos","events_url":"https://api.github.com/users/cbarca/events{/privacy}","received_events_url":"https://api.github.com/users/cbarca/received_events","type":"User","site_admin":false},"body":"prefix with `@inline` or use `private final` and perhaps the compiler will inline the method if/where it can\r\n\r\n[1]  http://alvinalexander.com/bookmarks/scala/scala-inline-final-example [inline def]\r\n[2] https://gist.github.com/rxin/37554d9f3e2e93220884 [val getting inlined]","created_at":"2016-03-15T09:54:35Z","updated_at":"2016-03-15T09:54:35Z","html_url":"https://github.com/ActianCorp/spark-vector/pull/16#discussion_r56138224","pull_request_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments/56138224"},"html":{"href":"https://github.com/ActianCorp/spark-vector/pull/16#discussion_r56138224"},"pull_request":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16","id":62787809,"html_url":"https://github.com/ActianCorp/spark-vector/pull/16","diff_url":"https://github.com/ActianCorp/spark-vector/pull/16.diff","patch_url":"https://github.com/ActianCorp/spark-vector/pull/16.patch","issue_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/16","number":16,"state":"open","locked":false,"title":"Fixed partition assignment to datastreams.","user":{"login":"and-costea","id":15726328,"avatar_url":"https://avatars.githubusercontent.com/u/15726328?v=3","gravatar_id":"","url":"https://api.github.com/users/and-costea","html_url":"https://github.com/and-costea","followers_url":"https://api.github.com/users/and-costea/followers","following_url":"https://api.github.com/users/and-costea/following{/other_user}","gists_url":"https://api.github.com/users/and-costea/gists{/gist_id}","starred_url":"https://api.github.com/users/and-costea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/and-costea/subscriptions","organizations_url":"https://api.github.com/users/and-costea/orgs","repos_url":"https://api.github.com/users/and-costea/repos","events_url":"https://api.github.com/users/and-costea/events{/privacy}","received_events_url":"https://api.github.com/users/and-costea/received_events","type":"User","site_admin":false},"body":"When the refactor was done to move the matching logic into a separate trait,  I mixed the \"numAperB\" with \"matchedAperB\". Also, adding some more tracing so that future errors/bugs in this code are easier to debug in the future.","created_at":"2016-03-14T17:40:11Z","updated_at":"2016-03-15T09:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd23d555259ece207bf1cfb71d5dbb2349c4324","assignee":{"login":"cbarca","id":1218881,"avatar_url":"https://avatars.githubusercontent.com/u/1218881?v=3","gravatar_id":"","url":"https://api.github.com/users/cbarca","html_url":"https://github.com/cbarca","followers_url":"https://api.github.com/users/cbarca/followers","following_url":"https://api.github.com/users/cbarca/following{/other_user}","gists_url":"https://api.github.com/users/cbarca/gists{/gist_id}","starred_url":"https://api.github.com/users/cbarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbarca/subscriptions","organizations_url":"https://api.github.com/users/cbarca/orgs","repos_url":"https://api.github.com/users/cbarca/repos","events_url":"https://api.github.com/users/cbarca/events{/privacy}","received_events_url":"https://api.github.com/users/cbarca/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16/commits","review_comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16/comments","review_comment_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/16/comments","statuses_url":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/f4b1784e1befb63b8853b89053891c3523927143","head":{"label":"ActianCorp:dev-fixpartitionassignment","ref":"dev-fixpartitionassignment","sha":"f4b1784e1befb63b8853b89053891c3523927143","user":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"repo":{"id":51449838,"name":"spark-vector","full_name":"ActianCorp/spark-vector","owner":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ActianCorp/spark-vector","description":"Repository for the Spark-Vector connector","fork":false,"url":"https://api.github.com/repos/ActianCorp/spark-vector","forks_url":"https://api.github.com/repos/ActianCorp/spark-vector/forks","keys_url":"https://api.github.com/repos/ActianCorp/spark-vector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ActianCorp/spark-vector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ActianCorp/spark-vector/teams","hooks_url":"https://api.github.com/repos/ActianCorp/spark-vector/hooks","issue_events_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/events{/number}","events_url":"https://api.github.com/repos/ActianCorp/spark-vector/events","assignees_url":"https://api.github.com/repos/ActianCorp/spark-vector/assignees{/user}","branches_url":"https://api.github.com/repos/ActianCorp/spark-vector/branches{/branch}","tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/tags","blobs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/refs{/sha}","trees_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/{sha}","languages_url":"https://api.github.com/repos/ActianCorp/spark-vector/languages","stargazers_url":"https://api.github.com/repos/ActianCorp/spark-vector/stargazers","contributors_url":"https://api.github.com/repos/ActianCorp/spark-vector/contributors","subscribers_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscribers","subscription_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscription","commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/commits{/sha}","git_commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/commits{/sha}","comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/comments{/number}","issue_comment_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/comments{/number}","contents_url":"https://api.github.com/repos/ActianCorp/spark-vector/contents/{+path}","compare_url":"https://api.github.com/repos/ActianCorp/spark-vector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ActianCorp/spark-vector/merges","archive_url":"https://api.github.com/repos/ActianCorp/spark-vector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ActianCorp/spark-vector/downloads","issues_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues{/number}","pulls_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls{/number}","milestones_url":"https://api.github.com/repos/ActianCorp/spark-vector/milestones{/number}","notifications_url":"https://api.github.com/repos/ActianCorp/spark-vector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ActianCorp/spark-vector/labels{/name}","releases_url":"https://api.github.com/repos/ActianCorp/spark-vector/releases{/id}","deployments_url":"https://api.github.com/repos/ActianCorp/spark-vector/deployments","created_at":"2016-02-10T15:30:30Z","updated_at":"2016-02-10T16:01:55Z","pushed_at":"2016-03-14T17:40:12Z","git_url":"git://github.com/ActianCorp/spark-vector.git","ssh_url":"git@github.com:ActianCorp/spark-vector.git","clone_url":"https://github.com/ActianCorp/spark-vector.git","svn_url":"https://github.com/ActianCorp/spark-vector","homepage":null,"size":1217,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"ActianCorp:master","ref":"master","sha":"d4df1e339a027a68ce4568aba5f4184546167459","user":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"repo":{"id":51449838,"name":"spark-vector","full_name":"ActianCorp/spark-vector","owner":{"login":"ActianCorp","id":11785919,"avatar_url":"https://avatars.githubusercontent.com/u/11785919?v=3","gravatar_id":"","url":"https://api.github.com/users/ActianCorp","html_url":"https://github.com/ActianCorp","followers_url":"https://api.github.com/users/ActianCorp/followers","following_url":"https://api.github.com/users/ActianCorp/following{/other_user}","gists_url":"https://api.github.com/users/ActianCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/ActianCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ActianCorp/subscriptions","organizations_url":"https://api.github.com/users/ActianCorp/orgs","repos_url":"https://api.github.com/users/ActianCorp/repos","events_url":"https://api.github.com/users/ActianCorp/events{/privacy}","received_events_url":"https://api.github.com/users/ActianCorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ActianCorp/spark-vector","description":"Repository for the Spark-Vector connector","fork":false,"url":"https://api.github.com/repos/ActianCorp/spark-vector","forks_url":"https://api.github.com/repos/ActianCorp/spark-vector/forks","keys_url":"https://api.github.com/repos/ActianCorp/spark-vector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ActianCorp/spark-vector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ActianCorp/spark-vector/teams","hooks_url":"https://api.github.com/repos/ActianCorp/spark-vector/hooks","issue_events_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/events{/number}","events_url":"https://api.github.com/repos/ActianCorp/spark-vector/events","assignees_url":"https://api.github.com/repos/ActianCorp/spark-vector/assignees{/user}","branches_url":"https://api.github.com/repos/ActianCorp/spark-vector/branches{/branch}","tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/tags","blobs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/refs{/sha}","trees_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/{sha}","languages_url":"https://api.github.com/repos/ActianCorp/spark-vector/languages","stargazers_url":"https://api.github.com/repos/ActianCorp/spark-vector/stargazers","contributors_url":"https://api.github.com/repos/ActianCorp/spark-vector/contributors","subscribers_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscribers","subscription_url":"https://api.github.com/repos/ActianCorp/spark-vector/subscription","commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/commits{/sha}","git_commits_url":"https://api.github.com/repos/ActianCorp/spark-vector/git/commits{/sha}","comments_url":"https://api.github.com/repos/ActianCorp/spark-vector/comments{/number}","issue_comment_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues/comments{/number}","contents_url":"https://api.github.com/repos/ActianCorp/spark-vector/contents/{+path}","compare_url":"https://api.github.com/repos/ActianCorp/spark-vector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ActianCorp/spark-vector/merges","archive_url":"https://api.github.com/repos/ActianCorp/spark-vector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ActianCorp/spark-vector/downloads","issues_url":"https://api.github.com/repos/ActianCorp/spark-vector/issues{/number}","pulls_url":"https://api.github.com/repos/ActianCorp/spark-vector/pulls{/number}","milestones_url":"https://api.github.com/repos/ActianCorp/spark-vector/milestones{/number}","notifications_url":"https://api.github.com/repos/ActianCorp/spark-vector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ActianCorp/spark-vector/labels{/name}","releases_url":"https://api.github.com/repos/ActianCorp/spark-vector/releases{/id}","deployments_url":"https://api.github.com/repos/ActianCorp/spark-vector/deployments","created_at":"2016-02-10T15:30:30Z","updated_at":"2016-02-10T16:01:55Z","pushed_at":"2016-03-14T17:40:12Z","git_url":"git://github.com/ActianCorp/spark-vector.git","ssh_url":"git@github.com:ActianCorp/spark-vector.git","clone_url":"https://github.com/ActianCorp/spark-vector.git","svn_url":"https://github.com/ActianCorp/spark-vector","homepage":null,"size":1217,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16"},"html":{"href":"https://github.com/ActianCorp/spark-vector/pull/16"},"issue":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/issues/16"},"comments":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/ActianCorp/spark-vector/statuses/f4b1784e1befb63b8853b89053891c3523927143"}}}}