{"action":"created","issue":{"url":"https://api.github.com/repos/mholt/caddy/issues/1184","repository_url":"https://api.github.com/repos/mholt/caddy","labels_url":"https://api.github.com/repos/mholt/caddy/issues/1184/labels{/name}","comments_url":"https://api.github.com/repos/mholt/caddy/issues/1184/comments","events_url":"https://api.github.com/repos/mholt/caddy/issues/1184/events","html_url":"https://github.com/mholt/caddy/pull/1184","id":182899774,"number":1184,"title":"Very simple fix for #1153","user":{"login":"tobya","id":325502,"avatar_url":"https://avatars.githubusercontent.com/u/325502?v=3","gravatar_id":"","url":"https://api.github.com/users/tobya","html_url":"https://github.com/tobya","followers_url":"https://api.github.com/users/tobya/followers","following_url":"https://api.github.com/users/tobya/following{/other_user}","gists_url":"https://api.github.com/users/tobya/gists{/gist_id}","starred_url":"https://api.github.com/users/tobya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobya/subscriptions","organizations_url":"https://api.github.com/users/tobya/orgs","repos_url":"https://api.github.com/users/tobya/repos","events_url":"https://api.github.com/users/tobya/events{/privacy}","received_events_url":"https://api.github.com/users/tobya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-13T21:00:40Z","updated_at":"2016-10-14T05:09:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mholt/caddy/pulls/1184","html_url":"https://github.com/mholt/caddy/pull/1184","diff_url":"https://github.com/mholt/caddy/pull/1184.diff","patch_url":"https://github.com/mholt/caddy/pull/1184.patch"},"body":"Preventing the deletion of  `Caddy-Rewrite-Original-URI` from header allows php fastcgi apps to correctly log the url requested.\r\n\r\nWith my basic testing seems to fix #1153 \r\n\r\nI do not have enough knowledge to know if the other lines in the if statement are relevant or should also be removed."},"comment":{"url":"https://api.github.com/repos/mholt/caddy/issues/comments/253710771","html_url":"https://github.com/mholt/caddy/pull/1184#issuecomment-253710771","issue_url":"https://api.github.com/repos/mholt/caddy/issues/1184","id":253710771,"user":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T05:09:02Z","updated_at":"2016-10-14T05:09:02Z","body":"Thanks for the PR @tobya! As long as keeping the header there will not impact any upstream PHP applications, then this change should be fine. I'm waiting for at least one reliable confirmation in the linked issue before merging this.\r\n\r\nMaybe we could accept this change either way if we skip this header field when forming the env vars that go to the PHP app (in the loop a bit lower with `// Add all HTTP headers to env variables`). That might be the cleanest, surest way to resolve this."}}
{"actor":{"display_login":"mholt"}}