{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/55274507","id":55274507,"diff_hunk":"@@ -216,6 +216,10 @@ In addition to the arguments available for any :ref:`Latent-Workers`, :class:`Do\n     Address of the master the worker should connect to. Use if you master machine does not have proper fqdn.\n     This value is passed to the docker image via environment variable ``BUILDMASTER``\n \n+``hostconfig``\n+    (optional)\n+    Extra host configuration parameters passed as a dictionary used to create HostConfig object. See `docker-py's HostConfig documentation <http://docker-py.readthedocs.org/en/latest/hostconfig/>`_ for all the supported options.\n+","path":"master/docs/manual/cfg-workers-docker.rst","position":7,"original_position":7,"commit_id":"3f8b607c6bb4581bc944c148ef09864fee57d188","original_commit_id":"3f8b607c6bb4581bc944c148ef09864fee57d188","user":{"login":"rutsky","id":46573,"avatar_url":"https://avatars.githubusercontent.com/u/46573?v=3","gravatar_id":"","url":"https://api.github.com/users/rutsky","html_url":"https://github.com/rutsky","followers_url":"https://api.github.com/users/rutsky/followers","following_url":"https://api.github.com/users/rutsky/following{/other_user}","gists_url":"https://api.github.com/users/rutsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rutsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rutsky/subscriptions","organizations_url":"https://api.github.com/users/rutsky/orgs","repos_url":"https://api.github.com/users/rutsky/repos","events_url":"https://api.github.com/users/rutsky/events{/privacy}","received_events_url":"https://api.github.com/users/rutsky/received_events","type":"User","site_admin":false},"body":"Please add short notice about this feature into release notes: https://github.com/buildbot/buildbot/blob/master/master/docs/relnotes/index.rst\r\n\r\nAlso I would appreciate if you include notice about your previous PR #2029 into release notes.","created_at":"2016-03-07T21:23:47Z","updated_at":"2016-03-07T21:23:47Z","html_url":"https://github.com/buildbot/buildbot/pull/2036#discussion_r55274507","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2036","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/55274507"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2036#discussion_r55274507"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2036"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2036","id":61952701,"html_url":"https://github.com/buildbot/buildbot/pull/2036","diff_url":"https://github.com/buildbot/buildbot/pull/2036.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2036.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2036","number":2036,"state":"open","locked":false,"title":"Add docker host config support","user":{"login":"anish","id":98102,"avatar_url":"https://avatars.githubusercontent.com/u/98102?v=3","gravatar_id":"","url":"https://api.github.com/users/anish","html_url":"https://github.com/anish","followers_url":"https://api.github.com/users/anish/followers","following_url":"https://api.github.com/users/anish/following{/other_user}","gists_url":"https://api.github.com/users/anish/gists{/gist_id}","starred_url":"https://api.github.com/users/anish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anish/subscriptions","organizations_url":"https://api.github.com/users/anish/orgs","repos_url":"https://api.github.com/users/anish/repos","events_url":"https://api.github.com/users/anish/events{/privacy}","received_events_url":"https://api.github.com/users/anish/received_events","type":"User","site_admin":false},"body":"Add ability to specify host configuration while creating a\r\ndocker latent worker. Currently regularly used options like --net and --dns cannot be provided while creating a docker latent worker, resulting in a broken worker as this often breaks network access\r\n\r\nA new hostconfig parameter is added that accepts host config options as a dict, complete list of supported options can be found [here](https://docker-py.readthedocs.org/en/latest/hostconfig/).","created_at":"2016-03-07T17:43:18Z","updated_at":"2016-03-07T21:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5382c0962daa994e01f1663080d177477492e16a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2036/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2036/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2036/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/3f8b607c6bb4581bc944c148ef09864fee57d188","head":{"label":"anish:support_host_config","ref":"support_host_config","sha":"3f8b607c6bb4581bc944c148ef09864fee57d188","user":{"login":"anish","id":98102,"avatar_url":"https://avatars.githubusercontent.com/u/98102?v=3","gravatar_id":"","url":"https://api.github.com/users/anish","html_url":"https://github.com/anish","followers_url":"https://api.github.com/users/anish/followers","following_url":"https://api.github.com/users/anish/following{/other_user}","gists_url":"https://api.github.com/users/anish/gists{/gist_id}","starred_url":"https://api.github.com/users/anish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anish/subscriptions","organizations_url":"https://api.github.com/users/anish/orgs","repos_url":"https://api.github.com/users/anish/repos","events_url":"https://api.github.com/users/anish/events{/privacy}","received_events_url":"https://api.github.com/users/anish/received_events","type":"User","site_admin":false},"repo":{"id":24831566,"name":"buildbot","full_name":"anish/buildbot","owner":{"login":"anish","id":98102,"avatar_url":"https://avatars.githubusercontent.com/u/98102?v=3","gravatar_id":"","url":"https://api.github.com/users/anish","html_url":"https://github.com/anish","followers_url":"https://api.github.com/users/anish/followers","following_url":"https://api.github.com/users/anish/following{/other_user}","gists_url":"https://api.github.com/users/anish/gists{/gist_id}","starred_url":"https://api.github.com/users/anish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anish/subscriptions","organizations_url":"https://api.github.com/users/anish/orgs","repos_url":"https://api.github.com/users/anish/repos","events_url":"https://api.github.com/users/anish/events{/privacy}","received_events_url":"https://api.github.com/users/anish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anish/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/anish/buildbot","forks_url":"https://api.github.com/repos/anish/buildbot/forks","keys_url":"https://api.github.com/repos/anish/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anish/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anish/buildbot/teams","hooks_url":"https://api.github.com/repos/anish/buildbot/hooks","issue_events_url":"https://api.github.com/repos/anish/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/anish/buildbot/events","assignees_url":"https://api.github.com/repos/anish/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/anish/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/anish/buildbot/tags","blobs_url":"https://api.github.com/repos/anish/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anish/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anish/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/anish/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anish/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/anish/buildbot/languages","stargazers_url":"https://api.github.com/repos/anish/buildbot/stargazers","contributors_url":"https://api.github.com/repos/anish/buildbot/contributors","subscribers_url":"https://api.github.com/repos/anish/buildbot/subscribers","subscription_url":"https://api.github.com/repos/anish/buildbot/subscription","commits_url":"https://api.github.com/repos/anish/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/anish/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/anish/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/anish/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/anish/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/anish/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anish/buildbot/merges","archive_url":"https://api.github.com/repos/anish/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anish/buildbot/downloads","issues_url":"https://api.github.com/repos/anish/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/anish/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/anish/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/anish/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anish/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/anish/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/anish/buildbot/deployments","created_at":"2014-10-06T02:13:09Z","updated_at":"2014-10-05T17:30:41Z","pushed_at":"2016-03-07T18:37:55Z","git_url":"git://github.com/anish/buildbot.git","ssh_url":"git@github.com:anish/buildbot.git","clone_url":"https://github.com/anish/buildbot.git","svn_url":"https://github.com/anish/buildbot","homepage":"http://buildbot.net","size":39985,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"ccfe739d35f028a28eb844f3d6d9d7665cc9576f","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-03-07T04:40:47Z","pushed_at":"2016-03-07T18:44:54Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":88573,"stargazers_count":2029,"watchers_count":2029,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":848,"mirror_url":null,"open_issues_count":26,"forks":848,"open_issues":26,"watchers":2029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2036"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2036"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2036"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2036/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2036/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2036/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/3f8b607c6bb4581bc944c148ef09864fee57d188"}}}}