{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/69460484","id":69460484,"diff_hunk":"@@ -63,6 +63,11 @@ let create ~__context ~tagged_PIF ~tag ~network =\n \tif Db.PIF.get_tunnel_access_PIF_of ~__context ~self:tagged_PIF <> [] then\n \t\traise (Api_errors.Server_error (Api_errors.is_tunnel_access_pif, [Ref.string_of tagged_PIF]));\n \n+\t(* Check the VLAN is not in use by FCoE *)","path":"ocaml/xapi/xapi_vlan.ml","position":4,"original_position":4,"commit_id":"60195b7016c0320b1522577b02c1858d3cdb2ecc","original_commit_id":"60195b7016c0320b1522577b02c1858d3cdb2ecc","user":{"login":"robhoes","id":413005,"avatar_url":"https://avatars.githubusercontent.com/u/413005?v=3","gravatar_id":"","url":"https://api.github.com/users/robhoes","html_url":"https://github.com/robhoes","followers_url":"https://api.github.com/users/robhoes/followers","following_url":"https://api.github.com/users/robhoes/following{/other_user}","gists_url":"https://api.github.com/users/robhoes/gists{/gist_id}","starred_url":"https://api.github.com/users/robhoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhoes/subscriptions","organizations_url":"https://api.github.com/users/robhoes/orgs","repos_url":"https://api.github.com/users/robhoes/repos","events_url":"https://api.github.com/users/robhoes/events{/privacy}","received_events_url":"https://api.github.com/users/robhoes/received_events","type":"User","site_admin":false},"body":"Make this comment more general: \"...in use by the kernel\".","created_at":"2016-07-04T13:50:30Z","updated_at":"2016-07-04T13:50:30Z","html_url":"https://github.com/xapi-project/xen-api/pull/2688#discussion_r69460484","pull_request_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/69460484"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2688#discussion_r69460484"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688","id":75927406,"html_url":"https://github.com/xapi-project/xen-api/pull/2688","diff_url":"https://github.com/xapi-project/xen-api/pull/2688.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/2688.patch","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2688","number":2688,"state":"open","locked":false,"title":"CA-201728: VLAN.create must fail if VLAN is in use by FCoE","user":{"login":"sharady","id":4865661,"avatar_url":"https://avatars.githubusercontent.com/u/4865661?v=3","gravatar_id":"","url":"https://api.github.com/users/sharady","html_url":"https://github.com/sharady","followers_url":"https://api.github.com/users/sharady/followers","following_url":"https://api.github.com/users/sharady/following{/other_user}","gists_url":"https://api.github.com/users/sharady/gists{/gist_id}","starred_url":"https://api.github.com/users/sharady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharady/subscriptions","organizations_url":"https://api.github.com/users/sharady/orgs","repos_url":"https://api.github.com/users/sharady/repos","events_url":"https://api.github.com/users/sharady/events{/privacy}","received_events_url":"https://api.github.com/users/sharady/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-01T04:57:11Z","updated_at":"2016-07-04T13:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"924db1d17cd8d25808164032afe49c794fbb7eaf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2688/comments","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/60195b7016c0320b1522577b02c1858d3cdb2ecc","head":{"label":"sharady:CA-201728","ref":"CA-201728","sha":"60195b7016c0320b1522577b02c1858d3cdb2ecc","user":{"login":"sharady","id":4865661,"avatar_url":"https://avatars.githubusercontent.com/u/4865661?v=3","gravatar_id":"","url":"https://api.github.com/users/sharady","html_url":"https://github.com/sharady","followers_url":"https://api.github.com/users/sharady/followers","following_url":"https://api.github.com/users/sharady/following{/other_user}","gists_url":"https://api.github.com/users/sharady/gists{/gist_id}","starred_url":"https://api.github.com/users/sharady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharady/subscriptions","organizations_url":"https://api.github.com/users/sharady/orgs","repos_url":"https://api.github.com/users/sharady/repos","events_url":"https://api.github.com/users/sharady/events{/privacy}","received_events_url":"https://api.github.com/users/sharady/received_events","type":"User","site_admin":false},"repo":{"id":24841127,"name":"xen-api","full_name":"sharady/xen-api","owner":{"login":"sharady","id":4865661,"avatar_url":"https://avatars.githubusercontent.com/u/4865661?v=3","gravatar_id":"","url":"https://api.github.com/users/sharady","html_url":"https://github.com/sharady","followers_url":"https://api.github.com/users/sharady/followers","following_url":"https://api.github.com/users/sharady/following{/other_user}","gists_url":"https://api.github.com/users/sharady/gists{/gist_id}","starred_url":"https://api.github.com/users/sharady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharady/subscriptions","organizations_url":"https://api.github.com/users/sharady/orgs","repos_url":"https://api.github.com/users/sharady/repos","events_url":"https://api.github.com/users/sharady/events{/privacy}","received_events_url":"https://api.github.com/users/sharady/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharady/xen-api","description":"The Xapi Project's XenAPI Server","fork":true,"url":"https://api.github.com/repos/sharady/xen-api","forks_url":"https://api.github.com/repos/sharady/xen-api/forks","keys_url":"https://api.github.com/repos/sharady/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharady/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharady/xen-api/teams","hooks_url":"https://api.github.com/repos/sharady/xen-api/hooks","issue_events_url":"https://api.github.com/repos/sharady/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/sharady/xen-api/events","assignees_url":"https://api.github.com/repos/sharady/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/sharady/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/sharady/xen-api/tags","blobs_url":"https://api.github.com/repos/sharady/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharady/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharady/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharady/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharady/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/sharady/xen-api/languages","stargazers_url":"https://api.github.com/repos/sharady/xen-api/stargazers","contributors_url":"https://api.github.com/repos/sharady/xen-api/contributors","subscribers_url":"https://api.github.com/repos/sharady/xen-api/subscribers","subscription_url":"https://api.github.com/repos/sharady/xen-api/subscription","commits_url":"https://api.github.com/repos/sharady/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharady/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharady/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharady/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharady/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/sharady/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharady/xen-api/merges","archive_url":"https://api.github.com/repos/sharady/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharady/xen-api/downloads","issues_url":"https://api.github.com/repos/sharady/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/sharady/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/sharady/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/sharady/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharady/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/sharady/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/sharady/xen-api/deployments","created_at":"2014-10-06T10:05:17Z","updated_at":"2014-09-25T07:06:19Z","pushed_at":"2016-07-01T04:54:54Z","git_url":"git://github.com/sharady/xen-api.git","ssh_url":"git@github.com:sharady/xen-api.git","clone_url":"https://github.com/sharady/xen-api.git","svn_url":"https://github.com/sharady/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":30738,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"7472352eeba82bcc24ea8ec6e19a9633b48a85b4","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":960233,"name":"xen-api","full_name":"xapi-project/xen-api","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xen-api","description":"The Xapi Project's XenAPI Server","fork":false,"url":"https://api.github.com/repos/xapi-project/xen-api","forks_url":"https://api.github.com/repos/xapi-project/xen-api/forks","keys_url":"https://api.github.com/repos/xapi-project/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xen-api/teams","hooks_url":"https://api.github.com/repos/xapi-project/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xen-api/events","assignees_url":"https://api.github.com/repos/xapi-project/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xen-api/tags","blobs_url":"https://api.github.com/repos/xapi-project/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xen-api/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xen-api/subscription","commits_url":"https://api.github.com/repos/xapi-project/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xen-api/merges","archive_url":"https://api.github.com/repos/xapi-project/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xen-api/downloads","issues_url":"https://api.github.com/repos/xapi-project/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xen-api/deployments","created_at":"2010-10-04T10:52:57Z","updated_at":"2016-06-21T08:18:42Z","pushed_at":"2016-07-04T08:27:31Z","git_url":"git://github.com/xapi-project/xen-api.git","ssh_url":"git@github.com:xapi-project/xen-api.git","clone_url":"https://github.com/xapi-project/xen-api.git","svn_url":"https://github.com/xapi-project/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":39070,"stargazers_count":217,"watchers_count":217,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":15,"forks":150,"open_issues":15,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2688"},"issue":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2688"},"comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2688/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2688/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xen-api/statuses/60195b7016c0320b1522577b02c1858d3cdb2ecc"}}}}
{"actor":{"display_login":"robhoes"}}