{"action":"created","comment":{"url":"https://api.github.com/repos/scalecube/scalecube/pulls/comments/78340909","id":78340909,"diff_hunk":"@@ -118,15 +115,15 @@ public void setMembers(Collection<Address> members) {\n     List<Address> list = new ArrayList<>(set);\n     Collections.shuffle(list);\n     this.members = list;\n-    LOGGER.debug(\"Set cluster members[{}]: {}\", this.members.size(), this.members);\n+    LOGGER.debug(\"Updated monitored members[{}]: {}\", this.members.size(), this.members);\n   }\n \n   @Override\n   public void start() {\n     onPingRequestSubscriber = Subscribers.create(new OnPingRequestAction());\n     transport.listen().observeOn(scheduler)\n         .filter(PING_FILTER)\n-        .filter(targetFilter(transport.address()))\n+        .filter(targetFilter())","path":"cluster/src/main/java/io/scalecube/cluster/fdetector/FailureDetector.java","position":30,"original_position":30,"commit_id":"4d4903f851507c7bca51c69208305023372290d1","original_commit_id":"4d4903f851507c7bca51c69208305023372290d1","user":{"login":"antonkharenko","id":589734,"avatar_url":"https://avatars.githubusercontent.com/u/589734?v=3","gravatar_id":"","url":"https://api.github.com/users/antonkharenko","html_url":"https://github.com/antonkharenko","followers_url":"https://api.github.com/users/antonkharenko/followers","following_url":"https://api.github.com/users/antonkharenko/following{/other_user}","gists_url":"https://api.github.com/users/antonkharenko/gists{/gist_id}","starred_url":"https://api.github.com/users/antonkharenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonkharenko/subscriptions","organizations_url":"https://api.github.com/users/antonkharenko/orgs","repos_url":"https://api.github.com/users/antonkharenko/repos","events_url":"https://api.github.com/users/antonkharenko/events{/privacy}","received_events_url":"https://api.github.com/users/antonkharenko/received_events","type":"User","site_admin":false},"body":"I think this targetFilter is useless overall. Algorithm can't send Ping not to you. So basically just filtering out this case not valid. ","created_at":"2016-09-12T09:31:51Z","updated_at":"2016-09-12T09:31:51Z","html_url":"https://github.com/scalecube/scalecube/pull/83#discussion_r78340909","pull_request_url":"https://api.github.com/repos/scalecube/scalecube/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/comments/78340909"},"html":{"href":"https://github.com/scalecube/scalecube/pull/83#discussion_r78340909"},"pull_request":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/scalecube/scalecube/pulls/83","id":84837736,"html_url":"https://github.com/scalecube/scalecube/pull/83","diff_url":"https://github.com/scalecube/scalecube/pull/83.diff","patch_url":"https://github.com/scalecube/scalecube/pull/83.patch","issue_url":"https://api.github.com/repos/scalecube/scalecube/issues/83","number":83,"state":"open","locked":false,"title":"Fixed setting function of FD.members from non-FD thread","user":{"login":"artem-v","id":860967,"avatar_url":"https://avatars.githubusercontent.com/u/860967?v=3","gravatar_id":"","url":"https://api.github.com/users/artem-v","html_url":"https://github.com/artem-v","followers_url":"https://api.github.com/users/artem-v/followers","following_url":"https://api.github.com/users/artem-v/following{/other_user}","gists_url":"https://api.github.com/users/artem-v/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-v/subscriptions","organizations_url":"https://api.github.com/users/artem-v/orgs","repos_url":"https://api.github.com/users/artem-v/repos","events_url":"https://api.github.com/users/artem-v/events{/privacy}","received_events_url":"https://api.github.com/users/artem-v/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-12T09:10:59Z","updated_at":"2016-09-12T09:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1154b78c9f9e148bc4cf6043d7c08e91f73202b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalecube/scalecube/pulls/83/commits","review_comments_url":"https://api.github.com/repos/scalecube/scalecube/pulls/83/comments","review_comment_url":"https://api.github.com/repos/scalecube/scalecube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalecube/scalecube/issues/83/comments","statuses_url":"https://api.github.com/repos/scalecube/scalecube/statuses/4d4903f851507c7bca51c69208305023372290d1","head":{"label":"scalecube:FixCodeInFailrureDetector","ref":"FixCodeInFailrureDetector","sha":"4d4903f851507c7bca51c69208305023372290d1","user":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":40714460,"name":"scalecube","full_name":"scalecube/scalecube","owner":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube","description":"ScaleCube is a lightweight decentralized cluster membership, failure detection, messaging and gossip protocol library for the Java VM","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube","forks_url":"https://api.github.com/repos/scalecube/scalecube/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube/deployments","created_at":"2015-08-14T12:44:39Z","updated_at":"2016-08-23T14:55:17Z","pushed_at":"2016-09-12T09:10:59Z","git_url":"git://github.com/scalecube/scalecube.git","ssh_url":"git@github.com:scalecube/scalecube.git","clone_url":"https://github.com/scalecube/scalecube.git","svn_url":"https://github.com/scalecube/scalecube","homepage":"http://scalecube.io/","size":881,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":19,"default_branch":"master"}},"base":{"label":"scalecube:membership-events","ref":"membership-events","sha":"54acee090abfa42cb21e769ae833976e52ff251d","user":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":40714460,"name":"scalecube","full_name":"scalecube/scalecube","owner":{"login":"scalecube","id":12896170,"avatar_url":"https://avatars.githubusercontent.com/u/12896170?v=3","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube","description":"ScaleCube is a lightweight decentralized cluster membership, failure detection, messaging and gossip protocol library for the Java VM","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube","forks_url":"https://api.github.com/repos/scalecube/scalecube/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube/deployments","created_at":"2015-08-14T12:44:39Z","updated_at":"2016-08-23T14:55:17Z","pushed_at":"2016-09-12T09:10:59Z","git_url":"git://github.com/scalecube/scalecube.git","ssh_url":"git@github.com:scalecube/scalecube.git","clone_url":"https://github.com/scalecube/scalecube.git","svn_url":"https://github.com/scalecube/scalecube","homepage":"http://scalecube.io/","size":881,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/83"},"html":{"href":"https://github.com/scalecube/scalecube/pull/83"},"issue":{"href":"https://api.github.com/repos/scalecube/scalecube/issues/83"},"comments":{"href":"https://api.github.com/repos/scalecube/scalecube/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalecube/scalecube/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/scalecube/scalecube/statuses/4d4903f851507c7bca51c69208305023372290d1"}}}}
{"actor":{"display_login":"antonkharenko"}}