{"action":"created","issue":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/846","labels_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/846/labels{/name}","comments_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/846/comments","events_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/846/events","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/846","id":127460872,"number":846,"title":"Cleanup of draw options gathering","user":{"login":"miscco","id":3017120,"avatar_url":"https://avatars.githubusercontent.com/u/3017120?v=3","gravatar_id":"","url":"https://api.github.com/users/miscco","html_url":"https://github.com/miscco","followers_url":"https://api.github.com/users/miscco/followers","following_url":"https://api.github.com/users/miscco/following{/other_user}","gists_url":"https://api.github.com/users/miscco/gists{/gist_id}","starred_url":"https://api.github.com/users/miscco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miscco/subscriptions","organizations_url":"https://api.github.com/users/miscco/orgs","repos_url":"https://api.github.com/users/miscco/repos","events_url":"https://api.github.com/users/miscco/events{/privacy}","received_events_url":"https://api.github.com/users/miscco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-19T14:44:47Z","updated_at":"2016-01-19T17:17:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/846","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/846","diff_url":"https://github.com/matlab2tikz/matlab2tikz/pull/846.diff","patch_url":"https://github.com/matlab2tikz/matlab2tikz/pull/846.patch"},"body":"So i looked into bar plots due to the issues we have with them. I found, that a lot of the draw options handling can be generalized for different plots, e.g. histogram/barplots/areas\r\n\r\nSo i did that and cleaned up various other occurrences of opt_print while i was at it.\r\n\r\nI did not bother to check all the differences yet, as i would like to know whether there is interest at all int that PR "},"comment":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/comments/172923299","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/846#issuecomment-172923299","issue_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/846","id":172923299,"user":{"login":"okomarov","id":3731173,"avatar_url":"https://avatars.githubusercontent.com/u/3731173?v=3","gravatar_id":"","url":"https://api.github.com/users/okomarov","html_url":"https://github.com/okomarov","followers_url":"https://api.github.com/users/okomarov/followers","following_url":"https://api.github.com/users/okomarov/following{/other_user}","gists_url":"https://api.github.com/users/okomarov/gists{/gist_id}","starred_url":"https://api.github.com/users/okomarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okomarov/subscriptions","organizations_url":"https://api.github.com/users/okomarov/orgs","repos_url":"https://api.github.com/users/okomarov/repos","events_url":"https://api.github.com/users/okomarov/events{/privacy}","received_events_url":"https://api.github.com/users/okomarov/received_events","type":"User","site_admin":false},"created_at":"2016-01-19T17:17:39Z","updated_at":"2016-01-19T17:17:39Z","body":"We should just make it a rule. Moving functions should be addressed in separate PRs! By moving I mean cut/paste with NO edits (not even a single char). Also, whitespace edits should be done in separate PRs. Basically, in these 2 cases, we could merge straight away or even the author of the PR, once he gets green light, he merges right away.\r\n\r\nIt is basically impossible to review this PR without opening Matlab, but often all is needed is a quick overview of the code, which can be done in github directly. "}}