{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/5547","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/5547/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/5547/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/5547/events","html_url":"https://github.com/eslint/eslint/issues/5547","id":140214416,"number":5547,"title":"`--no-ignore` should not un-ignore node_modules","user":{"login":"IanVS","id":4616705,"avatar_url":"https://avatars.githubusercontent.com/u/4616705?v=3","gravatar_id":"","url":"https://api.github.com/users/IanVS","html_url":"https://github.com/IanVS","followers_url":"https://api.github.com/users/IanVS/followers","following_url":"https://api.github.com/users/IanVS/following{/other_user}","gists_url":"https://api.github.com/users/IanVS/gists{/gist_id}","starred_url":"https://api.github.com/users/IanVS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanVS/subscriptions","organizations_url":"https://api.github.com/users/IanVS/orgs","repos_url":"https://api.github.com/users/IanVS/repos","events_url":"https://api.github.com/users/IanVS/events{/privacy}","received_events_url":"https://api.github.com/users/IanVS/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/eslint/eslint/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/eslint/eslint/labels/core","name":"core","color":"c7def8"},{"url":"https://api.github.com/repos/eslint/eslint/labels/evaluating","name":"evaluating","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-11T15:34:49Z","updated_at":"2016-03-22T22:26:30Z","closed_at":null,"body":"<!--\r\nThis template is for bug reports. If you are reporting a bug, please continue on. If you are here for another reason, please see below:\r\n\r\n1. To propose a new rule: http://eslint.org/docs/developer-guide/contributing/new-rules\r\n2. To request a change: http://eslint.org/docs/developer-guide/contributing/changes\r\n3. If you have any questions, please stop by our chatroom: https://gitter.im/eslint/eslint\r\n\r\nNote that leaving sections blank will make it difficult for us to troubleshoot and we may have to close the issue.\r\n-->\r\n\r\n**What version of ESLint are you using?**\r\nMaster\r\n\r\n**What configuration and parser (Espree, Babel-ESLint, etc.) are you using?**\r\nEspree\r\n\r\n**What did you do? Please include the actual source code causing the issue.**\r\nRan eslint with `--no-ignore` flag\r\n\r\n**What did you expect to happen?**\r\nIgnore settings from `.eslintignore` to be disregarded, as indicated in docs.\r\n\r\n**What actually happened? Please include the actual, raw output from ESLint.**\r\nESLint linted all files within `node_modules`.\r\n\r\nDespite having [tests](https://github.com/eslint/eslint/blob/d727f17f4efc888ed0e59259a4e4cac01a42f0d9/tests/lib/ignored-paths.js#L375-L383) to assert that `--no-ignore` will cause `node_modules` to be linted, I think this is not the behavior we expect or want.  \r\n\r\nThe --no-ignore docs say:\r\n> --no-ignore\r\n> Disables excluding of files from .eslintignore and --ignore-path files.\r\n\r\nThey don't say anything about also disabling default ignores.\r\n\r\nAfter https://github.com/eslint/eslint/issues/5410 is fixed, it will be possible to lint within node_modules by using a negation pattern.  (e.g. `!/node_modules/package-to-lint/`), at which time I think it would make sense to keep `--no-ignore` from linting `/node_modules/` and `/bower_components/`.\r\n\r\nDoes the team agree?"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/200061130","html_url":"https://github.com/eslint/eslint/issues/5547#issuecomment-200061130","issue_url":"https://api.github.com/repos/eslint/eslint/issues/5547","id":200061130,"user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T22:26:30Z","updated_at":"2016-03-22T22:26:30Z","body":"@alberto Is that really so, given one could specify ignore patterns in the CLI using `--ignore-pattern`?"}}