{"action":"closed","number":222,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/222","id":43702630,"html_url":"https://github.com/sonata-project/SonataBlockBundle/pull/222","diff_url":"https://github.com/sonata-project/SonataBlockBundle/pull/222.diff","patch_url":"https://github.com/sonata-project/SonataBlockBundle/pull/222.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/issues/222","number":222,"state":"closed","locked":false,"title":"Fix default settings order","user":{"login":"kea","id":208714,"avatar_url":"https://avatars.githubusercontent.com/u/208714?v=3","gravatar_id":"","url":"https://api.github.com/users/kea","html_url":"https://github.com/kea","followers_url":"https://api.github.com/users/kea/followers","following_url":"https://api.github.com/users/kea/following{/other_user}","gists_url":"https://api.github.com/users/kea/gists{/gist_id}","starred_url":"https://api.github.com/users/kea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kea/subscriptions","organizations_url":"https://api.github.com/users/kea/orgs","repos_url":"https://api.github.com/users/kea/repos","events_url":"https://api.github.com/users/kea/events{/privacy}","received_events_url":"https://api.github.com/users/kea/received_events","type":"User","site_admin":false},"body":"Related to\r\nhttps://github.com/sonata-project/SonataBlockBundle/issues/149\r\nwill close\r\nhttps://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/pull/345\r\n\r\nIn ```configureSettings``` the correct order for settings should be:\r\n- defaults for all blocks\r\n- defaults of service block\r\n- values from config\r\n\r\nI moved the ```$service->setDefaultSettings``` after the defaults for all blocks and just before the settings from config.","created_at":"2015-08-29T21:49:29Z","updated_at":"2016-05-07T15:21:28Z","closed_at":"2016-05-07T15:21:28Z","merged_at":null,"merge_commit_sha":"6db3b010b67f965baafc8286335acaaa9bca6880","assignee":null,"milestone":{"url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/milestones/2","html_url":"https://github.com/sonata-project/SonataBlockBundle/milestones/2.4","labels_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/milestones/2/labels","id":1277336,"number":2,"title":"2.4","description":"","creator":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2015-08-28T10:37:24Z","updated_at":"2016-05-07T15:21:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/222/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/222/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/issues/222/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/statuses/389999328f4ea3d40a2d6d6c96f5678aa285e4df","head":{"label":"kea:fix-default-settings-order","ref":"fix-default-settings-order","sha":"389999328f4ea3d40a2d6d6c96f5678aa285e4df","user":{"login":"kea","id":208714,"avatar_url":"https://avatars.githubusercontent.com/u/208714?v=3","gravatar_id":"","url":"https://api.github.com/users/kea","html_url":"https://github.com/kea","followers_url":"https://api.github.com/users/kea/followers","following_url":"https://api.github.com/users/kea/following{/other_user}","gists_url":"https://api.github.com/users/kea/gists{/gist_id}","starred_url":"https://api.github.com/users/kea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kea/subscriptions","organizations_url":"https://api.github.com/users/kea/orgs","repos_url":"https://api.github.com/users/kea/repos","events_url":"https://api.github.com/users/kea/events{/privacy}","received_events_url":"https://api.github.com/users/kea/received_events","type":"User","site_admin":false},"repo":{"id":41607938,"name":"SonataBlockBundle","full_name":"kea/SonataBlockBundle","owner":{"login":"kea","id":208714,"avatar_url":"https://avatars.githubusercontent.com/u/208714?v=3","gravatar_id":"","url":"https://api.github.com/users/kea","html_url":"https://github.com/kea","followers_url":"https://api.github.com/users/kea/followers","following_url":"https://api.github.com/users/kea/following{/other_user}","gists_url":"https://api.github.com/users/kea/gists{/gist_id}","starred_url":"https://api.github.com/users/kea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kea/subscriptions","organizations_url":"https://api.github.com/users/kea/orgs","repos_url":"https://api.github.com/users/kea/repos","events_url":"https://api.github.com/users/kea/events{/privacy}","received_events_url":"https://api.github.com/users/kea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kea/SonataBlockBundle","description":"Foundation to build HMVC layout","fork":true,"url":"https://api.github.com/repos/kea/SonataBlockBundle","forks_url":"https://api.github.com/repos/kea/SonataBlockBundle/forks","keys_url":"https://api.github.com/repos/kea/SonataBlockBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kea/SonataBlockBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kea/SonataBlockBundle/teams","hooks_url":"https://api.github.com/repos/kea/SonataBlockBundle/hooks","issue_events_url":"https://api.github.com/repos/kea/SonataBlockBundle/issues/events{/number}","events_url":"https://api.github.com/repos/kea/SonataBlockBundle/events","assignees_url":"https://api.github.com/repos/kea/SonataBlockBundle/assignees{/user}","branches_url":"https://api.github.com/repos/kea/SonataBlockBundle/branches{/branch}","tags_url":"https://api.github.com/repos/kea/SonataBlockBundle/tags","blobs_url":"https://api.github.com/repos/kea/SonataBlockBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kea/SonataBlockBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kea/SonataBlockBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kea/SonataBlockBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kea/SonataBlockBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/kea/SonataBlockBundle/languages","stargazers_url":"https://api.github.com/repos/kea/SonataBlockBundle/stargazers","contributors_url":"https://api.github.com/repos/kea/SonataBlockBundle/contributors","subscribers_url":"https://api.github.com/repos/kea/SonataBlockBundle/subscribers","subscription_url":"https://api.github.com/repos/kea/SonataBlockBundle/subscription","commits_url":"https://api.github.com/repos/kea/SonataBlockBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kea/SonataBlockBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kea/SonataBlockBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kea/SonataBlockBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kea/SonataBlockBundle/contents/{+path}","compare_url":"https://api.github.com/repos/kea/SonataBlockBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kea/SonataBlockBundle/merges","archive_url":"https://api.github.com/repos/kea/SonataBlockBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kea/SonataBlockBundle/downloads","issues_url":"https://api.github.com/repos/kea/SonataBlockBundle/issues{/number}","pulls_url":"https://api.github.com/repos/kea/SonataBlockBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/kea/SonataBlockBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/kea/SonataBlockBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kea/SonataBlockBundle/labels{/name}","releases_url":"https://api.github.com/repos/kea/SonataBlockBundle/releases{/id}","deployments_url":"https://api.github.com/repos/kea/SonataBlockBundle/deployments","created_at":"2015-08-29T21:31:58Z","updated_at":"2015-08-29T21:31:58Z","pushed_at":"2015-08-29T22:45:38Z","git_url":"git://github.com/kea/SonataBlockBundle.git","ssh_url":"git@github.com:kea/SonataBlockBundle.git","clone_url":"https://github.com/kea/SonataBlockBundle.git","svn_url":"https://github.com/kea/SonataBlockBundle","homepage":"http://sonata-project.org/bundles/block","size":1079,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"c05c4f6d3b60f6ca3d8cae7b405cee4d46938516","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":3409083,"name":"SonataBlockBundle","full_name":"sonata-project/SonataBlockBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataBlockBundle","description":"Foundation to build HMVC layout","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataBlockBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataBlockBundle/deployments","created_at":"2012-02-10T17:02:25Z","updated_at":"2015-09-28T08:40:31Z","pushed_at":"2016-05-07T15:20:17Z","git_url":"git://github.com/sonata-project/SonataBlockBundle.git","ssh_url":"git@github.com:sonata-project/SonataBlockBundle.git","clone_url":"https://github.com/sonata-project/SonataBlockBundle.git","svn_url":"https://github.com/sonata-project/SonataBlockBundle","homepage":"https://sonata-project.org/bundles/block","size":1535,"stargazers_count":55,"watchers_count":55,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":19,"forks":90,"open_issues":19,"watchers":55,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/222"},"html":{"href":"https://github.com/sonata-project/SonataBlockBundle/pull/222"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataBlockBundle/issues/222"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataBlockBundle/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataBlockBundle/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataBlockBundle/statuses/389999328f4ea3d40a2d6d6c96f5678aa285e4df"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":40,"deletions":9,"changed_files":2}}