{"push_id":1397933747,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"bbb8543ff1df2c6129922bea0bf0b21b4ec4d7f0","before":"6eb346b2ce79af793427938ee0309fa3bb0b2e32","commits":[{"sha":"0ac3b1517ddb801b9e8361ff3826da2082495ded","author":{"name":"Šimon Lukašík","email":"39cdf4aa51444886ae1240817ab16a5b40f250f2@fedoraproject.org"},"message":"Custom supports methods shall not crash UI\n\nSupportsFeatureMixin is used in many places in the application. For\ndynamic features a CustomFeatureMixin allows blocks like the following.\n\n    supports :x do\n      provider.api_version.abilities.include? :x\n    end\n\nThe problem occurs when an exception happens in the given block. As it\ndoes in https://bugzilla.redhat.com/show_bug.cgi?id=1394021\n\nThe supports methods are used in the UI and they are not expected to\nraise exceptions. The above mentioned bug crashes the vm details page.\n\nGiven our direction wrt code decentralization and pluggable features, I\nam afraid, our chances to keep custom supports blocks sane are\ndeteriorating. That's why I advise for rescue.","distinct":true,"url":"https://api.github.com/repos/ManageIQ/manageiq/commits/0ac3b1517ddb801b9e8361ff3826da2082495ded"},{"sha":"bbb8543ff1df2c6129922bea0bf0b21b4ec4d7f0","author":{"name":"Gregg Tanzillo","email":"f8d2bb4740e69994cb60899da8cf56590a460d57@redhat.com"},"message":"Merge pull request #12574 from isimluk/rhbz#1394021\n\nCustom supports methods shall not crash UI","distinct":true,"url":"https://api.github.com/repos/ManageIQ/manageiq/commits/bbb8543ff1df2c6129922bea0bf0b21b4ec4d7f0"}]}
{"actor":{"display_login":"gtanzillo"}}