{"action":"closed","number":198,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/198","id":46940554,"html_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/198","diff_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/198.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/198.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/198","number":198,"state":"closed","locked":false,"title":"(WIP) Use consul-tempalte for balancemembers","user":{"login":"bodepd","id":97123,"avatar_url":"https://avatars.githubusercontent.com/u/97123?v=3","gravatar_id":"","url":"https://api.github.com/users/bodepd","html_url":"https://github.com/bodepd","followers_url":"https://api.github.com/users/bodepd/followers","following_url":"https://api.github.com/users/bodepd/following{/other_user}","gists_url":"https://api.github.com/users/bodepd/gists{/gist_id}","starred_url":"https://api.github.com/users/bodepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodepd/subscriptions","organizations_url":"https://api.github.com/users/bodepd/orgs","repos_url":"https://api.github.com/users/bodepd/repos","events_url":"https://api.github.com/users/bodepd/events{/privacy}","received_events_url":"https://api.github.com/users/bodepd/received_events","type":"User","site_admin":false},"body":"This patch adds a second type of resource for\r\nadding balancemembers, namely: haproxy/balancemember_consul.\r\n\r\nThese balance members use consul-tempalte as a replacement for\r\nexport resources and assume that both consul as well as\r\nconsul-template are installed on any systems using this\r\ndefined resource type.\r\n\r\nConsul-template offers an alternative to exported resources\r\nthat allows for much more dynamic updates to configuration\r\nbased on the current state of a load balanced service (it\r\ncan allow nearly instantaneous updates of config when pool members\r\nor added, removed, or start behaving badly)\r\n\r\nPuppet configures the consul templates which rely on consul-template\r\nto actually convert them into the real haproxy file on disk.\r\n\r\nNOTE: this is marked as A WIP b/c I am interesting in feedback\r\nregarding if this patch is something that people or puppetlabs\r\nis interested in. I am happy to add tests or whatever other\r\nrequirements might exist once I have that feedback.","created_at":"2015-10-06T18:36:48Z","updated_at":"2016-02-02T04:49:16Z","closed_at":"2016-02-02T04:49:16Z","merged_at":null,"merge_commit_sha":"fe0dd36d91836430a1fdb2c5b826db2a94a769c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/198/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/198/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/198/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/statuses/764dab9b2cf13ad48f8a0af52f791c4ca925f9bb","head":{"label":"bodepd:consul_balancemembers","ref":"consul_balancemembers","sha":"764dab9b2cf13ad48f8a0af52f791c4ca925f9bb","user":{"login":"bodepd","id":97123,"avatar_url":"https://avatars.githubusercontent.com/u/97123?v=3","gravatar_id":"","url":"https://api.github.com/users/bodepd","html_url":"https://github.com/bodepd","followers_url":"https://api.github.com/users/bodepd/followers","following_url":"https://api.github.com/users/bodepd/following{/other_user}","gists_url":"https://api.github.com/users/bodepd/gists{/gist_id}","starred_url":"https://api.github.com/users/bodepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodepd/subscriptions","organizations_url":"https://api.github.com/users/bodepd/orgs","repos_url":"https://api.github.com/users/bodepd/repos","events_url":"https://api.github.com/users/bodepd/events{/privacy}","received_events_url":"https://api.github.com/users/bodepd/received_events","type":"User","site_admin":false},"repo":{"id":4621355,"name":"puppetlabs-haproxy","full_name":"bodepd/puppetlabs-haproxy","owner":{"login":"bodepd","id":97123,"avatar_url":"https://avatars.githubusercontent.com/u/97123?v=3","gravatar_id":"","url":"https://api.github.com/users/bodepd","html_url":"https://github.com/bodepd","followers_url":"https://api.github.com/users/bodepd/followers","following_url":"https://api.github.com/users/bodepd/following{/other_user}","gists_url":"https://api.github.com/users/bodepd/gists{/gist_id}","starred_url":"https://api.github.com/users/bodepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodepd/subscriptions","organizations_url":"https://api.github.com/users/bodepd/orgs","repos_url":"https://api.github.com/users/bodepd/repos","events_url":"https://api.github.com/users/bodepd/events{/privacy}","received_events_url":"https://api.github.com/users/bodepd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bodepd/puppetlabs-haproxy","description":"Puppet module to dynamically configure haproxy on Redhat family OSes using storeconfigs","fork":true,"url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy","forks_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/forks","keys_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/teams","hooks_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/hooks","issue_events_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/issues/events{/number}","events_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/events","assignees_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/assignees{/user}","branches_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/branches{/branch}","tags_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/tags","blobs_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/languages","stargazers_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/stargazers","contributors_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/contributors","subscribers_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/subscribers","subscription_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/subscription","commits_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/contents/{+path}","compare_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/merges","archive_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/downloads","issues_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/issues{/number}","pulls_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/labels{/name}","releases_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/releases{/id}","deployments_url":"https://api.github.com/repos/bodepd/puppetlabs-haproxy/deployments","created_at":"2012-06-11T05:30:54Z","updated_at":"2015-10-06T18:34:49Z","pushed_at":"2016-02-02T04:46:50Z","git_url":"git://github.com/bodepd/puppetlabs-haproxy.git","ssh_url":"git@github.com:bodepd/puppetlabs-haproxy.git","clone_url":"https://github.com/bodepd/puppetlabs-haproxy.git","svn_url":"https://github.com/bodepd/puppetlabs-haproxy","homepage":null,"size":372,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:1.3.x","ref":"1.3.x","sha":"1f0b8552d47fb1ef04c4be7457b0b7e6ac82d905","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":5579089,"name":"puppetlabs-haproxy","full_name":"puppetlabs/puppetlabs-haproxy","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-haproxy","description":"Puppet module to dynamically configure haproxy on Redhat family OSes using storeconfigs","fork":true,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/deployments","created_at":"2012-08-28T00:48:30Z","updated_at":"2016-01-04T12:32:12Z","pushed_at":"2016-02-02T04:48:32Z","git_url":"git://github.com/puppetlabs/puppetlabs-haproxy.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-haproxy.git","clone_url":"https://github.com/puppetlabs/puppetlabs-haproxy.git","svn_url":"https://github.com/puppetlabs/puppetlabs-haproxy","homepage":null,"size":748,"stargazers_count":71,"watchers_count":71,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":9,"forks":175,"open_issues":9,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/198"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-haproxy/pull/198"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/198"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-haproxy/statuses/764dab9b2cf13ad48f8a0af52f791c4ca925f9bb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":9,"review_comments":0,"commits":43,"additions":2464,"deletions":273,"changed_files":50}}