{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6395","repository_url":"https://api.github.com/repos/ember-cli/ember-cli","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6395/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6395/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6395/events","html_url":"https://github.com/ember-cli/ember-cli/pull/6395","id":186113981,"number":6395,"title":"[WIP]: Fastboot build in ember-cli","user":{"login":"kratiahuja","id":4064295,"avatar_url":"https://avatars.githubusercontent.com/u/4064295?v=3","gravatar_id":"","url":"https://api.github.com/users/kratiahuja","html_url":"https://github.com/kratiahuja","followers_url":"https://api.github.com/users/kratiahuja/followers","following_url":"https://api.github.com/users/kratiahuja/following{/other_user}","gists_url":"https://api.github.com/users/kratiahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/kratiahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kratiahuja/subscriptions","organizations_url":"https://api.github.com/users/kratiahuja/orgs","repos_url":"https://api.github.com/users/kratiahuja/repos","events_url":"https://api.github.com/users/kratiahuja/events{/privacy}","received_events_url":"https://api.github.com/users/kratiahuja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-30T03:06:30Z","updated_at":"2016-11-10T20:11:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6395","html_url":"https://github.com/ember-cli/ember-cli/pull/6395","diff_url":"https://github.com/ember-cli/ember-cli/pull/6395.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/6395.patch"},"body":"This PR is a POC that tracks building fastboot assets in ember-cli itself. The details of how fastboot should be built are [here](https://github.com/ember-cli/ember-cli/issues/6350). We would like to eventually build fastboot in an addon itself but this is a starting point. This PR is meant to evolve.\r\n\r\n_NOTE_: Some of the TODOs in this PR may change based on how we want to finally move forward with this in `ember-cli`. \r\n\r\nMy apologies if I have not followed the contributing guidelines. This is my first PR in `ember-cli`. I read all of the guidelines and tried following them but may have forgotten something on the way. \r\n\r\nThe PR has finished the POC for the following from the [task list](https://github.com/ember-cli/ember-cli/issues/6350):\r\n- [x] Build fastboot/app from app and addon into `appName-fastboot.js`\r\n- [x] Add tests for building `appName-fastboot.js`\r\n- [x] Expose a `fastboot` type for `postProcessTree` and `preProcessTree` hooks. This is needed in fastboot to add DOM helper patches based on versions and for `ember-fetch`\r\n- [x] Expose `treeForFastbootApp` and `treeForFastbootTemplates` to allow addons to munge the trees for fastboot assets.\r\n- [x] Lint the fastboot/app files as well\r\n\r\nTODO:\r\n- [ ] Update documentation of ember-cli with the additional public hooks and building of fastboot assets.\r\n\r\nI also have been locally testing the build part with a dummy fastboot app as well. If needed, I can push the dummy app changes upstream as well. Please let me know if you want to see that.\r\n\r\ncc: @stefanpenner @kellyselden @tomdale @rwjblue @chadhietala @ryanone @masonwan @danmcclain  @arjansingh\r\n"},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/259794684","html_url":"https://github.com/ember-cli/ember-cli/pull/6395#issuecomment-259794684","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6395","id":259794684,"user":{"login":"kratiahuja","id":4064295,"avatar_url":"https://avatars.githubusercontent.com/u/4064295?v=3","gravatar_id":"","url":"https://api.github.com/users/kratiahuja","html_url":"https://github.com/kratiahuja","followers_url":"https://api.github.com/users/kratiahuja/followers","following_url":"https://api.github.com/users/kratiahuja/following{/other_user}","gists_url":"https://api.github.com/users/kratiahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/kratiahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kratiahuja/subscriptions","organizations_url":"https://api.github.com/users/kratiahuja/orgs","repos_url":"https://api.github.com/users/kratiahuja/repos","events_url":"https://api.github.com/users/kratiahuja/events{/privacy}","received_events_url":"https://api.github.com/users/kratiahuja/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T20:11:39Z","updated_at":"2016-11-10T20:11:39Z","body":"@stefanpenner and everyone cc'd: This is ready to be reviewed now. Here is a [gist](https://gist.github.com/kratiahuja/e8f7c80a49deebc86a6b7130ef6d4764) of how this can run with fastboot currently. \r\n\r\nOnly remaining this is creating a new RFC to represent this work. I will send that out today and keep the current build-targets [RFC](https://github.com/ember-cli/rfcs/pull/75) open as is. "}}
{"actor":{"display_login":"kratiahuja"}}