{"push_id":1097169127,"size":12,"distinct_size":12,"ref":"refs/heads/acquire-error-2","head":"acc5e3a906c873493f74e21371624a9da7556d48","before":"85d430053050ab8983783d4d50d4e5b2b56c099e","commits":[{"sha":"1a38796e4118e593a28b70d1b991c688716ca942","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Propagate parser.TypedExpr throughout sql analysis\n\nAll sql analysis should be working on well-typed expressions. This\ncommit uses the `parser.TypedExpr` interface to assert that that is\ntrue.\n\nThis change also creates \"typed\" expression constructors within the\nsql/parser package, which are intended to:\n- hide the understanding that `Typed<X implements Expr>` types are\nimplemented by the same struct types as their corresponding `X\nimplements Expr` types.\n- Allow a follow-on PR to assure that during these constructors type\nannotations are set for the constructed `TypedExpr`s. The plan is to\npull out boolTypeAnnotion and force the explicit assignment for all\n`TypedExpr`s so we can use the annotation as a sanity check against\nimproper `Expr -> TypedExpr` type assertions.","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/1a38796e4118e593a28b70d1b991c688716ca942"},{"sha":"6ce8dc025b0d9542da1d24191bb5b6ab6173a5bd","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"storage: Fix some commentary in CommandQueue","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/6ce8dc025b0d9542da1d24191bb5b6ab6173a5bd"},{"sha":"ab0665283388c140552726f016df4aebaa5d95a0","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"Merge pull request #6478 from nvanbenschoten/nvanbenschoten/prop\n\nsql: Propagate parser.TypedExpr throughout sql analysis","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/ab0665283388c140552726f016df4aebaa5d95a0"},{"sha":"8238492cc808c9b652d4415fd16e117513d2b670","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"Merge pull request #6497 from tschottdorf/comments\n\nstorage: Fix some commentary in CommandQueue","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/8238492cc808c9b652d4415fd16e117513d2b670"},{"sha":"bc2b7a47e2c9c6cd92a18ebe916ea7ee2ddaedba","author":{"email":"ec1657b07dda0ff6262dc7efd2e7e3cc188a9ea2@gmail.com","name":"Radu Berinde"},"message":"sql: don't use qname visitor for check constraints\n\nThe check constraints verification code uses a big hammer to do a relatively\nsimple thing. I was looking at splitting off some code from the sql package and\nthe dependency on the qname visitor (part of the select code) is problematic.\n\nImplementing a convenience visitor implementation that takes a single function;\nusing it to replace the qname visitor use for check constraints.\n\nThis also results in a better error message and prevents accepting things that\n`resolveQNames` has special handling for, like `COUNT(*)` (added a test).","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/bc2b7a47e2c9c6cd92a18ebe916ea7ee2ddaedba"},{"sha":"26d59417957e0349777f3fa32fa6f02dea94df63","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Add sanity check when calling ReturnType on TypedExprs\n\nThis change asserts that `TypedExpr.ReturnType` is always called on\ntypes that both implement `TypedExpr` and have their type annotation\nset. This will act as another sanity check to work around the fact that\nmany struct types implement both `Expr` and `TypedExpr`. A future change\nmay add this precondition assertion into `TypedExpr.Eval` as well.","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/26d59417957e0349777f3fa32fa6f02dea94df63"},{"sha":"1c27739b619696282339d1d682f5007c35b6d2d2","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"sql: Create IsUnresolvedArgument method on MapArgs\n\nThe new `IsUnresolvedArgument` determines if a provided expression is a\n`ValArg` whose inferred type remains unset.","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/1c27739b619696282339d1d682f5007c35b6d2d2"},{"sha":"4b7ee2dda9d2a0c3e954c650c8be7eb3c656d47c","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"Merge pull request #6499 from nvanbenschoten/nvanbenschoten/isunres\n\nsql: Create IsUnresolvedArgument method on MapArgs","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/4b7ee2dda9d2a0c3e954c650c8be7eb3c656d47c"},{"sha":"3f85974837742513f9737db8b98ee9ee4614364b","author":{"email":"8cd32adbfdfb986a6f0d684f7a16030a20d97029@cockroachlabs.com","name":"RaduBerinde"},"message":"Merge pull request #6498 from RaduBerinde/check-refactor\n\nsql: don't use qname visitor for check constraints","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/3f85974837742513f9737db8b98ee9ee4614364b"},{"sha":"68c077841e27dc5537e259aeb48109492f691559","author":{"email":"885ea01d97daf7784d4a0ae7f66c69a3686faeb6@gmail.com","name":"Nathan VanBenschoten"},"message":"Merge pull request #6500 from nvanbenschoten/nvanbenschoten/sanity\n\nsql: Add sanity check when calling ReturnType on TypedExprs","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/68c077841e27dc5537e259aeb48109492f691559"},{"sha":"646296e98ae2b9255c0c9d62e6cd7ec3379372ee","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"rename Result.PErr to Result.Err","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/646296e98ae2b9255c0c9d62e6cd7ec3379372ee"},{"sha":"acc5e3a906c873493f74e21371624a9da7556d48","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"all: stop using pErr above the senders layer\n\nThe problem with using pErr is that any time you want to add a typed\nerror, you have to do it as an ErrorDetail in the proto. It's cumbersome\nand you hanve no control over the scope. There was no good reason for\nusing pErr above the Senders except that the DB.Txn used to return pErr.\n\nThis change the interface of Txn functions and DB.Txn() to return error\ninstead of pErr, and from there on a ton all the dominos fall up the\nstack. Retryable KV errors are now represented by a RetryableTxnError\ntype that is recognized by DB.Txn().\n\nStill to come is taking the ErrorDetails that don't need to go over the\nnetwork out of the proto.\n\nThis change cuts the transition from pErr to error short in a few places\n- notably some sql statements and the SQL Executor still deal with pErr\nfor the purposes of keeping this change under some size limit. This\nmeans that a number of hacks have been put it to be able to go back\nand forth between pErr and error.","distinct":true,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/acc5e3a906c873493f74e21371624a9da7556d48"}]}