{"action":"created","comment":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments/73603298","id":73603298,"diff_hunk":"@@ -23,7 +23,7 @@\n         . {{ maas_venv_bin }}/activate\n         {% endif %}\n         {{ maas_rpc_scripts_dir }}/rpc-maas-tool.py verify-created \\\n-        --entity {{ inventory_hostname }} \\\n+        --entity {{ inventory_hostname }}{{ maas_fqdn_extension }} \\","path":"rpcd/playbooks/verify-maas.yml","position":5,"original_position":5,"commit_id":"d2be00abb5d78033afd69cd376e50d794f182e77","original_commit_id":"d2be00abb5d78033afd69cd376e50d794f182e77","user":{"login":"Frank-ZhangXin","id":5384857,"avatar_url":"https://avatars.githubusercontent.com/u/5384857?v=3","gravatar_id":"","url":"https://api.github.com/users/Frank-ZhangXin","html_url":"https://github.com/Frank-ZhangXin","followers_url":"https://api.github.com/users/Frank-ZhangXin/followers","following_url":"https://api.github.com/users/Frank-ZhangXin/following{/other_user}","gists_url":"https://api.github.com/users/Frank-ZhangXin/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-ZhangXin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-ZhangXin/subscriptions","organizations_url":"https://api.github.com/users/Frank-ZhangXin/orgs","repos_url":"https://api.github.com/users/Frank-ZhangXin/repos","events_url":"https://api.github.com/users/Frank-ZhangXin/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-ZhangXin/received_events","type":"User","site_admin":false},"body":"verify-mass is still using inventory_hostname, which doesn't give solution that mix using hostname (ansible_hostname and inventory_name) in the same role (maas).","created_at":"2016-08-04T21:09:35Z","updated_at":"2016-08-04T21:09:35Z","html_url":"https://github.com/rcbops/rpc-openstack/pull/1289#discussion_r73603298","pull_request_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289","_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments/73603298"},"html":{"href":"https://github.com/rcbops/rpc-openstack/pull/1289#discussion_r73603298"},"pull_request":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289"}}},"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289","id":79995488,"html_url":"https://github.com/rcbops/rpc-openstack/pull/1289","diff_url":"https://github.com/rcbops/rpc-openstack/pull/1289.diff","patch_url":"https://github.com/rcbops/rpc-openstack/pull/1289.patch","issue_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1289","number":1289,"state":"open","locked":false,"title":"Use ansible_hostname in verify_maas.yml","user":{"login":"nategraf","id":5684286,"avatar_url":"https://avatars.githubusercontent.com/u/5684286?v=3","gravatar_id":"","url":"https://api.github.com/users/nategraf","html_url":"https://github.com/nategraf","followers_url":"https://api.github.com/users/nategraf/followers","following_url":"https://api.github.com/users/nategraf/following{/other_user}","gists_url":"https://api.github.com/users/nategraf/gists{/gist_id}","starred_url":"https://api.github.com/users/nategraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nategraf/subscriptions","organizations_url":"https://api.github.com/users/nategraf/orgs","repos_url":"https://api.github.com/users/nategraf/repos","events_url":"https://api.github.com/users/nategraf/events{/privacy}","received_events_url":"https://api.github.com/users/nategraf/received_events","type":"User","site_admin":false},"body":"All of the maas check templates use ansible_hostname to generate\r\ncheck names, and prior to this commit verify_maas.yml used\r\ninventory_hostname to generate the check names to verify.\r\nThis led to an error where verify_maas.yml would fail when\r\nansible_hostname and inventory_hostname were different\r\n\r\nThis commit fixes this by using ansible_hostname within\r\nverify_maas.yml to be consistent with the check templates.\r\n\r\nConnects #941","created_at":"2016-08-03T23:19:24Z","updated_at":"2016-08-04T21:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e5173855500b44e50b7ff6859b9e9111f5f56f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289/commits","review_comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289/comments","review_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1289/comments","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/d2be00abb5d78033afd69cd376e50d794f182e77","head":{"label":"rcbops:bug/941","ref":"bug/941","sha":"d2be00abb5d78033afd69cd376e50d794f182e77","user":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":30100099,"name":"rpc-openstack","full_name":"rcbops/rpc-openstack","owner":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc-openstack","description":"Rackspace Private Cloud Offering based on OpenStack","fork":false,"url":"https://api.github.com/repos/rcbops/rpc-openstack","forks_url":"https://api.github.com/repos/rcbops/rpc-openstack/forks","keys_url":"https://api.github.com/repos/rcbops/rpc-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc-openstack/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc-openstack/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/events","assignees_url":"https://api.github.com/repos/rcbops/rpc-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc-openstack/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc-openstack/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc-openstack/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc-openstack/merges","archive_url":"https://api.github.com/repos/rcbops/rpc-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc-openstack/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc-openstack/deployments","created_at":"2015-01-31T02:51:12Z","updated_at":"2016-07-27T21:21:14Z","pushed_at":"2016-08-04T20:57:44Z","git_url":"git://github.com/rcbops/rpc-openstack.git","ssh_url":"git@github.com:rcbops/rpc-openstack.git","clone_url":"https://github.com/rcbops/rpc-openstack.git","svn_url":"https://github.com/rcbops/rpc-openstack","homepage":"","size":2717,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":82,"forks":40,"open_issues":82,"watchers":31,"default_branch":"master"}},"base":{"label":"rcbops:master","ref":"master","sha":"d71e22184b761620005d6c6e6eb1b2235c4717f5","user":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":30100099,"name":"rpc-openstack","full_name":"rcbops/rpc-openstack","owner":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc-openstack","description":"Rackspace Private Cloud Offering based on OpenStack","fork":false,"url":"https://api.github.com/repos/rcbops/rpc-openstack","forks_url":"https://api.github.com/repos/rcbops/rpc-openstack/forks","keys_url":"https://api.github.com/repos/rcbops/rpc-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc-openstack/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc-openstack/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/events","assignees_url":"https://api.github.com/repos/rcbops/rpc-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc-openstack/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc-openstack/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc-openstack/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc-openstack/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc-openstack/merges","archive_url":"https://api.github.com/repos/rcbops/rpc-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc-openstack/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc-openstack/deployments","created_at":"2015-01-31T02:51:12Z","updated_at":"2016-07-27T21:21:14Z","pushed_at":"2016-08-04T20:57:44Z","git_url":"git://github.com/rcbops/rpc-openstack.git","ssh_url":"git@github.com:rcbops/rpc-openstack.git","clone_url":"https://github.com/rcbops/rpc-openstack.git","svn_url":"https://github.com/rcbops/rpc-openstack","homepage":"","size":2717,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":82,"forks":40,"open_issues":82,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289"},"html":{"href":"https://github.com/rcbops/rpc-openstack/pull/1289"},"issue":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1289"},"comments":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1289/comments"},"review_comments":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289/comments"},"review_comment":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1289/commits"},"statuses":{"href":"https://api.github.com/repos/rcbops/rpc-openstack/statuses/d2be00abb5d78033afd69cd376e50d794f182e77"}}}}
{"actor":{"display_login":"Frank-ZhangXin"}}