{"action":"created","comment":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/81248399","pull_request_review_id":2243298,"id":81248399,"diff_hunk":"@@ -66,6 +88,11 @@ export default function runAbstractStorageAdapterSpec(adapter) {\n           .then(() => assert.becomes(bound.get(key), obj))\n           .then(() => assert.isFulfilled(bound.del(key)))\n           .then(() => assert.isRejected(bound.get(key))));\n+\n+        it(`removes an item from the store when putting \\`undefined\\``, () =>\n+          bound.put(key, undefined)","path":"packages/storage-adapter-spec/src/index.js","position":42,"original_position":42,"commit_id":"2bde976706623b562f4170a5dc9d375c7269191c","original_commit_id":"2bde976706623b562f4170a5dc9d375c7269191c","user":{"login":"ianwremmel","id":1182361,"avatar_url":"https://avatars.githubusercontent.com/u/1182361?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwremmel","html_url":"https://github.com/ianwremmel","followers_url":"https://api.github.com/users/ianwremmel/followers","following_url":"https://api.github.com/users/ianwremmel/following{/other_user}","gists_url":"https://api.github.com/users/ianwremmel/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwremmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwremmel/subscriptions","organizations_url":"https://api.github.com/users/ianwremmel/orgs","repos_url":"https://api.github.com/users/ianwremmel/repos","events_url":"https://api.github.com/users/ianwremmel/events{/privacy}","received_events_url":"https://api.github.com/users/ianwremmel/received_events","type":"User","site_admin":false},"body":"When relying on implicit return, it's best to put the first line on the same line as the arrow so it's clear the braces were omitted intentionally.","created_at":"2016-09-29T22:30:37Z","updated_at":"2016-09-29T22:34:26Z","html_url":"https://github.com/ciscospark/spark-js-sdk/pull/154#discussion_r81248399","pull_request_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/81248399"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/154#discussion_r81248399"},"pull_request":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154","id":86262223,"html_url":"https://github.com/ciscospark/spark-js-sdk/pull/154","diff_url":"https://github.com/ciscospark/spark-js-sdk/pull/154.diff","patch_url":"https://github.com/ciscospark/spark-js-sdk/pull/154.patch","issue_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/154","number":154,"state":"open","locked":false,"title":"Implement IndexedDB","user":{"login":"mattnorris","id":2898571,"avatar_url":"https://avatars.githubusercontent.com/u/2898571?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnorris","html_url":"https://github.com/mattnorris","followers_url":"https://api.github.com/users/mattnorris/followers","following_url":"https://api.github.com/users/mattnorris/following{/other_user}","gists_url":"https://api.github.com/users/mattnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnorris/subscriptions","organizations_url":"https://api.github.com/users/mattnorris/orgs","repos_url":"https://api.github.com/users/mattnorris/repos","events_url":"https://api.github.com/users/mattnorris/events{/privacy}","received_events_url":"https://api.github.com/users/mattnorris/received_events","type":"User","site_admin":false},"body":"Fixes #146","created_at":"2016-09-22T00:04:34Z","updated_at":"2016-09-29T22:34:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6053da665a9abe0ed7c97f2e659e2aad11437362","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154/commits","review_comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154/comments","review_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/154/comments","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/2bde976706623b562f4170a5dc9d375c7269191c","head":{"label":"mattnorris:issue/146-indexeddb","ref":"issue/146-indexeddb","sha":"2bde976706623b562f4170a5dc9d375c7269191c","user":{"login":"mattnorris","id":2898571,"avatar_url":"https://avatars.githubusercontent.com/u/2898571?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnorris","html_url":"https://github.com/mattnorris","followers_url":"https://api.github.com/users/mattnorris/followers","following_url":"https://api.github.com/users/mattnorris/following{/other_user}","gists_url":"https://api.github.com/users/mattnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnorris/subscriptions","organizations_url":"https://api.github.com/users/mattnorris/orgs","repos_url":"https://api.github.com/users/mattnorris/repos","events_url":"https://api.github.com/users/mattnorris/events{/privacy}","received_events_url":"https://api.github.com/users/mattnorris/received_events","type":"User","site_admin":false},"repo":{"id":68856200,"name":"spark-js-sdk","full_name":"mattnorris/spark-js-sdk","owner":{"login":"mattnorris","id":2898571,"avatar_url":"https://avatars.githubusercontent.com/u/2898571?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnorris","html_url":"https://github.com/mattnorris","followers_url":"https://api.github.com/users/mattnorris/followers","following_url":"https://api.github.com/users/mattnorris/following{/other_user}","gists_url":"https://api.github.com/users/mattnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnorris/subscriptions","organizations_url":"https://api.github.com/users/mattnorris/orgs","repos_url":"https://api.github.com/users/mattnorris/repos","events_url":"https://api.github.com/users/mattnorris/events{/privacy}","received_events_url":"https://api.github.com/users/mattnorris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattnorris/spark-js-sdk","description":null,"fork":true,"url":"https://api.github.com/repos/mattnorris/spark-js-sdk","forks_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/mattnorris/spark-js-sdk/deployments","created_at":"2016-09-21T20:45:56Z","updated_at":"2016-09-21T20:45:58Z","pushed_at":"2016-09-29T21:08:56Z","git_url":"git://github.com/mattnorris/spark-js-sdk.git","ssh_url":"git@github.com:mattnorris/spark-js-sdk.git","clone_url":"https://github.com/mattnorris/spark-js-sdk.git","svn_url":"https://github.com/mattnorris/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":12345,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciscospark:master","ref":"master","sha":"c511913dcbd8e33cc0169b8b628645dcf59af15d","user":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars.githubusercontent.com/u/15900782?v=3","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"repo":{"id":62836827,"name":"spark-js-sdk","full_name":"ciscospark/spark-js-sdk","owner":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars.githubusercontent.com/u/15900782?v=3","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciscospark/spark-js-sdk","description":null,"fork":false,"url":"https://api.github.com/repos/ciscospark/spark-js-sdk","forks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/deployments","created_at":"2016-07-07T20:41:12Z","updated_at":"2016-09-21T20:03:46Z","pushed_at":"2016-09-29T22:18:39Z","git_url":"git://github.com/ciscospark/spark-js-sdk.git","ssh_url":"git@github.com:ciscospark/spark-js-sdk.git","clone_url":"https://github.com/ciscospark/spark-js-sdk.git","svn_url":"https://github.com/ciscospark/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":12725,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":87,"forks":20,"open_issues":87,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/154"},"issue":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/154"},"comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/2bde976706623b562f4170a5dc9d375c7269191c"}}}}
{"actor":{"display_login":"ianwremmel"}}