{"action":"created","issue":{"url":"https://api.github.com/repos/sass/node-sass/issues/998","repository_url":"https://api.github.com/repos/sass/node-sass","labels_url":"https://api.github.com/repos/sass/node-sass/issues/998/labels{/name}","comments_url":"https://api.github.com/repos/sass/node-sass/issues/998/comments","events_url":"https://api.github.com/repos/sass/node-sass/issues/998/events","html_url":"https://github.com/sass/node-sass/pull/998","id":87121265,"number":998,"title":"Adding a test for importer callback order","user":{"login":"beatak","id":23968,"avatar_url":"https://avatars.githubusercontent.com/u/23968?v=3","gravatar_id":"","url":"https://api.github.com/users/beatak","html_url":"https://github.com/beatak","followers_url":"https://api.github.com/users/beatak/followers","following_url":"https://api.github.com/users/beatak/following{/other_user}","gists_url":"https://api.github.com/users/beatak/gists{/gist_id}","starred_url":"https://api.github.com/users/beatak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beatak/subscriptions","organizations_url":"https://api.github.com/users/beatak/orgs","repos_url":"https://api.github.com/users/beatak/repos","events_url":"https://api.github.com/users/beatak/events{/privacy}","received_events_url":"https://api.github.com/users/beatak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-10T21:57:18Z","updated_at":"2016-03-23T10:29:37Z","closed_at":"2016-03-23T10:29:37Z","pull_request":{"url":"https://api.github.com/repos/sass/node-sass/pulls/998","html_url":"https://github.com/sass/node-sass/pull/998","diff_url":"https://github.com/sass/node-sass/pull/998.diff","patch_url":"https://github.com/sass/node-sass/pull/998.patch"},"body":"This pull request is to add a test case for https://github.com/sass/libsass/issues/1262 and this test is currently failing.  I have chatted with @xzyfer and he thinks it's a bug.\r\n\r\nBesides the main point (the callback order is not DFS), I also found that the importer won't callback for the nested nodes.\r\n\r\nThis test add `index.scss` and tree is as follows:\r\n```\r\n                   +-----+            \r\n                   |index|            \r\n                   +--+--+            \r\n                      |               \r\n         +-------------------------+  \r\n        +-+        +------+       +-+ \r\n        |a|        |common|       |b| \r\n        +++        +--+---+       +++ \r\n         |            |            |  \r\n   +-----+--+     +---+----+       |  \r\n+------+  +--+  +----+ +------+   ++-+\r\n|common|  |a1|  |vars| |struct|   |b1|\r\n+--+---+  +--+  +----+ +------+   +--+\r\n   |                                  \r\n  +--------+                          \r\n+----+ +------+                       \r\n|vars| |struct|                       \r\n+----+ +------+                       \r\n```\r\n\r\nActually, `node-sass` calls nodes in the order of `[a, common, b, common, a1, vars, struct, b1]` instead of `[a, common, vars, struct, a1, common, vars, struct, b, b1]`  Not only the order is wrong, but also `vars` and `struct` didn't get called twice."},"comment":{"url":"https://api.github.com/repos/sass/node-sass/issues/comments/200286827","html_url":"https://github.com/sass/node-sass/pull/998#issuecomment-200286827","issue_url":"https://api.github.com/repos/sass/node-sass/issues/998","id":200286827,"user":{"login":"xzyfer","id":579928,"avatar_url":"https://avatars.githubusercontent.com/u/579928?v=3","gravatar_id":"","url":"https://api.github.com/users/xzyfer","html_url":"https://github.com/xzyfer","followers_url":"https://api.github.com/users/xzyfer/followers","following_url":"https://api.github.com/users/xzyfer/following{/other_user}","gists_url":"https://api.github.com/users/xzyfer/gists{/gist_id}","starred_url":"https://api.github.com/users/xzyfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xzyfer/subscriptions","organizations_url":"https://api.github.com/users/xzyfer/orgs","repos_url":"https://api.github.com/users/xzyfer/repos","events_url":"https://api.github.com/users/xzyfer/events{/privacy}","received_events_url":"https://api.github.com/users/xzyfer/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T10:29:37Z","updated_at":"2016-03-23T10:29:37Z","body":"Superseded by #1420"}}