{"action":"opened","number":2840,"pull_request":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2840","id":83362087,"html_url":"https://github.com/zaproxy/zaproxy/pull/2840","diff_url":"https://github.com/zaproxy/zaproxy/pull/2840.diff","patch_url":"https://github.com/zaproxy/zaproxy/pull/2840.patch","issue_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/2840","number":2840,"state":"open","locked":false,"title":"Reduce session load time with many alerts","user":{"login":"thc202","id":4639210,"avatar_url":"https://avatars.githubusercontent.com/u/4639210?v=3","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"body":"Change SiteNode and HistoryReference to use a Set for the alerts, which\r\nalready ensures that there are no duplicates (instead of having to\r\niterate the Lists to check for duplicates, which was leading to too\r\nmuch time spent checking that). Also, for SiteNode keep track of the\r\nalert with highest risk instead of iterating the collection each time\r\nthe string representation is needed.\r\nChange other classes to reduce the calls to obtain the alerts from the\r\npreviously mentioned classes, since they return a copy of the internal\r\ncollection.","created_at":"2016-08-30T22:57:38Z","updated_at":"2016-08-30T22:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2840/commits","review_comments_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2840/comments","review_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/2840/comments","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/b44acb0a5cc82526dd9793d4b62c2e1f64bb10b0","head":{"label":"thc202:session-load-time","ref":"session-load-time","sha":"b44acb0a5cc82526dd9793d4b62c2e1f64bb10b0","user":{"login":"thc202","id":4639210,"avatar_url":"https://avatars.githubusercontent.com/u/4639210?v=3","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"repo":{"id":36922121,"name":"zaproxy","full_name":"thc202/zaproxy","owner":{"login":"thc202","id":4639210,"avatar_url":"https://avatars.githubusercontent.com/u/4639210?v=3","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thc202/zaproxy","description":"The OWASP ZAP core project","fork":true,"url":"https://api.github.com/repos/thc202/zaproxy","forks_url":"https://api.github.com/repos/thc202/zaproxy/forks","keys_url":"https://api.github.com/repos/thc202/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thc202/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thc202/zaproxy/teams","hooks_url":"https://api.github.com/repos/thc202/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/thc202/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/thc202/zaproxy/events","assignees_url":"https://api.github.com/repos/thc202/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/thc202/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/thc202/zaproxy/tags","blobs_url":"https://api.github.com/repos/thc202/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thc202/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thc202/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/thc202/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thc202/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/thc202/zaproxy/languages","stargazers_url":"https://api.github.com/repos/thc202/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/thc202/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/thc202/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/thc202/zaproxy/subscription","commits_url":"https://api.github.com/repos/thc202/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/thc202/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/thc202/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/thc202/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/thc202/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/thc202/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thc202/zaproxy/merges","archive_url":"https://api.github.com/repos/thc202/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thc202/zaproxy/downloads","issues_url":"https://api.github.com/repos/thc202/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/thc202/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/thc202/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/thc202/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thc202/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/thc202/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/thc202/zaproxy/deployments","created_at":"2015-06-05T08:44:56Z","updated_at":"2016-01-11T11:27:53Z","pushed_at":"2016-08-30T22:57:02Z","git_url":"git://github.com/thc202/zaproxy.git","ssh_url":"git@github.com:thc202/zaproxy.git","clone_url":"https://github.com/thc202/zaproxy.git","svn_url":"https://github.com/thc202/zaproxy","homepage":null,"size":166095,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zaproxy:develop","ref":"develop","sha":"7098ccd9de899678dc75be097598fb0180e3bc32","user":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars.githubusercontent.com/u/6716868?v=3","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":36817565,"name":"zaproxy","full_name":"zaproxy/zaproxy","owner":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars.githubusercontent.com/u/6716868?v=3","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zaproxy/zaproxy","description":"The OWASP ZAP core project","fork":false,"url":"https://api.github.com/repos/zaproxy/zaproxy","forks_url":"https://api.github.com/repos/zaproxy/zaproxy/forks","keys_url":"https://api.github.com/repos/zaproxy/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaproxy/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaproxy/zaproxy/teams","hooks_url":"https://api.github.com/repos/zaproxy/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/zaproxy/zaproxy/events","assignees_url":"https://api.github.com/repos/zaproxy/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/zaproxy/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/zaproxy/zaproxy/tags","blobs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaproxy/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaproxy/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/zaproxy/zaproxy/languages","stargazers_url":"https://api.github.com/repos/zaproxy/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/zaproxy/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/zaproxy/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/zaproxy/zaproxy/subscription","commits_url":"https://api.github.com/repos/zaproxy/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaproxy/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaproxy/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/zaproxy/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaproxy/zaproxy/merges","archive_url":"https://api.github.com/repos/zaproxy/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaproxy/zaproxy/downloads","issues_url":"https://api.github.com/repos/zaproxy/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/zaproxy/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/zaproxy/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaproxy/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/zaproxy/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/zaproxy/zaproxy/deployments","created_at":"2015-06-03T16:55:01Z","updated_at":"2016-08-30T18:50:39Z","pushed_at":"2016-08-30T22:16:14Z","git_url":"git://github.com/zaproxy/zaproxy.git","ssh_url":"git@github.com:zaproxy/zaproxy.git","clone_url":"https://github.com/zaproxy/zaproxy.git","svn_url":"https://github.com/zaproxy/zaproxy","homepage":null,"size":171817,"stargazers_count":1534,"watchers_count":1534,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":337,"mirror_url":null,"open_issues_count":525,"forks":337,"open_issues":525,"watchers":1534,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2840"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/2840"},"issue":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/2840"},"comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/2840/comments"},"review_comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2840/comments"},"review_comment":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/2840/commits"},"statuses":{"href":"https://api.github.com/repos/zaproxy/zaproxy/statuses/b44acb0a5cc82526dd9793d4b62c2e1f64bb10b0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":181,"deletions":72,"changed_files":4}}
{"actor":{"display_login":"thc202"}}