{"action":"created","comment":{"url":"https://api.github.com/repos/hackmdio/hackmd/pulls/comments/93650148","pull_request_review_id":14182539,"id":93650148,"diff_hunk":"@@ -22,6 +22,11 @@ You can quickly setup a sample heroku hackmd application by clicking the button\n \n [![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy)\n \n+You have to setup the minimal configuration\n+\n+- App Name ( Ex: hackmd )\n+- HMD_DOMAIN ( Ex: hackmd.herokuapp.com )","path":"README.md","position":7,"original_position":7,"commit_id":"a16f0ef258ea0fb184473d6bfb6e23f9ac1fa687","original_commit_id":"a16f0ef258ea0fb184473d6bfb6e23f9ac1fa687","user":{"login":"Yukaii","id":4230968,"avatar_url":"https://avatars.githubusercontent.com/u/4230968?v=3","gravatar_id":"","url":"https://api.github.com/users/Yukaii","html_url":"https://github.com/Yukaii","followers_url":"https://api.github.com/users/Yukaii/followers","following_url":"https://api.github.com/users/Yukaii/following{/other_user}","gists_url":"https://api.github.com/users/Yukaii/gists{/gist_id}","starred_url":"https://api.github.com/users/Yukaii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yukaii/subscriptions","organizations_url":"https://api.github.com/users/Yukaii/orgs","repos_url":"https://api.github.com/users/Yukaii/repos","events_url":"https://api.github.com/users/Yukaii/events{/privacy}","received_events_url":"https://api.github.com/users/Yukaii/received_events","type":"User","site_admin":false},"body":"I do prefer to let Heroku handle domain itself. I'm not setting `HMD_DOMAIN` value, and both heroku domain(xxx.herokuapp.com) and my custom domain work. 😄 ","created_at":"2016-12-22T16:10:00Z","updated_at":"2016-12-22T16:10:00Z","html_url":"https://github.com/hackmdio/hackmd/pull/295#discussion_r93650148","pull_request_url":"https://api.github.com/repos/hackmdio/hackmd/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/hackmdio/hackmd/pulls/comments/93650148"},"html":{"href":"https://github.com/hackmdio/hackmd/pull/295#discussion_r93650148"},"pull_request":{"href":"https://api.github.com/repos/hackmdio/hackmd/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/hackmdio/hackmd/pulls/295","id":99117705,"html_url":"https://github.com/hackmdio/hackmd/pull/295","diff_url":"https://github.com/hackmdio/hackmd/pull/295.diff","patch_url":"https://github.com/hackmdio/hackmd/pull/295.patch","issue_url":"https://api.github.com/repos/hackmdio/hackmd/issues/295","number":295,"state":"open","locked":false,"title":"Fix heroku config file error and set default value","user":{"login":"bananaappletw","id":6241350,"avatar_url":"https://avatars.githubusercontent.com/u/6241350?v=3","gravatar_id":"","url":"https://api.github.com/users/bananaappletw","html_url":"https://github.com/bananaappletw","followers_url":"https://api.github.com/users/bananaappletw/followers","following_url":"https://api.github.com/users/bananaappletw/following{/other_user}","gists_url":"https://api.github.com/users/bananaappletw/gists{/gist_id}","starred_url":"https://api.github.com/users/bananaappletw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bananaappletw/subscriptions","organizations_url":"https://api.github.com/users/bananaappletw/orgs","repos_url":"https://api.github.com/users/bananaappletw/repos","events_url":"https://api.github.com/users/bananaappletw/events{/privacy}","received_events_url":"https://api.github.com/users/bananaappletw/received_events","type":"User","site_admin":false},"body":"Fix  heroku config file error and set default value.\r\nEasier to deploy on heroku.","created_at":"2016-12-22T15:00:55Z","updated_at":"2016-12-22T16:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d435df04bc9617ff8b5756b3e82442bcf0512656","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hackmdio/hackmd/pulls/295/commits","review_comments_url":"https://api.github.com/repos/hackmdio/hackmd/pulls/295/comments","review_comment_url":"https://api.github.com/repos/hackmdio/hackmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hackmdio/hackmd/issues/295/comments","statuses_url":"https://api.github.com/repos/hackmdio/hackmd/statuses/a16f0ef258ea0fb184473d6bfb6e23f9ac1fa687","head":{"label":"bananaappletw:master","ref":"master","sha":"a16f0ef258ea0fb184473d6bfb6e23f9ac1fa687","user":{"login":"bananaappletw","id":6241350,"avatar_url":"https://avatars.githubusercontent.com/u/6241350?v=3","gravatar_id":"","url":"https://api.github.com/users/bananaappletw","html_url":"https://github.com/bananaappletw","followers_url":"https://api.github.com/users/bananaappletw/followers","following_url":"https://api.github.com/users/bananaappletw/following{/other_user}","gists_url":"https://api.github.com/users/bananaappletw/gists{/gist_id}","starred_url":"https://api.github.com/users/bananaappletw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bananaappletw/subscriptions","organizations_url":"https://api.github.com/users/bananaappletw/orgs","repos_url":"https://api.github.com/users/bananaappletw/repos","events_url":"https://api.github.com/users/bananaappletw/events{/privacy}","received_events_url":"https://api.github.com/users/bananaappletw/received_events","type":"User","site_admin":false},"repo":{"id":77151140,"name":"hackmd","full_name":"bananaappletw/hackmd","owner":{"login":"bananaappletw","id":6241350,"avatar_url":"https://avatars.githubusercontent.com/u/6241350?v=3","gravatar_id":"","url":"https://api.github.com/users/bananaappletw","html_url":"https://github.com/bananaappletw","followers_url":"https://api.github.com/users/bananaappletw/followers","following_url":"https://api.github.com/users/bananaappletw/following{/other_user}","gists_url":"https://api.github.com/users/bananaappletw/gists{/gist_id}","starred_url":"https://api.github.com/users/bananaappletw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bananaappletw/subscriptions","organizations_url":"https://api.github.com/users/bananaappletw/orgs","repos_url":"https://api.github.com/users/bananaappletw/repos","events_url":"https://api.github.com/users/bananaappletw/events{/privacy}","received_events_url":"https://api.github.com/users/bananaappletw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bananaappletw/hackmd","description":"Realtime collaborative markdown notes on all platforms.","fork":true,"url":"https://api.github.com/repos/bananaappletw/hackmd","forks_url":"https://api.github.com/repos/bananaappletw/hackmd/forks","keys_url":"https://api.github.com/repos/bananaappletw/hackmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bananaappletw/hackmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bananaappletw/hackmd/teams","hooks_url":"https://api.github.com/repos/bananaappletw/hackmd/hooks","issue_events_url":"https://api.github.com/repos/bananaappletw/hackmd/issues/events{/number}","events_url":"https://api.github.com/repos/bananaappletw/hackmd/events","assignees_url":"https://api.github.com/repos/bananaappletw/hackmd/assignees{/user}","branches_url":"https://api.github.com/repos/bananaappletw/hackmd/branches{/branch}","tags_url":"https://api.github.com/repos/bananaappletw/hackmd/tags","blobs_url":"https://api.github.com/repos/bananaappletw/hackmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bananaappletw/hackmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bananaappletw/hackmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bananaappletw/hackmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bananaappletw/hackmd/statuses/{sha}","languages_url":"https://api.github.com/repos/bananaappletw/hackmd/languages","stargazers_url":"https://api.github.com/repos/bananaappletw/hackmd/stargazers","contributors_url":"https://api.github.com/repos/bananaappletw/hackmd/contributors","subscribers_url":"https://api.github.com/repos/bananaappletw/hackmd/subscribers","subscription_url":"https://api.github.com/repos/bananaappletw/hackmd/subscription","commits_url":"https://api.github.com/repos/bananaappletw/hackmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bananaappletw/hackmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bananaappletw/hackmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bananaappletw/hackmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bananaappletw/hackmd/contents/{+path}","compare_url":"https://api.github.com/repos/bananaappletw/hackmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bananaappletw/hackmd/merges","archive_url":"https://api.github.com/repos/bananaappletw/hackmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bananaappletw/hackmd/downloads","issues_url":"https://api.github.com/repos/bananaappletw/hackmd/issues{/number}","pulls_url":"https://api.github.com/repos/bananaappletw/hackmd/pulls{/number}","milestones_url":"https://api.github.com/repos/bananaappletw/hackmd/milestones{/number}","notifications_url":"https://api.github.com/repos/bananaappletw/hackmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bananaappletw/hackmd/labels{/name}","releases_url":"https://api.github.com/repos/bananaappletw/hackmd/releases{/id}","deployments_url":"https://api.github.com/repos/bananaappletw/hackmd/deployments","created_at":"2016-12-22T14:31:53Z","updated_at":"2016-12-22T14:31:56Z","pushed_at":"2016-12-22T14:58:52Z","git_url":"git://github.com/bananaappletw/hackmd.git","ssh_url":"git@github.com:bananaappletw/hackmd.git","clone_url":"https://github.com/bananaappletw/hackmd.git","svn_url":"https://github.com/bananaappletw/hackmd","homepage":"https://hackmd.io","size":16585,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hackmdio:master","ref":"master","sha":"8cf849e825e96510c064479bbf89b595e6728511","user":{"login":"hackmdio","id":13574138,"avatar_url":"https://avatars.githubusercontent.com/u/13574138?v=3","gravatar_id":"","url":"https://api.github.com/users/hackmdio","html_url":"https://github.com/hackmdio","followers_url":"https://api.github.com/users/hackmdio/followers","following_url":"https://api.github.com/users/hackmdio/following{/other_user}","gists_url":"https://api.github.com/users/hackmdio/gists{/gist_id}","starred_url":"https://api.github.com/users/hackmdio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackmdio/subscriptions","organizations_url":"https://api.github.com/users/hackmdio/orgs","repos_url":"https://api.github.com/users/hackmdio/repos","events_url":"https://api.github.com/users/hackmdio/events{/privacy}","received_events_url":"https://api.github.com/users/hackmdio/received_events","type":"Organization","site_admin":false},"repo":{"id":35017238,"name":"hackmd","full_name":"hackmdio/hackmd","owner":{"login":"hackmdio","id":13574138,"avatar_url":"https://avatars.githubusercontent.com/u/13574138?v=3","gravatar_id":"","url":"https://api.github.com/users/hackmdio","html_url":"https://github.com/hackmdio","followers_url":"https://api.github.com/users/hackmdio/followers","following_url":"https://api.github.com/users/hackmdio/following{/other_user}","gists_url":"https://api.github.com/users/hackmdio/gists{/gist_id}","starred_url":"https://api.github.com/users/hackmdio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackmdio/subscriptions","organizations_url":"https://api.github.com/users/hackmdio/orgs","repos_url":"https://api.github.com/users/hackmdio/repos","events_url":"https://api.github.com/users/hackmdio/events{/privacy}","received_events_url":"https://api.github.com/users/hackmdio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hackmdio/hackmd","description":"Realtime collaborative markdown notes on all platforms.","fork":false,"url":"https://api.github.com/repos/hackmdio/hackmd","forks_url":"https://api.github.com/repos/hackmdio/hackmd/forks","keys_url":"https://api.github.com/repos/hackmdio/hackmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hackmdio/hackmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hackmdio/hackmd/teams","hooks_url":"https://api.github.com/repos/hackmdio/hackmd/hooks","issue_events_url":"https://api.github.com/repos/hackmdio/hackmd/issues/events{/number}","events_url":"https://api.github.com/repos/hackmdio/hackmd/events","assignees_url":"https://api.github.com/repos/hackmdio/hackmd/assignees{/user}","branches_url":"https://api.github.com/repos/hackmdio/hackmd/branches{/branch}","tags_url":"https://api.github.com/repos/hackmdio/hackmd/tags","blobs_url":"https://api.github.com/repos/hackmdio/hackmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hackmdio/hackmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hackmdio/hackmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hackmdio/hackmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hackmdio/hackmd/statuses/{sha}","languages_url":"https://api.github.com/repos/hackmdio/hackmd/languages","stargazers_url":"https://api.github.com/repos/hackmdio/hackmd/stargazers","contributors_url":"https://api.github.com/repos/hackmdio/hackmd/contributors","subscribers_url":"https://api.github.com/repos/hackmdio/hackmd/subscribers","subscription_url":"https://api.github.com/repos/hackmdio/hackmd/subscription","commits_url":"https://api.github.com/repos/hackmdio/hackmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hackmdio/hackmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hackmdio/hackmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hackmdio/hackmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hackmdio/hackmd/contents/{+path}","compare_url":"https://api.github.com/repos/hackmdio/hackmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hackmdio/hackmd/merges","archive_url":"https://api.github.com/repos/hackmdio/hackmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hackmdio/hackmd/downloads","issues_url":"https://api.github.com/repos/hackmdio/hackmd/issues{/number}","pulls_url":"https://api.github.com/repos/hackmdio/hackmd/pulls{/number}","milestones_url":"https://api.github.com/repos/hackmdio/hackmd/milestones{/number}","notifications_url":"https://api.github.com/repos/hackmdio/hackmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hackmdio/hackmd/labels{/name}","releases_url":"https://api.github.com/repos/hackmdio/hackmd/releases{/id}","deployments_url":"https://api.github.com/repos/hackmdio/hackmd/deployments","created_at":"2015-05-04T06:06:45Z","updated_at":"2016-12-22T11:22:43Z","pushed_at":"2016-12-22T15:00:56Z","git_url":"git://github.com/hackmdio/hackmd.git","ssh_url":"git@github.com:hackmdio/hackmd.git","clone_url":"https://github.com/hackmdio/hackmd.git","svn_url":"https://github.com/hackmdio/hackmd","homepage":"https://hackmd.io","size":16584,"stargazers_count":1341,"watchers_count":1341,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":69,"forks":161,"open_issues":69,"watchers":1341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hackmdio/hackmd/pulls/295"},"html":{"href":"https://github.com/hackmdio/hackmd/pull/295"},"issue":{"href":"https://api.github.com/repos/hackmdio/hackmd/issues/295"},"comments":{"href":"https://api.github.com/repos/hackmdio/hackmd/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/hackmdio/hackmd/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/hackmdio/hackmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hackmdio/hackmd/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/hackmdio/hackmd/statuses/a16f0ef258ea0fb184473d6bfb6e23f9ac1fa687"}}}}
{"actor":{"display_login":"Yukaii"}}