{"action":"closed","number":74,"pull_request":{"url":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/74","id":78188565,"html_url":"https://github.com/fuwaneko/node-protobuf/pull/74","diff_url":"https://github.com/fuwaneko/node-protobuf/pull/74.diff","patch_url":"https://github.com/fuwaneko/node-protobuf/pull/74.patch","issue_url":"https://api.github.com/repos/fuwaneko/node-protobuf/issues/74","number":74,"state":"closed","locked":false,"title":"avoid parsing and allocating memory for unset optional fields","user":{"login":"InfinitiesLoop","id":202632,"avatar_url":"https://avatars.githubusercontent.com/u/202632?v=3","gravatar_id":"","url":"https://api.github.com/users/InfinitiesLoop","html_url":"https://github.com/InfinitiesLoop","followers_url":"https://api.github.com/users/InfinitiesLoop/followers","following_url":"https://api.github.com/users/InfinitiesLoop/following{/other_user}","gists_url":"https://api.github.com/users/InfinitiesLoop/gists{/gist_id}","starred_url":"https://api.github.com/users/InfinitiesLoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfinitiesLoop/subscriptions","organizations_url":"https://api.github.com/users/InfinitiesLoop/orgs","repos_url":"https://api.github.com/users/InfinitiesLoop/repos","events_url":"https://api.github.com/users/InfinitiesLoop/events{/privacy}","received_events_url":"https://api.github.com/users/InfinitiesLoop/received_events","type":"User","site_admin":false},"body":"When the field is optional and the parsed protobuf Message does not have the field, there's no need to parse it into a v8 object. This just moves that check before the work is done. ","created_at":"2016-07-20T17:39:42Z","updated_at":"2016-07-21T09:10:31Z","closed_at":"2016-07-21T09:10:31Z","merged_at":"2016-07-21T09:10:31Z","merge_commit_sha":"c412f336c79a0d6dde10271d9f5332ebdce9483a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/74/commits","review_comments_url":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/74/comments","review_comment_url":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fuwaneko/node-protobuf/issues/74/comments","statuses_url":"https://api.github.com/repos/fuwaneko/node-protobuf/statuses/03192c04d6e0b1a9e44a2a44ac9934a6dec924c5","head":{"label":"InfinitiesLoop:unset-optional","ref":"unset-optional","sha":"03192c04d6e0b1a9e44a2a44ac9934a6dec924c5","user":{"login":"InfinitiesLoop","id":202632,"avatar_url":"https://avatars.githubusercontent.com/u/202632?v=3","gravatar_id":"","url":"https://api.github.com/users/InfinitiesLoop","html_url":"https://github.com/InfinitiesLoop","followers_url":"https://api.github.com/users/InfinitiesLoop/followers","following_url":"https://api.github.com/users/InfinitiesLoop/following{/other_user}","gists_url":"https://api.github.com/users/InfinitiesLoop/gists{/gist_id}","starred_url":"https://api.github.com/users/InfinitiesLoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfinitiesLoop/subscriptions","organizations_url":"https://api.github.com/users/InfinitiesLoop/orgs","repos_url":"https://api.github.com/users/InfinitiesLoop/repos","events_url":"https://api.github.com/users/InfinitiesLoop/events{/privacy}","received_events_url":"https://api.github.com/users/InfinitiesLoop/received_events","type":"User","site_admin":false},"repo":{"id":60497212,"name":"node-protobuf","full_name":"InfinitiesLoop/node-protobuf","owner":{"login":"InfinitiesLoop","id":202632,"avatar_url":"https://avatars.githubusercontent.com/u/202632?v=3","gravatar_id":"","url":"https://api.github.com/users/InfinitiesLoop","html_url":"https://github.com/InfinitiesLoop","followers_url":"https://api.github.com/users/InfinitiesLoop/followers","following_url":"https://api.github.com/users/InfinitiesLoop/following{/other_user}","gists_url":"https://api.github.com/users/InfinitiesLoop/gists{/gist_id}","starred_url":"https://api.github.com/users/InfinitiesLoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfinitiesLoop/subscriptions","organizations_url":"https://api.github.com/users/InfinitiesLoop/orgs","repos_url":"https://api.github.com/users/InfinitiesLoop/repos","events_url":"https://api.github.com/users/InfinitiesLoop/events{/privacy}","received_events_url":"https://api.github.com/users/InfinitiesLoop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/InfinitiesLoop/node-protobuf","description":"Google Protocol Buffers wrapper for Node.js","fork":true,"url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf","forks_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/forks","keys_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/teams","hooks_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/hooks","issue_events_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/events","assignees_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/tags","blobs_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/languages","stargazers_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/stargazers","contributors_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/contributors","subscribers_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/subscribers","subscription_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/subscription","commits_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/merges","archive_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/downloads","issues_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/labels{/name}","releases_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/InfinitiesLoop/node-protobuf/deployments","created_at":"2016-06-06T03:57:17Z","updated_at":"2016-07-19T21:09:21Z","pushed_at":"2016-07-20T17:57:19Z","git_url":"git://github.com/InfinitiesLoop/node-protobuf.git","ssh_url":"git@github.com:InfinitiesLoop/node-protobuf.git","clone_url":"https://github.com/InfinitiesLoop/node-protobuf.git","svn_url":"https://github.com/InfinitiesLoop/node-protobuf","homepage":null,"size":1920,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fuwaneko:master","ref":"master","sha":"42f24e84a78c458b313bd2a268df7ea682f7c57f","user":{"login":"fuwaneko","id":34433,"avatar_url":"https://avatars.githubusercontent.com/u/34433?v=3","gravatar_id":"","url":"https://api.github.com/users/fuwaneko","html_url":"https://github.com/fuwaneko","followers_url":"https://api.github.com/users/fuwaneko/followers","following_url":"https://api.github.com/users/fuwaneko/following{/other_user}","gists_url":"https://api.github.com/users/fuwaneko/gists{/gist_id}","starred_url":"https://api.github.com/users/fuwaneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuwaneko/subscriptions","organizations_url":"https://api.github.com/users/fuwaneko/orgs","repos_url":"https://api.github.com/users/fuwaneko/repos","events_url":"https://api.github.com/users/fuwaneko/events{/privacy}","received_events_url":"https://api.github.com/users/fuwaneko/received_events","type":"User","site_admin":false},"repo":{"id":10730595,"name":"node-protobuf","full_name":"fuwaneko/node-protobuf","owner":{"login":"fuwaneko","id":34433,"avatar_url":"https://avatars.githubusercontent.com/u/34433?v=3","gravatar_id":"","url":"https://api.github.com/users/fuwaneko","html_url":"https://github.com/fuwaneko","followers_url":"https://api.github.com/users/fuwaneko/followers","following_url":"https://api.github.com/users/fuwaneko/following{/other_user}","gists_url":"https://api.github.com/users/fuwaneko/gists{/gist_id}","starred_url":"https://api.github.com/users/fuwaneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuwaneko/subscriptions","organizations_url":"https://api.github.com/users/fuwaneko/orgs","repos_url":"https://api.github.com/users/fuwaneko/repos","events_url":"https://api.github.com/users/fuwaneko/events{/privacy}","received_events_url":"https://api.github.com/users/fuwaneko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fuwaneko/node-protobuf","description":"Google Protocol Buffers wrapper for Node.js","fork":false,"url":"https://api.github.com/repos/fuwaneko/node-protobuf","forks_url":"https://api.github.com/repos/fuwaneko/node-protobuf/forks","keys_url":"https://api.github.com/repos/fuwaneko/node-protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuwaneko/node-protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuwaneko/node-protobuf/teams","hooks_url":"https://api.github.com/repos/fuwaneko/node-protobuf/hooks","issue_events_url":"https://api.github.com/repos/fuwaneko/node-protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/fuwaneko/node-protobuf/events","assignees_url":"https://api.github.com/repos/fuwaneko/node-protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/fuwaneko/node-protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/fuwaneko/node-protobuf/tags","blobs_url":"https://api.github.com/repos/fuwaneko/node-protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuwaneko/node-protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuwaneko/node-protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuwaneko/node-protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuwaneko/node-protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/fuwaneko/node-protobuf/languages","stargazers_url":"https://api.github.com/repos/fuwaneko/node-protobuf/stargazers","contributors_url":"https://api.github.com/repos/fuwaneko/node-protobuf/contributors","subscribers_url":"https://api.github.com/repos/fuwaneko/node-protobuf/subscribers","subscription_url":"https://api.github.com/repos/fuwaneko/node-protobuf/subscription","commits_url":"https://api.github.com/repos/fuwaneko/node-protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuwaneko/node-protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuwaneko/node-protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuwaneko/node-protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuwaneko/node-protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/fuwaneko/node-protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuwaneko/node-protobuf/merges","archive_url":"https://api.github.com/repos/fuwaneko/node-protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuwaneko/node-protobuf/downloads","issues_url":"https://api.github.com/repos/fuwaneko/node-protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/fuwaneko/node-protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/fuwaneko/node-protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuwaneko/node-protobuf/labels{/name}","releases_url":"https://api.github.com/repos/fuwaneko/node-protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/fuwaneko/node-protobuf/deployments","created_at":"2013-06-17T05:24:41Z","updated_at":"2016-07-19T00:56:24Z","pushed_at":"2016-07-21T09:10:31Z","git_url":"git://github.com/fuwaneko/node-protobuf.git","ssh_url":"git@github.com:fuwaneko/node-protobuf.git","clone_url":"https://github.com/fuwaneko/node-protobuf.git","svn_url":"https://github.com/fuwaneko/node-protobuf","homepage":null,"size":1922,"stargazers_count":124,"watchers_count":124,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":3,"forks":33,"open_issues":3,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/74"},"html":{"href":"https://github.com/fuwaneko/node-protobuf/pull/74"},"issue":{"href":"https://api.github.com/repos/fuwaneko/node-protobuf/issues/74"},"comments":{"href":"https://api.github.com/repos/fuwaneko/node-protobuf/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fuwaneko/node-protobuf/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/fuwaneko/node-protobuf/statuses/03192c04d6e0b1a9e44a2a44ac9934a6dec924c5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fuwaneko","id":34433,"avatar_url":"https://avatars.githubusercontent.com/u/34433?v=3","gravatar_id":"","url":"https://api.github.com/users/fuwaneko","html_url":"https://github.com/fuwaneko","followers_url":"https://api.github.com/users/fuwaneko/followers","following_url":"https://api.github.com/users/fuwaneko/following{/other_user}","gists_url":"https://api.github.com/users/fuwaneko/gists{/gist_id}","starred_url":"https://api.github.com/users/fuwaneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuwaneko/subscriptions","organizations_url":"https://api.github.com/users/fuwaneko/orgs","repos_url":"https://api.github.com/users/fuwaneko/repos","events_url":"https://api.github.com/users/fuwaneko/events{/privacy}","received_events_url":"https://api.github.com/users/fuwaneko/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"fuwaneko"}}