{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/61121586","id":61121586,"diff_hunk":"@@ -0,0 +1,62 @@\n+\n+export class UrlOverflowService {\n+  constructor() {\n+    const key = 'error/url-overflow/url';\n+    const store = window.sessionStorage || {\n+      getItem() {},\n+      setItem() {},\n+      removeItem() {},\n+    };\n+\n+    // FIXME: Couldn't find a way to test for browser compatibility without\n+    // complex redirect and cookie based \"feature-detection\" page, so going\n+    // with user-agent detection for now.\n+    this._ieLike = /(;MSIE |Edge\\/\\d)/.test(window.navigator.userAgent);\n+\n+    this._val = store.getItem(key);\n+    this._sync = () => {\n+      if (this._val == null) store.removeItem(key);\n+      else store.setItem(key, this._val);\n+    };\n+  }\n+\n+  failLength() {\n+    return this._ieLike ? 2000 : 25000;","path":"src/ui/public/error_url_overflow/url_overflow_service.js","position":24,"original_position":24,"commit_id":"116521c6be68676ac2c808bfb065d209f3fa708c","original_commit_id":"116521c6be68676ac2c808bfb065d209f3fa708c","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"body":"Nope, I suppose it could be removed altogether.","created_at":"2016-04-26T16:49:07Z","updated_at":"2016-04-26T16:49:07Z","html_url":"https://github.com/elastic/kibana/pull/6773#discussion_r61121586","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/6773","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/61121586"},"html":{"href":"https://github.com/elastic/kibana/pull/6773#discussion_r61121586"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6773"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/6773","id":65222370,"html_url":"https://github.com/elastic/kibana/pull/6773","diff_url":"https://github.com/elastic/kibana/pull/6773.diff","patch_url":"https://github.com/elastic/kibana/pull/6773.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/6773","number":6773,"state":"open","locked":false,"title":"Implement/better warning for url length","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"body":"Fixes #6531 \r\nFixes #6790\r\n\r\nIn an attempt to detect the point that urls start failing, I was not able to find evidence of this occurring (something I could test for in an `if`). Instead this is simply two configuration limits at which we will start to warn users, `url:warnLength`, and then begin to fail aggressively, `url:limit`.","created_at":"2016-04-04T22:18:21Z","updated_at":"2016-04-26T16:49:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"056ec2145866b9400153eb85d138c32c103a3788","assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/6773/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/6773/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/6773/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/116521c6be68676ac2c808bfb065d209f3fa708c","head":{"label":"spalger:implement/betterWarningForUrlLength","ref":"implement/betterWarningForUrlLength","sha":"116521c6be68676ac2c808bfb065d209f3fa708c","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"repo":{"id":12307386,"name":"kibana","full_name":"spalger/kibana","owner":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spalger/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/spalger/kibana","forks_url":"https://api.github.com/repos/spalger/kibana/forks","keys_url":"https://api.github.com/repos/spalger/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spalger/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spalger/kibana/teams","hooks_url":"https://api.github.com/repos/spalger/kibana/hooks","issue_events_url":"https://api.github.com/repos/spalger/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/spalger/kibana/events","assignees_url":"https://api.github.com/repos/spalger/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/spalger/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/spalger/kibana/tags","blobs_url":"https://api.github.com/repos/spalger/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spalger/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spalger/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/spalger/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spalger/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/spalger/kibana/languages","stargazers_url":"https://api.github.com/repos/spalger/kibana/stargazers","contributors_url":"https://api.github.com/repos/spalger/kibana/contributors","subscribers_url":"https://api.github.com/repos/spalger/kibana/subscribers","subscription_url":"https://api.github.com/repos/spalger/kibana/subscription","commits_url":"https://api.github.com/repos/spalger/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/spalger/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/spalger/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/spalger/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/spalger/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/spalger/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spalger/kibana/merges","archive_url":"https://api.github.com/repos/spalger/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spalger/kibana/downloads","issues_url":"https://api.github.com/repos/spalger/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/spalger/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/spalger/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/spalger/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spalger/kibana/labels{/name}","releases_url":"https://api.github.com/repos/spalger/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/spalger/kibana/deployments","created_at":"2013-08-22T20:39:03Z","updated_at":"2015-05-08T18:10:59Z","pushed_at":"2016-04-22T20:42:41Z","git_url":"git://github.com/spalger/kibana.git","ssh_url":"git@github.com:spalger/kibana.git","clone_url":"https://github.com/spalger/kibana.git","svn_url":"https://github.com/spalger/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":132950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"176d271a207bbb12818681fd77ef7d2e9f96e3e8","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2016-04-26T13:17:47Z","pushed_at":"2016-04-26T16:43:04Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":153839,"stargazers_count":5200,"watchers_count":5200,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1957,"mirror_url":null,"open_issues_count":981,"forks":1957,"open_issues":981,"watchers":5200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6773"},"html":{"href":"https://github.com/elastic/kibana/pull/6773"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/6773"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/6773/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6773/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/6773/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/116521c6be68676ac2c808bfb065d209f3fa708c"}}}}