{"action":"opened","issue":{"url":"https://api.github.com/repos/inuitcss/inuitcss/issues/214","repository_url":"https://api.github.com/repos/inuitcss/inuitcss","labels_url":"https://api.github.com/repos/inuitcss/inuitcss/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/inuitcss/inuitcss/issues/214/comments","events_url":"https://api.github.com/repos/inuitcss/inuitcss/issues/214/events","html_url":"https://github.com/inuitcss/inuitcss/issues/214","id":184887167,"number":214,"title":"[settings.global] transition timing","user":{"login":"fuhlig","id":1364116,"avatar_url":"https://avatars.githubusercontent.com/u/1364116?v=3","gravatar_id":"","url":"https://api.github.com/users/fuhlig","html_url":"https://github.com/fuhlig","followers_url":"https://api.github.com/users/fuhlig/followers","following_url":"https://api.github.com/users/fuhlig/following{/other_user}","gists_url":"https://api.github.com/users/fuhlig/gists{/gist_id}","starred_url":"https://api.github.com/users/fuhlig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuhlig/subscriptions","organizations_url":"https://api.github.com/users/fuhlig/orgs","repos_url":"https://api.github.com/users/fuhlig/repos","events_url":"https://api.github.com/users/fuhlig/events{/privacy}","received_events_url":"https://api.github.com/users/fuhlig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-24T16:16:22Z","updated_at":"2016-10-24T16:16:22Z","closed_at":null,"body":"The transition-duration in `$global-transition` (despite being in example files) should not be written as a division as the output will be:\r\n`transition: 0.33333333s;` (depending on precision)\r\n\r\nSuggestion: 0.3s or 300ms\r\n\r\nThe transition should also include a property and timing-function otherwise it uses the default `all` and `linear`\r\n\r\n```\r\n// simple\r\n$global-transition: all 0.3s ease;\r\n\r\n// 'advanced'\r\n$global-transition-property: all;\r\n$global-transition-duration: 0.3s;\r\n$global-transition-timing-function: ease;\r\n\r\n$global-transition: $global-transition-property $global-transition-duration $global-transition-timing-function;\r\n\r\n.component {\r\n  transition: $global-transition;\r\n}\r\n```\r\n\r\n\r\nThis might be out of scope for the inuit framework but just setting a duration could be a potential promotion of *bad practice*  for transition.\r\nIt is open for discussion ofcourse and I'd be happy to open a Pull-Request when needed."}}
{"actor":{"display_login":"fuhlig"}}