{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/comments/54246284","id":54246284,"diff_hunk":"@@ -61,6 +61,10 @@ public static AuthorizationResponse fromString(final String s) throws Authorizat\n             for (final String pair : pairs) {\r\n                 final String[] nameAndValue = NAME_VALUE_SEPARATOR.split(pair, 2);\r\n                 try {\r\n+                    if (nameAndValue.length != 2) {\r","path":"oauth2-useragent-core/src/main/java/com/microsoft/alm/oauth2/useragent/AuthorizationResponse.java","position":4,"original_position":4,"commit_id":"b157dfaa893242da131ae6d194d1fb071c94566d","original_commit_id":"b157dfaa893242da131ae6d194d1fb071c94566d","user":{"login":"yacaovsnc","id":10119737,"avatar_url":"https://avatars.githubusercontent.com/u/10119737?v=3","gravatar_id":"","url":"https://api.github.com/users/yacaovsnc","html_url":"https://github.com/yacaovsnc","followers_url":"https://api.github.com/users/yacaovsnc/followers","following_url":"https://api.github.com/users/yacaovsnc/following{/other_user}","gists_url":"https://api.github.com/users/yacaovsnc/gists{/gist_id}","starred_url":"https://api.github.com/users/yacaovsnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yacaovsnc/subscriptions","organizations_url":"https://api.github.com/users/yacaovsnc/orgs","repos_url":"https://api.github.com/users/yacaovsnc/repos","events_url":"https://api.github.com/users/yacaovsnc/events{/privacy}","received_events_url":"https://api.github.com/users/yacaovsnc/received_events","type":"User","site_admin":false},"body":"Nope, this fix isn't for what's returned from server.  This is actually to make the test work.  The unit test 'cut' returns something and when we try to parse it, we get an ArrayIndexOutOfBoundsException, this is to guard for that exception.  \r\n\r\nI haven't seen a real life example that we would hit this yet.","created_at":"2016-02-26T14:08:25Z","updated_at":"2016-02-26T14:08:25Z","html_url":"https://github.com/Microsoft/oauth2-useragent/pull/11#discussion_r54246284","pull_request_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/comments/54246284"},"html":{"href":"https://github.com/Microsoft/oauth2-useragent/pull/11#discussion_r54246284"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11","id":60759399,"html_url":"https://github.com/Microsoft/oauth2-useragent/pull/11","diff_url":"https://github.com/Microsoft/oauth2-useragent/pull/11.diff","patch_url":"https://github.com/Microsoft/oauth2-useragent/pull/11.patch","issue_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/11","number":11,"state":"closed","locked":false,"title":"Ignore stderr when we call JavaFx provider first","user":{"login":"yacaovsnc","id":10119737,"avatar_url":"https://avatars.githubusercontent.com/u/10119737?v=3","gravatar_id":"","url":"https://api.github.com/users/yacaovsnc","html_url":"https://github.com/yacaovsnc","followers_url":"https://api.github.com/users/yacaovsnc/followers","following_url":"https://api.github.com/users/yacaovsnc/following{/other_user}","gists_url":"https://api.github.com/users/yacaovsnc/gists{/gist_id}","starred_url":"https://api.github.com/users/yacaovsnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yacaovsnc/subscriptions","organizations_url":"https://api.github.com/users/yacaovsnc/orgs","repos_url":"https://api.github.com/users/yacaovsnc/repos","events_url":"https://api.github.com/users/yacaovsnc/events{/privacy}","received_events_url":"https://api.github.com/users/yacaovsnc/received_events","type":"User","site_admin":false},"body":"The stderr maybe benign, but in its presence our process fails.\r\nWe should first try parse the stdout and if we could parse out a\r\ncorrect authorization code from the stdout, then treat the error\r\nmore seriously.  Otherwise even if there are stderr, but the code\r\nis retrieved, we should simply ignore it.","created_at":"2016-02-25T22:32:41Z","updated_at":"2016-02-26T14:08:25Z","closed_at":"2016-02-25T23:57:50Z","merged_at":"2016-02-25T23:57:50Z","merge_commit_sha":"16c651c803120eaaf5c6b551e6a728f60cc00404","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/11/comments","statuses_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/statuses/b157dfaa893242da131ae6d194d1fb071c94566d","head":{"label":"Microsoft:users/yacao/relaxstderr","ref":"users/yacao/relaxstderr","sha":"b157dfaa893242da131ae6d194d1fb071c94566d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":45931737,"name":"oauth2-useragent","full_name":"Microsoft/oauth2-useragent","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/oauth2-useragent","description":"Microsoft OAuth 2.0 User Agent library for Java. Provides classes to facilitate the implementation of \"4.1. Authorization Code Grant\" from RFC 6749.","fork":false,"url":"https://api.github.com/repos/Microsoft/oauth2-useragent","forks_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/forks","keys_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/teams","hooks_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/events","assignees_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/tags","blobs_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/languages","stargazers_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/subscription","commits_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/merges","archive_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/downloads","issues_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/deployments","created_at":"2015-11-10T18:25:59Z","updated_at":"2016-01-18T03:37:30Z","pushed_at":"2016-02-25T23:57:59Z","git_url":"git://github.com/Microsoft/oauth2-useragent.git","ssh_url":"git@github.com:Microsoft/oauth2-useragent.git","clone_url":"https://github.com/Microsoft/oauth2-useragent.git","svn_url":"https://github.com/Microsoft/oauth2-useragent","homepage":null,"size":164,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"ec319b4f1bade28b7be6fe7fa0aad89a692ad428","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":45931737,"name":"oauth2-useragent","full_name":"Microsoft/oauth2-useragent","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/oauth2-useragent","description":"Microsoft OAuth 2.0 User Agent library for Java. Provides classes to facilitate the implementation of \"4.1. Authorization Code Grant\" from RFC 6749.","fork":false,"url":"https://api.github.com/repos/Microsoft/oauth2-useragent","forks_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/forks","keys_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/teams","hooks_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/events","assignees_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/tags","blobs_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/languages","stargazers_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/subscription","commits_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/merges","archive_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/downloads","issues_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/oauth2-useragent/deployments","created_at":"2015-11-10T18:25:59Z","updated_at":"2016-01-18T03:37:30Z","pushed_at":"2016-02-25T23:57:59Z","git_url":"git://github.com/Microsoft/oauth2-useragent.git","ssh_url":"git@github.com:Microsoft/oauth2-useragent.git","clone_url":"https://github.com/Microsoft/oauth2-useragent.git","svn_url":"https://github.com/Microsoft/oauth2-useragent","homepage":null,"size":164,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11"},"html":{"href":"https://github.com/Microsoft/oauth2-useragent/pull/11"},"issue":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/11"},"comments":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/oauth2-useragent/statuses/b157dfaa893242da131ae6d194d1fb071c94566d"}}}}