{"action":"opened","number":819,"pull_request":{"url":"https://api.github.com/repos/assimp/assimp/pulls/819","id":62420246,"html_url":"https://github.com/assimp/assimp/pull/819","diff_url":"https://github.com/assimp/assimp/pull/819.diff","patch_url":"https://github.com/assimp/assimp/pull/819.patch","issue_url":"https://api.github.com/repos/assimp/assimp/issues/819","number":819,"state":"open","locked":false,"title":"PlyParser: fix invalid loading when comment is empty.","user":{"login":"emvivre","id":12485451,"avatar_url":"https://avatars.githubusercontent.com/u/12485451?v=3","gravatar_id":"","url":"https://api.github.com/users/emvivre","html_url":"https://github.com/emvivre","followers_url":"https://api.github.com/users/emvivre/followers","following_url":"https://api.github.com/users/emvivre/following{/other_user}","gists_url":"https://api.github.com/users/emvivre/gists{/gist_id}","starred_url":"https://api.github.com/users/emvivre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emvivre/subscriptions","organizations_url":"https://api.github.com/users/emvivre/orgs","repos_url":"https://api.github.com/users/emvivre/repos","events_url":"https://api.github.com/users/emvivre/events{/privacy}","received_events_url":"https://api.github.com/users/emvivre/received_events","type":"User","site_admin":false},"body":"When the \"comment\" field of a .ply is empty like \"comment\\n\", assimp field skip all the \"comment\\n\" (call of TokenMatch) with the next line too (call of SkipLine).\r\n\r\nBy Trying to convert the following .ply file, an error is returned\r\n$ assimp export cube.ply a.obj\r\nassimp export: select file format: 'obj' (Wavefront OBJ format)\r\nLaunching asset import ...           OK\r\nValidating postprocessing flags ...  OK\r\nERROR: Failed to load file: Invalid .ply file: No vertices found. Unable to parse the data format of the PLY file.\r\n\r\n\"\"\"\r\nply\r\nformat ascii 1.0\r\ncomment\r\nelement vertex 8\r\nproperty float x\r\nproperty float y\r\nproperty float z\r\nelement face 12\r\nproperty list uchar int vertex_indices\r\nend_header\r\n-1 -1 -1 \r\n-1 1 -1 \r\n0.999999 -1 1 \r\n-1 -1 1 \r\n-1 1 1 \r\n1 0.999999 1 \r\n1 1 -1 \r\n1 -1 -1 \r\n3 7 0 1 \r\n3 4 3 2 \r\n3 5 2 7 \r\n3 2 3 0 \r\n3 0 3 4 \r\n3 6 1 4 \r\n3 6 7 1 \r\n3 5 4 2 \r\n3 6 5 7 \r\n3 7 2 0 \r\n3 1 0 4 \r\n3 5 6 4 \r\n\"\"\"\r\n\r\n421         if (TokenMatch(pCur,''comment'',7))\r\n(gdb) p pCur\r\n$6 = 0x6361c5 ``comment\\nelement vertex 26\\nproperty float x\\nproperty float y\\nproperty float z\\nproperty float nx\\nproperty float ny\\nproperty float nz\\nelement face 12\\nproperty list uchar uint vertex_indices\\nend_header\\n1.''...\r\n(gdb) n\r\n423             SkipLine(pCur,&pCur);\r\n(gdb) p pCur\r\n$7 = 0x6361cd ``element vertex 26\\nproperty float x\\nproperty float y\\nproperty float z\\nproperty float nx\\nproperty float ny\\nproperty float nz\\nelement face 12\\nproperty list uchar uint vertex_indices\\nend_header\\n1.000000 -''...\r\n(gdb) n\r\n424             SkipComments(pCur,&pCur);\r\n(gdb) p pCur\r\n$8 = 0x6361df \"property float x\\nproperty float y\\nproperty float z\\nproperty float nx\\nproperty float ny\\nproperty float nz\\nelement face 12\\nproperty list uchar uint vertex_indices\\nend_header\\n1.000000 -1.000000 -1.000000\"...","created_at":"2016-03-10T16:52:30Z","updated_at":"2016-03-10T16:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/assimp/assimp/pulls/819/commits","review_comments_url":"https://api.github.com/repos/assimp/assimp/pulls/819/comments","review_comment_url":"https://api.github.com/repos/assimp/assimp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/assimp/assimp/issues/819/comments","statuses_url":"https://api.github.com/repos/assimp/assimp/statuses/93be0f69dacaeb0fe377290e8920feb93afd7666","head":{"label":"emvivre:master","ref":"master","sha":"93be0f69dacaeb0fe377290e8920feb93afd7666","user":{"login":"emvivre","id":12485451,"avatar_url":"https://avatars.githubusercontent.com/u/12485451?v=3","gravatar_id":"","url":"https://api.github.com/users/emvivre","html_url":"https://github.com/emvivre","followers_url":"https://api.github.com/users/emvivre/followers","following_url":"https://api.github.com/users/emvivre/following{/other_user}","gists_url":"https://api.github.com/users/emvivre/gists{/gist_id}","starred_url":"https://api.github.com/users/emvivre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emvivre/subscriptions","organizations_url":"https://api.github.com/users/emvivre/orgs","repos_url":"https://api.github.com/users/emvivre/repos","events_url":"https://api.github.com/users/emvivre/events{/privacy}","received_events_url":"https://api.github.com/users/emvivre/received_events","type":"User","site_admin":false},"repo":{"id":53597532,"name":"assimp","full_name":"emvivre/assimp","owner":{"login":"emvivre","id":12485451,"avatar_url":"https://avatars.githubusercontent.com/u/12485451?v=3","gravatar_id":"","url":"https://api.github.com/users/emvivre","html_url":"https://github.com/emvivre","followers_url":"https://api.github.com/users/emvivre/followers","following_url":"https://api.github.com/users/emvivre/following{/other_user}","gists_url":"https://api.github.com/users/emvivre/gists{/gist_id}","starred_url":"https://api.github.com/users/emvivre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emvivre/subscriptions","organizations_url":"https://api.github.com/users/emvivre/orgs","repos_url":"https://api.github.com/users/emvivre/repos","events_url":"https://api.github.com/users/emvivre/events{/privacy}","received_events_url":"https://api.github.com/users/emvivre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emvivre/assimp","description":"Official Open Asset Import Library Repository. Loads 40+ 3D file formats into one unified and clean data structure. ","fork":true,"url":"https://api.github.com/repos/emvivre/assimp","forks_url":"https://api.github.com/repos/emvivre/assimp/forks","keys_url":"https://api.github.com/repos/emvivre/assimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emvivre/assimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emvivre/assimp/teams","hooks_url":"https://api.github.com/repos/emvivre/assimp/hooks","issue_events_url":"https://api.github.com/repos/emvivre/assimp/issues/events{/number}","events_url":"https://api.github.com/repos/emvivre/assimp/events","assignees_url":"https://api.github.com/repos/emvivre/assimp/assignees{/user}","branches_url":"https://api.github.com/repos/emvivre/assimp/branches{/branch}","tags_url":"https://api.github.com/repos/emvivre/assimp/tags","blobs_url":"https://api.github.com/repos/emvivre/assimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emvivre/assimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emvivre/assimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/emvivre/assimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emvivre/assimp/statuses/{sha}","languages_url":"https://api.github.com/repos/emvivre/assimp/languages","stargazers_url":"https://api.github.com/repos/emvivre/assimp/stargazers","contributors_url":"https://api.github.com/repos/emvivre/assimp/contributors","subscribers_url":"https://api.github.com/repos/emvivre/assimp/subscribers","subscription_url":"https://api.github.com/repos/emvivre/assimp/subscription","commits_url":"https://api.github.com/repos/emvivre/assimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/emvivre/assimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/emvivre/assimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/emvivre/assimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/emvivre/assimp/contents/{+path}","compare_url":"https://api.github.com/repos/emvivre/assimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emvivre/assimp/merges","archive_url":"https://api.github.com/repos/emvivre/assimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emvivre/assimp/downloads","issues_url":"https://api.github.com/repos/emvivre/assimp/issues{/number}","pulls_url":"https://api.github.com/repos/emvivre/assimp/pulls{/number}","milestones_url":"https://api.github.com/repos/emvivre/assimp/milestones{/number}","notifications_url":"https://api.github.com/repos/emvivre/assimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emvivre/assimp/labels{/name}","releases_url":"https://api.github.com/repos/emvivre/assimp/releases{/id}","deployments_url":"https://api.github.com/repos/emvivre/assimp/deployments","created_at":"2016-03-10T15:58:01Z","updated_at":"2016-03-10T15:58:09Z","pushed_at":"2016-03-10T16:44:10Z","git_url":"git://github.com/emvivre/assimp.git","ssh_url":"git@github.com:emvivre/assimp.git","clone_url":"https://github.com/emvivre/assimp.git","svn_url":"https://github.com/emvivre/assimp","homepage":"http://www.assimp.org","size":82989,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"assimp:master","ref":"master","sha":"98ba2d23103546ad5770e706fb5993a183eaefa5","user":{"login":"assimp","id":265533,"avatar_url":"https://avatars.githubusercontent.com/u/265533?v=3","gravatar_id":"","url":"https://api.github.com/users/assimp","html_url":"https://github.com/assimp","followers_url":"https://api.github.com/users/assimp/followers","following_url":"https://api.github.com/users/assimp/following{/other_user}","gists_url":"https://api.github.com/users/assimp/gists{/gist_id}","starred_url":"https://api.github.com/users/assimp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assimp/subscriptions","organizations_url":"https://api.github.com/users/assimp/orgs","repos_url":"https://api.github.com/users/assimp/repos","events_url":"https://api.github.com/users/assimp/events{/privacy}","received_events_url":"https://api.github.com/users/assimp/received_events","type":"Organization","site_admin":false},"repo":{"id":648332,"name":"assimp","full_name":"assimp/assimp","owner":{"login":"assimp","id":265533,"avatar_url":"https://avatars.githubusercontent.com/u/265533?v=3","gravatar_id":"","url":"https://api.github.com/users/assimp","html_url":"https://github.com/assimp","followers_url":"https://api.github.com/users/assimp/followers","following_url":"https://api.github.com/users/assimp/following{/other_user}","gists_url":"https://api.github.com/users/assimp/gists{/gist_id}","starred_url":"https://api.github.com/users/assimp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assimp/subscriptions","organizations_url":"https://api.github.com/users/assimp/orgs","repos_url":"https://api.github.com/users/assimp/repos","events_url":"https://api.github.com/users/assimp/events{/privacy}","received_events_url":"https://api.github.com/users/assimp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assimp/assimp","description":"Official Open Asset Import Library Repository. Loads 40+ 3D file formats into one unified and clean data structure. ","fork":false,"url":"https://api.github.com/repos/assimp/assimp","forks_url":"https://api.github.com/repos/assimp/assimp/forks","keys_url":"https://api.github.com/repos/assimp/assimp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assimp/assimp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assimp/assimp/teams","hooks_url":"https://api.github.com/repos/assimp/assimp/hooks","issue_events_url":"https://api.github.com/repos/assimp/assimp/issues/events{/number}","events_url":"https://api.github.com/repos/assimp/assimp/events","assignees_url":"https://api.github.com/repos/assimp/assimp/assignees{/user}","branches_url":"https://api.github.com/repos/assimp/assimp/branches{/branch}","tags_url":"https://api.github.com/repos/assimp/assimp/tags","blobs_url":"https://api.github.com/repos/assimp/assimp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assimp/assimp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assimp/assimp/git/refs{/sha}","trees_url":"https://api.github.com/repos/assimp/assimp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assimp/assimp/statuses/{sha}","languages_url":"https://api.github.com/repos/assimp/assimp/languages","stargazers_url":"https://api.github.com/repos/assimp/assimp/stargazers","contributors_url":"https://api.github.com/repos/assimp/assimp/contributors","subscribers_url":"https://api.github.com/repos/assimp/assimp/subscribers","subscription_url":"https://api.github.com/repos/assimp/assimp/subscription","commits_url":"https://api.github.com/repos/assimp/assimp/commits{/sha}","git_commits_url":"https://api.github.com/repos/assimp/assimp/git/commits{/sha}","comments_url":"https://api.github.com/repos/assimp/assimp/comments{/number}","issue_comment_url":"https://api.github.com/repos/assimp/assimp/issues/comments{/number}","contents_url":"https://api.github.com/repos/assimp/assimp/contents/{+path}","compare_url":"https://api.github.com/repos/assimp/assimp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assimp/assimp/merges","archive_url":"https://api.github.com/repos/assimp/assimp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assimp/assimp/downloads","issues_url":"https://api.github.com/repos/assimp/assimp/issues{/number}","pulls_url":"https://api.github.com/repos/assimp/assimp/pulls{/number}","milestones_url":"https://api.github.com/repos/assimp/assimp/milestones{/number}","notifications_url":"https://api.github.com/repos/assimp/assimp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assimp/assimp/labels{/name}","releases_url":"https://api.github.com/repos/assimp/assimp/releases{/id}","deployments_url":"https://api.github.com/repos/assimp/assimp/deployments","created_at":"2010-05-05T12:53:45Z","updated_at":"2016-03-10T06:05:03Z","pushed_at":"2016-03-04T15:45:40Z","git_url":"git://github.com/assimp/assimp.git","ssh_url":"git@github.com:assimp/assimp.git","clone_url":"https://github.com/assimp/assimp.git","svn_url":"https://github.com/assimp/assimp","homepage":"http://www.assimp.org","size":103522,"stargazers_count":1188,"watchers_count":1188,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":464,"mirror_url":null,"open_issues_count":160,"forks":464,"open_issues":160,"watchers":1188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/assimp/assimp/pulls/819"},"html":{"href":"https://github.com/assimp/assimp/pull/819"},"issue":{"href":"https://api.github.com/repos/assimp/assimp/issues/819"},"comments":{"href":"https://api.github.com/repos/assimp/assimp/issues/819/comments"},"review_comments":{"href":"https://api.github.com/repos/assimp/assimp/pulls/819/comments"},"review_comment":{"href":"https://api.github.com/repos/assimp/assimp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/assimp/assimp/pulls/819/commits"},"statuses":{"href":"https://api.github.com/repos/assimp/assimp/statuses/93be0f69dacaeb0fe377290e8920feb93afd7666"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}