{"action":"created","comment":{"url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/comments/85627302","pull_request_review_id":6335772,"id":85627302,"diff_hunk":"@@ -24,12 +24,15 @@\n #include <mem/physmem.h>\n #include <global.h>\n #include <tty.h>\n+#include <cpu.h>\n #include \"pci.h\"\n \n-#include \"nic/intel/em/em.h\"\n-#include \"nic/intel/em/lem.h\"\n+#include <dev/nic/intel/em/em.h>\n+#include <dev/nic/intel/em/lem.h>\n+#include <dev/disk/ahci/ahci-raph.h>\n \n void PciCtrl::_Init() {\n+  _cpuid = cpu_ctrl->RetainCpuIdForPurpose(CpuPurpose::kLowPriority);\n   _mcfg = acpi_ctrl->GetMCFG();\n   if (_mcfg == nullptr) {\n     gtty->Cprintf(\"[Pci] error: could not find MCFG table.\\n\");","path":"source/kernel/dev/pci.cc","position":17,"original_position":17,"commit_id":"8a4542c29c74ed087cc3c4e2f0b243d73d73fc82","original_commit_id":"8a4542c29c74ed087cc3c4e2f0b243d73d73fc82","user":{"login":"levelfour","id":3879440,"avatar_url":"https://avatars.githubusercontent.com/u/3879440?v=3","gravatar_id":"","url":"https://api.github.com/users/levelfour","html_url":"https://github.com/levelfour","followers_url":"https://api.github.com/users/levelfour/followers","following_url":"https://api.github.com/users/levelfour/following{/other_user}","gists_url":"https://api.github.com/users/levelfour/gists{/gist_id}","starred_url":"https://api.github.com/users/levelfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levelfour/subscriptions","organizations_url":"https://api.github.com/users/levelfour/orgs","repos_url":"https://api.github.com/users/levelfour/repos","events_url":"https://api.github.com/users/levelfour/events{/privacy}","received_events_url":"https://api.github.com/users/levelfour/received_events","type":"User","site_admin":false},"body":"設計としてはステータスを戻り値で返してクラスの外部でエラーメッセージを出す、クラスの中には副作用をもたせない（完全には無理だけど）方がキレイかなと思うんだけど、そのへんの見解について少し議論しよう（このコメントは即時修正を促すものではありません）","created_at":"2016-10-28T23:58:02Z","updated_at":"2016-10-28T23:58:02Z","html_url":"https://github.com/Raphine/Raph_Kernel/pull/101#discussion_r85627302","pull_request_url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/comments/85627302"},"html":{"href":"https://github.com/Raphine/Raph_Kernel/pull/101#discussion_r85627302"},"pull_request":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101","id":90681651,"html_url":"https://github.com/Raphine/Raph_Kernel/pull/101","diff_url":"https://github.com/Raphine/Raph_Kernel/pull/101.diff","patch_url":"https://github.com/Raphine/Raph_Kernel/pull/101.patch","issue_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/101","number":101,"state":"open","locked":false,"title":"Fat","user":{"login":"liva","id":536883,"avatar_url":"https://avatars.githubusercontent.com/u/536883?v=3","gravatar_id":"","url":"https://api.github.com/users/liva","html_url":"https://github.com/liva","followers_url":"https://api.github.com/users/liva/followers","following_url":"https://api.github.com/users/liva/following{/other_user}","gists_url":"https://api.github.com/users/liva/gists{/gist_id}","starred_url":"https://api.github.com/users/liva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liva/subscriptions","organizations_url":"https://api.github.com/users/liva/orgs","repos_url":"https://api.github.com/users/liva/repos","events_url":"https://api.github.com/users/liva/events{/privacy}","received_events_url":"https://api.github.com/users/liva/received_events","type":"User","site_admin":false},"body":"implement AHCI driver and FAT driver and some bug fix","created_at":"2016-10-24T20:00:10Z","updated_at":"2016-10-28T23:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09b984c90a2c24a42d46ff077f89bd6d50d8d30b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101/commits","review_comments_url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101/comments","review_comment_url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/101/comments","statuses_url":"https://api.github.com/repos/Raphine/Raph_Kernel/statuses/8a4542c29c74ed087cc3c4e2f0b243d73d73fc82","head":{"label":"Raphine:fat","ref":"fat","sha":"8a4542c29c74ed087cc3c4e2f0b243d73d73fc82","user":{"login":"Raphine","id":18119103,"avatar_url":"https://avatars.githubusercontent.com/u/18119103?v=3","gravatar_id":"","url":"https://api.github.com/users/Raphine","html_url":"https://github.com/Raphine","followers_url":"https://api.github.com/users/Raphine/followers","following_url":"https://api.github.com/users/Raphine/following{/other_user}","gists_url":"https://api.github.com/users/Raphine/gists{/gist_id}","starred_url":"https://api.github.com/users/Raphine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raphine/subscriptions","organizations_url":"https://api.github.com/users/Raphine/orgs","repos_url":"https://api.github.com/users/Raphine/repos","events_url":"https://api.github.com/users/Raphine/events{/privacy}","received_events_url":"https://api.github.com/users/Raphine/received_events","type":"Organization","site_admin":false},"repo":{"id":55387285,"name":"Raph_Kernel","full_name":"Raphine/Raph_Kernel","owner":{"login":"Raphine","id":18119103,"avatar_url":"https://avatars.githubusercontent.com/u/18119103?v=3","gravatar_id":"","url":"https://api.github.com/users/Raphine","html_url":"https://github.com/Raphine","followers_url":"https://api.github.com/users/Raphine/followers","following_url":"https://api.github.com/users/Raphine/following{/other_user}","gists_url":"https://api.github.com/users/Raphine/gists{/gist_id}","starred_url":"https://api.github.com/users/Raphine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raphine/subscriptions","organizations_url":"https://api.github.com/users/Raphine/orgs","repos_url":"https://api.github.com/users/Raphine/repos","events_url":"https://api.github.com/users/Raphine/events{/privacy}","received_events_url":"https://api.github.com/users/Raphine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Raphine/Raph_Kernel","description":"for more information, watch our website (Japanese)","fork":false,"url":"https://api.github.com/repos/Raphine/Raph_Kernel","forks_url":"https://api.github.com/repos/Raphine/Raph_Kernel/forks","keys_url":"https://api.github.com/repos/Raphine/Raph_Kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Raphine/Raph_Kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Raphine/Raph_Kernel/teams","hooks_url":"https://api.github.com/repos/Raphine/Raph_Kernel/hooks","issue_events_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/events{/number}","events_url":"https://api.github.com/repos/Raphine/Raph_Kernel/events","assignees_url":"https://api.github.com/repos/Raphine/Raph_Kernel/assignees{/user}","branches_url":"https://api.github.com/repos/Raphine/Raph_Kernel/branches{/branch}","tags_url":"https://api.github.com/repos/Raphine/Raph_Kernel/tags","blobs_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Raphine/Raph_Kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/Raphine/Raph_Kernel/languages","stargazers_url":"https://api.github.com/repos/Raphine/Raph_Kernel/stargazers","contributors_url":"https://api.github.com/repos/Raphine/Raph_Kernel/contributors","subscribers_url":"https://api.github.com/repos/Raphine/Raph_Kernel/subscribers","subscription_url":"https://api.github.com/repos/Raphine/Raph_Kernel/subscription","commits_url":"https://api.github.com/repos/Raphine/Raph_Kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Raphine/Raph_Kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Raphine/Raph_Kernel/contents/{+path}","compare_url":"https://api.github.com/repos/Raphine/Raph_Kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Raphine/Raph_Kernel/merges","archive_url":"https://api.github.com/repos/Raphine/Raph_Kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Raphine/Raph_Kernel/downloads","issues_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues{/number}","pulls_url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/Raphine/Raph_Kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/Raphine/Raph_Kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Raphine/Raph_Kernel/labels{/name}","releases_url":"https://api.github.com/repos/Raphine/Raph_Kernel/releases{/id}","deployments_url":"https://api.github.com/repos/Raphine/Raph_Kernel/deployments","created_at":"2016-04-04T05:30:56Z","updated_at":"2016-09-20T18:32:48Z","pushed_at":"2016-10-27T09:13:51Z","git_url":"git://github.com/Raphine/Raph_Kernel.git","ssh_url":"git@github.com:Raphine/Raph_Kernel.git","clone_url":"https://github.com/Raphine/Raph_Kernel.git","svn_url":"https://github.com/Raphine/Raph_Kernel","homepage":"https://raphine.wordpress.com/","size":10078,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":8,"default_branch":"master"}},"base":{"label":"Raphine:develop","ref":"develop","sha":"bc652e5c965a43f01a84e5a3a76285a3a79082d8","user":{"login":"Raphine","id":18119103,"avatar_url":"https://avatars.githubusercontent.com/u/18119103?v=3","gravatar_id":"","url":"https://api.github.com/users/Raphine","html_url":"https://github.com/Raphine","followers_url":"https://api.github.com/users/Raphine/followers","following_url":"https://api.github.com/users/Raphine/following{/other_user}","gists_url":"https://api.github.com/users/Raphine/gists{/gist_id}","starred_url":"https://api.github.com/users/Raphine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raphine/subscriptions","organizations_url":"https://api.github.com/users/Raphine/orgs","repos_url":"https://api.github.com/users/Raphine/repos","events_url":"https://api.github.com/users/Raphine/events{/privacy}","received_events_url":"https://api.github.com/users/Raphine/received_events","type":"Organization","site_admin":false},"repo":{"id":55387285,"name":"Raph_Kernel","full_name":"Raphine/Raph_Kernel","owner":{"login":"Raphine","id":18119103,"avatar_url":"https://avatars.githubusercontent.com/u/18119103?v=3","gravatar_id":"","url":"https://api.github.com/users/Raphine","html_url":"https://github.com/Raphine","followers_url":"https://api.github.com/users/Raphine/followers","following_url":"https://api.github.com/users/Raphine/following{/other_user}","gists_url":"https://api.github.com/users/Raphine/gists{/gist_id}","starred_url":"https://api.github.com/users/Raphine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raphine/subscriptions","organizations_url":"https://api.github.com/users/Raphine/orgs","repos_url":"https://api.github.com/users/Raphine/repos","events_url":"https://api.github.com/users/Raphine/events{/privacy}","received_events_url":"https://api.github.com/users/Raphine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Raphine/Raph_Kernel","description":"for more information, watch our website (Japanese)","fork":false,"url":"https://api.github.com/repos/Raphine/Raph_Kernel","forks_url":"https://api.github.com/repos/Raphine/Raph_Kernel/forks","keys_url":"https://api.github.com/repos/Raphine/Raph_Kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Raphine/Raph_Kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Raphine/Raph_Kernel/teams","hooks_url":"https://api.github.com/repos/Raphine/Raph_Kernel/hooks","issue_events_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/events{/number}","events_url":"https://api.github.com/repos/Raphine/Raph_Kernel/events","assignees_url":"https://api.github.com/repos/Raphine/Raph_Kernel/assignees{/user}","branches_url":"https://api.github.com/repos/Raphine/Raph_Kernel/branches{/branch}","tags_url":"https://api.github.com/repos/Raphine/Raph_Kernel/tags","blobs_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Raphine/Raph_Kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/Raphine/Raph_Kernel/languages","stargazers_url":"https://api.github.com/repos/Raphine/Raph_Kernel/stargazers","contributors_url":"https://api.github.com/repos/Raphine/Raph_Kernel/contributors","subscribers_url":"https://api.github.com/repos/Raphine/Raph_Kernel/subscribers","subscription_url":"https://api.github.com/repos/Raphine/Raph_Kernel/subscription","commits_url":"https://api.github.com/repos/Raphine/Raph_Kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Raphine/Raph_Kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Raphine/Raph_Kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Raphine/Raph_Kernel/contents/{+path}","compare_url":"https://api.github.com/repos/Raphine/Raph_Kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Raphine/Raph_Kernel/merges","archive_url":"https://api.github.com/repos/Raphine/Raph_Kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Raphine/Raph_Kernel/downloads","issues_url":"https://api.github.com/repos/Raphine/Raph_Kernel/issues{/number}","pulls_url":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/Raphine/Raph_Kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/Raphine/Raph_Kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Raphine/Raph_Kernel/labels{/name}","releases_url":"https://api.github.com/repos/Raphine/Raph_Kernel/releases{/id}","deployments_url":"https://api.github.com/repos/Raphine/Raph_Kernel/deployments","created_at":"2016-04-04T05:30:56Z","updated_at":"2016-09-20T18:32:48Z","pushed_at":"2016-10-27T09:13:51Z","git_url":"git://github.com/Raphine/Raph_Kernel.git","ssh_url":"git@github.com:Raphine/Raph_Kernel.git","clone_url":"https://github.com/Raphine/Raph_Kernel.git","svn_url":"https://github.com/Raphine/Raph_Kernel","homepage":"https://raphine.wordpress.com/","size":10078,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101"},"html":{"href":"https://github.com/Raphine/Raph_Kernel/pull/101"},"issue":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/101"},"comments":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/Raphine/Raph_Kernel/statuses/8a4542c29c74ed087cc3c4e2f0b243d73d73fc82"}}}}
{"actor":{"display_login":"levelfour"}}