{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/28271","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/28271/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/28271/comments","events_url":"https://api.github.com/repos/docker/docker/issues/28271/events","html_url":"https://github.com/docker/docker/pull/28271","id":188650232,"number":28271,"title":"replace vim-common with vim for opensuse","user":{"login":"andrewhsu","id":57640,"avatar_url":"https://avatars.githubusercontent.com/u/57640?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewhsu","html_url":"https://github.com/andrewhsu","followers_url":"https://api.github.com/users/andrewhsu/followers","following_url":"https://api.github.com/users/andrewhsu/following{/other_user}","gists_url":"https://api.github.com/users/andrewhsu/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhsu/subscriptions","organizations_url":"https://api.github.com/users/andrewhsu/orgs","repos_url":"https://api.github.com/users/andrewhsu/repos","events_url":"https://api.github.com/users/andrewhsu/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhsu/received_events","type":"User","site_admin":false},"labels":[{"id":234913403,"url":"https://api.github.com/repos/docker/docker/labels/dco/no","name":"dco/no","color":"f7c6c7","default":false},{"id":175374554,"url":"https://api.github.com/repos/docker/docker/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-10T23:49:23Z","updated_at":"2016-11-10T23:49:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28271","html_url":"https://github.com/docker/docker/pull/28271","diff_url":"https://github.com/docker/docker/pull/28271.diff","patch_url":"https://github.com/docker/docker/pull/28271.patch"},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\nReplace `vim-common` install on opensuse builds with `vim` because there is no `vim-common` package in opensuse. Resolves #28270.\r\n\r\n**- How I did it**\r\n\r\nQuietly and carefully.\r\n\r\n**- How to verify it**\r\n\r\n```\r\n$ docker build -t makeamericagreat contrib/builder/rpm/amd64/opensuse-13.2\r\n...\r\n(63/69) Installing: vim-7.4.461.hg.6253-1.5 [............done]\r\n(64/69) Installing: libtool-2.4.2-15.2.2 [............done]\r\n(65/69) Installing: git-core-2.1.4-19.1 [............done]\r\n(66/69) Installing: policycoreutils-2.3-2.5.1 [...........done]\r\n(67/69) Installing: git-2.1.4-19.1 [....done]  \r\n(68/69) Installing: selinux-policy-20140730-21.1 [.....done]\r\nAdditional rpm output:\r\nUpdating /etc/sysconfig/selinux-policy...\r\n\r\n\r\n(69/69) Installing: selinux-policy-devel-20140730-21.1 [............done]\r\nOutput of btrfsprogs-4.5.3-13.1.x86_64.rpm %posttrans script:\r\n    Please run mkinitrd as soon as your system is complete.\r\n\r\n ---> 07ef5f66f350\r\nRemoving intermediate container 3bcc70df22b7\r\nStep 4 : ENV GO_VERSION 1.7.3\r\n ---> Running in bc2ff3cddaa7\r\n ---> 888325c576e4\r\nRemoving intermediate container bc2ff3cddaa7\r\nStep 5 : RUN curl -fSL \"https://golang.org/dl/go${GO_VERSION}.linux-amd64.tar.gz\" | tar xzC /usr/local\r\n ---> Running in 24c1363948c8\r\n  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\r\n                                 Dload  Upload   Total   Spent    Left  Speed\r\n100    87  100    87    0     0     15      0  0:00:05  0:00:05 --:--:--    28\r\n100 78.7M  100 78.7M    0     0  5485k      0  0:00:14  0:00:14 --:--:-- 22.4M\r\n ---> ceeb2066aacb\r\nRemoving intermediate container 24c1363948c8\r\nStep 6 : ENV PATH $PATH:/usr/local/go/bin\r\n ---> Running in ee4f90346fb7\r\n ---> 12b429d30cc6\r\nRemoving intermediate container ee4f90346fb7\r\nStep 7 : ENV AUTO_GOPATH 1\r\n ---> Running in 4167f6149a95\r\n ---> f6e5fbbd518a\r\nRemoving intermediate container 4167f6149a95\r\nStep 8 : ENV DOCKER_BUILDTAGS pkcs11 selinux\r\n ---> Running in 20b2f45c289e\r\n ---> 6e7da1101dd3\r\nRemoving intermediate container 20b2f45c289e\r\nStep 9 : ENV RUNC_BUILDTAGS selinux\r\n ---> Running in 8958758b3ca4\r\n ---> eebab8238ca8\r\nRemoving intermediate container 8958758b3ca4\r\nSuccessfully built eebab8238ca8\r\n\r\nreal    2m21.661s\r\nuser    0m0.069s\r\nsys     0m0.051s\r\n```\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\nN/A\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n🐥 \r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/259842274","html_url":"https://github.com/docker/docker/pull/28271#issuecomment-259842274","issue_url":"https://api.github.com/repos/docker/docker/issues/28271","id":259842274,"user":{"login":"GordonTheTurtle","id":10620046,"avatar_url":"https://avatars.githubusercontent.com/u/10620046?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonTheTurtle","html_url":"https://github.com/GordonTheTurtle","followers_url":"https://api.github.com/users/GordonTheTurtle/followers","following_url":"https://api.github.com/users/GordonTheTurtle/following{/other_user}","gists_url":"https://api.github.com/users/GordonTheTurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonTheTurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonTheTurtle/subscriptions","organizations_url":"https://api.github.com/users/GordonTheTurtle/orgs","repos_url":"https://api.github.com/users/GordonTheTurtle/repos","events_url":"https://api.github.com/users/GordonTheTurtle/events{/privacy}","received_events_url":"https://api.github.com/users/GordonTheTurtle/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T23:49:24Z","updated_at":"2016-11-10T23:49:24Z","body":"<!-- AUTOMATED:POULE:DCO-EXPLANATION -->\nPlease sign your commits following these rules:\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work\nThe easiest way to do this is to amend the last commit:\n~~~console\n$ git clone -b \"fix-opensuse\" git@github.com:andrewhsu/docker.git somewhere\n$ cd somewhere\n$ git commit --amend -s --no-edit\n$ git push -f\n~~~\n\nAmending updates the existing PR. You **DO NOT** need to open a new one.\n"}}
{"actor":{"display_login":"GordonTheTurtle"}}