{"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-framework/pulls/comments/91281524","pull_request_review_id":11789157,"id":91281524,"diff_hunk":"@@ -735,6 +735,9 @@ protected virtual void ApplyDrawNode(DrawNode node)\n         /// <returns>False if the drawable should not be updated.</returns>\r\n         protected internal virtual bool UpdateSubTree()\r\n         {\r\n+            if (Parent != null) //we don't want to update our clock if we are at the top of the stack. it's handled elsewhere for us.\r","path":"osu.Framework/Graphics/Drawable.cs","position":13,"original_position":13,"commit_id":"797576111a7ba4c469cd1a7d74708014264155ec","original_commit_id":"797576111a7ba4c469cd1a7d74708014264155ec","user":{"login":"Tom94","id":4923655,"avatar_url":"https://avatars.githubusercontent.com/u/4923655?v=3","gravatar_id":"","url":"https://api.github.com/users/Tom94","html_url":"https://github.com/Tom94","followers_url":"https://api.github.com/users/Tom94/followers","following_url":"https://api.github.com/users/Tom94/following{/other_user}","gists_url":"https://api.github.com/users/Tom94/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom94/subscriptions","organizations_url":"https://api.github.com/users/Tom94/orgs","repos_url":"https://api.github.com/users/Tom94/repos","events_url":"https://api.github.com/users/Tom94/events{/privacy}","received_events_url":"https://api.github.com/users/Tom94/received_events","type":"User","site_admin":false},"body":"Does it _have_ to be handled elsewhere? Ideally we would avoid special cases like that.","created_at":"2016-12-07T12:19:48Z","updated_at":"2016-12-07T12:19:48Z","html_url":"https://github.com/ppy/osu-framework/pull/383#discussion_r91281524","pull_request_url":"https://api.github.com/repos/ppy/osu-framework/pulls/383","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/comments/91281524"},"html":{"href":"https://github.com/ppy/osu-framework/pull/383#discussion_r91281524"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/383"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-framework/pulls/383","id":96908278,"html_url":"https://github.com/ppy/osu-framework/pull/383","diff_url":"https://github.com/ppy/osu-framework/pull/383.diff","patch_url":"https://github.com/ppy/osu-framework/pull/383.patch","issue_url":"https://api.github.com/repos/ppy/osu-framework/issues/383","number":383,"state":"open","locked":false,"title":"Make drawables update their own clocks when a custom clock is set.","user":{"login":"peppy","id":191335,"avatar_url":"https://avatars.githubusercontent.com/u/191335?v=3","gravatar_id":"","url":"https://api.github.com/users/peppy","html_url":"https://github.com/peppy","followers_url":"https://api.github.com/users/peppy/followers","following_url":"https://api.github.com/users/peppy/following{/other_user}","gists_url":"https://api.github.com/users/peppy/gists{/gist_id}","starred_url":"https://api.github.com/users/peppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppy/subscriptions","organizations_url":"https://api.github.com/users/peppy/orgs","repos_url":"https://api.github.com/users/peppy/repos","events_url":"https://api.github.com/users/peppy/events{/privacy}","received_events_url":"https://api.github.com/users/peppy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-07T11:46:43Z","updated_at":"2016-12-07T12:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95278dad6a0fcfd20fdf7081debf1e3d1adbd8c7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-framework/pulls/383/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-framework/pulls/383/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-framework/issues/383/comments","statuses_url":"https://api.github.com/repos/ppy/osu-framework/statuses/797576111a7ba4c469cd1a7d74708014264155ec","head":{"label":"peppy:general-fixes","ref":"general-fixes","sha":"797576111a7ba4c469cd1a7d74708014264155ec","user":{"login":"peppy","id":191335,"avatar_url":"https://avatars.githubusercontent.com/u/191335?v=3","gravatar_id":"","url":"https://api.github.com/users/peppy","html_url":"https://github.com/peppy","followers_url":"https://api.github.com/users/peppy/followers","following_url":"https://api.github.com/users/peppy/following{/other_user}","gists_url":"https://api.github.com/users/peppy/gists{/gist_id}","starred_url":"https://api.github.com/users/peppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppy/subscriptions","organizations_url":"https://api.github.com/users/peppy/orgs","repos_url":"https://api.github.com/users/peppy/repos","events_url":"https://api.github.com/users/peppy/events{/privacy}","received_events_url":"https://api.github.com/users/peppy/received_events","type":"User","site_admin":false},"repo":{"id":66810604,"name":"osu-framework","full_name":"peppy/osu-framework","owner":{"login":"peppy","id":191335,"avatar_url":"https://avatars.githubusercontent.com/u/191335?v=3","gravatar_id":"","url":"https://api.github.com/users/peppy","html_url":"https://github.com/peppy","followers_url":"https://api.github.com/users/peppy/followers","following_url":"https://api.github.com/users/peppy/following{/other_user}","gists_url":"https://api.github.com/users/peppy/gists{/gist_id}","starred_url":"https://api.github.com/users/peppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppy/subscriptions","organizations_url":"https://api.github.com/users/peppy/orgs","repos_url":"https://api.github.com/users/peppy/repos","events_url":"https://api.github.com/users/peppy/events{/privacy}","received_events_url":"https://api.github.com/users/peppy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peppy/osu-framework","description":"A game framework written with osu! in mind.","fork":true,"url":"https://api.github.com/repos/peppy/osu-framework","forks_url":"https://api.github.com/repos/peppy/osu-framework/forks","keys_url":"https://api.github.com/repos/peppy/osu-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peppy/osu-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peppy/osu-framework/teams","hooks_url":"https://api.github.com/repos/peppy/osu-framework/hooks","issue_events_url":"https://api.github.com/repos/peppy/osu-framework/issues/events{/number}","events_url":"https://api.github.com/repos/peppy/osu-framework/events","assignees_url":"https://api.github.com/repos/peppy/osu-framework/assignees{/user}","branches_url":"https://api.github.com/repos/peppy/osu-framework/branches{/branch}","tags_url":"https://api.github.com/repos/peppy/osu-framework/tags","blobs_url":"https://api.github.com/repos/peppy/osu-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peppy/osu-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peppy/osu-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/peppy/osu-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peppy/osu-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/peppy/osu-framework/languages","stargazers_url":"https://api.github.com/repos/peppy/osu-framework/stargazers","contributors_url":"https://api.github.com/repos/peppy/osu-framework/contributors","subscribers_url":"https://api.github.com/repos/peppy/osu-framework/subscribers","subscription_url":"https://api.github.com/repos/peppy/osu-framework/subscription","commits_url":"https://api.github.com/repos/peppy/osu-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/peppy/osu-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/peppy/osu-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/peppy/osu-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/peppy/osu-framework/contents/{+path}","compare_url":"https://api.github.com/repos/peppy/osu-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peppy/osu-framework/merges","archive_url":"https://api.github.com/repos/peppy/osu-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peppy/osu-framework/downloads","issues_url":"https://api.github.com/repos/peppy/osu-framework/issues{/number}","pulls_url":"https://api.github.com/repos/peppy/osu-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/peppy/osu-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/peppy/osu-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peppy/osu-framework/labels{/name}","releases_url":"https://api.github.com/repos/peppy/osu-framework/releases{/id}","deployments_url":"https://api.github.com/repos/peppy/osu-framework/deployments","created_at":"2016-08-29T04:12:29Z","updated_at":"2016-09-28T09:16:06Z","pushed_at":"2016-12-07T11:46:25Z","git_url":"git://github.com/peppy/osu-framework.git","ssh_url":"git@github.com:peppy/osu-framework.git","clone_url":"https://github.com/peppy/osu-framework.git","svn_url":"https://github.com/peppy/osu-framework","homepage":"","size":14747,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"8dbc789266c1bc3e46e364be824d69bcfac74e83","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":66614524,"name":"osu-framework","full_name":"ppy/osu-framework","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu-framework","description":"A game framework written with osu! in mind.","fork":false,"url":"https://api.github.com/repos/ppy/osu-framework","forks_url":"https://api.github.com/repos/ppy/osu-framework/forks","keys_url":"https://api.github.com/repos/ppy/osu-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-framework/teams","hooks_url":"https://api.github.com/repos/ppy/osu-framework/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-framework/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-framework/events","assignees_url":"https://api.github.com/repos/ppy/osu-framework/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-framework/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-framework/tags","blobs_url":"https://api.github.com/repos/ppy/osu-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-framework/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-framework/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-framework/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-framework/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-framework/subscription","commits_url":"https://api.github.com/repos/ppy/osu-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-framework/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-framework/merges","archive_url":"https://api.github.com/repos/ppy/osu-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-framework/downloads","issues_url":"https://api.github.com/repos/ppy/osu-framework/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-framework/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-framework/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-framework/deployments","created_at":"2016-08-26T03:45:35Z","updated_at":"2016-12-04T20:59:47Z","pushed_at":"2016-12-07T11:46:43Z","git_url":"git://github.com/ppy/osu-framework.git","ssh_url":"git@github.com:ppy/osu-framework.git","clone_url":"https://github.com/ppy/osu-framework.git","svn_url":"https://github.com/ppy/osu-framework","homepage":"","size":14941,"stargazers_count":104,"watchers_count":104,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":33,"forks":53,"open_issues":33,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/383"},"html":{"href":"https://github.com/ppy/osu-framework/pull/383"},"issue":{"href":"https://api.github.com/repos/ppy/osu-framework/issues/383"},"comments":{"href":"https://api.github.com/repos/ppy/osu-framework/issues/383/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/383/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/383/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-framework/statuses/797576111a7ba4c469cd1a7d74708014264155ec"}}}}
{"actor":{"display_login":"Tom94"}}