{"action":"opened","number":635,"pull_request":{"url":"https://api.github.com/repos/draios/sysdig/pulls/635","id":78350725,"html_url":"https://github.com/draios/sysdig/pull/635","diff_url":"https://github.com/draios/sysdig/pull/635.diff","patch_url":"https://github.com/draios/sysdig/pull/635.patch","issue_url":"https://api.github.com/repos/draios/sysdig/issues/635","number":635,"state":"open","locked":false,"title":"Flag bind events with EF_MODIFIES_STATE.","user":{"login":"mstemm","id":13422831,"avatar_url":"https://avatars.githubusercontent.com/u/13422831?v=3","gravatar_id":"","url":"https://api.github.com/users/mstemm","html_url":"https://github.com/mstemm","followers_url":"https://api.github.com/users/mstemm/followers","following_url":"https://api.github.com/users/mstemm/following{/other_user}","gists_url":"https://api.github.com/users/mstemm/gists{/gist_id}","starred_url":"https://api.github.com/users/mstemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstemm/subscriptions","organizations_url":"https://api.github.com/users/mstemm/orgs","repos_url":"https://api.github.com/users/mstemm/repos","events_url":"https://api.github.com/users/mstemm/events{/privacy}","received_events_url":"https://api.github.com/users/mstemm/received_events","type":"User","site_admin":false},"body":"Flag bind enter and exit events with EF_MODIFIES_STATE.\r\n\r\nbind exit events need the flag because they can change the type of\r\nm_fdinfo from SCAP_FD_IPV{4,6}_SOCK to _SERVSOCK based on the port\r\nnumber.\r\n\r\nbind enter events need the flag because if filters run and don't match\r\non the enter event, it clears the thread's m_lastevent_type, which\r\nprevents the exit event from getting a handle to the m_fdinfo.\r\n\r\nThis fixes #634.\r\n\r\n@ldegio @luca3m @gianlucaborello any objections to doing this? As an alternative, I could dive more into how m_lastevent_type is managed, but it's not something I'm that familiar with and this seems like the simplest fix.","created_at":"2016-07-21T16:54:11Z","updated_at":"2016-07-21T16:54:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49d560e07da0ad919301faf1dd55e40b141dabc4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/draios/sysdig/pulls/635/commits","review_comments_url":"https://api.github.com/repos/draios/sysdig/pulls/635/comments","review_comment_url":"https://api.github.com/repos/draios/sysdig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/draios/sysdig/issues/635/comments","statuses_url":"https://api.github.com/repos/draios/sysdig/statuses/a634367ff647dc30e91f33d3dc770e53da9e87b7","head":{"label":"draios:flag-bind-events","ref":"flag-bind-events","sha":"a634367ff647dc30e91f33d3dc770e53da9e87b7","user":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"repo":{"id":15926180,"name":"sysdig","full_name":"draios/sysdig","owner":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/draios/sysdig","description":"Linux system exploration and troubleshooting tool with first class support for containers","fork":false,"url":"https://api.github.com/repos/draios/sysdig","forks_url":"https://api.github.com/repos/draios/sysdig/forks","keys_url":"https://api.github.com/repos/draios/sysdig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/draios/sysdig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/draios/sysdig/teams","hooks_url":"https://api.github.com/repos/draios/sysdig/hooks","issue_events_url":"https://api.github.com/repos/draios/sysdig/issues/events{/number}","events_url":"https://api.github.com/repos/draios/sysdig/events","assignees_url":"https://api.github.com/repos/draios/sysdig/assignees{/user}","branches_url":"https://api.github.com/repos/draios/sysdig/branches{/branch}","tags_url":"https://api.github.com/repos/draios/sysdig/tags","blobs_url":"https://api.github.com/repos/draios/sysdig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/draios/sysdig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/draios/sysdig/git/refs{/sha}","trees_url":"https://api.github.com/repos/draios/sysdig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/draios/sysdig/statuses/{sha}","languages_url":"https://api.github.com/repos/draios/sysdig/languages","stargazers_url":"https://api.github.com/repos/draios/sysdig/stargazers","contributors_url":"https://api.github.com/repos/draios/sysdig/contributors","subscribers_url":"https://api.github.com/repos/draios/sysdig/subscribers","subscription_url":"https://api.github.com/repos/draios/sysdig/subscription","commits_url":"https://api.github.com/repos/draios/sysdig/commits{/sha}","git_commits_url":"https://api.github.com/repos/draios/sysdig/git/commits{/sha}","comments_url":"https://api.github.com/repos/draios/sysdig/comments{/number}","issue_comment_url":"https://api.github.com/repos/draios/sysdig/issues/comments{/number}","contents_url":"https://api.github.com/repos/draios/sysdig/contents/{+path}","compare_url":"https://api.github.com/repos/draios/sysdig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/draios/sysdig/merges","archive_url":"https://api.github.com/repos/draios/sysdig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/draios/sysdig/downloads","issues_url":"https://api.github.com/repos/draios/sysdig/issues{/number}","pulls_url":"https://api.github.com/repos/draios/sysdig/pulls{/number}","milestones_url":"https://api.github.com/repos/draios/sysdig/milestones{/number}","notifications_url":"https://api.github.com/repos/draios/sysdig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/draios/sysdig/labels{/name}","releases_url":"https://api.github.com/repos/draios/sysdig/releases{/id}","deployments_url":"https://api.github.com/repos/draios/sysdig/deployments","created_at":"2014-01-15T05:45:17Z","updated_at":"2016-07-21T14:08:20Z","pushed_at":"2016-07-21T16:54:11Z","git_url":"git://github.com/draios/sysdig.git","ssh_url":"git@github.com:draios/sysdig.git","clone_url":"https://github.com/draios/sysdig.git","svn_url":"https://github.com/draios/sysdig","homepage":"http://www.sysdig.org/","size":14328,"stargazers_count":3783,"watchers_count":3783,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":105,"forks":347,"open_issues":105,"watchers":3783,"default_branch":"dev"}},"base":{"label":"draios:dev","ref":"dev","sha":"821d4a5381259cfee4c564087ab6386229cefefb","user":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"repo":{"id":15926180,"name":"sysdig","full_name":"draios/sysdig","owner":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/draios/sysdig","description":"Linux system exploration and troubleshooting tool with first class support for containers","fork":false,"url":"https://api.github.com/repos/draios/sysdig","forks_url":"https://api.github.com/repos/draios/sysdig/forks","keys_url":"https://api.github.com/repos/draios/sysdig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/draios/sysdig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/draios/sysdig/teams","hooks_url":"https://api.github.com/repos/draios/sysdig/hooks","issue_events_url":"https://api.github.com/repos/draios/sysdig/issues/events{/number}","events_url":"https://api.github.com/repos/draios/sysdig/events","assignees_url":"https://api.github.com/repos/draios/sysdig/assignees{/user}","branches_url":"https://api.github.com/repos/draios/sysdig/branches{/branch}","tags_url":"https://api.github.com/repos/draios/sysdig/tags","blobs_url":"https://api.github.com/repos/draios/sysdig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/draios/sysdig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/draios/sysdig/git/refs{/sha}","trees_url":"https://api.github.com/repos/draios/sysdig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/draios/sysdig/statuses/{sha}","languages_url":"https://api.github.com/repos/draios/sysdig/languages","stargazers_url":"https://api.github.com/repos/draios/sysdig/stargazers","contributors_url":"https://api.github.com/repos/draios/sysdig/contributors","subscribers_url":"https://api.github.com/repos/draios/sysdig/subscribers","subscription_url":"https://api.github.com/repos/draios/sysdig/subscription","commits_url":"https://api.github.com/repos/draios/sysdig/commits{/sha}","git_commits_url":"https://api.github.com/repos/draios/sysdig/git/commits{/sha}","comments_url":"https://api.github.com/repos/draios/sysdig/comments{/number}","issue_comment_url":"https://api.github.com/repos/draios/sysdig/issues/comments{/number}","contents_url":"https://api.github.com/repos/draios/sysdig/contents/{+path}","compare_url":"https://api.github.com/repos/draios/sysdig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/draios/sysdig/merges","archive_url":"https://api.github.com/repos/draios/sysdig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/draios/sysdig/downloads","issues_url":"https://api.github.com/repos/draios/sysdig/issues{/number}","pulls_url":"https://api.github.com/repos/draios/sysdig/pulls{/number}","milestones_url":"https://api.github.com/repos/draios/sysdig/milestones{/number}","notifications_url":"https://api.github.com/repos/draios/sysdig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/draios/sysdig/labels{/name}","releases_url":"https://api.github.com/repos/draios/sysdig/releases{/id}","deployments_url":"https://api.github.com/repos/draios/sysdig/deployments","created_at":"2014-01-15T05:45:17Z","updated_at":"2016-07-21T14:08:20Z","pushed_at":"2016-07-21T16:54:11Z","git_url":"git://github.com/draios/sysdig.git","ssh_url":"git@github.com:draios/sysdig.git","clone_url":"https://github.com/draios/sysdig.git","svn_url":"https://github.com/draios/sysdig","homepage":"http://www.sysdig.org/","size":14328,"stargazers_count":3783,"watchers_count":3783,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":105,"forks":347,"open_issues":105,"watchers":3783,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/draios/sysdig/pulls/635"},"html":{"href":"https://github.com/draios/sysdig/pull/635"},"issue":{"href":"https://api.github.com/repos/draios/sysdig/issues/635"},"comments":{"href":"https://api.github.com/repos/draios/sysdig/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/draios/sysdig/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/draios/sysdig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/draios/sysdig/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/draios/sysdig/statuses/a634367ff647dc30e91f33d3dc770e53da9e87b7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"mstemm"}}