{"action":"opened","number":58,"pull_request":{"url":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/58","id":75244049,"html_url":"https://github.com/jiocloudDSS/ceph/pull/58","diff_url":"https://github.com/jiocloudDSS/ceph/pull/58.diff","patch_url":"https://github.com/jiocloudDSS/ceph/pull/58.patch","issue_url":"https://api.github.com/repos/jiocloudDSS/ceph/issues/58","number":58,"state":"open","locked":false,"title":"Final rename review. Mergeable.","user":{"login":"shivanshu21","id":14923644,"avatar_url":"https://avatars.githubusercontent.com/u/14923644?v=3","gravatar_id":"","url":"https://api.github.com/users/shivanshu21","html_url":"https://github.com/shivanshu21","followers_url":"https://api.github.com/users/shivanshu21/followers","following_url":"https://api.github.com/users/shivanshu21/following{/other_user}","gists_url":"https://api.github.com/users/shivanshu21/gists{/gist_id}","starred_url":"https://api.github.com/users/shivanshu21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivanshu21/subscriptions","organizations_url":"https://api.github.com/users/shivanshu21/orgs","repos_url":"https://api.github.com/users/shivanshu21/repos","events_url":"https://api.github.com/users/shivanshu21/events{/privacy}","received_events_url":"https://api.github.com/users/shivanshu21/received_events","type":"User","site_admin":false},"body":"1. Rename an object\r\n===================\r\n\r\nRename operation requires PutObject permission from IAM. It also requires authentication (token/signature based or presigned URL)\r\nEg. \r\nPUT https://www.dss.com/bucket/objname?newname=newobj\r\n\r\n* Rename an object with signature auth -> PASS\r\n* Rename an object with token auth -> PASS\r\n* Rename an object without IAM permissions. This should fail.\r\n\r\n\r\n2. Bad rename requests\r\n======================\r\n\r\n* Rename an object when bucket does not exists -> PASS\r\n* Rename an object when object does not exists -> PASS\r\n* Try rename op when the HTTP verb is GET/POST etc. Eg. POST https://www.dss.com/validbuck/validobj?newname=newobj. This should fail. -> FAILS\r\n* Disable rename op using ceph.conf option: \"rgw enable rename op = false\". Try rename. It should fail. -> FAILS\r\n* Have objects file1, file2. Rename file1 to file2. This should fail. -> FAILS\r\n* Rename an object with its own name. Copy fails as a legacy so this should fail. -> FAILS\r\n\r\n\r\n3. Fault injection cases\r\n========================\r\n\r\nHere are the fault injection options for ceph.conf\r\n1081 OPTION(fault_inj_rename_op_copy_fail, OPT_BOOL, false)          // Injects fault in rename op during copy operation\r\n1082 OPTION(fault_inj_rename_op_delete_fail, OPT_BOOL, false)        // Injects fault in rename op during delete operation\r\n1083 OPTION(fault_inj_rename_op_parse_fail, OPT_BOOL, false)         // Injects fault in rename op during parse operation\r\n1084 OPTION(fault_inj_rename_op_sleep_after_copy, OPT_BOOL, false)   // Make rename op sleep after copy\r\n\r\n* Turn copy fault on and try rename. Proper error message should be thrown and original object should stay intact. No ghost object should be present. -> PASS\r\n\r\n* Turn delete fault on and try rename. Original should remain. No ghosts. -> PASS\r\n\r\n* Turn parse fault on and try rename. Original should remain. No ghosts. -> PASS","created_at":"2016-06-26T23:32:17Z","updated_at":"2016-06-26T23:32:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/58/commits","review_comments_url":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/58/comments","review_comment_url":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jiocloudDSS/ceph/issues/58/comments","statuses_url":"https://api.github.com/repos/jiocloudDSS/ceph/statuses/14754e25d1108fca5bb5827518919aacf9b66368","head":{"label":"shivanshu21:final_rename_review","ref":"final_rename_review","sha":"14754e25d1108fca5bb5827518919aacf9b66368","user":{"login":"shivanshu21","id":14923644,"avatar_url":"https://avatars.githubusercontent.com/u/14923644?v=3","gravatar_id":"","url":"https://api.github.com/users/shivanshu21","html_url":"https://github.com/shivanshu21","followers_url":"https://api.github.com/users/shivanshu21/followers","following_url":"https://api.github.com/users/shivanshu21/following{/other_user}","gists_url":"https://api.github.com/users/shivanshu21/gists{/gist_id}","starred_url":"https://api.github.com/users/shivanshu21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivanshu21/subscriptions","organizations_url":"https://api.github.com/users/shivanshu21/orgs","repos_url":"https://api.github.com/users/shivanshu21/repos","events_url":"https://api.github.com/users/shivanshu21/events{/privacy}","received_events_url":"https://api.github.com/users/shivanshu21/received_events","type":"User","site_admin":false},"repo":{"id":48225349,"name":"ceph","full_name":"shivanshu21/ceph","owner":{"login":"shivanshu21","id":14923644,"avatar_url":"https://avatars.githubusercontent.com/u/14923644?v=3","gravatar_id":"","url":"https://api.github.com/users/shivanshu21","html_url":"https://github.com/shivanshu21","followers_url":"https://api.github.com/users/shivanshu21/followers","following_url":"https://api.github.com/users/shivanshu21/following{/other_user}","gists_url":"https://api.github.com/users/shivanshu21/gists{/gist_id}","starred_url":"https://api.github.com/users/shivanshu21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivanshu21/subscriptions","organizations_url":"https://api.github.com/users/shivanshu21/orgs","repos_url":"https://api.github.com/users/shivanshu21/repos","events_url":"https://api.github.com/users/shivanshu21/events{/privacy}","received_events_url":"https://api.github.com/users/shivanshu21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shivanshu21/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/shivanshu21/ceph","forks_url":"https://api.github.com/repos/shivanshu21/ceph/forks","keys_url":"https://api.github.com/repos/shivanshu21/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivanshu21/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivanshu21/ceph/teams","hooks_url":"https://api.github.com/repos/shivanshu21/ceph/hooks","issue_events_url":"https://api.github.com/repos/shivanshu21/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/shivanshu21/ceph/events","assignees_url":"https://api.github.com/repos/shivanshu21/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/shivanshu21/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/shivanshu21/ceph/tags","blobs_url":"https://api.github.com/repos/shivanshu21/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivanshu21/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivanshu21/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivanshu21/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivanshu21/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/shivanshu21/ceph/languages","stargazers_url":"https://api.github.com/repos/shivanshu21/ceph/stargazers","contributors_url":"https://api.github.com/repos/shivanshu21/ceph/contributors","subscribers_url":"https://api.github.com/repos/shivanshu21/ceph/subscribers","subscription_url":"https://api.github.com/repos/shivanshu21/ceph/subscription","commits_url":"https://api.github.com/repos/shivanshu21/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivanshu21/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivanshu21/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivanshu21/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivanshu21/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/shivanshu21/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivanshu21/ceph/merges","archive_url":"https://api.github.com/repos/shivanshu21/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivanshu21/ceph/downloads","issues_url":"https://api.github.com/repos/shivanshu21/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/shivanshu21/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/shivanshu21/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/shivanshu21/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivanshu21/ceph/labels{/name}","releases_url":"https://api.github.com/repos/shivanshu21/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/shivanshu21/ceph/deployments","created_at":"2015-12-18T09:06:54Z","updated_at":"2016-04-19T15:27:34Z","pushed_at":"2016-06-26T23:25:46Z","git_url":"git://github.com/shivanshu21/ceph.git","ssh_url":"git@github.com:shivanshu21/ceph.git","clone_url":"https://github.com/shivanshu21/ceph.git","svn_url":"https://github.com/shivanshu21/ceph","homepage":"http://ceph.com","size":157939,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jiocloudDSS:hammer","ref":"hammer","sha":"6fec0b1c1689bf85612091479f1d031a15577c66","user":{"login":"jiocloudDSS","id":16133223,"avatar_url":"https://avatars.githubusercontent.com/u/16133223?v=3","gravatar_id":"","url":"https://api.github.com/users/jiocloudDSS","html_url":"https://github.com/jiocloudDSS","followers_url":"https://api.github.com/users/jiocloudDSS/followers","following_url":"https://api.github.com/users/jiocloudDSS/following{/other_user}","gists_url":"https://api.github.com/users/jiocloudDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/jiocloudDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiocloudDSS/subscriptions","organizations_url":"https://api.github.com/users/jiocloudDSS/orgs","repos_url":"https://api.github.com/users/jiocloudDSS/repos","events_url":"https://api.github.com/users/jiocloudDSS/events{/privacy}","received_events_url":"https://api.github.com/users/jiocloudDSS/received_events","type":"Organization","site_admin":false},"repo":{"id":47325937,"name":"ceph","full_name":"jiocloudDSS/ceph","owner":{"login":"jiocloudDSS","id":16133223,"avatar_url":"https://avatars.githubusercontent.com/u/16133223?v=3","gravatar_id":"","url":"https://api.github.com/users/jiocloudDSS","html_url":"https://github.com/jiocloudDSS","followers_url":"https://api.github.com/users/jiocloudDSS/followers","following_url":"https://api.github.com/users/jiocloudDSS/following{/other_user}","gists_url":"https://api.github.com/users/jiocloudDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/jiocloudDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiocloudDSS/subscriptions","organizations_url":"https://api.github.com/users/jiocloudDSS/orgs","repos_url":"https://api.github.com/users/jiocloudDSS/repos","events_url":"https://api.github.com/users/jiocloudDSS/events{/privacy}","received_events_url":"https://api.github.com/users/jiocloudDSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jiocloudDSS/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/jiocloudDSS/ceph","forks_url":"https://api.github.com/repos/jiocloudDSS/ceph/forks","keys_url":"https://api.github.com/repos/jiocloudDSS/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiocloudDSS/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiocloudDSS/ceph/teams","hooks_url":"https://api.github.com/repos/jiocloudDSS/ceph/hooks","issue_events_url":"https://api.github.com/repos/jiocloudDSS/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/jiocloudDSS/ceph/events","assignees_url":"https://api.github.com/repos/jiocloudDSS/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/jiocloudDSS/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/jiocloudDSS/ceph/tags","blobs_url":"https://api.github.com/repos/jiocloudDSS/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiocloudDSS/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiocloudDSS/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiocloudDSS/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiocloudDSS/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/jiocloudDSS/ceph/languages","stargazers_url":"https://api.github.com/repos/jiocloudDSS/ceph/stargazers","contributors_url":"https://api.github.com/repos/jiocloudDSS/ceph/contributors","subscribers_url":"https://api.github.com/repos/jiocloudDSS/ceph/subscribers","subscription_url":"https://api.github.com/repos/jiocloudDSS/ceph/subscription","commits_url":"https://api.github.com/repos/jiocloudDSS/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiocloudDSS/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiocloudDSS/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiocloudDSS/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiocloudDSS/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/jiocloudDSS/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiocloudDSS/ceph/merges","archive_url":"https://api.github.com/repos/jiocloudDSS/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiocloudDSS/ceph/downloads","issues_url":"https://api.github.com/repos/jiocloudDSS/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/jiocloudDSS/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/jiocloudDSS/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/jiocloudDSS/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiocloudDSS/ceph/labels{/name}","releases_url":"https://api.github.com/repos/jiocloudDSS/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/jiocloudDSS/ceph/deployments","created_at":"2015-12-03T10:49:26Z","updated_at":"2015-12-03T10:50:19Z","pushed_at":"2016-06-26T23:32:17Z","git_url":"git://github.com/jiocloudDSS/ceph.git","ssh_url":"git@github.com:jiocloudDSS/ceph.git","clone_url":"https://github.com/jiocloudDSS/ceph.git","svn_url":"https://github.com/jiocloudDSS/ceph","homepage":"http://ceph.com","size":136070,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/58"},"html":{"href":"https://github.com/jiocloudDSS/ceph/pull/58"},"issue":{"href":"https://api.github.com/repos/jiocloudDSS/ceph/issues/58"},"comments":{"href":"https://api.github.com/repos/jiocloudDSS/ceph/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jiocloudDSS/ceph/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/jiocloudDSS/ceph/statuses/14754e25d1108fca5bb5827518919aacf9b66368"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":327,"deletions":15,"changed_files":9}}
{"actor":{"display_login":"shivanshu21"}}