{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/92329409","pull_request_review_id":12835298,"id":92329409,"diff_hunk":"@@ -0,0 +1,160 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.beam.sdk.io;\n+\n+import static com.google.common.base.Preconditions.checkArgument;\n+import static com.google.common.base.Preconditions.checkNotNull;\n+\n+import com.google.common.annotations.VisibleForTesting;\n+import com.google.common.base.Function;\n+import com.google.common.base.Joiner;\n+import com.google.common.collect.FluentIterable;\n+import com.google.common.collect.Lists;\n+import com.google.common.collect.Multimap;\n+import com.google.common.collect.Ordering;\n+import com.google.common.collect.Sets;\n+import com.google.common.collect.TreeMultimap;\n+import java.net.URI;\n+import java.util.Collection;\n+import java.util.Collections;\n+import java.util.HashMap;\n+import java.util.Map;\n+import java.util.Map.Entry;\n+import java.util.ServiceLoader;\n+import java.util.Set;\n+import java.util.regex.Pattern;\n+import javax.annotation.Nonnull;\n+import org.apache.beam.sdk.options.PipelineOptions;\n+import org.apache.beam.sdk.util.common.ReflectHelpers;\n+\n+/**\n+ * Clients facing {@link FileSystem} utility.\n+ */\n+public class FileSystems {\n+\n+  public static final String DEFAULT_SCHEME = \"default\";\n+\n+  private static final Pattern URI_SCHEME_PATTERN = Pattern.compile(\"^[a-zA-Z][-a-zA-Z0-9+.]*$\");\n+\n+  private static final ClassLoader CLASS_LOADER = ReflectHelpers.findClassLoader();\n+\n+  private static final Map<String, FileSystemRegistrar> REGISTRAR_MAP =\n+      Collections.synchronizedMap(new HashMap<String, FileSystemRegistrar>());\n+\n+  private static final Map<String, PipelineOptions> REGISTRAR_DEFAULT_CONFIG_MAP =\n+      Collections.synchronizedMap(new HashMap<String, PipelineOptions>());\n+\n+  public static void loadFileSystemRegistrars() {","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java","position":null,"original_position":62,"commit_id":"d929ab2ca22f95ca819b352e9a3895cb552e10bf","original_commit_id":"07e2a1aee8315adb54c66ad2da0efa7fc560a620","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"body":"I don't get it.\r\nOnly use CLASS_LOADER?","created_at":"2016-12-14T06:33:16Z","updated_at":"2016-12-14T06:36:00Z","html_url":"https://github.com/apache/incubator-beam/pull/1558#discussion_r92329409","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1558","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/92329409"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1558#discussion_r92329409"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1558"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1558","id":97226089,"html_url":"https://github.com/apache/incubator-beam/pull/1558","diff_url":"https://github.com/apache/incubator-beam/pull/1558.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1558.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1558","number":1558,"state":"open","locked":false,"title":"[BEAM-59] initial interfaces and classes of Beam FileSystem.","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [ ] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\n","created_at":"2016-12-09T00:01:20Z","updated_at":"2016-12-14T06:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"528ebd7ad82d9f95a5543a94db4a48e0ce2da28e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1558/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1558/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1558/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/d929ab2ca22f95ca819b352e9a3895cb552e10bf","head":{"label":"peihe:file-system-init","ref":"file-system-init","sha":"d929ab2ca22f95ca819b352e9a3895cb552e10bf","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"repo":{"id":52831526,"name":"incubator-beam","full_name":"peihe/incubator-beam","owner":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peihe/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/peihe/incubator-beam","forks_url":"https://api.github.com/repos/peihe/incubator-beam/forks","keys_url":"https://api.github.com/repos/peihe/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peihe/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peihe/incubator-beam/teams","hooks_url":"https://api.github.com/repos/peihe/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/peihe/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/peihe/incubator-beam/events","assignees_url":"https://api.github.com/repos/peihe/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/peihe/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/peihe/incubator-beam/tags","blobs_url":"https://api.github.com/repos/peihe/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peihe/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peihe/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/peihe/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peihe/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/peihe/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/peihe/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/peihe/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/peihe/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/peihe/incubator-beam/subscription","commits_url":"https://api.github.com/repos/peihe/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/peihe/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/peihe/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/peihe/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/peihe/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/peihe/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peihe/incubator-beam/merges","archive_url":"https://api.github.com/repos/peihe/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peihe/incubator-beam/downloads","issues_url":"https://api.github.com/repos/peihe/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/peihe/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/peihe/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/peihe/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peihe/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/peihe/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/peihe/incubator-beam/deployments","created_at":"2016-02-29T23:06:11Z","updated_at":"2016-02-29T23:06:15Z","pushed_at":"2016-12-14T06:34:57Z","git_url":"git://github.com/peihe/incubator-beam.git","ssh_url":"git@github.com:peihe/incubator-beam.git","clone_url":"https://github.com/peihe/incubator-beam.git","svn_url":"https://github.com/peihe/incubator-beam","homepage":null,"size":23224,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"58bb1174d087c5d3976dab921c528fdb6a45dbab","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-12-13T16:39:24Z","pushed_at":"2016-12-14T06:34:58Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":25146,"stargazers_count":526,"watchers_count":526,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":317,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":60,"forks":317,"open_issues":60,"watchers":526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1558"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1558"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1558"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1558/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1558/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1558/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/d929ab2ca22f95ca819b352e9a3895cb552e10bf"}}}}
{"actor":{"display_login":"peihe"}}