{"action":"created","issue":{"url":"https://api.github.com/repos/Jasig/cas/issues/1532","repository_url":"https://api.github.com/repos/Jasig/cas","labels_url":"https://api.github.com/repos/Jasig/cas/issues/1532/labels{/name}","comments_url":"https://api.github.com/repos/Jasig/cas/issues/1532/comments","events_url":"https://api.github.com/repos/Jasig/cas/issues/1532/events","html_url":"https://github.com/Jasig/cas/issues/1532","id":132121830,"number":1532,"title":"Package o.j.c.a.principal - incorrect documentation","user":{"login":"PetrGasparik","id":2803987,"avatar_url":"https://avatars.githubusercontent.com/u/2803987?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrGasparik","html_url":"https://github.com/PetrGasparik","followers_url":"https://api.github.com/users/PetrGasparik/followers","following_url":"https://api.github.com/users/PetrGasparik/following{/other_user}","gists_url":"https://api.github.com/users/PetrGasparik/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrGasparik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrGasparik/subscriptions","organizations_url":"https://api.github.com/users/PetrGasparik/orgs","repos_url":"https://api.github.com/users/PetrGasparik/repos","events_url":"https://api.github.com/users/PetrGasparik/events{/privacy}","received_events_url":"https://api.github.com/users/PetrGasparik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Jasig/cas/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/Jasig/cas/labels/Documentation","name":"Documentation","color":"5319e7"},{"url":"https://api.github.com/repos/Jasig/cas/labels/Principal%20Resolution","name":"Principal Resolution","color":"5319e7"},{"url":"https://api.github.com/repos/Jasig/cas/labels/Trivial","name":"Trivial","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Jasig/cas/milestones/22","html_url":"https://github.com/Jasig/cas/milestones/4.1.5","labels_url":"https://api.github.com/repos/Jasig/cas/milestones/22/labels","id":1513479,"number":22,"title":"4.1.5","description":"CAS 4.1.5 patch release","creator":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":10,"state":"open","created_at":"2016-01-18T21:03:55Z","updated_at":"2016-02-08T23:26:01Z","due_on":"2016-02-19T07:00:00Z","closed_at":null},"comments":3,"created_at":"2016-02-08T11:48:02Z","updated_at":"2016-02-09T09:23:48Z","closed_at":null,"body":"Package org.jasig.cas.authentication.principal has outdated documentation, citing classes, that do not exist:\r\n\r\n> The CredentialsToPrincipalResolver looks into previously validated Credentials to construct a Principal object containing an ID (and in more complex cases some attributes). The DefaultCredentialsToPrincipalResolver takes UsernamePasswordCredentials and creates a SimplePrincipal containing the Userid.\r\n\r\nI am just trying to understand this package so this information is important for me :) And now, when even SimplePrincipal is private since 4.1, it is even more important."},"comment":{"url":"https://api.github.com/repos/Jasig/cas/issues/comments/181775466","html_url":"https://github.com/Jasig/cas/issues/1532#issuecomment-181775466","issue_url":"https://api.github.com/repos/Jasig/cas/issues/1532","id":181775466,"user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"created_at":"2016-02-09T09:23:48Z","updated_at":"2016-02-09T09:23:48Z","body":"How about this:\r\n\r\n```\r\n/**\r\n * <p>Credentials is a marker interface for an opaque object that may be recognized by\r\n * Handlers and Resolvers. Credentials may be a UserId/Password, Certificate,\r\n * RemoteUser, IP address, etc.</p>\r\n * <p>When the authentication manager is\r\n * used, that bean is configured with a list of {@link org.jasig.cas.authentication.AuthenticationHandler} that\r\n * validate Credentials and {@link org.jasig.cas.authentication.principal.PrincipalResolver} that turn\r\n * {@link org.jasig.cas.authentication.Credential} objects into\r\n * into {@link org.jasig.cas.authentication.principal.Principal} objects.</p>\r\n * <p>The Authentication Handler validates credentials and in certain cases is able extract\r\n * information. The extraction use case is clearer when credentials are certificates.\r\n * A certificate is valid if you trust the CA, if it hasn't expired, and if it isn't revoked.\r\n * You can decide all this, and still not have the foggiest idea what ID to give to the person (if\r\n * it is a person) represented by the Certificate.</p>\r\n * <p>The {@link org.jasig.cas.authentication.principal.PrincipalResolver}\r\n * looks into previously validated credentials to construct a Principal object containing an ID (and in more\r\n * complex cases some attributes). The {@link org.jasig.cas.authentication.principal.BasicPrincipalResolver} takes\r\n * credentials and creates a SimplePrincipal containing the Userid.</p>\r\n * @since 3.0\r\n */\r\n```\r\n\r\nThis is based on master. Please adapt for 4.1. "}}