{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/54014405","id":54014405,"diff_hunk":"@@ -26,7 +26,6 @@ func (cli *DockerCli) CmdLogin(args ...string) error {\n \n \tflUser := cmd.String([]string{\"u\", \"-username\"}, \"\", \"Username\")\n \tflPassword := cmd.String([]string{\"p\", \"-password\"}, \"\", \"Password\")\n-\tflEmail := cmd.String([]string{\"e\", \"-email\"}, \"\", \"Email\")","path":"api/client/login.go","position":13,"original_position":13,"commit_id":"23c5bed7d2a2547e967ccf314029d48c929bcbce","original_commit_id":"23c5bed7d2a2547e967ccf314029d48c929bcbce","user":{"login":"kencochrane","id":261601,"avatar_url":"https://avatars.githubusercontent.com/u/261601?v=3","gravatar_id":"","url":"https://api.github.com/users/kencochrane","html_url":"https://github.com/kencochrane","followers_url":"https://api.github.com/users/kencochrane/followers","following_url":"https://api.github.com/users/kencochrane/following{/other_user}","gists_url":"https://api.github.com/users/kencochrane/gists{/gist_id}","starred_url":"https://api.github.com/users/kencochrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kencochrane/subscriptions","organizations_url":"https://api.github.com/users/kencochrane/orgs","repos_url":"https://api.github.com/users/kencochrane/repos","events_url":"https://api.github.com/users/kencochrane/events{/privacy}","received_events_url":"https://api.github.com/users/kencochrane/received_events","type":"User","site_admin":false},"body":"@thaJeztah if we mark it as deprecated, does that mean, we keep it there, we just ignore the value that is passed in? I'm fine with what ever you think is best, I just want to make sure I understand what you are saying, so that I can implement it correctly.","created_at":"2016-02-24T22:02:44Z","updated_at":"2016-02-24T22:02:44Z","html_url":"https://github.com/docker/docker/pull/20565#discussion_r54014405","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/20565","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/54014405"},"html":{"href":"https://github.com/docker/docker/pull/20565#discussion_r54014405"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/20565"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20565","id":60108351,"html_url":"https://github.com/docker/docker/pull/20565","diff_url":"https://github.com/docker/docker/pull/20565.diff","patch_url":"https://github.com/docker/docker/pull/20565.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/20565","number":20565,"state":"open","locked":false,"title":"Remove email address field from login","user":{"login":"kencochrane","id":261601,"avatar_url":"https://avatars.githubusercontent.com/u/261601?v=3","gravatar_id":"","url":"https://api.github.com/users/kencochrane","html_url":"https://github.com/kencochrane","followers_url":"https://api.github.com/users/kencochrane/followers","following_url":"https://api.github.com/users/kencochrane/following{/other_user}","gists_url":"https://api.github.com/users/kencochrane/gists{/gist_id}","starred_url":"https://api.github.com/users/kencochrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kencochrane/subscriptions","organizations_url":"https://api.github.com/users/kencochrane/orgs","repos_url":"https://api.github.com/users/kencochrane/repos","events_url":"https://api.github.com/users/kencochrane/events{/privacy}","received_events_url":"https://api.github.com/users/kencochrane/received_events","type":"User","site_admin":false},"body":"This removes the email prompt when you use docker login, and also removes the ability to register via the docker cli. Docker login, will strictly be used for logging into a registry server.\r\n\r\nThis picks up where ##16183 left off.\r\n\r\ncloses: #6400\r\n\r\nNot quite what @bfirsh wanted with #18668 but it solves the issue, and keeps backwards compatibility with older version of the engine.\r\n\r\nThere was one change on engine-api as well: https://github.com/docker/engine-api/pull/105 Not sure what the process is to update the vendored version of that lib.\r\n\r\n/cc @bfirsh @dmp42 \r\n\r\nSigned-off-by: Ken Cochrane <kencochrane@gmail.com>","created_at":"2016-02-21T22:58:23Z","updated_at":"2016-02-24T22:02:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc0bcbebb3abe7f3e20381ce93fda321ed1317b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/20565/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/20565/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/20565/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/23c5bed7d2a2547e967ccf314029d48c929bcbce","head":{"label":"kencochrane:remove_email_on_login","ref":"remove_email_on_login","sha":"23c5bed7d2a2547e967ccf314029d48c929bcbce","user":{"login":"kencochrane","id":261601,"avatar_url":"https://avatars.githubusercontent.com/u/261601?v=3","gravatar_id":"","url":"https://api.github.com/users/kencochrane","html_url":"https://github.com/kencochrane","followers_url":"https://api.github.com/users/kencochrane/followers","following_url":"https://api.github.com/users/kencochrane/following{/other_user}","gists_url":"https://api.github.com/users/kencochrane/gists{/gist_id}","starred_url":"https://api.github.com/users/kencochrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kencochrane/subscriptions","organizations_url":"https://api.github.com/users/kencochrane/orgs","repos_url":"https://api.github.com/users/kencochrane/repos","events_url":"https://api.github.com/users/kencochrane/events{/privacy}","received_events_url":"https://api.github.com/users/kencochrane/received_events","type":"User","site_admin":false},"repo":{"id":8713981,"name":"docker","full_name":"kencochrane/docker","owner":{"login":"kencochrane","id":261601,"avatar_url":"https://avatars.githubusercontent.com/u/261601?v=3","gravatar_id":"","url":"https://api.github.com/users/kencochrane","html_url":"https://github.com/kencochrane","followers_url":"https://api.github.com/users/kencochrane/followers","following_url":"https://api.github.com/users/kencochrane/following{/other_user}","gists_url":"https://api.github.com/users/kencochrane/gists{/gist_id}","starred_url":"https://api.github.com/users/kencochrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kencochrane/subscriptions","organizations_url":"https://api.github.com/users/kencochrane/orgs","repos_url":"https://api.github.com/users/kencochrane/repos","events_url":"https://api.github.com/users/kencochrane/events{/privacy}","received_events_url":"https://api.github.com/users/kencochrane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kencochrane/docker","description":"","fork":true,"url":"https://api.github.com/repos/kencochrane/docker","forks_url":"https://api.github.com/repos/kencochrane/docker/forks","keys_url":"https://api.github.com/repos/kencochrane/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kencochrane/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kencochrane/docker/teams","hooks_url":"https://api.github.com/repos/kencochrane/docker/hooks","issue_events_url":"https://api.github.com/repos/kencochrane/docker/issues/events{/number}","events_url":"https://api.github.com/repos/kencochrane/docker/events","assignees_url":"https://api.github.com/repos/kencochrane/docker/assignees{/user}","branches_url":"https://api.github.com/repos/kencochrane/docker/branches{/branch}","tags_url":"https://api.github.com/repos/kencochrane/docker/tags","blobs_url":"https://api.github.com/repos/kencochrane/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kencochrane/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kencochrane/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/kencochrane/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kencochrane/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/kencochrane/docker/languages","stargazers_url":"https://api.github.com/repos/kencochrane/docker/stargazers","contributors_url":"https://api.github.com/repos/kencochrane/docker/contributors","subscribers_url":"https://api.github.com/repos/kencochrane/docker/subscribers","subscription_url":"https://api.github.com/repos/kencochrane/docker/subscription","commits_url":"https://api.github.com/repos/kencochrane/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/kencochrane/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/kencochrane/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/kencochrane/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/kencochrane/docker/contents/{+path}","compare_url":"https://api.github.com/repos/kencochrane/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kencochrane/docker/merges","archive_url":"https://api.github.com/repos/kencochrane/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kencochrane/docker/downloads","issues_url":"https://api.github.com/repos/kencochrane/docker/issues{/number}","pulls_url":"https://api.github.com/repos/kencochrane/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/kencochrane/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/kencochrane/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kencochrane/docker/labels{/name}","releases_url":"https://api.github.com/repos/kencochrane/docker/releases{/id}","deployments_url":"https://api.github.com/repos/kencochrane/docker/deployments","created_at":"2013-03-11T21:42:42Z","updated_at":"2014-10-02T01:08:34Z","pushed_at":"2016-02-23T22:37:42Z","git_url":"git://github.com/kencochrane/docker.git","ssh_url":"git@github.com:kencochrane/docker.git","clone_url":"https://github.com/kencochrane/docker.git","svn_url":"https://github.com/kencochrane/docker","homepage":null,"size":80406,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"2ed1806b2c563e2276d81066cc492aaf7bcb145b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-02-24T21:29:48Z","pushed_at":"2016-02-24T21:57:35Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":137099,"stargazers_count":28935,"watchers_count":28935,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8066,"mirror_url":null,"open_issues_count":1392,"forks":8066,"open_issues":1392,"watchers":28935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/20565"},"html":{"href":"https://github.com/docker/docker/pull/20565"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/20565"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/20565/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/20565/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/20565/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/23c5bed7d2a2547e967ccf314029d48c929bcbce"}}}}