{"action":"created","issue":{"url":"https://api.github.com/repos/firehol/netdata/issues/600","repository_url":"https://api.github.com/repos/firehol/netdata","labels_url":"https://api.github.com/repos/firehol/netdata/issues/600/labels{/name}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/600/comments","events_url":"https://api.github.com/repos/firehol/netdata/issues/600/events","html_url":"https://github.com/firehol/netdata/pull/600","id":161725045,"number":600,"title":"Python and Shell fixes + apache and nginx python modules.","user":{"login":"paulfantom","id":3531758,"avatar_url":"https://avatars.githubusercontent.com/u/3531758?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-22T16:14:15Z","updated_at":"2016-06-22T21:24:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/firehol/netdata/pulls/600","html_url":"https://github.com/firehol/netdata/pull/600","diff_url":"https://github.com/firehol/netdata/pull/600.diff","patch_url":"https://github.com/firehol/netdata/pull/600.patch"},"body":"I found two issues with previous version of `python.d.plugin`\r\n1. every configuration file had to have `update_every` value\r\n2. `python.d.config debug 1` raised an exception and exited program\r\n\r\nBoth are fixed in this PR.\r\n\r\nThere was also an issue in UrlService which prevented running more than one instance of child classes. \r\n\r\nI have been testing it with Apache and nginx plugins which are now working, so I am adding them too. \r\n\r\nWhile testing apache plugins I found one issue in `apache.chart.sh`. fixed it.\r\n\r\nCurrently every plugin can monitor many instances, so I've added formatting of apache and nginx modules in `index.html`. They can be shown the same way as MySQL. But later I have commented it out due to incompatibility with shell counterparts.\r\n\r\nFinally I modified makefiles to include new python modules.\r\n\r\nEverything should work and is ready to be merged after your review.\r\n\r\nI have also compared run times: `apache.chart.sh` with `apache.chart.py` and `nginx.chart.sh` with `nginx.chart.py` and python versions are a little bit faster (about 50-90%).\r\n\r\nP.S. I didn't intend to make this PR so big. \r\n\r\nP.P.S. For some time I will cease rewriting bash modules to python."},"comment":{"url":"https://api.github.com/repos/firehol/netdata/issues/comments/227881368","html_url":"https://github.com/firehol/netdata/pull/600#issuecomment-227881368","issue_url":"https://api.github.com/repos/firehol/netdata/issues/600","id":227881368,"user":{"login":"ktsaou","id":2662304,"avatar_url":"https://avatars.githubusercontent.com/u/2662304?v=3","gravatar_id":"","url":"https://api.github.com/users/ktsaou","html_url":"https://github.com/ktsaou","followers_url":"https://api.github.com/users/ktsaou/followers","following_url":"https://api.github.com/users/ktsaou/following{/other_user}","gists_url":"https://api.github.com/users/ktsaou/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsaou/subscriptions","organizations_url":"https://api.github.com/users/ktsaou/orgs","repos_url":"https://api.github.com/users/ktsaou/repos","events_url":"https://api.github.com/users/ktsaou/events{/privacy}","received_events_url":"https://api.github.com/users/ktsaou/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T21:24:50Z","updated_at":"2016-06-22T21:24:50Z","body":"I have done some basic testing and it seems good. I cannot test apache and nginx until Sunday (I am in a trip). So, I think we can merge this and if I find something during the weekend I'll come back.\r\n\r\nok?\r\n"}}
{"actor":{"display_login":"ktsaou"}}