{"action":"created","issue":{"url":"https://api.github.com/repos/xunit/xunit/issues/1020","repository_url":"https://api.github.com/repos/xunit/xunit","labels_url":"https://api.github.com/repos/xunit/xunit/issues/1020/labels{/name}","comments_url":"https://api.github.com/repos/xunit/xunit/issues/1020/comments","events_url":"https://api.github.com/repos/xunit/xunit/issues/1020/events","html_url":"https://github.com/xunit/xunit/pull/1020","id":187582753,"number":1020,"title":"Add support for implicit and explicit conversions in theories","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"labels":[{"id":446930806,"url":"https://api.github.com/repos/xunit/xunit/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-06T19:26:42Z","updated_at":"2016-11-07T19:19:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xunit/xunit/pulls/1020","html_url":"https://github.com/xunit/xunit/pull/1020","diff_url":"https://github.com/xunit/xunit/pull/1020.diff","patch_url":"https://github.com/xunit/xunit/pull/1020.patch"},"body":"Fixes #1013 "},"comment":{"url":"https://api.github.com/repos/xunit/xunit/issues/comments/258934231","html_url":"https://github.com/xunit/xunit/pull/1020#issuecomment-258934231","issue_url":"https://api.github.com/repos/xunit/xunit/issues/1020","id":258934231,"user":{"login":"Ausm","id":5859112,"avatar_url":"https://avatars.githubusercontent.com/u/5859112?v=3","gravatar_id":"","url":"https://api.github.com/users/Ausm","html_url":"https://github.com/Ausm","followers_url":"https://api.github.com/users/Ausm/followers","following_url":"https://api.github.com/users/Ausm/following{/other_user}","gists_url":"https://api.github.com/users/Ausm/gists{/gist_id}","starred_url":"https://api.github.com/users/Ausm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ausm/subscriptions","organizations_url":"https://api.github.com/users/Ausm/orgs","repos_url":"https://api.github.com/users/Ausm/repos","events_url":"https://api.github.com/users/Ausm/events{/privacy}","received_events_url":"https://api.github.com/users/Ausm/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T19:19:08Z","updated_at":"2016-11-07T19:19:08Z","body":"Aha, yes, I see, you are null checking the MethodInfo's, and RuntimeType.TryChangeType does the implicit conversion for primitives later when calling the theory method.\r\nBut what's with explicit conversions between primitives, they fail, because there is no op_Explicit.\r\nI don't think that it's a good idea to query and invoke the op_... methods via reflection. Converting an object from one type to an other can be complex, and you cannot cover all special cases and you don't know how the .Net framework is changing in the future. And MethodInfo.Invoke is a strong performance killer, and you call it for each parameter of each dataRow given to each theory.\r\n\r\nWhether it should be in the ResolveMethodArguments or in the TestInvoker, don't know.\r\nI put it in the TestInvoker, because the Exception was thrown there, and I tried to fix it."}}
{"actor":{"display_login":"Ausm"}}