{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/pyethapp/issues/117","repository_url":"https://api.github.com/repos/ethereum/pyethapp","labels_url":"https://api.github.com/repos/ethereum/pyethapp/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/pyethapp/issues/117/comments","events_url":"https://api.github.com/repos/ethereum/pyethapp/issues/117/events","html_url":"https://github.com/ethereum/pyethapp/issues/117","id":144815704,"number":117,"title":"JSONRPCClient listens only on localhost","user":{"login":"4gn3s","id":1894412,"avatar_url":"https://avatars.githubusercontent.com/u/1894412?v=3","gravatar_id":"","url":"https://api.github.com/users/4gn3s","html_url":"https://github.com/4gn3s","followers_url":"https://api.github.com/users/4gn3s/followers","following_url":"https://api.github.com/users/4gn3s/following{/other_user}","gists_url":"https://api.github.com/users/4gn3s/gists{/gist_id}","starred_url":"https://api.github.com/users/4gn3s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4gn3s/subscriptions","organizations_url":"https://api.github.com/users/4gn3s/orgs","repos_url":"https://api.github.com/users/4gn3s/repos","events_url":"https://api.github.com/users/4gn3s/events{/privacy}","received_events_url":"https://api.github.com/users/4gn3s/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-31T07:39:43Z","updated_at":"2016-05-18T07:20:12Z","closed_at":null,"body":"JSONRPCClient should allow to define both the host address and the port of the Ethereum client. For now, JSONRPCClient always assumes the address is localhost. This improvement is useful e.g. when running the app and Ethereum client in separate docker containers. For now, the ugly workaround is:\r\n\r\n`self.client = JSONRPCClient(port=ETH_CLIENT_PORT)`\r\n`self.client.transport = HttpPostClientTransport('http://{}:{}'.format(ETH_CLIENT_ADDRESS, ETH_CLIENT_PORT))`\r\n\r\nI think it would be better to be able to just do:\r\n`self.client = JSONRPCClient(host=ETH_CLIENT_ADDRESS, port=ETH_CLIENT_PORT)`"},"comment":{"url":"https://api.github.com/repos/ethereum/pyethapp/issues/comments/219946078","html_url":"https://github.com/ethereum/pyethapp/issues/117#issuecomment-219946078","issue_url":"https://api.github.com/repos/ethereum/pyethapp/issues/117","id":219946078,"user":{"login":"anton44eg","id":896114,"avatar_url":"https://avatars.githubusercontent.com/u/896114?v=3","gravatar_id":"","url":"https://api.github.com/users/anton44eg","html_url":"https://github.com/anton44eg","followers_url":"https://api.github.com/users/anton44eg/followers","following_url":"https://api.github.com/users/anton44eg/following{/other_user}","gists_url":"https://api.github.com/users/anton44eg/gists{/gist_id}","starred_url":"https://api.github.com/users/anton44eg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton44eg/subscriptions","organizations_url":"https://api.github.com/users/anton44eg/orgs","repos_url":"https://api.github.com/users/anton44eg/repos","events_url":"https://api.github.com/users/anton44eg/events{/privacy}","received_events_url":"https://api.github.com/users/anton44eg/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T07:20:12Z","updated_at":"2016-05-18T07:20:12Z","body":"In my project I rewrite __init__\r\nNew signature \r\n`def __init__(self, url='http://127.0.0.1:8545', print_communication=True, privkey=None, sender=None)`\r\n\r\nBut it will brake backward compatability"}}