{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/71081786","id":71081786,"diff_hunk":"@@ -40,23 +93,19 @@\n  *\n  * Used as is as reference to a list.\n  *\n- * clist stores a pointer to the last element of a list.  That way, both\n- * appending to end of list and removing head can be done in constant time.\n- *\n- * Actual list objects should have a @c clist_node_t as member and then use\n- * the container_of() macro in list operations.\n- * See @ref thread_add_to_list() as example.\n  */\n typedef list_node_t clist_node_t;\n \n /**\n- * @brief inserts *new_node* into *list*\n+ * @brief Appends *new_node* at the end of *list\n+ *\n+ * @note Complexity: O(1)","path":"core/include/clist.h","position":96,"original_position":96,"commit_id":"dfc5a524e85871c2a644f53070ff8f9f84e70072","original_commit_id":"dfc5a524e85871c2a644f53070ff8f9f84e70072","user":{"login":"miri64","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"(to be in line with other, more complex mathematical terms)","created_at":"2016-07-17T12:44:00Z","updated_at":"2016-07-17T12:44:00Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/5629#discussion_r71081786","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/71081786"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/5629#discussion_r71081786"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629","id":77273388,"html_url":"https://github.com/RIOT-OS/RIOT/pull/5629","diff_url":"https://github.com/RIOT-OS/RIOT/pull/5629.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/5629.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5629","number":5629,"state":"open","locked":false,"title":"core: improve clist","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"body":"After working with redis for a while, I now find it's naming for list operations way more intuitive than what we had before, so I adapted our clist implementation accordingly.\r\n\r\nWhile at it, I added some functions and (IMHO) improved the docs quite a bit.\r\n\r\n*edit*\r\n\r\nWith the improvements from this PR, clist becomes a generally usable data structure that can be used wherever a list, stack (lifo) or queue (fifo) is needed, with O(1) operations for adding objects at head or tail and removing objects from head, in addition to O(n) operations for remove from tail, remove any object and find any object.","created_at":"2016-07-13T11:34:28Z","updated_at":"2016-07-17T12:44:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ba3c4e5570248b8cf35984461ec996a3a0bc5ac","assignee":{"login":"cgundogan","id":739129,"avatar_url":"https://avatars.githubusercontent.com/u/739129?v=3","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},"assignees":[{"login":"cgundogan","id":739129,"avatar_url":"https://avatars.githubusercontent.com/u/739129?v=3","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/14","html_url":"https://github.com/RIOT-OS/RIOT/milestones/Release%202016.07","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/14/labels","id":1657251,"number":14,"title":"Release 2016.07","description":"","creator":{"login":"miri64","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"open_issues":192,"closed_issues":154,"state":"open","created_at":"2016-03-21T13:28:08Z","updated_at":"2016-07-16T14:57:29Z","due_on":"2016-07-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5629/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/dfc5a524e85871c2a644f53070ff8f9f84e70072","head":{"label":"kaspar030:improve_clist","ref":"improve_clist","sha":"dfc5a524e85871c2a644f53070ff8f9f84e70072","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"repo":{"id":14115364,"name":"RIOT","full_name":"kaspar030/RIOT","owner":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaspar030/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/kaspar030/RIOT","forks_url":"https://api.github.com/repos/kaspar030/RIOT/forks","keys_url":"https://api.github.com/repos/kaspar030/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaspar030/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaspar030/RIOT/teams","hooks_url":"https://api.github.com/repos/kaspar030/RIOT/hooks","issue_events_url":"https://api.github.com/repos/kaspar030/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/kaspar030/RIOT/events","assignees_url":"https://api.github.com/repos/kaspar030/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/kaspar030/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/kaspar030/RIOT/tags","blobs_url":"https://api.github.com/repos/kaspar030/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaspar030/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaspar030/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaspar030/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaspar030/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/kaspar030/RIOT/languages","stargazers_url":"https://api.github.com/repos/kaspar030/RIOT/stargazers","contributors_url":"https://api.github.com/repos/kaspar030/RIOT/contributors","subscribers_url":"https://api.github.com/repos/kaspar030/RIOT/subscribers","subscription_url":"https://api.github.com/repos/kaspar030/RIOT/subscription","commits_url":"https://api.github.com/repos/kaspar030/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaspar030/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaspar030/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaspar030/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaspar030/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/kaspar030/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaspar030/RIOT/merges","archive_url":"https://api.github.com/repos/kaspar030/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaspar030/RIOT/downloads","issues_url":"https://api.github.com/repos/kaspar030/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/kaspar030/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/kaspar030/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/kaspar030/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaspar030/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/kaspar030/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/kaspar030/RIOT/deployments","created_at":"2013-11-04T16:04:12Z","updated_at":"2015-05-08T14:32:24Z","pushed_at":"2016-07-17T11:15:23Z","git_url":"git://github.com/kaspar030/RIOT.git","ssh_url":"git@github.com:kaspar030/RIOT.git","clone_url":"https://github.com/kaspar030/RIOT.git","svn_url":"https://github.com/kaspar030/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":28777,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"d0ab56ac825e9808b3214d2da8a87b344d63c8b7","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2016-07-17T10:45:31Z","pushed_at":"2016-07-17T11:15:24Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":95335,"stargazers_count":829,"watchers_count":829,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":583,"mirror_url":null,"open_issues_count":506,"forks":583,"open_issues":506,"watchers":829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/5629"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5629"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5629/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5629/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/dfc5a524e85871c2a644f53070ff8f9f84e70072"}}}}
{"actor":{"display_login":"miri64"}}