{"push_id":1366705585,"size":29,"distinct_size":1,"ref":"refs/heads/evaluate-refactor","head":"41526e2569ce25715e2422df7640a8d3c686d942","before":"856485c2e5b4eaf15755be1ef90de3843b1b7ee8","commits":[{"sha":"5bb306490d23e0ebcb9a9d54c07a703f634a4dc5","author":{"name":"a6802739","email":"c890cc9408328e85ef08e7a86efaf37ac7108554@gmail.com"},"message":"sql: remove the Executor reference from Session","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/5bb306490d23e0ebcb9a9d54c07a703f634a4dc5"},{"sha":"6926616e3f9c6756476760e562cfb07b51fb84f8","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"acceptance: clean up logging\n\nDo not create log directories unless asked.\nOn TeamCity, put the logs in the artifacts directory (this got lost\nduring the `pkg` transition). Noticed during triage of #10056.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/6926616e3f9c6756476760e562cfb07b51fb84f8"},{"sha":"f1bb557d87b7bec7e0dcc1f37d9597fc0c98b85b","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"docs: document RFC final comment period guidelines","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/f1bb557d87b7bec7e0dcc1f37d9597fc0c98b85b"},{"sha":"17ef6fc5967ad2faeead18906459f166f96d445f","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"Merge pull request #10180 from tschottdorf/acceptance\n\nacceptance: clean up logging","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/17ef6fc5967ad2faeead18906459f166f96d445f"},{"sha":"6bc7a174e75d96adf703779dbdd71c7453acb5cd","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"cli: remove shorthand special-case\n\nThis doesn't appear to do anything useful; `(*pflag.FlagSet).FooVar` is\njust sugar for `(*pflag.FlagSet).FooVarP` with an empty shorthand.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/6bc7a174e75d96adf703779dbdd71c7453acb5cd"},{"sha":"b9292755d364e8feafa5294938d65cee46f9559c","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"rpc: inline a function used in just one place\n\nThe other caller was removed in f74137a.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/b9292755d364e8feafa5294938d65cee46f9559c"},{"sha":"bfd87eb76837a6e70c57cf579fab03368dd0bf0b","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"acceptance: remove useless environment variables\n\nThese are used by libpq, and are not useful in the CLI tests.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/bfd87eb76837a6e70c57cf579fab03368dd0bf0b"},{"sha":"f1c8157f0dff8291da8cf23ed0d38fbca07c9456","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"RFCs: Mark views RFC as completed and update it for accuracy","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/f1c8157f0dff8291da8cf23ed0d38fbca07c9456"},{"sha":"ea018d50ec8b7699c8635e74c69e063b583972c1","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"cli: default host to \"localhost\" in client commands\n\nFixes an issue where client commands would fail to talk to secure\nservers due to a certificate verification error due to the hostname not\nbeing set on the client's tls.Config (deep in grpc).\n\nAlso cleans up some implicit test magic with respect to security flags.\n\nFixes #10119.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/ea018d50ec8b7699c8635e74c69e063b583972c1"},{"sha":"f4481b162b9836109000838051b63a3d1981de32","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"Merge pull request #10183 from a-robinson/viewsrfc\n\nRFCs: Mark views RFC as completed and update it for accuracy","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/f4481b162b9836109000838051b63a3d1981de32"},{"sha":"47dba3914b1593090a22cb3f004247f7cb19cb33","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"cli, storage: remove engine snapshotting debug feature\n\nIt's not used, races with engine stops, and uses the engines outside of the Server,\nwhich is a problem for the next commits.\n\nfixes #9815","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/47dba3914b1593090a22cb3f004247f7cb19cb33"},{"sha":"47ae3bf0eeedce8d55548e54b352cff7b2dc4f22","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"storage: remove Engine.Open()\n\nPrior to this commit, engine initialization and Open()ing were separate\noperations, mirroring the underlying interface provided by RocksDB.\nHowever keeping these operations separate suggest it is possible to open\nan engine multiple times, which we do not intend to support (it was\npartly suported only for memory-based unit tests, but you couldn't\nre-Open() an engine after Close()). So, instead, we combine\ninitialization with open, so that an Engine is always in the opened\nstate and this subtlety removed.\n\nWe also move towards explicit ownership of the engines by no longer\nhaving the factory schedule their destruction, and letting the caller do\nit.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/47ae3bf0eeedce8d55548e54b352cff7b2dc4f22"},{"sha":"92e7b65d2d0b38c2bda9496f735e33563dcbcade","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"server: unify the way engines are created\n\n... between tests and prod - handle everything in\nServerContext.InitStores(). So that a future commit can move that to the\nServer.Start().","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/92e7b65d2d0b38c2bda9496f735e33563dcbcade"},{"sha":"aa620d2d8edd889b5f007036e9b3a164a9e24646","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"server: take engines out or Server.Context\n\nThey didn't really belong there, as the Context is supposed to hold\nconfiguration, not this kind of objects. Moreover, the fact that they\nwere hanging from that Context made their ownership awkward.\nNow the Server takes ownership.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/aa620d2d8edd889b5f007036e9b3a164a9e24646"},{"sha":"67a48bf13a5db5fd978e52a413395465e3a1d2a9","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"server: move creation of Engines in Server.Start\n\nIt was unnecessary for it to happen earlier and it meant an extra\ntransfer of ownership.\n\nNow that Engines.Move() is not used in function calls, we change it\nto return by value.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/67a48bf13a5db5fd978e52a413395465e3a1d2a9"},{"sha":"174badd41d449c5fbf22ba13864416d59e7b53d1","author":{"name":"Andrei Matei","email":"10a93020cc4f038c14193f054a8660a80d6d683c@gmail.com"},"message":"Merge pull request #9845 from andreimatei/engine-close\n\nserver, storage: remove Open() from the Engine interface","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/174badd41d449c5fbf22ba13864416d59e7b53d1"},{"sha":"4c35c5d3fefc23e65b56bf6d47fcc6da784571db","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"Merge pull request #10181 from tamird/rfc-fcp\n\ndocs: document RFC final comment period guidelines","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/4c35c5d3fefc23e65b56bf6d47fcc6da784571db"},{"sha":"a7f6fcd6668ffc18784c0bbbf72e86ba37c9cf6c","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"sql: Add pg_constraint table to pg_catalog\n\nThe pg_constraint table provides access to check, primary key,\nunique, foreign key, and exclusion constraints on tables.","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/a7f6fcd6668ffc18784c0bbbf72e86ba37c9cf6c"},{"sha":"133c1f4a8152da44d55bf85e4c771c9d28a207fa","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"sql: Make sure spacing is consistent with virtual table schemas","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/133c1f4a8152da44d55bf85e4c771c9d28a207fa"},{"sha":"6256e071b28085dd212d75b7464ccf41fe98daff","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"sql: Improve documentation surrounding pg_catalog","distinct":false,"url":"https://api.github.com/repos/tschottdorf/cockroach/commits/6256e071b28085dd212d75b7464ccf41fe98daff"}]}
{"actor":{"display_login":"tschottdorf"}}