{"action":"created","comment":{"url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/comments/55166145","id":55166145,"diff_hunk":"@@ -344,6 +346,7 @@\n         },\n         \"largeMotor\": {\n             \"friendlyName\": \"Large Motor\",\n+            \"systemDeviceNameConvention\": \"motor{0}\",","path":"spec.json","position":168,"original_position":168,"commit_id":"a63978fe185466fb18e613da1020347d0c6dd1df","original_commit_id":"a63978fe185466fb18e613da1020347d0c6dd1df","user":{"login":"ddemidov","id":270503,"avatar_url":"https://avatars.githubusercontent.com/u/270503?v=3","gravatar_id":"","url":"https://api.github.com/users/ddemidov","html_url":"https://github.com/ddemidov","followers_url":"https://api.github.com/users/ddemidov/followers","following_url":"https://api.github.com/users/ddemidov/following{/other_user}","gists_url":"https://api.github.com/users/ddemidov/gists{/gist_id}","starred_url":"https://api.github.com/users/ddemidov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddemidov/subscriptions","organizations_url":"https://api.github.com/users/ddemidov/orgs","repos_url":"https://api.github.com/users/ddemidov/repos","events_url":"https://api.github.com/users/ddemidov/events{/privacy}","received_events_url":"https://api.github.com/users/ddemidov/received_events","type":"User","site_admin":false},"body":"Not really related to this PR, but looks like we have a mix of two mask styles: `*` and `{0}`. May be we need to choose one.","created_at":"2016-03-07T06:26:13Z","updated_at":"2016-03-07T06:26:13Z","html_url":"https://github.com/ev3dev/ev3dev-lang/pull/152#discussion_r55166145","pull_request_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/comments/55166145"},"html":{"href":"https://github.com/ev3dev/ev3dev-lang/pull/152#discussion_r55166145"},"pull_request":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152","id":61855518,"html_url":"https://github.com/ev3dev/ev3dev-lang/pull/152","diff_url":"https://github.com/ev3dev/ev3dev-lang/pull/152.diff","patch_url":"https://github.com/ev3dev/ev3dev-lang/pull/152.patch","issue_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/152","number":152,"state":"open","locked":false,"title":"Changes to support new tacho driver updates","user":{"login":"rhempel","id":5571620,"avatar_url":"https://avatars.githubusercontent.com/u/5571620?v=3","gravatar_id":"","url":"https://api.github.com/users/rhempel","html_url":"https://github.com/rhempel","followers_url":"https://api.github.com/users/rhempel/followers","following_url":"https://api.github.com/users/rhempel/following{/other_user}","gists_url":"https://api.github.com/users/rhempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rhempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhempel/subscriptions","organizations_url":"https://api.github.com/users/rhempel/orgs","repos_url":"https://api.github.com/users/rhempel/repos","events_url":"https://api.github.com/users/rhempel/events{/privacy}","received_events_url":"https://api.github.com/users/rhempel/received_events","type":"User","site_admin":false},"body":"- Eliminate speed_regulation_enabled attribute\r\n- Add max_speed attribute\r\n- Add count_per_m attribute for linear motors\r\n- Add fullt_travel_count attribute linear motors\r\n- Add subclasses for all known motor types\r\n- Change the speed_regulation_pid parameters to speed_pid\r\n\r\n- Add a paragraph to explain when attributes are handled.\r\n- See ev3dev/ev3dev#558\r\n\r\n- Fix line endings without commas","created_at":"2016-03-06T21:25:01Z","updated_at":"2016-03-07T06:26:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152/commits","review_comments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152/comments","review_comment_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/152/comments","statuses_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/statuses/a63978fe185466fb18e613da1020347d0c6dd1df","head":{"label":"ev3dev:feature-new-tacho-driver-attributes","ref":"feature-new-tacho-driver-attributes","sha":"a63978fe185466fb18e613da1020347d0c6dd1df","user":{"login":"ev3dev","id":6878323,"avatar_url":"https://avatars.githubusercontent.com/u/6878323?v=3","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"repo":{"id":18609918,"name":"ev3dev-lang","full_name":"ev3dev/ev3dev-lang","owner":{"login":"ev3dev","id":6878323,"avatar_url":"https://avatars.githubusercontent.com/u/6878323?v=3","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ev3dev/ev3dev-lang","description":"language bindings for ev3dev sensors, motors, LEDs, etc.","fork":false,"url":"https://api.github.com/repos/ev3dev/ev3dev-lang","forks_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/forks","keys_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/teams","hooks_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/hooks","issue_events_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/events{/number}","events_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/events","assignees_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/assignees{/user}","branches_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/branches{/branch}","tags_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/tags","blobs_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/languages","stargazers_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/stargazers","contributors_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/contributors","subscribers_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/subscribers","subscription_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/subscription","commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/contents/{+path}","compare_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/merges","archive_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/downloads","issues_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues{/number}","pulls_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/labels{/name}","releases_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/releases{/id}","deployments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/deployments","created_at":"2014-04-09T19:19:59Z","updated_at":"2016-02-07T17:54:12Z","pushed_at":"2016-03-06T21:51:05Z","git_url":"git://github.com/ev3dev/ev3dev-lang.git","ssh_url":"git@github.com:ev3dev/ev3dev-lang.git","clone_url":"https://github.com/ev3dev/ev3dev-lang.git","svn_url":"https://github.com/ev3dev/ev3dev-lang","homepage":"","size":1208,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":20,"forks":40,"open_issues":20,"watchers":38,"default_branch":"develop"}},"base":{"label":"ev3dev:develop","ref":"develop","sha":"fea721d8cb56ae6c111800f92c27f7f33f90d645","user":{"login":"ev3dev","id":6878323,"avatar_url":"https://avatars.githubusercontent.com/u/6878323?v=3","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"repo":{"id":18609918,"name":"ev3dev-lang","full_name":"ev3dev/ev3dev-lang","owner":{"login":"ev3dev","id":6878323,"avatar_url":"https://avatars.githubusercontent.com/u/6878323?v=3","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ev3dev/ev3dev-lang","description":"language bindings for ev3dev sensors, motors, LEDs, etc.","fork":false,"url":"https://api.github.com/repos/ev3dev/ev3dev-lang","forks_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/forks","keys_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/teams","hooks_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/hooks","issue_events_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/events{/number}","events_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/events","assignees_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/assignees{/user}","branches_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/branches{/branch}","tags_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/tags","blobs_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/languages","stargazers_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/stargazers","contributors_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/contributors","subscribers_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/subscribers","subscription_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/subscription","commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/contents/{+path}","compare_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/merges","archive_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/downloads","issues_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues{/number}","pulls_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/labels{/name}","releases_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/releases{/id}","deployments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang/deployments","created_at":"2014-04-09T19:19:59Z","updated_at":"2016-02-07T17:54:12Z","pushed_at":"2016-03-06T21:51:05Z","git_url":"git://github.com/ev3dev/ev3dev-lang.git","ssh_url":"git@github.com:ev3dev/ev3dev-lang.git","clone_url":"https://github.com/ev3dev/ev3dev-lang.git","svn_url":"https://github.com/ev3dev/ev3dev-lang","homepage":"","size":1208,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":20,"forks":40,"open_issues":20,"watchers":38,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152"},"html":{"href":"https://github.com/ev3dev/ev3dev-lang/pull/152"},"issue":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/152"},"comments":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang/statuses/a63978fe185466fb18e613da1020347d0c6dd1df"}}}}