{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/85800164","pull_request_review_id":6494428,"id":85800164,"diff_hunk":"@@ -0,0 +1,142 @@\n+// Copyright 2016 The etcd Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package integration\n+\n+import (\n+\t\"bufio\"\n+\t\"io\"\n+\t\"log\"\n+\t\"net/http\"\n+\t\"strconv\"\n+\t\"strings\"\n+\t\"testing\"\n+\n+\tpb \"github.com/coreos/etcd/etcdserver/etcdserverpb\"\n+\t\"github.com/prometheus/client_golang/prometheus\"\n+\n+\t\"golang.org/x/net/context\"\n+)\n+\n+func TestV3ClientMetrics(t *testing.T) {\n+\t// listen for all prometheus metrics\n+\tgo func() {\n+\t\thttp.Handle(\"/metrics\", prometheus.Handler())\n+\t\thttp.ListenAndServe(\":27989\", nil)","path":"integration/v3_metrics_test.go","position":36,"original_position":36,"commit_id":"e6b46057352c5c7be6fb438e0f391d3320737411","original_commit_id":"e6b46057352c5c7be6fb438e0f391d3320737411","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"we need to shutdown this http server after this test. or there will be go routine leak. you can create a listener first and close that listener after test.","created_at":"2016-10-31T18:17:35Z","updated_at":"2016-10-31T18:17:35Z","html_url":"https://github.com/coreos/etcd/pull/6748#discussion_r85800164","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/6748","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/85800164"},"html":{"href":"https://github.com/coreos/etcd/pull/6748#discussion_r85800164"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6748"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/6748","id":91302570,"html_url":"https://github.com/coreos/etcd/pull/6748","diff_url":"https://github.com/coreos/etcd/pull/6748.diff","patch_url":"https://github.com/coreos/etcd/pull/6748.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/6748","number":6748,"state":"open","locked":false,"title":"clientv3: added test for client metrics","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"body":"#6711\r\n","created_at":"2016-10-28T00:05:07Z","updated_at":"2016-10-31T18:17:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f61f05f9b74be4acfb0dcec3eb3ca80b4fa4a54","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/6748/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/6748/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/6748/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/e6b46057352c5c7be6fb438e0f391d3320737411","head":{"label":"sinsharat:client_metric_add_tests","ref":"client_metric_add_tests","sha":"e6b46057352c5c7be6fb438e0f391d3320737411","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"repo":{"id":67736780,"name":"etcd","full_name":"sinsharat/etcd","owner":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinsharat/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/sinsharat/etcd","forks_url":"https://api.github.com/repos/sinsharat/etcd/forks","keys_url":"https://api.github.com/repos/sinsharat/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinsharat/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinsharat/etcd/teams","hooks_url":"https://api.github.com/repos/sinsharat/etcd/hooks","issue_events_url":"https://api.github.com/repos/sinsharat/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/sinsharat/etcd/events","assignees_url":"https://api.github.com/repos/sinsharat/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/sinsharat/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/sinsharat/etcd/tags","blobs_url":"https://api.github.com/repos/sinsharat/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinsharat/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinsharat/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinsharat/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinsharat/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/sinsharat/etcd/languages","stargazers_url":"https://api.github.com/repos/sinsharat/etcd/stargazers","contributors_url":"https://api.github.com/repos/sinsharat/etcd/contributors","subscribers_url":"https://api.github.com/repos/sinsharat/etcd/subscribers","subscription_url":"https://api.github.com/repos/sinsharat/etcd/subscription","commits_url":"https://api.github.com/repos/sinsharat/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinsharat/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinsharat/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinsharat/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinsharat/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/sinsharat/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinsharat/etcd/merges","archive_url":"https://api.github.com/repos/sinsharat/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinsharat/etcd/downloads","issues_url":"https://api.github.com/repos/sinsharat/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/sinsharat/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/sinsharat/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/sinsharat/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinsharat/etcd/labels{/name}","releases_url":"https://api.github.com/repos/sinsharat/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/sinsharat/etcd/deployments","created_at":"2016-09-08T20:11:20Z","updated_at":"2016-10-24T18:39:31Z","pushed_at":"2016-10-28T20:17:52Z","git_url":"git://github.com/sinsharat/etcd.git","ssh_url":"git@github.com:sinsharat/etcd.git","clone_url":"https://github.com/sinsharat/etcd.git","svn_url":"https://github.com/sinsharat/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":25431,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"a0360a83c9915e2dcdce3e7160c722f6303dcf3a","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-10-31T15:05:20Z","pushed_at":"2016-10-31T17:43:18Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":33099,"stargazers_count":11263,"watchers_count":11263,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2006,"mirror_url":null,"open_issues_count":130,"forks":2006,"open_issues":130,"watchers":11263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6748"},"html":{"href":"https://github.com/coreos/etcd/pull/6748"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/6748"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/6748/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6748/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6748/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/e6b46057352c5c7be6fb438e0f391d3320737411"}}}}
{"actor":{"display_login":"xiang90"}}