{"action":"created","comment":{"url":"https://api.github.com/repos/irssi/irssi/pulls/comments/84583778","pull_request_review_id":5355183,"id":84583778,"diff_hunk":"@@ -565,6 +496,192 @@ static GIOChannel *irssi_ssl_get_iochannel(GIOChannel *handle, int port, SERVER_\n \treturn gchan;\n }\n \n+static void set_cipher_info(TLS_REC *tls, SSL *ssl)\n+{\n+\tg_assert(tls != NULL);\n+\tg_assert(ssl != NULL);\n+\n+\ttls_rec_set_protocol_version(tls, SSL_get_version(ssl));\n+\n+\ttls_rec_set_cipher(tls, SSL_CIPHER_get_name(SSL_get_current_cipher(ssl)));\n+\ttls_rec_set_cipher_size(tls, SSL_get_cipher_bits(ssl, NULL));\n+}\n+\n+static void set_pubkey_info(TLS_REC *tls, X509 *cert, unsigned char *cert_fingerprint, size_t cert_fingerprint_size, unsigned char *public_key_fingerprint, size_t public_key_fingerprint_size)\n+{\n+\tg_assert(tls != NULL);\n+\tg_assert(cert != NULL);","path":"src/core/network-openssl.c","position":162,"original_position":162,"commit_id":"fbf0bde0dc87f22fa82d622212154e4e36722857","original_commit_id":"fbf0bde0dc87f22fa82d622212154e4e36722857","user":{"login":"dequis","id":94108,"avatar_url":"https://avatars.githubusercontent.com/u/94108?v=3","gravatar_id":"","url":"https://api.github.com/users/dequis","html_url":"https://github.com/dequis","followers_url":"https://api.github.com/users/dequis/followers","following_url":"https://api.github.com/users/dequis/following{/other_user}","gists_url":"https://api.github.com/users/dequis/gists{/gist_id}","starred_url":"https://api.github.com/users/dequis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dequis/subscriptions","organizations_url":"https://api.github.com/users/dequis/orgs","repos_url":"https://api.github.com/users/dequis/repos","events_url":"https://api.github.com/users/dequis/events{/privacy}","received_events_url":"https://api.github.com/users/dequis/received_events","type":"User","site_admin":false},"body":"`s/g_assert/g_return_if_fail/`","created_at":"2016-10-22T19:34:16Z","updated_at":"2016-10-22T19:43:45Z","html_url":"https://github.com/irssi/irssi/pull/557#discussion_r84583778","pull_request_url":"https://api.github.com/repos/irssi/irssi/pulls/557","_links":{"self":{"href":"https://api.github.com/repos/irssi/irssi/pulls/comments/84583778"},"html":{"href":"https://github.com/irssi/irssi/pull/557#discussion_r84583778"},"pull_request":{"href":"https://api.github.com/repos/irssi/irssi/pulls/557"}}},"pull_request":{"url":"https://api.github.com/repos/irssi/irssi/pulls/557","id":89525727,"html_url":"https://github.com/irssi/irssi/pull/557","diff_url":"https://github.com/irssi/irssi/pull/557.diff","patch_url":"https://github.com/irssi/irssi/pull/557.patch","issue_url":"https://api.github.com/repos/irssi/irssi/issues/557","number":557,"state":"open","locked":false,"title":"TLS enhancements","user":{"login":"ahf","id":36521,"avatar_url":"https://avatars.githubusercontent.com/u/36521?v=3","gravatar_id":"","url":"https://api.github.com/users/ahf","html_url":"https://github.com/ahf","followers_url":"https://api.github.com/users/ahf/followers","following_url":"https://api.github.com/users/ahf/following{/other_user}","gists_url":"https://api.github.com/users/ahf/gists{/gist_id}","starred_url":"https://api.github.com/users/ahf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahf/subscriptions","organizations_url":"https://api.github.com/users/ahf/orgs","repos_url":"https://api.github.com/users/ahf/repos","events_url":"https://api.github.com/users/ahf/events{/privacy}","received_events_url":"https://api.github.com/users/ahf/received_events","type":"User","site_admin":false},"body":"For some reason Github decided not to update the original PR at https://github.com/irssi/irssi/pull/311 when I force pushed to the `ahf/tls` branch.\r\n\r\nThis is a cleaned up version of the initial patch-set from https://github.com/irssi/irssi/pull/311 with a few things changed:\r\n\r\n- We now support both pinning the x509 certificate and/or the subject public key information section of the certificate. This is especially useful for IRC networks that are adopting Lets Encrypt certificate where the public key remains the same for a long period, but the certificate is updated often.\r\n- I've fixed the changes that @dequis requested.\r\n\r\nLet's try to get this in for some proper testing.","created_at":"2016-10-16T13:23:53Z","updated_at":"2016-10-22T19:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e8a204d7317e146c50915f9aed3cf20bfe58416","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/irssi/irssi/pulls/557/commits","review_comments_url":"https://api.github.com/repos/irssi/irssi/pulls/557/comments","review_comment_url":"https://api.github.com/repos/irssi/irssi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/irssi/irssi/issues/557/comments","statuses_url":"https://api.github.com/repos/irssi/irssi/statuses/fbf0bde0dc87f22fa82d622212154e4e36722857","head":{"label":"irssi:ahf/tls-pr","ref":"ahf/tls-pr","sha":"fbf0bde0dc87f22fa82d622212154e4e36722857","user":{"login":"irssi","id":7750489,"avatar_url":"https://avatars.githubusercontent.com/u/7750489?v=3","gravatar_id":"","url":"https://api.github.com/users/irssi","html_url":"https://github.com/irssi","followers_url":"https://api.github.com/users/irssi/followers","following_url":"https://api.github.com/users/irssi/following{/other_user}","gists_url":"https://api.github.com/users/irssi/gists{/gist_id}","starred_url":"https://api.github.com/users/irssi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irssi/subscriptions","organizations_url":"https://api.github.com/users/irssi/orgs","repos_url":"https://api.github.com/users/irssi/repos","events_url":"https://api.github.com/users/irssi/events{/privacy}","received_events_url":"https://api.github.com/users/irssi/received_events","type":"Organization","site_admin":false},"repo":{"id":20344030,"name":"irssi","full_name":"irssi/irssi","owner":{"login":"irssi","id":7750489,"avatar_url":"https://avatars.githubusercontent.com/u/7750489?v=3","gravatar_id":"","url":"https://api.github.com/users/irssi","html_url":"https://github.com/irssi","followers_url":"https://api.github.com/users/irssi/followers","following_url":"https://api.github.com/users/irssi/following{/other_user}","gists_url":"https://api.github.com/users/irssi/gists{/gist_id}","starred_url":"https://api.github.com/users/irssi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irssi/subscriptions","organizations_url":"https://api.github.com/users/irssi/orgs","repos_url":"https://api.github.com/users/irssi/repos","events_url":"https://api.github.com/users/irssi/events{/privacy}","received_events_url":"https://api.github.com/users/irssi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/irssi/irssi","description":"The client of the future","fork":false,"url":"https://api.github.com/repos/irssi/irssi","forks_url":"https://api.github.com/repos/irssi/irssi/forks","keys_url":"https://api.github.com/repos/irssi/irssi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irssi/irssi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irssi/irssi/teams","hooks_url":"https://api.github.com/repos/irssi/irssi/hooks","issue_events_url":"https://api.github.com/repos/irssi/irssi/issues/events{/number}","events_url":"https://api.github.com/repos/irssi/irssi/events","assignees_url":"https://api.github.com/repos/irssi/irssi/assignees{/user}","branches_url":"https://api.github.com/repos/irssi/irssi/branches{/branch}","tags_url":"https://api.github.com/repos/irssi/irssi/tags","blobs_url":"https://api.github.com/repos/irssi/irssi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irssi/irssi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irssi/irssi/git/refs{/sha}","trees_url":"https://api.github.com/repos/irssi/irssi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irssi/irssi/statuses/{sha}","languages_url":"https://api.github.com/repos/irssi/irssi/languages","stargazers_url":"https://api.github.com/repos/irssi/irssi/stargazers","contributors_url":"https://api.github.com/repos/irssi/irssi/contributors","subscribers_url":"https://api.github.com/repos/irssi/irssi/subscribers","subscription_url":"https://api.github.com/repos/irssi/irssi/subscription","commits_url":"https://api.github.com/repos/irssi/irssi/commits{/sha}","git_commits_url":"https://api.github.com/repos/irssi/irssi/git/commits{/sha}","comments_url":"https://api.github.com/repos/irssi/irssi/comments{/number}","issue_comment_url":"https://api.github.com/repos/irssi/irssi/issues/comments{/number}","contents_url":"https://api.github.com/repos/irssi/irssi/contents/{+path}","compare_url":"https://api.github.com/repos/irssi/irssi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irssi/irssi/merges","archive_url":"https://api.github.com/repos/irssi/irssi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irssi/irssi/downloads","issues_url":"https://api.github.com/repos/irssi/irssi/issues{/number}","pulls_url":"https://api.github.com/repos/irssi/irssi/pulls{/number}","milestones_url":"https://api.github.com/repos/irssi/irssi/milestones{/number}","notifications_url":"https://api.github.com/repos/irssi/irssi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irssi/irssi/labels{/name}","releases_url":"https://api.github.com/repos/irssi/irssi/releases{/id}","deployments_url":"https://api.github.com/repos/irssi/irssi/deployments","created_at":"2014-05-30T22:11:55Z","updated_at":"2016-10-22T07:46:39Z","pushed_at":"2016-10-22T18:43:18Z","git_url":"git://github.com/irssi/irssi.git","ssh_url":"git@github.com:irssi/irssi.git","clone_url":"https://github.com/irssi/irssi.git","svn_url":"https://github.com/irssi/irssi","homepage":"irssi.org","size":9990,"stargazers_count":1289,"watchers_count":1289,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":74,"forks":168,"open_issues":74,"watchers":1289,"default_branch":"master"}},"base":{"label":"irssi:master","ref":"master","sha":"fb78787d4e2098612979b45df3237b67effbbc3a","user":{"login":"irssi","id":7750489,"avatar_url":"https://avatars.githubusercontent.com/u/7750489?v=3","gravatar_id":"","url":"https://api.github.com/users/irssi","html_url":"https://github.com/irssi","followers_url":"https://api.github.com/users/irssi/followers","following_url":"https://api.github.com/users/irssi/following{/other_user}","gists_url":"https://api.github.com/users/irssi/gists{/gist_id}","starred_url":"https://api.github.com/users/irssi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irssi/subscriptions","organizations_url":"https://api.github.com/users/irssi/orgs","repos_url":"https://api.github.com/users/irssi/repos","events_url":"https://api.github.com/users/irssi/events{/privacy}","received_events_url":"https://api.github.com/users/irssi/received_events","type":"Organization","site_admin":false},"repo":{"id":20344030,"name":"irssi","full_name":"irssi/irssi","owner":{"login":"irssi","id":7750489,"avatar_url":"https://avatars.githubusercontent.com/u/7750489?v=3","gravatar_id":"","url":"https://api.github.com/users/irssi","html_url":"https://github.com/irssi","followers_url":"https://api.github.com/users/irssi/followers","following_url":"https://api.github.com/users/irssi/following{/other_user}","gists_url":"https://api.github.com/users/irssi/gists{/gist_id}","starred_url":"https://api.github.com/users/irssi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irssi/subscriptions","organizations_url":"https://api.github.com/users/irssi/orgs","repos_url":"https://api.github.com/users/irssi/repos","events_url":"https://api.github.com/users/irssi/events{/privacy}","received_events_url":"https://api.github.com/users/irssi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/irssi/irssi","description":"The client of the future","fork":false,"url":"https://api.github.com/repos/irssi/irssi","forks_url":"https://api.github.com/repos/irssi/irssi/forks","keys_url":"https://api.github.com/repos/irssi/irssi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irssi/irssi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irssi/irssi/teams","hooks_url":"https://api.github.com/repos/irssi/irssi/hooks","issue_events_url":"https://api.github.com/repos/irssi/irssi/issues/events{/number}","events_url":"https://api.github.com/repos/irssi/irssi/events","assignees_url":"https://api.github.com/repos/irssi/irssi/assignees{/user}","branches_url":"https://api.github.com/repos/irssi/irssi/branches{/branch}","tags_url":"https://api.github.com/repos/irssi/irssi/tags","blobs_url":"https://api.github.com/repos/irssi/irssi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irssi/irssi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irssi/irssi/git/refs{/sha}","trees_url":"https://api.github.com/repos/irssi/irssi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irssi/irssi/statuses/{sha}","languages_url":"https://api.github.com/repos/irssi/irssi/languages","stargazers_url":"https://api.github.com/repos/irssi/irssi/stargazers","contributors_url":"https://api.github.com/repos/irssi/irssi/contributors","subscribers_url":"https://api.github.com/repos/irssi/irssi/subscribers","subscription_url":"https://api.github.com/repos/irssi/irssi/subscription","commits_url":"https://api.github.com/repos/irssi/irssi/commits{/sha}","git_commits_url":"https://api.github.com/repos/irssi/irssi/git/commits{/sha}","comments_url":"https://api.github.com/repos/irssi/irssi/comments{/number}","issue_comment_url":"https://api.github.com/repos/irssi/irssi/issues/comments{/number}","contents_url":"https://api.github.com/repos/irssi/irssi/contents/{+path}","compare_url":"https://api.github.com/repos/irssi/irssi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irssi/irssi/merges","archive_url":"https://api.github.com/repos/irssi/irssi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irssi/irssi/downloads","issues_url":"https://api.github.com/repos/irssi/irssi/issues{/number}","pulls_url":"https://api.github.com/repos/irssi/irssi/pulls{/number}","milestones_url":"https://api.github.com/repos/irssi/irssi/milestones{/number}","notifications_url":"https://api.github.com/repos/irssi/irssi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irssi/irssi/labels{/name}","releases_url":"https://api.github.com/repos/irssi/irssi/releases{/id}","deployments_url":"https://api.github.com/repos/irssi/irssi/deployments","created_at":"2014-05-30T22:11:55Z","updated_at":"2016-10-22T07:46:39Z","pushed_at":"2016-10-22T18:43:18Z","git_url":"git://github.com/irssi/irssi.git","ssh_url":"git@github.com:irssi/irssi.git","clone_url":"https://github.com/irssi/irssi.git","svn_url":"https://github.com/irssi/irssi","homepage":"irssi.org","size":9990,"stargazers_count":1289,"watchers_count":1289,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":74,"forks":168,"open_issues":74,"watchers":1289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/irssi/irssi/pulls/557"},"html":{"href":"https://github.com/irssi/irssi/pull/557"},"issue":{"href":"https://api.github.com/repos/irssi/irssi/issues/557"},"comments":{"href":"https://api.github.com/repos/irssi/irssi/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/irssi/irssi/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/irssi/irssi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/irssi/irssi/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/irssi/irssi/statuses/fbf0bde0dc87f22fa82d622212154e4e36722857"}}}}
{"actor":{"display_login":"dequis"}}