{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/kube-aws/issues/76","repository_url":"https://api.github.com/repos/coreos/kube-aws","labels_url":"https://api.github.com/repos/coreos/kube-aws/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/coreos/kube-aws/issues/76/comments","events_url":"https://api.github.com/repos/coreos/kube-aws/issues/76/events","html_url":"https://github.com/coreos/kube-aws/issues/76","id":190250240,"number":76,"title":"decrypt-tls-assets needlessly taking time","user":{"login":"mumoshu","id":22009,"avatar_url":"https://avatars.githubusercontent.com/u/22009?v=3","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-18T07:03:02Z","updated_at":"2016-11-18T07:55:22Z","closed_at":null,"body":"I've noticed that the current implementation of decrypt-tls-assets running `rkt run` multiple times seems to be resulting in adding up to 20 seconds(or possibly more?) in total run time.\r\n\r\nOne of the root causes seems to be that `rkt run` runs integrity check on a container image. Possibly related https://github.com/coreos/rkt/issues/1350\r\nWithout bypassing the check, we can make total run time shorter via running `rkt run` just once and loop over all the tls assets to decrypt inside the container.\r\n\r\nI've benchmarked three implementations from v1 to v3. v1 is the original implementation.\r\nhttps://gist.github.com/mumoshu/d1bb67ba48b975eccbec4bdf83559ade\r\n\r\nv2 looks good as it has a good balance of simplicity and speed.\r\n\r\nvanilla v0.9.1-rc.4 https://gist.github.com/mumoshu/8473065955a4602677fc2698c3720abf\r\nv0.9.1-rc.4 + v2 decrypt-tls-assets: https://gist.github.com/mumoshu/8bec0b49e7628ce5d929b467b1f70e15\r\n"},"comment":{"url":"https://api.github.com/repos/coreos/kube-aws/issues/comments/261470246","html_url":"https://github.com/coreos/kube-aws/issues/76#issuecomment-261470246","issue_url":"https://api.github.com/repos/coreos/kube-aws/issues/76","id":261470246,"user":{"login":"mumoshu","id":22009,"avatar_url":"https://avatars.githubusercontent.com/u/22009?v=3","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T07:55:22Z","updated_at":"2016-11-18T07:55:22Z","body":"@pieterlange @camilb FYI I'm going to work on this to make decrypt-tls-assets faster, at least 15 sec"}}
{"actor":{"display_login":"mumoshu"}}