{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/13037","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13037/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13037/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13037/events","html_url":"https://github.com/joomla/joomla-cms/pull/13037","id":191860534,"number":13037,"title":"[RFC] Add locked field to extensions table (and use it in core extensions)","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"id":198658453,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2016-11-27T13:08:39Z","updated_at":"2016-11-27T22:19:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13037","html_url":"https://github.com/joomla/joomla-cms/pull/13037","diff_url":"https://github.com/joomla/joomla-cms/pull/13037.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13037.patch"},"body":"### Summary of Changes\r\n\r\nThis adds a new column to extensions table named `locked`.\r\n\r\nThis column is a flag 1 or 0 to check if extension can be uninstalled.\r\n\r\nThis PR also marks all core extensions as uninstallable (ie locked), but most are unprotected now so they can be disabled.\r\n\r\nAs this is still RFC would aprecciate comments.\r\n\r\n### Testing Instructions\r\n\r\nFirst do a code review.\r\n\r\nTwo test needed: update, install\r\n\r\n- Update\r\n  - Apply patch\r\n  - Run the update query manually \r\n  - Check in extensions manage if protected extensions are protected and locked extensions are marked as so\r\n  - Check you cannot unninstall a locked extension but you can disable it if it's not protected.\r\n\r\n- Install\r\n  - Apply patch\r\n  - Delete configuration.php and install joomla as usual\r\n  - Check in extensions manage if protected extensions are protected and locked extensions are marked as so\r\n  - Check you cannot unninstall a locked extension but you can disable it if it's not protected.\r\n\r\nThis needs to be tested in all 3 db systems.\r\n\r\n### Documentation Changes Required\r\n\r\nNone."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/263151876","html_url":"https://github.com/joomla/joomla-cms/pull/13037#issuecomment-263151876","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13037","id":263151876,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T22:19:11Z","updated_at":"2016-11-27T22:19:11Z","body":"BTW why is templates locked to codemirror? can't it work without codemirror?"}}
{"actor":{"display_login":"andrepereiradasilva"}}