{"action":"created","issue":{"url":"https://api.github.com/repos/prebid/Prebid.js/issues/817","repository_url":"https://api.github.com/repos/prebid/Prebid.js","labels_url":"https://api.github.com/repos/prebid/Prebid.js/issues/817/labels{/name}","comments_url":"https://api.github.com/repos/prebid/Prebid.js/issues/817/comments","events_url":"https://api.github.com/repos/prebid/Prebid.js/issues/817/events","html_url":"https://github.com/prebid/Prebid.js/issues/817","id":190856978,"number":817,"title":"Make babel-plugin-* and babel-preset-* dependencies direct dependencies (as opposed to devDependencies)","user":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"labels":[{"id":410091542,"url":"https://api.github.com/repos/prebid/Prebid.js/labels/build%20process","name":"build process","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":{"login":"mkendall07","id":1870166,"avatar_url":"https://avatars.githubusercontent.com/u/1870166?v=3","gravatar_id":"","url":"https://api.github.com/users/mkendall07","html_url":"https://github.com/mkendall07","followers_url":"https://api.github.com/users/mkendall07/followers","following_url":"https://api.github.com/users/mkendall07/following{/other_user}","gists_url":"https://api.github.com/users/mkendall07/gists{/gist_id}","starred_url":"https://api.github.com/users/mkendall07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkendall07/subscriptions","organizations_url":"https://api.github.com/users/mkendall07/orgs","repos_url":"https://api.github.com/users/mkendall07/repos","events_url":"https://api.github.com/users/mkendall07/events{/privacy}","received_events_url":"https://api.github.com/users/mkendall07/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkendall07","id":1870166,"avatar_url":"https://avatars.githubusercontent.com/u/1870166?v=3","gravatar_id":"","url":"https://api.github.com/users/mkendall07","html_url":"https://github.com/mkendall07","followers_url":"https://api.github.com/users/mkendall07/followers","following_url":"https://api.github.com/users/mkendall07/following{/other_user}","gists_url":"https://api.github.com/users/mkendall07/gists{/gist_id}","starred_url":"https://api.github.com/users/mkendall07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkendall07/subscriptions","organizations_url":"https://api.github.com/users/mkendall07/orgs","repos_url":"https://api.github.com/users/mkendall07/repos","events_url":"https://api.github.com/users/mkendall07/events{/privacy}","received_events_url":"https://api.github.com/users/mkendall07/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-11-21T22:41:04Z","updated_at":"2016-12-22T15:36:44Z","closed_at":null,"body":"## Type of issue\r\n\r\nBug\r\n\r\n## Description\r\n\r\nMake `babel-plugin-*` and `babel-preset-*` dependencies direct dependencies (as opposed to devDependencies). These are used by `babel-register` when resolving the dependencies.\r\n\r\n> NOTE: This made me realize - you shouldn't include `es2015` preset in `.babelrc` thats being distributed in NPM package. Unless I am overlooking something (?), this will make webpack `babe-loader` pickup your config and negate the benefits of ES imports.\r\n\r\n## Steps to reproduce\r\n\r\n```bash\r\n$ npm install prebid.js\r\n$ cat <<'EOF' | > test.js\r\nrequire('babel-register')({\r\n  ignore: false;\r\n}};\r\nEOF\r\n$ node --require ./test.js -eval 'import \"prebid.js\"'\r\n```\r\n\r\nThe above will give an error:\r\n\r\n> ReferenceError: Unknown plugin \"transform-object-assign\" specified in \"/test/node_modules/prebid.js/.babelrc\" at 0, attempted to resolve relative to \"/test/node_modules/prebid.js\"\r\n\r\n### Expected results\r\n\r\nExpect `babel-register` to be able to resolve `prebid.js` transpilers."},"comment":{"url":"https://api.github.com/repos/prebid/Prebid.js/issues/comments/268824602","html_url":"https://github.com/prebid/Prebid.js/issues/817#issuecomment-268824602","issue_url":"https://api.github.com/repos/prebid/Prebid.js/issues/817","id":268824602,"user":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T15:36:44Z","updated_at":"2016-12-22T15:36:44Z","body":"> I would be interested in the type of changes you have made for optimization in the adapters.\r\n\r\nJust to be clear, we have not looked/ copied either the structure or the code of the adapters implementation in Prebid.js (except using it as a guide for Appnexus integration). Therefore, there is little in common.\r\n\r\nThere is not going to be much movement before the NY. Therefore, unlikely to share much before then. One thing that I can mention is that I have built a custom build system that inlines some of the SSP scripts into our codebase, which enables us to start bidding before loading their SDKs into the page. This alone has allowed us to start bidding around 300ms earlier than we were able before."}}
{"actor":{"display_login":"gajus"}}