{"action":"created","issue":{"url":"https://api.github.com/repos/xapi-project/blktap/issues/190","repository_url":"https://api.github.com/repos/xapi-project/blktap","labels_url":"https://api.github.com/repos/xapi-project/blktap/issues/190/labels{/name}","comments_url":"https://api.github.com/repos/xapi-project/blktap/issues/190/comments","events_url":"https://api.github.com/repos/xapi-project/blktap/issues/190/events","html_url":"https://github.com/xapi-project/blktap/pull/190","id":172669642,"number":190,"title":"CA-219462: Remove lock.h and lock.c","user":{"login":"kostaslamda","id":8862513,"avatar_url":"https://avatars.githubusercontent.com/u/8862513?v=3","gravatar_id":"","url":"https://api.github.com/users/kostaslamda","html_url":"https://github.com/kostaslamda","followers_url":"https://api.github.com/users/kostaslamda/followers","following_url":"https://api.github.com/users/kostaslamda/following{/other_user}","gists_url":"https://api.github.com/users/kostaslamda/gists{/gist_id}","starred_url":"https://api.github.com/users/kostaslamda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostaslamda/subscriptions","organizations_url":"https://api.github.com/users/kostaslamda/orgs","repos_url":"https://api.github.com/users/kostaslamda/repos","events_url":"https://api.github.com/users/kostaslamda/events{/privacy}","received_events_url":"https://api.github.com/users/kostaslamda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-23T10:56:56Z","updated_at":"2016-08-26T16:09:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xapi-project/blktap/pulls/190","html_url":"https://github.com/xapi-project/blktap/pull/190","diff_url":"https://github.com/xapi-project/blktap/pull/190.diff","patch_url":"https://github.com/xapi-project/blktap/pull/190.patch"},"body":"The public functions provided by lock.h are not being invoked\r\nin any place in the blktap code.\r\n\r\nThe standard blktap rpm (blktap-3.3.0.xs1098-xs7.0.1.x86_64.rpm at\r\nthe time of writing) provides the following shared objects:\r\n\r\n* libblktapctl.so.0.1.1\r\n* libvhdio-3.3.0.xs1098.so\r\n* libvhd.so.0.1.1\r\n\r\nThe devel blktap rpm (blktap-devel-3.3.0.xs1098-xs7.0.1.x86_64.rpm)\r\nprovides the following static libraries:\r\n\r\n* libblktapctl.a\r\n* libvhd.a\r\n\r\nNone of the above exports symbols for the functions in lock.h.\r\n\r\nTherefore, the files can be safely removed.\r\n\r\nSigned-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com>"},"comment":{"url":"https://api.github.com/repos/xapi-project/blktap/issues/comments/242778769","html_url":"https://github.com/xapi-project/blktap/pull/190#issuecomment-242778769","issue_url":"https://api.github.com/repos/xapi-project/blktap/issues/190","id":242778769,"user":{"login":"germanop","id":3437428,"avatar_url":"https://avatars.githubusercontent.com/u/3437428?v=3","gravatar_id":"","url":"https://api.github.com/users/germanop","html_url":"https://github.com/germanop","followers_url":"https://api.github.com/users/germanop/followers","following_url":"https://api.github.com/users/germanop/following{/other_user}","gists_url":"https://api.github.com/users/germanop/gists{/gist_id}","starred_url":"https://api.github.com/users/germanop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanop/subscriptions","organizations_url":"https://api.github.com/users/germanop/orgs","repos_url":"https://api.github.com/users/germanop/repos","events_url":"https://api.github.com/users/germanop/events{/privacy}","received_events_url":"https://api.github.com/users/germanop/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T16:09:56Z","updated_at":"2016-08-26T16:09:56Z","body":"Make sure the commit message reflects the fact that we are removing also an executable (lock-util) that has not been packaged for years (starting from commit 6449ea8).\r\nSo, in case we changed our mind, it would be easier to recover things"}}
{"actor":{"display_login":"germanop"}}