{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17316","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17316/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17316/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17316/events","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17316","id":159085364,"number":17316,"title":"Core/Scripts: npc_grandmother gossip text moved to DB","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-08T05:58:27Z","updated_at":"2016-06-08T18:20:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17316","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17316","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17316.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17316.patch"},"body":"**Changes proposed:**\r\n\r\nRemove one more hardcoded text line from core scripts.\r\nAlso add correct gossip to the npc_grandmother script.\r\n\r\nGossip changes in this script:\r\n- remove hardcoded text from core script\r\n- use existing npc_text IDs in gossip enum\r\n- add missing text rows to gossip_menu_option\r\n- use values from gossip_menu_option in enum\r\n\r\n**Target branch(es):** Both 3.3.5 and 6.x (src/server/scripts/EasternKingdoms/Karazhan/bosses_opera.cpp)\r\n\r\n**Issues addressed:** Updates [**Gossip migration from core scripts to SAI/DB ToDo List**](https://github.com/velinath/TrinityCore/issues/2) https://github.com/velinath/TrinityCore/issues/2\r\n\r\n**Tests performed**: (Does it build, tested in-game, etc)\r\nBuilds without issues in VS2013 Update 5 and here in travis-ci.\r\n\r\n**Known issues and TODO list:**\r\nNo known issues, the script behaviour is kept unhanged."},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/224682169","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17316#issuecomment-224682169","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17316","id":224682169,"user":{"login":"joschiwald","id":736792,"avatar_url":"https://avatars.githubusercontent.com/u/736792?v=3","gravatar_id":"","url":"https://api.github.com/users/joschiwald","html_url":"https://github.com/joschiwald","followers_url":"https://api.github.com/users/joschiwald/followers","following_url":"https://api.github.com/users/joschiwald/following{/other_user}","gists_url":"https://api.github.com/users/joschiwald/gists{/gist_id}","starred_url":"https://api.github.com/users/joschiwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joschiwald/subscriptions","organizations_url":"https://api.github.com/users/joschiwald/orgs","repos_url":"https://api.github.com/users/joschiwald/repos","events_url":"https://api.github.com/users/joschiwald/events{/privacy}","received_events_url":"https://api.github.com/users/joschiwald/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T18:20:59Z","updated_at":"2016-06-08T18:20:59Z","body":"remove stuff that is handled by db content"}}
{"actor":{"display_login":"joschiwald"}}