{"action":"created","issue":{"url":"https://api.github.com/repos/RackHD/RackHD/issues/270","repository_url":"https://api.github.com/repos/RackHD/RackHD","labels_url":"https://api.github.com/repos/RackHD/RackHD/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/RackHD/RackHD/issues/270/comments","events_url":"https://api.github.com/repos/RackHD/RackHD/issues/270/events","html_url":"https://github.com/RackHD/RackHD/issues/270","id":160134537,"number":270,"title":"The skip condition of Testing Graph.Discovery  is not  rigorous enough","user":{"login":"changev","id":5920192,"avatar_url":"https://avatars.githubusercontent.com/u/5920192?v=3","gravatar_id":"","url":"https://api.github.com/users/changev","html_url":"https://github.com/changev","followers_url":"https://api.github.com/users/changev/followers","following_url":"https://api.github.com/users/changev/following{/other_user}","gists_url":"https://api.github.com/users/changev/gists{/gist_id}","starred_url":"https://api.github.com/users/changev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/changev/subscriptions","organizations_url":"https://api.github.com/users/changev/orgs","repos_url":"https://api.github.com/users/changev/repos","events_url":"https://api.github.com/users/changev/events{/privacy}","received_events_url":"https://api.github.com/users/changev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RackHD/RackHD/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-06-14T09:21:29Z","updated_at":"2016-09-13T03:07:07Z","closed_at":null,"body":"Now when found data **not null** in \r\n```\r\n/api/1.1/nodes\r\n```\r\nthe Testing Graph.Discovery will be **skipped**. \r\n\r\nBut Graph.Discovery **not only** writes the nodes' data in mongo but also does other jobs like collecting catalogs, so finding data in **/api/1.1/nodes** doesn't mean  Graph.Discovery is over.\r\nAnother side ,if **not skipped**, the Graph.Discovery will monitor amqp info and **make sure** Graph.Discovery be finished.\r\nSo the judging conditions of the two flows are not symmetrical.\r\n\r\nThen in some cases, after rackhd service is running  and all the nodes are power on for test ,but  there are **too many** nodes so the power on spends more time hence before Test Graph.Discovery some nodes has been **imperfect** discovered(/api/1.1/nodes not null but catalogs null), as a result  Test Graph.Discovery will be skipped and next test cases will fail.\r\n\r\nSo i recommand enhancement of the skip condition in Testing Graph.Discovery."},"comment":{"url":"https://api.github.com/repos/RackHD/RackHD/issues/comments/246560530","html_url":"https://github.com/RackHD/RackHD/issues/270#issuecomment-246560530","issue_url":"https://api.github.com/repos/RackHD/RackHD/issues/270","id":246560530,"user":{"login":"changev","id":5920192,"avatar_url":"https://avatars.githubusercontent.com/u/5920192?v=3","gravatar_id":"","url":"https://api.github.com/users/changev","html_url":"https://github.com/changev","followers_url":"https://api.github.com/users/changev/followers","following_url":"https://api.github.com/users/changev/following{/other_user}","gists_url":"https://api.github.com/users/changev/gists{/gist_id}","starred_url":"https://api.github.com/users/changev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/changev/subscriptions","organizations_url":"https://api.github.com/users/changev/orgs","repos_url":"https://api.github.com/users/changev/repos","events_url":"https://api.github.com/users/changev/events{/privacy}","received_events_url":"https://api.github.com/users/changev/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T03:07:07Z","updated_at":"2016-09-13T03:07:07Z","body":"@jlongever I thinks that;s two things.\r\n1. Testing Graph.Discovery timed out after 20 minutes\r\n2. Testing Graph.Discovery just skip when ```curl localhost:port/api/2.0/nodes``` not empty, and with incomplete catalogs next cases will fail.\r\n\r\nAbout 1st problem, we've tracked it for a long time and find several possible reason:\r\n* Process Exited Abnormally without error in context, on-taskgraph and on-http process both have such thing happened. We consider this may be a foreman issue and I'm planning to compare the stability Foreman and PM2, intend to replace Foreman if necessary.\r\n* When vagrant up of after up for a while, mongo or rabbitmq service failed to start or stop abnormally.\r\nWe still can't find the root cause for this issue.\r\n\r\nThe 2nd problem is what I put forward here, and now I just have a workaround. And I fully expect your advice. Thanks."}}
{"actor":{"display_login":"changev"}}