{"action":"created","issue":{"url":"https://api.github.com/repos/webdriverio/webdriverio/issues/1461","repository_url":"https://api.github.com/repos/webdriverio/webdriverio","labels_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/1461/labels{/name}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/1461/comments","events_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/1461/events","html_url":"https://github.com/webdriverio/webdriverio/pull/1461","id":165970423,"number":1461,"title":"Await error screenshot before promise rejection","user":{"login":"just-boris","id":812240,"avatar_url":"https://avatars.githubusercontent.com/u/812240?v=3","gravatar_id":"","url":"https://api.github.com/users/just-boris","html_url":"https://github.com/just-boris","followers_url":"https://api.github.com/users/just-boris/followers","following_url":"https://api.github.com/users/just-boris/following{/other_user}","gists_url":"https://api.github.com/users/just-boris/gists{/gist_id}","starred_url":"https://api.github.com/users/just-boris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/just-boris/subscriptions","organizations_url":"https://api.github.com/users/just-boris/orgs","repos_url":"https://api.github.com/users/just-boris/repos","events_url":"https://api.github.com/users/just-boris/events{/privacy}","received_events_url":"https://api.github.com/users/just-boris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-17T10:21:31Z","updated_at":"2016-07-20T13:23:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/1461","html_url":"https://github.com/webdriverio/webdriverio/pull/1461","diff_url":"https://github.com/webdriverio/webdriverio/pull/1461.diff","patch_url":"https://github.com/webdriverio/webdriverio/pull/1461.patch"},"body":"## Proposed changes\r\n\r\nThis change is intended to fix https://github.com/webdriverio/wdio-allure-reporter/issues/24\r\nAfter that, screenshot command will be part of test workflow and will be finished before the test framework will get the failure.\r\n\r\nAlso, I am aware of https://github.com/webdriverio/webdriverio/pull/1441, which contains similar changes, but I think that this is not necessary to introduce new configuration option.\r\n\r\n## Types of changes\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n*Note*. According to currently existing  tests, there are nobody relied on current behavior. So, I consider this as bugfix to resolve a mess between `test:fail` and `runner:command` events.\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [CONTRIBUTING](/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n\r\n\r\n### Reviewers: @christian-bromann\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/webdriverio/webdriverio/issues/comments/233947358","html_url":"https://github.com/webdriverio/webdriverio/pull/1461#issuecomment-233947358","issue_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/1461","id":233947358,"user":{"login":"j0tunn","id":7701229,"avatar_url":"https://avatars.githubusercontent.com/u/7701229?v=3","gravatar_id":"","url":"https://api.github.com/users/j0tunn","html_url":"https://github.com/j0tunn","followers_url":"https://api.github.com/users/j0tunn/followers","following_url":"https://api.github.com/users/j0tunn/following{/other_user}","gists_url":"https://api.github.com/users/j0tunn/gists{/gist_id}","starred_url":"https://api.github.com/users/j0tunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0tunn/subscriptions","organizations_url":"https://api.github.com/users/j0tunn/orgs","repos_url":"https://api.github.com/users/j0tunn/repos","events_url":"https://api.github.com/users/j0tunn/events{/privacy}","received_events_url":"https://api.github.com/users/j0tunn/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T13:23:37Z","updated_at":"2016-07-20T13:23:37Z","body":"> You have also changed order of onReject call\r\n\r\nYep, it was necessary for correct work of my code."}}
{"actor":{"display_login":"j0tunn"}}