{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/199","repository_url":"https://api.github.com/repos/apache/cordova-plugin-camera","labels_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/199/labels{/name}","comments_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/199/comments","events_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/199/events","html_url":"https://github.com/apache/cordova-plugin-camera/pull/199","id":144308938,"number":199,"title":"Update plugin.xml","user":{"login":"mehmetcodes","id":11756350,"avatar_url":"https://avatars.githubusercontent.com/u/11756350?v=3","gravatar_id":"","url":"https://api.github.com/users/mehmetcodes","html_url":"https://github.com/mehmetcodes","followers_url":"https://api.github.com/users/mehmetcodes/followers","following_url":"https://api.github.com/users/mehmetcodes/following{/other_user}","gists_url":"https://api.github.com/users/mehmetcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/mehmetcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehmetcodes/subscriptions","organizations_url":"https://api.github.com/users/mehmetcodes/orgs","repos_url":"https://api.github.com/users/mehmetcodes/repos","events_url":"https://api.github.com/users/mehmetcodes/events{/privacy}","received_events_url":"https://api.github.com/users/mehmetcodes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-29T15:57:24Z","updated_at":"2016-03-29T20:55:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cordova-plugin-camera/pulls/199","html_url":"https://github.com/apache/cordova-plugin-camera/pull/199","diff_url":"https://github.com/apache/cordova-plugin-camera/pull/199.diff","patch_url":"https://github.com/apache/cordova-plugin-camera/pull/199.patch"},"body":"In principle Cordova should not use a permission where it is no longer relevant as it might leave things less secure.\r\n\r\nYou can see this documentation here http://developer.android.com/guide/topics/manifest/uses-permission-element.html\r\n\r\nNote the following in the documentation:\r\n\r\n============================================================================================\r\nandroid:maxSdkVersion\r\nThe highest API level at which this permission should be granted to your app. Setting this attribute is useful if the permission your app requires is no longer needed beginning at a certain API level.\r\nFor example, beginning with Android 4.4 (API level 19), it's no longer necessary for your app to request the WRITE_EXTERNAL_STORAGE permission when your app wants to write to its own application-specific directories on external storage (the directories provided by getExternalFilesDir()). However, the permission is required for API level 18 and lower. So you can declare that this permission is needed only up to API level 18 with a declaration such as this:\r\n\r\n<uses-permission\r\n     android:name=\"android.permission.WRITE_EXTERNAL_STORAGE\"\r\n     android:maxSdkVersion=\"18\" />\r\nThis way, beginning with API level 19, the system will no longer grant your app the WRITE_EXTERNAL_STORAGE permission.\r\n\r\nThis attribute was added in API level 19.\r\n=============================================================================================="},"comment":{"url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/comments/203098986","html_url":"https://github.com/apache/cordova-plugin-camera/pull/199#issuecomment-203098986","issue_url":"https://api.github.com/repos/apache/cordova-plugin-camera/issues/199","id":203098986,"user":{"login":"riknoll","id":13754588,"avatar_url":"https://avatars.githubusercontent.com/u/13754588?v=3","gravatar_id":"","url":"https://api.github.com/users/riknoll","html_url":"https://github.com/riknoll","followers_url":"https://api.github.com/users/riknoll/followers","following_url":"https://api.github.com/users/riknoll/following{/other_user}","gists_url":"https://api.github.com/users/riknoll/gists{/gist_id}","starred_url":"https://api.github.com/users/riknoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riknoll/subscriptions","organizations_url":"https://api.github.com/users/riknoll/orgs","repos_url":"https://api.github.com/users/riknoll/repos","events_url":"https://api.github.com/users/riknoll/events{/privacy}","received_events_url":"https://api.github.com/users/riknoll/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T20:55:42Z","updated_at":"2016-03-29T20:55:42Z","body":"I believe we do actually require that permission even in API level 19+. The current code requires access to the photos directory, which is outside of the application storage."}}