{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/13422","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/13422/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13422/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/13422/events","html_url":"https://github.com/edx/edx-platform/pull/13422","id":175683436,"number":13422,"title":"single form element per capa problem","user":{"login":"muhammad-ammar","id":6767924,"avatar_url":"https://avatars.githubusercontent.com/u/6767924?v=3","gravatar_id":"","url":"https://api.github.com/users/muhammad-ammar","html_url":"https://github.com/muhammad-ammar","followers_url":"https://api.github.com/users/muhammad-ammar/followers","following_url":"https://api.github.com/users/muhammad-ammar/following{/other_user}","gists_url":"https://api.github.com/users/muhammad-ammar/gists{/gist_id}","starred_url":"https://api.github.com/users/muhammad-ammar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhammad-ammar/subscriptions","organizations_url":"https://api.github.com/users/muhammad-ammar/orgs","repos_url":"https://api.github.com/users/muhammad-ammar/repos","events_url":"https://api.github.com/users/muhammad-ammar/events{/privacy}","received_events_url":"https://api.github.com/users/muhammad-ammar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-09-08T07:26:15Z","updated_at":"2016-10-06T19:26:29Z","closed_at":"2016-10-06T13:01:53Z","pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13422","html_url":"https://github.com/edx/edx-platform/pull/13422","diff_url":"https://github.com/edx/edx-platform/pull/13422.diff","patch_url":"https://github.com/edx/edx-platform/pull/13422.patch"},"body":"### [TNL-5402](https://openedx.atlassian.net/browse/TNL-5402)\r\n\r\n### [Sandbox](https://tnl4972.sandbox.edx.org)\r\n\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n\r\n- [x] Code review: @muzaffaryousaf  \r\n- [x] A11y review: @edx/edx-accessibility \r\n\r\n### Post-review\r\n- [x] Squash commits"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/252063779","html_url":"https://github.com/edx/edx-platform/pull/13422#issuecomment-252063779","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13422","id":252063779,"user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars.githubusercontent.com/u/484484?v=3","gravatar_id":"","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T19:26:29Z","updated_at":"2016-10-06T19:26:29Z","body":"@cptvitamin @muzaffaryousaf @muhammad-ammar This change makes me nervous. Because of it, I had to add type=\"button\" to button instances on our feature branch (see https://github.com/edx/edx-platform/pull/13052/commits/97c57891ade957e8ff8c7a002c3a004889473231), else pressing Enter caused the first focusable button to be triggered.\r\n\r\nWhile I have protected the buttons in our wrapper templates from being within a form element, I'm concerned that some of the funkier problem types might have buttons within their content, and they will now behave differently because they are within a form element. I also don't know what the other implications of being within a form element are.\r\n\r\nFYI @alisan617 and @staubina "}}
{"actor":{"display_login":"cahrens"}}