{"action":"created","issue":{"url":"https://api.github.com/repos/traildb/traildb/issues/63","repository_url":"https://api.github.com/repos/traildb/traildb","labels_url":"https://api.github.com/repos/traildb/traildb/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/traildb/traildb/issues/63/comments","events_url":"https://api.github.com/repos/traildb/traildb/issues/63/events","html_url":"https://github.com/traildb/traildb/issues/63","id":156741013,"number":63,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-25T12:43:18Z","updated_at":"2016-05-26T04:26:16Z","closed_at":null,"body":"I would like to point out that identifiers like \"[`__ARENA_H__`](https://github.com/traildb/traildb/blob/9dfdddb45e609b593d097c89b39a384549c65eb7/src/arena.h#L2)\" and \"[`__TRAILDB_H__`](https://github.com/traildb/traildb/blob/90b2de8793527642294e57aed8b7b62ece422249/src/traildb.h#L2)\" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 \"Do not use identifiers that are reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/traildb/traildb/issues/comments/221774434","html_url":"https://github.com/traildb/traildb/issues/63#issuecomment-221774434","issue_url":"https://api.github.com/repos/traildb/traildb/issues/63","id":221774434,"user":{"login":"whackashoe","id":855581,"avatar_url":"https://avatars.githubusercontent.com/u/855581?v=3","gravatar_id":"","url":"https://api.github.com/users/whackashoe","html_url":"https://github.com/whackashoe","followers_url":"https://api.github.com/users/whackashoe/followers","following_url":"https://api.github.com/users/whackashoe/following{/other_user}","gists_url":"https://api.github.com/users/whackashoe/gists{/gist_id}","starred_url":"https://api.github.com/users/whackashoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whackashoe/subscriptions","organizations_url":"https://api.github.com/users/whackashoe/orgs","repos_url":"https://api.github.com/users/whackashoe/repos","events_url":"https://api.github.com/users/whackashoe/events{/privacy}","received_events_url":"https://api.github.com/users/whackashoe/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T04:26:16Z","updated_at":"2016-05-26T04:26:16Z","body":"Well this is C not C++, but in [7.1.3 of the C standard](http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1124.pdf):\r\n\r\n`All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.`\r\n\r\nSo yeah, would be best if someone changed this. \r\n"}}
{"actor":{"display_login":"whackashoe"}}