{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/728","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/728/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/728/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/728/events","html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/728","id":160005495,"number":728,"title":"Flexible compat environment determination","user":{"login":"etanshaul","id":1735744,"avatar_url":"https://avatars.githubusercontent.com/u/1735744?v=3","gravatar_id":"","url":"https://api.github.com/users/etanshaul","html_url":"https://github.com/etanshaul","followers_url":"https://api.github.com/users/etanshaul/followers","following_url":"https://api.github.com/users/etanshaul/following{/other_user}","gists_url":"https://api.github.com/users/etanshaul/gists{/gist_id}","starred_url":"https://api.github.com/users/etanshaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etanshaul/subscriptions","organizations_url":"https://api.github.com/users/etanshaul/orgs","repos_url":"https://api.github.com/users/etanshaul/repos","events_url":"https://api.github.com/users/etanshaul/events{/privacy}","received_events_url":"https://api.github.com/users/etanshaul/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-13T17:40:20Z","updated_at":"2016-06-13T21:10:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/pulls/728","html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/728","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/728.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/728.patch"},"body":"fixes #720 \r\n\r\n@patflynn, @chanseokoh \r\n\r\nCurrently, the only use of determining this is for labeling in the UI."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/comments/225709685","html_url":"https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/728#issuecomment-225709685","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-intellij/issues/728","id":225709685,"user":{"login":"etanshaul","id":1735744,"avatar_url":"https://avatars.githubusercontent.com/u/1735744?v=3","gravatar_id":"","url":"https://api.github.com/users/etanshaul","html_url":"https://github.com/etanshaul","followers_url":"https://api.github.com/users/etanshaul/followers","following_url":"https://api.github.com/users/etanshaul/following{/other_user}","gists_url":"https://api.github.com/users/etanshaul/gists{/gist_id}","starred_url":"https://api.github.com/users/etanshaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etanshaul/subscriptions","organizations_url":"https://api.github.com/users/etanshaul/orgs","repos_url":"https://api.github.com/users/etanshaul/repos","events_url":"https://api.github.com/users/etanshaul/events{/privacy}","received_events_url":"https://api.github.com/users/etanshaul/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T21:10:31Z","updated_at":"2016-06-13T21:10:31Z","body":"Updated:\r\n- removed the 'compat' concept from the Environment enum, instead flex-compat projects are marked as targeting the flexible environment. It's now up to any client that needs to distinguish between flex and flex-compat to make the determination. For example, to determine if the deployment path should be a 'standard' deployment path it now looks like this:\r\n\r\n```\r\nif (targetEnvironment.isStandard()\r\n        || (targetEnvironment.isFlexible() && AppEngineUtil.isFlexCompat(project, source))) { ...\r\n```\r\n\r\nWith these changes, the UI labeling issue is resolved implicitly.\r\n\r\nI haven't moved the logic that loads the appengine-web.xml out of the static helper as I'm still looking into if this makes sense."}}
{"actor":{"display_login":"etanshaul"}}