{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/51013541","id":51013541,"diff_hunk":"@@ -134,17 +134,42 @@ mod imp {\n         Handler { _data: MAIN_ALTSTACK };\n     }\n \n-    pub unsafe fn make_handler() -> Handler {\n-        let alt_stack = mmap(ptr::null_mut(),\n-                             SIGSTKSZ,\n-                             PROT_READ | PROT_WRITE,\n-                             MAP_PRIVATE | MAP_ANON,\n-                             -1,\n-                             0);\n-        if alt_stack == MAP_FAILED {\n+    #[cfg(any(target_os = \"linux\",\n+              target_os = \"macos\",\n+              target_os = \"bitrig\",\n+              target_os = \"netbsd\",\n+              target_os = \"openbsd\"))]\n+    unsafe fn get_stack() -> *mut libc::c_void {","path":"src/libstd/sys/unix/stack_overflow.rs","position":17,"original_position":17,"commit_id":"ba49757072ba28d144ce88751894ca081c08559a","original_commit_id":"246529cc2f6af151fe51f472c394172cf0fc4235","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"@dhuseby you could also just insert `stack as *mut u8` and that should compile on all platforms (it's just that the source and destination type would be the same in both places).","created_at":"2016-01-27T16:57:38Z","updated_at":"2016-01-27T16:57:38Z","html_url":"https://github.com/rust-lang/rust/pull/31230#discussion_r51013541","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/31230","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/51013541"},"html":{"href":"https://github.com/rust-lang/rust/pull/31230#discussion_r51013541"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31230"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/31230","id":57301848,"html_url":"https://github.com/rust-lang/rust/pull/31230","diff_url":"https://github.com/rust-lang/rust/pull/31230.diff","patch_url":"https://github.com/rust-lang/rust/pull/31230.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/31230","number":31230,"state":"open","locked":false,"title":"Fixes #31229","user":{"login":"dhuseby","id":5017470,"avatar_url":"https://avatars.githubusercontent.com/u/5017470?v=3","gravatar_id":"","url":"https://api.github.com/users/dhuseby","html_url":"https://github.com/dhuseby","followers_url":"https://api.github.com/users/dhuseby/followers","following_url":"https://api.github.com/users/dhuseby/following{/other_user}","gists_url":"https://api.github.com/users/dhuseby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhuseby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhuseby/subscriptions","organizations_url":"https://api.github.com/users/dhuseby/orgs","repos_url":"https://api.github.com/users/dhuseby/repos","events_url":"https://api.github.com/users/dhuseby/events{/privacy}","received_events_url":"https://api.github.com/users/dhuseby/received_events","type":"User","site_admin":false},"body":"fixes the type mismatches breaking the build.","created_at":"2016-01-27T01:38:57Z","updated_at":"2016-01-27T16:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc3411fa33cdf7932b0056e2c549ab6c4698cbf8","assignee":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/31230/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/31230/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/31230/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ba49757072ba28d144ce88751894ca081c08559a","head":{"label":"dhuseby:fixing_bsd_builds","ref":"fixing_bsd_builds","sha":"ba49757072ba28d144ce88751894ca081c08559a","user":{"login":"dhuseby","id":5017470,"avatar_url":"https://avatars.githubusercontent.com/u/5017470?v=3","gravatar_id":"","url":"https://api.github.com/users/dhuseby","html_url":"https://github.com/dhuseby","followers_url":"https://api.github.com/users/dhuseby/followers","following_url":"https://api.github.com/users/dhuseby/following{/other_user}","gists_url":"https://api.github.com/users/dhuseby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhuseby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhuseby/subscriptions","organizations_url":"https://api.github.com/users/dhuseby/orgs","repos_url":"https://api.github.com/users/dhuseby/repos","events_url":"https://api.github.com/users/dhuseby/events{/privacy}","received_events_url":"https://api.github.com/users/dhuseby/received_events","type":"User","site_admin":false},"repo":{"id":26330875,"name":"rust","full_name":"dhuseby/rust","owner":{"login":"dhuseby","id":5017470,"avatar_url":"https://avatars.githubusercontent.com/u/5017470?v=3","gravatar_id":"","url":"https://api.github.com/users/dhuseby","html_url":"https://github.com/dhuseby","followers_url":"https://api.github.com/users/dhuseby/followers","following_url":"https://api.github.com/users/dhuseby/following{/other_user}","gists_url":"https://api.github.com/users/dhuseby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhuseby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhuseby/subscriptions","organizations_url":"https://api.github.com/users/dhuseby/orgs","repos_url":"https://api.github.com/users/dhuseby/repos","events_url":"https://api.github.com/users/dhuseby/events{/privacy}","received_events_url":"https://api.github.com/users/dhuseby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhuseby/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/dhuseby/rust","forks_url":"https://api.github.com/repos/dhuseby/rust/forks","keys_url":"https://api.github.com/repos/dhuseby/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhuseby/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhuseby/rust/teams","hooks_url":"https://api.github.com/repos/dhuseby/rust/hooks","issue_events_url":"https://api.github.com/repos/dhuseby/rust/issues/events{/number}","events_url":"https://api.github.com/repos/dhuseby/rust/events","assignees_url":"https://api.github.com/repos/dhuseby/rust/assignees{/user}","branches_url":"https://api.github.com/repos/dhuseby/rust/branches{/branch}","tags_url":"https://api.github.com/repos/dhuseby/rust/tags","blobs_url":"https://api.github.com/repos/dhuseby/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhuseby/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhuseby/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhuseby/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhuseby/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/dhuseby/rust/languages","stargazers_url":"https://api.github.com/repos/dhuseby/rust/stargazers","contributors_url":"https://api.github.com/repos/dhuseby/rust/contributors","subscribers_url":"https://api.github.com/repos/dhuseby/rust/subscribers","subscription_url":"https://api.github.com/repos/dhuseby/rust/subscription","commits_url":"https://api.github.com/repos/dhuseby/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhuseby/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhuseby/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhuseby/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhuseby/rust/contents/{+path}","compare_url":"https://api.github.com/repos/dhuseby/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhuseby/rust/merges","archive_url":"https://api.github.com/repos/dhuseby/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhuseby/rust/downloads","issues_url":"https://api.github.com/repos/dhuseby/rust/issues{/number}","pulls_url":"https://api.github.com/repos/dhuseby/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/dhuseby/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/dhuseby/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhuseby/rust/labels{/name}","releases_url":"https://api.github.com/repos/dhuseby/rust/releases{/id}","deployments_url":"https://api.github.com/repos/dhuseby/rust/deployments","created_at":"2014-11-07T17:49:00Z","updated_at":"2016-01-13T19:24:05Z","pushed_at":"2016-01-27T05:37:53Z","git_url":"git://github.com/dhuseby/rust.git","ssh_url":"git@github.com:dhuseby/rust.git","clone_url":"https://github.com/dhuseby/rust.git","svn_url":"https://github.com/dhuseby/rust","homepage":"http://www.rust-lang.org","size":275862,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"4b615854f00ba17ad704155e1d3196c17a6edb62","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-01-27T16:33:13Z","pushed_at":"2016-01-27T16:25:37Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":467639,"stargazers_count":15140,"watchers_count":15140,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2953,"mirror_url":null,"open_issues_count":2340,"forks":2953,"open_issues":2340,"watchers":15140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31230"},"html":{"href":"https://github.com/rust-lang/rust/pull/31230"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31230"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31230/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31230/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31230/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ba49757072ba28d144ce88751894ca081c08559a"}}}}