{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/components/pulls/comments/87162064","pull_request_review_id":7782607,"id":87162064,"diff_hunk":"@@ -0,0 +1,121 @@\n+// ============================================================================\n+//\n+// Copyright (C) 2006-2016 Talend Inc. - www.talend.com\n+//\n+// This source code is available under agreement available at\n+// %InstallDIR%\\features\\org.talend.rcp.branding.%PRODUCTNAME%\\%PRODUCTNAME%license.txt\n+//\n+// You should have received a copy of the agreement\n+// along with this program; if not, write to Talend SA\n+// 9 rue Pages 92150 Suresnes, France\n+//\n+// ============================================================================\n+\n+package org.talend.components.jms;\n+\n+import static org.talend.daikon.properties.presentation.Widget.widget;\n+import static org.talend.daikon.properties.property.PropertyFactory.*;\n+\n+import org.talend.components.common.SchemaProperties;\n+import org.talend.components.common.datastore.DatastoreProperties;\n+import org.talend.daikon.properties.PropertiesImpl;\n+import org.talend.daikon.properties.presentation.Form;\n+import org.talend.daikon.properties.presentation.Widget;\n+import org.talend.daikon.properties.property.Property;\n+import org.talend.daikon.properties.property.PropertyFactory;\n+\n+import java.util.Hashtable;\n+\n+//import javax.jms.ConnectionFactory;\n+//import javax.naming.Context;\n+//import javax.naming.InitialContext;\n+//import javax.naming.NamingException;\n+\n+public class JmsDatastoreProperties extends PropertiesImpl implements DatastoreProperties {\n+\n+    public enum JmsVersion{\n+        V_1_1,\n+        V_2_0\n+    }\n+\n+    public SchemaProperties main = new SchemaProperties(\"main\");\n+\n+    public JmsDatastoreProperties(String name) {\n+        super(name);\n+    }\n+\n+    // FIXME Default values are not working => There are just some examples for the user\n+\n+    public Property<JmsVersion> version = newEnum(\"version\", JmsVersion.class).setRequired();\n+\n+    public Property<String> contextProvider = PropertyFactory.newString(\"contextProvider\",\"com.tibco.tibjms.naming.TibjmsInitialContextFactory\").setRequired();\n+\n+    public Property<String> serverUrl = PropertyFactory.newString(\"serverUrl\",\"tibjmsnaming://localhost:7222\");\n+\n+    public Property<String> connectionFactoryName = PropertyFactory.newString(\"connectionFactoryName\",\"GenericConnectionFactory\");\n+\n+    public Property<Boolean> needUserIdentity = newBoolean(\"needUserIdentity\", false);\n+\n+    // TODO check if it is not better to do \"UserPasswordProperties\" class like for cassandra\n+    public Property<String> userName = PropertyFactory.newString(\"userName\",\"\");\n+\n+    public Property<String> userPassword = PropertyFactory.newString(\"userPassword\",\"\");\n+\n+    // Those advanced settings could be either in the datastore or in the dataset\n+    public Property<Boolean> useHttps = PropertyFactory.newBoolean(\"useHttps\",false);\n+\n+    public Property<String> httpsSettings = PropertyFactory.newString(\"httpsSettings\");\n+\n+    public Property<String> property = PropertyFactory.newString(\"property\",\"\");\n+\n+    public Property<String> value = PropertyFactory.newString(\"value\",\"\");\n+\n+\n+    @Override\n+    public void setupLayout() {\n+        super.setupLayout();\n+        Form mainForm = new Form(this, Form.MAIN);\n+        mainForm.addRow(main.getForm(Form.MAIN));\n+        mainForm.addRow(version);\n+        mainForm.addRow(contextProvider);\n+        mainForm.addRow(serverUrl);\n+        mainForm.addRow(connectionFactoryName);\n+        mainForm.addRow(userName);\n+        mainForm.addRow(userPassword);\n+\n+        Form advancedForm = new Form(this, Form.ADVANCED);\n+        advancedForm.addRow(useHttps);\n+        advancedForm.addRow(widget(httpsSettings).setWidgetType(Widget.NAME_SELECTION_AREA_WIDGET_TYPE));\n+        advancedForm.addRow(property);\n+        advancedForm.addRow(value);\n+    }\n+\n+    @Override\n+    public void refreshLayout(Form form) {\n+        super.refreshLayout(form);\n+        // Main properties\n+        if (form.getName().equals(Form.MAIN)) {\n+                form.getWidget(version.getName()).setVisible();\n+                form.getWidget(contextProvider.getName()).setVisible();\n+                form.getWidget(serverUrl.getName()).setVisible();\n+                if (needUserIdentity.getValue()) {","path":"components/components-jms/jms-definition/src/main/java/org/talend/components/jms/JmsDatastoreProperties.java","position":101,"original_position":101,"commit_id":"914906a7d87cc7503313f30389590bcae65699dc","original_commit_id":"914906a7d87cc7503313f30389590bcae65699dc","user":{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars.githubusercontent.com/u/7734020?v=3","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false},"body":"need a method named afterNeedUserIdentity to trigger","created_at":"2016-11-09T10:00:52Z","updated_at":"2016-11-09T10:00:52Z","html_url":"https://github.com/Talend/components/pull/292#discussion_r87162064","pull_request_url":"https://api.github.com/repos/Talend/components/pulls/292","_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/comments/87162064"},"html":{"href":"https://github.com/Talend/components/pull/292#discussion_r87162064"},"pull_request":{"href":"https://api.github.com/repos/Talend/components/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/components/pulls/292","id":92929068,"html_url":"https://github.com/Talend/components/pull/292","diff_url":"https://github.com/Talend/components/pull/292.diff","patch_url":"https://github.com/Talend/components/pull/292.patch","issue_url":"https://api.github.com/repos/Talend/components/issues/292","number":292,"state":"open","locked":false,"title":"feat(JMS): add JMS family (properties only)","user":{"login":"RyanSkraba","id":7744819,"avatar_url":"https://avatars.githubusercontent.com/u/7744819?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanSkraba","html_url":"https://github.com/RyanSkraba","followers_url":"https://api.github.com/users/RyanSkraba/followers","following_url":"https://api.github.com/users/RyanSkraba/following{/other_user}","gists_url":"https://api.github.com/users/RyanSkraba/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSkraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSkraba/subscriptions","organizations_url":"https://api.github.com/users/RyanSkraba/orgs","repos_url":"https://api.github.com/users/RyanSkraba/repos","events_url":"https://api.github.com/users/RyanSkraba/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSkraba/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [X] The commit message follows Talend standard\r\n- [X] Tests for the changes have been added (for bug fixes / features)\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nThere is no component available for the JMS technology.\r\n\r\n**What is the new behavior?**\r\n\r\nStarting point for the design-time properties of the JMS datastore, dataset and input/output components.\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [ ] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\nNobody depends on this component yet.\r\n\r\n**Other information**:\r\n\r\nThe runtime work is in progress, so the contents of the jsm-runtime_1_1 module are works in progress -- we'd really like to get a review on the jms-definition at this point and include it in the REST API to be consumed by the UI (for design-only at this point).\r\n","created_at":"2016-11-09T09:29:43Z","updated_at":"2016-11-09T10:29:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0f5da0b9a7f2abd42ffe62c744e723d16cb2c19","assignee":{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars.githubusercontent.com/u/7734020?v=3","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false},"assignees":[{"login":"bchen-talend","id":7734020,"avatar_url":"https://avatars.githubusercontent.com/u/7734020?v=3","gravatar_id":"","url":"https://api.github.com/users/bchen-talend","html_url":"https://github.com/bchen-talend","followers_url":"https://api.github.com/users/bchen-talend/followers","following_url":"https://api.github.com/users/bchen-talend/following{/other_user}","gists_url":"https://api.github.com/users/bchen-talend/gists{/gist_id}","starred_url":"https://api.github.com/users/bchen-talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchen-talend/subscriptions","organizations_url":"https://api.github.com/users/bchen-talend/orgs","repos_url":"https://api.github.com/users/bchen-talend/repos","events_url":"https://api.github.com/users/bchen-talend/events{/privacy}","received_events_url":"https://api.github.com/users/bchen-talend/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/components/pulls/292/commits","review_comments_url":"https://api.github.com/repos/Talend/components/pulls/292/comments","review_comment_url":"https://api.github.com/repos/Talend/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/components/issues/292/comments","statuses_url":"https://api.github.com/repos/Talend/components/statuses/914906a7d87cc7503313f30389590bcae65699dc","head":{"label":"Talend:components-jms","ref":"components-jms","sha":"914906a7d87cc7503313f30389590bcae65699dc","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2016-10-24T07:22:28Z","pushed_at":"2016-11-09T09:29:43Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":6907,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":14,"forks":19,"open_issues":14,"watchers":6,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"7ba81e79561bd5fcd9d278858cdf2e24f9ff278b","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":39855061,"name":"components","full_name":"Talend/components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/components","description":"Talend component infrastructure and public components","fork":false,"url":"https://api.github.com/repos/Talend/components","forks_url":"https://api.github.com/repos/Talend/components/forks","keys_url":"https://api.github.com/repos/Talend/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/components/teams","hooks_url":"https://api.github.com/repos/Talend/components/hooks","issue_events_url":"https://api.github.com/repos/Talend/components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/components/events","assignees_url":"https://api.github.com/repos/Talend/components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/components/tags","blobs_url":"https://api.github.com/repos/Talend/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/components/languages","stargazers_url":"https://api.github.com/repos/Talend/components/stargazers","contributors_url":"https://api.github.com/repos/Talend/components/contributors","subscribers_url":"https://api.github.com/repos/Talend/components/subscribers","subscription_url":"https://api.github.com/repos/Talend/components/subscription","commits_url":"https://api.github.com/repos/Talend/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/components/merges","archive_url":"https://api.github.com/repos/Talend/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/components/downloads","issues_url":"https://api.github.com/repos/Talend/components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/components/deployments","created_at":"2015-07-28T20:02:50Z","updated_at":"2016-10-24T07:22:28Z","pushed_at":"2016-11-09T09:29:43Z","git_url":"git://github.com/Talend/components.git","ssh_url":"git@github.com:Talend/components.git","clone_url":"https://github.com/Talend/components.git","svn_url":"https://github.com/Talend/components","homepage":null,"size":6907,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":14,"forks":19,"open_issues":14,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/components/pulls/292"},"html":{"href":"https://github.com/Talend/components/pull/292"},"issue":{"href":"https://api.github.com/repos/Talend/components/issues/292"},"comments":{"href":"https://api.github.com/repos/Talend/components/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/components/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/components/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/components/statuses/914906a7d87cc7503313f30389590bcae65699dc"}}}}
{"actor":{"display_login":"bchen-talend"}}