{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/91041275","pull_request_review_id":11550660,"id":91041275,"diff_hunk":"@@ -200,9 +220,10 @@ public void flush() throws IOException\n \n     public void close() throws IOException\n     {\n-        IOUtils.closeAll( partitions );\n-        partitions.clear();\n         open = false;\n+        List<AbstractIndexPartition> partitionsCopy = new ArrayList<>( partitions );","path":"community/lucene-index/src/main/java/org/neo4j/kernel/api/impl/index/AbstractLuceneIndex.java","position":65,"original_position":65,"commit_id":"48cedb6b5d2d2b386ab00575d9fae0eb8a95cd8c","original_commit_id":"48cedb6b5d2d2b386ab00575d9fae0eb8a95cd8c","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"i do not think it's needed since index is already closed at this point and we can operate on partitions itself right?","created_at":"2016-12-06T09:40:57Z","updated_at":"2016-12-06T10:02:49Z","html_url":"https://github.com/neo4j/neo4j/pull/8453#discussion_r91041275","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8453","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/91041275"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8453#discussion_r91041275"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8453"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/8453","id":95698574,"html_url":"https://github.com/neo4j/neo4j/pull/8453","diff_url":"https://github.com/neo4j/neo4j/pull/8453.diff","patch_url":"https://github.com/neo4j/neo4j/pull/8453.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/8453","number":8453,"state":"open","locked":false,"title":"Index optimisations","user":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars.githubusercontent.com/u/7993?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"body":"```\r\n       High selectivity read    Low selectivity read     Medium selectivity read   Write\r\n3.0:   0.581 ± 0.056  ops/ms    0.027 ± 0.003  ops/ms    0.143 ± 0.013  ops/ms      66.295 ± 2.103  ops/ms\r\n3.1:   0.497 ± 0.073  ops/ms    0.022 ± 0.002  ops/ms    0.120 ± 0.011  ops/ms     105.256 ± 10.828 ops/ms\r\nNow:   1.512 ± 0.137  ops/ms    0.030 ± 0.002  ops/ms    0.174 ± 0.019  ops/ms     104.168 ± 1.766  ops/ms\r\n```\r\n\r\nI think the removal of the `partition` lock is safe because of the use of a `CopyOnWriteArrayList`, plus I added extra synchronisation in the places that need atomicity at a higher level, but please check the correctness thoroughly.\r\n\r\n**Note:** This should not be merged until _after_ 3.1 GA.","created_at":"2016-11-29T14:07:46Z","updated_at":"2016-12-06T10:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80ed6508af5a304ff9e3660a6eb65131d6f079ea","assignee":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8453/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8453/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/8453/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/48cedb6b5d2d2b386ab00575d9fae0eb8a95cd8c","head":{"label":"chrisvest:3.1-index-opts","ref":"3.1-index-opts","sha":"48cedb6b5d2d2b386ab00575d9fae0eb8a95cd8c","user":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars.githubusercontent.com/u/7993?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"repo":{"id":12541371,"name":"neo4j","full_name":"chrisvest/neo4j","owner":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars.githubusercontent.com/u/7993?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisvest/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/chrisvest/neo4j","forks_url":"https://api.github.com/repos/chrisvest/neo4j/forks","keys_url":"https://api.github.com/repos/chrisvest/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisvest/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisvest/neo4j/teams","hooks_url":"https://api.github.com/repos/chrisvest/neo4j/hooks","issue_events_url":"https://api.github.com/repos/chrisvest/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/chrisvest/neo4j/events","assignees_url":"https://api.github.com/repos/chrisvest/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/chrisvest/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/chrisvest/neo4j/tags","blobs_url":"https://api.github.com/repos/chrisvest/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisvest/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisvest/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisvest/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisvest/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisvest/neo4j/languages","stargazers_url":"https://api.github.com/repos/chrisvest/neo4j/stargazers","contributors_url":"https://api.github.com/repos/chrisvest/neo4j/contributors","subscribers_url":"https://api.github.com/repos/chrisvest/neo4j/subscribers","subscription_url":"https://api.github.com/repos/chrisvest/neo4j/subscription","commits_url":"https://api.github.com/repos/chrisvest/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisvest/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisvest/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisvest/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisvest/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/chrisvest/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisvest/neo4j/merges","archive_url":"https://api.github.com/repos/chrisvest/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisvest/neo4j/downloads","issues_url":"https://api.github.com/repos/chrisvest/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/chrisvest/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisvest/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisvest/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisvest/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/chrisvest/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/chrisvest/neo4j/deployments","created_at":"2013-09-02T14:05:14Z","updated_at":"2015-03-27T13:31:38Z","pushed_at":"2016-12-06T09:36:28Z","git_url":"git://github.com/chrisvest/neo4j.git","ssh_url":"git@github.com:chrisvest/neo4j.git","clone_url":"https://github.com/chrisvest/neo4j.git","svn_url":"https://github.com/chrisvest/neo4j","homepage":"http://neo4j.org","size":315585,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:3.1","ref":"3.1","sha":"9e8717195c7c42f869aa8e74507b6a30fb203357","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-12-06T07:12:13Z","pushed_at":"2016-12-06T09:50:24Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":388340,"stargazers_count":3259,"watchers_count":3259,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1032,"mirror_url":null,"open_issues_count":412,"forks":1032,"open_issues":412,"watchers":3259,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8453"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8453"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8453"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8453/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8453/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8453/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/48cedb6b5d2d2b386ab00575d9fae0eb8a95cd8c"}}}}
{"actor":{"display_login":"MishaDemianenko"}}