{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11379","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11379/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11379/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11379/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11379","id":177901293,"number":11379,"title":"Generalize config management mixin for region and zone","user":{"login":"carbonin","id":12697904,"avatar_url":"https://avatars.githubusercontent.com/u/12697904?v=3","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/core","name":"core","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-09-19T21:20:57Z","updated_at":"2016-09-19T22:21:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11379","html_url":"https://github.com/ManageIQ/manageiq/pull/11379","diff_url":"https://github.com/ManageIQ/manageiq/pull/11379.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11379.patch"},"body":"This PR extracts the configuration handling from https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_server/configuration_management.rb and makes it usable for other resources that are currently usable as settings resources (`Zone` and `MiqRegion`).\r\n\r\nThis is a follow up to https://github.com/ManageIQ/manageiq/pull/11304 which added yum repo names as a config parameter attached to a region resource, rather than being in a database column.\r\nSpecifically, this PR is required to address the feedback [here](https://github.com/ManageIQ/manageiq/pull/11304#r79164661).\r\n\r\nUsing the `#add_settings_for_resource` method will both refresh the settings for the current worker as well as enqueue messages for all other servers that could be affected by the change.\r\n\r\n@Fryguy please review\r\n@miq-bot add_label core, enhancement"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/248145694","html_url":"https://github.com/ManageIQ/manageiq/pull/11379#issuecomment-248145694","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11379","id":248145694,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T22:21:53Z","updated_at":"2016-09-19T22:21:53Z","body":"<rubocop />Checked commits https://github.com/carbonin/manageiq/compare/422a8f075a5cb2b738d3ba1962be15373b1b8115~...b4ef3f167777b7873c9ddb7e87ff16e29eddf3f5 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n9 files checked, 1 offense detected\n\n**lib/vmdb/loggers.rb**\n- [ ] :exclamation: - [Line 78](https://github.com/carbonin/manageiq/blob/b4ef3f167777b7873c9ddb7e87ff16e29eddf3f5/lib/vmdb/loggers.rb#L78), Col 24 - [Style/ClassCheck](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/ClassCheck) - Prefer `Object#kind_of?` over `Object#is_a?`.\n"}}
{"actor":{"display_login":"miq-bot"}}