{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/endlessm/chromium-browser/pulls/43","id":62754998,"html_url":"https://github.com/endlessm/chromium-browser/pull/43","diff_url":"https://github.com/endlessm/chromium-browser/pull/43.diff","patch_url":"https://github.com/endlessm/chromium-browser/pull/43.patch","issue_url":"https://api.github.com/repos/endlessm/chromium-browser/issues/43","number":43,"state":"closed","locked":false,"title":"Consider the provisional document loader when overriding the User Agent","user":{"login":"mariospr","id":2197259,"avatar_url":"https://avatars.githubusercontent.com/u/2197259?v=3","gravatar_id":"","url":"https://api.github.com/users/mariospr","html_url":"https://github.com/mariospr","followers_url":"https://api.github.com/users/mariospr/followers","following_url":"https://api.github.com/users/mariospr/following{/other_user}","gists_url":"https://api.github.com/users/mariospr/gists{/gist_id}","starred_url":"https://api.github.com/users/mariospr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariospr/subscriptions","organizations_url":"https://api.github.com/users/mariospr/orgs","repos_url":"https://api.github.com/users/mariospr/repos","events_url":"https://api.github.com/users/mariospr/events{/privacy}","received_events_url":"https://api.github.com/users/mariospr/received_events","type":"User","site_admin":false},"body":"In some cases (e.g. calendar.google.com), waiting for the document loader\r\nto reach the \"committed\" state to decide whether to override the User Agent\r\nstring might be too late, as a redirection to a new URL address might have\r\nalready happened making the override useless in the end.\r\n\r\nTo workaround this problem, we don't assume that the document has a valid\r\nURL at the time we decide whether to override the UA. Instead, we check\r\nthe URL from the original request from either the provisional document\r\nloader (if it exists) or from the regular one, in that precise order.\r\n\r\nhttps://phabricator.endlessm.com/T6093","created_at":"2016-03-14T14:22:07Z","updated_at":"2016-03-14T22:08:04Z","closed_at":"2016-03-14T22:08:04Z","merged_at":"2016-03-14T22:08:04Z","merge_commit_sha":"bda579bc48e3e30a6c1bb36eaa621ae451098722","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/chromium-browser/pulls/43/commits","review_comments_url":"https://api.github.com/repos/endlessm/chromium-browser/pulls/43/comments","review_comment_url":"https://api.github.com/repos/endlessm/chromium-browser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/chromium-browser/issues/43/comments","statuses_url":"https://api.github.com/repos/endlessm/chromium-browser/statuses/ff85ddfa11524920f3f03e0dcb9e1334515301a3","head":{"label":"endlessm:T6093","ref":"T6093","sha":"ff85ddfa11524920f3f03e0dcb9e1334515301a3","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":38511569,"name":"chromium-browser","full_name":"endlessm/chromium-browser","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/chromium-browser","description":"Fork of chromium-browser with endless customizations","fork":false,"url":"https://api.github.com/repos/endlessm/chromium-browser","forks_url":"https://api.github.com/repos/endlessm/chromium-browser/forks","keys_url":"https://api.github.com/repos/endlessm/chromium-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/chromium-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/chromium-browser/teams","hooks_url":"https://api.github.com/repos/endlessm/chromium-browser/hooks","issue_events_url":"https://api.github.com/repos/endlessm/chromium-browser/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/chromium-browser/events","assignees_url":"https://api.github.com/repos/endlessm/chromium-browser/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/chromium-browser/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/chromium-browser/tags","blobs_url":"https://api.github.com/repos/endlessm/chromium-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/chromium-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/chromium-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/chromium-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/chromium-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/chromium-browser/languages","stargazers_url":"https://api.github.com/repos/endlessm/chromium-browser/stargazers","contributors_url":"https://api.github.com/repos/endlessm/chromium-browser/contributors","subscribers_url":"https://api.github.com/repos/endlessm/chromium-browser/subscribers","subscription_url":"https://api.github.com/repos/endlessm/chromium-browser/subscription","commits_url":"https://api.github.com/repos/endlessm/chromium-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/chromium-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/chromium-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/chromium-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/chromium-browser/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/chromium-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/chromium-browser/merges","archive_url":"https://api.github.com/repos/endlessm/chromium-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/chromium-browser/downloads","issues_url":"https://api.github.com/repos/endlessm/chromium-browser/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/chromium-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/chromium-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/chromium-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/chromium-browser/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/chromium-browser/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/chromium-browser/deployments","created_at":"2015-07-03T21:40:44Z","updated_at":"2016-01-12T17:57:30Z","pushed_at":"2016-03-14T22:08:04Z","git_url":"git://github.com/endlessm/chromium-browser.git","ssh_url":"git@github.com:endlessm/chromium-browser.git","clone_url":"https://github.com/endlessm/chromium-browser.git","svn_url":"https://github.com/endlessm/chromium-browser","homepage":null,"size":1874214,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"6e1e4017fc941935ef52379f1f397085ea5baf7d","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":38511569,"name":"chromium-browser","full_name":"endlessm/chromium-browser","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/chromium-browser","description":"Fork of chromium-browser with endless customizations","fork":false,"url":"https://api.github.com/repos/endlessm/chromium-browser","forks_url":"https://api.github.com/repos/endlessm/chromium-browser/forks","keys_url":"https://api.github.com/repos/endlessm/chromium-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/chromium-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/chromium-browser/teams","hooks_url":"https://api.github.com/repos/endlessm/chromium-browser/hooks","issue_events_url":"https://api.github.com/repos/endlessm/chromium-browser/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/chromium-browser/events","assignees_url":"https://api.github.com/repos/endlessm/chromium-browser/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/chromium-browser/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/chromium-browser/tags","blobs_url":"https://api.github.com/repos/endlessm/chromium-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/chromium-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/chromium-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/chromium-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/chromium-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/chromium-browser/languages","stargazers_url":"https://api.github.com/repos/endlessm/chromium-browser/stargazers","contributors_url":"https://api.github.com/repos/endlessm/chromium-browser/contributors","subscribers_url":"https://api.github.com/repos/endlessm/chromium-browser/subscribers","subscription_url":"https://api.github.com/repos/endlessm/chromium-browser/subscription","commits_url":"https://api.github.com/repos/endlessm/chromium-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/chromium-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/chromium-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/chromium-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/chromium-browser/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/chromium-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/chromium-browser/merges","archive_url":"https://api.github.com/repos/endlessm/chromium-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/chromium-browser/downloads","issues_url":"https://api.github.com/repos/endlessm/chromium-browser/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/chromium-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/chromium-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/chromium-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/chromium-browser/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/chromium-browser/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/chromium-browser/deployments","created_at":"2015-07-03T21:40:44Z","updated_at":"2016-01-12T17:57:30Z","pushed_at":"2016-03-14T22:08:04Z","git_url":"git://github.com/endlessm/chromium-browser.git","ssh_url":"git@github.com:endlessm/chromium-browser.git","clone_url":"https://github.com/endlessm/chromium-browser.git","svn_url":"https://github.com/endlessm/chromium-browser","homepage":null,"size":1874214,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/chromium-browser/pulls/43"},"html":{"href":"https://github.com/endlessm/chromium-browser/pull/43"},"issue":{"href":"https://api.github.com/repos/endlessm/chromium-browser/issues/43"},"comments":{"href":"https://api.github.com/repos/endlessm/chromium-browser/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/chromium-browser/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/chromium-browser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/chromium-browser/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/chromium-browser/statuses/ff85ddfa11524920f3f03e0dcb9e1334515301a3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rshuler","id":2050162,"avatar_url":"https://avatars.githubusercontent.com/u/2050162?v=3","gravatar_id":"","url":"https://api.github.com/users/rshuler","html_url":"https://github.com/rshuler","followers_url":"https://api.github.com/users/rshuler/followers","following_url":"https://api.github.com/users/rshuler/following{/other_user}","gists_url":"https://api.github.com/users/rshuler/gists{/gist_id}","starred_url":"https://api.github.com/users/rshuler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshuler/subscriptions","organizations_url":"https://api.github.com/users/rshuler/orgs","repos_url":"https://api.github.com/users/rshuler/repos","events_url":"https://api.github.com/users/rshuler/events{/privacy}","received_events_url":"https://api.github.com/users/rshuler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":1,"additions":5,"deletions":3,"changed_files":1}}