{"action":"created","comment":{"url":"https://api.github.com/repos/govend/govend/pulls/comments/57174899","id":57174899,"diff_hunk":"@@ -140,6 +143,7 @@ func projectImportPath() string {\n \t\tlog.Fatal(errors.New(\"$GOPATH not set\"))\n \t}\n \n-\t// leverage the $GOPATH to strip out everything but the base git URL\n-\treturn path[len(gopath+\"/src/\"):]\n+\t// trim the $GOPATH/src off the current working directory\n+\tgosrc := filepath.Join(gopath, \"src\") + string(filepath.Separator)\n+\treturn strings.TrimPrefix(cwd, gosrc)","path":"imports/filters/filters.go","position":29,"original_position":29,"commit_id":"f68c5c2afeac4153624199576f16a85c359aca32","original_commit_id":"f68c5c2afeac4153624199576f16a85c359aca32","user":{"login":"jackspirou","id":5687406,"avatar_url":"https://avatars.githubusercontent.com/u/5687406?v=3","gravatar_id":"","url":"https://api.github.com/users/jackspirou","html_url":"https://github.com/jackspirou","followers_url":"https://api.github.com/users/jackspirou/followers","following_url":"https://api.github.com/users/jackspirou/following{/other_user}","gists_url":"https://api.github.com/users/jackspirou/gists{/gist_id}","starred_url":"https://api.github.com/users/jackspirou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackspirou/subscriptions","organizations_url":"https://api.github.com/users/jackspirou/orgs","repos_url":"https://api.github.com/users/jackspirou/repos","events_url":"https://api.github.com/users/jackspirou/events{/privacy}","received_events_url":"https://api.github.com/users/jackspirou/received_events","type":"User","site_admin":false},"body":"Quick question, for the `projectImportPath` method, I think we always want to return a unix like path (since import paths are always unixy), never a windows like path.  I think this code will return a windows like path if the user is on windows, and that might mess up the `Local` filter method.","created_at":"2016-03-23T15:06:09Z","updated_at":"2016-03-23T15:06:09Z","html_url":"https://github.com/govend/govend/pull/43#discussion_r57174899","pull_request_url":"https://api.github.com/repos/govend/govend/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/govend/govend/pulls/comments/57174899"},"html":{"href":"https://github.com/govend/govend/pull/43#discussion_r57174899"},"pull_request":{"href":"https://api.github.com/repos/govend/govend/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/govend/govend/pulls/43","id":63894291,"html_url":"https://github.com/govend/govend/pull/43","diff_url":"https://github.com/govend/govend/pull/43.diff","patch_url":"https://github.com/govend/govend/pull/43.patch","issue_url":"https://api.github.com/repos/govend/govend/issues/43","number":43,"state":"open","locked":false,"title":"Replace os.Args[0] with os.Getwd for #42","user":{"login":"swdunlop","id":120188,"avatar_url":"https://avatars.githubusercontent.com/u/120188?v=3","gravatar_id":"","url":"https://api.github.com/users/swdunlop","html_url":"https://github.com/swdunlop","followers_url":"https://api.github.com/users/swdunlop/followers","following_url":"https://api.github.com/users/swdunlop/following{/other_user}","gists_url":"https://api.github.com/users/swdunlop/gists{/gist_id}","starred_url":"https://api.github.com/users/swdunlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swdunlop/subscriptions","organizations_url":"https://api.github.com/users/swdunlop/orgs","repos_url":"https://api.github.com/users/swdunlop/repos","events_url":"https://api.github.com/users/swdunlop/events{/privacy}","received_events_url":"https://api.github.com/users/swdunlop/received_events","type":"User","site_admin":false},"body":"Also replace some uses of \"/\" with filepath.Separator or filepath.Join; see #42.","created_at":"2016-03-23T14:51:53Z","updated_at":"2016-03-23T15:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5a6cdb4e85ea06b356096d6ff9777abb34997dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/govend/govend/pulls/43/commits","review_comments_url":"https://api.github.com/repos/govend/govend/pulls/43/comments","review_comment_url":"https://api.github.com/repos/govend/govend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/govend/govend/issues/43/comments","statuses_url":"https://api.github.com/repos/govend/govend/statuses/f68c5c2afeac4153624199576f16a85c359aca32","head":{"label":"swdunlop:master","ref":"master","sha":"f68c5c2afeac4153624199576f16a85c359aca32","user":{"login":"swdunlop","id":120188,"avatar_url":"https://avatars.githubusercontent.com/u/120188?v=3","gravatar_id":"","url":"https://api.github.com/users/swdunlop","html_url":"https://github.com/swdunlop","followers_url":"https://api.github.com/users/swdunlop/followers","following_url":"https://api.github.com/users/swdunlop/following{/other_user}","gists_url":"https://api.github.com/users/swdunlop/gists{/gist_id}","starred_url":"https://api.github.com/users/swdunlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swdunlop/subscriptions","organizations_url":"https://api.github.com/users/swdunlop/orgs","repos_url":"https://api.github.com/users/swdunlop/repos","events_url":"https://api.github.com/users/swdunlop/events{/privacy}","received_events_url":"https://api.github.com/users/swdunlop/received_events","type":"User","site_admin":false},"repo":{"id":54565357,"name":"govend","full_name":"swdunlop/govend","owner":{"login":"swdunlop","id":120188,"avatar_url":"https://avatars.githubusercontent.com/u/120188?v=3","gravatar_id":"","url":"https://api.github.com/users/swdunlop","html_url":"https://github.com/swdunlop","followers_url":"https://api.github.com/users/swdunlop/followers","following_url":"https://api.github.com/users/swdunlop/following{/other_user}","gists_url":"https://api.github.com/users/swdunlop/gists{/gist_id}","starred_url":"https://api.github.com/users/swdunlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swdunlop/subscriptions","organizations_url":"https://api.github.com/users/swdunlop/orgs","repos_url":"https://api.github.com/users/swdunlop/repos","events_url":"https://api.github.com/users/swdunlop/events{/privacy}","received_events_url":"https://api.github.com/users/swdunlop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swdunlop/govend","description":"A simple tool to vendor Go package dependencies. It's like \"go get\" for vendoring.","fork":true,"url":"https://api.github.com/repos/swdunlop/govend","forks_url":"https://api.github.com/repos/swdunlop/govend/forks","keys_url":"https://api.github.com/repos/swdunlop/govend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swdunlop/govend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swdunlop/govend/teams","hooks_url":"https://api.github.com/repos/swdunlop/govend/hooks","issue_events_url":"https://api.github.com/repos/swdunlop/govend/issues/events{/number}","events_url":"https://api.github.com/repos/swdunlop/govend/events","assignees_url":"https://api.github.com/repos/swdunlop/govend/assignees{/user}","branches_url":"https://api.github.com/repos/swdunlop/govend/branches{/branch}","tags_url":"https://api.github.com/repos/swdunlop/govend/tags","blobs_url":"https://api.github.com/repos/swdunlop/govend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swdunlop/govend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swdunlop/govend/git/refs{/sha}","trees_url":"https://api.github.com/repos/swdunlop/govend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swdunlop/govend/statuses/{sha}","languages_url":"https://api.github.com/repos/swdunlop/govend/languages","stargazers_url":"https://api.github.com/repos/swdunlop/govend/stargazers","contributors_url":"https://api.github.com/repos/swdunlop/govend/contributors","subscribers_url":"https://api.github.com/repos/swdunlop/govend/subscribers","subscription_url":"https://api.github.com/repos/swdunlop/govend/subscription","commits_url":"https://api.github.com/repos/swdunlop/govend/commits{/sha}","git_commits_url":"https://api.github.com/repos/swdunlop/govend/git/commits{/sha}","comments_url":"https://api.github.com/repos/swdunlop/govend/comments{/number}","issue_comment_url":"https://api.github.com/repos/swdunlop/govend/issues/comments{/number}","contents_url":"https://api.github.com/repos/swdunlop/govend/contents/{+path}","compare_url":"https://api.github.com/repos/swdunlop/govend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swdunlop/govend/merges","archive_url":"https://api.github.com/repos/swdunlop/govend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swdunlop/govend/downloads","issues_url":"https://api.github.com/repos/swdunlop/govend/issues{/number}","pulls_url":"https://api.github.com/repos/swdunlop/govend/pulls{/number}","milestones_url":"https://api.github.com/repos/swdunlop/govend/milestones{/number}","notifications_url":"https://api.github.com/repos/swdunlop/govend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swdunlop/govend/labels{/name}","releases_url":"https://api.github.com/repos/swdunlop/govend/releases{/id}","deployments_url":"https://api.github.com/repos/swdunlop/govend/deployments","created_at":"2016-03-23T14:15:08Z","updated_at":"2016-03-23T14:15:08Z","pushed_at":"2016-03-23T14:50:34Z","git_url":"git://github.com/swdunlop/govend.git","ssh_url":"git@github.com:swdunlop/govend.git","clone_url":"https://github.com/swdunlop/govend.git","svn_url":"https://github.com/swdunlop/govend","homepage":"","size":35090,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"govend:master","ref":"master","sha":"d1a6065e0b9f95e56bd6d5d458347ec309f46d8b","user":{"login":"govend","id":17211683,"avatar_url":"https://avatars.githubusercontent.com/u/17211683?v=3","gravatar_id":"","url":"https://api.github.com/users/govend","html_url":"https://github.com/govend","followers_url":"https://api.github.com/users/govend/followers","following_url":"https://api.github.com/users/govend/following{/other_user}","gists_url":"https://api.github.com/users/govend/gists{/gist_id}","starred_url":"https://api.github.com/users/govend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govend/subscriptions","organizations_url":"https://api.github.com/users/govend/orgs","repos_url":"https://api.github.com/users/govend/repos","events_url":"https://api.github.com/users/govend/events{/privacy}","received_events_url":"https://api.github.com/users/govend/received_events","type":"Organization","site_admin":false},"repo":{"id":25737215,"name":"govend","full_name":"govend/govend","owner":{"login":"govend","id":17211683,"avatar_url":"https://avatars.githubusercontent.com/u/17211683?v=3","gravatar_id":"","url":"https://api.github.com/users/govend","html_url":"https://github.com/govend","followers_url":"https://api.github.com/users/govend/followers","following_url":"https://api.github.com/users/govend/following{/other_user}","gists_url":"https://api.github.com/users/govend/gists{/gist_id}","starred_url":"https://api.github.com/users/govend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govend/subscriptions","organizations_url":"https://api.github.com/users/govend/orgs","repos_url":"https://api.github.com/users/govend/repos","events_url":"https://api.github.com/users/govend/events{/privacy}","received_events_url":"https://api.github.com/users/govend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/govend/govend","description":"A simple tool to vendor Go package dependencies. It's like \"go get\" for vendoring.","fork":false,"url":"https://api.github.com/repos/govend/govend","forks_url":"https://api.github.com/repos/govend/govend/forks","keys_url":"https://api.github.com/repos/govend/govend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/govend/govend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/govend/govend/teams","hooks_url":"https://api.github.com/repos/govend/govend/hooks","issue_events_url":"https://api.github.com/repos/govend/govend/issues/events{/number}","events_url":"https://api.github.com/repos/govend/govend/events","assignees_url":"https://api.github.com/repos/govend/govend/assignees{/user}","branches_url":"https://api.github.com/repos/govend/govend/branches{/branch}","tags_url":"https://api.github.com/repos/govend/govend/tags","blobs_url":"https://api.github.com/repos/govend/govend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/govend/govend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/govend/govend/git/refs{/sha}","trees_url":"https://api.github.com/repos/govend/govend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/govend/govend/statuses/{sha}","languages_url":"https://api.github.com/repos/govend/govend/languages","stargazers_url":"https://api.github.com/repos/govend/govend/stargazers","contributors_url":"https://api.github.com/repos/govend/govend/contributors","subscribers_url":"https://api.github.com/repos/govend/govend/subscribers","subscription_url":"https://api.github.com/repos/govend/govend/subscription","commits_url":"https://api.github.com/repos/govend/govend/commits{/sha}","git_commits_url":"https://api.github.com/repos/govend/govend/git/commits{/sha}","comments_url":"https://api.github.com/repos/govend/govend/comments{/number}","issue_comment_url":"https://api.github.com/repos/govend/govend/issues/comments{/number}","contents_url":"https://api.github.com/repos/govend/govend/contents/{+path}","compare_url":"https://api.github.com/repos/govend/govend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/govend/govend/merges","archive_url":"https://api.github.com/repos/govend/govend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/govend/govend/downloads","issues_url":"https://api.github.com/repos/govend/govend/issues{/number}","pulls_url":"https://api.github.com/repos/govend/govend/pulls{/number}","milestones_url":"https://api.github.com/repos/govend/govend/milestones{/number}","notifications_url":"https://api.github.com/repos/govend/govend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/govend/govend/labels{/name}","releases_url":"https://api.github.com/repos/govend/govend/releases{/id}","deployments_url":"https://api.github.com/repos/govend/govend/deployments","created_at":"2014-10-25T16:03:50Z","updated_at":"2016-03-23T11:57:52Z","pushed_at":"2016-03-23T14:51:54Z","git_url":"git://github.com/govend/govend.git","ssh_url":"git@github.com:govend/govend.git","clone_url":"https://github.com/govend/govend.git","svn_url":"https://github.com/govend/govend","homepage":"","size":36669,"stargazers_count":95,"watchers_count":95,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/govend/govend/pulls/43"},"html":{"href":"https://github.com/govend/govend/pull/43"},"issue":{"href":"https://api.github.com/repos/govend/govend/issues/43"},"comments":{"href":"https://api.github.com/repos/govend/govend/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/govend/govend/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/govend/govend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/govend/govend/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/govend/govend/statuses/f68c5c2afeac4153624199576f16a85c359aca32"}}}}