{"action":"created","issue":{"url":"https://api.github.com/repos/zhaozg/lua-openssl/issues/83","labels_url":"https://api.github.com/repos/zhaozg/lua-openssl/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/zhaozg/lua-openssl/issues/83/comments","events_url":"https://api.github.com/repos/zhaozg/lua-openssl/issues/83/events","html_url":"https://github.com/zhaozg/lua-openssl/issues/83","id":126232117,"number":83,"title":"src/digest.c : ligne 412","user":{"login":"abdelmouneim","id":15202983,"avatar_url":"https://avatars.githubusercontent.com/u/15202983?v=3","gravatar_id":"","url":"https://api.github.com/users/abdelmouneim","html_url":"https://github.com/abdelmouneim","followers_url":"https://api.github.com/users/abdelmouneim/followers","following_url":"https://api.github.com/users/abdelmouneim/following{/other_user}","gists_url":"https://api.github.com/users/abdelmouneim/gists{/gist_id}","starred_url":"https://api.github.com/users/abdelmouneim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdelmouneim/subscriptions","organizations_url":"https://api.github.com/users/abdelmouneim/orgs","repos_url":"https://api.github.com/users/abdelmouneim/repos","events_url":"https://api.github.com/users/abdelmouneim/events{/privacy}","received_events_url":"https://api.github.com/users/abdelmouneim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-12T17:39:20Z","updated_at":"2016-01-13T00:59:13Z","closed_at":null,"body":"this ligne : \r\n412:      ret = EVP_DigestVerifyFinal(ctx, (const unsigned char*) signature, signature_len);\r\nmust be replaced by this one : \r\n 412:     ret = EVP_DigestVerifyFinal(ctx, (unsigned char*) signature, signature_len);\r\n------------------------------------------------------------------------------------------------------------\r\nthis is the output of man EVP_DigestVerifyFinal\r\nNAME\r\n       EVP_DigestVerifyInit, EVP_DigestVerifyUpdate, EVP_DigestVerifyFinal -\r\n       EVP signature verification functions\r\n\r\nSYNOPSIS\r\n        #include <openssl/evp.h>\r\n\r\n        int EVP_DigestVerifyInit(EVP_MD_CTX *ctx, EVP_PKEY_CTX **pctx,\r\n                               const EVP_MD *type, ENGINE *e, EVP_PKEY *pkey);\r\n        int EVP_DigestVerifyUpdate(EVP_MD_CTX *ctx, const void *d, unsigned int cnt);\r\n        int EVP_DigestVerifyFinal(EVP_MD_CTX *ctx, unsigned char *sig, size_t siglen);\r\n"},"comment":{"url":"https://api.github.com/repos/zhaozg/lua-openssl/issues/comments/171116571","html_url":"https://github.com/zhaozg/lua-openssl/issues/83#issuecomment-171116571","issue_url":"https://api.github.com/repos/zhaozg/lua-openssl/issues/83","id":171116571,"user":{"login":"zhaozg","id":542599,"avatar_url":"https://avatars.githubusercontent.com/u/542599?v=3","gravatar_id":"","url":"https://api.github.com/users/zhaozg","html_url":"https://github.com/zhaozg","followers_url":"https://api.github.com/users/zhaozg/followers","following_url":"https://api.github.com/users/zhaozg/following{/other_user}","gists_url":"https://api.github.com/users/zhaozg/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaozg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaozg/subscriptions","organizations_url":"https://api.github.com/users/zhaozg/orgs","repos_url":"https://api.github.com/users/zhaozg/repos","events_url":"https://api.github.com/users/zhaozg/events{/privacy}","received_events_url":"https://api.github.com/users/zhaozg/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T00:59:13Z","updated_at":"2016-01-13T00:59:13Z","body":"Thanks, but please look at https://www.openssl.org/docs/manmaster/crypto/EVP_DigestVerifyInit.html\r\nor https://www.openssl.org/docs/man1.0.2/crypto/EVP_DigestVerifyInit.html, that is different with https://www.openssl.org/docs/man1.0.0/crypto/EVP_DigestVerifyInit.html\r\n\r\nAnd I think keep const should more safe."}}