{"action":"created","issue":{"url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/765","repository_url":"https://api.github.com/repos/OpenZWave/open-zwave","labels_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/765/labels{/name}","comments_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/765/comments","events_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/765/events","html_url":"https://github.com/OpenZWave/open-zwave/issues/765","id":130987437,"number":765,"title":"Manufacturer, product and type Ids default value is troublesome","user":{"login":"dsoulayrol","id":45929,"avatar_url":"https://avatars.githubusercontent.com/u/45929?v=3","gravatar_id":"","url":"https://api.github.com/users/dsoulayrol","html_url":"https://github.com/dsoulayrol","followers_url":"https://api.github.com/users/dsoulayrol/followers","following_url":"https://api.github.com/users/dsoulayrol/following{/other_user}","gists_url":"https://api.github.com/users/dsoulayrol/gists{/gist_id}","starred_url":"https://api.github.com/users/dsoulayrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsoulayrol/subscriptions","organizations_url":"https://api.github.com/users/dsoulayrol/orgs","repos_url":"https://api.github.com/users/dsoulayrol/repos","events_url":"https://api.github.com/users/dsoulayrol/events{/privacy}","received_events_url":"https://api.github.com/users/dsoulayrol/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-03T10:41:47Z","updated_at":"2016-02-05T07:13:45Z","closed_at":"2016-02-05T07:13:45Z","body":"Hi everyone,\r\n\r\nIn `Node.cpp`, default values for `m_manufacturerId`, `m_productType` and `m_productId` is `0`. However, `0` seems to be a valid value for each one of those attributes, even if it's true that no device in `config/manufacturer_specific.xml` is currently identified by this very 3-uplet.\r\n\r\nI suggest that those members should be initialized with some value that seem to never be used, like `0xffff`.\r\n\r\nAdditionally, documentation is false when it states that *an empty string* is returned if the *specific command class is not supported by the device*. Actually, `Manager::GetNodeManufacturerId` can return `Unknown` and `Driver::GetNodeManufacturerId` can return `0` by itself."},"comment":{"url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/comments/180232103","html_url":"https://github.com/OpenZWave/open-zwave/issues/765#issuecomment-180232103","issue_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/765","id":180232103,"user":{"login":"Fishwaldo","id":842308,"avatar_url":"https://avatars.githubusercontent.com/u/842308?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishwaldo","html_url":"https://github.com/Fishwaldo","followers_url":"https://api.github.com/users/Fishwaldo/followers","following_url":"https://api.github.com/users/Fishwaldo/following{/other_user}","gists_url":"https://api.github.com/users/Fishwaldo/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishwaldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishwaldo/subscriptions","organizations_url":"https://api.github.com/users/Fishwaldo/orgs","repos_url":"https://api.github.com/users/Fishwaldo/repos","events_url":"https://api.github.com/users/Fishwaldo/events{/privacy}","received_events_url":"https://api.github.com/users/Fishwaldo/received_events","type":"User","site_admin":false},"created_at":"2016-02-05T07:13:45Z","updated_at":"2016-02-05T07:13:45Z","body":"Changing that would probably break a lot of applications, so I wont do it.... and as you mentioned, no one has been assigned a \"0\" manufacturer ID, and I doubt anybody will do a type or product id of 0.\r\n\r\n> Additionally, documentation is false when it states that an empty string is returned if the specific command class is not supported by the device. Actually, Manager::GetNodeManufacturerId can return Unknown and Driver::GetNodeManufacturerId can return 0 by itself.\r\n\r\nI'm lost, the two functions you reference are not command class related, but manufacturer related?"}}