{"action":"created","issue":{"url":"https://api.github.com/repos/mottosso/Qt.py/issues/140","repository_url":"https://api.github.com/repos/mottosso/Qt.py","labels_url":"https://api.github.com/repos/mottosso/Qt.py/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/mottosso/Qt.py/issues/140/comments","events_url":"https://api.github.com/repos/mottosso/Qt.py/issues/140/events","html_url":"https://github.com/mottosso/Qt.py/pull/140","id":177571536,"number":140,"title":"Implement #139","user":{"login":"mottosso","id":2152766,"avatar_url":"https://avatars.githubusercontent.com/u/2152766?v=3","gravatar_id":"","url":"https://api.github.com/users/mottosso","html_url":"https://github.com/mottosso","followers_url":"https://api.github.com/users/mottosso/followers","following_url":"https://api.github.com/users/mottosso/following{/other_user}","gists_url":"https://api.github.com/users/mottosso/gists{/gist_id}","starred_url":"https://api.github.com/users/mottosso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mottosso/subscriptions","organizations_url":"https://api.github.com/users/mottosso/orgs","repos_url":"https://api.github.com/users/mottosso/repos","events_url":"https://api.github.com/users/mottosso/events{/privacy}","received_events_url":"https://api.github.com/users/mottosso/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mottosso/Qt.py/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-17T11:48:27Z","updated_at":"2016-09-20T18:07:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mottosso/Qt.py/pulls/140","html_url":"https://github.com/mottosso/Qt.py/pull/140","diff_url":"https://github.com/mottosso/Qt.py/pull/140.diff","patch_url":"https://github.com/mottosso/Qt.py/pull/140.patch"},"body":"This introduces a radical change to counter #139, #109, #112 and #96.\r\n\r\nThe change involves moving all added members of Qt.py to it's own individual module, `QtShim`.\r\n\r\n```python\r\n# Before\r\nimport Qt\r\nQt.setSectionResizeMode()\r\nQt.__binding__\r\n\r\n# After\r\nfrom Qt import QtShim\r\nQtShim.setSectionResizeMode()\r\nQtShim.__binding__ == \"PyQt5\"\r\n```\r\n\r\n- See [Example](https://github.com/abstractfactory/Qt.py/blob/master/CAVEATS.md#workaround-1)\r\n\r\nIt also counteracts our current Achilles heel, which is that at some point one of our additions are bound to conflict with native existing members of the binding. For example, if one day PySide decides to add `__qt_version__` to their offering, but have a different type for it, like `tuple`, whereas we have `str`\r\n\r\nSo I'm on the fence about whether this is the right way to do it. The disadvantage is a more complex code base; the reader must now understand how `self` plays a part, and how `QtShim` even makes it into the `Qt` namespace.\r\n\r\nSo let me know what you think."},"comment":{"url":"https://api.github.com/repos/mottosso/Qt.py/issues/comments/248383615","html_url":"https://github.com/mottosso/Qt.py/pull/140#issuecomment-248383615","issue_url":"https://api.github.com/repos/mottosso/Qt.py/issues/140","id":248383615,"user":{"login":"fredrikaverpil","id":994357,"avatar_url":"https://avatars.githubusercontent.com/u/994357?v=3","gravatar_id":"","url":"https://api.github.com/users/fredrikaverpil","html_url":"https://github.com/fredrikaverpil","followers_url":"https://api.github.com/users/fredrikaverpil/followers","following_url":"https://api.github.com/users/fredrikaverpil/following{/other_user}","gists_url":"https://api.github.com/users/fredrikaverpil/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikaverpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikaverpil/subscriptions","organizations_url":"https://api.github.com/users/fredrikaverpil/orgs","repos_url":"https://api.github.com/users/fredrikaverpil/repos","events_url":"https://api.github.com/users/fredrikaverpil/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikaverpil/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T18:07:37Z","updated_at":"2016-09-20T18:07:37Z","body":"> `from Qt import QtCompat`\r\n\r\nYep. Sounds good. Let's go for it.\r\nDoes this backwards-breaking feature that we should also hit v1.0.0?"}}
{"actor":{"display_login":"fredrikaverpil"}}