{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/80838942","pull_request_review_id":1864627,"id":80838942,"diff_hunk":"@@ -363,8 +363,12 @@ impl Document {\n     }\n \n     // https://dom.spec.whatwg.org/#concept-document-url\n-    pub fn url(&self) -> &Url {\n-        &self.url\n+    pub fn url(&self) -> Ref<Url> {\n+        self.url.borrow()\n+    }\n+\n+    pub fn set_url(&self, url: &Url) {\n+        *self.url.borrow_mut() = url.clone();","path":"components/script/dom/document.rs","position":20,"original_position":20,"commit_id":"b695a4e2fe3d5a515b8fb6d0e373dcf2336015aa","original_commit_id":"b695a4e2fe3d5a515b8fb6d0e373dcf2336015aa","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"body":"```rust\r\npub fn url_mut(&mut self) {\r\n    &mut self.url\r\n}\r\n```","created_at":"2016-09-28T03:44:37Z","updated_at":"2016-09-28T03:44:37Z","html_url":"https://github.com/servo/servo/pull/13418#discussion_r80838942","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13418","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/80838942"},"html":{"href":"https://github.com/servo/servo/pull/13418#discussion_r80838942"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13418"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13418","id":86665469,"html_url":"https://github.com/servo/servo/pull/13418","diff_url":"https://github.com/servo/servo/pull/13418.diff","patch_url":"https://github.com/servo/servo/pull/13418.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13418","number":13418,"state":"open","locked":false,"title":"Implement Location.replace()","user":{"login":"stshine","id":1694478,"avatar_url":"https://avatars.githubusercontent.com/u/1694478?v=3","gravatar_id":"","url":"https://api.github.com/users/stshine","html_url":"https://github.com/stshine","followers_url":"https://api.github.com/users/stshine/followers","following_url":"https://api.github.com/users/stshine/following{/other_user}","gists_url":"https://api.github.com/users/stshine/gists{/gist_id}","starred_url":"https://api.github.com/users/stshine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stshine/subscriptions","organizations_url":"https://api.github.com/users/stshine/orgs","repos_url":"https://api.github.com/users/stshine/repos","events_url":"https://api.github.com/users/stshine/events{/privacy}","received_events_url":"https://api.github.com/users/stshine/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #13413 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes OR\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13418)\n<!-- Reviewable:end -->\n","created_at":"2016-09-25T22:51:12Z","updated_at":"2016-09-28T03:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e71b59f21909b257623e84f2277e0a2df576c2f1","assignee":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13418/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13418/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13418/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/b695a4e2fe3d5a515b8fb6d0e373dcf2336015aa","head":{"label":"stshine:location-replace","ref":"location-replace","sha":"b695a4e2fe3d5a515b8fb6d0e373dcf2336015aa","user":{"login":"stshine","id":1694478,"avatar_url":"https://avatars.githubusercontent.com/u/1694478?v=3","gravatar_id":"","url":"https://api.github.com/users/stshine","html_url":"https://github.com/stshine","followers_url":"https://api.github.com/users/stshine/followers","following_url":"https://api.github.com/users/stshine/following{/other_user}","gists_url":"https://api.github.com/users/stshine/gists{/gist_id}","starred_url":"https://api.github.com/users/stshine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stshine/subscriptions","organizations_url":"https://api.github.com/users/stshine/orgs","repos_url":"https://api.github.com/users/stshine/repos","events_url":"https://api.github.com/users/stshine/events{/privacy}","received_events_url":"https://api.github.com/users/stshine/received_events","type":"User","site_admin":false},"repo":{"id":59609231,"name":"servo","full_name":"stshine/servo","owner":{"login":"stshine","id":1694478,"avatar_url":"https://avatars.githubusercontent.com/u/1694478?v=3","gravatar_id":"","url":"https://api.github.com/users/stshine","html_url":"https://github.com/stshine","followers_url":"https://api.github.com/users/stshine/followers","following_url":"https://api.github.com/users/stshine/following{/other_user}","gists_url":"https://api.github.com/users/stshine/gists{/gist_id}","starred_url":"https://api.github.com/users/stshine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stshine/subscriptions","organizations_url":"https://api.github.com/users/stshine/orgs","repos_url":"https://api.github.com/users/stshine/repos","events_url":"https://api.github.com/users/stshine/events{/privacy}","received_events_url":"https://api.github.com/users/stshine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stshine/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/stshine/servo","forks_url":"https://api.github.com/repos/stshine/servo/forks","keys_url":"https://api.github.com/repos/stshine/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stshine/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stshine/servo/teams","hooks_url":"https://api.github.com/repos/stshine/servo/hooks","issue_events_url":"https://api.github.com/repos/stshine/servo/issues/events{/number}","events_url":"https://api.github.com/repos/stshine/servo/events","assignees_url":"https://api.github.com/repos/stshine/servo/assignees{/user}","branches_url":"https://api.github.com/repos/stshine/servo/branches{/branch}","tags_url":"https://api.github.com/repos/stshine/servo/tags","blobs_url":"https://api.github.com/repos/stshine/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stshine/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stshine/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/stshine/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stshine/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/stshine/servo/languages","stargazers_url":"https://api.github.com/repos/stshine/servo/stargazers","contributors_url":"https://api.github.com/repos/stshine/servo/contributors","subscribers_url":"https://api.github.com/repos/stshine/servo/subscribers","subscription_url":"https://api.github.com/repos/stshine/servo/subscription","commits_url":"https://api.github.com/repos/stshine/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/stshine/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/stshine/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/stshine/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/stshine/servo/contents/{+path}","compare_url":"https://api.github.com/repos/stshine/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stshine/servo/merges","archive_url":"https://api.github.com/repos/stshine/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stshine/servo/downloads","issues_url":"https://api.github.com/repos/stshine/servo/issues{/number}","pulls_url":"https://api.github.com/repos/stshine/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/stshine/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/stshine/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stshine/servo/labels{/name}","releases_url":"https://api.github.com/repos/stshine/servo/releases{/id}","deployments_url":"https://api.github.com/repos/stshine/servo/deployments","created_at":"2016-05-24T21:16:50Z","updated_at":"2016-05-24T17:14:55Z","pushed_at":"2016-09-28T00:34:27Z","git_url":"git://github.com/stshine/servo.git","ssh_url":"git@github.com:stshine/servo.git","clone_url":"https://github.com/stshine/servo.git","svn_url":"https://github.com/stshine/servo","homepage":"https://servo.org/","size":209623,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"d00639c55f9a342765483d347a3c29d4647f7411","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-09-27T22:22:49Z","pushed_at":"2016-09-28T03:43:21Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":298681,"stargazers_count":7958,"watchers_count":7958,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1277,"mirror_url":null,"open_issues_count":1765,"forks":1277,"open_issues":1765,"watchers":7958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13418"},"html":{"href":"https://github.com/servo/servo/pull/13418"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13418"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13418/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13418/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13418/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/b695a4e2fe3d5a515b8fb6d0e373dcf2336015aa"}}}}
{"actor":{"display_login":"KiChjang"}}