{"action":"closed","number":12147,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/12147","id":71188357,"html_url":"https://github.com/odoo/odoo/pull/12147","diff_url":"https://github.com/odoo/odoo/pull/12147.diff","patch_url":"https://github.com/odoo/odoo/pull/12147.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/12147","number":12147,"state":"closed","locked":false,"title":"9_0_lead_automation_state","user":{"login":"eezeefho","id":16101054,"avatar_url":"https://avatars.githubusercontent.com/u/16101054?v=3","gravatar_id":"","url":"https://api.github.com/users/eezeefho","html_url":"https://github.com/eezeefho","followers_url":"https://api.github.com/users/eezeefho/followers","following_url":"https://api.github.com/users/eezeefho/following{/other_user}","gists_url":"https://api.github.com/users/eezeefho/gists{/gist_id}","starred_url":"https://api.github.com/users/eezeefho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eezeefho/subscriptions","organizations_url":"https://api.github.com/users/eezeefho/orgs","repos_url":"https://api.github.com/users/eezeefho/repos","events_url":"https://api.github.com/users/eezeefho/events{/privacy}","received_events_url":"https://api.github.com/users/eezeefho/received_events","type":"User","site_admin":false},"body":"**Description of the issue/feature this PR addresses:**\r\nThis change corrects the way conditions on workitems are addressed when running lead automation campaigns\r\n\r\n**Current behavior before PR:**\r\nCurrently, when you create an activity, a workitem is generated at first run when the segment is synchronized. If you select \"keep_if_condition_not_met\" and that the time trigger and condition are not met, the status of the work-item is set to \"cancelled\". if you don’t select \"don’t delete workitem\", the workitem is not generated. When the workitems are synchronized later by the scheduled action, this action will look for all items in \"todo\" status and try to run them. As our workitems are in status \"cancelled\" or are deleted, nothing will happen\r\n\r\n**Desired behavior after PR is merged:**\r\nWe have removed the option \"keep_if_condition_not_met\" in the activity. We have also changed the behaviour so that, if the time trigger and conditions are not met, the workitem is set with status \"todo\". This way, when the \"process workitems\" scheduled action is run, the system will find the workitems with \"todo\" status and run them again. If the conditions are met, they will be processed and the system will go to the next activity. This way, as long as the campaign is running, the records in our segment will continue to progress along our workitems and not be stuck anymore\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n\r\n…eld and let the state of workitem as 'todo' when he is not processed","created_at":"2016-05-24T09:40:57Z","updated_at":"2016-05-26T09:30:07Z","closed_at":"2016-05-26T09:30:07Z","merged_at":null,"merge_commit_sha":"2e4d823b66af0bfd82a8a32da5a2b424adb2b9dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/12147/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/12147/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/12147/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/13bb5f9a9209174879e1594b569dc8e483e6f30b","head":{"label":"eezee-it:fho/eoc-84","ref":"fho/eoc-84","sha":"13bb5f9a9209174879e1594b569dc8e483e6f30b","user":{"login":"eezee-it","id":2707883,"avatar_url":"https://avatars.githubusercontent.com/u/2707883?v=3","gravatar_id":"","url":"https://api.github.com/users/eezee-it","html_url":"https://github.com/eezee-it","followers_url":"https://api.github.com/users/eezee-it/followers","following_url":"https://api.github.com/users/eezee-it/following{/other_user}","gists_url":"https://api.github.com/users/eezee-it/gists{/gist_id}","starred_url":"https://api.github.com/users/eezee-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eezee-it/subscriptions","organizations_url":"https://api.github.com/users/eezee-it/orgs","repos_url":"https://api.github.com/users/eezee-it/repos","events_url":"https://api.github.com/users/eezee-it/events{/privacy}","received_events_url":"https://api.github.com/users/eezee-it/received_events","type":"Organization","site_admin":false},"repo":{"id":24092919,"name":"odoo","full_name":"eezee-it/odoo","owner":{"login":"eezee-it","id":2707883,"avatar_url":"https://avatars.githubusercontent.com/u/2707883?v=3","gravatar_id":"","url":"https://api.github.com/users/eezee-it","html_url":"https://github.com/eezee-it","followers_url":"https://api.github.com/users/eezee-it/followers","following_url":"https://api.github.com/users/eezee-it/following{/other_user}","gists_url":"https://api.github.com/users/eezee-it/gists{/gist_id}","starred_url":"https://api.github.com/users/eezee-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eezee-it/subscriptions","organizations_url":"https://api.github.com/users/eezee-it/orgs","repos_url":"https://api.github.com/users/eezee-it/repos","events_url":"https://api.github.com/users/eezee-it/events{/privacy}","received_events_url":"https://api.github.com/users/eezee-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eezee-it/odoo","description":"Eezee-It fork for Odoo. This fork has the only purpose to be able to define tags (i.e versions) on the odoo/odoo official repository to facilitate the use of a fix version of Odoo. You can use it to control the Odoo version. Tag naming convention is: v for version + '8.0' (branch i.e version of Odoo) + date + commit. Ex: v7.0.2014-12-16.f833d2e","fork":true,"url":"https://api.github.com/repos/eezee-it/odoo","forks_url":"https://api.github.com/repos/eezee-it/odoo/forks","keys_url":"https://api.github.com/repos/eezee-it/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eezee-it/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eezee-it/odoo/teams","hooks_url":"https://api.github.com/repos/eezee-it/odoo/hooks","issue_events_url":"https://api.github.com/repos/eezee-it/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/eezee-it/odoo/events","assignees_url":"https://api.github.com/repos/eezee-it/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/eezee-it/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/eezee-it/odoo/tags","blobs_url":"https://api.github.com/repos/eezee-it/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eezee-it/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eezee-it/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/eezee-it/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eezee-it/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/eezee-it/odoo/languages","stargazers_url":"https://api.github.com/repos/eezee-it/odoo/stargazers","contributors_url":"https://api.github.com/repos/eezee-it/odoo/contributors","subscribers_url":"https://api.github.com/repos/eezee-it/odoo/subscribers","subscription_url":"https://api.github.com/repos/eezee-it/odoo/subscription","commits_url":"https://api.github.com/repos/eezee-it/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/eezee-it/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/eezee-it/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/eezee-it/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/eezee-it/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/eezee-it/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eezee-it/odoo/merges","archive_url":"https://api.github.com/repos/eezee-it/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eezee-it/odoo/downloads","issues_url":"https://api.github.com/repos/eezee-it/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/eezee-it/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/eezee-it/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/eezee-it/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eezee-it/odoo/labels{/name}","releases_url":"https://api.github.com/repos/eezee-it/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/eezee-it/odoo/deployments","created_at":"2014-09-16T09:11:41Z","updated_at":"2016-01-28T14:48:05Z","pushed_at":"2016-05-23T08:11:59Z","git_url":"git://github.com/eezee-it/odoo.git","ssh_url":"git@github.com:eezee-it/odoo.git","clone_url":"https://github.com/eezee-it/odoo.git","svn_url":"https://github.com/eezee-it/odoo","homepage":"http://www.eezee-it.com","size":1409873,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"8.0"}},"base":{"label":"odoo:9.0","ref":"9.0","sha":"4c07fafe708d3ddb5079c930d536fc1e22b51aac","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2016-05-26T05:56:26Z","pushed_at":"2016-05-26T09:27:22Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1692107,"stargazers_count":4333,"watchers_count":4333,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4159,"mirror_url":null,"open_issues_count":3363,"forks":4159,"open_issues":3363,"watchers":4333,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12147"},"html":{"href":"https://github.com/odoo/odoo/pull/12147"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/12147"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/12147/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12147/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/12147/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/13bb5f9a9209174879e1594b569dc8e483e6f30b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":19,"deletions":12,"changed_files":3}}
{"actor":{"display_login":"nim-odoo"}}