{"action":"created","issue":{"url":"https://api.github.com/repos/HandBrake/HandBrake/issues/215","repository_url":"https://api.github.com/repos/HandBrake/HandBrake","labels_url":"https://api.github.com/repos/HandBrake/HandBrake/issues/215/labels{/name}","comments_url":"https://api.github.com/repos/HandBrake/HandBrake/issues/215/comments","events_url":"https://api.github.com/repos/HandBrake/HandBrake/issues/215/events","html_url":"https://github.com/HandBrake/HandBrake/issues/215","id":158553575,"number":215,"title":"encoding/muxing srt to ssa causes an extra line with space.","user":{"login":"christophecvr","id":2471016,"avatar_url":"https://avatars.githubusercontent.com/u/2471016?v=3","gravatar_id":"","url":"https://api.github.com/users/christophecvr","html_url":"https://github.com/christophecvr","followers_url":"https://api.github.com/users/christophecvr/followers","following_url":"https://api.github.com/users/christophecvr/following{/other_user}","gists_url":"https://api.github.com/users/christophecvr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophecvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophecvr/subscriptions","organizations_url":"https://api.github.com/users/christophecvr/orgs","repos_url":"https://api.github.com/users/christophecvr/repos","events_url":"https://api.github.com/users/christophecvr/events{/privacy}","received_events_url":"https://api.github.com/users/christophecvr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jstebbins","id":709720,"avatar_url":"https://avatars.githubusercontent.com/u/709720?v=3","gravatar_id":"","url":"https://api.github.com/users/jstebbins","html_url":"https://github.com/jstebbins","followers_url":"https://api.github.com/users/jstebbins/followers","following_url":"https://api.github.com/users/jstebbins/following{/other_user}","gists_url":"https://api.github.com/users/jstebbins/gists{/gist_id}","starred_url":"https://api.github.com/users/jstebbins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstebbins/subscriptions","organizations_url":"https://api.github.com/users/jstebbins/orgs","repos_url":"https://api.github.com/users/jstebbins/repos","events_url":"https://api.github.com/users/jstebbins/events{/privacy}","received_events_url":"https://api.github.com/users/jstebbins/received_events","type":"User","site_admin":false},"milestone":null,"comments":14,"created_at":"2016-06-05T13:07:57Z","updated_at":"2016-06-10T06:05:52Z","closed_at":"2016-06-09T22:44:40Z","body":"Hello, I noticed that until version release 0.10.2 all is ok when inserting pass trough srt subtitles.\r\nSince the release 0.10.5 (sorry I could not compile on ubuntu version between 0.10.2 and 0.10.5)\r\n\r\nWhat happening a normal srt is converted to ssa till version 0.10.2 all is ok. But since somewhere between 0.10.2 and 0.10.5 the resulting string in ssa ads at the end off string (before the \\0) and extra space and new line. w.a.w a blank line just containig a space. Here an investigating output off the string self in txt format.\r\n\r\nThe start sub only the to line off the origin srt file:\r\n\r\n`1\r\n00:00:00,000 --> 00:00:04,520\r\nOndertiteling Nederlands\r\n\r\n2\r\n00:00:17,620 --> 00:00:22,769\r\nLIGUSTERLAAN\r\n\r\n3\r\n00:01:18,399 --> 00:01:23,229\r\nIk had kunnen weten dat u hier\r\nwas, professor Anderling .`\r\n\r\nHere the log output specially made in our application to investigate the given string off the ssa.\r\n`Relevant characters for investigation are <0A> is new line <00> end string . So I set them between <>\r\n\r\nHandbrake version 0.10.2  converted srt to ssa.\r\n1 line: \r\n<136843.956> [eServiceMP3] pullSubtitle(GstBuffer *buffer)\r\n<136843.958> [eServiceMP3] ** investigate string ** [BEGIN]LIGUSTERLAAN[END] hex out: 4C494755535445524C41414E<00>\r\n\r\n2 lines:\r\n<137008.801> [eServiceMP3] pullSubtitle(GstBuffer *buffer)\r\n<137008.802> [eServiceMP3] ** investigate string ** [BEGIN]Ik had kunnen weten dat u hier \r\nwas, professor Anderling .[END] hex out: 496B20686164206B756E6E656E20776574656E206461742075206869657220<0A>7761732C2070726F666573736F7220416E6465726C696E67202E<00>\r\n\r\n\r\nHandbrake version 0.10.5 and above(till last git) converted srt to ssa.\r\n\r\n1 line :\r\n<137172.297> [eServiceMP3] pullSubtitle(GstBuffer *buffer)\r\n<137172.298> [eServiceMP3] ** investigate string ** [BEGIN]LIGUSTERLAAN \r\n[END] hex out; 4C494755535445524C41414E20<0A><00>\r\n\r\n2 lines :\r\n<137233.076> [eServiceMP3] pullSubtitle(GstBuffer *buffer)\r\n<137233.077> [eServiceMP3] ** investigate string ** [BEGIN]Ik had kunnen weten dat u hier \r\nwas, professor Anderling . \r\n[END] hex out: 496B20686164206B756E6E656E20776574656E206461742075206869657220<0A>7761732C2070726F666573736F7220416E6465726C696E67202E20<0A><00>`\r\n\r\nas You can see by handbrake above 0.10.2 a space 20 and return 0A is added.\r\n"},"comment":{"url":"https://api.github.com/repos/HandBrake/HandBrake/issues/comments/225101028","html_url":"https://github.com/HandBrake/HandBrake/issues/215#issuecomment-225101028","issue_url":"https://api.github.com/repos/HandBrake/HandBrake/issues/215","id":225101028,"user":{"login":"littlesat","id":1200384,"avatar_url":"https://avatars.githubusercontent.com/u/1200384?v=3","gravatar_id":"","url":"https://api.github.com/users/littlesat","html_url":"https://github.com/littlesat","followers_url":"https://api.github.com/users/littlesat/followers","following_url":"https://api.github.com/users/littlesat/following{/other_user}","gists_url":"https://api.github.com/users/littlesat/gists{/gist_id}","starred_url":"https://api.github.com/users/littlesat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/littlesat/subscriptions","organizations_url":"https://api.github.com/users/littlesat/orgs","repos_url":"https://api.github.com/users/littlesat/repos","events_url":"https://api.github.com/users/littlesat/events{/privacy}","received_events_url":"https://api.github.com/users/littlesat/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T06:05:52Z","updated_at":"2016-06-10T06:05:52Z","body":"A \\n at the last line I think could be OK but in fact not required at all..... \r\nBut ending it with multiple white spaces and/or multiple spaces at the end is not OK.... e.g. when you want to center a suptitlle and you have white spaces at the end the subtitle cannot be centered."}}
{"actor":{"display_login":"littlesat"}}