{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3813","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3813/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3813/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3813/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/3813","id":157902738,"number":3813,"title":"Fix unarchive bug when unzipping an archive that has one or more file (#3792)","user":{"login":"ethryx","id":341416,"avatar_url":"https://avatars.githubusercontent.com/u/341416?v=3","gravatar_id":"","url":"https://api.github.com/users/ethryx","html_url":"https://github.com/ethryx","followers_url":"https://api.github.com/users/ethryx/followers","following_url":"https://api.github.com/users/ethryx/following{/other_user}","gists_url":"https://api.github.com/users/ethryx/gists{/gist_id}","starred_url":"https://api.github.com/users/ethryx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethryx/subscriptions","organizations_url":"https://api.github.com/users/ethryx/orgs","repos_url":"https://api.github.com/users/ethryx/repos","events_url":"https://api.github.com/users/ethryx/events{/privacy}","received_events_url":"https://api.github.com/users/ethryx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/community_review","name":"community_review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-01T13:11:27Z","updated_at":"2016-06-01T15:47:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3813","html_url":"https://github.com/ansible/ansible-modules-core/pull/3813","diff_url":"https://github.com/ansible/ansible-modules-core/pull/3813.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/3813.patch"},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\nBugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the plugin/module/task  -->\r\nunarchive\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.1.0.0\r\n```\r\n\r\n##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\nFixes #3792 \r\n\r\nIn the unarchive module within the ZipArchive class, there is an issue with the method `is_unarchived`. It is parsing the output of `unzip -ZT <source>` and breaking on files that have a space in them. The current method is to split each line at the space character and if the length of the array is not 8, it will assume it is the header or footer of the command's output. Instead, I removed the header and footer explicitly so we know each line represents a file in the archive. Furthermore, the final path is determined by removing the elements before it in the array, which will retain any spaces in the path."},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/223036154","html_url":"https://github.com/ansible/ansible-modules-core/pull/3813#issuecomment-223036154","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3813","id":223036154,"user":{"login":"ethryx","id":341416,"avatar_url":"https://avatars.githubusercontent.com/u/341416?v=3","gravatar_id":"","url":"https://api.github.com/users/ethryx","html_url":"https://github.com/ethryx","followers_url":"https://api.github.com/users/ethryx/followers","following_url":"https://api.github.com/users/ethryx/following{/other_user}","gists_url":"https://api.github.com/users/ethryx/gists{/gist_id}","starred_url":"https://api.github.com/users/ethryx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethryx/subscriptions","organizations_url":"https://api.github.com/users/ethryx/orgs","repos_url":"https://api.github.com/users/ethryx/repos","events_url":"https://api.github.com/users/ethryx/events{/privacy}","received_events_url":"https://api.github.com/users/ethryx/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T15:47:46Z","updated_at":"2016-06-01T15:47:46Z","body":"@dagwieers Thanks for the feedback. I'll revise the PR in a little bit to be able to handle those situations. In my testing, I only saw a 1-line header/footer -- sorry I didn't catch that."}}
{"actor":{"display_login":"ethryx"}}