{"action":"closed","number":1454,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/1454","id":67614150,"html_url":"https://github.com/brave/browser-laptop/pull/1454","diff_url":"https://github.com/brave/browser-laptop/pull/1454.diff","patch_url":"https://github.com/brave/browser-laptop/pull/1454.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/1454","number":1454,"state":"closed","locked":false,"title":"Bookmarks Toolbar - shows in prefs and icons also show","user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"body":"Part 1 of a fix for https://github.com/brave/browser-laptop/issues/1114\r\n\r\nAdded configuration for toggling Bookmarks Toolbar / favicon. Favicon now shows in Bookmarks Toolbar (not in folders though- those use the ContextMenu object).\r\n\r\nHere's a pic which shows the preferences along with how the icons look in the menu. Ones that receive a 404 unfortunately don't have a default icon.\r\n\r\n![bookmarks_toolbar](https://cloud.githubusercontent.com/assets/4733304/14763233/826f1b36-0944-11e6-9377-039800138801.png)\r\n","created_at":"2016-04-23T18:14:18Z","updated_at":"2016-04-25T13:02:53Z","closed_at":"2016-04-25T13:02:53Z","merged_at":"2016-04-25T13:02:52Z","merge_commit_sha":"75b06f0c75c3ad05ca3b62f4d61667a43deae841","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/1454/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/1454/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/1454/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/8db2469f57198185cdcc4c3dd93e956b039b971b","head":{"label":"bsclifton:master","ref":"master","sha":"8db2469f57198185cdcc4c3dd93e956b039b971b","user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"repo":{"id":56203023,"name":"browser-laptop","full_name":"bsclifton/browser-laptop","owner":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsclifton/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/bsclifton/browser-laptop","forks_url":"https://api.github.com/repos/bsclifton/browser-laptop/forks","keys_url":"https://api.github.com/repos/bsclifton/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsclifton/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsclifton/browser-laptop/teams","hooks_url":"https://api.github.com/repos/bsclifton/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/bsclifton/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/bsclifton/browser-laptop/events","assignees_url":"https://api.github.com/repos/bsclifton/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/bsclifton/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/bsclifton/browser-laptop/tags","blobs_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsclifton/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/bsclifton/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/bsclifton/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/bsclifton/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/bsclifton/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/bsclifton/browser-laptop/subscription","commits_url":"https://api.github.com/repos/bsclifton/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsclifton/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsclifton/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsclifton/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/bsclifton/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsclifton/browser-laptop/merges","archive_url":"https://api.github.com/repos/bsclifton/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsclifton/browser-laptop/downloads","issues_url":"https://api.github.com/repos/bsclifton/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/bsclifton/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/bsclifton/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/bsclifton/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsclifton/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/bsclifton/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/bsclifton/browser-laptop/deployments","created_at":"2016-04-14T03:03:23Z","updated_at":"2016-04-25T01:11:35Z","pushed_at":"2016-04-25T08:02:21Z","git_url":"git://github.com/bsclifton/browser-laptop.git","ssh_url":"git@github.com:bsclifton/browser-laptop.git","clone_url":"https://github.com/bsclifton/browser-laptop.git","svn_url":"https://github.com/bsclifton/browser-laptop","homepage":"https://www.brave.com","size":9530,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"aed22138f64d5c495c07dcd14c0852493c412e2d","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-04-25T11:16:18Z","pushed_at":"2016-04-25T13:02:52Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":12700,"stargazers_count":2659,"watchers_count":2659,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"open_issues_count":526,"forks":287,"open_issues":526,"watchers":2659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/1454"},"html":{"href":"https://github.com/brave/browser-laptop/pull/1454"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/1454"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/1454/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/1454/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/1454/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/8db2469f57198185cdcc4c3dd93e956b039b971b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"comments":7,"review_comments":3,"commits":2,"additions":114,"deletions":28,"changed_files":10}}