{"action":"created","comment":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/comments/72009126","id":72009126,"diff_hunk":"@@ -2,6 +2,8 @@\n \n - Added: `block-closing-brace-empty-line-before` rule.\n - Added: `custom-property-empty-line-before` rule.\n+- Added: `declaration-empty-line-before` rule.\n+- Added: `media-feature-name-case` rule.","path":"CHANGELOG.md","position":5,"original_position":5,"commit_id":"b3e81bdd68732b1186e5975e1e2ce8c856ef447f","original_commit_id":"b3e81bdd68732b1186e5975e1e2ce8c856ef447f","user":{"login":"ntwb","id":1016458,"avatar_url":"https://avatars.githubusercontent.com/u/1016458?v=3","gravatar_id":"","url":"https://api.github.com/users/ntwb","html_url":"https://github.com/ntwb","followers_url":"https://api.github.com/users/ntwb/followers","following_url":"https://api.github.com/users/ntwb/following{/other_user}","gists_url":"https://api.github.com/users/ntwb/gists{/gist_id}","starred_url":"https://api.github.com/users/ntwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntwb/subscriptions","organizations_url":"https://api.github.com/users/ntwb/orgs","repos_url":"https://api.github.com/users/ntwb/repos","events_url":"https://api.github.com/users/ntwb/events{/privacy}","received_events_url":"https://api.github.com/users/ntwb/received_events","type":"User","site_admin":false},"body":"This isn't supposed to be in this PR, was added in https://github.com/stylelint/stylelint/commit/c1dd30891aa061dc39382f70ff7b2454087116fc","created_at":"2016-07-25T05:02:38Z","updated_at":"2016-07-25T05:02:38Z","html_url":"https://github.com/stylelint/stylelint/pull/1694#discussion_r72009126","pull_request_url":"https://api.github.com/repos/stylelint/stylelint/pulls/1694","_links":{"self":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/comments/72009126"},"html":{"href":"https://github.com/stylelint/stylelint/pull/1694#discussion_r72009126"},"pull_request":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1694"}}},"pull_request":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/1694","id":78356479,"html_url":"https://github.com/stylelint/stylelint/pull/1694","diff_url":"https://github.com/stylelint/stylelint/pull/1694.diff","patch_url":"https://github.com/stylelint/stylelint/pull/1694.patch","issue_url":"https://api.github.com/repos/stylelint/stylelint/issues/1694","number":1694,"state":"open","locked":false,"title":"Add declaration-empty-line-before","user":{"login":"jeddy3","id":808227,"avatar_url":"https://avatars.githubusercontent.com/u/808227?v=3","gravatar_id":"","url":"https://api.github.com/users/jeddy3","html_url":"https://github.com/jeddy3","followers_url":"https://api.github.com/users/jeddy3/followers","following_url":"https://api.github.com/users/jeddy3/following{/other_user}","gists_url":"https://api.github.com/users/jeddy3/gists{/gist_id}","starred_url":"https://api.github.com/users/jeddy3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeddy3/subscriptions","organizations_url":"https://api.github.com/users/jeddy3/orgs","repos_url":"https://api.github.com/users/jeddy3/repos","events_url":"https://api.github.com/users/jeddy3/events{/privacy}","received_events_url":"https://api.github.com/users/jeddy3/received_events","type":"User","site_admin":false},"body":"Closes #1573\r\n\r\nDoing this uncovered a few issues with the approach in `custom-property-empty-line-before`:\r\n\r\n1. Using `walkDecls` and `walkRules` together meant declarations within nested rules were being checked twice.\r\n2. We hadn't considered single-line blocks...\r\n\r\nI've gone with just using `walkDecls` to address the former.\r\n\r\nAnd I've gone with an `ignore: [\"inside-single-line-block\"]` secondary option (ok name?) to address the latter. \r\n\r\nThis is at odds with how I've dealt with single-line blocks within `block-closing-brace-empty-line-before`. There I've used an `\"always-multi-line\"`, rather than `\"always`\" option. As this is inline with the other `block-*-brace` rules.\r\n\r\nI had considered scoping `declaration-empty-line-before` to the declaration block e.g. `declaration-block-declaration-empty-line-before`. This would allow us to use `\"always-multi-line\"` in a consistent way. The naming would also be consistent with things like `declaration-block-single-line-max-declarations`. *However*, this would be at odds with `rule-nested-empty-line-before` and `at-rule-empty-line-before`.\r\n\r\nLong story short, I think adding an `ignore: [\"inside-single-line-block\"]` option to this and `custom-property-empty-line-before` is the best compromise on consistency.\r\n\r\nIf we're happy with this, I'll retrofit these changes to `custom-property-empty-line-before`.","created_at":"2016-07-21T17:35:27Z","updated_at":"2016-07-25T05:02:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b1efd7f274c01e1a987e80a5b756d0a180ffbe8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stylelint/stylelint/pulls/1694/commits","review_comments_url":"https://api.github.com/repos/stylelint/stylelint/pulls/1694/comments","review_comment_url":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stylelint/stylelint/issues/1694/comments","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/b3e81bdd68732b1186e5975e1e2ce8c856ef447f","head":{"label":"stylelint:declaration-empty-line-before","ref":"declaration-empty-line-before","sha":"b3e81bdd68732b1186e5975e1e2ce8c856ef447f","user":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"repo":{"id":27549019,"name":"stylelint","full_name":"stylelint/stylelint","owner":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stylelint/stylelint","description":"A mighty, modern CSS linter","fork":false,"url":"https://api.github.com/repos/stylelint/stylelint","forks_url":"https://api.github.com/repos/stylelint/stylelint/forks","keys_url":"https://api.github.com/repos/stylelint/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stylelint/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stylelint/stylelint/teams","hooks_url":"https://api.github.com/repos/stylelint/stylelint/hooks","issue_events_url":"https://api.github.com/repos/stylelint/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/stylelint/stylelint/events","assignees_url":"https://api.github.com/repos/stylelint/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/stylelint/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/stylelint/stylelint/tags","blobs_url":"https://api.github.com/repos/stylelint/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stylelint/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stylelint/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/stylelint/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/stylelint/stylelint/languages","stargazers_url":"https://api.github.com/repos/stylelint/stylelint/stargazers","contributors_url":"https://api.github.com/repos/stylelint/stylelint/contributors","subscribers_url":"https://api.github.com/repos/stylelint/stylelint/subscribers","subscription_url":"https://api.github.com/repos/stylelint/stylelint/subscription","commits_url":"https://api.github.com/repos/stylelint/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/stylelint/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/stylelint/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/stylelint/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/stylelint/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/stylelint/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stylelint/stylelint/merges","archive_url":"https://api.github.com/repos/stylelint/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stylelint/stylelint/downloads","issues_url":"https://api.github.com/repos/stylelint/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/stylelint/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/stylelint/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/stylelint/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stylelint/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/stylelint/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/stylelint/stylelint/deployments","created_at":"2014-12-04T16:25:23Z","updated_at":"2016-07-24T22:38:14Z","pushed_at":"2016-07-25T01:41:29Z","git_url":"git://github.com/stylelint/stylelint.git","ssh_url":"git@github.com:stylelint/stylelint.git","clone_url":"https://github.com/stylelint/stylelint.git","svn_url":"https://github.com/stylelint/stylelint","homepage":"http://stylelint.io/","size":5407,"stargazers_count":1933,"watchers_count":1933,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":34,"forks":127,"open_issues":34,"watchers":1933,"default_branch":"master"}},"base":{"label":"stylelint:master","ref":"master","sha":"705a5ceb41d9aed7fefee388d15f45d1e6a60beb","user":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"repo":{"id":27549019,"name":"stylelint","full_name":"stylelint/stylelint","owner":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stylelint/stylelint","description":"A mighty, modern CSS linter","fork":false,"url":"https://api.github.com/repos/stylelint/stylelint","forks_url":"https://api.github.com/repos/stylelint/stylelint/forks","keys_url":"https://api.github.com/repos/stylelint/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stylelint/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stylelint/stylelint/teams","hooks_url":"https://api.github.com/repos/stylelint/stylelint/hooks","issue_events_url":"https://api.github.com/repos/stylelint/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/stylelint/stylelint/events","assignees_url":"https://api.github.com/repos/stylelint/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/stylelint/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/stylelint/stylelint/tags","blobs_url":"https://api.github.com/repos/stylelint/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stylelint/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stylelint/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/stylelint/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/stylelint/stylelint/languages","stargazers_url":"https://api.github.com/repos/stylelint/stylelint/stargazers","contributors_url":"https://api.github.com/repos/stylelint/stylelint/contributors","subscribers_url":"https://api.github.com/repos/stylelint/stylelint/subscribers","subscription_url":"https://api.github.com/repos/stylelint/stylelint/subscription","commits_url":"https://api.github.com/repos/stylelint/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/stylelint/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/stylelint/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/stylelint/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/stylelint/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/stylelint/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stylelint/stylelint/merges","archive_url":"https://api.github.com/repos/stylelint/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stylelint/stylelint/downloads","issues_url":"https://api.github.com/repos/stylelint/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/stylelint/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/stylelint/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/stylelint/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stylelint/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/stylelint/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/stylelint/stylelint/deployments","created_at":"2014-12-04T16:25:23Z","updated_at":"2016-07-24T22:38:14Z","pushed_at":"2016-07-25T01:41:29Z","git_url":"git://github.com/stylelint/stylelint.git","ssh_url":"git@github.com:stylelint/stylelint.git","clone_url":"https://github.com/stylelint/stylelint.git","svn_url":"https://github.com/stylelint/stylelint","homepage":"http://stylelint.io/","size":5407,"stargazers_count":1933,"watchers_count":1933,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":34,"forks":127,"open_issues":34,"watchers":1933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1694"},"html":{"href":"https://github.com/stylelint/stylelint/pull/1694"},"issue":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/1694"},"comments":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/1694/comments"},"review_comments":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1694/comments"},"review_comment":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1694/commits"},"statuses":{"href":"https://api.github.com/repos/stylelint/stylelint/statuses/b3e81bdd68732b1186e5975e1e2ce8c856ef447f"}}}}
{"actor":{"display_login":"ntwb"}}