{"action":"created","comment":{"url":"https://api.github.com/repos/circleci/bond/pulls/comments/57835984","id":57835984,"diff_hunk":"@@ -0,0 +1,26 @@\n+var page = require('webpage').create();\n+var system = require('system');\n+\n+if (system.args.length !== 2) {\n+  console.log('Expected a target URL parameter.');\n+  phantom.exit(1);\n+}\n+\n+page.onConsoleMessage = function (message) {\n+  console.log(message);\n+};\n+\n+var url = system.args[1];\n+\n+page.open(url, function (status) {\n+  if (status !== \"success\") {\n+    phantom.exit(1);\n+  }\n+\n+  var exitCode = page.evaluate(function() {","path":"resources/test/phantom/runner.js","position":20,"original_position":20,"commit_id":"be8a1a24192a00c270264143ea127cf9031d541d","original_commit_id":"be8a1a24192a00c270264143ea127cf9031d541d","user":{"login":"JustinC474","id":1459073,"avatar_url":"https://avatars.githubusercontent.com/u/1459073?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinC474","html_url":"https://github.com/JustinC474","followers_url":"https://api.github.com/users/JustinC474/followers","following_url":"https://api.github.com/users/JustinC474/following{/other_user}","gists_url":"https://api.github.com/users/JustinC474/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinC474/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinC474/subscriptions","organizations_url":"https://api.github.com/users/JustinC474/orgs","repos_url":"https://api.github.com/users/JustinC474/repos","events_url":"https://api.github.com/users/JustinC474/events{/privacy}","received_events_url":"https://api.github.com/users/JustinC474/received_events","type":"User","site_admin":false},"body":"from the testing i did today it looks like phantom only returns a non zero status code when u explicitly do `phantom.exit(<non zero int>)`. I had to experiment with this a bit since I initially had tests that were failing but the CI wasn't showing as \"failed\"","created_at":"2016-03-30T04:31:34Z","updated_at":"2016-03-30T04:31:34Z","html_url":"https://github.com/circleci/bond/pull/19#discussion_r57835984","pull_request_url":"https://api.github.com/repos/circleci/bond/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/circleci/bond/pulls/comments/57835984"},"html":{"href":"https://github.com/circleci/bond/pull/19#discussion_r57835984"},"pull_request":{"href":"https://api.github.com/repos/circleci/bond/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/circleci/bond/pulls/19","id":64554325,"html_url":"https://github.com/circleci/bond/pull/19","diff_url":"https://github.com/circleci/bond/pull/19.diff","patch_url":"https://github.com/circleci/bond/pull/19.patch","issue_url":"https://api.github.com/repos/circleci/bond/issues/19","number":19,"state":"open","locked":false,"title":"Added cljs tests and bumped the bond version","user":{"login":"JustinC474","id":1459073,"avatar_url":"https://avatars.githubusercontent.com/u/1459073?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinC474","html_url":"https://github.com/JustinC474","followers_url":"https://api.github.com/users/JustinC474/followers","following_url":"https://api.github.com/users/JustinC474/following{/other_user}","gists_url":"https://api.github.com/users/JustinC474/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinC474/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinC474/subscriptions","organizations_url":"https://api.github.com/users/JustinC474/orgs","repos_url":"https://api.github.com/users/JustinC474/repos","events_url":"https://api.github.com/users/JustinC474/events{/privacy}","received_events_url":"https://api.github.com/users/JustinC474/received_events","type":"User","site_admin":false},"body":"Used cljsbuild to build our cljs tests and phantomjs to run them.\r\n\r\nRan known good and bad code to make sure it appropriately passes and fails in CI.\r\nfailing: https://circleci.com/gh/circleci/bond/72\r\npassing: https://circleci.com/gh/circleci/bond/71","created_at":"2016-03-30T00:14:11Z","updated_at":"2016-03-30T04:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6133e24e72112f920c5fff27faf6a3651d56748a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/circleci/bond/pulls/19/commits","review_comments_url":"https://api.github.com/repos/circleci/bond/pulls/19/comments","review_comment_url":"https://api.github.com/repos/circleci/bond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/circleci/bond/issues/19/comments","statuses_url":"https://api.github.com/repos/circleci/bond/statuses/be8a1a24192a00c270264143ea127cf9031d541d","head":{"label":"circleci:jcTestsCljs","ref":"jcTestsCljs","sha":"be8a1a24192a00c270264143ea127cf9031d541d","user":{"login":"circleci","id":1231870,"avatar_url":"https://avatars.githubusercontent.com/u/1231870?v=3","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"repo":{"id":3761799,"name":"bond","full_name":"circleci/bond","owner":{"login":"circleci","id":1231870,"avatar_url":"https://avatars.githubusercontent.com/u/1231870?v=3","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circleci/bond","description":"spying for tests","fork":false,"url":"https://api.github.com/repos/circleci/bond","forks_url":"https://api.github.com/repos/circleci/bond/forks","keys_url":"https://api.github.com/repos/circleci/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circleci/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circleci/bond/teams","hooks_url":"https://api.github.com/repos/circleci/bond/hooks","issue_events_url":"https://api.github.com/repos/circleci/bond/issues/events{/number}","events_url":"https://api.github.com/repos/circleci/bond/events","assignees_url":"https://api.github.com/repos/circleci/bond/assignees{/user}","branches_url":"https://api.github.com/repos/circleci/bond/branches{/branch}","tags_url":"https://api.github.com/repos/circleci/bond/tags","blobs_url":"https://api.github.com/repos/circleci/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circleci/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circleci/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/circleci/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circleci/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/circleci/bond/languages","stargazers_url":"https://api.github.com/repos/circleci/bond/stargazers","contributors_url":"https://api.github.com/repos/circleci/bond/contributors","subscribers_url":"https://api.github.com/repos/circleci/bond/subscribers","subscription_url":"https://api.github.com/repos/circleci/bond/subscription","commits_url":"https://api.github.com/repos/circleci/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/circleci/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/circleci/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/circleci/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/circleci/bond/contents/{+path}","compare_url":"https://api.github.com/repos/circleci/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circleci/bond/merges","archive_url":"https://api.github.com/repos/circleci/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circleci/bond/downloads","issues_url":"https://api.github.com/repos/circleci/bond/issues{/number}","pulls_url":"https://api.github.com/repos/circleci/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/circleci/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/circleci/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circleci/bond/labels{/name}","releases_url":"https://api.github.com/repos/circleci/bond/releases{/id}","deployments_url":"https://api.github.com/repos/circleci/bond/deployments","created_at":"2012-03-19T08:23:04Z","updated_at":"2015-12-04T11:49:51Z","pushed_at":"2016-03-30T01:29:30Z","git_url":"git://github.com/circleci/bond.git","ssh_url":"git@github.com:circleci/bond.git","clone_url":"https://github.com/circleci/bond.git","svn_url":"https://github.com/circleci/bond","homepage":"","size":42,"stargazers_count":35,"watchers_count":35,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":35,"default_branch":"master"}},"base":{"label":"circleci:master","ref":"master","sha":"eae3fcb0f88f1f2ecc5d3d0254809ac0499eac8d","user":{"login":"circleci","id":1231870,"avatar_url":"https://avatars.githubusercontent.com/u/1231870?v=3","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"repo":{"id":3761799,"name":"bond","full_name":"circleci/bond","owner":{"login":"circleci","id":1231870,"avatar_url":"https://avatars.githubusercontent.com/u/1231870?v=3","gravatar_id":"","url":"https://api.github.com/users/circleci","html_url":"https://github.com/circleci","followers_url":"https://api.github.com/users/circleci/followers","following_url":"https://api.github.com/users/circleci/following{/other_user}","gists_url":"https://api.github.com/users/circleci/gists{/gist_id}","starred_url":"https://api.github.com/users/circleci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circleci/subscriptions","organizations_url":"https://api.github.com/users/circleci/orgs","repos_url":"https://api.github.com/users/circleci/repos","events_url":"https://api.github.com/users/circleci/events{/privacy}","received_events_url":"https://api.github.com/users/circleci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circleci/bond","description":"spying for tests","fork":false,"url":"https://api.github.com/repos/circleci/bond","forks_url":"https://api.github.com/repos/circleci/bond/forks","keys_url":"https://api.github.com/repos/circleci/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circleci/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circleci/bond/teams","hooks_url":"https://api.github.com/repos/circleci/bond/hooks","issue_events_url":"https://api.github.com/repos/circleci/bond/issues/events{/number}","events_url":"https://api.github.com/repos/circleci/bond/events","assignees_url":"https://api.github.com/repos/circleci/bond/assignees{/user}","branches_url":"https://api.github.com/repos/circleci/bond/branches{/branch}","tags_url":"https://api.github.com/repos/circleci/bond/tags","blobs_url":"https://api.github.com/repos/circleci/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circleci/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circleci/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/circleci/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circleci/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/circleci/bond/languages","stargazers_url":"https://api.github.com/repos/circleci/bond/stargazers","contributors_url":"https://api.github.com/repos/circleci/bond/contributors","subscribers_url":"https://api.github.com/repos/circleci/bond/subscribers","subscription_url":"https://api.github.com/repos/circleci/bond/subscription","commits_url":"https://api.github.com/repos/circleci/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/circleci/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/circleci/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/circleci/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/circleci/bond/contents/{+path}","compare_url":"https://api.github.com/repos/circleci/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circleci/bond/merges","archive_url":"https://api.github.com/repos/circleci/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circleci/bond/downloads","issues_url":"https://api.github.com/repos/circleci/bond/issues{/number}","pulls_url":"https://api.github.com/repos/circleci/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/circleci/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/circleci/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circleci/bond/labels{/name}","releases_url":"https://api.github.com/repos/circleci/bond/releases{/id}","deployments_url":"https://api.github.com/repos/circleci/bond/deployments","created_at":"2012-03-19T08:23:04Z","updated_at":"2015-12-04T11:49:51Z","pushed_at":"2016-03-30T01:29:30Z","git_url":"git://github.com/circleci/bond.git","ssh_url":"git@github.com:circleci/bond.git","clone_url":"https://github.com/circleci/bond.git","svn_url":"https://github.com/circleci/bond","homepage":"","size":42,"stargazers_count":35,"watchers_count":35,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/circleci/bond/pulls/19"},"html":{"href":"https://github.com/circleci/bond/pull/19"},"issue":{"href":"https://api.github.com/repos/circleci/bond/issues/19"},"comments":{"href":"https://api.github.com/repos/circleci/bond/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/circleci/bond/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/circleci/bond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/circleci/bond/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/circleci/bond/statuses/be8a1a24192a00c270264143ea127cf9031d541d"}}}}