{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/manylinux/pulls/comments/58303675","id":58303675,"diff_hunk":"@@ -48,11 +48,11 @@ mkdir -p /opt/python\n build_cpythons $CPYTHON_VERSIONS\n rm -rf /usr/local/ssl\n \n-# Install patchelf and auditwheel (latest)\n-curl -sLO http://nixos.org/releases/patchelf/patchelf-0.9/patchelf-0.9.tar.gz\n-tar -xzf patchelf-0.9.tar.gz\n-(cd patchelf-0.9 && ./configure && make && make install)\n-rm -rf patchelf-0.9.tar.gz patchelf-0.9\n+# Install patchelf and auditwheel (latest with unreleased bug fixes)\n+curl -sLO http://nipy.bic.berkeley.edu/manylinux/patchelf-0.9njs2.tar.gz","path":"docker/build_scripts/build.sh","position":10,"original_position":10,"commit_id":"6f7aa47897c89e11ca30ef872a76f3a71dcc735a","original_commit_id":"6f7aa47897c89e11ca30ef872a76f3a71dcc735a","user":{"login":"njsmith","id":609896,"avatar_url":"https://avatars.githubusercontent.com/u/609896?v=3","gravatar_id":"","url":"https://api.github.com/users/njsmith","html_url":"https://github.com/njsmith","followers_url":"https://api.github.com/users/njsmith/followers","following_url":"https://api.github.com/users/njsmith/following{/other_user}","gists_url":"https://api.github.com/users/njsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/njsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njsmith/subscriptions","organizations_url":"https://api.github.com/users/njsmith/orgs","repos_url":"https://api.github.com/users/njsmith/repos","events_url":"https://api.github.com/users/njsmith/events{/privacy}","received_events_url":"https://api.github.com/users/njsmith/received_events","type":"User","site_admin":false},"body":"now that I think about it, it's kinda not-so-great that we're installing this directly over a plain unencrypted `http` link to a random server. It means that if `nipy.bic.berkeley.edu` gets 0wned or MITMed, then some large proportion of the internet gets 0wned too (basically everyone using pip on linux). We can't help having a somewhat broad trust footprint (github, travis, docker hub for our base image, fedora, python.org, pypi for auditwheel, the TLS certificate system), but we should still try to keep it down if we can :-).\r\n\r\nMaybe the best strategy would be to check the hash, like we do with openssl?","created_at":"2016-04-03T03:00:25Z","updated_at":"2016-04-03T03:00:25Z","html_url":"https://github.com/pypa/manylinux/pull/44#discussion_r58303675","pull_request_url":"https://api.github.com/repos/pypa/manylinux/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/pypa/manylinux/pulls/comments/58303675"},"html":{"href":"https://github.com/pypa/manylinux/pull/44#discussion_r58303675"},"pull_request":{"href":"https://api.github.com/repos/pypa/manylinux/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/manylinux/pulls/44","id":65051484,"html_url":"https://github.com/pypa/manylinux/pull/44","diff_url":"https://github.com/pypa/manylinux/pull/44.diff","patch_url":"https://github.com/pypa/manylinux/pull/44.patch","issue_url":"https://api.github.com/repos/pypa/manylinux/issues/44","number":44,"state":"open","locked":false,"title":"Use patchelf 0.9 + Nathaniel's fixes","user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"body":"As soon as @matthew-brett's test show that @njsmith's fixes to patchelf are safe, I think we can merge those to the official manylinux docker image.\r\n\r\nhttps://github.com/pypa/auditwheel/pull/25#issuecomment-204806583","created_at":"2016-04-02T22:00:02Z","updated_at":"2016-04-03T03:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d49746dd7d38999154a8b87a490fbc09791c275b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pypa/manylinux/pulls/44/commits","review_comments_url":"https://api.github.com/repos/pypa/manylinux/pulls/44/comments","review_comment_url":"https://api.github.com/repos/pypa/manylinux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/manylinux/issues/44/comments","statuses_url":"https://api.github.com/repos/pypa/manylinux/statuses/6f7aa47897c89e11ca30ef872a76f3a71dcc735a","head":{"label":"ogrisel:patchelf-fixes","ref":"patchelf-fixes","sha":"6f7aa47897c89e11ca30ef872a76f3a71dcc735a","user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"repo":{"id":53212985,"name":"manylinux","full_name":"ogrisel/manylinux","owner":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ogrisel/manylinux","description":"Python wheels that work on any linux (almost)","fork":true,"url":"https://api.github.com/repos/ogrisel/manylinux","forks_url":"https://api.github.com/repos/ogrisel/manylinux/forks","keys_url":"https://api.github.com/repos/ogrisel/manylinux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogrisel/manylinux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogrisel/manylinux/teams","hooks_url":"https://api.github.com/repos/ogrisel/manylinux/hooks","issue_events_url":"https://api.github.com/repos/ogrisel/manylinux/issues/events{/number}","events_url":"https://api.github.com/repos/ogrisel/manylinux/events","assignees_url":"https://api.github.com/repos/ogrisel/manylinux/assignees{/user}","branches_url":"https://api.github.com/repos/ogrisel/manylinux/branches{/branch}","tags_url":"https://api.github.com/repos/ogrisel/manylinux/tags","blobs_url":"https://api.github.com/repos/ogrisel/manylinux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogrisel/manylinux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogrisel/manylinux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogrisel/manylinux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogrisel/manylinux/statuses/{sha}","languages_url":"https://api.github.com/repos/ogrisel/manylinux/languages","stargazers_url":"https://api.github.com/repos/ogrisel/manylinux/stargazers","contributors_url":"https://api.github.com/repos/ogrisel/manylinux/contributors","subscribers_url":"https://api.github.com/repos/ogrisel/manylinux/subscribers","subscription_url":"https://api.github.com/repos/ogrisel/manylinux/subscription","commits_url":"https://api.github.com/repos/ogrisel/manylinux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogrisel/manylinux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogrisel/manylinux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogrisel/manylinux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogrisel/manylinux/contents/{+path}","compare_url":"https://api.github.com/repos/ogrisel/manylinux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogrisel/manylinux/merges","archive_url":"https://api.github.com/repos/ogrisel/manylinux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogrisel/manylinux/downloads","issues_url":"https://api.github.com/repos/ogrisel/manylinux/issues{/number}","pulls_url":"https://api.github.com/repos/ogrisel/manylinux/pulls{/number}","milestones_url":"https://api.github.com/repos/ogrisel/manylinux/milestones{/number}","notifications_url":"https://api.github.com/repos/ogrisel/manylinux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogrisel/manylinux/labels{/name}","releases_url":"https://api.github.com/repos/ogrisel/manylinux/releases{/id}","deployments_url":"https://api.github.com/repos/ogrisel/manylinux/deployments","created_at":"2016-03-05T17:12:43Z","updated_at":"2016-03-05T17:12:45Z","pushed_at":"2016-04-02T21:58:40Z","git_url":"git://github.com/ogrisel/manylinux.git","ssh_url":"git@github.com:ogrisel/manylinux.git","clone_url":"https://github.com/ogrisel/manylinux.git","svn_url":"https://github.com/ogrisel/manylinux","homepage":null,"size":104,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"807bebdb12ae973948bd528ebb4b516445ccbab4","user":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":49401134,"name":"manylinux","full_name":"pypa/manylinux","owner":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pypa/manylinux","description":"Python wheels that work on any linux (almost)","fork":false,"url":"https://api.github.com/repos/pypa/manylinux","forks_url":"https://api.github.com/repos/pypa/manylinux/forks","keys_url":"https://api.github.com/repos/pypa/manylinux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/manylinux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/manylinux/teams","hooks_url":"https://api.github.com/repos/pypa/manylinux/hooks","issue_events_url":"https://api.github.com/repos/pypa/manylinux/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/manylinux/events","assignees_url":"https://api.github.com/repos/pypa/manylinux/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/manylinux/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/manylinux/tags","blobs_url":"https://api.github.com/repos/pypa/manylinux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/manylinux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/manylinux/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/manylinux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/manylinux/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/manylinux/languages","stargazers_url":"https://api.github.com/repos/pypa/manylinux/stargazers","contributors_url":"https://api.github.com/repos/pypa/manylinux/contributors","subscribers_url":"https://api.github.com/repos/pypa/manylinux/subscribers","subscription_url":"https://api.github.com/repos/pypa/manylinux/subscription","commits_url":"https://api.github.com/repos/pypa/manylinux/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/manylinux/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/manylinux/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/manylinux/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/manylinux/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/manylinux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/manylinux/merges","archive_url":"https://api.github.com/repos/pypa/manylinux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/manylinux/downloads","issues_url":"https://api.github.com/repos/pypa/manylinux/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/manylinux/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/manylinux/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/manylinux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/manylinux/labels{/name}","releases_url":"https://api.github.com/repos/pypa/manylinux/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/manylinux/deployments","created_at":"2016-01-11T04:02:51Z","updated_at":"2016-04-02T11:01:52Z","pushed_at":"2016-04-02T22:00:03Z","git_url":"git://github.com/pypa/manylinux.git","ssh_url":"git@github.com:pypa/manylinux.git","clone_url":"https://github.com/pypa/manylinux.git","svn_url":"https://github.com/pypa/manylinux","homepage":null,"size":108,"stargazers_count":35,"watchers_count":35,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/manylinux/pulls/44"},"html":{"href":"https://github.com/pypa/manylinux/pull/44"},"issue":{"href":"https://api.github.com/repos/pypa/manylinux/issues/44"},"comments":{"href":"https://api.github.com/repos/pypa/manylinux/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/manylinux/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/manylinux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/manylinux/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/manylinux/statuses/6f7aa47897c89e11ca30ef872a76f3a71dcc735a"}}}}