{"action":"created","issue":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/1989","repository_url":"https://api.github.com/repos/pkp/pkp-lib","labels_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1989/labels{/name}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1989/comments","events_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1989/events","html_url":"https://github.com/pkp/pkp-lib/issues/1989","id":189272649,"number":1989,"title":"Some notification emails sent out with empty recipient list","user":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bozana","id":378421,"avatar_url":"https://avatars.githubusercontent.com/u/378421?v=3","gravatar_id":"","url":"https://api.github.com/users/bozana","html_url":"https://github.com/bozana","followers_url":"https://api.github.com/users/bozana/followers","following_url":"https://api.github.com/users/bozana/following{/other_user}","gists_url":"https://api.github.com/users/bozana/gists{/gist_id}","starred_url":"https://api.github.com/users/bozana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bozana/subscriptions","organizations_url":"https://api.github.com/users/bozana/orgs","repos_url":"https://api.github.com/users/bozana/repos","events_url":"https://api.github.com/users/bozana/events{/privacy}","received_events_url":"https://api.github.com/users/bozana/received_events","type":"User","site_admin":false},"assignees":[{"login":"bozana","id":378421,"avatar_url":"https://avatars.githubusercontent.com/u/378421?v=3","gravatar_id":"","url":"https://api.github.com/users/bozana","html_url":"https://github.com/bozana","followers_url":"https://api.github.com/users/bozana/followers","following_url":"https://api.github.com/users/bozana/following{/other_user}","gists_url":"https://api.github.com/users/bozana/gists{/gist_id}","starred_url":"https://api.github.com/users/bozana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bozana/subscriptions","organizations_url":"https://api.github.com/users/bozana/orgs","repos_url":"https://api.github.com/users/bozana/repos","events_url":"https://api.github.com/users/bozana/events{/privacy}","received_events_url":"https://api.github.com/users/bozana/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/pkp/pkp-lib/milestones/10","html_url":"https://github.com/pkp/pkp-lib/milestones/OJS%203.0.1","labels_url":"https://api.github.com/repos/pkp/pkp-lib/milestones/10/labels","id":1020591,"number":10,"title":"OJS 3.0.1","description":"OJS 3.0.1 will be the first maintenance release following OJS 3.0.","creator":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":51,"state":"open","created_at":"2015-03-13T16:21:17Z","updated_at":"2016-11-21T11:59:38Z","due_on":"2016-11-15T00:00:00Z","closed_at":null},"comments":14,"created_at":"2016-11-15T01:14:26Z","updated_at":"2016-11-21T16:53:45Z","closed_at":null,"body":"See e.g. ` NOTIFICATION_TYPE_EDITOR_ASSIGNMENT_SUBMISSION`, which is sent out from `PKPSubmissionSubmitStep4Form.inc.php` when a submission is assigned to an editor upon receipt:\r\n\r\n                // Update assignment notifications\r\n                import('classes.workflow.EditorDecisionActionsManager');\r\n                $notificationManager->updateNotification(\r\n                        $request,\r\n                        EditorDecisionActionsManager::getStageNotifications(),\r\n                        null,\r\n                        ASSOC_TYPE_SUBMISSION,\r\n                        $this->submission->getId()\r\n                );\r\n\r\nNote that no specific user is assigned to this notification.\r\n\r\nThis is handled by `EditorAssignmentNotificationManager.inc.php` (see the `updateNotification` function). Again, no specific users are expected by the function (the `$userIds` parameter goes unused).\r\n\r\nThis appears to be fine for the sake of the notification, but when it comes time to send the notification email, the recipient is not set so the email is sent with an empty recipient list.\r\n\r\nThis appears to affect all notifications that use a `null` value for `$userId` in calls to `createNotification`."},"comment":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/comments/261996945","html_url":"https://github.com/pkp/pkp-lib/issues/1989#issuecomment-261996945","issue_url":"https://api.github.com/repos/pkp/pkp-lib/issues/1989","id":261996945,"user":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T16:53:45Z","updated_at":"2016-11-21T16:53:45Z","body":"Thanks, @bozana, this looks good. Additional authors might find the emails confusing if e.g. they haven't been assigned for workflow access, but we'll see if feedback bears that out. Go ahead!"}}
{"actor":{"display_login":"asmecher"}}