{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/64895897","id":64895897,"diff_hunk":"@@ -60,6 +77,30 @@ type ImageLayer struct {\n \tSize int64\n }\n \n+// SignatureValidationResult holds a result of signature validation.\n+type SignatureValidationResult string\n+\n+// ImageSignature holds a signature of an image.\n+type ImageSignature struct {\n+\t// Describes a type of stored blob.\n+\tType string\n+\t// An opaque binary string which is an image's signature.\n+\tContent []byte\n+\t// A time of last server-side validation. IOW a time of the last update to ValidationResult.\n+\tLastValidation *unversioned.Time","path":"pkg/image/api/types.go","position":45,"original_position":45,"commit_id":"e2ee2502036892b3ee92f2be36e2f3287bb7d628","original_commit_id":"e2ee2502036892b3ee92f2be36e2f3287bb7d628","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"body":"I wanted to emphasize that this field is tightly related to `ValidationResult`. If renamed to `Checked`, then the second field should be renamed to `CheckResult` which seems ambiguous to me.","created_at":"2016-05-27T12:15:30Z","updated_at":"2016-05-27T12:15:30Z","html_url":"https://github.com/openshift/origin/pull/8371#discussion_r64895897","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8371","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/64895897"},"html":{"href":"https://github.com/openshift/origin/pull/8371#discussion_r64895897"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8371"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8371","id":65452706,"html_url":"https://github.com/openshift/origin/pull/8371","diff_url":"https://github.com/openshift/origin/pull/8371.diff","patch_url":"https://github.com/openshift/origin/pull/8371.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8371","number":8371,"state":"open","locked":false,"title":"Image Signing","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"body":"Allow to add signatures to image objects. They are treated as opaque blobs.\r\n\r\nAdded a new cluster resource `images/signatures`.\r\n\r\nAdded `system:image-signer` role that athorizes to update image signatures.\r\n\r\n*TODOs*:\r\n\r\n- [x] define signature types (e.g. `gpg/base64` or just `base64`).\r\n- [x] decide whether user can update signatures being tagged in the project, he administrates\r\n- [x] write some more tests","created_at":"2016-04-06T11:50:15Z","updated_at":"2016-05-27T12:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"212820c95b3a66e8775e00c8ac45d7be3967eddb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8371/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8371/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8371/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/e2ee2502036892b3ee92f2be36e2f3287bb7d628","head":{"label":"miminar:image-with-signatures","ref":"image-with-signatures","sha":"e2ee2502036892b3ee92f2be36e2f3287bb7d628","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"repo":{"id":36652057,"name":"origin","full_name":"miminar/origin","owner":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miminar/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/miminar/origin","forks_url":"https://api.github.com/repos/miminar/origin/forks","keys_url":"https://api.github.com/repos/miminar/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miminar/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miminar/origin/teams","hooks_url":"https://api.github.com/repos/miminar/origin/hooks","issue_events_url":"https://api.github.com/repos/miminar/origin/issues/events{/number}","events_url":"https://api.github.com/repos/miminar/origin/events","assignees_url":"https://api.github.com/repos/miminar/origin/assignees{/user}","branches_url":"https://api.github.com/repos/miminar/origin/branches{/branch}","tags_url":"https://api.github.com/repos/miminar/origin/tags","blobs_url":"https://api.github.com/repos/miminar/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miminar/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miminar/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/miminar/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miminar/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/miminar/origin/languages","stargazers_url":"https://api.github.com/repos/miminar/origin/stargazers","contributors_url":"https://api.github.com/repos/miminar/origin/contributors","subscribers_url":"https://api.github.com/repos/miminar/origin/subscribers","subscription_url":"https://api.github.com/repos/miminar/origin/subscription","commits_url":"https://api.github.com/repos/miminar/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/miminar/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/miminar/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/miminar/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/miminar/origin/contents/{+path}","compare_url":"https://api.github.com/repos/miminar/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miminar/origin/merges","archive_url":"https://api.github.com/repos/miminar/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miminar/origin/downloads","issues_url":"https://api.github.com/repos/miminar/origin/issues{/number}","pulls_url":"https://api.github.com/repos/miminar/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/miminar/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/miminar/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miminar/origin/labels{/name}","releases_url":"https://api.github.com/repos/miminar/origin/releases{/id}","deployments_url":"https://api.github.com/repos/miminar/origin/deployments","created_at":"2015-06-01T09:53:10Z","updated_at":"2016-01-14T09:43:02Z","pushed_at":"2016-05-27T09:08:49Z","git_url":"git://github.com/miminar/origin.git","ssh_url":"git@github.com:miminar/origin.git","clone_url":"https://github.com/miminar/origin.git","svn_url":"https://github.com/miminar/origin","homepage":"http://www.openshift.org","size":265671,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"940dcf28d4c81050759a613a3241b23e3c2d5755","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-05-27T03:45:03Z","pushed_at":"2016-05-27T12:11:39Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":509654,"stargazers_count":1321,"watchers_count":1321,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":794,"mirror_url":null,"open_issues_count":1008,"forks":794,"open_issues":1008,"watchers":1321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8371"},"html":{"href":"https://github.com/openshift/origin/pull/8371"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8371"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8371/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8371/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8371/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/e2ee2502036892b3ee92f2be36e2f3287bb7d628"}}}}
{"actor":{"display_login":"miminar"}}