{"action":"created","issue":{"url":"https://api.github.com/repos/glossier/solidus_retail/issues/16","repository_url":"https://api.github.com/repos/glossier/solidus_retail","labels_url":"https://api.github.com/repos/glossier/solidus_retail/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/glossier/solidus_retail/issues/16/comments","events_url":"https://api.github.com/repos/glossier/solidus_retail/issues/16/events","html_url":"https://github.com/glossier/solidus_retail/pull/16","id":175902328,"number":16,"title":"Export variants (master variant) during the first export","user":{"login":"cabouffard","id":1725061,"avatar_url":"https://avatars.githubusercontent.com/u/1725061?v=3","gravatar_id":"","url":"https://api.github.com/users/cabouffard","html_url":"https://github.com/cabouffard","followers_url":"https://api.github.com/users/cabouffard/followers","following_url":"https://api.github.com/users/cabouffard/following{/other_user}","gists_url":"https://api.github.com/users/cabouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/cabouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabouffard/subscriptions","organizations_url":"https://api.github.com/users/cabouffard/orgs","repos_url":"https://api.github.com/users/cabouffard/repos","events_url":"https://api.github.com/users/cabouffard/events{/privacy}","received_events_url":"https://api.github.com/users/cabouffard/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/glossier/solidus_retail/labels/cr-ready","name":"cr-ready","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"cabouffard","id":1725061,"avatar_url":"https://avatars.githubusercontent.com/u/1725061?v=3","gravatar_id":"","url":"https://api.github.com/users/cabouffard","html_url":"https://github.com/cabouffard","followers_url":"https://api.github.com/users/cabouffard/followers","following_url":"https://api.github.com/users/cabouffard/following{/other_user}","gists_url":"https://api.github.com/users/cabouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/cabouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabouffard/subscriptions","organizations_url":"https://api.github.com/users/cabouffard/orgs","repos_url":"https://api.github.com/users/cabouffard/repos","events_url":"https://api.github.com/users/cabouffard/events{/privacy}","received_events_url":"https://api.github.com/users/cabouffard/received_events","type":"User","site_admin":false},"assignees":[{"login":"cabouffard","id":1725061,"avatar_url":"https://avatars.githubusercontent.com/u/1725061?v=3","gravatar_id":"","url":"https://api.github.com/users/cabouffard","html_url":"https://github.com/cabouffard","followers_url":"https://api.github.com/users/cabouffard/followers","following_url":"https://api.github.com/users/cabouffard/following{/other_user}","gists_url":"https://api.github.com/users/cabouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/cabouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabouffard/subscriptions","organizations_url":"https://api.github.com/users/cabouffard/orgs","repos_url":"https://api.github.com/users/cabouffard/repos","events_url":"https://api.github.com/users/cabouffard/events{/privacy}","received_events_url":"https://api.github.com/users/cabouffard/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-09-09T01:04:14Z","updated_at":"2016-09-22T13:32:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/glossier/solidus_retail/pulls/16","html_url":"https://github.com/glossier/solidus_retail/pull/16","diff_url":"https://github.com/glossier/solidus_retail/pull/16.diff","patch_url":"https://github.com/glossier/solidus_retail/pull/16.patch"},"body":"The way that it works right now is that the exporter will export the\r\nwhole product, which means all of its variant.\r\n\r\nUpdaters will now only update self. So if we go in the admin and we\r\ndecide to update a unique product or a unique variant, then it will\r\nupdate itself instead of saving the whole product will all of its\r\nvariant.\r\n\r\nThere is still some work to do in order to reduce the code that is\r\nduplicated but that should still be good for CRing.\r\n\r\nThe goal is to run the exporter only once at the beginning of the\r\nproject, so fill the Shopify store with proper data. We were kind of\r\nobligated to do that, since if we don't assign any variant to the\r\nproduct when we create it, it assigns a dummy variant that is hard to\r\nget rid of. I tried just to export the master variant when creating a\r\nnew product but it was really pain in the arse. This came out to be the\r\nbest solution I could come up with."},"comment":{"url":"https://api.github.com/repos/glossier/solidus_retail/issues/comments/248904151","html_url":"https://github.com/glossier/solidus_retail/pull/16#issuecomment-248904151","issue_url":"https://api.github.com/repos/glossier/solidus_retail/issues/16","id":248904151,"user":{"login":"bryanmtl","id":12205,"avatar_url":"https://avatars.githubusercontent.com/u/12205?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanmtl","html_url":"https://github.com/bryanmtl","followers_url":"https://api.github.com/users/bryanmtl/followers","following_url":"https://api.github.com/users/bryanmtl/following{/other_user}","gists_url":"https://api.github.com/users/bryanmtl/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanmtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanmtl/subscriptions","organizations_url":"https://api.github.com/users/bryanmtl/orgs","repos_url":"https://api.github.com/users/bryanmtl/repos","events_url":"https://api.github.com/users/bryanmtl/events{/privacy}","received_events_url":"https://api.github.com/users/bryanmtl/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T13:32:14Z","updated_at":"2016-09-22T13:32:14Z","body":"@cabouffard This LGTM. I will play around with the code locally early next week to get a better feel for it. In the meantime, I don't see anything here that would prevent us from merging. "}}
{"actor":{"display_login":"bryanmtl"}}