{"action":"created","comment":{"url":"https://api.github.com/repos/quassel/quassel/pulls/comments/58563152","id":58563152,"diff_hunk":"@@ -259,15 +259,16 @@ void Quassel::setupBuildInfo()\n     _buildInfo.baseVersion = QUASSEL_VERSION_STRING;\n     _buildInfo.generatedVersion = GIT_DESCRIBE;\n \n-    // This will be imprecise for incremental builds not touching this file, but we really don't want to always recompile\n-    _buildInfo.buildDate = QString(\"%1 %2\").arg(__DATE__, __TIME__);\n-\n     // Check if we got a commit hash\n-    if (!QString(GIT_HEAD).isEmpty())\n-        _buildInfo.commitHash = GIT_HEAD;\n+\tif (!QString(GIT_HEAD).isEmpty()) {","path":"src/common/quassel.cpp","position":10,"original_position":10,"commit_id":"ab8ba50c9daf6b449cc7273392ab4bf91d8d08ad","original_commit_id":"ab8ba50c9daf6b449cc7273392ab4bf91d8d08ad","user":{"login":"sir-ragna","id":1280559,"avatar_url":"https://avatars.githubusercontent.com/u/1280559?v=3","gravatar_id":"","url":"https://api.github.com/users/sir-ragna","html_url":"https://github.com/sir-ragna","followers_url":"https://api.github.com/users/sir-ragna/followers","following_url":"https://api.github.com/users/sir-ragna/following{/other_user}","gists_url":"https://api.github.com/users/sir-ragna/gists{/gist_id}","starred_url":"https://api.github.com/users/sir-ragna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sir-ragna/subscriptions","organizations_url":"https://api.github.com/users/sir-ragna/orgs","repos_url":"https://api.github.com/users/sir-ragna/repos","events_url":"https://api.github.com/users/sir-ragna/events{/privacy}","received_events_url":"https://api.github.com/users/sir-ragna/received_events","type":"User","site_admin":false},"body":"It seems that you used tabs here instead of spaces contrary to the rest of the project. (See also src/qtui/aboutdlg.cpp line 39)","created_at":"2016-04-05T15:48:13Z","updated_at":"2016-04-05T15:48:13Z","html_url":"https://github.com/quassel/quassel/pull/159#discussion_r58563152","pull_request_url":"https://api.github.com/repos/quassel/quassel/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/quassel/quassel/pulls/comments/58563152"},"html":{"href":"https://github.com/quassel/quassel/pull/159#discussion_r58563152"},"pull_request":{"href":"https://api.github.com/repos/quassel/quassel/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/quassel/quassel/pulls/159","id":50673292,"html_url":"https://github.com/quassel/quassel/pull/159","diff_url":"https://github.com/quassel/quassel/pull/159.diff","patch_url":"https://github.com/quassel/quassel/pull/159.patch","issue_url":"https://api.github.com/repos/quassel/quassel/issues/159","number":159,"state":"open","locked":false,"title":"Replace build date with commit date (Alternative to #127)","user":{"login":"romibi","id":2631786,"avatar_url":"https://avatars.githubusercontent.com/u/2631786?v=3","gravatar_id":"","url":"https://api.github.com/users/romibi","html_url":"https://github.com/romibi","followers_url":"https://api.github.com/users/romibi/followers","following_url":"https://api.github.com/users/romibi/following{/other_user}","gists_url":"https://api.github.com/users/romibi/gists{/gist_id}","starred_url":"https://api.github.com/users/romibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romibi/subscriptions","organizations_url":"https://api.github.com/users/romibi/orgs","repos_url":"https://api.github.com/users/romibi/repos","events_url":"https://api.github.com/users/romibi/events{/privacy}","received_events_url":"https://api.github.com/users/romibi/received_events","type":"User","site_admin":false},"body":"Alternative to and based on PR #127\r\n\r\nThis makes it possible to create reproducible builds.\r\n\r\nHere using the git-commit date instead of a dummy date\r\n\r\nSee also:\r\nhttps://wiki.debian.org/ReproducibleBuilds/About\r\n\r\n\r\nBecause I'm not yet very familiar with cmake and c++ please double check:\r\n* that I didn't overlook something and _buildInfo.commitDate was really not used! (changed from uint to QString)\r\n* that the change to CMakeLists.txt is ok...","created_at":"2015-11-13T18:17:15Z","updated_at":"2016-04-05T15:48:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9c8bcadc587fe054d6cc8082489003caa3aab52","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/quassel/quassel/pulls/159/commits","review_comments_url":"https://api.github.com/repos/quassel/quassel/pulls/159/comments","review_comment_url":"https://api.github.com/repos/quassel/quassel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quassel/quassel/issues/159/comments","statuses_url":"https://api.github.com/repos/quassel/quassel/statuses/ab8ba50c9daf6b449cc7273392ab4bf91d8d08ad","head":{"label":"romibi:reproducible","ref":"reproducible","sha":"ab8ba50c9daf6b449cc7273392ab4bf91d8d08ad","user":{"login":"romibi","id":2631786,"avatar_url":"https://avatars.githubusercontent.com/u/2631786?v=3","gravatar_id":"","url":"https://api.github.com/users/romibi","html_url":"https://github.com/romibi","followers_url":"https://api.github.com/users/romibi/followers","following_url":"https://api.github.com/users/romibi/following{/other_user}","gists_url":"https://api.github.com/users/romibi/gists{/gist_id}","starred_url":"https://api.github.com/users/romibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romibi/subscriptions","organizations_url":"https://api.github.com/users/romibi/orgs","repos_url":"https://api.github.com/users/romibi/repos","events_url":"https://api.github.com/users/romibi/events{/privacy}","received_events_url":"https://api.github.com/users/romibi/received_events","type":"User","site_admin":false},"repo":{"id":46115106,"name":"quassel","full_name":"romibi/quassel","owner":{"login":"romibi","id":2631786,"avatar_url":"https://avatars.githubusercontent.com/u/2631786?v=3","gravatar_id":"","url":"https://api.github.com/users/romibi","html_url":"https://github.com/romibi","followers_url":"https://api.github.com/users/romibi/followers","following_url":"https://api.github.com/users/romibi/following{/other_user}","gists_url":"https://api.github.com/users/romibi/gists{/gist_id}","starred_url":"https://api.github.com/users/romibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romibi/subscriptions","organizations_url":"https://api.github.com/users/romibi/orgs","repos_url":"https://api.github.com/users/romibi/repos","events_url":"https://api.github.com/users/romibi/events{/privacy}","received_events_url":"https://api.github.com/users/romibi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romibi/quassel","description":"Quassel IRC","fork":true,"url":"https://api.github.com/repos/romibi/quassel","forks_url":"https://api.github.com/repos/romibi/quassel/forks","keys_url":"https://api.github.com/repos/romibi/quassel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romibi/quassel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romibi/quassel/teams","hooks_url":"https://api.github.com/repos/romibi/quassel/hooks","issue_events_url":"https://api.github.com/repos/romibi/quassel/issues/events{/number}","events_url":"https://api.github.com/repos/romibi/quassel/events","assignees_url":"https://api.github.com/repos/romibi/quassel/assignees{/user}","branches_url":"https://api.github.com/repos/romibi/quassel/branches{/branch}","tags_url":"https://api.github.com/repos/romibi/quassel/tags","blobs_url":"https://api.github.com/repos/romibi/quassel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romibi/quassel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romibi/quassel/git/refs{/sha}","trees_url":"https://api.github.com/repos/romibi/quassel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romibi/quassel/statuses/{sha}","languages_url":"https://api.github.com/repos/romibi/quassel/languages","stargazers_url":"https://api.github.com/repos/romibi/quassel/stargazers","contributors_url":"https://api.github.com/repos/romibi/quassel/contributors","subscribers_url":"https://api.github.com/repos/romibi/quassel/subscribers","subscription_url":"https://api.github.com/repos/romibi/quassel/subscription","commits_url":"https://api.github.com/repos/romibi/quassel/commits{/sha}","git_commits_url":"https://api.github.com/repos/romibi/quassel/git/commits{/sha}","comments_url":"https://api.github.com/repos/romibi/quassel/comments{/number}","issue_comment_url":"https://api.github.com/repos/romibi/quassel/issues/comments{/number}","contents_url":"https://api.github.com/repos/romibi/quassel/contents/{+path}","compare_url":"https://api.github.com/repos/romibi/quassel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romibi/quassel/merges","archive_url":"https://api.github.com/repos/romibi/quassel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romibi/quassel/downloads","issues_url":"https://api.github.com/repos/romibi/quassel/issues{/number}","pulls_url":"https://api.github.com/repos/romibi/quassel/pulls{/number}","milestones_url":"https://api.github.com/repos/romibi/quassel/milestones{/number}","notifications_url":"https://api.github.com/repos/romibi/quassel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romibi/quassel/labels{/name}","releases_url":"https://api.github.com/repos/romibi/quassel/releases{/id}","deployments_url":"https://api.github.com/repos/romibi/quassel/deployments","created_at":"2015-11-13T10:19:15Z","updated_at":"2016-02-08T22:08:47Z","pushed_at":"2016-02-19T19:56:43Z","git_url":"git://github.com/romibi/quassel.git","ssh_url":"git@github.com:romibi/quassel.git","clone_url":"https://github.com/romibi/quassel.git","svn_url":"https://github.com/romibi/quassel","homepage":null,"size":23376,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quassel:master","ref":"master","sha":"b49c64970b6237fc95f8ca88c8bb6bcf04c251d7","user":{"login":"quassel","id":2965670,"avatar_url":"https://avatars.githubusercontent.com/u/2965670?v=3","gravatar_id":"","url":"https://api.github.com/users/quassel","html_url":"https://github.com/quassel","followers_url":"https://api.github.com/users/quassel/followers","following_url":"https://api.github.com/users/quassel/following{/other_user}","gists_url":"https://api.github.com/users/quassel/gists{/gist_id}","starred_url":"https://api.github.com/users/quassel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quassel/subscriptions","organizations_url":"https://api.github.com/users/quassel/orgs","repos_url":"https://api.github.com/users/quassel/repos","events_url":"https://api.github.com/users/quassel/events{/privacy}","received_events_url":"https://api.github.com/users/quassel/received_events","type":"Organization","site_admin":false},"repo":{"id":7007419,"name":"quassel","full_name":"quassel/quassel","owner":{"login":"quassel","id":2965670,"avatar_url":"https://avatars.githubusercontent.com/u/2965670?v=3","gravatar_id":"","url":"https://api.github.com/users/quassel","html_url":"https://github.com/quassel","followers_url":"https://api.github.com/users/quassel/followers","following_url":"https://api.github.com/users/quassel/following{/other_user}","gists_url":"https://api.github.com/users/quassel/gists{/gist_id}","starred_url":"https://api.github.com/users/quassel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quassel/subscriptions","organizations_url":"https://api.github.com/users/quassel/orgs","repos_url":"https://api.github.com/users/quassel/repos","events_url":"https://api.github.com/users/quassel/events{/privacy}","received_events_url":"https://api.github.com/users/quassel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quassel/quassel","description":"Quassel IRC","fork":false,"url":"https://api.github.com/repos/quassel/quassel","forks_url":"https://api.github.com/repos/quassel/quassel/forks","keys_url":"https://api.github.com/repos/quassel/quassel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quassel/quassel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quassel/quassel/teams","hooks_url":"https://api.github.com/repos/quassel/quassel/hooks","issue_events_url":"https://api.github.com/repos/quassel/quassel/issues/events{/number}","events_url":"https://api.github.com/repos/quassel/quassel/events","assignees_url":"https://api.github.com/repos/quassel/quassel/assignees{/user}","branches_url":"https://api.github.com/repos/quassel/quassel/branches{/branch}","tags_url":"https://api.github.com/repos/quassel/quassel/tags","blobs_url":"https://api.github.com/repos/quassel/quassel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quassel/quassel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quassel/quassel/git/refs{/sha}","trees_url":"https://api.github.com/repos/quassel/quassel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quassel/quassel/statuses/{sha}","languages_url":"https://api.github.com/repos/quassel/quassel/languages","stargazers_url":"https://api.github.com/repos/quassel/quassel/stargazers","contributors_url":"https://api.github.com/repos/quassel/quassel/contributors","subscribers_url":"https://api.github.com/repos/quassel/quassel/subscribers","subscription_url":"https://api.github.com/repos/quassel/quassel/subscription","commits_url":"https://api.github.com/repos/quassel/quassel/commits{/sha}","git_commits_url":"https://api.github.com/repos/quassel/quassel/git/commits{/sha}","comments_url":"https://api.github.com/repos/quassel/quassel/comments{/number}","issue_comment_url":"https://api.github.com/repos/quassel/quassel/issues/comments{/number}","contents_url":"https://api.github.com/repos/quassel/quassel/contents/{+path}","compare_url":"https://api.github.com/repos/quassel/quassel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quassel/quassel/merges","archive_url":"https://api.github.com/repos/quassel/quassel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quassel/quassel/downloads","issues_url":"https://api.github.com/repos/quassel/quassel/issues{/number}","pulls_url":"https://api.github.com/repos/quassel/quassel/pulls{/number}","milestones_url":"https://api.github.com/repos/quassel/quassel/milestones{/number}","notifications_url":"https://api.github.com/repos/quassel/quassel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quassel/quassel/labels{/name}","releases_url":"https://api.github.com/repos/quassel/quassel/releases{/id}","deployments_url":"https://api.github.com/repos/quassel/quassel/deployments","created_at":"2012-12-04T21:43:06Z","updated_at":"2016-04-03T15:46:54Z","pushed_at":"2016-04-03T17:38:36Z","git_url":"git://github.com/quassel/quassel.git","ssh_url":"git@github.com:quassel/quassel.git","clone_url":"https://github.com/quassel/quassel.git","svn_url":"https://github.com/quassel/quassel","homepage":null,"size":25151,"stargazers_count":267,"watchers_count":267,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":15,"forks":132,"open_issues":15,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quassel/quassel/pulls/159"},"html":{"href":"https://github.com/quassel/quassel/pull/159"},"issue":{"href":"https://api.github.com/repos/quassel/quassel/issues/159"},"comments":{"href":"https://api.github.com/repos/quassel/quassel/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/quassel/quassel/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/quassel/quassel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quassel/quassel/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/quassel/quassel/statuses/ab8ba50c9daf6b449cc7273392ab4bf91d8d08ad"}}}}