{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/54","id":87114246,"html_url":"https://github.com/vert-x3/vertx-stack/pull/54","diff_url":"https://github.com/vert-x3/vertx-stack/pull/54.diff","patch_url":"https://github.com/vert-x3/vertx-stack/pull/54.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-stack/issues/54","number":54,"state":"closed","locked":false,"title":"stack-docker: make the JVM get pid 1 to allow graceful shutdown","user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"body":"The \"sh -c\" entry point is nice to work around the Docker var replacement limitation in CMD statements.\r\nHowever the shell keeps running along with the JVM and the shell gets pid 1.\r\nConsequently, when you run `docker stop`, the shell process gets the SIGTERM signal, but does not forward it to the JVM.\r\nThis means Vert.x does not shutdown gracefully.\r\n\r\n`exec` allows the JVM process to replace the shell.","created_at":"2016-09-28T12:57:14Z","updated_at":"2016-09-28T16:36:53Z","closed_at":"2016-09-28T16:36:53Z","merged_at":"2016-09-28T16:36:53Z","merge_commit_sha":"65f8387da05c186394cc905b736a571316a8e330","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/54/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/54/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-stack/issues/54/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-stack/statuses/65f8387da05c186394cc905b736a571316a8e330","head":{"label":"tsegismont:make-jvm-pid-1","ref":"make-jvm-pid-1","sha":"65f8387da05c186394cc905b736a571316a8e330","user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"repo":{"id":46229242,"name":"vertx-stack","full_name":"tsegismont/vertx-stack","owner":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsegismont/vertx-stack","description":"Vert.x stack","fork":true,"url":"https://api.github.com/repos/tsegismont/vertx-stack","forks_url":"https://api.github.com/repos/tsegismont/vertx-stack/forks","keys_url":"https://api.github.com/repos/tsegismont/vertx-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsegismont/vertx-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsegismont/vertx-stack/teams","hooks_url":"https://api.github.com/repos/tsegismont/vertx-stack/hooks","issue_events_url":"https://api.github.com/repos/tsegismont/vertx-stack/issues/events{/number}","events_url":"https://api.github.com/repos/tsegismont/vertx-stack/events","assignees_url":"https://api.github.com/repos/tsegismont/vertx-stack/assignees{/user}","branches_url":"https://api.github.com/repos/tsegismont/vertx-stack/branches{/branch}","tags_url":"https://api.github.com/repos/tsegismont/vertx-stack/tags","blobs_url":"https://api.github.com/repos/tsegismont/vertx-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsegismont/vertx-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsegismont/vertx-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsegismont/vertx-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsegismont/vertx-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/tsegismont/vertx-stack/languages","stargazers_url":"https://api.github.com/repos/tsegismont/vertx-stack/stargazers","contributors_url":"https://api.github.com/repos/tsegismont/vertx-stack/contributors","subscribers_url":"https://api.github.com/repos/tsegismont/vertx-stack/subscribers","subscription_url":"https://api.github.com/repos/tsegismont/vertx-stack/subscription","commits_url":"https://api.github.com/repos/tsegismont/vertx-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsegismont/vertx-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsegismont/vertx-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsegismont/vertx-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsegismont/vertx-stack/contents/{+path}","compare_url":"https://api.github.com/repos/tsegismont/vertx-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsegismont/vertx-stack/merges","archive_url":"https://api.github.com/repos/tsegismont/vertx-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsegismont/vertx-stack/downloads","issues_url":"https://api.github.com/repos/tsegismont/vertx-stack/issues{/number}","pulls_url":"https://api.github.com/repos/tsegismont/vertx-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/tsegismont/vertx-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/tsegismont/vertx-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsegismont/vertx-stack/labels{/name}","releases_url":"https://api.github.com/repos/tsegismont/vertx-stack/releases{/id}","deployments_url":"https://api.github.com/repos/tsegismont/vertx-stack/deployments","created_at":"2015-11-15T18:03:22Z","updated_at":"2016-09-26T16:22:54Z","pushed_at":"2016-09-28T12:57:14Z","git_url":"git://github.com/tsegismont/vertx-stack.git","ssh_url":"git@github.com:tsegismont/vertx-stack.git","clone_url":"https://github.com/tsegismont/vertx-stack.git","svn_url":"https://github.com/tsegismont/vertx-stack","homepage":null,"size":437,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"367d36d6ae82dac53b16b6e1c7338ac1fa6bbd92","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":22686950,"name":"vertx-stack","full_name":"vert-x3/vertx-stack","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-stack","description":"Vert.x stack","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-stack","forks_url":"https://api.github.com/repos/vert-x3/vertx-stack/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-stack/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-stack/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-stack/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-stack/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-stack/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-stack/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-stack/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-stack/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-stack/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-stack/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-stack/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-stack/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-stack/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-stack/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-stack/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-stack/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-stack/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-stack/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-stack/deployments","created_at":"2014-08-06T15:05:50Z","updated_at":"2016-09-28T01:08:41Z","pushed_at":"2016-09-28T16:36:52Z","git_url":"git://github.com/vert-x3/vertx-stack.git","ssh_url":"git@github.com:vert-x3/vertx-stack.git","clone_url":"https://github.com/vert-x3/vertx-stack.git","svn_url":"https://github.com/vert-x3/vertx-stack","homepage":null,"size":542,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":3,"forks":28,"open_issues":3,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/54"},"html":{"href":"https://github.com/vert-x3/vertx-stack/pull/54"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-stack/issues/54"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-stack/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-stack/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-stack/statuses/65f8387da05c186394cc905b736a571316a8e330"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cescoffier","id":402301,"avatar_url":"https://avatars.githubusercontent.com/u/402301?v=3","gravatar_id":"","url":"https://api.github.com/users/cescoffier","html_url":"https://github.com/cescoffier","followers_url":"https://api.github.com/users/cescoffier/followers","following_url":"https://api.github.com/users/cescoffier/following{/other_user}","gists_url":"https://api.github.com/users/cescoffier/gists{/gist_id}","starred_url":"https://api.github.com/users/cescoffier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cescoffier/subscriptions","organizations_url":"https://api.github.com/users/cescoffier/orgs","repos_url":"https://api.github.com/users/cescoffier/repos","events_url":"https://api.github.com/users/cescoffier/events{/privacy}","received_events_url":"https://api.github.com/users/cescoffier/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":12,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"cescoffier"}}