{"action":"created","issue":{"url":"https://api.github.com/repos/gammapy/gammapy/issues/744","repository_url":"https://api.github.com/repos/gammapy/gammapy","labels_url":"https://api.github.com/repos/gammapy/gammapy/issues/744/labels{/name}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/744/comments","events_url":"https://api.github.com/repos/gammapy/gammapy/issues/744/events","html_url":"https://github.com/gammapy/gammapy/pull/744","id":185190450,"number":744,"title":"Change hi and low threshold for spectral extraction","user":{"login":"JouvinLea","id":14295716,"avatar_url":"https://avatars.githubusercontent.com/u/14295716?v=3","gravatar_id":"","url":"https://api.github.com/users/JouvinLea","html_url":"https://github.com/JouvinLea","followers_url":"https://api.github.com/users/JouvinLea/followers","following_url":"https://api.github.com/users/JouvinLea/following{/other_user}","gists_url":"https://api.github.com/users/JouvinLea/gists{/gist_id}","starred_url":"https://api.github.com/users/JouvinLea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JouvinLea/subscriptions","organizations_url":"https://api.github.com/users/JouvinLea/orgs","repos_url":"https://api.github.com/users/JouvinLea/repos","events_url":"https://api.github.com/users/JouvinLea/events{/privacy}","received_events_url":"https://api.github.com/users/JouvinLea/received_events","type":"User","site_admin":false},"labels":[{"id":52741016,"url":"https://api.github.com/repos/gammapy/gammapy/labels/cleanup","name":"cleanup","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"joleroi","id":11678435,"avatar_url":"https://avatars.githubusercontent.com/u/11678435?v=3","gravatar_id":"","url":"https://api.github.com/users/joleroi","html_url":"https://github.com/joleroi","followers_url":"https://api.github.com/users/joleroi/followers","following_url":"https://api.github.com/users/joleroi/following{/other_user}","gists_url":"https://api.github.com/users/joleroi/gists{/gist_id}","starred_url":"https://api.github.com/users/joleroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joleroi/subscriptions","organizations_url":"https://api.github.com/users/joleroi/orgs","repos_url":"https://api.github.com/users/joleroi/repos","events_url":"https://api.github.com/users/joleroi/events{/privacy}","received_events_url":"https://api.github.com/users/joleroi/received_events","type":"User","site_admin":false},"assignees":[{"login":"joleroi","id":11678435,"avatar_url":"https://avatars.githubusercontent.com/u/11678435?v=3","gravatar_id":"","url":"https://api.github.com/users/joleroi","html_url":"https://github.com/joleroi","followers_url":"https://api.github.com/users/joleroi/followers","following_url":"https://api.github.com/users/joleroi/following{/other_user}","gists_url":"https://api.github.com/users/joleroi/gists{/gist_id}","starred_url":"https://api.github.com/users/joleroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joleroi/subscriptions","organizations_url":"https://api.github.com/users/joleroi/orgs","repos_url":"https://api.github.com/users/joleroi/repos","events_url":"https://api.github.com/users/joleroi/events{/privacy}","received_events_url":"https://api.github.com/users/joleroi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/gammapy/gammapy/milestones/7","html_url":"https://github.com/gammapy/gammapy/milestones/0.5","labels_url":"https://api.github.com/repos/gammapy/gammapy/milestones/7/labels","id":1275561,"number":7,"title":"0.5","description":"","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":181,"state":"open","created_at":"2015-08-27T09:29:48Z","updated_at":"2016-10-28T10:45:05Z","due_on":"2016-09-27T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-10-25T18:01:36Z","updated_at":"2016-10-31T11:46:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/744","html_url":"https://github.com/gammapy/gammapy/pull/744","diff_url":"https://github.com/gammapy/gammapy/pull/744.diff","patch_url":"https://github.com/gammapy/gammapy/pull/744.patch"},"body":"I change the setter function for the low and hi threshold in spectrum extraction. For the moment you were taking the bin under/upper the user low/hi requested threshold. I think it's better to be less optimistic and to not take the energy reco bin where are located the hi or lo threshold. \n"},"comment":{"url":"https://api.github.com/repos/gammapy/gammapy/issues/comments/257273899","html_url":"https://github.com/gammapy/gammapy/pull/744#issuecomment-257273899","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/744","id":257273899,"user":{"login":"joleroi","id":11678435,"avatar_url":"https://avatars.githubusercontent.com/u/11678435?v=3","gravatar_id":"","url":"https://api.github.com/users/joleroi","html_url":"https://github.com/joleroi","followers_url":"https://api.github.com/users/joleroi/followers","following_url":"https://api.github.com/users/joleroi/following{/other_user}","gists_url":"https://api.github.com/users/joleroi/gists{/gist_id}","starred_url":"https://api.github.com/users/joleroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joleroi/subscriptions","organizations_url":"https://api.github.com/users/joleroi/orgs","repos_url":"https://api.github.com/users/joleroi/repos","events_url":"https://api.github.com/users/joleroi/events{/privacy}","received_events_url":"https://api.github.com/users/joleroi/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T11:46:55Z","updated_at":"2016-10-31T11:46:55Z","body":"I think you are right in not including the reco bins containing the thresholds, so :+1: to merge. I restarted the failing tests so see if they pass now (it was some connection timeout issue I guess)"}}
{"actor":{"display_login":"joleroi"}}