{"action":"created","issue":{"url":"https://api.github.com/repos/opencomputeproject/SAI/issues/247","repository_url":"https://api.github.com/repos/opencomputeproject/SAI","labels_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/247/comments","events_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/247/events","html_url":"https://github.com/opencomputeproject/SAI/pull/247","id":180423892,"number":247,"title":"[copp] Added copp tests","user":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-30T23:47:09Z","updated_at":"2016-11-03T22:34:11Z","closed_at":"2016-11-01T21:08:48Z","pull_request":{"url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/247","html_url":"https://github.com/opencomputeproject/SAI/pull/247","diff_url":"https://github.com/opencomputeproject/SAI/pull/247.diff","patch_url":"https://github.com/opencomputeproject/SAI/pull/247.patch"},"body":"- List of tests:\n- ARPTest\n- DHCPTest\n- LLDPTest\n- BGPTest\n- LACPTest\n- SNMPTest\n- SSHTest\n- IP2METest\n- DefaultTest\n- The test closely replicates SONIC's setup for copp, for the trap ids mentioned\n- above.\n\nSigned-off-by: hrachya@mellanox.com\n"},"comment":{"url":"https://api.github.com/repos/opencomputeproject/SAI/issues/comments/258294376","html_url":"https://github.com/opencomputeproject/SAI/pull/247#issuecomment-258294376","issue_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/247","id":258294376,"user":{"login":"vkochan-mlnx","id":22504264,"avatar_url":"https://avatars.githubusercontent.com/u/22504264?v=3","gravatar_id":"","url":"https://api.github.com/users/vkochan-mlnx","html_url":"https://github.com/vkochan-mlnx","followers_url":"https://api.github.com/users/vkochan-mlnx/followers","following_url":"https://api.github.com/users/vkochan-mlnx/following{/other_user}","gists_url":"https://api.github.com/users/vkochan-mlnx/gists{/gist_id}","starred_url":"https://api.github.com/users/vkochan-mlnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkochan-mlnx/subscriptions","organizations_url":"https://api.github.com/users/vkochan-mlnx/orgs","repos_url":"https://api.github.com/users/vkochan-mlnx/repos","events_url":"https://api.github.com/users/vkochan-mlnx/events{/privacy}","received_events_url":"https://api.github.com/users/vkochan-mlnx/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T22:34:11Z","updated_at":"2016-11-03T22:34:11Z","body":"Does anyone else can't run for example sail2.py tests after this pull-request ?\r\n\r\nI got:\r\n------------->8-------------------------------------------------------\r\nFAILED (errors=1)\r\nsail2.L2LagTest ... ERROR\r\n\r\n======================================================================\r\nERROR: sail2.L2LagTest\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"SAI/test/saithrift/tests/sai_base_test.py\", line 94, in setUp\r\n    ThriftInterface.setUp(self)\r\n  File \"SAI/test/saithrift/tests/sai_base_test.py\", line 79, in setUp\r\n    self.loadPortMap()\r\n  File \"SAI/test/saithrift/tests/sai_base_test.py\", line 41, in loadPortMap\r\n    if self.test_params.has_key(\"port_map\"):\r\nAttributeError: 'L2LagTest' object has no attribute 'test_params'\r\n----------------------8<-----------------------------------------------------------\r\n\r\nAnd looks like test_params needs to be set earlier before self.loadPortMap() will be loaded\r\nin sai_base_test.py:setUp(self) function."}}
{"actor":{"display_login":"vkochan-mlnx"}}