{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/76308648","id":76308648,"diff_hunk":"@@ -0,0 +1,72 @@\n+# Specify analysis options.\n+\n+# This file is the .analysis_options file used by Flutter editors, such as\n+# Atom. It is very similar to flutter_tools/flutter_analysis_options; the only\n+# difference (currently) is the public_member_api_docs option, which triggers\n+# too many messages to be used in editors.\n+\n+analyzer:\n+  language:\n+    enableStrictCallChecks: true\n+    enableSuperMixins: true\n+  strong-mode: true","path":"packages/flutter_tools/templates/create/.analysis_options.tmpl","position":null,"original_position":12,"commit_id":"89381afa3514051bb96047fc6eb8437dabcab653","original_commit_id":"d969edad378a6fdc6374fb31b1b494fa27963bec","user":{"login":"sethladd","id":5479,"avatar_url":"https://avatars.githubusercontent.com/u/5479?v=3","gravatar_id":"","url":"https://api.github.com/users/sethladd","html_url":"https://github.com/sethladd","followers_url":"https://api.github.com/users/sethladd/followers","following_url":"https://api.github.com/users/sethladd/following{/other_user}","gists_url":"https://api.github.com/users/sethladd/gists{/gist_id}","starred_url":"https://api.github.com/users/sethladd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethladd/subscriptions","organizations_url":"https://api.github.com/users/sethladd/orgs","repos_url":"https://api.github.com/users/sethladd/repos","events_url":"https://api.github.com/users/sethladd/events{/privacy}","received_events_url":"https://api.github.com/users/sethladd/received_events","type":"User","site_admin":false},"body":"Fair enough. Until we can define it, we probably don't want to turn it on\nby default.\nOn Thu, Aug 25, 2016 at 11:45 Ian Hickson <notifications@github.com> wrote:\n\n> In packages/flutter_tools/templates/create/.analysis_options.tmpl\n> <https://github.com/flutter/flutter/pull/5573#discussion_r76302190>:\n>\n> > @@ -0,0 +1,72 @@\n> > +# Specify analysis options.\n> > +\n> > +# This file is the .analysis_options file used by Flutter editors, such as\n> > +# Atom. It is very similar to flutter_tools/flutter_analysis_options; the only\n> > +# difference (currently) is the public_member_api_docs option, which triggers\n> > +# too many messages to be used in editors.\n> > +\n> > +analyzer:\n> > +  language:\n> > +    enableStrictCallChecks: true\n> > +    enableSuperMixins: true\n> > +  strong-mode: true\n>\n> Strong mode today, strong mode with the four strong_mode_* fields turned\n> off as we have them below, and strong mode for 2.0, are all very different\n> beasts. Given that many of our customers are coming from the JS \"types\n> shmypes\" school of programming, I doubt that they'd want strong mode as we\n> have it today, and trying to explain what strong mode means with all the\n> flags below turned to \"ignore\" is difficult (I'm not sure I could even tell\n> you what it means to be honest... we turned it on just to get a bit more\n> type checking, but as discussed elsewhere, we should probably not turn on\n> type checking by default).\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/flutter/flutter/pull/5573/files/d969edad378a6fdc6374fb31b1b494fa27963bec#r76302190>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAAVZxFnRaSRFfM5P7-MgsxHoPzkDPMGks5qjeLUgaJpZM4JsVqE>\n> .\n>\n","created_at":"2016-08-25T19:25:22Z","updated_at":"2016-08-25T19:25:22Z","html_url":"https://github.com/flutter/flutter/pull/5573#discussion_r76308648","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/5573","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/76308648"},"html":{"href":"https://github.com/flutter/flutter/pull/5573#discussion_r76308648"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5573"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/5573","id":82598161,"html_url":"https://github.com/flutter/flutter/pull/5573","diff_url":"https://github.com/flutter/flutter/pull/5573.diff","patch_url":"https://github.com/flutter/flutter/pull/5573.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/5573","number":5573,"state":"open","locked":false,"title":"add analysis_options to create project template","user":{"login":"danrubel","id":2891888,"avatar_url":"https://avatars.githubusercontent.com/u/2891888?v=3","gravatar_id":"","url":"https://api.github.com/users/danrubel","html_url":"https://github.com/danrubel","followers_url":"https://api.github.com/users/danrubel/followers","following_url":"https://api.github.com/users/danrubel/following{/other_user}","gists_url":"https://api.github.com/users/danrubel/gists{/gist_id}","starred_url":"https://api.github.com/users/danrubel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrubel/subscriptions","organizations_url":"https://api.github.com/users/danrubel/orgs","repos_url":"https://api.github.com/users/danrubel/repos","events_url":"https://api.github.com/users/danrubel/events{/privacy}","received_events_url":"https://api.github.com/users/danrubel/received_events","type":"User","site_admin":false},"body":"@devoncarew \r\nFixes https://github.com/flutter/flutter/issues/5488","created_at":"2016-08-24T18:58:44Z","updated_at":"2016-08-25T19:25:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95d105350e463c394ef1eb8918510c0309949d1d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/5573/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/5573/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/5573/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/89381afa3514051bb96047fc6eb8437dabcab653","head":{"label":"danrubel:create-proj-includes-analysis-options","ref":"create-proj-includes-analysis-options","sha":"89381afa3514051bb96047fc6eb8437dabcab653","user":{"login":"danrubel","id":2891888,"avatar_url":"https://avatars.githubusercontent.com/u/2891888?v=3","gravatar_id":"","url":"https://api.github.com/users/danrubel","html_url":"https://github.com/danrubel","followers_url":"https://api.github.com/users/danrubel/followers","following_url":"https://api.github.com/users/danrubel/following{/other_user}","gists_url":"https://api.github.com/users/danrubel/gists{/gist_id}","starred_url":"https://api.github.com/users/danrubel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrubel/subscriptions","organizations_url":"https://api.github.com/users/danrubel/orgs","repos_url":"https://api.github.com/users/danrubel/repos","events_url":"https://api.github.com/users/danrubel/events{/privacy}","received_events_url":"https://api.github.com/users/danrubel/received_events","type":"User","site_admin":false},"repo":{"id":66037711,"name":"flutter","full_name":"danrubel/flutter","owner":{"login":"danrubel","id":2891888,"avatar_url":"https://avatars.githubusercontent.com/u/2891888?v=3","gravatar_id":"","url":"https://api.github.com/users/danrubel","html_url":"https://github.com/danrubel","followers_url":"https://api.github.com/users/danrubel/followers","following_url":"https://api.github.com/users/danrubel/following{/other_user}","gists_url":"https://api.github.com/users/danrubel/gists{/gist_id}","starred_url":"https://api.github.com/users/danrubel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrubel/subscriptions","organizations_url":"https://api.github.com/users/danrubel/orgs","repos_url":"https://api.github.com/users/danrubel/repos","events_url":"https://api.github.com/users/danrubel/events{/privacy}","received_events_url":"https://api.github.com/users/danrubel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danrubel/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/danrubel/flutter","forks_url":"https://api.github.com/repos/danrubel/flutter/forks","keys_url":"https://api.github.com/repos/danrubel/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danrubel/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danrubel/flutter/teams","hooks_url":"https://api.github.com/repos/danrubel/flutter/hooks","issue_events_url":"https://api.github.com/repos/danrubel/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/danrubel/flutter/events","assignees_url":"https://api.github.com/repos/danrubel/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/danrubel/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/danrubel/flutter/tags","blobs_url":"https://api.github.com/repos/danrubel/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danrubel/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danrubel/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/danrubel/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danrubel/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/danrubel/flutter/languages","stargazers_url":"https://api.github.com/repos/danrubel/flutter/stargazers","contributors_url":"https://api.github.com/repos/danrubel/flutter/contributors","subscribers_url":"https://api.github.com/repos/danrubel/flutter/subscribers","subscription_url":"https://api.github.com/repos/danrubel/flutter/subscription","commits_url":"https://api.github.com/repos/danrubel/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/danrubel/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/danrubel/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/danrubel/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/danrubel/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/danrubel/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danrubel/flutter/merges","archive_url":"https://api.github.com/repos/danrubel/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danrubel/flutter/downloads","issues_url":"https://api.github.com/repos/danrubel/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/danrubel/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/danrubel/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/danrubel/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danrubel/flutter/labels{/name}","releases_url":"https://api.github.com/repos/danrubel/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/danrubel/flutter/deployments","created_at":"2016-08-18T23:40:06Z","updated_at":"2016-08-18T23:40:09Z","pushed_at":"2016-08-25T19:20:44Z","git_url":"git://github.com/danrubel/flutter.git","ssh_url":"git@github.com:danrubel/flutter.git","clone_url":"https://github.com/danrubel/flutter.git","svn_url":"https://github.com/danrubel/flutter","homepage":"https://flutter.io","size":21180,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"8c294a10b446ba185d6c5f8494e42cf02c24b6a1","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-08-25T14:49:57Z","pushed_at":"2016-08-25T19:16:22Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":115620,"stargazers_count":3175,"watchers_count":3175,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":345,"mirror_url":null,"open_issues_count":1307,"forks":345,"open_issues":1307,"watchers":3175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5573"},"html":{"href":"https://github.com/flutter/flutter/pull/5573"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/5573"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/5573/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5573/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/5573/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/89381afa3514051bb96047fc6eb8437dabcab653"}}}}
{"actor":{"display_login":"sethladd"}}