{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/socorro-collector/pulls/comments/69921258","id":69921258,"diff_hunk":"@@ -147,8 +146,8 @@ def setup_mocked_s3_storage(\n         if storage_class == 'BotoS3CrashStorage':\n             config.bucket_name = 'crash_storage'\n             s3 = BotoS3CrashStorage(config)\n-        elif storage_class == 'SupportReasonAPIStorage':\n-            s3 = SupportReasonAPIStorage(config)\n+        else:\n+            raise Exception('No such storage_class')","path":"collector/unittest/external/boto/test_crashstorage.py","position":15,"original_position":15,"commit_id":"396ebd5e2c52d73e6d9863765306765ab025fc79","original_commit_id":"396ebd5e2c52d73e6d9863765306765ab025fc79","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"This is in the test infrastructure so I don't think the exception class raised makes a difference.\r\n\r\nThe better fix is probably to remove the code that allows us to switch on the `storage_class` at all. I'll look at doing that.","created_at":"2016-07-07T14:52:43Z","updated_at":"2016-07-07T14:52:43Z","html_url":"https://github.com/mozilla/socorro-collector/pull/29#discussion_r69921258","pull_request_url":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro-collector/pulls/comments/69921258"},"html":{"href":"https://github.com/mozilla/socorro-collector/pull/29#discussion_r69921258"},"pull_request":{"href":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29","id":76514855,"html_url":"https://github.com/mozilla/socorro-collector/pull/29","diff_url":"https://github.com/mozilla/socorro-collector/pull/29.diff","patch_url":"https://github.com/mozilla/socorro-collector/pull/29.patch","issue_url":"https://api.github.com/repos/mozilla/socorro-collector/issues/29","number":29,"state":"open","locked":false,"title":"The culling: nix boto SupportReasonAPIStorage","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"We're not using this anymore and large portions of it are commented out.\r\n\r\nr?","created_at":"2016-07-06T22:49:13Z","updated_at":"2016-07-07T14:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf19d40a96d6f3de8afd157d1859b403674a77cc","assignee":{"login":"adngdb","id":328790,"avatar_url":"https://avatars.githubusercontent.com/u/328790?v=3","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"assignees":[{"login":"adngdb","id":328790,"avatar_url":"https://avatars.githubusercontent.com/u/328790?v=3","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29/commits","review_comments_url":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29/comments","review_comment_url":"https://api.github.com/repos/mozilla/socorro-collector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/socorro-collector/issues/29/comments","statuses_url":"https://api.github.com/repos/mozilla/socorro-collector/statuses/396ebd5e2c52d73e6d9863765306765ab025fc79","head":{"label":"willkg:the-culling","ref":"the-culling","sha":"396ebd5e2c52d73e6d9863765306765ab025fc79","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"repo":{"id":61642472,"name":"socorro-collector","full_name":"willkg/socorro-collector","owner":{"login":"willkg","id":820826,"avatar_url":"https://avatars.githubusercontent.com/u/820826?v=3","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willkg/socorro-collector","description":"Collector for Socorro","fork":true,"url":"https://api.github.com/repos/willkg/socorro-collector","forks_url":"https://api.github.com/repos/willkg/socorro-collector/forks","keys_url":"https://api.github.com/repos/willkg/socorro-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willkg/socorro-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willkg/socorro-collector/teams","hooks_url":"https://api.github.com/repos/willkg/socorro-collector/hooks","issue_events_url":"https://api.github.com/repos/willkg/socorro-collector/issues/events{/number}","events_url":"https://api.github.com/repos/willkg/socorro-collector/events","assignees_url":"https://api.github.com/repos/willkg/socorro-collector/assignees{/user}","branches_url":"https://api.github.com/repos/willkg/socorro-collector/branches{/branch}","tags_url":"https://api.github.com/repos/willkg/socorro-collector/tags","blobs_url":"https://api.github.com/repos/willkg/socorro-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willkg/socorro-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willkg/socorro-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/willkg/socorro-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willkg/socorro-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/willkg/socorro-collector/languages","stargazers_url":"https://api.github.com/repos/willkg/socorro-collector/stargazers","contributors_url":"https://api.github.com/repos/willkg/socorro-collector/contributors","subscribers_url":"https://api.github.com/repos/willkg/socorro-collector/subscribers","subscription_url":"https://api.github.com/repos/willkg/socorro-collector/subscription","commits_url":"https://api.github.com/repos/willkg/socorro-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/willkg/socorro-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/willkg/socorro-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/willkg/socorro-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/willkg/socorro-collector/contents/{+path}","compare_url":"https://api.github.com/repos/willkg/socorro-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willkg/socorro-collector/merges","archive_url":"https://api.github.com/repos/willkg/socorro-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willkg/socorro-collector/downloads","issues_url":"https://api.github.com/repos/willkg/socorro-collector/issues{/number}","pulls_url":"https://api.github.com/repos/willkg/socorro-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/willkg/socorro-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/willkg/socorro-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willkg/socorro-collector/labels{/name}","releases_url":"https://api.github.com/repos/willkg/socorro-collector/releases{/id}","deployments_url":"https://api.github.com/repos/willkg/socorro-collector/deployments","created_at":"2016-06-21T14:51:32Z","updated_at":"2016-06-21T14:51:33Z","pushed_at":"2016-07-06T22:48:55Z","git_url":"git://github.com/willkg/socorro-collector.git","ssh_url":"git@github.com:willkg/socorro-collector.git","clone_url":"https://github.com/willkg/socorro-collector.git","svn_url":"https://github.com/willkg/socorro-collector","homepage":null,"size":927,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"2f177754a46807d4b27dc577941f25b9c75239ec","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":55797226,"name":"socorro-collector","full_name":"mozilla/socorro-collector","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/socorro-collector","description":"Collector for Socorro","fork":false,"url":"https://api.github.com/repos/mozilla/socorro-collector","forks_url":"https://api.github.com/repos/mozilla/socorro-collector/forks","keys_url":"https://api.github.com/repos/mozilla/socorro-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/socorro-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/socorro-collector/teams","hooks_url":"https://api.github.com/repos/mozilla/socorro-collector/hooks","issue_events_url":"https://api.github.com/repos/mozilla/socorro-collector/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/socorro-collector/events","assignees_url":"https://api.github.com/repos/mozilla/socorro-collector/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/socorro-collector/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/socorro-collector/tags","blobs_url":"https://api.github.com/repos/mozilla/socorro-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/socorro-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/socorro-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/socorro-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/socorro-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/socorro-collector/languages","stargazers_url":"https://api.github.com/repos/mozilla/socorro-collector/stargazers","contributors_url":"https://api.github.com/repos/mozilla/socorro-collector/contributors","subscribers_url":"https://api.github.com/repos/mozilla/socorro-collector/subscribers","subscription_url":"https://api.github.com/repos/mozilla/socorro-collector/subscription","commits_url":"https://api.github.com/repos/mozilla/socorro-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/socorro-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/socorro-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/socorro-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/socorro-collector/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/socorro-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/socorro-collector/merges","archive_url":"https://api.github.com/repos/mozilla/socorro-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/socorro-collector/downloads","issues_url":"https://api.github.com/repos/mozilla/socorro-collector/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/socorro-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/socorro-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/socorro-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/socorro-collector/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/socorro-collector/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/socorro-collector/deployments","created_at":"2016-04-08T17:26:07Z","updated_at":"2016-06-28T08:04:14Z","pushed_at":"2016-07-06T22:49:14Z","git_url":"git://github.com/mozilla/socorro-collector.git","ssh_url":"git@github.com:mozilla/socorro-collector.git","clone_url":"https://github.com/mozilla/socorro-collector.git","svn_url":"https://github.com/mozilla/socorro-collector","homepage":"https://socorro-collector.readthedocs.io","size":930,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29"},"html":{"href":"https://github.com/mozilla/socorro-collector/pull/29"},"issue":{"href":"https://api.github.com/repos/mozilla/socorro-collector/issues/29"},"comments":{"href":"https://api.github.com/repos/mozilla/socorro-collector/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/socorro-collector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/socorro-collector/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/socorro-collector/statuses/396ebd5e2c52d73e6d9863765306765ab025fc79"}}}}
{"actor":{"display_login":"willkg"}}