{"action":"created","issue":{"url":"https://api.github.com/repos/racket/typed-racket/issues/473","repository_url":"https://api.github.com/repos/racket/typed-racket","labels_url":"https://api.github.com/repos/racket/typed-racket/issues/473/labels{/name}","comments_url":"https://api.github.com/repos/racket/typed-racket/issues/473/comments","events_url":"https://api.github.com/repos/racket/typed-racket/issues/473/events","html_url":"https://github.com/racket/typed-racket/pull/473","id":196193838,"number":473,"title":"fix intermittent error in 8e7f390","user":{"login":"pnwamk","id":3662058,"avatar_url":"https://avatars.githubusercontent.com/u/3662058?v=3","gravatar_id":"","url":"https://api.github.com/users/pnwamk","html_url":"https://github.com/pnwamk","followers_url":"https://api.github.com/users/pnwamk/followers","following_url":"https://api.github.com/users/pnwamk/following{/other_user}","gists_url":"https://api.github.com/users/pnwamk/gists{/gist_id}","starred_url":"https://api.github.com/users/pnwamk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnwamk/subscriptions","organizations_url":"https://api.github.com/users/pnwamk/orgs","repos_url":"https://api.github.com/users/pnwamk/repos","events_url":"https://api.github.com/users/pnwamk/events{/privacy}","received_events_url":"https://api.github.com/users/pnwamk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-17T03:44:45Z","updated_at":"2016-12-17T14:34:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/racket/typed-racket/pulls/473","html_url":"https://github.com/racket/typed-racket/pull/473","diff_url":"https://github.com/racket/typed-racket/pull/473.diff","patch_url":"https://github.com/racket/typed-racket/pull/473.patch"},"body":"This PR (1) removes some unnecessary nondeterminism from prop-ops and (2) fixes the issue where the `nested-poly` integration test would occasionally fail. Basically, the correctness of type checking currently relies on the `var-name-table` in `type-rep.rkt` being *persistent*... which seems odd and wrong, but that's definitely the issue. I removed the table entirely and that caused the error to consistently happen, and it seems like that program w/ its nested polymorphic applications is the only program I've run into that relied on that particular table being persistent.\r\n\r\nA better fix I think would be to further examine how the table is used and remove this requirement --- my initial assumption was that the table was just for error reporting and printing (so that users saw types w/ the same polymorphic variables that appeared in the program) but clearly its doing a little more than that."},"comment":{"url":"https://api.github.com/repos/racket/typed-racket/issues/comments/267765901","html_url":"https://github.com/racket/typed-racket/pull/473#issuecomment-267765901","issue_url":"https://api.github.com/repos/racket/typed-racket/issues/473","id":267765901,"user":{"login":"pnwamk","id":3662058,"avatar_url":"https://avatars.githubusercontent.com/u/3662058?v=3","gravatar_id":"","url":"https://api.github.com/users/pnwamk","html_url":"https://github.com/pnwamk","followers_url":"https://api.github.com/users/pnwamk/followers","following_url":"https://api.github.com/users/pnwamk/following{/other_user}","gists_url":"https://api.github.com/users/pnwamk/gists{/gist_id}","starred_url":"https://api.github.com/users/pnwamk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnwamk/subscriptions","organizations_url":"https://api.github.com/users/pnwamk/orgs","repos_url":"https://api.github.com/users/pnwamk/repos","events_url":"https://api.github.com/users/pnwamk/events{/privacy}","received_events_url":"https://api.github.com/users/pnwamk/received_events","type":"User","site_admin":false},"created_at":"2016-12-17T14:34:49Z","updated_at":"2016-12-17T14:34:49Z","body":"Again sorry for not being clear. The pull request that changes `make-weak-hash` to `make-hash` fixes the bug we saw. \r\n\r\nThe other changes (in prop-ops.rkt) are proactive so there is not nondeterminism in the `prop-ops` code that _could be_ the cause of issues in the future (especially since the deterministic version performs just as well!).\r\n"}}
{"actor":{"display_login":"pnwamk"}}