{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1196","repository_url":"https://api.github.com/repos/DynamoDS/DynamoRevit","labels_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1196/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1196/comments","events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1196/events","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1196","id":171878271,"number":1196,"title":"Preload ASM for Revit","user":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars.githubusercontent.com/u/5710686?v=3","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/labels/LGTM","name":"LGTM","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-18T11:22:59Z","updated_at":"2016-08-25T18:00:55Z","closed_at":"2016-08-19T03:05:20Z","pull_request":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1196","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1196","diff_url":"https://github.com/DynamoDS/DynamoRevit/pull/1196.diff","patch_url":"https://github.com/DynamoDS/DynamoRevit/pull/1196.patch"},"body":"### Purpose\r\n\r\nThis is a fix for [MAGN-10546] (http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-10546). \r\n\r\n### Background\r\n\r\nThe issue here was that in the presence of Alias 2017 installed, the wrong ASM version was being inherited (the version from Alias instead of from Revit 2017) and since LibG is incompatible with the version of ASM in Alias, it was refusing to load. As a result all geometry nodes are rendered useless. The reason for this is that installing Alias adds the Alias bin folder containing ASM binaries to the PATH envar, which is why these binaries took precedence over those from Revit. This could happen for any other Autodesk product that comes with an ASM installation. \r\n\r\n### Solution\r\n\r\nThe fix for this is to preload ASM binaries specifically from the Revit installation that is being used to host Dynamo just like we do in the case of DynamoSandbox. This way there is no confusion about the version of ASM that will be loaded for Dynamo-Revit and we can ensure that LibG will always load no matter which other Autodesk product is installed on the users system.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [X] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [ ] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] Snapshot of UI changes, if any.\r\n\r\n### Reviewers\r\n\r\n@sharadkjaiswal \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/comments/242483837","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1196#issuecomment-242483837","issue_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1196","id":242483837,"user":{"login":"QilongTang","id":3942418,"avatar_url":"https://avatars.githubusercontent.com/u/3942418?v=3","gravatar_id":"","url":"https://api.github.com/users/QilongTang","html_url":"https://github.com/QilongTang","followers_url":"https://api.github.com/users/QilongTang/followers","following_url":"https://api.github.com/users/QilongTang/following{/other_user}","gists_url":"https://api.github.com/users/QilongTang/gists{/gist_id}","starred_url":"https://api.github.com/users/QilongTang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QilongTang/subscriptions","organizations_url":"https://api.github.com/users/QilongTang/orgs","repos_url":"https://api.github.com/users/QilongTang/repos","events_url":"https://api.github.com/users/QilongTang/events{/privacy}","received_events_url":"https://api.github.com/users/QilongTang/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T18:00:55Z","updated_at":"2016-08-25T18:00:55Z","body":"@aparajit-pratap Can we cross merge this into Revit2018 branch as well?"}}
{"actor":{"display_login":"QilongTang"}}