{"action":"created","comment":{"url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/comments/75964503","id":75964503,"diff_hunk":"@@ -9,5 +10,7 @@ def __init__(self, topic=\"\", sensor_id=\"\", credentials_dir=False):\n     def destroy(self):\n         self.mqClient.disconnect()\n \n-    def publish(self, msg):\n+    def publish(self, msg, topic=None):\n+        if topic is not None:\n+            self.set_topic(topic)","path":"baa_messages/publisher/mqtt.py","position":15,"original_position":15,"commit_id":"95fdd8c7ad0cde931b0684a8724e04940c3e4fde","original_commit_id":"95fdd8c7ad0cde931b0684a8724e04940c3e4fde","user":{"login":"gwincr11","id":289882,"avatar_url":"https://avatars.githubusercontent.com/u/289882?v=3","gravatar_id":"","url":"https://api.github.com/users/gwincr11","html_url":"https://github.com/gwincr11","followers_url":"https://api.github.com/users/gwincr11/followers","following_url":"https://api.github.com/users/gwincr11/following{/other_user}","gists_url":"https://api.github.com/users/gwincr11/gists{/gist_id}","starred_url":"https://api.github.com/users/gwincr11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwincr11/subscriptions","organizations_url":"https://api.github.com/users/gwincr11/orgs","repos_url":"https://api.github.com/users/gwincr11/repos","events_url":"https://api.github.com/users/gwincr11/events{/privacy}","received_events_url":"https://api.github.com/users/gwincr11/received_events","type":"User","site_admin":false},"body":"Is there a way to put this in the abstract class and call it as a super method?","created_at":"2016-08-23T22:35:26Z","updated_at":"2016-08-23T22:35:26Z","html_url":"https://github.com/berkeleyapplied/baa_messages/pull/11#discussion_r75964503","pull_request_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/comments/75964503"},"html":{"href":"https://github.com/berkeleyapplied/baa_messages/pull/11#discussion_r75964503"},"pull_request":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11","id":82036941,"html_url":"https://github.com/berkeleyapplied/baa_messages/pull/11","diff_url":"https://github.com/berkeleyapplied/baa_messages/pull/11.diff","patch_url":"https://github.com/berkeleyapplied/baa_messages/pull/11.patch","issue_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/11","number":11,"state":"open","locked":false,"title":"Ssh schema factory","user":{"login":"hensh2ss","id":11616829,"avatar_url":"https://avatars.githubusercontent.com/u/11616829?v=3","gravatar_id":"","url":"https://api.github.com/users/hensh2ss","html_url":"https://github.com/hensh2ss","followers_url":"https://api.github.com/users/hensh2ss/followers","following_url":"https://api.github.com/users/hensh2ss/following{/other_user}","gists_url":"https://api.github.com/users/hensh2ss/gists{/gist_id}","starred_url":"https://api.github.com/users/hensh2ss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hensh2ss/subscriptions","organizations_url":"https://api.github.com/users/hensh2ss/orgs","repos_url":"https://api.github.com/users/hensh2ss/repos","events_url":"https://api.github.com/users/hensh2ss/events{/privacy}","received_events_url":"https://api.github.com/users/hensh2ss/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\n- Refactor the schema directory so that it faciliates extensiblity to sensor update and algorithm updates\r\n- Add a components module to house Component Factories and publisher (pub maps objects to topics and mqtt/kafka publishers)\r\n- Create more unit tests to check the functionality\r\n\r\nTo Do:\r\n- Check the validity of the thrift conversions in encoding (especially float values)\r\n- Check funtionality with IoT components\r\n- Do testing with sudo real data to check functionality\r\n- complete implementation of Sensor Factory\r\n- Start and complete implmentation of AlgorithmFactory\r\n- Build out integration with publishers\r\n\r\n@gwincr11 Please take a look at this (especially the components section and the restructuring of the schemas) and let me know what you think.  In the mean time I am going to work on the precision issue we discussed previously.  Also note that this will require some mods to your serverless to integrate","created_at":"2016-08-19T19:58:06Z","updated_at":"2016-08-23T22:35:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"682284060feabb53d2137178708886ef54226e9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11/commits","review_comments_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11/comments","review_comment_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/11/comments","statuses_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/statuses/95fdd8c7ad0cde931b0684a8724e04940c3e4fde","head":{"label":"berkeleyapplied:ssh_schema_factory","ref":"ssh_schema_factory","sha":"95fdd8c7ad0cde931b0684a8724e04940c3e4fde","user":{"login":"berkeleyapplied","id":9554969,"avatar_url":"https://avatars.githubusercontent.com/u/9554969?v=3","gravatar_id":"","url":"https://api.github.com/users/berkeleyapplied","html_url":"https://github.com/berkeleyapplied","followers_url":"https://api.github.com/users/berkeleyapplied/followers","following_url":"https://api.github.com/users/berkeleyapplied/following{/other_user}","gists_url":"https://api.github.com/users/berkeleyapplied/gists{/gist_id}","starred_url":"https://api.github.com/users/berkeleyapplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berkeleyapplied/subscriptions","organizations_url":"https://api.github.com/users/berkeleyapplied/orgs","repos_url":"https://api.github.com/users/berkeleyapplied/repos","events_url":"https://api.github.com/users/berkeleyapplied/events{/privacy}","received_events_url":"https://api.github.com/users/berkeleyapplied/received_events","type":"Organization","site_admin":false},"repo":{"id":64798615,"name":"baa_messages","full_name":"berkeleyapplied/baa_messages","owner":{"login":"berkeleyapplied","id":9554969,"avatar_url":"https://avatars.githubusercontent.com/u/9554969?v=3","gravatar_id":"","url":"https://api.github.com/users/berkeleyapplied","html_url":"https://github.com/berkeleyapplied","followers_url":"https://api.github.com/users/berkeleyapplied/followers","following_url":"https://api.github.com/users/berkeleyapplied/following{/other_user}","gists_url":"https://api.github.com/users/berkeleyapplied/gists{/gist_id}","starred_url":"https://api.github.com/users/berkeleyapplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berkeleyapplied/subscriptions","organizations_url":"https://api.github.com/users/berkeleyapplied/orgs","repos_url":"https://api.github.com/users/berkeleyapplied/repos","events_url":"https://api.github.com/users/berkeleyapplied/events{/privacy}","received_events_url":"https://api.github.com/users/berkeleyapplied/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/berkeleyapplied/baa_messages","description":null,"fork":false,"url":"https://api.github.com/repos/berkeleyapplied/baa_messages","forks_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/forks","keys_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/teams","hooks_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/hooks","issue_events_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/events{/number}","events_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/events","assignees_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/assignees{/user}","branches_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/branches{/branch}","tags_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/tags","blobs_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/refs{/sha}","trees_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/statuses/{sha}","languages_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/languages","stargazers_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/stargazers","contributors_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/contributors","subscribers_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/subscribers","subscription_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/subscription","commits_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/commits{/sha}","git_commits_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/commits{/sha}","comments_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/comments{/number}","issue_comment_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/comments{/number}","contents_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/contents/{+path}","compare_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/merges","archive_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/downloads","issues_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues{/number}","pulls_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls{/number}","milestones_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/milestones{/number}","notifications_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/labels{/name}","releases_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/releases{/id}","deployments_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/deployments","created_at":"2016-08-02T23:16:04Z","updated_at":"2016-08-09T19:55:25Z","pushed_at":"2016-08-23T19:44:32Z","git_url":"git://github.com/berkeleyapplied/baa_messages.git","ssh_url":"git@github.com:berkeleyapplied/baa_messages.git","clone_url":"https://github.com/berkeleyapplied/baa_messages.git","svn_url":"https://github.com/berkeleyapplied/baa_messages","homepage":null,"size":4962,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"berkeleyapplied:dev","ref":"dev","sha":"7c6e574e6aebc61fd0a729403b47672c4138a634","user":{"login":"berkeleyapplied","id":9554969,"avatar_url":"https://avatars.githubusercontent.com/u/9554969?v=3","gravatar_id":"","url":"https://api.github.com/users/berkeleyapplied","html_url":"https://github.com/berkeleyapplied","followers_url":"https://api.github.com/users/berkeleyapplied/followers","following_url":"https://api.github.com/users/berkeleyapplied/following{/other_user}","gists_url":"https://api.github.com/users/berkeleyapplied/gists{/gist_id}","starred_url":"https://api.github.com/users/berkeleyapplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berkeleyapplied/subscriptions","organizations_url":"https://api.github.com/users/berkeleyapplied/orgs","repos_url":"https://api.github.com/users/berkeleyapplied/repos","events_url":"https://api.github.com/users/berkeleyapplied/events{/privacy}","received_events_url":"https://api.github.com/users/berkeleyapplied/received_events","type":"Organization","site_admin":false},"repo":{"id":64798615,"name":"baa_messages","full_name":"berkeleyapplied/baa_messages","owner":{"login":"berkeleyapplied","id":9554969,"avatar_url":"https://avatars.githubusercontent.com/u/9554969?v=3","gravatar_id":"","url":"https://api.github.com/users/berkeleyapplied","html_url":"https://github.com/berkeleyapplied","followers_url":"https://api.github.com/users/berkeleyapplied/followers","following_url":"https://api.github.com/users/berkeleyapplied/following{/other_user}","gists_url":"https://api.github.com/users/berkeleyapplied/gists{/gist_id}","starred_url":"https://api.github.com/users/berkeleyapplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berkeleyapplied/subscriptions","organizations_url":"https://api.github.com/users/berkeleyapplied/orgs","repos_url":"https://api.github.com/users/berkeleyapplied/repos","events_url":"https://api.github.com/users/berkeleyapplied/events{/privacy}","received_events_url":"https://api.github.com/users/berkeleyapplied/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/berkeleyapplied/baa_messages","description":null,"fork":false,"url":"https://api.github.com/repos/berkeleyapplied/baa_messages","forks_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/forks","keys_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/teams","hooks_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/hooks","issue_events_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/events{/number}","events_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/events","assignees_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/assignees{/user}","branches_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/branches{/branch}","tags_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/tags","blobs_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/refs{/sha}","trees_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/statuses/{sha}","languages_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/languages","stargazers_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/stargazers","contributors_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/contributors","subscribers_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/subscribers","subscription_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/subscription","commits_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/commits{/sha}","git_commits_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/git/commits{/sha}","comments_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/comments{/number}","issue_comment_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/comments{/number}","contents_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/contents/{+path}","compare_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/merges","archive_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/downloads","issues_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues{/number}","pulls_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls{/number}","milestones_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/milestones{/number}","notifications_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/labels{/name}","releases_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/releases{/id}","deployments_url":"https://api.github.com/repos/berkeleyapplied/baa_messages/deployments","created_at":"2016-08-02T23:16:04Z","updated_at":"2016-08-09T19:55:25Z","pushed_at":"2016-08-23T19:44:32Z","git_url":"git://github.com/berkeleyapplied/baa_messages.git","ssh_url":"git@github.com:berkeleyapplied/baa_messages.git","clone_url":"https://github.com/berkeleyapplied/baa_messages.git","svn_url":"https://github.com/berkeleyapplied/baa_messages","homepage":null,"size":4962,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11"},"html":{"href":"https://github.com/berkeleyapplied/baa_messages/pull/11"},"issue":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/11"},"comments":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/berkeleyapplied/baa_messages/statuses/95fdd8c7ad0cde931b0684a8724e04940c3e4fde"}}}}
{"actor":{"display_login":"gwincr11"}}