{"action":"created","issue":{"url":"https://api.github.com/repos/zo0r/react-native-push-notification/issues/158","repository_url":"https://api.github.com/repos/zo0r/react-native-push-notification","labels_url":"https://api.github.com/repos/zo0r/react-native-push-notification/issues/158/labels{/name}","comments_url":"https://api.github.com/repos/zo0r/react-native-push-notification/issues/158/comments","events_url":"https://api.github.com/repos/zo0r/react-native-push-notification/issues/158/events","html_url":"https://github.com/zo0r/react-native-push-notification/issues/158","id":167859388,"number":158,"title":"Android build error with react-native@0.30.0","user":{"login":"jpapillon","id":3585712,"avatar_url":"https://avatars.githubusercontent.com/u/3585712?v=3","gravatar_id":"","url":"https://api.github.com/users/jpapillon","html_url":"https://github.com/jpapillon","followers_url":"https://api.github.com/users/jpapillon/followers","following_url":"https://api.github.com/users/jpapillon/following{/other_user}","gists_url":"https://api.github.com/users/jpapillon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpapillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpapillon/subscriptions","organizations_url":"https://api.github.com/users/jpapillon/orgs","repos_url":"https://api.github.com/users/jpapillon/repos","events_url":"https://api.github.com/users/jpapillon/events{/privacy}","received_events_url":"https://api.github.com/users/jpapillon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":35,"created_at":"2016-07-27T13:53:01Z","updated_at":"2016-09-12T16:21:06Z","closed_at":null,"body":"I get this error when building with `react-native@0.30.0`:\r\n```\r\nnode_modules/react-native-push-notification/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java:64: error: method does not override or implement a method from a supertype\r\n    @Override\r\n    ^\r\n1 error\r\n```\r\n[Quick link to line](https://github.com/zo0r/react-native-push-notification/blob/2ee0c696f8eb108a678658aaeb1e61370d9a87bd/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotification.java#L64)"},"comment":{"url":"https://api.github.com/repos/zo0r/react-native-push-notification/issues/comments/246402632","html_url":"https://github.com/zo0r/react-native-push-notification/issues/158#issuecomment-246402632","issue_url":"https://api.github.com/repos/zo0r/react-native-push-notification/issues/158","id":246402632,"user":{"login":"npomfret","id":5489469,"avatar_url":"https://avatars.githubusercontent.com/u/5489469?v=3","gravatar_id":"","url":"https://api.github.com/users/npomfret","html_url":"https://github.com/npomfret","followers_url":"https://api.github.com/users/npomfret/followers","following_url":"https://api.github.com/users/npomfret/following{/other_user}","gists_url":"https://api.github.com/users/npomfret/gists{/gist_id}","starred_url":"https://api.github.com/users/npomfret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npomfret/subscriptions","organizations_url":"https://api.github.com/users/npomfret/orgs","repos_url":"https://api.github.com/users/npomfret/repos","events_url":"https://api.github.com/users/npomfret/events{/privacy}","received_events_url":"https://api.github.com/users/npomfret/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T16:21:05Z","updated_at":"2016-09-12T16:21:05Z","body":"That's good that it works on RN0.33 because I've been testing on rn0.32 (haddn't tried 33 yet).  Hold off on the release though, it was quite a big change.  Wouldn't mind getting a few people to try it first.\r\n\r\nTo fix the incompatibility problem I took out the `@Override` annotations, and left both implementations of the problematic method in.  So I think thats why it works with RN33 and earlier now.  It was a guest though, apologies if its not correct.\r\n\r\nThe annotations are only a compile-time tool and have no effect at runtime. In a sense they're totally optional.  IMO it's always a good idea to use them, commenting them out is a hack, but until its decided that this project only supports the latests RN (maybe?) then I guess we can leave both implementations of the method in.\r\n\r\nI'd suggest that supporting more than 1 version of RN is going to be a nightmare.  Perhaps each time RN because incompatible we simply make a branch for the old one, and keep master compatible with the latest RN?  Then just link to the branch on the README file for this people who want the old version."}}
{"actor":{"display_login":"npomfret"}}