{"action":"created","issue":{"url":"https://api.github.com/repos/adaptivecomputing/torque/issues/348","repository_url":"https://api.github.com/repos/adaptivecomputing/torque","labels_url":"https://api.github.com/repos/adaptivecomputing/torque/issues/348/labels{/name}","comments_url":"https://api.github.com/repos/adaptivecomputing/torque/issues/348/comments","events_url":"https://api.github.com/repos/adaptivecomputing/torque/issues/348/events","html_url":"https://github.com/adaptivecomputing/torque/pull/348","id":139344018,"number":348,"title":"Error notes should begin with \"ERROR -\" instead of just \"ERROR\", \"ERROR\" is too generic","user":{"login":"starboarder2001","id":5209230,"avatar_url":"https://avatars.githubusercontent.com/u/5209230?v=3","gravatar_id":"","url":"https://api.github.com/users/starboarder2001","html_url":"https://github.com/starboarder2001","followers_url":"https://api.github.com/users/starboarder2001/followers","following_url":"https://api.github.com/users/starboarder2001/following{/other_user}","gists_url":"https://api.github.com/users/starboarder2001/gists{/gist_id}","starred_url":"https://api.github.com/users/starboarder2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starboarder2001/subscriptions","organizations_url":"https://api.github.com/users/starboarder2001/orgs","repos_url":"https://api.github.com/users/starboarder2001/repos","events_url":"https://api.github.com/users/starboarder2001/events{/privacy}","received_events_url":"https://api.github.com/users/starboarder2001/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-08T17:41:59Z","updated_at":"2016-03-08T17:52:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adaptivecomputing/torque/pulls/348","html_url":"https://github.com/adaptivecomputing/torque/pull/348","diff_url":"https://github.com/adaptivecomputing/torque/pull/348.diff","patch_url":"https://github.com/adaptivecomputing/torque/pull/348.patch"},"body":"nhc (node health check) outputs to STDOUT \"ERROR: some message\" and has never caused any issues with torque release prior to 6.0.1. With torque 6.0.1 this is interpreted as an error to append to the note, this is not the desired or expected behavior.\r\n\r\nCan you provide some background as to why this feature was needed? I don't want to break compatibility if this is a well documented and used feature.\r\n\r\nI was not able to run the unit tests to verify this change doesn't break them, do you have instructions for running the unit tests?\r\n\r\n-David"},"comment":{"url":"https://api.github.com/repos/adaptivecomputing/torque/issues/comments/193889452","html_url":"https://github.com/adaptivecomputing/torque/pull/348#issuecomment-193889452","issue_url":"https://api.github.com/repos/adaptivecomputing/torque/issues/348","id":193889452,"user":{"login":"knielson","id":2130972,"avatar_url":"https://avatars.githubusercontent.com/u/2130972?v=3","gravatar_id":"","url":"https://api.github.com/users/knielson","html_url":"https://github.com/knielson","followers_url":"https://api.github.com/users/knielson/followers","following_url":"https://api.github.com/users/knielson/following{/other_user}","gists_url":"https://api.github.com/users/knielson/gists{/gist_id}","starred_url":"https://api.github.com/users/knielson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knielson/subscriptions","organizations_url":"https://api.github.com/users/knielson/orgs","repos_url":"https://api.github.com/users/knielson/repos","events_url":"https://api.github.com/users/knielson/events{/privacy}","received_events_url":"https://api.github.com/users/knielson/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T17:52:45Z","updated_at":"2016-03-08T17:52:45Z","body":"David,\n\nTo run unit tests make sure check is installed on your system. Next on the\nconfigure line add --with-check. To run the tests do a make check.\n\nKen\n\nOn Tue, Mar 8, 2016 at 10:42 AM, David Whiteside <notifications@github.com>\nwrote:\n\n> nhc (node health check) outputs to STDOUT \"ERROR: some message\" and has\n> never caused any issues with torque release prior to 6.0.1. With torque\n> 6.0.1 this is interpreted as an error to append to the note, this is not\n> the desired or expected behavior.\n>\n> Can you provide some background as to why this feature was needed? I don't\n> want to break compatibility if this is a well documented and used feature.\n>\n> I was not able to run the unit tests to verify this change doesn't break\n> them, do you have instructions for running the unit tests?\n>\n> -David\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/adaptivecomputing/torque/pull/348\n> Commit Summary\n>\n>    - make errors begin with \"ERROR -\" instead of just \"ERROR\", its too\n>    generic and breaks existing node check scripts such as nhc (node health\n>    check)\n>\n> File Changes\n>\n>    - *M* src/server/process_mom_update.c\n>    <https://github.com/adaptivecomputing/torque/pull/348/files#diff-0>\n>    (2)\n>    - *M* src/test/process_mom_update/test_uut.c\n>    <https://github.com/adaptivecomputing/torque/pull/348/files#diff-1>\n>    (4)\n>\n> Patch Links:\n>\n>    - https://github.com/adaptivecomputing/torque/pull/348.patch\n>    - https://github.com/adaptivecomputing/torque/pull/348.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/adaptivecomputing/torque/pull/348>.\n>\n\n\n\n-- \n[image: Adaptive Computing] <http://www.adaptivecomputing.com>\n[image: Twitter] <http://twitter.com/AdaptiveMoab> [image: LinkedIn]\n<http://www.linkedin.com/company/448673?goback=.fcs_GLHD_adaptive+computing_false_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2&trk=ncsrch_hits>\n[image:\nYouTube] <http://www.youtube.com/adaptivecomputing> [image: GooglePlus]\n<https://plus.google.com/u/0/102155039310685515037/posts> [image: Facebook]\n<http://www.facebook.com/pages/Adaptive-Computing/314449798572695?fref=ts>\n[image:\nRSS] <http://www.adaptivecomputing.com/feed>\nKen Nielson Sr. Software Engineer\n+1 801.717.3700 office    +1 801.717.3738 fax\n1712 S. East Bay Blvd, Suite 300     Provo, UT 84606\nwww.adaptivecomputing.com\n"}}