{"action":"created","issue":{"url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/88","repository_url":"https://api.github.com/repos/Keno/Polynomials.jl","labels_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/88/comments","events_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/88/events","html_url":"https://github.com/Keno/Polynomials.jl/pull/88","id":195081484,"number":88,"title":"Handle `NaN`s in `Poly` objects and do some cleanup","user":{"login":"aytekinar","id":8845951,"avatar_url":"https://avatars.githubusercontent.com/u/8845951?v=3","gravatar_id":"","url":"https://api.github.com/users/aytekinar","html_url":"https://github.com/aytekinar","followers_url":"https://api.github.com/users/aytekinar/followers","following_url":"https://api.github.com/users/aytekinar/following{/other_user}","gists_url":"https://api.github.com/users/aytekinar/gists{/gist_id}","starred_url":"https://api.github.com/users/aytekinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aytekinar/subscriptions","organizations_url":"https://api.github.com/users/aytekinar/orgs","repos_url":"https://api.github.com/users/aytekinar/repos","events_url":"https://api.github.com/users/aytekinar/events{/privacy}","received_events_url":"https://api.github.com/users/aytekinar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-12T20:48:28Z","updated_at":"2016-12-14T23:40:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Keno/Polynomials.jl/pulls/88","html_url":"https://github.com/Keno/Polynomials.jl/pull/88","diff_url":"https://github.com/Keno/Polynomials.jl/pull/88.diff","patch_url":"https://github.com/Keno/Polynomials.jl/pull/88.patch"},"body":"Modified:\r\n\r\n- [x] `polyder` and `polyint` so that they return `NaN` when appropriate.\r\n\r\nBonus:\r\n\r\n- [x] Relaxed `polyval`, `polyder` and `polyint` to evaluate at `AbstractArray`s\r\n  of `Poly{T}`s,\r\n- [x] Implemented `isequal` to check `hash`es of `Poly`s for comparison,\r\n- [x] Removed `ctranspose` to avoid problems when dealing with\r\n  `AbstractArray`s of `Poly`s (see #85),\r\n- [x] Added `dot` and `transpose` for `Poly` objects (see #85),\r\n\r\nPasses all tests.\r\n\r\nFixes #80 and #87.\r\nCloses #85."},"comment":{"url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/comments/267191641","html_url":"https://github.com/Keno/Polynomials.jl/pull/88#issuecomment-267191641","issue_url":"https://api.github.com/repos/Keno/Polynomials.jl/issues/88","id":267191641,"user":{"login":"jverzani","id":421708,"avatar_url":"https://avatars.githubusercontent.com/u/421708?v=3","gravatar_id":"","url":"https://api.github.com/users/jverzani","html_url":"https://github.com/jverzani","followers_url":"https://api.github.com/users/jverzani/followers","following_url":"https://api.github.com/users/jverzani/following{/other_user}","gists_url":"https://api.github.com/users/jverzani/gists{/gist_id}","starred_url":"https://api.github.com/users/jverzani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverzani/subscriptions","organizations_url":"https://api.github.com/users/jverzani/orgs","repos_url":"https://api.github.com/users/jverzani/repos","events_url":"https://api.github.com/users/jverzani/events{/privacy}","received_events_url":"https://api.github.com/users/jverzani/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T23:40:32Z","updated_at":"2016-12-14T23:40:32Z","body":"I don't think this check (`isnan(k)`) is needed, as it gets caught in the\ncomputation, though admittedly, this gets to it faster.\n\nOn Wed, Dec 14, 2016 at 6:38 PM, Arda Aytekin <notifications@github.com>\nwrote:\n\n> I cannot rely on isnan(k), directly, either, since Mod2 was also a Number,\n> which did not have its isnan defined.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Keno/Polynomials.jl/pull/88#issuecomment-267191215>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAZvTN05UEe59-ObCyejbTkaar9u47-dks5rIH3YgaJpZM4LLAdn>\n> .\n>\n\n\n\n-- \nJohn Verzani\nChair, Department of Mathematics\nCollege of Staten Island, CUNY\nverzani@math.csi.cuny.edu\n"}}
{"actor":{"display_login":"jverzani"}}