{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/68606582","id":68606582,"diff_hunk":"@@ -7,6 +7,7 @@\n  * of patent rights can be found in the PATENTS file in the same directory.\n  *\n  * @providesModule ReactReconcileTransaction\n+ * @flow weak","path":"src/renderers/dom/client/ReactReconcileTransaction.js","position":4,"original_position":4,"commit_id":"25f05564a9589d12112ac471e67d236a0d981e74","original_commit_id":"565dfbbeb5f4ed23bfa23ee2129ccf45f9403342","user":{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?v=3","gravatar_id":"","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false},"body":"For instance, I think you could add `@flow weak` everywhere in this codebase without raising much issues. The upside would be that flow could still emit warnings on very risky things it managed to infer.","created_at":"2016-06-27T16:16:57Z","updated_at":"2016-06-27T16:16:57Z","html_url":"https://github.com/facebook/react/pull/7127#discussion_r68606582","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/7127","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/68606582"},"html":{"href":"https://github.com/facebook/react/pull/7127#discussion_r68606582"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/7127"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/7127","id":75276159,"html_url":"https://github.com/facebook/react/pull/7127","diff_url":"https://github.com/facebook/react/pull/7127.diff","patch_url":"https://github.com/facebook/react/pull/7127.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/7127","number":7127,"state":"open","locked":false,"title":"Trigger a proper no-op warning for async state changes on server","user":{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?v=3","gravatar_id":"","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false},"body":"This commit fixes #5473: ReactDOMServer.renderToString: presence of onClick\r\nhandler causes errors on async update\r\n\r\nThis commit performs the following changes:\r\n\r\n- Adds a getUpdateQueue method to  ReactServerRenderingTransaction,\r\n  ReactReconcileTransaction, ReactNativeReconcileTransaction and\r\n  ReactTestReconcileTransaction\r\n- Make the ReactCompositeComponent call this getUpdateQueue instead of using\r\n  ReactUpdateQueue that was unwanted at certain moments on server\r\n- On ReactServerRenderingTransaction, dispatch ReactUpdateQueue's methods\r\n  while rendering and ReactNoopUpdateQueue's methods afterwards\r\n- Added a test that mimics the case presented in #5473 with setState and\r\n  replaceState","created_at":"2016-06-27T08:55:30Z","updated_at":"2016-06-27T16:16:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"328ac319488db53d30b3be300c0041e79a3accc2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/7127/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/7127/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/7127/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/25f05564a9589d12112ac471e67d236a0d981e74","head":{"label":"rricard:fix-5473","ref":"fix-5473","sha":"25f05564a9589d12112ac471e67d236a0d981e74","user":{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?v=3","gravatar_id":"","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false},"repo":{"id":62010851,"name":"react","full_name":"rricard/react","owner":{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?v=3","gravatar_id":"","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rricard/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/rricard/react","forks_url":"https://api.github.com/repos/rricard/react/forks","keys_url":"https://api.github.com/repos/rricard/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rricard/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rricard/react/teams","hooks_url":"https://api.github.com/repos/rricard/react/hooks","issue_events_url":"https://api.github.com/repos/rricard/react/issues/events{/number}","events_url":"https://api.github.com/repos/rricard/react/events","assignees_url":"https://api.github.com/repos/rricard/react/assignees{/user}","branches_url":"https://api.github.com/repos/rricard/react/branches{/branch}","tags_url":"https://api.github.com/repos/rricard/react/tags","blobs_url":"https://api.github.com/repos/rricard/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rricard/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rricard/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/rricard/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rricard/react/statuses/{sha}","languages_url":"https://api.github.com/repos/rricard/react/languages","stargazers_url":"https://api.github.com/repos/rricard/react/stargazers","contributors_url":"https://api.github.com/repos/rricard/react/contributors","subscribers_url":"https://api.github.com/repos/rricard/react/subscribers","subscription_url":"https://api.github.com/repos/rricard/react/subscription","commits_url":"https://api.github.com/repos/rricard/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/rricard/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/rricard/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/rricard/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/rricard/react/contents/{+path}","compare_url":"https://api.github.com/repos/rricard/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rricard/react/merges","archive_url":"https://api.github.com/repos/rricard/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rricard/react/downloads","issues_url":"https://api.github.com/repos/rricard/react/issues{/number}","pulls_url":"https://api.github.com/repos/rricard/react/pulls{/number}","milestones_url":"https://api.github.com/repos/rricard/react/milestones{/number}","notifications_url":"https://api.github.com/repos/rricard/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rricard/react/labels{/name}","releases_url":"https://api.github.com/repos/rricard/react/releases{/id}","deployments_url":"https://api.github.com/repos/rricard/react/deployments","created_at":"2016-06-26T22:20:10Z","updated_at":"2016-06-26T22:20:14Z","pushed_at":"2016-06-27T14:21:56Z","git_url":"git://github.com/rricard/react.git","ssh_url":"git@github.com:rricard/react.git","clone_url":"https://github.com/rricard/react.git","svn_url":"https://github.com/rricard/react","homepage":"https://facebook.github.io/react/","size":94403,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a49b7a2dfb57852264eb83a7510490d19268089c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-06-27T15:59:22Z","pushed_at":"2016-06-27T16:14:14Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":117893,"stargazers_count":44328,"watchers_count":44328,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7659,"mirror_url":null,"open_issues_count":548,"forks":7659,"open_issues":548,"watchers":44328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/7127"},"html":{"href":"https://github.com/facebook/react/pull/7127"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/7127"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/7127/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/7127/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/7127/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/25f05564a9589d12112ac471e67d236a0d981e74"}}}}
{"actor":{"display_login":"rricard"}}