{"action":"created","comment":{"url":"https://api.github.com/repos/haypo/fatoptimizer/pulls/comments/67423480","id":67423480,"diff_hunk":"@@ -3206,6 +3206,70 @@ def test_str_encode(self):\n         self.check_dont_optimize(r'\"ab\\xff\".encode(\"big5\")')\n         self.check_dont_optimize(r'\"ab\\xff\".encode(\"ascii\", \"backslashreplace\")')\n \n+    def test_str_lower(self):\n+        self.check_optimize(r'\"ABC\".lower()', '\"abc\"')\n+\n+    def test_str_upper(self):\n+        self.check_optimize(r'\"ABC\".upper()', '\"ABC\"')\n+\n+    def test_str_capitalize(self):\n+        self.check_optimize(r'\"abc\".capitalize()', '\"Abc\"')\n+\n+    def test_str_swapcase(self):\n+        self.check_optimize(r'\"aBc\".swapcase()', '\"AbC\"')\n+\n+    def test_str_casefold(self):\n+        self.check_optimize(r'\"ABC\".casefold()', '\"abc\"')\n+        self.check_optimize(r'\"ß\".casefold()', '\"ss\"')\n+\n+    def test_str_isalpha(self):\n+        self.check_optimize(r'\"\".isalpha()', 'False')\n+        self.check_optimize(r'\"123\".isalpha()', 'False')\n+        self.check_optimize(r'\"abc123\".isalpha()', 'False')\n+        self.check_optimize(r'\"abcß\".isalpha()', 'True')\n+\n+    def test_str_isalnum(self):\n+        self.check_optimize(r'\"\".isalnum()', 'False')\n+        self.check_optimize(r'\"abc123\".isalnum()', 'True')\n+        self.check_optimize(r'\"abc123\".isalnum()', 'True')\n+        self.check_optimize(r'\"abc123ß\".isalnum()', 'True')\n+\n+    def test_str_isdecimal(self):\n+        self.check_optimize(r'\"\".isdecimal()', 'False')\n+        self.check_optimize(r'\"abc\".isdecimal()', 'False')\n+        self.check_optimize(r'\"\\u00B2\".isdecimal()', 'False')\n+        self.check_optimize(r'\"\\u00BD\".isdecimal()', 'False')\n+        self.check_optimize(r'\"1.0\".isdecimal()', 'False')\n+        self.check_optimize(r'\"1\".isdecimal()', 'True')\n+\n+    def test_str_isdigit(self):\n+        self.check_optimize(r'\"\".isdigit()', 'False')\n+        self.check_optimize(r'\"abc\".isdigit()', 'False')\n+        self.check_optimize(r'\"\\u00B2\".isdigit()', 'True')\n+        self.check_optimize(r'\"\\u00BD\".isdigit()', 'False')\n+        self.check_optimize(r'\"1.0\".isdigit()', 'False')\n+        self.check_optimize(r'\"1\".isdigit()', 'True')\n+\n+    def test_str_islower(self):\n+        self.check_optimize(r'\"\".islower()', 'False')\n+        self.check_optimize(r'\"ABC\".islower()', 'False')\n+        self.check_optimize(r'\"aBc\".islower()', 'False')\n+        self.check_optimize(r'\"abc\".islower()', 'True')\n+\n+    def test_str_isnumeric(self):\n+        self.check_optimize(r'\"\".isnumeric()', 'False')\n+        self.check_optimize(r'\"abc\".isnumeric()', 'False')\n+        self.check_optimize(r'\"\\u00B2\".isnumeric()', 'True')\n+        self.check_optimize(r'\"\\u00BD\".isnumeric()', 'True')\n+        self.check_optimize(r'\"1.0\".isnumeric()', 'False')\n+        self.check_optimize(r'\"1\".isnumeric()', 'True')\n+\n+    def test_str_isupper(self):\n+        self.check_optimize(r'\"\".isupper()', 'False')\n+        self.check_optimize(r'\"ABC\".isupper()', 'True')\n+        self.check_optimize(r'\"aBc\".isupper()', 'False')\n+        self.check_optimize(r'\"abc\".isupper()', 'False')","path":"test_fatoptimizer.py","position":66,"original_position":66,"commit_id":"6ec12bd32e759eef8b788224636c81260940f753","original_commit_id":"6ec12bd32e759eef8b788224636c81260940f753","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"body":"Same here: fold is_xxx() into a single test function and restrict to one test per method.","created_at":"2016-06-16T21:02:34Z","updated_at":"2016-06-16T21:02:34Z","html_url":"https://github.com/haypo/fatoptimizer/pull/8#discussion_r67423480","pull_request_url":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/haypo/fatoptimizer/pulls/comments/67423480"},"html":{"href":"https://github.com/haypo/fatoptimizer/pull/8#discussion_r67423480"},"pull_request":{"href":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8","id":74107362,"html_url":"https://github.com/haypo/fatoptimizer/pull/8","diff_url":"https://github.com/haypo/fatoptimizer/pull/8.diff","patch_url":"https://github.com/haypo/fatoptimizer/pull/8.patch","issue_url":"https://api.github.com/repos/haypo/fatoptimizer/issues/8","number":8,"state":"open","locked":false,"title":"Add str pure methods + tests","user":{"login":"travcunn","id":3720254,"avatar_url":"https://avatars.githubusercontent.com/u/3720254?v=3","gravatar_id":"","url":"https://api.github.com/users/travcunn","html_url":"https://github.com/travcunn","followers_url":"https://api.github.com/users/travcunn/followers","following_url":"https://api.github.com/users/travcunn/following{/other_user}","gists_url":"https://api.github.com/users/travcunn/gists{/gist_id}","starred_url":"https://api.github.com/users/travcunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travcunn/subscriptions","organizations_url":"https://api.github.com/users/travcunn/orgs","repos_url":"https://api.github.com/users/travcunn/repos","events_url":"https://api.github.com/users/travcunn/events{/privacy}","received_events_url":"https://api.github.com/users/travcunn/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-16T16:01:36Z","updated_at":"2016-06-16T21:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8929cbe8534ee9e7d0e34fd9e2b99542daa6795","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8/commits","review_comments_url":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8/comments","review_comment_url":"https://api.github.com/repos/haypo/fatoptimizer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haypo/fatoptimizer/issues/8/comments","statuses_url":"https://api.github.com/repos/haypo/fatoptimizer/statuses/6ec12bd32e759eef8b788224636c81260940f753","head":{"label":"travcunn:master","ref":"master","sha":"6ec12bd32e759eef8b788224636c81260940f753","user":{"login":"travcunn","id":3720254,"avatar_url":"https://avatars.githubusercontent.com/u/3720254?v=3","gravatar_id":"","url":"https://api.github.com/users/travcunn","html_url":"https://github.com/travcunn","followers_url":"https://api.github.com/users/travcunn/followers","following_url":"https://api.github.com/users/travcunn/following{/other_user}","gists_url":"https://api.github.com/users/travcunn/gists{/gist_id}","starred_url":"https://api.github.com/users/travcunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travcunn/subscriptions","organizations_url":"https://api.github.com/users/travcunn/orgs","repos_url":"https://api.github.com/users/travcunn/repos","events_url":"https://api.github.com/users/travcunn/events{/privacy}","received_events_url":"https://api.github.com/users/travcunn/received_events","type":"User","site_admin":false},"repo":{"id":60872486,"name":"fatoptimizer","full_name":"travcunn/fatoptimizer","owner":{"login":"travcunn","id":3720254,"avatar_url":"https://avatars.githubusercontent.com/u/3720254?v=3","gravatar_id":"","url":"https://api.github.com/users/travcunn","html_url":"https://github.com/travcunn","followers_url":"https://api.github.com/users/travcunn/followers","following_url":"https://api.github.com/users/travcunn/following{/other_user}","gists_url":"https://api.github.com/users/travcunn/gists{/gist_id}","starred_url":"https://api.github.com/users/travcunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travcunn/subscriptions","organizations_url":"https://api.github.com/users/travcunn/orgs","repos_url":"https://api.github.com/users/travcunn/repos","events_url":"https://api.github.com/users/travcunn/events{/privacy}","received_events_url":"https://api.github.com/users/travcunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/travcunn/fatoptimizer","description":"Static optimizer specializing functions with guards for Python 3.6","fork":true,"url":"https://api.github.com/repos/travcunn/fatoptimizer","forks_url":"https://api.github.com/repos/travcunn/fatoptimizer/forks","keys_url":"https://api.github.com/repos/travcunn/fatoptimizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travcunn/fatoptimizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travcunn/fatoptimizer/teams","hooks_url":"https://api.github.com/repos/travcunn/fatoptimizer/hooks","issue_events_url":"https://api.github.com/repos/travcunn/fatoptimizer/issues/events{/number}","events_url":"https://api.github.com/repos/travcunn/fatoptimizer/events","assignees_url":"https://api.github.com/repos/travcunn/fatoptimizer/assignees{/user}","branches_url":"https://api.github.com/repos/travcunn/fatoptimizer/branches{/branch}","tags_url":"https://api.github.com/repos/travcunn/fatoptimizer/tags","blobs_url":"https://api.github.com/repos/travcunn/fatoptimizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travcunn/fatoptimizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travcunn/fatoptimizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/travcunn/fatoptimizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travcunn/fatoptimizer/statuses/{sha}","languages_url":"https://api.github.com/repos/travcunn/fatoptimizer/languages","stargazers_url":"https://api.github.com/repos/travcunn/fatoptimizer/stargazers","contributors_url":"https://api.github.com/repos/travcunn/fatoptimizer/contributors","subscribers_url":"https://api.github.com/repos/travcunn/fatoptimizer/subscribers","subscription_url":"https://api.github.com/repos/travcunn/fatoptimizer/subscription","commits_url":"https://api.github.com/repos/travcunn/fatoptimizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/travcunn/fatoptimizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/travcunn/fatoptimizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/travcunn/fatoptimizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/travcunn/fatoptimizer/contents/{+path}","compare_url":"https://api.github.com/repos/travcunn/fatoptimizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travcunn/fatoptimizer/merges","archive_url":"https://api.github.com/repos/travcunn/fatoptimizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travcunn/fatoptimizer/downloads","issues_url":"https://api.github.com/repos/travcunn/fatoptimizer/issues{/number}","pulls_url":"https://api.github.com/repos/travcunn/fatoptimizer/pulls{/number}","milestones_url":"https://api.github.com/repos/travcunn/fatoptimizer/milestones{/number}","notifications_url":"https://api.github.com/repos/travcunn/fatoptimizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travcunn/fatoptimizer/labels{/name}","releases_url":"https://api.github.com/repos/travcunn/fatoptimizer/releases{/id}","deployments_url":"https://api.github.com/repos/travcunn/fatoptimizer/deployments","created_at":"2016-06-10T19:39:33Z","updated_at":"2016-06-10T19:39:34Z","pushed_at":"2016-06-16T16:00:45Z","git_url":"git://github.com/travcunn/fatoptimizer.git","ssh_url":"git@github.com:travcunn/fatoptimizer.git","clone_url":"https://github.com/travcunn/fatoptimizer.git","svn_url":"https://github.com/travcunn/fatoptimizer","homepage":"https://fatoptimizer.readthedocs.org/en/latest/","size":176,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haypo:master","ref":"master","sha":"538c92bb0a4257d2d386e112ba4a651567cdcdb6","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"repo":{"id":49607254,"name":"fatoptimizer","full_name":"haypo/fatoptimizer","owner":{"login":"haypo","id":194129,"avatar_url":"https://avatars.githubusercontent.com/u/194129?v=3","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haypo/fatoptimizer","description":"Static optimizer specializing functions with guards for Python 3.6","fork":false,"url":"https://api.github.com/repos/haypo/fatoptimizer","forks_url":"https://api.github.com/repos/haypo/fatoptimizer/forks","keys_url":"https://api.github.com/repos/haypo/fatoptimizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haypo/fatoptimizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haypo/fatoptimizer/teams","hooks_url":"https://api.github.com/repos/haypo/fatoptimizer/hooks","issue_events_url":"https://api.github.com/repos/haypo/fatoptimizer/issues/events{/number}","events_url":"https://api.github.com/repos/haypo/fatoptimizer/events","assignees_url":"https://api.github.com/repos/haypo/fatoptimizer/assignees{/user}","branches_url":"https://api.github.com/repos/haypo/fatoptimizer/branches{/branch}","tags_url":"https://api.github.com/repos/haypo/fatoptimizer/tags","blobs_url":"https://api.github.com/repos/haypo/fatoptimizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haypo/fatoptimizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haypo/fatoptimizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/haypo/fatoptimizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haypo/fatoptimizer/statuses/{sha}","languages_url":"https://api.github.com/repos/haypo/fatoptimizer/languages","stargazers_url":"https://api.github.com/repos/haypo/fatoptimizer/stargazers","contributors_url":"https://api.github.com/repos/haypo/fatoptimizer/contributors","subscribers_url":"https://api.github.com/repos/haypo/fatoptimizer/subscribers","subscription_url":"https://api.github.com/repos/haypo/fatoptimizer/subscription","commits_url":"https://api.github.com/repos/haypo/fatoptimizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/haypo/fatoptimizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/haypo/fatoptimizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/haypo/fatoptimizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/haypo/fatoptimizer/contents/{+path}","compare_url":"https://api.github.com/repos/haypo/fatoptimizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haypo/fatoptimizer/merges","archive_url":"https://api.github.com/repos/haypo/fatoptimizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haypo/fatoptimizer/downloads","issues_url":"https://api.github.com/repos/haypo/fatoptimizer/issues{/number}","pulls_url":"https://api.github.com/repos/haypo/fatoptimizer/pulls{/number}","milestones_url":"https://api.github.com/repos/haypo/fatoptimizer/milestones{/number}","notifications_url":"https://api.github.com/repos/haypo/fatoptimizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haypo/fatoptimizer/labels{/name}","releases_url":"https://api.github.com/repos/haypo/fatoptimizer/releases{/id}","deployments_url":"https://api.github.com/repos/haypo/fatoptimizer/deployments","created_at":"2016-01-13T22:48:46Z","updated_at":"2016-06-02T07:55:15Z","pushed_at":"2016-06-16T16:01:36Z","git_url":"git://github.com/haypo/fatoptimizer.git","ssh_url":"git@github.com:haypo/fatoptimizer.git","clone_url":"https://github.com/haypo/fatoptimizer.git","svn_url":"https://github.com/haypo/fatoptimizer","homepage":"https://fatoptimizer.readthedocs.org/en/latest/","size":176,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8"},"html":{"href":"https://github.com/haypo/fatoptimizer/pull/8"},"issue":{"href":"https://api.github.com/repos/haypo/fatoptimizer/issues/8"},"comments":{"href":"https://api.github.com/repos/haypo/fatoptimizer/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/haypo/fatoptimizer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haypo/fatoptimizer/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/haypo/fatoptimizer/statuses/6ec12bd32e759eef8b788224636c81260940f753"}}}}
{"actor":{"display_login":"haypo"}}