{"action":"created","comment":{"url":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/comments/93166217","pull_request_review_id":13687791,"id":93166217,"diff_hunk":"@@ -8,24 +8,10 @@ To compile for Microsoft Windows, see [COMPILE-WINDOWS.md](COMPILE-WINDOWS.md)\n \n [0] Dependencies\n \n-Unicorn requires few dependent packages as follows.\n-\n-- For Mac OS X, \"pkg-config\" and \"glib\" are needed.\n-  Brew users can install \"pkg-config\" and \"glib\" with:\n-\n-        $ brew install pkg-config glib\n-\n-  NOTE: to build Unicorn universal binaries (which support both 32-bit &\n-  64-bit), you need to have glib in universal format. To do that, build &\n-  install glib with:\n-\n-        $ brew install glib --universal\n-\n-- For Linux, \"glib2-dev\" is needed.\n-  Ubuntu/Debian users can install this with:\n-\n-        $ sudo apt-get install libglib2.0-dev\n+For MacOS, Unicorn requires \"pkg-config\" package.","path":"docs/COMPILE-NIX.md","position":21,"original_position":21,"commit_id":"f8f9e993a85dabea9f933ac7350447db518bd1c4","original_commit_id":"f8f9e993a85dabea9f933ac7350447db518bd1c4","user":{"login":"aquynh","id":5965536,"avatar_url":"https://avatars.githubusercontent.com/u/5965536?v=3","gravatar_id":"","url":"https://api.github.com/users/aquynh","html_url":"https://github.com/aquynh","followers_url":"https://api.github.com/users/aquynh/followers","following_url":"https://api.github.com/users/aquynh/following{/other_user}","gists_url":"https://api.github.com/users/aquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/aquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquynh/subscriptions","organizations_url":"https://api.github.com/users/aquynh/orgs","repos_url":"https://api.github.com/users/aquynh/repos","events_url":"https://api.github.com/users/aquynh/events{/privacy}","received_events_url":"https://api.github.com/users/aquynh/received_events","type":"User","site_admin":false},"body":"pkgconfig is checked in qemu/configure, but looks like we dont need that anymore. i will remove this dependency.","created_at":"2016-12-20T03:30:49Z","updated_at":"2016-12-20T03:30:49Z","html_url":"https://github.com/unicorn-engine/unicorn/pull/690#discussion_r93166217","pull_request_url":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/comments/93166217"},"html":{"href":"https://github.com/unicorn-engine/unicorn/pull/690#discussion_r93166217"},"pull_request":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690","id":98492056,"html_url":"https://github.com/unicorn-engine/unicorn/pull/690","diff_url":"https://github.com/unicorn-engine/unicorn/pull/690.diff","patch_url":"https://github.com/unicorn-engine/unicorn/pull/690.patch","issue_url":"https://api.github.com/repos/unicorn-engine/unicorn/issues/690","number":690,"state":"open","locked":false,"title":"remove glib dependency by providing compatible replacements","user":{"login":"cseagle","id":7685466,"avatar_url":"https://avatars.githubusercontent.com/u/7685466?v=3","gravatar_id":"","url":"https://api.github.com/users/cseagle","html_url":"https://github.com/cseagle","followers_url":"https://api.github.com/users/cseagle/followers","following_url":"https://api.github.com/users/cseagle/following{/other_user}","gists_url":"https://api.github.com/users/cseagle/gists{/gist_id}","starred_url":"https://api.github.com/users/cseagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseagle/subscriptions","organizations_url":"https://api.github.com/users/cseagle/orgs","repos_url":"https://api.github.com/users/cseagle/repos","events_url":"https://api.github.com/users/cseagle/events{/privacy}","received_events_url":"https://api.github.com/users/cseagle/received_events","type":"User","site_admin":false},"body":"Added glib compatible replacements for all glib functions used in unicorn. Removed glib dependencies in Makefiles.\r\nI threw the list and hash table implementations together and have paid no attention to their performance. Feel free to replace the hash table implementation with something that performs better.\r\nNeed help testing. All samples and unit tests run with same results as master on the following platforms:\r\nwin32 (using mingw), OS X 64, Linux 32, Linux 64.\r\nHave not done much testing beyond that.","created_at":"2016-12-18T23:30:21Z","updated_at":"2016-12-20T03:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a19f9173d4074d528835edffa96aec147a2fbc84","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690/commits","review_comments_url":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690/comments","review_comment_url":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unicorn-engine/unicorn/issues/690/comments","statuses_url":"https://api.github.com/repos/unicorn-engine/unicorn/statuses/f8f9e993a85dabea9f933ac7350447db518bd1c4","head":{"label":"cseagle:noglib","ref":"noglib","sha":"f8f9e993a85dabea9f933ac7350447db518bd1c4","user":{"login":"cseagle","id":7685466,"avatar_url":"https://avatars.githubusercontent.com/u/7685466?v=3","gravatar_id":"","url":"https://api.github.com/users/cseagle","html_url":"https://github.com/cseagle","followers_url":"https://api.github.com/users/cseagle/followers","following_url":"https://api.github.com/users/cseagle/following{/other_user}","gists_url":"https://api.github.com/users/cseagle/gists{/gist_id}","starred_url":"https://api.github.com/users/cseagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseagle/subscriptions","organizations_url":"https://api.github.com/users/cseagle/orgs","repos_url":"https://api.github.com/users/cseagle/repos","events_url":"https://api.github.com/users/cseagle/events{/privacy}","received_events_url":"https://api.github.com/users/cseagle/received_events","type":"User","site_admin":false},"repo":{"id":51016339,"name":"unicorn","full_name":"cseagle/unicorn","owner":{"login":"cseagle","id":7685466,"avatar_url":"https://avatars.githubusercontent.com/u/7685466?v=3","gravatar_id":"","url":"https://api.github.com/users/cseagle","html_url":"https://github.com/cseagle","followers_url":"https://api.github.com/users/cseagle/followers","following_url":"https://api.github.com/users/cseagle/following{/other_user}","gists_url":"https://api.github.com/users/cseagle/gists{/gist_id}","starred_url":"https://api.github.com/users/cseagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseagle/subscriptions","organizations_url":"https://api.github.com/users/cseagle/orgs","repos_url":"https://api.github.com/users/cseagle/repos","events_url":"https://api.github.com/users/cseagle/events{/privacy}","received_events_url":"https://api.github.com/users/cseagle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cseagle/unicorn","description":"Unicorn CPU emulator engine","fork":true,"url":"https://api.github.com/repos/cseagle/unicorn","forks_url":"https://api.github.com/repos/cseagle/unicorn/forks","keys_url":"https://api.github.com/repos/cseagle/unicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cseagle/unicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cseagle/unicorn/teams","hooks_url":"https://api.github.com/repos/cseagle/unicorn/hooks","issue_events_url":"https://api.github.com/repos/cseagle/unicorn/issues/events{/number}","events_url":"https://api.github.com/repos/cseagle/unicorn/events","assignees_url":"https://api.github.com/repos/cseagle/unicorn/assignees{/user}","branches_url":"https://api.github.com/repos/cseagle/unicorn/branches{/branch}","tags_url":"https://api.github.com/repos/cseagle/unicorn/tags","blobs_url":"https://api.github.com/repos/cseagle/unicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cseagle/unicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cseagle/unicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/cseagle/unicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cseagle/unicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/cseagle/unicorn/languages","stargazers_url":"https://api.github.com/repos/cseagle/unicorn/stargazers","contributors_url":"https://api.github.com/repos/cseagle/unicorn/contributors","subscribers_url":"https://api.github.com/repos/cseagle/unicorn/subscribers","subscription_url":"https://api.github.com/repos/cseagle/unicorn/subscription","commits_url":"https://api.github.com/repos/cseagle/unicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/cseagle/unicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/cseagle/unicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/cseagle/unicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/cseagle/unicorn/contents/{+path}","compare_url":"https://api.github.com/repos/cseagle/unicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cseagle/unicorn/merges","archive_url":"https://api.github.com/repos/cseagle/unicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cseagle/unicorn/downloads","issues_url":"https://api.github.com/repos/cseagle/unicorn/issues{/number}","pulls_url":"https://api.github.com/repos/cseagle/unicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/cseagle/unicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/cseagle/unicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cseagle/unicorn/labels{/name}","releases_url":"https://api.github.com/repos/cseagle/unicorn/releases{/id}","deployments_url":"https://api.github.com/repos/cseagle/unicorn/deployments","created_at":"2016-02-03T17:14:08Z","updated_at":"2016-11-26T19:53:01Z","pushed_at":"2016-12-19T20:32:39Z","git_url":"git://github.com/cseagle/unicorn.git","ssh_url":"git@github.com:cseagle/unicorn.git","clone_url":"https://github.com/cseagle/unicorn.git","svn_url":"https://github.com/cseagle/unicorn","homepage":"http://www.unicorn-engine.org","size":6152,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"unicorn-engine:master","ref":"master","sha":"934fa2c90f0c49ae209f697d44d681ddbcdea2d1","user":{"login":"unicorn-engine","id":13391512,"avatar_url":"https://avatars.githubusercontent.com/u/13391512?v=3","gravatar_id":"","url":"https://api.github.com/users/unicorn-engine","html_url":"https://github.com/unicorn-engine","followers_url":"https://api.github.com/users/unicorn-engine/followers","following_url":"https://api.github.com/users/unicorn-engine/following{/other_user}","gists_url":"https://api.github.com/users/unicorn-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/unicorn-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicorn-engine/subscriptions","organizations_url":"https://api.github.com/users/unicorn-engine/orgs","repos_url":"https://api.github.com/users/unicorn-engine/repos","events_url":"https://api.github.com/users/unicorn-engine/events{/privacy}","received_events_url":"https://api.github.com/users/unicorn-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":41107037,"name":"unicorn","full_name":"unicorn-engine/unicorn","owner":{"login":"unicorn-engine","id":13391512,"avatar_url":"https://avatars.githubusercontent.com/u/13391512?v=3","gravatar_id":"","url":"https://api.github.com/users/unicorn-engine","html_url":"https://github.com/unicorn-engine","followers_url":"https://api.github.com/users/unicorn-engine/followers","following_url":"https://api.github.com/users/unicorn-engine/following{/other_user}","gists_url":"https://api.github.com/users/unicorn-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/unicorn-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicorn-engine/subscriptions","organizations_url":"https://api.github.com/users/unicorn-engine/orgs","repos_url":"https://api.github.com/users/unicorn-engine/repos","events_url":"https://api.github.com/users/unicorn-engine/events{/privacy}","received_events_url":"https://api.github.com/users/unicorn-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicorn-engine/unicorn","description":"Unicorn CPU emulator framework (ARM, AArch64, M68K, Mips, Sparc, X86)","fork":false,"url":"https://api.github.com/repos/unicorn-engine/unicorn","forks_url":"https://api.github.com/repos/unicorn-engine/unicorn/forks","keys_url":"https://api.github.com/repos/unicorn-engine/unicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicorn-engine/unicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicorn-engine/unicorn/teams","hooks_url":"https://api.github.com/repos/unicorn-engine/unicorn/hooks","issue_events_url":"https://api.github.com/repos/unicorn-engine/unicorn/issues/events{/number}","events_url":"https://api.github.com/repos/unicorn-engine/unicorn/events","assignees_url":"https://api.github.com/repos/unicorn-engine/unicorn/assignees{/user}","branches_url":"https://api.github.com/repos/unicorn-engine/unicorn/branches{/branch}","tags_url":"https://api.github.com/repos/unicorn-engine/unicorn/tags","blobs_url":"https://api.github.com/repos/unicorn-engine/unicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicorn-engine/unicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicorn-engine/unicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicorn-engine/unicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicorn-engine/unicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/unicorn-engine/unicorn/languages","stargazers_url":"https://api.github.com/repos/unicorn-engine/unicorn/stargazers","contributors_url":"https://api.github.com/repos/unicorn-engine/unicorn/contributors","subscribers_url":"https://api.github.com/repos/unicorn-engine/unicorn/subscribers","subscription_url":"https://api.github.com/repos/unicorn-engine/unicorn/subscription","commits_url":"https://api.github.com/repos/unicorn-engine/unicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicorn-engine/unicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicorn-engine/unicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicorn-engine/unicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicorn-engine/unicorn/contents/{+path}","compare_url":"https://api.github.com/repos/unicorn-engine/unicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicorn-engine/unicorn/merges","archive_url":"https://api.github.com/repos/unicorn-engine/unicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicorn-engine/unicorn/downloads","issues_url":"https://api.github.com/repos/unicorn-engine/unicorn/issues{/number}","pulls_url":"https://api.github.com/repos/unicorn-engine/unicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/unicorn-engine/unicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/unicorn-engine/unicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicorn-engine/unicorn/labels{/name}","releases_url":"https://api.github.com/repos/unicorn-engine/unicorn/releases{/id}","deployments_url":"https://api.github.com/repos/unicorn-engine/unicorn/deployments","created_at":"2015-08-20T16:35:45Z","updated_at":"2016-12-20T01:46:15Z","pushed_at":"2016-12-20T03:30:37Z","git_url":"git://github.com/unicorn-engine/unicorn.git","ssh_url":"git@github.com:unicorn-engine/unicorn.git","clone_url":"https://github.com/unicorn-engine/unicorn.git","svn_url":"https://github.com/unicorn-engine/unicorn","homepage":"http://www.unicorn-engine.org","size":6076,"stargazers_count":887,"watchers_count":887,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":135,"forks":208,"open_issues":135,"watchers":887,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690"},"html":{"href":"https://github.com/unicorn-engine/unicorn/pull/690"},"issue":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/issues/690"},"comments":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/unicorn-engine/unicorn/statuses/f8f9e993a85dabea9f933ac7350447db518bd1c4"}}}}
{"actor":{"display_login":"aquynh"}}