{"action":"created","comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments/60744568","id":60744568,"diff_hunk":"@@ -84,26 +84,42 @@ Please note — packaged into an asar archive [by default](https://github.com/el\n * `-amd64.deb` and `-i386.deb`: Linux Debian package. Please note — by default the most effective [xz](https://en.wikipedia.org/wiki/Xz) compression format used.\n \n You need to deploy somewhere releases/downloads server.\n-Consider to use [Nuts](https://github.com/GitbookIO/nuts) (GitHub as a backend to store assets) or [Electron Release Server](https://github.com/ArekSredzki/electron-release-server).\n+Consider using [Nuts](https://github.com/GitbookIO/nuts) (GitHub as a backend to store assets) or [Electron Release Server](https://github.com/ArekSredzki/electron-release-server).\n \n # Code Signing\n OS X and Windows code singing is supported.\n-On a development machine set environment variable `CSC_NAME` to your identity (recommended). Or pass `--sign` parameter.\n+\n+## Signing OS X Development Builds\n+On a development machine, set environment variable `CSC_NAME` to your identity (recommended). Or pass `--sign` parameter.\n ```\n export CSC_NAME=\"Developer ID Application: Your Name (code)\"\n ```\n \n-## Travis, AppVeyor and other CI servers\n+This is only required on OS X.\n+\n+## Signing Production Builds on Travis, AppVeyor and other CI servers\n To sign app on build server:\n \n-1. [Export](https://developer.apple.com/library/ios/documentation/IDEs/Conceptual/AppDistributionGuide/MaintainingCertificates/MaintainingCertificates.html#//apple_ref/doc/uid/TP40012582-CH31-SW7) certificate.\n- [Strong password](http://security.stackexchange.com/a/54773) must be used. Consider to not use special characters (for bash) because “*values are not escaped when your builds are executed*”.\n-2. Upload `*.p12` file (e.g. on [Google Drive](http://www.syncwithtech.org/p/direct-download-link-generator.html)).\n+> **NOTICE**: When exporting a code signing certificate, a [strong password](http://security.stackexchange.com/a/54773) must be used.\n+> Avoid using special characters (for bash) because “*values are not escaped when your builds are executed*”.\n+\n+1. Get a code signing certificate\n+  - OS X","path":"README.md","position":30,"original_position":30,"commit_id":"3639dd18f82a9567d65de0fad21026a59c3cc9d1","original_commit_id":"3639dd18f82a9567d65de0fad21026a59c3cc9d1","user":{"login":"Lange","id":873012,"avatar_url":"https://avatars.githubusercontent.com/u/873012?v=3","gravatar_id":"","url":"https://api.github.com/users/Lange","html_url":"https://github.com/Lange","followers_url":"https://api.github.com/users/Lange/followers","following_url":"https://api.github.com/users/Lange/following{/other_user}","gists_url":"https://api.github.com/users/Lange/gists{/gist_id}","starred_url":"https://api.github.com/users/Lange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lange/subscriptions","organizations_url":"https://api.github.com/users/Lange/orgs","repos_url":"https://api.github.com/users/Lange/repos","events_url":"https://api.github.com/users/Lange/events{/privacy}","received_events_url":"https://api.github.com/users/Lange/received_events","type":"User","site_admin":false},"body":"Oh, I bought an Apple Developer account *and* DigiCert certificate just for this because I thought I had to. I couldn't find anything on the internet that said otherwise. We should definitely recommend cheaper alternatives.","created_at":"2016-04-22T14:12:40Z","updated_at":"2016-04-22T14:12:40Z","html_url":"https://github.com/electron-userland/electron-builder/pull/350#discussion_r60744568","pull_request_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments/60744568"},"html":{"href":"https://github.com/electron-userland/electron-builder/pull/350#discussion_r60744568"},"pull_request":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350","id":67368220,"html_url":"https://github.com/electron-userland/electron-builder/pull/350","diff_url":"https://github.com/electron-userland/electron-builder/pull/350.diff","patch_url":"https://github.com/electron-userland/electron-builder/pull/350.patch","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/350","number":350,"state":"open","locked":false,"title":"Clarify Documentation","user":{"login":"Lange","id":873012,"avatar_url":"https://avatars.githubusercontent.com/u/873012?v=3","gravatar_id":"","url":"https://api.github.com/users/Lange","html_url":"https://github.com/Lange","followers_url":"https://api.github.com/users/Lange/followers","following_url":"https://api.github.com/users/Lange/following{/other_user}","gists_url":"https://api.github.com/users/Lange/gists{/gist_id}","starred_url":"https://api.github.com/users/Lange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lange/subscriptions","organizations_url":"https://api.github.com/users/Lange/orgs","repos_url":"https://api.github.com/users/Lange/repos","events_url":"https://api.github.com/users/Lange/events{/privacy}","received_events_url":"https://api.github.com/users/Lange/received_events","type":"User","site_admin":false},"body":"**This PR is a work-in-progress. It is not ready to be merged yet.**\r\n\r\nAs discussed in Issue #346.\r\n\r\nChanges so far:\r\n\r\n- [x] Clarify code signing docs\r\n\r\nPlanned changes:\r\n\r\n- [ ] Mention that Electron's autoUpdater behavior must be implemented for auto updating to work. ([Example](https://github.com/develar/onshape-desktop-shell/blob/master/src/AppUpdater.ts))\r\n- [ ] More prominently link to the contents of the [`docs`](https://github.com/electron-userland/electron-builder/tree/master/docs) folder, specifically [`Publishing Artifacts.md`](https://github.com/electron-userland/electron-builder/blob/master/docs/Publishing%20Artifacts.md).\r\n- [ ] Add docs explaining that the OSX DMG installer window size is based on the size of `background.png`.\r\n- [ ] More clearly document the recommended draft/release workflow, as discussed in [this comment](https://github.com/electron-userland/electron-builder/issues/340#issuecomment-212426562) on Issue #340.\r\n\r\nThere may be more changes as I work through the docs and find more things to clarify or expand upon. Suggestions of other areas of the documentation to improve are welcome.\r\n\r\n","created_at":"2016-04-21T14:55:15Z","updated_at":"2016-04-22T14:12:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6473c063fe20f531ef01daa3bfe1f3de4d0cef89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350/commits","review_comments_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350/comments","review_comment_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/350/comments","statuses_url":"https://api.github.com/repos/electron-userland/electron-builder/statuses/3639dd18f82a9567d65de0fad21026a59c3cc9d1","head":{"label":"Lange:clarify-docs","ref":"clarify-docs","sha":"3639dd18f82a9567d65de0fad21026a59c3cc9d1","user":{"login":"Lange","id":873012,"avatar_url":"https://avatars.githubusercontent.com/u/873012?v=3","gravatar_id":"","url":"https://api.github.com/users/Lange","html_url":"https://github.com/Lange","followers_url":"https://api.github.com/users/Lange/followers","following_url":"https://api.github.com/users/Lange/following{/other_user}","gists_url":"https://api.github.com/users/Lange/gists{/gist_id}","starred_url":"https://api.github.com/users/Lange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lange/subscriptions","organizations_url":"https://api.github.com/users/Lange/orgs","repos_url":"https://api.github.com/users/Lange/repos","events_url":"https://api.github.com/users/Lange/events{/privacy}","received_events_url":"https://api.github.com/users/Lange/received_events","type":"User","site_admin":false},"repo":{"id":56729516,"name":"electron-builder","full_name":"Lange/electron-builder","owner":{"login":"Lange","id":873012,"avatar_url":"https://avatars.githubusercontent.com/u/873012?v=3","gravatar_id":"","url":"https://api.github.com/users/Lange","html_url":"https://github.com/Lange","followers_url":"https://api.github.com/users/Lange/followers","following_url":"https://api.github.com/users/Lange/following{/other_user}","gists_url":"https://api.github.com/users/Lange/gists{/gist_id}","starred_url":"https://api.github.com/users/Lange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lange/subscriptions","organizations_url":"https://api.github.com/users/Lange/orgs","repos_url":"https://api.github.com/users/Lange/repos","events_url":"https://api.github.com/users/Lange/events{/privacy}","received_events_url":"https://api.github.com/users/Lange/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lange/electron-builder","description":"Complete solution to package and deploy Electron apps","fork":true,"url":"https://api.github.com/repos/Lange/electron-builder","forks_url":"https://api.github.com/repos/Lange/electron-builder/forks","keys_url":"https://api.github.com/repos/Lange/electron-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lange/electron-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lange/electron-builder/teams","hooks_url":"https://api.github.com/repos/Lange/electron-builder/hooks","issue_events_url":"https://api.github.com/repos/Lange/electron-builder/issues/events{/number}","events_url":"https://api.github.com/repos/Lange/electron-builder/events","assignees_url":"https://api.github.com/repos/Lange/electron-builder/assignees{/user}","branches_url":"https://api.github.com/repos/Lange/electron-builder/branches{/branch}","tags_url":"https://api.github.com/repos/Lange/electron-builder/tags","blobs_url":"https://api.github.com/repos/Lange/electron-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lange/electron-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lange/electron-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lange/electron-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lange/electron-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/Lange/electron-builder/languages","stargazers_url":"https://api.github.com/repos/Lange/electron-builder/stargazers","contributors_url":"https://api.github.com/repos/Lange/electron-builder/contributors","subscribers_url":"https://api.github.com/repos/Lange/electron-builder/subscribers","subscription_url":"https://api.github.com/repos/Lange/electron-builder/subscription","commits_url":"https://api.github.com/repos/Lange/electron-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lange/electron-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lange/electron-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lange/electron-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lange/electron-builder/contents/{+path}","compare_url":"https://api.github.com/repos/Lange/electron-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lange/electron-builder/merges","archive_url":"https://api.github.com/repos/Lange/electron-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lange/electron-builder/downloads","issues_url":"https://api.github.com/repos/Lange/electron-builder/issues{/number}","pulls_url":"https://api.github.com/repos/Lange/electron-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/Lange/electron-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/Lange/electron-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lange/electron-builder/labels{/name}","releases_url":"https://api.github.com/repos/Lange/electron-builder/releases{/id}","deployments_url":"https://api.github.com/repos/Lange/electron-builder/deployments","created_at":"2016-04-21T00:21:05Z","updated_at":"2016-04-21T00:21:06Z","pushed_at":"2016-04-21T14:49:43Z","git_url":"git://github.com/Lange/electron-builder.git","ssh_url":"git@github.com:Lange/electron-builder.git","clone_url":"https://github.com/Lange/electron-builder.git","svn_url":"https://github.com/Lange/electron-builder","homepage":"","size":105035,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron-userland:master","ref":"master","sha":"84ead730444edbfeccbfbfa4812d48e0d03087b9","user":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"repo":{"id":35998691,"name":"electron-builder","full_name":"electron-userland/electron-builder","owner":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron-userland/electron-builder","description":"Complete solution to package and deploy Electron apps","fork":false,"url":"https://api.github.com/repos/electron-userland/electron-builder","forks_url":"https://api.github.com/repos/electron-userland/electron-builder/forks","keys_url":"https://api.github.com/repos/electron-userland/electron-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron-userland/electron-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron-userland/electron-builder/teams","hooks_url":"https://api.github.com/repos/electron-userland/electron-builder/hooks","issue_events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/events{/number}","events_url":"https://api.github.com/repos/electron-userland/electron-builder/events","assignees_url":"https://api.github.com/repos/electron-userland/electron-builder/assignees{/user}","branches_url":"https://api.github.com/repos/electron-userland/electron-builder/branches{/branch}","tags_url":"https://api.github.com/repos/electron-userland/electron-builder/tags","blobs_url":"https://api.github.com/repos/electron-userland/electron-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron-userland/electron-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron-userland/electron-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron-userland/electron-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron-userland/electron-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/electron-userland/electron-builder/languages","stargazers_url":"https://api.github.com/repos/electron-userland/electron-builder/stargazers","contributors_url":"https://api.github.com/repos/electron-userland/electron-builder/contributors","subscribers_url":"https://api.github.com/repos/electron-userland/electron-builder/subscribers","subscription_url":"https://api.github.com/repos/electron-userland/electron-builder/subscription","commits_url":"https://api.github.com/repos/electron-userland/electron-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron-userland/electron-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron-userland/electron-builder/contents/{+path}","compare_url":"https://api.github.com/repos/electron-userland/electron-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron-userland/electron-builder/merges","archive_url":"https://api.github.com/repos/electron-userland/electron-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron-userland/electron-builder/downloads","issues_url":"https://api.github.com/repos/electron-userland/electron-builder/issues{/number}","pulls_url":"https://api.github.com/repos/electron-userland/electron-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/electron-userland/electron-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/electron-userland/electron-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/labels{/name}","releases_url":"https://api.github.com/repos/electron-userland/electron-builder/releases{/id}","deployments_url":"https://api.github.com/repos/electron-userland/electron-builder/deployments","created_at":"2015-05-21T07:45:02Z","updated_at":"2016-04-22T14:10:04Z","pushed_at":"2016-04-21T14:55:16Z","git_url":"git://github.com/electron-userland/electron-builder.git","ssh_url":"git@github.com:electron-userland/electron-builder.git","clone_url":"https://github.com/electron-userland/electron-builder.git","svn_url":"https://github.com/electron-userland/electron-builder","homepage":"","size":105099,"stargazers_count":684,"watchers_count":684,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":13,"forks":70,"open_issues":13,"watchers":684,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350"},"html":{"href":"https://github.com/electron-userland/electron-builder/pull/350"},"issue":{"href":"https://api.github.com/repos/electron-userland/electron-builder/issues/350"},"comments":{"href":"https://api.github.com/repos/electron-userland/electron-builder/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron-userland/electron-builder/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/electron-userland/electron-builder/statuses/3639dd18f82a9567d65de0fad21026a59c3cc9d1"}}}}