{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/seperman/deepdiff/pulls/32","id":78009563,"html_url":"https://github.com/seperman/deepdiff/pull/32","diff_url":"https://github.com/seperman/deepdiff/pull/32.diff","patch_url":"https://github.com/seperman/deepdiff/pull/32.patch","issue_url":"https://api.github.com/repos/seperman/deepdiff/issues/32","number":32,"state":"closed","locked":false,"title":"Deep-compare custom objects within sets","user":{"login":"victorhahncastell","id":3177019,"avatar_url":"https://avatars.githubusercontent.com/u/3177019?v=3","gravatar_id":"","url":"https://api.github.com/users/victorhahncastell","html_url":"https://github.com/victorhahncastell","followers_url":"https://api.github.com/users/victorhahncastell/followers","following_url":"https://api.github.com/users/victorhahncastell/following{/other_user}","gists_url":"https://api.github.com/users/victorhahncastell/gists{/gist_id}","starred_url":"https://api.github.com/users/victorhahncastell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorhahncastell/subscriptions","organizations_url":"https://api.github.com/users/victorhahncastell/orgs","repos_url":"https://api.github.com/users/victorhahncastell/repos","events_url":"https://api.github.com/users/victorhahncastell/events{/privacy}","received_events_url":"https://api.github.com/users/victorhahncastell/received_events","type":"User","site_admin":false},"body":"Quite a big change for a rather peculiar bug. DeepDiff failed to deep-compare custom objects within a set. As sets are used internally to compare dicts ignoring the order this bug also affected dicts.\r\n\r\nThis PR introduces an additional class, DeepSet, which is essentially a set providing deep comparison.\r\n\r\nDeepSet is not feature complete yet, but does satisfy DeepDiff's requirements (for now).\r\n\r\nA similar, still unfixed bug involves dicts containing equal (but not identical) custom objects as keys. This does not work yet because we also need a DeepDict that supports the [] operator for equal but not identical objects. We'd also need to implement a couple more set features in DeepSet. A test for this is in my fix_diff_dict_keys branch -- I didn't get a chance to implement a fix though, as right not, the feature is not on my personal requirements list.","created_at":"2016-07-19T16:39:19Z","updated_at":"2016-08-02T13:49:57Z","closed_at":"2016-08-02T13:49:57Z","merged_at":null,"merge_commit_sha":"4e7d37c0a746e3ecab0f0d5540254201fa85ec1f","assignee":{"login":"seperman","id":2314797,"avatar_url":"https://avatars.githubusercontent.com/u/2314797?v=3","gravatar_id":"","url":"https://api.github.com/users/seperman","html_url":"https://github.com/seperman","followers_url":"https://api.github.com/users/seperman/followers","following_url":"https://api.github.com/users/seperman/following{/other_user}","gists_url":"https://api.github.com/users/seperman/gists{/gist_id}","starred_url":"https://api.github.com/users/seperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seperman/subscriptions","organizations_url":"https://api.github.com/users/seperman/orgs","repos_url":"https://api.github.com/users/seperman/repos","events_url":"https://api.github.com/users/seperman/events{/privacy}","received_events_url":"https://api.github.com/users/seperman/received_events","type":"User","site_admin":false},"assignees":[{"login":"seperman","id":2314797,"avatar_url":"https://avatars.githubusercontent.com/u/2314797?v=3","gravatar_id":"","url":"https://api.github.com/users/seperman","html_url":"https://github.com/seperman","followers_url":"https://api.github.com/users/seperman/followers","following_url":"https://api.github.com/users/seperman/following{/other_user}","gists_url":"https://api.github.com/users/seperman/gists{/gist_id}","starred_url":"https://api.github.com/users/seperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seperman/subscriptions","organizations_url":"https://api.github.com/users/seperman/orgs","repos_url":"https://api.github.com/users/seperman/repos","events_url":"https://api.github.com/users/seperman/events{/privacy}","received_events_url":"https://api.github.com/users/seperman/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/seperman/deepdiff/pulls/32/commits","review_comments_url":"https://api.github.com/repos/seperman/deepdiff/pulls/32/comments","review_comment_url":"https://api.github.com/repos/seperman/deepdiff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seperman/deepdiff/issues/32/comments","statuses_url":"https://api.github.com/repos/seperman/deepdiff/statuses/7c0405d2d6bb773d8d2ce1fd8cfa0328db5b4807","head":{"label":"victorhahncastell:pr1","ref":"pr1","sha":"7c0405d2d6bb773d8d2ce1fd8cfa0328db5b4807","user":{"login":"victorhahncastell","id":3177019,"avatar_url":"https://avatars.githubusercontent.com/u/3177019?v=3","gravatar_id":"","url":"https://api.github.com/users/victorhahncastell","html_url":"https://github.com/victorhahncastell","followers_url":"https://api.github.com/users/victorhahncastell/followers","following_url":"https://api.github.com/users/victorhahncastell/following{/other_user}","gists_url":"https://api.github.com/users/victorhahncastell/gists{/gist_id}","starred_url":"https://api.github.com/users/victorhahncastell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorhahncastell/subscriptions","organizations_url":"https://api.github.com/users/victorhahncastell/orgs","repos_url":"https://api.github.com/users/victorhahncastell/repos","events_url":"https://api.github.com/users/victorhahncastell/events{/privacy}","received_events_url":"https://api.github.com/users/victorhahncastell/received_events","type":"User","site_admin":false},"repo":{"id":62630122,"name":"deepdiff","full_name":"victorhahncastell/deepdiff","owner":{"login":"victorhahncastell","id":3177019,"avatar_url":"https://avatars.githubusercontent.com/u/3177019?v=3","gravatar_id":"","url":"https://api.github.com/users/victorhahncastell","html_url":"https://github.com/victorhahncastell","followers_url":"https://api.github.com/users/victorhahncastell/followers","following_url":"https://api.github.com/users/victorhahncastell/following{/other_user}","gists_url":"https://api.github.com/users/victorhahncastell/gists{/gist_id}","starred_url":"https://api.github.com/users/victorhahncastell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorhahncastell/subscriptions","organizations_url":"https://api.github.com/users/victorhahncastell/orgs","repos_url":"https://api.github.com/users/victorhahncastell/repos","events_url":"https://api.github.com/users/victorhahncastell/events{/privacy}","received_events_url":"https://api.github.com/users/victorhahncastell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victorhahncastell/deepdiff","description":"Deep Difference of dictionaries, iterables, strings and other objects. It will recursively look for all the changes.","fork":true,"url":"https://api.github.com/repos/victorhahncastell/deepdiff","forks_url":"https://api.github.com/repos/victorhahncastell/deepdiff/forks","keys_url":"https://api.github.com/repos/victorhahncastell/deepdiff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victorhahncastell/deepdiff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victorhahncastell/deepdiff/teams","hooks_url":"https://api.github.com/repos/victorhahncastell/deepdiff/hooks","issue_events_url":"https://api.github.com/repos/victorhahncastell/deepdiff/issues/events{/number}","events_url":"https://api.github.com/repos/victorhahncastell/deepdiff/events","assignees_url":"https://api.github.com/repos/victorhahncastell/deepdiff/assignees{/user}","branches_url":"https://api.github.com/repos/victorhahncastell/deepdiff/branches{/branch}","tags_url":"https://api.github.com/repos/victorhahncastell/deepdiff/tags","blobs_url":"https://api.github.com/repos/victorhahncastell/deepdiff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victorhahncastell/deepdiff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victorhahncastell/deepdiff/git/refs{/sha}","trees_url":"https://api.github.com/repos/victorhahncastell/deepdiff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victorhahncastell/deepdiff/statuses/{sha}","languages_url":"https://api.github.com/repos/victorhahncastell/deepdiff/languages","stargazers_url":"https://api.github.com/repos/victorhahncastell/deepdiff/stargazers","contributors_url":"https://api.github.com/repos/victorhahncastell/deepdiff/contributors","subscribers_url":"https://api.github.com/repos/victorhahncastell/deepdiff/subscribers","subscription_url":"https://api.github.com/repos/victorhahncastell/deepdiff/subscription","commits_url":"https://api.github.com/repos/victorhahncastell/deepdiff/commits{/sha}","git_commits_url":"https://api.github.com/repos/victorhahncastell/deepdiff/git/commits{/sha}","comments_url":"https://api.github.com/repos/victorhahncastell/deepdiff/comments{/number}","issue_comment_url":"https://api.github.com/repos/victorhahncastell/deepdiff/issues/comments{/number}","contents_url":"https://api.github.com/repos/victorhahncastell/deepdiff/contents/{+path}","compare_url":"https://api.github.com/repos/victorhahncastell/deepdiff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victorhahncastell/deepdiff/merges","archive_url":"https://api.github.com/repos/victorhahncastell/deepdiff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victorhahncastell/deepdiff/downloads","issues_url":"https://api.github.com/repos/victorhahncastell/deepdiff/issues{/number}","pulls_url":"https://api.github.com/repos/victorhahncastell/deepdiff/pulls{/number}","milestones_url":"https://api.github.com/repos/victorhahncastell/deepdiff/milestones{/number}","notifications_url":"https://api.github.com/repos/victorhahncastell/deepdiff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victorhahncastell/deepdiff/labels{/name}","releases_url":"https://api.github.com/repos/victorhahncastell/deepdiff/releases{/id}","deployments_url":"https://api.github.com/repos/victorhahncastell/deepdiff/deployments","created_at":"2016-07-05T11:02:32Z","updated_at":"2016-07-05T11:02:33Z","pushed_at":"2016-07-19T16:57:41Z","git_url":"git://github.com/victorhahncastell/deepdiff.git","ssh_url":"git@github.com:victorhahncastell/deepdiff.git","clone_url":"https://github.com/victorhahncastell/deepdiff.git","svn_url":"https://github.com/victorhahncastell/deepdiff","homepage":null,"size":223,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seperman:master","ref":"master","sha":"22e2b6e4656493e340ec60bc57571c8111f69eb6","user":{"login":"seperman","id":2314797,"avatar_url":"https://avatars.githubusercontent.com/u/2314797?v=3","gravatar_id":"","url":"https://api.github.com/users/seperman","html_url":"https://github.com/seperman","followers_url":"https://api.github.com/users/seperman/followers","following_url":"https://api.github.com/users/seperman/following{/other_user}","gists_url":"https://api.github.com/users/seperman/gists{/gist_id}","starred_url":"https://api.github.com/users/seperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seperman/subscriptions","organizations_url":"https://api.github.com/users/seperman/orgs","repos_url":"https://api.github.com/users/seperman/repos","events_url":"https://api.github.com/users/seperman/events{/privacy}","received_events_url":"https://api.github.com/users/seperman/received_events","type":"User","site_admin":false},"repo":{"id":24484622,"name":"deepdiff","full_name":"seperman/deepdiff","owner":{"login":"seperman","id":2314797,"avatar_url":"https://avatars.githubusercontent.com/u/2314797?v=3","gravatar_id":"","url":"https://api.github.com/users/seperman","html_url":"https://github.com/seperman","followers_url":"https://api.github.com/users/seperman/followers","following_url":"https://api.github.com/users/seperman/following{/other_user}","gists_url":"https://api.github.com/users/seperman/gists{/gist_id}","starred_url":"https://api.github.com/users/seperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seperman/subscriptions","organizations_url":"https://api.github.com/users/seperman/orgs","repos_url":"https://api.github.com/users/seperman/repos","events_url":"https://api.github.com/users/seperman/events{/privacy}","received_events_url":"https://api.github.com/users/seperman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seperman/deepdiff","description":"Deep Difference of dictionaries, iterables, strings and other objects. It will recursively look for all the changes.","fork":false,"url":"https://api.github.com/repos/seperman/deepdiff","forks_url":"https://api.github.com/repos/seperman/deepdiff/forks","keys_url":"https://api.github.com/repos/seperman/deepdiff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seperman/deepdiff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seperman/deepdiff/teams","hooks_url":"https://api.github.com/repos/seperman/deepdiff/hooks","issue_events_url":"https://api.github.com/repos/seperman/deepdiff/issues/events{/number}","events_url":"https://api.github.com/repos/seperman/deepdiff/events","assignees_url":"https://api.github.com/repos/seperman/deepdiff/assignees{/user}","branches_url":"https://api.github.com/repos/seperman/deepdiff/branches{/branch}","tags_url":"https://api.github.com/repos/seperman/deepdiff/tags","blobs_url":"https://api.github.com/repos/seperman/deepdiff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seperman/deepdiff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seperman/deepdiff/git/refs{/sha}","trees_url":"https://api.github.com/repos/seperman/deepdiff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seperman/deepdiff/statuses/{sha}","languages_url":"https://api.github.com/repos/seperman/deepdiff/languages","stargazers_url":"https://api.github.com/repos/seperman/deepdiff/stargazers","contributors_url":"https://api.github.com/repos/seperman/deepdiff/contributors","subscribers_url":"https://api.github.com/repos/seperman/deepdiff/subscribers","subscription_url":"https://api.github.com/repos/seperman/deepdiff/subscription","commits_url":"https://api.github.com/repos/seperman/deepdiff/commits{/sha}","git_commits_url":"https://api.github.com/repos/seperman/deepdiff/git/commits{/sha}","comments_url":"https://api.github.com/repos/seperman/deepdiff/comments{/number}","issue_comment_url":"https://api.github.com/repos/seperman/deepdiff/issues/comments{/number}","contents_url":"https://api.github.com/repos/seperman/deepdiff/contents/{+path}","compare_url":"https://api.github.com/repos/seperman/deepdiff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seperman/deepdiff/merges","archive_url":"https://api.github.com/repos/seperman/deepdiff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seperman/deepdiff/downloads","issues_url":"https://api.github.com/repos/seperman/deepdiff/issues{/number}","pulls_url":"https://api.github.com/repos/seperman/deepdiff/pulls{/number}","milestones_url":"https://api.github.com/repos/seperman/deepdiff/milestones{/number}","notifications_url":"https://api.github.com/repos/seperman/deepdiff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seperman/deepdiff/labels{/name}","releases_url":"https://api.github.com/repos/seperman/deepdiff/releases{/id}","deployments_url":"https://api.github.com/repos/seperman/deepdiff/deployments","created_at":"2014-09-26T03:21:47Z","updated_at":"2016-08-01T13:46:04Z","pushed_at":"2016-07-31T06:29:57Z","git_url":"git://github.com/seperman/deepdiff.git","ssh_url":"git@github.com:seperman/deepdiff.git","clone_url":"https://github.com/seperman/deepdiff.git","svn_url":"https://github.com/seperman/deepdiff","homepage":null,"size":220,"stargazers_count":93,"watchers_count":93,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":5,"forks":23,"open_issues":5,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seperman/deepdiff/pulls/32"},"html":{"href":"https://github.com/seperman/deepdiff/pull/32"},"issue":{"href":"https://api.github.com/repos/seperman/deepdiff/issues/32"},"comments":{"href":"https://api.github.com/repos/seperman/deepdiff/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/seperman/deepdiff/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/seperman/deepdiff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seperman/deepdiff/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/seperman/deepdiff/statuses/7c0405d2d6bb773d8d2ce1fd8cfa0328db5b4807"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":25,"additions":614,"deletions":99,"changed_files":12}}
{"actor":{"display_login":"victorhahncastell"}}