{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/webui/pulls/comments/53725671","id":53725671,"diff_hunk":"@@ -0,0 +1,14 @@\n+import {expect} from 'chai'\n+import {render} from 'enzyme'\n+import React from 'react'\n+\n+import WorldMap from '../../app/scripts/components/world-map'\n+\n+describe('WorldMap', () => {\n+  it('should render an svg', () => {\n+    const c = [[12, 14]]\n+\n+    const el = render(<WorldMap coordinates={c}/>)\n+    expect(el.find('svg').length).to.equal(1)","path":"test/components/world-map.spec.js","position":12,"original_position":12,"commit_id":"87cb734276ff57ec0e1d7805417be43135e86d4d","original_commit_id":"87cb734276ff57ec0e1d7805417be43135e86d4d","user":{"login":"suisha","id":1280376,"avatar_url":"https://avatars.githubusercontent.com/u/1280376?v=3","gravatar_id":"","url":"https://api.github.com/users/suisha","html_url":"https://github.com/suisha","followers_url":"https://api.github.com/users/suisha/followers","following_url":"https://api.github.com/users/suisha/following{/other_user}","gists_url":"https://api.github.com/users/suisha/gists{/gist_id}","starred_url":"https://api.github.com/users/suisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suisha/subscriptions","organizations_url":"https://api.github.com/users/suisha/orgs","repos_url":"https://api.github.com/users/suisha/repos","events_url":"https://api.github.com/users/suisha/events{/privacy}","received_events_url":"https://api.github.com/users/suisha/received_events","type":"User","site_admin":false},"body":"I tried to think of more meaningful assertions to add here but drew a blank. The resulting output of `_renderMap` is basically all generated by `d3` and I couldn't find anything else on the rendered output that could be used to assert correctness.","created_at":"2016-02-23T01:47:07Z","updated_at":"2016-02-23T01:47:07Z","html_url":"https://github.com/ipfs/webui/pull/253#discussion_r53725671","pull_request_url":"https://api.github.com/repos/ipfs/webui/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/ipfs/webui/pulls/comments/53725671"},"html":{"href":"https://github.com/ipfs/webui/pull/253#discussion_r53725671"},"pull_request":{"href":"https://api.github.com/repos/ipfs/webui/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/webui/pulls/253","id":60137893,"html_url":"https://github.com/ipfs/webui/pull/253","diff_url":"https://github.com/ipfs/webui/pull/253.diff","patch_url":"https://github.com/ipfs/webui/pull/253.patch","issue_url":"https://api.github.com/repos/ipfs/webui/issues/253","number":253,"state":"open","locked":false,"title":"world spec","user":{"login":"suisha","id":1280376,"avatar_url":"https://avatars.githubusercontent.com/u/1280376?v=3","gravatar_id":"","url":"https://api.github.com/users/suisha","html_url":"https://github.com/suisha","followers_url":"https://api.github.com/users/suisha/followers","following_url":"https://api.github.com/users/suisha/following{/other_user}","gists_url":"https://api.github.com/users/suisha/gists{/gist_id}","starred_url":"https://api.github.com/users/suisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suisha/subscriptions","organizations_url":"https://api.github.com/users/suisha/orgs","repos_url":"https://api.github.com/users/suisha/repos","events_url":"https://api.github.com/users/suisha/events{/privacy}","received_events_url":"https://api.github.com/users/suisha/received_events","type":"User","site_admin":false},"body":"https://github.com/ipfs/webui/issues/137\r\n\r\nI'm not sure if [`_renderMap`](https://github.com/ipfs/webui/blob/redux/app/scripts/components/world.js#L21-L91) is testable here without either exposing it or doing a non-shallow render(not advisable for unit tests).\r\n\r\nWe could also make this a separate react component with width/height as state, if it's reusable.","created_at":"2016-02-22T08:11:08Z","updated_at":"2016-02-23T01:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cb7f75bfba3ccbab4ee4312dd35a98ceb497268","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/webui/pulls/253/commits","review_comments_url":"https://api.github.com/repos/ipfs/webui/pulls/253/comments","review_comment_url":"https://api.github.com/repos/ipfs/webui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/webui/issues/253/comments","statuses_url":"https://api.github.com/repos/ipfs/webui/statuses/87cb734276ff57ec0e1d7805417be43135e86d4d","head":{"label":"suisha:world-spec","ref":"world-spec","sha":"87cb734276ff57ec0e1d7805417be43135e86d4d","user":{"login":"suisha","id":1280376,"avatar_url":"https://avatars.githubusercontent.com/u/1280376?v=3","gravatar_id":"","url":"https://api.github.com/users/suisha","html_url":"https://github.com/suisha","followers_url":"https://api.github.com/users/suisha/followers","following_url":"https://api.github.com/users/suisha/following{/other_user}","gists_url":"https://api.github.com/users/suisha/gists{/gist_id}","starred_url":"https://api.github.com/users/suisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suisha/subscriptions","organizations_url":"https://api.github.com/users/suisha/orgs","repos_url":"https://api.github.com/users/suisha/repos","events_url":"https://api.github.com/users/suisha/events{/privacy}","received_events_url":"https://api.github.com/users/suisha/received_events","type":"User","site_admin":false},"repo":{"id":51892284,"name":"webui","full_name":"suisha/webui","owner":{"login":"suisha","id":1280376,"avatar_url":"https://avatars.githubusercontent.com/u/1280376?v=3","gravatar_id":"","url":"https://api.github.com/users/suisha","html_url":"https://github.com/suisha","followers_url":"https://api.github.com/users/suisha/followers","following_url":"https://api.github.com/users/suisha/following{/other_user}","gists_url":"https://api.github.com/users/suisha/gists{/gist_id}","starred_url":"https://api.github.com/users/suisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suisha/subscriptions","organizations_url":"https://api.github.com/users/suisha/orgs","repos_url":"https://api.github.com/users/suisha/repos","events_url":"https://api.github.com/users/suisha/events{/privacy}","received_events_url":"https://api.github.com/users/suisha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suisha/webui","description":"A frontend for IPFS","fork":true,"url":"https://api.github.com/repos/suisha/webui","forks_url":"https://api.github.com/repos/suisha/webui/forks","keys_url":"https://api.github.com/repos/suisha/webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suisha/webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suisha/webui/teams","hooks_url":"https://api.github.com/repos/suisha/webui/hooks","issue_events_url":"https://api.github.com/repos/suisha/webui/issues/events{/number}","events_url":"https://api.github.com/repos/suisha/webui/events","assignees_url":"https://api.github.com/repos/suisha/webui/assignees{/user}","branches_url":"https://api.github.com/repos/suisha/webui/branches{/branch}","tags_url":"https://api.github.com/repos/suisha/webui/tags","blobs_url":"https://api.github.com/repos/suisha/webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suisha/webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suisha/webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/suisha/webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suisha/webui/statuses/{sha}","languages_url":"https://api.github.com/repos/suisha/webui/languages","stargazers_url":"https://api.github.com/repos/suisha/webui/stargazers","contributors_url":"https://api.github.com/repos/suisha/webui/contributors","subscribers_url":"https://api.github.com/repos/suisha/webui/subscribers","subscription_url":"https://api.github.com/repos/suisha/webui/subscription","commits_url":"https://api.github.com/repos/suisha/webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/suisha/webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/suisha/webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/suisha/webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/suisha/webui/contents/{+path}","compare_url":"https://api.github.com/repos/suisha/webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suisha/webui/merges","archive_url":"https://api.github.com/repos/suisha/webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suisha/webui/downloads","issues_url":"https://api.github.com/repos/suisha/webui/issues{/number}","pulls_url":"https://api.github.com/repos/suisha/webui/pulls{/number}","milestones_url":"https://api.github.com/repos/suisha/webui/milestones{/number}","notifications_url":"https://api.github.com/repos/suisha/webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suisha/webui/labels{/name}","releases_url":"https://api.github.com/repos/suisha/webui/releases{/id}","deployments_url":"https://api.github.com/repos/suisha/webui/deployments","created_at":"2016-02-17T03:43:09Z","updated_at":"2016-02-17T03:43:11Z","pushed_at":"2016-02-23T01:40:21Z","git_url":"git://github.com/suisha/webui.git","ssh_url":"git@github.com:suisha/webui.git","clone_url":"https://github.com/suisha/webui.git","svn_url":"https://github.com/suisha/webui","homepage":null,"size":14066,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipfs:redux","ref":"redux","sha":"f00b678c5a511d89716245721efb86af5a654d56","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":24483721,"name":"webui","full_name":"ipfs/webui","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/webui","description":"A frontend for IPFS","fork":false,"url":"https://api.github.com/repos/ipfs/webui","forks_url":"https://api.github.com/repos/ipfs/webui/forks","keys_url":"https://api.github.com/repos/ipfs/webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/webui/teams","hooks_url":"https://api.github.com/repos/ipfs/webui/hooks","issue_events_url":"https://api.github.com/repos/ipfs/webui/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/webui/events","assignees_url":"https://api.github.com/repos/ipfs/webui/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/webui/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/webui/tags","blobs_url":"https://api.github.com/repos/ipfs/webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/webui/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/webui/languages","stargazers_url":"https://api.github.com/repos/ipfs/webui/stargazers","contributors_url":"https://api.github.com/repos/ipfs/webui/contributors","subscribers_url":"https://api.github.com/repos/ipfs/webui/subscribers","subscription_url":"https://api.github.com/repos/ipfs/webui/subscription","commits_url":"https://api.github.com/repos/ipfs/webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/webui/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/webui/merges","archive_url":"https://api.github.com/repos/ipfs/webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/webui/downloads","issues_url":"https://api.github.com/repos/ipfs/webui/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/webui/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/webui/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/webui/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/webui/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/webui/deployments","created_at":"2014-09-26T02:47:31Z","updated_at":"2016-02-22T08:29:39Z","pushed_at":"2016-02-23T01:40:21Z","git_url":"git://github.com/ipfs/webui.git","ssh_url":"git@github.com:ipfs/webui.git","clone_url":"https://github.com/ipfs/webui.git","svn_url":"https://github.com/ipfs/webui","homepage":null,"size":14215,"stargazers_count":115,"watchers_count":115,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":26,"forks":39,"open_issues":26,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/webui/pulls/253"},"html":{"href":"https://github.com/ipfs/webui/pull/253"},"issue":{"href":"https://api.github.com/repos/ipfs/webui/issues/253"},"comments":{"href":"https://api.github.com/repos/ipfs/webui/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/webui/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/webui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/webui/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/webui/statuses/87cb734276ff57ec0e1d7805417be43135e86d4d"}}}}