{"action":"created","comment":{"url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments/91622378","pull_request_review_id":12127017,"id":91622378,"diff_hunk":"@@ -176,12 +171,12 @@ def _create_encoder_graph(self):\n         self.attention_tensor = tf.nn.dropout(self.attention_tensor,\n                                               self.dropout_placeholder)\n \n-\n     def feed_dict(self, dataset, train=False):\n-        factors = {data_id: dataset.get_series(data_id) for data_id in self.data_ids}\n+        factors = {data_id: dataset.get_series(\n+            data_id) for data_id in self.data_ids}","path":"neuralmonkey/encoders/factored_encoder.py","position":124,"original_position":124,"commit_id":"c04b76ebbbefe59363e79628b7a60ee8bb3c3b29","original_commit_id":"c04b76ebbbefe59363e79628b7a60ee8bb3c3b29","user":{"login":"jindrahelcl","id":1842355,"avatar_url":"https://avatars.githubusercontent.com/u/1842355?v=3","gravatar_id":"","url":"https://api.github.com/users/jindrahelcl","html_url":"https://github.com/jindrahelcl","followers_url":"https://api.github.com/users/jindrahelcl/followers","following_url":"https://api.github.com/users/jindrahelcl/following{/other_user}","gists_url":"https://api.github.com/users/jindrahelcl/gists{/gist_id}","starred_url":"https://api.github.com/users/jindrahelcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jindrahelcl/subscriptions","organizations_url":"https://api.github.com/users/jindrahelcl/orgs","repos_url":"https://api.github.com/users/jindrahelcl/repos","events_url":"https://api.github.com/users/jindrahelcl/events{/privacy}","received_events_url":"https://api.github.com/users/jindrahelcl/received_events","type":"User","site_admin":false},"body":"já to radši škubu až před `for`, který se pak zarovná pod `data_id`, ale proti gustu.. :-)","created_at":"2016-12-08T22:31:05Z","updated_at":"2016-12-08T22:31:06Z","html_url":"https://github.com/ufal/neuralmonkey/pull/174#discussion_r91622378","pull_request_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments/91622378"},"html":{"href":"https://github.com/ufal/neuralmonkey/pull/174#discussion_r91622378"},"pull_request":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174","id":96247485,"html_url":"https://github.com/ufal/neuralmonkey/pull/174","diff_url":"https://github.com/ufal/neuralmonkey/pull/174.diff","patch_url":"https://github.com/ufal/neuralmonkey/pull/174.patch","issue_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/174","number":174,"state":"open","locked":false,"title":"Separate training and runtime attention","user":{"login":"cifkao","id":8046580,"avatar_url":"https://avatars.githubusercontent.com/u/8046580?v=3","gravatar_id":"","url":"https://api.github.com/users/cifkao","html_url":"https://github.com/cifkao","followers_url":"https://api.github.com/users/cifkao/followers","following_url":"https://api.github.com/users/cifkao/following{/other_user}","gists_url":"https://api.github.com/users/cifkao/gists{/gist_id}","starred_url":"https://api.github.com/users/cifkao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cifkao/subscriptions","organizations_url":"https://api.github.com/users/cifkao/orgs","repos_url":"https://api.github.com/users/cifkao/repos","events_url":"https://api.github.com/users/cifkao/events{/privacy}","received_events_url":"https://api.github.com/users/cifkao/received_events","type":"User","site_admin":false},"body":"Should fix the issue mentioned [here](https://github.com/ufal/neuralmonkey/pull/121#issuecomment-259075579):\r\n\r\n> The problem is that the same `Attention` object is used for constructing both the training and runtime parts of the graph, and therefore `attentions_in_time` contains tensors from both parts. Because I'm using `attentions_in_time` for visualization, I was getting images like this:\r\n>\r\n> ![tensorboard](https://cloud.githubusercontent.com/assets/8046580/20091403/dac7641a-a592-11e6-9777-ce513c1e0bb1.png)","created_at":"2016-12-02T09:35:46Z","updated_at":"2016-12-08T22:34:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2d6a6745d910c77e749b4be9ebe945c9e7efc7b","assignee":{"login":"jlibovicky","id":1221979,"avatar_url":"https://avatars.githubusercontent.com/u/1221979?v=3","gravatar_id":"","url":"https://api.github.com/users/jlibovicky","html_url":"https://github.com/jlibovicky","followers_url":"https://api.github.com/users/jlibovicky/followers","following_url":"https://api.github.com/users/jlibovicky/following{/other_user}","gists_url":"https://api.github.com/users/jlibovicky/gists{/gist_id}","starred_url":"https://api.github.com/users/jlibovicky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlibovicky/subscriptions","organizations_url":"https://api.github.com/users/jlibovicky/orgs","repos_url":"https://api.github.com/users/jlibovicky/repos","events_url":"https://api.github.com/users/jlibovicky/events{/privacy}","received_events_url":"https://api.github.com/users/jlibovicky/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlibovicky","id":1221979,"avatar_url":"https://avatars.githubusercontent.com/u/1221979?v=3","gravatar_id":"","url":"https://api.github.com/users/jlibovicky","html_url":"https://github.com/jlibovicky","followers_url":"https://api.github.com/users/jlibovicky/followers","following_url":"https://api.github.com/users/jlibovicky/following{/other_user}","gists_url":"https://api.github.com/users/jlibovicky/gists{/gist_id}","starred_url":"https://api.github.com/users/jlibovicky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlibovicky/subscriptions","organizations_url":"https://api.github.com/users/jlibovicky/orgs","repos_url":"https://api.github.com/users/jlibovicky/repos","events_url":"https://api.github.com/users/jlibovicky/events{/privacy}","received_events_url":"https://api.github.com/users/jlibovicky/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174/commits","review_comments_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174/comments","review_comment_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/174/comments","statuses_url":"https://api.github.com/repos/ufal/neuralmonkey/statuses/c04b76ebbbefe59363e79628b7a60ee8bb3c3b29","head":{"label":"ufal:fix-attentions-in-time","ref":"fix-attentions-in-time","sha":"c04b76ebbbefe59363e79628b7a60ee8bb3c3b29","user":{"login":"ufal","id":5220747,"avatar_url":"https://avatars.githubusercontent.com/u/5220747?v=3","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"repo":{"id":61285083,"name":"neuralmonkey","full_name":"ufal/neuralmonkey","owner":{"login":"ufal","id":5220747,"avatar_url":"https://avatars.githubusercontent.com/u/5220747?v=3","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufal/neuralmonkey","description":"An open-source tool for sequence learning in NLP built on TensorFlow.","fork":false,"url":"https://api.github.com/repos/ufal/neuralmonkey","forks_url":"https://api.github.com/repos/ufal/neuralmonkey/forks","keys_url":"https://api.github.com/repos/ufal/neuralmonkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufal/neuralmonkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufal/neuralmonkey/teams","hooks_url":"https://api.github.com/repos/ufal/neuralmonkey/hooks","issue_events_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/events{/number}","events_url":"https://api.github.com/repos/ufal/neuralmonkey/events","assignees_url":"https://api.github.com/repos/ufal/neuralmonkey/assignees{/user}","branches_url":"https://api.github.com/repos/ufal/neuralmonkey/branches{/branch}","tags_url":"https://api.github.com/repos/ufal/neuralmonkey/tags","blobs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufal/neuralmonkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufal/neuralmonkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufal/neuralmonkey/statuses/{sha}","languages_url":"https://api.github.com/repos/ufal/neuralmonkey/languages","stargazers_url":"https://api.github.com/repos/ufal/neuralmonkey/stargazers","contributors_url":"https://api.github.com/repos/ufal/neuralmonkey/contributors","subscribers_url":"https://api.github.com/repos/ufal/neuralmonkey/subscribers","subscription_url":"https://api.github.com/repos/ufal/neuralmonkey/subscription","commits_url":"https://api.github.com/repos/ufal/neuralmonkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufal/neuralmonkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufal/neuralmonkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufal/neuralmonkey/contents/{+path}","compare_url":"https://api.github.com/repos/ufal/neuralmonkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufal/neuralmonkey/merges","archive_url":"https://api.github.com/repos/ufal/neuralmonkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufal/neuralmonkey/downloads","issues_url":"https://api.github.com/repos/ufal/neuralmonkey/issues{/number}","pulls_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls{/number}","milestones_url":"https://api.github.com/repos/ufal/neuralmonkey/milestones{/number}","notifications_url":"https://api.github.com/repos/ufal/neuralmonkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufal/neuralmonkey/labels{/name}","releases_url":"https://api.github.com/repos/ufal/neuralmonkey/releases{/id}","deployments_url":"https://api.github.com/repos/ufal/neuralmonkey/deployments","created_at":"2016-06-16T10:46:43Z","updated_at":"2016-12-04T08:13:43Z","pushed_at":"2016-12-08T18:08:36Z","git_url":"git://github.com/ufal/neuralmonkey.git","ssh_url":"git@github.com:ufal/neuralmonkey.git","clone_url":"https://github.com/ufal/neuralmonkey.git","svn_url":"https://github.com/ufal/neuralmonkey","homepage":"","size":1026,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":62,"forks":12,"open_issues":62,"watchers":49,"default_branch":"master"}},"base":{"label":"ufal:master","ref":"master","sha":"5f5e8d9b7545f0db7d5554278e08a72e096c7832","user":{"login":"ufal","id":5220747,"avatar_url":"https://avatars.githubusercontent.com/u/5220747?v=3","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"repo":{"id":61285083,"name":"neuralmonkey","full_name":"ufal/neuralmonkey","owner":{"login":"ufal","id":5220747,"avatar_url":"https://avatars.githubusercontent.com/u/5220747?v=3","gravatar_id":"","url":"https://api.github.com/users/ufal","html_url":"https://github.com/ufal","followers_url":"https://api.github.com/users/ufal/followers","following_url":"https://api.github.com/users/ufal/following{/other_user}","gists_url":"https://api.github.com/users/ufal/gists{/gist_id}","starred_url":"https://api.github.com/users/ufal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufal/subscriptions","organizations_url":"https://api.github.com/users/ufal/orgs","repos_url":"https://api.github.com/users/ufal/repos","events_url":"https://api.github.com/users/ufal/events{/privacy}","received_events_url":"https://api.github.com/users/ufal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufal/neuralmonkey","description":"An open-source tool for sequence learning in NLP built on TensorFlow.","fork":false,"url":"https://api.github.com/repos/ufal/neuralmonkey","forks_url":"https://api.github.com/repos/ufal/neuralmonkey/forks","keys_url":"https://api.github.com/repos/ufal/neuralmonkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufal/neuralmonkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufal/neuralmonkey/teams","hooks_url":"https://api.github.com/repos/ufal/neuralmonkey/hooks","issue_events_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/events{/number}","events_url":"https://api.github.com/repos/ufal/neuralmonkey/events","assignees_url":"https://api.github.com/repos/ufal/neuralmonkey/assignees{/user}","branches_url":"https://api.github.com/repos/ufal/neuralmonkey/branches{/branch}","tags_url":"https://api.github.com/repos/ufal/neuralmonkey/tags","blobs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufal/neuralmonkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufal/neuralmonkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufal/neuralmonkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufal/neuralmonkey/statuses/{sha}","languages_url":"https://api.github.com/repos/ufal/neuralmonkey/languages","stargazers_url":"https://api.github.com/repos/ufal/neuralmonkey/stargazers","contributors_url":"https://api.github.com/repos/ufal/neuralmonkey/contributors","subscribers_url":"https://api.github.com/repos/ufal/neuralmonkey/subscribers","subscription_url":"https://api.github.com/repos/ufal/neuralmonkey/subscription","commits_url":"https://api.github.com/repos/ufal/neuralmonkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufal/neuralmonkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufal/neuralmonkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufal/neuralmonkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufal/neuralmonkey/contents/{+path}","compare_url":"https://api.github.com/repos/ufal/neuralmonkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufal/neuralmonkey/merges","archive_url":"https://api.github.com/repos/ufal/neuralmonkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufal/neuralmonkey/downloads","issues_url":"https://api.github.com/repos/ufal/neuralmonkey/issues{/number}","pulls_url":"https://api.github.com/repos/ufal/neuralmonkey/pulls{/number}","milestones_url":"https://api.github.com/repos/ufal/neuralmonkey/milestones{/number}","notifications_url":"https://api.github.com/repos/ufal/neuralmonkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufal/neuralmonkey/labels{/name}","releases_url":"https://api.github.com/repos/ufal/neuralmonkey/releases{/id}","deployments_url":"https://api.github.com/repos/ufal/neuralmonkey/deployments","created_at":"2016-06-16T10:46:43Z","updated_at":"2016-12-04T08:13:43Z","pushed_at":"2016-12-08T18:08:36Z","git_url":"git://github.com/ufal/neuralmonkey.git","ssh_url":"git@github.com:ufal/neuralmonkey.git","clone_url":"https://github.com/ufal/neuralmonkey.git","svn_url":"https://github.com/ufal/neuralmonkey","homepage":"","size":1026,"stargazers_count":49,"watchers_count":49,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":62,"forks":12,"open_issues":62,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174"},"html":{"href":"https://github.com/ufal/neuralmonkey/pull/174"},"issue":{"href":"https://api.github.com/repos/ufal/neuralmonkey/issues/174"},"comments":{"href":"https://api.github.com/repos/ufal/neuralmonkey/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufal/neuralmonkey/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/ufal/neuralmonkey/statuses/c04b76ebbbefe59363e79628b7a60ee8bb3c3b29"}}}}
{"actor":{"display_login":"jindrahelcl"}}