{"push_id":1358939881,"size":68,"distinct_size":48,"ref":"refs/heads/sparse_iohelper3","head":"fa380932b305c85b6daf384dbe1e0c735aca9cf5","before":"4e01874033ea535910cc2725488af3d94cbf8ba8","commits":[{"sha":"88ecc38f031bd181abf345f4e8898d08eea9b745","author":{"name":"Martin Kletzander","email":"b95c1c5986c2c30eff5096e3d1c8d4510b550570@redhat.com"},"message":"schema: Allow alias for panic device\n\nAs with all other devices, it's not part of 'address'.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/88ecc38f031bd181abf345f4e8898d08eea9b745"},{"sha":"041dfc2b7d493a82f568ff54f670e29b9144c97f","author":{"name":"Martin Kletzander","email":"b95c1c5986c2c30eff5096e3d1c8d4510b550570@redhat.com"},"message":"conf: Honour flags in virDomainPanicDefParseXML\n\nWithout them we're keeping <alias/> even for inactive XML.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/041dfc2b7d493a82f568ff54f670e29b9144c97f"},{"sha":"f29b13f8307985cffbd8a1a8c25bc4421db6f8a5","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"util: Alter return value of virReadFCHost and fix mem leak\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1357416\n\nRather than return a 0 or -1 and the *result string, return just the result\nstring to the caller.  Alter all the callers to handle the different return.\n\nAs a side effect or result of this, it's much clearer that we cannot just\nassign the returned string into the scsi_host wwnn, wwpn, and fabric_wwn\nfields - rather we should fetch a temporary string, then as long as our\nfetch was good, VIR_FREE what may have been there, and STEAL what we just got.\nThis fixes a memory leak in the virNodeDeviceCreateXML code path through\nfind_new_device and nodeDeviceLookupSCSIHostByWWN which will continually\ncall nodeDeviceSysfsGetSCSIHostCaps until the expected wwnn/wwpn is found\nin the device object capabilities.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/f29b13f8307985cffbd8a1a8c25bc4421db6f8a5"},{"sha":"538220c3c42cad0adbd818b6a931c69492a572de","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"conf: restrict what type of buses will accept a pci-bridge\n\nA pci-bridge has *almost* the same rules as a legacy PCI endpoint\ndevice for where it can be automatically connected, and until now both\nhad been considered identical. There is one pairing that is okay when\nspecifically requested by the user (i.e. manual assignment), but we\nwant to avoid it when auto-assigning addresses - plugging a pci-bridge\ndirectly into pcie-root (it is cleaner to plug in a dmi-to-pci-bridge,\nthen plug the pci-bridge into that).\n\nIn order to allow that difference, this patch makes a separate\nCONNECT_TYPE for pci-bridge, and uses it to restrict auto-assigned\naddresses for pci-bridges to be only on pci-root, pci-expander-bus,\ndmi-to-pci-bridge, or on another pci-bridge.\n\nNB: As with other discouraged-but-seem-to-work configurations\n(e.g. plugging a legacy PCI device into a pcie-root-port) if someone\n*really* wants to, they can still force a pci-bridge to be plugged\ninto pcie-root (by manually specifying its PCI address.)","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/538220c3c42cad0adbd818b6a931c69492a572de"},{"sha":"61e101437bd5bdeedf843cd5bc7a4950684d905f","author":{"name":"Andrea Bolognani","email":"0c58d8c54619c257465b8c09c1c6917894f8def9@redhat.com"},"message":"conf: Explain some code in more detail\n\nThe code is entirely correct, but it still managed to trip me\nup when I first ran into it because I did not realize right away\nthat VIR_PCI_CONNECT_TYPES_ENDPOINT was not a single flag, but\nrather a mask including both VIR_PCI_CONNECT_TYPE_PCI_DEVICE and\nVIR_PCI_CONNECT_TYPE_PCIE_DEVICE.\n\nIn order to save the next distracted traveler in PCI Address Land\nsome time, document this fact with a comment. Add a test case for\nthe behavior as well.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/61e101437bd5bdeedf843cd5bc7a4950684d905f"},{"sha":"a99d9082ac00f7ca544f1d86abda20be3f688c68","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Remove unnecessary cfg fetch/unref\n\nqemuProcessPrepareDomain has no need to fetch/unref the cfg, so remove it.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/a99d9082ac00f7ca544f1d86abda20be3f688c68"},{"sha":"40b6f919001565b03fa5dd394a45df470c2b7a07","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Add 'verify-peer=yes' test for chardev TCP TLS\n\nMissing the option to set verify-peer to yes\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/40b6f919001565b03fa5dd394a45df470c2b7a07"},{"sha":"6262a9b282bf55a0b39abb49f54e18c7cb61c3dd","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Remove unnecessary NULL arg check\n\nqemuDomainSecret{Disk|Hostdev}Prepare has a prototype that checks for\nATTRIBUTE_NONNULL(1) for 'conn'.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/6262a9b282bf55a0b39abb49f54e18c7cb61c3dd"},{"sha":"08107826644daa0af710c36aa9282f590e0438dc","author":{"name":"Pavel Hrdina","email":"ab12192c95093947fa56ccf60770e010465455a4@redhat.com"},"message":"qemu_hotplug: fix crash in hot(un)plugging chardev devices\n\nWe need to make sure that the chardev is TCP.  Without this check we\nmay access different part of union and corrupt pointers.\n\nSigned-off-by: Pavel Hrdina <phrdina@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/08107826644daa0af710c36aa9282f590e0438dc"},{"sha":"b5459326ec6121e135b64974fb96f695578f945d","author":{"name":"Pavel Hrdina","email":"ab12192c95093947fa56ccf60770e010465455a4@redhat.com"},"message":"qemu_alias: introduce qemuAliasChardevFromDevAlias helper\n\nSigned-off-by: Pavel Hrdina <phrdina@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/b5459326ec6121e135b64974fb96f695578f945d"},{"sha":"635b5ec8e8123b3954a2eb957114d3dbed8d1ab9","author":{"name":"Pavel Hrdina","email":"ab12192c95093947fa56ccf60770e010465455a4@redhat.com"},"message":"qemu_command: create prefixed alias to separate variable\n\nInstead of typing the prefix every time we want to append parameters\nto qemu command line use a variable that contains prefixed alias.\n\nSigned-off-by: Pavel Hrdina <phrdina@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/635b5ec8e8123b3954a2eb957114d3dbed8d1ab9"},{"sha":"df93b5f5f53da7eb607da09862dadfcb140ada1e","author":{"name":"Pavel Hrdina","email":"ab12192c95093947fa56ccf60770e010465455a4@redhat.com"},"message":"qemu: always generate the same alias for tls-creds-x509 object\n\nThere was inconsistency between alias used to create tls-creds-x509\nobject and alias used to link that object to chardev while hotpluging.\nHotplug ends with this error:\n\n  error: Failed to detach device from channel-tcp.xml\n  error: internal error: unable to execute QEMU command 'chardev-add':\n  No TLS credentials with id 'objcharchannel3_tls0'\n\nIn XML we have for example alias \"serial0\", but on qemu command line we\ngenerate \"charserial0\".\n\nThe issue was that code, that creates QMP command to hotplug chardev\ndevices uses only the second alias \"charserial0\" and that alias is also\nused to link the tls-creds-x509 object.\n\nThis patch unifies the aliases for tls-creds-x509 to be always generated\nfrom \"charserial0\".\n\nSigned-off-by: Pavel Hrdina <phrdina@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/df93b5f5f53da7eb607da09862dadfcb140ada1e"},{"sha":"8126d870783e69cfa9e9f8b366f21548c1abe3fa","author":{"name":"Cédric Bosdonnat","email":"a37af6b5c72cbfe05bb0466e63b2605bb9242c50@suse.com"},"message":"xl: don't output (null) target in domxml-to-native\n\nWhen converting a domain xml containing a CDROM device without\nany attached source, don't add a target=(null) to the libxl config\ndisk definition: xen doesn't like it at all and would fail to start\nthe domain.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/8126d870783e69cfa9e9f8b366f21548c1abe3fa"},{"sha":"c9ddecdf44d7a051402a3ace248742735c249762","author":{"name":"Andrea Bolognani","email":"0c58d8c54619c257465b8c09c1c6917894f8def9@redhat.com"},"message":"spec: Drop support for Fedora < 23\n\nWe only claim support for OSs that are still supported by the\nrespective vendors, which means anything older than Fedora 23\nis out. Reword the comment a bit to highlight the criteria.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/c9ddecdf44d7a051402a3ace248742735c249762"},{"sha":"710d875fb7d1e3c584415105a67f66724d0ea89d","author":{"name":"Cédric Bosdonnat","email":"a37af6b5c72cbfe05bb0466e63b2605bb9242c50@suse.com"},"message":"xl: fix 8126d870 broken test\n\nxlconfigtest expects the comma, don't clean it up even if there is\nno target to write.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/710d875fb7d1e3c584415105a67f66724d0ea89d"},{"sha":"3b668bb51ad0ed7f95fef0b0afafed47937c1495","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"conf: Introduce {default|chardev}_tls_x509_secret_uuid\n\nAdd a new qemu.conf variables to store the UUID for the secret that could\nbe used to present credentials to access the TLS chardev.  Since this will\nbe a server level and it's possible to use some sort of default, introduce\nboth the default and chardev logic at the same time making the setting of\nthe chardev check for it's own value, then if not present checking whether\nthe default value had been set.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/3b668bb51ad0ed7f95fef0b0afafed47937c1495"},{"sha":"5f2a132786da3727349a168418dce9cb3e0e54a2","author":{"name":"John Ferlan","email":"ea4b206ebea463545bcc9d546f93a642d7aeb984@redhat.com"},"message":"qemu: Introduce qemuDomainChardevPrivatePtr\n\nModeled after the qemuDomainHostdevPrivatePtr (commit id '27726d8c'),\ncreate a privateData pointer in the _virDomainChardevDef to allow storage\nof private data for a hypervisor in order to at least temporarily store\nsecret data for usage during qemuBuildCommandLine.\n\nNB: Since the qemu_parse_command (qemuParseCommandLine) code is not\nexpecting to restore the secret data, there's no need to add code\ncode to handle this new structure there.\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/5f2a132786da3727349a168418dce9cb3e0e54a2"},{"sha":"7a2216460f8a67c305364d69d33847a3b845e708","author":{"name":"Sławek Kapłoński","email":"ac1c02f3fc8111a986fb418d7b448f2c63c7cdf7@kaplonski.pl"},"message":"virxml: Add function to check if string contains some illegal chars\n\nThis new function can be used to check if e.g. name of XML\nnode don't contains forbidden chars like \"/\" or \"\\n\".\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/7a2216460f8a67c305364d69d33847a3b845e708"},{"sha":"e1b8196866c2c70bc7303ee69561e7f52edb8460","author":{"name":"Sławek Kapłoński","email":"ac1c02f3fc8111a986fb418d7b448f2c63c7cdf7@kaplonski.pl"},"message":"network: Use new util function to check name\n\nNew util function virXMLCheckIllegalChars is now used to test if\nparsed network contains illegal char '/' in it's name.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/e1b8196866c2c70bc7303ee69561e7f52edb8460"},{"sha":"dc40dd605800c560dec6ec73b7bbd922666e5d73","author":{"name":"Sławek Kapłoński","email":"ac1c02f3fc8111a986fb418d7b448f2c63c7cdf7@kaplonski.pl"},"message":"networkValidate: Forbid new-line char in network name\n\nNew line character in name of network is now forbidden because it\nmess virsh output and can be confusing for users.  Validation of\nname is done in network driver, after parsing XML to avoid\nproblems with disappeared network which was already created with\nnew-line char in name.\n\nCloses-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=818064\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/dc40dd605800c560dec6ec73b7bbd922666e5d73"}]}
{"actor":{"display_login":"zippy2"}}