{"action":"created","comment":{"url":"https://api.github.com/repos/root-mirror/cling/pulls/comments/78141141","id":78141141,"diff_hunk":"@@ -893,16 +902,64 @@ namespace {\n     // of the two is the underlying compiler.\n \n #ifdef __clang__\n-    PPOpts.addMacroDef(\"__CLING__clang__=\" ClingStringify(__clang__));\n+  #if defined(__apple_build_version__)\n+     // __apple_build_version__ >= 8000031 Xcode 8\n+     #if __apple_build_version__ >= 7030029","path":"lib/Interpreter/CIFactory.cpp","position":216,"original_position":70,"commit_id":"e12537948662edc0fa95e3430d58c72a8af88ee1","original_commit_id":"b4f2baf32f9f487ec89e057417f50fa172253306","user":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"body":"Because of Apple's macro's there's no good way to get the version on clang compiled with.  It's a nice opportunity to be more specific, and this makes it much easier to get the version in cling. __clang__ is already defined as __clang__ so it's not losing any information.\r\n\r\n","created_at":"2016-09-09T07:50:25Z","updated_at":"2016-09-09T07:50:25Z","html_url":"https://github.com/root-mirror/cling/pull/46#discussion_r78141141","pull_request_url":"https://api.github.com/repos/root-mirror/cling/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/root-mirror/cling/pulls/comments/78141141"},"html":{"href":"https://github.com/root-mirror/cling/pull/46#discussion_r78141141"},"pull_request":{"href":"https://api.github.com/repos/root-mirror/cling/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/root-mirror/cling/pulls/46","id":84338182,"html_url":"https://github.com/root-mirror/cling/pull/46","diff_url":"https://github.com/root-mirror/cling/pull/46.diff","patch_url":"https://github.com/root-mirror/cling/pull/46.patch","issue_url":"https://api.github.com/repos/root-mirror/cling/issues/46","number":46,"state":"open","locked":false,"title":"Fallback to getting system version with sw_vers","user":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-07T17:03:14Z","updated_at":"2016-09-09T07:50:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1715d2d4b465e7b09734bb05deab3c7bb421561f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-mirror/cling/pulls/46/commits","review_comments_url":"https://api.github.com/repos/root-mirror/cling/pulls/46/comments","review_comment_url":"https://api.github.com/repos/root-mirror/cling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-mirror/cling/issues/46/comments","statuses_url":"https://api.github.com/repos/root-mirror/cling/statuses/e12537948662edc0fa95e3430d58c72a8af88ee1","head":{"label":"marsupial:pr7.4","ref":"pr7.4","sha":"e12537948662edc0fa95e3430d58c72a8af88ee1","user":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"repo":{"id":60884930,"name":"cling","full_name":"marsupial/cling","owner":{"login":"marsupial","id":1831409,"avatar_url":"https://avatars.githubusercontent.com/u/1831409?v=3","gravatar_id":"","url":"https://api.github.com/users/marsupial","html_url":"https://github.com/marsupial","followers_url":"https://api.github.com/users/marsupial/followers","following_url":"https://api.github.com/users/marsupial/following{/other_user}","gists_url":"https://api.github.com/users/marsupial/gists{/gist_id}","starred_url":"https://api.github.com/users/marsupial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsupial/subscriptions","organizations_url":"https://api.github.com/users/marsupial/orgs","repos_url":"https://api.github.com/users/marsupial/repos","events_url":"https://api.github.com/users/marsupial/events{/privacy}","received_events_url":"https://api.github.com/users/marsupial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marsupial/cling","description":"cling, the C++ interpreter","fork":true,"url":"https://api.github.com/repos/marsupial/cling","forks_url":"https://api.github.com/repos/marsupial/cling/forks","keys_url":"https://api.github.com/repos/marsupial/cling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marsupial/cling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marsupial/cling/teams","hooks_url":"https://api.github.com/repos/marsupial/cling/hooks","issue_events_url":"https://api.github.com/repos/marsupial/cling/issues/events{/number}","events_url":"https://api.github.com/repos/marsupial/cling/events","assignees_url":"https://api.github.com/repos/marsupial/cling/assignees{/user}","branches_url":"https://api.github.com/repos/marsupial/cling/branches{/branch}","tags_url":"https://api.github.com/repos/marsupial/cling/tags","blobs_url":"https://api.github.com/repos/marsupial/cling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marsupial/cling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marsupial/cling/git/refs{/sha}","trees_url":"https://api.github.com/repos/marsupial/cling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marsupial/cling/statuses/{sha}","languages_url":"https://api.github.com/repos/marsupial/cling/languages","stargazers_url":"https://api.github.com/repos/marsupial/cling/stargazers","contributors_url":"https://api.github.com/repos/marsupial/cling/contributors","subscribers_url":"https://api.github.com/repos/marsupial/cling/subscribers","subscription_url":"https://api.github.com/repos/marsupial/cling/subscription","commits_url":"https://api.github.com/repos/marsupial/cling/commits{/sha}","git_commits_url":"https://api.github.com/repos/marsupial/cling/git/commits{/sha}","comments_url":"https://api.github.com/repos/marsupial/cling/comments{/number}","issue_comment_url":"https://api.github.com/repos/marsupial/cling/issues/comments{/number}","contents_url":"https://api.github.com/repos/marsupial/cling/contents/{+path}","compare_url":"https://api.github.com/repos/marsupial/cling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marsupial/cling/merges","archive_url":"https://api.github.com/repos/marsupial/cling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marsupial/cling/downloads","issues_url":"https://api.github.com/repos/marsupial/cling/issues{/number}","pulls_url":"https://api.github.com/repos/marsupial/cling/pulls{/number}","milestones_url":"https://api.github.com/repos/marsupial/cling/milestones{/number}","notifications_url":"https://api.github.com/repos/marsupial/cling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marsupial/cling/labels{/name}","releases_url":"https://api.github.com/repos/marsupial/cling/releases{/id}","deployments_url":"https://api.github.com/repos/marsupial/cling/deployments","created_at":"2016-06-11T00:57:45Z","updated_at":"2016-06-11T00:57:46Z","pushed_at":"2016-09-09T07:35:29Z","git_url":"git://github.com/marsupial/cling.git","ssh_url":"git@github.com:marsupial/cling.git","clone_url":"https://github.com/marsupial/cling.git","svn_url":"https://github.com/marsupial/cling","homepage":null,"size":16786,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-mirror:master","ref":"master","sha":"a34f2512c4341e3d5d551d25ad65d52f979e5406","user":{"login":"root-mirror","id":4849136,"avatar_url":"https://avatars.githubusercontent.com/u/4849136?v=3","gravatar_id":"","url":"https://api.github.com/users/root-mirror","html_url":"https://github.com/root-mirror","followers_url":"https://api.github.com/users/root-mirror/followers","following_url":"https://api.github.com/users/root-mirror/following{/other_user}","gists_url":"https://api.github.com/users/root-mirror/gists{/gist_id}","starred_url":"https://api.github.com/users/root-mirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-mirror/subscriptions","organizations_url":"https://api.github.com/users/root-mirror/orgs","repos_url":"https://api.github.com/users/root-mirror/repos","events_url":"https://api.github.com/users/root-mirror/events{/privacy}","received_events_url":"https://api.github.com/users/root-mirror/received_events","type":"Organization","site_admin":false},"repo":{"id":49210203,"name":"cling","full_name":"root-mirror/cling","owner":{"login":"root-mirror","id":4849136,"avatar_url":"https://avatars.githubusercontent.com/u/4849136?v=3","gravatar_id":"","url":"https://api.github.com/users/root-mirror","html_url":"https://github.com/root-mirror","followers_url":"https://api.github.com/users/root-mirror/followers","following_url":"https://api.github.com/users/root-mirror/following{/other_user}","gists_url":"https://api.github.com/users/root-mirror/gists{/gist_id}","starred_url":"https://api.github.com/users/root-mirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-mirror/subscriptions","organizations_url":"https://api.github.com/users/root-mirror/orgs","repos_url":"https://api.github.com/users/root-mirror/repos","events_url":"https://api.github.com/users/root-mirror/events{/privacy}","received_events_url":"https://api.github.com/users/root-mirror/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-mirror/cling","description":"cling, the C++ interpreter","fork":false,"url":"https://api.github.com/repos/root-mirror/cling","forks_url":"https://api.github.com/repos/root-mirror/cling/forks","keys_url":"https://api.github.com/repos/root-mirror/cling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-mirror/cling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-mirror/cling/teams","hooks_url":"https://api.github.com/repos/root-mirror/cling/hooks","issue_events_url":"https://api.github.com/repos/root-mirror/cling/issues/events{/number}","events_url":"https://api.github.com/repos/root-mirror/cling/events","assignees_url":"https://api.github.com/repos/root-mirror/cling/assignees{/user}","branches_url":"https://api.github.com/repos/root-mirror/cling/branches{/branch}","tags_url":"https://api.github.com/repos/root-mirror/cling/tags","blobs_url":"https://api.github.com/repos/root-mirror/cling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-mirror/cling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-mirror/cling/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-mirror/cling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-mirror/cling/statuses/{sha}","languages_url":"https://api.github.com/repos/root-mirror/cling/languages","stargazers_url":"https://api.github.com/repos/root-mirror/cling/stargazers","contributors_url":"https://api.github.com/repos/root-mirror/cling/contributors","subscribers_url":"https://api.github.com/repos/root-mirror/cling/subscribers","subscription_url":"https://api.github.com/repos/root-mirror/cling/subscription","commits_url":"https://api.github.com/repos/root-mirror/cling/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-mirror/cling/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-mirror/cling/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-mirror/cling/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-mirror/cling/contents/{+path}","compare_url":"https://api.github.com/repos/root-mirror/cling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-mirror/cling/merges","archive_url":"https://api.github.com/repos/root-mirror/cling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-mirror/cling/downloads","issues_url":"https://api.github.com/repos/root-mirror/cling/issues{/number}","pulls_url":"https://api.github.com/repos/root-mirror/cling/pulls{/number}","milestones_url":"https://api.github.com/repos/root-mirror/cling/milestones{/number}","notifications_url":"https://api.github.com/repos/root-mirror/cling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-mirror/cling/labels{/name}","releases_url":"https://api.github.com/repos/root-mirror/cling/releases{/id}","deployments_url":"https://api.github.com/repos/root-mirror/cling/deployments","created_at":"2016-01-07T14:45:35Z","updated_at":"2016-09-05T23:43:05Z","pushed_at":"2016-09-09T07:35:29Z","git_url":"git://github.com/root-mirror/cling.git","ssh_url":"git@github.com:root-mirror/cling.git","clone_url":"https://github.com/root-mirror/cling.git","svn_url":"https://github.com/root-mirror/cling","homepage":null,"size":16614,"stargazers_count":91,"watchers_count":91,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-mirror/cling/pulls/46"},"html":{"href":"https://github.com/root-mirror/cling/pull/46"},"issue":{"href":"https://api.github.com/repos/root-mirror/cling/issues/46"},"comments":{"href":"https://api.github.com/repos/root-mirror/cling/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/root-mirror/cling/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/root-mirror/cling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-mirror/cling/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/root-mirror/cling/statuses/e12537948662edc0fa95e3430d58c72a8af88ee1"}}}}
{"actor":{"display_login":"marsupial"}}