{"action":"closed","number":226,"pull_request":{"url":"https://api.github.com/repos/cfpb/college-costs/pulls/226","id":78701187,"html_url":"https://github.com/cfpb/college-costs/pull/226","diff_url":"https://github.com/cfpb/college-costs/pull/226.diff","patch_url":"https://github.com/cfpb/college-costs/pull/226.patch","issue_url":"https://api.github.com/repos/cfpb/college-costs/issues/226","number":226,"state":"closed","locked":false,"title":"Miscellaneous static and dynamic content updates","user":{"login":"marteki","id":1183435,"avatar_url":"https://avatars.githubusercontent.com/u/1183435?v=3","gravatar_id":"","url":"https://api.github.com/users/marteki","html_url":"https://github.com/marteki","followers_url":"https://api.github.com/users/marteki/followers","following_url":"https://api.github.com/users/marteki/following{/other_user}","gists_url":"https://api.github.com/users/marteki/gists{/gist_id}","starred_url":"https://api.github.com/users/marteki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marteki/subscriptions","organizations_url":"https://api.github.com/users/marteki/orgs","repos_url":"https://api.github.com/users/marteki/repos","events_url":"https://api.github.com/users/marteki/events{/privacy}","received_events_url":"https://api.github.com/users/marteki/received_events","type":"User","site_admin":false},"body":"This fixes errors in the static content and error messaging for the tool. It also adjusts the dynamic showing/hiding for job placement rates and program type to address bugs.\r\n\r\n## Additions\r\n\r\n- Missing words or periods as needed per the rules of English grammar 😄 \r\n\r\n## Removals\r\n\r\n- Content that has been removed due to negotiations\r\n\r\n## Changes\r\n\r\n- Adjusts the criteria for dynamic showing/hiding of job placement rates\r\n- Adjusts how to determine whether a program offers a degree or a certificate\r\n\r\n## Testing\r\n\r\nPull down the branch, and load up a sample URL on localhost.\r\n\r\n- If more than the allowed amount is inputted for military tuition assistance, the error message should use the word 'awarded' instead of 'borrowed'.\r\n- The content in the Step 1 Federal Loans section about tax burdens and tax advisors should be gone.\r\n- The content at the end of Step 1 should state \"Think about how borrowing $X,XXX this year will affect your future finances\" instead of \"Think about how $X,XXX this year will affect your future finances\".\r\n- The sentence in Step 2 that ends with \"to borrow money to purchase a car or a home\" should end in a period.\r\n- If not given by the school, the job placement rate paragraph should be hidden, and you should not see a NaN% value in Step 2 for it.\r\n- The question between Step 2 and Step 3 should accurately display whether the program [offers a degree](http://localhost:8000/paying-for-college2/understanding-your-financial-aid-offer/offer/?iped=234492&pid=94&oid=740280139f3238cbc9702c7b0d62e5c238a835d0&book=850&gib=6000&gpl=0&hous=20000&insl=0&insi=1&inst=1&mta=4500&othg=2000&othr=500&parl=0&pelg=4000&perl=0&prvf=0&prvi=8&prvl=0&ppl=0&schg=2000&stag=2000&subl=1000&totl=88592&tran=5000&tuit=30000&unsl=1000&wkst=0) or [offers a certificate](http://localhost:8000/paying-for-college2/understanding-your-financial-aid-offer/offer/?iped=117113&pid=2765&totl=50000&tuit=30000&hous=20000&book=10000&tran=5000&othr=500&pelg=0&schg=2000&stag=3000&othg=2000&mta=2000&gib=5000&wkst=100&ppl=2110&parl=1234&perl=0&subl=0&unsl=0&gpl=0&prvl=0&prvi=20&prvf=10&insl=10000&insi=4&inst=50&oid=9e0280139f3238cbc9702c7b0d62e5c238a835d0).\r\n\r\n\r\nAll JS unit tests should pass.\r\nAfter some package updates and patching, our NPM security test should pass.\r\n**Functional browser tests are still not passing. They will be re-evaluated and refactored in a coming PR.**\r\n\r\n## Review\r\n\r\n- @mistergone @higs4281 @amymok @anselmbradford\r\n\r\n## Checklist\r\n\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [x] Visually tested in supported browsers and devices\r\n* [x] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n","created_at":"2016-07-25T15:25:37Z","updated_at":"2016-07-25T17:29:07Z","closed_at":"2016-07-25T17:29:07Z","merged_at":"2016-07-25T17:29:07Z","merge_commit_sha":"c2d1a653df8390849ddf84f5f71ffdc064b4c2cb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/college-costs/pulls/226/commits","review_comments_url":"https://api.github.com/repos/cfpb/college-costs/pulls/226/comments","review_comment_url":"https://api.github.com/repos/cfpb/college-costs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/college-costs/issues/226/comments","statuses_url":"https://api.github.com/repos/cfpb/college-costs/statuses/ad787c7c742af09c76246b9f2c0b257f16967a39","head":{"label":"cfpb:content-content-content","ref":"content-content-content","sha":"ad787c7c742af09c76246b9f2c0b257f16967a39","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":43300650,"name":"college-costs","full_name":"cfpb/college-costs","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/college-costs","description":"A tool to help students weigh the costs and rewards of a college program. ","fork":false,"url":"https://api.github.com/repos/cfpb/college-costs","forks_url":"https://api.github.com/repos/cfpb/college-costs/forks","keys_url":"https://api.github.com/repos/cfpb/college-costs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/college-costs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/college-costs/teams","hooks_url":"https://api.github.com/repos/cfpb/college-costs/hooks","issue_events_url":"https://api.github.com/repos/cfpb/college-costs/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/college-costs/events","assignees_url":"https://api.github.com/repos/cfpb/college-costs/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/college-costs/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/college-costs/tags","blobs_url":"https://api.github.com/repos/cfpb/college-costs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/college-costs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/college-costs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/college-costs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/college-costs/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/college-costs/languages","stargazers_url":"https://api.github.com/repos/cfpb/college-costs/stargazers","contributors_url":"https://api.github.com/repos/cfpb/college-costs/contributors","subscribers_url":"https://api.github.com/repos/cfpb/college-costs/subscribers","subscription_url":"https://api.github.com/repos/cfpb/college-costs/subscription","commits_url":"https://api.github.com/repos/cfpb/college-costs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/college-costs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/college-costs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/college-costs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/college-costs/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/college-costs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/college-costs/merges","archive_url":"https://api.github.com/repos/cfpb/college-costs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/college-costs/downloads","issues_url":"https://api.github.com/repos/cfpb/college-costs/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/college-costs/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/college-costs/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/college-costs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/college-costs/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/college-costs/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/college-costs/deployments","created_at":"2015-09-28T12:51:23Z","updated_at":"2016-03-15T21:45:30Z","pushed_at":"2016-07-25T17:29:08Z","git_url":"git://github.com/cfpb/college-costs.git","ssh_url":"git@github.com:cfpb/college-costs.git","clone_url":"https://github.com/cfpb/college-costs.git","svn_url":"https://github.com/cfpb/college-costs","homepage":null,"size":30749,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"83578eea9334dc2d2b9754cbcc277e81d9ed56f0","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":43300650,"name":"college-costs","full_name":"cfpb/college-costs","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/college-costs","description":"A tool to help students weigh the costs and rewards of a college program. ","fork":false,"url":"https://api.github.com/repos/cfpb/college-costs","forks_url":"https://api.github.com/repos/cfpb/college-costs/forks","keys_url":"https://api.github.com/repos/cfpb/college-costs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/college-costs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/college-costs/teams","hooks_url":"https://api.github.com/repos/cfpb/college-costs/hooks","issue_events_url":"https://api.github.com/repos/cfpb/college-costs/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/college-costs/events","assignees_url":"https://api.github.com/repos/cfpb/college-costs/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/college-costs/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/college-costs/tags","blobs_url":"https://api.github.com/repos/cfpb/college-costs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/college-costs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/college-costs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/college-costs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/college-costs/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/college-costs/languages","stargazers_url":"https://api.github.com/repos/cfpb/college-costs/stargazers","contributors_url":"https://api.github.com/repos/cfpb/college-costs/contributors","subscribers_url":"https://api.github.com/repos/cfpb/college-costs/subscribers","subscription_url":"https://api.github.com/repos/cfpb/college-costs/subscription","commits_url":"https://api.github.com/repos/cfpb/college-costs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/college-costs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/college-costs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/college-costs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/college-costs/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/college-costs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/college-costs/merges","archive_url":"https://api.github.com/repos/cfpb/college-costs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/college-costs/downloads","issues_url":"https://api.github.com/repos/cfpb/college-costs/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/college-costs/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/college-costs/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/college-costs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/college-costs/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/college-costs/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/college-costs/deployments","created_at":"2015-09-28T12:51:23Z","updated_at":"2016-03-15T21:45:30Z","pushed_at":"2016-07-25T17:29:08Z","git_url":"git://github.com/cfpb/college-costs.git","ssh_url":"git@github.com:cfpb/college-costs.git","clone_url":"https://github.com/cfpb/college-costs.git","svn_url":"https://github.com/cfpb/college-costs","homepage":null,"size":30749,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/college-costs/pulls/226"},"html":{"href":"https://github.com/cfpb/college-costs/pull/226"},"issue":{"href":"https://api.github.com/repos/cfpb/college-costs/issues/226"},"comments":{"href":"https://api.github.com/repos/cfpb/college-costs/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/college-costs/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/college-costs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/college-costs/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/college-costs/statuses/ad787c7c742af09c76246b9f2c0b257f16967a39"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"marteki","id":1183435,"avatar_url":"https://avatars.githubusercontent.com/u/1183435?v=3","gravatar_id":"","url":"https://api.github.com/users/marteki","html_url":"https://github.com/marteki","followers_url":"https://api.github.com/users/marteki/followers","following_url":"https://api.github.com/users/marteki/following{/other_user}","gists_url":"https://api.github.com/users/marteki/gists{/gist_id}","starred_url":"https://api.github.com/users/marteki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marteki/subscriptions","organizations_url":"https://api.github.com/users/marteki/orgs","repos_url":"https://api.github.com/users/marteki/repos","events_url":"https://api.github.com/users/marteki/events{/privacy}","received_events_url":"https://api.github.com/users/marteki/received_events","type":"User","site_admin":false},"comments":15,"review_comments":2,"commits":10,"additions":251,"deletions":818,"changed_files":6}}
{"actor":{"display_login":"marteki"}}