{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/autorest/pulls/comments/83890760","pull_request_review_id":4703873,"id":83890760,"diff_hunk":"@@ -252,4 +252,10 @@\n   <data name=\"InvalidConstraint\" xml:space=\"preserve\">\n     <value>Constraint is not supported for this type and will be ignored.</value>\n   </data>\n+  <data name=\"OperationParametersNotAllowedMessage\" xml:space=\"preserve\">\n+    <value>Parameters \"subscriptionId\" and \"api-version\" are not allowed in the operations section of azure swagger specs</value>","path":"src/core/AutoRest.Core/Properties/Resources.resx","position":5,"original_position":5,"commit_id":"3f434feae48298891c582a9c40cef419c868fbce","original_commit_id":"3f434feae48298891c582a9c40cef419c868fbce","user":{"login":"fearthecowboy","id":133736,"avatar_url":"https://avatars.githubusercontent.com/u/133736?v=3","gravatar_id":"","url":"https://api.github.com/users/fearthecowboy","html_url":"https://github.com/fearthecowboy","followers_url":"https://api.github.com/users/fearthecowboy/followers","following_url":"https://api.github.com/users/fearthecowboy/following{/other_user}","gists_url":"https://api.github.com/users/fearthecowboy/gists{/gist_id}","starred_url":"https://api.github.com/users/fearthecowboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearthecowboy/subscriptions","organizations_url":"https://api.github.com/users/fearthecowboy/orgs","repos_url":"https://api.github.com/users/fearthecowboy/repos","events_url":"https://api.github.com/users/fearthecowboy/events{/privacy}","received_events_url":"https://api.github.com/users/fearthecowboy/received_events","type":"User","site_admin":false},"body":"`Parameters \"subscriptionId\" and \"api-version\" are not allowed in the operations section` ?","created_at":"2016-10-18T16:07:49Z","updated_at":"2016-10-18T16:07:49Z","html_url":"https://github.com/Azure/autorest/pull/1513#discussion_r83890760","pull_request_url":"https://api.github.com/repos/Azure/autorest/pulls/1513","_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments/83890760"},"html":{"href":"https://github.com/Azure/autorest/pull/1513#discussion_r83890760"},"pull_request":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1513"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/autorest/pulls/1513","id":89676829,"html_url":"https://github.com/Azure/autorest/pull/1513","diff_url":"https://github.com/Azure/autorest/pull/1513.diff","patch_url":"https://github.com/Azure/autorest/pull/1513.patch","issue_url":"https://api.github.com/repos/Azure/autorest/issues/1513","number":1513,"state":"open","locked":false,"title":"Adding validation rules for subscriptionId/api-version params","user":{"login":"dsgouda","id":14796031,"avatar_url":"https://avatars.githubusercontent.com/u/14796031?v=3","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false},"body":"Adding validation rules to enforce:\r\n- Parameters section for operations should not define the subscriptionId and api-version parameters\r\n- Service definition section must contain parameters api-version and subscriptionId\r\n\r\nModified all swagger validation test jsons to adhere to these validation rules\r\nFixing issue https://github.com/Azure/autorest/issues/1515\r\n\r\n@tbombach \r\n","created_at":"2016-10-17T18:29:38Z","updated_at":"2016-10-18T16:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1820dfa22795b617e373c20b373e409d18ccb473","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/autorest/pulls/1513/commits","review_comments_url":"https://api.github.com/repos/Azure/autorest/pulls/1513/comments","review_comment_url":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/autorest/issues/1513/comments","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/3f434feae48298891c582a9c40cef419c868fbce","head":{"label":"dsgouda:params","ref":"params","sha":"3f434feae48298891c582a9c40cef419c868fbce","user":{"login":"dsgouda","id":14796031,"avatar_url":"https://avatars.githubusercontent.com/u/14796031?v=3","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false},"repo":{"id":67553230,"name":"autorest","full_name":"dsgouda/autorest","owner":{"login":"dsgouda","id":14796031,"avatar_url":"https://avatars.githubusercontent.com/u/14796031?v=3","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsgouda/autorest","description":"Swagger (OpenAPI) Specification code generator featuring C# and Razor templates. Supports C#, Java, Node.js, TypeScript, Python and Ruby.","fork":true,"url":"https://api.github.com/repos/dsgouda/autorest","forks_url":"https://api.github.com/repos/dsgouda/autorest/forks","keys_url":"https://api.github.com/repos/dsgouda/autorest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsgouda/autorest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsgouda/autorest/teams","hooks_url":"https://api.github.com/repos/dsgouda/autorest/hooks","issue_events_url":"https://api.github.com/repos/dsgouda/autorest/issues/events{/number}","events_url":"https://api.github.com/repos/dsgouda/autorest/events","assignees_url":"https://api.github.com/repos/dsgouda/autorest/assignees{/user}","branches_url":"https://api.github.com/repos/dsgouda/autorest/branches{/branch}","tags_url":"https://api.github.com/repos/dsgouda/autorest/tags","blobs_url":"https://api.github.com/repos/dsgouda/autorest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsgouda/autorest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsgouda/autorest/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsgouda/autorest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsgouda/autorest/statuses/{sha}","languages_url":"https://api.github.com/repos/dsgouda/autorest/languages","stargazers_url":"https://api.github.com/repos/dsgouda/autorest/stargazers","contributors_url":"https://api.github.com/repos/dsgouda/autorest/contributors","subscribers_url":"https://api.github.com/repos/dsgouda/autorest/subscribers","subscription_url":"https://api.github.com/repos/dsgouda/autorest/subscription","commits_url":"https://api.github.com/repos/dsgouda/autorest/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsgouda/autorest/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsgouda/autorest/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsgouda/autorest/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsgouda/autorest/contents/{+path}","compare_url":"https://api.github.com/repos/dsgouda/autorest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsgouda/autorest/merges","archive_url":"https://api.github.com/repos/dsgouda/autorest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsgouda/autorest/downloads","issues_url":"https://api.github.com/repos/dsgouda/autorest/issues{/number}","pulls_url":"https://api.github.com/repos/dsgouda/autorest/pulls{/number}","milestones_url":"https://api.github.com/repos/dsgouda/autorest/milestones{/number}","notifications_url":"https://api.github.com/repos/dsgouda/autorest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsgouda/autorest/labels{/name}","releases_url":"https://api.github.com/repos/dsgouda/autorest/releases{/id}","deployments_url":"https://api.github.com/repos/dsgouda/autorest/deployments","created_at":"2016-09-06T23:03:41Z","updated_at":"2016-09-06T23:03:49Z","pushed_at":"2016-10-17T18:27:55Z","git_url":"git://github.com/dsgouda/autorest.git","ssh_url":"git@github.com:dsgouda/autorest.git","clone_url":"https://github.com/dsgouda/autorest.git","svn_url":"https://github.com/dsgouda/autorest","homepage":"","size":54262,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"b24dfeb5729a5ed7295b92a5e95116d279769388","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":31089461,"name":"autorest","full_name":"Azure/autorest","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest","description":"Swagger (OpenAPI) Specification code generator featuring C# and Razor templates. Supports C#, Java, Node.js, TypeScript, Python and Ruby.","fork":false,"url":"https://api.github.com/repos/Azure/autorest","forks_url":"https://api.github.com/repos/Azure/autorest/forks","keys_url":"https://api.github.com/repos/Azure/autorest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest/teams","hooks_url":"https://api.github.com/repos/Azure/autorest/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest/events","assignees_url":"https://api.github.com/repos/Azure/autorest/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest/tags","blobs_url":"https://api.github.com/repos/Azure/autorest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest/subscription","commits_url":"https://api.github.com/repos/Azure/autorest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest/merges","archive_url":"https://api.github.com/repos/Azure/autorest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest/downloads","issues_url":"https://api.github.com/repos/Azure/autorest/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/autorest/deployments","created_at":"2015-02-20T23:02:54Z","updated_at":"2016-10-17T16:17:32Z","pushed_at":"2016-10-18T04:46:41Z","git_url":"git://github.com/Azure/autorest.git","ssh_url":"git@github.com:Azure/autorest.git","clone_url":"https://github.com/Azure/autorest.git","svn_url":"https://github.com/Azure/autorest","homepage":"","size":60126,"stargazers_count":522,"watchers_count":522,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":155,"forks":180,"open_issues":155,"watchers":522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1513"},"html":{"href":"https://github.com/Azure/autorest/pull/1513"},"issue":{"href":"https://api.github.com/repos/Azure/autorest/issues/1513"},"comments":{"href":"https://api.github.com/repos/Azure/autorest/issues/1513/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1513/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/autorest/pulls/1513/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/autorest/statuses/3f434feae48298891c582a9c40cef419c868fbce"}}}}
{"actor":{"display_login":"fearthecowboy"}}