{"action":"created","comment":{"url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/comments/90101078","pull_request_review_id":10625532,"id":90101078,"diff_hunk":"@@ -3,6 +3,6 @@ module.exports = ->\n   @set-default-timeout 1000\n \n \n-  @After ->\n-    @exocom?.close!\n+  @After (_, done) ->","path":"features/support/env.ls","position":null,"original_position":6,"commit_id":"aac65a4736f25e1c65d79562d9563ff45e45ff58","original_commit_id":"5914ca7a966e74c8bf28b3389b17303b126d69b3","user":{"login":"kevgo","id":268934,"avatar_url":"https://avatars.githubusercontent.com/u/268934?v=3","gravatar_id":"","url":"https://api.github.com/users/kevgo","html_url":"https://github.com/kevgo","followers_url":"https://api.github.com/users/kevgo/followers","following_url":"https://api.github.com/users/kevgo/following{/other_user}","gists_url":"https://api.github.com/users/kevgo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevgo/subscriptions","organizations_url":"https://api.github.com/users/kevgo/orgs","repos_url":"https://api.github.com/users/kevgo/repos","events_url":"https://api.github.com/users/kevgo/events{/privacy}","received_events_url":"https://api.github.com/users/kevgo/received_events","type":"User","site_admin":false},"body":"After each scenario, see https://github.com/cucumber/cucumber-js/blob/master/docs/support_files/hooks.md. I have changed the name of the first parameter to `_scenario` to make it more descriptive and indicate that it isn't used.","created_at":"2016-11-29T20:05:27Z","updated_at":"2016-11-29T20:05:27Z","html_url":"https://github.com/Originate/exocom-mock-js/pull/12#discussion_r90101078","pull_request_url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/comments/90101078"},"html":{"href":"https://github.com/Originate/exocom-mock-js/pull/12#discussion_r90101078"},"pull_request":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12","id":95737956,"html_url":"https://github.com/Originate/exocom-mock-js/pull/12","diff_url":"https://github.com/Originate/exocom-mock-js/pull/12.diff","patch_url":"https://github.com/Originate/exocom-mock-js/pull/12.patch","issue_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues/12","number":12,"state":"open","locked":false,"title":"Proper async setup","user":{"login":"kevgo","id":268934,"avatar_url":"https://avatars.githubusercontent.com/u/268934?v=3","gravatar_id":"","url":"https://api.github.com/users/kevgo","html_url":"https://github.com/kevgo","followers_url":"https://api.github.com/users/kevgo/followers","following_url":"https://api.github.com/users/kevgo/following{/other_user}","gists_url":"https://api.github.com/users/kevgo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevgo/subscriptions","organizations_url":"https://api.github.com/users/kevgo/orgs","repos_url":"https://api.github.com/users/kevgo/repos","events_url":"https://api.github.com/users/kevgo/events{/privacy}","received_events_url":"https://api.github.com/users/kevgo/received_events","type":"User","site_admin":false},"body":"@trushton this library didn't properly wait until previous processes were done, necessitating a number of hacks and causing test flakiness. This PR makes sure each step properly waits until what it does is done, so that the next step finds a correctly set up system in the expected state, and can focus on what it is supposed to do.","created_at":"2016-11-29T17:26:16Z","updated_at":"2016-11-29T20:05:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d77582afb94f2442a54e26476ef7c0839b694fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues/12/comments","statuses_url":"https://api.github.com/repos/Originate/exocom-mock-js/statuses/aac65a4736f25e1c65d79562d9563ff45e45ff58","head":{"label":"Originate:kg-async-1","ref":"kg-async-1","sha":"aac65a4736f25e1c65d79562d9563ff45e45ff58","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":51075214,"name":"exocom-mock-js","full_name":"Originate/exocom-mock-js","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exocom-mock-js","description":"A mock implementation of the ExoComm development server in JavaScript, for testing","fork":false,"url":"https://api.github.com/repos/Originate/exocom-mock-js","forks_url":"https://api.github.com/repos/Originate/exocom-mock-js/forks","keys_url":"https://api.github.com/repos/Originate/exocom-mock-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exocom-mock-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exocom-mock-js/teams","hooks_url":"https://api.github.com/repos/Originate/exocom-mock-js/hooks","issue_events_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exocom-mock-js/events","assignees_url":"https://api.github.com/repos/Originate/exocom-mock-js/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exocom-mock-js/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exocom-mock-js/tags","blobs_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exocom-mock-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exocom-mock-js/languages","stargazers_url":"https://api.github.com/repos/Originate/exocom-mock-js/stargazers","contributors_url":"https://api.github.com/repos/Originate/exocom-mock-js/contributors","subscribers_url":"https://api.github.com/repos/Originate/exocom-mock-js/subscribers","subscription_url":"https://api.github.com/repos/Originate/exocom-mock-js/subscription","commits_url":"https://api.github.com/repos/Originate/exocom-mock-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exocom-mock-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exocom-mock-js/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exocom-mock-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exocom-mock-js/merges","archive_url":"https://api.github.com/repos/Originate/exocom-mock-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exocom-mock-js/downloads","issues_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exocom-mock-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exocom-mock-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exocom-mock-js/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exocom-mock-js/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exocom-mock-js/deployments","created_at":"2016-02-04T12:41:32Z","updated_at":"2016-11-15T17:57:51Z","pushed_at":"2016-11-29T20:04:13Z","git_url":"git://github.com/Originate/exocom-mock-js.git","ssh_url":"git@github.com:Originate/exocom-mock-js.git","clone_url":"https://github.com/Originate/exocom-mock-js.git","svn_url":"https://github.com/Originate/exocom-mock-js","homepage":null,"size":202,"stargazers_count":2,"watchers_count":2,"language":"LiveScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"Originate:master","ref":"master","sha":"f44cf259ee3d8839680e677371137113e6e92511","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":51075214,"name":"exocom-mock-js","full_name":"Originate/exocom-mock-js","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exocom-mock-js","description":"A mock implementation of the ExoComm development server in JavaScript, for testing","fork":false,"url":"https://api.github.com/repos/Originate/exocom-mock-js","forks_url":"https://api.github.com/repos/Originate/exocom-mock-js/forks","keys_url":"https://api.github.com/repos/Originate/exocom-mock-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exocom-mock-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exocom-mock-js/teams","hooks_url":"https://api.github.com/repos/Originate/exocom-mock-js/hooks","issue_events_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exocom-mock-js/events","assignees_url":"https://api.github.com/repos/Originate/exocom-mock-js/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exocom-mock-js/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exocom-mock-js/tags","blobs_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exocom-mock-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exocom-mock-js/languages","stargazers_url":"https://api.github.com/repos/Originate/exocom-mock-js/stargazers","contributors_url":"https://api.github.com/repos/Originate/exocom-mock-js/contributors","subscribers_url":"https://api.github.com/repos/Originate/exocom-mock-js/subscribers","subscription_url":"https://api.github.com/repos/Originate/exocom-mock-js/subscription","commits_url":"https://api.github.com/repos/Originate/exocom-mock-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exocom-mock-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exocom-mock-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exocom-mock-js/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exocom-mock-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exocom-mock-js/merges","archive_url":"https://api.github.com/repos/Originate/exocom-mock-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exocom-mock-js/downloads","issues_url":"https://api.github.com/repos/Originate/exocom-mock-js/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exocom-mock-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exocom-mock-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exocom-mock-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exocom-mock-js/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exocom-mock-js/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exocom-mock-js/deployments","created_at":"2016-02-04T12:41:32Z","updated_at":"2016-11-15T17:57:51Z","pushed_at":"2016-11-29T20:04:13Z","git_url":"git://github.com/Originate/exocom-mock-js.git","ssh_url":"git@github.com:Originate/exocom-mock-js.git","clone_url":"https://github.com/Originate/exocom-mock-js.git","svn_url":"https://github.com/Originate/exocom-mock-js","homepage":null,"size":202,"stargazers_count":2,"watchers_count":2,"language":"LiveScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12"},"html":{"href":"https://github.com/Originate/exocom-mock-js/pull/12"},"issue":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/issues/12"},"comments":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Originate/exocom-mock-js/statuses/aac65a4736f25e1c65d79562d9563ff45e45ff58"}}}}
{"actor":{"display_login":"kevgo"}}