{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments/92693781","pull_request_review_id":13214209,"id":92693781,"diff_hunk":"@@ -54,6 +57,7 @@ protected override Task InitializeAsync(CancellationToken cancellationToken, IPr\n             _factory = new MigrateXprojProjectFactory(new ProcessRunner(), new FileSystem());\n             _factory.SetSite(this);\n             RegisterProjectFactory(_factory);\n+            RegisterEditorFactory(new LoadedProjectFileEditorFactory(this));","path":"src/Microsoft.VisualStudio.ProjectSystem.CSharp.VS/Packaging/CSharpProjectSystemPackage.cs","position":30,"original_position":30,"commit_id":"85de82d9e0a318afab879cf115a59e6c00eaa6aa","original_commit_id":"85de82d9e0a318afab879cf115a59e6c00eaa6aa","user":{"login":"333fred","id":2371880,"avatar_url":"https://avatars.githubusercontent.com/u/2371880?v=3","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"body":"It hasn't crashed anything yet, but probably not. I'll run a switch to the ui thread.","created_at":"2016-12-15T20:30:09Z","updated_at":"2016-12-15T20:30:09Z","html_url":"https://github.com/dotnet/roslyn-project-system/pull/942#discussion_r92693781","pull_request_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments/92693781"},"html":{"href":"https://github.com/dotnet/roslyn-project-system/pull/942#discussion_r92693781"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942","id":97875332,"html_url":"https://github.com/dotnet/roslyn-project-system/pull/942","diff_url":"https://github.com/dotnet/roslyn-project-system/pull/942.diff","patch_url":"https://github.com/dotnet/roslyn-project-system/pull/942.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/942","number":942,"state":"open","locked":false,"title":"[WIP] In Memory Editor","user":{"login":"333fred","id":2371880,"avatar_url":"https://avatars.githubusercontent.com/u/2371880?v=3","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"body":"This is a fairly large change, so I want to get the review started now. The salient points are:\r\n* Project file editing now uses an in-memory buffer instead of a temporary file. This greatly improves the experience, and `Open Containing Folder` now works as expected.\r\n* Previous to this change, the state was all contained in a couple of files, and did not have defined state transitions. With this new change, that quickly became untenable. I've factored the state machine into a single class, EditorStateModel, which coordinates all state changes. I've tried to make the states descriptive, and provide examples and valid state transitions.\r\n\r\nMain todos:\r\n* I'm not handling saving dirty state at all when closing the buffer or updating the project file.\r\n* Tests probably don't compile, let alone run.\r\n\r\nI'm not expecting this PR to pass tests yet (or even for the tests to compile), those are still to come. Tagging @dotnet/project-system, @davkean, @BillHiebert, @srivatsn to start the review.","created_at":"2016-12-14T02:18:41Z","updated_at":"2016-12-15T20:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/942/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/85de82d9e0a318afab879cf115a59e6c00eaa6aa","head":{"label":"333fred:InMemoryEditor","ref":"InMemoryEditor","sha":"85de82d9e0a318afab879cf115a59e6c00eaa6aa","user":{"login":"333fred","id":2371880,"avatar_url":"https://avatars.githubusercontent.com/u/2371880?v=3","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"repo":{"id":62111220,"name":"roslyn-project-system","full_name":"333fred/roslyn-project-system","owner":{"login":"333fred","id":2371880,"avatar_url":"https://avatars.githubusercontent.com/u/2371880?v=3","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/333fred/roslyn-project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":true,"url":"https://api.github.com/repos/333fred/roslyn-project-system","forks_url":"https://api.github.com/repos/333fred/roslyn-project-system/forks","keys_url":"https://api.github.com/repos/333fred/roslyn-project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/333fred/roslyn-project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/333fred/roslyn-project-system/teams","hooks_url":"https://api.github.com/repos/333fred/roslyn-project-system/hooks","issue_events_url":"https://api.github.com/repos/333fred/roslyn-project-system/issues/events{/number}","events_url":"https://api.github.com/repos/333fred/roslyn-project-system/events","assignees_url":"https://api.github.com/repos/333fred/roslyn-project-system/assignees{/user}","branches_url":"https://api.github.com/repos/333fred/roslyn-project-system/branches{/branch}","tags_url":"https://api.github.com/repos/333fred/roslyn-project-system/tags","blobs_url":"https://api.github.com/repos/333fred/roslyn-project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/333fred/roslyn-project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/333fred/roslyn-project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/333fred/roslyn-project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/333fred/roslyn-project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/333fred/roslyn-project-system/languages","stargazers_url":"https://api.github.com/repos/333fred/roslyn-project-system/stargazers","contributors_url":"https://api.github.com/repos/333fred/roslyn-project-system/contributors","subscribers_url":"https://api.github.com/repos/333fred/roslyn-project-system/subscribers","subscription_url":"https://api.github.com/repos/333fred/roslyn-project-system/subscription","commits_url":"https://api.github.com/repos/333fred/roslyn-project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/333fred/roslyn-project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/333fred/roslyn-project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/333fred/roslyn-project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/333fred/roslyn-project-system/contents/{+path}","compare_url":"https://api.github.com/repos/333fred/roslyn-project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/333fred/roslyn-project-system/merges","archive_url":"https://api.github.com/repos/333fred/roslyn-project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/333fred/roslyn-project-system/downloads","issues_url":"https://api.github.com/repos/333fred/roslyn-project-system/issues{/number}","pulls_url":"https://api.github.com/repos/333fred/roslyn-project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/333fred/roslyn-project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/333fred/roslyn-project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/333fred/roslyn-project-system/labels{/name}","releases_url":"https://api.github.com/repos/333fred/roslyn-project-system/releases{/id}","deployments_url":"https://api.github.com/repos/333fred/roslyn-project-system/deployments","created_at":"2016-06-28T04:56:42Z","updated_at":"2016-10-24T21:57:49Z","pushed_at":"2016-12-15T18:14:51Z","git_url":"git://github.com/333fred/roslyn-project-system.git","ssh_url":"git@github.com:333fred/roslyn-project-system.git","clone_url":"https://github.com/333fred/roslyn-project-system.git","svn_url":"https://github.com/333fred/roslyn-project-system","homepage":null,"size":9009,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"4e48529d4a64a965f23d3ddefcc26aa7ca222887","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"name":"roslyn-project-system","full_name":"dotnet/roslyn-project-system","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn-project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn-project-system","forks_url":"https://api.github.com/repos/dotnet/roslyn-project-system/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn-project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn-project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn-project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn-project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn-project-system/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn-project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn-project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn-project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn-project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn-project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn-project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn-project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn-project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn-project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn-project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn-project-system/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn-project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn-project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn-project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn-project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn-project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn-project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2016-12-11T09:33:08Z","pushed_at":"2016-12-15T18:47:37Z","git_url":"git://github.com/dotnet/roslyn-project-system.git","ssh_url":"git@github.com:dotnet/roslyn-project-system.git","clone_url":"https://github.com/dotnet/roslyn-project-system.git","svn_url":"https://github.com/dotnet/roslyn-project-system","homepage":null,"size":8991,"stargazers_count":184,"watchers_count":184,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":326,"forks":46,"open_issues":326,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942"},"html":{"href":"https://github.com/dotnet/roslyn-project-system/pull/942"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/942"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/942/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/942/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/85de82d9e0a318afab879cf115a59e6c00eaa6aa"}}}}
{"actor":{"display_login":"333fred"}}