{"action":"created","issue":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1197","repository_url":"https://api.github.com/repos/PCSX2/pcsx2","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1197/labels{/name}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1197/comments","events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1197/events","html_url":"https://github.com/PCSX2/pcsx2/pull/1197","id":135097497,"number":1197,"title":"Gsdx: PNG screenshots (Windows), use libpng directly","user":{"login":"turtleli","id":10976277,"avatar_url":"https://avatars.githubusercontent.com/u/10976277?v=3","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Plugin:%20GSdx","name":"Plugin: GSdx","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"turtleli","id":10976277,"avatar_url":"https://avatars.githubusercontent.com/u/10976277?v=3","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2016-02-20T16:48:22Z","updated_at":"2016-02-22T21:18:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1197","html_url":"https://github.com/PCSX2/pcsx2/pull/1197","diff_url":"https://github.com/PCSX2/pcsx2/pull/1197.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1197.patch"},"body":"Changes:\r\n * Adds png++ to 3rdparty\r\n * Saves GSdx screenshots for all renderers as PNG files on Windows.\r\n\r\nNotes: \r\n * For dump screenshots when using the DX9 renderer, some screenshots have the red and blue channels flipped. This is present in master too, so it's not a regression.\r\n * I used the png stuff instead of the d3dx stuff for saving PNGs on the dx9/dx11 renderers to reduce the amount of changes necessary to migrate GSdx to the newer Windows SDK - All that's left is to switch to using D3DCompile, which is fairly simple to do.\r\n * Instead of using png++, I could always rewrite the GSPng ~~class~~stuff to use libpng directly - Some Linux distros don't have a png++ package so some users might still be saving snapshots as BMP files, and both VS2013/VS2015 spit out warnings due to png++ (interaction between _setjmp and C++ object destruction is non-portable).\r\n\r\nEDIT: Whitespace issues in png++ ~~is~~are not my fault."},"comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments/187387624","html_url":"https://github.com/PCSX2/pcsx2/pull/1197#issuecomment-187387624","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1197","id":187387624,"user":{"login":"turtleli","id":10976277,"avatar_url":"https://avatars.githubusercontent.com/u/10976277?v=3","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T21:18:53Z","updated_at":"2016-02-22T21:18:53Z","body":"Ok, I can do that."}}