{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8151","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8151/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8151/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8151/events","html_url":"https://github.com/cockroachdb/cockroach/pull/8151","id":168488920,"number":8151,"title":"RFC: streaming snapshots","user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-30T21:54:50Z","updated_at":"2016-08-01T01:26:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8151","html_url":"https://github.com/cockroachdb/cockroach/pull/8151","diff_url":"https://github.com/cockroachdb/cockroach/pull/8151.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8151.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8151)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/236470502","html_url":"https://github.com/cockroachdb/cockroach/pull/8151#issuecomment-236470502","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8151","id":236470502,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T01:26:17Z","updated_at":"2016-08-01T01:26:17Z","body":"\n\n\n\nReviewed 1 of 1 files at r2.\nReview status: all files reviewed at latest revision, 9 unresolved discussions, some commit checks pending.\n\n---\n\n*[docs/RFCS/streaming_snapshots.md, line 128 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8151#-KNy-cdO0aln7nqk8wZD:-KO2fXXCk1Jo93KcV4x3:766498083) ([raw file](https://github.com/cockroachdb/cockroach/blob/40bb137ce99551257e6b0442d6cde9e097936715/docs/RFCS/streaming_snapshots.md#L128)):*\n<details><summary><i>Previously, bdarnell (Ben Darnell) wrote…</i></summary>\n> s/footer/header/. There used to be a footer before I had worked out that phase 2 would need the MsgSnap first. \n</details>\nIs the intention that only the first message in the outbound stream will have a non-empty header?\n\n---\n\n*[docs/RFCS/streaming_snapshots.md, line 56 \\[r2\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8151#-KO2g3DZB2WcKT3BOEJR:-KO2g3DZB2WcKT3BOEJS:832524130) ([raw file](https://github.com/cockroachdb/cockroach/blob/2b65c08ef9e34027935e1cc0cbb0d6079f197fa5/docs/RFCS/streaming_snapshots.md#L56)):*\n> ```Markdown\n>   message Header {\n>     optional roachpb.RangeDescriptor range_descriptor = 1 [(gogoproto.nullable) = false)];\n>     optional int64 range_size = 2 [(gogoproto.nullable) = false];\n> ```\n\nwhat's this used for?\n\n---\n\n*[docs/RFCS/streaming_snapshots.md, line 139 \\[r2\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8151#-KO2gc_YKFJTjSJcijM9:-KO2gc_ZTsepnnnTaWIn:-1568601099) ([raw file](https://github.com/cockroachdb/cockroach/blob/2b65c08ef9e34027935e1cc0cbb0d6079f197fa5/docs/RFCS/streaming_snapshots.md#L139)):*\n> ```Markdown\n> \n> The recipient will accumulate all `SnapshotRequests` in memory, into a\n> rocksdb `Batch`, keyed by the UUID from the header. It sends the\n> ```\n\nthere's no reason for this to be the same uuid as was generated on the sender, correct? perhaps spell out that it might be convenient for tracking snapshots around.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/8151)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}