{"action":"created","issue":{"url":"https://api.github.com/repos/mikegore1000/SqueezeMe/issues/7","repository_url":"https://api.github.com/repos/mikegore1000/SqueezeMe","labels_url":"https://api.github.com/repos/mikegore1000/SqueezeMe/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/mikegore1000/SqueezeMe/issues/7/comments","events_url":"https://api.github.com/repos/mikegore1000/SqueezeMe/issues/7/events","html_url":"https://github.com/mikegore1000/SqueezeMe/issues/7","id":175363533,"number":7,"title":"Vary Http Response Header Missing","user":{"login":"phil000","id":9067236,"avatar_url":"https://avatars.githubusercontent.com/u/9067236?v=3","gravatar_id":"","url":"https://api.github.com/users/phil000","html_url":"https://github.com/phil000","followers_url":"https://api.github.com/users/phil000/followers","following_url":"https://api.github.com/users/phil000/following{/other_user}","gists_url":"https://api.github.com/users/phil000/gists{/gist_id}","starred_url":"https://api.github.com/users/phil000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil000/subscriptions","organizations_url":"https://api.github.com/users/phil000/orgs","repos_url":"https://api.github.com/users/phil000/repos","events_url":"https://api.github.com/users/phil000/events{/privacy}","received_events_url":"https://api.github.com/users/phil000/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-06T22:06:20Z","updated_at":"2016-11-10T00:13:04Z","closed_at":null,"body":"I see this issue has come up before and been closed, however I cannot find anything anywhere that suggests adding Vary: accept-encoding is anything other than required and a best practise. Any reason why the previous issue was marked 'invalid'?\nTa\n"},"comment":{"url":"https://api.github.com/repos/mikegore1000/SqueezeMe/issues/comments/259564220","html_url":"https://github.com/mikegore1000/SqueezeMe/issues/7#issuecomment-259564220","issue_url":"https://api.github.com/repos/mikegore1000/SqueezeMe/issues/7","id":259564220,"user":{"login":"phil000","id":9067236,"avatar_url":"https://avatars.githubusercontent.com/u/9067236?v=3","gravatar_id":"","url":"https://api.github.com/users/phil000","html_url":"https://github.com/phil000","followers_url":"https://api.github.com/users/phil000/followers","following_url":"https://api.github.com/users/phil000/following{/other_user}","gists_url":"https://api.github.com/users/phil000/gists{/gist_id}","starred_url":"https://api.github.com/users/phil000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil000/subscriptions","organizations_url":"https://api.github.com/users/phil000/orgs","repos_url":"https://api.github.com/users/phil000/repos","events_url":"https://api.github.com/users/phil000/events{/privacy}","received_events_url":"https://api.github.com/users/phil000/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T00:13:04Z","updated_at":"2016-11-10T00:13:04Z","body":"It integrates into the OWIN pipeline to perform compression on http requests\\responses. As such is should follow recommended practises with regards to http cache control and varying responses by the compression method used, otherwise people could be served wrong content. \r\n\r\nA key point is that it is not a *general purpose compression* library, but specifically compression of HTTP responses. With regards to that there are recommended practises because of how HTTP responses can be cached. If you do not use the Vary header people may ask for deflate but be given the gzip response from cache because you have not said to vary the response by accept-encoding.\r\n\r\nIf it's modifying the http response to perform compression, but *not* setting the correct headers then who should do it? Should we write *another* OWIN middleware just to set the vary header ourselves?\r\n\r\nThanks!"}}
{"actor":{"display_login":"phil000"}}