{"action":"created","comment":{"url":"https://api.github.com/repos/http4s/rho/pulls/comments/94274549","pull_request_review_id":14804859,"id":94274549,"diff_hunk":"@@ -1,22 +1,27 @@\n package org.http4s\n package rho\n \n-import bits.MethodAliases._\n-import bits.ResponseGeneratorInstances._\n-\n-import org.http4s.rho.bits.{TypedHeader, PathTree, SuccessResponse, FailureResponse}\n-import org.http4s.headers.{`Content-Length`, ETag}\n+import org.http4s.headers.{ETag, `Content-Length`}\n+import org.http4s.rho.bits.MethodAliases._\n import org.http4s.rho.bits.RequestAST.AndRule\n-\n+import org.http4s.rho.bits.ResponseGeneratorInstances._\n+import org.http4s.rho.bits._\n import org.specs2.mutable._\n-import shapeless.HNil\n-import scalaz.{-\\/, \\/-}\n+import scodec.bits.ByteVector\n+import shapeless.{HList, HNil}\n+\n import scalaz.concurrent.Task\n import scalaz.stream.Process\n-import scodec.bits.ByteVector\n+import scalaz.{-\\/, \\/-}\n \n // TODO: these tests are a bit of a mess\n class ApiTest extends Specification {\n+\n+  def runWith[T <: HList, F](exec: RouteExecutable[T])(f: F)(implicit hltf: HListToFunc[T, F]): Request => Task[Response] = {","path":"core/src/test/scala/org/http4s/rho/ApiTest.scala","position":29,"original_position":29,"commit_id":"f2aa7c1ce24d32c694d708a87bae117c35bfb431","original_commit_id":"f2aa7c1ce24d32c694d708a87bae117c35bfb431","user":{"login":"zarthross","id":1111592,"avatar_url":"https://avatars.githubusercontent.com/u/1111592?v=3","gravatar_id":"","url":"https://api.github.com/users/zarthross","html_url":"https://github.com/zarthross","followers_url":"https://api.github.com/users/zarthross/followers","following_url":"https://api.github.com/users/zarthross/following{/other_user}","gists_url":"https://api.github.com/users/zarthross/gists{/gist_id}","starred_url":"https://api.github.com/users/zarthross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarthross/subscriptions","organizations_url":"https://api.github.com/users/zarthross/orgs","repos_url":"https://api.github.com/users/zarthross/repos","events_url":"https://api.github.com/users/zarthross/events{/privacy}","received_events_url":"https://api.github.com/users/zarthross/received_events","type":"User","site_admin":false},"body":"The name 'runWith' doesn't read as well in Polish notation as it did in infix.  I suggest either rename it or maybe make it an extension method instead so the syntax stays the same.","created_at":"2016-12-31T14:50:36Z","updated_at":"2016-12-31T14:54:00Z","html_url":"https://github.com/http4s/rho/pull/160#discussion_r94274549","pull_request_url":"https://api.github.com/repos/http4s/rho/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/http4s/rho/pulls/comments/94274549"},"html":{"href":"https://github.com/http4s/rho/pull/160#discussion_r94274549"},"pull_request":{"href":"https://api.github.com/repos/http4s/rho/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/http4s/rho/pulls/160","id":99777102,"html_url":"https://github.com/http4s/rho/pull/160","diff_url":"https://github.com/http4s/rho/pull/160.diff","patch_url":"https://github.com/http4s/rho/pull/160.patch","issue_url":"https://api.github.com/repos/http4s/rho/issues/160","number":160,"state":"open","locked":false,"title":"Clean up a few sections of the API","user":{"login":"bryce-anderson","id":2948506,"avatar_url":"https://avatars.githubusercontent.com/u/2948506?v=3","gravatar_id":"","url":"https://api.github.com/users/bryce-anderson","html_url":"https://github.com/bryce-anderson","followers_url":"https://api.github.com/users/bryce-anderson/followers","following_url":"https://api.github.com/users/bryce-anderson/following{/other_user}","gists_url":"https://api.github.com/users/bryce-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/bryce-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryce-anderson/subscriptions","organizations_url":"https://api.github.com/users/bryce-anderson/orgs","repos_url":"https://api.github.com/users/bryce-anderson/repos","events_url":"https://api.github.com/users/bryce-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/bryce-anderson/received_events","type":"User","site_admin":false},"body":"We have a lot of API surface right now that should probably not be exposed. This commit starts to trim away the things that aren't necessary for public consumption.\r\n\r\nTargets include:\r\n\r\n* RouteExecutable: `runWith` is unnecessary and very inefficient.\r\n* CompileService: pull ServiceBuilder into its own file and clean it up.\r\n* Minor other changes.\r\n\r\nThis is a binary incompatible change, but shouldn't be controversial.","created_at":"2016-12-30T19:26:10Z","updated_at":"2016-12-31T14:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99d7e2bedcbc9e2ef6fbbdbb329104f4e197ad57","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/http4s/rho/pulls/160/commits","review_comments_url":"https://api.github.com/repos/http4s/rho/pulls/160/comments","review_comment_url":"https://api.github.com/repos/http4s/rho/pulls/comments{/number}","comments_url":"https://api.github.com/repos/http4s/rho/issues/160/comments","statuses_url":"https://api.github.com/repos/http4s/rho/statuses/f2aa7c1ce24d32c694d708a87bae117c35bfb431","head":{"label":"http4s:api-cleanup-pt1","ref":"api-cleanup-pt1","sha":"f2aa7c1ce24d32c694d708a87bae117c35bfb431","user":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":21328529,"name":"rho","full_name":"http4s/rho","owner":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http4s/rho","description":"A self documenting DSL built on http4s","fork":false,"url":"https://api.github.com/repos/http4s/rho","forks_url":"https://api.github.com/repos/http4s/rho/forks","keys_url":"https://api.github.com/repos/http4s/rho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/rho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/rho/teams","hooks_url":"https://api.github.com/repos/http4s/rho/hooks","issue_events_url":"https://api.github.com/repos/http4s/rho/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/rho/events","assignees_url":"https://api.github.com/repos/http4s/rho/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/rho/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/rho/tags","blobs_url":"https://api.github.com/repos/http4s/rho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/rho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/rho/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/rho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/rho/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/rho/languages","stargazers_url":"https://api.github.com/repos/http4s/rho/stargazers","contributors_url":"https://api.github.com/repos/http4s/rho/contributors","subscribers_url":"https://api.github.com/repos/http4s/rho/subscribers","subscription_url":"https://api.github.com/repos/http4s/rho/subscription","commits_url":"https://api.github.com/repos/http4s/rho/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/rho/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/rho/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/rho/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/rho/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/rho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/rho/merges","archive_url":"https://api.github.com/repos/http4s/rho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/rho/downloads","issues_url":"https://api.github.com/repos/http4s/rho/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/rho/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/rho/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/rho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/rho/labels{/name}","releases_url":"https://api.github.com/repos/http4s/rho/releases{/id}","deployments_url":"https://api.github.com/repos/http4s/rho/deployments","created_at":"2014-06-29T17:41:15Z","updated_at":"2016-12-27T16:17:04Z","pushed_at":"2016-12-30T19:26:10Z","git_url":"git://github.com/http4s/rho.git","ssh_url":"git@github.com:http4s/rho.git","clone_url":"https://github.com/http4s/rho.git","svn_url":"https://github.com/http4s/rho","homepage":null,"size":2986,"stargazers_count":79,"watchers_count":79,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":20,"forks":10,"open_issues":20,"watchers":79,"default_branch":"master"}},"base":{"label":"http4s:master","ref":"master","sha":"80fadb0a1c415d1b87f4eca2e81c17c519c9c9b0","user":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":21328529,"name":"rho","full_name":"http4s/rho","owner":{"login":"http4s","id":1527492,"avatar_url":"https://avatars.githubusercontent.com/u/1527492?v=3","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/http4s/rho","description":"A self documenting DSL built on http4s","fork":false,"url":"https://api.github.com/repos/http4s/rho","forks_url":"https://api.github.com/repos/http4s/rho/forks","keys_url":"https://api.github.com/repos/http4s/rho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/rho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/rho/teams","hooks_url":"https://api.github.com/repos/http4s/rho/hooks","issue_events_url":"https://api.github.com/repos/http4s/rho/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/rho/events","assignees_url":"https://api.github.com/repos/http4s/rho/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/rho/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/rho/tags","blobs_url":"https://api.github.com/repos/http4s/rho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/rho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/rho/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/rho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/rho/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/rho/languages","stargazers_url":"https://api.github.com/repos/http4s/rho/stargazers","contributors_url":"https://api.github.com/repos/http4s/rho/contributors","subscribers_url":"https://api.github.com/repos/http4s/rho/subscribers","subscription_url":"https://api.github.com/repos/http4s/rho/subscription","commits_url":"https://api.github.com/repos/http4s/rho/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/rho/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/rho/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/rho/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/rho/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/rho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/rho/merges","archive_url":"https://api.github.com/repos/http4s/rho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/rho/downloads","issues_url":"https://api.github.com/repos/http4s/rho/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/rho/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/rho/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/rho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/rho/labels{/name}","releases_url":"https://api.github.com/repos/http4s/rho/releases{/id}","deployments_url":"https://api.github.com/repos/http4s/rho/deployments","created_at":"2014-06-29T17:41:15Z","updated_at":"2016-12-27T16:17:04Z","pushed_at":"2016-12-30T19:26:10Z","git_url":"git://github.com/http4s/rho.git","ssh_url":"git@github.com:http4s/rho.git","clone_url":"https://github.com/http4s/rho.git","svn_url":"https://github.com/http4s/rho","homepage":null,"size":2986,"stargazers_count":79,"watchers_count":79,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":20,"forks":10,"open_issues":20,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http4s/rho/pulls/160"},"html":{"href":"https://github.com/http4s/rho/pull/160"},"issue":{"href":"https://api.github.com/repos/http4s/rho/issues/160"},"comments":{"href":"https://api.github.com/repos/http4s/rho/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/http4s/rho/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/http4s/rho/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/http4s/rho/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/http4s/rho/statuses/f2aa7c1ce24d32c694d708a87bae117c35bfb431"}}}}
{"actor":{"display_login":"zarthross"}}