{"action":"created","comment":{"url":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/comments/93683478","pull_request_review_id":14216845,"id":93683478,"diff_hunk":"@@ -0,0 +1,72 @@\n+# Author: Sawood Alam <@ibnesayeed>","path":"lib/classifier-reborn/backends/bayes_memory_backend.rb","position":1,"original_position":1,"commit_id":"737e744d51671d0275c5d81e313ae12e3daf794f","original_commit_id":"737e744d51671d0275c5d81e313ae12e3daf794f","user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},"body":"We don't have any author comments in our code – your authorship is present in the Git history and here on GitHub. 😄 ","created_at":"2016-12-22T19:33:50Z","updated_at":"2016-12-22T19:41:39Z","html_url":"https://github.com/jekyll/classifier-reborn/pull/84#discussion_r93683478","pull_request_url":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/comments/93683478"},"html":{"href":"https://github.com/jekyll/classifier-reborn/pull/84#discussion_r93683478"},"pull_request":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84","id":99055012,"html_url":"https://github.com/jekyll/classifier-reborn/pull/84","diff_url":"https://github.com/jekyll/classifier-reborn/pull/84.diff","patch_url":"https://github.com/jekyll/classifier-reborn/pull/84.patch","issue_url":"https://api.github.com/repos/jekyll/classifier-reborn/issues/84","number":84,"state":"open","locked":false,"title":"WIP: Memory and Redis backend support","user":{"login":"ibnesayeed","id":65147,"avatar_url":"https://avatars.githubusercontent.com/u/65147?v=3","gravatar_id":"","url":"https://api.github.com/users/ibnesayeed","html_url":"https://github.com/ibnesayeed","followers_url":"https://api.github.com/users/ibnesayeed/followers","following_url":"https://api.github.com/users/ibnesayeed/following{/other_user}","gists_url":"https://api.github.com/users/ibnesayeed/gists{/gist_id}","starred_url":"https://api.github.com/users/ibnesayeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibnesayeed/subscriptions","organizations_url":"https://api.github.com/users/ibnesayeed/orgs","repos_url":"https://api.github.com/users/ibnesayeed/repos","events_url":"https://api.github.com/users/ibnesayeed/events{/privacy}","received_events_url":"https://api.github.com/users/ibnesayeed/received_events","type":"User","site_admin":false},"body":"This WIP PR is to support #81\r\n\r\n## TODO\r\n\r\n* [x] Refactor Bayes classifier code to extract all the persistent states and data structures away\r\n* [x] Conditional initialization of the backends (Memory or Redis)\r\n* [x] Meaningful proxy read and write method names to allow uniform backend API\r\n* [x] Change in data structure for better generalization\r\n* [x] Implementation of the Memory backend\r\n* [x] Passing existing tests\r\n* [ ] Code review\r\n* [ ] Implementation of the Redis backend\r\n* [ ] Writing more tests\r\n* [ ] Update README","created_at":"2016-12-22T06:36:04Z","updated_at":"2016-12-22T19:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ce31f66e49922ae8e151dbc8618bceac38fc2f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84/commits","review_comments_url":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84/comments","review_comment_url":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jekyll/classifier-reborn/issues/84/comments","statuses_url":"https://api.github.com/repos/jekyll/classifier-reborn/statuses/737e744d51671d0275c5d81e313ae12e3daf794f","head":{"label":"ibnesayeed:redis","ref":"redis","sha":"737e744d51671d0275c5d81e313ae12e3daf794f","user":{"login":"ibnesayeed","id":65147,"avatar_url":"https://avatars.githubusercontent.com/u/65147?v=3","gravatar_id":"","url":"https://api.github.com/users/ibnesayeed","html_url":"https://github.com/ibnesayeed","followers_url":"https://api.github.com/users/ibnesayeed/followers","following_url":"https://api.github.com/users/ibnesayeed/following{/other_user}","gists_url":"https://api.github.com/users/ibnesayeed/gists{/gist_id}","starred_url":"https://api.github.com/users/ibnesayeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibnesayeed/subscriptions","organizations_url":"https://api.github.com/users/ibnesayeed/orgs","repos_url":"https://api.github.com/users/ibnesayeed/repos","events_url":"https://api.github.com/users/ibnesayeed/events{/privacy}","received_events_url":"https://api.github.com/users/ibnesayeed/received_events","type":"User","site_admin":false},"repo":{"id":76664878,"name":"classifier-reborn","full_name":"ibnesayeed/classifier-reborn","owner":{"login":"ibnesayeed","id":65147,"avatar_url":"https://avatars.githubusercontent.com/u/65147?v=3","gravatar_id":"","url":"https://api.github.com/users/ibnesayeed","html_url":"https://github.com/ibnesayeed","followers_url":"https://api.github.com/users/ibnesayeed/followers","following_url":"https://api.github.com/users/ibnesayeed/following{/other_user}","gists_url":"https://api.github.com/users/ibnesayeed/gists{/gist_id}","starred_url":"https://api.github.com/users/ibnesayeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibnesayeed/subscriptions","organizations_url":"https://api.github.com/users/ibnesayeed/orgs","repos_url":"https://api.github.com/users/ibnesayeed/repos","events_url":"https://api.github.com/users/ibnesayeed/events{/privacy}","received_events_url":"https://api.github.com/users/ibnesayeed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibnesayeed/classifier-reborn","description":"A general classifier module to allow Bayesian and other types of classifications. A fork of cardmagic/classifier.","fork":true,"url":"https://api.github.com/repos/ibnesayeed/classifier-reborn","forks_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/forks","keys_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/teams","hooks_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/hooks","issue_events_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/issues/events{/number}","events_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/events","assignees_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/assignees{/user}","branches_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/branches{/branch}","tags_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/tags","blobs_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/statuses/{sha}","languages_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/languages","stargazers_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/stargazers","contributors_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/contributors","subscribers_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/subscribers","subscription_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/subscription","commits_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/contents/{+path}","compare_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/merges","archive_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/downloads","issues_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/issues{/number}","pulls_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/pulls{/number}","milestones_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/milestones{/number}","notifications_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/labels{/name}","releases_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/releases{/id}","deployments_url":"https://api.github.com/repos/ibnesayeed/classifier-reborn/deployments","created_at":"2016-12-16T15:39:26Z","updated_at":"2016-12-16T15:39:27Z","pushed_at":"2016-12-22T06:21:29Z","git_url":"git://github.com/ibnesayeed/classifier-reborn.git","ssh_url":"git@github.com:ibnesayeed/classifier-reborn.git","clone_url":"https://github.com/ibnesayeed/classifier-reborn.git","svn_url":"https://github.com/ibnesayeed/classifier-reborn","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"6b363ccc5bbc2d4b5528a9ffb1299be94f8f8aad","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":22818441,"name":"classifier-reborn","full_name":"jekyll/classifier-reborn","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/classifier-reborn","description":"A general classifier module to allow Bayesian and other types of classifications. A fork of cardmagic/classifier.","fork":false,"url":"https://api.github.com/repos/jekyll/classifier-reborn","forks_url":"https://api.github.com/repos/jekyll/classifier-reborn/forks","keys_url":"https://api.github.com/repos/jekyll/classifier-reborn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/classifier-reborn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/classifier-reborn/teams","hooks_url":"https://api.github.com/repos/jekyll/classifier-reborn/hooks","issue_events_url":"https://api.github.com/repos/jekyll/classifier-reborn/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/classifier-reborn/events","assignees_url":"https://api.github.com/repos/jekyll/classifier-reborn/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/classifier-reborn/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/classifier-reborn/tags","blobs_url":"https://api.github.com/repos/jekyll/classifier-reborn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/classifier-reborn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/classifier-reborn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/classifier-reborn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/classifier-reborn/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/classifier-reborn/languages","stargazers_url":"https://api.github.com/repos/jekyll/classifier-reborn/stargazers","contributors_url":"https://api.github.com/repos/jekyll/classifier-reborn/contributors","subscribers_url":"https://api.github.com/repos/jekyll/classifier-reborn/subscribers","subscription_url":"https://api.github.com/repos/jekyll/classifier-reborn/subscription","commits_url":"https://api.github.com/repos/jekyll/classifier-reborn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/classifier-reborn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/classifier-reborn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/classifier-reborn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekyll/classifier-reborn/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/classifier-reborn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/classifier-reborn/merges","archive_url":"https://api.github.com/repos/jekyll/classifier-reborn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/classifier-reborn/downloads","issues_url":"https://api.github.com/repos/jekyll/classifier-reborn/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/classifier-reborn/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/classifier-reborn/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/classifier-reborn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/classifier-reborn/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/classifier-reborn/releases{/id}","deployments_url":"https://api.github.com/repos/jekyll/classifier-reborn/deployments","created_at":"2014-08-10T20:54:45Z","updated_at":"2016-12-20T12:28:48Z","pushed_at":"2016-12-22T06:36:04Z","git_url":"git://github.com/jekyll/classifier-reborn.git","ssh_url":"git@github.com:jekyll/classifier-reborn.git","clone_url":"https://github.com/jekyll/classifier-reborn.git","svn_url":"https://github.com/jekyll/classifier-reborn","homepage":null,"size":192,"stargazers_count":280,"watchers_count":280,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":15,"forks":46,"open_issues":15,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84"},"html":{"href":"https://github.com/jekyll/classifier-reborn/pull/84"},"issue":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/issues/84"},"comments":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/classifier-reborn/statuses/737e744d51671d0275c5d81e313ae12e3daf794f"}}}}
{"actor":{"display_login":"parkr"}}