{"action":"created","comment":{"url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments/88863645","pull_request_review_id":9421694,"id":88863645,"diff_hunk":"@@ -168,7 +168,7 @@ protected function _getComponentCssClass($prefix)\n         return null;\n     }\n \n-    private static function _getAbsolutePath($path)\n+    public static function getAbsolutePath($path)","path":"Kwf/Assets/Dependency/File.php","position":5,"original_position":5,"commit_id":"4f76486a12a28c78d9d75ff87a54da4abbe519f1","original_commit_id":"238a3f4e17a25c9bf91ccac4110297cd1367d21c","user":{"login":"nsams","id":50764,"avatar_url":"https://avatars.githubusercontent.com/u/50764?v=3","gravatar_id":"","url":"https://api.github.com/users/nsams","html_url":"https://github.com/nsams","followers_url":"https://api.github.com/users/nsams/followers","following_url":"https://api.github.com/users/nsams/following{/other_user}","gists_url":"https://api.github.com/users/nsams/gists{/gist_id}","starred_url":"https://api.github.com/users/nsams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsams/subscriptions","organizations_url":"https://api.github.com/users/nsams/orgs","repos_url":"https://api.github.com/users/nsams/repos","events_url":"https://api.github.com/users/nsams/events{/privacy}","received_events_url":"https://api.github.com/users/nsams/received_events","type":"User","site_admin":false},"body":"now that it is public we should think about a good name: calculateAbsolutePath, resolveAbsolutePath\r\n\r\nget (especally in Dependency_File) is missleading","created_at":"2016-11-21T10:14:58Z","updated_at":"2016-11-21T10:16:48Z","html_url":"https://github.com/koala-framework/koala-framework/pull/579#discussion_r88863645","pull_request_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579","_links":{"self":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments/88863645"},"html":{"href":"https://github.com/koala-framework/koala-framework/pull/579#discussion_r88863645"},"pull_request":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579","id":94576903,"html_url":"https://github.com/koala-framework/koala-framework/pull/579","diff_url":"https://github.com/koala-framework/koala-framework/pull/579.diff","patch_url":"https://github.com/koala-framework/koala-framework/pull/579.patch","issue_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/579","number":579,"state":"open","locked":false,"title":"Improved support for browser field in js-libraries","user":{"login":"fraxachun","id":1013756,"avatar_url":"https://avatars.githubusercontent.com/u/1013756?v=3","gravatar_id":"","url":"https://api.github.com/users/fraxachun","html_url":"https://github.com/fraxachun","followers_url":"https://api.github.com/users/fraxachun/followers","following_url":"https://api.github.com/users/fraxachun/following{/other_user}","gists_url":"https://api.github.com/users/fraxachun/gists{/gist_id}","starred_url":"https://api.github.com/users/fraxachun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraxachun/subscriptions","organizations_url":"https://api.github.com/users/fraxachun/orgs","repos_url":"https://api.github.com/users/fraxachun/repos","events_url":"https://api.github.com/users/fraxachun/events{/privacy}","received_events_url":"https://api.github.com/users/fraxachun/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-21T09:11:40Z","updated_at":"2016-11-21T10:16:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01bd1c9d3fa8102c24f181d7de56b9f883d27d44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579/commits","review_comments_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579/comments","review_comment_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/579/comments","statuses_url":"https://api.github.com/repos/koala-framework/koala-framework/statuses/4f76486a12a28c78d9d75ff87a54da4abbe519f1","head":{"label":"fraxachun:4.2-assets-browser-field","ref":"4.2-assets-browser-field","sha":"4f76486a12a28c78d9d75ff87a54da4abbe519f1","user":{"login":"fraxachun","id":1013756,"avatar_url":"https://avatars.githubusercontent.com/u/1013756?v=3","gravatar_id":"","url":"https://api.github.com/users/fraxachun","html_url":"https://github.com/fraxachun","followers_url":"https://api.github.com/users/fraxachun/followers","following_url":"https://api.github.com/users/fraxachun/following{/other_user}","gists_url":"https://api.github.com/users/fraxachun/gists{/gist_id}","starred_url":"https://api.github.com/users/fraxachun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraxachun/subscriptions","organizations_url":"https://api.github.com/users/fraxachun/orgs","repos_url":"https://api.github.com/users/fraxachun/repos","events_url":"https://api.github.com/users/fraxachun/events{/privacy}","received_events_url":"https://api.github.com/users/fraxachun/received_events","type":"User","site_admin":false},"repo":{"id":10214205,"name":"koala-framework","full_name":"fraxachun/koala-framework","owner":{"login":"fraxachun","id":1013756,"avatar_url":"https://avatars.githubusercontent.com/u/1013756?v=3","gravatar_id":"","url":"https://api.github.com/users/fraxachun","html_url":"https://github.com/fraxachun","followers_url":"https://api.github.com/users/fraxachun/followers","following_url":"https://api.github.com/users/fraxachun/following{/other_user}","gists_url":"https://api.github.com/users/fraxachun/gists{/gist_id}","starred_url":"https://api.github.com/users/fraxachun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraxachun/subscriptions","organizations_url":"https://api.github.com/users/fraxachun/orgs","repos_url":"https://api.github.com/users/fraxachun/repos","events_url":"https://api.github.com/users/fraxachun/events{/privacy}","received_events_url":"https://api.github.com/users/fraxachun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fraxachun/koala-framework","description":"Framework and CMS based on Zend Framework and ExtJS","fork":true,"url":"https://api.github.com/repos/fraxachun/koala-framework","forks_url":"https://api.github.com/repos/fraxachun/koala-framework/forks","keys_url":"https://api.github.com/repos/fraxachun/koala-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fraxachun/koala-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fraxachun/koala-framework/teams","hooks_url":"https://api.github.com/repos/fraxachun/koala-framework/hooks","issue_events_url":"https://api.github.com/repos/fraxachun/koala-framework/issues/events{/number}","events_url":"https://api.github.com/repos/fraxachun/koala-framework/events","assignees_url":"https://api.github.com/repos/fraxachun/koala-framework/assignees{/user}","branches_url":"https://api.github.com/repos/fraxachun/koala-framework/branches{/branch}","tags_url":"https://api.github.com/repos/fraxachun/koala-framework/tags","blobs_url":"https://api.github.com/repos/fraxachun/koala-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fraxachun/koala-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fraxachun/koala-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/fraxachun/koala-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fraxachun/koala-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/fraxachun/koala-framework/languages","stargazers_url":"https://api.github.com/repos/fraxachun/koala-framework/stargazers","contributors_url":"https://api.github.com/repos/fraxachun/koala-framework/contributors","subscribers_url":"https://api.github.com/repos/fraxachun/koala-framework/subscribers","subscription_url":"https://api.github.com/repos/fraxachun/koala-framework/subscription","commits_url":"https://api.github.com/repos/fraxachun/koala-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/fraxachun/koala-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/fraxachun/koala-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/fraxachun/koala-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/fraxachun/koala-framework/contents/{+path}","compare_url":"https://api.github.com/repos/fraxachun/koala-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fraxachun/koala-framework/merges","archive_url":"https://api.github.com/repos/fraxachun/koala-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fraxachun/koala-framework/downloads","issues_url":"https://api.github.com/repos/fraxachun/koala-framework/issues{/number}","pulls_url":"https://api.github.com/repos/fraxachun/koala-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/fraxachun/koala-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/fraxachun/koala-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fraxachun/koala-framework/labels{/name}","releases_url":"https://api.github.com/repos/fraxachun/koala-framework/releases{/id}","deployments_url":"https://api.github.com/repos/fraxachun/koala-framework/deployments","created_at":"2013-05-22T07:23:48Z","updated_at":"2014-05-21T07:06:52Z","pushed_at":"2016-11-21T09:10:54Z","git_url":"git://github.com/fraxachun/koala-framework.git","ssh_url":"git@github.com:fraxachun/koala-framework.git","clone_url":"https://github.com/fraxachun/koala-framework.git","svn_url":"https://github.com/fraxachun/koala-framework","homepage":"http://www.koala-framework.org/","size":66661,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.3"}},"base":{"label":"koala-framework:4.2","ref":"4.2","sha":"341859b7c9df44dc8a50f6a026048a162b417604","user":{"login":"koala-framework","id":7679767,"avatar_url":"https://avatars.githubusercontent.com/u/7679767?v=3","gravatar_id":"","url":"https://api.github.com/users/koala-framework","html_url":"https://github.com/koala-framework","followers_url":"https://api.github.com/users/koala-framework/followers","following_url":"https://api.github.com/users/koala-framework/following{/other_user}","gists_url":"https://api.github.com/users/koala-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/koala-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koala-framework/subscriptions","organizations_url":"https://api.github.com/users/koala-framework/orgs","repos_url":"https://api.github.com/users/koala-framework/repos","events_url":"https://api.github.com/users/koala-framework/events{/privacy}","received_events_url":"https://api.github.com/users/koala-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":2466955,"name":"koala-framework","full_name":"koala-framework/koala-framework","owner":{"login":"koala-framework","id":7679767,"avatar_url":"https://avatars.githubusercontent.com/u/7679767?v=3","gravatar_id":"","url":"https://api.github.com/users/koala-framework","html_url":"https://github.com/koala-framework","followers_url":"https://api.github.com/users/koala-framework/followers","following_url":"https://api.github.com/users/koala-framework/following{/other_user}","gists_url":"https://api.github.com/users/koala-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/koala-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koala-framework/subscriptions","organizations_url":"https://api.github.com/users/koala-framework/orgs","repos_url":"https://api.github.com/users/koala-framework/repos","events_url":"https://api.github.com/users/koala-framework/events{/privacy}","received_events_url":"https://api.github.com/users/koala-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koala-framework/koala-framework","description":"Framework and CMS based on Zend Framework and ExtJS","fork":false,"url":"https://api.github.com/repos/koala-framework/koala-framework","forks_url":"https://api.github.com/repos/koala-framework/koala-framework/forks","keys_url":"https://api.github.com/repos/koala-framework/koala-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koala-framework/koala-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koala-framework/koala-framework/teams","hooks_url":"https://api.github.com/repos/koala-framework/koala-framework/hooks","issue_events_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/events{/number}","events_url":"https://api.github.com/repos/koala-framework/koala-framework/events","assignees_url":"https://api.github.com/repos/koala-framework/koala-framework/assignees{/user}","branches_url":"https://api.github.com/repos/koala-framework/koala-framework/branches{/branch}","tags_url":"https://api.github.com/repos/koala-framework/koala-framework/tags","blobs_url":"https://api.github.com/repos/koala-framework/koala-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koala-framework/koala-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koala-framework/koala-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/koala-framework/koala-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koala-framework/koala-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/koala-framework/koala-framework/languages","stargazers_url":"https://api.github.com/repos/koala-framework/koala-framework/stargazers","contributors_url":"https://api.github.com/repos/koala-framework/koala-framework/contributors","subscribers_url":"https://api.github.com/repos/koala-framework/koala-framework/subscribers","subscription_url":"https://api.github.com/repos/koala-framework/koala-framework/subscription","commits_url":"https://api.github.com/repos/koala-framework/koala-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/koala-framework/koala-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/koala-framework/koala-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/koala-framework/koala-framework/contents/{+path}","compare_url":"https://api.github.com/repos/koala-framework/koala-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koala-framework/koala-framework/merges","archive_url":"https://api.github.com/repos/koala-framework/koala-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koala-framework/koala-framework/downloads","issues_url":"https://api.github.com/repos/koala-framework/koala-framework/issues{/number}","pulls_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/koala-framework/koala-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/koala-framework/koala-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koala-framework/koala-framework/labels{/name}","releases_url":"https://api.github.com/repos/koala-framework/koala-framework/releases{/id}","deployments_url":"https://api.github.com/repos/koala-framework/koala-framework/deployments","created_at":"2011-09-27T10:36:51Z","updated_at":"2016-09-05T09:42:48Z","pushed_at":"2016-11-21T09:11:40Z","git_url":"git://github.com/koala-framework/koala-framework.git","ssh_url":"git@github.com:koala-framework/koala-framework.git","clone_url":"https://github.com/koala-framework/koala-framework.git","svn_url":"https://github.com/koala-framework/koala-framework","homepage":"http://www.koala-framework.org/","size":77310,"stargazers_count":41,"watchers_count":41,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":31,"forks":29,"open_issues":31,"watchers":41,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579"},"html":{"href":"https://github.com/koala-framework/koala-framework/pull/579"},"issue":{"href":"https://api.github.com/repos/koala-framework/koala-framework/issues/579"},"comments":{"href":"https://api.github.com/repos/koala-framework/koala-framework/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/koala-framework/koala-framework/statuses/4f76486a12a28c78d9d75ff87a54da4abbe519f1"}}}}
{"actor":{"display_login":"nsams"}}