{"action":"created","comment":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments/55629768","id":55629768,"diff_hunk":"@@ -28,8 +31,10 @@\n \n     (when-not lein-version-ok?\n       (lein/warn \"Warning: cider-nrepl requires Leiningen 2.5.2 or greater.\"))\n-    (when-not clojure-version-ok?\n+    (when (or (not clojure-version-ok?) clojure-excluded?)","path":"src/cider_nrepl/plugin.clj","position":27,"original_position":27,"commit_id":"0d0e563b55f1f5ad0af3f2ed39b3d722f0dbb593","original_commit_id":"0d0e563b55f1f5ad0af3f2ed39b3d722f0dbb593","user":{"login":"Malabarba","id":453029,"avatar_url":"https://avatars.githubusercontent.com/u/453029?v=3","gravatar_id":"","url":"https://api.github.com/users/Malabarba","html_url":"https://github.com/Malabarba","followers_url":"https://api.github.com/users/Malabarba/followers","following_url":"https://api.github.com/users/Malabarba/following{/other_user}","gists_url":"https://api.github.com/users/Malabarba/gists{/gist_id}","starred_url":"https://api.github.com/users/Malabarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Malabarba/subscriptions","organizations_url":"https://api.github.com/users/Malabarba/orgs","repos_url":"https://api.github.com/users/Malabarba/repos","events_url":"https://api.github.com/users/Malabarba/events{/privacy}","received_events_url":"https://api.github.com/users/Malabarba/received_events","type":"User","site_admin":false},"body":"Shouldn't this be a `(when-not (or clojure-version-ok? clojure-excluded?)`? ","created_at":"2016-03-10T03:25:54Z","updated_at":"2016-03-10T03:25:54Z","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/316#discussion_r55629768","pull_request_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316","_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments/55629768"},"html":{"href":"https://github.com/clojure-emacs/cider-nrepl/pull/316#discussion_r55629768"},"pull_request":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316","id":62332730,"html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/316","diff_url":"https://github.com/clojure-emacs/cider-nrepl/pull/316.diff","patch_url":"https://github.com/clojure-emacs/cider-nrepl/pull/316.patch","issue_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/316","number":316,"state":"open","locked":false,"title":"Include cider-nrepl anyway when clj is excluded","user":{"login":"arrdem","id":704767,"avatar_url":"https://avatars.githubusercontent.com/u/704767?v=3","gravatar_id":"","url":"https://api.github.com/users/arrdem","html_url":"https://github.com/arrdem","followers_url":"https://api.github.com/users/arrdem/followers","following_url":"https://api.github.com/users/arrdem/following{/other_user}","gists_url":"https://api.github.com/users/arrdem/gists{/gist_id}","starred_url":"https://api.github.com/users/arrdem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrdem/subscriptions","organizations_url":"https://api.github.com/users/arrdem/orgs","repos_url":"https://api.github.com/users/arrdem/repos","events_url":"https://api.github.com/users/arrdem/events{/privacy}","received_events_url":"https://api.github.com/users/arrdem/received_events","type":"User","site_admin":false},"body":"This patch allows the cider-nrepl middleware to be injected into a project which does not depend on `org.clojure/clojure`, if and only if the user has explicitly provided `:exclusions [... org.clojure/clojure]`\r\nin the `project.clj` file. This allows users who know what they're doing to take on the responsibility of providing an appropriate build of Clojure and thus use CIDER with forks albeit with a warning.\r\n\r\nReplaces https://github.com/clojure-emacs/cider/pull/1603","created_at":"2016-03-10T03:02:56Z","updated_at":"2016-03-10T03:25:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40c0fe8fe557faeff2d83592af71108f8d414adc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316/commits","review_comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316/comments","review_comment_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/316/comments","statuses_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/0d0e563b55f1f5ad0af3f2ed39b3d722f0dbb593","head":{"label":"arrdem:feature/excluded-clojure","ref":"feature/excluded-clojure","sha":"0d0e563b55f1f5ad0af3f2ed39b3d722f0dbb593","user":{"login":"arrdem","id":704767,"avatar_url":"https://avatars.githubusercontent.com/u/704767?v=3","gravatar_id":"","url":"https://api.github.com/users/arrdem","html_url":"https://github.com/arrdem","followers_url":"https://api.github.com/users/arrdem/followers","following_url":"https://api.github.com/users/arrdem/following{/other_user}","gists_url":"https://api.github.com/users/arrdem/gists{/gist_id}","starred_url":"https://api.github.com/users/arrdem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrdem/subscriptions","organizations_url":"https://api.github.com/users/arrdem/orgs","repos_url":"https://api.github.com/users/arrdem/repos","events_url":"https://api.github.com/users/arrdem/events{/privacy}","received_events_url":"https://api.github.com/users/arrdem/received_events","type":"User","site_admin":false},"repo":{"id":53549375,"name":"cider-nrepl","full_name":"arrdem/cider-nrepl","owner":{"login":"arrdem","id":704767,"avatar_url":"https://avatars.githubusercontent.com/u/704767?v=3","gravatar_id":"","url":"https://api.github.com/users/arrdem","html_url":"https://github.com/arrdem","followers_url":"https://api.github.com/users/arrdem/followers","following_url":"https://api.github.com/users/arrdem/following{/other_user}","gists_url":"https://api.github.com/users/arrdem/gists{/gist_id}","starred_url":"https://api.github.com/users/arrdem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrdem/subscriptions","organizations_url":"https://api.github.com/users/arrdem/orgs","repos_url":"https://api.github.com/users/arrdem/repos","events_url":"https://api.github.com/users/arrdem/events{/privacy}","received_events_url":"https://api.github.com/users/arrdem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arrdem/cider-nrepl","description":"nREPL middleware for CIDER","fork":true,"url":"https://api.github.com/repos/arrdem/cider-nrepl","forks_url":"https://api.github.com/repos/arrdem/cider-nrepl/forks","keys_url":"https://api.github.com/repos/arrdem/cider-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arrdem/cider-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arrdem/cider-nrepl/teams","hooks_url":"https://api.github.com/repos/arrdem/cider-nrepl/hooks","issue_events_url":"https://api.github.com/repos/arrdem/cider-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/arrdem/cider-nrepl/events","assignees_url":"https://api.github.com/repos/arrdem/cider-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/arrdem/cider-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/arrdem/cider-nrepl/tags","blobs_url":"https://api.github.com/repos/arrdem/cider-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arrdem/cider-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arrdem/cider-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/arrdem/cider-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arrdem/cider-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/arrdem/cider-nrepl/languages","stargazers_url":"https://api.github.com/repos/arrdem/cider-nrepl/stargazers","contributors_url":"https://api.github.com/repos/arrdem/cider-nrepl/contributors","subscribers_url":"https://api.github.com/repos/arrdem/cider-nrepl/subscribers","subscription_url":"https://api.github.com/repos/arrdem/cider-nrepl/subscription","commits_url":"https://api.github.com/repos/arrdem/cider-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/arrdem/cider-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/arrdem/cider-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/arrdem/cider-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/arrdem/cider-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/arrdem/cider-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arrdem/cider-nrepl/merges","archive_url":"https://api.github.com/repos/arrdem/cider-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arrdem/cider-nrepl/downloads","issues_url":"https://api.github.com/repos/arrdem/cider-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/arrdem/cider-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/arrdem/cider-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/arrdem/cider-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arrdem/cider-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/arrdem/cider-nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/arrdem/cider-nrepl/deployments","created_at":"2016-03-10T02:46:16Z","updated_at":"2016-03-10T02:46:17Z","pushed_at":"2016-03-10T03:02:48Z","git_url":"git://github.com/arrdem/cider-nrepl.git","ssh_url":"git@github.com:arrdem/cider-nrepl.git","clone_url":"https://github.com/arrdem/cider-nrepl.git","svn_url":"https://github.com/arrdem/cider-nrepl","homepage":null,"size":838,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clojure-emacs:master","ref":"master","sha":"a9237d66f29c6077f81b09d30887f73b8ac5d1cc","user":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":15360927,"name":"cider-nrepl","full_name":"clojure-emacs/cider-nrepl","owner":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clojure-emacs/cider-nrepl","description":"nREPL middleware for CIDER","fork":false,"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl","forks_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/forks","keys_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/events","assignees_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/merges","archive_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/deployments","created_at":"2013-12-21T15:27:38Z","updated_at":"2016-03-06T07:41:59Z","pushed_at":"2016-03-10T03:09:44Z","git_url":"git://github.com/clojure-emacs/cider-nrepl.git","ssh_url":"git@github.com:clojure-emacs/cider-nrepl.git","clone_url":"https://github.com/clojure-emacs/cider-nrepl.git","svn_url":"https://github.com/clojure-emacs/cider-nrepl","homepage":null,"size":913,"stargazers_count":225,"watchers_count":225,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":15,"forks":70,"open_issues":15,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316"},"html":{"href":"https://github.com/clojure-emacs/cider-nrepl/pull/316"},"issue":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/316"},"comments":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/0d0e563b55f1f5ad0af3f2ed39b3d722f0dbb593"}}}}