{"action":"created","issue":{"url":"https://api.github.com/repos/Samsung/GearVRf/issues/381","labels_url":"https://api.github.com/repos/Samsung/GearVRf/issues/381/labels{/name}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/381/comments","events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/381/events","html_url":"https://github.com/Samsung/GearVRf/pull/381","id":127534065,"number":381,"title":"Shadow mapping implementation","user":{"login":"fredduarte","id":1534070,"avatar_url":"https://avatars.githubusercontent.com/u/1534070?v=3","gravatar_id":"","url":"https://api.github.com/users/fredduarte","html_url":"https://github.com/fredduarte","followers_url":"https://api.github.com/users/fredduarte/followers","following_url":"https://api.github.com/users/fredduarte/following{/other_user}","gists_url":"https://api.github.com/users/fredduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredduarte/subscriptions","organizations_url":"https://api.github.com/users/fredduarte/orgs","repos_url":"https://api.github.com/users/fredduarte/repos","events_url":"https://api.github.com/users/fredduarte/events{/privacy}","received_events_url":"https://api.github.com/users/fredduarte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-19T20:43:17Z","updated_at":"2016-01-22T19:12:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/381","html_url":"https://github.com/Samsung/GearVRf/pull/381","diff_url":"https://github.com/Samsung/GearVRf/pull/381.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/381.patch"},"body":"- Implemented shadow mapping technique using 3-step rendering process:\r\n* First, it renders the scene from the perspective of the light;\r\n* Second, it renders the scene from the perspective of the camera;\r\n* Finally, it combines both to produce the shadows;\r\n\r\n- Implemented a directional light object which is used for calculating the shadowmap Z distance.\r\n\r\n- Created a sample project for displaying and testing the shadow mapping.\r\n"},"comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments/174015612","html_url":"https://github.com/Samsung/GearVRf/pull/381#issuecomment-174015612","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/381","id":174015612,"user":{"login":"Vittalbabu","id":13738187,"avatar_url":"https://avatars.githubusercontent.com/u/13738187?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittalbabu","html_url":"https://github.com/Vittalbabu","followers_url":"https://api.github.com/users/Vittalbabu/followers","following_url":"https://api.github.com/users/Vittalbabu/following{/other_user}","gists_url":"https://api.github.com/users/Vittalbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittalbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittalbabu/subscriptions","organizations_url":"https://api.github.com/users/Vittalbabu/orgs","repos_url":"https://api.github.com/users/Vittalbabu/repos","events_url":"https://api.github.com/users/Vittalbabu/events{/privacy}","received_events_url":"https://api.github.com/users/Vittalbabu/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T19:12:57Z","updated_at":"2016-01-22T19:12:57Z","body":"Overall looks nice but I have some questions regarding testing.\r\n\r\n1. Need to validate that we do not accidentally invoke shadow map shader when that is not the intent. (eg) We can add a log message to ShadowShader::render() and run a few of our existing samples.\r\n2. What is the performance delta of using these 3 passes? We should test with a scene of moderate GPU load and heavy GPU load - with shadow map on and off. Based on the results we can decide how to proceed."}}