{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/77419363","id":77419363,"diff_hunk":"@@ -41,23 +43,23 @@ Object.assign(CallbackQueue.prototype, {\n    * @param {?object} context Context to call `callback` with.\n    * @internal\n    */\n-  enqueue: function(callback, context) {\n+   enqueue(callback: () => void, context: T) {\n     this._callbacks = this._callbacks || [];\n-    this._contexts = this._contexts || [];\n     this._callbacks.push(callback);\n+    this._contexts = this._contexts || [];","path":"src/renderers/shared/utils/CallbackQueue.js","position":29,"original_position":29,"commit_id":"f450c0ba69fde97ce9340a69daa6199275548f29","original_commit_id":"f450c0ba69fde97ce9340a69daa6199275548f29","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"body":"Never mind, I guess I see.","created_at":"2016-09-02T22:18:19Z","updated_at":"2016-09-02T22:18:19Z","html_url":"https://github.com/facebook/react/pull/7647#discussion_r77419363","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/7647","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/77419363"},"html":{"href":"https://github.com/facebook/react/pull/7647#discussion_r77419363"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/7647"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/7647","id":83871262,"html_url":"https://github.com/facebook/react/pull/7647","diff_url":"https://github.com/facebook/react/pull/7647.diff","patch_url":"https://github.com/facebook/react/pull/7647.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/7647","number":7647,"state":"open","locked":false,"title":"Convert CallbackQueue to a class","user":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"body":"It turns out that flow cannot type `this` with a function constructor + prototype overrides. Turning it to a class makes flow happy and has minimal impact on the output.\r\n\r\nIn open source, we already use the loose version of the class transform and internally we have one that's outputting even less code if you have `@preventMunge` in the header.\r\n\r\nSee discussion in https://www.facebook.com/groups/2003630259862046/permalink/2098480820376989/","created_at":"2016-09-02T22:11:23Z","updated_at":"2016-09-02T22:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90516f8e3a314a3a6f083fba07a4566d62a8260","assignee":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"assignees":[{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/7647/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/7647/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/7647/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/f450c0ba69fde97ce9340a69daa6199275548f29","head":{"label":"vjeux:type_CallbackQueue2","ref":"type_CallbackQueue2","sha":"f450c0ba69fde97ce9340a69daa6199275548f29","user":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"repo":{"id":22545610,"name":"react","full_name":"vjeux/react","owner":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjeux/react","description":"React is a JavaScript library for building user interfaces. It's declarative, efficient, and extremely flexible. What's more, it works with the libraries and frameworks that you already know.","fork":true,"url":"https://api.github.com/repos/vjeux/react","forks_url":"https://api.github.com/repos/vjeux/react/forks","keys_url":"https://api.github.com/repos/vjeux/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjeux/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjeux/react/teams","hooks_url":"https://api.github.com/repos/vjeux/react/hooks","issue_events_url":"https://api.github.com/repos/vjeux/react/issues/events{/number}","events_url":"https://api.github.com/repos/vjeux/react/events","assignees_url":"https://api.github.com/repos/vjeux/react/assignees{/user}","branches_url":"https://api.github.com/repos/vjeux/react/branches{/branch}","tags_url":"https://api.github.com/repos/vjeux/react/tags","blobs_url":"https://api.github.com/repos/vjeux/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjeux/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjeux/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjeux/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjeux/react/statuses/{sha}","languages_url":"https://api.github.com/repos/vjeux/react/languages","stargazers_url":"https://api.github.com/repos/vjeux/react/stargazers","contributors_url":"https://api.github.com/repos/vjeux/react/contributors","subscribers_url":"https://api.github.com/repos/vjeux/react/subscribers","subscription_url":"https://api.github.com/repos/vjeux/react/subscription","commits_url":"https://api.github.com/repos/vjeux/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjeux/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjeux/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjeux/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/vjeux/react/contents/{+path}","compare_url":"https://api.github.com/repos/vjeux/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjeux/react/merges","archive_url":"https://api.github.com/repos/vjeux/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjeux/react/downloads","issues_url":"https://api.github.com/repos/vjeux/react/issues{/number}","pulls_url":"https://api.github.com/repos/vjeux/react/pulls{/number}","milestones_url":"https://api.github.com/repos/vjeux/react/milestones{/number}","notifications_url":"https://api.github.com/repos/vjeux/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjeux/react/labels{/name}","releases_url":"https://api.github.com/repos/vjeux/react/releases{/id}","deployments_url":"https://api.github.com/repos/vjeux/react/deployments","created_at":"2014-08-02T12:21:36Z","updated_at":"2016-08-28T06:26:14Z","pushed_at":"2016-09-02T22:11:15Z","git_url":"git://github.com/vjeux/react.git","ssh_url":"git@github.com:vjeux/react.git","clone_url":"https://github.com/vjeux/react.git","svn_url":"https://github.com/vjeux/react","homepage":"http://facebook.github.io/react/","size":69108,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"839697f60c6117e3a562c91142bda4c12acc4146","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-09-02T21:00:09Z","pushed_at":"2016-09-02T22:11:23Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":129260,"stargazers_count":48420,"watchers_count":48420,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8523,"mirror_url":null,"open_issues_count":647,"forks":8523,"open_issues":647,"watchers":48420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/7647"},"html":{"href":"https://github.com/facebook/react/pull/7647"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/7647"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/7647/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/7647/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/7647/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/f450c0ba69fde97ce9340a69daa6199275548f29"}}}}
{"actor":{"display_login":"spicyj"}}