{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/82048013","pull_request_review_id":2979348,"id":82048013,"diff_hunk":"@@ -2149,6 +2112,7 @@ ssl_callback_session_ticket(SSL *ssl, unsigned char *keyname, unsigned char *iv,\n                             int enc)\n {\n   SSLCertificateConfig::scoped_config lookup;\n+  SSLConfig::scoped_config params;","path":"iocore/net/SSLUtils.cc","position":76,"original_position":76,"commit_id":"c3b2cb65ef92a74345611d54b3919b733da707ea","original_commit_id":"c3b2cb65ef92a74345611d54b3919b733da707ea","user":{"login":"jpeach","id":9917,"avatar_url":"https://avatars.githubusercontent.com/u/9917?v=3","gravatar_id":"","url":"https://api.github.com/users/jpeach","html_url":"https://github.com/jpeach","followers_url":"https://api.github.com/users/jpeach/followers","following_url":"https://api.github.com/users/jpeach/following{/other_user}","gists_url":"https://api.github.com/users/jpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeach/subscriptions","organizations_url":"https://api.github.com/users/jpeach/orgs","repos_url":"https://api.github.com/users/jpeach/repos","events_url":"https://api.github.com/users/jpeach/events{/privacy}","received_events_url":"https://api.github.com/users/jpeach/received_events","type":"User","site_admin":false},"body":"Move this inside keyblock check so that we don't try to acquire the config unless we need it.","created_at":"2016-10-05T19:10:46Z","updated_at":"2016-10-05T19:17:31Z","html_url":"https://github.com/apache/trafficserver/pull/1024#discussion_r82048013","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/1024","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/82048013"},"html":{"href":"https://github.com/apache/trafficserver/pull/1024#discussion_r82048013"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1024"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/1024","id":85450275,"html_url":"https://github.com/apache/trafficserver/pull/1024","diff_url":"https://github.com/apache/trafficserver/pull/1024.diff","patch_url":"https://github.com/apache/trafficserver/pull/1024.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/1024","number":1024,"state":"open","locked":false,"title":"TS-4858: fix memory leak of global_default_keyblock","user":{"login":"persiaAziz","id":12615662,"avatar_url":"https://avatars.githubusercontent.com/u/12615662?v=3","gravatar_id":"","url":"https://api.github.com/users/persiaAziz","html_url":"https://github.com/persiaAziz","followers_url":"https://api.github.com/users/persiaAziz/followers","following_url":"https://api.github.com/users/persiaAziz/following{/other_user}","gists_url":"https://api.github.com/users/persiaAziz/gists{/gist_id}","starred_url":"https://api.github.com/users/persiaAziz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiaAziz/subscriptions","organizations_url":"https://api.github.com/users/persiaAziz/orgs","repos_url":"https://api.github.com/users/persiaAziz/repos","events_url":"https://api.github.com/users/persiaAziz/events{/privacy}","received_events_url":"https://api.github.com/users/persiaAziz/received_events","type":"User","site_admin":false},"body":"fix memory leak of global_default_keyblock. \r\nglobal_defualt_keyblock will be freed and reassigned on each reload","created_at":"2016-09-15T17:56:33Z","updated_at":"2016-10-05T19:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e4b647ae68a5c362ef8d4136e9a866e198b2507","assignee":{"login":"zwoop","id":202131,"avatar_url":"https://avatars.githubusercontent.com/u/202131?v=3","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"assignees":[{"login":"zwoop","id":202131,"avatar_url":"https://avatars.githubusercontent.com/u/202131?v=3","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},{"login":"shinrich","id":334488,"avatar_url":"https://avatars.githubusercontent.com/u/334488?v=3","gravatar_id":"","url":"https://api.github.com/users/shinrich","html_url":"https://github.com/shinrich","followers_url":"https://api.github.com/users/shinrich/followers","following_url":"https://api.github.com/users/shinrich/following{/other_user}","gists_url":"https://api.github.com/users/shinrich/gists{/gist_id}","starred_url":"https://api.github.com/users/shinrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinrich/subscriptions","organizations_url":"https://api.github.com/users/shinrich/orgs","repos_url":"https://api.github.com/users/shinrich/repos","events_url":"https://api.github.com/users/shinrich/events{/privacy}","received_events_url":"https://api.github.com/users/shinrich/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/2","html_url":"https://github.com/apache/trafficserver/milestones/7.1.0","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/2/labels","id":1761237,"number":2,"title":"7.1.0","description":"","creator":{"login":"zwoop","id":202131,"avatar_url":"https://avatars.githubusercontent.com/u/202131?v=3","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":36,"state":"open","created_at":"2016-05-11T22:45:45Z","updated_at":"2016-10-05T14:12:31Z","due_on":"2017-02-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/1024/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/c3b2cb65ef92a74345611d54b3919b733da707ea","head":{"label":"persiaAziz:TS-4858","ref":"TS-4858","sha":"c3b2cb65ef92a74345611d54b3919b733da707ea","user":{"login":"persiaAziz","id":12615662,"avatar_url":"https://avatars.githubusercontent.com/u/12615662?v=3","gravatar_id":"","url":"https://api.github.com/users/persiaAziz","html_url":"https://github.com/persiaAziz","followers_url":"https://api.github.com/users/persiaAziz/followers","following_url":"https://api.github.com/users/persiaAziz/following{/other_user}","gists_url":"https://api.github.com/users/persiaAziz/gists{/gist_id}","starred_url":"https://api.github.com/users/persiaAziz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiaAziz/subscriptions","organizations_url":"https://api.github.com/users/persiaAziz/orgs","repos_url":"https://api.github.com/users/persiaAziz/repos","events_url":"https://api.github.com/users/persiaAziz/events{/privacy}","received_events_url":"https://api.github.com/users/persiaAziz/received_events","type":"User","site_admin":false},"repo":{"id":36323350,"name":"trafficserver","full_name":"persiaAziz/trafficserver","owner":{"login":"persiaAziz","id":12615662,"avatar_url":"https://avatars.githubusercontent.com/u/12615662?v=3","gravatar_id":"","url":"https://api.github.com/users/persiaAziz","html_url":"https://github.com/persiaAziz","followers_url":"https://api.github.com/users/persiaAziz/followers","following_url":"https://api.github.com/users/persiaAziz/following{/other_user}","gists_url":"https://api.github.com/users/persiaAziz/gists{/gist_id}","starred_url":"https://api.github.com/users/persiaAziz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiaAziz/subscriptions","organizations_url":"https://api.github.com/users/persiaAziz/orgs","repos_url":"https://api.github.com/users/persiaAziz/repos","events_url":"https://api.github.com/users/persiaAziz/events{/privacy}","received_events_url":"https://api.github.com/users/persiaAziz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/persiaAziz/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/persiaAziz/trafficserver","forks_url":"https://api.github.com/repos/persiaAziz/trafficserver/forks","keys_url":"https://api.github.com/repos/persiaAziz/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/persiaAziz/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/persiaAziz/trafficserver/teams","hooks_url":"https://api.github.com/repos/persiaAziz/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/persiaAziz/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/persiaAziz/trafficserver/events","assignees_url":"https://api.github.com/repos/persiaAziz/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/persiaAziz/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/persiaAziz/trafficserver/tags","blobs_url":"https://api.github.com/repos/persiaAziz/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/persiaAziz/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/persiaAziz/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/persiaAziz/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/persiaAziz/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/persiaAziz/trafficserver/languages","stargazers_url":"https://api.github.com/repos/persiaAziz/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/persiaAziz/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/persiaAziz/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/persiaAziz/trafficserver/subscription","commits_url":"https://api.github.com/repos/persiaAziz/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/persiaAziz/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/persiaAziz/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/persiaAziz/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/persiaAziz/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/persiaAziz/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/persiaAziz/trafficserver/merges","archive_url":"https://api.github.com/repos/persiaAziz/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/persiaAziz/trafficserver/downloads","issues_url":"https://api.github.com/repos/persiaAziz/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/persiaAziz/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/persiaAziz/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/persiaAziz/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/persiaAziz/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/persiaAziz/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/persiaAziz/trafficserver/deployments","created_at":"2015-05-26T20:57:47Z","updated_at":"2016-06-28T19:26:02Z","pushed_at":"2016-10-05T17:57:56Z","git_url":"git://github.com/persiaAziz/trafficserver.git","ssh_url":"git@github.com:persiaAziz/trafficserver.git","clone_url":"https://github.com/persiaAziz/trafficserver.git","svn_url":"https://github.com/persiaAziz/trafficserver","homepage":null,"size":58394,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"366399e1e7adbfdf172314425a6cec33b6bd95b0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2016-10-04T09:18:50Z","pushed_at":"2016-10-05T19:14:11Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":69727,"stargazers_count":462,"watchers_count":462,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":368,"mirror_url":null,"open_issues_count":47,"forks":368,"open_issues":47,"watchers":462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1024"},"html":{"href":"https://github.com/apache/trafficserver/pull/1024"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/1024"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/c3b2cb65ef92a74345611d54b3919b733da707ea"}}}}
{"actor":{"display_login":"jpeach"}}