{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/68479263","id":68479263,"diff_hunk":"@@ -2,8 +2,10 @@\n // Licensed under the MIT License. See LICENSE in the project root for license information.\n \n \n+using System.Threading;\n+\n namespace Microsoft.Languages.Editor.Host {\n     public interface IIdleTimeService {\n-        void DoIdle();\n+        void DoIdle(Thread thread = null);","path":"src/Common/Core/Impl/Shell/IIdleTimeService.cs","position":9,"original_position":9,"commit_id":"cf34a9914e3deb884ffe99a4ce3e269fd32500db","original_commit_id":"a193479f18fb789dbb8c95e5b3f76937b387b4c8","user":{"login":"AlexanderSher","id":8933858,"avatar_url":"https://avatars.githubusercontent.com/u/8933858?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexanderSher","html_url":"https://github.com/AlexanderSher","followers_url":"https://api.github.com/users/AlexanderSher/followers","following_url":"https://api.github.com/users/AlexanderSher/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderSher/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderSher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderSher/subscriptions","organizations_url":"https://api.github.com/users/AlexanderSher/orgs","repos_url":"https://api.github.com/users/AlexanderSher/repos","events_url":"https://api.github.com/users/AlexanderSher/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderSher/received_events","type":"User","site_admin":false},"body":"Can you explain this change?","created_at":"2016-06-25T00:17:02Z","updated_at":"2016-06-25T00:17:02Z","html_url":"https://github.com/Microsoft/RTVS/pull/2004#discussion_r68479263","pull_request_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/68479263"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2004#discussion_r68479263"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004","id":75150068,"html_url":"https://github.com/Microsoft/RTVS/pull/2004","diff_url":"https://github.com/Microsoft/RTVS/pull/2004.diff","patch_url":"https://github.com/Microsoft/RTVS/pull/2004.patch","issue_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2004","number":2004,"state":"open","locked":false,"title":"Tests stability","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"Apart from https://github.com/Microsoft/RTVS/issues/2001 All tests pass consistently together on my two machines. Changes:\r\n\r\n- Make sure editor tree and documents are disposed of. Otherwise they stay attached to idle and throw when called on wrong thread.\r\n- Idle event can specify which thread to fire at.\r\n- Some tests had hardcoded R 3.2, Now use RInstallation\r\n- RInstallation static didn't work well since registry mocks affected tests that expected real registry when running in parallel\r\n- Export provider should not be disposed since tests dispose it before WPF window is fully closed and all view and editor components are disposed of.\r\n\r\n","created_at":"2016-06-24T17:56:12Z","updated_at":"2016-06-25T00:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2b4b7e10878678518181ff955622dbf2ca446eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004/commits","review_comments_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004/comments","review_comment_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2004/comments","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/cf34a9914e3deb884ffe99a4ce3e269fd32500db","head":{"label":"MikhailArkhipov:Tests","ref":"Tests","sha":"cf34a9914e3deb884ffe99a4ce3e269fd32500db","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"repo":{"id":53517720,"name":"RTVS","full_name":"MikhailArkhipov/RTVS","owner":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikhailArkhipov/RTVS","description":"R Tools for Visual Studio.","fork":true,"url":"https://api.github.com/repos/MikhailArkhipov/RTVS","forks_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/forks","keys_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/teams","hooks_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/hooks","issue_events_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/events","assignees_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/tags","blobs_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/languages","stargazers_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/stargazers","contributors_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/contributors","subscribers_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/subscribers","subscription_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/subscription","commits_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/merges","archive_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/downloads","issues_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/deployments","created_at":"2016-03-09T17:33:45Z","updated_at":"2016-03-09T17:33:51Z","pushed_at":"2016-06-25T00:00:46Z","git_url":"git://github.com/MikhailArkhipov/RTVS.git","ssh_url":"git@github.com:MikhailArkhipov/RTVS.git","clone_url":"https://github.com/MikhailArkhipov/RTVS.git","svn_url":"https://github.com/MikhailArkhipov/RTVS","homepage":null,"size":47786,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"9fe870af2c4e5a85766f6d465facd94e5eaffeef","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38640473,"name":"RTVS","full_name":"Microsoft/RTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/RTVS","description":"R Tools for Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/RTVS","forks_url":"https://api.github.com/repos/Microsoft/RTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/RTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/RTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/RTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/RTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/RTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/RTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/RTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/RTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/RTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/RTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/RTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/RTVS/deployments","created_at":"2015-07-06T19:14:09Z","updated_at":"2016-06-23T19:39:33Z","pushed_at":"2016-06-25T00:00:47Z","git_url":"git://github.com/Microsoft/RTVS.git","ssh_url":"git@github.com:Microsoft/RTVS.git","clone_url":"https://github.com/Microsoft/RTVS.git","svn_url":"https://github.com/Microsoft/RTVS","homepage":null,"size":48004,"stargazers_count":161,"watchers_count":161,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":261,"forks":45,"open_issues":261,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2004"},"issue":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2004"},"comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2004/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2004/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/RTVS/statuses/cf34a9914e3deb884ffe99a4ce3e269fd32500db"}}}}
{"actor":{"display_login":"AlexanderSher"}}