{"action":"created","issue":{"url":"https://api.github.com/repos/yaronn/xml-crypto/issues/99","repository_url":"https://api.github.com/repos/yaronn/xml-crypto","labels_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/99/comments","events_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/99/events","html_url":"https://github.com/yaronn/xml-crypto/pull/99","id":139736932,"number":99,"title":"Fixed normalization of special characters according to spec","user":{"login":"marklagendijk","id":1188039,"avatar_url":"https://avatars.githubusercontent.com/u/1188039?v=3","gravatar_id":"","url":"https://api.github.com/users/marklagendijk","html_url":"https://github.com/marklagendijk","followers_url":"https://api.github.com/users/marklagendijk/followers","following_url":"https://api.github.com/users/marklagendijk/following{/other_user}","gists_url":"https://api.github.com/users/marklagendijk/gists{/gist_id}","starred_url":"https://api.github.com/users/marklagendijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marklagendijk/subscriptions","organizations_url":"https://api.github.com/users/marklagendijk/orgs","repos_url":"https://api.github.com/users/marklagendijk/repos","events_url":"https://api.github.com/users/marklagendijk/events{/privacy}","received_events_url":"https://api.github.com/users/marklagendijk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/yaronn/xml-crypto/labels/need-revision","name":"need-revision","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-09T23:47:50Z","updated_at":"2016-03-11T12:17:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yaronn/xml-crypto/pulls/99","html_url":"https://github.com/yaronn/xml-crypto/pull/99","diff_url":"https://github.com/yaronn/xml-crypto/pull/99.diff","patch_url":"https://github.com/yaronn/xml-crypto/pull/99.patch"},"body":"This is an attempt to fix several issues related to the canocalization of special characters. This fixes #28.\r\n\r\nSee:\r\n- https://www.w3.org/TR/xml-c14n#ProcessingModel (Attribute Nodes, Text Nodes)\r\n- https://www.w3.org/TR/xml-c14n#Example-Chars\r\n\r\nNote: when checking the documentation of c14n or xml, it is very important to make sure you are viewing the latest version. It can happen quite easily that you are reading an outdated spec.\r\n\r\nPinging @cmordue @yaronn @bjrmatos "},"comment":{"url":"https://api.github.com/repos/yaronn/xml-crypto/issues/comments/195346028","html_url":"https://github.com/yaronn/xml-crypto/pull/99#issuecomment-195346028","issue_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/99","id":195346028,"user":{"login":"marklagendijk","id":1188039,"avatar_url":"https://avatars.githubusercontent.com/u/1188039?v=3","gravatar_id":"","url":"https://api.github.com/users/marklagendijk","html_url":"https://github.com/marklagendijk","followers_url":"https://api.github.com/users/marklagendijk/followers","following_url":"https://api.github.com/users/marklagendijk/following{/other_user}","gists_url":"https://api.github.com/users/marklagendijk/gists{/gist_id}","starred_url":"https://api.github.com/users/marklagendijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marklagendijk/subscriptions","organizations_url":"https://api.github.com/users/marklagendijk/orgs","repos_url":"https://api.github.com/users/marklagendijk/repos","events_url":"https://api.github.com/users/marklagendijk/events{/privacy}","received_events_url":"https://api.github.com/users/marklagendijk/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T12:17:08Z","updated_at":"2016-03-11T12:17:08Z","body":"@yaronn, @bjrmatos I hope this can be merged ASAP. The eventual fixes are quite straightforward, proven by references to the relevant documentation, and tested against a reliable third party implementation (xmlsec).\r\nThis pull request will fix most, if not all, issues people have with mismatching digests.\r\n"}}