{"action":"closed","issue":{"url":"https://api.github.com/repos/WordImpress/Give/issues/1181","repository_url":"https://api.github.com/repos/WordImpress/Give","labels_url":"https://api.github.com/repos/WordImpress/Give/issues/1181/labels{/name}","comments_url":"https://api.github.com/repos/WordImpress/Give/issues/1181/comments","events_url":"https://api.github.com/repos/WordImpress/Give/issues/1181/events","html_url":"https://github.com/WordImpress/Give/issues/1181","id":186226190,"number":1181,"title":"a11y: fieldset hierarchy","user":{"login":"ramiy","id":576623,"avatar_url":"https://avatars.githubusercontent.com/u/576623?v=3","gravatar_id":"","url":"https://api.github.com/users/ramiy","html_url":"https://github.com/ramiy","followers_url":"https://api.github.com/users/ramiy/followers","following_url":"https://api.github.com/users/ramiy/following{/other_user}","gists_url":"https://api.github.com/users/ramiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiy/subscriptions","organizations_url":"https://api.github.com/users/ramiy/orgs","repos_url":"https://api.github.com/users/ramiy/repos","events_url":"https://api.github.com/users/ramiy/events{/privacy}","received_events_url":"https://api.github.com/users/ramiy/received_events","type":"User","site_admin":false},"labels":[{"id":273069637,"url":"https://api.github.com/repos/WordImpress/Give/labels/a11y","name":"a11y","color":"bfdadc","default":false},{"id":332627973,"url":"https://api.github.com/repos/WordImpress/Give/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"ramiy","id":576623,"avatar_url":"https://avatars.githubusercontent.com/u/576623?v=3","gravatar_id":"","url":"https://api.github.com/users/ramiy","html_url":"https://github.com/ramiy","followers_url":"https://api.github.com/users/ramiy/followers","following_url":"https://api.github.com/users/ramiy/following{/other_user}","gists_url":"https://api.github.com/users/ramiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiy/subscriptions","organizations_url":"https://api.github.com/users/ramiy/orgs","repos_url":"https://api.github.com/users/ramiy/repos","events_url":"https://api.github.com/users/ramiy/events{/privacy}","received_events_url":"https://api.github.com/users/ramiy/received_events","type":"User","site_admin":false},"assignees":[{"login":"ramiy","id":576623,"avatar_url":"https://avatars.githubusercontent.com/u/576623?v=3","gravatar_id":"","url":"https://api.github.com/users/ramiy","html_url":"https://github.com/ramiy","followers_url":"https://api.github.com/users/ramiy/followers","following_url":"https://api.github.com/users/ramiy/following{/other_user}","gists_url":"https://api.github.com/users/ramiy/gists{/gist_id}","starred_url":"https://api.github.com/users/ramiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramiy/subscriptions","organizations_url":"https://api.github.com/users/ramiy/orgs","repos_url":"https://api.github.com/users/ramiy/repos","events_url":"https://api.github.com/users/ramiy/events{/privacy}","received_events_url":"https://api.github.com/users/ramiy/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WordImpress/Give/milestones/20","html_url":"https://github.com/WordImpress/Give/milestones/1.7","labels_url":"https://api.github.com/repos/WordImpress/Give/milestones/20/labels","id":1702585,"number":20,"title":"1.7","description":"","creator":{"login":"DevinWalker","id":1571635,"avatar_url":"https://avatars.githubusercontent.com/u/1571635?v=3","gravatar_id":"","url":"https://api.github.com/users/DevinWalker","html_url":"https://github.com/DevinWalker","followers_url":"https://api.github.com/users/DevinWalker/followers","following_url":"https://api.github.com/users/DevinWalker/following{/other_user}","gists_url":"https://api.github.com/users/DevinWalker/gists{/gist_id}","starred_url":"https://api.github.com/users/DevinWalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevinWalker/subscriptions","organizations_url":"https://api.github.com/users/DevinWalker/orgs","repos_url":"https://api.github.com/users/DevinWalker/repos","events_url":"https://api.github.com/users/DevinWalker/events{/privacy}","received_events_url":"https://api.github.com/users/DevinWalker/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":62,"state":"open","created_at":"2016-04-12T22:55:51Z","updated_at":"2016-11-02T03:37:08Z","due_on":"2016-11-10T00:00:00Z","closed_at":null},"comments":1,"created_at":"2016-10-31T08:10:07Z","updated_at":"2016-11-02T03:37:08Z","closed_at":"2016-11-02T03:37:08Z","body":"## Issue Overview\r\n\r\nThe `<fieldset>` hierarchy in the donation form needs some love.\r\n\r\nSee the the screenshots and the proposed solution.\r\n\r\n## Current Behavior\r\n\r\n![screenshot 2016-10-31 09 49 07](https://cloud.githubusercontent.com/assets/576623/19847437/87576490-9f4f-11e6-8593-8a079cf3783c.png)\r\n\r\n## Expected Behavior\r\n\r\n![screenshot 2016-10-31 09 51 17](https://cloud.githubusercontent.com/assets/576623/19847470/c8b210ac-9f4f-11e6-9936-9be44fb5080e.png)\r\n\r\n## Why that happens?\r\n\r\nThe `give_terms_agreement()` function, which displays terms agreement fields, hooks to the wrong action.\r\n\r\n## Possible Solution\r\n\r\nReplace this:\r\n\r\n`add_action( 'give_donation_form_before_submit', 'give_terms_agreement', 10, 1 );`\r\n\r\nWith that:\r\n\r\n`add_action( 'give_donation_form_after_cc_form', 'give_terms_agreement', 8888, 1 );`\r\n\r\n**Why this Solution?**\r\n\r\nBecause we already use this action to display the \"Checkout Submit\" section with:\r\n\r\n`add_action( 'give_donation_form_after_cc_form', 'give_checkout_submit', 9999 );`\r\n\r\nThis way, both sections use the same action hook but with different priority. Terms will use 8888, and the checkout will use 9999. This way we control the location of each item on the form.\r\n"}}
{"actor":{"display_login":"DevinWalker"}}