{"action":"opened","number":3581,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3581","id":56271213,"html_url":"https://github.com/minetest/minetest/pull/3581","diff_url":"https://github.com/minetest/minetest/pull/3581.diff","patch_url":"https://github.com/minetest/minetest/pull/3581.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3581","number":3581,"state":"open","locked":false,"title":"Liquid flow: Prevent water spreading on ignore WIP","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"![screenshot_20160117_053200](https://cloud.githubusercontent.com/assets/3686677/12376182/08ed76ce-bcdf-11e5-9ba9-24349ef7864b.png)\r\n\r\n^ Before\r\nv After\r\n\r\n![screenshot_20160117_053829](https://cloud.githubusercontent.com/assets/3686677/12376184/163454f6-bcdf-11e5-9a8a-28f88d0a66e7.png)\r\n\r\nWhen the node below water is 'ignore' the 'flow down' flag is set to true to prevent water spreading outwards on the surface of ignore.\r\nTests were in floatlands by placing a source and watchiing the water column fall down below until it reaches an ungenerated mapchunk and either stops or spreads out.\r\nFlying down to the column base does not start it flowing down again. I experimented with a hacky ABM for updating water nodes to start the column flowing down again (nodeupdate(pos) does not work):\r\n```\r\nminetest.register_abm({\r\n\tnodenames = {\"group:water\"},\r\n\tneighbors = {\"air\"},\r\n\tinterval = 1,\r\n\tchance = 64,\r\n\tcatch_up = false,\r\n\taction = function(pos, node)\r\n\t\tminetest.place_node(pos, {name = node.name})\r\n\tend\r\n})\r\n```\r\nIf updating the water by ABM is eventually done perhpas we need a new API that updates a water node by adding it to the liquid queue?","created_at":"2016-01-17T06:03:54Z","updated_at":"2016-01-17T06:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74bfaa4d1b548840cc1ae3361804b587cdaf0378","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3581/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3581/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3581/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/f63b5b45d180602733c1c087de40464045ef6f35","head":{"label":"paramat:waterignore","ref":"waterignore","sha":"f63b5b45d180602733c1c087de40464045ef6f35","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"repo":{"id":25287736,"name":"minetest","full_name":"paramat/minetest","owner":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paramat/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/paramat/minetest","forks_url":"https://api.github.com/repos/paramat/minetest/forks","keys_url":"https://api.github.com/repos/paramat/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paramat/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paramat/minetest/teams","hooks_url":"https://api.github.com/repos/paramat/minetest/hooks","issue_events_url":"https://api.github.com/repos/paramat/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/paramat/minetest/events","assignees_url":"https://api.github.com/repos/paramat/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/paramat/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/paramat/minetest/tags","blobs_url":"https://api.github.com/repos/paramat/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paramat/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paramat/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/paramat/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paramat/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/paramat/minetest/languages","stargazers_url":"https://api.github.com/repos/paramat/minetest/stargazers","contributors_url":"https://api.github.com/repos/paramat/minetest/contributors","subscribers_url":"https://api.github.com/repos/paramat/minetest/subscribers","subscription_url":"https://api.github.com/repos/paramat/minetest/subscription","commits_url":"https://api.github.com/repos/paramat/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/paramat/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/paramat/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/paramat/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/paramat/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/paramat/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paramat/minetest/merges","archive_url":"https://api.github.com/repos/paramat/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paramat/minetest/downloads","issues_url":"https://api.github.com/repos/paramat/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/paramat/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/paramat/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/paramat/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paramat/minetest/labels{/name}","releases_url":"https://api.github.com/repos/paramat/minetest/releases{/id}","created_at":"2014-10-16T05:25:29Z","updated_at":"2016-01-14T06:22:07Z","pushed_at":"2016-01-17T05:12:02Z","git_url":"git://github.com/paramat/minetest.git","ssh_url":"git@github.com:paramat/minetest.git","clone_url":"https://github.com/paramat/minetest.git","svn_url":"https://github.com/paramat/minetest","homepage":"http://minetest.net/","size":44423,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"22bc66d3a7b96f0742669a988b45d07d58e32928","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2016-01-16T20:12:28Z","pushed_at":"2016-01-17T06:03:54Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":91183,"stargazers_count":1763,"watchers_count":1763,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":585,"mirror_url":null,"open_issues_count":700,"forks":585,"open_issues":700,"watchers":1763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3581"},"html":{"href":"https://github.com/minetest/minetest/pull/3581"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3581"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3581/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3581/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3581/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/f63b5b45d180602733c1c087de40464045ef6f35"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":1}}