{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/84174167","pull_request_review_id":4968297,"id":84174167,"diff_hunk":"@@ -342,6 +344,13 @@ static bool populateOutOfDateMap(InputInfoMap &map, StringRef argsHashStr,\n   }\n \n   if (!optionsMatch) {\n+    if (ShowIncrementalBuildDecisions) {\n+      llvm::outs() << \"Incremental compilation has been disabled, because \"\n+                   << \"different arguments were passed to the compiler.\\n\"\n+                   << \"\\tCompiling with argument hash: \" << argsHashStr << \"\\n\"","path":"lib/Driver/Driver.cpp","position":25,"original_position":25,"commit_id":"a9a2cebc050caf1b07a9d2fcaeb9e95b4f57e266","original_commit_id":"a9a2cebc050caf1b07a9d2fcaeb9e95b4f57e266","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"I guess we could just store the old argument list verbatim, in addition to the hash? The only time you'll see it is when you change something that does affect the output.","created_at":"2016-10-19T21:45:15Z","updated_at":"2016-10-19T21:45:15Z","html_url":"https://github.com/apple/swift/pull/5336#discussion_r84174167","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/5336","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/84174167"},"html":{"href":"https://github.com/apple/swift/pull/5336#discussion_r84174167"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/5336"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5336","id":89723871,"html_url":"https://github.com/apple/swift/pull/5336","diff_url":"https://github.com/apple/swift/pull/5336.diff","patch_url":"https://github.com/apple/swift/pull/5336.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5336","number":5336,"state":"open","locked":false,"title":"[SR-2855] Show args mismatch in -driver-show-incremental","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nSR-2855 suggests `-driver-show-incremental` not only print information about why certain files are included in incremental compilation, but also print out why incremental compilation may be disabled altogether.\r\n\r\nAdd a message for one such reason: when the arguments passed to the Swift compiler don't match the ones used previously.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nThis addresses one part of [SR-2855](https://bugs.swift.org/browse/SR-2855).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n","created_at":"2016-10-17T23:46:56Z","updated_at":"2016-10-19T21:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"700f3d5f4e5ee1a7f7fdb1afd742b052860f57d5","assignee":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5336/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5336/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5336/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/a9a2cebc050caf1b07a9d2fcaeb9e95b4f57e266","head":{"label":"modocache:sr-2855-driver-show-incremental-args","ref":"sr-2855-driver-show-incremental-args","sha":"a9a2cebc050caf1b07a9d2fcaeb9e95b4f57e266","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"repo":{"id":47582695,"name":"swift","full_name":"modocache/swift","owner":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/modocache/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/modocache/swift","forks_url":"https://api.github.com/repos/modocache/swift/forks","keys_url":"https://api.github.com/repos/modocache/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modocache/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modocache/swift/teams","hooks_url":"https://api.github.com/repos/modocache/swift/hooks","issue_events_url":"https://api.github.com/repos/modocache/swift/issues/events{/number}","events_url":"https://api.github.com/repos/modocache/swift/events","assignees_url":"https://api.github.com/repos/modocache/swift/assignees{/user}","branches_url":"https://api.github.com/repos/modocache/swift/branches{/branch}","tags_url":"https://api.github.com/repos/modocache/swift/tags","blobs_url":"https://api.github.com/repos/modocache/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modocache/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modocache/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/modocache/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modocache/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/modocache/swift/languages","stargazers_url":"https://api.github.com/repos/modocache/swift/stargazers","contributors_url":"https://api.github.com/repos/modocache/swift/contributors","subscribers_url":"https://api.github.com/repos/modocache/swift/subscribers","subscription_url":"https://api.github.com/repos/modocache/swift/subscription","commits_url":"https://api.github.com/repos/modocache/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/modocache/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/modocache/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/modocache/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/modocache/swift/contents/{+path}","compare_url":"https://api.github.com/repos/modocache/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modocache/swift/merges","archive_url":"https://api.github.com/repos/modocache/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modocache/swift/downloads","issues_url":"https://api.github.com/repos/modocache/swift/issues{/number}","pulls_url":"https://api.github.com/repos/modocache/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/modocache/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/modocache/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modocache/swift/labels{/name}","releases_url":"https://api.github.com/repos/modocache/swift/releases{/id}","deployments_url":"https://api.github.com/repos/modocache/swift/deployments","created_at":"2015-12-07T22:16:48Z","updated_at":"2016-04-01T19:24:05Z","pushed_at":"2016-10-19T19:13:42Z","git_url":"git://github.com/modocache/swift.git","ssh_url":"git@github.com:modocache/swift.git","clone_url":"https://github.com/modocache/swift.git","svn_url":"https://github.com/modocache/swift","homepage":"","size":120890,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"14b689dee1dcd4e5e7a8b5722ce343a57e10149d","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-10-19T20:49:42Z","pushed_at":"2016-10-19T21:34:31Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":190341,"stargazers_count":34605,"watchers_count":34605,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4969,"mirror_url":null,"open_issues_count":106,"forks":4969,"open_issues":106,"watchers":34605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5336"},"html":{"href":"https://github.com/apple/swift/pull/5336"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5336"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5336/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5336/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5336/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/a9a2cebc050caf1b07a9d2fcaeb9e95b4f57e266"}}}}
{"actor":{"display_login":"jrose-apple"}}