{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments/74599827","id":74599827,"diff_hunk":"@@ -118,16 +122,18 @@ end\n function _logpdf{T<:Real}(d::Multinomial, x::AbstractVector{T})\n     p = probs(d)\n     n = ntrials(d)\n-    s = lgamma(n + 1.0)\n-    t = 0\n+    S = eltype(p)\n+    R = promote_type(T, S)\n+    s = R(lgamma(n + 1))","path":"src/multivariate/multinomial.jl","position":109,"original_position":109,"commit_id":"35cc11b0c63da3428ad878d3aea5f416693aa338","original_commit_id":"35cc11b0c63da3428ad878d3aea5f416693aa338","user":{"login":"jmxpearson","id":3165415,"avatar_url":"https://avatars.githubusercontent.com/u/3165415?v=3","gravatar_id":"","url":"https://api.github.com/users/jmxpearson","html_url":"https://github.com/jmxpearson","followers_url":"https://api.github.com/users/jmxpearson/followers","following_url":"https://api.github.com/users/jmxpearson/following{/other_user}","gists_url":"https://api.github.com/users/jmxpearson/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxpearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxpearson/subscriptions","organizations_url":"https://api.github.com/users/jmxpearson/orgs","repos_url":"https://api.github.com/users/jmxpearson/repos","events_url":"https://api.github.com/users/jmxpearson/events{/privacy}","received_events_url":"https://api.github.com/users/jmxpearson/received_events","type":"User","site_admin":false},"body":"Except `p` must be a probability vector, so we can't have `S <: Integer`.","created_at":"2016-08-12T14:27:42Z","updated_at":"2016-08-12T14:27:42Z","html_url":"https://github.com/JuliaStats/Distributions.jl/pull/522#discussion_r74599827","pull_request_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522","_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments/74599827"},"html":{"href":"https://github.com/JuliaStats/Distributions.jl/pull/522#discussion_r74599827"},"pull_request":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522","id":80691067,"html_url":"https://github.com/JuliaStats/Distributions.jl/pull/522","diff_url":"https://github.com/JuliaStats/Distributions.jl/pull/522.diff","patch_url":"https://github.com/JuliaStats/Distributions.jl/pull/522.patch","issue_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/522","number":522,"state":"closed","locked":false,"title":"more parametric distributions","user":{"login":"jmxpearson","id":3165415,"avatar_url":"https://avatars.githubusercontent.com/u/3165415?v=3","gravatar_id":"","url":"https://api.github.com/users/jmxpearson","html_url":"https://github.com/jmxpearson","followers_url":"https://api.github.com/users/jmxpearson/followers","following_url":"https://api.github.com/users/jmxpearson/following{/other_user}","gists_url":"https://api.github.com/users/jmxpearson/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxpearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxpearson/subscriptions","organizations_url":"https://api.github.com/users/jmxpearson/orgs","repos_url":"https://api.github.com/users/jmxpearson/repos","events_url":"https://api.github.com/users/jmxpearson/events{/privacy}","received_events_url":"https://api.github.com/users/jmxpearson/received_events","type":"User","site_admin":false},"body":"This PR encompasses two sets of changes:\r\n- fleshing out conversions (with tests) for multivariate and matrix-variate distributions that had already been parameterized\r\n- adding the last unparameterized multivariates:\r\n  - `MvLogNormal`\r\n  - `Multinomial`\r\n  - `VonMisesFisher`\r\n\r\nOn the roadmap to fully parametric, there remains:\r\n\r\n1. Fixing remaining hardcoded `Float64`s. In particular:\r\n  - aliases like `ZeroMeanIsoNormal` in the multivariates\r\n  - code for computing MLEs, where type stability is trickier to think through\r\n1. Truncated distributions\r\n1. Mixtures (though I was under the impression that these were moving out; should this be a priority?)","created_at":"2016-08-09T20:44:00Z","updated_at":"2016-08-12T14:27:43Z","closed_at":"2016-08-12T14:01:10Z","merged_at":"2016-08-12T14:01:10Z","merge_commit_sha":"d368823bf8a2ca4d776e6a43b3fd6b0cbaef191a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522/commits","review_comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522/comments","review_comment_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/522/comments","statuses_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/35cc11b0c63da3428ad878d3aea5f416693aa338","head":{"label":"JuliaStats:jp/moreparams","ref":"jp/moreparams","sha":"35cc11b0c63da3428ad878d3aea5f416693aa338","user":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":6619192,"name":"Distributions.jl","full_name":"JuliaStats/Distributions.jl","owner":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaStats/Distributions.jl","description":"A Julia package for probability distributions and associated functions.","fork":false,"url":"https://api.github.com/repos/JuliaStats/Distributions.jl","forks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/deployments","created_at":"2012-11-09T20:01:33Z","updated_at":"2016-08-11T14:44:11Z","pushed_at":"2016-08-12T14:01:14Z","git_url":"git://github.com/JuliaStats/Distributions.jl.git","ssh_url":"git@github.com:JuliaStats/Distributions.jl.git","clone_url":"https://github.com/JuliaStats/Distributions.jl.git","svn_url":"https://github.com/JuliaStats/Distributions.jl","homepage":"","size":2708,"stargazers_count":192,"watchers_count":192,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":123,"mirror_url":null,"open_issues_count":82,"forks":123,"open_issues":82,"watchers":192,"default_branch":"master"}},"base":{"label":"JuliaStats:master","ref":"master","sha":"b4c303e4409380846f652a7a1cf1cb815985811e","user":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":6619192,"name":"Distributions.jl","full_name":"JuliaStats/Distributions.jl","owner":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaStats/Distributions.jl","description":"A Julia package for probability distributions and associated functions.","fork":false,"url":"https://api.github.com/repos/JuliaStats/Distributions.jl","forks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/deployments","created_at":"2012-11-09T20:01:33Z","updated_at":"2016-08-11T14:44:11Z","pushed_at":"2016-08-12T14:01:14Z","git_url":"git://github.com/JuliaStats/Distributions.jl.git","ssh_url":"git@github.com:JuliaStats/Distributions.jl.git","clone_url":"https://github.com/JuliaStats/Distributions.jl.git","svn_url":"https://github.com/JuliaStats/Distributions.jl","homepage":"","size":2708,"stargazers_count":192,"watchers_count":192,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":123,"mirror_url":null,"open_issues_count":82,"forks":123,"open_issues":82,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522"},"html":{"href":"https://github.com/JuliaStats/Distributions.jl/pull/522"},"issue":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/522"},"comments":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/522/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/522/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/35cc11b0c63da3428ad878d3aea5f416693aa338"}}}}
{"actor":{"display_login":"jmxpearson"}}