{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/66609392","id":66609392,"diff_hunk":"@@ -1,19 +1,205 @@\n #include <mbgl/test/util.hpp>\n #include <mbgl/style/layers/background_layer.hpp>\n #include <mbgl/style/layers/background_layer_impl.hpp>\n+#include <mbgl/style/layers/circle_layer.hpp>\n+#include <mbgl/style/layers/circle_layer_impl.hpp>\n+#include <mbgl/style/layers/custom_layer.hpp>\n+#include <mbgl/style/layers/custom_layer_impl.hpp>\n+#include <mbgl/style/layers/fill_layer.hpp>\n+#include <mbgl/style/layers/fill_layer_impl.hpp>\n+#include <mbgl/style/layers/line_layer.hpp>\n+#include <mbgl/style/layers/line_layer_impl.hpp>\n+#include <mbgl/style/layers/raster_layer.hpp>\n+#include <mbgl/style/layers/raster_layer_impl.hpp>\n+#include <mbgl/style/layers/symbol_layer.hpp>\n+#include <mbgl/style/layers/symbol_layer_impl.hpp>\n \n using namespace mbgl;\n using namespace mbgl::style;\n \n-TEST(Layer, Clone) {\n-    std::unique_ptr<Layer> layer = std::make_unique<BackgroundLayer>(\"id\");\n-    std::unique_ptr<Layer> clone = layer->baseImpl->clone();\n-    EXPECT_NE(layer.get(), clone.get());\n-    EXPECT_TRUE(reinterpret_cast<BackgroundLayer::Impl*>(clone->baseImpl.get()));\n-}\n+namespace {\n \n-TEST(Layer, CloneCopiesBaseProperties) {\n-    std::unique_ptr<BackgroundLayer> layer = std::make_unique<BackgroundLayer>(\"id\");\n+template <class T, class... Params> void testClone(Params... params) {\n+    auto layer = std::make_unique<T>(std::forward<Params>(params)...);\n+    auto clone = layer->baseImpl->clone();\n+    EXPECT_NE(layer.get(), clone.get());\n+    EXPECT_TRUE(reinterpret_cast<typename T::Impl*>(clone->baseImpl.get()));\n     layer->impl->id = \"test\";\n     EXPECT_EQ(\"test\", layer->baseImpl->clone()->getID());\n }\n+\n+auto color = PropertyValue<Color> {{{ 1, 0, 0, 1 }}};","path":"test/style/style_layer.cpp","position":39,"original_position":39,"commit_id":"bbe0a3af786ed1199c4b8db1a119c919217fbd3a","original_commit_id":"bbe0a3af786ed1199c4b8db1a119c919217fbd3a","user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"body":"Yep :+1: ","created_at":"2016-06-10T13:07:19Z","updated_at":"2016-06-10T13:07:19Z","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/5308#discussion_r66609392","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/66609392"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/5308#discussion_r66609392"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308","id":73365005,"html_url":"https://github.com/mapbox/mapbox-gl-native/pull/5308","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/5308.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/5308.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5308","number":5308,"state":"open","locked":false,"title":"[test] Added style layer properties utests","user":{"login":"brunoabinader","id":76133,"avatar_url":"https://avatars.githubusercontent.com/u/76133?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoabinader","html_url":"https://github.com/brunoabinader","followers_url":"https://api.github.com/users/brunoabinader/followers","following_url":"https://api.github.com/users/brunoabinader/following{/other_user}","gists_url":"https://api.github.com/users/brunoabinader/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoabinader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoabinader/subscriptions","organizations_url":"https://api.github.com/users/brunoabinader/orgs","repos_url":"https://api.github.com/users/brunoabinader/repos","events_url":"https://api.github.com/users/brunoabinader/events{/privacy}","received_events_url":"https://api.github.com/users/brunoabinader/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-10T12:21:27Z","updated_at":"2016-06-10T13:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a87c326775f2d52c481415ef6b245f27574fbcdd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5308/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/bbe0a3af786ed1199c4b8db1a119c919217fbd3a","head":{"label":"mapbox:brunoabinader-stylelayer-utests","ref":"brunoabinader-stylelayer-utests","sha":"bbe0a3af786ed1199c4b8db1a119c919217fbd3a","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Render Mapbox styles in mobile, desktop, and node applications using C++ and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2016-06-10T11:38:07Z","pushed_at":"2016-06-10T12:21:27Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":103666,"stargazers_count":1312,"watchers_count":1312,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"open_issues_count":488,"forks":355,"open_issues":488,"watchers":1312,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"ca8b26bbf669905ef73aa0b27c753e5f18dd26e6","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Render Mapbox styles in mobile, desktop, and node applications using C++ and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2016-06-10T11:38:07Z","pushed_at":"2016-06-10T12:21:27Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":103666,"stargazers_count":1312,"watchers_count":1312,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"open_issues_count":488,"forks":355,"open_issues":488,"watchers":1312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/5308"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5308"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/5308/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/5308/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/bbe0a3af786ed1199c4b8db1a119c919217fbd3a"}}}}
{"actor":{"display_login":"brunoabinader"}}