{"action":"created","issue":{"url":"https://api.github.com/repos/ccrama/Slide/issues/1590","repository_url":"https://api.github.com/repos/ccrama/Slide","labels_url":"https://api.github.com/repos/ccrama/Slide/issues/1590/labels{/name}","comments_url":"https://api.github.com/repos/ccrama/Slide/issues/1590/comments","events_url":"https://api.github.com/repos/ccrama/Slide/issues/1590/events","html_url":"https://github.com/ccrama/Slide/pull/1590","id":151373313,"number":1590,"title":"Make sure we have a valid position to scroll when using PreCachingLayoutManager (fixes #1196)","user":{"login":"seizonsenryaku","id":10538982,"avatar_url":"https://avatars.githubusercontent.com/u/10538982?v=3","gravatar_id":"","url":"https://api.github.com/users/seizonsenryaku","html_url":"https://github.com/seizonsenryaku","followers_url":"https://api.github.com/users/seizonsenryaku/followers","following_url":"https://api.github.com/users/seizonsenryaku/following{/other_user}","gists_url":"https://api.github.com/users/seizonsenryaku/gists{/gist_id}","starred_url":"https://api.github.com/users/seizonsenryaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seizonsenryaku/subscriptions","organizations_url":"https://api.github.com/users/seizonsenryaku/orgs","repos_url":"https://api.github.com/users/seizonsenryaku/repos","events_url":"https://api.github.com/users/seizonsenryaku/events{/privacy}","received_events_url":"https://api.github.com/users/seizonsenryaku/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-04-27T12:30:38Z","updated_at":"2016-04-27T16:25:58Z","closed_at":"2016-04-27T14:39:41Z","pull_request":{"url":"https://api.github.com/repos/ccrama/Slide/pulls/1590","html_url":"https://github.com/ccrama/Slide/pull/1590","diff_url":"https://github.com/ccrama/Slide/pull/1590.diff","patch_url":"https://github.com/ccrama/Slide/pull/1590.patch"},"body":"LinearLayoutManager.findFirstCompletelyVisibleItemPosition() position is orientation dependent and seems to return the constant NO_POSITION on some cases onConfigurationChanged. \r\nIf that happens, use findFirstVisibleItemPosition() instead.\r\nThis fixes #1196."},"comment":{"url":"https://api.github.com/repos/ccrama/Slide/issues/comments/215138479","html_url":"https://github.com/ccrama/Slide/pull/1590#issuecomment-215138479","issue_url":"https://api.github.com/repos/ccrama/Slide/issues/1590","id":215138479,"user":{"login":"bantar","id":16184500,"avatar_url":"https://avatars.githubusercontent.com/u/16184500?v=3","gravatar_id":"","url":"https://api.github.com/users/bantar","html_url":"https://github.com/bantar","followers_url":"https://api.github.com/users/bantar/followers","following_url":"https://api.github.com/users/bantar/following{/other_user}","gists_url":"https://api.github.com/users/bantar/gists{/gist_id}","starred_url":"https://api.github.com/users/bantar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantar/subscriptions","organizations_url":"https://api.github.com/users/bantar/orgs","repos_url":"https://api.github.com/users/bantar/repos","events_url":"https://api.github.com/users/bantar/events{/privacy}","received_events_url":"https://api.github.com/users/bantar/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T16:25:58Z","updated_at":"2016-04-27T16:25:58Z","body":"Nice work seizonsenryaku!   Thanks for finding this.   And thanks to ccrama for keeping it open and looking too and deploying a fix.   I'll test it as soon as it's pushed to Alpha and report back.\r\n\r\n> there isn't a single submission view that is entirely visible on screen (the screen contains either two or one partial submission views),\r\n\r\nWhen I rotate to H, I've noticed that there is almost never a single image showing in the view.  The only reason that I noticed this is because the target picture is often almost always off the screen by 50-80%, after rotation, making me need to scroll a bit before clicking on it.    \r\n\r\nLooking at this closer, when there is an imgur image, the best I can get to show on the screen, when H, is about 90% of one post.   I'd say the slide header takes up 35-40% of the screen, then the picture is shown taking up the other 60-65% and the title text and various buttons are off the bottom of the screen.   If I scroll up, the slide header collapses to about 15-20% and even with a 1 line title, I don't see the full post.   The bottom button row is always clipped.   So, I conclude that my phone can never display a single full image post when H.\r\n\r\nI'm downloading an update now."}}