{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/8390","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/8390/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/8390/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/8390/events","html_url":"https://github.com/ceph/ceph/pull/8390","id":144841539,"number":8390,"title":"osd: drop map_lock during tick to reduce look contention","user":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0052cc"},{"url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ceph/ceph/milestones/9","html_url":"https://github.com/ceph/ceph/milestones/kraken","labels_url":"https://api.github.com/repos/ceph/ceph/milestones/9/labels","id":1642631,"number":9,"title":"kraken","description":"","creator":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2016-03-14T12:28:24Z","updated_at":"2016-04-04T19:24:26Z","due_on":"2016-08-01T04:00:00Z","closed_at":null},"comments":4,"created_at":"2016-03-31T09:27:55Z","updated_at":"2016-04-05T04:31:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/8390","html_url":"https://github.com/ceph/ceph/pull/8390","diff_url":"https://github.com/ceph/ceph/pull/8390.diff","patch_url":"https://github.com/ceph/ceph/pull/8390.patch"},"body":"    Because in tick() procedure, we already have osd_lock in hand\r\n    to prevent osdmap from changing. Therefore we don't need to\r\n    acquire map_lock again in order to call maybe_update_heartbeat_peers(),\r\n    which is a pure waste and may cause lock concentration as the\r\n    tick_without_osd_lock periodically need the same lock too.\r\n    \r\n    Only when called from tick_without_osd_lock() or queue_want_up_thru()\r\n    from the peeringWQ, we shall require the map_lock in hand to safely access\r\n    osdmap as we don't with osd_lock held in those cases.\r\n    \r\n    Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/205639847","html_url":"https://github.com/ceph/ceph/pull/8390#issuecomment-205639847","issue_url":"https://api.github.com/repos/ceph/ceph/issues/8390","id":205639847,"user":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T04:31:12Z","updated_at":"2016-04-05T04:31:12Z","body":"@tchaikov Ping"}}