{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7908","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7908/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7908/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7908/events","html_url":"https://github.com/Automattic/wp-calypso/pull/7908","id":175494099,"number":7908,"title":"GuidedTours: (blanket) exit by guessing user intent","user":{"login":"lsinger","id":23619,"avatar_url":"https://avatars.githubusercontent.com/u/23619?v=3","gravatar_id":"","url":"https://api.github.com/users/lsinger","html_url":"https://github.com/lsinger","followers_url":"https://api.github.com/users/lsinger/followers","following_url":"https://api.github.com/users/lsinger/following{/other_user}","gists_url":"https://api.github.com/users/lsinger/gists{/gist_id}","starred_url":"https://api.github.com/users/lsinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsinger/subscriptions","organizations_url":"https://api.github.com/users/lsinger/orgs","repos_url":"https://api.github.com/users/lsinger/repos","events_url":"https://api.github.com/users/lsinger/events{/privacy}","received_events_url":"https://api.github.com/users/lsinger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/GuidedTours","name":"GuidedTours","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"lsinger","id":23619,"avatar_url":"https://avatars.githubusercontent.com/u/23619?v=3","gravatar_id":"","url":"https://api.github.com/users/lsinger","html_url":"https://github.com/lsinger","followers_url":"https://api.github.com/users/lsinger/followers","following_url":"https://api.github.com/users/lsinger/following{/other_user}","gists_url":"https://api.github.com/users/lsinger/gists{/gist_id}","starred_url":"https://api.github.com/users/lsinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsinger/subscriptions","organizations_url":"https://api.github.com/users/lsinger/orgs","repos_url":"https://api.github.com/users/lsinger/repos","events_url":"https://api.github.com/users/lsinger/events{/privacy}","received_events_url":"https://api.github.com/users/lsinger/received_events","type":"User","site_admin":false},"assignees":[{"login":"lsinger","id":23619,"avatar_url":"https://avatars.githubusercontent.com/u/23619?v=3","gravatar_id":"","url":"https://api.github.com/users/lsinger","html_url":"https://github.com/lsinger","followers_url":"https://api.github.com/users/lsinger/followers","following_url":"https://api.github.com/users/lsinger/following{/other_user}","gists_url":"https://api.github.com/users/lsinger/gists{/gist_id}","starred_url":"https://api.github.com/users/lsinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsinger/subscriptions","organizations_url":"https://api.github.com/users/lsinger/orgs","repos_url":"https://api.github.com/users/lsinger/repos","events_url":"https://api.github.com/users/lsinger/events{/privacy}","received_events_url":"https://api.github.com/users/lsinger/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/90","html_url":"https://github.com/Automattic/wp-calypso/milestones/GuidedTours%20M3:%20Multitours","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/90/labels","id":1768696,"number":90,"title":"GuidedTours M3: Multitours","description":"Multiple tours, contextual tour triggers.","creator":{"login":"ehg","id":215074,"avatar_url":"https://avatars.githubusercontent.com/u/215074?v=3","gravatar_id":"","url":"https://api.github.com/users/ehg","html_url":"https://github.com/ehg","followers_url":"https://api.github.com/users/ehg/followers","following_url":"https://api.github.com/users/ehg/following{/other_user}","gists_url":"https://api.github.com/users/ehg/gists{/gist_id}","starred_url":"https://api.github.com/users/ehg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehg/subscriptions","organizations_url":"https://api.github.com/users/ehg/orgs","repos_url":"https://api.github.com/users/ehg/repos","events_url":"https://api.github.com/users/ehg/events{/privacy}","received_events_url":"https://api.github.com/users/ehg/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":21,"state":"open","created_at":"2016-05-16T13:38:13Z","updated_at":"2016-10-05T14:23:34Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-09-07T12:49:55Z","updated_at":"2016-10-10T15:56:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/7908","html_url":"https://github.com/Automattic/wp-calypso/pull/7908","diff_url":"https://github.com/Automattic/wp-calypso/pull/7908.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/7908.patch"},"body":"Sometimes, a user just wants to navigate away from a Guided Tour without necessarily clicking the correct \"Exit Tour\" button. Still, we'd like to quit in those cases where user intent is reasonably clear.\r\n\r\nThis change quits a currently running tour in the following cases:\r\n\r\n- The step has a \"target\" element that it points to or expects an interaction with, but the user navigates to a new route where the target isn't available anymore.\r\n- The step waits for the user the click \"Next\", but the user navigates to a different route.\r\n\r\nThis doesn't work in all cases. We'd rather have false negatives (trouble quitting a tour without clicking the \"Exit Tour\" button) than any false positives (unintended quits).\r\n\r\nThis closes #5787 and #5861. \r\n\r\nTo test:\r\n\r\n- go to http://calypso.localhost:3000/?tour=main or https://calypso.live/?branch=add/guided-tours-blanket-exit-only&tour=main\r\n- click on \"My Sites\"\r\n- ensure the tour doesn't appear again\r\n- go back to http://calypso.localhost:3000/?tour=main or https://calypso.live/?branch=add/guided-tours-blanket-exit-only&tour=main (with a proper new load or reload)\r\n- click through the tour until the step that says \"This shows your currently selected site's name and address. Click your site's name to continue.\"\r\n- click on \"Reader\"\r\n- ensure the tour doesn't appear again\r\n- go back to http://calypso.localhost:3000/?tour=main or https://calypso.live/?branch=add/guided-tours-blanket-exit-only&tour=main (with a proper new load or reload)\r\n- go through the tour normally, following all the instructions\r\n- ensure the tour steps all work and you get to the step that says \"That's it! Now that you know a few of the basics, feel free to wander around.\" at the end\r\n\r\nTest live: https://calypso.live/?branch=add/guided-tours-blanket-exit-only"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/252663548","html_url":"https://github.com/Automattic/wp-calypso/pull/7908#issuecomment-252663548","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7908","id":252663548,"user":{"login":"lsinger","id":23619,"avatar_url":"https://avatars.githubusercontent.com/u/23619?v=3","gravatar_id":"","url":"https://api.github.com/users/lsinger","html_url":"https://github.com/lsinger","followers_url":"https://api.github.com/users/lsinger/followers","following_url":"https://api.github.com/users/lsinger/following{/other_user}","gists_url":"https://api.github.com/users/lsinger/gists{/gist_id}","starred_url":"https://api.github.com/users/lsinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsinger/subscriptions","organizations_url":"https://api.github.com/users/lsinger/orgs","repos_url":"https://api.github.com/users/lsinger/repos","events_url":"https://api.github.com/users/lsinger/events{/privacy}","received_events_url":"https://api.github.com/users/lsinger/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T15:56:07Z","updated_at":"2016-10-10T15:56:07Z","body":"OK, I *can* reproduce problem no. 1. \r\n\r\nThe — or at least *one* — problem seems to be: `this.section` and `lastAction.path` regularly point to the same thing. E.g. when I start on `/?tour=main` and then click `My Sites`, I'll have `/stats` for `this.section` and `/stats/...` for `lastAction.path`.\r\n\r\nIs maybe `lastAction` assigned too early? Is it currently kind of the \"current action\" instead of the \"previous action\"? \r\n\r\n/cc @mcsf in case you remember what exactly we were thinking"}}
{"actor":{"display_login":"lsinger"}}