{"action":"created","issue":{"url":"https://api.github.com/repos/OfficeDev/PnP-JS-Core/issues/185","repository_url":"https://api.github.com/repos/OfficeDev/PnP-JS-Core","labels_url":"https://api.github.com/repos/OfficeDev/PnP-JS-Core/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/OfficeDev/PnP-JS-Core/issues/185/comments","events_url":"https://api.github.com/repos/OfficeDev/PnP-JS-Core/issues/185/events","html_url":"https://github.com/OfficeDev/PnP-JS-Core/issues/185","id":173292698,"number":185,"title":"Missing node-fetch in rendered SPFx client-side web-part","user":{"login":"SPDoctor","id":10207194,"avatar_url":"https://avatars.githubusercontent.com/u/10207194?v=3","gravatar_id":"","url":"https://api.github.com/users/SPDoctor","html_url":"https://github.com/SPDoctor","followers_url":"https://api.github.com/users/SPDoctor/followers","following_url":"https://api.github.com/users/SPDoctor/following{/other_user}","gists_url":"https://api.github.com/users/SPDoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/SPDoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SPDoctor/subscriptions","organizations_url":"https://api.github.com/users/SPDoctor/orgs","repos_url":"https://api.github.com/users/SPDoctor/repos","events_url":"https://api.github.com/users/SPDoctor/events{/privacy}","received_events_url":"https://api.github.com/users/SPDoctor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-25T19:47:27Z","updated_at":"2016-08-26T09:13:06Z","closed_at":null,"body":"#### Category\r\n[ ] Enhancement\r\n\r\n[X ] Bug\r\n\r\n[ ] Question\r\n\r\n#### Expected / Desired Behavior / Question\r\nDependencies such as node-fetch should be installed when the npm package is installed.\r\n\r\n#### Observed Behavior\r\nOn building an SPFx client-side web-part using sp-pnp-js library I get a runtime error in the rendered web part that the module node-fetch is missing. \r\n\r\n![image](https://cloud.githubusercontent.com/assets/10207194/17985454/c59c7554-6b0d-11e6-8a79-210daacd7f1b.png)\r\n\r\n\r\n#### Steps to Reproduce\r\nCreate a client-side web-part using **yo @microsoft/sharepoint**. Add pnp-JS-Core library using **npm install --save sp-pnp-js**. Reference sp-pnp-js in the web part. Test the web part in the workbench using **gulp serve**.\r\n\r\n#### Workaround\r\nIf I run **npm install --save node-fetch** the problem goes away. Should node-fetch be moved from devDependencies to dependencies?"},"comment":{"url":"https://api.github.com/repos/OfficeDev/PnP-JS-Core/issues/comments/242675420","html_url":"https://github.com/OfficeDev/PnP-JS-Core/issues/185#issuecomment-242675420","issue_url":"https://api.github.com/repos/OfficeDev/PnP-JS-Core/issues/185","id":242675420,"user":{"login":"johnnliu","id":1279372,"avatar_url":"https://avatars.githubusercontent.com/u/1279372?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnliu","html_url":"https://github.com/johnnliu","followers_url":"https://api.github.com/users/johnnliu/followers","following_url":"https://api.github.com/users/johnnliu/following{/other_user}","gists_url":"https://api.github.com/users/johnnliu/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnliu/subscriptions","organizations_url":"https://api.github.com/users/johnnliu/orgs","repos_url":"https://api.github.com/users/johnnliu/repos","events_url":"https://api.github.com/users/johnnliu/events{/privacy}","received_events_url":"https://api.github.com/users/johnnliu/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T09:13:06Z","updated_at":"2016-08-26T09:13:06Z","body":"Change to \r\n\r\n`    \"./lib/net/nodefetchclient.js\": \"./lib/net/nodefetchclientbrowser.js\"\r\n`\r\n\r\nSeems to fix it for me."}}
{"actor":{"display_login":"johnnliu"}}