{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/9439","repository_url":"https://api.github.com/repos/Microsoft/TypeScript","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/9439/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/9439/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/9439/events","html_url":"https://github.com/Microsoft/TypeScript/pull/9439","id":163134522,"number":9439,"title":"Use sorcery to merge sourcemaps between browserify and gulp-typescript","user":{"login":"weswigham","id":2932786,"avatar_url":"https://avatars.githubusercontent.com/u/2932786?v=3","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/TypeScript/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-30T10:38:17Z","updated_at":"2016-07-07T23:16:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/9439","html_url":"https://github.com/Microsoft/TypeScript/pull/9439","diff_url":"https://github.com/Microsoft/TypeScript/pull/9439.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/9439.patch"},"body":"Yesterday @sandersn and @andy-ms both mentioned that their sourcemaps for in-browser debugging seemed off. I checked, and despite loading in the correct files, the maps were indeed off by around 1 line in most places! After looking into it, I determined it was because we were never integrating any sourcemaps from the browserify transform step of the browser tests build. Now, browserify doesn't ingest sourcemaps from the incoming stream particularly well (or at all), so I extracted the single-stage sourcemaps it makes and merged two two layers of sourcemaps using a library called `sorcery`. I've tried combining them using `vinyl-sourcemaps-apply` and `combine-source-maps` (more popular libraries), but it seems like those libraries are focused more for concatenation, not redirection/layering - for some reason neither of them actually merge both the actual sourcemaps and source files list correctly (whereas `sorcery` does, with a little coercion).\r\n\r\n@rbuckton You typically have opinions on all things gulp - do you have any suggestions/feedback here?\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/231235191","html_url":"https://github.com/Microsoft/TypeScript/pull/9439#issuecomment-231235191","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/9439","id":231235191,"user":{"login":"sandersn","id":293473,"avatar_url":"https://avatars.githubusercontent.com/u/293473?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersn","html_url":"https://github.com/sandersn","followers_url":"https://api.github.com/users/sandersn/followers","following_url":"https://api.github.com/users/sandersn/following{/other_user}","gists_url":"https://api.github.com/users/sandersn/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersn/subscriptions","organizations_url":"https://api.github.com/users/sandersn/orgs","repos_url":"https://api.github.com/users/sandersn/repos","events_url":"https://api.github.com/users/sandersn/events{/privacy}","received_events_url":"https://api.github.com/users/sandersn/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T23:16:11Z","updated_at":"2016-07-07T23:16:11Z","body":":+1: -- works for me. 1 minor nit about the conditional left."}}
{"actor":{"display_login":"sandersn"}}