{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2070","repository_url":"https://api.github.com/repos/jenkinsci/jenkins","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2070/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2070/comments","events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2070/events","html_url":"https://github.com/jenkinsci/jenkins/pull/2070","id":137274331,"number":2070,"title":"[JENKINS-32393] Don't pass the whole build.environment to launcher as env overrides","user":{"login":"ndeloof","id":132757,"avatar_url":"https://avatars.githubusercontent.com/u/132757?v=3","gravatar_id":"","url":"https://api.github.com/users/ndeloof","html_url":"https://github.com/ndeloof","followers_url":"https://api.github.com/users/ndeloof/followers","following_url":"https://api.github.com/users/ndeloof/following{/other_user}","gists_url":"https://api.github.com/users/ndeloof/gists{/gist_id}","starred_url":"https://api.github.com/users/ndeloof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndeloof/subscriptions","organizations_url":"https://api.github.com/users/ndeloof/orgs","repos_url":"https://api.github.com/users/ndeloof/repos","events_url":"https://api.github.com/users/ndeloof/events{/privacy}","received_events_url":"https://api.github.com/users/ndeloof/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/jenkins/labels/needs-review","name":"needs-review","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-29T14:45:32Z","updated_at":"2016-04-10T11:54:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2070","html_url":"https://github.com/jenkinsci/jenkins/pull/2070","diff_url":"https://github.com/jenkinsci/jenkins/pull/2070.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2070.patch"},"body":"launcher is already set from executor with host environment, so no need to re-inject it again using `env()`, which is designed for overrides (see it's javadoc).\r\nThis has side effect in Docker Custom Build Environment Plugin to re-inject the dockerhost computer environment inside the container and break isolation."},"comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments/207970698","html_url":"https://github.com/jenkinsci/jenkins/pull/2070#issuecomment-207970698","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2070","id":207970698,"user":{"login":"ndeloof","id":132757,"avatar_url":"https://avatars.githubusercontent.com/u/132757?v=3","gravatar_id":"","url":"https://api.github.com/users/ndeloof","html_url":"https://github.com/ndeloof","followers_url":"https://api.github.com/users/ndeloof/followers","following_url":"https://api.github.com/users/ndeloof/following{/other_user}","gists_url":"https://api.github.com/users/ndeloof/gists{/gist_id}","starred_url":"https://api.github.com/users/ndeloof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndeloof/subscriptions","organizations_url":"https://api.github.com/users/ndeloof/orgs","repos_url":"https://api.github.com/users/ndeloof/repos","events_url":"https://api.github.com/users/ndeloof/events{/privacy}","received_events_url":"https://api.github.com/users/ndeloof/received_events","type":"User","site_admin":false},"created_at":"2016-04-10T11:54:41Z","updated_at":"2016-04-10T11:54:41Z","body":"@oleg-nenashev did you actually tried using envinject with this change ? Isn't `EnvironmentContributingActions` applied on Launcher ? "}}