{"action":"created","issue":{"url":"https://api.github.com/repos/ubuntu-core/snappy/issues/1119","repository_url":"https://api.github.com/repos/ubuntu-core/snappy","labels_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/1119/labels{/name}","comments_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/1119/comments","events_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/1119/events","html_url":"https://github.com/ubuntu-core/snappy/pull/1119","id":152781254,"number":1119,"title":"snappy,systemd,wrappers: move service units generation to wrappers","user":{"login":"pedronis","id":975757,"avatar_url":"https://avatars.githubusercontent.com/u/975757?v=3","gravatar_id":"","url":"https://api.github.com/users/pedronis","html_url":"https://github.com/pedronis","followers_url":"https://api.github.com/users/pedronis/followers","following_url":"https://api.github.com/users/pedronis/following{/other_user}","gists_url":"https://api.github.com/users/pedronis/gists{/gist_id}","starred_url":"https://api.github.com/users/pedronis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedronis/subscriptions","organizations_url":"https://api.github.com/users/pedronis/orgs","repos_url":"https://api.github.com/users/pedronis/repos","events_url":"https://api.github.com/users/pedronis/events{/privacy}","received_events_url":"https://api.github.com/users/pedronis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-03T14:04:45Z","updated_at":"2016-05-04T09:39:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ubuntu-core/snappy/pulls/1119","html_url":"https://github.com/ubuntu-core/snappy/pull/1119","diff_url":"https://github.com/ubuntu-core/snappy/pull/1119.diff","patch_url":"https://github.com/ubuntu-core/snappy/pull/1119.patch"},"body":"This moves service units generation in the wrappers package with some cleanups and porting tests.\r\n\r\nIn the process found out that systemd Stop was in practice rounding timeouts to 30s, changed the code to avoid that for small timeouts and otherwise round to 10s.\r\n\r\nAlso some followup to the previous branch to make things more uniform."},"comment":{"url":"https://api.github.com/repos/ubuntu-core/snappy/issues/comments/216812244","html_url":"https://github.com/ubuntu-core/snappy/pull/1119#issuecomment-216812244","issue_url":"https://api.github.com/repos/ubuntu-core/snappy/issues/1119","id":216812244,"user":{"login":"mvo5","id":914418,"avatar_url":"https://avatars.githubusercontent.com/u/914418?v=3","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T09:39:45Z","updated_at":"2016-05-04T09:39:45Z","body":"This looks fine, thanks! One thing I noticed is that the new `wrappers/services.go` has a `interacter` that has `Agreed` and `Notify`. I think we just need a `notifier` with `Notify` here. But that is not a blocker."}}