{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3345","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3345/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3345/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3345/events","html_url":"https://github.com/RobotLocomotion/drake/pull/3345","id":174598863,"number":3345,"title":"Add a first basic pass at gflags / spdlog integration","user":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-09-01T18:55:13Z","updated_at":"2016-09-12T16:44:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/3345","html_url":"https://github.com/RobotLocomotion/drake/pull/3345","diff_url":"https://github.com/RobotLocomotion/drake/pull/3345.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/3345.patch"},"body":"This PR adds a first basic pass at gflags / spdlog integration, including a main program that can toggle the level.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/3345)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/246409943","html_url":"https://github.com/RobotLocomotion/drake/pull/3345#issuecomment-246409943","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3345","id":246409943,"user":{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T16:44:17Z","updated_at":"2016-09-12T16:44:17Z","body":"\n\n\n\nReview status: 0 of 5 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[CMakeLists.txt, line 137 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3345#-KRUFfjtRAWrUZunmFSB:-KRUFfjuq-P_Gd1gudzr:bm3dj8l) ([raw file](https://github.com/robotlocomotion/drake/blob/51a7e8020b6995abeb3cdfe100053cfb7f6d5d54/CMakeLists.txt#L137)):*\n> ```CMake\n> \n> # gflags\n> if(WIN32)\n> ```\n\nPlease add a comment explaining this conditional.\n\n---\n\n*[drake/common/text_logging.cc, line 14 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3345#-KRUGbWOIupRFOKDMErb:-KRUGbWOIupRFOKDMErc:bt3mike) ([raw file](https://github.com/robotlocomotion/drake/blob/51a7e8020b6995abeb3cdfe100053cfb7f6d5d54/drake/common/text_logging.cc#L14)):*\n> ```cpp\n> constexpr const char kTrace[] = \"trace\";\n> constexpr const char kDebug[] = \"debug\";\n> constexpr const char kLevelHelp[] =\n> ```\n\nBTW, this named constant seems like a minor antipattern to me, since it really should not be used more than once ever.\n\nAlso, while it's not difficult in this file, in some files you could imagine it being a pain for readers of the flag definition to dereference `kLevelHelp`.\n\n---\n\n*[drake/common/text_logging.cc, line 31 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3345#-KRUGISB-uczi0Mn1XOd:-KRUGISB-uczi0Mn1XOe:bffu1m3) ([raw file](https://github.com/robotlocomotion/drake/blob/51a7e8020b6995abeb3cdfe100053cfb7f6d5d54/drake/common/text_logging.cc#L31)):*\n> ```cpp\n>     throw std::runtime_error(\"Unknown spdlog level\");\n>   }\n> #ifdef HAVE_SPDLOG\n> ```\n\nWhere does this come from, and when wouldn't it be true?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/3345)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"david-german-tri"}}