{"action":"created","comment":{"url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/comments/60092383","id":60092383,"diff_hunk":"@@ -213,20 +217,33 @@ docker logs jupyterhub\n \n ### How do I specify the Notebook server image to spawn for users? \n \n-In this deployment, JupyterHub uses DockerSpawner to spawn single-user Notebook servers.  The `jupyterhub_config.py` reads the image name from the `DOCKER_CONTAINER_IMAGE` environment variable.\n+In this deployment, JupyterHub uses DockerSpawner to spawn single-user\n+Notebook servers. You set the desired Notebook server image in a\n+`DOCKER_CONTAINER_IMAGE` environment variable.\n+\n+When spawning single-user notebooks, JupyterHub reads the DockerSpawner's \n+image name from `jupyterhub_config.py` file. This file includes the\n+DockerSpawner's image name which refers to desired image in the\n+`DOCKER_CONTAINER_IMAGE` environment variable:\n ","path":"README.md","position":26,"original_position":26,"commit_id":"7ac7c8204032b613cf227fe6f4c1f73a71b9dc1b","original_commit_id":"7ac7c8204032b613cf227fe6f4c1f73a71b9dc1b","user":{"login":"jtyberg","id":359081,"avatar_url":"https://avatars.githubusercontent.com/u/359081?v=3","gravatar_id":"","url":"https://api.github.com/users/jtyberg","html_url":"https://github.com/jtyberg","followers_url":"https://api.github.com/users/jtyberg/followers","following_url":"https://api.github.com/users/jtyberg/following{/other_user}","gists_url":"https://api.github.com/users/jtyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jtyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtyberg/subscriptions","organizations_url":"https://api.github.com/users/jtyberg/orgs","repos_url":"https://api.github.com/users/jtyberg/repos","events_url":"https://api.github.com/users/jtyberg/events{/privacy}","received_events_url":"https://api.github.com/users/jtyberg/received_events","type":"User","site_admin":false},"body":"I get tripped up a bit on this one.  It reads like the `jupyterhub_config.py` is consulted when an image is spawned, but the `DOCKER_CONTAINER_IMAGE` is only read during JHub startup.  And one could interpret \"DockerSpawner's image name\" as the spawner itself having an image, but we're really talking about the Notebook server image that DockerSpawner uses to spawn a container.  \r\n\r\nPerhaps: \"JupyterHub reads the Notebook image name from `jupyterhub_config.py`.  This file retrieves the Notebook image name from the `DOCKER_CONTAINER_IMAGE` environment variable:\"\r\n\r\nI think the name of the variable may be causing some confusion.  Perhaps we should name it something like, `DOCKER_NOTEBOOK_IMAGE`, or something.","created_at":"2016-04-18T16:47:04Z","updated_at":"2016-04-18T16:47:04Z","html_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/3#discussion_r60092383","pull_request_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/comments/60092383"},"html":{"href":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/3#discussion_r60092383"},"pull_request":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3","id":66878383,"html_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/3","diff_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/3.diff","patch_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/3.patch","issue_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/3","number":3,"state":"open","locked":false,"title":"Edit FAQ","user":{"login":"willingc","id":2680980,"avatar_url":"https://avatars.githubusercontent.com/u/2680980?v=3","gravatar_id":"","url":"https://api.github.com/users/willingc","html_url":"https://github.com/willingc","followers_url":"https://api.github.com/users/willingc/followers","following_url":"https://api.github.com/users/willingc/following{/other_user}","gists_url":"https://api.github.com/users/willingc/gists{/gist_id}","starred_url":"https://api.github.com/users/willingc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willingc/subscriptions","organizations_url":"https://api.github.com/users/willingc/orgs","repos_url":"https://api.github.com/users/willingc/repos","events_url":"https://api.github.com/users/willingc/events{/privacy}","received_events_url":"https://api.github.com/users/willingc/received_events","type":"User","site_admin":false},"body":"Following up on the recent additions by @jtyberg (thanks!) in PR #2 , I have attempted to add more concrete wording for some of the pronoun references. Minimizing pronouns helps the reader avoid confusion.\r\n\r\n@jtyberg Would you mind reviewing to make sure that I haven't changed your intended meaning or introduced an error into the FAQ with my changes? Thanks!","created_at":"2016-04-18T15:59:56Z","updated_at":"2016-04-18T16:47:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a34c2ee7ccbae20d0be5edcba37b3f7c89f2518","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3/commits","review_comments_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3/comments","review_comment_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/3/comments","statuses_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/statuses/7ac7c8204032b613cf227fe6f4c1f73a71b9dc1b","head":{"label":"willingc:faq-edit","ref":"faq-edit","sha":"7ac7c8204032b613cf227fe6f4c1f73a71b9dc1b","user":{"login":"willingc","id":2680980,"avatar_url":"https://avatars.githubusercontent.com/u/2680980?v=3","gravatar_id":"","url":"https://api.github.com/users/willingc","html_url":"https://github.com/willingc","followers_url":"https://api.github.com/users/willingc/followers","following_url":"https://api.github.com/users/willingc/following{/other_user}","gists_url":"https://api.github.com/users/willingc/gists{/gist_id}","starred_url":"https://api.github.com/users/willingc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willingc/subscriptions","organizations_url":"https://api.github.com/users/willingc/orgs","repos_url":"https://api.github.com/users/willingc/repos","events_url":"https://api.github.com/users/willingc/events{/privacy}","received_events_url":"https://api.github.com/users/willingc/received_events","type":"User","site_admin":false},"repo":{"id":56251673,"name":"jupyterhub-deploy-docker","full_name":"willingc/jupyterhub-deploy-docker","owner":{"login":"willingc","id":2680980,"avatar_url":"https://avatars.githubusercontent.com/u/2680980?v=3","gravatar_id":"","url":"https://api.github.com/users/willingc","html_url":"https://github.com/willingc","followers_url":"https://api.github.com/users/willingc/followers","following_url":"https://api.github.com/users/willingc/following{/other_user}","gists_url":"https://api.github.com/users/willingc/gists{/gist_id}","starred_url":"https://api.github.com/users/willingc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willingc/subscriptions","organizations_url":"https://api.github.com/users/willingc/orgs","repos_url":"https://api.github.com/users/willingc/repos","events_url":"https://api.github.com/users/willingc/events{/privacy}","received_events_url":"https://api.github.com/users/willingc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willingc/jupyterhub-deploy-docker","description":"Reference deployment of JupyterHub with docker","fork":true,"url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker","forks_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/forks","keys_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/teams","hooks_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/hooks","issue_events_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/issues/events{/number}","events_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/events","assignees_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/assignees{/user}","branches_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/branches{/branch}","tags_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/tags","blobs_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/languages","stargazers_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/stargazers","contributors_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/contributors","subscribers_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/subscribers","subscription_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/subscription","commits_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/contents/{+path}","compare_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/merges","archive_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/downloads","issues_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/issues{/number}","pulls_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/labels{/name}","releases_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/releases{/id}","deployments_url":"https://api.github.com/repos/willingc/jupyterhub-deploy-docker/deployments","created_at":"2016-04-14T16:07:59Z","updated_at":"2016-04-18T15:01:32Z","pushed_at":"2016-04-18T15:55:08Z","git_url":"git://github.com/willingc/jupyterhub-deploy-docker.git","ssh_url":"git@github.com:willingc/jupyterhub-deploy-docker.git","clone_url":"https://github.com/willingc/jupyterhub-deploy-docker.git","svn_url":"https://github.com/willingc/jupyterhub-deploy-docker","homepage":null,"size":122,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyterhub:master","ref":"master","sha":"a7f38aaf2f2835945c723340699afcf9f720d42b","user":{"login":"jupyterhub","id":17927519,"avatar_url":"https://avatars.githubusercontent.com/u/17927519?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"repo":{"id":56241532,"name":"jupyterhub-deploy-docker","full_name":"jupyterhub/jupyterhub-deploy-docker","owner":{"login":"jupyterhub","id":17927519,"avatar_url":"https://avatars.githubusercontent.com/u/17927519?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyterhub","html_url":"https://github.com/jupyterhub","followers_url":"https://api.github.com/users/jupyterhub/followers","following_url":"https://api.github.com/users/jupyterhub/following{/other_user}","gists_url":"https://api.github.com/users/jupyterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterhub/subscriptions","organizations_url":"https://api.github.com/users/jupyterhub/orgs","repos_url":"https://api.github.com/users/jupyterhub/repos","events_url":"https://api.github.com/users/jupyterhub/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterhub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker","description":"Reference deployment of JupyterHub with docker","fork":false,"url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker","forks_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/forks","keys_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/teams","hooks_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/hooks","issue_events_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/events","assignees_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/tags","blobs_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/languages","stargazers_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/stargazers","contributors_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/contributors","subscribers_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/subscribers","subscription_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/subscription","commits_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/merges","archive_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/downloads","issues_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/labels{/name}","releases_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/deployments","created_at":"2016-04-14T13:53:14Z","updated_at":"2016-04-18T08:51:22Z","pushed_at":"2016-04-18T15:59:56Z","git_url":"git://github.com/jupyterhub/jupyterhub-deploy-docker.git","ssh_url":"git@github.com:jupyterhub/jupyterhub-deploy-docker.git","clone_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker.git","svn_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker","homepage":null,"size":105,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3"},"html":{"href":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/3"},"issue":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/3"},"comments":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/statuses/7ac7c8204032b613cf227fe6f4c1f73a71b9dc1b"}}}}