{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7938","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7938/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7938/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7938/events","html_url":"https://github.com/Automattic/wp-calypso/pull/7938","id":175570376,"number":7938,"title":"Editor: Contact Form: Add hover text to Edit button","user":{"login":"nitrajka","id":14272775,"avatar_url":"https://avatars.githubusercontent.com/u/14272775?v=3","gravatar_id":"","url":"https://api.github.com/users/nitrajka","html_url":"https://github.com/nitrajka","followers_url":"https://api.github.com/users/nitrajka/followers","following_url":"https://api.github.com/users/nitrajka/following{/other_user}","gists_url":"https://api.github.com/users/nitrajka/gists{/gist_id}","starred_url":"https://api.github.com/users/nitrajka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitrajka/subscriptions","organizations_url":"https://api.github.com/users/nitrajka/orgs","repos_url":"https://api.github.com/users/nitrajka/repos","events_url":"https://api.github.com/users/nitrajka/events{/privacy}","received_events_url":"https://api.github.com/users/nitrajka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/OSS%20Citizen","name":"OSS Citizen","color":"5319e7"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-09-07T18:12:15Z","updated_at":"2016-09-13T00:04:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/7938","html_url":"https://github.com/Automattic/wp-calypso/pull/7938","diff_url":"https://github.com/Automattic/wp-calypso/pull/7938.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/7938.patch"},"body":"Hi,\r\n\r\nI fixed the bug #4116 . I came up with 4 solutions, but decided to use the following one. \r\nI wrapped the `<Gridicon>` component in a new `<div>` and styled the `<div>` with paddings. Exactly like the remove button located in 'components/tinymce/plugins/contact-form/dialog/field-remove-button.jsx' which is on the left side of edit button. \r\nIf there wouldn't be paddings, the hover text would appear not in the same line as the hover text for remove button. I added a Popover component to the edit button. If there would be problem with ES6 import which I added, I can rewrite it to es5 or the others rewrite to es6."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/246533513","html_url":"https://github.com/Automattic/wp-calypso/pull/7938#issuecomment-246533513","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/7938","id":246533513,"user":{"login":"alisterscott","id":128826,"avatar_url":"https://avatars.githubusercontent.com/u/128826?v=3","gravatar_id":"","url":"https://api.github.com/users/alisterscott","html_url":"https://github.com/alisterscott","followers_url":"https://api.github.com/users/alisterscott/followers","following_url":"https://api.github.com/users/alisterscott/following{/other_user}","gists_url":"https://api.github.com/users/alisterscott/gists{/gist_id}","starred_url":"https://api.github.com/users/alisterscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisterscott/subscriptions","organizations_url":"https://api.github.com/users/alisterscott/orgs","repos_url":"https://api.github.com/users/alisterscott/repos","events_url":"https://api.github.com/users/alisterscott/events{/privacy}","received_events_url":"https://api.github.com/users/alisterscott/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T00:04:11Z","updated_at":"2016-09-13T00:04:11Z","body":"Thanks for working on this change. I tested this out and it worked well in Chrome, Firefox and Safari (OSX) - the only issue I found was in Safari, whilst the hover text looks great, the Edit button styling no longer displays the same as previously (and the other button)\r\n\r\n![safari edit hover](https://cloud.githubusercontent.com/assets/128826/18457097/58a3ae6e-7999-11e6-9281-f77b86bce88b.png)\r\n"}}
{"actor":{"display_login":"alisterscott"}}