{"action":"closed","number":1766,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1766","id":76044304,"html_url":"https://github.com/ripple/rippled/pull/1766","diff_url":"https://github.com/ripple/rippled/pull/1766.diff","patch_url":"https://github.com/ripple/rippled/pull/1766.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1766","number":1766,"state":"closed","locked":false,"title":"Ignore empty CONFIG_DIR for validators file (RIPD-1221)","user":{"login":"wilsonianb","id":5885521,"avatar_url":"https://avatars.githubusercontent.com/u/5885521?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false},"body":"Some unit tests load configs with `Config::loadFromString()` instead of `Config::setup()` where an actual rippled.cfg file path exists and `CONFIG_DIR` is defined.\r\nThe empty `CONFIG_DIR` was causing rippled to look for validators.txt at the current path, leading to test failure if a validators.txt was unexpectedly found there.","created_at":"2016-07-01T22:31:53Z","updated_at":"2016-07-06T19:28:59Z","closed_at":"2016-07-06T19:28:59Z","merged_at":null,"merge_commit_sha":"793c3662b0e02e984213bf2099f980f479f9c11c","assignee":{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1766/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1766/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1766/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/4fb552be0a2f418da3e403ffa696296db676e446","head":{"label":"wilsonianb:fix-validators-file","ref":"fix-validators-file","sha":"4fb552be0a2f418da3e403ffa696296db676e446","user":{"login":"wilsonianb","id":5885521,"avatar_url":"https://avatars.githubusercontent.com/u/5885521?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false},"repo":{"id":16365871,"name":"rippled","full_name":"wilsonianb/rippled","owner":{"login":"wilsonianb","id":5885521,"avatar_url":"https://avatars.githubusercontent.com/u/5885521?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilsonianb/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/wilsonianb/rippled","forks_url":"https://api.github.com/repos/wilsonianb/rippled/forks","keys_url":"https://api.github.com/repos/wilsonianb/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilsonianb/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilsonianb/rippled/teams","hooks_url":"https://api.github.com/repos/wilsonianb/rippled/hooks","issue_events_url":"https://api.github.com/repos/wilsonianb/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/wilsonianb/rippled/events","assignees_url":"https://api.github.com/repos/wilsonianb/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/wilsonianb/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/wilsonianb/rippled/tags","blobs_url":"https://api.github.com/repos/wilsonianb/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilsonianb/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilsonianb/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilsonianb/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilsonianb/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/wilsonianb/rippled/languages","stargazers_url":"https://api.github.com/repos/wilsonianb/rippled/stargazers","contributors_url":"https://api.github.com/repos/wilsonianb/rippled/contributors","subscribers_url":"https://api.github.com/repos/wilsonianb/rippled/subscribers","subscription_url":"https://api.github.com/repos/wilsonianb/rippled/subscription","commits_url":"https://api.github.com/repos/wilsonianb/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilsonianb/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilsonianb/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilsonianb/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilsonianb/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/wilsonianb/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilsonianb/rippled/merges","archive_url":"https://api.github.com/repos/wilsonianb/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilsonianb/rippled/downloads","issues_url":"https://api.github.com/repos/wilsonianb/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/wilsonianb/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/wilsonianb/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/wilsonianb/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilsonianb/rippled/labels{/name}","releases_url":"https://api.github.com/repos/wilsonianb/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/wilsonianb/rippled/deployments","created_at":"2014-01-30T01:59:42Z","updated_at":"2015-05-27T17:06:13Z","pushed_at":"2016-07-01T22:28:28Z","git_url":"git://github.com/wilsonianb/rippled.git","ssh_url":"git@github.com:wilsonianb/rippled.git","clone_url":"https://github.com/wilsonianb/rippled.git","svn_url":"https://github.com/wilsonianb/rippled","homepage":"https://ripple.com","size":115273,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"a22fa21ce42b11967700be94dee517185df0dccf","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2016-07-05T23:41:18Z","pushed_at":"2016-07-06T19:27:33Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":113893,"stargazers_count":1109,"watchers_count":1109,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":113,"forks":332,"open_issues":113,"watchers":1109,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1766"},"html":{"href":"https://github.com/ripple/rippled/pull/1766"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1766"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1766/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1766/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1766/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/4fb552be0a2f418da3e403ffa696296db676e446"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":14,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"seelabs"}}