{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/1","id":98829340,"html_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1","diff_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1.diff","patch_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1.patch","issue_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1","number":1,"state":"closed","locked":false,"title":"Implement sorting and filtering. Make example folder.","user":{"login":"Nathan-Schwartz","id":7296584,"avatar_url":"https://avatars.githubusercontent.com/u/7296584?v=3","gravatar_id":"","url":"https://api.github.com/users/Nathan-Schwartz","html_url":"https://github.com/Nathan-Schwartz","followers_url":"https://api.github.com/users/Nathan-Schwartz/followers","following_url":"https://api.github.com/users/Nathan-Schwartz/following{/other_user}","gists_url":"https://api.github.com/users/Nathan-Schwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/Nathan-Schwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nathan-Schwartz/subscriptions","organizations_url":"https://api.github.com/users/Nathan-Schwartz/orgs","repos_url":"https://api.github.com/users/Nathan-Schwartz/repos","events_url":"https://api.github.com/users/Nathan-Schwartz/events{/privacy}","received_events_url":"https://api.github.com/users/Nathan-Schwartz/received_events","type":"User","site_admin":false},"body":"The table wasn't updating when receiving new props. Reason being that PureComponent doesn't check deep equality. I used normal Component with isEqual in componentShouldUpdate for the main component, but unsure if we should continue using PureComponent elsewhere. If we do it could potentially limit the compatibility of our package for users.\r\n\r\nNot sure if we want to do debouncing/throttling within the package. Atm it seems like it is one more package and option to handle.\r\n\r\nFilter functionality still needs to be implemented, and then I will be able to actually test this in our application. After all of that is done I will feel more comfortable refactoring and doing things like adding ES7 class properties.\r\n","created_at":"2016-12-20T21:31:30Z","updated_at":"2016-12-21T22:52:37Z","closed_at":"2016-12-21T22:52:37Z","merged_at":"2016-12-21T22:52:37Z","merge_commit_sha":"9dd242c39cf3c7c992c84bc916295c1aa821c345","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1/comments","statuses_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/statuses/f3759b203ba416171820f9e0608ce6e1f6ef97f0","head":{"label":"ConciergeAuctions:feature/implement-sorting","ref":"feature/implement-sorting","sha":"f3759b203ba416171820f9e0608ce6e1f6ef97f0","user":{"login":"ConciergeAuctions","id":10405966,"avatar_url":"https://avatars.githubusercontent.com/u/10405966?v=3","gravatar_id":"","url":"https://api.github.com/users/ConciergeAuctions","html_url":"https://github.com/ConciergeAuctions","followers_url":"https://api.github.com/users/ConciergeAuctions/followers","following_url":"https://api.github.com/users/ConciergeAuctions/following{/other_user}","gists_url":"https://api.github.com/users/ConciergeAuctions/gists{/gist_id}","starred_url":"https://api.github.com/users/ConciergeAuctions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConciergeAuctions/subscriptions","organizations_url":"https://api.github.com/users/ConciergeAuctions/orgs","repos_url":"https://api.github.com/users/ConciergeAuctions/repos","events_url":"https://api.github.com/users/ConciergeAuctions/events{/privacy}","received_events_url":"https://api.github.com/users/ConciergeAuctions/received_events","type":"Organization","site_admin":false},"repo":{"id":76280115,"name":"react-mui-table","full_name":"ConciergeAuctions/react-mui-table","owner":{"login":"ConciergeAuctions","id":10405966,"avatar_url":"https://avatars.githubusercontent.com/u/10405966?v=3","gravatar_id":"","url":"https://api.github.com/users/ConciergeAuctions","html_url":"https://github.com/ConciergeAuctions","followers_url":"https://api.github.com/users/ConciergeAuctions/followers","following_url":"https://api.github.com/users/ConciergeAuctions/following{/other_user}","gists_url":"https://api.github.com/users/ConciergeAuctions/gists{/gist_id}","starred_url":"https://api.github.com/users/ConciergeAuctions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConciergeAuctions/subscriptions","organizations_url":"https://api.github.com/users/ConciergeAuctions/orgs","repos_url":"https://api.github.com/users/ConciergeAuctions/repos","events_url":"https://api.github.com/users/ConciergeAuctions/events{/privacy}","received_events_url":"https://api.github.com/users/ConciergeAuctions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConciergeAuctions/react-mui-table","description":"A react component that takes data & style parameters, and renders a Material UI table.","fork":false,"url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table","forks_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/forks","keys_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/teams","hooks_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/hooks","issue_events_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/events{/number}","events_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/events","assignees_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/assignees{/user}","branches_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/branches{/branch}","tags_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/tags","blobs_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/statuses/{sha}","languages_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/languages","stargazers_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/stargazers","contributors_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/contributors","subscribers_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/subscribers","subscription_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/subscription","commits_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/contents/{+path}","compare_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/merges","archive_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/downloads","issues_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues{/number}","pulls_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls{/number}","milestones_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/milestones{/number}","notifications_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/labels{/name}","releases_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/releases{/id}","deployments_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/deployments","created_at":"2016-12-12T17:36:44Z","updated_at":"2016-12-12T20:03:42Z","pushed_at":"2016-12-21T22:52:37Z","git_url":"git://github.com/ConciergeAuctions/react-mui-table.git","ssh_url":"git@github.com:ConciergeAuctions/react-mui-table.git","clone_url":"https://github.com/ConciergeAuctions/react-mui-table.git","svn_url":"https://github.com/ConciergeAuctions/react-mui-table","homepage":null,"size":228,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ConciergeAuctions:master","ref":"master","sha":"cd4a1319e58cc089fb735f224fceb9e1d1f7b9be","user":{"login":"ConciergeAuctions","id":10405966,"avatar_url":"https://avatars.githubusercontent.com/u/10405966?v=3","gravatar_id":"","url":"https://api.github.com/users/ConciergeAuctions","html_url":"https://github.com/ConciergeAuctions","followers_url":"https://api.github.com/users/ConciergeAuctions/followers","following_url":"https://api.github.com/users/ConciergeAuctions/following{/other_user}","gists_url":"https://api.github.com/users/ConciergeAuctions/gists{/gist_id}","starred_url":"https://api.github.com/users/ConciergeAuctions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConciergeAuctions/subscriptions","organizations_url":"https://api.github.com/users/ConciergeAuctions/orgs","repos_url":"https://api.github.com/users/ConciergeAuctions/repos","events_url":"https://api.github.com/users/ConciergeAuctions/events{/privacy}","received_events_url":"https://api.github.com/users/ConciergeAuctions/received_events","type":"Organization","site_admin":false},"repo":{"id":76280115,"name":"react-mui-table","full_name":"ConciergeAuctions/react-mui-table","owner":{"login":"ConciergeAuctions","id":10405966,"avatar_url":"https://avatars.githubusercontent.com/u/10405966?v=3","gravatar_id":"","url":"https://api.github.com/users/ConciergeAuctions","html_url":"https://github.com/ConciergeAuctions","followers_url":"https://api.github.com/users/ConciergeAuctions/followers","following_url":"https://api.github.com/users/ConciergeAuctions/following{/other_user}","gists_url":"https://api.github.com/users/ConciergeAuctions/gists{/gist_id}","starred_url":"https://api.github.com/users/ConciergeAuctions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConciergeAuctions/subscriptions","organizations_url":"https://api.github.com/users/ConciergeAuctions/orgs","repos_url":"https://api.github.com/users/ConciergeAuctions/repos","events_url":"https://api.github.com/users/ConciergeAuctions/events{/privacy}","received_events_url":"https://api.github.com/users/ConciergeAuctions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConciergeAuctions/react-mui-table","description":"A react component that takes data & style parameters, and renders a Material UI table.","fork":false,"url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table","forks_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/forks","keys_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/teams","hooks_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/hooks","issue_events_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/events{/number}","events_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/events","assignees_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/assignees{/user}","branches_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/branches{/branch}","tags_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/tags","blobs_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/statuses/{sha}","languages_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/languages","stargazers_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/stargazers","contributors_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/contributors","subscribers_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/subscribers","subscription_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/subscription","commits_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/contents/{+path}","compare_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/merges","archive_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/downloads","issues_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues{/number}","pulls_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls{/number}","milestones_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/milestones{/number}","notifications_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/labels{/name}","releases_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/releases{/id}","deployments_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/deployments","created_at":"2016-12-12T17:36:44Z","updated_at":"2016-12-12T20:03:42Z","pushed_at":"2016-12-21T22:52:37Z","git_url":"git://github.com/ConciergeAuctions/react-mui-table.git","ssh_url":"git@github.com:ConciergeAuctions/react-mui-table.git","clone_url":"https://github.com/ConciergeAuctions/react-mui-table.git","svn_url":"https://github.com/ConciergeAuctions/react-mui-table","homepage":null,"size":228,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/1"},"html":{"href":"https://github.com/ConciergeAuctions/react-mui-table/pull/1"},"issue":{"href":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1"},"comments":{"href":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/statuses/f3759b203ba416171820f9e0608ce6e1f6ef97f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"brad-decker","id":4448075,"avatar_url":"https://avatars.githubusercontent.com/u/4448075?v=3","gravatar_id":"","url":"https://api.github.com/users/brad-decker","html_url":"https://github.com/brad-decker","followers_url":"https://api.github.com/users/brad-decker/followers","following_url":"https://api.github.com/users/brad-decker/following{/other_user}","gists_url":"https://api.github.com/users/brad-decker/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-decker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-decker/subscriptions","organizations_url":"https://api.github.com/users/brad-decker/orgs","repos_url":"https://api.github.com/users/brad-decker/repos","events_url":"https://api.github.com/users/brad-decker/events{/privacy}","received_events_url":"https://api.github.com/users/brad-decker/received_events","type":"User","site_admin":false},"comments":5,"review_comments":20,"commits":3,"additions":343,"deletions":235,"changed_files":17}}
{"actor":{"display_login":"brad-decker"}}