{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/ServiceControl/issues/484","repository_url":"https://api.github.com/repos/Particular/ServiceControl","labels_url":"https://api.github.com/repos/Particular/ServiceControl/issues/484/labels{/name}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/issues/484/comments","events_url":"https://api.github.com/repos/Particular/ServiceControl/issues/484/events","html_url":"https://github.com/Particular/ServiceControl/issues/484","id":93656614,"number":484,"title":"Circuit breaker settings are hard coded in Service Control and plugins","user":{"login":"vellad","id":4854840,"avatar_url":"https://avatars.githubusercontent.com/u/4854840?v=3","gravatar_id":"","url":"https://api.github.com/users/vellad","html_url":"https://github.com/vellad","followers_url":"https://api.github.com/users/vellad/followers","following_url":"https://api.github.com/users/vellad/following{/other_user}","gists_url":"https://api.github.com/users/vellad/gists{/gist_id}","starred_url":"https://api.github.com/users/vellad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vellad/subscriptions","organizations_url":"https://api.github.com/users/vellad/orgs","repos_url":"https://api.github.com/users/vellad/repos","events_url":"https://api.github.com/users/vellad/events{/privacy}","received_events_url":"https://api.github.com/users/vellad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-08T00:00:15Z","updated_at":"2016-02-18T01:17:19Z","closed_at":null,"body":"The two circuit breaker settings are hard coded for Service Control to these values:\r\ntimeToWaitBeforeTriggering: 2 mins\r\ndelayAfterFailure: 20 secs\r\n\r\nThey are also hardcoded in the heartbeat plugin to these values:\r\ntimeToWaitBeforeTriggering: 2 mins\r\ndelayAfterFailure: 1 sec (default from circuit breaker class)\r\n\r\nThis could be the case in other plugins as well.\r\n\r\nThey need to all be configurable in code and/or a config file."},"comment":{"url":"https://api.github.com/repos/Particular/ServiceControl/issues/comments/185493359","html_url":"https://github.com/Particular/ServiceControl/issues/484#issuecomment-185493359","issue_url":"https://api.github.com/repos/Particular/ServiceControl/issues/484","id":185493359,"user":{"login":"yossita","id":429055,"avatar_url":"https://avatars.githubusercontent.com/u/429055?v=3","gravatar_id":"","url":"https://api.github.com/users/yossita","html_url":"https://github.com/yossita","followers_url":"https://api.github.com/users/yossita/followers","following_url":"https://api.github.com/users/yossita/following{/other_user}","gists_url":"https://api.github.com/users/yossita/gists{/gist_id}","starred_url":"https://api.github.com/users/yossita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yossita/subscriptions","organizations_url":"https://api.github.com/users/yossita/orgs","repos_url":"https://api.github.com/users/yossita/repos","events_url":"https://api.github.com/users/yossita/events{/privacy}","received_events_url":"https://api.github.com/users/yossita/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T01:17:19Z","updated_at":"2016-02-18T01:17:19Z","body":"Just in this subject, when communicating with a sql server cluster, some\nenvironments take time to fail over, 2 minutes might not be enough to\nrecover.\n\nOn Wed, Feb 17, 2016 at 2:20 PM John Simons <notifications@github.com>\nwrote:\n\n> @mauroservienti <https://github.com/mauroservienti> in that scenario I\n> see us doing them a favor and pointing out issues with their own\n> infrastructure.\n> The current hardcoded times are IMO quite generous, we currently wait up\n> to 2mins before arming the breaker, this is IMO quite a bit of time to wait\n> for a network to respond, increasing this number even further could have\n> dangerous effects.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Particular/ServiceControl/issues/484#issuecomment-185433206>\n> .\n>\n"}}