{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/78226574","id":78226574,"diff_hunk":"@@ -101,25 +110,74 @@\n const CFStringRef kCTFontFeatureSelectorSettingKey = static_cast<CFStringRef>(@\"kCTFontFeatureSelectorSettingKey\");\n \n /**\n+ All these values are fixed number in IOS no matter on iphone* or ipad*.\n+ */\n+const CGFloat kCTFontLabelFontSize = 17.0f;\n+const CGFloat kCTFontButtonFontSize = 14.0f;\n+const CGFloat kCTFontSmallSystemFontSize = 12.0f;\n+const CGFloat kCTFontSystemFontSize = 14.0f;\n+\n+using namespace Microsoft::WRL;\n+\n+struct __CTFont {","path":"Frameworks/CoreText/CTFont.mm","position":38,"original_position":38,"commit_id":"436864149c26fc1a62fd690afaa1c02995ff1b59","original_commit_id":"436864149c26fc1a62fd690afaa1c02995ff1b59","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"body":"- Is the same style as CF\r\n- For most purposes, since this is already def'd to CTFontRef, you can just use that\r\n- The only times when 'struct' is used is when directly modifying the struct members, and I don't dislike the emphasis there\r\n\r\n---\r\nIn reply to: [78220566](https://github.com/Microsoft/WinObjC/pull/987#discussion_r78220566) [](ancestors = 78220566,78205733)","created_at":"2016-09-09T18:25:09Z","updated_at":"2016-09-09T18:25:09Z","html_url":"https://github.com/Microsoft/WinObjC/pull/987#discussion_r78226574","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/78226574"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/987#discussion_r78226574"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987","id":84577576,"html_url":"https://github.com/Microsoft/WinObjC/pull/987","diff_url":"https://github.com/Microsoft/WinObjC/pull/987.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/987.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/987","number":987,"state":"open","locked":false,"title":"Initial bridging of CTFontRef and UIFont","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"body":" - Rewrite big chunk of CTFont to use DWrite instead of FreeType\r\n    - Add to DWriteWrapper file\r\n - Bridge CTFontRef and UIFont, UICTFont introduced\r\n - Add tests for UIFont and CTFont\r\n    - Moved two UIKit test files that were in an incorrect location\r\n - Changed instances of 'SegoeUI' in our codebase to 'Segoe UI' - the latter is what DWrite uses for its names\r\n\r\nAddresses #729","created_at":"2016-09-09T00:43:27Z","updated_at":"2016-09-09T18:25:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed6aa7d6ec7ccf3cf5262646cb81917c37fd0cec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/987/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/436864149c26fc1a62fd690afaa1c02995ff1b59","head":{"label":"ms-jihua:ctfont","ref":"ctfont","sha":"436864149c26fc1a62fd690afaa1c02995ff1b59","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"repo":{"id":63092436,"name":"WinObjC","full_name":"ms-jihua/WinObjC","owner":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ms-jihua/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/ms-jihua/WinObjC","forks_url":"https://api.github.com/repos/ms-jihua/WinObjC/forks","keys_url":"https://api.github.com/repos/ms-jihua/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ms-jihua/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ms-jihua/WinObjC/teams","hooks_url":"https://api.github.com/repos/ms-jihua/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/ms-jihua/WinObjC/events","assignees_url":"https://api.github.com/repos/ms-jihua/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/ms-jihua/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/ms-jihua/WinObjC/tags","blobs_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ms-jihua/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/ms-jihua/WinObjC/languages","stargazers_url":"https://api.github.com/repos/ms-jihua/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/ms-jihua/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/ms-jihua/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/ms-jihua/WinObjC/subscription","commits_url":"https://api.github.com/repos/ms-jihua/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/ms-jihua/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/ms-jihua/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/ms-jihua/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ms-jihua/WinObjC/merges","archive_url":"https://api.github.com/repos/ms-jihua/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ms-jihua/WinObjC/downloads","issues_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/ms-jihua/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/ms-jihua/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/ms-jihua/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ms-jihua/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/ms-jihua/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/ms-jihua/WinObjC/deployments","created_at":"2016-07-11T18:32:57Z","updated_at":"2016-07-11T18:33:10Z","pushed_at":"2016-09-09T00:43:13Z","git_url":"git://github.com/ms-jihua/WinObjC.git","ssh_url":"git@github.com:ms-jihua/WinObjC.git","clone_url":"https://github.com/ms-jihua/WinObjC.git","svn_url":"https://github.com/ms-jihua/WinObjC","homepage":"","size":333253,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:CT-DW","ref":"CT-DW","sha":"f94598b9947d5bb903302e470d25fefc263a229d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-09-09T06:05:12Z","pushed_at":"2016-09-09T18:21:39Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":336082,"stargazers_count":5437,"watchers_count":5437,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":698,"mirror_url":null,"open_issues_count":238,"forks":698,"open_issues":238,"watchers":5437,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/987"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/987"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/987/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/987/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/436864149c26fc1a62fd690afaa1c02995ff1b59"}}}}
{"actor":{"display_login":"ms-jihua"}}