{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/83967587","pull_request_review_id":4776345,"id":83967587,"diff_hunk":"@@ -305,6 +306,11 @@ def test_integer_bounds(self):\n         # This should not raise an exception\n         fmin_slsqp(lambda z: z**2 - 1, [0], bounds=[[0, 1]], iprint=0)\n \n+    def test_obj_must_return_scalar(self):\n+        # If objective function does not return a scalar, raises ValueError","path":"scipy/optimize/tests/test_slsqp.py","position":null,"original_position":15,"commit_id":"049a6116ffadf0bf17becda772f8f5834c03d322","original_commit_id":"5615a371aae193391810ea79939e7d8aeb8c5687","user":{"login":"b-carter","id":6495170,"avatar_url":"https://avatars.githubusercontent.com/u/6495170?v=3","gravatar_id":"","url":"https://api.github.com/users/b-carter","html_url":"https://github.com/b-carter","followers_url":"https://api.github.com/users/b-carter/followers","following_url":"https://api.github.com/users/b-carter/following{/other_user}","gists_url":"https://api.github.com/users/b-carter/gists{/gist_id}","starred_url":"https://api.github.com/users/b-carter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-carter/subscriptions","organizations_url":"https://api.github.com/users/b-carter/orgs","repos_url":"https://api.github.com/users/b-carter/repos","events_url":"https://api.github.com/users/b-carter/events{/privacy}","received_events_url":"https://api.github.com/users/b-carter/received_events","type":"User","site_admin":false},"body":"Added!","created_at":"2016-10-18T22:51:12Z","updated_at":"2016-10-18T22:51:12Z","html_url":"https://github.com/scipy/scipy/pull/6691#discussion_r83967587","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/6691","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/83967587"},"html":{"href":"https://github.com/scipy/scipy/pull/6691#discussion_r83967587"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6691"}}},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/6691","id":89547006,"html_url":"https://github.com/scipy/scipy/pull/6691","diff_url":"https://github.com/scipy/scipy/pull/6691.diff","patch_url":"https://github.com/scipy/scipy/pull/6691.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/6691","number":6691,"state":"open","locked":false,"title":"ENH: Clearer error when fmin_slsqp obj doesn't return scalar","user":{"login":"b-carter","id":6495170,"avatar_url":"https://avatars.githubusercontent.com/u/6495170?v=3","gravatar_id":"","url":"https://api.github.com/users/b-carter","html_url":"https://github.com/b-carter","followers_url":"https://api.github.com/users/b-carter/followers","following_url":"https://api.github.com/users/b-carter/following{/other_user}","gists_url":"https://api.github.com/users/b-carter/gists{/gist_id}","starred_url":"https://api.github.com/users/b-carter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-carter/subscriptions","organizations_url":"https://api.github.com/users/b-carter/orgs","repos_url":"https://api.github.com/users/b-carter/repos","events_url":"https://api.github.com/users/b-carter/events{/privacy}","received_events_url":"https://api.github.com/users/b-carter/received_events","type":"User","site_admin":false},"body":"See #5433 \r\n\r\nValueError with a clear message is raised when the objective function in `fmin_slsqp` doesn't return a scalar.\r\n\r\nAlso updates docstring to add that objective function must return a scalar and adds a test for look for the ValueError.","created_at":"2016-10-17T00:37:59Z","updated_at":"2016-10-18T22:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6841072edf7f82662241ec3e938cd728bd4e62a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/6691/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/6691/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/6691/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/049a6116ffadf0bf17becda772f8f5834c03d322","head":{"label":"b-carter:fix_invalid_fmin_slsqp_objective","ref":"fix_invalid_fmin_slsqp_objective","sha":"049a6116ffadf0bf17becda772f8f5834c03d322","user":{"login":"b-carter","id":6495170,"avatar_url":"https://avatars.githubusercontent.com/u/6495170?v=3","gravatar_id":"","url":"https://api.github.com/users/b-carter","html_url":"https://github.com/b-carter","followers_url":"https://api.github.com/users/b-carter/followers","following_url":"https://api.github.com/users/b-carter/following{/other_user}","gists_url":"https://api.github.com/users/b-carter/gists{/gist_id}","starred_url":"https://api.github.com/users/b-carter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-carter/subscriptions","organizations_url":"https://api.github.com/users/b-carter/orgs","repos_url":"https://api.github.com/users/b-carter/repos","events_url":"https://api.github.com/users/b-carter/events{/privacy}","received_events_url":"https://api.github.com/users/b-carter/received_events","type":"User","site_admin":false},"repo":{"id":70720302,"name":"scipy","full_name":"b-carter/scipy","owner":{"login":"b-carter","id":6495170,"avatar_url":"https://avatars.githubusercontent.com/u/6495170?v=3","gravatar_id":"","url":"https://api.github.com/users/b-carter","html_url":"https://github.com/b-carter","followers_url":"https://api.github.com/users/b-carter/followers","following_url":"https://api.github.com/users/b-carter/following{/other_user}","gists_url":"https://api.github.com/users/b-carter/gists{/gist_id}","starred_url":"https://api.github.com/users/b-carter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-carter/subscriptions","organizations_url":"https://api.github.com/users/b-carter/orgs","repos_url":"https://api.github.com/users/b-carter/repos","events_url":"https://api.github.com/users/b-carter/events{/privacy}","received_events_url":"https://api.github.com/users/b-carter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/b-carter/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/b-carter/scipy","forks_url":"https://api.github.com/repos/b-carter/scipy/forks","keys_url":"https://api.github.com/repos/b-carter/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b-carter/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b-carter/scipy/teams","hooks_url":"https://api.github.com/repos/b-carter/scipy/hooks","issue_events_url":"https://api.github.com/repos/b-carter/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/b-carter/scipy/events","assignees_url":"https://api.github.com/repos/b-carter/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/b-carter/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/b-carter/scipy/tags","blobs_url":"https://api.github.com/repos/b-carter/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b-carter/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b-carter/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/b-carter/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b-carter/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/b-carter/scipy/languages","stargazers_url":"https://api.github.com/repos/b-carter/scipy/stargazers","contributors_url":"https://api.github.com/repos/b-carter/scipy/contributors","subscribers_url":"https://api.github.com/repos/b-carter/scipy/subscribers","subscription_url":"https://api.github.com/repos/b-carter/scipy/subscription","commits_url":"https://api.github.com/repos/b-carter/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/b-carter/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/b-carter/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/b-carter/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/b-carter/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/b-carter/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b-carter/scipy/merges","archive_url":"https://api.github.com/repos/b-carter/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b-carter/scipy/downloads","issues_url":"https://api.github.com/repos/b-carter/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/b-carter/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/b-carter/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/b-carter/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b-carter/scipy/labels{/name}","releases_url":"https://api.github.com/repos/b-carter/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/b-carter/scipy/deployments","created_at":"2016-10-12T16:42:01Z","updated_at":"2016-10-12T16:42:10Z","pushed_at":"2016-10-18T22:50:57Z","git_url":"git://github.com/b-carter/scipy.git","ssh_url":"git@github.com:b-carter/scipy.git","clone_url":"https://github.com/b-carter/scipy.git","svn_url":"https://github.com/b-carter/scipy","homepage":"http://scipy.org/scipylib/","size":62084,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"ef3d6b68e157b0a4302c41f5430f93a875e820ec","user":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2016-10-18T14:58:15Z","pushed_at":"2016-10-18T22:50:58Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"http://scipy.org/scipylib/","size":79344,"stargazers_count":2636,"watchers_count":2636,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1533,"mirror_url":null,"open_issues_count":965,"forks":1533,"open_issues":965,"watchers":2636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6691"},"html":{"href":"https://github.com/scipy/scipy/pull/6691"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/6691"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/6691/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6691/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6691/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/049a6116ffadf0bf17becda772f8f5834c03d322"}}}}
{"actor":{"display_login":"b-carter"}}