{"push_id":1324737603,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"9912c99cbd50bb17b5cc74076cb93891be209bb8","before":"b0ee963adf3e7be525d83d9a8a80fdd2f01009e6","commits":[{"sha":"cc48f2e22cbf05aa6665274059919d625c9ad9b7","author":{"name":"Martin Tomov","email":"997ae5d5240a7b4b186737a25d37bbc7c9cf6468@outlook.com"},"message":"Improve respond to JS from `OrdersController#populate` action\n\n  * Using an instance variable allows JS populate operations to have\n    access to the @order from within the rendered .js.erb files\n\n  * Assign all line_item errors to the order's base\n\n  * Allow to respond to JS requests for `#populate` and `#update` actions.\n    It is left for the developer to actually implement the `js.erb` views\n\nTo consider / TODO:\n\n  - to avoid the whole rescue operation, and manually assigning line item\n    errors to the order, we'd need to do to be doing `order.save`\n    instead of `line_item.save!` in [`OrderContents`](https://github.com/solidusio/solidus/blob/master/core/app/models/spree/order_contents.rb#L151)\n\n  -> That would have the effect to \"automatically\" assign the line item\n     errors on the order in the form: `line_items.quantity` in Rails 4.x\n     and \"line_items[0].quantity\" in Rails 5\n\n  More info:\n  - https://github.com/rails/rails/pull/8638\n  - https://github.com/rails/rails/pull/19686","distinct":true,"url":"https://api.github.com/repos/solidusio/solidus/commits/cc48f2e22cbf05aa6665274059919d625c9ad9b7"},{"sha":"a1be72217790a6673451641d871f5a1586958b1f","author":{"name":"Martin Tomov","email":"997ae5d5240a7b4b186737a25d37bbc7c9cf6468@outlook.com"},"message":"Improve respond to JS from `OrdersController#update` action\n\n  - move the non-redirect operations out of the html handling block, so\n    that they will also be executed on a JS format call\n\n  - add missing test for the click on the `checkout` button, which is\n    meant to advance the order instead of only updating the cart","distinct":true,"url":"https://api.github.com/repos/solidusio/solidus/commits/a1be72217790a6673451641d871f5a1586958b1f"},{"sha":"9912c99cbd50bb17b5cc74076cb93891be209bb8","author":{"name":"John Hawthorn","email":"e16f939e6ecfb0bd18aed8ce51dd3489d9b39eaa@gmail.com"},"message":"Merge pull request #1440 from mtomov/improve-populate-for-ajax\n\nImprove JS handling for OrdersController","distinct":true,"url":"https://api.github.com/repos/solidusio/solidus/commits/9912c99cbd50bb17b5cc74076cb93891be209bb8"}]}
{"actor":{"display_login":"jhawthorn"}}