{"action":"created","issue":{"url":"https://api.github.com/repos/computationalmodelling/fidimag/issues/58","repository_url":"https://api.github.com/repos/computationalmodelling/fidimag","labels_url":"https://api.github.com/repos/computationalmodelling/fidimag/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/computationalmodelling/fidimag/issues/58/comments","events_url":"https://api.github.com/repos/computationalmodelling/fidimag/issues/58/events","html_url":"https://github.com/computationalmodelling/fidimag/issues/58","id":164511078,"number":58,"title":"Clean up - tests","user":{"login":"ryanpepper","id":8539474,"avatar_url":"https://avatars.githubusercontent.com/u/8539474?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpepper","html_url":"https://github.com/ryanpepper","followers_url":"https://api.github.com/users/ryanpepper/followers","following_url":"https://api.github.com/users/ryanpepper/following{/other_user}","gists_url":"https://api.github.com/users/ryanpepper/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpepper/subscriptions","organizations_url":"https://api.github.com/users/ryanpepper/orgs","repos_url":"https://api.github.com/users/ryanpepper/repos","events_url":"https://api.github.com/users/ryanpepper/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpepper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/computationalmodelling/fidimag/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-08T11:23:35Z","updated_at":"2016-07-13T15:16:21Z","closed_at":"2016-07-13T15:16:21Z","body":"We have files all over the repository called things like integrators_test.py, cuboid_mesh_test.py.\r\n\r\nDo we need these, as they're not executed every time? And if so, I think it might be better to move them to the tests directory."},"comment":{"url":"https://api.github.com/repos/computationalmodelling/fidimag/issues/comments/232388022","html_url":"https://github.com/computationalmodelling/fidimag/issues/58#issuecomment-232388022","issue_url":"https://api.github.com/repos/computationalmodelling/fidimag/issues/58","id":232388022,"user":{"login":"fangohr","id":4489119,"avatar_url":"https://avatars.githubusercontent.com/u/4489119?v=3","gravatar_id":"","url":"https://api.github.com/users/fangohr","html_url":"https://github.com/fangohr","followers_url":"https://api.github.com/users/fangohr/followers","following_url":"https://api.github.com/users/fangohr/following{/other_user}","gists_url":"https://api.github.com/users/fangohr/gists{/gist_id}","starred_url":"https://api.github.com/users/fangohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fangohr/subscriptions","organizations_url":"https://api.github.com/users/fangohr/orgs","repos_url":"https://api.github.com/users/fangohr/repos","events_url":"https://api.github.com/users/fangohr/events{/privacy}","received_events_url":"https://api.github.com/users/fangohr/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T15:16:21Z","updated_at":"2016-07-13T15:16:21Z","body":"These tests can be run with `make test`. What we run on Travis is only `make test-basics`, for time reasons. So it is good to have those tests.\r\n\r\nRegarding the location: I am not sure - I would expect that a file test_x.py would probably start with `import x`, and thus it is practical to have the test file in the same directory as the code to be tested itself. \r\n\r\nSo in summary, I don't find it clear that the current setup is wrong. "}}
{"actor":{"display_login":"fangohr"}}