{"action":"opened","number":596,"pull_request":{"url":"https://api.github.com/repos/angular/universal/pulls/596","id":89583429,"html_url":"https://github.com/angular/universal/pull/596","diff_url":"https://github.com/angular/universal/pull/596.diff","patch_url":"https://github.com/angular/universal/pull/596.patch","issue_url":"https://api.github.com/repos/angular/universal/issues/596","number":596,"state":"open","locked":false,"title":"fix(ResourceLoader): provides ResourceLoader for not inlined templates","user":{"login":"jkuri","id":1796022,"avatar_url":"https://avatars.githubusercontent.com/u/1796022?v=3","gravatar_id":"","url":"https://api.github.com/users/jkuri","html_url":"https://github.com/jkuri","followers_url":"https://api.github.com/users/jkuri/followers","following_url":"https://api.github.com/users/jkuri/following{/other_user}","gists_url":"https://api.github.com/users/jkuri/gists{/gist_id}","starred_url":"https://api.github.com/users/jkuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkuri/subscriptions","organizations_url":"https://api.github.com/users/jkuri/orgs","repos_url":"https://api.github.com/users/jkuri/repos","events_url":"https://api.github.com/users/jkuri/events{/privacy}","received_events_url":"https://api.github.com/users/jkuri/received_events","type":"User","site_admin":false},"body":"- [ ] add simple test for that fix\r\n\r\nThis adds fix that templates does not have to be inlined.\r\nThis PR still need discussion if it's available to use this without `moduleId: module.id` option to get relative paths to templates. After chatting with Patrick there might be an option to let AoT compiler inline all templates.\r\n\r\n\\cc @gdi2290 ","created_at":"2016-10-17T08:54:27Z","updated_at":"2016-10-17T08:54:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35247a3933ec44f8cec3c65c49a0ab726b208377","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/universal/pulls/596/commits","review_comments_url":"https://api.github.com/repos/angular/universal/pulls/596/comments","review_comment_url":"https://api.github.com/repos/angular/universal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/universal/issues/596/comments","statuses_url":"https://api.github.com/repos/angular/universal/statuses/96bad03a3fa69a526ded5eb7c20da8783de230c2","head":{"label":"jkuri:resource-loader","ref":"resource-loader","sha":"96bad03a3fa69a526ded5eb7c20da8783de230c2","user":{"login":"jkuri","id":1796022,"avatar_url":"https://avatars.githubusercontent.com/u/1796022?v=3","gravatar_id":"","url":"https://api.github.com/users/jkuri","html_url":"https://github.com/jkuri","followers_url":"https://api.github.com/users/jkuri/followers","following_url":"https://api.github.com/users/jkuri/following{/other_user}","gists_url":"https://api.github.com/users/jkuri/gists{/gist_id}","starred_url":"https://api.github.com/users/jkuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkuri/subscriptions","organizations_url":"https://api.github.com/users/jkuri/orgs","repos_url":"https://api.github.com/users/jkuri/repos","events_url":"https://api.github.com/users/jkuri/events{/privacy}","received_events_url":"https://api.github.com/users/jkuri/received_events","type":"User","site_admin":false},"repo":{"id":70871821,"name":"universal","full_name":"jkuri/universal","owner":{"login":"jkuri","id":1796022,"avatar_url":"https://avatars.githubusercontent.com/u/1796022?v=3","gravatar_id":"","url":"https://api.github.com/users/jkuri","html_url":"https://github.com/jkuri","followers_url":"https://api.github.com/users/jkuri/followers","following_url":"https://api.github.com/users/jkuri/following{/other_user}","gists_url":"https://api.github.com/users/jkuri/gists{/gist_id}","starred_url":"https://api.github.com/users/jkuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkuri/subscriptions","organizations_url":"https://api.github.com/users/jkuri/orgs","repos_url":"https://api.github.com/users/jkuri/repos","events_url":"https://api.github.com/users/jkuri/events{/privacy}","received_events_url":"https://api.github.com/users/jkuri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkuri/universal","description":"Universal (isomorphic) javascript support for Angular2","fork":true,"url":"https://api.github.com/repos/jkuri/universal","forks_url":"https://api.github.com/repos/jkuri/universal/forks","keys_url":"https://api.github.com/repos/jkuri/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkuri/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkuri/universal/teams","hooks_url":"https://api.github.com/repos/jkuri/universal/hooks","issue_events_url":"https://api.github.com/repos/jkuri/universal/issues/events{/number}","events_url":"https://api.github.com/repos/jkuri/universal/events","assignees_url":"https://api.github.com/repos/jkuri/universal/assignees{/user}","branches_url":"https://api.github.com/repos/jkuri/universal/branches{/branch}","tags_url":"https://api.github.com/repos/jkuri/universal/tags","blobs_url":"https://api.github.com/repos/jkuri/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkuri/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkuri/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkuri/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkuri/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/jkuri/universal/languages","stargazers_url":"https://api.github.com/repos/jkuri/universal/stargazers","contributors_url":"https://api.github.com/repos/jkuri/universal/contributors","subscribers_url":"https://api.github.com/repos/jkuri/universal/subscribers","subscription_url":"https://api.github.com/repos/jkuri/universal/subscription","commits_url":"https://api.github.com/repos/jkuri/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkuri/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkuri/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkuri/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkuri/universal/contents/{+path}","compare_url":"https://api.github.com/repos/jkuri/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkuri/universal/merges","archive_url":"https://api.github.com/repos/jkuri/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkuri/universal/downloads","issues_url":"https://api.github.com/repos/jkuri/universal/issues{/number}","pulls_url":"https://api.github.com/repos/jkuri/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/jkuri/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/jkuri/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkuri/universal/labels{/name}","releases_url":"https://api.github.com/repos/jkuri/universal/releases{/id}","deployments_url":"https://api.github.com/repos/jkuri/universal/deployments","created_at":"2016-10-14T03:46:18Z","updated_at":"2016-10-14T03:46:20Z","pushed_at":"2016-10-17T08:48:10Z","git_url":"git://github.com/jkuri/universal.git","ssh_url":"git@github.com:jkuri/universal.git","clone_url":"https://github.com/jkuri/universal.git","svn_url":"https://github.com/jkuri/universal","homepage":null,"size":6072,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"97bf17df581e6a0383ab12471009169aee16ee44","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":37953959,"name":"universal","full_name":"angular/universal","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/universal","description":"Universal (isomorphic) javascript support for Angular2","fork":false,"url":"https://api.github.com/repos/angular/universal","forks_url":"https://api.github.com/repos/angular/universal/forks","keys_url":"https://api.github.com/repos/angular/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/universal/teams","hooks_url":"https://api.github.com/repos/angular/universal/hooks","issue_events_url":"https://api.github.com/repos/angular/universal/issues/events{/number}","events_url":"https://api.github.com/repos/angular/universal/events","assignees_url":"https://api.github.com/repos/angular/universal/assignees{/user}","branches_url":"https://api.github.com/repos/angular/universal/branches{/branch}","tags_url":"https://api.github.com/repos/angular/universal/tags","blobs_url":"https://api.github.com/repos/angular/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/universal/languages","stargazers_url":"https://api.github.com/repos/angular/universal/stargazers","contributors_url":"https://api.github.com/repos/angular/universal/contributors","subscribers_url":"https://api.github.com/repos/angular/universal/subscribers","subscription_url":"https://api.github.com/repos/angular/universal/subscription","commits_url":"https://api.github.com/repos/angular/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/universal/contents/{+path}","compare_url":"https://api.github.com/repos/angular/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/universal/merges","archive_url":"https://api.github.com/repos/angular/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/universal/downloads","issues_url":"https://api.github.com/repos/angular/universal/issues{/number}","pulls_url":"https://api.github.com/repos/angular/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/universal/labels{/name}","releases_url":"https://api.github.com/repos/angular/universal/releases{/id}","deployments_url":"https://api.github.com/repos/angular/universal/deployments","created_at":"2015-06-24T01:07:44Z","updated_at":"2016-10-17T05:52:53Z","pushed_at":"2016-10-17T08:54:27Z","git_url":"git://github.com/angular/universal.git","ssh_url":"git@github.com:angular/universal.git","clone_url":"https://github.com/angular/universal.git","svn_url":"https://github.com/angular/universal","homepage":null,"size":6072,"stargazers_count":1435,"watchers_count":1435,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":33,"forks":179,"open_issues":33,"watchers":1435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/universal/pulls/596"},"html":{"href":"https://github.com/angular/universal/pull/596"},"issue":{"href":"https://api.github.com/repos/angular/universal/issues/596"},"comments":{"href":"https://api.github.com/repos/angular/universal/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/universal/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/universal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/universal/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/angular/universal/statuses/96bad03a3fa69a526ded5eb7c20da8783de230c2"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jkuri"}}