{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/meta/issues/107","repository_url":"https://api.github.com/repos/dojo/meta","labels_url":"https://api.github.com/repos/dojo/meta/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/dojo/meta/issues/107/comments","events_url":"https://api.github.com/repos/dojo/meta/issues/107/events","html_url":"https://github.com/dojo/meta/issues/107","id":186587090,"number":107,"title":"Style Guide: Ordering","user":{"login":"msssk","id":931637,"avatar_url":"https://avatars.githubusercontent.com/u/931637?v=3","gravatar_id":"","url":"https://api.github.com/users/msssk","html_url":"https://github.com/msssk","followers_url":"https://api.github.com/users/msssk/followers","following_url":"https://api.github.com/users/msssk/following{/other_user}","gists_url":"https://api.github.com/users/msssk/gists{/gist_id}","starred_url":"https://api.github.com/users/msssk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msssk/subscriptions","organizations_url":"https://api.github.com/users/msssk/orgs","repos_url":"https://api.github.com/users/msssk/repos","events_url":"https://api.github.com/users/msssk/events{/privacy}","received_events_url":"https://api.github.com/users/msssk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-01T16:58:28Z","updated_at":"2016-12-13T20:08:13Z","closed_at":null,"body":"https://github.com/dojo/meta/blob/master/STYLE.md#ordering\r\n\r\nDo we want to revisit this? While this has been specified in Dojo's style guide for years, I personally have not seen it put into practice.\r\n\r\nMost commonly what I see is that methods are ordered in a way that someone new to the code, reading top to bottom, can get the best idea of what's going on. Alphabetic ordering does not serve this purpose.\r\n\r\nFor example, with Dijit widgets, methods are typically ordered with the lifecycle methods first, in order of execution. There may be more preferable approaches than alphabetic ordering, so it might be helpful to poll more people to see what they are actually doing, and decide if we want to strongly recommend people adhere to alphabetic ordering (and spell out what the benefits are), or if we want to revise our style guide recommendation."},"comment":{"url":"https://api.github.com/repos/dojo/meta/issues/comments/266847122","html_url":"https://github.com/dojo/meta/issues/107#issuecomment-266847122","issue_url":"https://api.github.com/repos/dojo/meta/issues/107","id":266847122,"user":{"login":"dylans","id":97291,"avatar_url":"https://avatars.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T20:08:13Z","updated_at":"2016-12-13T20:08:13Z","body":"@msssk I think these suggestions are reasonable. I'm not sure if we have made much use of _ in Dojo 2 (I know that today we renamed render to __render__ to indicate it should never be overridden. :)"}}
{"actor":{"display_login":"dylans"}}