{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/75073235","id":75073235,"diff_hunk":"@@ -2102,7 +2105,10 @@ def _minimize_scalar_golden(func, brack=None, args=(),\n     f1 = func(*((x1,) + args))\n     f2 = func(*((x2,) + args))\n     funcalls += 2\n-    while (numpy.abs(x3 - x0) > tol * (numpy.abs(x1) + numpy.abs(x2))):\n+    nit = 0\n+    for i in xrange(maxiter):","path":"scipy/optimize/optimize.py","position":45,"original_position":45,"commit_id":"6154f88b77815d5fc7e62705e2cb3084e67d8b44","original_commit_id":"77d86695f9aee2d1f9fbdc2de07c221610aaa0ee","user":{"login":"dlax","id":1046124,"avatar_url":"https://avatars.githubusercontent.com/u/1046124?v=3","gravatar_id":"","url":"https://api.github.com/users/dlax","html_url":"https://github.com/dlax","followers_url":"https://api.github.com/users/dlax/followers","following_url":"https://api.github.com/users/dlax/following{/other_user}","gists_url":"https://api.github.com/users/dlax/gists{/gist_id}","starred_url":"https://api.github.com/users/dlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlax/subscriptions","organizations_url":"https://api.github.com/users/dlax/orgs","repos_url":"https://api.github.com/users/dlax/repos","events_url":"https://api.github.com/users/dlax/events{/privacy}","received_events_url":"https://api.github.com/users/dlax/received_events","type":"User","site_admin":false},"body":"Yurii Shevchuk a écrit :\n> For instance it doesn't work when |maxiter = 1|. In this case |nit = 0|.\n>\n\nThen, wouldn't `for nit in xrange(1, maxiter + 1):` work?\n","created_at":"2016-08-17T07:20:56Z","updated_at":"2016-08-17T07:20:56Z","html_url":"https://github.com/scipy/scipy/pull/6489#discussion_r75073235","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/6489","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/75073235"},"html":{"href":"https://github.com/scipy/scipy/pull/6489#discussion_r75073235"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6489"}}},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/6489","id":81246156,"html_url":"https://github.com/scipy/scipy/pull/6489","diff_url":"https://github.com/scipy/scipy/pull/6489.diff","patch_url":"https://github.com/scipy/scipy/pull/6489.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/6489","number":6489,"state":"open","locked":false,"title":"Added maxiter option into golden search.","user":{"login":"itdxer","id":1621713,"avatar_url":"https://avatars.githubusercontent.com/u/1621713?v=3","gravatar_id":"","url":"https://api.github.com/users/itdxer","html_url":"https://github.com/itdxer","followers_url":"https://api.github.com/users/itdxer/followers","following_url":"https://api.github.com/users/itdxer/following{/other_user}","gists_url":"https://api.github.com/users/itdxer/gists{/gist_id}","starred_url":"https://api.github.com/users/itdxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itdxer/subscriptions","organizations_url":"https://api.github.com/users/itdxer/orgs","repos_url":"https://api.github.com/users/itdxer/repos","events_url":"https://api.github.com/users/itdxer/events{/privacy}","received_events_url":"https://api.github.com/users/itdxer/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-14T15:11:27Z","updated_at":"2016-08-17T07:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f915ddd9dd45963660bed24ccd7b2d4a538fc6d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/6489/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/6489/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/6489/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/6154f88b77815d5fc7e62705e2cb3084e67d8b44","head":{"label":"itdxer:golden-search-maxiter","ref":"golden-search-maxiter","sha":"6154f88b77815d5fc7e62705e2cb3084e67d8b44","user":{"login":"itdxer","id":1621713,"avatar_url":"https://avatars.githubusercontent.com/u/1621713?v=3","gravatar_id":"","url":"https://api.github.com/users/itdxer","html_url":"https://github.com/itdxer","followers_url":"https://api.github.com/users/itdxer/followers","following_url":"https://api.github.com/users/itdxer/following{/other_user}","gists_url":"https://api.github.com/users/itdxer/gists{/gist_id}","starred_url":"https://api.github.com/users/itdxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itdxer/subscriptions","organizations_url":"https://api.github.com/users/itdxer/orgs","repos_url":"https://api.github.com/users/itdxer/repos","events_url":"https://api.github.com/users/itdxer/events{/privacy}","received_events_url":"https://api.github.com/users/itdxer/received_events","type":"User","site_admin":false},"repo":{"id":65623354,"name":"scipy","full_name":"itdxer/scipy","owner":{"login":"itdxer","id":1621713,"avatar_url":"https://avatars.githubusercontent.com/u/1621713?v=3","gravatar_id":"","url":"https://api.github.com/users/itdxer","html_url":"https://github.com/itdxer","followers_url":"https://api.github.com/users/itdxer/followers","following_url":"https://api.github.com/users/itdxer/following{/other_user}","gists_url":"https://api.github.com/users/itdxer/gists{/gist_id}","starred_url":"https://api.github.com/users/itdxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itdxer/subscriptions","organizations_url":"https://api.github.com/users/itdxer/orgs","repos_url":"https://api.github.com/users/itdxer/repos","events_url":"https://api.github.com/users/itdxer/events{/privacy}","received_events_url":"https://api.github.com/users/itdxer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itdxer/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/itdxer/scipy","forks_url":"https://api.github.com/repos/itdxer/scipy/forks","keys_url":"https://api.github.com/repos/itdxer/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itdxer/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itdxer/scipy/teams","hooks_url":"https://api.github.com/repos/itdxer/scipy/hooks","issue_events_url":"https://api.github.com/repos/itdxer/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/itdxer/scipy/events","assignees_url":"https://api.github.com/repos/itdxer/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/itdxer/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/itdxer/scipy/tags","blobs_url":"https://api.github.com/repos/itdxer/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itdxer/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itdxer/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/itdxer/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itdxer/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/itdxer/scipy/languages","stargazers_url":"https://api.github.com/repos/itdxer/scipy/stargazers","contributors_url":"https://api.github.com/repos/itdxer/scipy/contributors","subscribers_url":"https://api.github.com/repos/itdxer/scipy/subscribers","subscription_url":"https://api.github.com/repos/itdxer/scipy/subscription","commits_url":"https://api.github.com/repos/itdxer/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/itdxer/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/itdxer/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/itdxer/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/itdxer/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/itdxer/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itdxer/scipy/merges","archive_url":"https://api.github.com/repos/itdxer/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itdxer/scipy/downloads","issues_url":"https://api.github.com/repos/itdxer/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/itdxer/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/itdxer/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/itdxer/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itdxer/scipy/labels{/name}","releases_url":"https://api.github.com/repos/itdxer/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/itdxer/scipy/deployments","created_at":"2016-08-13T15:19:08Z","updated_at":"2016-08-13T15:19:19Z","pushed_at":"2016-08-16T17:57:24Z","git_url":"git://github.com/itdxer/scipy.git","ssh_url":"git@github.com:itdxer/scipy.git","clone_url":"https://github.com/itdxer/scipy.git","svn_url":"https://github.com/itdxer/scipy","homepage":"http://scipy.org/scipylib/","size":59572,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"d2b4e1786bc4737849695c67f32fedd81ec9466b","user":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2016-08-17T01:34:36Z","pushed_at":"2016-08-17T06:16:34Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"http://scipy.org/scipylib/","size":76330,"stargazers_count":2517,"watchers_count":2517,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1460,"mirror_url":null,"open_issues_count":939,"forks":1460,"open_issues":939,"watchers":2517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6489"},"html":{"href":"https://github.com/scipy/scipy/pull/6489"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/6489"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/6489/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6489/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/6489/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/6154f88b77815d5fc7e62705e2cb3084e67d8b44"}}}}
{"actor":{"display_login":"dlax"}}