{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/49732932","id":49732932,"diff_hunk":"@@ -51,18 +50,73 @@\n       });\n     },\n \n+    /* Sends an SMS based on the specified parameter object.\n+     *\n+     * TODO: Splitting this complicated method\n+     * @param {object} options Options object that contains :-\n+     * - recipients (string or array of string): contains the list of\n+     *   recipients for this message\n+     * - content (string): the message's body\n+     * - serviceId (optional long or string): the SIM serviceId we use to send\n+     *   the message\n+     * - onsuccess (optional function): will be called when one SMS has been\n+     *   sent successfully, with the request's result as argument. Can be called\n+     *   several times.\n+     * - onerror (optional function): will be called when one SMS transmission\n+     *   failed, with the error object as argument. Can be called several times.\n+     * - oncomplete (optional function): will be called when all messages have\n+     *   been sent. It's argument will have the following properties:\n+     *   + hasError (boolean): whether we had at least one error\n+     *   + return (array): each item is an object with the following properties:\n+     *     . success (boolean): whether this is a success or an error\n+     *     . result (request's result): the request's result object\n+     *     . recipient (string): the recipient used for this transmission.\n+     * @returns {Promise}\n+     */\n     sendSMS(options) {\n       return client.method('sendSMS', options, appInstanceId);\n     },\n \n+    /* Sends an MMS based on the specified parameter object.\n+     * @param {Object} options Options object is the options field with the\n+     * following properties:\n+     * - recipients (string or array of string): recipients for this message.\n+     * - subject (optional string): subject for this message.\n+     * - content (array of SMIL slides): this is the content for the message\n+     *   (see ConversationView for more information).\n+     * - serviceId (optional long or string): the SIM that should be used for\n+     *   sending this message. If this is not the current default configuration\n+     *   for sending MMS, then we'll first switch the configuration to this\n+     *   serviceId, and only then send the message. That means that the\n+     *   \"sending\" event will come quite late in this case.\n+     * - onsuccess (optional func): called only once, even for several\n+     *   recipients, when the message is successfully sent.\n+     * - onerror (optional func): called only once if there is an error.\n+     * @returns {Promise}\n+     */\n     sendMMS(options) {\n       return client.method('sendMMS', options, appInstanceId);\n     },\n \n+    /**\n+     * Resends message with the given opts.\n+     * Takes a formatted message in case you happen to have one.\n+     * @param {object} message The message object containing all the information\n+     * depending on the type of the message which can be 'sms' or 'mms'.\n+     * @returns {Promise}\n+     */\n     resendMessage(message) {\n       return client.method('resendMessage', message, appInstanceId);\n     },\n \n+    /**\n+     * Gets the MMS object having a given id.\n+     * @param {number} id The id of the MMS we wish to get.\n+     * @return {DOMRequest.MmsMessage} A DOMRequest object to handle the success","path":"apps/sms/services/js/messaging/messaging_client.js","position":74,"original_position":74,"commit_id":"8981a7d2fa7e5ffca541b058d4565f71f3b0c376","original_commit_id":"8981a7d2fa7e5ffca541b058d4565f71f3b0c376","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"__nit:__ Looks like you've missed my previous comment - it should be ```{DOMRequest<MmsMessage>}```","created_at":"2016-01-14T14:40:36Z","updated_at":"2016-01-14T14:40:36Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/33202#discussion_r49732932","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/49732932"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/33202#discussion_r49732932"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202","id":50733485,"html_url":"https://github.com/mozilla-b2g/gaia/pull/33202","diff_url":"https://github.com/mozilla-b2g/gaia/pull/33202.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/33202.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33202","number":33202,"state":"open","locked":false,"title":"Bug 1223462 - adding documentation to message_manager.js","user":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"body":"I've added some basic documentation to the file. Do let me know the changes I need to adopt before I proceed with the rest of the functions. @azasypkin @kumarrishav ","created_at":"2015-11-14T22:04:09Z","updated_at":"2016-01-14T14:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"373593095ca87f762c52b52b94644fa0d041a3fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33202/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/8981a7d2fa7e5ffca541b058d4565f71f3b0c376","head":{"label":"martiansideofthemoon:my-code-fix","ref":"my-code-fix","sha":"8981a7d2fa7e5ffca541b058d4565f71f3b0c376","user":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"repo":{"id":41804608,"name":"gaia","full_name":"martiansideofthemoon/gaia","owner":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martiansideofthemoon/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/martiansideofthemoon/gaia","forks_url":"https://api.github.com/repos/martiansideofthemoon/gaia/forks","keys_url":"https://api.github.com/repos/martiansideofthemoon/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martiansideofthemoon/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martiansideofthemoon/gaia/teams","hooks_url":"https://api.github.com/repos/martiansideofthemoon/gaia/hooks","issue_events_url":"https://api.github.com/repos/martiansideofthemoon/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/martiansideofthemoon/gaia/events","assignees_url":"https://api.github.com/repos/martiansideofthemoon/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/martiansideofthemoon/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/martiansideofthemoon/gaia/tags","blobs_url":"https://api.github.com/repos/martiansideofthemoon/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martiansideofthemoon/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martiansideofthemoon/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/martiansideofthemoon/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martiansideofthemoon/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/martiansideofthemoon/gaia/languages","stargazers_url":"https://api.github.com/repos/martiansideofthemoon/gaia/stargazers","contributors_url":"https://api.github.com/repos/martiansideofthemoon/gaia/contributors","subscribers_url":"https://api.github.com/repos/martiansideofthemoon/gaia/subscribers","subscription_url":"https://api.github.com/repos/martiansideofthemoon/gaia/subscription","commits_url":"https://api.github.com/repos/martiansideofthemoon/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/martiansideofthemoon/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/martiansideofthemoon/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/martiansideofthemoon/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/martiansideofthemoon/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/martiansideofthemoon/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martiansideofthemoon/gaia/merges","archive_url":"https://api.github.com/repos/martiansideofthemoon/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martiansideofthemoon/gaia/downloads","issues_url":"https://api.github.com/repos/martiansideofthemoon/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/martiansideofthemoon/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/martiansideofthemoon/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/martiansideofthemoon/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martiansideofthemoon/gaia/labels{/name}","releases_url":"https://api.github.com/repos/martiansideofthemoon/gaia/releases{/id}","created_at":"2015-09-02T14:05:54Z","updated_at":"2015-09-02T14:06:25Z","pushed_at":"2016-01-13T20:31:15Z","git_url":"git://github.com/martiansideofthemoon/gaia.git","ssh_url":"git@github.com:martiansideofthemoon/gaia.git","clone_url":"https://github.com/martiansideofthemoon/gaia.git","svn_url":"https://github.com/martiansideofthemoon/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1001995,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"2e97f49e03878c9021f893a878283b7c34e76eaf","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2016-01-12T17:46:24Z","pushed_at":"2016-01-14T14:20:43Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1196121,"stargazers_count":2030,"watchers_count":2030,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2577,"mirror_url":null,"open_issues_count":1306,"forks":2577,"open_issues":1306,"watchers":2030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/33202"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33202"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/33202/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/33202/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/8981a7d2fa7e5ffca541b058d4565f71f3b0c376"}}}}