{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/54427490","id":54427490,"diff_hunk":"@@ -186,6 +186,11 @@ dummy:\n # Object backend\n #osd_objectstore: filestore\n \n+# xattrs. by default, 'filestore xattr use omap' is set to 'true' if\n+# ext4 if 'osd_mkfs_type' is set to 'ext4'; otherwise it isn't set. This\n+# can be set to 'true' or 'false' to explicitly override those defaults.\n+# filestore_xattr_use_omap: null","path":"group_vars/all.sample","position":null,"original_position":7,"commit_id":"cedec0d52f5123bef0d4cd28cd94e9454c18ecb6","original_commit_id":"019065e6ad6f678c2b28ba2dcda5339367d83346","user":{"login":"stpierre","id":632407,"avatar_url":"https://avatars.githubusercontent.com/u/632407?v=3","gravatar_id":"","url":"https://api.github.com/users/stpierre","html_url":"https://github.com/stpierre","followers_url":"https://api.github.com/users/stpierre/followers","following_url":"https://api.github.com/users/stpierre/following{/other_user}","gists_url":"https://api.github.com/users/stpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/stpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpierre/subscriptions","organizations_url":"https://api.github.com/users/stpierre/orgs","repos_url":"https://api.github.com/users/stpierre/repos","events_url":"https://api.github.com/users/stpierre/events{/privacy}","received_events_url":"https://api.github.com/users/stpierre/received_events","type":"User","site_admin":false},"body":"Docs fixed. I think I got lost halfway through that sentence.\r\n\r\n`false`/`null` doesn't really matter; it just needs to be a non-true value. But I think `null` is more intuitive, since the difference between `false` (the boolean) and `\"false\"` (the string) is super critical here and not super obvious. But if you've got religion about this being `false` I'll change it.","created_at":"2016-02-29T15:46:19Z","updated_at":"2016-02-29T15:46:19Z","html_url":"https://github.com/ceph/ceph-ansible/pull/553#discussion_r54427490","pull_request_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/54427490"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/553#discussion_r54427490"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553","id":60008055,"html_url":"https://github.com/ceph/ceph-ansible/pull/553","diff_url":"https://github.com/ceph/ceph-ansible/pull/553.diff","patch_url":"https://github.com/ceph/ceph-ansible/pull/553.patch","issue_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/553","number":553,"state":"open","locked":false,"title":"Use object map for xattrs with ext4","user":{"login":"stpierre","id":632407,"avatar_url":"https://avatars.githubusercontent.com/u/632407?v=3","gravatar_id":"","url":"https://api.github.com/users/stpierre","html_url":"https://github.com/stpierre","followers_url":"https://api.github.com/users/stpierre/followers","following_url":"https://api.github.com/users/stpierre/following{/other_user}","gists_url":"https://api.github.com/users/stpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/stpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpierre/subscriptions","organizations_url":"https://api.github.com/users/stpierre/orgs","repos_url":"https://api.github.com/users/stpierre/repos","events_url":"https://api.github.com/users/stpierre/events{/privacy}","received_events_url":"https://api.github.com/users/stpierre/received_events","type":"User","site_admin":false},"body":"These three commits add a number of useful tunables for the ceph.conf template.","created_at":"2016-02-19T21:12:31Z","updated_at":"2016-02-29T15:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37702d7337cd81bb7f9d2c81c2fa81fccedb2059","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/553/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/cedec0d52f5123bef0d4cd28cd94e9454c18ecb6","head":{"label":"stpierre:add-tunables","ref":"add-tunables","sha":"cedec0d52f5123bef0d4cd28cd94e9454c18ecb6","user":{"login":"stpierre","id":632407,"avatar_url":"https://avatars.githubusercontent.com/u/632407?v=3","gravatar_id":"","url":"https://api.github.com/users/stpierre","html_url":"https://github.com/stpierre","followers_url":"https://api.github.com/users/stpierre/followers","following_url":"https://api.github.com/users/stpierre/following{/other_user}","gists_url":"https://api.github.com/users/stpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/stpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpierre/subscriptions","organizations_url":"https://api.github.com/users/stpierre/orgs","repos_url":"https://api.github.com/users/stpierre/repos","events_url":"https://api.github.com/users/stpierre/events{/privacy}","received_events_url":"https://api.github.com/users/stpierre/received_events","type":"User","site_admin":false},"repo":{"id":52116626,"name":"ceph-ansible","full_name":"stpierre/ceph-ansible","owner":{"login":"stpierre","id":632407,"avatar_url":"https://avatars.githubusercontent.com/u/632407?v=3","gravatar_id":"","url":"https://api.github.com/users/stpierre","html_url":"https://github.com/stpierre","followers_url":"https://api.github.com/users/stpierre/followers","following_url":"https://api.github.com/users/stpierre/following{/other_user}","gists_url":"https://api.github.com/users/stpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/stpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpierre/subscriptions","organizations_url":"https://api.github.com/users/stpierre/orgs","repos_url":"https://api.github.com/users/stpierre/repos","events_url":"https://api.github.com/users/stpierre/events{/privacy}","received_events_url":"https://api.github.com/users/stpierre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stpierre/ceph-ansible","description":"Ansible playbooks for Ceph","fork":true,"url":"https://api.github.com/repos/stpierre/ceph-ansible","forks_url":"https://api.github.com/repos/stpierre/ceph-ansible/forks","keys_url":"https://api.github.com/repos/stpierre/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stpierre/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stpierre/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/stpierre/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/stpierre/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/stpierre/ceph-ansible/events","assignees_url":"https://api.github.com/repos/stpierre/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/stpierre/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/stpierre/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stpierre/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/stpierre/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/stpierre/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/stpierre/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/stpierre/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/stpierre/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/stpierre/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/stpierre/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/stpierre/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/stpierre/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/stpierre/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stpierre/ceph-ansible/merges","archive_url":"https://api.github.com/repos/stpierre/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stpierre/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/stpierre/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/stpierre/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/stpierre/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/stpierre/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stpierre/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/stpierre/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/stpierre/ceph-ansible/deployments","created_at":"2016-02-19T21:11:31Z","updated_at":"2016-02-19T21:11:32Z","pushed_at":"2016-02-29T15:45:00Z","git_url":"git://github.com/stpierre/ceph-ansible.git","ssh_url":"git@github.com:stpierre/ceph-ansible.git","clone_url":"https://github.com/stpierre/ceph-ansible.git","svn_url":"https://github.com/stpierre/ceph-ansible","homepage":null,"size":1048,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"8615dd0cce84c1e97fb433d31a96658914cf7b9b","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"name":"ceph-ansible","full_name":"ceph/ceph-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks for Ceph","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2016-02-25T20:07:34Z","pushed_at":"2016-02-29T15:45:01Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":null,"size":23480,"stargazers_count":207,"watchers_count":207,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":22,"forks":134,"open_issues":22,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/553"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/553"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/553/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/553/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-ansible/statuses/cedec0d52f5123bef0d4cd28cd94e9454c18ecb6"}}}}