{"action":"created","comment":{"url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/comments/76713313","id":76713313,"diff_hunk":"@@ -29,12 +29,17 @@\n   },\n   \"devDependencies\": {\n     \"angular-mocks\": \"^1.5.8\",\n+    \"eslint\": \"^3.4.0\",\n+    \"eslint-config-angular\": \"^0.5.0\",\n+    \"eslint-config-standard\": \"^6.0.0\",\n+    \"eslint-plugin-angular\": \"^1.3.1\",","path":"package.json","position":7,"original_position":7,"commit_id":"dc2626a09a05fb3f76db03ebe47de7b9dfcae140","original_commit_id":"dc2626a09a05fb3f76db03ebe47de7b9dfcae140","user":{"login":"charwking","id":5176154,"avatar_url":"https://avatars.githubusercontent.com/u/5176154?v=3","gravatar_id":"","url":"https://api.github.com/users/charwking","html_url":"https://github.com/charwking","followers_url":"https://api.github.com/users/charwking/followers","following_url":"https://api.github.com/users/charwking/following{/other_user}","gists_url":"https://api.github.com/users/charwking/gists{/gist_id}","starred_url":"https://api.github.com/users/charwking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charwking/subscriptions","organizations_url":"https://api.github.com/users/charwking/orgs","repos_url":"https://api.github.com/users/charwking/repos","events_url":"https://api.github.com/users/charwking/events{/privacy}","received_events_url":"https://api.github.com/users/charwking/received_events","type":"User","site_admin":false},"body":"I don't think `eslint` is needed since we're not using it directly. The `grunt-eslint` package brings `eslint` in as a dependency. Also, I don't think `eslint-config-standard` is being used, since it's not complaining about things in the code that violate [the standard rules](http://standardjs.com/).\r\n\r\nI have no idea if you can extend multiple configs -- this is my first experience with eslint.","created_at":"2016-08-30T00:34:01Z","updated_at":"2016-08-30T00:34:01Z","html_url":"https://github.com/charwking/gift-exchange-web/pull/25#discussion_r76713313","pull_request_url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/comments/76713313"},"html":{"href":"https://github.com/charwking/gift-exchange-web/pull/25#discussion_r76713313"},"pull_request":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25","id":83185488,"html_url":"https://github.com/charwking/gift-exchange-web/pull/25","diff_url":"https://github.com/charwking/gift-exchange-web/pull/25.diff","patch_url":"https://github.com/charwking/gift-exchange-web/pull/25.patch","issue_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues/25","number":25,"state":"open","locked":false,"title":"Adds eslint, fixes #21","user":{"login":"cwkingjr","id":4205364,"avatar_url":"https://avatars.githubusercontent.com/u/4205364?v=3","gravatar_id":"","url":"https://api.github.com/users/cwkingjr","html_url":"https://github.com/cwkingjr","followers_url":"https://api.github.com/users/cwkingjr/followers","following_url":"https://api.github.com/users/cwkingjr/following{/other_user}","gists_url":"https://api.github.com/users/cwkingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/cwkingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwkingjr/subscriptions","organizations_url":"https://api.github.com/users/cwkingjr/orgs","repos_url":"https://api.github.com/users/cwkingjr/repos","events_url":"https://api.github.com/users/cwkingjr/events{/privacy}","received_events_url":"https://api.github.com/users/cwkingjr/received_events","type":"User","site_admin":false},"body":"@charwking Adds ESLint with Angular plugin and sharable config.\r\n\r\nhttps://www.npmjs.com/package/eslint-plugin-angular\r\nhttps://github.com/dustinspecker/eslint-config-angular\r\n\r\nPrior to adding angular plugin/config, I was getting an \"angular\" not defined error in each js where you had angular.something declarations.","created_at":"2016-08-29T23:31:33Z","updated_at":"2016-08-30T00:34:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2f5e9e15e930b85d47c9e965ab47114a2441c7e","assignee":{"login":"cwkingjr","id":4205364,"avatar_url":"https://avatars.githubusercontent.com/u/4205364?v=3","gravatar_id":"","url":"https://api.github.com/users/cwkingjr","html_url":"https://github.com/cwkingjr","followers_url":"https://api.github.com/users/cwkingjr/followers","following_url":"https://api.github.com/users/cwkingjr/following{/other_user}","gists_url":"https://api.github.com/users/cwkingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/cwkingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwkingjr/subscriptions","organizations_url":"https://api.github.com/users/cwkingjr/orgs","repos_url":"https://api.github.com/users/cwkingjr/repos","events_url":"https://api.github.com/users/cwkingjr/events{/privacy}","received_events_url":"https://api.github.com/users/cwkingjr/received_events","type":"User","site_admin":false},"assignees":[{"login":"cwkingjr","id":4205364,"avatar_url":"https://avatars.githubusercontent.com/u/4205364?v=3","gravatar_id":"","url":"https://api.github.com/users/cwkingjr","html_url":"https://github.com/cwkingjr","followers_url":"https://api.github.com/users/cwkingjr/followers","following_url":"https://api.github.com/users/cwkingjr/following{/other_user}","gists_url":"https://api.github.com/users/cwkingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/cwkingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwkingjr/subscriptions","organizations_url":"https://api.github.com/users/cwkingjr/orgs","repos_url":"https://api.github.com/users/cwkingjr/repos","events_url":"https://api.github.com/users/cwkingjr/events{/privacy}","received_events_url":"https://api.github.com/users/cwkingjr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25/commits","review_comments_url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25/comments","review_comment_url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues/25/comments","statuses_url":"https://api.github.com/repos/charwking/gift-exchange-web/statuses/dc2626a09a05fb3f76db03ebe47de7b9dfcae140","head":{"label":"charwking:chuck-eslint","ref":"chuck-eslint","sha":"dc2626a09a05fb3f76db03ebe47de7b9dfcae140","user":{"login":"charwking","id":5176154,"avatar_url":"https://avatars.githubusercontent.com/u/5176154?v=3","gravatar_id":"","url":"https://api.github.com/users/charwking","html_url":"https://github.com/charwking","followers_url":"https://api.github.com/users/charwking/followers","following_url":"https://api.github.com/users/charwking/following{/other_user}","gists_url":"https://api.github.com/users/charwking/gists{/gist_id}","starred_url":"https://api.github.com/users/charwking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charwking/subscriptions","organizations_url":"https://api.github.com/users/charwking/orgs","repos_url":"https://api.github.com/users/charwking/repos","events_url":"https://api.github.com/users/charwking/events{/privacy}","received_events_url":"https://api.github.com/users/charwking/received_events","type":"User","site_admin":false},"repo":{"id":62591954,"name":"gift-exchange-web","full_name":"charwking/gift-exchange-web","owner":{"login":"charwking","id":5176154,"avatar_url":"https://avatars.githubusercontent.com/u/5176154?v=3","gravatar_id":"","url":"https://api.github.com/users/charwking","html_url":"https://github.com/charwking","followers_url":"https://api.github.com/users/charwking/followers","following_url":"https://api.github.com/users/charwking/following{/other_user}","gists_url":"https://api.github.com/users/charwking/gists{/gist_id}","starred_url":"https://api.github.com/users/charwking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charwking/subscriptions","organizations_url":"https://api.github.com/users/charwking/orgs","repos_url":"https://api.github.com/users/charwking/repos","events_url":"https://api.github.com/users/charwking/events{/privacy}","received_events_url":"https://api.github.com/users/charwking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charwking/gift-exchange-web","description":"Web client for a gift exchange application","fork":false,"url":"https://api.github.com/repos/charwking/gift-exchange-web","forks_url":"https://api.github.com/repos/charwking/gift-exchange-web/forks","keys_url":"https://api.github.com/repos/charwking/gift-exchange-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charwking/gift-exchange-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charwking/gift-exchange-web/teams","hooks_url":"https://api.github.com/repos/charwking/gift-exchange-web/hooks","issue_events_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues/events{/number}","events_url":"https://api.github.com/repos/charwking/gift-exchange-web/events","assignees_url":"https://api.github.com/repos/charwking/gift-exchange-web/assignees{/user}","branches_url":"https://api.github.com/repos/charwking/gift-exchange-web/branches{/branch}","tags_url":"https://api.github.com/repos/charwking/gift-exchange-web/tags","blobs_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charwking/gift-exchange-web/statuses/{sha}","languages_url":"https://api.github.com/repos/charwking/gift-exchange-web/languages","stargazers_url":"https://api.github.com/repos/charwking/gift-exchange-web/stargazers","contributors_url":"https://api.github.com/repos/charwking/gift-exchange-web/contributors","subscribers_url":"https://api.github.com/repos/charwking/gift-exchange-web/subscribers","subscription_url":"https://api.github.com/repos/charwking/gift-exchange-web/subscription","commits_url":"https://api.github.com/repos/charwking/gift-exchange-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/charwking/gift-exchange-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/charwking/gift-exchange-web/contents/{+path}","compare_url":"https://api.github.com/repos/charwking/gift-exchange-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charwking/gift-exchange-web/merges","archive_url":"https://api.github.com/repos/charwking/gift-exchange-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charwking/gift-exchange-web/downloads","issues_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues{/number}","pulls_url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls{/number}","milestones_url":"https://api.github.com/repos/charwking/gift-exchange-web/milestones{/number}","notifications_url":"https://api.github.com/repos/charwking/gift-exchange-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charwking/gift-exchange-web/labels{/name}","releases_url":"https://api.github.com/repos/charwking/gift-exchange-web/releases{/id}","deployments_url":"https://api.github.com/repos/charwking/gift-exchange-web/deployments","created_at":"2016-07-04T23:01:38Z","updated_at":"2016-08-06T17:08:32Z","pushed_at":"2016-08-29T23:31:33Z","git_url":"git://github.com/charwking/gift-exchange-web.git","ssh_url":"git@github.com:charwking/gift-exchange-web.git","clone_url":"https://github.com/charwking/gift-exchange-web.git","svn_url":"https://github.com/charwking/gift-exchange-web","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"charwking:master","ref":"master","sha":"fe4f408d3066abac3125161c219b6fbc157011b7","user":{"login":"charwking","id":5176154,"avatar_url":"https://avatars.githubusercontent.com/u/5176154?v=3","gravatar_id":"","url":"https://api.github.com/users/charwking","html_url":"https://github.com/charwking","followers_url":"https://api.github.com/users/charwking/followers","following_url":"https://api.github.com/users/charwking/following{/other_user}","gists_url":"https://api.github.com/users/charwking/gists{/gist_id}","starred_url":"https://api.github.com/users/charwking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charwking/subscriptions","organizations_url":"https://api.github.com/users/charwking/orgs","repos_url":"https://api.github.com/users/charwking/repos","events_url":"https://api.github.com/users/charwking/events{/privacy}","received_events_url":"https://api.github.com/users/charwking/received_events","type":"User","site_admin":false},"repo":{"id":62591954,"name":"gift-exchange-web","full_name":"charwking/gift-exchange-web","owner":{"login":"charwking","id":5176154,"avatar_url":"https://avatars.githubusercontent.com/u/5176154?v=3","gravatar_id":"","url":"https://api.github.com/users/charwking","html_url":"https://github.com/charwking","followers_url":"https://api.github.com/users/charwking/followers","following_url":"https://api.github.com/users/charwking/following{/other_user}","gists_url":"https://api.github.com/users/charwking/gists{/gist_id}","starred_url":"https://api.github.com/users/charwking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charwking/subscriptions","organizations_url":"https://api.github.com/users/charwking/orgs","repos_url":"https://api.github.com/users/charwking/repos","events_url":"https://api.github.com/users/charwking/events{/privacy}","received_events_url":"https://api.github.com/users/charwking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charwking/gift-exchange-web","description":"Web client for a gift exchange application","fork":false,"url":"https://api.github.com/repos/charwking/gift-exchange-web","forks_url":"https://api.github.com/repos/charwking/gift-exchange-web/forks","keys_url":"https://api.github.com/repos/charwking/gift-exchange-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charwking/gift-exchange-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charwking/gift-exchange-web/teams","hooks_url":"https://api.github.com/repos/charwking/gift-exchange-web/hooks","issue_events_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues/events{/number}","events_url":"https://api.github.com/repos/charwking/gift-exchange-web/events","assignees_url":"https://api.github.com/repos/charwking/gift-exchange-web/assignees{/user}","branches_url":"https://api.github.com/repos/charwking/gift-exchange-web/branches{/branch}","tags_url":"https://api.github.com/repos/charwking/gift-exchange-web/tags","blobs_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charwking/gift-exchange-web/statuses/{sha}","languages_url":"https://api.github.com/repos/charwking/gift-exchange-web/languages","stargazers_url":"https://api.github.com/repos/charwking/gift-exchange-web/stargazers","contributors_url":"https://api.github.com/repos/charwking/gift-exchange-web/contributors","subscribers_url":"https://api.github.com/repos/charwking/gift-exchange-web/subscribers","subscription_url":"https://api.github.com/repos/charwking/gift-exchange-web/subscription","commits_url":"https://api.github.com/repos/charwking/gift-exchange-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/charwking/gift-exchange-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/charwking/gift-exchange-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/charwking/gift-exchange-web/contents/{+path}","compare_url":"https://api.github.com/repos/charwking/gift-exchange-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charwking/gift-exchange-web/merges","archive_url":"https://api.github.com/repos/charwking/gift-exchange-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charwking/gift-exchange-web/downloads","issues_url":"https://api.github.com/repos/charwking/gift-exchange-web/issues{/number}","pulls_url":"https://api.github.com/repos/charwking/gift-exchange-web/pulls{/number}","milestones_url":"https://api.github.com/repos/charwking/gift-exchange-web/milestones{/number}","notifications_url":"https://api.github.com/repos/charwking/gift-exchange-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charwking/gift-exchange-web/labels{/name}","releases_url":"https://api.github.com/repos/charwking/gift-exchange-web/releases{/id}","deployments_url":"https://api.github.com/repos/charwking/gift-exchange-web/deployments","created_at":"2016-07-04T23:01:38Z","updated_at":"2016-08-06T17:08:32Z","pushed_at":"2016-08-29T23:31:33Z","git_url":"git://github.com/charwking/gift-exchange-web.git","ssh_url":"git@github.com:charwking/gift-exchange-web.git","clone_url":"https://github.com/charwking/gift-exchange-web.git","svn_url":"https://github.com/charwking/gift-exchange-web","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25"},"html":{"href":"https://github.com/charwking/gift-exchange-web/pull/25"},"issue":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/issues/25"},"comments":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/charwking/gift-exchange-web/statuses/dc2626a09a05fb3f76db03ebe47de7b9dfcae140"}}}}
{"actor":{"display_login":"charwking"}}