{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/90137426","pull_request_review_id":10661559,"id":90137426,"diff_hunk":"@@ -397,6 +397,31 @@ public void RegisterStreamProvider(string providerTypeFullName, string providerN\n             ProviderConfigurationUtility.RegisterProvider(ProviderConfigurations, ProviderCategoryConfiguration.STREAM_PROVIDER_CATEGORY_NAME, providerTypeFullName, providerName, properties);\n         }\n \n+\n+        public void RegisterStatisticsProvider<T>(string providerName, IDictionary<string, string> properties = null) where T : IStatisticsPublisher, IClientMetricsDataPublisher\n+        {\n+            TypeInfo providerTypeInfo = typeof(T).GetTypeInfo();\n+            if (providerTypeInfo.IsAbstract ||\n+                providerTypeInfo.IsGenericType ||\n+                providerTypeInfo.IsGenericType ||\n+                !(\n+                typeof(IStatisticsPublisher).IsAssignableFrom(providerTypeInfo) &&\n+                typeof(IClientMetricsDataPublisher).IsAssignableFrom(providerTypeInfo)\n+                ))","path":"src/Orleans/Configuration/ClientConfiguration.cs","position":14,"original_position":14,"commit_id":"46c5d8ea859d51e6c948739563bf3511d274acfd","original_commit_id":"46c5d8ea859d51e6c948739563bf3511d274acfd","user":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars.githubusercontent.com/u/20803801?v=3","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"body":"Your build in netstandard environment failed on \r\n\r\n> \\src\\Orleans\\Configuration\\ClientConfiguration.cs(408,63): error CS1503: Argument 2: cannot convert from 'System.Reflection.TypeInfo' to 'System.Type' \r\n\r\nBecause in netstandard, `TypeInfo `doesn't Inherit `Type` class anymore. And signature of `IsAssignableFrom` is \r\n`Type.IsAssignableFrom(System.Type).` You need to do \r\nTypeproviderType = typeof(T).GetType(); \r\n","created_at":"2016-11-29T23:16:54Z","updated_at":"2016-11-29T23:16:55Z","html_url":"https://github.com/dotnet/orleans/pull/2371#discussion_r90137426","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/2371","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/90137426"},"html":{"href":"https://github.com/dotnet/orleans/pull/2371#discussion_r90137426"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2371"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/2371","id":91508992,"html_url":"https://github.com/dotnet/orleans/pull/2371","diff_url":"https://github.com/dotnet/orleans/pull/2371.diff","patch_url":"https://github.com/dotnet/orleans/pull/2371.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/2371","number":2371,"state":"open","locked":false,"title":"RegisterStatisticsProvider and ShardedStorageProvider","user":{"login":"amccool","id":191144,"avatar_url":"https://avatars.githubusercontent.com/u/191144?v=3","gravatar_id":"","url":"https://api.github.com/users/amccool","html_url":"https://github.com/amccool","followers_url":"https://api.github.com/users/amccool/followers","following_url":"https://api.github.com/users/amccool/following{/other_user}","gists_url":"https://api.github.com/users/amccool/gists{/gist_id}","starred_url":"https://api.github.com/users/amccool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amccool/subscriptions","organizations_url":"https://api.github.com/users/amccool/orgs","repos_url":"https://api.github.com/users/amccool/repos","events_url":"https://api.github.com/users/amccool/events{/privacy}","received_events_url":"https://api.github.com/users/amccool/received_events","type":"User","site_admin":false},"body":"this PR is for #2232.   Leaving only the geo-cluster tests using TestingSiloHost.\n\nWhile the BVT's are green, the implementation of `RegisterStatisticsProvider` and the usage `RegisterStorageProvider<ShardedStorageProvider>` do not work fully.\n\nI wanted to get this out for feedback\n","created_at":"2016-10-30T02:36:51Z","updated_at":"2016-11-29T23:16:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2fc9c5a395a02844465f6d3b13f639b14a10813","assignee":{"login":"jdom","id":1361686,"avatar_url":"https://avatars.githubusercontent.com/u/1361686?v=3","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdom","id":1361686,"avatar_url":"https://avatars.githubusercontent.com/u/1361686?v=3","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/orleans/milestones/14","html_url":"https://github.com/dotnet/orleans/milestones/1.4.0","labels_url":"https://api.github.com/repos/dotnet/orleans/milestones/14/labels","id":2017852,"number":14,"title":"1.4.0","description":"","creator":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars.githubusercontent.com/u/8248806?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":20,"state":"open","created_at":"2016-09-20T23:16:17Z","updated_at":"2016-11-29T21:45:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/2371/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/2371/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/2371/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/46c5d8ea859d51e6c948739563bf3511d274acfd","head":{"label":"amccool:Partial-implemation-of-RegisterStatisticsProvider","ref":"Partial-implemation-of-RegisterStatisticsProvider","sha":"46c5d8ea859d51e6c948739563bf3511d274acfd","user":{"login":"amccool","id":191144,"avatar_url":"https://avatars.githubusercontent.com/u/191144?v=3","gravatar_id":"","url":"https://api.github.com/users/amccool","html_url":"https://github.com/amccool","followers_url":"https://api.github.com/users/amccool/followers","following_url":"https://api.github.com/users/amccool/following{/other_user}","gists_url":"https://api.github.com/users/amccool/gists{/gist_id}","starred_url":"https://api.github.com/users/amccool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amccool/subscriptions","organizations_url":"https://api.github.com/users/amccool/orgs","repos_url":"https://api.github.com/users/amccool/repos","events_url":"https://api.github.com/users/amccool/events{/privacy}","received_events_url":"https://api.github.com/users/amccool/received_events","type":"User","site_admin":false},"repo":{"id":39597014,"name":"orleans","full_name":"amccool/orleans","owner":{"login":"amccool","id":191144,"avatar_url":"https://avatars.githubusercontent.com/u/191144?v=3","gravatar_id":"","url":"https://api.github.com/users/amccool","html_url":"https://github.com/amccool","followers_url":"https://api.github.com/users/amccool/followers","following_url":"https://api.github.com/users/amccool/following{/other_user}","gists_url":"https://api.github.com/users/amccool/gists{/gist_id}","starred_url":"https://api.github.com/users/amccool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amccool/subscriptions","organizations_url":"https://api.github.com/users/amccool/orgs","repos_url":"https://api.github.com/users/amccool/repos","events_url":"https://api.github.com/users/amccool/events{/privacy}","received_events_url":"https://api.github.com/users/amccool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amccool/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/amccool/orleans","forks_url":"https://api.github.com/repos/amccool/orleans/forks","keys_url":"https://api.github.com/repos/amccool/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amccool/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amccool/orleans/teams","hooks_url":"https://api.github.com/repos/amccool/orleans/hooks","issue_events_url":"https://api.github.com/repos/amccool/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/amccool/orleans/events","assignees_url":"https://api.github.com/repos/amccool/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/amccool/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/amccool/orleans/tags","blobs_url":"https://api.github.com/repos/amccool/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amccool/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amccool/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/amccool/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amccool/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/amccool/orleans/languages","stargazers_url":"https://api.github.com/repos/amccool/orleans/stargazers","contributors_url":"https://api.github.com/repos/amccool/orleans/contributors","subscribers_url":"https://api.github.com/repos/amccool/orleans/subscribers","subscription_url":"https://api.github.com/repos/amccool/orleans/subscription","commits_url":"https://api.github.com/repos/amccool/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/amccool/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/amccool/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/amccool/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/amccool/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/amccool/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amccool/orleans/merges","archive_url":"https://api.github.com/repos/amccool/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amccool/orleans/downloads","issues_url":"https://api.github.com/repos/amccool/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/amccool/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/amccool/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/amccool/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amccool/orleans/labels{/name}","releases_url":"https://api.github.com/repos/amccool/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/amccool/orleans/deployments","created_at":"2015-07-23T22:31:25Z","updated_at":"2016-01-22T06:00:59Z","pushed_at":"2016-11-18T00:35:33Z","git_url":"git://github.com/amccool/orleans.git","ssh_url":"git@github.com:amccool/orleans.git","clone_url":"https://github.com/amccool/orleans.git","svn_url":"https://github.com/amccool/orleans","homepage":"http://dotnet.github.io/orleans","size":31420,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"873bb89921f92549b11e487c84b3e581357bccb5","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2016-11-29T17:49:28Z","pushed_at":"2016-11-29T23:06:17Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":52497,"stargazers_count":2388,"watchers_count":2388,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":592,"mirror_url":null,"open_issues_count":244,"forks":592,"open_issues":244,"watchers":2388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2371"},"html":{"href":"https://github.com/dotnet/orleans/pull/2371"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2371"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2371/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2371/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2371/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/46c5d8ea859d51e6c948739563bf3511d274acfd"}}}}
{"actor":{"display_login":"xiazen"}}