{"action":"created","issue":{"url":"https://api.github.com/repos/oscarlopezalegre/homework2/issues/1","labels_url":"https://api.github.com/repos/oscarlopezalegre/homework2/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/oscarlopezalegre/homework2/issues/1/comments","events_url":"https://api.github.com/repos/oscarlopezalegre/homework2/issues/1/events","html_url":"https://github.com/oscarlopezalegre/homework2/issues/1","id":122115876,"number":1,"title":"Finished ","user":{"login":"oscarlopezalegre","id":16038394,"avatar_url":"https://avatars.githubusercontent.com/u/16038394?v=3","gravatar_id":"","url":"https://api.github.com/users/oscarlopezalegre","html_url":"https://github.com/oscarlopezalegre","followers_url":"https://api.github.com/users/oscarlopezalegre/followers","following_url":"https://api.github.com/users/oscarlopezalegre/following{/other_user}","gists_url":"https://api.github.com/users/oscarlopezalegre/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarlopezalegre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarlopezalegre/subscriptions","organizations_url":"https://api.github.com/users/oscarlopezalegre/orgs","repos_url":"https://api.github.com/users/oscarlopezalegre/repos","events_url":"https://api.github.com/users/oscarlopezalegre/events{/privacy}","received_events_url":"https://api.github.com/users/oscarlopezalegre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-14T19:45:03Z","updated_at":"2016-01-11T15:41:01Z","closed_at":null,"body":"Dear @coderschoolreview,\r\n\r\nFind my homework for last week.\r\n\r\nI have some known issues due to lack of time:\r\n- You must use a real email account (but I'm not verifying)\r\n- If email crash it will fail.\r\n- Blocking do not have effect\r\n\r\nRegards,\r\nOscar"},"comment":{"url":"https://api.github.com/repos/oscarlopezalegre/homework2/issues/comments/170590799","html_url":"https://github.com/oscarlopezalegre/homework2/issues/1#issuecomment-170590799","issue_url":"https://api.github.com/repos/oscarlopezalegre/homework2/issues/1","id":170590799,"user":{"login":"chug2k","id":44512,"avatar_url":"https://avatars.githubusercontent.com/u/44512?v=3","gravatar_id":"","url":"https://api.github.com/users/chug2k","html_url":"https://github.com/chug2k","followers_url":"https://api.github.com/users/chug2k/followers","following_url":"https://api.github.com/users/chug2k/following{/other_user}","gists_url":"https://api.github.com/users/chug2k/gists{/gist_id}","starred_url":"https://api.github.com/users/chug2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chug2k/subscriptions","organizations_url":"https://api.github.com/users/chug2k/orgs","repos_url":"https://api.github.com/users/chug2k/repos","events_url":"https://api.github.com/users/chug2k/events{/privacy}","received_events_url":"https://api.github.com/users/chug2k/received_events","type":"User","site_admin":false},"created_at":"2016-01-11T15:41:01Z","updated_at":"2016-01-11T15:41:01Z","body":"Good work, and sorry for the slow review! This homework is on authentication, using ActiveRecord::Relation, dealing with model associations, using partials, and the items under Bonus help with upcoming topics we will cover.\r\n\r\nOscar, I'm very surprised by this homework! You clearly put in a lot of time. :clap: :bow: Good stuff! Amazing that you did so many optional tasks. Facebook Login, Email, attachments...wowza.  :100: \r\n\r\n### Suggestions\r\n\r\n* Please fix your tabbing. It seems minor, but is especially hard for people to collaborate with you since your code style is messy. The code itself is good, the formatting is not (and easy to fix).\r\n* Rather than checking `if session[:userid]` everywhere directly, use the `current_user` method. So instead of \r\n```ruby\r\n    if session[:userid] != message.recipient\r\n```\r\nYou can do something like\r\n```\r\n  if current_user != message.recipient\r\n```\r\n( move current_user out of `private` in `application_controller` so you can inherit it properly)\r\n\r\nWe talked more about `deliver_later` in lecture, which you may find useful in future classes. In general, I think you did a great job with the homework. Things are rough around the edges - for the final demo, you'll have to polish them out. But I think you did a great job demonstrating you know what's going on!"}}