{"action":"created","issue":{"url":"https://api.github.com/repos/alexreisner/geocoder/issues/1056","repository_url":"https://api.github.com/repos/alexreisner/geocoder","labels_url":"https://api.github.com/repos/alexreisner/geocoder/issues/1056/labels{/name}","comments_url":"https://api.github.com/repos/alexreisner/geocoder/issues/1056/comments","events_url":"https://api.github.com/repos/alexreisner/geocoder/issues/1056/events","html_url":"https://github.com/alexreisner/geocoder/pull/1056","id":156860147,"number":1056,"title":"adds test for esri token generation from client credentials","user":{"login":"aaronpk","id":113001,"avatar_url":"https://avatars.githubusercontent.com/u/113001?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronpk","html_url":"https://github.com/aaronpk","followers_url":"https://api.github.com/users/aaronpk/followers","following_url":"https://api.github.com/users/aaronpk/following{/other_user}","gists_url":"https://api.github.com/users/aaronpk/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronpk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronpk/subscriptions","organizations_url":"https://api.github.com/users/aaronpk/orgs","repos_url":"https://api.github.com/users/aaronpk/repos","events_url":"https://api.github.com/users/aaronpk/events{/privacy}","received_events_url":"https://api.github.com/users/aaronpk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-25T22:00:03Z","updated_at":"2016-05-26T00:43:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alexreisner/geocoder/pulls/1056","html_url":"https://github.com/alexreisner/geocoder/pull/1056","diff_url":"https://github.com/alexreisner/geocoder/pull/1056.diff","patch_url":"https://github.com/alexreisner/geocoder/pull/1056.patch"},"body":"This stubs the `generate_token` method only within this test. This brings the test coverage of `Geocoder::Lookup::Esri` closer to 100%."},"comment":{"url":"https://api.github.com/repos/alexreisner/geocoder/issues/comments/221748595","html_url":"https://github.com/alexreisner/geocoder/pull/1056#issuecomment-221748595","issue_url":"https://api.github.com/repos/alexreisner/geocoder/issues/1056","id":221748595,"user":{"login":"alexreisner","id":32069,"avatar_url":"https://avatars.githubusercontent.com/u/32069?v=3","gravatar_id":"","url":"https://api.github.com/users/alexreisner","html_url":"https://github.com/alexreisner","followers_url":"https://api.github.com/users/alexreisner/followers","following_url":"https://api.github.com/users/alexreisner/following{/other_user}","gists_url":"https://api.github.com/users/alexreisner/gists{/gist_id}","starred_url":"https://api.github.com/users/alexreisner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexreisner/subscriptions","organizations_url":"https://api.github.com/users/alexreisner/orgs","repos_url":"https://api.github.com/users/alexreisner/repos","events_url":"https://api.github.com/users/alexreisner/events{/privacy}","received_events_url":"https://api.github.com/users/alexreisner/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T00:43:27Z","updated_at":"2016-05-26T00:43:27Z","body":"> ...stubbing the `create_token` method on the ESRI lookup instance in the test (using `instance_eval` or something similar). This way we can avoid stubbing (and then not unstubbing) important methods in the code.\r\n\r\nWhat I mean is something like this:\r\n\r\n    lookup.instance_eval do\r\n      # redefine `create_token` to return a manually-created token\r\n    end\r\n\r\nWe don't want to touch any classes, only the particular instance we're testing.\r\n"}}
{"actor":{"display_login":"alexreisner"}}