{"action":"created","issue":{"url":"https://api.github.com/repos/acemod/ACE3/issues/3561","repository_url":"https://api.github.com/repos/acemod/ACE3","labels_url":"https://api.github.com/repos/acemod/ACE3/issues/3561/labels{/name}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/3561/comments","events_url":"https://api.github.com/repos/acemod/ACE3/issues/3561/events","html_url":"https://github.com/acemod/ACE3/pull/3561","id":139168406,"number":3561,"title":"FCS and Scopes with no compat pbo required","user":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"labels":[{"id":164932009,"url":"https://api.github.com/repos/acemod/ACE3/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":221216927,"url":"https://api.github.com/repos/acemod/ACE3/labels/experimental","name":"experimental","color":"fad8c7","default":false},{"id":164932010,"url":"https://api.github.com/repos/acemod/ACE3/labels/needs%20testing","name":"needs testing","color":"159818","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/2","html_url":"https://github.com/acemod/ACE3/milestones/Backlog","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/2/labels","id":941455,"number":2,"title":"Backlog","description":"Tasks that have a specific end point, but no due date.","creator":{"login":"bux578","id":1235520,"avatar_url":"https://avatars.githubusercontent.com/u/1235520?v=3","gravatar_id":"","url":"https://api.github.com/users/bux578","html_url":"https://github.com/bux578","followers_url":"https://api.github.com/users/bux578/followers","following_url":"https://api.github.com/users/bux578/following{/other_user}","gists_url":"https://api.github.com/users/bux578/gists{/gist_id}","starred_url":"https://api.github.com/users/bux578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bux578/subscriptions","organizations_url":"https://api.github.com/users/bux578/orgs","repos_url":"https://api.github.com/users/bux578/repos","events_url":"https://api.github.com/users/bux578/events{/privacy}","received_events_url":"https://api.github.com/users/bux578/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":118,"state":"open","created_at":"2015-01-19T08:37:47Z","updated_at":"2016-10-21T06:25:34Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-03-08T03:25:45Z","updated_at":"2016-10-29T12:13:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/3561","html_url":"https://github.com/acemod/ACE3/pull/3561","diff_url":"https://github.com/acemod/ACE3/pull/3561.diff","patch_url":"https://github.com/acemod/ACE3/pull/3561.patch"},"body":"**Experimental**\r\n\r\n**When merged this pull request will:**\r\n- Add a correction to ACE_FCS to account for vanilla zeroing\r\n- Allow ACE_FCS to work without requiring a compatibility PBO\r\n- Add a correction to ACE_Scopes to account for vanilla zeroing\r\n- Allow ACE_Scopes to work without requiring a compatibility PBO\r\n\r\n**Rationale**\r\nThere are currently 4 ACE systems that require \"ACE-Exclusive\" compatibility PBOs (that cannot be included in the content without breaking it for vanilla):\r\n- FCS (`discreteDistance[] = {}`)\r\n- Scopes (`discreteDistance[] = {}`)\r\n- Explosives\r\n- Disposable\r\n\r\n~~The technique applied in this PR could also be applied to scopes~~ (done), so the only remaining systems would be explosives and disposable, which affect only a minimum fraction of third party content (e.g., doesn't affect vehicles nor small arms).\r\n\r\nThe current fix is fast (the extension takes 0.01 ms to calculate, and only is required to do so once every time the unit changes zeroing, weapon or ammo) and seems to be as accurate. Fortunately `currentZeroing` works properly with remote units.\r\n\r\n**TODO** \r\n- [ ] Hide the vanilla zeroing control when appropiate, so the end user won't even know it's still enabled. Tagging @jonpas for advice\r\n- [ ] Restore `discreteDistance[] = {}` for vanilla content?\r\n- [ ] Correctly compute the initSpeed from config instead of getting it from the bullet?"},"comment":{"url":"https://api.github.com/repos/acemod/ACE3/issues/comments/257088375","html_url":"https://github.com/acemod/ACE3/pull/3561#issuecomment-257088375","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/3561","id":257088375,"user":{"login":"ulteq","id":9437207,"avatar_url":"https://avatars.githubusercontent.com/u/9437207?v=3","gravatar_id":"","url":"https://api.github.com/users/ulteq","html_url":"https://github.com/ulteq","followers_url":"https://api.github.com/users/ulteq/followers","following_url":"https://api.github.com/users/ulteq/following{/other_user}","gists_url":"https://api.github.com/users/ulteq/gists{/gist_id}","starred_url":"https://api.github.com/users/ulteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulteq/subscriptions","organizations_url":"https://api.github.com/users/ulteq/orgs","repos_url":"https://api.github.com/users/ulteq/repos","events_url":"https://api.github.com/users/ulteq/events{/privacy}","received_events_url":"https://api.github.com/users/ulteq/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T12:13:52Z","updated_at":"2016-10-29T12:13:52Z","body":"> I added a first implementation of the correction to ACE_Scopes.\r\n\r\nWon't this cause all scopes to be zeroed at 0 meters?"}}
{"actor":{"display_login":"ulteq"}}