{"action":"opened","number":7945,"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/7945","id":97499230,"html_url":"https://github.com/syl20bnr/spacemacs/pull/7945","diff_url":"https://github.com/syl20bnr/spacemacs/pull/7945.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/7945.patch","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7945","number":7945,"state":"open","locked":false,"title":"Colors Layer: Major layer enhancements and bug fixes","user":{"login":"SteveJobzniak","id":22373193,"avatar_url":"https://avatars.githubusercontent.com/u/22373193?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveJobzniak","html_url":"https://github.com/SteveJobzniak","followers_url":"https://api.github.com/users/SteveJobzniak/followers","following_url":"https://api.github.com/users/SteveJobzniak/following{/other_user}","gists_url":"https://api.github.com/users/SteveJobzniak/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveJobzniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveJobzniak/subscriptions","organizations_url":"https://api.github.com/users/SteveJobzniak/orgs","repos_url":"https://api.github.com/users/SteveJobzniak/repos","events_url":"https://api.github.com/users/SteveJobzniak/events{/privacy}","received_events_url":"https://api.github.com/users/SteveJobzniak/received_events","type":"User","site_admin":false},"body":"Here are some major enhancements which make the \"colors\" layer suck a _lot_ less. Please consider merging these quickly into the next release. Because the current layer as-provided in Spacemacs is _full_ of hardcoded nonsense and bugs which makes it nearly useless (compared to just manually adding a package and having full control).\r\n\r\n**Fixed and added:**\r\n- Keybinding documentation has been corrected to reflect earlier code changes that moved color toggles to `<SPC tC>`.\r\n- The messy documentation has been rewritten to fix bugs, straighten out terminology, and to make people's heads spin less.\r\n- Added the ability to set the default saturation and lightness of rainbow-identifiers for any themes that haven't been manually overriden, instead of being forced to live with what the earliest author of this layer liked.\r\n- Improved resetting of saturation and lightness in the transient-state, so that it now resets to the user's own defaults.\r\n- Added support for 9 new themes, and updated the defaults for some old definitions to much more closely match the \"spirit\" of each theme's individual intended brightness and saturation level.\r\n- Major fix to actually render the user's desired per-theme rainbow-identifiers settings when switching theme. This solves the theme switching bug where you get stuck with an ugly mishmash of old colors and a new theme.\r\n- Faster method of redrawing buffer for transient state.\r\n\r\n**Future wishlist, because I don't have more time:**\r\n- Enhance the transient-state resetting even further, so that it resets to the default that would be used for that theme.\r\n- Add the ability to set theme colors via a variable in :variables. Although, this is pretty much a non-issue after my documentation fixes that describe how to currently achieve it.\r\n\r\n**Bonus for end-users:**\r\n\r\nKnowing that it sometimes takes months for a merge, I've created a private version of this exact code and renamed it to \"paintvars\" to avoid \"Duplicate layer\" errors. So just in case anyone wants to use this massively enhanced \"colors\" layer right away together with their normal non-development Spacemacs, you can just do the following to put it in your private layers folder, which will allow you to use it in your config just like any normal Spacemacs layer:\r\n\r\n```bash\r\ngit clone https://github.com/SteveJobzniak/spacemacs-private-paintvars.git ~/.emacs.d/private/paintvars\r\n```\r\n\r\nHere's the documentation, with the renamed variables (every setting is literally the same as \"colors\" but with the word replaced with \"paintvars\"):\r\nhttps://github.com/SteveJobzniak/spacemacs-private-paintvars/blob/master/README.org","created_at":"2016-12-12T06:07:15Z","updated_at":"2016-12-12T06:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/7945/commits","review_comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/7945/comments","review_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7945/comments","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/ca4649e55e392d9c1cbc8f674c0a85b51b36d378","head":{"label":"SteveJobzniak:develop-SteveJobzniak-colors","ref":"develop-SteveJobzniak-colors","sha":"ca4649e55e392d9c1cbc8f674c0a85b51b36d378","user":{"login":"SteveJobzniak","id":22373193,"avatar_url":"https://avatars.githubusercontent.com/u/22373193?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveJobzniak","html_url":"https://github.com/SteveJobzniak","followers_url":"https://api.github.com/users/SteveJobzniak/followers","following_url":"https://api.github.com/users/SteveJobzniak/following{/other_user}","gists_url":"https://api.github.com/users/SteveJobzniak/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveJobzniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveJobzniak/subscriptions","organizations_url":"https://api.github.com/users/SteveJobzniak/orgs","repos_url":"https://api.github.com/users/SteveJobzniak/repos","events_url":"https://api.github.com/users/SteveJobzniak/events{/privacy}","received_events_url":"https://api.github.com/users/SteveJobzniak/received_events","type":"User","site_admin":false},"repo":{"id":75874148,"name":"spacemacs","full_name":"SteveJobzniak/spacemacs","owner":{"login":"SteveJobzniak","id":22373193,"avatar_url":"https://avatars.githubusercontent.com/u/22373193?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveJobzniak","html_url":"https://github.com/SteveJobzniak","followers_url":"https://api.github.com/users/SteveJobzniak/followers","following_url":"https://api.github.com/users/SteveJobzniak/following{/other_user}","gists_url":"https://api.github.com/users/SteveJobzniak/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveJobzniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveJobzniak/subscriptions","organizations_url":"https://api.github.com/users/SteveJobzniak/orgs","repos_url":"https://api.github.com/users/SteveJobzniak/repos","events_url":"https://api.github.com/users/SteveJobzniak/events{/privacy}","received_events_url":"https://api.github.com/users/SteveJobzniak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SteveJobzniak/spacemacs","description":"A community-driven Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":true,"url":"https://api.github.com/repos/SteveJobzniak/spacemacs","forks_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/forks","keys_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/teams","hooks_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/events","assignees_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/tags","blobs_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/languages","stargazers_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/subscription","commits_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/merges","archive_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/downloads","issues_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/releases{/id}","deployments_url":"https://api.github.com/repos/SteveJobzniak/spacemacs/deployments","created_at":"2016-12-07T20:44:44Z","updated_at":"2016-12-07T20:44:55Z","pushed_at":"2016-12-12T05:42:56Z","git_url":"git://github.com/SteveJobzniak/spacemacs.git","ssh_url":"git@github.com:SteveJobzniak/spacemacs.git","clone_url":"https://github.com/SteveJobzniak/spacemacs.git","svn_url":"https://github.com/SteveJobzniak/spacemacs","homepage":"http://spacemacs.org","size":29118,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syl20bnr:develop","ref":"develop","sha":"afa2226051945b73c89fad46b56eb5fe6d4ece89","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"repo":{"id":7212645,"name":"spacemacs","full_name":"syl20bnr/spacemacs","owner":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syl20bnr/spacemacs","description":"A community-driven Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":false,"url":"https://api.github.com/repos/syl20bnr/spacemacs","forks_url":"https://api.github.com/repos/syl20bnr/spacemacs/forks","keys_url":"https://api.github.com/repos/syl20bnr/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syl20bnr/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syl20bnr/spacemacs/teams","hooks_url":"https://api.github.com/repos/syl20bnr/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/events","assignees_url":"https://api.github.com/repos/syl20bnr/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/syl20bnr/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/tags","blobs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/syl20bnr/spacemacs/languages","stargazers_url":"https://api.github.com/repos/syl20bnr/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/syl20bnr/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscription","commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/syl20bnr/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/syl20bnr/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syl20bnr/spacemacs/merges","archive_url":"https://api.github.com/repos/syl20bnr/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syl20bnr/spacemacs/downloads","issues_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/syl20bnr/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/syl20bnr/spacemacs/releases{/id}","deployments_url":"https://api.github.com/repos/syl20bnr/spacemacs/deployments","created_at":"2012-12-17T21:34:03Z","updated_at":"2016-12-12T03:31:17Z","pushed_at":"2016-12-12T06:07:15Z","git_url":"git://github.com/syl20bnr/spacemacs.git","ssh_url":"git@github.com:syl20bnr/spacemacs.git","clone_url":"https://github.com/syl20bnr/spacemacs.git","svn_url":"https://github.com/syl20bnr/spacemacs","homepage":"http://spacemacs.org","size":53681,"stargazers_count":10035,"watchers_count":10035,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2603,"mirror_url":null,"open_issues_count":1168,"forks":2603,"open_issues":1168,"watchers":10035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/7945"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/7945"},"issue":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7945"},"comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7945/comments"},"review_comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/7945/comments"},"review_comment":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/7945/commits"},"statuses":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/ca4649e55e392d9c1cbc8f674c0a85b51b36d378"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":104,"deletions":45,"changed_files":4}}
{"actor":{"display_login":"SteveJobzniak"}}