{"action":"opened","number":3845,"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/3845","id":64985611,"html_url":"https://github.com/ArduPilot/ardupilot/pull/3845","diff_url":"https://github.com/ArduPilot/ardupilot/pull/3845.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/3845.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/3845","number":3845,"state":"open","locked":false,"title":"cmath: start using it v3","user":{"login":"ricardotk","id":3178975,"avatar_url":"https://avatars.githubusercontent.com/u/3178975?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardotk","html_url":"https://github.com/ricardotk","followers_url":"https://api.github.com/users/ricardotk/followers","following_url":"https://api.github.com/users/ricardotk/following{/other_user}","gists_url":"https://api.github.com/users/ricardotk/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardotk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardotk/subscriptions","organizations_url":"https://api.github.com/users/ricardotk/orgs","repos_url":"https://api.github.com/users/ricardotk/repos","events_url":"https://api.github.com/users/ricardotk/events{/privacy}","received_events_url":"https://api.github.com/users/ricardotk/received_events","type":"User","site_admin":false},"body":"Changes from v2:\r\n    - handle \"make\" in order to retain its current behavior after the changes\r\n    - add configuration_helper waf tool \r\n\r\nChanges from v1:\r\n    - changed `#ifdef` check from private guard used by glibcxx to waf build system parameter check.\r\n\r\nThese series swaps math.h usage to cmath usage.\r\n\r\nIt all started with an update on ArchLinux that broke ArduPilot build for me, the fix was to put `std::` in front of `isnan()`, `isinf()` and `isfinite()`. But I decided to send a better fix here.\r\n\r\nFlash size before:\r\n\r\n| text | data | bss | dec | hex | filename\r\n|----- | ------ | ---- | ----- | ----- | ---------- |\r\n|972588    |2820   |57116 |1032524 |  fc14c | master\r\n\r\nFlash size after:\r\n\r\n| text | data | bss | dec | hex | filename\r\n|----- | ------ | ---- | ----- | ----- | ---------- |\r\n| 972628   | 2820   | 57132 | 1032580 |  fc184 | cmath\r\n\r\nThanks!","created_at":"2016-04-01T18:28:05Z","updated_at":"2016-04-01T18:28:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/3845/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/3845/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/3845/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/2794c0f2eb4a4db8816b478871c2a901de22c210","head":{"label":"ricardotk:cmath-v3","ref":"cmath-v3","sha":"2794c0f2eb4a4db8816b478871c2a901de22c210","user":{"login":"ricardotk","id":3178975,"avatar_url":"https://avatars.githubusercontent.com/u/3178975?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardotk","html_url":"https://github.com/ricardotk","followers_url":"https://api.github.com/users/ricardotk/followers","following_url":"https://api.github.com/users/ricardotk/following{/other_user}","gists_url":"https://api.github.com/users/ricardotk/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardotk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardotk/subscriptions","organizations_url":"https://api.github.com/users/ricardotk/orgs","repos_url":"https://api.github.com/users/ricardotk/repos","events_url":"https://api.github.com/users/ricardotk/events{/privacy}","received_events_url":"https://api.github.com/users/ricardotk/received_events","type":"User","site_admin":false},"repo":{"id":48503449,"name":"ardupilot","full_name":"ricardotk/ardupilot","owner":{"login":"ricardotk","id":3178975,"avatar_url":"https://avatars.githubusercontent.com/u/3178975?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardotk","html_url":"https://github.com/ricardotk","followers_url":"https://api.github.com/users/ricardotk/followers","following_url":"https://api.github.com/users/ricardotk/following{/other_user}","gists_url":"https://api.github.com/users/ricardotk/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardotk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardotk/subscriptions","organizations_url":"https://api.github.com/users/ricardotk/orgs","repos_url":"https://api.github.com/users/ricardotk/repos","events_url":"https://api.github.com/users/ricardotk/events{/privacy}","received_events_url":"https://api.github.com/users/ricardotk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ricardotk/ardupilot","description":"APM Plane, APM Copter, APM Rover source","fork":true,"url":"https://api.github.com/repos/ricardotk/ardupilot","forks_url":"https://api.github.com/repos/ricardotk/ardupilot/forks","keys_url":"https://api.github.com/repos/ricardotk/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ricardotk/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ricardotk/ardupilot/teams","hooks_url":"https://api.github.com/repos/ricardotk/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ricardotk/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ricardotk/ardupilot/events","assignees_url":"https://api.github.com/repos/ricardotk/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ricardotk/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ricardotk/ardupilot/tags","blobs_url":"https://api.github.com/repos/ricardotk/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ricardotk/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ricardotk/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ricardotk/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ricardotk/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ricardotk/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ricardotk/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ricardotk/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ricardotk/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ricardotk/ardupilot/subscription","commits_url":"https://api.github.com/repos/ricardotk/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ricardotk/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ricardotk/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ricardotk/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ricardotk/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ricardotk/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ricardotk/ardupilot/merges","archive_url":"https://api.github.com/repos/ricardotk/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ricardotk/ardupilot/downloads","issues_url":"https://api.github.com/repos/ricardotk/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ricardotk/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ricardotk/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ricardotk/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ricardotk/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ricardotk/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ricardotk/ardupilot/deployments","created_at":"2015-12-23T17:44:42Z","updated_at":"2016-03-25T08:46:56Z","pushed_at":"2016-04-01T18:13:21Z","git_url":"git://github.com/ricardotk/ardupilot.git","ssh_url":"git@github.com:ricardotk/ardupilot.git","clone_url":"https://github.com/ricardotk/ardupilot.git","svn_url":"https://github.com/ricardotk/ardupilot","homepage":"http://ardupilot.com/","size":71997,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"913cf9dd376424c53dc063583d11f02ca9e46d25","user":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2016-04-01T15:00:58Z","pushed_at":"2016-04-01T18:28:05Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":126734,"stargazers_count":1773,"watchers_count":1773,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3711,"mirror_url":null,"open_issues_count":703,"forks":3711,"open_issues":703,"watchers":1773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/3845"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/3845"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/3845"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/3845/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/3845/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/3845/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/2794c0f2eb4a4db8816b478871c2a901de22c210"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":106,"deletions":42,"changed_files":46}}