{"action":"created","comment":{"url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/comments/66642581","id":66642581,"diff_hunk":"@@ -0,0 +1,8 @@\n+'use strict';\n+\n+const Joi = require('joi');\n+\n+module.exports = Joi.object().keys({\n+  title: Joi.string().min(1).max(255).required(),\n+  release_year: Joi.number().min(1878).max(9999).optional()","path":"lib/validators/movie.js","position":7,"original_position":7,"commit_id":"176b26b35018a248ec9668c8a06b08888a6652a1","original_commit_id":"176b26b35018a248ec9668c8a06b08888a6652a1","user":{"login":"charlesbjohnson","id":4823640,"avatar_url":"https://avatars.githubusercontent.com/u/4823640?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesbjohnson","html_url":"https://github.com/charlesbjohnson","followers_url":"https://api.github.com/users/charlesbjohnson/followers","following_url":"https://api.github.com/users/charlesbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/charlesbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesbjohnson/subscriptions","organizations_url":"https://api.github.com/users/charlesbjohnson/orgs","repos_url":"https://api.github.com/users/charlesbjohnson/repos","events_url":"https://api.github.com/users/charlesbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/charlesbjohnson/received_events","type":"User","site_admin":false},"body":"This should also require that the number be an `integer`, since that is the [schema](https://github.com/pallavi-s/sfmovies/blob/2ae40fc7f7c3a4012ace8a606eb3462af2d976f0/db/migrations/20160608152858_create_movies.js#L7) of the table. As is, this validator would allow `1999.5` to be inserted, but the database would not.","created_at":"2016-06-10T16:29:33Z","updated_at":"2016-06-10T16:29:33Z","html_url":"https://github.com/pallavi-s/sfmovies/pull/3#discussion_r66642581","pull_request_url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/comments/66642581"},"html":{"href":"https://github.com/pallavi-s/sfmovies/pull/3#discussion_r66642581"},"pull_request":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3","id":73298504,"html_url":"https://github.com/pallavi-s/sfmovies/pull/3","diff_url":"https://github.com/pallavi-s/sfmovies/pull/3.diff","patch_url":"https://github.com/pallavi-s/sfmovies/pull/3.patch","issue_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues/3","number":3,"state":"open","locked":false,"title":"feat(endpoints): adds a movies POST endpoint","user":{"login":"pallavi-s","id":18632342,"avatar_url":"https://avatars.githubusercontent.com/u/18632342?v=3","gravatar_id":"","url":"https://api.github.com/users/pallavi-s","html_url":"https://github.com/pallavi-s","followers_url":"https://api.github.com/users/pallavi-s/followers","following_url":"https://api.github.com/users/pallavi-s/following{/other_user}","gists_url":"https://api.github.com/users/pallavi-s/gists{/gist_id}","starred_url":"https://api.github.com/users/pallavi-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallavi-s/subscriptions","organizations_url":"https://api.github.com/users/pallavi-s/orgs","repos_url":"https://api.github.com/users/pallavi-s/repos","events_url":"https://api.github.com/users/pallavi-s/events{/privacy}","received_events_url":"https://api.github.com/users/pallavi-s/received_events","type":"User","site_admin":false},"body":"What: Added a POST /movies endpoint.\r\n\r\nWhy: Allows movies to be added to the database.\r\n\r\nDetails:\r\n\r\n- Defined the POST /movies route\r\n- Created and tested movie validation rules with Joi\r\n- Created a controller, connected it to the endpoint, and tested\r\n- Wrote integration tests","created_at":"2016-06-09T22:45:21Z","updated_at":"2016-06-10T16:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cf37dfa19b9d3cd1c9234b40d24a74c110ee946","assignee":{"login":"mgartner","id":1128750,"avatar_url":"https://avatars.githubusercontent.com/u/1128750?v=3","gravatar_id":"","url":"https://api.github.com/users/mgartner","html_url":"https://github.com/mgartner","followers_url":"https://api.github.com/users/mgartner/followers","following_url":"https://api.github.com/users/mgartner/following{/other_user}","gists_url":"https://api.github.com/users/mgartner/gists{/gist_id}","starred_url":"https://api.github.com/users/mgartner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgartner/subscriptions","organizations_url":"https://api.github.com/users/mgartner/orgs","repos_url":"https://api.github.com/users/mgartner/repos","events_url":"https://api.github.com/users/mgartner/events{/privacy}","received_events_url":"https://api.github.com/users/mgartner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3/commits","review_comments_url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3/comments","review_comment_url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues/3/comments","statuses_url":"https://api.github.com/repos/pallavi-s/sfmovies/statuses/176b26b35018a248ec9668c8a06b08888a6652a1","head":{"label":"pallavi-s:endpoints","ref":"endpoints","sha":"176b26b35018a248ec9668c8a06b08888a6652a1","user":{"login":"pallavi-s","id":18632342,"avatar_url":"https://avatars.githubusercontent.com/u/18632342?v=3","gravatar_id":"","url":"https://api.github.com/users/pallavi-s","html_url":"https://github.com/pallavi-s","followers_url":"https://api.github.com/users/pallavi-s/followers","following_url":"https://api.github.com/users/pallavi-s/following{/other_user}","gists_url":"https://api.github.com/users/pallavi-s/gists{/gist_id}","starred_url":"https://api.github.com/users/pallavi-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallavi-s/subscriptions","organizations_url":"https://api.github.com/users/pallavi-s/orgs","repos_url":"https://api.github.com/users/pallavi-s/repos","events_url":"https://api.github.com/users/pallavi-s/events{/privacy}","received_events_url":"https://api.github.com/users/pallavi-s/received_events","type":"User","site_admin":false},"repo":{"id":60718353,"name":"sfmovies","full_name":"pallavi-s/sfmovies","owner":{"login":"pallavi-s","id":18632342,"avatar_url":"https://avatars.githubusercontent.com/u/18632342?v=3","gravatar_id":"","url":"https://api.github.com/users/pallavi-s","html_url":"https://github.com/pallavi-s","followers_url":"https://api.github.com/users/pallavi-s/followers","following_url":"https://api.github.com/users/pallavi-s/following{/other_user}","gists_url":"https://api.github.com/users/pallavi-s/gists{/gist_id}","starred_url":"https://api.github.com/users/pallavi-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallavi-s/subscriptions","organizations_url":"https://api.github.com/users/pallavi-s/orgs","repos_url":"https://api.github.com/users/pallavi-s/repos","events_url":"https://api.github.com/users/pallavi-s/events{/privacy}","received_events_url":"https://api.github.com/users/pallavi-s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pallavi-s/sfmovies","description":"A RESTful API for movies filmed in San Francisco","fork":false,"url":"https://api.github.com/repos/pallavi-s/sfmovies","forks_url":"https://api.github.com/repos/pallavi-s/sfmovies/forks","keys_url":"https://api.github.com/repos/pallavi-s/sfmovies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pallavi-s/sfmovies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pallavi-s/sfmovies/teams","hooks_url":"https://api.github.com/repos/pallavi-s/sfmovies/hooks","issue_events_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues/events{/number}","events_url":"https://api.github.com/repos/pallavi-s/sfmovies/events","assignees_url":"https://api.github.com/repos/pallavi-s/sfmovies/assignees{/user}","branches_url":"https://api.github.com/repos/pallavi-s/sfmovies/branches{/branch}","tags_url":"https://api.github.com/repos/pallavi-s/sfmovies/tags","blobs_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/refs{/sha}","trees_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pallavi-s/sfmovies/statuses/{sha}","languages_url":"https://api.github.com/repos/pallavi-s/sfmovies/languages","stargazers_url":"https://api.github.com/repos/pallavi-s/sfmovies/stargazers","contributors_url":"https://api.github.com/repos/pallavi-s/sfmovies/contributors","subscribers_url":"https://api.github.com/repos/pallavi-s/sfmovies/subscribers","subscription_url":"https://api.github.com/repos/pallavi-s/sfmovies/subscription","commits_url":"https://api.github.com/repos/pallavi-s/sfmovies/commits{/sha}","git_commits_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/commits{/sha}","comments_url":"https://api.github.com/repos/pallavi-s/sfmovies/comments{/number}","issue_comment_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues/comments{/number}","contents_url":"https://api.github.com/repos/pallavi-s/sfmovies/contents/{+path}","compare_url":"https://api.github.com/repos/pallavi-s/sfmovies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pallavi-s/sfmovies/merges","archive_url":"https://api.github.com/repos/pallavi-s/sfmovies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pallavi-s/sfmovies/downloads","issues_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues{/number}","pulls_url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls{/number}","milestones_url":"https://api.github.com/repos/pallavi-s/sfmovies/milestones{/number}","notifications_url":"https://api.github.com/repos/pallavi-s/sfmovies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pallavi-s/sfmovies/labels{/name}","releases_url":"https://api.github.com/repos/pallavi-s/sfmovies/releases{/id}","deployments_url":"https://api.github.com/repos/pallavi-s/sfmovies/deployments","created_at":"2016-06-08T17:52:36Z","updated_at":"2016-06-09T17:39:01Z","pushed_at":"2016-06-09T23:33:51Z","git_url":"git://github.com/pallavi-s/sfmovies.git","ssh_url":"git@github.com:pallavi-s/sfmovies.git","clone_url":"https://github.com/pallavi-s/sfmovies.git","svn_url":"https://github.com/pallavi-s/sfmovies","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pallavi-s:master","ref":"master","sha":"2ae40fc7f7c3a4012ace8a606eb3462af2d976f0","user":{"login":"pallavi-s","id":18632342,"avatar_url":"https://avatars.githubusercontent.com/u/18632342?v=3","gravatar_id":"","url":"https://api.github.com/users/pallavi-s","html_url":"https://github.com/pallavi-s","followers_url":"https://api.github.com/users/pallavi-s/followers","following_url":"https://api.github.com/users/pallavi-s/following{/other_user}","gists_url":"https://api.github.com/users/pallavi-s/gists{/gist_id}","starred_url":"https://api.github.com/users/pallavi-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallavi-s/subscriptions","organizations_url":"https://api.github.com/users/pallavi-s/orgs","repos_url":"https://api.github.com/users/pallavi-s/repos","events_url":"https://api.github.com/users/pallavi-s/events{/privacy}","received_events_url":"https://api.github.com/users/pallavi-s/received_events","type":"User","site_admin":false},"repo":{"id":60718353,"name":"sfmovies","full_name":"pallavi-s/sfmovies","owner":{"login":"pallavi-s","id":18632342,"avatar_url":"https://avatars.githubusercontent.com/u/18632342?v=3","gravatar_id":"","url":"https://api.github.com/users/pallavi-s","html_url":"https://github.com/pallavi-s","followers_url":"https://api.github.com/users/pallavi-s/followers","following_url":"https://api.github.com/users/pallavi-s/following{/other_user}","gists_url":"https://api.github.com/users/pallavi-s/gists{/gist_id}","starred_url":"https://api.github.com/users/pallavi-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallavi-s/subscriptions","organizations_url":"https://api.github.com/users/pallavi-s/orgs","repos_url":"https://api.github.com/users/pallavi-s/repos","events_url":"https://api.github.com/users/pallavi-s/events{/privacy}","received_events_url":"https://api.github.com/users/pallavi-s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pallavi-s/sfmovies","description":"A RESTful API for movies filmed in San Francisco","fork":false,"url":"https://api.github.com/repos/pallavi-s/sfmovies","forks_url":"https://api.github.com/repos/pallavi-s/sfmovies/forks","keys_url":"https://api.github.com/repos/pallavi-s/sfmovies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pallavi-s/sfmovies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pallavi-s/sfmovies/teams","hooks_url":"https://api.github.com/repos/pallavi-s/sfmovies/hooks","issue_events_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues/events{/number}","events_url":"https://api.github.com/repos/pallavi-s/sfmovies/events","assignees_url":"https://api.github.com/repos/pallavi-s/sfmovies/assignees{/user}","branches_url":"https://api.github.com/repos/pallavi-s/sfmovies/branches{/branch}","tags_url":"https://api.github.com/repos/pallavi-s/sfmovies/tags","blobs_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/refs{/sha}","trees_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pallavi-s/sfmovies/statuses/{sha}","languages_url":"https://api.github.com/repos/pallavi-s/sfmovies/languages","stargazers_url":"https://api.github.com/repos/pallavi-s/sfmovies/stargazers","contributors_url":"https://api.github.com/repos/pallavi-s/sfmovies/contributors","subscribers_url":"https://api.github.com/repos/pallavi-s/sfmovies/subscribers","subscription_url":"https://api.github.com/repos/pallavi-s/sfmovies/subscription","commits_url":"https://api.github.com/repos/pallavi-s/sfmovies/commits{/sha}","git_commits_url":"https://api.github.com/repos/pallavi-s/sfmovies/git/commits{/sha}","comments_url":"https://api.github.com/repos/pallavi-s/sfmovies/comments{/number}","issue_comment_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues/comments{/number}","contents_url":"https://api.github.com/repos/pallavi-s/sfmovies/contents/{+path}","compare_url":"https://api.github.com/repos/pallavi-s/sfmovies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pallavi-s/sfmovies/merges","archive_url":"https://api.github.com/repos/pallavi-s/sfmovies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pallavi-s/sfmovies/downloads","issues_url":"https://api.github.com/repos/pallavi-s/sfmovies/issues{/number}","pulls_url":"https://api.github.com/repos/pallavi-s/sfmovies/pulls{/number}","milestones_url":"https://api.github.com/repos/pallavi-s/sfmovies/milestones{/number}","notifications_url":"https://api.github.com/repos/pallavi-s/sfmovies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pallavi-s/sfmovies/labels{/name}","releases_url":"https://api.github.com/repos/pallavi-s/sfmovies/releases{/id}","deployments_url":"https://api.github.com/repos/pallavi-s/sfmovies/deployments","created_at":"2016-06-08T17:52:36Z","updated_at":"2016-06-09T17:39:01Z","pushed_at":"2016-06-09T23:33:51Z","git_url":"git://github.com/pallavi-s/sfmovies.git","ssh_url":"git@github.com:pallavi-s/sfmovies.git","clone_url":"https://github.com/pallavi-s/sfmovies.git","svn_url":"https://github.com/pallavi-s/sfmovies","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3"},"html":{"href":"https://github.com/pallavi-s/sfmovies/pull/3"},"issue":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/issues/3"},"comments":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/pallavi-s/sfmovies/statuses/176b26b35018a248ec9668c8a06b08888a6652a1"}}}}
{"actor":{"display_login":"charlesbjohnson"}}