{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/83148226","pull_request_review_id":4007837,"id":83148226,"diff_hunk":"@@ -41,3 +41,14 @@ def onchange_workflow_process_id(self):\n             warning = {'title': _('Workflow Warning'),\n                        'message': workflow.warning}\n             return {'warning': warning}\n+\n+    @api.multi\n+    def action_invoice_create(self, grouped=False, final=False):\n+        for order in self:\n+            if not order.workflow_process_id.invoice_service_delivery:\n+                continue\n+            for line in order.order_line:\n+                if line.qty_delivered_updateable and not line.qty_delivered:","path":"sale_automatic_workflow/models/sale.py","position":11,"original_position":11,"commit_id":"7bc4c4582c2706d92b60bc4efb4496d461bcdc9e","original_commit_id":"7bc4c4582c2706d92b60bc4efb4496d461bcdc9e","user":{"login":"StefanRijnhart","id":1033124,"avatar_url":"https://avatars.githubusercontent.com/u/1033124?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanRijnhart","html_url":"https://github.com/StefanRijnhart","followers_url":"https://api.github.com/users/StefanRijnhart/followers","following_url":"https://api.github.com/users/StefanRijnhart/following{/other_user}","gists_url":"https://api.github.com/users/StefanRijnhart/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanRijnhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanRijnhart/subscriptions","organizations_url":"https://api.github.com/users/StefanRijnhart/orgs","repos_url":"https://api.github.com/users/StefanRijnhart/repos","events_url":"https://api.github.com/users/StefanRijnhart/events{/privacy}","received_events_url":"https://api.github.com/users/StefanRijnhart/received_events","type":"User","site_admin":false},"body":"No, it's a valid question. I had to look it up as well during the review, so I could have mentioned this observation in my review, or maybe a code comment would have been helpful. Next time!","created_at":"2016-10-13T05:55:47Z","updated_at":"2016-10-13T05:55:47Z","html_url":"https://github.com/OCA/sale-workflow/pull/342#discussion_r83148226","pull_request_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/342","_links":{"self":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/83148226"},"html":{"href":"https://github.com/OCA/sale-workflow/pull/342#discussion_r83148226"},"pull_request":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/sale-workflow/pulls/342","id":87326148,"html_url":"https://github.com/OCA/sale-workflow/pull/342","diff_url":"https://github.com/OCA/sale-workflow/pull/342.diff","patch_url":"https://github.com/OCA/sale-workflow/pull/342.patch","issue_url":"https://api.github.com/repos/OCA/sale-workflow/issues/342","number":342,"state":"closed","locked":false,"title":"[9.0][sale_automatic_workflow]Add possibility to invoice service automatically on delivery","user":{"login":"florian-dacosta","id":5393860,"avatar_url":"https://avatars.githubusercontent.com/u/5393860?v=3","gravatar_id":"","url":"https://api.github.com/users/florian-dacosta","html_url":"https://github.com/florian-dacosta","followers_url":"https://api.github.com/users/florian-dacosta/followers","following_url":"https://api.github.com/users/florian-dacosta/following{/other_user}","gists_url":"https://api.github.com/users/florian-dacosta/gists{/gist_id}","starred_url":"https://api.github.com/users/florian-dacosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florian-dacosta/subscriptions","organizations_url":"https://api.github.com/users/florian-dacosta/orgs","repos_url":"https://api.github.com/users/florian-dacosta/repos","events_url":"https://api.github.com/users/florian-dacosta/events{/privacy}","received_events_url":"https://api.github.com/users/florian-dacosta/received_events","type":"User","site_admin":false},"body":"The case is when I want to automatically invoice my sale orders at delivery.\r\nProduct service must be marked as shipped manually, but when we use sale automatic workflow, we do not want to make manual actions.\r\n\r\nSo I propose to add an option to automatically fill delivered quantity on sale order line if the product is a service. It will be automatically filled during the first invoice creation.\r\nOne comon use case is the shipping fee, we want to invoice it together with the other products.\r\n\r\n@guewen ","created_at":"2016-09-29T14:38:06Z","updated_at":"2016-10-13T05:55:47Z","closed_at":"2016-10-12T16:38:40Z","merged_at":"2016-10-12T16:38:40Z","merge_commit_sha":"2168195736780b71410678875c259cb3bac0943a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/342/commits","review_comments_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/342/comments","review_comment_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/sale-workflow/issues/342/comments","statuses_url":"https://api.github.com/repos/OCA/sale-workflow/statuses/7bc4c4582c2706d92b60bc4efb4496d461bcdc9e","head":{"label":"akretion:9-sale-automatic-workflow-invoice-service_delivery","ref":"9-sale-automatic-workflow-invoice-service_delivery","sha":"7bc4c4582c2706d92b60bc4efb4496d461bcdc9e","user":{"login":"akretion","id":1853423,"avatar_url":"https://avatars.githubusercontent.com/u/1853423?v=3","gravatar_id":"","url":"https://api.github.com/users/akretion","html_url":"https://github.com/akretion","followers_url":"https://api.github.com/users/akretion/followers","following_url":"https://api.github.com/users/akretion/following{/other_user}","gists_url":"https://api.github.com/users/akretion/gists{/gist_id}","starred_url":"https://api.github.com/users/akretion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akretion/subscriptions","organizations_url":"https://api.github.com/users/akretion/orgs","repos_url":"https://api.github.com/users/akretion/repos","events_url":"https://api.github.com/users/akretion/events{/privacy}","received_events_url":"https://api.github.com/users/akretion/received_events","type":"Organization","site_admin":false},"repo":{"id":23385877,"name":"sale-workflow","full_name":"akretion/sale-workflow","owner":{"login":"akretion","id":1853423,"avatar_url":"https://avatars.githubusercontent.com/u/1853423?v=3","gravatar_id":"","url":"https://api.github.com/users/akretion","html_url":"https://github.com/akretion","followers_url":"https://api.github.com/users/akretion/followers","following_url":"https://api.github.com/users/akretion/following{/other_user}","gists_url":"https://api.github.com/users/akretion/gists{/gist_id}","starred_url":"https://api.github.com/users/akretion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akretion/subscriptions","organizations_url":"https://api.github.com/users/akretion/orgs","repos_url":"https://api.github.com/users/akretion/repos","events_url":"https://api.github.com/users/akretion/events{/privacy}","received_events_url":"https://api.github.com/users/akretion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akretion/sale-workflow","description":null,"fork":true,"url":"https://api.github.com/repos/akretion/sale-workflow","forks_url":"https://api.github.com/repos/akretion/sale-workflow/forks","keys_url":"https://api.github.com/repos/akretion/sale-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akretion/sale-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akretion/sale-workflow/teams","hooks_url":"https://api.github.com/repos/akretion/sale-workflow/hooks","issue_events_url":"https://api.github.com/repos/akretion/sale-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/akretion/sale-workflow/events","assignees_url":"https://api.github.com/repos/akretion/sale-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/akretion/sale-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/akretion/sale-workflow/tags","blobs_url":"https://api.github.com/repos/akretion/sale-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akretion/sale-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akretion/sale-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/akretion/sale-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akretion/sale-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/akretion/sale-workflow/languages","stargazers_url":"https://api.github.com/repos/akretion/sale-workflow/stargazers","contributors_url":"https://api.github.com/repos/akretion/sale-workflow/contributors","subscribers_url":"https://api.github.com/repos/akretion/sale-workflow/subscribers","subscription_url":"https://api.github.com/repos/akretion/sale-workflow/subscription","commits_url":"https://api.github.com/repos/akretion/sale-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/akretion/sale-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/akretion/sale-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/akretion/sale-workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/akretion/sale-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/akretion/sale-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akretion/sale-workflow/merges","archive_url":"https://api.github.com/repos/akretion/sale-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akretion/sale-workflow/downloads","issues_url":"https://api.github.com/repos/akretion/sale-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/akretion/sale-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/akretion/sale-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/akretion/sale-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akretion/sale-workflow/labels{/name}","releases_url":"https://api.github.com/repos/akretion/sale-workflow/releases{/id}","deployments_url":"https://api.github.com/repos/akretion/sale-workflow/deployments","created_at":"2014-08-27T10:31:07Z","updated_at":"2016-10-11T08:42:27Z","pushed_at":"2016-10-12T22:43:55Z","git_url":"git://github.com/akretion/sale-workflow.git","ssh_url":"git@github.com:akretion/sale-workflow.git","clone_url":"https://github.com/akretion/sale-workflow.git","svn_url":"https://github.com/akretion/sale-workflow","homepage":"","size":3834,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"8.0"}},"base":{"label":"OCA:9.0","ref":"9.0","sha":"8afd6aed986991487abdffffcc07ce904a51c582","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20882412,"name":"sale-workflow","full_name":"OCA/sale-workflow","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/sale-workflow","description":"Odoo Sales, Workflow and Organization","fork":false,"url":"https://api.github.com/repos/OCA/sale-workflow","forks_url":"https://api.github.com/repos/OCA/sale-workflow/forks","keys_url":"https://api.github.com/repos/OCA/sale-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/sale-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/sale-workflow/teams","hooks_url":"https://api.github.com/repos/OCA/sale-workflow/hooks","issue_events_url":"https://api.github.com/repos/OCA/sale-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/sale-workflow/events","assignees_url":"https://api.github.com/repos/OCA/sale-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/sale-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/sale-workflow/tags","blobs_url":"https://api.github.com/repos/OCA/sale-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/sale-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/sale-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/sale-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/sale-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/sale-workflow/languages","stargazers_url":"https://api.github.com/repos/OCA/sale-workflow/stargazers","contributors_url":"https://api.github.com/repos/OCA/sale-workflow/contributors","subscribers_url":"https://api.github.com/repos/OCA/sale-workflow/subscribers","subscription_url":"https://api.github.com/repos/OCA/sale-workflow/subscription","commits_url":"https://api.github.com/repos/OCA/sale-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/sale-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/sale-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/sale-workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/sale-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/sale-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/sale-workflow/merges","archive_url":"https://api.github.com/repos/OCA/sale-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/sale-workflow/downloads","issues_url":"https://api.github.com/repos/OCA/sale-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/sale-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/sale-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/sale-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/sale-workflow/labels{/name}","releases_url":"https://api.github.com/repos/OCA/sale-workflow/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/sale-workflow/deployments","created_at":"2014-06-16T11:26:39Z","updated_at":"2016-10-04T13:54:10Z","pushed_at":"2016-10-13T02:35:42Z","git_url":"git://github.com/OCA/sale-workflow.git","ssh_url":"git@github.com:OCA/sale-workflow.git","clone_url":"https://github.com/OCA/sale-workflow.git","svn_url":"https://github.com/OCA/sale-workflow","homepage":"","size":6560,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":85,"forks":177,"open_issues":85,"watchers":34,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/342"},"html":{"href":"https://github.com/OCA/sale-workflow/pull/342"},"issue":{"href":"https://api.github.com/repos/OCA/sale-workflow/issues/342"},"comments":{"href":"https://api.github.com/repos/OCA/sale-workflow/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/sale-workflow/statuses/7bc4c4582c2706d92b60bc4efb4496d461bcdc9e"}}}}
{"actor":{"display_login":"StefanRijnhart"}}