{"action":"created","comment":{"url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/comments/57898619","id":57898619,"diff_hunk":"@@ -21,13 +21,21 @@ const PROVIDERS = {\n // Options that apply to any provider\n const defaults = {\n   idField: '_id',\n+  shouldSetupSuccessRoute: true,\n+  shouldSetupFailureRoute: true,\n   successRedirect: '/auth/success',\n   failureRedirect: '/auth/failure',\n   tokenEndpoint: '/auth/token',\n   localEndpoint: '/auth/local',\n   userEndpoint: '/users',\n   header: 'authorization',\n-  cookie: 'feathers-jwt'\n+  cookie: {\n+    enabled: true,","path":"src/index.js","position":14,"original_position":14,"commit_id":"1905e0dba585699c1e74644627187d2be4fa57a3","original_commit_id":"1905e0dba585699c1e74644627187d2be4fa57a3","user":{"login":"daffl","id":338316,"avatar_url":"https://avatars.githubusercontent.com/u/338316?v=3","gravatar_id":"","url":"https://api.github.com/users/daffl","html_url":"https://github.com/daffl","followers_url":"https://api.github.com/users/daffl/followers","following_url":"https://api.github.com/users/daffl/following{/other_user}","gists_url":"https://api.github.com/users/daffl/gists{/gist_id}","starred_url":"https://api.github.com/users/daffl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daffl/subscriptions","organizations_url":"https://api.github.com/users/daffl/orgs","repos_url":"https://api.github.com/users/daffl/repos","events_url":"https://api.github.com/users/daffl/events{/privacy}","received_events_url":"https://api.github.com/users/daffl/received_events","type":"User","site_admin":false},"body":"Can this just be considered disabled when someone set `cookie: false`?","created_at":"2016-03-30T14:33:33Z","updated_at":"2016-03-30T14:33:33Z","html_url":"https://github.com/feathersjs/feathers-authentication/pull/139#discussion_r57898619","pull_request_url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/comments/57898619"},"html":{"href":"https://github.com/feathersjs/feathers-authentication/pull/139#discussion_r57898619"},"pull_request":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139","id":64577534,"html_url":"https://github.com/feathersjs/feathers-authentication/pull/139","diff_url":"https://github.com/feathersjs/feathers-authentication/pull/139.diff","patch_url":"https://github.com/feathersjs/feathers-authentication/pull/139.patch","issue_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/139","number":139,"state":"open","locked":false,"title":"0.7 Release","user":{"login":"ekryski","id":599019,"avatar_url":"https://avatars.githubusercontent.com/u/599019?v=3","gravatar_id":"","url":"https://api.github.com/users/ekryski","html_url":"https://github.com/ekryski","followers_url":"https://api.github.com/users/ekryski/followers","following_url":"https://api.github.com/users/ekryski/following{/other_user}","gists_url":"https://api.github.com/users/ekryski/gists{/gist_id}","starred_url":"https://api.github.com/users/ekryski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekryski/subscriptions","organizations_url":"https://api.github.com/users/ekryski/orgs","repos_url":"https://api.github.com/users/ekryski/repos","events_url":"https://api.github.com/users/ekryski/events{/privacy}","received_events_url":"https://api.github.com/users/ekryski/received_events","type":"User","site_admin":false},"body":"This PR has a bunch more bug fixes and some pretty critical security fixes\r\n\r\n- [x] Lock down cookie (#132)\r\n- [x] Add unit tests for cookie options\r\n- [x] can now use default redirect routes with a custom handler (#121)\r\n- [x] Add middleware tests for successfulLogin\r\n- [x] Add middleware tests for failedLogin\r\n- [ ] Add integration tests for custom redirects\r\n- [x] Prevent emitting auth service events (#126)\r\n- [ ] Add tests to make sure auth service events are not fired\r\n- [x] RestrictToOwner hook needs to throw an error (#128)\r\n- [x] RestrictToRoles hook needs to throw an error (#127)\r\n- [x] OAuth user profile should be updated (#124)\r\n- [x] All hooks should support internal usage passthrough (#138)\r\n- [x] Clear cookie on logout (#122)\r\n- [ ] Add service tests\r\n- [ ] Update docs and examples\r\n- [x] de-auth socket on logout (#136)\r\n- [x] get logout integration tests working\r\n- [x] Move to bcryptjs instead of native brcrypt\r\n- [x] Removes ability to authenticate with the cookie that is used to transmit the JWT to the client","created_at":"2016-03-30T06:28:17Z","updated_at":"2016-03-30T14:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a104c3c6f13c85b7a2386fa082c12e82b1be932f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139/commits","review_comments_url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139/comments","review_comment_url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/139/comments","statuses_url":"https://api.github.com/repos/feathersjs/feathers-authentication/statuses/1905e0dba585699c1e74644627187d2be4fa57a3","head":{"label":"feathersjs:0.7","ref":"0.7","sha":"1905e0dba585699c1e74644627187d2be4fa57a3","user":{"login":"feathersjs","id":5321853,"avatar_url":"https://avatars.githubusercontent.com/u/5321853?v=3","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"repo":{"id":43711619,"name":"feathers-authentication","full_name":"feathersjs/feathers-authentication","owner":{"login":"feathersjs","id":5321853,"avatar_url":"https://avatars.githubusercontent.com/u/5321853?v=3","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feathersjs/feathers-authentication","description":"Feathers REST and Websocket authentication using JSON Web Tokens (JWT) with PassportJS.","fork":false,"url":"https://api.github.com/repos/feathersjs/feathers-authentication","forks_url":"https://api.github.com/repos/feathersjs/feathers-authentication/forks","keys_url":"https://api.github.com/repos/feathersjs/feathers-authentication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feathersjs/feathers-authentication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feathersjs/feathers-authentication/teams","hooks_url":"https://api.github.com/repos/feathersjs/feathers-authentication/hooks","issue_events_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/events{/number}","events_url":"https://api.github.com/repos/feathersjs/feathers-authentication/events","assignees_url":"https://api.github.com/repos/feathersjs/feathers-authentication/assignees{/user}","branches_url":"https://api.github.com/repos/feathersjs/feathers-authentication/branches{/branch}","tags_url":"https://api.github.com/repos/feathersjs/feathers-authentication/tags","blobs_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/refs{/sha}","trees_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feathersjs/feathers-authentication/statuses/{sha}","languages_url":"https://api.github.com/repos/feathersjs/feathers-authentication/languages","stargazers_url":"https://api.github.com/repos/feathersjs/feathers-authentication/stargazers","contributors_url":"https://api.github.com/repos/feathersjs/feathers-authentication/contributors","subscribers_url":"https://api.github.com/repos/feathersjs/feathers-authentication/subscribers","subscription_url":"https://api.github.com/repos/feathersjs/feathers-authentication/subscription","commits_url":"https://api.github.com/repos/feathersjs/feathers-authentication/commits{/sha}","git_commits_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/commits{/sha}","comments_url":"https://api.github.com/repos/feathersjs/feathers-authentication/comments{/number}","issue_comment_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/comments{/number}","contents_url":"https://api.github.com/repos/feathersjs/feathers-authentication/contents/{+path}","compare_url":"https://api.github.com/repos/feathersjs/feathers-authentication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feathersjs/feathers-authentication/merges","archive_url":"https://api.github.com/repos/feathersjs/feathers-authentication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feathersjs/feathers-authentication/downloads","issues_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues{/number}","pulls_url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls{/number}","milestones_url":"https://api.github.com/repos/feathersjs/feathers-authentication/milestones{/number}","notifications_url":"https://api.github.com/repos/feathersjs/feathers-authentication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feathersjs/feathers-authentication/labels{/name}","releases_url":"https://api.github.com/repos/feathersjs/feathers-authentication/releases{/id}","deployments_url":"https://api.github.com/repos/feathersjs/feathers-authentication/deployments","created_at":"2015-10-05T20:22:25Z","updated_at":"2016-03-29T08:55:15Z","pushed_at":"2016-03-30T11:19:45Z","git_url":"git://github.com/feathersjs/feathers-authentication.git","ssh_url":"git@github.com:feathersjs/feathers-authentication.git","clone_url":"https://github.com/feathersjs/feathers-authentication.git","svn_url":"https://github.com/feathersjs/feathers-authentication","homepage":null,"size":333,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":30,"forks":14,"open_issues":30,"watchers":30,"default_branch":"master"}},"base":{"label":"feathersjs:master","ref":"master","sha":"848c2477a75a4840c90603d76ea169e8b6030d67","user":{"login":"feathersjs","id":5321853,"avatar_url":"https://avatars.githubusercontent.com/u/5321853?v=3","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"repo":{"id":43711619,"name":"feathers-authentication","full_name":"feathersjs/feathers-authentication","owner":{"login":"feathersjs","id":5321853,"avatar_url":"https://avatars.githubusercontent.com/u/5321853?v=3","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feathersjs/feathers-authentication","description":"Feathers REST and Websocket authentication using JSON Web Tokens (JWT) with PassportJS.","fork":false,"url":"https://api.github.com/repos/feathersjs/feathers-authentication","forks_url":"https://api.github.com/repos/feathersjs/feathers-authentication/forks","keys_url":"https://api.github.com/repos/feathersjs/feathers-authentication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feathersjs/feathers-authentication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feathersjs/feathers-authentication/teams","hooks_url":"https://api.github.com/repos/feathersjs/feathers-authentication/hooks","issue_events_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/events{/number}","events_url":"https://api.github.com/repos/feathersjs/feathers-authentication/events","assignees_url":"https://api.github.com/repos/feathersjs/feathers-authentication/assignees{/user}","branches_url":"https://api.github.com/repos/feathersjs/feathers-authentication/branches{/branch}","tags_url":"https://api.github.com/repos/feathersjs/feathers-authentication/tags","blobs_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/refs{/sha}","trees_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feathersjs/feathers-authentication/statuses/{sha}","languages_url":"https://api.github.com/repos/feathersjs/feathers-authentication/languages","stargazers_url":"https://api.github.com/repos/feathersjs/feathers-authentication/stargazers","contributors_url":"https://api.github.com/repos/feathersjs/feathers-authentication/contributors","subscribers_url":"https://api.github.com/repos/feathersjs/feathers-authentication/subscribers","subscription_url":"https://api.github.com/repos/feathersjs/feathers-authentication/subscription","commits_url":"https://api.github.com/repos/feathersjs/feathers-authentication/commits{/sha}","git_commits_url":"https://api.github.com/repos/feathersjs/feathers-authentication/git/commits{/sha}","comments_url":"https://api.github.com/repos/feathersjs/feathers-authentication/comments{/number}","issue_comment_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/comments{/number}","contents_url":"https://api.github.com/repos/feathersjs/feathers-authentication/contents/{+path}","compare_url":"https://api.github.com/repos/feathersjs/feathers-authentication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feathersjs/feathers-authentication/merges","archive_url":"https://api.github.com/repos/feathersjs/feathers-authentication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feathersjs/feathers-authentication/downloads","issues_url":"https://api.github.com/repos/feathersjs/feathers-authentication/issues{/number}","pulls_url":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls{/number}","milestones_url":"https://api.github.com/repos/feathersjs/feathers-authentication/milestones{/number}","notifications_url":"https://api.github.com/repos/feathersjs/feathers-authentication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feathersjs/feathers-authentication/labels{/name}","releases_url":"https://api.github.com/repos/feathersjs/feathers-authentication/releases{/id}","deployments_url":"https://api.github.com/repos/feathersjs/feathers-authentication/deployments","created_at":"2015-10-05T20:22:25Z","updated_at":"2016-03-29T08:55:15Z","pushed_at":"2016-03-30T11:19:45Z","git_url":"git://github.com/feathersjs/feathers-authentication.git","ssh_url":"git@github.com:feathersjs/feathers-authentication.git","clone_url":"https://github.com/feathersjs/feathers-authentication.git","svn_url":"https://github.com/feathersjs/feathers-authentication","homepage":null,"size":333,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":30,"forks":14,"open_issues":30,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139"},"html":{"href":"https://github.com/feathersjs/feathers-authentication/pull/139"},"issue":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/139"},"comments":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/feathersjs/feathers-authentication/statuses/1905e0dba585699c1e74644627187d2be4fa57a3"}}}}