{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/14496","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/14496/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/14496/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/14496/events","html_url":"https://github.com/dotnet/corefx/issues/14496","id":195426290,"number":14496,"title":"Time to revisit need to register code pages provider?","user":{"login":"nguerrera","id":75470,"avatar_url":"https://avatars.githubusercontent.com/u/75470?v=3","gravatar_id":"","url":"https://api.github.com/users/nguerrera","html_url":"https://github.com/nguerrera","followers_url":"https://api.github.com/users/nguerrera/followers","following_url":"https://api.github.com/users/nguerrera/following{/other_user}","gists_url":"https://api.github.com/users/nguerrera/gists{/gist_id}","starred_url":"https://api.github.com/users/nguerrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguerrera/subscriptions","organizations_url":"https://api.github.com/users/nguerrera/orgs","repos_url":"https://api.github.com/users/nguerrera/repos","events_url":"https://api.github.com/users/nguerrera/events{/privacy}","received_events_url":"https://api.github.com/users/nguerrera/received_events","type":"User","site_admin":false},"labels":[{"id":167013730,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Text.Encoding","name":"area-System.Text.Encoding","color":"d4c5f9","default":false},{"id":309869280,"url":"https://api.github.com/repos/dotnet/corefx/labels/question","name":"question","color":"207de5","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-14T02:43:54Z","updated_at":"2016-12-14T17:38:30Z","closed_at":null,"body":"I'm working on localization of dotnet/cli itself and I hit an issue where csc on .NET Core on Windows can give me garbled text if I'm on a non English machine with corresponding satellite assemblies present. \r\n\r\nThe root cause is https://github.com/dotnet/corefx/issues/10054. I'm going to have to ensure that msbuild, cli, and roslyn all call Encoding.RegisterProvider(CodePagesEncodingProvider.Instance) before outputting anything to the console in non-English locales.\r\n\r\nI'm concerned that this pain point for .NET Core on Windows is not worth the benefit of making the code page data \"optional\". I say optional in quotes because the shared framework carries System.Text.Encoding.CodePages.dll and if I publish a standalone .NET Core app with our tools and the usual steps, System.Text.Encoding.CodePages is copied in to my app folder. Is anyone actually getting the benefit of not having System.Text.Encoding.CodePages?\r\n\r\nGiven the high likelihood of System.Text.Encoding.CodePages.dll being present in practice, could System.Console light-up on it somehow? i.e. If it's there next to System.Console.dll, then use it regardless of whether register has been called whenever the console code page is not UTF8  and text outside ASCII range is written?\r\n\r\n@terrajobst @tarekgh @karelz \r\n\r\nFYI @piotrpMSFT @cdmihai @jaredpar\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/267100878","html_url":"https://github.com/dotnet/corefx/issues/14496#issuecomment-267100878","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/14496","id":267100878,"user":{"login":"nguerrera","id":75470,"avatar_url":"https://avatars.githubusercontent.com/u/75470?v=3","gravatar_id":"","url":"https://api.github.com/users/nguerrera","html_url":"https://github.com/nguerrera","followers_url":"https://api.github.com/users/nguerrera/followers","following_url":"https://api.github.com/users/nguerrera/following{/other_user}","gists_url":"https://api.github.com/users/nguerrera/gists{/gist_id}","starred_url":"https://api.github.com/users/nguerrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguerrera/subscriptions","organizations_url":"https://api.github.com/users/nguerrera/orgs","repos_url":"https://api.github.com/users/nguerrera/repos","events_url":"https://api.github.com/users/nguerrera/events{/privacy}","received_events_url":"https://api.github.com/users/nguerrera/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T17:38:30Z","updated_at":"2016-12-14T17:38:30Z","body":"> Windows team currently working hard to get the console working seamlessly with UTF8 too and eventually this will be the default encoding.\r\n\r\nI will cry tears of joy when the Windows console defaults to UTF8. In the meantime, though, let's do the best we can for today's Windows reality. ;)\r\n\r\n\r\n> my understanding is CLI and Roslyn handling that already.\r\n\r\nThe CLI does. Roslyn still has a bug open on it: dotnet/roslyn#10875. I also had to file one against msbuild: dotnet/msbuild#1477\r\n"}}
{"actor":{"display_login":"nguerrera"}}