{"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/rib/linux/pulls/7","id":57491078,"html_url":"https://github.com/rib/linux/pull/7","diff_url":"https://github.com/rib/linux/pull/7.diff","patch_url":"https://github.com/rib/linux/pull/7.patch","issue_url":"https://api.github.com/repos/rib/linux/issues/7","number":7,"state":"open","locked":false,"title":"Wip/matt auld/oa 4.4 dynamic testing","user":{"login":"matt-auld","id":2013525,"avatar_url":"https://avatars.githubusercontent.com/u/2013525?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-auld","html_url":"https://github.com/matt-auld","followers_url":"https://api.github.com/users/matt-auld/followers","following_url":"https://api.github.com/users/matt-auld/following{/other_user}","gists_url":"https://api.github.com/users/matt-auld/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-auld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-auld/subscriptions","organizations_url":"https://api.github.com/users/matt-auld/orgs","repos_url":"https://api.github.com/users/matt-auld/repos","events_url":"https://api.github.com/users/matt-auld/events{/privacy}","received_events_url":"https://api.github.com/users/matt-auld/received_events","type":"User","site_admin":false},"body":"Feel free to take a look when you get the time. Thanks.\r\n\r\nAs per your comments:\r\n* We now silently fail when given an empty OA register set\r\n* We now check that at least one register set is given, be it MUX, BOOL or FLEX\r\n* We now explicitly check the uuid format from user-space - this is still just treated as a string and not a 128bit value\r\n  * I did look into using the 128bit form for the uuid, but I couldn't find any helpful kernel utilities, other than this https://lwn.net/Articles/356868/. Something like uuid_unparse would be really nice here. \r\n* We now check for a uuid collision early on\r\n* We now return from the icotl the metric-set id, rather than storing it in the user struct - much cleaner\r\n\r\nI think some kind of locking is still needed.\r\n ","created_at":"2016-01-28T11:47:20Z","updated_at":"2016-01-28T11:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2598a27bd09a06d7797a54a3fe1ff6bf503163e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rib/linux/pulls/7/commits","review_comments_url":"https://api.github.com/repos/rib/linux/pulls/7/comments","review_comment_url":"https://api.github.com/repos/rib/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rib/linux/issues/7/comments","statuses_url":"https://api.github.com/repos/rib/linux/statuses/58aa293c888c052fd7da14640f8562d58f01b191","head":{"label":"matt-auld:wip/matt-auld/oa-4.4-dynamic-testing","ref":"wip/matt-auld/oa-4.4-dynamic-testing","sha":"58aa293c888c052fd7da14640f8562d58f01b191","user":{"login":"matt-auld","id":2013525,"avatar_url":"https://avatars.githubusercontent.com/u/2013525?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-auld","html_url":"https://github.com/matt-auld","followers_url":"https://api.github.com/users/matt-auld/followers","following_url":"https://api.github.com/users/matt-auld/following{/other_user}","gists_url":"https://api.github.com/users/matt-auld/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-auld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-auld/subscriptions","organizations_url":"https://api.github.com/users/matt-auld/orgs","repos_url":"https://api.github.com/users/matt-auld/repos","events_url":"https://api.github.com/users/matt-auld/events{/privacy}","received_events_url":"https://api.github.com/users/matt-auld/received_events","type":"User","site_admin":false},"repo":{"id":47269696,"name":"linux","full_name":"matt-auld/linux","owner":{"login":"matt-auld","id":2013525,"avatar_url":"https://avatars.githubusercontent.com/u/2013525?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-auld","html_url":"https://github.com/matt-auld","followers_url":"https://api.github.com/users/matt-auld/followers","following_url":"https://api.github.com/users/matt-auld/following{/other_user}","gists_url":"https://api.github.com/users/matt-auld/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-auld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-auld/subscriptions","organizations_url":"https://api.github.com/users/matt-auld/orgs","repos_url":"https://api.github.com/users/matt-auld/repos","events_url":"https://api.github.com/users/matt-auld/events{/privacy}","received_events_url":"https://api.github.com/users/matt-auld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matt-auld/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/matt-auld/linux","forks_url":"https://api.github.com/repos/matt-auld/linux/forks","keys_url":"https://api.github.com/repos/matt-auld/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matt-auld/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matt-auld/linux/teams","hooks_url":"https://api.github.com/repos/matt-auld/linux/hooks","issue_events_url":"https://api.github.com/repos/matt-auld/linux/issues/events{/number}","events_url":"https://api.github.com/repos/matt-auld/linux/events","assignees_url":"https://api.github.com/repos/matt-auld/linux/assignees{/user}","branches_url":"https://api.github.com/repos/matt-auld/linux/branches{/branch}","tags_url":"https://api.github.com/repos/matt-auld/linux/tags","blobs_url":"https://api.github.com/repos/matt-auld/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matt-auld/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matt-auld/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/matt-auld/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matt-auld/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/matt-auld/linux/languages","stargazers_url":"https://api.github.com/repos/matt-auld/linux/stargazers","contributors_url":"https://api.github.com/repos/matt-auld/linux/contributors","subscribers_url":"https://api.github.com/repos/matt-auld/linux/subscribers","subscription_url":"https://api.github.com/repos/matt-auld/linux/subscription","commits_url":"https://api.github.com/repos/matt-auld/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/matt-auld/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/matt-auld/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/matt-auld/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/matt-auld/linux/contents/{+path}","compare_url":"https://api.github.com/repos/matt-auld/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matt-auld/linux/merges","archive_url":"https://api.github.com/repos/matt-auld/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matt-auld/linux/downloads","issues_url":"https://api.github.com/repos/matt-auld/linux/issues{/number}","pulls_url":"https://api.github.com/repos/matt-auld/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/matt-auld/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/matt-auld/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matt-auld/linux/labels{/name}","releases_url":"https://api.github.com/repos/matt-auld/linux/releases{/id}","deployments_url":"https://api.github.com/repos/matt-auld/linux/deployments","created_at":"2015-12-02T15:23:45Z","updated_at":"2015-12-02T15:32:04Z","pushed_at":"2016-01-28T11:31:35Z","git_url":"git://github.com/matt-auld/linux.git","ssh_url":"git@github.com:matt-auld/linux.git","clone_url":"https://github.com/matt-auld/linux.git","svn_url":"https://github.com/matt-auld/linux","homepage":"","size":1328654,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"wip/rib/oa-next"}},"base":{"label":"rib:wip/rib/oa-4.4-testing","ref":"wip/rib/oa-4.4-testing","sha":"753f3707b2b8e8904b0f5fa2518b52e7350bc292","user":{"login":"rib","id":235361,"avatar_url":"https://avatars.githubusercontent.com/u/235361?v=3","gravatar_id":"","url":"https://api.github.com/users/rib","html_url":"https://github.com/rib","followers_url":"https://api.github.com/users/rib/followers","following_url":"https://api.github.com/users/rib/following{/other_user}","gists_url":"https://api.github.com/users/rib/gists{/gist_id}","starred_url":"https://api.github.com/users/rib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rib/subscriptions","organizations_url":"https://api.github.com/users/rib/orgs","repos_url":"https://api.github.com/users/rib/repos","events_url":"https://api.github.com/users/rib/events{/privacy}","received_events_url":"https://api.github.com/users/rib/received_events","type":"User","site_admin":false},"repo":{"id":25265017,"name":"linux","full_name":"rib/linux","owner":{"login":"rib","id":235361,"avatar_url":"https://avatars.githubusercontent.com/u/235361?v=3","gravatar_id":"","url":"https://api.github.com/users/rib","html_url":"https://github.com/rib","followers_url":"https://api.github.com/users/rib/followers","following_url":"https://api.github.com/users/rib/following{/other_user}","gists_url":"https://api.github.com/users/rib/gists{/gist_id}","starred_url":"https://api.github.com/users/rib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rib/subscriptions","organizations_url":"https://api.github.com/users/rib/orgs","repos_url":"https://api.github.com/users/rib/repos","events_url":"https://api.github.com/users/rib/events{/privacy}","received_events_url":"https://api.github.com/users/rib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rib/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/rib/linux","forks_url":"https://api.github.com/repos/rib/linux/forks","keys_url":"https://api.github.com/repos/rib/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rib/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rib/linux/teams","hooks_url":"https://api.github.com/repos/rib/linux/hooks","issue_events_url":"https://api.github.com/repos/rib/linux/issues/events{/number}","events_url":"https://api.github.com/repos/rib/linux/events","assignees_url":"https://api.github.com/repos/rib/linux/assignees{/user}","branches_url":"https://api.github.com/repos/rib/linux/branches{/branch}","tags_url":"https://api.github.com/repos/rib/linux/tags","blobs_url":"https://api.github.com/repos/rib/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rib/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rib/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/rib/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rib/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/rib/linux/languages","stargazers_url":"https://api.github.com/repos/rib/linux/stargazers","contributors_url":"https://api.github.com/repos/rib/linux/contributors","subscribers_url":"https://api.github.com/repos/rib/linux/subscribers","subscription_url":"https://api.github.com/repos/rib/linux/subscription","commits_url":"https://api.github.com/repos/rib/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/rib/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/rib/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/rib/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/rib/linux/contents/{+path}","compare_url":"https://api.github.com/repos/rib/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rib/linux/merges","archive_url":"https://api.github.com/repos/rib/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rib/linux/downloads","issues_url":"https://api.github.com/repos/rib/linux/issues{/number}","pulls_url":"https://api.github.com/repos/rib/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/rib/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/rib/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rib/linux/labels{/name}","releases_url":"https://api.github.com/repos/rib/linux/releases{/id}","deployments_url":"https://api.github.com/repos/rib/linux/deployments","created_at":"2014-10-15T17:14:53Z","updated_at":"2015-12-02T17:38:14Z","pushed_at":"2016-01-28T11:47:21Z","git_url":"git://github.com/rib/linux.git","ssh_url":"git@github.com:rib/linux.git","clone_url":"https://github.com/rib/linux.git","svn_url":"https://github.com/rib/linux","homepage":"","size":1328781,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":0,"default_branch":"wip/rib/oa-next"}},"_links":{"self":{"href":"https://api.github.com/repos/rib/linux/pulls/7"},"html":{"href":"https://github.com/rib/linux/pull/7"},"issue":{"href":"https://api.github.com/repos/rib/linux/issues/7"},"comments":{"href":"https://api.github.com/repos/rib/linux/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/rib/linux/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/rib/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rib/linux/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/rib/linux/statuses/58aa293c888c052fd7da14640f8562d58f01b191"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":302,"deletions":6,"changed_files":4}}