{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/ansible-elasticsearch/issues/182","repository_url":"https://api.github.com/repos/elastic/ansible-elasticsearch","labels_url":"https://api.github.com/repos/elastic/ansible-elasticsearch/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/elastic/ansible-elasticsearch/issues/182/comments","events_url":"https://api.github.com/repos/elastic/ansible-elasticsearch/issues/182/events","html_url":"https://github.com/elastic/ansible-elasticsearch/pull/182","id":187081744,"number":182,"title":"Add support for Elasticsearch 5.x","user":{"login":"veger","id":171827,"avatar_url":"https://avatars.githubusercontent.com/u/171827?v=3","gravatar_id":"","url":"https://api.github.com/users/veger","html_url":"https://github.com/veger","followers_url":"https://api.github.com/users/veger/followers","following_url":"https://api.github.com/users/veger/following{/other_user}","gists_url":"https://api.github.com/users/veger/gists{/gist_id}","starred_url":"https://api.github.com/users/veger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veger/subscriptions","organizations_url":"https://api.github.com/users/veger/orgs","repos_url":"https://api.github.com/users/veger/repos","events_url":"https://api.github.com/users/veger/events{/privacy}","received_events_url":"https://api.github.com/users/veger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-03T14:51:46Z","updated_at":"2016-11-09T06:48:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/ansible-elasticsearch/pulls/182","html_url":"https://github.com/elastic/ansible-elasticsearch/pull/182","diff_url":"https://github.com/elastic/ansible-elasticsearch/pull/182.diff","patch_url":"https://github.com/elastic/ansible-elasticsearch/pull/182.patch"},"body":"In order to be able to install a Elasticsearch cluster using version 5.0.0, I had to add the following v5.x support (next to the other PRs I submitted today and yesterday):\r\n\r\n* **Use log4j2.properties instead of logging.yml** - https://www.elastic.co/guide/en/elasticsearch/reference/5.0/settings.html#logging\r\n* **Add jvm.options** - https://www.elastic.co/guide/en/elasticsearch/reference/master/setting-system-settings.html#es-java-opts\r\n* **Use bootstrap.memory_lock instead of bootstrap.mlockall** - https://www.elastic.co/guide/en/elasticsearch/reference/master/setup-configuration-memory.html#mlockall\r\n* **Get rid of work directory** - https://github.com/elastic/elasticsearch/pull/10672\r\n* **Executable does not accept `-D` anymore, replace with `-E` and `-p`** - `--help` of executable\r\n* **Executable does not accept `--` anymore, replace with `-E`** - https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_settings_changes.html#_removed_using_double_dashes_to_configure_elasticsearch\r\n* **Get rid of 5.x default (file)s** - Similar to other package defaults\r\n\r\n:warning: I am absolutely no Elasticsearch expert (or a experiences user), so I added my references to the list of changes to show why I made the modifications\r\n\r\nAdditional remarks:\r\n\r\n* I tried to keep ES < 5.x compatible, hence the version checks. If support for < 5.x is not required, I can remove the checks\r\n* I do not know about (the/Ansible) role tests, so they probably break... I would appreciate it, if someone is willing to help, or point me in the right direction!\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/ansible-elasticsearch/issues/comments/259345081","html_url":"https://github.com/elastic/ansible-elasticsearch/pull/182#issuecomment-259345081","issue_url":"https://api.github.com/repos/elastic/ansible-elasticsearch/issues/182","id":259345081,"user":{"login":"veger","id":171827,"avatar_url":"https://avatars.githubusercontent.com/u/171827?v=3","gravatar_id":"","url":"https://api.github.com/users/veger","html_url":"https://github.com/veger","followers_url":"https://api.github.com/users/veger/followers","following_url":"https://api.github.com/users/veger/following{/other_user}","gists_url":"https://api.github.com/users/veger/gists{/gist_id}","starred_url":"https://api.github.com/users/veger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veger/subscriptions","organizations_url":"https://api.github.com/users/veger/orgs","repos_url":"https://api.github.com/users/veger/repos","events_url":"https://api.github.com/users/veger/events{/privacy}","received_events_url":"https://api.github.com/users/veger/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T06:48:31Z","updated_at":"2016-11-09T06:48:31Z","body":"I do not know, but you can always checkout my branch and us that (same we are doing ATM... ;) )"}}
{"actor":{"display_login":"veger"}}