{"action":"created","comment":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/91982799","pull_request_review_id":12491948,"id":91982799,"diff_hunk":"@@ -46,30 +46,30 @@ set (COMMON_WARNING_FLAGS \"-Wall -Werror\")\n set (CXX_WARNING_FLAGS \"-Wnon-virtual-dtor -Wold-style-cast\")\n \n set (CXX11_ABI \"DEFAULT\" CACHE STRING \"Use C++11 ABI: DEFAULT, ENABLE, DISABLE\")\n-set (TEST_COVERAGE FALSE CACHE BOOL \"Enables flags for test coverage\")\n-set (ENABLE_TESTS TRUE CACHE BOOL \"Enables tests\")\n+option (TEST_COVERAGE \"Enables flags for test coverage\" OFF)","path":"CMakeLists.txt","position":null,"original_position":6,"commit_id":"876ad28dd8df816276dd69fc162779fe97d9b4da","original_commit_id":"decf424dfca4dc6dc5b9742b8232b0ec69809ae4","user":{"login":"ludv1x","id":1247636,"avatar_url":"https://avatars.githubusercontent.com/u/1247636?v=3","gravatar_id":"","url":"https://api.github.com/users/ludv1x","html_url":"https://github.com/ludv1x","followers_url":"https://api.github.com/users/ludv1x/followers","following_url":"https://api.github.com/users/ludv1x/following{/other_user}","gists_url":"https://api.github.com/users/ludv1x/gists{/gist_id}","starred_url":"https://api.github.com/users/ludv1x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludv1x/subscriptions","organizations_url":"https://api.github.com/users/ludv1x/orgs","repos_url":"https://api.github.com/users/ludv1x/repos","events_url":"https://api.github.com/users/ludv1x/events{/privacy}","received_events_url":"https://api.github.com/users/ludv1x/received_events","type":"User","site_admin":false},"body":"Do you mean describe behavior of additional options?\r\nDefault behavior remains the same, and scripts from `build.md` seem to be workable.","created_at":"2016-12-12T16:28:24Z","updated_at":"2016-12-12T16:28:24Z","html_url":"https://github.com/yandex/ClickHouse/pull/233#discussion_r91982799","pull_request_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/91982799"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/233#discussion_r91982799"},"pull_request":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/233","id":96953694,"html_url":"https://github.com/yandex/ClickHouse/pull/233","diff_url":"https://github.com/yandex/ClickHouse/pull/233.diff","patch_url":"https://github.com/yandex/ClickHouse/pull/233.patch","issue_url":"https://api.github.com/repos/yandex/ClickHouse/issues/233","number":233,"state":"open","locked":false,"title":"Perfomance metrics refinement","user":{"login":"ludv1x","id":1247636,"avatar_url":"https://avatars.githubusercontent.com/u/1247636?v=3","gravatar_id":"","url":"https://api.github.com/users/ludv1x","html_url":"https://github.com/ludv1x","followers_url":"https://api.github.com/users/ludv1x/followers","following_url":"https://api.github.com/users/ludv1x/following{/other_user}","gists_url":"https://api.github.com/users/ludv1x/gists{/gist_id}","starred_url":"https://api.github.com/users/ludv1x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludv1x/subscriptions","organizations_url":"https://api.github.com/users/ludv1x/orgs","repos_url":"https://api.github.com/users/ludv1x/repos","events_url":"https://api.github.com/users/ludv1x/events{/privacy}","received_events_url":"https://api.github.com/users/ludv1x/received_events","type":"User","site_admin":false},"body":"METR-19372\r\nMETR-23305","created_at":"2016-12-07T16:08:52Z","updated_at":"2016-12-12T16:28:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac036422101751213d612a31ecec992027916982","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/233/commits","review_comments_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/233/comments","review_comment_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/issues/233/comments","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/876ad28dd8df816276dd69fc162779fe97d9b4da","head":{"label":"yandex:metrics_refinement","ref":"metrics_refinement","sha":"876ad28dd8df816276dd69fc162779fe97d9b4da","user":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"repo":{"id":60246359,"name":"ClickHouse","full_name":"yandex/ClickHouse","owner":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":false,"url":"https://api.github.com/repos/yandex/ClickHouse","forks_url":"https://api.github.com/repos/yandex/ClickHouse/forks","keys_url":"https://api.github.com/repos/yandex/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex/ClickHouse/teams","hooks_url":"https://api.github.com/repos/yandex/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/yandex/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/yandex/ClickHouse/events","assignees_url":"https://api.github.com/repos/yandex/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/yandex/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/yandex/ClickHouse/tags","blobs_url":"https://api.github.com/repos/yandex/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/yandex/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/yandex/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/yandex/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/yandex/ClickHouse/subscription","commits_url":"https://api.github.com/repos/yandex/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/yandex/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/yandex/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex/ClickHouse/merges","archive_url":"https://api.github.com/repos/yandex/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex/ClickHouse/downloads","issues_url":"https://api.github.com/repos/yandex/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/yandex/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/yandex/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/yandex/ClickHouse/deployments","created_at":"2016-06-02T08:28:18Z","updated_at":"2016-12-12T08:20:01Z","pushed_at":"2016-12-12T16:21:11Z","git_url":"git://github.com/yandex/ClickHouse.git","ssh_url":"git@github.com:yandex/ClickHouse.git","clone_url":"https://github.com/yandex/ClickHouse.git","svn_url":"https://github.com/yandex/ClickHouse","homepage":null,"size":40024,"stargazers_count":1829,"watchers_count":1829,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"open_issues_count":73,"forks":204,"open_issues":73,"watchers":1829,"default_branch":"master"}},"base":{"label":"yandex:master","ref":"master","sha":"5320a9764efed24ad25ba2401bd71aa0b4468f80","user":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"repo":{"id":60246359,"name":"ClickHouse","full_name":"yandex/ClickHouse","owner":{"login":"yandex","id":7409213,"avatar_url":"https://avatars.githubusercontent.com/u/7409213?v=3","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":false,"url":"https://api.github.com/repos/yandex/ClickHouse","forks_url":"https://api.github.com/repos/yandex/ClickHouse/forks","keys_url":"https://api.github.com/repos/yandex/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex/ClickHouse/teams","hooks_url":"https://api.github.com/repos/yandex/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/yandex/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/yandex/ClickHouse/events","assignees_url":"https://api.github.com/repos/yandex/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/yandex/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/yandex/ClickHouse/tags","blobs_url":"https://api.github.com/repos/yandex/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/yandex/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/yandex/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/yandex/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/yandex/ClickHouse/subscription","commits_url":"https://api.github.com/repos/yandex/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/yandex/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/yandex/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex/ClickHouse/merges","archive_url":"https://api.github.com/repos/yandex/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex/ClickHouse/downloads","issues_url":"https://api.github.com/repos/yandex/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/yandex/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/yandex/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/yandex/ClickHouse/deployments","created_at":"2016-06-02T08:28:18Z","updated_at":"2016-12-12T08:20:01Z","pushed_at":"2016-12-12T16:21:11Z","git_url":"git://github.com/yandex/ClickHouse.git","ssh_url":"git@github.com:yandex/ClickHouse.git","clone_url":"https://github.com/yandex/ClickHouse.git","svn_url":"https://github.com/yandex/ClickHouse","homepage":null,"size":40024,"stargazers_count":1829,"watchers_count":1829,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"open_issues_count":73,"forks":204,"open_issues":73,"watchers":1829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/233"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/233"},"issue":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/233"},"comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/yandex/ClickHouse/statuses/876ad28dd8df816276dd69fc162779fe97d9b4da"}}}}
{"actor":{"display_login":"ludv1x"}}