{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/56046875","id":56046875,"diff_hunk":"@@ -1302,7 +840,7 @@ class FunctionSignatureOpts : public SILModuleTransform {\n \n       // Otherwise, try to optimize the function signature of F.\n       Changed |=\n-          optimizeFunctionSignature(Allocator, RCIA->get(F), AA, F, CallSites);\n+          optimizeFunctionSignature(Allocator, RCIA->get(F), FSA->get(F), AA, F, CallSites);","path":"lib/SILOptimizer/IPO/FunctionSignatureOpts.cpp","position":860,"original_position":860,"commit_id":"e196a0cfa3c52707574b82f6e9bc0ee6ea2129ab","original_commit_id":"e196a0cfa3c52707574b82f6e9bc0ee6ea2129ab","user":{"login":"rudkx","id":162784,"avatar_url":"https://avatars.githubusercontent.com/u/162784?v=3","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false},"body":"This line is now over 80 chars. Can you please fix?","created_at":"2016-03-14T18:03:38Z","updated_at":"2016-03-14T18:03:38Z","html_url":"https://github.com/apple/swift/pull/1677#discussion_r56046875","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/1677","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/56046875"},"html":{"href":"https://github.com/apple/swift/pull/1677#discussion_r56046875"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/1677"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/1677","id":62783152,"html_url":"https://github.com/apple/swift/pull/1677","diff_url":"https://github.com/apple/swift/pull/1677.diff","patch_url":"https://github.com/apple/swift/pull/1677.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/1677","number":1677,"state":"open","locked":false,"title":"Split SignatureAnalyzer into a separate function pass","user":{"login":"trentxintong","id":14864764,"avatar_url":"https://avatars.githubusercontent.com/u/14864764?v=3","gravatar_id":"","url":"https://api.github.com/users/trentxintong","html_url":"https://github.com/trentxintong","followers_url":"https://api.github.com/users/trentxintong/followers","following_url":"https://api.github.com/users/trentxintong/following{/other_user}","gists_url":"https://api.github.com/users/trentxintong/gists{/gist_id}","starred_url":"https://api.github.com/users/trentxintong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentxintong/subscriptions","organizations_url":"https://api.github.com/users/trentxintong/orgs","repos_url":"https://api.github.com/users/trentxintong/repos","events_url":"https://api.github.com/users/trentxintong/events{/privacy}","received_events_url":"https://api.github.com/users/trentxintong/received_events","type":"User","site_admin":false},"body":"#### What's in this pull request?\r\n\r\nThis changes moves SignatureAnalyzer and ArgumentDescriptor/ResultDescriptor into a separate\r\npass.\r\n\r\nThis pass is run on every function and the optimized signature is return'ed through the\r\ngetArgDescList and getResultDescList.\r\n\r\nNext step is to split to cloning and callsite rewriting into their own function passes.\r\n\r\nrdar://24730896","created_at":"2016-03-14T17:10:04Z","updated_at":"2016-03-14T18:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff8cecb50665c9b2ac05b5a0bbe8fa38b90d1fbf","assignee":{"login":"rudkx","id":162784,"avatar_url":"https://avatars.githubusercontent.com/u/162784?v=3","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/1677/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/1677/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/1677/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/e196a0cfa3c52707574b82f6e9bc0ee6ea2129ab","head":{"label":"trentxintong:master","ref":"master","sha":"e196a0cfa3c52707574b82f6e9bc0ee6ea2129ab","user":{"login":"trentxintong","id":14864764,"avatar_url":"https://avatars.githubusercontent.com/u/14864764?v=3","gravatar_id":"","url":"https://api.github.com/users/trentxintong","html_url":"https://github.com/trentxintong","followers_url":"https://api.github.com/users/trentxintong/followers","following_url":"https://api.github.com/users/trentxintong/following{/other_user}","gists_url":"https://api.github.com/users/trentxintong/gists{/gist_id}","starred_url":"https://api.github.com/users/trentxintong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentxintong/subscriptions","organizations_url":"https://api.github.com/users/trentxintong/orgs","repos_url":"https://api.github.com/users/trentxintong/repos","events_url":"https://api.github.com/users/trentxintong/events{/privacy}","received_events_url":"https://api.github.com/users/trentxintong/received_events","type":"User","site_admin":false},"repo":{"id":53875100,"name":"swift","full_name":"trentxintong/swift","owner":{"login":"trentxintong","id":14864764,"avatar_url":"https://avatars.githubusercontent.com/u/14864764?v=3","gravatar_id":"","url":"https://api.github.com/users/trentxintong","html_url":"https://github.com/trentxintong","followers_url":"https://api.github.com/users/trentxintong/followers","following_url":"https://api.github.com/users/trentxintong/following{/other_user}","gists_url":"https://api.github.com/users/trentxintong/gists{/gist_id}","starred_url":"https://api.github.com/users/trentxintong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentxintong/subscriptions","organizations_url":"https://api.github.com/users/trentxintong/orgs","repos_url":"https://api.github.com/users/trentxintong/repos","events_url":"https://api.github.com/users/trentxintong/events{/privacy}","received_events_url":"https://api.github.com/users/trentxintong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trentxintong/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/trentxintong/swift","forks_url":"https://api.github.com/repos/trentxintong/swift/forks","keys_url":"https://api.github.com/repos/trentxintong/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trentxintong/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trentxintong/swift/teams","hooks_url":"https://api.github.com/repos/trentxintong/swift/hooks","issue_events_url":"https://api.github.com/repos/trentxintong/swift/issues/events{/number}","events_url":"https://api.github.com/repos/trentxintong/swift/events","assignees_url":"https://api.github.com/repos/trentxintong/swift/assignees{/user}","branches_url":"https://api.github.com/repos/trentxintong/swift/branches{/branch}","tags_url":"https://api.github.com/repos/trentxintong/swift/tags","blobs_url":"https://api.github.com/repos/trentxintong/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trentxintong/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trentxintong/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/trentxintong/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trentxintong/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/trentxintong/swift/languages","stargazers_url":"https://api.github.com/repos/trentxintong/swift/stargazers","contributors_url":"https://api.github.com/repos/trentxintong/swift/contributors","subscribers_url":"https://api.github.com/repos/trentxintong/swift/subscribers","subscription_url":"https://api.github.com/repos/trentxintong/swift/subscription","commits_url":"https://api.github.com/repos/trentxintong/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/trentxintong/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/trentxintong/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/trentxintong/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/trentxintong/swift/contents/{+path}","compare_url":"https://api.github.com/repos/trentxintong/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trentxintong/swift/merges","archive_url":"https://api.github.com/repos/trentxintong/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trentxintong/swift/downloads","issues_url":"https://api.github.com/repos/trentxintong/swift/issues{/number}","pulls_url":"https://api.github.com/repos/trentxintong/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/trentxintong/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/trentxintong/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trentxintong/swift/labels{/name}","releases_url":"https://api.github.com/repos/trentxintong/swift/releases{/id}","deployments_url":"https://api.github.com/repos/trentxintong/swift/deployments","created_at":"2016-03-14T17:02:09Z","updated_at":"2016-03-14T17:02:26Z","pushed_at":"2016-03-14T17:07:14Z","git_url":"git://github.com/trentxintong/swift.git","ssh_url":"git@github.com:trentxintong/swift.git","clone_url":"https://github.com/trentxintong/swift.git","svn_url":"https://github.com/trentxintong/swift","homepage":"https://swift.org/","size":79343,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"0bdf4a982494c84e216b9b0b84e1143892e3bf5a","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-03-14T17:52:14Z","pushed_at":"2016-03-14T17:27:59Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":107810,"stargazers_count":27613,"watchers_count":27613,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3603,"mirror_url":null,"open_issues_count":65,"forks":3603,"open_issues":65,"watchers":27613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/1677"},"html":{"href":"https://github.com/apple/swift/pull/1677"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/1677"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/1677/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/1677/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/1677/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/e196a0cfa3c52707574b82f6e9bc0ee6ea2129ab"}}}}