{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty-tcnative/issues/181","repository_url":"https://api.github.com/repos/netty/netty-tcnative","labels_url":"https://api.github.com/repos/netty/netty-tcnative/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/issues/181/comments","events_url":"https://api.github.com/repos/netty/netty-tcnative/issues/181/events","html_url":"https://github.com/netty/netty-tcnative/pull/181","id":172374503,"number":181,"title":"Refactor CertificateRequestedCallback to fix possible segfault.","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-22T05:54:49Z","updated_at":"2016-08-24T14:10:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty-tcnative/pulls/181","html_url":"https://github.com/netty/netty-tcnative/pull/181","diff_url":"https://github.com/netty/netty-tcnative/pull/181.diff","patch_url":"https://github.com/netty/netty-tcnative/pull/181.patch"},"body":"Motivation:\r\n\r\nIn the previous CertificateRequestedCallback interface the contract was that users will directly call SSL_ methods to set the key, cert and chain. This could lead to memory leaks or segfaults depending on if the key, cert and chain is freed or not.\r\n\r\nModification:\r\n\r\nChange the CertificateRequestedCallback interface to return a KeyMaterial object that holds the chain, key and password. We will call the correct SSL_ methods after calling the callback and so help to prevent leaks and segfaults.\r\n\r\nResults:\r\n\r\nNo more leaks and segfaults."},"comment":{"url":"https://api.github.com/repos/netty/netty-tcnative/issues/comments/242078714","html_url":"https://github.com/netty/netty-tcnative/pull/181#issuecomment-242078714","issue_url":"https://api.github.com/repos/netty/netty-tcnative/issues/181","id":242078714,"user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T14:10:48Z","updated_at":"2016-08-24T14:10:48Z","body":"@normanmaurer nope ... ship it!"}}
{"actor":{"display_login":"nmittler"}}