{"action":"created","issue":{"url":"https://api.github.com/repos/serilog/serilog/issues/8","repository_url":"https://api.github.com/repos/serilog/serilog","labels_url":"https://api.github.com/repos/serilog/serilog/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/serilog/serilog/issues/8/comments","events_url":"https://api.github.com/repos/serilog/serilog/issues/8/events","html_url":"https://github.com/serilog/serilog/issues/8","id":12368081,"number":8,"title":"Dispose sinks along with logger","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2013-03-24T01:29:20Z","updated_at":"2016-02-17T22:14:39Z","closed_at":"2013-03-24T02:05:45Z","body":"LoggerConfiguration may return a (disposable) Logger instead of ILogger, to avoid making ILogger itself disposable. Only the root logger should be disposable. Enrichers probably don't require disposal."},"comment":{"url":"https://api.github.com/repos/serilog/serilog/issues/comments/185431327","html_url":"https://github.com/serilog/serilog/issues/8#issuecomment-185431327","issue_url":"https://api.github.com/repos/serilog/serilog/issues/8","id":185431327,"user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T22:14:38Z","updated_at":"2016-02-17T22:14:38Z","body":"Correct - 2.0 has a new method to deal with the static `Log` class:\r\n\r\n```csharp\r\nLog.CloseAndFlush();\r\n```\r\n\r\nI don't think `ILogger` is a candidate for adding `Dispose()` because most of the loggers in an app aren't disposable - `ForContext()` returns an `ILogger` but no resources/sinks are directly associated with it.\r\n\r\n_Ideally_, `LoggerConfiguration.CreateLogger()` would return a `Logger` class that implements both `IDisposable` and `ILogger`.\r\n\r\nThere would need to be a few design decisions made, e.g. is `Log.Logger` still an `ILogger`? (I think \"yes\") but perhaps it's time to explore this further given the opportunity presented by the upcoming v2.\r\n\r\nI'll have a look today :+1:"}}