{"action":"opened","number":139,"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/139","id":88838276,"html_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/139","diff_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/139.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/139.patch","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/139","number":139,"state":"open","locked":false,"title":"Use VLOG in LoggingMixin","user":{"login":"foghina","id":412054,"avatar_url":"https://avatars.githubusercontent.com/u/412054?v=3","gravatar_id":"","url":"https://api.github.com/users/foghina","html_url":"https://github.com/foghina","followers_url":"https://api.github.com/users/foghina/followers","following_url":"https://api.github.com/users/foghina/following{/other_user}","gists_url":"https://api.github.com/users/foghina/gists{/gist_id}","starred_url":"https://api.github.com/users/foghina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foghina/subscriptions","organizations_url":"https://api.github.com/users/foghina/orgs","repos_url":"https://api.github.com/users/foghina/repos","events_url":"https://api.github.com/users/foghina/events{/privacy}","received_events_url":"https://api.github.com/users/foghina/received_events","type":"User","site_admin":false},"body":"This addresses #115.\r\n\r\nChange most logging in `LoggingMixin.h` to use `VLOG` (except for error states).\r\n\r\nBecause `VLOG` effectively evaluates to `void` we can't use `Base::logPrefix` as before, so we overload `<<` in `LoggingMixin` to write the prefix. This requires `logPrefix` to be made public.","created_at":"2016-10-11T14:02:56Z","updated_at":"2016-10-11T14:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"485d4297e62d56101dae9090e7c6e1f99e24777a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/139/commits","review_comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/139/comments","review_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/139/comments","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/statuses/a86307ece1022f36b2e2fc72792124b63fd5e20c","head":{"label":"foghina:logging","ref":"logging","sha":"a86307ece1022f36b2e2fc72792124b63fd5e20c","user":{"login":"foghina","id":412054,"avatar_url":"https://avatars.githubusercontent.com/u/412054?v=3","gravatar_id":"","url":"https://api.github.com/users/foghina","html_url":"https://github.com/foghina","followers_url":"https://api.github.com/users/foghina/followers","following_url":"https://api.github.com/users/foghina/following{/other_user}","gists_url":"https://api.github.com/users/foghina/gists{/gist_id}","starred_url":"https://api.github.com/users/foghina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foghina/subscriptions","organizations_url":"https://api.github.com/users/foghina/orgs","repos_url":"https://api.github.com/users/foghina/repos","events_url":"https://api.github.com/users/foghina/events{/privacy}","received_events_url":"https://api.github.com/users/foghina/received_events","type":"User","site_admin":false},"repo":{"id":70598483,"name":"reactivesocket-cpp","full_name":"foghina/reactivesocket-cpp","owner":{"login":"foghina","id":412054,"avatar_url":"https://avatars.githubusercontent.com/u/412054?v=3","gravatar_id":"","url":"https://api.github.com/users/foghina","html_url":"https://github.com/foghina","followers_url":"https://api.github.com/users/foghina/followers","following_url":"https://api.github.com/users/foghina/following{/other_user}","gists_url":"https://api.github.com/users/foghina/gists{/gist_id}","starred_url":"https://api.github.com/users/foghina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foghina/subscriptions","organizations_url":"https://api.github.com/users/foghina/orgs","repos_url":"https://api.github.com/users/foghina/repos","events_url":"https://api.github.com/users/foghina/events{/privacy}","received_events_url":"https://api.github.com/users/foghina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foghina/reactivesocket-cpp","description":"C++ implementation of ReactiveSocket","fork":true,"url":"https://api.github.com/repos/foghina/reactivesocket-cpp","forks_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/forks","keys_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/teams","hooks_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/hooks","issue_events_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/events","assignees_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/tags","blobs_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/languages","stargazers_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/stargazers","contributors_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/contributors","subscribers_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/subscribers","subscription_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/subscription","commits_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/merges","archive_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/downloads","issues_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/labels{/name}","releases_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/foghina/reactivesocket-cpp/deployments","created_at":"2016-10-11T13:52:16Z","updated_at":"2016-10-11T13:52:17Z","pushed_at":"2016-10-11T14:01:42Z","git_url":"git://github.com/foghina/reactivesocket-cpp.git","ssh_url":"git@github.com:foghina/reactivesocket-cpp.git","clone_url":"https://github.com/foghina/reactivesocket-cpp.git","svn_url":"https://github.com/foghina/reactivesocket-cpp","homepage":null,"size":1989,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveSocket:master","ref":"master","sha":"56b10e7906296c221383cf48943abb1de34852e0","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":53889141,"name":"reactivesocket-cpp","full_name":"ReactiveSocket/reactivesocket-cpp","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-cpp","description":"C++ implementation of ReactiveSocket","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/deployments","created_at":"2016-03-14T20:20:55Z","updated_at":"2016-09-09T17:21:48Z","pushed_at":"2016-10-11T14:02:56Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-cpp.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-cpp.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-cpp.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-cpp","homepage":null,"size":1989,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":15,"forks":13,"open_issues":15,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/139"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/139"},"issue":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/139"},"comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/statuses/a86307ece1022f36b2e2fc72792124b63fd5e20c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":54,"deletions":50,"changed_files":16}}
{"actor":{"display_login":"foghina"}}