{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/33","id":94938363,"html_url":"https://github.com/BTCfork/hardfork_prototype_1_mvf-bu/pull/33","diff_url":"https://github.com/BTCfork/hardfork_prototype_1_mvf-bu/pull/33.diff","patch_url":"https://github.com/BTCfork/hardfork_prototype_1_mvf-bu/pull/33.patch","issue_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/issues/33","number":33,"state":"closed","locked":false,"title":"Triggering adjustments (set FinalActivateForkHeight) and wallet backup fixes, etc.","user":{"login":"ftrader","id":16613123,"avatar_url":"https://avatars.githubusercontent.com/u/16613123?v=3","gravatar_id":"","url":"https://api.github.com/users/ftrader","html_url":"https://github.com/ftrader","followers_url":"https://api.github.com/users/ftrader/followers","following_url":"https://api.github.com/users/ftrader/following{/other_user}","gists_url":"https://api.github.com/users/ftrader/gists{/gist_id}","starred_url":"https://api.github.com/users/ftrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftrader/subscriptions","organizations_url":"https://api.github.com/users/ftrader/orgs","repos_url":"https://api.github.com/users/ftrader/repos","events_url":"https://api.github.com/users/ftrader/events{/privacy}","received_events_url":"https://api.github.com/users/ftrader/received_events","type":"User","site_admin":false},"body":"This PR covers some necessary fixes to the way we handle wallet backup.\r\n\r\nWallet backup is now also checked+done (if necessary) in ActivateFork(). This is done so that the wallet is backed up even if the fork is triggered by SegWit before the fork height or auto backup block height are reached. That's what users will expect - a reliable backup when the fork triggers. This also matches the requirements MVHF-BU-USER-REQ-10 and its children.\r\n\r\nThe wallet backup check in UpdateTip() remains, so that wallet backups on specific pre-fork blocks can still be done as before. However, the check and possible triggering of ActivateFork() is moved in front of the wallet backup check in UpdateTip(), and if necessary pre-empts it.\r\n\r\nThe fork activation now sets FinalActivateForkHeight to the actual fork height, so other functions like the difficulty retargeting periods should work correctly even if the fork is triggered by SegWit. The actual fork height + actual backup block height are now also written correctly to btcfork.conf when the fork triggers.\r\n\r\nOther changes include adaptation of the wallet backup test to take into account that triggering the fork before the wallet backup block no longer works the same way (therefore the forkheight was shifted to autobackupblock+1.\r\n\r\nFUTURE WORK\r\n\r\nThe wallet backup test may need to be extended with another node test run where the node forkheight < autobackupblock , to check that it backs up correctly at the fork point and not again at the autobackupblock when the fork is already active.\r\n\r\nA \"backup on SegWit activation\" test case should also be included - this should now work due to the wallet backup code being called in ActivateFork().","created_at":"2016-11-23T03:01:43Z","updated_at":"2016-11-24T00:45:27Z","closed_at":"2016-11-24T00:45:27Z","merged_at":"2016-11-24T00:45:27Z","merge_commit_sha":"a2a723ad04428ed7be8b48006243ef51d2271685","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/33/commits","review_comments_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/33/comments","review_comment_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/issues/33/comments","statuses_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/statuses/bd10ae38467f8e9ea32553d292b5419c0ed8c732","head":{"label":"ftrader-bitcoinunlimited:feature/trig","ref":"feature/trig","sha":"bd10ae38467f8e9ea32553d292b5419c0ed8c732","user":{"login":"ftrader-bitcoinunlimited","id":22471647,"avatar_url":"https://avatars.githubusercontent.com/u/22471647?v=3","gravatar_id":"","url":"https://api.github.com/users/ftrader-bitcoinunlimited","html_url":"https://github.com/ftrader-bitcoinunlimited","followers_url":"https://api.github.com/users/ftrader-bitcoinunlimited/followers","following_url":"https://api.github.com/users/ftrader-bitcoinunlimited/following{/other_user}","gists_url":"https://api.github.com/users/ftrader-bitcoinunlimited/gists{/gist_id}","starred_url":"https://api.github.com/users/ftrader-bitcoinunlimited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftrader-bitcoinunlimited/subscriptions","organizations_url":"https://api.github.com/users/ftrader-bitcoinunlimited/orgs","repos_url":"https://api.github.com/users/ftrader-bitcoinunlimited/repos","events_url":"https://api.github.com/users/ftrader-bitcoinunlimited/events{/privacy}","received_events_url":"https://api.github.com/users/ftrader-bitcoinunlimited/received_events","type":"Organization","site_admin":false},"repo":{"id":69360671,"name":"hardfork_prototype_1_mvf-bu","full_name":"ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu","owner":{"login":"ftrader-bitcoinunlimited","id":22471647,"avatar_url":"https://avatars.githubusercontent.com/u/22471647?v=3","gravatar_id":"","url":"https://api.github.com/users/ftrader-bitcoinunlimited","html_url":"https://github.com/ftrader-bitcoinunlimited","followers_url":"https://api.github.com/users/ftrader-bitcoinunlimited/followers","following_url":"https://api.github.com/users/ftrader-bitcoinunlimited/following{/other_user}","gists_url":"https://api.github.com/users/ftrader-bitcoinunlimited/gists{/gist_id}","starred_url":"https://api.github.com/users/ftrader-bitcoinunlimited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftrader-bitcoinunlimited/subscriptions","organizations_url":"https://api.github.com/users/ftrader-bitcoinunlimited/orgs","repos_url":"https://api.github.com/users/ftrader-bitcoinunlimited/repos","events_url":"https://api.github.com/users/ftrader-bitcoinunlimited/events{/privacy}","received_events_url":"https://api.github.com/users/ftrader-bitcoinunlimited/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu","description":"For work on the MVF prototype","fork":true,"url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu","forks_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/forks","keys_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/teams","hooks_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/hooks","issue_events_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/issues/events{/number}","events_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/events","assignees_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/assignees{/user}","branches_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/branches{/branch}","tags_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/tags","blobs_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/statuses/{sha}","languages_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/languages","stargazers_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/stargazers","contributors_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/contributors","subscribers_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/subscribers","subscription_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/subscription","commits_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/contents/{+path}","compare_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/merges","archive_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/downloads","issues_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/issues{/number}","pulls_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/pulls{/number}","milestones_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/milestones{/number}","notifications_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/labels{/name}","releases_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/releases{/id}","deployments_url":"https://api.github.com/repos/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/deployments","created_at":"2016-09-27T13:39:13Z","updated_at":"2016-09-27T13:39:21Z","pushed_at":"2016-11-24T00:44:39Z","git_url":"git://github.com/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu.git","ssh_url":"git@github.com:ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu.git","clone_url":"https://github.com/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu.git","svn_url":"https://github.com/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu","homepage":null,"size":55509,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BTCfork:master","ref":"master","sha":"1719da2adb502e4a9e50d5786adc12f7f8ad2fea","user":{"login":"BTCfork","id":20826420,"avatar_url":"https://avatars.githubusercontent.com/u/20826420?v=3","gravatar_id":"","url":"https://api.github.com/users/BTCfork","html_url":"https://github.com/BTCfork","followers_url":"https://api.github.com/users/BTCfork/followers","following_url":"https://api.github.com/users/BTCfork/following{/other_user}","gists_url":"https://api.github.com/users/BTCfork/gists{/gist_id}","starred_url":"https://api.github.com/users/BTCfork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTCfork/subscriptions","organizations_url":"https://api.github.com/users/BTCfork/orgs","repos_url":"https://api.github.com/users/BTCfork/repos","events_url":"https://api.github.com/users/BTCfork/events{/privacy}","received_events_url":"https://api.github.com/users/BTCfork/received_events","type":"Organization","site_admin":false},"repo":{"id":67009886,"name":"hardfork_prototype_1_mvf-bu","full_name":"BTCfork/hardfork_prototype_1_mvf-bu","owner":{"login":"BTCfork","id":20826420,"avatar_url":"https://avatars.githubusercontent.com/u/20826420?v=3","gravatar_id":"","url":"https://api.github.com/users/BTCfork","html_url":"https://github.com/BTCfork","followers_url":"https://api.github.com/users/BTCfork/followers","following_url":"https://api.github.com/users/BTCfork/following{/other_user}","gists_url":"https://api.github.com/users/BTCfork/gists{/gist_id}","starred_url":"https://api.github.com/users/BTCfork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTCfork/subscriptions","organizations_url":"https://api.github.com/users/BTCfork/orgs","repos_url":"https://api.github.com/users/BTCfork/repos","events_url":"https://api.github.com/users/BTCfork/events{/privacy}","received_events_url":"https://api.github.com/users/BTCfork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BTCfork/hardfork_prototype_1_mvf-bu","description":"MVF prototype based on Bitcoin Unlimited","fork":false,"url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu","forks_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/forks","keys_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/teams","hooks_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/hooks","issue_events_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/issues/events{/number}","events_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/events","assignees_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/assignees{/user}","branches_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/branches{/branch}","tags_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/tags","blobs_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/git/refs{/sha}","trees_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/statuses/{sha}","languages_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/languages","stargazers_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/stargazers","contributors_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/contributors","subscribers_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/subscribers","subscription_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/subscription","commits_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/commits{/sha}","git_commits_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/git/commits{/sha}","comments_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/comments{/number}","issue_comment_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/issues/comments{/number}","contents_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/contents/{+path}","compare_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/merges","archive_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/downloads","issues_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/issues{/number}","pulls_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls{/number}","milestones_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/milestones{/number}","notifications_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/labels{/name}","releases_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/releases{/id}","deployments_url":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/deployments","created_at":"2016-08-31T06:28:21Z","updated_at":"2016-10-22T10:25:16Z","pushed_at":"2016-11-24T00:45:27Z","git_url":"git://github.com/BTCfork/hardfork_prototype_1_mvf-bu.git","ssh_url":"git@github.com:BTCfork/hardfork_prototype_1_mvf-bu.git","clone_url":"https://github.com/BTCfork/hardfork_prototype_1_mvf-bu.git","svn_url":"https://github.com/BTCfork/hardfork_prototype_1_mvf-bu","homepage":"","size":55509,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/33"},"html":{"href":"https://github.com/BTCfork/hardfork_prototype_1_mvf-bu/pull/33"},"issue":{"href":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/issues/33"},"comments":{"href":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/BTCfork/hardfork_prototype_1_mvf-bu/statuses/bd10ae38467f8e9ea32553d292b5419c0ed8c732"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ftrader","id":16613123,"avatar_url":"https://avatars.githubusercontent.com/u/16613123?v=3","gravatar_id":"","url":"https://api.github.com/users/ftrader","html_url":"https://github.com/ftrader","followers_url":"https://api.github.com/users/ftrader/followers","following_url":"https://api.github.com/users/ftrader/following{/other_user}","gists_url":"https://api.github.com/users/ftrader/gists{/gist_id}","starred_url":"https://api.github.com/users/ftrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftrader/subscriptions","organizations_url":"https://api.github.com/users/ftrader/orgs","repos_url":"https://api.github.com/users/ftrader/repos","events_url":"https://api.github.com/users/ftrader/events{/privacy}","received_events_url":"https://api.github.com/users/ftrader/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":5,"additions":95,"deletions":29,"changed_files":5}}
{"actor":{"display_login":"ftrader"}}