{"action":"created","issue":{"url":"https://api.github.com/repos/collectd/collectd/issues/1791","repository_url":"https://api.github.com/repos/collectd/collectd","labels_url":"https://api.github.com/repos/collectd/collectd/issues/1791/labels{/name}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1791/comments","events_url":"https://api.github.com/repos/collectd/collectd/issues/1791/events","html_url":"https://github.com/collectd/collectd/pull/1791","id":165317855,"number":1791,"title":"add ActiveInterfaceOnly option to interface plugin","user":{"login":"rinigus","id":15706605,"avatar_url":"https://avatars.githubusercontent.com/u/15706605?v=3","gravatar_id":"","url":"https://api.github.com/users/rinigus","html_url":"https://github.com/rinigus","followers_url":"https://api.github.com/users/rinigus/followers","following_url":"https://api.github.com/users/rinigus/following{/other_user}","gists_url":"https://api.github.com/users/rinigus/gists{/gist_id}","starred_url":"https://api.github.com/users/rinigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinigus/subscriptions","organizations_url":"https://api.github.com/users/rinigus/orgs","repos_url":"https://api.github.com/users/rinigus/repos","events_url":"https://api.github.com/users/rinigus/events{/privacy}","received_events_url":"https://api.github.com/users/rinigus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/collectd/collectd/labels/Feature","name":"Feature","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-13T13:17:08Z","updated_at":"2016-07-31T08:23:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1791","html_url":"https://github.com/collectd/collectd/pull/1791","diff_url":"https://github.com/collectd/collectd/pull/1791.diff","patch_url":"https://github.com/collectd/collectd/pull/1791.patch"},"body":"This PR adds ActiveInterfaceOnly to interface plugin. \r\n\r\nRationale: In Sailfish devices there are very many network interfaces (28 in Nexus 4) out of which only 3 are actually used: one for cellular data, one for WIFI, and lo. Unfortunately, active interfaces on different devices could be different leading to inability to enable only the active ones using Interface option for all devices in default configuration. So, users would have to find out which interface is active for them and enable these interfaces manually.\r\n\r\nBy adding ActiveInterfaceOnly option, only interfaces with packet count larger than 0 would be reported. The implementation has been tested on Linux (Sailfish), but I hope that it works on other platforms as well."},"comment":{"url":"https://api.github.com/repos/collectd/collectd/issues/comments/236417744","html_url":"https://github.com/collectd/collectd/pull/1791#issuecomment-236417744","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1791","id":236417744,"user":{"login":"rubenk","id":47338,"avatar_url":"https://avatars.githubusercontent.com/u/47338?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"created_at":"2016-07-31T08:23:50Z","updated_at":"2016-07-31T08:23:50Z","body":"I'd thought the first 2 points in the Coding Style cover it al:\r\n- If you're starting a new file, we recommend to indent with two spaces.\r\n- If you're writing a patch, please use the indentation of the surrounding code.\r\n\r\nThese recommendations are not always followed though unfortunately, and the document itself is a bit hard to find.\r\n\r\nI have no preference for tabs or spaces, but like to avoid a mix of them.\r\nHave a look at https://github.com/collectd/collectd/pull/1822/commits/30bb3da506ce9ab8b03316cc71263239c1e2e40d and you'll see what I mean. The nesting became so hard to follow it cost me an hour to see the actual issue I was looking for in that file.\r\n\r\nIf we all agree, I can add instructions about the bracing style, and about not adding more mode lines and fold markers.\r\n\r\n\r\n"}}
{"actor":{"display_login":"rubenk"}}