{"action":"created","comment":{"url":"https://api.github.com/repos/SSSD/sssd/pulls/comments/87228491","pull_request_review_id":7848567,"id":87228491,"diff_hunk":"@@ -115,15 +115,15 @@ END_TEST\n \n START_TEST(test_signals)\n {\n-    const struct sbus_signal_meta *signal;\n+    const struct sbus_signal_meta *sm_signal;","path":"src/tests/sbus_codegen_tests.c","position":5,"original_position":5,"commit_id":"508cddbac06b85689ecb78a6aa8990cd6f53dd53","original_commit_id":"8b3e2934589c3d6ae57bf25f317173a49a6df60e","user":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"body":"Okay, I'll follow one of your suggestions.","created_at":"2016-11-09T16:35:48Z","updated_at":"2016-11-09T16:35:48Z","html_url":"https://github.com/SSSD/sssd/pull/50#discussion_r87228491","pull_request_url":"https://api.github.com/repos/SSSD/sssd/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/comments/87228491"},"html":{"href":"https://github.com/SSSD/sssd/pull/50#discussion_r87228491"},"pull_request":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/SSSD/sssd/pulls/50","id":89586045,"html_url":"https://github.com/SSSD/sssd/pull/50","diff_url":"https://github.com/SSSD/sssd/pull/50.diff","patch_url":"https://github.com/SSSD/sssd/pull/50.patch","issue_url":"https://api.github.com/repos/SSSD/sssd/issues/50","number":50,"state":"open","locked":false,"title":"[RFC] Use GNULIB's compiler warning code","user":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"body":"This patch series was sent to the sssd-devel and some discussions\nalready happened there[0](https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/thread/CTGR5CYV2PT3PLFLIRBCRTJP5ZW2XBMO/#CTGR5CYV2PT3PLFLIRBCRTJP5ZW2XBMO). I've decided to open the PR because there\nare some few patches that can be pushed even if we decide to not use\nthe \"many warnings\" patches.\n\nLet's keep track of those patches (and discussions related to them) in\nthe github, in this way we can avoid them to get lost. :-)\n\nBest Regards,\n\nChanges:\n\n683f72d (Fabiano Fidêncio, 10 weeks ago)\n   BUILD: Make use of GNULIB's compiler warning code\n\n   As GNULIB has the 'manywarnings' module, which basically turns on every GCC\n   warning, let's make use of it. We can easily blacklist the warnings we\n   cannot cope with, but the main goal should be to have enabled every\n   possible GCC warning.\n\n   When new GCC warnings are created the 'manywarnings' file can be refreshed\n   from upstream GNULIB.\n\n   Signed-off-by: Fabiano Fidêncio fidencio@redhat.com\n\nf59828a (Fabiano Fidêncio, 5 days ago)\n   NSS: Fix \"old-style-definition\" warning caught by GCC\n\n   Signed-off-by: Fabiano Fidêncio fidencio@redhat.com\n\nf22aff7 (Fabiano Fidêncio, 5 days ago)\n   SIFP: Fix a \"jump-misses-init\" warning caught by GCC\n\n   Signed-off-by: Fabiano Fidêncio fidencio@redhat.com\n\n58609d3 (Fabiano Fidêncio, 5 days ago)\n   RESOLV: Fix a \"-Werror=null-dereference\" caught by GCC\n\n   Signed-off-by: Fabiano Fidêncio fidencio@redhat.com\n\nbd1d7fd (Fabiano Fidêncio, 5 days ago)\n   RESOLV: Simplify reply_weight_rearrange() a little bit\n\n   Signed-off-by: Fabiano Fidêncio fidencio@redhat.com\n","created_at":"2016-10-17T09:12:51Z","updated_at":"2016-11-09T16:35:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c48bc618152f716971345da869a5d9da5b9a919","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SSSD/sssd/pulls/50/commits","review_comments_url":"https://api.github.com/repos/SSSD/sssd/pulls/50/comments","review_comment_url":"https://api.github.com/repos/SSSD/sssd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SSSD/sssd/issues/50/comments","statuses_url":"https://api.github.com/repos/SSSD/sssd/statuses/508cddbac06b85689ecb78a6aa8990cd6f53dd53","head":{"label":"fidencio:wip/manywarnings","ref":"wip/manywarnings","sha":"508cddbac06b85689ecb78a6aa8990cd6f53dd53","user":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"repo":{"id":67102888,"name":"sssd","full_name":"fidencio/sssd","owner":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fidencio/sssd","description":"A daemon to manage identity, authentication and authorization for centrally-managed systems.","fork":true,"url":"https://api.github.com/repos/fidencio/sssd","forks_url":"https://api.github.com/repos/fidencio/sssd/forks","keys_url":"https://api.github.com/repos/fidencio/sssd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fidencio/sssd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fidencio/sssd/teams","hooks_url":"https://api.github.com/repos/fidencio/sssd/hooks","issue_events_url":"https://api.github.com/repos/fidencio/sssd/issues/events{/number}","events_url":"https://api.github.com/repos/fidencio/sssd/events","assignees_url":"https://api.github.com/repos/fidencio/sssd/assignees{/user}","branches_url":"https://api.github.com/repos/fidencio/sssd/branches{/branch}","tags_url":"https://api.github.com/repos/fidencio/sssd/tags","blobs_url":"https://api.github.com/repos/fidencio/sssd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fidencio/sssd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fidencio/sssd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fidencio/sssd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fidencio/sssd/statuses/{sha}","languages_url":"https://api.github.com/repos/fidencio/sssd/languages","stargazers_url":"https://api.github.com/repos/fidencio/sssd/stargazers","contributors_url":"https://api.github.com/repos/fidencio/sssd/contributors","subscribers_url":"https://api.github.com/repos/fidencio/sssd/subscribers","subscription_url":"https://api.github.com/repos/fidencio/sssd/subscription","commits_url":"https://api.github.com/repos/fidencio/sssd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fidencio/sssd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fidencio/sssd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fidencio/sssd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fidencio/sssd/contents/{+path}","compare_url":"https://api.github.com/repos/fidencio/sssd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fidencio/sssd/merges","archive_url":"https://api.github.com/repos/fidencio/sssd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fidencio/sssd/downloads","issues_url":"https://api.github.com/repos/fidencio/sssd/issues{/number}","pulls_url":"https://api.github.com/repos/fidencio/sssd/pulls{/number}","milestones_url":"https://api.github.com/repos/fidencio/sssd/milestones{/number}","notifications_url":"https://api.github.com/repos/fidencio/sssd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fidencio/sssd/labels{/name}","releases_url":"https://api.github.com/repos/fidencio/sssd/releases{/id}","deployments_url":"https://api.github.com/repos/fidencio/sssd/deployments","created_at":"2016-09-01T06:05:21Z","updated_at":"2016-09-01T06:05:26Z","pushed_at":"2016-11-09T15:02:46Z","git_url":"git://github.com/fidencio/sssd.git","ssh_url":"git@github.com:fidencio/sssd.git","clone_url":"https://github.com/fidencio/sssd.git","svn_url":"https://github.com/fidencio/sssd","homepage":"https://fedorahosted.org/sssd","size":32453,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SSSD:master","ref":"master","sha":"fd25e68446ae86135489edb0823607b394f4ec40","user":{"login":"SSSD","id":12898906,"avatar_url":"https://avatars.githubusercontent.com/u/12898906?v=3","gravatar_id":"","url":"https://api.github.com/users/SSSD","html_url":"https://github.com/SSSD","followers_url":"https://api.github.com/users/SSSD/followers","following_url":"https://api.github.com/users/SSSD/following{/other_user}","gists_url":"https://api.github.com/users/SSSD/gists{/gist_id}","starred_url":"https://api.github.com/users/SSSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSSD/subscriptions","organizations_url":"https://api.github.com/users/SSSD/orgs","repos_url":"https://api.github.com/users/SSSD/repos","events_url":"https://api.github.com/users/SSSD/events{/privacy}","received_events_url":"https://api.github.com/users/SSSD/received_events","type":"Organization","site_admin":false},"repo":{"id":37479167,"name":"sssd","full_name":"SSSD/sssd","owner":{"login":"SSSD","id":12898906,"avatar_url":"https://avatars.githubusercontent.com/u/12898906?v=3","gravatar_id":"","url":"https://api.github.com/users/SSSD","html_url":"https://github.com/SSSD","followers_url":"https://api.github.com/users/SSSD/followers","following_url":"https://api.github.com/users/SSSD/following{/other_user}","gists_url":"https://api.github.com/users/SSSD/gists{/gist_id}","starred_url":"https://api.github.com/users/SSSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSSD/subscriptions","organizations_url":"https://api.github.com/users/SSSD/orgs","repos_url":"https://api.github.com/users/SSSD/repos","events_url":"https://api.github.com/users/SSSD/events{/privacy}","received_events_url":"https://api.github.com/users/SSSD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SSSD/sssd","description":"A daemon to manage identity, authentication and authorization for centrally-managed systems.","fork":false,"url":"https://api.github.com/repos/SSSD/sssd","forks_url":"https://api.github.com/repos/SSSD/sssd/forks","keys_url":"https://api.github.com/repos/SSSD/sssd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SSSD/sssd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SSSD/sssd/teams","hooks_url":"https://api.github.com/repos/SSSD/sssd/hooks","issue_events_url":"https://api.github.com/repos/SSSD/sssd/issues/events{/number}","events_url":"https://api.github.com/repos/SSSD/sssd/events","assignees_url":"https://api.github.com/repos/SSSD/sssd/assignees{/user}","branches_url":"https://api.github.com/repos/SSSD/sssd/branches{/branch}","tags_url":"https://api.github.com/repos/SSSD/sssd/tags","blobs_url":"https://api.github.com/repos/SSSD/sssd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SSSD/sssd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SSSD/sssd/git/refs{/sha}","trees_url":"https://api.github.com/repos/SSSD/sssd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SSSD/sssd/statuses/{sha}","languages_url":"https://api.github.com/repos/SSSD/sssd/languages","stargazers_url":"https://api.github.com/repos/SSSD/sssd/stargazers","contributors_url":"https://api.github.com/repos/SSSD/sssd/contributors","subscribers_url":"https://api.github.com/repos/SSSD/sssd/subscribers","subscription_url":"https://api.github.com/repos/SSSD/sssd/subscription","commits_url":"https://api.github.com/repos/SSSD/sssd/commits{/sha}","git_commits_url":"https://api.github.com/repos/SSSD/sssd/git/commits{/sha}","comments_url":"https://api.github.com/repos/SSSD/sssd/comments{/number}","issue_comment_url":"https://api.github.com/repos/SSSD/sssd/issues/comments{/number}","contents_url":"https://api.github.com/repos/SSSD/sssd/contents/{+path}","compare_url":"https://api.github.com/repos/SSSD/sssd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SSSD/sssd/merges","archive_url":"https://api.github.com/repos/SSSD/sssd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SSSD/sssd/downloads","issues_url":"https://api.github.com/repos/SSSD/sssd/issues{/number}","pulls_url":"https://api.github.com/repos/SSSD/sssd/pulls{/number}","milestones_url":"https://api.github.com/repos/SSSD/sssd/milestones{/number}","notifications_url":"https://api.github.com/repos/SSSD/sssd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SSSD/sssd/labels{/name}","releases_url":"https://api.github.com/repos/SSSD/sssd/releases{/id}","deployments_url":"https://api.github.com/repos/SSSD/sssd/deployments","created_at":"2015-06-15T17:09:48Z","updated_at":"2016-10-22T20:54:43Z","pushed_at":"2016-11-09T15:02:46Z","git_url":"git://github.com/SSSD/sssd.git","ssh_url":"git@github.com:SSSD/sssd.git","clone_url":"https://github.com/SSSD/sssd.git","svn_url":"https://github.com/SSSD/sssd","homepage":"https://fedorahosted.org/sssd","size":32677,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":16,"forks":23,"open_issues":16,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/50"},"html":{"href":"https://github.com/SSSD/sssd/pull/50"},"issue":{"href":"https://api.github.com/repos/SSSD/sssd/issues/50"},"comments":{"href":"https://api.github.com/repos/SSSD/sssd/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/SSSD/sssd/statuses/508cddbac06b85689ecb78a6aa8990cd6f53dd53"}}}}
{"actor":{"display_login":"fidencio"}}