{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/17799","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/17799/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/17799/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/17799/events","html_url":"https://github.com/ansible/ansible/pull/17799","id":179872874,"number":17799,"title":"Fix gathering=smart and custom module facts","user":{"login":"alikins","id":15162,"avatar_url":"https://avatars.githubusercontent.com/u/15162?v=3","gravatar_id":"","url":"https://api.github.com/users/alikins","html_url":"https://github.com/alikins","followers_url":"https://api.github.com/users/alikins/followers","following_url":"https://api.github.com/users/alikins/following{/other_user}","gists_url":"https://api.github.com/users/alikins/gists{/gist_id}","starred_url":"https://api.github.com/users/alikins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikins/subscriptions","organizations_url":"https://api.github.com/users/alikins/orgs","repos_url":"https://api.github.com/users/alikins/repos","events_url":"https://api.github.com/users/alikins/events{/privacy}","received_events_url":"https://api.github.com/users/alikins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270"},{"url":"https://api.github.com/repos/ansible/ansible/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/ansible/ansible/labels/P2","name":"P2","color":"fad8c7"}],"state":"closed","locked":false,"assignee":{"login":"bcoca","id":836171,"avatar_url":"https://avatars.githubusercontent.com/u/836171?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoca","html_url":"https://github.com/bcoca","followers_url":"https://api.github.com/users/bcoca/followers","following_url":"https://api.github.com/users/bcoca/following{/other_user}","gists_url":"https://api.github.com/users/bcoca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoca/subscriptions","organizations_url":"https://api.github.com/users/bcoca/orgs","repos_url":"https://api.github.com/users/bcoca/repos","events_url":"https://api.github.com/users/bcoca/events{/privacy}","received_events_url":"https://api.github.com/users/bcoca/received_events","type":"User","site_admin":false},"assignees":[{"login":"bcoca","id":836171,"avatar_url":"https://avatars.githubusercontent.com/u/836171?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoca","html_url":"https://github.com/bcoca","followers_url":"https://api.github.com/users/bcoca/followers","following_url":"https://api.github.com/users/bcoca/following{/other_user}","gists_url":"https://api.github.com/users/bcoca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoca/subscriptions","organizations_url":"https://api.github.com/users/bcoca/orgs","repos_url":"https://api.github.com/users/bcoca/repos","events_url":"https://api.github.com/users/bcoca/events{/privacy}","received_events_url":"https://api.github.com/users/bcoca/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ansible/ansible/milestones/8","html_url":"https://github.com/ansible/ansible/milestones/2.2.0","labels_url":"https://api.github.com/repos/ansible/ansible/milestones/8/labels","id":1702615,"number":8,"title":"2.2.0","description":"","creator":{"login":"sivel","id":39340,"avatar_url":"https://avatars.githubusercontent.com/u/39340?v=3","gravatar_id":"","url":"https://api.github.com/users/sivel","html_url":"https://github.com/sivel","followers_url":"https://api.github.com/users/sivel/followers","following_url":"https://api.github.com/users/sivel/following{/other_user}","gists_url":"https://api.github.com/users/sivel/gists{/gist_id}","starred_url":"https://api.github.com/users/sivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivel/subscriptions","organizations_url":"https://api.github.com/users/sivel/orgs","repos_url":"https://api.github.com/users/sivel/repos","events_url":"https://api.github.com/users/sivel/events{/privacy}","received_events_url":"https://api.github.com/users/sivel/received_events","type":"User","site_admin":false},"open_issues":156,"closed_issues":279,"state":"open","created_at":"2016-04-12T23:10:49Z","updated_at":"2016-09-30T17:31:37Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-09-28T19:58:21Z","updated_at":"2016-09-30T17:31:37Z","closed_at":"2016-09-30T17:31:37Z","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/17799","html_url":"https://github.com/ansible/ansible/pull/17799","diff_url":"https://github.com/ansible/ansible/pull/17799.diff","patch_url":"https://github.com/ansible/ansible/pull/17799.patch"},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n\r\n - Bugfix Pull Request\r\n \r\n\r\n##### COMPONENT NAME\r\nfact gathering policy\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\nansible 2.2.0 (gather_smart_facts_17213 4649e70eec) last updated 2016/09/28 15:56:26 (GMT -400)\r\n  lib/ansible/modules/core: (detached HEAD 7808f42aff) last updated 2016/09/28 15:39:58 (GMT -400)\r\n  lib/ansible/modules/extras: (detached HEAD 881d2f95a8) last updated 2016/09/28 15:39:58 (GMT -400)\r\n  config file = /home/adrian/ansible/ansible.cfg\r\n  configured module search path = Default w/o overrides\r\n\r\n```\r\n\r\n##### SUMMARY\r\n\r\n\r\n<!-- Paste verbatim command output below, e.g. before and after your change -->\r\n\r\nIf the 'gathering' facts collection config was set\r\nto 'smart', any module that returned ansible_facts would\r\nmark a host as having had _gathered_facts=True, by way\r\nof adding the hostname to the fact cache for module facts,\r\neven if 'setup' itself was never invoked and no other facts\r\nwere cached.\r\n\r\nInstead of allowing existense of the hostname key in fact\r\ncache to determine initial _gathered_facts, only set if\r\nif the 'setup' action was invoked.\r\n\r\nFixes #17213"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/250804582","html_url":"https://github.com/ansible/ansible/pull/17799#issuecomment-250804582","issue_url":"https://api.github.com/repos/ansible/ansible/issues/17799","id":250804582,"user":{"login":"jimi-c","id":26403,"avatar_url":"https://avatars.githubusercontent.com/u/26403?v=3","gravatar_id":"","url":"https://api.github.com/users/jimi-c","html_url":"https://github.com/jimi-c","followers_url":"https://api.github.com/users/jimi-c/followers","following_url":"https://api.github.com/users/jimi-c/following{/other_user}","gists_url":"https://api.github.com/users/jimi-c/gists{/gist_id}","starred_url":"https://api.github.com/users/jimi-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimi-c/subscriptions","organizations_url":"https://api.github.com/users/jimi-c/orgs","repos_url":"https://api.github.com/users/jimi-c/repos","events_url":"https://api.github.com/users/jimi-c/events{/privacy}","received_events_url":"https://api.github.com/users/jimi-c/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T17:31:37Z","updated_at":"2016-09-30T17:31:37Z","body":"We're going to fix this another way, per discussion today."}}
{"actor":{"display_login":"jimi-c"}}