{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/92525683","pull_request_review_id":13042726,"id":92525683,"diff_hunk":"@@ -1,11 +1,1039 @@\n-imageName: \"grafana/grafana\"\n-adminUser: \"admin\"\n-adminPassword: \"admin\"\n+server:\n+  ## Grafana Pod annotations:\n+  ##\n+  # annotations:\n+  #   iam.amazonaws.com/role: grafana\n \n-# Persist data to a persitent volume\n-persistence:\n-  enabled: true\n-  storageClass: generic\n-  accessMode: ReadWriteOnce\n-  size: \"1Gi\"\n+  ## Grafana service port\n+  ##\n+  httpPort: 80\n \n+  ## Grafana Docker image\n+  ##\n+  image: \"grafana/grafana:latest\"\n+\n+  ingress:\n+    ## If true, Grafana Ingress will be created\n+    ##\n+    enabled: false\n+\n+    ## Grafana Ingress annotations\n+    ##\n+    # annotations:\n+    #   kubernetes.io/ingress.class: nginx\n+    #   kubernetes.io/tls-acme: 'true'\n+\n+    ## Grafana Ingress hostnames\n+    ## Must be provided if Ingress is enabled\n+    ##\n+    # hosts:\n+    #   - grafana.domain.com\n+\n+    ## Grafana Ingress TLS configuration\n+    ## Secrets must be manually created in the namespace\n+    ##\n+    # tls:\n+    #   - secretName: grafana-server-tls\n+    #     hosts:\n+    #       - grafana.domain.com\n+\n+  ## Grafana container name\n+  ##\n+  name: grafana\n+\n+  adminUser: \"admin\"\n+  adminPassword: \"admin\"\n+\n+  ## Global imagePullPolicy\n+  ## Default: 'Always' if image tag is 'latest', else 'IfNotPresent'\n+  ## Ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images\n+  ##\n+  # imagePullPolicy:\n+\n+  # Persist data to a persitent volume\n+  persistentVolume:\n+    ## If true, Grafana will create a Persistent Volume Claim\n+    ## If false, use emptyDir\n+    ##\n+    enabled: true\n+\n+    ## Grafana data Persistent Volume access modes\n+    ## Must match those of existing PV or dynamic provisioner\n+    ## Ref: http://kubernetes.io/docs/user-guide/persistent-volumes/\n+    ##\n+    accessModes:\n+      - ReadWriteOnce\n+\n+    ## Server data Persistent Volume annotations\n+    ##\n+    # annotations:\n+\n+    ## Grafana data Persistent Volume size\n+    ## Default: 1Gi\n+    ##\n+    size: 1Gi\n+\n+    ## Data Persistent Volume Storage Class\n+    ## If defined, volume.beta.kubernetes.io/storage-class: <storageClass>\n+    ## Default: volume.alpha.kubernetes.io/storage-class: default\n+    ##\n+    # storageClass:\n+\n+  ## Grafana resource requests and limits\n+  ## Ref: http://kubernetes.io/docs/user-guide/compute-resources/\n+  ##\n+  resources:\n+    # limits:\n+    #   cpu: 500m\n+    #   memory: 512Mi\n+    requests:\n+      cpu: 100m\n+      memory: 100Mi\n+\n+  serviceType: NodePort","path":"incubator/grafana/values.yaml","position":102,"original_position":102,"commit_id":"cb68a4c1a679a1de22b4a99940d2757d98fbd211","original_commit_id":"cb68a4c1a679a1de22b4a99940d2757d98fbd211","user":{"login":"viglesiasce","id":410279,"avatar_url":"https://avatars.githubusercontent.com/u/410279?v=3","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"body":"Make this a  ClusterIP by default","created_at":"2016-12-15T01:07:37Z","updated_at":"2016-12-15T01:10:35Z","html_url":"https://github.com/kubernetes/charts/pull/292#discussion_r92525683","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/292","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/92525683"},"html":{"href":"https://github.com/kubernetes/charts/pull/292#discussion_r92525683"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/292","id":97870842,"html_url":"https://github.com/kubernetes/charts/pull/292","diff_url":"https://github.com/kubernetes/charts/pull/292.diff","patch_url":"https://github.com/kubernetes/charts/pull/292.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/292","number":292,"state":"open","locked":false,"title":"modify grafana chart as prometheus like format","user":{"login":"zanhsieh","id":283101,"avatar_url":"https://avatars.githubusercontent.com/u/283101?v=3","gravatar_id":"","url":"https://api.github.com/users/zanhsieh","html_url":"https://github.com/zanhsieh","followers_url":"https://api.github.com/users/zanhsieh/followers","following_url":"https://api.github.com/users/zanhsieh/following{/other_user}","gists_url":"https://api.github.com/users/zanhsieh/gists{/gist_id}","starred_url":"https://api.github.com/users/zanhsieh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanhsieh/subscriptions","organizations_url":"https://api.github.com/users/zanhsieh/orgs","repos_url":"https://api.github.com/users/zanhsieh/repos","events_url":"https://api.github.com/users/zanhsieh/events{/privacy}","received_events_url":"https://api.github.com/users/zanhsieh/received_events","type":"User","site_admin":false},"body":"1. Prometheus-like chart format\r\n2. Dashboard example\r\n3. Initial add datasource example","created_at":"2016-12-14T01:27:12Z","updated_at":"2016-12-15T01:10:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f9b4b3ca1778b86029a2699938884b8183b7601","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/292/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/292/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/292/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/cb68a4c1a679a1de22b4a99940d2757d98fbd211","head":{"label":"zanhsieh:master","ref":"master","sha":"cb68a4c1a679a1de22b4a99940d2757d98fbd211","user":{"login":"zanhsieh","id":283101,"avatar_url":"https://avatars.githubusercontent.com/u/283101?v=3","gravatar_id":"","url":"https://api.github.com/users/zanhsieh","html_url":"https://github.com/zanhsieh","followers_url":"https://api.github.com/users/zanhsieh/followers","following_url":"https://api.github.com/users/zanhsieh/following{/other_user}","gists_url":"https://api.github.com/users/zanhsieh/gists{/gist_id}","starred_url":"https://api.github.com/users/zanhsieh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanhsieh/subscriptions","organizations_url":"https://api.github.com/users/zanhsieh/orgs","repos_url":"https://api.github.com/users/zanhsieh/repos","events_url":"https://api.github.com/users/zanhsieh/events{/privacy}","received_events_url":"https://api.github.com/users/zanhsieh/received_events","type":"User","site_admin":false},"repo":{"id":76412702,"name":"charts","full_name":"zanhsieh/charts","owner":{"login":"zanhsieh","id":283101,"avatar_url":"https://avatars.githubusercontent.com/u/283101?v=3","gravatar_id":"","url":"https://api.github.com/users/zanhsieh","html_url":"https://github.com/zanhsieh","followers_url":"https://api.github.com/users/zanhsieh/followers","following_url":"https://api.github.com/users/zanhsieh/following{/other_user}","gists_url":"https://api.github.com/users/zanhsieh/gists{/gist_id}","starred_url":"https://api.github.com/users/zanhsieh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanhsieh/subscriptions","organizations_url":"https://api.github.com/users/zanhsieh/orgs","repos_url":"https://api.github.com/users/zanhsieh/repos","events_url":"https://api.github.com/users/zanhsieh/events{/privacy}","received_events_url":"https://api.github.com/users/zanhsieh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zanhsieh/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/zanhsieh/charts","forks_url":"https://api.github.com/repos/zanhsieh/charts/forks","keys_url":"https://api.github.com/repos/zanhsieh/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanhsieh/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanhsieh/charts/teams","hooks_url":"https://api.github.com/repos/zanhsieh/charts/hooks","issue_events_url":"https://api.github.com/repos/zanhsieh/charts/issues/events{/number}","events_url":"https://api.github.com/repos/zanhsieh/charts/events","assignees_url":"https://api.github.com/repos/zanhsieh/charts/assignees{/user}","branches_url":"https://api.github.com/repos/zanhsieh/charts/branches{/branch}","tags_url":"https://api.github.com/repos/zanhsieh/charts/tags","blobs_url":"https://api.github.com/repos/zanhsieh/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanhsieh/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanhsieh/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanhsieh/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanhsieh/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/zanhsieh/charts/languages","stargazers_url":"https://api.github.com/repos/zanhsieh/charts/stargazers","contributors_url":"https://api.github.com/repos/zanhsieh/charts/contributors","subscribers_url":"https://api.github.com/repos/zanhsieh/charts/subscribers","subscription_url":"https://api.github.com/repos/zanhsieh/charts/subscription","commits_url":"https://api.github.com/repos/zanhsieh/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanhsieh/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanhsieh/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanhsieh/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanhsieh/charts/contents/{+path}","compare_url":"https://api.github.com/repos/zanhsieh/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanhsieh/charts/merges","archive_url":"https://api.github.com/repos/zanhsieh/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanhsieh/charts/downloads","issues_url":"https://api.github.com/repos/zanhsieh/charts/issues{/number}","pulls_url":"https://api.github.com/repos/zanhsieh/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/zanhsieh/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/zanhsieh/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanhsieh/charts/labels{/name}","releases_url":"https://api.github.com/repos/zanhsieh/charts/releases{/id}","deployments_url":"https://api.github.com/repos/zanhsieh/charts/deployments","created_at":"2016-12-14T01:19:29Z","updated_at":"2016-12-14T01:19:31Z","pushed_at":"2016-12-14T01:25:10Z","git_url":"git://github.com/zanhsieh/charts.git","ssh_url":"git@github.com:zanhsieh/charts.git","clone_url":"https://github.com/zanhsieh/charts.git","svn_url":"https://github.com/zanhsieh/charts","homepage":"","size":497,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9f202405f116ee4326d6dce427ae2742da21a05a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2016-12-13T19:49:01Z","pushed_at":"2016-12-15T00:39:32Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":1329,"stargazers_count":185,"watchers_count":185,"language":"Smarty","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":61,"forks":119,"open_issues":61,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/292"},"html":{"href":"https://github.com/kubernetes/charts/pull/292"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/292"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/cb68a4c1a679a1de22b4a99940d2757d98fbd211"}}}}
{"actor":{"display_login":"viglesiasce"}}