{"action":"closed","number":462,"pull_request":{"url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/462","id":77146733,"html_url":"https://github.com/superdesk/superdesk-core/pull/462","diff_url":"https://github.com/superdesk/superdesk-core/pull/462.diff","patch_url":"https://github.com/superdesk/superdesk-core/pull/462.patch","issue_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/462","number":462,"state":"closed","locked":false,"title":"[FORMATTER][NITF] reorganized NITF formatter code to make it more eas…","user":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"body":"…y to subclass\r\n\r\nthis commit mainly replaces double underscore prefixes by single ones to\r\navoid name mangling, so subclassing is more doable.\r\n\r\nSome code parts have been removed to specific methods, again to make\r\nsubclassing more easy.\r\n\r\nThere is also a slight behaviour modification, the former code was:\r\n    if 'priority' in article:\r\n\tSubElement(head, 'meta', {'name': 'aap-priority', 'content': str(article.get('priority', '3'))})\r\nThis may the '3' default value could never be used as the \"if\" forbid the\r\ncode to be executed if article['priority'] is not set. So the \"if\" has\r\nbeen removed.\r\n\r\ncommit needed for SDNTB-229","created_at":"2016-07-12T16:17:58Z","updated_at":"2016-07-14T13:51:47Z","closed_at":"2016-07-14T13:51:47Z","merged_at":"2016-07-14T13:51:47Z","merge_commit_sha":"161a4ba6251101a486ea36570f7bf97de7bd72f8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/462/commits","review_comments_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/462/comments","review_comment_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/462/comments","statuses_url":"https://api.github.com/repos/superdesk/superdesk-core/statuses/f013ea86d3dcb9ca1a2a35b156693c4913643d9c","head":{"label":"jerome-poisson:SDNTB-229","ref":"SDNTB-229","sha":"f013ea86d3dcb9ca1a2a35b156693c4913643d9c","user":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"repo":{"id":55399604,"name":"superdesk-core","full_name":"jerome-poisson/superdesk-core","owner":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerome-poisson/superdesk-core","description":"common server modules for superdesk","fork":true,"url":"https://api.github.com/repos/jerome-poisson/superdesk-core","forks_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/forks","keys_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/teams","hooks_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/hooks","issue_events_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/issues/events{/number}","events_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/events","assignees_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/assignees{/user}","branches_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/branches{/branch}","tags_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/tags","blobs_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/languages","stargazers_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/stargazers","contributors_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/contributors","subscribers_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/subscribers","subscription_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/subscription","commits_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/contents/{+path}","compare_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/merges","archive_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/downloads","issues_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/issues{/number}","pulls_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/labels{/name}","releases_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/releases{/id}","deployments_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/deployments","created_at":"2016-04-04T09:35:09Z","updated_at":"2016-04-04T09:35:11Z","pushed_at":"2016-07-12T16:04:16Z","git_url":"git://github.com/jerome-poisson/superdesk-core.git","ssh_url":"git@github.com:jerome-poisson/superdesk-core.git","clone_url":"https://github.com/jerome-poisson/superdesk-core.git","svn_url":"https://github.com/jerome-poisson/superdesk-core","homepage":"","size":8150,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superdesk:master","ref":"master","sha":"79022d78ab46949b99140447ae90a4e2cec26bed","user":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"repo":{"id":41092776,"name":"superdesk-core","full_name":"superdesk/superdesk-core","owner":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superdesk/superdesk-core","description":"common server modules for superdesk","fork":false,"url":"https://api.github.com/repos/superdesk/superdesk-core","forks_url":"https://api.github.com/repos/superdesk/superdesk-core/forks","keys_url":"https://api.github.com/repos/superdesk/superdesk-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdesk/superdesk-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdesk/superdesk-core/teams","hooks_url":"https://api.github.com/repos/superdesk/superdesk-core/hooks","issue_events_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/events{/number}","events_url":"https://api.github.com/repos/superdesk/superdesk-core/events","assignees_url":"https://api.github.com/repos/superdesk/superdesk-core/assignees{/user}","branches_url":"https://api.github.com/repos/superdesk/superdesk-core/branches{/branch}","tags_url":"https://api.github.com/repos/superdesk/superdesk-core/tags","blobs_url":"https://api.github.com/repos/superdesk/superdesk-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdesk/superdesk-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdesk/superdesk-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdesk/superdesk-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdesk/superdesk-core/statuses/{sha}","languages_url":"https://api.github.com/repos/superdesk/superdesk-core/languages","stargazers_url":"https://api.github.com/repos/superdesk/superdesk-core/stargazers","contributors_url":"https://api.github.com/repos/superdesk/superdesk-core/contributors","subscribers_url":"https://api.github.com/repos/superdesk/superdesk-core/subscribers","subscription_url":"https://api.github.com/repos/superdesk/superdesk-core/subscription","commits_url":"https://api.github.com/repos/superdesk/superdesk-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdesk/superdesk-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdesk/superdesk-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdesk/superdesk-core/contents/{+path}","compare_url":"https://api.github.com/repos/superdesk/superdesk-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdesk/superdesk-core/merges","archive_url":"https://api.github.com/repos/superdesk/superdesk-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdesk/superdesk-core/downloads","issues_url":"https://api.github.com/repos/superdesk/superdesk-core/issues{/number}","pulls_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls{/number}","milestones_url":"https://api.github.com/repos/superdesk/superdesk-core/milestones{/number}","notifications_url":"https://api.github.com/repos/superdesk/superdesk-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdesk/superdesk-core/labels{/name}","releases_url":"https://api.github.com/repos/superdesk/superdesk-core/releases{/id}","deployments_url":"https://api.github.com/repos/superdesk/superdesk-core/deployments","created_at":"2015-08-20T11:46:19Z","updated_at":"2016-06-28T08:44:38Z","pushed_at":"2016-07-14T13:51:47Z","git_url":"git://github.com/superdesk/superdesk-core.git","ssh_url":"git@github.com:superdesk/superdesk-core.git","clone_url":"https://github.com/superdesk/superdesk-core.git","svn_url":"https://github.com/superdesk/superdesk-core","homepage":"","size":8279,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":9,"forks":25,"open_issues":9,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/462"},"html":{"href":"https://github.com/superdesk/superdesk-core/pull/462"},"issue":{"href":"https://api.github.com/repos/superdesk/superdesk-core/issues/462"},"comments":{"href":"https://api.github.com/repos/superdesk/superdesk-core/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/superdesk/superdesk-core/statuses/f013ea86d3dcb9ca1a2a35b156693c4913643d9c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":43,"deletions":31,"changed_files":1}}
{"actor":{"display_login":"jerome-poisson"}}