{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3756","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3756/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3756/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3756/events","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/3756","id":129755583,"number":3756,"title":"Annotations refactoring for 4.0.0","user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"labels":[{"id":143173729,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Android","name":"Android","color":"000000","default":false},{"id":121069548,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/refactor","name":"refactor","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/26","html_url":"https://github.com/mapbox/mapbox-gl-native/milestone/26","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/26/labels","id":1520788,"number":26,"title":"android-v4.0.0","description":"","creator":{"login":"bleege","id":989928,"avatar_url":"https://avatars.githubusercontent.com/u/989928?v=3","gravatar_id":"","url":"https://api.github.com/users/bleege","html_url":"https://github.com/bleege","followers_url":"https://api.github.com/users/bleege/followers","following_url":"https://api.github.com/users/bleege/following{/other_user}","gists_url":"https://api.github.com/users/bleege/gists{/gist_id}","starred_url":"https://api.github.com/users/bleege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleege/subscriptions","organizations_url":"https://api.github.com/users/bleege/orgs","repos_url":"https://api.github.com/users/bleege/repos","events_url":"https://api.github.com/users/bleege/events{/privacy}","received_events_url":"https://api.github.com/users/bleege/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":336,"state":"closed","created_at":"2016-01-19T23:39:55Z","updated_at":"2016-04-06T14:21:08Z","due_on":null,"closed_at":"2016-04-06T14:21:08Z"},"comments":9,"created_at":"2016-01-29T12:45:43Z","updated_at":"2016-12-12T14:26:41Z","closed_at":"2016-02-15T16:06:11Z","body":"We should refactor the annotations package before freezing the api with the  `4.0.0` release:\n- [x]  discuss the need for IconFactory and see if we can remove it\n  - we can't remove this, needed for JNI\n- [x]  support inheritance (iOS parity) or provide an alternative for https://github.com/mapbox/mapbox-gl-native/issues/3041\n- [x]  ~~provide a way to pass in custom data to a marker. (equivalent of `setTag` in Android SDK)~~\n- [x]  convention names/models with GeoJSON https://github.com/mapbox/mapbox-gl-native/issues/3288\n  -  going to punt on this until roadmap GeoJSON is more clear\n- [x] add getters for different subtypes of annotation\n- [x] add a removeAnnotation(id) method\n- [x] add unit tests!\n"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/266443755","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/3756#issuecomment-266443755","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/3756","id":266443755,"user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T14:26:41Z","updated_at":"2016-12-12T14:26:41Z","body":"I would love to add the setTag method but that wasn't possible due the contract with Parceable inteface :disappointed:. That said, if inheritance is too much hassle and you aren't creating an insane amount of annotations I would suggest using `Map<Annotation,Object>` or `LongSparseArray<Object>` where the  key = id of the Annotation. "}}
{"actor":{"display_login":"tobrun"}}