{"action":"closed","number":18668,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/18668","id":86664239,"html_url":"https://github.com/JuliaLang/julia/pull/18668","diff_url":"https://github.com/JuliaLang/julia/pull/18668.diff","patch_url":"https://github.com/JuliaLang/julia/pull/18668.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/18668","number":18668,"state":"closed","locked":false,"title":"make findnext work for utf8 strings (and other iterators)","user":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"body":"... and why not use closures on 0.6, so that there is actually only one real implementation of findnext.\r\nA simple benchmark suggests that there are no speed regression:\r\n```Julia\r\nusing BenchmarkTools\r\na = rand(10000)\r\nv = 42.0\r\na[end] == v\r\nb1 = @benchmark simon.findnext($a, $v, $(1))\r\nb2 = @benchmark master.findnext($a, $v, $(1))\r\njudge(minimum(b1), minimum(b2))\r\n-> invariant\r\n```","created_at":"2016-09-25T22:02:52Z","updated_at":"2016-10-11T11:25:39Z","closed_at":"2016-10-11T11:25:39Z","merged_at":null,"merge_commit_sha":"250a771cc980d30d6076125576c56bf1a83e2241","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18668/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/18668/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/18668/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/23aa0cd353f3b88eb5ca5fc22cdd5219d641810e","head":{"label":"SimonDanisch:master","ref":"master","sha":"23aa0cd353f3b88eb5ca5fc22cdd5219d641810e","user":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"repo":{"id":27457519,"name":"julia","full_name":"SimonDanisch/julia","owner":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonDanisch/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/SimonDanisch/julia","forks_url":"https://api.github.com/repos/SimonDanisch/julia/forks","keys_url":"https://api.github.com/repos/SimonDanisch/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonDanisch/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonDanisch/julia/teams","hooks_url":"https://api.github.com/repos/SimonDanisch/julia/hooks","issue_events_url":"https://api.github.com/repos/SimonDanisch/julia/issues/events{/number}","events_url":"https://api.github.com/repos/SimonDanisch/julia/events","assignees_url":"https://api.github.com/repos/SimonDanisch/julia/assignees{/user}","branches_url":"https://api.github.com/repos/SimonDanisch/julia/branches{/branch}","tags_url":"https://api.github.com/repos/SimonDanisch/julia/tags","blobs_url":"https://api.github.com/repos/SimonDanisch/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonDanisch/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonDanisch/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonDanisch/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonDanisch/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonDanisch/julia/languages","stargazers_url":"https://api.github.com/repos/SimonDanisch/julia/stargazers","contributors_url":"https://api.github.com/repos/SimonDanisch/julia/contributors","subscribers_url":"https://api.github.com/repos/SimonDanisch/julia/subscribers","subscription_url":"https://api.github.com/repos/SimonDanisch/julia/subscription","commits_url":"https://api.github.com/repos/SimonDanisch/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonDanisch/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonDanisch/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonDanisch/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonDanisch/julia/contents/{+path}","compare_url":"https://api.github.com/repos/SimonDanisch/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonDanisch/julia/merges","archive_url":"https://api.github.com/repos/SimonDanisch/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonDanisch/julia/downloads","issues_url":"https://api.github.com/repos/SimonDanisch/julia/issues{/number}","pulls_url":"https://api.github.com/repos/SimonDanisch/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonDanisch/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonDanisch/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonDanisch/julia/labels{/name}","releases_url":"https://api.github.com/repos/SimonDanisch/julia/releases{/id}","deployments_url":"https://api.github.com/repos/SimonDanisch/julia/deployments","created_at":"2014-12-02T22:50:15Z","updated_at":"2016-09-25T21:59:08Z","pushed_at":"2016-10-11T11:25:38Z","git_url":"git://github.com/SimonDanisch/julia.git","ssh_url":"git@github.com:SimonDanisch/julia.git","clone_url":"https://github.com/SimonDanisch/julia.git","svn_url":"https://github.com/SimonDanisch/julia","homepage":"http://julialang.org/","size":93541,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"496dd4041576c33a7568e2617f9906251220b73f","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-10-11T07:44:04Z","pushed_at":"2016-10-11T10:43:48Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":424441,"stargazers_count":7650,"watchers_count":7650,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1793,"mirror_url":null,"open_issues_count":2071,"forks":1793,"open_issues":2071,"watchers":7650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18668"},"html":{"href":"https://github.com/JuliaLang/julia/pull/18668"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/18668"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/18668/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18668/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/18668/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/23aa0cd353f3b88eb5ca5fc22cdd5219d641810e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":11,"review_comments":15,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"SimonDanisch"}}