{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/3","id":65175586,"html_url":"https://github.com/pitermarx/NCalc-Edge/pull/3","diff_url":"https://github.com/pitermarx/NCalc-Edge/pull/3.diff","patch_url":"https://github.com/pitermarx/NCalc-Edge/pull/3.patch","issue_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/issues/3","number":3,"state":"open","locked":false,"title":"allow null parameters when comparing to nullable value","user":{"login":"tmenier","id":1350414,"avatar_url":"https://avatars.githubusercontent.com/u/1350414?v=3","gravatar_id":"","url":"https://api.github.com/users/tmenier","html_url":"https://github.com/tmenier","followers_url":"https://api.github.com/users/tmenier/followers","following_url":"https://api.github.com/users/tmenier/following{/other_user}","gists_url":"https://api.github.com/users/tmenier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmenier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmenier/subscriptions","organizations_url":"https://api.github.com/users/tmenier/orgs","repos_url":"https://api.github.com/users/tmenier/repos","events_url":"https://api.github.com/users/tmenier/events{/privacy}","received_events_url":"https://api.github.com/users/tmenier/received_events","type":"User","site_admin":false},"body":"Previously this test failed with a NullReferenceException (on x.GetType() deep inside EvaluationVisitor):\r\n\r\n````\r\n[TestMethod]\r\npublic void ShouldCompareNullToString() {\r\n    var e = new Expression(\"[x] = 'foo'\");\r\n    e.Parameters[\"x\"] = null;\r\n    Assert.IsFalse((bool)e.Evaluate());\r\n}\r\n````\r\n\r\nWhen comparing null to a NON-nullable value (such as an integer) and an exception is thrown, an argument could be made that that was the author's intent. However, I believe the above issue is a legitimate bug.","created_at":"2016-04-04T16:40:26Z","updated_at":"2016-04-04T16:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/3/commits","review_comments_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/3/comments","review_comment_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/issues/3/comments","statuses_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/statuses/3d28d524dd3f801a318e178ab8bab831e43f1a5b","head":{"label":"tmenier:master","ref":"master","sha":"3d28d524dd3f801a318e178ab8bab831e43f1a5b","user":{"login":"tmenier","id":1350414,"avatar_url":"https://avatars.githubusercontent.com/u/1350414?v=3","gravatar_id":"","url":"https://api.github.com/users/tmenier","html_url":"https://github.com/tmenier","followers_url":"https://api.github.com/users/tmenier/followers","following_url":"https://api.github.com/users/tmenier/following{/other_user}","gists_url":"https://api.github.com/users/tmenier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmenier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmenier/subscriptions","organizations_url":"https://api.github.com/users/tmenier/orgs","repos_url":"https://api.github.com/users/tmenier/repos","events_url":"https://api.github.com/users/tmenier/events{/privacy}","received_events_url":"https://api.github.com/users/tmenier/received_events","type":"User","site_admin":false},"repo":{"id":55418265,"name":"NCalc-Edge","full_name":"tmenier/NCalc-Edge","owner":{"login":"tmenier","id":1350414,"avatar_url":"https://avatars.githubusercontent.com/u/1350414?v=3","gravatar_id":"","url":"https://api.github.com/users/tmenier","html_url":"https://github.com/tmenier","followers_url":"https://api.github.com/users/tmenier/followers","following_url":"https://api.github.com/users/tmenier/following{/other_user}","gists_url":"https://api.github.com/users/tmenier/gists{/gist_id}","starred_url":"https://api.github.com/users/tmenier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmenier/subscriptions","organizations_url":"https://api.github.com/users/tmenier/orgs","repos_url":"https://api.github.com/users/tmenier/repos","events_url":"https://api.github.com/users/tmenier/events{/privacy}","received_events_url":"https://api.github.com/users/tmenier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmenier/NCalc-Edge","description":"A clone of NCalc. Latest source. Published to Nuget.org. version 1.4.1","fork":true,"url":"https://api.github.com/repos/tmenier/NCalc-Edge","forks_url":"https://api.github.com/repos/tmenier/NCalc-Edge/forks","keys_url":"https://api.github.com/repos/tmenier/NCalc-Edge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmenier/NCalc-Edge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmenier/NCalc-Edge/teams","hooks_url":"https://api.github.com/repos/tmenier/NCalc-Edge/hooks","issue_events_url":"https://api.github.com/repos/tmenier/NCalc-Edge/issues/events{/number}","events_url":"https://api.github.com/repos/tmenier/NCalc-Edge/events","assignees_url":"https://api.github.com/repos/tmenier/NCalc-Edge/assignees{/user}","branches_url":"https://api.github.com/repos/tmenier/NCalc-Edge/branches{/branch}","tags_url":"https://api.github.com/repos/tmenier/NCalc-Edge/tags","blobs_url":"https://api.github.com/repos/tmenier/NCalc-Edge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmenier/NCalc-Edge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmenier/NCalc-Edge/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmenier/NCalc-Edge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmenier/NCalc-Edge/statuses/{sha}","languages_url":"https://api.github.com/repos/tmenier/NCalc-Edge/languages","stargazers_url":"https://api.github.com/repos/tmenier/NCalc-Edge/stargazers","contributors_url":"https://api.github.com/repos/tmenier/NCalc-Edge/contributors","subscribers_url":"https://api.github.com/repos/tmenier/NCalc-Edge/subscribers","subscription_url":"https://api.github.com/repos/tmenier/NCalc-Edge/subscription","commits_url":"https://api.github.com/repos/tmenier/NCalc-Edge/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmenier/NCalc-Edge/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmenier/NCalc-Edge/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmenier/NCalc-Edge/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmenier/NCalc-Edge/contents/{+path}","compare_url":"https://api.github.com/repos/tmenier/NCalc-Edge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmenier/NCalc-Edge/merges","archive_url":"https://api.github.com/repos/tmenier/NCalc-Edge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmenier/NCalc-Edge/downloads","issues_url":"https://api.github.com/repos/tmenier/NCalc-Edge/issues{/number}","pulls_url":"https://api.github.com/repos/tmenier/NCalc-Edge/pulls{/number}","milestones_url":"https://api.github.com/repos/tmenier/NCalc-Edge/milestones{/number}","notifications_url":"https://api.github.com/repos/tmenier/NCalc-Edge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmenier/NCalc-Edge/labels{/name}","releases_url":"https://api.github.com/repos/tmenier/NCalc-Edge/releases{/id}","deployments_url":"https://api.github.com/repos/tmenier/NCalc-Edge/deployments","created_at":"2016-04-04T14:32:19Z","updated_at":"2016-04-04T14:32:20Z","pushed_at":"2016-04-04T16:31:31Z","git_url":"git://github.com/tmenier/NCalc-Edge.git","ssh_url":"git@github.com:tmenier/NCalc-Edge.git","clone_url":"https://github.com/tmenier/NCalc-Edge.git","svn_url":"https://github.com/tmenier/NCalc-Edge","homepage":"http://ncalc.codeplex.com/","size":143,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pitermarx:master","ref":"master","sha":"df36670ac4da131d696ad7beef21103c141db25e","user":{"login":"pitermarx","id":3081298,"avatar_url":"https://avatars.githubusercontent.com/u/3081298?v=3","gravatar_id":"","url":"https://api.github.com/users/pitermarx","html_url":"https://github.com/pitermarx","followers_url":"https://api.github.com/users/pitermarx/followers","following_url":"https://api.github.com/users/pitermarx/following{/other_user}","gists_url":"https://api.github.com/users/pitermarx/gists{/gist_id}","starred_url":"https://api.github.com/users/pitermarx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitermarx/subscriptions","organizations_url":"https://api.github.com/users/pitermarx/orgs","repos_url":"https://api.github.com/users/pitermarx/repos","events_url":"https://api.github.com/users/pitermarx/events{/privacy}","received_events_url":"https://api.github.com/users/pitermarx/received_events","type":"User","site_admin":false},"repo":{"id":32926487,"name":"NCalc-Edge","full_name":"pitermarx/NCalc-Edge","owner":{"login":"pitermarx","id":3081298,"avatar_url":"https://avatars.githubusercontent.com/u/3081298?v=3","gravatar_id":"","url":"https://api.github.com/users/pitermarx","html_url":"https://github.com/pitermarx","followers_url":"https://api.github.com/users/pitermarx/followers","following_url":"https://api.github.com/users/pitermarx/following{/other_user}","gists_url":"https://api.github.com/users/pitermarx/gists{/gist_id}","starred_url":"https://api.github.com/users/pitermarx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitermarx/subscriptions","organizations_url":"https://api.github.com/users/pitermarx/orgs","repos_url":"https://api.github.com/users/pitermarx/repos","events_url":"https://api.github.com/users/pitermarx/events{/privacy}","received_events_url":"https://api.github.com/users/pitermarx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pitermarx/NCalc-Edge","description":"A clone of NCalc. Latest source. Published to Nuget.org. version 1.4.1","fork":false,"url":"https://api.github.com/repos/pitermarx/NCalc-Edge","forks_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/forks","keys_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/teams","hooks_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/hooks","issue_events_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/issues/events{/number}","events_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/events","assignees_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/assignees{/user}","branches_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/branches{/branch}","tags_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/tags","blobs_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/git/refs{/sha}","trees_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/statuses/{sha}","languages_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/languages","stargazers_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/stargazers","contributors_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/contributors","subscribers_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/subscribers","subscription_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/subscription","commits_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/commits{/sha}","git_commits_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/git/commits{/sha}","comments_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/comments{/number}","issue_comment_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/issues/comments{/number}","contents_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/contents/{+path}","compare_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/merges","archive_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/downloads","issues_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/issues{/number}","pulls_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls{/number}","milestones_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/milestones{/number}","notifications_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/labels{/name}","releases_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/releases{/id}","deployments_url":"https://api.github.com/repos/pitermarx/NCalc-Edge/deployments","created_at":"2015-03-26T12:37:40Z","updated_at":"2016-01-27T02:12:24Z","pushed_at":"2015-10-13T09:18:18Z","git_url":"git://github.com/pitermarx/NCalc-Edge.git","ssh_url":"git@github.com:pitermarx/NCalc-Edge.git","clone_url":"https://github.com/pitermarx/NCalc-Edge.git","svn_url":"https://github.com/pitermarx/NCalc-Edge","homepage":"http://ncalc.codeplex.com/","size":328,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/3"},"html":{"href":"https://github.com/pitermarx/NCalc-Edge/pull/3"},"issue":{"href":"https://api.github.com/repos/pitermarx/NCalc-Edge/issues/3"},"comments":{"href":"https://api.github.com/repos/pitermarx/NCalc-Edge/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pitermarx/NCalc-Edge/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/pitermarx/NCalc-Edge/statuses/3d28d524dd3f801a318e178ab8bab831e43f1a5b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":20,"changed_files":2}}