{"action":"closed","number":313,"pull_request":{"url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/313","id":81848087,"html_url":"https://github.com/tahoe-lafs/tahoe-lafs/pull/313","diff_url":"https://github.com/tahoe-lafs/tahoe-lafs/pull/313.diff","patch_url":"https://github.com/tahoe-lafs/tahoe-lafs/pull/313.patch","issue_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/313","number":313,"state":"closed","locked":false,"title":"Fix file-operations/inotify testing","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"body":"This re-factors the magic-folder tests to abstract the whole \"do a file operation\" so we can properly send fake (or wait for real) inotify events to the uploader/downloader. This speeds up the tests quite a bit and makes test_alice_bob reasonable again (at about 1.5s instead of over 30s).\r\n\r\nA few other cleanups and fixes are sprinkled in here, and an intermittent problem with magic-folder not shutting down properly if a test has an error is also solved.\r\n\r\nThis speeds up the whole test-suite by a little over 10%, down to 6 minutes on my machines.\r\n\r\nFixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2806","created_at":"2016-08-18T16:36:29Z","updated_at":"2016-08-19T01:04:15Z","closed_at":"2016-08-19T01:04:15Z","merged_at":"2016-08-19T01:04:15Z","merge_commit_sha":"5e011e65d3d47801e3c8a00e24c52ef8fd2d1555","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/313/commits","review_comments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/313/comments","review_comment_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/313/comments","statuses_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/statuses/5e011e65d3d47801e3c8a00e24c52ef8fd2d1555","head":{"label":"meejah:2806.magic-folder-test-speedup.1","ref":"2806.magic-folder-test-speedup.1","sha":"5e011e65d3d47801e3c8a00e24c52ef8fd2d1555","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"repo":{"id":42634043,"name":"tahoe-lafs","full_name":"meejah/tahoe-lafs","owner":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meejah/tahoe-lafs","description":"The Tahoe-LAFS decentralized secure filesystem.","fork":true,"url":"https://api.github.com/repos/meejah/tahoe-lafs","forks_url":"https://api.github.com/repos/meejah/tahoe-lafs/forks","keys_url":"https://api.github.com/repos/meejah/tahoe-lafs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meejah/tahoe-lafs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meejah/tahoe-lafs/teams","hooks_url":"https://api.github.com/repos/meejah/tahoe-lafs/hooks","issue_events_url":"https://api.github.com/repos/meejah/tahoe-lafs/issues/events{/number}","events_url":"https://api.github.com/repos/meejah/tahoe-lafs/events","assignees_url":"https://api.github.com/repos/meejah/tahoe-lafs/assignees{/user}","branches_url":"https://api.github.com/repos/meejah/tahoe-lafs/branches{/branch}","tags_url":"https://api.github.com/repos/meejah/tahoe-lafs/tags","blobs_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/refs{/sha}","trees_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meejah/tahoe-lafs/statuses/{sha}","languages_url":"https://api.github.com/repos/meejah/tahoe-lafs/languages","stargazers_url":"https://api.github.com/repos/meejah/tahoe-lafs/stargazers","contributors_url":"https://api.github.com/repos/meejah/tahoe-lafs/contributors","subscribers_url":"https://api.github.com/repos/meejah/tahoe-lafs/subscribers","subscription_url":"https://api.github.com/repos/meejah/tahoe-lafs/subscription","commits_url":"https://api.github.com/repos/meejah/tahoe-lafs/commits{/sha}","git_commits_url":"https://api.github.com/repos/meejah/tahoe-lafs/git/commits{/sha}","comments_url":"https://api.github.com/repos/meejah/tahoe-lafs/comments{/number}","issue_comment_url":"https://api.github.com/repos/meejah/tahoe-lafs/issues/comments{/number}","contents_url":"https://api.github.com/repos/meejah/tahoe-lafs/contents/{+path}","compare_url":"https://api.github.com/repos/meejah/tahoe-lafs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meejah/tahoe-lafs/merges","archive_url":"https://api.github.com/repos/meejah/tahoe-lafs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meejah/tahoe-lafs/downloads","issues_url":"https://api.github.com/repos/meejah/tahoe-lafs/issues{/number}","pulls_url":"https://api.github.com/repos/meejah/tahoe-lafs/pulls{/number}","milestones_url":"https://api.github.com/repos/meejah/tahoe-lafs/milestones{/number}","notifications_url":"https://api.github.com/repos/meejah/tahoe-lafs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meejah/tahoe-lafs/labels{/name}","releases_url":"https://api.github.com/repos/meejah/tahoe-lafs/releases{/id}","deployments_url":"https://api.github.com/repos/meejah/tahoe-lafs/deployments","created_at":"2015-09-17T04:05:14Z","updated_at":"2016-01-19T19:35:02Z","pushed_at":"2016-08-18T23:40:55Z","git_url":"git://github.com/meejah/tahoe-lafs.git","ssh_url":"git@github.com:meejah/tahoe-lafs.git","clone_url":"https://github.com/meejah/tahoe-lafs.git","svn_url":"https://github.com/meejah/tahoe-lafs","homepage":"https://tahoe-lafs.org/","size":67925,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tahoe-lafs:master","ref":"master","sha":"b637636ef9de701340e25373fe25771f1b9a0b9d","user":{"login":"tahoe-lafs","id":1156454,"avatar_url":"https://avatars.githubusercontent.com/u/1156454?v=3","gravatar_id":"","url":"https://api.github.com/users/tahoe-lafs","html_url":"https://github.com/tahoe-lafs","followers_url":"https://api.github.com/users/tahoe-lafs/followers","following_url":"https://api.github.com/users/tahoe-lafs/following{/other_user}","gists_url":"https://api.github.com/users/tahoe-lafs/gists{/gist_id}","starred_url":"https://api.github.com/users/tahoe-lafs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahoe-lafs/subscriptions","organizations_url":"https://api.github.com/users/tahoe-lafs/orgs","repos_url":"https://api.github.com/users/tahoe-lafs/repos","events_url":"https://api.github.com/users/tahoe-lafs/events{/privacy}","received_events_url":"https://api.github.com/users/tahoe-lafs/received_events","type":"Organization","site_admin":false},"repo":{"id":3007569,"name":"tahoe-lafs","full_name":"tahoe-lafs/tahoe-lafs","owner":{"login":"tahoe-lafs","id":1156454,"avatar_url":"https://avatars.githubusercontent.com/u/1156454?v=3","gravatar_id":"","url":"https://api.github.com/users/tahoe-lafs","html_url":"https://github.com/tahoe-lafs","followers_url":"https://api.github.com/users/tahoe-lafs/followers","following_url":"https://api.github.com/users/tahoe-lafs/following{/other_user}","gists_url":"https://api.github.com/users/tahoe-lafs/gists{/gist_id}","starred_url":"https://api.github.com/users/tahoe-lafs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahoe-lafs/subscriptions","organizations_url":"https://api.github.com/users/tahoe-lafs/orgs","repos_url":"https://api.github.com/users/tahoe-lafs/repos","events_url":"https://api.github.com/users/tahoe-lafs/events{/privacy}","received_events_url":"https://api.github.com/users/tahoe-lafs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tahoe-lafs/tahoe-lafs","description":"The Tahoe-LAFS decentralized secure filesystem.","fork":false,"url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs","forks_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/forks","keys_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/teams","hooks_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/hooks","issue_events_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/events{/number}","events_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/events","assignees_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/assignees{/user}","branches_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/branches{/branch}","tags_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/tags","blobs_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/statuses/{sha}","languages_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/languages","stargazers_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/stargazers","contributors_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/contributors","subscribers_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/subscribers","subscription_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/subscription","commits_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/contents/{+path}","compare_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/merges","archive_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/downloads","issues_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues{/number}","pulls_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls{/number}","milestones_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/milestones{/number}","notifications_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/labels{/name}","releases_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/releases{/id}","deployments_url":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/deployments","created_at":"2011-12-18T19:33:55Z","updated_at":"2016-08-17T12:16:57Z","pushed_at":"2016-08-19T01:04:13Z","git_url":"git://github.com/tahoe-lafs/tahoe-lafs.git","ssh_url":"git@github.com:tahoe-lafs/tahoe-lafs.git","clone_url":"https://github.com/tahoe-lafs/tahoe-lafs.git","svn_url":"https://github.com/tahoe-lafs/tahoe-lafs","homepage":"https://tahoe-lafs.org/","size":73542,"stargazers_count":509,"watchers_count":509,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":24,"forks":147,"open_issues":24,"watchers":509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/313"},"html":{"href":"https://github.com/tahoe-lafs/tahoe-lafs/pull/313"},"issue":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/313"},"comments":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/tahoe-lafs/tahoe-lafs/statuses/5e011e65d3d47801e3c8a00e24c52ef8fd2d1555"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"warner","id":27146,"avatar_url":"https://avatars.githubusercontent.com/u/27146?v=3","gravatar_id":"","url":"https://api.github.com/users/warner","html_url":"https://github.com/warner","followers_url":"https://api.github.com/users/warner/followers","following_url":"https://api.github.com/users/warner/following{/other_user}","gists_url":"https://api.github.com/users/warner/gists{/gist_id}","starred_url":"https://api.github.com/users/warner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warner/subscriptions","organizations_url":"https://api.github.com/users/warner/orgs","repos_url":"https://api.github.com/users/warner/repos","events_url":"https://api.github.com/users/warner/events{/privacy}","received_events_url":"https://api.github.com/users/warner/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":3,"additions":171,"deletions":126,"changed_files":3}}
{"actor":{"display_login":"warner"}}