{"action":"created","issue":{"url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/9","repository_url":"https://api.github.com/repos/jrean/laravel-user-verification","labels_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/9/comments","events_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/9/events","html_url":"https://github.com/jrean/laravel-user-verification/issues/9","id":143839875,"number":9,"title":"generate token, should be the user's encrypted email?","user":{"login":"damarev","id":680831,"avatar_url":"https://avatars.githubusercontent.com/u/680831?v=3","gravatar_id":"","url":"https://api.github.com/users/damarev","html_url":"https://github.com/damarev","followers_url":"https://api.github.com/users/damarev/followers","following_url":"https://api.github.com/users/damarev/following{/other_user}","gists_url":"https://api.github.com/users/damarev/gists{/gist_id}","starred_url":"https://api.github.com/users/damarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damarev/subscriptions","organizations_url":"https://api.github.com/users/damarev/orgs","repos_url":"https://api.github.com/users/damarev/repos","events_url":"https://api.github.com/users/damarev/events{/privacy}","received_events_url":"https://api.github.com/users/damarev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jrean/laravel-user-verification/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-27T19:33:07Z","updated_at":"2016-03-28T10:25:29Z","closed_at":"2016-03-28T10:25:29Z","body":"Just a suggestion, i think generated token/code should be random and fixed length:\r\n```\r\n    protected function generateToken($email)\r\n    {\r\n        return sha1(microtime() . Crypt::encrypt($email));\r\n    }\r\n```\r\n\r\nNow, Crypt::encrypt($email) returns a string of 272 characters from a 40 characters email, exceeding the 255 limit of the database migration.\r\n\r\nWould you consider a PR?\r\nThank you for this nice laravel package."},"comment":{"url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/comments/202334517","html_url":"https://github.com/jrean/laravel-user-verification/issues/9#issuecomment-202334517","issue_url":"https://api.github.com/repos/jrean/laravel-user-verification/issues/9","id":202334517,"user":{"login":"jrean","id":5646128,"avatar_url":"https://avatars.githubusercontent.com/u/5646128?v=3","gravatar_id":"","url":"https://api.github.com/users/jrean","html_url":"https://github.com/jrean","followers_url":"https://api.github.com/users/jrean/followers","following_url":"https://api.github.com/users/jrean/following{/other_user}","gists_url":"https://api.github.com/users/jrean/gists{/gist_id}","starred_url":"https://api.github.com/users/jrean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrean/subscriptions","organizations_url":"https://api.github.com/users/jrean/orgs","repos_url":"https://api.github.com/users/jrean/repos","events_url":"https://api.github.com/users/jrean/events{/privacy}","received_events_url":"https://api.github.com/users/jrean/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T10:25:29Z","updated_at":"2016-03-28T10:25:29Z","body":"@damarev thank you for the feedback.\r\nhttps://github.com/jrean/laravel-user-verification/releases/tag/v2.2.0"}}