{"action":"created","comment":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments/49917319","id":49917319,"diff_hunk":"@@ -763,53 +763,6 @@ describe('dest stream', function() {\n     stream.end();\n   });\n \n-  it('should write file atime and mtime using the vinyl stat', function(done) {","path":"test/dest.js","position":55,"original_position":55,"commit_id":"d8c3c848b9304d7f82fe097a8c40af8c84177faf","original_commit_id":"d8c3c848b9304d7f82fe097a8c40af8c84177faf","user":{"login":"erikkemperman","id":3100637,"avatar_url":"https://avatars.githubusercontent.com/u/3100637?v=3","gravatar_id":"","url":"https://api.github.com/users/erikkemperman","html_url":"https://github.com/erikkemperman","followers_url":"https://api.github.com/users/erikkemperman/followers","following_url":"https://api.github.com/users/erikkemperman/following{/other_user}","gists_url":"https://api.github.com/users/erikkemperman/gists{/gist_id}","starred_url":"https://api.github.com/users/erikkemperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikkemperman/subscriptions","organizations_url":"https://api.github.com/users/erikkemperman/orgs","repos_url":"https://api.github.com/users/erikkemperman/repos","events_url":"https://api.github.com/users/erikkemperman/events{/privacy}","received_events_url":"https://api.github.com/users/erikkemperman/received_events","type":"User","site_admin":false},"body":"> Ah. Yeah, those things seem very wrong :P\r\n\r\nI thought so. And yet all of this passes the tests...\r\n\r\nEffectively, I guess, the current behaviour of the getter and setter of `contents` is correct from the pov of a plugin, but we must kind of invert things at the terminals `src` and `dest`?\r\n\r\nWhen `src` sets `file.contents` this represents an access of the physical source file it reflects. So the setter of `contents`, as called by `src`, should update `atime`. The `mtime` should be the same as the source file.\r\n\r\nWhen `dest` gets `file.contents` this represents a modification of the file on disk, and so it should update `mtime`. The `atime` of the physical destination file should be the same is the vinyl.\r\n\r\nDoes that make any sense?","created_at":"2016-01-15T23:22:32Z","updated_at":"2016-01-15T23:22:32Z","html_url":"https://github.com/gulpjs/vinyl-fs/pull/143#discussion_r49917319","pull_request_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments/49917319"},"html":{"href":"https://github.com/gulpjs/vinyl-fs/pull/143#discussion_r49917319"},"pull_request":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143","id":55824739,"html_url":"https://github.com/gulpjs/vinyl-fs/pull/143","diff_url":"https://github.com/gulpjs/vinyl-fs/pull/143.diff","patch_url":"https://github.com/gulpjs/vinyl-fs/pull/143.patch","issue_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/143","number":143,"state":"open","locked":false,"title":"Adapt tests to vinyl stats changes","user":{"login":"erikkemperman","id":3100637,"avatar_url":"https://avatars.githubusercontent.com/u/3100637?v=3","gravatar_id":"","url":"https://api.github.com/users/erikkemperman","html_url":"https://github.com/erikkemperman","followers_url":"https://api.github.com/users/erikkemperman/followers","following_url":"https://api.github.com/users/erikkemperman/following{/other_user}","gists_url":"https://api.github.com/users/erikkemperman/gists{/gist_id}","starred_url":"https://api.github.com/users/erikkemperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikkemperman/subscriptions","organizations_url":"https://api.github.com/users/erikkemperman/orgs","repos_url":"https://api.github.com/users/erikkemperman/repos","events_url":"https://api.github.com/users/erikkemperman/events{/privacy}","received_events_url":"https://api.github.com/users/erikkemperman/received_events","type":"User","site_admin":false},"body":"I had to adapt the tests to changes I submitted to `vinyl` [here](https://github.com/gulpjs/vinyl/pull/75).","created_at":"2016-01-12T22:08:29Z","updated_at":"2016-01-15T23:22:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da3e322654df37bba3170b18e31545909df0b2d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143/commits","review_comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143/comments","review_comment_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/143/comments","statuses_url":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/d8c3c848b9304d7f82fe097a8c40af8c84177faf","head":{"label":"erikkemperman:feature-stats","ref":"feature-stats","sha":"d8c3c848b9304d7f82fe097a8c40af8c84177faf","user":{"login":"erikkemperman","id":3100637,"avatar_url":"https://avatars.githubusercontent.com/u/3100637?v=3","gravatar_id":"","url":"https://api.github.com/users/erikkemperman","html_url":"https://github.com/erikkemperman","followers_url":"https://api.github.com/users/erikkemperman/followers","following_url":"https://api.github.com/users/erikkemperman/following{/other_user}","gists_url":"https://api.github.com/users/erikkemperman/gists{/gist_id}","starred_url":"https://api.github.com/users/erikkemperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikkemperman/subscriptions","organizations_url":"https://api.github.com/users/erikkemperman/orgs","repos_url":"https://api.github.com/users/erikkemperman/repos","events_url":"https://api.github.com/users/erikkemperman/events{/privacy}","received_events_url":"https://api.github.com/users/erikkemperman/received_events","type":"User","site_admin":false},"repo":{"id":45627648,"name":"vinyl-fs","full_name":"erikkemperman/vinyl-fs","owner":{"login":"erikkemperman","id":3100637,"avatar_url":"https://avatars.githubusercontent.com/u/3100637?v=3","gravatar_id":"","url":"https://api.github.com/users/erikkemperman","html_url":"https://github.com/erikkemperman","followers_url":"https://api.github.com/users/erikkemperman/followers","following_url":"https://api.github.com/users/erikkemperman/following{/other_user}","gists_url":"https://api.github.com/users/erikkemperman/gists{/gist_id}","starred_url":"https://api.github.com/users/erikkemperman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikkemperman/subscriptions","organizations_url":"https://api.github.com/users/erikkemperman/orgs","repos_url":"https://api.github.com/users/erikkemperman/repos","events_url":"https://api.github.com/users/erikkemperman/events{/privacy}","received_events_url":"https://api.github.com/users/erikkemperman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikkemperman/vinyl-fs","description":"Vinyl adapter for the file system","fork":true,"url":"https://api.github.com/repos/erikkemperman/vinyl-fs","forks_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/forks","keys_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/teams","hooks_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/hooks","issue_events_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/issues/events{/number}","events_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/events","assignees_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/assignees{/user}","branches_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/branches{/branch}","tags_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/tags","blobs_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/languages","stargazers_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/stargazers","contributors_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/contributors","subscribers_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/subscribers","subscription_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/subscription","commits_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/contents/{+path}","compare_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/merges","archive_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/downloads","issues_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/issues{/number}","pulls_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/labels{/name}","releases_url":"https://api.github.com/repos/erikkemperman/vinyl-fs/releases{/id}","created_at":"2015-11-05T17:28:08Z","updated_at":"2016-01-12T14:52:18Z","pushed_at":"2016-01-15T21:48:17Z","git_url":"git://github.com/erikkemperman/vinyl-fs.git","ssh_url":"git@github.com:erikkemperman/vinyl-fs.git","clone_url":"https://github.com/erikkemperman/vinyl-fs.git","svn_url":"https://github.com/erikkemperman/vinyl-fs","homepage":null,"size":255,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gulpjs:master","ref":"master","sha":"941b040905616eb0408a44213d5efe010388cb9d","user":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15355019,"name":"vinyl-fs","full_name":"gulpjs/vinyl-fs","owner":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gulpjs/vinyl-fs","description":"Vinyl adapter for the file system","fork":false,"url":"https://api.github.com/repos/gulpjs/vinyl-fs","forks_url":"https://api.github.com/repos/gulpjs/vinyl-fs/forks","keys_url":"https://api.github.com/repos/gulpjs/vinyl-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gulpjs/vinyl-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gulpjs/vinyl-fs/teams","hooks_url":"https://api.github.com/repos/gulpjs/vinyl-fs/hooks","issue_events_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/events{/number}","events_url":"https://api.github.com/repos/gulpjs/vinyl-fs/events","assignees_url":"https://api.github.com/repos/gulpjs/vinyl-fs/assignees{/user}","branches_url":"https://api.github.com/repos/gulpjs/vinyl-fs/branches{/branch}","tags_url":"https://api.github.com/repos/gulpjs/vinyl-fs/tags","blobs_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/gulpjs/vinyl-fs/languages","stargazers_url":"https://api.github.com/repos/gulpjs/vinyl-fs/stargazers","contributors_url":"https://api.github.com/repos/gulpjs/vinyl-fs/contributors","subscribers_url":"https://api.github.com/repos/gulpjs/vinyl-fs/subscribers","subscription_url":"https://api.github.com/repos/gulpjs/vinyl-fs/subscription","commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gulpjs/vinyl-fs/contents/{+path}","compare_url":"https://api.github.com/repos/gulpjs/vinyl-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gulpjs/vinyl-fs/merges","archive_url":"https://api.github.com/repos/gulpjs/vinyl-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gulpjs/vinyl-fs/downloads","issues_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues{/number}","pulls_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/gulpjs/vinyl-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/gulpjs/vinyl-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gulpjs/vinyl-fs/labels{/name}","releases_url":"https://api.github.com/repos/gulpjs/vinyl-fs/releases{/id}","created_at":"2013-12-21T06:40:44Z","updated_at":"2016-01-15T16:59:19Z","pushed_at":"2016-01-15T21:48:17Z","git_url":"git://github.com/gulpjs/vinyl-fs.git","ssh_url":"git@github.com:gulpjs/vinyl-fs.git","clone_url":"https://github.com/gulpjs/vinyl-fs.git","svn_url":"https://github.com/gulpjs/vinyl-fs","homepage":null,"size":316,"stargazers_count":416,"watchers_count":416,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":14,"forks":68,"open_issues":14,"watchers":416,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143"},"html":{"href":"https://github.com/gulpjs/vinyl-fs/pull/143"},"issue":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/143"},"comments":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/d8c3c848b9304d7f82fe097a8c40af8c84177faf"}}}}