{"action":"opened","number":4837,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/4837","id":89521168,"html_url":"https://github.com/brave/browser-laptop/pull/4837","diff_url":"https://github.com/brave/browser-laptop/pull/4837.diff","patch_url":"https://github.com/brave/browser-laptop/pull/4837.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/4837","number":4837,"state":"open","locked":false,"title":"Fixing magic number bug in downloads bar","user":{"login":"maaz93","id":6594255,"avatar_url":"https://avatars.githubusercontent.com/u/6594255?v=3","gravatar_id":"","url":"https://api.github.com/users/maaz93","html_url":"https://github.com/maaz93","followers_url":"https://api.github.com/users/maaz93/followers","following_url":"https://api.github.com/users/maaz93/following{/other_user}","gists_url":"https://api.github.com/users/maaz93/gists{/gist_id}","starred_url":"https://api.github.com/users/maaz93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaz93/subscriptions","organizations_url":"https://api.github.com/users/maaz93/orgs","repos_url":"https://api.github.com/users/maaz93/repos","events_url":"https://api.github.com/users/maaz93/events{/privacy}","received_events_url":"https://api.github.com/users/maaz93/received_events","type":"User","site_admin":false},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n\r\nTest Plan:\r\n\r\nFixes #3604 \r\n\r\nAdded a new variable for downloads bar height in variables.less and consumed this across the codebase where 50px was hardcoded for this.\r\n\r\nAuditors: @bsclifton \r\n\r\n","created_at":"2016-10-16T09:44:07Z","updated_at":"2016-10-16T09:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/4837/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/4837/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/4837/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/1a1b65834af9298c7e6e4ed5a35c6bfb2a3d4548","head":{"label":"maaz93:magic-number","ref":"magic-number","sha":"1a1b65834af9298c7e6e4ed5a35c6bfb2a3d4548","user":{"login":"maaz93","id":6594255,"avatar_url":"https://avatars.githubusercontent.com/u/6594255?v=3","gravatar_id":"","url":"https://api.github.com/users/maaz93","html_url":"https://github.com/maaz93","followers_url":"https://api.github.com/users/maaz93/followers","following_url":"https://api.github.com/users/maaz93/following{/other_user}","gists_url":"https://api.github.com/users/maaz93/gists{/gist_id}","starred_url":"https://api.github.com/users/maaz93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaz93/subscriptions","organizations_url":"https://api.github.com/users/maaz93/orgs","repos_url":"https://api.github.com/users/maaz93/repos","events_url":"https://api.github.com/users/maaz93/events{/privacy}","received_events_url":"https://api.github.com/users/maaz93/received_events","type":"User","site_admin":false},"repo":{"id":71039735,"name":"browser-laptop","full_name":"maaz93/browser-laptop","owner":{"login":"maaz93","id":6594255,"avatar_url":"https://avatars.githubusercontent.com/u/6594255?v=3","gravatar_id":"","url":"https://api.github.com/users/maaz93","html_url":"https://github.com/maaz93","followers_url":"https://api.github.com/users/maaz93/followers","following_url":"https://api.github.com/users/maaz93/following{/other_user}","gists_url":"https://api.github.com/users/maaz93/gists{/gist_id}","starred_url":"https://api.github.com/users/maaz93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaz93/subscriptions","organizations_url":"https://api.github.com/users/maaz93/orgs","repos_url":"https://api.github.com/users/maaz93/repos","events_url":"https://api.github.com/users/maaz93/events{/privacy}","received_events_url":"https://api.github.com/users/maaz93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maaz93/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/maaz93/browser-laptop","forks_url":"https://api.github.com/repos/maaz93/browser-laptop/forks","keys_url":"https://api.github.com/repos/maaz93/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maaz93/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maaz93/browser-laptop/teams","hooks_url":"https://api.github.com/repos/maaz93/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/maaz93/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/maaz93/browser-laptop/events","assignees_url":"https://api.github.com/repos/maaz93/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/maaz93/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/maaz93/browser-laptop/tags","blobs_url":"https://api.github.com/repos/maaz93/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maaz93/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maaz93/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/maaz93/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maaz93/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/maaz93/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/maaz93/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/maaz93/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/maaz93/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/maaz93/browser-laptop/subscription","commits_url":"https://api.github.com/repos/maaz93/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/maaz93/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/maaz93/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/maaz93/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/maaz93/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/maaz93/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maaz93/browser-laptop/merges","archive_url":"https://api.github.com/repos/maaz93/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maaz93/browser-laptop/downloads","issues_url":"https://api.github.com/repos/maaz93/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/maaz93/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/maaz93/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/maaz93/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maaz93/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/maaz93/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/maaz93/browser-laptop/deployments","created_at":"2016-10-16T08:59:41Z","updated_at":"2016-10-16T08:59:43Z","pushed_at":"2016-10-16T09:37:11Z","git_url":"git://github.com/maaz93/browser-laptop.git","ssh_url":"git@github.com:maaz93/browser-laptop.git","clone_url":"https://github.com/maaz93/browser-laptop.git","svn_url":"https://github.com/maaz93/browser-laptop","homepage":"https://www.brave.com","size":41484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"a24dcad2151fb9b33c21ee6bb636968aac3bbfa9","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-10-15T22:37:48Z","pushed_at":"2016-10-16T09:44:07Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":41484,"stargazers_count":3578,"watchers_count":3578,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":1374,"forks":408,"open_issues":1374,"watchers":3578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4837"},"html":{"href":"https://github.com/brave/browser-laptop/pull/4837"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/4837"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/4837/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4837/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4837/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/1a1b65834af9298c7e6e4ed5a35c6bfb2a3d4548"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":7,"changed_files":4}}
{"actor":{"display_login":"maaz93"}}