{"action":"closed","number":382,"pull_request":{"url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/382","id":70111661,"html_url":"https://github.com/Microsoft/Windows-universal-samples/pull/382","diff_url":"https://github.com/Microsoft/Windows-universal-samples/pull/382.diff","patch_url":"https://github.com/Microsoft/Windows-universal-samples/pull/382.patch","issue_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/382","number":382,"state":"closed","locked":false,"title":"XamlNavigation: add proper <SplitView.Content> tag to splitview","user":{"login":"HerrickSpencerMSFT","id":13108756,"avatar_url":"https://avatars.githubusercontent.com/u/13108756?v=3","gravatar_id":"","url":"https://api.github.com/users/HerrickSpencerMSFT","html_url":"https://github.com/HerrickSpencerMSFT","followers_url":"https://api.github.com/users/HerrickSpencerMSFT/followers","following_url":"https://api.github.com/users/HerrickSpencerMSFT/following{/other_user}","gists_url":"https://api.github.com/users/HerrickSpencerMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/HerrickSpencerMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerrickSpencerMSFT/subscriptions","organizations_url":"https://api.github.com/users/HerrickSpencerMSFT/orgs","repos_url":"https://api.github.com/users/HerrickSpencerMSFT/repos","events_url":"https://api.github.com/users/HerrickSpencerMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/HerrickSpencerMSFT/received_events","type":"User","site_admin":false},"body":"Simply adding a <SplitView.Content> tag around the <Frame> content will make the complier warning go away.. and is likely the proper way to enclose this content.\r\n\r\nSeverity\tCode\tDescription\tProject\tFile\tLine\tSuppression State\r\n_Error\t\tCannot add content to an object of type \"SplitView\".\tNavigationMenu\tC:\\Users\\Herrick\\Documents\\Visual Studio 2015\\Projects\\Windows-universal-samples\\Samples\\XamlNavigation\\shared\\AppShell.xaml\t128_\t\r\n\r\nThis error DOES go away after a build... and doesn't prevent running. However, since this is sample code for others to use, should be properly updated.","created_at":"2016-05-15T04:21:15Z","updated_at":"2016-06-04T03:24:29Z","closed_at":"2016-06-04T03:24:29Z","merged_at":null,"merge_commit_sha":"5cb637b64f30a929f7ef5794d32e26bf3eb4dfb6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/382/commits","review_comments_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/382/comments","review_comment_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/382/comments","statuses_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/statuses/14cccc918c002b8e1be4f33c7ba966c7ad9aad9d","head":{"label":"HerrickSpencerMSFT:master","ref":"master","sha":"14cccc918c002b8e1be4f33c7ba966c7ad9aad9d","user":{"login":"HerrickSpencerMSFT","id":13108756,"avatar_url":"https://avatars.githubusercontent.com/u/13108756?v=3","gravatar_id":"","url":"https://api.github.com/users/HerrickSpencerMSFT","html_url":"https://github.com/HerrickSpencerMSFT","followers_url":"https://api.github.com/users/HerrickSpencerMSFT/followers","following_url":"https://api.github.com/users/HerrickSpencerMSFT/following{/other_user}","gists_url":"https://api.github.com/users/HerrickSpencerMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/HerrickSpencerMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerrickSpencerMSFT/subscriptions","organizations_url":"https://api.github.com/users/HerrickSpencerMSFT/orgs","repos_url":"https://api.github.com/users/HerrickSpencerMSFT/repos","events_url":"https://api.github.com/users/HerrickSpencerMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/HerrickSpencerMSFT/received_events","type":"User","site_admin":false},"repo":{"id":58843202,"name":"Windows-universal-samples","full_name":"HerrickSpencerMSFT/Windows-universal-samples","owner":{"login":"HerrickSpencerMSFT","id":13108756,"avatar_url":"https://avatars.githubusercontent.com/u/13108756?v=3","gravatar_id":"","url":"https://api.github.com/users/HerrickSpencerMSFT","html_url":"https://github.com/HerrickSpencerMSFT","followers_url":"https://api.github.com/users/HerrickSpencerMSFT/followers","following_url":"https://api.github.com/users/HerrickSpencerMSFT/following{/other_user}","gists_url":"https://api.github.com/users/HerrickSpencerMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/HerrickSpencerMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerrickSpencerMSFT/subscriptions","organizations_url":"https://api.github.com/users/HerrickSpencerMSFT/orgs","repos_url":"https://api.github.com/users/HerrickSpencerMSFT/repos","events_url":"https://api.github.com/users/HerrickSpencerMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/HerrickSpencerMSFT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HerrickSpencerMSFT/Windows-universal-samples","description":"API samples for the Universal Windows Platform.","fork":true,"url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples","forks_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/forks","keys_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/teams","hooks_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/hooks","issue_events_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/issues/events{/number}","events_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/events","assignees_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/assignees{/user}","branches_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/branches{/branch}","tags_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/tags","blobs_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/languages","stargazers_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/stargazers","contributors_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/contributors","subscribers_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/subscribers","subscription_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/subscription","commits_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/contents/{+path}","compare_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/merges","archive_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/downloads","issues_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/issues{/number}","pulls_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/labels{/name}","releases_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/releases{/id}","deployments_url":"https://api.github.com/repos/HerrickSpencerMSFT/Windows-universal-samples/deployments","created_at":"2016-05-15T03:59:13Z","updated_at":"2016-05-15T03:59:17Z","pushed_at":"2016-05-15T04:07:11Z","git_url":"git://github.com/HerrickSpencerMSFT/Windows-universal-samples.git","ssh_url":"git@github.com:HerrickSpencerMSFT/Windows-universal-samples.git","clone_url":"https://github.com/HerrickSpencerMSFT/Windows-universal-samples.git","svn_url":"https://github.com/HerrickSpencerMSFT/Windows-universal-samples","homepage":"","size":21074,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:dev","ref":"dev","sha":"ec1744d1d0337babd41b0c8038d956384bc6acdb","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":31791381,"name":"Windows-universal-samples","full_name":"Microsoft/Windows-universal-samples","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/Windows-universal-samples","description":"API samples for the Universal Windows Platform.","fork":false,"url":"https://api.github.com/repos/Microsoft/Windows-universal-samples","forks_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/forks","keys_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/events","assignees_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/merges","archive_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/deployments","created_at":"2015-03-06T22:13:13Z","updated_at":"2016-06-04T03:07:52Z","pushed_at":"2016-06-02T00:43:17Z","git_url":"git://github.com/Microsoft/Windows-universal-samples.git","ssh_url":"git@github.com:Microsoft/Windows-universal-samples.git","clone_url":"https://github.com/Microsoft/Windows-universal-samples.git","svn_url":"https://github.com/Microsoft/Windows-universal-samples","homepage":"","size":192649,"stargazers_count":3043,"watchers_count":3043,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2870,"mirror_url":null,"open_issues_count":74,"forks":2870,"open_issues":74,"watchers":3043,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/382"},"html":{"href":"https://github.com/Microsoft/Windows-universal-samples/pull/382"},"issue":{"href":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/382"},"comments":{"href":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/382/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/382/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/382/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/Windows-universal-samples/statuses/14cccc918c002b8e1be4f33c7ba966c7ad9aad9d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":18,"deletions":17,"changed_files":1}}
{"actor":{"display_login":"YuliKl"}}