{"action":"created","issue":{"url":"https://api.github.com/repos/Schibsted-Tech-Polska/good-guy-http/issues/2","repository_url":"https://api.github.com/repos/Schibsted-Tech-Polska/good-guy-http","labels_url":"https://api.github.com/repos/Schibsted-Tech-Polska/good-guy-http/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/Schibsted-Tech-Polska/good-guy-http/issues/2/comments","events_url":"https://api.github.com/repos/Schibsted-Tech-Polska/good-guy-http/issues/2/events","html_url":"https://github.com/Schibsted-Tech-Polska/good-guy-http/issues/2","id":130711238,"number":2,"title":"Query params are ignored when using cache","user":{"login":"krzychukula","id":240264,"avatar_url":"https://avatars.githubusercontent.com/u/240264?v=3","gravatar_id":"","url":"https://api.github.com/users/krzychukula","html_url":"https://github.com/krzychukula","followers_url":"https://api.github.com/users/krzychukula/followers","following_url":"https://api.github.com/users/krzychukula/following{/other_user}","gists_url":"https://api.github.com/users/krzychukula/gists{/gist_id}","starred_url":"https://api.github.com/users/krzychukula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzychukula/subscriptions","organizations_url":"https://api.github.com/users/krzychukula/orgs","repos_url":"https://api.github.com/users/krzychukula/repos","events_url":"https://api.github.com/users/krzychukula/events{/privacy}","received_events_url":"https://api.github.com/users/krzychukula/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-02T15:12:45Z","updated_at":"2016-02-15T15:06:18Z","closed_at":"2016-02-15T14:05:54Z","body":"When using something like:\r\n```\r\nvar options = {\r\n            url: \"/something\",\r\n            qs: {\r\n                queryParam1: 'some',\r\n                queryParam2: 'values'\r\n            }\r\n        };\r\nrequest(options)\r\n```\r\nCurrent implementation seem to ignore query params, at least to my understanding: https://github.com/Schibsted-Tech-Polska/good-guy-http/blob/master/lib/caching/request-key.js\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Schibsted-Tech-Polska/good-guy-http/issues/comments/184246495","html_url":"https://github.com/Schibsted-Tech-Polska/good-guy-http/issues/2#issuecomment-184246495","issue_url":"https://api.github.com/repos/Schibsted-Tech-Polska/good-guy-http/issues/2","id":184246495,"user":{"login":"jakubwasilewski","id":7520696,"avatar_url":"https://avatars.githubusercontent.com/u/7520696?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubwasilewski","html_url":"https://github.com/jakubwasilewski","followers_url":"https://api.github.com/users/jakubwasilewski/followers","following_url":"https://api.github.com/users/jakubwasilewski/following{/other_user}","gists_url":"https://api.github.com/users/jakubwasilewski/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubwasilewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubwasilewski/subscriptions","organizations_url":"https://api.github.com/users/jakubwasilewski/orgs","repos_url":"https://api.github.com/users/jakubwasilewski/repos","events_url":"https://api.github.com/users/jakubwasilewski/events{/privacy}","received_events_url":"https://api.github.com/users/jakubwasilewski/received_events","type":"User","site_admin":false},"created_at":"2016-02-15T15:06:18Z","updated_at":"2016-02-15T15:06:18Z","body":"Fix included in 1.4.2 and 1.5.0."}}