{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/57124667","id":57124667,"diff_hunk":"@@ -456,6 +456,11 @@ def test_issue_8730():\n     assert limit(subfactorial(x), x, oo) == oo\n \n \n+def test_issue_10801():\n+    # make sure limits work with binomial\n+    assert limit(16**k/(k*binomial(2*k,k)**2), k, oo) == pi","path":"sympy/series/tests/test_limits.py","position":6,"original_position":6,"commit_id":"f3f0c9cca71cff715398aa3805226d4dc2957389","original_commit_id":"f3f0c9cca71cff715398aa3805226d4dc2957389","user":{"login":"leosartaj","id":6217976,"avatar_url":"https://avatars.githubusercontent.com/u/6217976?v=3","gravatar_id":"","url":"https://api.github.com/users/leosartaj","html_url":"https://github.com/leosartaj","followers_url":"https://api.github.com/users/leosartaj/followers","following_url":"https://api.github.com/users/leosartaj/following{/other_user}","gists_url":"https://api.github.com/users/leosartaj/gists{/gist_id}","starred_url":"https://api.github.com/users/leosartaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leosartaj/subscriptions","organizations_url":"https://api.github.com/users/leosartaj/orgs","repos_url":"https://api.github.com/users/leosartaj/repos","events_url":"https://api.github.com/users/leosartaj/events{/privacy}","received_events_url":"https://api.github.com/users/leosartaj/received_events","type":"User","site_admin":false},"body":"Actually [here](https://github.com/sympy/sympy/tree/master/sympy/series/gruntz.py#L411) the expression is converted into tractable form. In the case ``_eval_rewrite_as_tractable = _eval_rewrite_as_gamma``, ``binomial`` is just converted into ``gamma`` form. The current implementation wants  ``gamma`` to also be converted into tractable form.","created_at":"2016-03-23T08:42:29Z","updated_at":"2016-03-23T08:42:29Z","html_url":"https://github.com/sympy/sympy/pull/10883#discussion_r57124667","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/10883","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/57124667"},"html":{"href":"https://github.com/sympy/sympy/pull/10883#discussion_r57124667"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10883"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/10883","id":63719762,"html_url":"https://github.com/sympy/sympy/pull/10883","diff_url":"https://github.com/sympy/sympy/pull/10883.diff","patch_url":"https://github.com/sympy/sympy/pull/10883.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/10883","number":10883,"state":"open","locked":false,"title":"Issue#10801 : Made limits work with a binomial expression","user":{"login":"rehassachdeva","id":9818774,"avatar_url":"https://avatars.githubusercontent.com/u/9818774?v=3","gravatar_id":"","url":"https://api.github.com/users/rehassachdeva","html_url":"https://github.com/rehassachdeva","followers_url":"https://api.github.com/users/rehassachdeva/followers","following_url":"https://api.github.com/users/rehassachdeva/following{/other_user}","gists_url":"https://api.github.com/users/rehassachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/rehassachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehassachdeva/subscriptions","organizations_url":"https://api.github.com/users/rehassachdeva/orgs","repos_url":"https://api.github.com/users/rehassachdeva/repos","events_url":"https://api.github.com/users/rehassachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/rehassachdeva/received_events","type":"User","site_admin":false},"body":"This patch fixes #10801 .\r\n\r\nThe issue was that this doesn't work:\r\n`limit(16**k/(k*binomial(2*k,k)**2), k, oo)`\r\nIn general limit doesn't work with such expressions. \r\nSo to fix it we can check if it contains binomial and then convert it to factorial form.\r\nNow it works as shown:\r\n```\r\nIn [1]: limit(16**k/(k*binomial(2*k,k)**2), k, oo)\r\nOut[1]: π\r\n```\r\n\r\nPlease review. ","created_at":"2016-03-22T13:32:56Z","updated_at":"2016-03-23T08:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9559d50bfee8793958b5a27d1a8d55e2038fcd35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/10883/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/10883/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/10883/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/f3f0c9cca71cff715398aa3805226d4dc2957389","head":{"label":"rehassachdeva:issue#10801","ref":"issue#10801","sha":"f3f0c9cca71cff715398aa3805226d4dc2957389","user":{"login":"rehassachdeva","id":9818774,"avatar_url":"https://avatars.githubusercontent.com/u/9818774?v=3","gravatar_id":"","url":"https://api.github.com/users/rehassachdeva","html_url":"https://github.com/rehassachdeva","followers_url":"https://api.github.com/users/rehassachdeva/followers","following_url":"https://api.github.com/users/rehassachdeva/following{/other_user}","gists_url":"https://api.github.com/users/rehassachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/rehassachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehassachdeva/subscriptions","organizations_url":"https://api.github.com/users/rehassachdeva/orgs","repos_url":"https://api.github.com/users/rehassachdeva/repos","events_url":"https://api.github.com/users/rehassachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/rehassachdeva/received_events","type":"User","site_admin":false},"repo":{"id":54222796,"name":"sympy","full_name":"rehassachdeva/sympy","owner":{"login":"rehassachdeva","id":9818774,"avatar_url":"https://avatars.githubusercontent.com/u/9818774?v=3","gravatar_id":"","url":"https://api.github.com/users/rehassachdeva","html_url":"https://github.com/rehassachdeva","followers_url":"https://api.github.com/users/rehassachdeva/followers","following_url":"https://api.github.com/users/rehassachdeva/following{/other_user}","gists_url":"https://api.github.com/users/rehassachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/rehassachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehassachdeva/subscriptions","organizations_url":"https://api.github.com/users/rehassachdeva/orgs","repos_url":"https://api.github.com/users/rehassachdeva/repos","events_url":"https://api.github.com/users/rehassachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/rehassachdeva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rehassachdeva/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/rehassachdeva/sympy","forks_url":"https://api.github.com/repos/rehassachdeva/sympy/forks","keys_url":"https://api.github.com/repos/rehassachdeva/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rehassachdeva/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rehassachdeva/sympy/teams","hooks_url":"https://api.github.com/repos/rehassachdeva/sympy/hooks","issue_events_url":"https://api.github.com/repos/rehassachdeva/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/rehassachdeva/sympy/events","assignees_url":"https://api.github.com/repos/rehassachdeva/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/rehassachdeva/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/rehassachdeva/sympy/tags","blobs_url":"https://api.github.com/repos/rehassachdeva/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rehassachdeva/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rehassachdeva/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rehassachdeva/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rehassachdeva/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/rehassachdeva/sympy/languages","stargazers_url":"https://api.github.com/repos/rehassachdeva/sympy/stargazers","contributors_url":"https://api.github.com/repos/rehassachdeva/sympy/contributors","subscribers_url":"https://api.github.com/repos/rehassachdeva/sympy/subscribers","subscription_url":"https://api.github.com/repos/rehassachdeva/sympy/subscription","commits_url":"https://api.github.com/repos/rehassachdeva/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rehassachdeva/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rehassachdeva/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rehassachdeva/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rehassachdeva/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/rehassachdeva/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rehassachdeva/sympy/merges","archive_url":"https://api.github.com/repos/rehassachdeva/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rehassachdeva/sympy/downloads","issues_url":"https://api.github.com/repos/rehassachdeva/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/rehassachdeva/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/rehassachdeva/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/rehassachdeva/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rehassachdeva/sympy/labels{/name}","releases_url":"https://api.github.com/repos/rehassachdeva/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/rehassachdeva/sympy/deployments","created_at":"2016-03-18T18:21:45Z","updated_at":"2016-03-18T18:21:51Z","pushed_at":"2016-03-22T13:31:23Z","git_url":"git://github.com/rehassachdeva/sympy.git","ssh_url":"git@github.com:rehassachdeva/sympy.git","clone_url":"https://github.com/rehassachdeva/sympy.git","svn_url":"https://github.com/rehassachdeva/sympy","homepage":"http://sympy.org/","size":76389,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"c025799e5a3a5bab5cf051a5f003e96133a1fcdd","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2016-03-23T01:55:30Z","pushed_at":"2016-03-23T07:42:33Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":106620,"stargazers_count":2737,"watchers_count":2737,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1413,"mirror_url":null,"open_issues_count":2259,"forks":1413,"open_issues":2259,"watchers":2737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10883"},"html":{"href":"https://github.com/sympy/sympy/pull/10883"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/10883"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/10883/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10883/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10883/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/f3f0c9cca71cff715398aa3805226d4dc2957389"}}}}