{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/77919582","id":77919582,"diff_hunk":"@@ -3019,14 +3019,17 @@ static void NotifyHeaderTip() {\n bool ActivateBestChain(CValidationState &state, const CChainParams& chainparams, const CBlock *pblock) {\n     CBlockIndex *pindexMostWork = NULL;\n     CBlockIndex *pindexNewTip = NULL;\n+    std::vector<std::tuple<CTransaction,CBlockIndex*,int> > txChanged;","path":"src/main.cpp","position":13,"original_position":13,"commit_id":"8625f705003f60897679d5313e51a8bf3ee34d9c","original_commit_id":"8625f705003f60897679d5313e51a8bf3ee34d9c","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"body":"In c++11 the ugly '> >' (with a space in between) is no longer needed. Might as well fix it when you're changing it.","created_at":"2016-09-07T22:56:14Z","updated_at":"2016-09-07T22:56:14Z","html_url":"https://github.com/bitcoin/bitcoin/pull/8681#discussion_r77919582","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/77919582"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8681#discussion_r77919582"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681","id":84387910,"html_url":"https://github.com/bitcoin/bitcoin/pull/8681","diff_url":"https://github.com/bitcoin/bitcoin/pull/8681.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8681.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8681","number":8681,"state":"open","locked":false,"title":"Performance Regression Fix: Pre-Allocate txChanged vector","user":{"login":"JeremyRubin","id":886523,"avatar_url":"https://avatars.githubusercontent.com/u/886523?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyRubin","html_url":"https://github.com/JeremyRubin","followers_url":"https://api.github.com/users/JeremyRubin/followers","following_url":"https://api.github.com/users/JeremyRubin/following{/other_user}","gists_url":"https://api.github.com/users/JeremyRubin/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyRubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyRubin/subscriptions","organizations_url":"https://api.github.com/users/JeremyRubin/orgs","repos_url":"https://api.github.com/users/JeremyRubin/repos","events_url":"https://api.github.com/users/JeremyRubin/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyRubin/received_events","type":"User","site_admin":false},"body":"There's a non-trivial performance regression in the Connect postprocess time. Part of the problem is that the vector is not preallocated & the elements are copy-constructed. This commit should fix those two concerns, and address the performance regression significantly.\r\n\r\n\r\ns/o to @morcos for noticing that this was a slowdown.","created_at":"2016-09-07T22:54:35Z","updated_at":"2016-09-07T22:56:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e6416e5648506d1b1a739bc05af5565baead38d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8681/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/8625f705003f60897679d5313e51a8bf3ee34d9c","head":{"label":"JeremyRubin:fix-perf-regressed-txChanged","ref":"fix-perf-regressed-txChanged","sha":"8625f705003f60897679d5313e51a8bf3ee34d9c","user":{"login":"JeremyRubin","id":886523,"avatar_url":"https://avatars.githubusercontent.com/u/886523?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyRubin","html_url":"https://github.com/JeremyRubin","followers_url":"https://api.github.com/users/JeremyRubin/followers","following_url":"https://api.github.com/users/JeremyRubin/following{/other_user}","gists_url":"https://api.github.com/users/JeremyRubin/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyRubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyRubin/subscriptions","organizations_url":"https://api.github.com/users/JeremyRubin/orgs","repos_url":"https://api.github.com/users/JeremyRubin/repos","events_url":"https://api.github.com/users/JeremyRubin/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyRubin/received_events","type":"User","site_admin":false},"repo":{"id":53111803,"name":"bitcoin","full_name":"JeremyRubin/bitcoin","owner":{"login":"JeremyRubin","id":886523,"avatar_url":"https://avatars.githubusercontent.com/u/886523?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyRubin","html_url":"https://github.com/JeremyRubin","followers_url":"https://api.github.com/users/JeremyRubin/followers","following_url":"https://api.github.com/users/JeremyRubin/following{/other_user}","gists_url":"https://api.github.com/users/JeremyRubin/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyRubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyRubin/subscriptions","organizations_url":"https://api.github.com/users/JeremyRubin/orgs","repos_url":"https://api.github.com/users/JeremyRubin/repos","events_url":"https://api.github.com/users/JeremyRubin/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyRubin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JeremyRubin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/JeremyRubin/bitcoin","forks_url":"https://api.github.com/repos/JeremyRubin/bitcoin/forks","keys_url":"https://api.github.com/repos/JeremyRubin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeremyRubin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeremyRubin/bitcoin/teams","hooks_url":"https://api.github.com/repos/JeremyRubin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/JeremyRubin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/JeremyRubin/bitcoin/events","assignees_url":"https://api.github.com/repos/JeremyRubin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/JeremyRubin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/JeremyRubin/bitcoin/tags","blobs_url":"https://api.github.com/repos/JeremyRubin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeremyRubin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeremyRubin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeremyRubin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeremyRubin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/JeremyRubin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/JeremyRubin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/JeremyRubin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/JeremyRubin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/JeremyRubin/bitcoin/subscription","commits_url":"https://api.github.com/repos/JeremyRubin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeremyRubin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeremyRubin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeremyRubin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JeremyRubin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/JeremyRubin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeremyRubin/bitcoin/merges","archive_url":"https://api.github.com/repos/JeremyRubin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeremyRubin/bitcoin/downloads","issues_url":"https://api.github.com/repos/JeremyRubin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/JeremyRubin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/JeremyRubin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/JeremyRubin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeremyRubin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/JeremyRubin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/JeremyRubin/bitcoin/deployments","created_at":"2016-03-04T06:06:13Z","updated_at":"2016-08-19T18:42:35Z","pushed_at":"2016-09-07T22:45:38Z","git_url":"git://github.com/JeremyRubin/bitcoin.git","ssh_url":"git@github.com:JeremyRubin/bitcoin.git","clone_url":"https://github.com/JeremyRubin/bitcoin.git","svn_url":"https://github.com/JeremyRubin/bitcoin","homepage":"https://bitcoin.org/en/download","size":68491,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"ec139a5621a9c9f03e1988391a3c7c6c5d849776","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-09-07T21:09:13Z","pushed_at":"2016-09-07T22:54:35Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":151263,"stargazers_count":9867,"watchers_count":9867,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6576,"mirror_url":null,"open_issues_count":536,"forks":6576,"open_issues":536,"watchers":9867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8681"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8681"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8681/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8681/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/8625f705003f60897679d5313e51a8bf3ee34d9c"}}}}
{"actor":{"display_login":"sipa"}}