{"action":"closed","number":188,"pull_request":{"url":"https://api.github.com/repos/sourcelair/xterm.js/pulls/188","id":77699618,"html_url":"https://github.com/sourcelair/xterm.js/pull/188","diff_url":"https://github.com/sourcelair/xterm.js/pull/188.diff","patch_url":"https://github.com/sourcelair/xterm.js/pull/188.patch","issue_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/188","number":188,"state":"closed","locked":false,"title":"Use constant line-height","user":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars.githubusercontent.com/u/2193314?v=3","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"body":"Unicode characters have a constant height when using a decimal (eg. 1.2) but\r\ncan overlap which looks unattractive on some browsers that use transparent\r\nselections (Chrome). \"normal\" line-height differs for CJK and other unicode\r\nchars, only exactly pixel sized seems to work all the time.\r\n\r\nFixes #149","created_at":"2016-07-16T03:48:02Z","updated_at":"2016-08-02T18:02:57Z","closed_at":"2016-08-02T18:02:57Z","merged_at":null,"merge_commit_sha":"a47f9c5108869c5999294e8c960ef9bd094e29c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sourcelair/xterm.js/pulls/188/commits","review_comments_url":"https://api.github.com/repos/sourcelair/xterm.js/pulls/188/comments","review_comment_url":"https://api.github.com/repos/sourcelair/xterm.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/188/comments","statuses_url":"https://api.github.com/repos/sourcelair/xterm.js/statuses/1311a1316aa6887934b5fe40c61078901a818943","head":{"label":"Tyriar:149_fix_unicode_height","ref":"149_fix_unicode_height","sha":"1311a1316aa6887934b5fe40c61078901a818943","user":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars.githubusercontent.com/u/2193314?v=3","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"repo":{"id":60249805,"name":"xterm.js","full_name":"Tyriar/xterm.js","owner":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars.githubusercontent.com/u/2193314?v=3","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tyriar/xterm.js","description":"Full xterm terminal, in your browser","fork":true,"url":"https://api.github.com/repos/Tyriar/xterm.js","forks_url":"https://api.github.com/repos/Tyriar/xterm.js/forks","keys_url":"https://api.github.com/repos/Tyriar/xterm.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tyriar/xterm.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tyriar/xterm.js/teams","hooks_url":"https://api.github.com/repos/Tyriar/xterm.js/hooks","issue_events_url":"https://api.github.com/repos/Tyriar/xterm.js/issues/events{/number}","events_url":"https://api.github.com/repos/Tyriar/xterm.js/events","assignees_url":"https://api.github.com/repos/Tyriar/xterm.js/assignees{/user}","branches_url":"https://api.github.com/repos/Tyriar/xterm.js/branches{/branch}","tags_url":"https://api.github.com/repos/Tyriar/xterm.js/tags","blobs_url":"https://api.github.com/repos/Tyriar/xterm.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tyriar/xterm.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tyriar/xterm.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tyriar/xterm.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tyriar/xterm.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Tyriar/xterm.js/languages","stargazers_url":"https://api.github.com/repos/Tyriar/xterm.js/stargazers","contributors_url":"https://api.github.com/repos/Tyriar/xterm.js/contributors","subscribers_url":"https://api.github.com/repos/Tyriar/xterm.js/subscribers","subscription_url":"https://api.github.com/repos/Tyriar/xterm.js/subscription","commits_url":"https://api.github.com/repos/Tyriar/xterm.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tyriar/xterm.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tyriar/xterm.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tyriar/xterm.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tyriar/xterm.js/contents/{+path}","compare_url":"https://api.github.com/repos/Tyriar/xterm.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tyriar/xterm.js/merges","archive_url":"https://api.github.com/repos/Tyriar/xterm.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tyriar/xterm.js/downloads","issues_url":"https://api.github.com/repos/Tyriar/xterm.js/issues{/number}","pulls_url":"https://api.github.com/repos/Tyriar/xterm.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Tyriar/xterm.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Tyriar/xterm.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tyriar/xterm.js/labels{/name}","releases_url":"https://api.github.com/repos/Tyriar/xterm.js/releases{/id}","deployments_url":"https://api.github.com/repos/Tyriar/xterm.js/deployments","created_at":"2016-06-02T09:15:32Z","updated_at":"2016-06-19T07:29:48Z","pushed_at":"2016-08-02T16:27:00Z","git_url":"git://github.com/Tyriar/xterm.js.git","ssh_url":"git@github.com:Tyriar/xterm.js.git","clone_url":"https://github.com/Tyriar/xterm.js.git","svn_url":"https://github.com/Tyriar/xterm.js","homepage":"https://lair.io/sourcelair/xterm","size":1523,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sourcelair:master","ref":"master","sha":"13644ce35190e5bb5119e322f5f5f169ab7a1aa9","user":{"login":"sourcelair","id":799101,"avatar_url":"https://avatars.githubusercontent.com/u/799101?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcelair","html_url":"https://github.com/sourcelair","followers_url":"https://api.github.com/users/sourcelair/followers","following_url":"https://api.github.com/users/sourcelair/following{/other_user}","gists_url":"https://api.github.com/users/sourcelair/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcelair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcelair/subscriptions","organizations_url":"https://api.github.com/users/sourcelair/orgs","repos_url":"https://api.github.com/users/sourcelair/repos","events_url":"https://api.github.com/users/sourcelair/events{/privacy}","received_events_url":"https://api.github.com/users/sourcelair/received_events","type":"Organization","site_admin":false},"repo":{"id":18068542,"name":"xterm.js","full_name":"sourcelair/xterm.js","owner":{"login":"sourcelair","id":799101,"avatar_url":"https://avatars.githubusercontent.com/u/799101?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcelair","html_url":"https://github.com/sourcelair","followers_url":"https://api.github.com/users/sourcelair/followers","following_url":"https://api.github.com/users/sourcelair/following{/other_user}","gists_url":"https://api.github.com/users/sourcelair/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcelair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcelair/subscriptions","organizations_url":"https://api.github.com/users/sourcelair/orgs","repos_url":"https://api.github.com/users/sourcelair/repos","events_url":"https://api.github.com/users/sourcelair/events{/privacy}","received_events_url":"https://api.github.com/users/sourcelair/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcelair/xterm.js","description":"Full xterm terminal, in your browser","fork":false,"url":"https://api.github.com/repos/sourcelair/xterm.js","forks_url":"https://api.github.com/repos/sourcelair/xterm.js/forks","keys_url":"https://api.github.com/repos/sourcelair/xterm.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcelair/xterm.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcelair/xterm.js/teams","hooks_url":"https://api.github.com/repos/sourcelair/xterm.js/hooks","issue_events_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/events{/number}","events_url":"https://api.github.com/repos/sourcelair/xterm.js/events","assignees_url":"https://api.github.com/repos/sourcelair/xterm.js/assignees{/user}","branches_url":"https://api.github.com/repos/sourcelair/xterm.js/branches{/branch}","tags_url":"https://api.github.com/repos/sourcelair/xterm.js/tags","blobs_url":"https://api.github.com/repos/sourcelair/xterm.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcelair/xterm.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcelair/xterm.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcelair/xterm.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcelair/xterm.js/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcelair/xterm.js/languages","stargazers_url":"https://api.github.com/repos/sourcelair/xterm.js/stargazers","contributors_url":"https://api.github.com/repos/sourcelair/xterm.js/contributors","subscribers_url":"https://api.github.com/repos/sourcelair/xterm.js/subscribers","subscription_url":"https://api.github.com/repos/sourcelair/xterm.js/subscription","commits_url":"https://api.github.com/repos/sourcelair/xterm.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcelair/xterm.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcelair/xterm.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcelair/xterm.js/contents/{+path}","compare_url":"https://api.github.com/repos/sourcelair/xterm.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcelair/xterm.js/merges","archive_url":"https://api.github.com/repos/sourcelair/xterm.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcelair/xterm.js/downloads","issues_url":"https://api.github.com/repos/sourcelair/xterm.js/issues{/number}","pulls_url":"https://api.github.com/repos/sourcelair/xterm.js/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcelair/xterm.js/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcelair/xterm.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/labels{/name}","releases_url":"https://api.github.com/repos/sourcelair/xterm.js/releases{/id}","deployments_url":"https://api.github.com/repos/sourcelair/xterm.js/deployments","created_at":"2014-03-24T16:04:04Z","updated_at":"2016-08-02T13:32:29Z","pushed_at":"2016-08-02T13:59:16Z","git_url":"git://github.com/sourcelair/xterm.js.git","ssh_url":"git@github.com:sourcelair/xterm.js.git","clone_url":"https://github.com/sourcelair/xterm.js.git","svn_url":"https://github.com/sourcelair/xterm.js","homepage":"https://lair.io/sourcelair/xterm","size":1773,"stargazers_count":270,"watchers_count":270,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":52,"forks":44,"open_issues":52,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcelair/xterm.js/pulls/188"},"html":{"href":"https://github.com/sourcelair/xterm.js/pull/188"},"issue":{"href":"https://api.github.com/repos/sourcelair/xterm.js/issues/188"},"comments":{"href":"https://api.github.com/repos/sourcelair/xterm.js/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcelair/xterm.js/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcelair/xterm.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcelair/xterm.js/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/sourcelair/xterm.js/statuses/1311a1316aa6887934b5fe40c61078901a818943"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"Tyriar"}}