{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/54761652","id":54761652,"diff_hunk":"@@ -139,6 +143,15 @@ class XMLHttpRequestBase {\n     }\n   }\n \n+  _stringToArrayBuffer(str: string): ArrayBuffer {\n+    var buffer = new ArrayBuffer(str.length);\n+    var bufferView = new Uint8Array(buffer);","path":"Libraries/Network/XMLHttpRequestBase.js","position":24,"original_position":24,"commit_id":"f00106944b967c9ec105ccd89b5d38816bf6b30d","original_commit_id":"f00106944b967c9ec105ccd89b5d38816bf6b30d","user":{"login":"sreesharp","id":5561852,"avatar_url":"https://avatars.githubusercontent.com/u/5561852?v=3","gravatar_id":"","url":"https://api.github.com/users/sreesharp","html_url":"https://github.com/sreesharp","followers_url":"https://api.github.com/users/sreesharp/followers","following_url":"https://api.github.com/users/sreesharp/following{/other_user}","gists_url":"https://api.github.com/users/sreesharp/gists{/gist_id}","starred_url":"https://api.github.com/users/sreesharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreesharp/subscriptions","organizations_url":"https://api.github.com/users/sreesharp/orgs","repos_url":"https://api.github.com/users/sreesharp/repos","events_url":"https://api.github.com/users/sreesharp/events{/privacy}","received_events_url":"https://api.github.com/users/sreesharp/received_events","type":"User","site_admin":false},"body":"Looks like iOS7 market share is less than 6%  https://developer.apple.com/support/app-store/. Do you recommend enabling this feature with a flag by checking the iOS version? @javache ","created_at":"2016-03-02T17:50:00Z","updated_at":"2016-03-02T17:50:00Z","html_url":"https://github.com/facebook/react-native/pull/6156#discussion_r54761652","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/6156","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/54761652"},"html":{"href":"https://github.com/facebook/react-native/pull/6156#discussion_r54761652"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6156"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/6156","id":60774133,"html_url":"https://github.com/facebook/react-native/pull/6156","diff_url":"https://github.com/facebook/react-native/pull/6156.diff","patch_url":"https://github.com/facebook/react-native/pull/6156.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/6156","number":6156,"state":"closed","locked":false,"title":"Support for XHR responseType and response attributes","user":{"login":"sreesharp","id":5561852,"avatar_url":"https://avatars.githubusercontent.com/u/5561852?v=3","gravatar_id":"","url":"https://api.github.com/users/sreesharp","html_url":"https://github.com/sreesharp","followers_url":"https://api.github.com/users/sreesharp/followers","following_url":"https://api.github.com/users/sreesharp/following{/other_user}","gists_url":"https://api.github.com/users/sreesharp/gists{/gist_id}","starred_url":"https://api.github.com/users/sreesharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreesharp/subscriptions","organizations_url":"https://api.github.com/users/sreesharp/orgs","repos_url":"https://api.github.com/users/sreesharp/repos","events_url":"https://api.github.com/users/sreesharp/events{/privacy}","received_events_url":"https://api.github.com/users/sreesharp/received_events","type":"User","site_admin":false},"body":"Currently the XMLHttpRequest don't support any response types other than text. This PR will add responseType attribute as well response attribute. \r\n\r\nThis PR will partially solve the issue https://github.com/facebook/react-native/issues/6017","created_at":"2016-02-26T00:43:51Z","updated_at":"2016-03-02T17:50:00Z","closed_at":"2016-03-01T17:36:56Z","merged_at":null,"merge_commit_sha":"8aab65311658653a7550cc93c43d8d4fe5f1f8bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/6156/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/6156/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/6156/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/f00106944b967c9ec105ccd89b5d38816bf6b30d","head":{"label":"sreesharp:master","ref":"master","sha":"f00106944b967c9ec105ccd89b5d38816bf6b30d","user":{"login":"sreesharp","id":5561852,"avatar_url":"https://avatars.githubusercontent.com/u/5561852?v=3","gravatar_id":"","url":"https://api.github.com/users/sreesharp","html_url":"https://github.com/sreesharp","followers_url":"https://api.github.com/users/sreesharp/followers","following_url":"https://api.github.com/users/sreesharp/following{/other_user}","gists_url":"https://api.github.com/users/sreesharp/gists{/gist_id}","starred_url":"https://api.github.com/users/sreesharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreesharp/subscriptions","organizations_url":"https://api.github.com/users/sreesharp/orgs","repos_url":"https://api.github.com/users/sreesharp/repos","events_url":"https://api.github.com/users/sreesharp/events{/privacy}","received_events_url":"https://api.github.com/users/sreesharp/received_events","type":"User","site_admin":false},"repo":{"id":52552380,"name":"react-native","full_name":"sreesharp/react-native","owner":{"login":"sreesharp","id":5561852,"avatar_url":"https://avatars.githubusercontent.com/u/5561852?v=3","gravatar_id":"","url":"https://api.github.com/users/sreesharp","html_url":"https://github.com/sreesharp","followers_url":"https://api.github.com/users/sreesharp/followers","following_url":"https://api.github.com/users/sreesharp/following{/other_user}","gists_url":"https://api.github.com/users/sreesharp/gists{/gist_id}","starred_url":"https://api.github.com/users/sreesharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreesharp/subscriptions","organizations_url":"https://api.github.com/users/sreesharp/orgs","repos_url":"https://api.github.com/users/sreesharp/repos","events_url":"https://api.github.com/users/sreesharp/events{/privacy}","received_events_url":"https://api.github.com/users/sreesharp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sreesharp/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/sreesharp/react-native","forks_url":"https://api.github.com/repos/sreesharp/react-native/forks","keys_url":"https://api.github.com/repos/sreesharp/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sreesharp/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sreesharp/react-native/teams","hooks_url":"https://api.github.com/repos/sreesharp/react-native/hooks","issue_events_url":"https://api.github.com/repos/sreesharp/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/sreesharp/react-native/events","assignees_url":"https://api.github.com/repos/sreesharp/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/sreesharp/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/sreesharp/react-native/tags","blobs_url":"https://api.github.com/repos/sreesharp/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sreesharp/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sreesharp/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/sreesharp/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sreesharp/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/sreesharp/react-native/languages","stargazers_url":"https://api.github.com/repos/sreesharp/react-native/stargazers","contributors_url":"https://api.github.com/repos/sreesharp/react-native/contributors","subscribers_url":"https://api.github.com/repos/sreesharp/react-native/subscribers","subscription_url":"https://api.github.com/repos/sreesharp/react-native/subscription","commits_url":"https://api.github.com/repos/sreesharp/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/sreesharp/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/sreesharp/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/sreesharp/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/sreesharp/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/sreesharp/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sreesharp/react-native/merges","archive_url":"https://api.github.com/repos/sreesharp/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sreesharp/react-native/downloads","issues_url":"https://api.github.com/repos/sreesharp/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/sreesharp/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/sreesharp/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/sreesharp/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sreesharp/react-native/labels{/name}","releases_url":"https://api.github.com/repos/sreesharp/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/sreesharp/react-native/deployments","created_at":"2016-02-25T19:50:58Z","updated_at":"2016-02-25T19:51:05Z","pushed_at":"2016-03-01T17:04:49Z","git_url":"git://github.com/sreesharp/react-native.git","ssh_url":"git@github.com:sreesharp/react-native.git","clone_url":"https://github.com/sreesharp/react-native.git","svn_url":"https://github.com/sreesharp/react-native","homepage":"http://facebook.github.io/react-native/","size":46965,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"bd95b22844e9facd2c6f34c644f4b33fd116c2d7","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-03-02T17:45:47Z","pushed_at":"2016-03-02T17:25:18Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":81172,"stargazers_count":28026,"watchers_count":28026,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5196,"mirror_url":null,"open_issues_count":1181,"forks":5196,"open_issues":1181,"watchers":28026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6156"},"html":{"href":"https://github.com/facebook/react-native/pull/6156"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/6156"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/6156/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6156/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6156/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/f00106944b967c9ec105ccd89b5d38816bf6b30d"}}}}