{"action":"created","comment":{"url":"https://api.github.com/repos/uwdata/compassql/pulls/comments/73762576","id":73762576,"diff_hunk":"@@ -186,6 +175,170 @@ describe('schema', () => {\n       });\n       assert.equal(cardinality, 7);\n     });\n+\n+    it('should correctly compute new binned cardinality when binned cardinality is less than non-binned cardinality', () => {\n+      const cardinalityData = [\n+        {a: 0}, {a: 1},                 // bin 0-1\n+        {a: 2}, {a: 2}, {a: 3}, {a: 3}, // bin 2-3\n+        {a: 6}, {a: 7}                  // bin 6-7","path":"test/schema.test.ts","position":27,"original_position":27,"commit_id":"1f0df9bb6b7e29f2a33001a3c12bb9e81eb17446","original_commit_id":"1f0df9bb6b7e29f2a33001a3c12bb9e81eb17446","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars.githubusercontent.com/u/111269?v=3","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"If I understand correctly, bin 4-5 is empty.  If so add a line \r\n\r\n```\r\n// bin 4-5 is empty\r\n```","created_at":"2016-08-05T21:31:55Z","updated_at":"2016-08-05T21:31:55Z","html_url":"https://github.com/uwdata/compassql/pull/135#discussion_r73762576","pull_request_url":"https://api.github.com/repos/uwdata/compassql/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/comments/73762576"},"html":{"href":"https://github.com/uwdata/compassql/pull/135#discussion_r73762576"},"pull_request":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/uwdata/compassql/pulls/135","id":77512088,"html_url":"https://github.com/uwdata/compassql/pull/135","diff_url":"https://github.com/uwdata/compassql/pull/135.diff","patch_url":"https://github.com/uwdata/compassql/pull/135.patch","issue_url":"https://api.github.com/repos/uwdata/compassql/issues/135","number":135,"state":"open","locked":false,"title":"[WIP] Cardinality functionality for bin/timeUnit fields - Fix #95","user":{"login":"RileyChang","id":4986478,"avatar_url":"https://avatars.githubusercontent.com/u/4986478?v=3","gravatar_id":"","url":"https://api.github.com/users/RileyChang","html_url":"https://github.com/RileyChang","followers_url":"https://api.github.com/users/RileyChang/followers","following_url":"https://api.github.com/users/RileyChang/following{/other_user}","gists_url":"https://api.github.com/users/RileyChang/gists{/gist_id}","starred_url":"https://api.github.com/users/RileyChang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RileyChang/subscriptions","organizations_url":"https://api.github.com/users/RileyChang/orgs","repos_url":"https://api.github.com/users/RileyChang/repos","events_url":"https://api.github.com/users/RileyChang/events{/privacy}","received_events_url":"https://api.github.com/users/RileyChang/received_events","type":"User","site_admin":false},"body":"Fix #95 \r\n1. `cardinality` method functions correctly for bin/timeUnit fields (issue #95)\r\n2. Test coverage for cardinality","created_at":"2016-07-14T19:31:58Z","updated_at":"2016-08-05T21:31:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"141e15347fed8bb679435e1fc703af3280461be0","assignee":{"login":"kanitw","id":111269,"avatar_url":"https://avatars.githubusercontent.com/u/111269?v=3","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"assignees":[{"login":"kanitw","id":111269,"avatar_url":"https://avatars.githubusercontent.com/u/111269?v=3","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uwdata/compassql/pulls/135/commits","review_comments_url":"https://api.github.com/repos/uwdata/compassql/pulls/135/comments","review_comment_url":"https://api.github.com/repos/uwdata/compassql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uwdata/compassql/issues/135/comments","statuses_url":"https://api.github.com/repos/uwdata/compassql/statuses/1f0df9bb6b7e29f2a33001a3c12bb9e81eb17446","head":{"label":"uwdata:rc/bin-timeUnit-cardinality","ref":"rc/bin-timeUnit-cardinality","sha":"1f0df9bb6b7e29f2a33001a3c12bb9e81eb17446","user":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"repo":{"id":58768960,"name":"compassql","full_name":"uwdata/compassql","owner":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwdata/compassql","description":"CompassQL Query Language for visualization recommendation.","fork":false,"url":"https://api.github.com/repos/uwdata/compassql","forks_url":"https://api.github.com/repos/uwdata/compassql/forks","keys_url":"https://api.github.com/repos/uwdata/compassql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwdata/compassql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwdata/compassql/teams","hooks_url":"https://api.github.com/repos/uwdata/compassql/hooks","issue_events_url":"https://api.github.com/repos/uwdata/compassql/issues/events{/number}","events_url":"https://api.github.com/repos/uwdata/compassql/events","assignees_url":"https://api.github.com/repos/uwdata/compassql/assignees{/user}","branches_url":"https://api.github.com/repos/uwdata/compassql/branches{/branch}","tags_url":"https://api.github.com/repos/uwdata/compassql/tags","blobs_url":"https://api.github.com/repos/uwdata/compassql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwdata/compassql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwdata/compassql/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwdata/compassql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwdata/compassql/statuses/{sha}","languages_url":"https://api.github.com/repos/uwdata/compassql/languages","stargazers_url":"https://api.github.com/repos/uwdata/compassql/stargazers","contributors_url":"https://api.github.com/repos/uwdata/compassql/contributors","subscribers_url":"https://api.github.com/repos/uwdata/compassql/subscribers","subscription_url":"https://api.github.com/repos/uwdata/compassql/subscription","commits_url":"https://api.github.com/repos/uwdata/compassql/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwdata/compassql/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwdata/compassql/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwdata/compassql/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwdata/compassql/contents/{+path}","compare_url":"https://api.github.com/repos/uwdata/compassql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwdata/compassql/merges","archive_url":"https://api.github.com/repos/uwdata/compassql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwdata/compassql/downloads","issues_url":"https://api.github.com/repos/uwdata/compassql/issues{/number}","pulls_url":"https://api.github.com/repos/uwdata/compassql/pulls{/number}","milestones_url":"https://api.github.com/repos/uwdata/compassql/milestones{/number}","notifications_url":"https://api.github.com/repos/uwdata/compassql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwdata/compassql/labels{/name}","releases_url":"https://api.github.com/repos/uwdata/compassql/releases{/id}","deployments_url":"https://api.github.com/repos/uwdata/compassql/deployments","created_at":"2016-05-13T20:01:53Z","updated_at":"2016-07-19T01:19:16Z","pushed_at":"2016-08-05T21:27:33Z","git_url":"git://github.com/uwdata/compassql.git","ssh_url":"git@github.com:uwdata/compassql.git","clone_url":"https://github.com/uwdata/compassql.git","svn_url":"https://github.com/uwdata/compassql","homepage":null,"size":1176,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":63,"forks":0,"open_issues":63,"watchers":2,"default_branch":"master"}},"base":{"label":"uwdata:master","ref":"master","sha":"130b60916dd6f78bbf907759a2053b0398f08a00","user":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"repo":{"id":58768960,"name":"compassql","full_name":"uwdata/compassql","owner":{"login":"uwdata","id":5448960,"avatar_url":"https://avatars.githubusercontent.com/u/5448960?v=3","gravatar_id":"","url":"https://api.github.com/users/uwdata","html_url":"https://github.com/uwdata","followers_url":"https://api.github.com/users/uwdata/followers","following_url":"https://api.github.com/users/uwdata/following{/other_user}","gists_url":"https://api.github.com/users/uwdata/gists{/gist_id}","starred_url":"https://api.github.com/users/uwdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwdata/subscriptions","organizations_url":"https://api.github.com/users/uwdata/orgs","repos_url":"https://api.github.com/users/uwdata/repos","events_url":"https://api.github.com/users/uwdata/events{/privacy}","received_events_url":"https://api.github.com/users/uwdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwdata/compassql","description":"CompassQL Query Language for visualization recommendation.","fork":false,"url":"https://api.github.com/repos/uwdata/compassql","forks_url":"https://api.github.com/repos/uwdata/compassql/forks","keys_url":"https://api.github.com/repos/uwdata/compassql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwdata/compassql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwdata/compassql/teams","hooks_url":"https://api.github.com/repos/uwdata/compassql/hooks","issue_events_url":"https://api.github.com/repos/uwdata/compassql/issues/events{/number}","events_url":"https://api.github.com/repos/uwdata/compassql/events","assignees_url":"https://api.github.com/repos/uwdata/compassql/assignees{/user}","branches_url":"https://api.github.com/repos/uwdata/compassql/branches{/branch}","tags_url":"https://api.github.com/repos/uwdata/compassql/tags","blobs_url":"https://api.github.com/repos/uwdata/compassql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwdata/compassql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwdata/compassql/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwdata/compassql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwdata/compassql/statuses/{sha}","languages_url":"https://api.github.com/repos/uwdata/compassql/languages","stargazers_url":"https://api.github.com/repos/uwdata/compassql/stargazers","contributors_url":"https://api.github.com/repos/uwdata/compassql/contributors","subscribers_url":"https://api.github.com/repos/uwdata/compassql/subscribers","subscription_url":"https://api.github.com/repos/uwdata/compassql/subscription","commits_url":"https://api.github.com/repos/uwdata/compassql/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwdata/compassql/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwdata/compassql/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwdata/compassql/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwdata/compassql/contents/{+path}","compare_url":"https://api.github.com/repos/uwdata/compassql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwdata/compassql/merges","archive_url":"https://api.github.com/repos/uwdata/compassql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwdata/compassql/downloads","issues_url":"https://api.github.com/repos/uwdata/compassql/issues{/number}","pulls_url":"https://api.github.com/repos/uwdata/compassql/pulls{/number}","milestones_url":"https://api.github.com/repos/uwdata/compassql/milestones{/number}","notifications_url":"https://api.github.com/repos/uwdata/compassql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwdata/compassql/labels{/name}","releases_url":"https://api.github.com/repos/uwdata/compassql/releases{/id}","deployments_url":"https://api.github.com/repos/uwdata/compassql/deployments","created_at":"2016-05-13T20:01:53Z","updated_at":"2016-07-19T01:19:16Z","pushed_at":"2016-08-05T21:27:33Z","git_url":"git://github.com/uwdata/compassql.git","ssh_url":"git@github.com:uwdata/compassql.git","clone_url":"https://github.com/uwdata/compassql.git","svn_url":"https://github.com/uwdata/compassql","homepage":null,"size":1176,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":63,"forks":0,"open_issues":63,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/135"},"html":{"href":"https://github.com/uwdata/compassql/pull/135"},"issue":{"href":"https://api.github.com/repos/uwdata/compassql/issues/135"},"comments":{"href":"https://api.github.com/repos/uwdata/compassql/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uwdata/compassql/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/uwdata/compassql/statuses/1f0df9bb6b7e29f2a33001a3c12bb9e81eb17446"}}}}
{"actor":{"display_login":"kanitw"}}