{"action":"created","comment":{"url":"https://api.github.com/repos/mbedmicro/mbed/pulls/comments/71695702","id":71695702,"diff_hunk":"@@ -260,117 +277,67 @@ def build_project(src_path, build_path, target, toolchain_name,\n \n def build_library(src_paths, build_path, target, toolchain_name,\n          dependencies_paths=None, options=None, name=None, clean=False, archive=True,\n-         notify=None, verbose=False, macros=None, inc_dirs=None, inc_dirs_ext=None,\n+         notify=None, verbose=False, macros=None, inc_dirs=None,","path":"tools/build_api.py","position":238,"original_position":238,"commit_id":"e2fc956f006ab4c36d31f9c0ac286325fe79bd07","original_commit_id":"e2fc956f006ab4c36d31f9c0ac286325fe79bd07","user":{"login":"screamerbg","id":5940648,"avatar_url":"https://avatars.githubusercontent.com/u/5940648?v=3","gravatar_id":"","url":"https://api.github.com/users/screamerbg","html_url":"https://github.com/screamerbg","followers_url":"https://api.github.com/users/screamerbg/followers","following_url":"https://api.github.com/users/screamerbg/following{/other_user}","gists_url":"https://api.github.com/users/screamerbg/gists{/gist_id}","starred_url":"https://api.github.com/users/screamerbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screamerbg/subscriptions","organizations_url":"https://api.github.com/users/screamerbg/orgs","repos_url":"https://api.github.com/users/screamerbg/repos","events_url":"https://api.github.com/users/screamerbg/events{/privacy}","received_events_url":"https://api.github.com/users/screamerbg/received_events","type":"User","site_admin":false},"body":"inc_dirs_ext is no longer used for build_library(). It's remnant from old code which is no longer present.","created_at":"2016-07-21T12:28:45Z","updated_at":"2016-07-21T12:28:45Z","html_url":"https://github.com/mbedmicro/mbed/pull/2188#discussion_r71695702","pull_request_url":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188","_links":{"self":{"href":"https://api.github.com/repos/mbedmicro/mbed/pulls/comments/71695702"},"html":{"href":"https://github.com/mbedmicro/mbed/pull/2188#discussion_r71695702"},"pull_request":{"href":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188"}}},"pull_request":{"url":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188","id":77860498,"html_url":"https://github.com/mbedmicro/mbed/pull/2188","diff_url":"https://github.com/mbedmicro/mbed/pull/2188.diff","patch_url":"https://github.com/mbedmicro/mbed/pull/2188.patch","issue_url":"https://api.github.com/repos/mbedmicro/mbed/issues/2188","number":2188,"state":"open","locked":false,"title":"[Tools] Unify common routines in build_api.py","user":{"login":"screamerbg","id":5940648,"avatar_url":"https://avatars.githubusercontent.com/u/5940648?v=3","gravatar_id":"","url":"https://api.github.com/users/screamerbg","html_url":"https://github.com/screamerbg","followers_url":"https://api.github.com/users/screamerbg/followers","following_url":"https://api.github.com/users/screamerbg/following{/other_user}","gists_url":"https://api.github.com/users/screamerbg/gists{/gist_id}","starred_url":"https://api.github.com/users/screamerbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screamerbg/subscriptions","organizations_url":"https://api.github.com/users/screamerbg/orgs","repos_url":"https://api.github.com/users/screamerbg/repos","events_url":"https://api.github.com/users/screamerbg/events{/privacy}","received_events_url":"https://api.github.com/users/screamerbg/received_events","type":"User","site_admin":false},"body":"Introduce prepare_toolchain() which handles:\r\n * de-duplication of src_paths\r\n * config initialization\r\n * toolchain initialization\r\n * toolchain flags\r\n * returns toolchain object\r\n\r\nIntroduce scan_resources() which handles:\r\n * scanning of sources\r\n * scanning of include dirs\r\n * inclusion of addition include dirs\r\n * returns resources object with scanned resources\r\n\r\nApply prepare_toolchain() and scan_resources() in:\r\n* get_config()\r\n* build_project()\r\n* build_library()","created_at":"2016-07-18T19:02:28Z","updated_at":"2016-07-21T12:28:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99838f572fe81c65bb6c469c4459628f5d194987","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188/commits","review_comments_url":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188/comments","review_comment_url":"https://api.github.com/repos/mbedmicro/mbed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mbedmicro/mbed/issues/2188/comments","statuses_url":"https://api.github.com/repos/mbedmicro/mbed/statuses/e2fc956f006ab4c36d31f9c0ac286325fe79bd07","head":{"label":"screamerbg:build-common","ref":"build-common","sha":"e2fc956f006ab4c36d31f9c0ac286325fe79bd07","user":{"login":"screamerbg","id":5940648,"avatar_url":"https://avatars.githubusercontent.com/u/5940648?v=3","gravatar_id":"","url":"https://api.github.com/users/screamerbg","html_url":"https://github.com/screamerbg","followers_url":"https://api.github.com/users/screamerbg/followers","following_url":"https://api.github.com/users/screamerbg/following{/other_user}","gists_url":"https://api.github.com/users/screamerbg/gists{/gist_id}","starred_url":"https://api.github.com/users/screamerbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screamerbg/subscriptions","organizations_url":"https://api.github.com/users/screamerbg/orgs","repos_url":"https://api.github.com/users/screamerbg/repos","events_url":"https://api.github.com/users/screamerbg/events{/privacy}","received_events_url":"https://api.github.com/users/screamerbg/received_events","type":"User","site_admin":false},"repo":{"id":59601258,"name":"mbed","full_name":"screamerbg/mbed","owner":{"login":"screamerbg","id":5940648,"avatar_url":"https://avatars.githubusercontent.com/u/5940648?v=3","gravatar_id":"","url":"https://api.github.com/users/screamerbg","html_url":"https://github.com/screamerbg","followers_url":"https://api.github.com/users/screamerbg/followers","following_url":"https://api.github.com/users/screamerbg/following{/other_user}","gists_url":"https://api.github.com/users/screamerbg/gists{/gist_id}","starred_url":"https://api.github.com/users/screamerbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screamerbg/subscriptions","organizations_url":"https://api.github.com/users/screamerbg/orgs","repos_url":"https://api.github.com/users/screamerbg/repos","events_url":"https://api.github.com/users/screamerbg/events{/privacy}","received_events_url":"https://api.github.com/users/screamerbg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/screamerbg/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/screamerbg/mbed","forks_url":"https://api.github.com/repos/screamerbg/mbed/forks","keys_url":"https://api.github.com/repos/screamerbg/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screamerbg/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screamerbg/mbed/teams","hooks_url":"https://api.github.com/repos/screamerbg/mbed/hooks","issue_events_url":"https://api.github.com/repos/screamerbg/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/screamerbg/mbed/events","assignees_url":"https://api.github.com/repos/screamerbg/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/screamerbg/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/screamerbg/mbed/tags","blobs_url":"https://api.github.com/repos/screamerbg/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screamerbg/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screamerbg/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/screamerbg/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screamerbg/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/screamerbg/mbed/languages","stargazers_url":"https://api.github.com/repos/screamerbg/mbed/stargazers","contributors_url":"https://api.github.com/repos/screamerbg/mbed/contributors","subscribers_url":"https://api.github.com/repos/screamerbg/mbed/subscribers","subscription_url":"https://api.github.com/repos/screamerbg/mbed/subscription","commits_url":"https://api.github.com/repos/screamerbg/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/screamerbg/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/screamerbg/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/screamerbg/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/screamerbg/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/screamerbg/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screamerbg/mbed/merges","archive_url":"https://api.github.com/repos/screamerbg/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screamerbg/mbed/downloads","issues_url":"https://api.github.com/repos/screamerbg/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/screamerbg/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/screamerbg/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/screamerbg/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screamerbg/mbed/labels{/name}","releases_url":"https://api.github.com/repos/screamerbg/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/screamerbg/mbed/deployments","created_at":"2016-05-24T19:13:11Z","updated_at":"2016-05-24T19:14:09Z","pushed_at":"2016-07-19T09:43:01Z","git_url":"git://github.com/screamerbg/mbed.git","ssh_url":"git@github.com:screamerbg/mbed.git","clone_url":"https://github.com/screamerbg/mbed.git","svn_url":"https://github.com/screamerbg/mbed","homepage":"","size":52210,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mbedmicro:master","ref":"master","sha":"5cd73170ba13e7cae2243e5759fbfd976411683a","user":{"login":"mbedmicro","id":3626466,"avatar_url":"https://avatars.githubusercontent.com/u/3626466?v=3","gravatar_id":"","url":"https://api.github.com/users/mbedmicro","html_url":"https://github.com/mbedmicro","followers_url":"https://api.github.com/users/mbedmicro/followers","following_url":"https://api.github.com/users/mbedmicro/following{/other_user}","gists_url":"https://api.github.com/users/mbedmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/mbedmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbedmicro/subscriptions","organizations_url":"https://api.github.com/users/mbedmicro/orgs","repos_url":"https://api.github.com/users/mbedmicro/repos","events_url":"https://api.github.com/users/mbedmicro/events{/privacy}","received_events_url":"https://api.github.com/users/mbedmicro/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed","full_name":"mbedmicro/mbed","owner":{"login":"mbedmicro","id":3626466,"avatar_url":"https://avatars.githubusercontent.com/u/3626466?v=3","gravatar_id":"","url":"https://api.github.com/users/mbedmicro","html_url":"https://github.com/mbedmicro","followers_url":"https://api.github.com/users/mbedmicro/followers","following_url":"https://api.github.com/users/mbedmicro/following{/other_user}","gists_url":"https://api.github.com/users/mbedmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/mbedmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbedmicro/subscriptions","organizations_url":"https://api.github.com/users/mbedmicro/orgs","repos_url":"https://api.github.com/users/mbedmicro/repos","events_url":"https://api.github.com/users/mbedmicro/events{/privacy}","received_events_url":"https://api.github.com/users/mbedmicro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mbedmicro/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":false,"url":"https://api.github.com/repos/mbedmicro/mbed","forks_url":"https://api.github.com/repos/mbedmicro/mbed/forks","keys_url":"https://api.github.com/repos/mbedmicro/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbedmicro/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbedmicro/mbed/teams","hooks_url":"https://api.github.com/repos/mbedmicro/mbed/hooks","issue_events_url":"https://api.github.com/repos/mbedmicro/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/mbedmicro/mbed/events","assignees_url":"https://api.github.com/repos/mbedmicro/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/mbedmicro/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/mbedmicro/mbed/tags","blobs_url":"https://api.github.com/repos/mbedmicro/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbedmicro/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbedmicro/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbedmicro/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbedmicro/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/mbedmicro/mbed/languages","stargazers_url":"https://api.github.com/repos/mbedmicro/mbed/stargazers","contributors_url":"https://api.github.com/repos/mbedmicro/mbed/contributors","subscribers_url":"https://api.github.com/repos/mbedmicro/mbed/subscribers","subscription_url":"https://api.github.com/repos/mbedmicro/mbed/subscription","commits_url":"https://api.github.com/repos/mbedmicro/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbedmicro/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbedmicro/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbedmicro/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbedmicro/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/mbedmicro/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbedmicro/mbed/merges","archive_url":"https://api.github.com/repos/mbedmicro/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbedmicro/mbed/downloads","issues_url":"https://api.github.com/repos/mbedmicro/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/mbedmicro/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/mbedmicro/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/mbedmicro/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbedmicro/mbed/labels{/name}","releases_url":"https://api.github.com/repos/mbedmicro/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/mbedmicro/mbed/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2016-07-21T12:11:53Z","pushed_at":"2016-07-21T11:10:35Z","git_url":"git://github.com/mbedmicro/mbed.git","ssh_url":"git@github.com:mbedmicro/mbed.git","clone_url":"https://github.com/mbedmicro/mbed.git","svn_url":"https://github.com/mbedmicro/mbed","homepage":"","size":59847,"stargazers_count":681,"watchers_count":681,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":690,"mirror_url":null,"open_issues_count":265,"forks":690,"open_issues":265,"watchers":681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188"},"html":{"href":"https://github.com/mbedmicro/mbed/pull/2188"},"issue":{"href":"https://api.github.com/repos/mbedmicro/mbed/issues/2188"},"comments":{"href":"https://api.github.com/repos/mbedmicro/mbed/issues/2188/comments"},"review_comments":{"href":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188/comments"},"review_comment":{"href":"https://api.github.com/repos/mbedmicro/mbed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mbedmicro/mbed/pulls/2188/commits"},"statuses":{"href":"https://api.github.com/repos/mbedmicro/mbed/statuses/e2fc956f006ab4c36d31f9c0ac286325fe79bd07"}}}}
{"actor":{"display_login":"screamerbg"}}