{"action":"created","comment":{"url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments/89800485","pull_request_review_id":10325156,"id":89800485,"diff_hunk":"@@ -254,8 +260,6 @@ object TransformData extends App {\n \n     /**\n       * Looks for regions that have the label \"test\" and changes their label to the value of their `knora-base:hasComment`.\n-      *","path":"webapi/src/main/scala/org/knora/webapi/util/TransformData.scala","position":37,"original_position":37,"commit_id":"ed70accc2a351aee50e1b7babc466c239f0914af","original_commit_id":"ed70accc2a351aee50e1b7babc466c239f0914af","user":{"login":"tobiasschweizer","id":6000023,"avatar_url":"https://avatars.githubusercontent.com/u/6000023?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasschweizer","html_url":"https://github.com/tobiasschweizer","followers_url":"https://api.github.com/users/tobiasschweizer/followers","following_url":"https://api.github.com/users/tobiasschweizer/following{/other_user}","gists_url":"https://api.github.com/users/tobiasschweizer/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasschweizer/subscriptions","organizations_url":"https://api.github.com/users/tobiasschweizer/orgs","repos_url":"https://api.github.com/users/tobiasschweizer/repos","events_url":"https://api.github.com/users/tobiasschweizer/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasschweizer/received_events","type":"User","site_admin":false},"body":"Why did you remove the documentation of the required param? Because it is already documented in the abstract super class?","created_at":"2016-11-28T15:14:34Z","updated_at":"2016-11-28T15:17:28Z","html_url":"https://github.com/dhlab-basel/Knora/pull/330#discussion_r89800485","pull_request_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330","_links":{"self":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments/89800485"},"html":{"href":"https://github.com/dhlab-basel/Knora/pull/330#discussion_r89800485"},"pull_request":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330","id":94664981,"html_url":"https://github.com/dhlab-basel/Knora/pull/330","diff_url":"https://github.com/dhlab-basel/Knora/pull/330.diff","patch_url":"https://github.com/dhlab-basel/Knora/pull/330.patch","issue_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/330","number":330,"state":"open","locked":false,"title":"Fix various inconsistencies in knora-base.ttl and docs.","user":{"login":"benjamingeer","id":558389,"avatar_url":"https://avatars.githubusercontent.com/u/558389?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamingeer","html_url":"https://github.com/benjamingeer","followers_url":"https://api.github.com/users/benjamingeer/followers","following_url":"https://api.github.com/users/benjamingeer/following{/other_user}","gists_url":"https://api.github.com/users/benjamingeer/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingeer/subscriptions","organizations_url":"https://api.github.com/users/benjamingeer/orgs","repos_url":"https://api.github.com/users/benjamingeer/repos","events_url":"https://api.github.com/users/benjamingeer/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingeer/received_events","type":"User","site_admin":false},"body":"Fixes inconsistencies in `knora-base.ttl`:\r\n\r\n* Add datatype properties `knora-base:name`, `knora-base:givenName`, and `knora-base:familyName`, as subproperties of the corresponding `foaf` properties and of `knora-base:objectCannotBeMarkedAsDeleted`, and use the `knora-base` properties instead of the `foaf` ones, so consistency rules can check them properly.\r\n* Change the type of `knora-base:valueHas` to `rdf:Property`, so its subproperties can be either object properties or datatype properties.\r\n* Make `valueHasListNode` an object property.\r\n* Remove incorrect cardinalities for `hasComment` on value classes.\r\n* Fix cardinalities on `DocumentRepresentation` and `TextRepresentation`.\r\n* Remove unused properties `currentproject`, `filename`, and `protocol`.\r\n* Don't use `foaf:birthday`, whose object should be a literal.\r\n* Don't use `foaf:member`, because it means the opposite of what was intended.\r\n* Improve comments and labels.\r\n* Use the term Julian Day Number instead of Julian Day Count (#327).\r\n\r\nTest data and tests are fixed accordingly. There are also some corrections and clarifications in `knora-base.rst`.\r\n\r\nCloses #327.\r\nCloses #328.","created_at":"2016-11-21T17:56:17Z","updated_at":"2016-11-28T15:17:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b17ffea3c483ccbab4e130b1e79dea20e552115","assignee":{"login":"tobiasschweizer","id":6000023,"avatar_url":"https://avatars.githubusercontent.com/u/6000023?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasschweizer","html_url":"https://github.com/tobiasschweizer","followers_url":"https://api.github.com/users/tobiasschweizer/followers","following_url":"https://api.github.com/users/tobiasschweizer/following{/other_user}","gists_url":"https://api.github.com/users/tobiasschweizer/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasschweizer/subscriptions","organizations_url":"https://api.github.com/users/tobiasschweizer/orgs","repos_url":"https://api.github.com/users/tobiasschweizer/repos","events_url":"https://api.github.com/users/tobiasschweizer/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasschweizer/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobiasschweizer","id":6000023,"avatar_url":"https://avatars.githubusercontent.com/u/6000023?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasschweizer","html_url":"https://github.com/tobiasschweizer","followers_url":"https://api.github.com/users/tobiasschweizer/followers","following_url":"https://api.github.com/users/tobiasschweizer/following{/other_user}","gists_url":"https://api.github.com/users/tobiasschweizer/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasschweizer/subscriptions","organizations_url":"https://api.github.com/users/tobiasschweizer/orgs","repos_url":"https://api.github.com/users/tobiasschweizer/repos","events_url":"https://api.github.com/users/tobiasschweizer/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasschweizer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dhlab-basel/Knora/milestones/3","html_url":"https://github.com/dhlab-basel/Knora/milestones/Beta%20Release","labels_url":"https://api.github.com/repos/dhlab-basel/Knora/milestones/3/labels","id":1843168,"number":3,"title":"Beta Release","description":"","creator":{"login":"subotic","id":400790,"avatar_url":"https://avatars.githubusercontent.com/u/400790?v=3","gravatar_id":"","url":"https://api.github.com/users/subotic","html_url":"https://github.com/subotic","followers_url":"https://api.github.com/users/subotic/followers","following_url":"https://api.github.com/users/subotic/following{/other_user}","gists_url":"https://api.github.com/users/subotic/gists{/gist_id}","starred_url":"https://api.github.com/users/subotic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subotic/subscriptions","organizations_url":"https://api.github.com/users/subotic/orgs","repos_url":"https://api.github.com/users/subotic/repos","events_url":"https://api.github.com/users/subotic/events{/privacy}","received_events_url":"https://api.github.com/users/subotic/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":60,"state":"open","created_at":"2016-06-22T13:53:33Z","updated_at":"2016-11-28T14:42:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330/commits","review_comments_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330/comments","review_comment_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/330/comments","statuses_url":"https://api.github.com/repos/dhlab-basel/Knora/statuses/ed70accc2a351aee50e1b7babc466c239f0914af","head":{"label":"dhlab-basel:wip/ontology-fixes","ref":"wip/ontology-fixes","sha":"ed70accc2a351aee50e1b7babc466c239f0914af","user":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"repo":{"id":47264649,"name":"Knora","full_name":"dhlab-basel/Knora","owner":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhlab-basel/Knora","description":"Knowledge Organization, Representation, and Annotation","fork":false,"url":"https://api.github.com/repos/dhlab-basel/Knora","forks_url":"https://api.github.com/repos/dhlab-basel/Knora/forks","keys_url":"https://api.github.com/repos/dhlab-basel/Knora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhlab-basel/Knora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhlab-basel/Knora/teams","hooks_url":"https://api.github.com/repos/dhlab-basel/Knora/hooks","issue_events_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/events{/number}","events_url":"https://api.github.com/repos/dhlab-basel/Knora/events","assignees_url":"https://api.github.com/repos/dhlab-basel/Knora/assignees{/user}","branches_url":"https://api.github.com/repos/dhlab-basel/Knora/branches{/branch}","tags_url":"https://api.github.com/repos/dhlab-basel/Knora/tags","blobs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhlab-basel/Knora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhlab-basel/Knora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhlab-basel/Knora/statuses/{sha}","languages_url":"https://api.github.com/repos/dhlab-basel/Knora/languages","stargazers_url":"https://api.github.com/repos/dhlab-basel/Knora/stargazers","contributors_url":"https://api.github.com/repos/dhlab-basel/Knora/contributors","subscribers_url":"https://api.github.com/repos/dhlab-basel/Knora/subscribers","subscription_url":"https://api.github.com/repos/dhlab-basel/Knora/subscription","commits_url":"https://api.github.com/repos/dhlab-basel/Knora/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhlab-basel/Knora/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhlab-basel/Knora/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhlab-basel/Knora/contents/{+path}","compare_url":"https://api.github.com/repos/dhlab-basel/Knora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhlab-basel/Knora/merges","archive_url":"https://api.github.com/repos/dhlab-basel/Knora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhlab-basel/Knora/downloads","issues_url":"https://api.github.com/repos/dhlab-basel/Knora/issues{/number}","pulls_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls{/number}","milestones_url":"https://api.github.com/repos/dhlab-basel/Knora/milestones{/number}","notifications_url":"https://api.github.com/repos/dhlab-basel/Knora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhlab-basel/Knora/labels{/name}","releases_url":"https://api.github.com/repos/dhlab-basel/Knora/releases{/id}","deployments_url":"https://api.github.com/repos/dhlab-basel/Knora/deployments","created_at":"2015-12-02T14:00:26Z","updated_at":"2016-11-15T00:58:10Z","pushed_at":"2016-11-28T14:39:57Z","git_url":"git://github.com/dhlab-basel/Knora.git","ssh_url":"git@github.com:dhlab-basel/Knora.git","clone_url":"https://github.com/dhlab-basel/Knora.git","svn_url":"https://github.com/dhlab-basel/Knora","homepage":"http://knora.org","size":247574,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":122,"forks":6,"open_issues":122,"watchers":7,"default_branch":"develop"}},"base":{"label":"dhlab-basel:develop","ref":"develop","sha":"5e60fc2e521129d13e9ea9d51499e235c7c2240e","user":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"repo":{"id":47264649,"name":"Knora","full_name":"dhlab-basel/Knora","owner":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhlab-basel/Knora","description":"Knowledge Organization, Representation, and Annotation","fork":false,"url":"https://api.github.com/repos/dhlab-basel/Knora","forks_url":"https://api.github.com/repos/dhlab-basel/Knora/forks","keys_url":"https://api.github.com/repos/dhlab-basel/Knora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhlab-basel/Knora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhlab-basel/Knora/teams","hooks_url":"https://api.github.com/repos/dhlab-basel/Knora/hooks","issue_events_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/events{/number}","events_url":"https://api.github.com/repos/dhlab-basel/Knora/events","assignees_url":"https://api.github.com/repos/dhlab-basel/Knora/assignees{/user}","branches_url":"https://api.github.com/repos/dhlab-basel/Knora/branches{/branch}","tags_url":"https://api.github.com/repos/dhlab-basel/Knora/tags","blobs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhlab-basel/Knora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhlab-basel/Knora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhlab-basel/Knora/statuses/{sha}","languages_url":"https://api.github.com/repos/dhlab-basel/Knora/languages","stargazers_url":"https://api.github.com/repos/dhlab-basel/Knora/stargazers","contributors_url":"https://api.github.com/repos/dhlab-basel/Knora/contributors","subscribers_url":"https://api.github.com/repos/dhlab-basel/Knora/subscribers","subscription_url":"https://api.github.com/repos/dhlab-basel/Knora/subscription","commits_url":"https://api.github.com/repos/dhlab-basel/Knora/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhlab-basel/Knora/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhlab-basel/Knora/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhlab-basel/Knora/contents/{+path}","compare_url":"https://api.github.com/repos/dhlab-basel/Knora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhlab-basel/Knora/merges","archive_url":"https://api.github.com/repos/dhlab-basel/Knora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhlab-basel/Knora/downloads","issues_url":"https://api.github.com/repos/dhlab-basel/Knora/issues{/number}","pulls_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls{/number}","milestones_url":"https://api.github.com/repos/dhlab-basel/Knora/milestones{/number}","notifications_url":"https://api.github.com/repos/dhlab-basel/Knora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhlab-basel/Knora/labels{/name}","releases_url":"https://api.github.com/repos/dhlab-basel/Knora/releases{/id}","deployments_url":"https://api.github.com/repos/dhlab-basel/Knora/deployments","created_at":"2015-12-02T14:00:26Z","updated_at":"2016-11-15T00:58:10Z","pushed_at":"2016-11-28T14:39:57Z","git_url":"git://github.com/dhlab-basel/Knora.git","ssh_url":"git@github.com:dhlab-basel/Knora.git","clone_url":"https://github.com/dhlab-basel/Knora.git","svn_url":"https://github.com/dhlab-basel/Knora","homepage":"http://knora.org","size":247574,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":122,"forks":6,"open_issues":122,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330"},"html":{"href":"https://github.com/dhlab-basel/Knora/pull/330"},"issue":{"href":"https://api.github.com/repos/dhlab-basel/Knora/issues/330"},"comments":{"href":"https://api.github.com/repos/dhlab-basel/Knora/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/dhlab-basel/Knora/statuses/ed70accc2a351aee50e1b7babc466c239f0914af"}}}}
{"actor":{"display_login":"tobiasschweizer"}}