{"action":"created","comment":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/85372130","pull_request_review_id":6093094,"id":85372130,"diff_hunk":"@@ -58,10 +60,24 @@ def __init__(self, name, address, reset=False, numdacs=16, dac_step=10,\n         # values based on descriptor\n         self.visa_handle.baud_rate = 115200\n         self.visa_handle.parity = visa.constants.Parity(1)  # odd parity\n+        self.visa_handle.write_termination = ''\n+        self.visa_handle.read_termination = ''\n \n         self.add_parameter('version',\n                            get_cmd=self._get_version)\n-        \n+\n+        self.add_parameter('check_setpoints',\n+                           parameter_class=ManualParameter,\n+                           initial_value=False,\n+                           label='Check setpoints',\n+                           vals=Bool())\n+\n+        self.add_parameter('dac_set_sleep',","path":"qcodes/instrument_drivers/QuTech/IVVI.py","position":26,"original_position":26,"commit_id":"e4de6228499bca43e792d7075a83e774f893eec3","original_commit_id":"e4de6228499bca43e792d7075a83e774f893eec3","user":{"login":"peendebak","id":17724047,"avatar_url":"https://avatars.githubusercontent.com/u/17724047?v=3","gravatar_id":"","url":"https://api.github.com/users/peendebak","html_url":"https://github.com/peendebak","followers_url":"https://api.github.com/users/peendebak/followers","following_url":"https://api.github.com/users/peendebak/following{/other_user}","gists_url":"https://api.github.com/users/peendebak/gists{/gist_id}","starred_url":"https://api.github.com/users/peendebak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peendebak/subscriptions","organizations_url":"https://api.github.com/users/peendebak/orgs","repos_url":"https://api.github.com/users/peendebak/repos","events_url":"https://api.github.com/users/peendebak/events{/privacy}","received_events_url":"https://api.github.com/users/peendebak/received_events","type":"User","site_admin":false},"body":"It is implemented, see for example the PR #335","created_at":"2016-10-27T16:10:34Z","updated_at":"2016-10-27T16:10:34Z","html_url":"https://github.com/QCoDeS/Qcodes/pull/320#discussion_r85372130","pull_request_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320","_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/85372130"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/320#discussion_r85372130"},"pull_request":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320","id":83222258,"html_url":"https://github.com/QCoDeS/Qcodes/pull/320","diff_url":"https://github.com/QCoDeS/Qcodes/pull/320.diff","patch_url":"https://github.com/QCoDeS/Qcodes/pull/320.patch","issue_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/320","number":320,"state":"open","locked":false,"title":"Improved IVVI driver speed","user":{"login":"Rubenknex","id":610967,"avatar_url":"https://avatars.githubusercontent.com/u/610967?v=3","gravatar_id":"","url":"https://api.github.com/users/Rubenknex","html_url":"https://github.com/Rubenknex","followers_url":"https://api.github.com/users/Rubenknex/followers","following_url":"https://api.github.com/users/Rubenknex/following{/other_user}","gists_url":"https://api.github.com/users/Rubenknex/gists{/gist_id}","starred_url":"https://api.github.com/users/Rubenknex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rubenknex/subscriptions","organizations_url":"https://api.github.com/users/Rubenknex/orgs","repos_url":"https://api.github.com/users/Rubenknex/repos","events_url":"https://api.github.com/users/Rubenknex/events{/privacy}","received_events_url":"https://api.github.com/users/Rubenknex/received_events","type":"User","site_admin":false},"body":"Changes proposed in this pull request:\r\n- Removed checking for same DAC values in the `_set_dac`. At least for my machine the setting is fast enough that a check only causes an extra delay.\r\n- Removed 50ms sleep in `_set_dac` as there seems to be no reason to sleep here\r\n- Reduced the interval for checking the buffer in `read` from 50ms to 25ms as this (again on my machine) seems to always be completed in under 20ms.\r\n\r\n- [ ] Test in an actual measurement\r\n\r\n@alexcjohnson\r\n\r\n","created_at":"2016-08-30T07:39:57Z","updated_at":"2016-10-27T16:10:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecda4601cf111d664faa2c49b1548d4aa35007dd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320/commits","review_comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320/comments","review_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/320/comments","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/e4de6228499bca43e792d7075a83e774f893eec3","head":{"label":"QCoDeS:feature/IVVI-timings","ref":"feature/IVVI-timings","sha":"e4de6228499bca43e792d7075a83e774f893eec3","user":{"login":"QCoDeS","id":20478252,"avatar_url":"https://avatars.githubusercontent.com/u/20478252?v=3","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"repo":{"id":37137879,"name":"Qcodes","full_name":"QCoDeS/Qcodes","owner":{"login":"QCoDeS","id":20478252,"avatar_url":"https://avatars.githubusercontent.com/u/20478252?v=3","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QCoDeS/Qcodes","description":"Modular data acquisition and analysis framework","fork":false,"url":"https://api.github.com/repos/QCoDeS/Qcodes","forks_url":"https://api.github.com/repos/QCoDeS/Qcodes/forks","keys_url":"https://api.github.com/repos/QCoDeS/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QCoDeS/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QCoDeS/Qcodes/teams","hooks_url":"https://api.github.com/repos/QCoDeS/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/QCoDeS/Qcodes/events","assignees_url":"https://api.github.com/repos/QCoDeS/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/QCoDeS/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/tags","blobs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/QCoDeS/Qcodes/languages","stargazers_url":"https://api.github.com/repos/QCoDeS/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/QCoDeS/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscription","commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/QCoDeS/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/QCoDeS/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QCoDeS/Qcodes/merges","archive_url":"https://api.github.com/repos/QCoDeS/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QCoDeS/Qcodes/downloads","issues_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/QCoDeS/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/QCoDeS/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QCoDeS/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/QCoDeS/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/QCoDeS/Qcodes/deployments","created_at":"2015-06-09T14:42:14Z","updated_at":"2016-10-25T12:31:32Z","pushed_at":"2016-10-27T15:51:10Z","git_url":"git://github.com/QCoDeS/Qcodes.git","ssh_url":"git@github.com:QCoDeS/Qcodes.git","clone_url":"https://github.com/QCoDeS/Qcodes.git","svn_url":"https://github.com/QCoDeS/Qcodes","homepage":"https://pypi.python.org/pypi/qcodes","size":21195,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":110,"forks":3,"open_issues":110,"watchers":2,"default_branch":"master"}},"base":{"label":"QCoDeS:master","ref":"master","sha":"c64bbf81fa7ef4356b93b906916ac0f34ef2047a","user":{"login":"QCoDeS","id":20478252,"avatar_url":"https://avatars.githubusercontent.com/u/20478252?v=3","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"repo":{"id":37137879,"name":"Qcodes","full_name":"QCoDeS/Qcodes","owner":{"login":"QCoDeS","id":20478252,"avatar_url":"https://avatars.githubusercontent.com/u/20478252?v=3","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QCoDeS/Qcodes","description":"Modular data acquisition and analysis framework","fork":false,"url":"https://api.github.com/repos/QCoDeS/Qcodes","forks_url":"https://api.github.com/repos/QCoDeS/Qcodes/forks","keys_url":"https://api.github.com/repos/QCoDeS/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QCoDeS/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QCoDeS/Qcodes/teams","hooks_url":"https://api.github.com/repos/QCoDeS/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/QCoDeS/Qcodes/events","assignees_url":"https://api.github.com/repos/QCoDeS/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/QCoDeS/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/tags","blobs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/QCoDeS/Qcodes/languages","stargazers_url":"https://api.github.com/repos/QCoDeS/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/QCoDeS/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscription","commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/QCoDeS/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/QCoDeS/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QCoDeS/Qcodes/merges","archive_url":"https://api.github.com/repos/QCoDeS/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QCoDeS/Qcodes/downloads","issues_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/QCoDeS/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/QCoDeS/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QCoDeS/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/QCoDeS/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/QCoDeS/Qcodes/deployments","created_at":"2015-06-09T14:42:14Z","updated_at":"2016-10-25T12:31:32Z","pushed_at":"2016-10-27T15:51:10Z","git_url":"git://github.com/QCoDeS/Qcodes.git","ssh_url":"git@github.com:QCoDeS/Qcodes.git","clone_url":"https://github.com/QCoDeS/Qcodes.git","svn_url":"https://github.com/QCoDeS/Qcodes","homepage":"https://pypi.python.org/pypi/qcodes","size":21195,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":110,"forks":3,"open_issues":110,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/320"},"issue":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/320"},"comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/e4de6228499bca43e792d7075a83e774f893eec3"}}}}
{"actor":{"display_login":"peendebak"}}