{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/88033616","pull_request_review_id":8619458,"id":88033616,"diff_hunk":"@@ -238,9 +238,65 @@ def prepare(options = {})\n       protected\n \n       def upgrade_controller_nodes\n-        drbd_nodes = NodeObject.find(\"drbd:*\")\n-        # FIXME: prepare for cases with no drbd out there\n-        return true if drbd_nodes.empty?\n+        drbd_nodes = NodeObject.find(\"drbd_rsc:*\")\n+        return upgrade_drbd_nodes unless drbd_nodes.empty?\n+\n+        founder = NodeObject.find(\n+          \"state:crowbar_upgrade AND pacemaker_founder:true\"\n+        ).first\n+        cluster_env = founder[:pacemaker][:config][:environment]\n+\n+        non_founder = NodeObject.find(\n+          \"state:crowbar_upgrade AND pacemaker_founder:false AND \" \\\n+          \"pacemaker_config_environment:#{cluster_env}\"\n+        ).first\n+\n+        # 1. upgrade the founder\n+        save_upgrade_state(\"Starting the upgrade of node #{founder.name}\")\n+        founder_api = Api::Node.new founder.name","path":"crowbar_framework/app/models/api/upgrade.rb","position":22,"original_position":22,"commit_id":"a084a051f5b3354741b3e5823f5354c10a72e984","original_commit_id":"a084a051f5b3354741b3e5823f5354c10a72e984","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"why not name it `founder_node`?","created_at":"2016-11-15T15:02:10Z","updated_at":"2016-11-15T15:02:10Z","html_url":"https://github.com/crowbar/crowbar-core/pull/779#discussion_r88033616","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/88033616"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/779#discussion_r88033616"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779","id":93191275,"html_url":"https://github.com/crowbar/crowbar-core/pull/779","diff_url":"https://github.com/crowbar/crowbar-core/pull/779.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/779.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/779","number":779,"state":"open","locked":false,"title":"Upgrade non-drbd controller nodes","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"Includes code from @abel-navarro's https://github.com/crowbar/crowbar-core/pull/783, but executed directly from crowbar app","created_at":"2016-11-10T17:06:34Z","updated_at":"2016-11-15T15:05:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b98054b0c4876b048e93425535074cf275c3822d","assignee":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"assignees":[{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/779/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/a084a051f5b3354741b3e5823f5354c10a72e984","head":{"label":"jsuchome:upgrade-non-drbd","ref":"upgrade-non-drbd","sha":"a084a051f5b3354741b3e5823f5354c10a72e984","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"repo":{"id":44730679,"name":"crowbar-core","full_name":"jsuchome/crowbar-core","owner":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsuchome/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/jsuchome/crowbar-core","forks_url":"https://api.github.com/repos/jsuchome/crowbar-core/forks","keys_url":"https://api.github.com/repos/jsuchome/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsuchome/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsuchome/crowbar-core/teams","hooks_url":"https://api.github.com/repos/jsuchome/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/jsuchome/crowbar-core/events","assignees_url":"https://api.github.com/repos/jsuchome/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/jsuchome/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/tags","blobs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsuchome/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jsuchome/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/jsuchome/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/jsuchome/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscription","commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsuchome/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsuchome/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/jsuchome/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsuchome/crowbar-core/merges","archive_url":"https://api.github.com/repos/jsuchome/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsuchome/crowbar-core/downloads","issues_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/jsuchome/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jsuchome/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jsuchome/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsuchome/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/jsuchome/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/jsuchome/crowbar-core/deployments","created_at":"2015-10-22T07:59:41Z","updated_at":"2015-10-22T07:59:49Z","pushed_at":"2016-11-15T13:50:16Z","git_url":"git://github.com/jsuchome/crowbar-core.git","ssh_url":"git@github.com:jsuchome/crowbar-core.git","clone_url":"https://github.com/jsuchome/crowbar-core.git","svn_url":"https://github.com/jsuchome/crowbar-core","homepage":null,"size":106553,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"1d0c75991b91a139327fc791a0bc014defa72ed7","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-11-11T19:16:44Z","pushed_at":"2016-11-15T14:31:21Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":121797,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":49,"forks":37,"open_issues":49,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/779"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/779"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/779/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/779/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/a084a051f5b3354741b3e5823f5354c10a72e984"}}}}
{"actor":{"display_login":"MaximilianMeister"}}