{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments/69766735","id":69766735,"diff_hunk":"@@ -3337,7 +3341,19 @@ NextControl:\n         ''' <returns></returns>\n         ''' <remarks></remarks>\n         Protected Function GetProjectPath() As String\n-            Return CStr(GetCommonPropertyValueNative(\"FullPath\")) 'CONSIDER: This won't work for all project types, e.g. ASP.NET when project path is a URL","path":"src/Microsoft.VisualStudio.AppDesigner/PropPages/PropPageUserControlBase.vb","position":15,"original_position":15,"commit_id":"01cd8137987f9b21f813dca03e5e2dfc6f0943b0","original_commit_id":"01cd8137987f9b21f813dca03e5e2dfc6f0943b0","user":{"login":"davkean","id":1103906,"avatar_url":"https://avatars.githubusercontent.com/u/1103906?v=3","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"body":"BrowseObject != Project Properties, basically if you add it to ConfigurationGeneral, it should show up.","created_at":"2016-07-06T16:42:37Z","updated_at":"2016-07-06T16:42:37Z","html_url":"https://github.com/dotnet/roslyn-project-system/pull/287#discussion_r69766735","pull_request_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments/69766735"},"html":{"href":"https://github.com/dotnet/roslyn-project-system/pull/287#discussion_r69766735"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287","id":76364401,"html_url":"https://github.com/dotnet/roslyn-project-system/pull/287","diff_url":"https://github.com/dotnet/roslyn-project-system/pull/287.diff","patch_url":"https://github.com/dotnet/roslyn-project-system/pull/287.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/287","number":287,"state":"open","locked":false,"title":"Signing prop page","user":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars.githubusercontent.com/u/10605811?v=3","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"body":"Add support to show the Signing property page and implement `InterceptedProjectPropertiesProvider` (allows to write a single property value provider to validate and/or transform a property value)\r\n\r\nFixes #265\r\n\r\n**NOTE:** This PR depends on bunch of source and test changes from @natidea's PR https://github.com/dotnet/roslyn-project-system/pull/283/ - I have just cloned these files for now. Once that PR has been merged in, I'll remove the cloned copies in my branch.","created_at":"2016-07-06T00:47:12Z","updated_at":"2016-07-06T16:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8993685e660f30560921b1f59315a1081ed1a6e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/287/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/01cd8137987f9b21f813dca03e5e2dfc6f0943b0","head":{"label":"mavasani:SigningPropPage","ref":"SigningPropPage","sha":"01cd8137987f9b21f813dca03e5e2dfc6f0943b0","user":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars.githubusercontent.com/u/10605811?v=3","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"repo":{"id":61313125,"name":"roslyn-project-system","full_name":"mavasani/roslyn-project-system","owner":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars.githubusercontent.com/u/10605811?v=3","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mavasani/roslyn-project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":true,"url":"https://api.github.com/repos/mavasani/roslyn-project-system","forks_url":"https://api.github.com/repos/mavasani/roslyn-project-system/forks","keys_url":"https://api.github.com/repos/mavasani/roslyn-project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavasani/roslyn-project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavasani/roslyn-project-system/teams","hooks_url":"https://api.github.com/repos/mavasani/roslyn-project-system/hooks","issue_events_url":"https://api.github.com/repos/mavasani/roslyn-project-system/issues/events{/number}","events_url":"https://api.github.com/repos/mavasani/roslyn-project-system/events","assignees_url":"https://api.github.com/repos/mavasani/roslyn-project-system/assignees{/user}","branches_url":"https://api.github.com/repos/mavasani/roslyn-project-system/branches{/branch}","tags_url":"https://api.github.com/repos/mavasani/roslyn-project-system/tags","blobs_url":"https://api.github.com/repos/mavasani/roslyn-project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavasani/roslyn-project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavasani/roslyn-project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavasani/roslyn-project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavasani/roslyn-project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/mavasani/roslyn-project-system/languages","stargazers_url":"https://api.github.com/repos/mavasani/roslyn-project-system/stargazers","contributors_url":"https://api.github.com/repos/mavasani/roslyn-project-system/contributors","subscribers_url":"https://api.github.com/repos/mavasani/roslyn-project-system/subscribers","subscription_url":"https://api.github.com/repos/mavasani/roslyn-project-system/subscription","commits_url":"https://api.github.com/repos/mavasani/roslyn-project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavasani/roslyn-project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavasani/roslyn-project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavasani/roslyn-project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavasani/roslyn-project-system/contents/{+path}","compare_url":"https://api.github.com/repos/mavasani/roslyn-project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavasani/roslyn-project-system/merges","archive_url":"https://api.github.com/repos/mavasani/roslyn-project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavasani/roslyn-project-system/downloads","issues_url":"https://api.github.com/repos/mavasani/roslyn-project-system/issues{/number}","pulls_url":"https://api.github.com/repos/mavasani/roslyn-project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/mavasani/roslyn-project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/mavasani/roslyn-project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavasani/roslyn-project-system/labels{/name}","releases_url":"https://api.github.com/repos/mavasani/roslyn-project-system/releases{/id}","deployments_url":"https://api.github.com/repos/mavasani/roslyn-project-system/deployments","created_at":"2016-06-16T17:30:39Z","updated_at":"2016-06-16T17:30:40Z","pushed_at":"2016-07-06T00:40:23Z","git_url":"git://github.com/mavasani/roslyn-project-system.git","ssh_url":"git@github.com:mavasani/roslyn-project-system.git","clone_url":"https://github.com/mavasani/roslyn-project-system.git","svn_url":"https://github.com/mavasani/roslyn-project-system","homepage":null,"size":4911,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"fbf596a2daf3b972bd695ed70bac7700eddf0e60","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"name":"roslyn-project-system","full_name":"dotnet/roslyn-project-system","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn-project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn-project-system","forks_url":"https://api.github.com/repos/dotnet/roslyn-project-system/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn-project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn-project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn-project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn-project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn-project-system/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn-project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn-project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn-project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn-project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn-project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn-project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn-project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn-project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn-project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn-project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn-project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn-project-system/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn-project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn-project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn-project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn-project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn-project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn-project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn-project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn-project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2016-07-05T22:41:08Z","pushed_at":"2016-07-06T16:29:25Z","git_url":"git://github.com/dotnet/roslyn-project-system.git","ssh_url":"git@github.com:dotnet/roslyn-project-system.git","clone_url":"https://github.com/dotnet/roslyn-project-system.git","svn_url":"https://github.com/dotnet/roslyn-project-system","homepage":null,"size":5213,"stargazers_count":118,"watchers_count":118,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":162,"forks":18,"open_issues":162,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287"},"html":{"href":"https://github.com/dotnet/roslyn-project-system/pull/287"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/287"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn-project-system/statuses/01cd8137987f9b21f813dca03e5e2dfc6f0943b0"}}}}
{"actor":{"display_login":"davkean"}}