{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/64580773","id":64580773,"diff_hunk":"@@ -55,6 +55,34 @@ defineSuite([\n         s.destroy();\n     });\n \n+    it('draws sky with setDayNight(true) ', function() {\n+        var s = new SkyAtmosphere();\n+\n+        expect(scene.renderForSpecs()).toEqual([0, 0, 0, 255]);\n+        scene.render();\n+\n+        var command = s.update(scene.frameState);\n+        expect(command).toBeDefined();\n+        expect(s._iDayNight === true);","path":"Specs/Scene/SkyAtmosphereSpec.js","position":12,"original_position":12,"commit_id":"d2efb37a12d09bfb159f1b55866577ca60c39c06","original_commit_id":"d2efb37a12d09bfb159f1b55866577ca60c39c06","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"body":"Ah.. actually this should be `toBe(1)` once the other change is in.","created_at":"2016-05-25T14:18:59Z","updated_at":"2016-05-25T14:18:59Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3955#discussion_r64580773","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/64580773"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3955#discussion_r64580773"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955","id":71293509,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3955","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3955.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3955.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3955","number":3955,"state":"open","locked":false,"title":"Sun-position based atmosphere color","user":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars.githubusercontent.com/u/5395255?v=3","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"body":"As a partial response to #3439, enabled support for sun position based atmospheric color when drawing with `enableLighting`.\r\n\r\nAlso updated CHANGES.md.","created_at":"2016-05-24T21:11:47Z","updated_at":"2016-05-25T14:18:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3955/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/d2efb37a12d09bfb159f1b55866577ca60c39c06","head":{"label":"likangning93:sunBasedAtmosphereColorChange","ref":"sunBasedAtmosphereColorChange","sha":"d2efb37a12d09bfb159f1b55866577ca60c39c06","user":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars.githubusercontent.com/u/5395255?v=3","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"repo":{"id":59577300,"name":"cesium","full_name":"likangning93/cesium","owner":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars.githubusercontent.com/u/5395255?v=3","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/likangning93/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/likangning93/cesium","forks_url":"https://api.github.com/repos/likangning93/cesium/forks","keys_url":"https://api.github.com/repos/likangning93/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/likangning93/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/likangning93/cesium/teams","hooks_url":"https://api.github.com/repos/likangning93/cesium/hooks","issue_events_url":"https://api.github.com/repos/likangning93/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/likangning93/cesium/events","assignees_url":"https://api.github.com/repos/likangning93/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/likangning93/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/likangning93/cesium/tags","blobs_url":"https://api.github.com/repos/likangning93/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/likangning93/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/likangning93/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/likangning93/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/likangning93/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/likangning93/cesium/languages","stargazers_url":"https://api.github.com/repos/likangning93/cesium/stargazers","contributors_url":"https://api.github.com/repos/likangning93/cesium/contributors","subscribers_url":"https://api.github.com/repos/likangning93/cesium/subscribers","subscription_url":"https://api.github.com/repos/likangning93/cesium/subscription","commits_url":"https://api.github.com/repos/likangning93/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/likangning93/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/likangning93/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/likangning93/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/likangning93/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/likangning93/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/likangning93/cesium/merges","archive_url":"https://api.github.com/repos/likangning93/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/likangning93/cesium/downloads","issues_url":"https://api.github.com/repos/likangning93/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/likangning93/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/likangning93/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/likangning93/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/likangning93/cesium/labels{/name}","releases_url":"https://api.github.com/repos/likangning93/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/likangning93/cesium/deployments","created_at":"2016-05-24T13:50:36Z","updated_at":"2016-05-24T13:50:48Z","pushed_at":"2016-05-24T21:04:53Z","git_url":"git://github.com/likangning93/cesium.git","ssh_url":"git@github.com:likangning93/cesium.git","clone_url":"https://github.com/likangning93/cesium.git","svn_url":"https://github.com/likangning93/cesium","homepage":"cesiumjs.org","size":239167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"d929f97ca6f6ef65932c9e26403702dd93feba58","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"WebGL virtual globe and map engine","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2016-05-25T07:56:45Z","pushed_at":"2016-05-25T13:35:06Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"cesiumjs.org","size":378188,"stargazers_count":1284,"watchers_count":1284,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":729,"mirror_url":null,"open_issues_count":410,"forks":729,"open_issues":410,"watchers":1284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3955"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3955"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3955/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3955/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/d2efb37a12d09bfb159f1b55866577ca60c39c06"}}}}
{"actor":{"display_login":"lilleyse"}}