{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/50113930","id":50113930,"diff_hunk":"@@ -2,17 +2,17 @@\n \n # Checks if the tools required for properly building, verifying and testing GlusterD are installed.\n \n-TOOLS=(glide gometalinter)\n+TOOLS=(glide gometalinter etcd)\n \n MISSING=0\n \n for tool in ${TOOLS[@]}; do\n   type $tool >/dev/null 2>&1\n   if [ $? -ne 0 ]; then\n-    echo \"$tool is missing on the system\"\n+    echo \"$tool package is missing on the system\"","path":"scripts/check-reqs.sh","position":13,"original_position":13,"commit_id":"0f938b570a299fdffd5f114b92fe6a4348ee685a","original_commit_id":"0f938b570a299fdffd5f114b92fe6a4348ee685a","user":{"login":"gaurav36","id":6826559,"avatar_url":"https://avatars.githubusercontent.com/u/6826559?v=3","gravatar_id":"","url":"https://api.github.com/users/gaurav36","html_url":"https://github.com/gaurav36","followers_url":"https://api.github.com/users/gaurav36/followers","following_url":"https://api.github.com/users/gaurav36/following{/other_user}","gists_url":"https://api.github.com/users/gaurav36/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurav36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurav36/subscriptions","organizations_url":"https://api.github.com/users/gaurav36/orgs","repos_url":"https://api.github.com/users/gaurav36/repos","events_url":"https://api.github.com/users/gaurav36/events{/privacy}","received_events_url":"https://api.github.com/users/gaurav36/received_events","type":"User","site_admin":false},"body":"it should not be tool package. because suppose etcd is missing then value of $tool will be etcd, and according to your opinion if i change it to too/package then it will become  etcd/package missing.","created_at":"2016-01-19T13:56:52Z","updated_at":"2016-01-19T13:56:52Z","html_url":"https://github.com/gluster/glusterd2/pull/71#discussion_r50113930","pull_request_url":"https://api.github.com/repos/gluster/glusterd2/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/50113930"},"html":{"href":"https://github.com/gluster/glusterd2/pull/71#discussion_r50113930"},"pull_request":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/71","id":56440861,"html_url":"https://github.com/gluster/glusterd2/pull/71","diff_url":"https://github.com/gluster/glusterd2/pull/71.diff","patch_url":"https://github.com/gluster/glusterd2/pull/71.patch","issue_url":"https://api.github.com/repos/gluster/glusterd2/issues/71","number":71,"state":"open","locked":false,"title":"Install etcd as a package requirement for GlusterD 2.0","user":{"login":"gaurav36","id":6826559,"avatar_url":"https://avatars.githubusercontent.com/u/6826559?v=3","gravatar_id":"","url":"https://api.github.com/users/gaurav36","html_url":"https://github.com/gaurav36","followers_url":"https://api.github.com/users/gaurav36/followers","following_url":"https://api.github.com/users/gaurav36/following{/other_user}","gists_url":"https://api.github.com/users/gaurav36/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurav36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurav36/subscriptions","organizations_url":"https://api.github.com/users/gaurav36/orgs","repos_url":"https://api.github.com/users/gaurav36/repos","events_url":"https://api.github.com/users/gaurav36/events{/privacy}","received_events_url":"https://api.github.com/users/gaurav36/received_events","type":"User","site_admin":false},"body":"Install etcd while executing install-reqs.sh (all necessary package for\r\nGlusterD 2.0).\r\n\r\nIssue #70\r\n\r\nSigned-off-by: Gaurav Kumar Garg <garg.gaurav52@gmail.com>","created_at":"2016-01-19T09:34:48Z","updated_at":"2016-01-19T13:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18b0b2cb1526630ba87e7e4941b7a3eeab457769","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gluster/glusterd2/pulls/71/commits","review_comments_url":"https://api.github.com/repos/gluster/glusterd2/pulls/71/comments","review_comment_url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/glusterd2/issues/71/comments","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/0f938b570a299fdffd5f114b92fe6a4348ee685a","head":{"label":"gaurav36:install-etcd-upon-go-get-glusterd2","ref":"install-etcd-upon-go-get-glusterd2","sha":"0f938b570a299fdffd5f114b92fe6a4348ee685a","user":{"login":"gaurav36","id":6826559,"avatar_url":"https://avatars.githubusercontent.com/u/6826559?v=3","gravatar_id":"","url":"https://api.github.com/users/gaurav36","html_url":"https://github.com/gaurav36","followers_url":"https://api.github.com/users/gaurav36/followers","following_url":"https://api.github.com/users/gaurav36/following{/other_user}","gists_url":"https://api.github.com/users/gaurav36/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurav36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurav36/subscriptions","organizations_url":"https://api.github.com/users/gaurav36/orgs","repos_url":"https://api.github.com/users/gaurav36/repos","events_url":"https://api.github.com/users/gaurav36/events{/privacy}","received_events_url":"https://api.github.com/users/gaurav36/received_events","type":"User","site_admin":false},"repo":{"id":46916725,"name":"glusterd2","full_name":"gaurav36/glusterd2","owner":{"login":"gaurav36","id":6826559,"avatar_url":"https://avatars.githubusercontent.com/u/6826559?v=3","gravatar_id":"","url":"https://api.github.com/users/gaurav36","html_url":"https://github.com/gaurav36","followers_url":"https://api.github.com/users/gaurav36/followers","following_url":"https://api.github.com/users/gaurav36/following{/other_user}","gists_url":"https://api.github.com/users/gaurav36/gists{/gist_id}","starred_url":"https://api.github.com/users/gaurav36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaurav36/subscriptions","organizations_url":"https://api.github.com/users/gaurav36/orgs","repos_url":"https://api.github.com/users/gaurav36/repos","events_url":"https://api.github.com/users/gaurav36/events{/privacy}","received_events_url":"https://api.github.com/users/gaurav36/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaurav36/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":true,"url":"https://api.github.com/repos/gaurav36/glusterd2","forks_url":"https://api.github.com/repos/gaurav36/glusterd2/forks","keys_url":"https://api.github.com/repos/gaurav36/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaurav36/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaurav36/glusterd2/teams","hooks_url":"https://api.github.com/repos/gaurav36/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/gaurav36/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/gaurav36/glusterd2/events","assignees_url":"https://api.github.com/repos/gaurav36/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/gaurav36/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/gaurav36/glusterd2/tags","blobs_url":"https://api.github.com/repos/gaurav36/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaurav36/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaurav36/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaurav36/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaurav36/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/gaurav36/glusterd2/languages","stargazers_url":"https://api.github.com/repos/gaurav36/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/gaurav36/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/gaurav36/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/gaurav36/glusterd2/subscription","commits_url":"https://api.github.com/repos/gaurav36/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaurav36/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaurav36/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaurav36/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaurav36/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/gaurav36/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaurav36/glusterd2/merges","archive_url":"https://api.github.com/repos/gaurav36/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaurav36/glusterd2/downloads","issues_url":"https://api.github.com/repos/gaurav36/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/gaurav36/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/gaurav36/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/gaurav36/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaurav36/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/gaurav36/glusterd2/releases{/id}","created_at":"2015-11-26T09:26:45Z","updated_at":"2015-11-26T09:26:45Z","pushed_at":"2016-01-19T12:26:26Z","git_url":"git://github.com/gaurav36/glusterd2.git","ssh_url":"git@github.com:gaurav36/glusterd2.git","clone_url":"https://github.com/gaurav36/glusterd2.git","svn_url":"https://github.com/gaurav36/glusterd2","homepage":"","size":1432,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"d6e08814f547f6df04dd2c4a5dcaf84000ac7b2c","user":{"login":"gluster","id":622644,"avatar_url":"https://avatars.githubusercontent.com/u/622644?v=3","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":24369600,"name":"glusterd2","full_name":"gluster/glusterd2","owner":{"login":"gluster","id":622644,"avatar_url":"https://avatars.githubusercontent.com/u/622644?v=3","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":false,"url":"https://api.github.com/repos/gluster/glusterd2","forks_url":"https://api.github.com/repos/gluster/glusterd2/forks","keys_url":"https://api.github.com/repos/gluster/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/glusterd2/teams","hooks_url":"https://api.github.com/repos/gluster/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/gluster/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/glusterd2/events","assignees_url":"https://api.github.com/repos/gluster/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/glusterd2/tags","blobs_url":"https://api.github.com/repos/gluster/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/glusterd2/languages","stargazers_url":"https://api.github.com/repos/gluster/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/gluster/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/gluster/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/gluster/glusterd2/subscription","commits_url":"https://api.github.com/repos/gluster/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/glusterd2/merges","archive_url":"https://api.github.com/repos/gluster/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/glusterd2/downloads","issues_url":"https://api.github.com/repos/gluster/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/gluster/glusterd2/releases{/id}","created_at":"2014-09-23T12:02:13Z","updated_at":"2016-01-11T14:29:09Z","pushed_at":"2016-01-19T12:26:26Z","git_url":"git://github.com/gluster/glusterd2.git","ssh_url":"git@github.com:gluster/glusterd2.git","clone_url":"https://github.com/gluster/glusterd2.git","svn_url":"https://github.com/gluster/glusterd2","homepage":"","size":1482,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":15,"forks":7,"open_issues":15,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/71"},"html":{"href":"https://github.com/gluster/glusterd2/pull/71"},"issue":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/71"},"comments":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/glusterd2/statuses/0f938b570a299fdffd5f114b92fe6a4348ee685a"}}}}