{"action":"created","comment":{"url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/comments/49999871","id":49999871,"diff_hunk":"@@ -441,7 +441,7 @@ class ReplCalculator(\n     val SparkConfScript = {\n       val m = customSparkConf .getOrElse(Map.empty[String, String])\n       m .map { case (k, v) =>\n-        \"( \\\"\" + k + \"\\\"  → \\\"\" + v + \"\\\" )\"\n+        \"( \\\"\" + k + \"\\\"  → \\\"\\\"\\\"\" + v + \"\\\"\\\"\\\" )\"","path":"modules/kernel/src/main/scala-2.10/notebook/ReplCalculator.scala","position":5,"original_position":5,"commit_id":"a64220edbcd4e7a5b50badd16bd8e9750a3e6044","original_commit_id":"a64220edbcd4e7a5b50badd16bd8e9750a3e6044","user":{"login":"andypetrella","id":663344,"avatar_url":"https://avatars.githubusercontent.com/u/663344?v=3","gravatar_id":"","url":"https://api.github.com/users/andypetrella","html_url":"https://github.com/andypetrella","followers_url":"https://api.github.com/users/andypetrella/followers","following_url":"https://api.github.com/users/andypetrella/following{/other_user}","gists_url":"https://api.github.com/users/andypetrella/gists{/gist_id}","starred_url":"https://api.github.com/users/andypetrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andypetrella/subscriptions","organizations_url":"https://api.github.com/users/andypetrella/orgs","repos_url":"https://api.github.com/users/andypetrella/repos","events_url":"https://api.github.com/users/andypetrella/events{/privacy}","received_events_url":"https://api.github.com/users/andypetrella/received_events","type":"User","site_admin":false},"body":"I guess that should work too :-)","created_at":"2016-01-18T13:47:39Z","updated_at":"2016-01-18T13:47:39Z","html_url":"https://github.com/andypetrella/spark-notebook/pull/546#discussion_r49999871","pull_request_url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546","_links":{"self":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/comments/49999871"},"html":{"href":"https://github.com/andypetrella/spark-notebook/pull/546#discussion_r49999871"},"pull_request":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546"}}},"pull_request":{"url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546","id":56257338,"html_url":"https://github.com/andypetrella/spark-notebook/pull/546","diff_url":"https://github.com/andypetrella/spark-notebook/pull/546.diff","patch_url":"https://github.com/andypetrella/spark-notebook/pull/546.patch","issue_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues/546","number":546,"state":"open","locked":false,"title":"support SPARK_HOME explicitly in override","user":{"login":"andypetrella","id":663344,"avatar_url":"https://avatars.githubusercontent.com/u/663344?v=3","gravatar_id":"","url":"https://api.github.com/users/andypetrella","html_url":"https://github.com/andypetrella","followers_url":"https://api.github.com/users/andypetrella/followers","following_url":"https://api.github.com/users/andypetrella/following{/other_user}","gists_url":"https://api.github.com/users/andypetrella/gists{/gist_id}","starred_url":"https://api.github.com/users/andypetrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andypetrella/subscriptions","organizations_url":"https://api.github.com/users/andypetrella/orgs","repos_url":"https://api.github.com/users/andypetrella/repos","events_url":"https://api.github.com/users/andypetrella/events{/privacy}","received_events_url":"https://api.github.com/users/andypetrella/received_events","type":"User","site_admin":false},"body":"This PR aims to bring explicit support for `SPARK_HOME` to fetch the defaults values.\r\n\r\nSince the var env are passed to the spawned VM, this shouldn't be required -- However, I saw that defaults wouldn't be loaded if we set only `SPARK_HOME` and not `SPARK_CONF_DIR`.\r\n\r\nThis being said, this PR allows also these configuration to be pre-fetched so it'll still work when we'll spawn VM using a cluster manager like mesos for instance.\r\n\r\n**Note**: this should allow one to use the spark notebook using a distro like cloudera without the pain to configure the spark conf thingies in the `application.conf`.\r\n\r\ncc @vidma @meh-ninja \r\n","created_at":"2016-01-16T16:38:53Z","updated_at":"2016-01-18T13:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bbbff040a3fd9585c6727b7ec330731fd205cf7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546/commits","review_comments_url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546/comments","review_comment_url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues/546/comments","statuses_url":"https://api.github.com/repos/andypetrella/spark-notebook/statuses/a64220edbcd4e7a5b50badd16bd8e9750a3e6044","head":{"label":"andypetrella:features/spark-conf-from-dist","ref":"features/spark-conf-from-dist","sha":"a64220edbcd4e7a5b50badd16bd8e9750a3e6044","user":{"login":"andypetrella","id":663344,"avatar_url":"https://avatars.githubusercontent.com/u/663344?v=3","gravatar_id":"","url":"https://api.github.com/users/andypetrella","html_url":"https://github.com/andypetrella","followers_url":"https://api.github.com/users/andypetrella/followers","following_url":"https://api.github.com/users/andypetrella/following{/other_user}","gists_url":"https://api.github.com/users/andypetrella/gists{/gist_id}","starred_url":"https://api.github.com/users/andypetrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andypetrella/subscriptions","organizations_url":"https://api.github.com/users/andypetrella/orgs","repos_url":"https://api.github.com/users/andypetrella/repos","events_url":"https://api.github.com/users/andypetrella/events{/privacy}","received_events_url":"https://api.github.com/users/andypetrella/received_events","type":"User","site_admin":false},"repo":{"id":23715842,"name":"spark-notebook","full_name":"andypetrella/spark-notebook","owner":{"login":"andypetrella","id":663344,"avatar_url":"https://avatars.githubusercontent.com/u/663344?v=3","gravatar_id":"","url":"https://api.github.com/users/andypetrella","html_url":"https://github.com/andypetrella","followers_url":"https://api.github.com/users/andypetrella/followers","following_url":"https://api.github.com/users/andypetrella/following{/other_user}","gists_url":"https://api.github.com/users/andypetrella/gists{/gist_id}","starred_url":"https://api.github.com/users/andypetrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andypetrella/subscriptions","organizations_url":"https://api.github.com/users/andypetrella/orgs","repos_url":"https://api.github.com/users/andypetrella/repos","events_url":"https://api.github.com/users/andypetrella/events{/privacy}","received_events_url":"https://api.github.com/users/andypetrella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andypetrella/spark-notebook","description":"Use Apache Spark straight from the Browser","fork":false,"url":"https://api.github.com/repos/andypetrella/spark-notebook","forks_url":"https://api.github.com/repos/andypetrella/spark-notebook/forks","keys_url":"https://api.github.com/repos/andypetrella/spark-notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andypetrella/spark-notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andypetrella/spark-notebook/teams","hooks_url":"https://api.github.com/repos/andypetrella/spark-notebook/hooks","issue_events_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues/events{/number}","events_url":"https://api.github.com/repos/andypetrella/spark-notebook/events","assignees_url":"https://api.github.com/repos/andypetrella/spark-notebook/assignees{/user}","branches_url":"https://api.github.com/repos/andypetrella/spark-notebook/branches{/branch}","tags_url":"https://api.github.com/repos/andypetrella/spark-notebook/tags","blobs_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andypetrella/spark-notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/andypetrella/spark-notebook/languages","stargazers_url":"https://api.github.com/repos/andypetrella/spark-notebook/stargazers","contributors_url":"https://api.github.com/repos/andypetrella/spark-notebook/contributors","subscribers_url":"https://api.github.com/repos/andypetrella/spark-notebook/subscribers","subscription_url":"https://api.github.com/repos/andypetrella/spark-notebook/subscription","commits_url":"https://api.github.com/repos/andypetrella/spark-notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/andypetrella/spark-notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/andypetrella/spark-notebook/contents/{+path}","compare_url":"https://api.github.com/repos/andypetrella/spark-notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andypetrella/spark-notebook/merges","archive_url":"https://api.github.com/repos/andypetrella/spark-notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andypetrella/spark-notebook/downloads","issues_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues{/number}","pulls_url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/andypetrella/spark-notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/andypetrella/spark-notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andypetrella/spark-notebook/labels{/name}","releases_url":"https://api.github.com/repos/andypetrella/spark-notebook/releases{/id}","created_at":"2014-09-05T19:35:25Z","updated_at":"2016-01-18T08:58:26Z","pushed_at":"2016-01-18T13:46:48Z","git_url":"git://github.com/andypetrella/spark-notebook.git","ssh_url":"git@github.com:andypetrella/spark-notebook.git","clone_url":"https://github.com/andypetrella/spark-notebook.git","svn_url":"https://github.com/andypetrella/spark-notebook","homepage":"","size":13393,"stargazers_count":905,"watchers_count":905,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":228,"mirror_url":null,"open_issues_count":110,"forks":228,"open_issues":110,"watchers":905,"default_branch":"master"}},"base":{"label":"andypetrella:master","ref":"master","sha":"0b5e9f3e3b6fdcf02f191c29bb8b6e06f9822677","user":{"login":"andypetrella","id":663344,"avatar_url":"https://avatars.githubusercontent.com/u/663344?v=3","gravatar_id":"","url":"https://api.github.com/users/andypetrella","html_url":"https://github.com/andypetrella","followers_url":"https://api.github.com/users/andypetrella/followers","following_url":"https://api.github.com/users/andypetrella/following{/other_user}","gists_url":"https://api.github.com/users/andypetrella/gists{/gist_id}","starred_url":"https://api.github.com/users/andypetrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andypetrella/subscriptions","organizations_url":"https://api.github.com/users/andypetrella/orgs","repos_url":"https://api.github.com/users/andypetrella/repos","events_url":"https://api.github.com/users/andypetrella/events{/privacy}","received_events_url":"https://api.github.com/users/andypetrella/received_events","type":"User","site_admin":false},"repo":{"id":23715842,"name":"spark-notebook","full_name":"andypetrella/spark-notebook","owner":{"login":"andypetrella","id":663344,"avatar_url":"https://avatars.githubusercontent.com/u/663344?v=3","gravatar_id":"","url":"https://api.github.com/users/andypetrella","html_url":"https://github.com/andypetrella","followers_url":"https://api.github.com/users/andypetrella/followers","following_url":"https://api.github.com/users/andypetrella/following{/other_user}","gists_url":"https://api.github.com/users/andypetrella/gists{/gist_id}","starred_url":"https://api.github.com/users/andypetrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andypetrella/subscriptions","organizations_url":"https://api.github.com/users/andypetrella/orgs","repos_url":"https://api.github.com/users/andypetrella/repos","events_url":"https://api.github.com/users/andypetrella/events{/privacy}","received_events_url":"https://api.github.com/users/andypetrella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andypetrella/spark-notebook","description":"Use Apache Spark straight from the Browser","fork":false,"url":"https://api.github.com/repos/andypetrella/spark-notebook","forks_url":"https://api.github.com/repos/andypetrella/spark-notebook/forks","keys_url":"https://api.github.com/repos/andypetrella/spark-notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andypetrella/spark-notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andypetrella/spark-notebook/teams","hooks_url":"https://api.github.com/repos/andypetrella/spark-notebook/hooks","issue_events_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues/events{/number}","events_url":"https://api.github.com/repos/andypetrella/spark-notebook/events","assignees_url":"https://api.github.com/repos/andypetrella/spark-notebook/assignees{/user}","branches_url":"https://api.github.com/repos/andypetrella/spark-notebook/branches{/branch}","tags_url":"https://api.github.com/repos/andypetrella/spark-notebook/tags","blobs_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andypetrella/spark-notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/andypetrella/spark-notebook/languages","stargazers_url":"https://api.github.com/repos/andypetrella/spark-notebook/stargazers","contributors_url":"https://api.github.com/repos/andypetrella/spark-notebook/contributors","subscribers_url":"https://api.github.com/repos/andypetrella/spark-notebook/subscribers","subscription_url":"https://api.github.com/repos/andypetrella/spark-notebook/subscription","commits_url":"https://api.github.com/repos/andypetrella/spark-notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/andypetrella/spark-notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/andypetrella/spark-notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/andypetrella/spark-notebook/contents/{+path}","compare_url":"https://api.github.com/repos/andypetrella/spark-notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andypetrella/spark-notebook/merges","archive_url":"https://api.github.com/repos/andypetrella/spark-notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andypetrella/spark-notebook/downloads","issues_url":"https://api.github.com/repos/andypetrella/spark-notebook/issues{/number}","pulls_url":"https://api.github.com/repos/andypetrella/spark-notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/andypetrella/spark-notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/andypetrella/spark-notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andypetrella/spark-notebook/labels{/name}","releases_url":"https://api.github.com/repos/andypetrella/spark-notebook/releases{/id}","created_at":"2014-09-05T19:35:25Z","updated_at":"2016-01-18T08:58:26Z","pushed_at":"2016-01-18T13:46:48Z","git_url":"git://github.com/andypetrella/spark-notebook.git","ssh_url":"git@github.com:andypetrella/spark-notebook.git","clone_url":"https://github.com/andypetrella/spark-notebook.git","svn_url":"https://github.com/andypetrella/spark-notebook","homepage":"","size":13393,"stargazers_count":905,"watchers_count":905,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":228,"mirror_url":null,"open_issues_count":110,"forks":228,"open_issues":110,"watchers":905,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546"},"html":{"href":"https://github.com/andypetrella/spark-notebook/pull/546"},"issue":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/issues/546"},"comments":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/issues/546/comments"},"review_comments":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546/comments"},"review_comment":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/pulls/546/commits"},"statuses":{"href":"https://api.github.com/repos/andypetrella/spark-notebook/statuses/a64220edbcd4e7a5b50badd16bd8e9750a3e6044"}}}}