{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/12","id":92145669,"html_url":"https://github.com/ShiftForward/adstax-sdk-scala/pull/12","diff_url":"https://github.com/ShiftForward/adstax-sdk-scala/pull/12.diff","patch_url":"https://github.com/ShiftForward/adstax-sdk-scala/pull/12.patch","issue_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/12","number":12,"state":"closed","locked":false,"title":"Improve handling of errors in RPC interfaces","user":{"login":"jcazevedo","id":143188,"avatar_url":"https://avatars.githubusercontent.com/u/143188?v=3","gravatar_id":"","url":"https://api.github.com/users/jcazevedo","html_url":"https://github.com/jcazevedo","followers_url":"https://api.github.com/users/jcazevedo/followers","following_url":"https://api.github.com/users/jcazevedo/following{/other_user}","gists_url":"https://api.github.com/users/jcazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcazevedo/subscriptions","organizations_url":"https://api.github.com/users/jcazevedo/orgs","repos_url":"https://api.github.com/users/jcazevedo/repos","events_url":"https://api.github.com/users/jcazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/jcazevedo/received_events","type":"User","site_admin":false},"body":"This PR improves the handling of errors in RPC interfaces, by introducing the possibility of the server replying with a `Rpc.Error` that results in an exception raised in RPC clients (and a failed `Future`). Some response messages were changed to remove explicit exceptions (or error messages) wrapped in the response.","created_at":"2016-11-03T12:42:27Z","updated_at":"2016-11-04T11:25:40Z","closed_at":"2016-11-04T11:25:40Z","merged_at":"2016-11-04T11:25:40Z","merge_commit_sha":"c1b848a99983a7471fa5408401ec4b59b4b02a9c","assignee":{"login":"belerophon","id":203170,"avatar_url":"https://avatars.githubusercontent.com/u/203170?v=3","gravatar_id":"","url":"https://api.github.com/users/belerophon","html_url":"https://github.com/belerophon","followers_url":"https://api.github.com/users/belerophon/followers","following_url":"https://api.github.com/users/belerophon/following{/other_user}","gists_url":"https://api.github.com/users/belerophon/gists{/gist_id}","starred_url":"https://api.github.com/users/belerophon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belerophon/subscriptions","organizations_url":"https://api.github.com/users/belerophon/orgs","repos_url":"https://api.github.com/users/belerophon/repos","events_url":"https://api.github.com/users/belerophon/events{/privacy}","received_events_url":"https://api.github.com/users/belerophon/received_events","type":"User","site_admin":false},"assignees":[{"login":"belerophon","id":203170,"avatar_url":"https://avatars.githubusercontent.com/u/203170?v=3","gravatar_id":"","url":"https://api.github.com/users/belerophon","html_url":"https://github.com/belerophon","followers_url":"https://api.github.com/users/belerophon/followers","following_url":"https://api.github.com/users/belerophon/following{/other_user}","gists_url":"https://api.github.com/users/belerophon/gists{/gist_id}","starred_url":"https://api.github.com/users/belerophon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belerophon/subscriptions","organizations_url":"https://api.github.com/users/belerophon/orgs","repos_url":"https://api.github.com/users/belerophon/repos","events_url":"https://api.github.com/users/belerophon/events{/privacy}","received_events_url":"https://api.github.com/users/belerophon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/12/comments","statuses_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/021233f2230f5f455f98428f12d616beae5dea68","head":{"label":"ShiftForward:rpc-client-either","ref":"rpc-client-either","sha":"021233f2230f5f455f98428f12d616beae5dea68","user":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"repo":{"id":63863997,"name":"adstax-sdk-scala","full_name":"ShiftForward/adstax-sdk-scala","owner":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ShiftForward/adstax-sdk-scala","description":"Tools for programmatic interaction with an AdStax instance using Scala","fork":false,"url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala","forks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/forks","keys_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/teams","hooks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/hooks","issue_events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/events{/number}","events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/events","assignees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/assignees{/user}","branches_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/branches{/branch}","tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/tags","blobs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/languages","stargazers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/stargazers","contributors_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contributors","subscribers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscribers","subscription_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscription","commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contents/{+path}","compare_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/merges","archive_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/downloads","issues_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues{/number}","pulls_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/labels{/name}","releases_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/releases{/id}","deployments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/deployments","created_at":"2016-07-21T11:32:44Z","updated_at":"2016-10-26T16:23:47Z","pushed_at":"2016-11-04T11:25:40Z","git_url":"git://github.com/ShiftForward/adstax-sdk-scala.git","ssh_url":"git@github.com:ShiftForward/adstax-sdk-scala.git","clone_url":"https://github.com/ShiftForward/adstax-sdk-scala.git","svn_url":"https://github.com/ShiftForward/adstax-sdk-scala","homepage":null,"size":340,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ShiftForward:master","ref":"master","sha":"98a4a6f7bc4795be8e53ab1c0862cafe0b1fb8ed","user":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"repo":{"id":63863997,"name":"adstax-sdk-scala","full_name":"ShiftForward/adstax-sdk-scala","owner":{"login":"ShiftForward","id":930467,"avatar_url":"https://avatars.githubusercontent.com/u/930467?v=3","gravatar_id":"","url":"https://api.github.com/users/ShiftForward","html_url":"https://github.com/ShiftForward","followers_url":"https://api.github.com/users/ShiftForward/followers","following_url":"https://api.github.com/users/ShiftForward/following{/other_user}","gists_url":"https://api.github.com/users/ShiftForward/gists{/gist_id}","starred_url":"https://api.github.com/users/ShiftForward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShiftForward/subscriptions","organizations_url":"https://api.github.com/users/ShiftForward/orgs","repos_url":"https://api.github.com/users/ShiftForward/repos","events_url":"https://api.github.com/users/ShiftForward/events{/privacy}","received_events_url":"https://api.github.com/users/ShiftForward/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ShiftForward/adstax-sdk-scala","description":"Tools for programmatic interaction with an AdStax instance using Scala","fork":false,"url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala","forks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/forks","keys_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/teams","hooks_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/hooks","issue_events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/events{/number}","events_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/events","assignees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/assignees{/user}","branches_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/branches{/branch}","tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/tags","blobs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/{sha}","languages_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/languages","stargazers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/stargazers","contributors_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contributors","subscribers_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscribers","subscription_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/subscription","commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/contents/{+path}","compare_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/merges","archive_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/downloads","issues_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues{/number}","pulls_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls{/number}","milestones_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/milestones{/number}","notifications_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/labels{/name}","releases_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/releases{/id}","deployments_url":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/deployments","created_at":"2016-07-21T11:32:44Z","updated_at":"2016-10-26T16:23:47Z","pushed_at":"2016-11-04T11:25:40Z","git_url":"git://github.com/ShiftForward/adstax-sdk-scala.git","ssh_url":"git@github.com:ShiftForward/adstax-sdk-scala.git","clone_url":"https://github.com/ShiftForward/adstax-sdk-scala.git","svn_url":"https://github.com/ShiftForward/adstax-sdk-scala","homepage":null,"size":340,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/12"},"html":{"href":"https://github.com/ShiftForward/adstax-sdk-scala/pull/12"},"issue":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/12"},"comments":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ShiftForward/adstax-sdk-scala/statuses/021233f2230f5f455f98428f12d616beae5dea68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"belerophon","id":203170,"avatar_url":"https://avatars.githubusercontent.com/u/203170?v=3","gravatar_id":"","url":"https://api.github.com/users/belerophon","html_url":"https://github.com/belerophon","followers_url":"https://api.github.com/users/belerophon/followers","following_url":"https://api.github.com/users/belerophon/following{/other_user}","gists_url":"https://api.github.com/users/belerophon/gists{/gist_id}","starred_url":"https://api.github.com/users/belerophon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belerophon/subscriptions","organizations_url":"https://api.github.com/users/belerophon/orgs","repos_url":"https://api.github.com/users/belerophon/repos","events_url":"https://api.github.com/users/belerophon/events{/privacy}","received_events_url":"https://api.github.com/users/belerophon/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":8,"additions":90,"deletions":219,"changed_files":8}}
{"actor":{"display_login":"belerophon"}}