{"action":"created","comment":{"url":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments/75654565","id":75654565,"diff_hunk":"@@ -0,0 +1,16 @@\n+require 'rrrspec/client/rspec_runner'\n+\n+module RRRSpec\n+  module Client\n+    class RSpecRunnerFactory\n+\n+      def initialize\n+        @runner = RSpecRunner.new\n+      end\n+\n+      def create(file_extension)\n+        return @runner if file_extension == '.rb'","path":"rrrspec-client/lib/rrrspec/client/rspec_runner_factory.rb","position":null,"original_position":12,"commit_id":"0f1e5f55346df98c063169aaf43399a0d771765f","original_commit_id":"90359c3e34d4896baa4383270e0a225033c3d47c","user":{"login":"jrluis","id":617053,"avatar_url":"https://avatars.githubusercontent.com/u/617053?v=3","gravatar_id":"","url":"https://api.github.com/users/jrluis","html_url":"https://github.com/jrluis","followers_url":"https://api.github.com/users/jrluis/followers","following_url":"https://api.github.com/users/jrluis/following{/other_user}","gists_url":"https://api.github.com/users/jrluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jrluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrluis/subscriptions","organizations_url":"https://api.github.com/users/jrluis/orgs","repos_url":"https://api.github.com/users/jrluis/repos","events_url":"https://api.github.com/users/jrluis/events{/privacy}","received_events_url":"https://api.github.com/users/jrluis/received_events","type":"User","site_admin":false},"body":"Removed the factories as the they don't make sense having the registration by file extension.","created_at":"2016-08-22T10:36:30Z","updated_at":"2016-08-22T10:36:30Z","html_url":"https://github.com/cookpad/rrrspec/pull/62#discussion_r75654565","pull_request_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments/75654565"},"html":{"href":"https://github.com/cookpad/rrrspec/pull/62#discussion_r75654565"},"pull_request":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/cookpad/rrrspec/pulls/62","id":79343944,"html_url":"https://github.com/cookpad/rrrspec/pull/62","diff_url":"https://github.com/cookpad/rrrspec/pull/62.diff","patch_url":"https://github.com/cookpad/rrrspec/pull/62.patch","issue_url":"https://api.github.com/repos/cookpad/rrrspec/issues/62","number":62,"state":"open","locked":false,"title":"add support for registering runners","user":{"login":"jrluis","id":617053,"avatar_url":"https://avatars.githubusercontent.com/u/617053?v=3","gravatar_id":"","url":"https://api.github.com/users/jrluis","html_url":"https://github.com/jrluis","followers_url":"https://api.github.com/users/jrluis/followers","following_url":"https://api.github.com/users/jrluis/following{/other_user}","gists_url":"https://api.github.com/users/jrluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jrluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrluis/subscriptions","organizations_url":"https://api.github.com/users/jrluis/orgs","repos_url":"https://api.github.com/users/jrluis/repos","events_url":"https://api.github.com/users/jrluis/events{/privacy}","received_events_url":"https://api.github.com/users/jrluis/received_events","type":"User","site_admin":false},"body":"This runs cucumber tests mixed with rspec tests.\r\n\r\nTo add the cucumber plugin add rrrspec-cucumber to your gemfile\r\n\r\n```\r\ngem 'rrrspec-cucumber'\r\n```\r\n\r\nThen in .rrrspec configure the runner chain to include rrrspec-cucumber\r\n\r\n```\r\nrequire 'rrrspec/cucumber'\r\n\r\nRRRSpec::Registry.register_runner_factory RRRSpec::Cucumber::CucumberRunnerFactory.new\r\n\r\n```\r\n\r\nYou can checkout the plugin code at https://github.com/Seedrs/rrrspec-cucumber\r\n\r\nFor the slave to load the .rrrspec configuration the slave command also has to be changed\r\n\r\n```\r\n  conf.slave_command = <<-SLAVE\r\n    bundle exec rrrspec-client slave --config .rrrspec\r\n  SLAVE\r\n\r\n```\r\n\r\nFinally, add cucumber to a rails project and in .rrrspec also select the .features\r\n\r\n  ```\r\nconf.spec_files = lambda do\r\n    Dir.chdir(conf.packaging_dir) do\r\n        Dir['features/**{,/*/**}/*.feature'].uniq\r\n    end\r\nend\r\n```\r\n","created_at":"2016-07-29T11:14:17Z","updated_at":"2016-08-22T10:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f45e85cdce053a49aa5135e9d914d368b32f7c7b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/62/commits","review_comments_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/62/comments","review_comment_url":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cookpad/rrrspec/issues/62/comments","statuses_url":"https://api.github.com/repos/cookpad/rrrspec/statuses/0f1e5f55346df98c063169aaf43399a0d771765f","head":{"label":"jrluis:cucumber-support","ref":"cucumber-support","sha":"0f1e5f55346df98c063169aaf43399a0d771765f","user":{"login":"jrluis","id":617053,"avatar_url":"https://avatars.githubusercontent.com/u/617053?v=3","gravatar_id":"","url":"https://api.github.com/users/jrluis","html_url":"https://github.com/jrluis","followers_url":"https://api.github.com/users/jrluis/followers","following_url":"https://api.github.com/users/jrluis/following{/other_user}","gists_url":"https://api.github.com/users/jrluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jrluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrluis/subscriptions","organizations_url":"https://api.github.com/users/jrluis/orgs","repos_url":"https://api.github.com/users/jrluis/repos","events_url":"https://api.github.com/users/jrluis/events{/privacy}","received_events_url":"https://api.github.com/users/jrluis/received_events","type":"User","site_admin":false},"repo":{"id":61615523,"name":"rrrspec","full_name":"jrluis/rrrspec","owner":{"login":"jrluis","id":617053,"avatar_url":"https://avatars.githubusercontent.com/u/617053?v=3","gravatar_id":"","url":"https://api.github.com/users/jrluis","html_url":"https://github.com/jrluis","followers_url":"https://api.github.com/users/jrluis/followers","following_url":"https://api.github.com/users/jrluis/following{/other_user}","gists_url":"https://api.github.com/users/jrluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jrluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrluis/subscriptions","organizations_url":"https://api.github.com/users/jrluis/orgs","repos_url":"https://api.github.com/users/jrluis/repos","events_url":"https://api.github.com/users/jrluis/events{/privacy}","received_events_url":"https://api.github.com/users/jrluis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrluis/rrrspec","description":"Distributed RSpec","fork":true,"url":"https://api.github.com/repos/jrluis/rrrspec","forks_url":"https://api.github.com/repos/jrluis/rrrspec/forks","keys_url":"https://api.github.com/repos/jrluis/rrrspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrluis/rrrspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrluis/rrrspec/teams","hooks_url":"https://api.github.com/repos/jrluis/rrrspec/hooks","issue_events_url":"https://api.github.com/repos/jrluis/rrrspec/issues/events{/number}","events_url":"https://api.github.com/repos/jrluis/rrrspec/events","assignees_url":"https://api.github.com/repos/jrluis/rrrspec/assignees{/user}","branches_url":"https://api.github.com/repos/jrluis/rrrspec/branches{/branch}","tags_url":"https://api.github.com/repos/jrluis/rrrspec/tags","blobs_url":"https://api.github.com/repos/jrluis/rrrspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrluis/rrrspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrluis/rrrspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrluis/rrrspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrluis/rrrspec/statuses/{sha}","languages_url":"https://api.github.com/repos/jrluis/rrrspec/languages","stargazers_url":"https://api.github.com/repos/jrluis/rrrspec/stargazers","contributors_url":"https://api.github.com/repos/jrluis/rrrspec/contributors","subscribers_url":"https://api.github.com/repos/jrluis/rrrspec/subscribers","subscription_url":"https://api.github.com/repos/jrluis/rrrspec/subscription","commits_url":"https://api.github.com/repos/jrluis/rrrspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrluis/rrrspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrluis/rrrspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrluis/rrrspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrluis/rrrspec/contents/{+path}","compare_url":"https://api.github.com/repos/jrluis/rrrspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrluis/rrrspec/merges","archive_url":"https://api.github.com/repos/jrluis/rrrspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrluis/rrrspec/downloads","issues_url":"https://api.github.com/repos/jrluis/rrrspec/issues{/number}","pulls_url":"https://api.github.com/repos/jrluis/rrrspec/pulls{/number}","milestones_url":"https://api.github.com/repos/jrluis/rrrspec/milestones{/number}","notifications_url":"https://api.github.com/repos/jrluis/rrrspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrluis/rrrspec/labels{/name}","releases_url":"https://api.github.com/repos/jrluis/rrrspec/releases{/id}","deployments_url":"https://api.github.com/repos/jrluis/rrrspec/deployments","created_at":"2016-06-21T08:17:02Z","updated_at":"2016-06-21T08:17:04Z","pushed_at":"2016-08-22T10:33:53Z","git_url":"git://github.com/jrluis/rrrspec.git","ssh_url":"git@github.com:jrluis/rrrspec.git","clone_url":"https://github.com/jrluis/rrrspec.git","svn_url":"https://github.com/jrluis/rrrspec","homepage":"","size":1065,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cookpad:master","ref":"master","sha":"318679c449f0b9d1649189ff5eabc8e00c3557d3","user":{"login":"cookpad","id":119195,"avatar_url":"https://avatars.githubusercontent.com/u/119195?v=3","gravatar_id":"","url":"https://api.github.com/users/cookpad","html_url":"https://github.com/cookpad","followers_url":"https://api.github.com/users/cookpad/followers","following_url":"https://api.github.com/users/cookpad/following{/other_user}","gists_url":"https://api.github.com/users/cookpad/gists{/gist_id}","starred_url":"https://api.github.com/users/cookpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cookpad/subscriptions","organizations_url":"https://api.github.com/users/cookpad/orgs","repos_url":"https://api.github.com/users/cookpad/repos","events_url":"https://api.github.com/users/cookpad/events{/privacy}","received_events_url":"https://api.github.com/users/cookpad/received_events","type":"Organization","site_admin":false},"repo":{"id":16797453,"name":"rrrspec","full_name":"cookpad/rrrspec","owner":{"login":"cookpad","id":119195,"avatar_url":"https://avatars.githubusercontent.com/u/119195?v=3","gravatar_id":"","url":"https://api.github.com/users/cookpad","html_url":"https://github.com/cookpad","followers_url":"https://api.github.com/users/cookpad/followers","following_url":"https://api.github.com/users/cookpad/following{/other_user}","gists_url":"https://api.github.com/users/cookpad/gists{/gist_id}","starred_url":"https://api.github.com/users/cookpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cookpad/subscriptions","organizations_url":"https://api.github.com/users/cookpad/orgs","repos_url":"https://api.github.com/users/cookpad/repos","events_url":"https://api.github.com/users/cookpad/events{/privacy}","received_events_url":"https://api.github.com/users/cookpad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cookpad/rrrspec","description":"Distributed RSpec","fork":false,"url":"https://api.github.com/repos/cookpad/rrrspec","forks_url":"https://api.github.com/repos/cookpad/rrrspec/forks","keys_url":"https://api.github.com/repos/cookpad/rrrspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cookpad/rrrspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cookpad/rrrspec/teams","hooks_url":"https://api.github.com/repos/cookpad/rrrspec/hooks","issue_events_url":"https://api.github.com/repos/cookpad/rrrspec/issues/events{/number}","events_url":"https://api.github.com/repos/cookpad/rrrspec/events","assignees_url":"https://api.github.com/repos/cookpad/rrrspec/assignees{/user}","branches_url":"https://api.github.com/repos/cookpad/rrrspec/branches{/branch}","tags_url":"https://api.github.com/repos/cookpad/rrrspec/tags","blobs_url":"https://api.github.com/repos/cookpad/rrrspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cookpad/rrrspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cookpad/rrrspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/cookpad/rrrspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cookpad/rrrspec/statuses/{sha}","languages_url":"https://api.github.com/repos/cookpad/rrrspec/languages","stargazers_url":"https://api.github.com/repos/cookpad/rrrspec/stargazers","contributors_url":"https://api.github.com/repos/cookpad/rrrspec/contributors","subscribers_url":"https://api.github.com/repos/cookpad/rrrspec/subscribers","subscription_url":"https://api.github.com/repos/cookpad/rrrspec/subscription","commits_url":"https://api.github.com/repos/cookpad/rrrspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/cookpad/rrrspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/cookpad/rrrspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/cookpad/rrrspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/cookpad/rrrspec/contents/{+path}","compare_url":"https://api.github.com/repos/cookpad/rrrspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cookpad/rrrspec/merges","archive_url":"https://api.github.com/repos/cookpad/rrrspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cookpad/rrrspec/downloads","issues_url":"https://api.github.com/repos/cookpad/rrrspec/issues{/number}","pulls_url":"https://api.github.com/repos/cookpad/rrrspec/pulls{/number}","milestones_url":"https://api.github.com/repos/cookpad/rrrspec/milestones{/number}","notifications_url":"https://api.github.com/repos/cookpad/rrrspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cookpad/rrrspec/labels{/name}","releases_url":"https://api.github.com/repos/cookpad/rrrspec/releases{/id}","deployments_url":"https://api.github.com/repos/cookpad/rrrspec/deployments","created_at":"2014-02-13T09:06:44Z","updated_at":"2016-07-21T06:21:08Z","pushed_at":"2016-08-22T10:33:53Z","git_url":"git://github.com/cookpad/rrrspec.git","ssh_url":"git@github.com:cookpad/rrrspec.git","clone_url":"https://github.com/cookpad/rrrspec.git","svn_url":"https://github.com/cookpad/rrrspec","homepage":"","size":1066,"stargazers_count":355,"watchers_count":355,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":7,"forks":17,"open_issues":7,"watchers":355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/62"},"html":{"href":"https://github.com/cookpad/rrrspec/pull/62"},"issue":{"href":"https://api.github.com/repos/cookpad/rrrspec/issues/62"},"comments":{"href":"https://api.github.com/repos/cookpad/rrrspec/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cookpad/rrrspec/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/cookpad/rrrspec/statuses/0f1e5f55346df98c063169aaf43399a0d771765f"}}}}
{"actor":{"display_login":"jrluis"}}