{"action":"created","comment":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/81733759","pull_request_review_id":2690876,"id":81733759,"diff_hunk":"@@ -530,6 +530,20 @@\n     trigger_error($error, E_USER_ERROR);\n }\n \n+/**\n+ * As we try to handle charsets by ourself, mbstring overloads just\n+ * break it, see bug 1063821.\n+ */\n+if (@extension_loaded('mbstring') && @ini_get('mbstring.func_overload') != '0') {","path":"libraries/common.inc.php","position":8,"original_position":8,"commit_id":"4055eb9162006111bd33964535a076b87d2a4d6f","original_commit_id":"4055eb9162006111bd33964535a076b87d2a4d6f","user":{"login":"nijel","id":212189,"avatar_url":"https://avatars.githubusercontent.com/u/212189?v=3","gravatar_id":"","url":"https://api.github.com/users/nijel","html_url":"https://github.com/nijel","followers_url":"https://api.github.com/users/nijel/followers","following_url":"https://api.github.com/users/nijel/following{/other_user}","gists_url":"https://api.github.com/users/nijel/gists{/gist_id}","starred_url":"https://api.github.com/users/nijel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijel/subscriptions","organizations_url":"https://api.github.com/users/nijel/orgs","repos_url":"https://api.github.com/users/nijel/repos","events_url":"https://api.github.com/users/nijel/events{/privacy}","received_events_url":"https://api.github.com/users/nijel/received_events","type":"User","site_admin":false},"body":"Note that this is intentionally stricter than previous check. I really don't think anybody should enable this setting system wide.","created_at":"2016-10-04T11:12:19Z","updated_at":"2016-10-04T11:12:19Z","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/12616#discussion_r81733759","pull_request_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616","_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments/81733759"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/12616#discussion_r81733759"},"pull_request":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616"}}},"pull_request":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616","id":87873158,"html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/12616","diff_url":"https://github.com/phpmyadmin/phpmyadmin/pull/12616.diff","patch_url":"https://github.com/phpmyadmin/phpmyadmin/pull/12616.patch","issue_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12616","number":12616,"state":"open","locked":false,"title":"Refuse to work with mbstring.func_overload enabled","user":{"login":"nijel","id":212189,"avatar_url":"https://avatars.githubusercontent.com/u/212189?v=3","gravatar_id":"","url":"https://api.github.com/users/nijel","html_url":"https://github.com/nijel","followers_url":"https://api.github.com/users/nijel/followers","following_url":"https://api.github.com/users/nijel/following{/other_user}","gists_url":"https://api.github.com/users/nijel/gists{/gist_id}","starred_url":"https://api.github.com/users/nijel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijel/subscriptions","organizations_url":"https://api.github.com/users/nijel/orgs","repos_url":"https://api.github.com/users/nijel/repos","events_url":"https://api.github.com/users/nijel/events{/privacy}","received_events_url":"https://api.github.com/users/nijel/received_events","type":"User","site_admin":false},"body":"Before submitting pull request, please check that every commit:\r\n\r\n- [x] Has proper Signed-Off-By\r\n- [x] Has commit message which describes it\r\n- [x] Is needed on it's own, if you have just minor fixes to previous commits, you can squash them\r\n- [x] Any new functionality is covered by tests\r\n\r\nIn several places our code assumes that strlen does return length in\r\nbytes and not in chars. This can be different with\r\nmbstring.func_overload and will lead to several hard to debug breakages.\r\nTherefore it's safer to simply deny using phpMyAdmin with this setting.\r\n\r\nSigned-off-by: Michal Čihař <michal@cihar.com>","created_at":"2016-10-04T11:04:43Z","updated_at":"2016-10-04T11:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90fb643c3f70dca4d8eb0cde5bdf529d54752cd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616/commits","review_comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616/comments","review_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12616/comments","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/4055eb9162006111bd33964535a076b87d2a4d6f","head":{"label":"nijel:mbstring.func_overload","ref":"mbstring.func_overload","sha":"4055eb9162006111bd33964535a076b87d2a4d6f","user":{"login":"nijel","id":212189,"avatar_url":"https://avatars.githubusercontent.com/u/212189?v=3","gravatar_id":"","url":"https://api.github.com/users/nijel","html_url":"https://github.com/nijel","followers_url":"https://api.github.com/users/nijel/followers","following_url":"https://api.github.com/users/nijel/following{/other_user}","gists_url":"https://api.github.com/users/nijel/gists{/gist_id}","starred_url":"https://api.github.com/users/nijel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijel/subscriptions","organizations_url":"https://api.github.com/users/nijel/orgs","repos_url":"https://api.github.com/users/nijel/repos","events_url":"https://api.github.com/users/nijel/events{/privacy}","received_events_url":"https://api.github.com/users/nijel/received_events","type":"User","site_admin":false},"repo":{"id":3993712,"name":"phpmyadmin","full_name":"nijel/phpmyadmin","owner":{"login":"nijel","id":212189,"avatar_url":"https://avatars.githubusercontent.com/u/212189?v=3","gravatar_id":"","url":"https://api.github.com/users/nijel","html_url":"https://github.com/nijel","followers_url":"https://api.github.com/users/nijel/followers","following_url":"https://api.github.com/users/nijel/following{/other_user}","gists_url":"https://api.github.com/users/nijel/gists{/gist_id}","starred_url":"https://api.github.com/users/nijel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijel/subscriptions","organizations_url":"https://api.github.com/users/nijel/orgs","repos_url":"https://api.github.com/users/nijel/repos","events_url":"https://api.github.com/users/nijel/events{/privacy}","received_events_url":"https://api.github.com/users/nijel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nijel/phpmyadmin","description":"phpMyAdmin itself","fork":true,"url":"https://api.github.com/repos/nijel/phpmyadmin","forks_url":"https://api.github.com/repos/nijel/phpmyadmin/forks","keys_url":"https://api.github.com/repos/nijel/phpmyadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nijel/phpmyadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nijel/phpmyadmin/teams","hooks_url":"https://api.github.com/repos/nijel/phpmyadmin/hooks","issue_events_url":"https://api.github.com/repos/nijel/phpmyadmin/issues/events{/number}","events_url":"https://api.github.com/repos/nijel/phpmyadmin/events","assignees_url":"https://api.github.com/repos/nijel/phpmyadmin/assignees{/user}","branches_url":"https://api.github.com/repos/nijel/phpmyadmin/branches{/branch}","tags_url":"https://api.github.com/repos/nijel/phpmyadmin/tags","blobs_url":"https://api.github.com/repos/nijel/phpmyadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nijel/phpmyadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nijel/phpmyadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nijel/phpmyadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nijel/phpmyadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/nijel/phpmyadmin/languages","stargazers_url":"https://api.github.com/repos/nijel/phpmyadmin/stargazers","contributors_url":"https://api.github.com/repos/nijel/phpmyadmin/contributors","subscribers_url":"https://api.github.com/repos/nijel/phpmyadmin/subscribers","subscription_url":"https://api.github.com/repos/nijel/phpmyadmin/subscription","commits_url":"https://api.github.com/repos/nijel/phpmyadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nijel/phpmyadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nijel/phpmyadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nijel/phpmyadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nijel/phpmyadmin/contents/{+path}","compare_url":"https://api.github.com/repos/nijel/phpmyadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nijel/phpmyadmin/merges","archive_url":"https://api.github.com/repos/nijel/phpmyadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nijel/phpmyadmin/downloads","issues_url":"https://api.github.com/repos/nijel/phpmyadmin/issues{/number}","pulls_url":"https://api.github.com/repos/nijel/phpmyadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/nijel/phpmyadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/nijel/phpmyadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nijel/phpmyadmin/labels{/name}","releases_url":"https://api.github.com/repos/nijel/phpmyadmin/releases{/id}","deployments_url":"https://api.github.com/repos/nijel/phpmyadmin/deployments","created_at":"2012-04-11T13:23:13Z","updated_at":"2015-05-18T10:44:51Z","pushed_at":"2016-10-04T11:06:10Z","git_url":"git://github.com/nijel/phpmyadmin.git","ssh_url":"git@github.com:nijel/phpmyadmin.git","clone_url":"https://github.com/nijel/phpmyadmin.git","svn_url":"https://github.com/nijel/phpmyadmin","homepage":"http://www.phpmyadmin.net/","size":404842,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"phpmyadmin:QA_4_6","ref":"QA_4_6","sha":"a7786dd93a5ce1ee6a6026864275bb5b753b87ae","user":{"login":"phpmyadmin","id":1351977,"avatar_url":"https://avatars.githubusercontent.com/u/1351977?v=3","gravatar_id":"","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":3217621,"name":"phpmyadmin","full_name":"phpmyadmin/phpmyadmin","owner":{"login":"phpmyadmin","id":1351977,"avatar_url":"https://avatars.githubusercontent.com/u/1351977?v=3","gravatar_id":"","url":"https://api.github.com/users/phpmyadmin","html_url":"https://github.com/phpmyadmin","followers_url":"https://api.github.com/users/phpmyadmin/followers","following_url":"https://api.github.com/users/phpmyadmin/following{/other_user}","gists_url":"https://api.github.com/users/phpmyadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/phpmyadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpmyadmin/subscriptions","organizations_url":"https://api.github.com/users/phpmyadmin/orgs","repos_url":"https://api.github.com/users/phpmyadmin/repos","events_url":"https://api.github.com/users/phpmyadmin/events{/privacy}","received_events_url":"https://api.github.com/users/phpmyadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpmyadmin/phpmyadmin","description":"phpMyAdmin","fork":false,"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin","forks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/forks","keys_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/teams","hooks_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/hooks","issue_events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/events{/number}","events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/events","assignees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/assignees{/user}","branches_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/branches{/branch}","tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/tags","blobs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/languages","stargazers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/stargazers","contributors_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contributors","subscribers_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscribers","subscription_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/subscription","commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/contents/{+path}","compare_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/merges","archive_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/downloads","issues_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues{/number}","pulls_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/labels{/name}","releases_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/releases{/id}","deployments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/deployments","created_at":"2012-01-19T13:21:52Z","updated_at":"2016-10-03T18:07:26Z","pushed_at":"2016-10-04T11:06:10Z","git_url":"git://github.com/phpmyadmin/phpmyadmin.git","ssh_url":"git@github.com:phpmyadmin/phpmyadmin.git","clone_url":"https://github.com/phpmyadmin/phpmyadmin.git","svn_url":"https://github.com/phpmyadmin/phpmyadmin","homepage":"https://www.phpmyadmin.net/","size":528507,"stargazers_count":1861,"watchers_count":1861,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1085,"mirror_url":null,"open_issues_count":192,"forks":1085,"open_issues":192,"watchers":1861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616"},"html":{"href":"https://github.com/phpmyadmin/phpmyadmin/pull/12616"},"issue":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12616"},"comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/12616/comments"},"review_comments":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616/comments"},"review_comment":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/12616/commits"},"statuses":{"href":"https://api.github.com/repos/phpmyadmin/phpmyadmin/statuses/4055eb9162006111bd33964535a076b87d2a4d6f"}}}}
{"actor":{"display_login":"nijel"}}