{"action":"created","issue":{"url":"https://api.github.com/repos/ScaleChain/scalechain/issues/93","repository_url":"https://api.github.com/repos/ScaleChain/scalechain","labels_url":"https://api.github.com/repos/ScaleChain/scalechain/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/ScaleChain/scalechain/issues/93/comments","events_url":"https://api.github.com/repos/ScaleChain/scalechain/issues/93/events","html_url":"https://github.com/ScaleChain/scalechain/issues/93","id":164712686,"number":93,"title":"Add protobuf encoder/decoder for better performance.","user":{"login":"Kangmo","id":510271,"avatar_url":"https://avatars.githubusercontent.com/u/510271?v=3","gravatar_id":"","url":"https://api.github.com/users/Kangmo","html_url":"https://github.com/Kangmo","followers_url":"https://api.github.com/users/Kangmo/followers","following_url":"https://api.github.com/users/Kangmo/following{/other_user}","gists_url":"https://api.github.com/users/Kangmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Kangmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kangmo/subscriptions","organizations_url":"https://api.github.com/users/Kangmo/orgs","repos_url":"https://api.github.com/users/Kangmo/repos","events_url":"https://api.github.com/users/Kangmo/events{/privacy}","received_events_url":"https://api.github.com/users/Kangmo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-07-10T12:07:23Z","updated_at":"2016-07-11T04:19:57Z","closed_at":null,"body":"## What\r\nNeed to add a new implementation of proto-codec layer using protobuf.\r\n\r\n## Why\r\nThrift is also an option, but lacks documentation. Google protobuf provides smaller encoded data size, as well as better performance when optimised for speed.\r\n\r\n## How\r\n1. Start coding using protobuf ;-)\r\n2. Meet mountains.\r\n3. Climb mountains.\r\n4. Conquer the big mountain. ;-)))\r\n\r\nBTW, we need to keep the current implementation with scodec to keep the compatibility with Bitcoin.\r\nNon-Goal : Keep compatibility with Bitcoin for the protobuf implementation of proto-codec"},"comment":{"url":"https://api.github.com/repos/ScaleChain/scalechain/issues/comments/231639167","html_url":"https://github.com/ScaleChain/scalechain/issues/93#issuecomment-231639167","issue_url":"https://api.github.com/repos/ScaleChain/scalechain/issues/93","id":231639167,"user":{"login":"Kangmo","id":510271,"avatar_url":"https://avatars.githubusercontent.com/u/510271?v=3","gravatar_id":"","url":"https://api.github.com/users/Kangmo","html_url":"https://github.com/Kangmo","followers_url":"https://api.github.com/users/Kangmo/followers","following_url":"https://api.github.com/users/Kangmo/following{/other_user}","gists_url":"https://api.github.com/users/Kangmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Kangmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kangmo/subscriptions","organizations_url":"https://api.github.com/users/Kangmo/orgs","repos_url":"https://api.github.com/users/Kangmo/repos","events_url":"https://api.github.com/users/Kangmo/events{/privacy}","received_events_url":"https://api.github.com/users/Kangmo/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T04:19:57Z","updated_at":"2016-07-11T04:19:57Z","body":"Thanks Thrift. Thrift does not support struct inheritance, which I need. \r\nNo need to investigate Thrift. \r\n\r\nhttps://wiki.apache.org/thrift/FAQ\r\n```\r\nIs struct inheritance supported?\r\n\r\nNo, it isn't. Thrift support inheritance of service interfaces, but only composition/containment for structures.\r\n```"}}
{"actor":{"display_login":"Kangmo"}}