{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/16383","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/16383/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/16383/comments","events_url":"https://api.github.com/repos/apache/spark/issues/16383/events","html_url":"https://github.com/apache/spark/pull/16383","id":197162349,"number":16383,"title":"[SPARK-18980][SQL] implement Aggregator with TypedImperativeAggregate","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-22T12:16:37Z","updated_at":"2016-12-22T14:44:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16383","html_url":"https://github.com/apache/spark/pull/16383","diff_url":"https://github.com/apache/spark/pull/16383.diff","patch_url":"https://github.com/apache/spark/pull/16383.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nCurrently we implement `Aggregator` with `DeclarativeAggregate`, which will serialize/deserialize the buffer object every time we process an input.\r\n\r\nThis PR implements `Aggregator` with `TypedImperativeAggregate` and avoids to serialize/deserialize many times. The benchmark shows we get about 2 times speed up.\r\n\r\nFor simple buffer object that doesn't need serialization, we still go with `DeclarativeAggregate`, to avoid performance regression.\r\n\r\n## How was this patch tested?\r\n\r\nN/A"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/268813537","html_url":"https://github.com/apache/spark/pull/16383#issuecomment-268813537","issue_url":"https://api.github.com/repos/apache/spark/issues/16383","id":268813537,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T14:44:31Z","updated_at":"2016-12-22T14:44:31Z","body":"Merged build finished. Test PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}