{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/92839435","pull_request_review_id":13362679,"id":92839435,"diff_hunk":"@@ -0,0 +1,24 @@\n+package net.corda.vega\n+\n+class SimmValuationTest: IntegrationTestCategory {\n+\n+    @Test fun `runs SIMM valuation demo`() {\n+        driver(isDebug = true) {\n+            val controller = startNode(\"Controller\", setOf(ServiceInfo(SimpleNotaryService.type))).getOrThrow()\n+            val nodeA = startNode(\"Bank A\").getOrThrow()\n+            val nodeB = startNode(\"Bank B\").getOrThrow()\n+            assert(createTrade())\n+            assert(runValuations())\n+        }\n+    }\n+\n+    // TODO: create, verify, run, verify or determine a better test structure.\n+    private fun createTrade(): Boolean {\n+\n+    }\n+\n+    private fun runValuations(): Boolean {\n+","path":"samples/simm-valuation-demo/src/integration-test/kotlin/net/corda/vega/SimmValuationTest.kt","position":null,"original_position":21,"commit_id":"fa1e7cfa1596ba72526c306ab14bd126fde5cbfb","original_commit_id":"2334824a734ff13d7477a850f24de2a0510c180d","user":{"login":"ragmondo","id":616888,"avatar_url":"https://avatars.githubusercontent.com/u/616888?v=3","gravatar_id":"","url":"https://api.github.com/users/ragmondo","html_url":"https://github.com/ragmondo","followers_url":"https://api.github.com/users/ragmondo/followers","following_url":"https://api.github.com/users/ragmondo/following{/other_user}","gists_url":"https://api.github.com/users/ragmondo/gists{/gist_id}","starred_url":"https://api.github.com/users/ragmondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragmondo/subscriptions","organizations_url":"https://api.github.com/users/ragmondo/orgs","repos_url":"https://api.github.com/users/ragmondo/repos","events_url":"https://api.github.com/users/ragmondo/events{/privacy}","received_events_url":"https://api.github.com/users/ragmondo/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2016-12-16T16:18:49Z","updated_at":"2016-12-16T16:18:49Z","html_url":"https://github.com/corda/corda/pull/72#discussion_r92839435","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/92839435"},"html":{"href":"https://github.com/corda/corda/pull/72#discussion_r92839435"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/72","id":98348100,"html_url":"https://github.com/corda/corda/pull/72","diff_url":"https://github.com/corda/corda/pull/72.diff","patch_url":"https://github.com/corda/corda/pull/72.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/72","number":72,"state":"open","locked":false,"title":"Add SIMM valuation demo integration test","user":{"login":"Clintonio","id":474659,"avatar_url":"https://avatars.githubusercontent.com/u/474659?v=3","gravatar_id":"","url":"https://api.github.com/users/Clintonio","html_url":"https://github.com/Clintonio","followers_url":"https://api.github.com/users/Clintonio/followers","following_url":"https://api.github.com/users/Clintonio/following{/other_user}","gists_url":"https://api.github.com/users/Clintonio/gists{/gist_id}","starred_url":"https://api.github.com/users/Clintonio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clintonio/subscriptions","organizations_url":"https://api.github.com/users/Clintonio/orgs","repos_url":"https://api.github.com/users/Clintonio/repos","events_url":"https://api.github.com/users/Clintonio/events{/privacy}","received_events_url":"https://api.github.com/users/Clintonio/received_events","type":"User","site_admin":false},"body":"Changes:\r\n\r\n* Added getJson to HTTP and API utilities.\r\n* Modified JSON support to allow other Jackson serialisers to be created (without identityservice built in)\r\n* Added a passing integration test for SIMM valuation demo that tests the creation of trades, valuations touching a majority of the endpoints.","created_at":"2016-12-16T14:58:13Z","updated_at":"2016-12-16T16:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8cd7f0f93dc4d81470c9d2fd29b137ac472114d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/72/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/72/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/72/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/fa1e7cfa1596ba72526c306ab14bd126fde5cbfb","head":{"label":"corda:clint-simmdemointegrationtest","ref":"clint-simmdemointegrationtest","sha":"fa1e7cfa1596ba72526c306ab14bd126fde5cbfb","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions, it offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2016-12-16T13:52:03Z","pushed_at":"2016-12-16T15:48:53Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":52476,"stargazers_count":358,"watchers_count":358,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":13,"forks":97,"open_issues":13,"watchers":358,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"f44dd969ce1bea553820396992932d0f65cdbe10","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions, it offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2016-12-16T13:52:03Z","pushed_at":"2016-12-16T15:48:53Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":52476,"stargazers_count":358,"watchers_count":358,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":13,"forks":97,"open_issues":13,"watchers":358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/72"},"html":{"href":"https://github.com/corda/corda/pull/72"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/72"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/fa1e7cfa1596ba72526c306ab14bd126fde5cbfb"}}}}
{"actor":{"display_login":"ragmondo"}}