{"action":"opened","number":60,"pull_request":{"url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/60","id":74081668,"html_url":"https://github.com/mattrayner/cordova-plugin-vuforia/pull/60","diff_url":"https://github.com/mattrayner/cordova-plugin-vuforia/pull/60.diff","patch_url":"https://github.com/mattrayner/cordova-plugin-vuforia/pull/60.patch","issue_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/issues/60","number":60,"state":"open","locked":false,"title":"Options parameter and new overlay","user":{"login":"Stending","id":14004383,"avatar_url":"https://avatars.githubusercontent.com/u/14004383?v=3","gravatar_id":"","url":"https://api.github.com/users/Stending","html_url":"https://github.com/Stending","followers_url":"https://api.github.com/users/Stending/followers","following_url":"https://api.github.com/users/Stending/following{/other_user}","gists_url":"https://api.github.com/users/Stending/gists{/gist_id}","starred_url":"https://api.github.com/users/Stending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stending/subscriptions","organizations_url":"https://api.github.com/users/Stending/orgs","repos_url":"https://api.github.com/users/Stending/repos","events_url":"https://api.github.com/users/Stending/events{/privacy}","received_events_url":"https://api.github.com/users/Stending/received_events","type":"User","site_admin":false},"body":"## Description\r\nBased on the refactor_options branch #45 by @nleclerc.\r\nThe overlay was improved, it is now a bit more organized and flexible.\r\n\r\nThe devices icon is now disabled by default, but, only on android, you can display it by adding a boolean parameter \"devicesIconVisible\" to the options object, and set it to true.\r\nIt doesn't work on iOS because there is no proper way to send overlay options to the ImageTargetsViewController, for now. Might be a future pull request.\r\n\r\nAn android InApp close button is now available. It is disabled by default to, but you can enable it with the parameter showAndroidCloseButton to true.\r\n\r\n## Motivation and Context\r\nA InApp close button on android can be useful for app disabling the back button, like our.\r\nA more stable and customizable overlay is useful to. It fits more with our app, and is a bit more generic.\r\n\r\n## How Has This Been Tested?\r\nTested on an iPod Touch and a Galaxy S2.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [] My change requires a change to the documentation.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n","created_at":"2016-06-16T13:36:19Z","updated_at":"2016-06-16T13:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c0cc3eb24b340b0b5e76cfbfcdbf02d3a41a693","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/60/commits","review_comments_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/60/comments","review_comment_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/issues/60/comments","statuses_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/statuses/1744ce005daa22137ef6390f30d73b7d04c46128","head":{"label":"happinov:overlay_redesign","ref":"overlay_redesign","sha":"1744ce005daa22137ef6390f30d73b7d04c46128","user":{"login":"happinov","id":14196496,"avatar_url":"https://avatars.githubusercontent.com/u/14196496?v=3","gravatar_id":"","url":"https://api.github.com/users/happinov","html_url":"https://github.com/happinov","followers_url":"https://api.github.com/users/happinov/followers","following_url":"https://api.github.com/users/happinov/following{/other_user}","gists_url":"https://api.github.com/users/happinov/gists{/gist_id}","starred_url":"https://api.github.com/users/happinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/happinov/subscriptions","organizations_url":"https://api.github.com/users/happinov/orgs","repos_url":"https://api.github.com/users/happinov/repos","events_url":"https://api.github.com/users/happinov/events{/privacy}","received_events_url":"https://api.github.com/users/happinov/received_events","type":"Organization","site_admin":false},"repo":{"id":59129837,"name":"cordova-plugin-vuforia","full_name":"happinov/cordova-plugin-vuforia","owner":{"login":"happinov","id":14196496,"avatar_url":"https://avatars.githubusercontent.com/u/14196496?v=3","gravatar_id":"","url":"https://api.github.com/users/happinov","html_url":"https://github.com/happinov","followers_url":"https://api.github.com/users/happinov/followers","following_url":"https://api.github.com/users/happinov/following{/other_user}","gists_url":"https://api.github.com/users/happinov/gists{/gist_id}","starred_url":"https://api.github.com/users/happinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/happinov/subscriptions","organizations_url":"https://api.github.com/users/happinov/orgs","repos_url":"https://api.github.com/users/happinov/repos","events_url":"https://api.github.com/users/happinov/events{/privacy}","received_events_url":"https://api.github.com/users/happinov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/happinov/cordova-plugin-vuforia","description":"A 'simple' Vuforia based image recognition plugin for Cordova - created by BD Network","fork":true,"url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia","forks_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/forks","keys_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/teams","hooks_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/hooks","issue_events_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/issues/events{/number}","events_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/events","assignees_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/assignees{/user}","branches_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/branches{/branch}","tags_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/tags","blobs_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/git/refs{/sha}","trees_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/statuses/{sha}","languages_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/languages","stargazers_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/stargazers","contributors_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/contributors","subscribers_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/subscribers","subscription_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/subscription","commits_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/commits{/sha}","git_commits_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/git/commits{/sha}","comments_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/comments{/number}","issue_comment_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/issues/comments{/number}","contents_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/contents/{+path}","compare_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/merges","archive_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/downloads","issues_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/issues{/number}","pulls_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/pulls{/number}","milestones_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/milestones{/number}","notifications_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/labels{/name}","releases_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/releases{/id}","deployments_url":"https://api.github.com/repos/happinov/cordova-plugin-vuforia/deployments","created_at":"2016-05-18T15:47:12Z","updated_at":"2016-05-18T15:47:14Z","pushed_at":"2016-06-16T13:18:26Z","git_url":"git://github.com/happinov/cordova-plugin-vuforia.git","ssh_url":"git@github.com:happinov/cordova-plugin-vuforia.git","clone_url":"https://github.com/happinov/cordova-plugin-vuforia.git","svn_url":"https://github.com/happinov/cordova-plugin-vuforia","homepage":"http://thisisbd.com","size":58941,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattrayner:master","ref":"master","sha":"e032889328ce2751e816ef091df664947830dc73","user":{"login":"mattrayner","id":3502902,"avatar_url":"https://avatars.githubusercontent.com/u/3502902?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrayner","html_url":"https://github.com/mattrayner","followers_url":"https://api.github.com/users/mattrayner/followers","following_url":"https://api.github.com/users/mattrayner/following{/other_user}","gists_url":"https://api.github.com/users/mattrayner/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrayner/subscriptions","organizations_url":"https://api.github.com/users/mattrayner/orgs","repos_url":"https://api.github.com/users/mattrayner/repos","events_url":"https://api.github.com/users/mattrayner/events{/privacy}","received_events_url":"https://api.github.com/users/mattrayner/received_events","type":"User","site_admin":false},"repo":{"id":46061837,"name":"cordova-plugin-vuforia","full_name":"mattrayner/cordova-plugin-vuforia","owner":{"login":"mattrayner","id":3502902,"avatar_url":"https://avatars.githubusercontent.com/u/3502902?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrayner","html_url":"https://github.com/mattrayner","followers_url":"https://api.github.com/users/mattrayner/followers","following_url":"https://api.github.com/users/mattrayner/following{/other_user}","gists_url":"https://api.github.com/users/mattrayner/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrayner/subscriptions","organizations_url":"https://api.github.com/users/mattrayner/orgs","repos_url":"https://api.github.com/users/mattrayner/repos","events_url":"https://api.github.com/users/mattrayner/events{/privacy}","received_events_url":"https://api.github.com/users/mattrayner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattrayner/cordova-plugin-vuforia","description":"A 'simple' Vuforia based image recognition plugin for Cordova","fork":false,"url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia","forks_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/forks","keys_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/teams","hooks_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/hooks","issue_events_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/issues/events{/number}","events_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/events","assignees_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/assignees{/user}","branches_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/branches{/branch}","tags_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/tags","blobs_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/statuses/{sha}","languages_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/languages","stargazers_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/stargazers","contributors_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/contributors","subscribers_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/subscribers","subscription_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/subscription","commits_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/contents/{+path}","compare_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/merges","archive_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/downloads","issues_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/issues{/number}","pulls_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls{/number}","milestones_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/milestones{/number}","notifications_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/labels{/name}","releases_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/releases{/id}","deployments_url":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/deployments","created_at":"2015-11-12T15:26:09Z","updated_at":"2016-06-14T23:37:36Z","pushed_at":"2016-06-16T13:36:19Z","git_url":"git://github.com/mattrayner/cordova-plugin-vuforia.git","ssh_url":"git@github.com:mattrayner/cordova-plugin-vuforia.git","clone_url":"https://github.com/mattrayner/cordova-plugin-vuforia.git","svn_url":"https://github.com/mattrayner/cordova-plugin-vuforia","homepage":"","size":59002,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/60"},"html":{"href":"https://github.com/mattrayner/cordova-plugin-vuforia/pull/60"},"issue":{"href":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/issues/60"},"comments":{"href":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/mattrayner/cordova-plugin-vuforia/statuses/1744ce005daa22137ef6390f30d73b7d04c46128"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":147,"deletions":72,"changed_files":17}}
{"actor":{"display_login":"Stending"}}