{"action":"closed","issue":{"url":"https://api.github.com/repos/mundschenk-at/wp-typography/issues/32","repository_url":"https://api.github.com/repos/mundschenk-at/wp-typography","labels_url":"https://api.github.com/repos/mundschenk-at/wp-typography/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/mundschenk-at/wp-typography/issues/32/comments","events_url":"https://api.github.com/repos/mundschenk-at/wp-typography/issues/32/events","html_url":"https://github.com/mundschenk-at/wp-typography/issues/32","id":157028747,"number":32,"title":"French punctuation: insert `&nbsp;` for literal `«` and `»`","user":{"login":"fvsch","id":243601,"avatar_url":"https://avatars.githubusercontent.com/u/243601?v=3","gravatar_id":"","url":"https://api.github.com/users/fvsch","html_url":"https://github.com/fvsch","followers_url":"https://api.github.com/users/fvsch/followers","following_url":"https://api.github.com/users/fvsch/following{/other_user}","gists_url":"https://api.github.com/users/fvsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fvsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvsch/subscriptions","organizations_url":"https://api.github.com/users/fvsch/orgs","repos_url":"https://api.github.com/users/fvsch/repos","events_url":"https://api.github.com/users/fvsch/events{/privacy}","received_events_url":"https://api.github.com/users/fvsch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mundschenk-at/wp-typography/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/mundschenk-at/wp-typography/labels/confirmed","name":"confirmed","color":"fbca04"},{"url":"https://api.github.com/repos/mundschenk-at/wp-typography/labels/php_typography","name":"php_typography","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"mundschenk-at","id":6943905,"avatar_url":"https://avatars.githubusercontent.com/u/6943905?v=3","gravatar_id":"","url":"https://api.github.com/users/mundschenk-at","html_url":"https://github.com/mundschenk-at","followers_url":"https://api.github.com/users/mundschenk-at/followers","following_url":"https://api.github.com/users/mundschenk-at/following{/other_user}","gists_url":"https://api.github.com/users/mundschenk-at/gists{/gist_id}","starred_url":"https://api.github.com/users/mundschenk-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mundschenk-at/subscriptions","organizations_url":"https://api.github.com/users/mundschenk-at/orgs","repos_url":"https://api.github.com/users/mundschenk-at/repos","events_url":"https://api.github.com/users/mundschenk-at/events{/privacy}","received_events_url":"https://api.github.com/users/mundschenk-at/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mundschenk-at/wp-typography/milestones/7","html_url":"https://github.com/mundschenk-at/wp-typography/milestones/3.3.0","labels_url":"https://api.github.com/repos/mundschenk-at/wp-typography/milestones/7/labels","id":1746095,"number":7,"title":"3.3.0","description":"","creator":{"login":"mundschenk-at","id":6943905,"avatar_url":"https://avatars.githubusercontent.com/u/6943905?v=3","gravatar_id":"","url":"https://api.github.com/users/mundschenk-at","html_url":"https://github.com/mundschenk-at","followers_url":"https://api.github.com/users/mundschenk-at/followers","following_url":"https://api.github.com/users/mundschenk-at/following{/other_user}","gists_url":"https://api.github.com/users/mundschenk-at/gists{/gist_id}","starred_url":"https://api.github.com/users/mundschenk-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mundschenk-at/subscriptions","organizations_url":"https://api.github.com/users/mundschenk-at/orgs","repos_url":"https://api.github.com/users/mundschenk-at/repos","events_url":"https://api.github.com/users/mundschenk-at/events{/privacy}","received_events_url":"https://api.github.com/users/mundschenk-at/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2016-05-03T20:14:02Z","updated_at":"2016-05-29T12:05:30Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-05-26T16:48:03Z","updated_at":"2016-05-29T12:05:30Z","closed_at":"2016-05-29T12:05:30Z","body":"Use case: input text was correctly typed as `« bonjour »` or copied from a word processor that converts straight quotes to `«` and `»` for French documents.\r\n\r\nProvided the following input:\r\n\r\n```\r\nLes « courants de bord ouest » du Pacifique ?\r\nEh bien : ils sont \"fabuleux\".\r\n```\r\n\r\nI'm getting this result (with hyphenation turned off):\r\n\r\n```html\r\nLes « courants de bord ouest » du Pacifique&nbsp;?\r\nEh bien&nbsp;: ils sont «&nbsp;fabuleux&nbsp;».\r\n```\r\n\r\nIdeally, I would like the `set_french_punctuation_spacing` method or other relevant setting (not sure for wp-Typography, since I'm using https://github.com/fabianmichael/kirby-typography and its settings are named and managed differently) to deal with `« »` quotes in the same way it deals with `?!:;`, i.e. to transform `«\\s+` to `«&nbsp;` and `\\s+»` to `&nbsp;»`.\r\n\r\nSince it's a setting for French, there should be no doubt whether `»` is a closing or opening quote (it's a closing quote).\r\n\r\nWould that be doable in PHP_Typography?\r\n\r\nPS: issue ported from https://github.com/fabianmichael/kirby-typography/issues/8"}}
{"actor":{"display_login":"mundschenk-at"}}