{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/86929213","pull_request_review_id":7561565,"id":86929213,"diff_hunk":"@@ -1454,14 +1450,14 @@ private static Binder GetQueryEnclosingBinder(int position, CSharpSyntaxNode sta\n                                                   position, unbound.BindForErrorRecovery().Binder, unbound.Syntax);\n                     case BoundKind.Lambda:\n                         var lambda = (BoundLambda)n;\n-                        return GetEnclosingBinder(AdjustStartingNodeAccordingToNewRoot(startingNode, lambda.Body.Syntax), \n+                        return GetEnclosingBinder(AdjustStartingNodeAccordingToNewRoot(startingNode, lambda.Body.Syntax),\n                                                   position, lambda.Binder, lambda.Body.Syntax);\n                     default:\n                         goto done;\n                 }\n             }\n \n-done:\n+            done:","path":"src/Compilers/CSharp/Portable/Compilation/MemberSemanticModel.cs","position":123,"original_position":123,"commit_id":"31e942139d9b8041de6b43dd609d7c85aeddd4a5","original_commit_id":"31e942139d9b8041de6b43dd609d7c85aeddd4a5","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":"I think the code is more readable when labels are at the beginning of the lines.","created_at":"2016-11-08T06:13:18Z","updated_at":"2016-11-08T06:13:18Z","html_url":"https://github.com/dotnet/roslyn/pull/14871#discussion_r86929213","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14871","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/86929213"},"html":{"href":"https://github.com/dotnet/roslyn/pull/14871#discussion_r86929213"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14871"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/14871","id":91882025,"html_url":"https://github.com/dotnet/roslyn/pull/14871","diff_url":"https://github.com/dotnet/roslyn/pull/14871.diff","patch_url":"https://github.com/dotnet/roslyn/pull/14871.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/14871","number":14871,"state":"open","locked":false,"title":"D-declaration should use declaration expressions","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"body":"This implements the syntax changes (not the wildcard part) of https://github.com/dotnet/roslyn/issues/14832.\r\nThe first commit has the changes to the parser and parsing tests. The second commit has the rest (binding and semantic model).\r\n\r\nFrom our discussion we could keep the following restrictions for now:\r\n- only parse the declaration form of deconstruction when it is a standalone statement (as today), which means we wouldn't parse `M((int x, int y) = e);` for now (I will do that next)\r\n- no support for mixing declarations and assignments in one deconstruction, such as `(x, var y) = e;`\r\n\r\nOn the other hand, deconstruction declaration is now allowed as an embedded statement.\r\n\r\nSome follow-ups:\r\n- merge the parsing logic (and some of the binding logic) between d-assignment and d-declaration (which will allow mixing at some point)\r\n- the logic for parsing d-assignment and d-declaration is still separate (we can merge later). Some of the binding logic could also be factored further.\r\n- GetTypeInfo on tuple expression in the left-hand-side of d-assignment and d-declaration.","created_at":"2016-11-01T23:12:13Z","updated_at":"2016-11-08T06:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbc42d6bbf82170a7adebfbe7a2850ba0d84c9c5","assignee":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/24","html_url":"https://github.com/dotnet/roslyn/milestones/2.0%20(RC.2)","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/24/labels","id":2090735,"number":24,"title":"2.0 (RC.2)","description":"","creator":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":200,"closed_issues":47,"state":"open","created_at":"2016-10-24T21:54:24Z","updated_at":"2016-11-08T02:59:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14871/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14871/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/14871/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/31e942139d9b8041de6b43dd609d7c85aeddd4a5","head":{"label":"jcouv:decon-syntax","ref":"decon-syntax","sha":"31e942139d9b8041de6b43dd609d7c85aeddd4a5","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"repo":{"id":50162064,"name":"roslyn","full_name":"jcouv/roslyn","owner":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcouv/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/jcouv/roslyn","forks_url":"https://api.github.com/repos/jcouv/roslyn/forks","keys_url":"https://api.github.com/repos/jcouv/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcouv/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcouv/roslyn/teams","hooks_url":"https://api.github.com/repos/jcouv/roslyn/hooks","issue_events_url":"https://api.github.com/repos/jcouv/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/jcouv/roslyn/events","assignees_url":"https://api.github.com/repos/jcouv/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/jcouv/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/jcouv/roslyn/tags","blobs_url":"https://api.github.com/repos/jcouv/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcouv/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcouv/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcouv/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcouv/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/jcouv/roslyn/languages","stargazers_url":"https://api.github.com/repos/jcouv/roslyn/stargazers","contributors_url":"https://api.github.com/repos/jcouv/roslyn/contributors","subscribers_url":"https://api.github.com/repos/jcouv/roslyn/subscribers","subscription_url":"https://api.github.com/repos/jcouv/roslyn/subscription","commits_url":"https://api.github.com/repos/jcouv/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcouv/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcouv/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcouv/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcouv/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/jcouv/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcouv/roslyn/merges","archive_url":"https://api.github.com/repos/jcouv/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcouv/roslyn/downloads","issues_url":"https://api.github.com/repos/jcouv/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/jcouv/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/jcouv/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/jcouv/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcouv/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/jcouv/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/jcouv/roslyn/deployments","created_at":"2016-01-22T06:19:22Z","updated_at":"2016-01-22T06:19:52Z","pushed_at":"2016-11-07T19:34:11Z","git_url":"git://github.com/jcouv/roslyn.git","ssh_url":"git@github.com:jcouv/roslyn.git","clone_url":"https://github.com/jcouv/roslyn.git","svn_url":"https://github.com/jcouv/roslyn","homepage":"","size":187263,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b73c499f25e656c568676ae4c95c0b408bac8de8","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-11-08T05:56:50Z","pushed_at":"2016-11-08T06:04:30Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":350451,"stargazers_count":6491,"watchers_count":6491,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1553,"mirror_url":null,"open_issues_count":3370,"forks":1553,"open_issues":3370,"watchers":6491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14871"},"html":{"href":"https://github.com/dotnet/roslyn/pull/14871"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/14871"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/14871/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14871/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14871/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/31e942139d9b8041de6b43dd609d7c85aeddd4a5"}}}}
{"actor":{"display_login":"AlekseyTs"}}