{"action":"created","issue":{"url":"https://api.github.com/repos/peterasplund/MagentoReact/issues/5","repository_url":"https://api.github.com/repos/peterasplund/MagentoReact","labels_url":"https://api.github.com/repos/peterasplund/MagentoReact/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/peterasplund/MagentoReact/issues/5/comments","events_url":"https://api.github.com/repos/peterasplund/MagentoReact/issues/5/events","html_url":"https://github.com/peterasplund/MagentoReact/pull/5","id":165953177,"number":5,"title":"Srcset","user":{"login":"Poggen","id":5216834,"avatar_url":"https://avatars.githubusercontent.com/u/5216834?v=3","gravatar_id":"","url":"https://api.github.com/users/Poggen","html_url":"https://github.com/Poggen","followers_url":"https://api.github.com/users/Poggen/followers","following_url":"https://api.github.com/users/Poggen/following{/other_user}","gists_url":"https://api.github.com/users/Poggen/gists{/gist_id}","starred_url":"https://api.github.com/users/Poggen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poggen/subscriptions","organizations_url":"https://api.github.com/users/Poggen/orgs","repos_url":"https://api.github.com/users/Poggen/repos","events_url":"https://api.github.com/users/Poggen/events{/privacy}","received_events_url":"https://api.github.com/users/Poggen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-17T00:04:46Z","updated_at":"2016-08-03T15:23:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/peterasplund/MagentoReact/pulls/5","html_url":"https://github.com/peterasplund/MagentoReact/pull/5","diff_url":"https://github.com/peterasplund/MagentoReact/pull/5.diff","patch_url":"https://github.com/peterasplund/MagentoReact/pull/5.patch"},"body":"As per commit message – this is just a proof of concept and it will need iteration. The controller needs a rework anyway – I have confirmed that it returns images regardless of whether the images is disabled. If we want to let the frontend handle whether the image is displayed, we should probably send more data about the images, i.e something like this:\r\n\r\n```json\r\n{\r\n\t\"image\": {\r\n\t\t\"description\": \"Lorem ipsum\",\r\n\t\t\"hidden\": false,\r\n\t\t\"disabled\": false,\r\n\t\t\"srcset\": {\r\n\t\t\t\"src\": {\r\n\t\t\t\t\"url\": \"http://local.magento/media/catalog/product/cache/1/image/600x/9df78eab33525d08d6e5fb8d27136e95/m/p/mpd000t_3.jpg\",\r\n\t\t\t\t\"size\": \"w600\"\r\n\t\t\t},\r\n\t\t\t\"src\": {\r\n\t\t\t\t\"url\": \"http://local.magento/media/catalog/product/cache/1/image/1200x/9df78eab33525d08d6e5fb8d27136e95/m/p/mpd000t_3.jpg\",\r\n\t\t\t\t\"size\": \"w1200\"\r\n\t\t\t}\r\n\t\t}\r\n\t}\r\n}\r\n```\r\n\r\n and create a `<Picture>`-component based on that from the markup in `Media.js`."},"comment":{"url":"https://api.github.com/repos/peterasplund/MagentoReact/issues/comments/237270960","html_url":"https://github.com/peterasplund/MagentoReact/pull/5#issuecomment-237270960","issue_url":"https://api.github.com/repos/peterasplund/MagentoReact/issues/5","id":237270960,"user":{"login":"Poggen","id":5216834,"avatar_url":"https://avatars.githubusercontent.com/u/5216834?v=3","gravatar_id":"","url":"https://api.github.com/users/Poggen","html_url":"https://github.com/Poggen","followers_url":"https://api.github.com/users/Poggen/followers","following_url":"https://api.github.com/users/Poggen/following{/other_user}","gists_url":"https://api.github.com/users/Poggen/gists{/gist_id}","starred_url":"https://api.github.com/users/Poggen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poggen/subscriptions","organizations_url":"https://api.github.com/users/Poggen/orgs","repos_url":"https://api.github.com/users/Poggen/repos","events_url":"https://api.github.com/users/Poggen/events{/privacy}","received_events_url":"https://api.github.com/users/Poggen/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T15:23:28Z","updated_at":"2016-08-03T15:23:28Z","body":"Thanks @nilskaspersson – fixed the issues you mentioned."}}
{"actor":{"display_login":"Poggen"}}