{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/91232094","pull_request_review_id":11740817,"id":91232094,"diff_hunk":"@@ -41,48 +44,76 @@\n       <IncludeOutputGroupsInVSIX>BuiltProjectOutputGroup</IncludeOutputGroupsInVSIX>\n       <IncludeOutputGroupsInVSIXLocalOnly>DebugSymbolsProjectOutputGroup</IncludeOutputGroupsInVSIXLocalOnly>\n       <ForceIncludeInVSIX>true</ForceIncludeInVSIX>\n+      <Ngen>true</Ngen>\n+      <NgenApplication>vsn.exe</NgenApplication>\n+      <NgenArchitecture>All</NgenArchitecture>\n+      <NgenPriority>3</NgenPriority>\n     </ProjectReference>\n     <ProjectReference Include=\"..\\Core\\Source\\FunctionResolver\\FunctionResolver.csproj\">\n       <Project>{6FC8E6F5-659C-424D-AEB5-331B95883E29}</Project>\n       <Name>FunctionResolver</Name>\n       <IncludeOutputGroupsInVSIX>BuiltProjectOutputGroup%3bVsdConfigOutputGroup</IncludeOutputGroupsInVSIX>\n       <IncludeOutputGroupsInVSIXLocalOnly>DebugSymbolsProjectOutputGroup</IncludeOutputGroupsInVSIXLocalOnly>\n       <ForceIncludeInVSIX>true</ForceIncludeInVSIX>\n+      <Ngen>true</Ngen>\n+      <NgenApplication>vsn.exe</NgenApplication>\n+      <NgenArchitecture>All</NgenArchitecture>\n+      <NgenPriority>3</NgenPriority>","path":"src/ExpressionEvaluator/Package/ExpressionEvaluatorPackage.csproj","position":17,"original_position":28,"commit_id":"bc6a97a4d478dde40f7289ff79b82d03ff34bd98","original_commit_id":"bc6a97a4d478dde40f7289ff79b82d03ff34bd98","user":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"body":"What does priority mean here? ","created_at":"2016-12-07T06:10:50Z","updated_at":"2016-12-07T06:13:00Z","html_url":"https://github.com/dotnet/roslyn/pull/15710#discussion_r91232094","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15710","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/91232094"},"html":{"href":"https://github.com/dotnet/roslyn/pull/15710#discussion_r91232094"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15710"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/15710","id":96811994,"html_url":"https://github.com/dotnet/roslyn/pull/15710","diff_url":"https://github.com/dotnet/roslyn/pull/15710.diff","patch_url":"https://github.com/dotnet/roslyn/pull/15710.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/15710","number":15710,"state":"open","locked":false,"title":"Update vsixes to use new VSSDK format","user":{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars.githubusercontent.com/u/9797472?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"body":"**Customer scenario**\r\n\r\nRoslyn does not install on RC.3 machines\r\n\r\n**Bugs this fixes:** \r\n\r\nhttps://devdiv.visualstudio.com/DevDiv/_workitems/edit/299109\r\n\r\n**Workarounds, if any**\r\n\r\nnone\r\n\r\n**Risk**\r\n\r\nThis changes how our packages are built.  We will need to do a validation build to ensure that all of the willow dependencies are still valid.\r\n\r\n**Performance impact**\r\n\r\nnone, this is setup authoring\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nYes\r\n\r\n**Root cause analysis:**\r\n\r\nVSSDK required everyone to upgrade, unfortunately there was some miscomumication as both the project system repo and testimpact made these changes while roslyn did not.\r\n\r\n**How was the bug found?**\r\n\r\nnightly run\r\n\r\n\r\n@DustinCampbell @brettfo @tannergooding @dotnet/roslyn-infrastructure Please Review","created_at":"2016-12-06T21:43:09Z","updated_at":"2016-12-07T06:13:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"191b62ef8f8b09bcb9ae09dac109b208c32fcf1a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/25","html_url":"https://github.com/dotnet/roslyn/milestones/2.0%20(RC.3)","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/25/labels","id":2090736,"number":25,"title":"2.0 (RC.3)","description":"","creator":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":176,"closed_issues":42,"state":"open","created_at":"2016-10-24T21:54:30Z","updated_at":"2016-12-06T23:43:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15710/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15710/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/15710/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/bc6a97a4d478dde40f7289ff79b82d03ff34bd98","head":{"label":"jmarolf:bugfix/upgrade-vssdk","ref":"bugfix/upgrade-vssdk","sha":"bc6a97a4d478dde40f7289ff79b82d03ff34bd98","user":{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars.githubusercontent.com/u/9797472?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"repo":{"id":29874637,"name":"roslyn","full_name":"jmarolf/roslyn","owner":{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars.githubusercontent.com/u/9797472?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmarolf/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/jmarolf/roslyn","forks_url":"https://api.github.com/repos/jmarolf/roslyn/forks","keys_url":"https://api.github.com/repos/jmarolf/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarolf/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarolf/roslyn/teams","hooks_url":"https://api.github.com/repos/jmarolf/roslyn/hooks","issue_events_url":"https://api.github.com/repos/jmarolf/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/jmarolf/roslyn/events","assignees_url":"https://api.github.com/repos/jmarolf/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/jmarolf/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/jmarolf/roslyn/tags","blobs_url":"https://api.github.com/repos/jmarolf/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarolf/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarolf/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarolf/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarolf/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarolf/roslyn/languages","stargazers_url":"https://api.github.com/repos/jmarolf/roslyn/stargazers","contributors_url":"https://api.github.com/repos/jmarolf/roslyn/contributors","subscribers_url":"https://api.github.com/repos/jmarolf/roslyn/subscribers","subscription_url":"https://api.github.com/repos/jmarolf/roslyn/subscription","commits_url":"https://api.github.com/repos/jmarolf/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarolf/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarolf/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarolf/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmarolf/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/jmarolf/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarolf/roslyn/merges","archive_url":"https://api.github.com/repos/jmarolf/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarolf/roslyn/downloads","issues_url":"https://api.github.com/repos/jmarolf/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/jmarolf/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarolf/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarolf/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarolf/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/jmarolf/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/jmarolf/roslyn/deployments","created_at":"2015-01-26T18:16:39Z","updated_at":"2015-09-24T00:09:04Z","pushed_at":"2016-12-07T00:35:02Z","git_url":"git://github.com/jmarolf/roslyn.git","ssh_url":"git@github.com:jmarolf/roslyn.git","clone_url":"https://github.com/jmarolf/roslyn.git","svn_url":"https://github.com/jmarolf/roslyn","homepage":"","size":193102,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"363cbb59d305ad1647479e017ac029d1b892fc5c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-12-07T01:17:26Z","pushed_at":"2016-12-07T02:50:14Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":359239,"stargazers_count":6659,"watchers_count":6659,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1601,"mirror_url":null,"open_issues_count":3483,"forks":1601,"open_issues":3483,"watchers":6659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15710"},"html":{"href":"https://github.com/dotnet/roslyn/pull/15710"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/15710"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/15710/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15710/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15710/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/bc6a97a4d478dde40f7289ff79b82d03ff34bd98"}}}}
{"actor":{"display_login":"jaredpar"}}