{"action":"created","issue":{"url":"https://api.github.com/repos/Diaoul/subliminal/issues/538","labels_url":"https://api.github.com/repos/Diaoul/subliminal/issues/538/labels{/name}","comments_url":"https://api.github.com/repos/Diaoul/subliminal/issues/538/comments","events_url":"https://api.github.com/repos/Diaoul/subliminal/issues/538/events","html_url":"https://github.com/Diaoul/subliminal/issues/538","id":119104162,"number":538,"title":"OpenSubtitles: don't rely on hash that much","user":{"login":"pannal","id":1359593,"avatar_url":"https://avatars.githubusercontent.com/u/1359593?v=3","gravatar_id":"","url":"https://api.github.com/users/pannal","html_url":"https://github.com/pannal","followers_url":"https://api.github.com/users/pannal/followers","following_url":"https://api.github.com/users/pannal/following{/other_user}","gists_url":"https://api.github.com/users/pannal/gists{/gist_id}","starred_url":"https://api.github.com/users/pannal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pannal/subscriptions","organizations_url":"https://api.github.com/users/pannal/orgs","repos_url":"https://api.github.com/users/pannal/repos","events_url":"https://api.github.com/users/pannal/events{/privacy}","received_events_url":"https://api.github.com/users/pannal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Diaoul/subliminal/labels/type/enhancement","name":"type/enhancement","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"Diaoul","id":319220,"avatar_url":"https://avatars.githubusercontent.com/u/319220?v=3","gravatar_id":"","url":"https://api.github.com/users/Diaoul","html_url":"https://github.com/Diaoul","followers_url":"https://api.github.com/users/Diaoul/followers","following_url":"https://api.github.com/users/Diaoul/following{/other_user}","gists_url":"https://api.github.com/users/Diaoul/gists{/gist_id}","starred_url":"https://api.github.com/users/Diaoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diaoul/subscriptions","organizations_url":"https://api.github.com/users/Diaoul/orgs","repos_url":"https://api.github.com/users/Diaoul/repos","events_url":"https://api.github.com/users/Diaoul/events{/privacy}","received_events_url":"https://api.github.com/users/Diaoul/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Diaoul/subliminal/milestones/4","html_url":"https://github.com/Diaoul/subliminal/milestones/1.2","labels_url":"https://api.github.com/repos/Diaoul/subliminal/milestones/4/labels","id":1476711,"number":4,"title":"1.2","description":"","creator":{"login":"Diaoul","id":319220,"avatar_url":"https://avatars.githubusercontent.com/u/319220?v=3","gravatar_id":"","url":"https://api.github.com/users/Diaoul","html_url":"https://github.com/Diaoul","followers_url":"https://api.github.com/users/Diaoul/followers","following_url":"https://api.github.com/users/Diaoul/following{/other_user}","gists_url":"https://api.github.com/users/Diaoul/gists{/gist_id}","starred_url":"https://api.github.com/users/Diaoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diaoul/subscriptions","organizations_url":"https://api.github.com/users/Diaoul/orgs","repos_url":"https://api.github.com/users/Diaoul/repos","events_url":"https://api.github.com/users/Diaoul/events{/privacy}","received_events_url":"https://api.github.com/users/Diaoul/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":2,"state":"open","created_at":"2015-12-29T06:39:24Z","updated_at":"2016-01-04T09:10:50Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2015-11-26T21:40:07Z","updated_at":"2016-01-04T17:40:55Z","closed_at":null,"body":"I've made some changes to the OpenSubtitles provider in Sub-Zero to overcome some of the issues some users have reported.\r\n\r\nSubliminal relies on the file hash too much; there are too many subtitles on OSS with wrong or duplicate hashes set, thus downloading wrong subtitles for the videos. (As hashes are \"blindly\" trusted by subliminal)\r\n\r\nI've added a fail-safe to the hash-matching itself: https://github.com/pannal/Sub-Zero.bundle/blob/master/Contents/Libraries/Shared/subliminal_patch/patch_subtitle.py#L32\r\n\r\nWhat I've also noticed is, that OpenSubtitles doesn't get queried with the movie name as a separate criterium, if the hash exists - this also is a problem as it narrows the search for matching subtitles too much. Fixed here: https://github.com/pannal/Sub-Zero.bundle/commit/af7434e35d84bf663730e9d2c7d82f62c1154e0f"},"comment":{"url":"https://api.github.com/repos/Diaoul/subliminal/issues/comments/168748114","html_url":"https://github.com/Diaoul/subliminal/issues/538#issuecomment-168748114","issue_url":"https://api.github.com/repos/Diaoul/subliminal/issues/538","id":168748114,"user":{"login":"Diaoul","id":319220,"avatar_url":"https://avatars.githubusercontent.com/u/319220?v=3","gravatar_id":"","url":"https://api.github.com/users/Diaoul","html_url":"https://github.com/Diaoul","followers_url":"https://api.github.com/users/Diaoul/followers","following_url":"https://api.github.com/users/Diaoul/following{/other_user}","gists_url":"https://api.github.com/users/Diaoul/gists{/gist_id}","starred_url":"https://api.github.com/users/Diaoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diaoul/subscriptions","organizations_url":"https://api.github.com/users/Diaoul/orgs","repos_url":"https://api.github.com/users/Diaoul/repos","events_url":"https://api.github.com/users/Diaoul/events{/privacy}","received_events_url":"https://api.github.com/users/Diaoul/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T17:40:55Z","updated_at":"2016-01-04T17:40:55Z","body":"I didn't add the hash match for tag indeed. Anything from the MovieReleaseName is already parsed by guessit and added as matches so the tag match should achieve highest score (after hash...).\r\n\r\nI will change the way score is treated. Most likely I will change it to a value from 0 to 1 and scale it so the highest **achievable** score is equivalent to the hash score.\r\nSo for example `man.of.steel.2013.720p.bluray.x264-felony.mkv` will have maximum achievable score `{'title', 'year', 'resolution', 'format', 'video_codec', 'release_group'}` and `hash` will be exactly equivalent to this.\r\nWhat do you think of this way?"}}