{"action":"created","comment":{"url":"https://api.github.com/repos/chaijs/chai/pulls/comments/90780298","pull_request_review_id":11296613,"id":90780298,"diff_hunk":"@@ -1500,6 +1505,85 @@ module.exports = function (chai, _) {\n   Assertion.addMethod('keys', assertKeys);\n   Assertion.addMethod('key', assertKeys);\n \n+  function assertStrings (strings) {\n+    _.expectTypes(this, ['string']);\n+    var obj = flag(this, 'object')\n+      , negate = flag(this, 'negate')\n+      , stringsType = _.type(strings)\n+      , str\n+      , deepStr = ''\n+      , ok = true\n+      , mixedArgsMsg = 'when testing strings against strings you must give a single Array|String argument or multiple String arguments';\n+\n+    if (stringsType === 'Array') {\n+      if (arguments.length > 1) throw new Error(mixedArgsMsg);","path":"lib/chai/core/assertions.js","position":60,"original_position":60,"commit_id":"544534f84323392ef32e88b47d2aec4551ec812c","original_commit_id":"544534f84323392ef32e88b47d2aec4551ec812c","user":{"login":"vieiralucas","id":7764293,"avatar_url":"https://avatars.githubusercontent.com/u/7764293?v=3","gravatar_id":"","url":"https://api.github.com/users/vieiralucas","html_url":"https://github.com/vieiralucas","followers_url":"https://api.github.com/users/vieiralucas/followers","following_url":"https://api.github.com/users/vieiralucas/following{/other_user}","gists_url":"https://api.github.com/users/vieiralucas/gists{/gist_id}","starred_url":"https://api.github.com/users/vieiralucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieiralucas/subscriptions","organizations_url":"https://api.github.com/users/vieiralucas/orgs","repos_url":"https://api.github.com/users/vieiralucas/repos","events_url":"https://api.github.com/users/vieiralucas/events{/privacy}","received_events_url":"https://api.github.com/users/vieiralucas/received_events","type":"User","site_admin":false},"body":"Add curly braces around `if`","created_at":"2016-12-04T16:18:44Z","updated_at":"2016-12-04T16:37:50Z","html_url":"https://github.com/chaijs/chai/pull/880#discussion_r90780298","pull_request_url":"https://api.github.com/repos/chaijs/chai/pulls/880","_links":{"self":{"href":"https://api.github.com/repos/chaijs/chai/pulls/comments/90780298"},"html":{"href":"https://github.com/chaijs/chai/pull/880#discussion_r90780298"},"pull_request":{"href":"https://api.github.com/repos/chaijs/chai/pulls/880"}}},"pull_request":{"url":"https://api.github.com/repos/chaijs/chai/pulls/880","id":96429779,"html_url":"https://github.com/chaijs/chai/pull/880","diff_url":"https://github.com/chaijs/chai/pull/880.diff","patch_url":"https://github.com/chaijs/chai/pull/880.patch","issue_url":"https://api.github.com/repos/chaijs/chai/issues/880","number":880,"state":"open","locked":false,"title":"(WIP) Implement .{include,contain}.{all,any}.strings","user":{"login":"postatum","id":1999863,"avatar_url":"https://avatars.githubusercontent.com/u/1999863?v=3","gravatar_id":"","url":"https://api.github.com/users/postatum","html_url":"https://github.com/postatum","followers_url":"https://api.github.com/users/postatum/followers","following_url":"https://api.github.com/users/postatum/following{/other_user}","gists_url":"https://api.github.com/users/postatum/gists{/gist_id}","starred_url":"https://api.github.com/users/postatum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postatum/subscriptions","organizations_url":"https://api.github.com/users/postatum/orgs","repos_url":"https://api.github.com/users/postatum/repos","events_url":"https://api.github.com/users/postatum/events{/privacy}","received_events_url":"https://api.github.com/users/postatum/received_events","type":"User","site_admin":false},"body":"Hello dear chai team :)\r\n\r\nThis is a WIP PR (as suggested by @vieiralucas) that should implement https://github.com/chaijs/chai/issues/858.\r\n\r\nThis is an initial version just to get your feedback on style, corner cases, tests, etc. Maybe something else needs to be changed to make new assertion work properly.\r\nOne thing I know is missing - docstrings for a new method and I also need to check with chai coding style guidelines.\r\nWill be happy to hear your thoughts on this.\r\n\r\nHave a good day!","created_at":"2016-12-04T11:39:38Z","updated_at":"2016-12-04T16:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc3b509e682501766dd0c2c68557cd0a4a898a88","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chaijs/chai/pulls/880/commits","review_comments_url":"https://api.github.com/repos/chaijs/chai/pulls/880/comments","review_comment_url":"https://api.github.com/repos/chaijs/chai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chaijs/chai/issues/880/comments","statuses_url":"https://api.github.com/repos/chaijs/chai/statuses/544534f84323392ef32e88b47d2aec4551ec812c","head":{"label":"postatum:assertion-contain-string","ref":"assertion-contain-string","sha":"544534f84323392ef32e88b47d2aec4551ec812c","user":{"login":"postatum","id":1999863,"avatar_url":"https://avatars.githubusercontent.com/u/1999863?v=3","gravatar_id":"","url":"https://api.github.com/users/postatum","html_url":"https://github.com/postatum","followers_url":"https://api.github.com/users/postatum/followers","following_url":"https://api.github.com/users/postatum/following{/other_user}","gists_url":"https://api.github.com/users/postatum/gists{/gist_id}","starred_url":"https://api.github.com/users/postatum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postatum/subscriptions","organizations_url":"https://api.github.com/users/postatum/orgs","repos_url":"https://api.github.com/users/postatum/repos","events_url":"https://api.github.com/users/postatum/events{/privacy}","received_events_url":"https://api.github.com/users/postatum/received_events","type":"User","site_admin":false},"repo":{"id":73544093,"name":"chai","full_name":"postatum/chai","owner":{"login":"postatum","id":1999863,"avatar_url":"https://avatars.githubusercontent.com/u/1999863?v=3","gravatar_id":"","url":"https://api.github.com/users/postatum","html_url":"https://github.com/postatum","followers_url":"https://api.github.com/users/postatum/followers","following_url":"https://api.github.com/users/postatum/following{/other_user}","gists_url":"https://api.github.com/users/postatum/gists{/gist_id}","starred_url":"https://api.github.com/users/postatum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postatum/subscriptions","organizations_url":"https://api.github.com/users/postatum/orgs","repos_url":"https://api.github.com/users/postatum/repos","events_url":"https://api.github.com/users/postatum/events{/privacy}","received_events_url":"https://api.github.com/users/postatum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/postatum/chai","description":"BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.","fork":true,"url":"https://api.github.com/repos/postatum/chai","forks_url":"https://api.github.com/repos/postatum/chai/forks","keys_url":"https://api.github.com/repos/postatum/chai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postatum/chai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postatum/chai/teams","hooks_url":"https://api.github.com/repos/postatum/chai/hooks","issue_events_url":"https://api.github.com/repos/postatum/chai/issues/events{/number}","events_url":"https://api.github.com/repos/postatum/chai/events","assignees_url":"https://api.github.com/repos/postatum/chai/assignees{/user}","branches_url":"https://api.github.com/repos/postatum/chai/branches{/branch}","tags_url":"https://api.github.com/repos/postatum/chai/tags","blobs_url":"https://api.github.com/repos/postatum/chai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postatum/chai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postatum/chai/git/refs{/sha}","trees_url":"https://api.github.com/repos/postatum/chai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postatum/chai/statuses/{sha}","languages_url":"https://api.github.com/repos/postatum/chai/languages","stargazers_url":"https://api.github.com/repos/postatum/chai/stargazers","contributors_url":"https://api.github.com/repos/postatum/chai/contributors","subscribers_url":"https://api.github.com/repos/postatum/chai/subscribers","subscription_url":"https://api.github.com/repos/postatum/chai/subscription","commits_url":"https://api.github.com/repos/postatum/chai/commits{/sha}","git_commits_url":"https://api.github.com/repos/postatum/chai/git/commits{/sha}","comments_url":"https://api.github.com/repos/postatum/chai/comments{/number}","issue_comment_url":"https://api.github.com/repos/postatum/chai/issues/comments{/number}","contents_url":"https://api.github.com/repos/postatum/chai/contents/{+path}","compare_url":"https://api.github.com/repos/postatum/chai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postatum/chai/merges","archive_url":"https://api.github.com/repos/postatum/chai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postatum/chai/downloads","issues_url":"https://api.github.com/repos/postatum/chai/issues{/number}","pulls_url":"https://api.github.com/repos/postatum/chai/pulls{/number}","milestones_url":"https://api.github.com/repos/postatum/chai/milestones{/number}","notifications_url":"https://api.github.com/repos/postatum/chai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postatum/chai/labels{/name}","releases_url":"https://api.github.com/repos/postatum/chai/releases{/id}","deployments_url":"https://api.github.com/repos/postatum/chai/deployments","created_at":"2016-11-12T09:42:23Z","updated_at":"2016-11-12T09:42:24Z","pushed_at":"2016-12-04T11:27:30Z","git_url":"git://github.com/postatum/chai.git","ssh_url":"git@github.com:postatum/chai.git","clone_url":"https://github.com/postatum/chai.git","svn_url":"https://github.com/postatum/chai","homepage":"http://chaijs.com","size":2854,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chaijs:master","ref":"master","sha":"b7ff1446a7fc63ee99c4b7bfd8d71fe27b087f45","user":{"login":"chaijs","id":1515293,"avatar_url":"https://avatars.githubusercontent.com/u/1515293?v=3","gravatar_id":"","url":"https://api.github.com/users/chaijs","html_url":"https://github.com/chaijs","followers_url":"https://api.github.com/users/chaijs/followers","following_url":"https://api.github.com/users/chaijs/following{/other_user}","gists_url":"https://api.github.com/users/chaijs/gists{/gist_id}","starred_url":"https://api.github.com/users/chaijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaijs/subscriptions","organizations_url":"https://api.github.com/users/chaijs/orgs","repos_url":"https://api.github.com/users/chaijs/repos","events_url":"https://api.github.com/users/chaijs/events{/privacy}","received_events_url":"https://api.github.com/users/chaijs/received_events","type":"Organization","site_admin":false},"repo":{"id":2931111,"name":"chai","full_name":"chaijs/chai","owner":{"login":"chaijs","id":1515293,"avatar_url":"https://avatars.githubusercontent.com/u/1515293?v=3","gravatar_id":"","url":"https://api.github.com/users/chaijs","html_url":"https://github.com/chaijs","followers_url":"https://api.github.com/users/chaijs/followers","following_url":"https://api.github.com/users/chaijs/following{/other_user}","gists_url":"https://api.github.com/users/chaijs/gists{/gist_id}","starred_url":"https://api.github.com/users/chaijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaijs/subscriptions","organizations_url":"https://api.github.com/users/chaijs/orgs","repos_url":"https://api.github.com/users/chaijs/repos","events_url":"https://api.github.com/users/chaijs/events{/privacy}","received_events_url":"https://api.github.com/users/chaijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chaijs/chai","description":"BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.","fork":false,"url":"https://api.github.com/repos/chaijs/chai","forks_url":"https://api.github.com/repos/chaijs/chai/forks","keys_url":"https://api.github.com/repos/chaijs/chai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaijs/chai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaijs/chai/teams","hooks_url":"https://api.github.com/repos/chaijs/chai/hooks","issue_events_url":"https://api.github.com/repos/chaijs/chai/issues/events{/number}","events_url":"https://api.github.com/repos/chaijs/chai/events","assignees_url":"https://api.github.com/repos/chaijs/chai/assignees{/user}","branches_url":"https://api.github.com/repos/chaijs/chai/branches{/branch}","tags_url":"https://api.github.com/repos/chaijs/chai/tags","blobs_url":"https://api.github.com/repos/chaijs/chai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaijs/chai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaijs/chai/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaijs/chai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaijs/chai/statuses/{sha}","languages_url":"https://api.github.com/repos/chaijs/chai/languages","stargazers_url":"https://api.github.com/repos/chaijs/chai/stargazers","contributors_url":"https://api.github.com/repos/chaijs/chai/contributors","subscribers_url":"https://api.github.com/repos/chaijs/chai/subscribers","subscription_url":"https://api.github.com/repos/chaijs/chai/subscription","commits_url":"https://api.github.com/repos/chaijs/chai/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaijs/chai/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaijs/chai/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaijs/chai/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaijs/chai/contents/{+path}","compare_url":"https://api.github.com/repos/chaijs/chai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaijs/chai/merges","archive_url":"https://api.github.com/repos/chaijs/chai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaijs/chai/downloads","issues_url":"https://api.github.com/repos/chaijs/chai/issues{/number}","pulls_url":"https://api.github.com/repos/chaijs/chai/pulls{/number}","milestones_url":"https://api.github.com/repos/chaijs/chai/milestones{/number}","notifications_url":"https://api.github.com/repos/chaijs/chai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaijs/chai/labels{/name}","releases_url":"https://api.github.com/repos/chaijs/chai/releases{/id}","deployments_url":"https://api.github.com/repos/chaijs/chai/deployments","created_at":"2011-12-07T08:06:35Z","updated_at":"2016-12-04T12:47:59Z","pushed_at":"2016-12-04T11:39:38Z","git_url":"git://github.com/chaijs/chai.git","ssh_url":"git@github.com:chaijs/chai.git","clone_url":"https://github.com/chaijs/chai.git","svn_url":"https://github.com/chaijs/chai","homepage":"http://chaijs.com","size":3781,"stargazers_count":3590,"watchers_count":3590,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":33,"forks":333,"open_issues":33,"watchers":3590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chaijs/chai/pulls/880"},"html":{"href":"https://github.com/chaijs/chai/pull/880"},"issue":{"href":"https://api.github.com/repos/chaijs/chai/issues/880"},"comments":{"href":"https://api.github.com/repos/chaijs/chai/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/chaijs/chai/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/chaijs/chai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chaijs/chai/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/chaijs/chai/statuses/544534f84323392ef32e88b47d2aec4551ec812c"}}}}
{"actor":{"display_login":"vieiralucas"}}