{"action":"opened","number":22,"pull_request":{"url":"https://api.github.com/repos/alonsodomin/cron4s/pulls/22","id":98441265,"html_url":"https://github.com/alonsodomin/cron4s/pull/22","diff_url":"https://github.com/alonsodomin/cron4s/pull/22.diff","patch_url":"https://github.com/alonsodomin/cron4s/pull/22.patch","issue_url":"https://api.github.com/repos/alonsodomin/cron4s/issues/22","number":22,"state":"open","locked":false,"title":"Replace parser combinators by FastParse","user":{"login":"alonsodomin","id":2269440,"avatar_url":"https://avatars.githubusercontent.com/u/2269440?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsodomin","html_url":"https://github.com/alonsodomin","followers_url":"https://api.github.com/users/alonsodomin/followers","following_url":"https://api.github.com/users/alonsodomin/following{/other_user}","gists_url":"https://api.github.com/users/alonsodomin/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsodomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsodomin/subscriptions","organizations_url":"https://api.github.com/users/alonsodomin/orgs","repos_url":"https://api.github.com/users/alonsodomin/repos","events_url":"https://api.github.com/users/alonsodomin/events{/privacy}","received_events_url":"https://api.github.com/users/alonsodomin/received_events","type":"User","site_admin":false},"body":"This PR rewrites the whole implementation of the parser using FastParse instead of Scala Parser Combinators. The reasons behind this change are:\r\n\r\n * FastParse is faster, specially when parsing a self-recursive AST like the one in cron4s\r\n * Better error messages when parsing fails. Scala Parser Combinators is able to report on the position in which the parser failed but not which was the depest sub-parser that performed the attempt and failed. This feature in FastParse will enable providing with better and more comprehensive error messages.\r\n * Slow release cycle in Scala Parser Combinators, specially noticed whilst waiting for a Scala 2.12 ScalaJS compatible artifacts.","created_at":"2016-12-17T11:15:39Z","updated_at":"2016-12-17T11:15:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alonsodomin/cron4s/pulls/22/commits","review_comments_url":"https://api.github.com/repos/alonsodomin/cron4s/pulls/22/comments","review_comment_url":"https://api.github.com/repos/alonsodomin/cron4s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alonsodomin/cron4s/issues/22/comments","statuses_url":"https://api.github.com/repos/alonsodomin/cron4s/statuses/4a75da918ec2c431ad7f925c34016660cdc79c11","head":{"label":"alonsodomin:fastparse","ref":"fastparse","sha":"4a75da918ec2c431ad7f925c34016660cdc79c11","user":{"login":"alonsodomin","id":2269440,"avatar_url":"https://avatars.githubusercontent.com/u/2269440?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsodomin","html_url":"https://github.com/alonsodomin","followers_url":"https://api.github.com/users/alonsodomin/followers","following_url":"https://api.github.com/users/alonsodomin/following{/other_user}","gists_url":"https://api.github.com/users/alonsodomin/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsodomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsodomin/subscriptions","organizations_url":"https://api.github.com/users/alonsodomin/orgs","repos_url":"https://api.github.com/users/alonsodomin/repos","events_url":"https://api.github.com/users/alonsodomin/events{/privacy}","received_events_url":"https://api.github.com/users/alonsodomin/received_events","type":"User","site_admin":false},"repo":{"id":64489127,"name":"cron4s","full_name":"alonsodomin/cron4s","owner":{"login":"alonsodomin","id":2269440,"avatar_url":"https://avatars.githubusercontent.com/u/2269440?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsodomin","html_url":"https://github.com/alonsodomin","followers_url":"https://api.github.com/users/alonsodomin/followers","following_url":"https://api.github.com/users/alonsodomin/following{/other_user}","gists_url":"https://api.github.com/users/alonsodomin/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsodomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsodomin/subscriptions","organizations_url":"https://api.github.com/users/alonsodomin/orgs","repos_url":"https://api.github.com/users/alonsodomin/repos","events_url":"https://api.github.com/users/alonsodomin/events{/privacy}","received_events_url":"https://api.github.com/users/alonsodomin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alonsodomin/cron4s","description":"Cron expression parsing for Scala and ScalaJS","fork":false,"url":"https://api.github.com/repos/alonsodomin/cron4s","forks_url":"https://api.github.com/repos/alonsodomin/cron4s/forks","keys_url":"https://api.github.com/repos/alonsodomin/cron4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alonsodomin/cron4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alonsodomin/cron4s/teams","hooks_url":"https://api.github.com/repos/alonsodomin/cron4s/hooks","issue_events_url":"https://api.github.com/repos/alonsodomin/cron4s/issues/events{/number}","events_url":"https://api.github.com/repos/alonsodomin/cron4s/events","assignees_url":"https://api.github.com/repos/alonsodomin/cron4s/assignees{/user}","branches_url":"https://api.github.com/repos/alonsodomin/cron4s/branches{/branch}","tags_url":"https://api.github.com/repos/alonsodomin/cron4s/tags","blobs_url":"https://api.github.com/repos/alonsodomin/cron4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alonsodomin/cron4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alonsodomin/cron4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/alonsodomin/cron4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alonsodomin/cron4s/statuses/{sha}","languages_url":"https://api.github.com/repos/alonsodomin/cron4s/languages","stargazers_url":"https://api.github.com/repos/alonsodomin/cron4s/stargazers","contributors_url":"https://api.github.com/repos/alonsodomin/cron4s/contributors","subscribers_url":"https://api.github.com/repos/alonsodomin/cron4s/subscribers","subscription_url":"https://api.github.com/repos/alonsodomin/cron4s/subscription","commits_url":"https://api.github.com/repos/alonsodomin/cron4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/alonsodomin/cron4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/alonsodomin/cron4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/alonsodomin/cron4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/alonsodomin/cron4s/contents/{+path}","compare_url":"https://api.github.com/repos/alonsodomin/cron4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alonsodomin/cron4s/merges","archive_url":"https://api.github.com/repos/alonsodomin/cron4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alonsodomin/cron4s/downloads","issues_url":"https://api.github.com/repos/alonsodomin/cron4s/issues{/number}","pulls_url":"https://api.github.com/repos/alonsodomin/cron4s/pulls{/number}","milestones_url":"https://api.github.com/repos/alonsodomin/cron4s/milestones{/number}","notifications_url":"https://api.github.com/repos/alonsodomin/cron4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alonsodomin/cron4s/labels{/name}","releases_url":"https://api.github.com/repos/alonsodomin/cron4s/releases{/id}","deployments_url":"https://api.github.com/repos/alonsodomin/cron4s/deployments","created_at":"2016-07-29T15:01:18Z","updated_at":"2016-12-13T08:59:55Z","pushed_at":"2016-12-17T11:09:17Z","git_url":"git://github.com/alonsodomin/cron4s.git","ssh_url":"git@github.com:alonsodomin/cron4s.git","clone_url":"https://github.com/alonsodomin/cron4s.git","svn_url":"https://github.com/alonsodomin/cron4s","homepage":"https://alonsodomin.github.io/cron4s","size":779,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":7,"default_branch":"master"}},"base":{"label":"alonsodomin:master","ref":"master","sha":"4fa17dee6fb05d7d1fcb67aab55b7b93232169c1","user":{"login":"alonsodomin","id":2269440,"avatar_url":"https://avatars.githubusercontent.com/u/2269440?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsodomin","html_url":"https://github.com/alonsodomin","followers_url":"https://api.github.com/users/alonsodomin/followers","following_url":"https://api.github.com/users/alonsodomin/following{/other_user}","gists_url":"https://api.github.com/users/alonsodomin/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsodomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsodomin/subscriptions","organizations_url":"https://api.github.com/users/alonsodomin/orgs","repos_url":"https://api.github.com/users/alonsodomin/repos","events_url":"https://api.github.com/users/alonsodomin/events{/privacy}","received_events_url":"https://api.github.com/users/alonsodomin/received_events","type":"User","site_admin":false},"repo":{"id":64489127,"name":"cron4s","full_name":"alonsodomin/cron4s","owner":{"login":"alonsodomin","id":2269440,"avatar_url":"https://avatars.githubusercontent.com/u/2269440?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsodomin","html_url":"https://github.com/alonsodomin","followers_url":"https://api.github.com/users/alonsodomin/followers","following_url":"https://api.github.com/users/alonsodomin/following{/other_user}","gists_url":"https://api.github.com/users/alonsodomin/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsodomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsodomin/subscriptions","organizations_url":"https://api.github.com/users/alonsodomin/orgs","repos_url":"https://api.github.com/users/alonsodomin/repos","events_url":"https://api.github.com/users/alonsodomin/events{/privacy}","received_events_url":"https://api.github.com/users/alonsodomin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alonsodomin/cron4s","description":"Cron expression parsing for Scala and ScalaJS","fork":false,"url":"https://api.github.com/repos/alonsodomin/cron4s","forks_url":"https://api.github.com/repos/alonsodomin/cron4s/forks","keys_url":"https://api.github.com/repos/alonsodomin/cron4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alonsodomin/cron4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alonsodomin/cron4s/teams","hooks_url":"https://api.github.com/repos/alonsodomin/cron4s/hooks","issue_events_url":"https://api.github.com/repos/alonsodomin/cron4s/issues/events{/number}","events_url":"https://api.github.com/repos/alonsodomin/cron4s/events","assignees_url":"https://api.github.com/repos/alonsodomin/cron4s/assignees{/user}","branches_url":"https://api.github.com/repos/alonsodomin/cron4s/branches{/branch}","tags_url":"https://api.github.com/repos/alonsodomin/cron4s/tags","blobs_url":"https://api.github.com/repos/alonsodomin/cron4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alonsodomin/cron4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alonsodomin/cron4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/alonsodomin/cron4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alonsodomin/cron4s/statuses/{sha}","languages_url":"https://api.github.com/repos/alonsodomin/cron4s/languages","stargazers_url":"https://api.github.com/repos/alonsodomin/cron4s/stargazers","contributors_url":"https://api.github.com/repos/alonsodomin/cron4s/contributors","subscribers_url":"https://api.github.com/repos/alonsodomin/cron4s/subscribers","subscription_url":"https://api.github.com/repos/alonsodomin/cron4s/subscription","commits_url":"https://api.github.com/repos/alonsodomin/cron4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/alonsodomin/cron4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/alonsodomin/cron4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/alonsodomin/cron4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/alonsodomin/cron4s/contents/{+path}","compare_url":"https://api.github.com/repos/alonsodomin/cron4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alonsodomin/cron4s/merges","archive_url":"https://api.github.com/repos/alonsodomin/cron4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alonsodomin/cron4s/downloads","issues_url":"https://api.github.com/repos/alonsodomin/cron4s/issues{/number}","pulls_url":"https://api.github.com/repos/alonsodomin/cron4s/pulls{/number}","milestones_url":"https://api.github.com/repos/alonsodomin/cron4s/milestones{/number}","notifications_url":"https://api.github.com/repos/alonsodomin/cron4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alonsodomin/cron4s/labels{/name}","releases_url":"https://api.github.com/repos/alonsodomin/cron4s/releases{/id}","deployments_url":"https://api.github.com/repos/alonsodomin/cron4s/deployments","created_at":"2016-07-29T15:01:18Z","updated_at":"2016-12-13T08:59:55Z","pushed_at":"2016-12-17T11:09:17Z","git_url":"git://github.com/alonsodomin/cron4s.git","ssh_url":"git@github.com:alonsodomin/cron4s.git","clone_url":"https://github.com/alonsodomin/cron4s.git","svn_url":"https://github.com/alonsodomin/cron4s","homepage":"https://alonsodomin.github.io/cron4s","size":779,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alonsodomin/cron4s/pulls/22"},"html":{"href":"https://github.com/alonsodomin/cron4s/pull/22"},"issue":{"href":"https://api.github.com/repos/alonsodomin/cron4s/issues/22"},"comments":{"href":"https://api.github.com/repos/alonsodomin/cron4s/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/alonsodomin/cron4s/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/alonsodomin/cron4s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alonsodomin/cron4s/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/alonsodomin/cron4s/statuses/4a75da918ec2c431ad7f925c34016660cdc79c11"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":225,"deletions":231,"changed_files":19}}
{"actor":{"display_login":"alonsodomin"}}