{"action":"created","issue":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/564","repository_url":"https://api.github.com/repos/meetecho/janus-gateway","labels_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/564/labels{/name}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/564/comments","events_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/564/events","html_url":"https://github.com/meetecho/janus-gateway/issues/564","id":160817134,"number":564,"title":"HTTP transport: ACL does not work, if no interface/IP specified ","user":{"login":"uxmaster","id":5693497,"avatar_url":"https://avatars.githubusercontent.com/u/5693497?v=3","gravatar_id":"","url":"https://api.github.com/users/uxmaster","html_url":"https://github.com/uxmaster","followers_url":"https://api.github.com/users/uxmaster/followers","following_url":"https://api.github.com/users/uxmaster/following{/other_user}","gists_url":"https://api.github.com/users/uxmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/uxmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uxmaster/subscriptions","organizations_url":"https://api.github.com/users/uxmaster/orgs","repos_url":"https://api.github.com/users/uxmaster/repos","events_url":"https://api.github.com/users/uxmaster/events{/privacy}","received_events_url":"https://api.github.com/users/uxmaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-17T05:54:36Z","updated_at":"2016-06-17T08:15:31Z","closed_at":null,"body":"If no interface/IP is specified for binding, IP address (https://github.com/meetecho/janus-gateway/blob/master/transports/janus_http.c#L977) is always 0.0.0.0, which renders ACL unusable.\r\nI have checked it with libmicrohttpd 0.9.33 (Ubuntu 14.04.4) and 0.9.50 (the newest).\r\n\r\nThis regression is caused by https://github.com/meetecho/janus-gateway/commit/55280d5221ce46b49abcc3aba6cfcec9a85644e0, when I backed it out, everything returned to normal."},"comment":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/comments/226708865","html_url":"https://github.com/meetecho/janus-gateway/issues/564#issuecomment-226708865","issue_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/564","id":226708865,"user":{"login":"lminiero","id":3684796,"avatar_url":"https://avatars.githubusercontent.com/u/3684796?v=3","gravatar_id":"","url":"https://api.github.com/users/lminiero","html_url":"https://github.com/lminiero","followers_url":"https://api.github.com/users/lminiero/followers","following_url":"https://api.github.com/users/lminiero/following{/other_user}","gists_url":"https://api.github.com/users/lminiero/gists{/gist_id}","starred_url":"https://api.github.com/users/lminiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lminiero/subscriptions","organizations_url":"https://api.github.com/users/lminiero/orgs","repos_url":"https://api.github.com/users/lminiero/repos","events_url":"https://api.github.com/users/lminiero/events{/privacy}","received_events_url":"https://api.github.com/users/lminiero/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T08:15:31Z","updated_at":"2016-06-17T08:15:31Z","body":"Found out the cause of the issue: when you pass `MHD_USE_DUAL_STACK`, the addresses that are passed to that method are always IPv6, no matter the source. Since our callback assumes it's a `sockaddr_in`, the resolution of the address gives `0.0.0.0`. I'll try and fix the check there."}}
{"actor":{"display_login":"lminiero"}}