{"action":"created","comment":{"url":"https://api.github.com/repos/trello/RxLifecycle/pulls/comments/86553233","pull_request_review_id":7207222,"id":86553233,"diff_hunk":"@@ -47,28 +48,28 @@ private RxLifecycle() {\n         checkNotNull(lifecycle, \"lifecycle == null\");\n         checkNotNull(event, \"event == null\");\n \n-        return new UntilEventObservableTransformer<>(lifecycle, event);\n+        return new UntilEventTransformer<>(lifecycle, event);\n     }\n \n     /**\n      * Binds the given source to a lifecycle.\n      * <p>\n-     * Use with {@link Observable#compose(Observable.Transformer)}:\n+     * Use with {@link Observable#compose(ObservableTransformer)}:\n      * {@code source.compose(RxLifecycle.bind(lifecycle)).subscribe()}\n      * <p>\n      * This helper automatically determines (based on the lifecycle sequence itself) when the source\n      * should stop emitting items. Note that for this method, it assumes <em>any</em> event\n      * emitted by the given lifecycle indicates that the lifecycle is over.\n      *\n      * @param lifecycle the lifecycle sequence\n-     * @return a reusable {@link Observable.Transformer} that unsubscribes the source whenever the lifecycle emits\n+     * @return a reusable {@link ObservableTransformer} that unsubscribes the source whenever the lifecycle emits","path":"rxlifecycle/src/main/java/com/trello/rxlifecycle/RxLifecycle.java","position":48,"original_position":48,"commit_id":"2c4666bf6101e9bf38267cfd7841216fb41c39b2","original_commit_id":"2c4666bf6101e9bf38267cfd7841216fb41c39b2","user":{"login":"vanniktech","id":5759366,"avatar_url":"https://avatars.githubusercontent.com/u/5759366?v=3","gravatar_id":"","url":"https://api.github.com/users/vanniktech","html_url":"https://github.com/vanniktech","followers_url":"https://api.github.com/users/vanniktech/followers","following_url":"https://api.github.com/users/vanniktech/following{/other_user}","gists_url":"https://api.github.com/users/vanniktech/gists{/gist_id}","starred_url":"https://api.github.com/users/vanniktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanniktech/subscriptions","organizations_url":"https://api.github.com/users/vanniktech/orgs","repos_url":"https://api.github.com/users/vanniktech/repos","events_url":"https://api.github.com/users/vanniktech/events{/privacy}","received_events_url":"https://api.github.com/users/vanniktech/received_events","type":"User","site_admin":false},"body":"it returns a `LifecycleTransformer`","created_at":"2016-11-04T14:14:53Z","updated_at":"2016-11-04T14:14:53Z","html_url":"https://github.com/trello/RxLifecycle/pull/167#discussion_r86553233","pull_request_url":"https://api.github.com/repos/trello/RxLifecycle/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/trello/RxLifecycle/pulls/comments/86553233"},"html":{"href":"https://github.com/trello/RxLifecycle/pull/167#discussion_r86553233"},"pull_request":{"href":"https://api.github.com/repos/trello/RxLifecycle/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/trello/RxLifecycle/pulls/167","id":92343299,"html_url":"https://github.com/trello/RxLifecycle/pull/167","diff_url":"https://github.com/trello/RxLifecycle/pull/167.diff","patch_url":"https://github.com/trello/RxLifecycle/pull/167.patch","issue_url":"https://api.github.com/repos/trello/RxLifecycle/issues/167","number":167,"state":"open","locked":false,"title":"Upgrade to RxJava 2","user":{"login":"dlew","id":514850,"avatar_url":"https://avatars.githubusercontent.com/u/514850?v=3","gravatar_id":"","url":"https://api.github.com/users/dlew","html_url":"https://github.com/dlew","followers_url":"https://api.github.com/users/dlew/followers","following_url":"https://api.github.com/users/dlew/following{/other_user}","gists_url":"https://api.github.com/users/dlew/gists{/gist_id}","starred_url":"https://api.github.com/users/dlew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlew/subscriptions","organizations_url":"https://api.github.com/users/dlew/orgs","repos_url":"https://api.github.com/users/dlew/repos","events_url":"https://api.github.com/users/dlew/events{/privacy}","received_events_url":"https://api.github.com/users/dlew/received_events","type":"User","site_admin":false},"body":"The goal here is just to start the big transition, I'm sure there are\r\nlots of little polishes/improvements we can do once this is in.\r\n\r\nSome of the bigger changes:\r\n\r\n- Removed dependency on RxBinding since there is no RxJava 2-based\r\n  RxBinding yet. Implementing our own ViewDetachesOnSubscribe was\r\n  not that bad.\r\n\r\n- Rolled all Transformers into a single LifecycleTransformer, now that\r\n  we can do so (due to composition-friendly interfaces).","created_at":"2016-11-04T13:51:21Z","updated_at":"2016-11-04T14:19:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54625ba9823a9e8bdf0a666eaed4360d17bce257","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/trello/RxLifecycle/pulls/167/commits","review_comments_url":"https://api.github.com/repos/trello/RxLifecycle/pulls/167/comments","review_comment_url":"https://api.github.com/repos/trello/RxLifecycle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trello/RxLifecycle/issues/167/comments","statuses_url":"https://api.github.com/repos/trello/RxLifecycle/statuses/2c4666bf6101e9bf38267cfd7841216fb41c39b2","head":{"label":"trello:dlew/rxjava2","ref":"dlew/rxjava2","sha":"2c4666bf6101e9bf38267cfd7841216fb41c39b2","user":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"repo":{"id":39385621,"name":"RxLifecycle","full_name":"trello/RxLifecycle","owner":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trello/RxLifecycle","description":"Lifecycle handling APIs for Android apps using RxJava","fork":false,"url":"https://api.github.com/repos/trello/RxLifecycle","forks_url":"https://api.github.com/repos/trello/RxLifecycle/forks","keys_url":"https://api.github.com/repos/trello/RxLifecycle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trello/RxLifecycle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trello/RxLifecycle/teams","hooks_url":"https://api.github.com/repos/trello/RxLifecycle/hooks","issue_events_url":"https://api.github.com/repos/trello/RxLifecycle/issues/events{/number}","events_url":"https://api.github.com/repos/trello/RxLifecycle/events","assignees_url":"https://api.github.com/repos/trello/RxLifecycle/assignees{/user}","branches_url":"https://api.github.com/repos/trello/RxLifecycle/branches{/branch}","tags_url":"https://api.github.com/repos/trello/RxLifecycle/tags","blobs_url":"https://api.github.com/repos/trello/RxLifecycle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trello/RxLifecycle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trello/RxLifecycle/git/refs{/sha}","trees_url":"https://api.github.com/repos/trello/RxLifecycle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trello/RxLifecycle/statuses/{sha}","languages_url":"https://api.github.com/repos/trello/RxLifecycle/languages","stargazers_url":"https://api.github.com/repos/trello/RxLifecycle/stargazers","contributors_url":"https://api.github.com/repos/trello/RxLifecycle/contributors","subscribers_url":"https://api.github.com/repos/trello/RxLifecycle/subscribers","subscription_url":"https://api.github.com/repos/trello/RxLifecycle/subscription","commits_url":"https://api.github.com/repos/trello/RxLifecycle/commits{/sha}","git_commits_url":"https://api.github.com/repos/trello/RxLifecycle/git/commits{/sha}","comments_url":"https://api.github.com/repos/trello/RxLifecycle/comments{/number}","issue_comment_url":"https://api.github.com/repos/trello/RxLifecycle/issues/comments{/number}","contents_url":"https://api.github.com/repos/trello/RxLifecycle/contents/{+path}","compare_url":"https://api.github.com/repos/trello/RxLifecycle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trello/RxLifecycle/merges","archive_url":"https://api.github.com/repos/trello/RxLifecycle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trello/RxLifecycle/downloads","issues_url":"https://api.github.com/repos/trello/RxLifecycle/issues{/number}","pulls_url":"https://api.github.com/repos/trello/RxLifecycle/pulls{/number}","milestones_url":"https://api.github.com/repos/trello/RxLifecycle/milestones{/number}","notifications_url":"https://api.github.com/repos/trello/RxLifecycle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trello/RxLifecycle/labels{/name}","releases_url":"https://api.github.com/repos/trello/RxLifecycle/releases{/id}","deployments_url":"https://api.github.com/repos/trello/RxLifecycle/deployments","created_at":"2015-07-20T13:32:23Z","updated_at":"2016-11-04T12:50:11Z","pushed_at":"2016-11-04T13:51:21Z","git_url":"git://github.com/trello/RxLifecycle.git","ssh_url":"git@github.com:trello/RxLifecycle.git","clone_url":"https://github.com/trello/RxLifecycle.git","svn_url":"https://github.com/trello/RxLifecycle","homepage":null,"size":513,"stargazers_count":2352,"watchers_count":2352,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":209,"mirror_url":null,"open_issues_count":6,"forks":209,"open_issues":6,"watchers":2352,"default_branch":"master"}},"base":{"label":"trello:2.x","ref":"2.x","sha":"1a78ef1cc772e99e74aace5091b66ece7615764a","user":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"repo":{"id":39385621,"name":"RxLifecycle","full_name":"trello/RxLifecycle","owner":{"login":"trello","id":6181431,"avatar_url":"https://avatars.githubusercontent.com/u/6181431?v=3","gravatar_id":"","url":"https://api.github.com/users/trello","html_url":"https://github.com/trello","followers_url":"https://api.github.com/users/trello/followers","following_url":"https://api.github.com/users/trello/following{/other_user}","gists_url":"https://api.github.com/users/trello/gists{/gist_id}","starred_url":"https://api.github.com/users/trello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trello/subscriptions","organizations_url":"https://api.github.com/users/trello/orgs","repos_url":"https://api.github.com/users/trello/repos","events_url":"https://api.github.com/users/trello/events{/privacy}","received_events_url":"https://api.github.com/users/trello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trello/RxLifecycle","description":"Lifecycle handling APIs for Android apps using RxJava","fork":false,"url":"https://api.github.com/repos/trello/RxLifecycle","forks_url":"https://api.github.com/repos/trello/RxLifecycle/forks","keys_url":"https://api.github.com/repos/trello/RxLifecycle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trello/RxLifecycle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trello/RxLifecycle/teams","hooks_url":"https://api.github.com/repos/trello/RxLifecycle/hooks","issue_events_url":"https://api.github.com/repos/trello/RxLifecycle/issues/events{/number}","events_url":"https://api.github.com/repos/trello/RxLifecycle/events","assignees_url":"https://api.github.com/repos/trello/RxLifecycle/assignees{/user}","branches_url":"https://api.github.com/repos/trello/RxLifecycle/branches{/branch}","tags_url":"https://api.github.com/repos/trello/RxLifecycle/tags","blobs_url":"https://api.github.com/repos/trello/RxLifecycle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trello/RxLifecycle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trello/RxLifecycle/git/refs{/sha}","trees_url":"https://api.github.com/repos/trello/RxLifecycle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trello/RxLifecycle/statuses/{sha}","languages_url":"https://api.github.com/repos/trello/RxLifecycle/languages","stargazers_url":"https://api.github.com/repos/trello/RxLifecycle/stargazers","contributors_url":"https://api.github.com/repos/trello/RxLifecycle/contributors","subscribers_url":"https://api.github.com/repos/trello/RxLifecycle/subscribers","subscription_url":"https://api.github.com/repos/trello/RxLifecycle/subscription","commits_url":"https://api.github.com/repos/trello/RxLifecycle/commits{/sha}","git_commits_url":"https://api.github.com/repos/trello/RxLifecycle/git/commits{/sha}","comments_url":"https://api.github.com/repos/trello/RxLifecycle/comments{/number}","issue_comment_url":"https://api.github.com/repos/trello/RxLifecycle/issues/comments{/number}","contents_url":"https://api.github.com/repos/trello/RxLifecycle/contents/{+path}","compare_url":"https://api.github.com/repos/trello/RxLifecycle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trello/RxLifecycle/merges","archive_url":"https://api.github.com/repos/trello/RxLifecycle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trello/RxLifecycle/downloads","issues_url":"https://api.github.com/repos/trello/RxLifecycle/issues{/number}","pulls_url":"https://api.github.com/repos/trello/RxLifecycle/pulls{/number}","milestones_url":"https://api.github.com/repos/trello/RxLifecycle/milestones{/number}","notifications_url":"https://api.github.com/repos/trello/RxLifecycle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trello/RxLifecycle/labels{/name}","releases_url":"https://api.github.com/repos/trello/RxLifecycle/releases{/id}","deployments_url":"https://api.github.com/repos/trello/RxLifecycle/deployments","created_at":"2015-07-20T13:32:23Z","updated_at":"2016-11-04T12:50:11Z","pushed_at":"2016-11-04T13:51:21Z","git_url":"git://github.com/trello/RxLifecycle.git","ssh_url":"git@github.com:trello/RxLifecycle.git","clone_url":"https://github.com/trello/RxLifecycle.git","svn_url":"https://github.com/trello/RxLifecycle","homepage":null,"size":513,"stargazers_count":2352,"watchers_count":2352,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":209,"mirror_url":null,"open_issues_count":6,"forks":209,"open_issues":6,"watchers":2352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trello/RxLifecycle/pulls/167"},"html":{"href":"https://github.com/trello/RxLifecycle/pull/167"},"issue":{"href":"https://api.github.com/repos/trello/RxLifecycle/issues/167"},"comments":{"href":"https://api.github.com/repos/trello/RxLifecycle/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/trello/RxLifecycle/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/trello/RxLifecycle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trello/RxLifecycle/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/trello/RxLifecycle/statuses/2c4666bf6101e9bf38267cfd7841216fb41c39b2"}}}}
{"actor":{"display_login":"vanniktech"}}