{"action":"opened","number":34,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/34","id":98198395,"html_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime/pull/34","diff_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime/pull/34.diff","patch_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime/pull/34.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/34","number":34,"state":"open","locked":false,"title":"Introduce app.jar convention for child containers [EXPERIMENTAL]","user":{"login":"meltsufin","id":17732492,"avatar_url":"https://avatars.githubusercontent.com/u/17732492?v=3","gravatar_id":"","url":"https://api.github.com/users/meltsufin","html_url":"https://github.com/meltsufin","followers_url":"https://api.github.com/users/meltsufin/followers","following_url":"https://api.github.com/users/meltsufin/following{/other_user}","gists_url":"https://api.github.com/users/meltsufin/gists{/gist_id}","starred_url":"https://api.github.com/users/meltsufin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meltsufin/subscriptions","organizations_url":"https://api.github.com/users/meltsufin/orgs","repos_url":"https://api.github.com/users/meltsufin/repos","events_url":"https://api.github.com/users/meltsufin/events{/privacy}","received_events_url":"https://api.github.com/users/meltsufin/received_events","type":"User","site_admin":false},"body":"I'm just putting this up for comment. Experimenting with `ONBUILD` to potentially simplify the creation of child containers that use `app.jar` as the convention for application archive.\r\nCurrently, users write a custom Dockerfile like this:\r\n```\r\nFROM gcr.io/google-appengine/openjdk\r\nADD springboot-petclinic-1.4.2.jar /app/app.jar\r\nCMD [\"java\", \"-jar\", \"/app/app.jar\"]\r\n```\r\n\r\nAs long as they rename the archive to `app.jar`, it would allow them to write the Dockerfile with just the FROM line:\r\n```\r\nFROM gcr.io/google-appengine/openjdk\r\n```\r\n\r\nOne downside I can think of is that the `ONBUILD ADD app.jar /app/` command will be inherited by our jetty-runtime, and although harmless, would just be an unnecessary layer in the image.","created_at":"2016-12-15T17:48:11Z","updated_at":"2016-12-15T17:48:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/34/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/34/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/34/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/statuses/312a4c8996e45c60d8ca6325c65be5aa3bb02abc","head":{"label":"GoogleCloudPlatform:app_jar_convention","ref":"app_jar_convention","sha":"312a4c8996e45c60d8ca6325c65be5aa3bb02abc","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":66016292,"name":"openjdk-runtime","full_name":"GoogleCloudPlatform/openjdk-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/deployments","created_at":"2016-08-18T17:13:04Z","updated_at":"2016-12-09T10:40:17Z","pushed_at":"2016-12-15T17:48:11Z","git_url":"git://github.com/GoogleCloudPlatform/openjdk-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/openjdk-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime","homepage":null,"size":2748,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"a7812ae1faad4edb7548d078c7b6ea1c077ec3dc","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":66016292,"name":"openjdk-runtime","full_name":"GoogleCloudPlatform/openjdk-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/deployments","created_at":"2016-08-18T17:13:04Z","updated_at":"2016-12-09T10:40:17Z","pushed_at":"2016-12-15T17:48:11Z","git_url":"git://github.com/GoogleCloudPlatform/openjdk-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/openjdk-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/openjdk-runtime","homepage":null,"size":2748,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/34"},"html":{"href":"https://github.com/GoogleCloudPlatform/openjdk-runtime/pull/34"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/34"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/openjdk-runtime/statuses/312a4c8996e45c60d8ca6325c65be5aa3bb02abc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"meltsufin"}}