{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9679","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9679/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9679/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9679/events","html_url":"https://github.com/joomla/joomla-cms/pull/9679","id":144682259,"number":9679,"title":"Title of wrong menu item changed for com_contact","user":{"login":"wojsmol","id":4176111,"avatar_url":"https://avatars.githubusercontent.com/u/4176111?v=3","gravatar_id":"","url":"https://api.github.com/users/wojsmol","html_url":"https://github.com/wojsmol","followers_url":"https://api.github.com/users/wojsmol/followers","following_url":"https://api.github.com/users/wojsmol/following{/other_user}","gists_url":"https://api.github.com/users/wojsmol/gists{/gist_id}","starred_url":"https://api.github.com/users/wojsmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojsmol/subscriptions","organizations_url":"https://api.github.com/users/wojsmol/orgs","repos_url":"https://api.github.com/users/wojsmol/repos","events_url":"https://api.github.com/users/wojsmol/events{/privacy}","received_events_url":"https://api.github.com/users/wojsmol/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-30T18:34:19Z","updated_at":"2016-03-30T19:25:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9679","html_url":"https://github.com/joomla/joomla-cms/pull/9679","diff_url":"https://github.com/joomla/joomla-cms/pull/9679.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9679.patch"},"body":"Pull Request for Issue #9525\r\n\r\nOriginal issue description\r\n\r\n> ### Steps to reproduce the issue\r\n> \r\n> Upgrade from Joomla 3.4.8 to Joomla 3.5 on a very long living site.\r\n> ### Expected result\r\n> \r\n> The title of admin menu item with title \"com_contact\" is renamed to \"com_contact_contacts\".\r\n> ### Actual result\r\n> \r\n> The title of a menu item which is used on the frontend (title = 'Geschiedenis') is renamed to \"com_contact_contacts\". That means the main menu on my site now contains a item with title \"com_contact_contacts\".\r\n> System information (as much as possible)\r\n> \r\n>     * Upgrade from 3.4.8 to 3.5\r\n>     * Long living installation, migrations and upgrades since Joomla 1.5\r\n>     * Using MySQL database\r\n>     * The IDs of the backend menu items (client_id = 1) are not equal to the ones in a clean Joomla installation.\r\n> \r\n> ### Additional comments\r\n> \r\n> Issue is caused by #8212 which uses a hardcoded menu item ID (8) to update the menu item title. Menu item ID 8 may be used for another than the meant one.\r\n> Fix proposal\r\n> \r\n> I think other people with (somehow) non-default menu item IDs may/will have the same problem. My proposal is to only change the title for menu items which matches the follow criteria:\r\n> a) only backend menu items (client_id = 1)\r\n> b) with title = 'com_contact'\r\n> c) in a submenu (level = 2)\r\n> \r\n> For MySQL the following query does the job from phpMyAdmin:\r\n> UPDATE jml_menu SET title = 'com_contact_contacts' WHERE client_id = 1 AND level = 2 AND title = 'com_contact'\r\n> \r\n> If you agree I wil be happy to change the queries and submit another PR. I also can help testing for MySQL because I did not upgrade my production installation yet.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/203594819","html_url":"https://github.com/joomla/joomla-cms/pull/9679#issuecomment-203594819","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9679","id":203594819,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T19:25:31Z","updated_at":"2016-03-30T19:25:31Z","body":"and how do we test the PR?"}}