{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/1498","repository_url":"https://api.github.com/repos/nunit/nunit","labels_url":"https://api.github.com/repos/nunit/nunit/issues/1498/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/1498/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/1498/events","html_url":"https://github.com/nunit/nunit/pull/1498","id":155036338,"number":1498,"title":"Enable / Disable Extensions","user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-16T14:05:32Z","updated_at":"2016-05-20T15:19:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/1498","html_url":"https://github.com/nunit/nunit/pull/1498","diff_url":"https://github.com/nunit/nunit/pull/1498.diff","patch_url":"https://github.com/nunit/nunit/pull/1498.patch"},"body":"This PR is the first step in adding the feature described in #1010. Since I'm working on this in stages, it can be merged whenever we like and I'll just continue using a new PR.\r\n\r\nThe initial commit implements the ability for extensions to be enabled and disabled individually. These classic example of needing this would be for an extension to handle team city service messages. We would not want the messages to be issued all the time, but only when running under team city. A property of the TestPackage (NYI) could be used to \"turn on\" the extension.\r\n\r\n * Extensions continue to be enabled by default, as this is what works best for most extensions\r\n * Extensions that are present but should only be enabled by command may be initially disabled by adding a named property to the ExtensionAttribute.\r\n * ExtensionService now has an entry that allows enabling an extension by specifying its full type name.\r\n * Disabled extensions are never instantiated.\r\n * The tests demonstrates that all defaults still work and that existing extensions are enabled. A dummy disabled extension is used to test default behavior and enabling the extension.\r\n\r\nWhether we merge right away or not, this would be a good point to review the API changes."},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/220635188","html_url":"https://github.com/nunit/nunit/pull/1498#issuecomment-220635188","issue_url":"https://api.github.com/repos/nunit/nunit/issues/1498","id":220635188,"user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T15:19:32Z","updated_at":"2016-05-20T15:19:32Z","body":"I've been continuing work on this while travelling on branch work-1010 so that there wouldn't be a PR build every time I committed. I'll be merging that work back to this branch later today."}}
{"actor":{"display_login":"CharliePoole"}}