{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/3486","repository_url":"https://api.github.com/repos/callemall/material-ui","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/3486/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/3486/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/3486/events","html_url":"https://github.com/callemall/material-ui/issues/3486","id":136793363,"number":3486,"title":"Add Tests for components","user":{"login":"alitaheri","id":8528759,"avatar_url":"https://avatars.githubusercontent.com/u/8528759?v=3","gravatar_id":"","url":"https://api.github.com/users/alitaheri","html_url":"https://github.com/alitaheri","followers_url":"https://api.github.com/users/alitaheri/followers","following_url":"https://api.github.com/users/alitaheri/following{/other_user}","gists_url":"https://api.github.com/users/alitaheri/gists{/gist_id}","starred_url":"https://api.github.com/users/alitaheri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alitaheri/subscriptions","organizations_url":"https://api.github.com/users/alitaheri/orgs","repos_url":"https://api.github.com/users/alitaheri/repos","events_url":"https://api.github.com/users/alitaheri/events{/privacy}","received_events_url":"https://api.github.com/users/alitaheri/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/callemall/material-ui/labels/Umbrella","name":"Umbrella","color":"1a1a1a"},{"url":"https://api.github.com/repos/callemall/material-ui/labels/Unit%20Test","name":"Unit Test","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/callemall/material-ui/milestones/14","html_url":"https://github.com/callemall/material-ui/milestones/0.16.0%20Release","labels_url":"https://api.github.com/repos/callemall/material-ui/milestones/14/labels","id":1582007,"number":14,"title":"0.16.0 Release","description":"","creator":{"login":"alitaheri","id":8528759,"avatar_url":"https://avatars.githubusercontent.com/u/8528759?v=3","gravatar_id":"","url":"https://api.github.com/users/alitaheri","html_url":"https://github.com/alitaheri","followers_url":"https://api.github.com/users/alitaheri/followers","following_url":"https://api.github.com/users/alitaheri/following{/other_user}","gists_url":"https://api.github.com/users/alitaheri/gists{/gist_id}","starred_url":"https://api.github.com/users/alitaheri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alitaheri/subscriptions","organizations_url":"https://api.github.com/users/alitaheri/orgs","repos_url":"https://api.github.com/users/alitaheri/repos","events_url":"https://api.github.com/users/alitaheri/events{/privacy}","received_events_url":"https://api.github.com/users/alitaheri/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-02-14T16:34:47Z","updated_at":"2016-02-26T19:40:04Z","due_on":null,"closed_at":null},"comments":32,"created_at":"2016-02-26T19:40:03Z","updated_at":"2016-02-28T17:58:57Z","closed_at":null,"body":"After the great work done by @nathanmarks with the tests we should now go ahead and make unit tests for each component to ensure their integrity :+1: \r\n\r\nThis is the list of all components that need unit tests:\r\n\r\n### Components:\r\n\r\n- [ ] [AppBar] `app-bar`: #3487 @pradel \r\n- [ ] [AutoComplete] `auto-complete`\r\n- [ ] [Avatar] `avatar`: Partial: (#3405 @nathanmarks)\r\n- [x] [Badge] `badge`: #3427 @pradel \r\n- [ ] [FlatButtonLabel] `buttons/flat-button-label`\r\n- [ ] [Card] `card/card`\r\n- [ ] [CardAction] `card/card-actions`\r\n- [ ] [CardExpandable] `card/card-expandable`\r\n- [ ] [CardHeader] `card/card-header`\r\n- [ ] [CardMedia] `card/card-media`\r\n- [ ] [CardText] `card/card-text`\r\n- [ ] [CardTitle] `card/card-title`\r\n- [ ] [Checkbox] `checkbox`\r\n- [ ] [CircularProgress] `circular-progress`\r\n- [ ] [Calendar] `date-picker/calendar`\r\n- [ ] [CalendarMonth] `date-picker/calendar-month`\r\n- [ ] [CalendarToolbar] `date-picker/calendar-toolbar`\r\n- [ ] [CalendarYear] `date-picker/calendar-year`\r\n- [ ] [DateDisplay] `date-picker/date-display`\r\n- [ ] [DatePicker] `date-picker/date-picker`\r\n- [ ] [DatePickerDialog] `date-picker/date-picker-dialog`\r\n- [ ] [DatePickerInline] `date-picker/date-picker-inline`\r\n- [ ] [DayButton] `date-picker/day-button`\r\n- [ ] [YearButton] `date-picker/year-button`\r\n- [ ] [Dialog] `dialog`\r\n- [ ] [Divider] `divider`\r\n- [ ] [DropDownMenu] `DropDownMenu/DropDownMenu`\r\n- [ ] [EnhancedButton] `enhanced-button`\r\n- [ ] [EnhancedSwitch] `enhanced-switch`\r\n- [ ] [EnhancedTextarea] `enhanced-textarea`\r\n- [ ] [FlatButton] `flat-button`\r\n- [ ] [FloatingActionButton] `floating-action-button`\r\n- [ ] [FontIcon] `font-icon`: #3490 @pradel \r\n- [ ] [GridList] `grid-list/grid-list`: #3488 @pradel \r\n- [ ] [GridTitle] `grid-list/grid-tile`\r\n- [ ] [IconButton] `icon-button`\r\n- [ ] [InkBar] `ink-bar`\r\n- [ ] [LeftNav] `left-nav`\r\n- [ ] [LinearProgress] `linear-progress`\r\n- [ ] [List] `lists/list`\r\n- [ ] [ListItem] `lists/list-item`\r\n- [ ] [NestedList] `lists/nested-list`\r\n- [ ] [IconMenu] `menus/icon-menu`\r\n- [ ] [Menu] `menus/menu`\r\n- [ ] [MenuItem] `menus/menu-item`\r\n- [ ] [Overlay] `overlay`\r\n- [ ] [Paper] `paper`\r\n- [ ] [Popover] `popover/popover`\r\n- [ ] [PopoverAnimationFromTop] `popover/popover-animation-from-top`\r\n- [ ] [PopoverDefaultAnimationp] `popover/popover-default-animation`\r\n- [ ] [RadioButton] `radio-button`\r\n- [ ] [RadioButtonGroup] `radio-button-group`\r\n- [ ] [RaisedButton] `raised-button`\r\n- [ ] [RefreshIndicator] `refresh-indicator`\r\n- [ ] [RenderToLayer] `render-to-layer`\r\n- [ ] [CircleRipple] `ripples/circle-ripple`\r\n- [ ] [FocusRipple] `ripples/focus-ripple`\r\n- [ ] [TouchRipple] `ripples/touch-ripple`\r\n- [ ] [SelectField] `SelectField/SelectField`\r\n- [ ] [Slider] `slider`\r\n- [ ] [SnackBar] `snackbar`\r\n- [ ] [Subheader] `Subheader/Subheader`\r\n- [ ] [SvgIcon] `svg-icon`: #3489 @pradel \r\n- [ ] [Table] `table/table`\r\n- [ ] [TableBody] `table/table-body`\r\n- [ ] [TableFooter] `table/table-footer`\r\n- [ ] [TableHeader] `table/table-header`\r\n- [ ] [TableHeaderColumn] `table/table-header-column`\r\n- [ ] [TableRow] `table/table-row`\r\n- [ ] [TableRowColumn] `table/table-row-column`\r\n- [ ] [Tab] `tabs/tab`\r\n- [ ] [Tabs] `tabs/tabs`\r\n- [ ] [TabTemplate] `tabs/tabTemplate`\r\n- [ ] [TextField] `TextField/TextField`\r\n- [ ] [TextFieldHint] `TextField/TextFieldHint`\r\n- [ ] [TextFieldLabel] `TextField/TextFieldLabel`\r\n- [ ] [TextFieldUnderline] `TextField/TextFieldUnderline`\r\n- [ ] [Clock] `time-picker/clock`\r\n- [ ] [ClockHours] `time-picker/clock-hours`\r\n- [ ] [ClockMinutes] `time-picker/clock-minutes`\r\n- [ ] [ClockNumber] `time-picker/clock-number`\r\n- [ ] [ClockPointer] `time-picker/clock-pointer`\r\n- [ ] [TimeDisplay] `time-picker/time-display`\r\n- [ ] [TimePicker] `time-picker/time-picker`\r\n- [ ] [TimePickerDialog] `time-picker/time-picker-dialog`\r\n- [ ] [Toggle] `toggle`\r\n- [ ] [Toolbar] `toolbar/toolbar`\r\n- [ ] [ToolbarGroup] `toolbar/toolbar-group`\r\n- [ ] [ToolbarSeparator] `toolbar/toolbar-separator`\r\n- [ ] [ToolbarTitle] `toolbar/toolbar-title`\r\n- [ ] [ToolTip] `tooltip`\r\n\r\n### Utility Components:\r\n\r\n- [ ] [ClickAwayListener] `ClickAwayListener`\r\n- [ ] [muiThemeable] `muiThemeable`\r\n- [ ] [MuiThemeProvider] `MuiThemeProvider`\r\n- [ ] [ScaleIn] `transition-groups/scale-in`\r\n- [ ] [ScaleInChild] `transition-groups/scale-in-child`\r\n- [ ] [SlideIn] `transition-groups/slide-in`\r\n- [ ] [SlideInChild] `transition-groups/slide-in-child`\r\n\r\n### Styles:\r\n\r\n- [ ] [getMuiTheme] `styles/getMuiTheme.js`\r\n- [ ] [AutoPrefixerTransformer] `styles/transformers/autoprefixer.js`\r\n- [ ] [RtlTransformer] `styles/transformers/rtl.js`\r\n- [ ] [Transitions] `styles/transitions.js`"},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/189915421","html_url":"https://github.com/callemall/material-ui/issues/3486#issuecomment-189915421","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/3486","id":189915421,"user":{"login":"newoga","id":344018,"avatar_url":"https://avatars.githubusercontent.com/u/344018?v=3","gravatar_id":"","url":"https://api.github.com/users/newoga","html_url":"https://github.com/newoga","followers_url":"https://api.github.com/users/newoga/followers","following_url":"https://api.github.com/users/newoga/following{/other_user}","gists_url":"https://api.github.com/users/newoga/gists{/gist_id}","starred_url":"https://api.github.com/users/newoga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newoga/subscriptions","organizations_url":"https://api.github.com/users/newoga/orgs","repos_url":"https://api.github.com/users/newoga/repos","events_url":"https://api.github.com/users/newoga/events{/privacy}","received_events_url":"https://api.github.com/users/newoga/received_events","type":"User","site_admin":false},"created_at":"2016-02-28T17:58:56Z","updated_at":"2016-02-28T17:58:56Z","body":"I'd have to look over everything again with a fresh perspective. I think some component APIs are closer than others, and some will likely require a complete redesign. The challenge is I don't think we're going to have anytime to do any of the major component API refactoring in the `0.15.0` release. \r\n\r\nThat being said, I think the two that came immediately to mind that I'd like to remove are `Clearfix` and `BeforeAfterWrapper`. I'd like to remove those for sure so I wouldn't bother writing tests for those. Maybe before writing tests for any new components, maybe we should quickly regroup and decide what we think our mid and longterm goals might be for the component."}}