{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/70411236","id":70411236,"diff_hunk":"@@ -618,6 +621,17 @@ static int term_movecursor(VTermPos new, VTermPos old, int visible,\n   return 1;\n }\n \n+// Set the terminal title. Takes ownership of the title string.","path":"src/nvim/terminal.c","position":21,"original_position":21,"commit_id":"4b3a47c228ce257f46d4da45572ff90fc507f53c","original_commit_id":"4b3a47c228ce257f46d4da45572ff90fc507f53c","user":{"login":"joshtriplett","id":162737,"avatar_url":"https://avatars.githubusercontent.com/u/162737?v=3","gravatar_id":"","url":"https://api.github.com/users/joshtriplett","html_url":"https://github.com/joshtriplett","followers_url":"https://api.github.com/users/joshtriplett/followers","following_url":"https://api.github.com/users/joshtriplett/following{/other_user}","gists_url":"https://api.github.com/users/joshtriplett/gists{/gist_id}","starred_url":"https://api.github.com/users/joshtriplett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshtriplett/subscriptions","organizations_url":"https://api.github.com/users/joshtriplett/orgs","repos_url":"https://api.github.com/users/joshtriplett/repos","events_url":"https://api.github.com/users/joshtriplett/events{/privacy}","received_events_url":"https://api.github.com/users/joshtriplett/received_events","type":"User","site_admin":false},"body":"As far as I can tell, the string is placed into the dictionary uncopied, and when strings are subsequently removed from that dictionary, they're freed.  Have I missed a copying function somewhere?","created_at":"2016-07-12T10:09:41Z","updated_at":"2016-07-12T10:09:41Z","html_url":"https://github.com/neovim/neovim/pull/5026#discussion_r70411236","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/5026","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/70411236"},"html":{"href":"https://github.com/neovim/neovim/pull/5026#discussion_r70411236"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5026"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/5026","id":76881708,"html_url":"https://github.com/neovim/neovim/pull/5026","diff_url":"https://github.com/neovim/neovim/pull/5026.diff","patch_url":"https://github.com/neovim/neovim/pull/5026.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/5026","number":5026,"state":"open","locked":false,"title":"Please support setting terminal title in :terminal","user":{"login":"joshtriplett","id":162737,"avatar_url":"https://avatars.githubusercontent.com/u/162737?v=3","gravatar_id":"","url":"https://api.github.com/users/joshtriplett","html_url":"https://github.com/joshtriplett","followers_url":"https://api.github.com/users/joshtriplett/followers","following_url":"https://api.github.com/users/joshtriplett/following{/other_user}","gists_url":"https://api.github.com/users/joshtriplett/gists{/gist_id}","starred_url":"https://api.github.com/users/joshtriplett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshtriplett/subscriptions","organizations_url":"https://api.github.com/users/joshtriplett/orgs","repos_url":"https://api.github.com/users/joshtriplett/repos","events_url":"https://api.github.com/users/joshtriplett/events{/privacy}","received_events_url":"https://api.github.com/users/joshtriplett/received_events","type":"User","site_admin":false},"body":"- `nvim --version`:\r\n\r\n```\r\nNVIM 0.1.4\r\nBuild type: None\r\nCompilation: /usr/bin/cc -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DDISABLE_LOG -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1  -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/build/neovim-1AXpO2/neovim-0.1.4/build/config -I/build/neovim-1AXpO2/neovim-0.1.4/src -I/usr/include -I/usr/include -I/usr/include/luajit-2.0 -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/build/neovim-1AXpO2/neovim-0.1.4/build/src/nvim/auto -I/build/neovim-1AXpO2/neovim-0.1.4/build/include\r\nCompiled by buildd@babin\r\n\r\nOptional features included (+) or not (-): +acl   +iconv    +jemalloc \r\nFor differences from Vim, see :help vim-differences\r\n\r\n   system vimrc file: \"$VIM/sysinit.vim\"\r\n  fall-back for $VIM: \"/usr/share/nvim\"\r\n```\r\n\r\n- Vim (version: ) behaves differently?\r\n\r\nN/A; vim doesn't have :terminal.\r\n\r\n- Operating system/version:\r\n\r\nLatest Debian sid, with neovim package 0.1.4-1 from experimental.\r\n\r\n- Terminal name/version:\r\n\r\ngnome-terminal 3.20.2\r\n\r\n- `$TERM`:\r\n\r\nxterm-256color\r\n\r\n### Actual behaviour\r\n\r\nTerminal control sequences to set the terminal title get ignored.\r\n\r\n### Expected behaviour\r\n\r\nTerminal control sequences to set the terminal title set a buffer-local variable, and the default status line for terminal buffers includes that variable.\r\n\r\nMany programs support setting the terminal title, as do the default shell startup files on many people's systems.\r\n\r\n### Steps to reproduce using `nvim -u NORC`\r\n\r\n```\r\nnvim -u NORC\r\n:terminal\r\n/usr/bin/printf '\\e]2;title\\a' ; sleep 10\r\n```\r\n\r\nThat escape sequence sets the terminal title to \"title\".  (See http://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h2-Operating-System-Controls for details on these control sequences.)","created_at":"2016-07-10T19:42:22Z","updated_at":"2016-07-12T10:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c919778e37612d47a4ee081caf8c974b6f4dbc9a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/neovim/neovim/milestones/6","html_url":"https://github.com/neovim/neovim/milestones/todo","labels_url":"https://api.github.com/repos/neovim/neovim/milestones/6/labels","id":655037,"number":6,"title":"todo","description":"\"todo\" items are *definitely not* planned for the *current* target, but *may* be given priority for a future target. Y'know, like todo.txt ;)","creator":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"open_issues":150,"closed_issues":43,"state":"open","created_at":"2014-05-10T20:43:04Z","updated_at":"2016-07-09T18:01:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/5026/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/5026/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/5026/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/4b3a47c228ce257f46d4da45572ff90fc507f53c","head":{"label":"joshtriplett:term-title-statusline","ref":"term-title-statusline","sha":"4b3a47c228ce257f46d4da45572ff90fc507f53c","user":{"login":"joshtriplett","id":162737,"avatar_url":"https://avatars.githubusercontent.com/u/162737?v=3","gravatar_id":"","url":"https://api.github.com/users/joshtriplett","html_url":"https://github.com/joshtriplett","followers_url":"https://api.github.com/users/joshtriplett/followers","following_url":"https://api.github.com/users/joshtriplett/following{/other_user}","gists_url":"https://api.github.com/users/joshtriplett/gists{/gist_id}","starred_url":"https://api.github.com/users/joshtriplett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshtriplett/subscriptions","organizations_url":"https://api.github.com/users/joshtriplett/orgs","repos_url":"https://api.github.com/users/joshtriplett/repos","events_url":"https://api.github.com/users/joshtriplett/events{/privacy}","received_events_url":"https://api.github.com/users/joshtriplett/received_events","type":"User","site_admin":false},"repo":{"id":62962639,"name":"neovim","full_name":"joshtriplett/neovim","owner":{"login":"joshtriplett","id":162737,"avatar_url":"https://avatars.githubusercontent.com/u/162737?v=3","gravatar_id":"","url":"https://api.github.com/users/joshtriplett","html_url":"https://github.com/joshtriplett","followers_url":"https://api.github.com/users/joshtriplett/followers","following_url":"https://api.github.com/users/joshtriplett/following{/other_user}","gists_url":"https://api.github.com/users/joshtriplett/gists{/gist_id}","starred_url":"https://api.github.com/users/joshtriplett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshtriplett/subscriptions","organizations_url":"https://api.github.com/users/joshtriplett/orgs","repos_url":"https://api.github.com/users/joshtriplett/repos","events_url":"https://api.github.com/users/joshtriplett/events{/privacy}","received_events_url":"https://api.github.com/users/joshtriplett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshtriplett/neovim","description":"Vim-fork focused on extensibility and agility.","fork":true,"url":"https://api.github.com/repos/joshtriplett/neovim","forks_url":"https://api.github.com/repos/joshtriplett/neovim/forks","keys_url":"https://api.github.com/repos/joshtriplett/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshtriplett/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshtriplett/neovim/teams","hooks_url":"https://api.github.com/repos/joshtriplett/neovim/hooks","issue_events_url":"https://api.github.com/repos/joshtriplett/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/joshtriplett/neovim/events","assignees_url":"https://api.github.com/repos/joshtriplett/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/joshtriplett/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/joshtriplett/neovim/tags","blobs_url":"https://api.github.com/repos/joshtriplett/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshtriplett/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshtriplett/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshtriplett/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshtriplett/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/joshtriplett/neovim/languages","stargazers_url":"https://api.github.com/repos/joshtriplett/neovim/stargazers","contributors_url":"https://api.github.com/repos/joshtriplett/neovim/contributors","subscribers_url":"https://api.github.com/repos/joshtriplett/neovim/subscribers","subscription_url":"https://api.github.com/repos/joshtriplett/neovim/subscription","commits_url":"https://api.github.com/repos/joshtriplett/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshtriplett/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshtriplett/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshtriplett/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshtriplett/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/joshtriplett/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshtriplett/neovim/merges","archive_url":"https://api.github.com/repos/joshtriplett/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshtriplett/neovim/downloads","issues_url":"https://api.github.com/repos/joshtriplett/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/joshtriplett/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/joshtriplett/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/joshtriplett/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshtriplett/neovim/labels{/name}","releases_url":"https://api.github.com/repos/joshtriplett/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/joshtriplett/neovim/deployments","created_at":"2016-07-09T18:10:41Z","updated_at":"2016-07-09T18:10:49Z","pushed_at":"2016-07-11T10:39:25Z","git_url":"git://github.com/joshtriplett/neovim.git","ssh_url":"git@github.com:joshtriplett/neovim.git","clone_url":"https://github.com/joshtriplett/neovim.git","svn_url":"https://github.com/joshtriplett/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":43471,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"dcbd1c7b13e98766754c4e75d3bb59021248217e","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility.","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2016-07-12T09:21:18Z","pushed_at":"2016-07-12T08:28:11Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":71489,"stargazers_count":19287,"watchers_count":19287,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1363,"mirror_url":null,"open_issues_count":737,"forks":1363,"open_issues":737,"watchers":19287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5026"},"html":{"href":"https://github.com/neovim/neovim/pull/5026"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/5026"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/5026/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5026/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5026/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/4b3a47c228ce257f46d4da45572ff90fc507f53c"}}}}
{"actor":{"display_login":"joshtriplett"}}