{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4769","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4769/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4769/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4769/events","html_url":"https://github.com/home-assistant/home-assistant/pull/4769","id":193650437,"number":4769,"title":"Ecobee detect Smart Away","user":{"login":"devdelay","id":18601270,"avatar_url":"https://avatars.githubusercontent.com/u/18601270?v=3","gravatar_id":"","url":"https://api.github.com/users/devdelay","html_url":"https://github.com/devdelay","followers_url":"https://api.github.com/users/devdelay/followers","following_url":"https://api.github.com/users/devdelay/following{/other_user}","gists_url":"https://api.github.com/users/devdelay/gists{/gist_id}","starred_url":"https://api.github.com/users/devdelay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devdelay/subscriptions","organizations_url":"https://api.github.com/users/devdelay/orgs","repos_url":"https://api.github.com/users/devdelay/repos","events_url":"https://api.github.com/users/devdelay/events{/privacy}","received_events_url":"https://api.github.com/users/devdelay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"assignees":[{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-12-06T00:28:01Z","updated_at":"2016-12-17T15:15:38Z","closed_at":"2016-12-11T22:46:10Z","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4769","html_url":"https://github.com/home-assistant/home-assistant/pull/4769","diff_url":"https://github.com/home-assistant/home-assistant/pull/4769.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/4769.patch"},"body":"**Description:**\r\nEcobee component is not able determine if the thermostat is in Away mode once Smart Away mode has created an away event. When Smart Away mode is enabled, after some time that occupancy is no longer detected, an event will be created with type = autoAway and holdClimateRef = ' '. When Away mode is manually enabled or set via Home-Assistant, type = hold and holdClimateRef = away.\r\n\r\nThis is a difficult situation to test but I was looking for some more validation and input on this code because I'm sure it's butchered, although it appears to work properly. There may be other cases I am currently not aware of. Normally my device trackers will Ecobee Away mode on and off. I had suspected this was happening months ago but was only able to confirm it while I was on vacation and someone was house sitting for me. \r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\nSomewhat related to #4510 \r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>\r\n\r\n**Example entry for `configuration.yaml` (if applicable):**\r\n```yaml\r\n\r\n```\r\n\r\n**Checklist:**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/267767935","html_url":"https://github.com/home-assistant/home-assistant/pull/4769#issuecomment-267767935","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4769","id":267767935,"user":{"login":"Duoxilian","id":24535446,"avatar_url":"https://avatars.githubusercontent.com/u/24535446?v=3","gravatar_id":"","url":"https://api.github.com/users/Duoxilian","html_url":"https://github.com/Duoxilian","followers_url":"https://api.github.com/users/Duoxilian/followers","following_url":"https://api.github.com/users/Duoxilian/following{/other_user}","gists_url":"https://api.github.com/users/Duoxilian/gists{/gist_id}","starred_url":"https://api.github.com/users/Duoxilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Duoxilian/subscriptions","organizations_url":"https://api.github.com/users/Duoxilian/orgs","repos_url":"https://api.github.com/users/Duoxilian/repos","events_url":"https://api.github.com/users/Duoxilian/events{/privacy}","received_events_url":"https://api.github.com/users/Duoxilian/received_events","type":"User","site_admin":false},"created_at":"2016-12-17T15:15:38Z","updated_at":"2016-12-17T15:15:38Z","body":"As an aside, I implemented the corresponding smarthome mode in issue #4950 as a trivial extension. It works and is handy if you want to manipulate that mode, e.g., putting the thermostat into home hold when the mode is sleep (to increase the temperature while you are up at that schedule)."}}
{"actor":{"display_login":"Duoxilian"}}