{"action":"created","issue":{"url":"https://api.github.com/repos/docker/machine/issues/3410","repository_url":"https://api.github.com/repos/docker/machine","labels_url":"https://api.github.com/repos/docker/machine/issues/3410/labels{/name}","comments_url":"https://api.github.com/repos/docker/machine/issues/3410/comments","events_url":"https://api.github.com/repos/docker/machine/issues/3410/events","html_url":"https://github.com/docker/machine/pull/3410","id":153225807,"number":3410,"title":"Machine-specific persistent option to specify SSH config","user":{"login":"brettdh","id":91550,"avatar_url":"https://avatars.githubusercontent.com/u/91550?v=3","gravatar_id":"","url":"https://api.github.com/users/brettdh","html_url":"https://github.com/brettdh","followers_url":"https://api.github.com/users/brettdh/followers","following_url":"https://api.github.com/users/brettdh/following{/other_user}","gists_url":"https://api.github.com/users/brettdh/gists{/gist_id}","starred_url":"https://api.github.com/users/brettdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettdh/subscriptions","organizations_url":"https://api.github.com/users/brettdh/orgs","repos_url":"https://api.github.com/users/brettdh/repos","events_url":"https://api.github.com/users/brettdh/events{/privacy}","received_events_url":"https://api.github.com/users/brettdh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/machine/labels/dco/no","name":"dco/no","color":"f7c6c7"},{"url":"https://api.github.com/repos/docker/machine/labels/status/0-triage","name":"status/0-triage","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-05T12:53:41Z","updated_at":"2016-05-09T12:16:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/machine/pulls/3410","html_url":"https://github.com/docker/machine/pull/3410","diff_url":"https://github.com/docker/machine/pull/3410.diff","patch_url":"https://github.com/docker/machine/pull/3410.patch"},"body":"@nathanleclaire\n\nThis adds two flags to `docker-machine create`:\n\n    --generic-ssh-config-file <path/to/config>\n\n        Use the provided config file with the external SSH client (-F)\n\n    --generic-use-user-ssh-config\n\n        Use ~/.ssh/config as the config file\n\n(The flags are mutually exclusive in order to avoid ambiguity.)\n\nTried this out in my environment, which requires a `ProxyCommand` to\naccess a remote site via SSH. Before, the issue described in #3310\noccurred, preventing me from using `docker-machine` to configure this\nhost. With this, the `--generic-use-user-ssh-config` option adds\nthe config file in place of the previous-default `/dev/null` and all\nseems well.\n\nAlso added a couple unit test cases.\n\nDepends on an updated version of #3209.\nNote that this PR includes brettdh/machine@d39de4f\n(which is just #3209 rebased on master).\n\nThe merge will be a bit messy, since this will get rebased on whatever #3209\nbecomes, but at least now it can be reviewed in relative isolation.\nI considered setting the base for this PR on brettdh/machine@d39de4f,\nbut I'm pretty sure that would make a PR on my fork, rather than on docker/machine."},"comment":{"url":"https://api.github.com/repos/docker/machine/issues/comments/217848516","html_url":"https://github.com/docker/machine/pull/3410#issuecomment-217848516","issue_url":"https://api.github.com/repos/docker/machine/issues/3410","id":217848516,"user":{"login":"GordonTheTurtle","id":10620046,"avatar_url":"https://avatars.githubusercontent.com/u/10620046?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonTheTurtle","html_url":"https://github.com/GordonTheTurtle","followers_url":"https://api.github.com/users/GordonTheTurtle/followers","following_url":"https://api.github.com/users/GordonTheTurtle/following{/other_user}","gists_url":"https://api.github.com/users/GordonTheTurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonTheTurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonTheTurtle/subscriptions","organizations_url":"https://api.github.com/users/GordonTheTurtle/orgs","repos_url":"https://api.github.com/users/GordonTheTurtle/repos","events_url":"https://api.github.com/users/GordonTheTurtle/events{/privacy}","received_events_url":"https://api.github.com/users/GordonTheTurtle/received_events","type":"User","site_admin":false},"created_at":"2016-05-09T12:16:47Z","updated_at":"2016-05-09T12:16:47Z","body":"Please sign your commits following these rules:\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work\nThe easiest way to do this is to amend the last commit:\n~~~console\n$ git clone -b \"use-user-ssh-config\" git@github.com:brettdh/machine.git somewhere\n$ cd somewhere\n$ git rebase -i HEAD~7\neditor opens\nchange each 'pick' to 'edit'\nsave the file and quit\n$ git commit --amend -s --no-edit\n$ git rebase --continue # and repeat the amend for each commit\n$ git push -f\n~~~\n\nAmmending updates the existing PR. You **DO NOT** need to open a new one.\n"}}