{"action":"created","comment":{"url":"https://api.github.com/repos/shelljs/shelljs/pulls/comments/65012190","id":65012190,"diff_hunk":"@@ -236,6 +244,7 @@ exports.randomFileName = randomFileName;\n // extend(target_obj, source_obj1 [, source_obj2 ...])\n // Shallow extend, e.g.:\n //    extend({A:1}, {b:2}, {c:3}) returns {A:1, b:2, c:3}\n+// XXX: This isn't going to be a part of plugin.utils. We should upgrade to Babel, Then we'll use Object.assign (or a ponyfill)","path":"src/common.js","position":65,"original_position":65,"commit_id":"69f574b132fc65bd8e58a0f16d0d9352ac429b88","original_commit_id":"69f574b132fc65bd8e58a0f16d0d9352ac429b88","user":{"login":"ariporad","id":1817508,"avatar_url":"https://avatars.githubusercontent.com/u/1817508?v=3","gravatar_id":"","url":"https://api.github.com/users/ariporad","html_url":"https://github.com/ariporad","followers_url":"https://api.github.com/users/ariporad/followers","following_url":"https://api.github.com/users/ariporad/following{/other_user}","gists_url":"https://api.github.com/users/ariporad/gists{/gist_id}","starred_url":"https://api.github.com/users/ariporad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariporad/subscriptions","organizations_url":"https://api.github.com/users/ariporad/orgs","repos_url":"https://api.github.com/users/ariporad/repos","events_url":"https://api.github.com/users/ariporad/events{/privacy}","received_events_url":"https://api.github.com/users/ariporad/received_events","type":"User","site_admin":false},"body":"No, I just feel like it's a bit out of place here: Everything else is shell-related in some way, except for this, which is just a generic utility function. I don't know...","created_at":"2016-05-29T21:51:04Z","updated_at":"2016-05-29T21:51:04Z","html_url":"https://github.com/shelljs/shelljs/pull/451#discussion_r65012190","pull_request_url":"https://api.github.com/repos/shelljs/shelljs/pulls/451","_links":{"self":{"href":"https://api.github.com/repos/shelljs/shelljs/pulls/comments/65012190"},"html":{"href":"https://github.com/shelljs/shelljs/pull/451#discussion_r65012190"},"pull_request":{"href":"https://api.github.com/repos/shelljs/shelljs/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/shelljs/shelljs/pulls/451","id":71816939,"html_url":"https://github.com/shelljs/shelljs/pull/451","diff_url":"https://github.com/shelljs/shelljs/pull/451.diff","patch_url":"https://github.com/shelljs/shelljs/pull/451.patch","issue_url":"https://api.github.com/repos/shelljs/shelljs/issues/451","number":451,"state":"open","locked":false,"title":"Plugins","user":{"login":"ariporad","id":1817508,"avatar_url":"https://avatars.githubusercontent.com/u/1817508?v=3","gravatar_id":"","url":"https://api.github.com/users/ariporad","html_url":"https://github.com/ariporad","followers_url":"https://api.github.com/users/ariporad/followers","following_url":"https://api.github.com/users/ariporad/following{/other_user}","gists_url":"https://api.github.com/users/ariporad/gists{/gist_id}","starred_url":"https://api.github.com/users/ariporad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariporad/subscriptions","organizations_url":"https://api.github.com/users/ariporad/orgs","repos_url":"https://api.github.com/users/ariporad/repos","events_url":"https://api.github.com/users/ariporad/events{/privacy}","received_events_url":"https://api.github.com/users/ariporad/received_events","type":"User","site_admin":false},"body":"This is a very, very rough first draft of an implementation of #391. \r\n\r\nCurrently, I've written the code that will handle all the plugins, and started porting stuff from `common.js` to it.\r\n\r\nSome things about this PR:\r\n- It is written in ES6. Since the change to a plugin design will be a huge refactor, I figure this is a good chance to switch to babel. (@levithomason, what are your thoughts on setting up a build system, similar to shx, for this repo?)\r\n- It has no tests. It's very much a rough idea, some things won't work as some parts haven't been integrated.\r\n- I have `// XXX:` comments next to everything I'm unsure about, bikeshedding is requested.\r\n\r\nSo, @levithomason, @nfischer: What do you think?\r\n","created_at":"2016-05-29T03:05:26Z","updated_at":"2016-05-29T21:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/shelljs/shelljs/milestones/2","html_url":"https://github.com/shelljs/shelljs/milestones/v1.0.0","labels_url":"https://api.github.com/repos/shelljs/shelljs/milestones/2/labels","id":1548250,"number":2,"title":"v1.0.0","description":null,"creator":{"login":"nfischer","id":5801521,"avatar_url":"https://avatars.githubusercontent.com/u/5801521?v=3","gravatar_id":"","url":"https://api.github.com/users/nfischer","html_url":"https://github.com/nfischer","followers_url":"https://api.github.com/users/nfischer/followers","following_url":"https://api.github.com/users/nfischer/following{/other_user}","gists_url":"https://api.github.com/users/nfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfischer/subscriptions","organizations_url":"https://api.github.com/users/nfischer/orgs","repos_url":"https://api.github.com/users/nfischer/repos","events_url":"https://api.github.com/users/nfischer/events{/privacy}","received_events_url":"https://api.github.com/users/nfischer/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":1,"state":"open","created_at":"2016-01-28T04:45:24Z","updated_at":"2016-05-29T03:05:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/shelljs/shelljs/pulls/451/commits","review_comments_url":"https://api.github.com/repos/shelljs/shelljs/pulls/451/comments","review_comment_url":"https://api.github.com/repos/shelljs/shelljs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shelljs/shelljs/issues/451/comments","statuses_url":"https://api.github.com/repos/shelljs/shelljs/statuses/69f574b132fc65bd8e58a0f16d0d9352ac429b88","head":{"label":"shelljs:plugins","ref":"plugins","sha":"69f574b132fc65bd8e58a0f16d0d9352ac429b88","user":{"login":"shelljs","id":14236201,"avatar_url":"https://avatars.githubusercontent.com/u/14236201?v=3","gravatar_id":"","url":"https://api.github.com/users/shelljs","html_url":"https://github.com/shelljs","followers_url":"https://api.github.com/users/shelljs/followers","following_url":"https://api.github.com/users/shelljs/following{/other_user}","gists_url":"https://api.github.com/users/shelljs/gists{/gist_id}","starred_url":"https://api.github.com/users/shelljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelljs/subscriptions","organizations_url":"https://api.github.com/users/shelljs/orgs","repos_url":"https://api.github.com/users/shelljs/repos","events_url":"https://api.github.com/users/shelljs/events{/privacy}","received_events_url":"https://api.github.com/users/shelljs/received_events","type":"Organization","site_admin":false},"repo":{"id":3604157,"name":"shelljs","full_name":"shelljs/shelljs","owner":{"login":"shelljs","id":14236201,"avatar_url":"https://avatars.githubusercontent.com/u/14236201?v=3","gravatar_id":"","url":"https://api.github.com/users/shelljs","html_url":"https://github.com/shelljs","followers_url":"https://api.github.com/users/shelljs/followers","following_url":"https://api.github.com/users/shelljs/following{/other_user}","gists_url":"https://api.github.com/users/shelljs/gists{/gist_id}","starred_url":"https://api.github.com/users/shelljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelljs/subscriptions","organizations_url":"https://api.github.com/users/shelljs/orgs","repos_url":"https://api.github.com/users/shelljs/repos","events_url":"https://api.github.com/users/shelljs/events{/privacy}","received_events_url":"https://api.github.com/users/shelljs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shelljs/shelljs","description":"Portable Unix shell commands for Node.js","fork":false,"url":"https://api.github.com/repos/shelljs/shelljs","forks_url":"https://api.github.com/repos/shelljs/shelljs/forks","keys_url":"https://api.github.com/repos/shelljs/shelljs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shelljs/shelljs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shelljs/shelljs/teams","hooks_url":"https://api.github.com/repos/shelljs/shelljs/hooks","issue_events_url":"https://api.github.com/repos/shelljs/shelljs/issues/events{/number}","events_url":"https://api.github.com/repos/shelljs/shelljs/events","assignees_url":"https://api.github.com/repos/shelljs/shelljs/assignees{/user}","branches_url":"https://api.github.com/repos/shelljs/shelljs/branches{/branch}","tags_url":"https://api.github.com/repos/shelljs/shelljs/tags","blobs_url":"https://api.github.com/repos/shelljs/shelljs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shelljs/shelljs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shelljs/shelljs/git/refs{/sha}","trees_url":"https://api.github.com/repos/shelljs/shelljs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shelljs/shelljs/statuses/{sha}","languages_url":"https://api.github.com/repos/shelljs/shelljs/languages","stargazers_url":"https://api.github.com/repos/shelljs/shelljs/stargazers","contributors_url":"https://api.github.com/repos/shelljs/shelljs/contributors","subscribers_url":"https://api.github.com/repos/shelljs/shelljs/subscribers","subscription_url":"https://api.github.com/repos/shelljs/shelljs/subscription","commits_url":"https://api.github.com/repos/shelljs/shelljs/commits{/sha}","git_commits_url":"https://api.github.com/repos/shelljs/shelljs/git/commits{/sha}","comments_url":"https://api.github.com/repos/shelljs/shelljs/comments{/number}","issue_comment_url":"https://api.github.com/repos/shelljs/shelljs/issues/comments{/number}","contents_url":"https://api.github.com/repos/shelljs/shelljs/contents/{+path}","compare_url":"https://api.github.com/repos/shelljs/shelljs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shelljs/shelljs/merges","archive_url":"https://api.github.com/repos/shelljs/shelljs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shelljs/shelljs/downloads","issues_url":"https://api.github.com/repos/shelljs/shelljs/issues{/number}","pulls_url":"https://api.github.com/repos/shelljs/shelljs/pulls{/number}","milestones_url":"https://api.github.com/repos/shelljs/shelljs/milestones{/number}","notifications_url":"https://api.github.com/repos/shelljs/shelljs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shelljs/shelljs/labels{/name}","releases_url":"https://api.github.com/repos/shelljs/shelljs/releases{/id}","deployments_url":"https://api.github.com/repos/shelljs/shelljs/deployments","created_at":"2012-03-02T17:04:47Z","updated_at":"2016-05-29T03:42:40Z","pushed_at":"2016-05-29T21:47:29Z","git_url":"git://github.com/shelljs/shelljs.git","ssh_url":"git@github.com:shelljs/shelljs.git","clone_url":"https://github.com/shelljs/shelljs.git","svn_url":"https://github.com/shelljs/shelljs","homepage":"shelljs.org","size":850,"stargazers_count":4192,"watchers_count":4192,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"open_issues_count":63,"forks":270,"open_issues":63,"watchers":4192,"default_branch":"master"}},"base":{"label":"shelljs:master","ref":"master","sha":"497149cc2330737dd322b804dc198e5dcb21f6ba","user":{"login":"shelljs","id":14236201,"avatar_url":"https://avatars.githubusercontent.com/u/14236201?v=3","gravatar_id":"","url":"https://api.github.com/users/shelljs","html_url":"https://github.com/shelljs","followers_url":"https://api.github.com/users/shelljs/followers","following_url":"https://api.github.com/users/shelljs/following{/other_user}","gists_url":"https://api.github.com/users/shelljs/gists{/gist_id}","starred_url":"https://api.github.com/users/shelljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelljs/subscriptions","organizations_url":"https://api.github.com/users/shelljs/orgs","repos_url":"https://api.github.com/users/shelljs/repos","events_url":"https://api.github.com/users/shelljs/events{/privacy}","received_events_url":"https://api.github.com/users/shelljs/received_events","type":"Organization","site_admin":false},"repo":{"id":3604157,"name":"shelljs","full_name":"shelljs/shelljs","owner":{"login":"shelljs","id":14236201,"avatar_url":"https://avatars.githubusercontent.com/u/14236201?v=3","gravatar_id":"","url":"https://api.github.com/users/shelljs","html_url":"https://github.com/shelljs","followers_url":"https://api.github.com/users/shelljs/followers","following_url":"https://api.github.com/users/shelljs/following{/other_user}","gists_url":"https://api.github.com/users/shelljs/gists{/gist_id}","starred_url":"https://api.github.com/users/shelljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelljs/subscriptions","organizations_url":"https://api.github.com/users/shelljs/orgs","repos_url":"https://api.github.com/users/shelljs/repos","events_url":"https://api.github.com/users/shelljs/events{/privacy}","received_events_url":"https://api.github.com/users/shelljs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shelljs/shelljs","description":"Portable Unix shell commands for Node.js","fork":false,"url":"https://api.github.com/repos/shelljs/shelljs","forks_url":"https://api.github.com/repos/shelljs/shelljs/forks","keys_url":"https://api.github.com/repos/shelljs/shelljs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shelljs/shelljs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shelljs/shelljs/teams","hooks_url":"https://api.github.com/repos/shelljs/shelljs/hooks","issue_events_url":"https://api.github.com/repos/shelljs/shelljs/issues/events{/number}","events_url":"https://api.github.com/repos/shelljs/shelljs/events","assignees_url":"https://api.github.com/repos/shelljs/shelljs/assignees{/user}","branches_url":"https://api.github.com/repos/shelljs/shelljs/branches{/branch}","tags_url":"https://api.github.com/repos/shelljs/shelljs/tags","blobs_url":"https://api.github.com/repos/shelljs/shelljs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shelljs/shelljs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shelljs/shelljs/git/refs{/sha}","trees_url":"https://api.github.com/repos/shelljs/shelljs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shelljs/shelljs/statuses/{sha}","languages_url":"https://api.github.com/repos/shelljs/shelljs/languages","stargazers_url":"https://api.github.com/repos/shelljs/shelljs/stargazers","contributors_url":"https://api.github.com/repos/shelljs/shelljs/contributors","subscribers_url":"https://api.github.com/repos/shelljs/shelljs/subscribers","subscription_url":"https://api.github.com/repos/shelljs/shelljs/subscription","commits_url":"https://api.github.com/repos/shelljs/shelljs/commits{/sha}","git_commits_url":"https://api.github.com/repos/shelljs/shelljs/git/commits{/sha}","comments_url":"https://api.github.com/repos/shelljs/shelljs/comments{/number}","issue_comment_url":"https://api.github.com/repos/shelljs/shelljs/issues/comments{/number}","contents_url":"https://api.github.com/repos/shelljs/shelljs/contents/{+path}","compare_url":"https://api.github.com/repos/shelljs/shelljs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shelljs/shelljs/merges","archive_url":"https://api.github.com/repos/shelljs/shelljs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shelljs/shelljs/downloads","issues_url":"https://api.github.com/repos/shelljs/shelljs/issues{/number}","pulls_url":"https://api.github.com/repos/shelljs/shelljs/pulls{/number}","milestones_url":"https://api.github.com/repos/shelljs/shelljs/milestones{/number}","notifications_url":"https://api.github.com/repos/shelljs/shelljs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shelljs/shelljs/labels{/name}","releases_url":"https://api.github.com/repos/shelljs/shelljs/releases{/id}","deployments_url":"https://api.github.com/repos/shelljs/shelljs/deployments","created_at":"2012-03-02T17:04:47Z","updated_at":"2016-05-29T03:42:40Z","pushed_at":"2016-05-29T21:47:29Z","git_url":"git://github.com/shelljs/shelljs.git","ssh_url":"git@github.com:shelljs/shelljs.git","clone_url":"https://github.com/shelljs/shelljs.git","svn_url":"https://github.com/shelljs/shelljs","homepage":"shelljs.org","size":850,"stargazers_count":4192,"watchers_count":4192,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"open_issues_count":63,"forks":270,"open_issues":63,"watchers":4192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shelljs/shelljs/pulls/451"},"html":{"href":"https://github.com/shelljs/shelljs/pull/451"},"issue":{"href":"https://api.github.com/repos/shelljs/shelljs/issues/451"},"comments":{"href":"https://api.github.com/repos/shelljs/shelljs/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/shelljs/shelljs/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/shelljs/shelljs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shelljs/shelljs/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/shelljs/shelljs/statuses/69f574b132fc65bd8e58a0f16d0d9352ac429b88"}}}}
{"actor":{"display_login":"ariporad"}}