{"action":"created","comment":{"url":"https://api.github.com/repos/sysown/proxysql/pulls/comments/54841076","id":54841076,"diff_hunk":"@@ -1268,7 +1269,7 @@ void admin_session_handler(MySQL_Session *sess, ProxySQL_Admin *pa, PtrSize_t *p\n \tmemcpy(query,(char *)pkt->ptr+sizeof(mysql_hdr)+1,query_length-1);\n \tquery[query_length-1]=0;\n \n-\tchar *query_no_space=(char *)l_alloc(query_length);\t\n+\tchar *query_no_space=(char *)l_alloc(query_length);","path":"lib/ProxySQL_Admin.cpp","position":38,"original_position":38,"commit_id":"6a6f32c77e60592c42d38c2acc078fa567b44e76","original_commit_id":"6a6f32c77e60592c42d38c2acc078fa567b44e76","user":{"login":"aismail","id":82345,"avatar_url":"https://avatars.githubusercontent.com/u/82345?v=3","gravatar_id":"","url":"https://api.github.com/users/aismail","html_url":"https://github.com/aismail","followers_url":"https://api.github.com/users/aismail/followers","following_url":"https://api.github.com/users/aismail/following{/other_user}","gists_url":"https://api.github.com/users/aismail/gists{/gist_id}","starred_url":"https://api.github.com/users/aismail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aismail/subscriptions","organizations_url":"https://api.github.com/users/aismail/orgs","repos_url":"https://api.github.com/users/aismail/repos","events_url":"https://api.github.com/users/aismail/events{/privacy}","received_events_url":"https://api.github.com/users/aismail/received_events","type":"User","site_admin":false},"body":"What branch did you create this branch from? It seems that you picked up some commits that have nothing to do with your work.","created_at":"2016-03-03T06:36:40Z","updated_at":"2016-03-03T06:36:40Z","html_url":"https://github.com/sysown/proxysql/pull/499#discussion_r54841076","pull_request_url":"https://api.github.com/repos/sysown/proxysql/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/sysown/proxysql/pulls/comments/54841076"},"html":{"href":"https://github.com/sysown/proxysql/pull/499#discussion_r54841076"},"pull_request":{"href":"https://api.github.com/repos/sysown/proxysql/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/sysown/proxysql/pulls/499","id":61417196,"html_url":"https://github.com/sysown/proxysql/pull/499","diff_url":"https://github.com/sysown/proxysql/pull/499.diff","patch_url":"https://github.com/sysown/proxysql/pull/499.patch","issue_url":"https://api.github.com/repos/sysown/proxysql/issues/499","number":499,"state":"open","locked":false,"title":"T92 add consul script path variable","user":{"login":"iprunache","id":15313824,"avatar_url":"https://avatars.githubusercontent.com/u/15313824?v=3","gravatar_id":"","url":"https://api.github.com/users/iprunache","html_url":"https://github.com/iprunache","followers_url":"https://api.github.com/users/iprunache/followers","following_url":"https://api.github.com/users/iprunache/following{/other_user}","gists_url":"https://api.github.com/users/iprunache/gists{/gist_id}","starred_url":"https://api.github.com/users/iprunache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iprunache/subscriptions","organizations_url":"https://api.github.com/users/iprunache/orgs","repos_url":"https://api.github.com/users/iprunache/repos","events_url":"https://api.github.com/users/iprunache/events{/privacy}","received_events_url":"https://api.github.com/users/iprunache/received_events","type":"User","site_admin":false},"body":"Added the 'admin-proxysql_consul_path' variable to control the path to the proxysql-consul script. Default value is '/usr/local/bin/proxysql-consul'.\r\n\r\nSome minor patches ended up on this branch too:\r\n- forgot to add a proxysql-consul dependency\r\n- trimmed trailing whitespace since the editor I use does that on save automatically (common feature with IDEs and some editors)","created_at":"2016-03-02T15:31:34Z","updated_at":"2016-03-03T06:36:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2850d5e072304265498a695aeefab379a42b504d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sysown/proxysql/pulls/499/commits","review_comments_url":"https://api.github.com/repos/sysown/proxysql/pulls/499/comments","review_comment_url":"https://api.github.com/repos/sysown/proxysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sysown/proxysql/issues/499/comments","statuses_url":"https://api.github.com/repos/sysown/proxysql/statuses/6a6f32c77e60592c42d38c2acc078fa567b44e76","head":{"label":"sysown:T92_add_consul_script_path_variable","ref":"T92_add_consul_script_path_variable","sha":"6a6f32c77e60592c42d38c2acc078fa567b44e76","user":{"login":"sysown","id":10014617,"avatar_url":"https://avatars.githubusercontent.com/u/10014617?v=3","gravatar_id":"","url":"https://api.github.com/users/sysown","html_url":"https://github.com/sysown","followers_url":"https://api.github.com/users/sysown/followers","following_url":"https://api.github.com/users/sysown/following{/other_user}","gists_url":"https://api.github.com/users/sysown/gists{/gist_id}","starred_url":"https://api.github.com/users/sysown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysown/subscriptions","organizations_url":"https://api.github.com/users/sysown/orgs","repos_url":"https://api.github.com/users/sysown/repos","events_url":"https://api.github.com/users/sysown/events{/privacy}","received_events_url":"https://api.github.com/users/sysown/received_events","type":"Organization","site_admin":false},"repo":{"id":27358084,"name":"proxysql","full_name":"sysown/proxysql","owner":{"login":"sysown","id":10014617,"avatar_url":"https://avatars.githubusercontent.com/u/10014617?v=3","gravatar_id":"","url":"https://api.github.com/users/sysown","html_url":"https://github.com/sysown","followers_url":"https://api.github.com/users/sysown/followers","following_url":"https://api.github.com/users/sysown/following{/other_user}","gists_url":"https://api.github.com/users/sysown/gists{/gist_id}","starred_url":"https://api.github.com/users/sysown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysown/subscriptions","organizations_url":"https://api.github.com/users/sysown/orgs","repos_url":"https://api.github.com/users/sysown/repos","events_url":"https://api.github.com/users/sysown/events{/privacy}","received_events_url":"https://api.github.com/users/sysown/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sysown/proxysql","description":"","fork":false,"url":"https://api.github.com/repos/sysown/proxysql","forks_url":"https://api.github.com/repos/sysown/proxysql/forks","keys_url":"https://api.github.com/repos/sysown/proxysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sysown/proxysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sysown/proxysql/teams","hooks_url":"https://api.github.com/repos/sysown/proxysql/hooks","issue_events_url":"https://api.github.com/repos/sysown/proxysql/issues/events{/number}","events_url":"https://api.github.com/repos/sysown/proxysql/events","assignees_url":"https://api.github.com/repos/sysown/proxysql/assignees{/user}","branches_url":"https://api.github.com/repos/sysown/proxysql/branches{/branch}","tags_url":"https://api.github.com/repos/sysown/proxysql/tags","blobs_url":"https://api.github.com/repos/sysown/proxysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sysown/proxysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sysown/proxysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/sysown/proxysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sysown/proxysql/statuses/{sha}","languages_url":"https://api.github.com/repos/sysown/proxysql/languages","stargazers_url":"https://api.github.com/repos/sysown/proxysql/stargazers","contributors_url":"https://api.github.com/repos/sysown/proxysql/contributors","subscribers_url":"https://api.github.com/repos/sysown/proxysql/subscribers","subscription_url":"https://api.github.com/repos/sysown/proxysql/subscription","commits_url":"https://api.github.com/repos/sysown/proxysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/sysown/proxysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/sysown/proxysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/sysown/proxysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/sysown/proxysql/contents/{+path}","compare_url":"https://api.github.com/repos/sysown/proxysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sysown/proxysql/merges","archive_url":"https://api.github.com/repos/sysown/proxysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sysown/proxysql/downloads","issues_url":"https://api.github.com/repos/sysown/proxysql/issues{/number}","pulls_url":"https://api.github.com/repos/sysown/proxysql/pulls{/number}","milestones_url":"https://api.github.com/repos/sysown/proxysql/milestones{/number}","notifications_url":"https://api.github.com/repos/sysown/proxysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sysown/proxysql/labels{/name}","releases_url":"https://api.github.com/repos/sysown/proxysql/releases{/id}","deployments_url":"https://api.github.com/repos/sysown/proxysql/deployments","created_at":"2014-12-01T01:58:26Z","updated_at":"2016-02-19T12:09:00Z","pushed_at":"2016-03-02T15:54:52Z","git_url":"git://github.com/sysown/proxysql.git","ssh_url":"git@github.com:sysown/proxysql.git","clone_url":"https://github.com/sysown/proxysql.git","svn_url":"https://github.com/sysown/proxysql","homepage":"","size":21002,"stargazers_count":33,"watchers_count":33,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":169,"forks":16,"open_issues":169,"watchers":33,"default_branch":"master"}},"base":{"label":"sysown:v1.1.1","ref":"v1.1.1","sha":"c47767c74e5c7a9d44a357ff4d067258043fe62b","user":{"login":"sysown","id":10014617,"avatar_url":"https://avatars.githubusercontent.com/u/10014617?v=3","gravatar_id":"","url":"https://api.github.com/users/sysown","html_url":"https://github.com/sysown","followers_url":"https://api.github.com/users/sysown/followers","following_url":"https://api.github.com/users/sysown/following{/other_user}","gists_url":"https://api.github.com/users/sysown/gists{/gist_id}","starred_url":"https://api.github.com/users/sysown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysown/subscriptions","organizations_url":"https://api.github.com/users/sysown/orgs","repos_url":"https://api.github.com/users/sysown/repos","events_url":"https://api.github.com/users/sysown/events{/privacy}","received_events_url":"https://api.github.com/users/sysown/received_events","type":"Organization","site_admin":false},"repo":{"id":27358084,"name":"proxysql","full_name":"sysown/proxysql","owner":{"login":"sysown","id":10014617,"avatar_url":"https://avatars.githubusercontent.com/u/10014617?v=3","gravatar_id":"","url":"https://api.github.com/users/sysown","html_url":"https://github.com/sysown","followers_url":"https://api.github.com/users/sysown/followers","following_url":"https://api.github.com/users/sysown/following{/other_user}","gists_url":"https://api.github.com/users/sysown/gists{/gist_id}","starred_url":"https://api.github.com/users/sysown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysown/subscriptions","organizations_url":"https://api.github.com/users/sysown/orgs","repos_url":"https://api.github.com/users/sysown/repos","events_url":"https://api.github.com/users/sysown/events{/privacy}","received_events_url":"https://api.github.com/users/sysown/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sysown/proxysql","description":"","fork":false,"url":"https://api.github.com/repos/sysown/proxysql","forks_url":"https://api.github.com/repos/sysown/proxysql/forks","keys_url":"https://api.github.com/repos/sysown/proxysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sysown/proxysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sysown/proxysql/teams","hooks_url":"https://api.github.com/repos/sysown/proxysql/hooks","issue_events_url":"https://api.github.com/repos/sysown/proxysql/issues/events{/number}","events_url":"https://api.github.com/repos/sysown/proxysql/events","assignees_url":"https://api.github.com/repos/sysown/proxysql/assignees{/user}","branches_url":"https://api.github.com/repos/sysown/proxysql/branches{/branch}","tags_url":"https://api.github.com/repos/sysown/proxysql/tags","blobs_url":"https://api.github.com/repos/sysown/proxysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sysown/proxysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sysown/proxysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/sysown/proxysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sysown/proxysql/statuses/{sha}","languages_url":"https://api.github.com/repos/sysown/proxysql/languages","stargazers_url":"https://api.github.com/repos/sysown/proxysql/stargazers","contributors_url":"https://api.github.com/repos/sysown/proxysql/contributors","subscribers_url":"https://api.github.com/repos/sysown/proxysql/subscribers","subscription_url":"https://api.github.com/repos/sysown/proxysql/subscription","commits_url":"https://api.github.com/repos/sysown/proxysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/sysown/proxysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/sysown/proxysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/sysown/proxysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/sysown/proxysql/contents/{+path}","compare_url":"https://api.github.com/repos/sysown/proxysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sysown/proxysql/merges","archive_url":"https://api.github.com/repos/sysown/proxysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sysown/proxysql/downloads","issues_url":"https://api.github.com/repos/sysown/proxysql/issues{/number}","pulls_url":"https://api.github.com/repos/sysown/proxysql/pulls{/number}","milestones_url":"https://api.github.com/repos/sysown/proxysql/milestones{/number}","notifications_url":"https://api.github.com/repos/sysown/proxysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sysown/proxysql/labels{/name}","releases_url":"https://api.github.com/repos/sysown/proxysql/releases{/id}","deployments_url":"https://api.github.com/repos/sysown/proxysql/deployments","created_at":"2014-12-01T01:58:26Z","updated_at":"2016-02-19T12:09:00Z","pushed_at":"2016-03-02T15:54:52Z","git_url":"git://github.com/sysown/proxysql.git","ssh_url":"git@github.com:sysown/proxysql.git","clone_url":"https://github.com/sysown/proxysql.git","svn_url":"https://github.com/sysown/proxysql","homepage":"","size":21002,"stargazers_count":33,"watchers_count":33,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":169,"forks":16,"open_issues":169,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sysown/proxysql/pulls/499"},"html":{"href":"https://github.com/sysown/proxysql/pull/499"},"issue":{"href":"https://api.github.com/repos/sysown/proxysql/issues/499"},"comments":{"href":"https://api.github.com/repos/sysown/proxysql/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/sysown/proxysql/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/sysown/proxysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sysown/proxysql/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/sysown/proxysql/statuses/6a6f32c77e60592c42d38c2acc078fa567b44e76"}}}}