{"action":"opened","number":16319,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16319","id":98408294,"html_url":"https://github.com/apache/spark/pull/16319","diff_url":"https://github.com/apache/spark/pull/16319.diff","patch_url":"https://github.com/apache/spark/pull/16319.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16319","number":16319,"state":"open","locked":false,"title":"SPARK-18906 SQL - parsing CSV should return null for certain numeric …","user":{"login":"kubatyszko","id":826814,"avatar_url":"https://avatars.githubusercontent.com/u/826814?v=3","gravatar_id":"","url":"https://api.github.com/users/kubatyszko","html_url":"https://github.com/kubatyszko","followers_url":"https://api.github.com/users/kubatyszko/followers","following_url":"https://api.github.com/users/kubatyszko/following{/other_user}","gists_url":"https://api.github.com/users/kubatyszko/gists{/gist_id}","starred_url":"https://api.github.com/users/kubatyszko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubatyszko/subscriptions","organizations_url":"https://api.github.com/users/kubatyszko/orgs","repos_url":"https://api.github.com/users/kubatyszko/repos","events_url":"https://api.github.com/users/kubatyszko/events{/privacy}","received_events_url":"https://api.github.com/users/kubatyszko/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nCSV parser changes allowing parsing of numeric fields to fail and return null in such case.\r\nIn conjunction with \"nullValue\" option that may be used elsewhere this allows handling of certain csv sources that may use empty string as indication of null in one column and another specific value indicating null in another.\r\n\r\nCurrently the option \"nullValue\" can only be provided once and we can't assume that a data source won't have a single \"null\" indicator.\r\n\r\nThis problem is very similar to the one discussed here: https://github.com/databricks/spark-csv/issues/239\r\n\r\nSargis Dudaklayan and Kuba Tyszko - Zest Finance\r\n\r\n## How was this patch tested?\r\n\r\nThe patch was tested using freshly compiled spark version 2.0.1 on a sample data source that has \"null\" values in 2 columns, one specified as \"NA\" and set using nullValue and another column with \"\" indicating no integer value.\r\n\r\nPlease review http://spark.apache.org/contributing.html before opening a pull request.\r\n","created_at":"2016-12-16T21:48:05Z","updated_at":"2016-12-16T21:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16319/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16319/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16319/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0e6b41e01f8c9ac7c8a262bd58f2564a64a638e6","head":{"label":"Katlean:master","ref":"master","sha":"0e6b41e01f8c9ac7c8a262bd58f2564a64a638e6","user":{"login":"Katlean","id":145569,"avatar_url":"https://avatars.githubusercontent.com/u/145569?v=3","gravatar_id":"","url":"https://api.github.com/users/Katlean","html_url":"https://github.com/Katlean","followers_url":"https://api.github.com/users/Katlean/followers","following_url":"https://api.github.com/users/Katlean/following{/other_user}","gists_url":"https://api.github.com/users/Katlean/gists{/gist_id}","starred_url":"https://api.github.com/users/Katlean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katlean/subscriptions","organizations_url":"https://api.github.com/users/Katlean/orgs","repos_url":"https://api.github.com/users/Katlean/repos","events_url":"https://api.github.com/users/Katlean/events{/privacy}","received_events_url":"https://api.github.com/users/Katlean/received_events","type":"Organization","site_admin":false},"repo":{"id":76687494,"name":"spark","full_name":"Katlean/spark","owner":{"login":"Katlean","id":145569,"avatar_url":"https://avatars.githubusercontent.com/u/145569?v=3","gravatar_id":"","url":"https://api.github.com/users/Katlean","html_url":"https://github.com/Katlean","followers_url":"https://api.github.com/users/Katlean/followers","following_url":"https://api.github.com/users/Katlean/following{/other_user}","gists_url":"https://api.github.com/users/Katlean/gists{/gist_id}","starred_url":"https://api.github.com/users/Katlean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katlean/subscriptions","organizations_url":"https://api.github.com/users/Katlean/orgs","repos_url":"https://api.github.com/users/Katlean/repos","events_url":"https://api.github.com/users/Katlean/events{/privacy}","received_events_url":"https://api.github.com/users/Katlean/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katlean/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/Katlean/spark","forks_url":"https://api.github.com/repos/Katlean/spark/forks","keys_url":"https://api.github.com/repos/Katlean/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katlean/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katlean/spark/teams","hooks_url":"https://api.github.com/repos/Katlean/spark/hooks","issue_events_url":"https://api.github.com/repos/Katlean/spark/issues/events{/number}","events_url":"https://api.github.com/repos/Katlean/spark/events","assignees_url":"https://api.github.com/repos/Katlean/spark/assignees{/user}","branches_url":"https://api.github.com/repos/Katlean/spark/branches{/branch}","tags_url":"https://api.github.com/repos/Katlean/spark/tags","blobs_url":"https://api.github.com/repos/Katlean/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katlean/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katlean/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katlean/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katlean/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/Katlean/spark/languages","stargazers_url":"https://api.github.com/repos/Katlean/spark/stargazers","contributors_url":"https://api.github.com/repos/Katlean/spark/contributors","subscribers_url":"https://api.github.com/repos/Katlean/spark/subscribers","subscription_url":"https://api.github.com/repos/Katlean/spark/subscription","commits_url":"https://api.github.com/repos/Katlean/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katlean/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katlean/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katlean/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katlean/spark/contents/{+path}","compare_url":"https://api.github.com/repos/Katlean/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katlean/spark/merges","archive_url":"https://api.github.com/repos/Katlean/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katlean/spark/downloads","issues_url":"https://api.github.com/repos/Katlean/spark/issues{/number}","pulls_url":"https://api.github.com/repos/Katlean/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/Katlean/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/Katlean/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katlean/spark/labels{/name}","releases_url":"https://api.github.com/repos/Katlean/spark/releases{/id}","deployments_url":"https://api.github.com/repos/Katlean/spark/deployments","created_at":"2016-12-16T21:41:36Z","updated_at":"2016-12-16T21:42:00Z","pushed_at":"2016-12-16T21:46:52Z","git_url":"git://github.com/Katlean/spark.git","ssh_url":"git@github.com:Katlean/spark.git","clone_url":"https://github.com/Katlean/spark.git","svn_url":"https://github.com/Katlean/spark","homepage":null,"size":258356,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"295db8259b307cc0e7d9de44f5638c1aa7ef6047","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-12-16T21:08:27Z","pushed_at":"2016-12-16T21:48:06Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":258356,"stargazers_count":11098,"watchers_count":11098,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10409,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":435,"forks":10409,"open_issues":435,"watchers":11098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16319"},"html":{"href":"https://github.com/apache/spark/pull/16319"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16319"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16319/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16319/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16319/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0e6b41e01f8c9ac7c8a262bd58f2564a64a638e6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"kubatyszko"}}