{"action":"created","issue":{"url":"https://api.github.com/repos/prolic/zfc-rbac/issues/1","repository_url":"https://api.github.com/repos/prolic/zfc-rbac","labels_url":"https://api.github.com/repos/prolic/zfc-rbac/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/prolic/zfc-rbac/issues/1/comments","events_url":"https://api.github.com/repos/prolic/zfc-rbac/issues/1/events","html_url":"https://github.com/prolic/zfc-rbac/pull/1","id":167308298,"number":1,"title":"Fix for #340","user":{"login":"nasko","id":283257,"avatar_url":"https://avatars.githubusercontent.com/u/283257?v=3","gravatar_id":"","url":"https://api.github.com/users/nasko","html_url":"https://github.com/nasko","followers_url":"https://api.github.com/users/nasko/followers","following_url":"https://api.github.com/users/nasko/following{/other_user}","gists_url":"https://api.github.com/users/nasko/gists{/gist_id}","starred_url":"https://api.github.com/users/nasko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasko/subscriptions","organizations_url":"https://api.github.com/users/nasko/orgs","repos_url":"https://api.github.com/users/nasko/repos","events_url":"https://api.github.com/users/nasko/events{/privacy}","received_events_url":"https://api.github.com/users/nasko/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-25T08:14:25Z","updated_at":"2016-07-25T08:44:29Z","closed_at":"2016-07-25T08:36:24Z","pull_request":{"url":"https://api.github.com/repos/prolic/zfc-rbac/pulls/1","html_url":"https://github.com/prolic/zfc-rbac/pull/1","diff_url":"https://github.com/prolic/zfc-rbac/pull/1.diff","patch_url":"https://github.com/prolic/zfc-rbac/pull/1.patch"},"body":"I've modified only those tests, that are concerned with the changed implementation.\r\nHowever, although I tried to make the tests both ZF2 and ZF3-compatible, I'm not sure if the implementation will also work with ZF2, or if it would be BC"},"comment":{"url":"https://api.github.com/repos/prolic/zfc-rbac/issues/comments/234890348","html_url":"https://github.com/prolic/zfc-rbac/pull/1#issuecomment-234890348","issue_url":"https://api.github.com/repos/prolic/zfc-rbac/issues/1","id":234890348,"user":{"login":"prolic","id":394428,"avatar_url":"https://avatars.githubusercontent.com/u/394428?v=3","gravatar_id":"","url":"https://api.github.com/users/prolic","html_url":"https://github.com/prolic","followers_url":"https://api.github.com/users/prolic/followers","following_url":"https://api.github.com/users/prolic/following{/other_user}","gists_url":"https://api.github.com/users/prolic/gists{/gist_id}","starred_url":"https://api.github.com/users/prolic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prolic/subscriptions","organizations_url":"https://api.github.com/users/prolic/orgs","repos_url":"https://api.github.com/users/prolic/repos","events_url":"https://api.github.com/users/prolic/events{/privacy}","received_events_url":"https://api.github.com/users/prolic/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T08:44:29Z","updated_at":"2016-07-25T08:44:29Z","body":"@nasko I needed to revert, 4 tests are failing with zf3:\r\n\r\n```\r\nThere were 4 errors:\r\n\r\n1) ZfcRbacTest\\Guard\\ControllerGuardTest::testProperlySetUnauthorizedAndTriggerEventOnUnauthorization\r\n\r\nError: Call to undefined method Mock_EventManagerInterface_9d9e4254::triggerEvent()\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/src/ZfcRbac/Guard/AbstractGuard.php:74\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/tests/ZfcRbacTest/Guard/ControllerGuardTest.php:522\r\n\r\n2) ZfcRbacTest\\Guard\\ControllerPermissionsGuardTest::testProperlySetUnauthorizedAndTriggerEventOnUnauthorization\r\n\r\nError: Call to undefined method Mock_EventManagerInterface_9d9e4254::triggerEvent()\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/src/ZfcRbac/Guard/AbstractGuard.php:74\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/tests/ZfcRbacTest/Guard/ControllerPermissionsGuardTest.php:511\r\n\r\n3) ZfcRbacTest\\Guard\\RouteGuardTest::testProperlySetUnauthorizedAndTriggerEventOnUnauthorization\r\n\r\nError: Call to undefined method Mock_EventManagerInterface_9d9e4254::triggerEvent()\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/src/ZfcRbac/Guard/AbstractGuard.php:74\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/tests/ZfcRbacTest/Guard/RouteGuardTest.php:463\r\n\r\n4) ZfcRbacTest\\Guard\\RoutePermissionsGuardTest::testProperlySetUnauthorizedAndTriggerEventOnUnauthorization\r\n\r\nError: Call to undefined method Mock_EventManagerInterface_9d9e4254::triggerEvent()\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/src/ZfcRbac/Guard/AbstractGuard.php:74\r\n\r\n/home/travis/build/ZF-Commons/zfc-rbac/tests/ZfcRbacTest/Guard/RoutePermissionsGuardTest.php:441\r\n```"}}
{"actor":{"display_login":"prolic"}}