{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/49","id":80398462,"html_url":"https://github.com/apache/incubator-guacamole-client/pull/49","diff_url":"https://github.com/apache/incubator-guacamole-client/pull/49.diff","patch_url":"https://github.com/apache/incubator-guacamole-client/pull/49.patch","issue_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/49","number":49,"state":"closed","locked":false,"title":"GUACAMOLE-5: Define both connection and sharing profile parameters.","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"body":"The `ProtocolInfo` object (and the `Protocol` object in JavaScript) only define parameters from the perspective of connections. As sharing profiles will not necessarily use the exact same connection parameters, these parameters need to be defined independently.\r\n\r\nThis change splits the old `forms` property of `Protocol` into `connectionForms` and `sharingProfileForms`, such that connections and sharing profiles need not share the exact same parameters. An analogous change is made to `ProtocolInfo`.\r\n\r\nAs the only parameter currently supported by Guacamole's VNC, RDP, SSH, and telnet for joining connections is \"read-only\", that is the only parameter added to the JSON here.","created_at":"2016-08-08T06:05:32Z","updated_at":"2016-08-10T23:50:57Z","closed_at":"2016-08-10T23:50:57Z","merged_at":"2016-08-10T23:50:56Z","merge_commit_sha":"94ce151f69a7cbe5b98f86d9f7997c498955bb6c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/49/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/49/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/49/comments","statuses_url":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/94ce151f69a7cbe5b98f86d9f7997c498955bb6c","head":{"label":"mike-jumper:share-parameters","ref":"share-parameters","sha":"94ce151f69a7cbe5b98f86d9f7997c498955bb6c","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"repo":{"id":54506694,"name":"incubator-guacamole-client","full_name":"mike-jumper/incubator-guacamole-client","owner":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-jumper/incubator-guacamole-client","description":"Mirror of Apache Guacamole Client (Incubating)","fork":true,"url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client","forks_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/forks","keys_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/teams","hooks_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/events","assignees_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/tags","blobs_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/languages","stargazers_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/subscription","commits_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/merges","archive_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/downloads","issues_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/mike-jumper/incubator-guacamole-client/deployments","created_at":"2016-03-22T20:30:39Z","updated_at":"2016-03-22T20:30:42Z","pushed_at":"2016-08-08T18:45:47Z","git_url":"git://github.com/mike-jumper/incubator-guacamole-client.git","ssh_url":"git@github.com:mike-jumper/incubator-guacamole-client.git","clone_url":"https://github.com/mike-jumper/incubator-guacamole-client.git","svn_url":"https://github.com/mike-jumper/incubator-guacamole-client","homepage":null,"size":10942,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"989ad395132f319a18bfb2b6cf6ed2ff8c0152b1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":54452622,"name":"incubator-guacamole-client","full_name":"apache/incubator-guacamole-client","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-guacamole-client","description":"Mirror of Apache Guacamole Client (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-guacamole-client","forks_url":"https://api.github.com/repos/apache/incubator-guacamole-client/forks","keys_url":"https://api.github.com/repos/apache/incubator-guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-guacamole-client/teams","hooks_url":"https://api.github.com/repos/apache/incubator-guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-guacamole-client/events","assignees_url":"https://api.github.com/repos/apache/incubator-guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-guacamole-client/tags","blobs_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-guacamole-client/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-guacamole-client/subscription","commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-guacamole-client/merges","archive_url":"https://api.github.com/repos/apache/incubator-guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-guacamole-client/downloads","issues_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/deployments","created_at":"2016-03-22T07:00:06Z","updated_at":"2016-08-09T01:15:07Z","pushed_at":"2016-08-10T23:50:56Z","git_url":"git://github.com/apache/incubator-guacamole-client.git","ssh_url":"git@github.com:apache/incubator-guacamole-client.git","clone_url":"https://github.com/apache/incubator-guacamole-client.git","svn_url":"https://github.com/apache/incubator-guacamole-client","homepage":null,"size":10855,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":"git://git.apache.org/incubator-guacamole-client.git","open_issues_count":3,"forks":27,"open_issues":3,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/49"},"html":{"href":"https://github.com/apache/incubator-guacamole-client/pull/49"},"issue":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/49"},"comments":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/94ce151f69a7cbe5b98f86d9f7997c498955bb6c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asfgit","id":1341245,"avatar_url":"https://avatars.githubusercontent.com/u/1341245?v=3","gravatar_id":"","url":"https://api.github.com/users/asfgit","html_url":"https://github.com/asfgit","followers_url":"https://api.github.com/users/asfgit/followers","following_url":"https://api.github.com/users/asfgit/following{/other_user}","gists_url":"https://api.github.com/users/asfgit/gists{/gist_id}","starred_url":"https://api.github.com/users/asfgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfgit/subscriptions","organizations_url":"https://api.github.com/users/asfgit/orgs","repos_url":"https://api.github.com/users/asfgit/repos","events_url":"https://api.github.com/users/asfgit/events{/privacy}","received_events_url":"https://api.github.com/users/asfgit/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":194,"deletions":33,"changed_files":12}}
{"actor":{"display_login":"asfgit"}}