{"action":"created","issue":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/515","labels_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/515/labels{/name}","comments_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/515/comments","events_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/515/events","html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/515","id":127557059,"number":515,"title":"always pass Serializer.serialize the request as a second argument","user":{"login":"2468ben","id":597252,"avatar_url":"https://avatars.githubusercontent.com/u/597252?v=3","gravatar_id":"","url":"https://api.github.com/users/2468ben","html_url":"https://github.com/2468ben","followers_url":"https://api.github.com/users/2468ben/followers","following_url":"https://api.github.com/users/2468ben/following{/other_user}","gists_url":"https://api.github.com/users/2468ben/gists{/gist_id}","starred_url":"https://api.github.com/users/2468ben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2468ben/subscriptions","organizations_url":"https://api.github.com/users/2468ben/orgs","repos_url":"https://api.github.com/users/2468ben/repos","events_url":"https://api.github.com/users/2468ben/events{/privacy}","received_events_url":"https://api.github.com/users/2468ben/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-19T22:46:31Z","updated_at":"2016-01-25T04:12:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/515","html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/515","diff_url":"https://github.com/samselikoff/ember-cli-mirage/pull/515.diff","patch_url":"https://github.com/samselikoff/ember-cli-mirage/pull/515.patch"},"body":"http://www.ember-cli-mirage.com/docs/v0.2.0-beta.3/serializers/#serializeresponse-request\r\n\r\nSometimes while on the way to the serializer's serialize function, the request argument gets left behind. These changes should make sure it gets there."},"comment":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/comments/174392632","html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/515#issuecomment-174392632","issue_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/515","id":174392632,"user":{"login":"samselikoff","id":2922250,"avatar_url":"https://avatars.githubusercontent.com/u/2922250?v=3","gravatar_id":"","url":"https://api.github.com/users/samselikoff","html_url":"https://github.com/samselikoff","followers_url":"https://api.github.com/users/samselikoff/followers","following_url":"https://api.github.com/users/samselikoff/following{/other_user}","gists_url":"https://api.github.com/users/samselikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/samselikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samselikoff/subscriptions","organizations_url":"https://api.github.com/users/samselikoff/orgs","repos_url":"https://api.github.com/users/samselikoff/repos","events_url":"https://api.github.com/users/samselikoff/events{/privacy}","received_events_url":"https://api.github.com/users/samselikoff/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T04:12:26Z","updated_at":"2016-01-25T04:12:26Z","body":"Good catch... how did you discover this? Was there a particular bug? Ideally we'd think of a failing test along with these updates.\r\n\r\nIf users need to override `#serialize` they should *always* get the request... I think it got left behind in a few of these methods, simply because they are implementation details of the default serialize handler, and they don't rely on data from the `request` object (as opposed to, for example, the json-api-serializer).\r\n\r\nThere's a refactoring that needs to happen, moving most of these methods into the `serializer` class (they are really the job of the serializer, not the registry). In any case, I'm interested to hear how this came up."}}