{"action":"opened","number":505,"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly/pulls/505","id":88904951,"html_url":"https://github.com/patternfly/patternfly/pull/505","diff_url":"https://github.com/patternfly/patternfly/pull/505.diff","patch_url":"https://github.com/patternfly/patternfly/pull/505.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly/issues/505","number":505,"state":"open","locked":false,"title":"Added labels for a11y.","user":{"login":"dlabrecq","id":17481322,"avatar_url":"https://avatars.githubusercontent.com/u/17481322?v=3","gravatar_id":"","url":"https://api.github.com/users/dlabrecq","html_url":"https://github.com/dlabrecq","followers_url":"https://api.github.com/users/dlabrecq/followers","following_url":"https://api.github.com/users/dlabrecq/following{/other_user}","gists_url":"https://api.github.com/users/dlabrecq/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabrecq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabrecq/subscriptions","organizations_url":"https://api.github.com/users/dlabrecq/orgs","repos_url":"https://api.github.com/users/dlabrecq/repos","events_url":"https://api.github.com/users/dlabrecq/events{/privacy}","received_events_url":"https://api.github.com/users/dlabrecq/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdded labels for a11y. Note that the labels are positioned off-screen, hidden from view, but still accessible to screen readers.\r\n\r\nThe approach is documented here: http://webaim.org/techniques/css/invisiblecontent/\r\n\r\nThis addresses Gabriel's code review comments from:\r\n\r\nhttps://github.com/patternfly/patternfly/pull/500\r\n\r\n## Changes\r\n\r\nWrite a list of changes the PR introduces\r\n\r\n* Added labels for a11y\r\n* Added style to position labels off-screen\r\n* Change 03\r\n\r\n## Link to rawgit and/or image\r\n\r\nhttps://rawgit.com/dlabrecq/patternfly/table-view-dist/dist/tests/datatables.html\r\n\r\nThis is an image:\r\n\r\n![screen shot 2016-10-11 at 4 22 49 pm](https://cloud.githubusercontent.com/assets/17481322/19287440/bc6456be-8fcf-11e6-9b4b-3269f10835d9.png)\r\n\r\n## PR checklist (if relevant)\r\n\r\n- [ ] **Cross browser**: works in IE9\r\n- [ ] **Cross browser**: works in IE10\r\n- [ ] **Cross browser**: works in IE11\r\n- [ ] **Cross browser**: works in Edge\r\n- [x] **Cross browser**: works in Chrome\r\n- [x] **Cross browser**: works in Firefox\r\n- [ ] **Cross browser**: works in Safari\r\n- [ ] **Cross browser**: works in Opera\r\n- [ ] **Responsive**: works in extra small, small, medium and large view ports.\r\n- [x] **Preview the PR**: An image or a URL for designer to preview this PR is provided.","created_at":"2016-10-11T20:28:58Z","updated_at":"2016-10-11T20:28:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly/pulls/505/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly/pulls/505/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly/issues/505/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly/statuses/48b007e972e782fbc172022ac4963fa2257e8bdf","head":{"label":"dlabrecq:table-view-a11y","ref":"table-view-a11y","sha":"48b007e972e782fbc172022ac4963fa2257e8bdf","user":{"login":"dlabrecq","id":17481322,"avatar_url":"https://avatars.githubusercontent.com/u/17481322?v=3","gravatar_id":"","url":"https://api.github.com/users/dlabrecq","html_url":"https://github.com/dlabrecq","followers_url":"https://api.github.com/users/dlabrecq/followers","following_url":"https://api.github.com/users/dlabrecq/following{/other_user}","gists_url":"https://api.github.com/users/dlabrecq/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabrecq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabrecq/subscriptions","organizations_url":"https://api.github.com/users/dlabrecq/orgs","repos_url":"https://api.github.com/users/dlabrecq/repos","events_url":"https://api.github.com/users/dlabrecq/events{/privacy}","received_events_url":"https://api.github.com/users/dlabrecq/received_events","type":"User","site_admin":false},"repo":{"id":53080529,"name":"patternfly","full_name":"dlabrecq/patternfly","owner":{"login":"dlabrecq","id":17481322,"avatar_url":"https://avatars.githubusercontent.com/u/17481322?v=3","gravatar_id":"","url":"https://api.github.com/users/dlabrecq","html_url":"https://github.com/dlabrecq","followers_url":"https://api.github.com/users/dlabrecq/followers","following_url":"https://api.github.com/users/dlabrecq/following{/other_user}","gists_url":"https://api.github.com/users/dlabrecq/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabrecq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabrecq/subscriptions","organizations_url":"https://api.github.com/users/dlabrecq/orgs","repos_url":"https://api.github.com/users/dlabrecq/repos","events_url":"https://api.github.com/users/dlabrecq/events{/privacy}","received_events_url":"https://api.github.com/users/dlabrecq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dlabrecq/patternfly","description":"PatternFly open interface project","fork":true,"url":"https://api.github.com/repos/dlabrecq/patternfly","forks_url":"https://api.github.com/repos/dlabrecq/patternfly/forks","keys_url":"https://api.github.com/repos/dlabrecq/patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlabrecq/patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlabrecq/patternfly/teams","hooks_url":"https://api.github.com/repos/dlabrecq/patternfly/hooks","issue_events_url":"https://api.github.com/repos/dlabrecq/patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/dlabrecq/patternfly/events","assignees_url":"https://api.github.com/repos/dlabrecq/patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/dlabrecq/patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/dlabrecq/patternfly/tags","blobs_url":"https://api.github.com/repos/dlabrecq/patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlabrecq/patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlabrecq/patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlabrecq/patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlabrecq/patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/dlabrecq/patternfly/languages","stargazers_url":"https://api.github.com/repos/dlabrecq/patternfly/stargazers","contributors_url":"https://api.github.com/repos/dlabrecq/patternfly/contributors","subscribers_url":"https://api.github.com/repos/dlabrecq/patternfly/subscribers","subscription_url":"https://api.github.com/repos/dlabrecq/patternfly/subscription","commits_url":"https://api.github.com/repos/dlabrecq/patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlabrecq/patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlabrecq/patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlabrecq/patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlabrecq/patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/dlabrecq/patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlabrecq/patternfly/merges","archive_url":"https://api.github.com/repos/dlabrecq/patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlabrecq/patternfly/downloads","issues_url":"https://api.github.com/repos/dlabrecq/patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/dlabrecq/patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/dlabrecq/patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/dlabrecq/patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlabrecq/patternfly/labels{/name}","releases_url":"https://api.github.com/repos/dlabrecq/patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/dlabrecq/patternfly/deployments","created_at":"2016-03-03T20:23:13Z","updated_at":"2016-03-03T20:23:15Z","pushed_at":"2016-10-11T20:24:37Z","git_url":"git://github.com/dlabrecq/patternfly.git","ssh_url":"git@github.com:dlabrecq/patternfly.git","clone_url":"https://github.com/dlabrecq/patternfly.git","svn_url":"https://github.com/dlabrecq/patternfly","homepage":"https://www.patternfly.org/","size":15221,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:table-view","ref":"table-view","sha":"f433848b2499c7af9b7a3ce62467504374851e06","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":16493298,"name":"patternfly","full_name":"patternfly/patternfly","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/patternfly","description":"PatternFly open interface project","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly","forks_url":"https://api.github.com/repos/patternfly/patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly/deployments","created_at":"2014-02-03T21:18:00Z","updated_at":"2016-10-10T09:01:59Z","pushed_at":"2016-10-11T19:34:39Z","git_url":"git://github.com/patternfly/patternfly.git","ssh_url":"git@github.com:patternfly/patternfly.git","clone_url":"https://github.com/patternfly/patternfly.git","svn_url":"https://github.com/patternfly/patternfly","homepage":"https://www.patternfly.org/","size":15954,"stargazers_count":482,"watchers_count":482,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":68,"forks":140,"open_issues":68,"watchers":482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/505"},"html":{"href":"https://github.com/patternfly/patternfly/pull/505"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly/issues/505"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly/statuses/48b007e972e782fbc172022ac4963fa2257e8bdf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"dlabrecq"}}