{"action":"created","issue":{"url":"https://api.github.com/repos/OlegLevoniuk/Java_Tutorial/issues/4","repository_url":"https://api.github.com/repos/OlegLevoniuk/Java_Tutorial","labels_url":"https://api.github.com/repos/OlegLevoniuk/Java_Tutorial/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/OlegLevoniuk/Java_Tutorial/issues/4/comments","events_url":"https://api.github.com/repos/OlegLevoniuk/Java_Tutorial/issues/4/events","html_url":"https://github.com/OlegLevoniuk/Java_Tutorial/issues/4","id":158005234,"number":4,"title":"Add logging support","user":{"login":"igor-levoniuk","id":1905626,"avatar_url":"https://avatars.githubusercontent.com/u/1905626?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-levoniuk","html_url":"https://github.com/igor-levoniuk","followers_url":"https://api.github.com/users/igor-levoniuk/followers","following_url":"https://api.github.com/users/igor-levoniuk/following{/other_user}","gists_url":"https://api.github.com/users/igor-levoniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-levoniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-levoniuk/subscriptions","organizations_url":"https://api.github.com/users/igor-levoniuk/orgs","repos_url":"https://api.github.com/users/igor-levoniuk/repos","events_url":"https://api.github.com/users/igor-levoniuk/events{/privacy}","received_events_url":"https://api.github.com/users/igor-levoniuk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-01T20:56:53Z","updated_at":"2016-07-19T18:30:03Z","closed_at":null,"body":"Usually, you need to know what exactly happens inside the application during its work. Often you don't have a UI for it or UI is used by end user and you need some other way to get that information.\r\n\r\nThat way is out there and that is logging - during execution your application writes messages which end up in a text files called log files. By reading that you can get an insight of what what going on with you app in a particular point in time.\r\n\r\nGet yourself familiar with log4j or logback frameworks. You can either use them directly within your code or access them through another framework called slf4j (preferred way - that would keep you abstracted from concrete implementation of logging framework). Add proper logging for your project."},"comment":{"url":"https://api.github.com/repos/OlegLevoniuk/Java_Tutorial/issues/comments/233723852","html_url":"https://github.com/OlegLevoniuk/Java_Tutorial/issues/4#issuecomment-233723852","issue_url":"https://api.github.com/repos/OlegLevoniuk/Java_Tutorial/issues/4","id":233723852,"user":{"login":"igor-levoniuk","id":1905626,"avatar_url":"https://avatars.githubusercontent.com/u/1905626?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-levoniuk","html_url":"https://github.com/igor-levoniuk","followers_url":"https://api.github.com/users/igor-levoniuk/followers","following_url":"https://api.github.com/users/igor-levoniuk/following{/other_user}","gists_url":"https://api.github.com/users/igor-levoniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-levoniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-levoniuk/subscriptions","organizations_url":"https://api.github.com/users/igor-levoniuk/orgs","repos_url":"https://api.github.com/users/igor-levoniuk/repos","events_url":"https://api.github.com/users/igor-levoniuk/events{/privacy}","received_events_url":"https://api.github.com/users/igor-levoniuk/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T18:30:03Z","updated_at":"2016-07-19T18:30:03Z","body":"Looks good. Although, in general its best for each class to have its own logger (created in a way which you've used in IsItHere class. The reason for that log4j config allows enabling logging only for particular class/package, and if you pass logger from one class to the other one this mechanism breaks.\r\nOther point is, on line 23, why do we log this on info level? Isn't this warn or error? Also, you usually want to log all the details you have, so if something fails you could understand exactly what was going on in the system"}}
{"actor":{"display_login":"igor-levoniuk"}}