{"action":"created","issue":{"url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/issues/13","repository_url":"https://api.github.com/repos/alces-software/flight-aws-marketplace","labels_url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/issues/13/comments","events_url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/issues/13/events","html_url":"https://github.com/alces-software/flight-aws-marketplace/issues/13","id":148994791,"number":13,"title":"Launching Enhancements","user":{"login":"ste78","id":503613,"avatar_url":"https://avatars.githubusercontent.com/u/503613?v=3","gravatar_id":"","url":"https://api.github.com/users/ste78","html_url":"https://github.com/ste78","followers_url":"https://api.github.com/users/ste78/followers","following_url":"https://api.github.com/users/ste78/following{/other_user}","gists_url":"https://api.github.com/users/ste78/gists{/gist_id}","starred_url":"https://api.github.com/users/ste78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ste78/subscriptions","organizations_url":"https://api.github.com/users/ste78/orgs","repos_url":"https://api.github.com/users/ste78/repos","events_url":"https://api.github.com/users/ste78/events{/privacy}","received_events_url":"https://api.github.com/users/ste78/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/labels/Feature","name":"Feature","color":"5319e7"},{"url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/labels/ready","name":"ready","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/milestones/1","html_url":"https://github.com/alces-software/flight-aws-marketplace/milestones/2016.2","labels_url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/milestones/1/labels","id":1689638,"number":1,"title":"2016.2","description":"","creator":{"login":"vlj91","id":10548294,"avatar_url":"https://avatars.githubusercontent.com/u/10548294?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj91","html_url":"https://github.com/vlj91","followers_url":"https://api.github.com/users/vlj91/followers","following_url":"https://api.github.com/users/vlj91/following{/other_user}","gists_url":"https://api.github.com/users/vlj91/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj91/subscriptions","organizations_url":"https://api.github.com/users/vlj91/orgs","repos_url":"https://api.github.com/users/vlj91/repos","events_url":"https://api.github.com/users/vlj91/events{/privacy}","received_events_url":"https://api.github.com/users/vlj91/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":7,"state":"open","created_at":"2016-04-07T14:31:32Z","updated_at":"2016-04-18T08:32:47Z","due_on":"2016-05-15T23:00:00Z","closed_at":null},"comments":1,"created_at":"2016-04-17T20:47:08Z","updated_at":"2016-04-20T11:26:45Z","closed_at":null,"body":"Launching enhancements:\r\n - user specified VPC\r\n - true autoscaling\r\n"},"comment":{"url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/issues/comments/212387214","html_url":"https://github.com/alces-software/flight-aws-marketplace/issues/13#issuecomment-212387214","issue_url":"https://api.github.com/repos/alces-software/flight-aws-marketplace/issues/13","id":212387214,"user":{"login":"vlj91","id":10548294,"avatar_url":"https://avatars.githubusercontent.com/u/10548294?v=3","gravatar_id":"","url":"https://api.github.com/users/vlj91","html_url":"https://github.com/vlj91","followers_url":"https://api.github.com/users/vlj91/followers","following_url":"https://api.github.com/users/vlj91/following{/other_user}","gists_url":"https://api.github.com/users/vlj91/gists{/gist_id}","starred_url":"https://api.github.com/users/vlj91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlj91/subscriptions","organizations_url":"https://api.github.com/users/vlj91/orgs","repos_url":"https://api.github.com/users/vlj91/repos","events_url":"https://api.github.com/users/vlj91/events{/privacy}","received_events_url":"https://api.github.com/users/vlj91/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T11:26:45Z","updated_at":"2016-04-20T11:26:45Z","body":"Regarding user specified VPC/network creation if no network parameters offered - \r\n\r\nWhen playing previously I came across the issue that whilst completely okay to do, there is an issue with the cluster login node and its dependency. \r\n\r\nWhen creating a private network - the login node must depend on the `InternetGateway` resource, to ensure that the stack deletes cleanly and in the right order. With a user specified VPC - the dependency on the internet gateway cannot exist, as the resource does not exist as it was never created. \r\n\r\nI've looked, but cannot see an appropriate way of saying if the internet gateway resource doesn't exist then don't depend on it. \r\n\r\nThe only appropriate method I can really see to fix this is to have two sets of cluster login node resource blocks: \r\n\r\n1. create login node and depend on internet gateway resource if private cluster network is created\r\n2. create login node with no dependency as no network creation has taken place\r\n\r\nIt doesn't really present a problem but also isn't the cleanest method of doing it. What are your thoughts? "}}