{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/51131426","id":51131426,"diff_hunk":"@@ -161,6 +161,9 @@ func (n *network) destroySandbox() {\n \tif sbox != nil {\n \t\tfor _, iface := range sbox.Info().Interfaces() {\n \t\t\tiface.Remove()","path":"drivers/overlay/ov_network.go","position":3,"original_position":3,"commit_id":"a3eadc483927124e249be3cf95cf067984222359","original_commit_id":"a3eadc483927124e249be3cf95cf067984222359","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"Why is this retained ? Shouldnt this call to `Remove()` be removed ?","created_at":"2016-01-28T14:52:03Z","updated_at":"2016-01-28T14:52:03Z","html_url":"https://github.com/docker/libnetwork/pull/905#discussion_r51131426","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/905","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/51131426"},"html":{"href":"https://github.com/docker/libnetwork/pull/905#discussion_r51131426"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/905"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/905","id":57420742,"html_url":"https://github.com/docker/libnetwork/pull/905","diff_url":"https://github.com/docker/libnetwork/pull/905.diff","patch_url":"https://github.com/docker/libnetwork/pull/905.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/905","number":905,"state":"open","locked":false,"title":"Delete the interface on endpoint delete in overlay","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"body":"- Attempt the veth delete only after both ends are moved into the default network namespace.\r\n  Which is after both driver.Leave() and sandbox.clearNetworkResources() are called.\r\n\r\nSigned-off-by: Alessandro Boch <aboch@docker.com>","created_at":"2016-01-27T20:52:12Z","updated_at":"2016-01-28T14:52:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"781826dd1e059d794e936c8e16148ce320e5c4fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/905/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/905/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/905/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/a3eadc483927124e249be3cf95cf067984222359","head":{"label":"aboch:lv","ref":"lv","sha":"a3eadc483927124e249be3cf95cf067984222359","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"repo":{"id":34007834,"name":"libnetwork_new","full_name":"aboch/libnetwork_new","owner":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aboch/libnetwork_new","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/aboch/libnetwork_new","forks_url":"https://api.github.com/repos/aboch/libnetwork_new/forks","keys_url":"https://api.github.com/repos/aboch/libnetwork_new/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aboch/libnetwork_new/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aboch/libnetwork_new/teams","hooks_url":"https://api.github.com/repos/aboch/libnetwork_new/hooks","issue_events_url":"https://api.github.com/repos/aboch/libnetwork_new/issues/events{/number}","events_url":"https://api.github.com/repos/aboch/libnetwork_new/events","assignees_url":"https://api.github.com/repos/aboch/libnetwork_new/assignees{/user}","branches_url":"https://api.github.com/repos/aboch/libnetwork_new/branches{/branch}","tags_url":"https://api.github.com/repos/aboch/libnetwork_new/tags","blobs_url":"https://api.github.com/repos/aboch/libnetwork_new/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aboch/libnetwork_new/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aboch/libnetwork_new/git/refs{/sha}","trees_url":"https://api.github.com/repos/aboch/libnetwork_new/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aboch/libnetwork_new/statuses/{sha}","languages_url":"https://api.github.com/repos/aboch/libnetwork_new/languages","stargazers_url":"https://api.github.com/repos/aboch/libnetwork_new/stargazers","contributors_url":"https://api.github.com/repos/aboch/libnetwork_new/contributors","subscribers_url":"https://api.github.com/repos/aboch/libnetwork_new/subscribers","subscription_url":"https://api.github.com/repos/aboch/libnetwork_new/subscription","commits_url":"https://api.github.com/repos/aboch/libnetwork_new/commits{/sha}","git_commits_url":"https://api.github.com/repos/aboch/libnetwork_new/git/commits{/sha}","comments_url":"https://api.github.com/repos/aboch/libnetwork_new/comments{/number}","issue_comment_url":"https://api.github.com/repos/aboch/libnetwork_new/issues/comments{/number}","contents_url":"https://api.github.com/repos/aboch/libnetwork_new/contents/{+path}","compare_url":"https://api.github.com/repos/aboch/libnetwork_new/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aboch/libnetwork_new/merges","archive_url":"https://api.github.com/repos/aboch/libnetwork_new/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aboch/libnetwork_new/downloads","issues_url":"https://api.github.com/repos/aboch/libnetwork_new/issues{/number}","pulls_url":"https://api.github.com/repos/aboch/libnetwork_new/pulls{/number}","milestones_url":"https://api.github.com/repos/aboch/libnetwork_new/milestones{/number}","notifications_url":"https://api.github.com/repos/aboch/libnetwork_new/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aboch/libnetwork_new/labels{/name}","releases_url":"https://api.github.com/repos/aboch/libnetwork_new/releases{/id}","deployments_url":"https://api.github.com/repos/aboch/libnetwork_new/deployments","created_at":"2015-04-15T17:16:09Z","updated_at":"2016-01-27T21:23:38Z","pushed_at":"2016-01-27T21:23:14Z","git_url":"git://github.com/aboch/libnetwork_new.git","ssh_url":"git@github.com:aboch/libnetwork_new.git","clone_url":"https://github.com/aboch/libnetwork_new.git","svn_url":"https://github.com/aboch/libnetwork_new","homepage":"","size":7269,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"82252efa714ac37c0946eb3fa50c3e888f961581","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"Docker Networking","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/docker/libnetwork/deployments","created_at":"2015-02-20T01:20:15Z","updated_at":"2016-01-27T01:34:25Z","pushed_at":"2016-01-27T20:52:12Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":10925,"stargazers_count":584,"watchers_count":584,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":139,"forks":254,"open_issues":139,"watchers":584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/905"},"html":{"href":"https://github.com/docker/libnetwork/pull/905"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/905"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/905/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/905/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/905/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/a3eadc483927124e249be3cf95cf067984222359"}}}}