{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68680408","id":68680408,"diff_hunk":"@@ -21,8 +21,53 @@ set -o nounset\n set -o pipefail\n set -o xtrace\n \n+# include shell2junit library\n+source <(curl -fsS --retry 3 'https://raw.githubusercontent.com/kubernetes/kubernetes/master/third_party/forked/shell2junit/sh2ju.sh')\n+\n+# Have cmd/e2e run by goe2e.sh generate JUnit report in ${WORKSPACE}/junit*.xml\n+ARTIFACTS=${WORKSPACE}/_artifacts\n+mkdir -p ${ARTIFACTS}\n+\n+# E2E runner stages\n+STAGE_PRE=\"PRE-SETUP\"\n+STAGE_SETUP=\"SETUP\"\n+STAGE_CLEANUP=\"CLEANUP\"\n+STAGE_KUBEMARK=\"KUBEMARK\"\n+\n : ${KUBE_GCS_RELEASE_BUCKET:=\"kubernetes-release\"}\n \n+# record_command records the command output and error message in junit format\n+# it expects the first argument to be the class and the second to be the name of the command\n+# Example:\n+# record_command PRESETUP curltest curl google.com\n+# record_command CLEANUP check false\n+#\n+# WARNING: variable changes will NOT be effective after record_command returns\n+function record_command() {\n+    set +o xtrace\n+    set +o nounset\n+    set +o errexit\n+\n+    class=$1\n+    shift\n+    name=$1\n+    shift\n+    echo \"Recording: ${class} ${name}\"\n+    echo \"Running command: $@\"\n+    local -r ret=$(juLog -output=\"${ARTIFACTS}\" -class=\"${class}\" -name=\"${name}\" \"$@\")\n+\n+    set -o nounset\n+    set -o errexit\n+    set -o xtrace\n+\n+    # since record_command disable errexit, exit script on failure.\n+    local -r found=$(echo \"${ret}\" | grep -c \"+++ exit code: 0\")\n+    if [ ${found} -le 0 ]; then","path":"hack/jenkins/e2e-runner.sh","position":45,"original_position":45,"commit_id":"0b2922834a2adc130539f915f2ffb23f8e404f71","original_commit_id":"0b2922834a2adc130539f915f2ffb23f8e404f71","user":{"login":"david-mcmahon","id":15622407,"avatar_url":"https://avatars.githubusercontent.com/u/15622407?v=3","gravatar_id":"","url":"https://api.github.com/users/david-mcmahon","html_url":"https://github.com/david-mcmahon","followers_url":"https://api.github.com/users/david-mcmahon/followers","following_url":"https://api.github.com/users/david-mcmahon/following{/other_user}","gists_url":"https://api.github.com/users/david-mcmahon/gists{/gist_id}","starred_url":"https://api.github.com/users/david-mcmahon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-mcmahon/subscriptions","organizations_url":"https://api.github.com/users/david-mcmahon/orgs","repos_url":"https://api.github.com/users/david-mcmahon/repos","events_url":"https://api.github.com/users/david-mcmahon/events{/privacy}","received_events_url":"https://api.github.com/users/david-mcmahon/received_events","type":"User","site_admin":false},"body":"Does juLog return 0 or 1? Why not just:\r\nif juLog ...; then\r\nfi","created_at":"2016-06-28T00:31:11Z","updated_at":"2016-06-28T00:31:11Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28133#discussion_r68680408","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68680408"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28133#discussion_r68680408"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133","id":75388619,"html_url":"https://github.com/kubernetes/kubernetes/pull/28133","diff_url":"https://github.com/kubernetes/kubernetes/pull/28133.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28133.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28133","number":28133,"state":"open","locked":false,"title":"add junit recording in e2e runner","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"2nd part of #27825  \r\n\r\nInjected junit recorder at a few places. ","created_at":"2016-06-27T22:10:34Z","updated_at":"2016-06-28T00:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb508f08acc3a02dee3b6e7d07d8970a67bb65bb","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28133/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0b2922834a2adc130539f915f2ffb23f8e404f71","head":{"label":"freehan:e2ejunit","ref":"e2ejunit","sha":"0b2922834a2adc130539f915f2ffb23f8e404f71","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"repo":{"id":45570688,"name":"kubernetes","full_name":"freehan/kubernetes","owner":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freehan/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/freehan/kubernetes","forks_url":"https://api.github.com/repos/freehan/kubernetes/forks","keys_url":"https://api.github.com/repos/freehan/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freehan/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freehan/kubernetes/teams","hooks_url":"https://api.github.com/repos/freehan/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/freehan/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/freehan/kubernetes/events","assignees_url":"https://api.github.com/repos/freehan/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/freehan/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/freehan/kubernetes/tags","blobs_url":"https://api.github.com/repos/freehan/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freehan/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freehan/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/freehan/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freehan/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/freehan/kubernetes/languages","stargazers_url":"https://api.github.com/repos/freehan/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/freehan/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/freehan/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/freehan/kubernetes/subscription","commits_url":"https://api.github.com/repos/freehan/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/freehan/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/freehan/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/freehan/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/freehan/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/freehan/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freehan/kubernetes/merges","archive_url":"https://api.github.com/repos/freehan/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freehan/kubernetes/downloads","issues_url":"https://api.github.com/repos/freehan/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/freehan/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/freehan/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/freehan/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freehan/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/freehan/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/freehan/kubernetes/deployments","created_at":"2015-11-04T22:09:37Z","updated_at":"2016-01-13T01:28:27Z","pushed_at":"2016-06-27T22:19:21Z","git_url":"git://github.com/freehan/kubernetes.git","ssh_url":"git@github.com:freehan/kubernetes.git","clone_url":"https://github.com/freehan/kubernetes.git","svn_url":"https://github.com/freehan/kubernetes","homepage":"http://kubernetes.io","size":271784,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"be682148fb31628eefa8dc2da6f7bdf42f79b2ff","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-27T19:24:42Z","pushed_at":"2016-06-28T00:29:15Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":484434,"stargazers_count":15117,"watchers_count":15117,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4720,"mirror_url":null,"open_issues_count":3779,"forks":4720,"open_issues":3779,"watchers":15117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28133"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28133"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28133/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28133/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0b2922834a2adc130539f915f2ffb23f8e404f71"}}}}
{"actor":{"display_login":"david-mcmahon"}}