{"action":"created","issue":{"url":"https://api.github.com/repos/SUSE/DeepSea/issues/53","repository_url":"https://api.github.com/repos/SUSE/DeepSea","labels_url":"https://api.github.com/repos/SUSE/DeepSea/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/SUSE/DeepSea/issues/53/comments","events_url":"https://api.github.com/repos/SUSE/DeepSea/issues/53/events","html_url":"https://github.com/SUSE/DeepSea/pull/53","id":192046260,"number":53,"title":"Adding nfs-ganesha state to Deepsea","user":{"login":"supriti","id":1038503,"avatar_url":"https://avatars.githubusercontent.com/u/1038503?v=3","gravatar_id":"","url":"https://api.github.com/users/supriti","html_url":"https://github.com/supriti","followers_url":"https://api.github.com/users/supriti/followers","following_url":"https://api.github.com/users/supriti/following{/other_user}","gists_url":"https://api.github.com/users/supriti/gists{/gist_id}","starred_url":"https://api.github.com/users/supriti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supriti/subscriptions","organizations_url":"https://api.github.com/users/supriti/orgs","repos_url":"https://api.github.com/users/supriti/repos","events_url":"https://api.github.com/users/supriti/events{/privacy}","received_events_url":"https://api.github.com/users/supriti/received_events","type":"User","site_admin":false},"labels":[{"id":490324689,"url":"https://api.github.com/repos/SUSE/DeepSea/labels/feature","name":"feature","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-28T16:09:42Z","updated_at":"2016-11-28T22:28:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SUSE/DeepSea/pulls/53","html_url":"https://github.com/SUSE/DeepSea/pull/53","diff_url":"https://github.com/SUSE/DeepSea/pull/53.diff","patch_url":"https://github.com/SUSE/DeepSea/pull/53.patch"},"body":"With this commit,\r\n- \"ganesha\" role is defined\r\n- nfs-ganesha and other prerequisite package is installed on the minion acting as ganesha server \r\n- The service is started with correct conf file. \r\n- Ganesha is not added as part of services for deployment in stage 4 as it still needs some work. \r\n\r\nIts still WIP. It requires at least the following changes to make it complete\r\n- Better error and state handling. The current commit is missing check if service started with success or not. \r\n- Adding more fields in ceph.conf for better flexibility\r\n- Checking if cephfs is mounted on the server acting as nfs-ganesha server before doing anything else. "},"comment":{"url":"https://api.github.com/repos/SUSE/DeepSea/issues/comments/263415059","html_url":"https://github.com/SUSE/DeepSea/pull/53#issuecomment-263415059","issue_url":"https://api.github.com/repos/SUSE/DeepSea/issues/53","id":263415059,"user":{"login":"rjfd","id":17119885,"avatar_url":"https://avatars.githubusercontent.com/u/17119885?v=3","gravatar_id":"","url":"https://api.github.com/users/rjfd","html_url":"https://github.com/rjfd","followers_url":"https://api.github.com/users/rjfd/followers","following_url":"https://api.github.com/users/rjfd/following{/other_user}","gists_url":"https://api.github.com/users/rjfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rjfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjfd/subscriptions","organizations_url":"https://api.github.com/users/rjfd/orgs","repos_url":"https://api.github.com/users/rjfd/repos","events_url":"https://api.github.com/users/rjfd/events{/privacy}","received_events_url":"https://api.github.com/users/rjfd/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T22:28:44Z","updated_at":"2016-11-28T22:28:44Z","body":"@supriti I often run into the same problem. What I usually end up doing is squash everything into a single commit and then I edit the single commit and create the necessary commits with respective pieces.\r\nThe command `git add -p file` is very useful to just add part of the changes of a file for staging.\r\n\r\nThis is a nice exercise to learn more about git, at least this was how I learned :-), try the \"commit edit\" in another branch first before doing it in this branch."}}
{"actor":{"display_login":"rjfd"}}