{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/90762910","pull_request_review_id":11282104,"id":90762910,"diff_hunk":"@@ -165,9 +166,18 @@ public function loadClass($class)\n \n             if (in_array(strtolower($refl->getShortName()), self::$php7Reserved)) {\n                 @trigger_error(sprintf('%s uses a reserved class name (%s) that will break on PHP 7 and higher', $name, $refl->getShortName()), E_USER_DEPRECATED);\n-            } elseif (preg_match('#\\n \\* @deprecated (.*?)\\r?\\n \\*(?: @|/$)#s', $refl->getDocComment(), $notice)) {\n+            }\n+\n+            if (preg_match('#\\n \\* @final( .*)?\\r?\\n \\*(?: @|/$)#s', $refl->getDocComment())) {","path":"src/Symfony/Component/Debug/DebugClassLoader.php","position":null,"original_position":15,"commit_id":"02c9a3cbac27c01ad4bed08179193e5e251333f4","original_commit_id":"b2bb9c38404a3f80394ed69f993a53771fdeb996","user":{"login":"GuilhemN","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/GuilhemN","html_url":"https://github.com/GuilhemN","followers_url":"https://api.github.com/users/GuilhemN/followers","following_url":"https://api.github.com/users/GuilhemN/following{/other_user}","gists_url":"https://api.github.com/users/GuilhemN/gists{/gist_id}","starred_url":"https://api.github.com/users/GuilhemN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuilhemN/subscriptions","organizations_url":"https://api.github.com/users/GuilhemN/orgs","repos_url":"https://api.github.com/users/GuilhemN/repos","events_url":"https://api.github.com/users/GuilhemN/events{/privacy}","received_events_url":"https://api.github.com/users/GuilhemN/received_events","type":"User","site_admin":false},"body":"I don't know, do you think we should use it to indicate a version or something like that?","created_at":"2016-12-03T19:07:05Z","updated_at":"2016-12-03T19:12:55Z","html_url":"https://github.com/symfony/symfony/pull/20493#discussion_r90762910","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20493","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/90762910"},"html":{"href":"https://github.com/symfony/symfony/pull/20493#discussion_r90762910"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20493"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20493","id":93394619,"html_url":"https://github.com/symfony/symfony/pull/20493","diff_url":"https://github.com/symfony/symfony/pull/20493.diff","patch_url":"https://github.com/symfony/symfony/pull/20493.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20493","number":20493,"state":"open","locked":false,"title":"Prepare making some classes final in 4.0","user":{"login":"GuilhemN","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/GuilhemN","html_url":"https://github.com/GuilhemN","followers_url":"https://api.github.com/users/GuilhemN/followers","following_url":"https://api.github.com/users/GuilhemN/following{/other_user}","gists_url":"https://api.github.com/users/GuilhemN/gists{/gist_id}","starred_url":"https://api.github.com/users/GuilhemN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuilhemN/subscriptions","organizations_url":"https://api.github.com/users/GuilhemN/orgs","repos_url":"https://api.github.com/users/GuilhemN/repos","events_url":"https://api.github.com/users/GuilhemN/events{/privacy}","received_events_url":"https://api.github.com/users/GuilhemN/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | follows https://github.com/symfony/symfony/pull/19734\r\n| License       | MIT\r\n| Doc PR        |  |\r\n\r\nBC promises become quickly huge but making classes `final` can limit these promises.\r\nAt the same time, many classes of the symfony codebase are not meant to be extended and could be  `final`; that's the goal of this PR: prepare making them final in 4.0 by triggering deprecations in their constructor:\r\n```php\r\npublic function __construct()\r\n{\r\n    if (__CLASS__ !== get_class($this)) {\r\n        @trigger_error(sprintf('Extending %s is deprecated since 3.3 and won\\'t be supported in 4.0 as it will be final.', __CLASS__), E_USER_DEPRECATED);\r\n    }\r\n}\r\n```\r\n\r\nI updated two classes for now but we can do much more if you like it.","created_at":"2016-11-11T20:40:32Z","updated_at":"2016-12-03T19:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5281ffa59f16718173cc72d06916dc42c6828704","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20493/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20493/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20493/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/02c9a3cbac27c01ad4bed08179193e5e251333f4","head":{"label":"GuilhemN:EXTENDING","ref":"EXTENDING","sha":"02c9a3cbac27c01ad4bed08179193e5e251333f4","user":{"login":"GuilhemN","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/GuilhemN","html_url":"https://github.com/GuilhemN","followers_url":"https://api.github.com/users/GuilhemN/followers","following_url":"https://api.github.com/users/GuilhemN/following{/other_user}","gists_url":"https://api.github.com/users/GuilhemN/gists{/gist_id}","starred_url":"https://api.github.com/users/GuilhemN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuilhemN/subscriptions","organizations_url":"https://api.github.com/users/GuilhemN/orgs","repos_url":"https://api.github.com/users/GuilhemN/repos","events_url":"https://api.github.com/users/GuilhemN/events{/privacy}","received_events_url":"https://api.github.com/users/GuilhemN/received_events","type":"User","site_admin":false},"repo":{"id":47275948,"name":"symfony","full_name":"GuilhemN/symfony","owner":{"login":"GuilhemN","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/GuilhemN","html_url":"https://github.com/GuilhemN","followers_url":"https://api.github.com/users/GuilhemN/followers","following_url":"https://api.github.com/users/GuilhemN/following{/other_user}","gists_url":"https://api.github.com/users/GuilhemN/gists{/gist_id}","starred_url":"https://api.github.com/users/GuilhemN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuilhemN/subscriptions","organizations_url":"https://api.github.com/users/GuilhemN/orgs","repos_url":"https://api.github.com/users/GuilhemN/repos","events_url":"https://api.github.com/users/GuilhemN/events{/privacy}","received_events_url":"https://api.github.com/users/GuilhemN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GuilhemN/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/GuilhemN/symfony","forks_url":"https://api.github.com/repos/GuilhemN/symfony/forks","keys_url":"https://api.github.com/repos/GuilhemN/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GuilhemN/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GuilhemN/symfony/teams","hooks_url":"https://api.github.com/repos/GuilhemN/symfony/hooks","issue_events_url":"https://api.github.com/repos/GuilhemN/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/GuilhemN/symfony/events","assignees_url":"https://api.github.com/repos/GuilhemN/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/GuilhemN/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/GuilhemN/symfony/tags","blobs_url":"https://api.github.com/repos/GuilhemN/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GuilhemN/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GuilhemN/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/GuilhemN/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GuilhemN/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/GuilhemN/symfony/languages","stargazers_url":"https://api.github.com/repos/GuilhemN/symfony/stargazers","contributors_url":"https://api.github.com/repos/GuilhemN/symfony/contributors","subscribers_url":"https://api.github.com/repos/GuilhemN/symfony/subscribers","subscription_url":"https://api.github.com/repos/GuilhemN/symfony/subscription","commits_url":"https://api.github.com/repos/GuilhemN/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/GuilhemN/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/GuilhemN/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/GuilhemN/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/GuilhemN/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/GuilhemN/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GuilhemN/symfony/merges","archive_url":"https://api.github.com/repos/GuilhemN/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GuilhemN/symfony/downloads","issues_url":"https://api.github.com/repos/GuilhemN/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/GuilhemN/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/GuilhemN/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/GuilhemN/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GuilhemN/symfony/labels{/name}","releases_url":"https://api.github.com/repos/GuilhemN/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/GuilhemN/symfony/deployments","created_at":"2015-12-02T17:11:04Z","updated_at":"2016-03-29T17:14:37Z","pushed_at":"2016-12-03T19:12:44Z","git_url":"git://github.com/GuilhemN/symfony.git","ssh_url":"git@github.com:GuilhemN/symfony.git","clone_url":"https://github.com/GuilhemN/symfony.git","svn_url":"https://github.com/GuilhemN/symfony","homepage":"symfony.com","size":74277,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"FQCN"}},"base":{"label":"symfony:master","ref":"master","sha":"9361c5eacfad8dafe837af062baff9da6b6e2cb6","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-12-03T15:58:37Z","pushed_at":"2016-12-03T19:12:47Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":144668,"stargazers_count":13396,"watchers_count":13396,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5191,"mirror_url":null,"open_issues_count":854,"forks":5191,"open_issues":854,"watchers":13396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20493"},"html":{"href":"https://github.com/symfony/symfony/pull/20493"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20493"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20493/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20493/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20493/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/02c9a3cbac27c01ad4bed08179193e5e251333f4"}}}}
{"actor":{"display_login":"GuilhemN"}}