{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/solidity/issues/875","repository_url":"https://api.github.com/repos/ethereum/solidity","labels_url":"https://api.github.com/repos/ethereum/solidity/issues/875/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/875/comments","events_url":"https://api.github.com/repos/ethereum/solidity/issues/875/events","html_url":"https://github.com/ethereum/solidity/issues/875","id":170763895,"number":875,"title":"install_deps.sh: alpine detection","user":{"login":"rainbeam","id":18486361,"avatar_url":"https://avatars.githubusercontent.com/u/18486361?v=3","gravatar_id":"","url":"https://api.github.com/users/rainbeam","html_url":"https://github.com/rainbeam","followers_url":"https://api.github.com/users/rainbeam/followers","following_url":"https://api.github.com/users/rainbeam/following{/other_user}","gists_url":"https://api.github.com/users/rainbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/rainbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainbeam/subscriptions","organizations_url":"https://api.github.com/users/rainbeam/orgs","repos_url":"https://api.github.com/users/rainbeam/repos","events_url":"https://api.github.com/users/rainbeam/events{/privacy}","received_events_url":"https://api.github.com/users/rainbeam/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/solidity/labels/bug","name":"bug","color":"fc1313"}],"state":"open","locked":false,"assignee":{"login":"bobsummerwill","id":3788156,"avatar_url":"https://avatars.githubusercontent.com/u/3788156?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsummerwill","html_url":"https://github.com/bobsummerwill","followers_url":"https://api.github.com/users/bobsummerwill/followers","following_url":"https://api.github.com/users/bobsummerwill/following{/other_user}","gists_url":"https://api.github.com/users/bobsummerwill/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsummerwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsummerwill/subscriptions","organizations_url":"https://api.github.com/users/bobsummerwill/orgs","repos_url":"https://api.github.com/users/bobsummerwill/repos","events_url":"https://api.github.com/users/bobsummerwill/events{/privacy}","received_events_url":"https://api.github.com/users/bobsummerwill/received_events","type":"User","site_admin":false},"assignees":[{"login":"bobsummerwill","id":3788156,"avatar_url":"https://avatars.githubusercontent.com/u/3788156?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsummerwill","html_url":"https://github.com/bobsummerwill","followers_url":"https://api.github.com/users/bobsummerwill/followers","following_url":"https://api.github.com/users/bobsummerwill/following{/other_user}","gists_url":"https://api.github.com/users/bobsummerwill/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsummerwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsummerwill/subscriptions","organizations_url":"https://api.github.com/users/bobsummerwill/orgs","repos_url":"https://api.github.com/users/bobsummerwill/repos","events_url":"https://api.github.com/users/bobsummerwill/events{/privacy}","received_events_url":"https://api.github.com/users/bobsummerwill/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-11T22:40:31Z","updated_at":"2016-08-12T02:23:54Z","closed_at":null,"body":"Two issues with install_deps for detecting Alpine linux:\r\n\r\n1) It uses bash. The alpine docker image only has `sh`\r\n\r\n2) Alpine doesn't have `lsb_release`. It has '/etc/os-release' instead:\r\n\r\n```\r\n# cat /etc/os-release \r\nNAME=\"Alpine Linux\"\r\nID=alpine\r\nVERSION_ID=3.4.0\r\nPRETTY_NAME=\"Alpine Linux v3.4\"\r\nHOME_URL=\"http://alpinelinux.org\"\r\nBUG_REPORT_URL=\"http://bugs.alpinelinux.org\"\r\n```\r\n\r\nI think parsing `os-release` is going to be the solution overall as most big distros now use it, as far as I can tell.\r\n\r\nhttps://www.freedesktop.org/software/systemd/man/os-release.html"},"comment":{"url":"https://api.github.com/repos/ethereum/solidity/issues/comments/239346675","html_url":"https://github.com/ethereum/solidity/issues/875#issuecomment-239346675","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/875","id":239346675,"user":{"login":"bobsummerwill","id":3788156,"avatar_url":"https://avatars.githubusercontent.com/u/3788156?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsummerwill","html_url":"https://github.com/bobsummerwill","followers_url":"https://api.github.com/users/bobsummerwill/followers","following_url":"https://api.github.com/users/bobsummerwill/following{/other_user}","gists_url":"https://api.github.com/users/bobsummerwill/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsummerwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsummerwill/subscriptions","organizations_url":"https://api.github.com/users/bobsummerwill/orgs","repos_url":"https://api.github.com/users/bobsummerwill/repos","events_url":"https://api.github.com/users/bobsummerwill/events{/privacy}","received_events_url":"https://api.github.com/users/bobsummerwill/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T02:23:53Z","updated_at":"2016-08-12T02:23:53Z","body":"From what I can see, there is no single simple approach to this which will work for all distros.\r\n\r\nA simpler start for Alpine would be to check for `/etc/alpine-release`.\r\n\r\nFor the `sh` issue, does the bash shebang break anything if you run this script?   Or is it just ignored?\r\n\r\nIf you could create a PR for these changes (or any changes you can make which work) that would be much appreciated.   You have the test environment, so can validate this easier.\r\n\r\nThere will be an analogous TODO for cpp-ethereum.\r\n\r\nhttps://github.com/bobsummerwill/cpp-ethereum/blob/merge_repos/scripts/install_deps.sh"}}
{"actor":{"display_login":"bobsummerwill"}}