{"action":"opened","number":20498,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20498","id":93434385,"html_url":"https://github.com/symfony/symfony/pull/20498","diff_url":"https://github.com/symfony/symfony/pull/20498.diff","patch_url":"https://github.com/symfony/symfony/pull/20498.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20498","number":20498,"state":"open","locked":false,"title":"[Workflow] Made the DefinitionBuilder instantiate the Transition objects","user":{"login":"HeahDude","id":10107633,"avatar_url":"https://avatars.githubusercontent.com/u/10107633?v=3","gravatar_id":"","url":"https://api.github.com/users/HeahDude","html_url":"https://github.com/HeahDude","followers_url":"https://api.github.com/users/HeahDude/followers","following_url":"https://api.github.com/users/HeahDude/following{/other_user}","gists_url":"https://api.github.com/users/HeahDude/gists{/gist_id}","starred_url":"https://api.github.com/users/HeahDude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeahDude/subscriptions","organizations_url":"https://api.github.com/users/HeahDude/orgs","repos_url":"https://api.github.com/users/HeahDude/repos","events_url":"https://api.github.com/users/HeahDude/events{/privacy}","received_events_url":"https://api.github.com/users/HeahDude/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | ~\r\n| License       | MIT\r\n| Doc PR        | https://github.com/symfony/symfony-docs/pull/6871\r\n\r\nI suggest to no construct `Transition` object repeatedly in user land code, ortherwise we can just create our own `Definition`, let's abstract it in the builder.\r\n\r\nping @lyrixx @Nyholm","created_at":"2016-11-12T09:59:08Z","updated_at":"2016-11-12T09:59:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0940f56bbfb268e278e28ec553621d6dc892328","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20498/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20498/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20498/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/22bac90ad1a98649f58bac1fe2bacd2b5ac6e9d9","head":{"label":"HeahDude:workflow-definition-factory","ref":"workflow-definition-factory","sha":"22bac90ad1a98649f58bac1fe2bacd2b5ac6e9d9","user":{"login":"HeahDude","id":10107633,"avatar_url":"https://avatars.githubusercontent.com/u/10107633?v=3","gravatar_id":"","url":"https://api.github.com/users/HeahDude","html_url":"https://github.com/HeahDude","followers_url":"https://api.github.com/users/HeahDude/followers","following_url":"https://api.github.com/users/HeahDude/following{/other_user}","gists_url":"https://api.github.com/users/HeahDude/gists{/gist_id}","starred_url":"https://api.github.com/users/HeahDude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeahDude/subscriptions","organizations_url":"https://api.github.com/users/HeahDude/orgs","repos_url":"https://api.github.com/users/HeahDude/repos","events_url":"https://api.github.com/users/HeahDude/events{/privacy}","received_events_url":"https://api.github.com/users/HeahDude/received_events","type":"User","site_admin":false},"repo":{"id":27680958,"name":"symfony","full_name":"HeahDude/symfony","owner":{"login":"HeahDude","id":10107633,"avatar_url":"https://avatars.githubusercontent.com/u/10107633?v=3","gravatar_id":"","url":"https://api.github.com/users/HeahDude","html_url":"https://github.com/HeahDude","followers_url":"https://api.github.com/users/HeahDude/followers","following_url":"https://api.github.com/users/HeahDude/following{/other_user}","gists_url":"https://api.github.com/users/HeahDude/gists{/gist_id}","starred_url":"https://api.github.com/users/HeahDude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeahDude/subscriptions","organizations_url":"https://api.github.com/users/HeahDude/orgs","repos_url":"https://api.github.com/users/HeahDude/repos","events_url":"https://api.github.com/users/HeahDude/events{/privacy}","received_events_url":"https://api.github.com/users/HeahDude/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HeahDude/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/HeahDude/symfony","forks_url":"https://api.github.com/repos/HeahDude/symfony/forks","keys_url":"https://api.github.com/repos/HeahDude/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HeahDude/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HeahDude/symfony/teams","hooks_url":"https://api.github.com/repos/HeahDude/symfony/hooks","issue_events_url":"https://api.github.com/repos/HeahDude/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/HeahDude/symfony/events","assignees_url":"https://api.github.com/repos/HeahDude/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/HeahDude/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/HeahDude/symfony/tags","blobs_url":"https://api.github.com/repos/HeahDude/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HeahDude/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HeahDude/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/HeahDude/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HeahDude/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/HeahDude/symfony/languages","stargazers_url":"https://api.github.com/repos/HeahDude/symfony/stargazers","contributors_url":"https://api.github.com/repos/HeahDude/symfony/contributors","subscribers_url":"https://api.github.com/repos/HeahDude/symfony/subscribers","subscription_url":"https://api.github.com/repos/HeahDude/symfony/subscription","commits_url":"https://api.github.com/repos/HeahDude/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/HeahDude/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/HeahDude/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/HeahDude/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/HeahDude/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/HeahDude/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HeahDude/symfony/merges","archive_url":"https://api.github.com/repos/HeahDude/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HeahDude/symfony/downloads","issues_url":"https://api.github.com/repos/HeahDude/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/HeahDude/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/HeahDude/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/HeahDude/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HeahDude/symfony/labels{/name}","releases_url":"https://api.github.com/repos/HeahDude/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/HeahDude/symfony/deployments","created_at":"2014-12-07T19:00:38Z","updated_at":"2016-10-29T15:42:13Z","pushed_at":"2016-11-12T09:55:59Z","git_url":"git://github.com/HeahDude/symfony.git","ssh_url":"git@github.com:HeahDude/symfony.git","clone_url":"https://github.com/HeahDude/symfony.git","svn_url":"https://github.com/HeahDude/symfony","homepage":"symfony.com","size":74933,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"62533f322e0a7e014b13fa4dd0928d02055b205a","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-11-12T08:50:31Z","pushed_at":"2016-11-12T09:59:09Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":141375,"stargazers_count":13261,"watchers_count":13261,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5113,"mirror_url":null,"open_issues_count":803,"forks":5113,"open_issues":803,"watchers":13261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20498"},"html":{"href":"https://github.com/symfony/symfony/pull/20498"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20498"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20498/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20498/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20498/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/22bac90ad1a98649f58bac1fe2bacd2b5ac6e9d9"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":25,"deletions":22,"changed_files":4}}
{"actor":{"display_login":"HeahDude"}}