{"action":"created","issue":{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1477","repository_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js","labels_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1477/labels{/name}","comments_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1477/comments","events_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1477/events","html_url":"https://github.com/Dash-Industry-Forum/dash.js/issues/1477","id":163971039,"number":1477,"title":"dist release of dash.js attempts to set property on undefined","user":{"login":"addelong","id":2716784,"avatar_url":"https://avatars.githubusercontent.com/u/2716784?v=3","gravatar_id":"","url":"https://api.github.com/users/addelong","html_url":"https://github.com/addelong","followers_url":"https://api.github.com/users/addelong/followers","following_url":"https://api.github.com/users/addelong/following{/other_user}","gists_url":"https://api.github.com/users/addelong/gists{/gist_id}","starred_url":"https://api.github.com/users/addelong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addelong/subscriptions","organizations_url":"https://api.github.com/users/addelong/orgs","repos_url":"https://api.github.com/users/addelong/repos","events_url":"https://api.github.com/users/addelong/events{/privacy}","received_events_url":"https://api.github.com/users/addelong/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/labels/Awaiting%20Feedback","name":"Awaiting Feedback","color":"cc33ff"},{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/labels/More%20Information%20Required","name":"More Information Required","color":"cc002b"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-05T23:50:50Z","updated_at":"2016-09-20T09:20:02Z","closed_at":null,"body":"##### Steps to reproduce\r\n1. Grab the v2.1.1 zip from here: https://github.com/Dash-Industry-Forum/dash.js/releases\r\n2. Look at dist/dash.all.debug.js line 1416\r\n2. `(typeof exports === 'undefined' ? undefined.cea608parser = {} : exports);` is not legal javascript, you can not set a property on `undefined`\r\n\r\n##### Observed behaviour\r\nBrowser syntax error when trying to use dash.js\r\n\r\n##### Console output\r\n```\r\nUncaught SyntaxError: Invalid or unexpected token    dash.all.debug.js:1416\r\n```\r\n\r\nNote: I assume this is happening because in `src/cea608-parser.js`, the line is `(typeof exports === 'undefined' ? this.cea608parser = {} : exports));` and `this` is not bound when the code is bundled. But I've only been attempting to use dash.js (by way of videojs-contrib-dash) for the past day or so, so I'm not sure what your preferred fix for this is."},"comment":{"url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/comments/248248888","html_url":"https://github.com/Dash-Industry-Forum/dash.js/issues/1477#issuecomment-248248888","issue_url":"https://api.github.com/repos/Dash-Industry-Forum/dash.js/issues/1477","id":248248888,"user":{"login":"bbcrddave","id":5390145,"avatar_url":"https://avatars.githubusercontent.com/u/5390145?v=3","gravatar_id":"","url":"https://api.github.com/users/bbcrddave","html_url":"https://github.com/bbcrddave","followers_url":"https://api.github.com/users/bbcrddave/followers","following_url":"https://api.github.com/users/bbcrddave/following{/other_user}","gists_url":"https://api.github.com/users/bbcrddave/gists{/gist_id}","starred_url":"https://api.github.com/users/bbcrddave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbcrddave/subscriptions","organizations_url":"https://api.github.com/users/bbcrddave/orgs","repos_url":"https://api.github.com/users/bbcrddave/repos","events_url":"https://api.github.com/users/bbcrddave/events{/privacy}","received_events_url":"https://api.github.com/users/bbcrddave/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T09:20:02Z","updated_at":"2016-09-20T09:20:02Z","body":"That's strange because `undefined.cea608parser` no longer exists when you build that version, so I don't understand how you can still be seeing that error message\r\n\r\nCan you post the error message you are seeing after rebuilding dash.all.debug.js and using it in your project?"}}
{"actor":{"display_login":"bbcrddave"}}