{"action":"opened","number":45166,"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/45166","id":96002181,"html_url":"https://github.com/brianchandotcom/liferay-portal/pull/45166","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/45166.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/45166.patch","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/45166","number":45166,"state":"open","locked":false,"title":"Lps 68289 65","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"body":"Hey @mjbradford89 @csierra @migue @rotty3000,\r\n\r\nI am notifying you with this, because you are the authors to at least one of those felix AbstractExtender based extenders. And those extenders have been causing race conditions.\r\n\r\nPlease read the long commit message here https://github.com/brianchandotcom/liferay-portal/commit/d1eed0b65ba468f3e114e589cc1297a69ac3c419 for detailed info.\r\n\r\nBasically this is a bug inside org.apache.felix.utils.extender.AbstractExtender, but since it can be fixed by subclass/overriding, I am just fixing it this way(and as a side affect, it avoids the duplicated bnd includes, which can help shrinking perm/meta space by the way. And also make sure we won't create unnecessary threadpools). @rotty3000 if you are interested in contributing the fix back to felix, please go ahead.\r\n\r\n@hhuijser we will need a SF check for this, basically no direct org.apache.felix.utils.extender.AbstractExtender usage is allowed anymore, except the usage inside com.liferay.osgi.felix.util.AbstractExtender. If anyone tries to add a new usage of org.apache.felix.utils.extender.AbstractExtender, automatically switch it to use com.liferay.osgi.felix.util.AbstractExtender.\r\n\r\nThanks\r\n\r\nCC @mhan810","created_at":"2016-12-01T00:21:44Z","updated_at":"2016-12-01T00:21:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/45166/commits","review_comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/45166/comments","review_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/45166/comments","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/0425f390b3a69b64d8b4d40f04868ccbfa9f062e","head":{"label":"shuyangzhou:LPS-68289-65","ref":"LPS-68289-65","sha":"0425f390b3a69b64d8b4d40f04868ccbfa9f062e","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"repo":{"id":1921247,"name":"liferay-portal","full_name":"shuyangzhou/liferay-portal","owner":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuyangzhou/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/shuyangzhou/liferay-portal","forks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/forks","keys_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/teams","hooks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/events","assignees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/tags","blobs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscription","commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/merges","archive_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/downloads","issues_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/deployments","created_at":"2011-06-20T00:16:27Z","updated_at":"2016-08-21T23:18:33Z","pushed_at":"2016-12-01T00:19:15Z","git_url":"git://github.com/shuyangzhou/liferay-portal.git","ssh_url":"git@github.com:shuyangzhou/liferay-portal.git","clone_url":"https://github.com/shuyangzhou/liferay-portal.git","svn_url":"https://github.com/shuyangzhou/liferay-portal","homepage":"http://liferay.com","size":10816858,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":43,"forks":1,"open_issues":43,"watchers":2,"default_branch":"master"}},"base":{"label":"brianchandotcom:master","ref":"master","sha":"254da3878ad5f30445946b1f99396e76ed23d3f2","user":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"repo":{"id":1920851,"name":"liferay-portal","full_name":"brianchandotcom/liferay-portal","owner":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianchandotcom/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/brianchandotcom/liferay-portal","forks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/forks","keys_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/teams","hooks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/events","assignees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/tags","blobs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscription","commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/merges","archive_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/downloads","issues_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/deployments","created_at":"2011-06-19T21:37:56Z","updated_at":"2016-11-29T05:21:43Z","pushed_at":"2016-12-01T00:21:45Z","git_url":"git://github.com/brianchandotcom/liferay-portal.git","ssh_url":"git@github.com:brianchandotcom/liferay-portal.git","clone_url":"https://github.com/brianchandotcom/liferay-portal.git","svn_url":"https://github.com/brianchandotcom/liferay-portal","homepage":"http://liferay.com","size":11844142,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":14,"forks":12,"open_issues":14,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/45166"},"html":{"href":"https://github.com/brianchandotcom/liferay-portal/pull/45166"},"issue":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/45166"},"comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/45166/comments"},"review_comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/45166/comments"},"review_comment":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/45166/commits"},"statuses":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/0425f390b3a69b64d8b4d40f04868ccbfa9f062e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":2241,"deletions":2204,"changed_files":47}}
{"actor":{"display_login":"shuyangzhou"}}