{"action":"closed","issue":{"url":"https://api.github.com/repos/php-http/fig-standards/issues/1","repository_url":"https://api.github.com/repos/php-http/fig-standards","labels_url":"https://api.github.com/repos/php-http/fig-standards/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/php-http/fig-standards/issues/1/comments","events_url":"https://api.github.com/repos/php-http/fig-standards/issues/1/events","html_url":"https://github.com/php-http/fig-standards/issues/1","id":175497323,"number":1,"title":"Exception inheritance","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2016-09-07T13:05:10Z","updated_at":"2016-09-13T15:47:09Z","closed_at":"2016-09-13T15:47:09Z","body":"The current draft is very similar to HTTPlug. The main difference is the exceptions. The proposed exceptions does not inherit each other. The exceptions we got is: \r\n- Something wrong with the request\r\n- Something wrong with the transfer\r\n- Bad response (4xx and 5xx)\r\n- Other (base)\r\n\r\nIn my opinion they have nothing to do with each other and that is why I did not use inheritance. \r\nThe reason why HTTPlug currently have inheritance is because the methods within those interfaces are similar. \r\n\r\nAlso, HTTPlug do not have exception **interfaces**, we have classes. Inheritance between the classes makes sense because it make implementation easier. \r\n\r\n\r\nI want to know what you think, please refer me to any previous discussions if this has been mentioned before. "}}
{"actor":{"display_login":"Nyholm"}}