{"action":"created","comment":{"url":"https://api.github.com/repos/geany/geany/pulls/comments/68140708","id":68140708,"diff_hunk":"@@ -70,6 +70,9 @@ typedef struct GeanyFilePrefs\n GeanyFilePrefs;\n \n \n+#define GEANY_TYPE_DOCUMENT (document_get_type())\n+GType document_get_type (void);","path":"src/document.h","position":5,"original_position":5,"commit_id":"6b5a47d05f575b321ff158044420864ee9e59889","original_commit_id":"112ef938ff8c100b62c3ca12a608ed44daa365cf","user":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"body":"> Besides, I do generate a (mostly) working .vapi from the .gir. Vala plugins written against that use the C header files so they need to be in the public headers (peasy is partly written in vala).\r\n\r\nOkay then.","created_at":"2016-06-22T21:41:19Z","updated_at":"2016-06-22T21:41:19Z","html_url":"https://github.com/geany/geany/pull/1038#discussion_r68140708","pull_request_url":"https://api.github.com/repos/geany/geany/pulls/1038","_links":{"self":{"href":"https://api.github.com/repos/geany/geany/pulls/comments/68140708"},"html":{"href":"https://github.com/geany/geany/pull/1038#discussion_r68140708"},"pull_request":{"href":"https://api.github.com/repos/geany/geany/pulls/1038"}}},"pull_request":{"url":"https://api.github.com/repos/geany/geany/pulls/1038","id":70271917,"html_url":"https://github.com/geany/geany/pull/1038","diff_url":"https://github.com/geany/geany/pull/1038.diff","patch_url":"https://github.com/geany/geany/pull/1038.patch","issue_url":"https://api.github.com/repos/geany/geany/issues/1038","number":1038,"state":"open","locked":false,"title":"Gi signals","user":{"login":"kugel-","id":564520,"avatar_url":"https://avatars.githubusercontent.com/u/564520?v=3","gravatar_id":"","url":"https://api.github.com/users/kugel-","html_url":"https://github.com/kugel-","followers_url":"https://api.github.com/users/kugel-/followers","following_url":"https://api.github.com/users/kugel-/following{/other_user}","gists_url":"https://api.github.com/users/kugel-/gists{/gist_id}","starred_url":"https://api.github.com/users/kugel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kugel-/subscriptions","organizations_url":"https://api.github.com/users/kugel-/orgs","repos_url":"https://api.github.com/users/kugel-/repos","events_url":"https://api.github.com/users/kugel-/events{/privacy}","received_events_url":"https://api.github.com/users/kugel-/received_events","type":"User","site_admin":false},"body":"This are the changes to geany that allow plugin signals to be used by GI-based plugins (e.g. through peasy).\r\n\r\n- signal params must be boxed or gobject (I used gboxed)\r\n- the GType must be passed to g_signal_new()\r\n- since glib 2.30 there is a generic marshaller which can be used. otherwise we'd need a lot of duplicated, new marshaller code. I chosed to use the generic marshaller (by passing NULL to g_signal_new's marshall func)\r\n- geanyobject must be exposed to connect to. I chosed to implement a get_instance() function (singleton pattern)\r\n\r\nPlease review and comment","created_at":"2016-05-16T22:24:13Z","updated_at":"2016-06-22T21:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a88d694e468671ac05fa8d9629ac3c630786dbe","assignee":null,"milestone":{"url":"https://api.github.com/repos/geany/geany/milestones/5","html_url":"https://github.com/geany/geany/milestones/1.28","labels_url":"https://api.github.com/repos/geany/geany/milestones/5/labels","id":1495828,"number":5,"title":"1.28","description":"","creator":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":18,"state":"open","created_at":"2016-01-10T23:27:47Z","updated_at":"2016-06-11T08:21:07Z","due_on":"2016-07-09T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/geany/geany/pulls/1038/commits","review_comments_url":"https://api.github.com/repos/geany/geany/pulls/1038/comments","review_comment_url":"https://api.github.com/repos/geany/geany/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geany/geany/issues/1038/comments","statuses_url":"https://api.github.com/repos/geany/geany/statuses/6b5a47d05f575b321ff158044420864ee9e59889","head":{"label":"kugel-:gi-signals","ref":"gi-signals","sha":"6b5a47d05f575b321ff158044420864ee9e59889","user":{"login":"kugel-","id":564520,"avatar_url":"https://avatars.githubusercontent.com/u/564520?v=3","gravatar_id":"","url":"https://api.github.com/users/kugel-","html_url":"https://github.com/kugel-","followers_url":"https://api.github.com/users/kugel-/followers","following_url":"https://api.github.com/users/kugel-/following{/other_user}","gists_url":"https://api.github.com/users/kugel-/gists{/gist_id}","starred_url":"https://api.github.com/users/kugel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kugel-/subscriptions","organizations_url":"https://api.github.com/users/kugel-/orgs","repos_url":"https://api.github.com/users/kugel-/repos","events_url":"https://api.github.com/users/kugel-/events{/privacy}","received_events_url":"https://api.github.com/users/kugel-/received_events","type":"User","site_admin":false},"repo":{"id":2544402,"name":"geany","full_name":"kugel-/geany","owner":{"login":"kugel-","id":564520,"avatar_url":"https://avatars.githubusercontent.com/u/564520?v=3","gravatar_id":"","url":"https://api.github.com/users/kugel-","html_url":"https://github.com/kugel-","followers_url":"https://api.github.com/users/kugel-/followers","following_url":"https://api.github.com/users/kugel-/following{/other_user}","gists_url":"https://api.github.com/users/kugel-/gists{/gist_id}","starred_url":"https://api.github.com/users/kugel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kugel-/subscriptions","organizations_url":"https://api.github.com/users/kugel-/orgs","repos_url":"https://api.github.com/users/kugel-/repos","events_url":"https://api.github.com/users/kugel-/events{/privacy}","received_events_url":"https://api.github.com/users/kugel-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kugel-/geany","description":"A fast and lightweight IDE","fork":true,"url":"https://api.github.com/repos/kugel-/geany","forks_url":"https://api.github.com/repos/kugel-/geany/forks","keys_url":"https://api.github.com/repos/kugel-/geany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kugel-/geany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kugel-/geany/teams","hooks_url":"https://api.github.com/repos/kugel-/geany/hooks","issue_events_url":"https://api.github.com/repos/kugel-/geany/issues/events{/number}","events_url":"https://api.github.com/repos/kugel-/geany/events","assignees_url":"https://api.github.com/repos/kugel-/geany/assignees{/user}","branches_url":"https://api.github.com/repos/kugel-/geany/branches{/branch}","tags_url":"https://api.github.com/repos/kugel-/geany/tags","blobs_url":"https://api.github.com/repos/kugel-/geany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kugel-/geany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kugel-/geany/git/refs{/sha}","trees_url":"https://api.github.com/repos/kugel-/geany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kugel-/geany/statuses/{sha}","languages_url":"https://api.github.com/repos/kugel-/geany/languages","stargazers_url":"https://api.github.com/repos/kugel-/geany/stargazers","contributors_url":"https://api.github.com/repos/kugel-/geany/contributors","subscribers_url":"https://api.github.com/repos/kugel-/geany/subscribers","subscription_url":"https://api.github.com/repos/kugel-/geany/subscription","commits_url":"https://api.github.com/repos/kugel-/geany/commits{/sha}","git_commits_url":"https://api.github.com/repos/kugel-/geany/git/commits{/sha}","comments_url":"https://api.github.com/repos/kugel-/geany/comments{/number}","issue_comment_url":"https://api.github.com/repos/kugel-/geany/issues/comments{/number}","contents_url":"https://api.github.com/repos/kugel-/geany/contents/{+path}","compare_url":"https://api.github.com/repos/kugel-/geany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kugel-/geany/merges","archive_url":"https://api.github.com/repos/kugel-/geany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kugel-/geany/downloads","issues_url":"https://api.github.com/repos/kugel-/geany/issues{/number}","pulls_url":"https://api.github.com/repos/kugel-/geany/pulls{/number}","milestones_url":"https://api.github.com/repos/kugel-/geany/milestones{/number}","notifications_url":"https://api.github.com/repos/kugel-/geany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kugel-/geany/labels{/name}","releases_url":"https://api.github.com/repos/kugel-/geany/releases{/id}","deployments_url":"https://api.github.com/repos/kugel-/geany/deployments","created_at":"2011-10-09T20:46:57Z","updated_at":"2015-07-28T08:28:33Z","pushed_at":"2016-06-22T14:19:49Z","git_url":"git://github.com/kugel-/geany.git","ssh_url":"git@github.com:kugel-/geany.git","clone_url":"https://github.com/kugel-/geany.git","svn_url":"https://github.com/kugel-/geany","homepage":"http://www.geany.org","size":48029,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"geany:master","ref":"master","sha":"fda89798a468c65afc1c0d56d0cf9b68a0f98dea","user":{"login":"geany","id":1108795,"avatar_url":"https://avatars.githubusercontent.com/u/1108795?v=3","gravatar_id":"","url":"https://api.github.com/users/geany","html_url":"https://github.com/geany","followers_url":"https://api.github.com/users/geany/followers","following_url":"https://api.github.com/users/geany/following{/other_user}","gists_url":"https://api.github.com/users/geany/gists{/gist_id}","starred_url":"https://api.github.com/users/geany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geany/subscriptions","organizations_url":"https://api.github.com/users/geany/orgs","repos_url":"https://api.github.com/users/geany/repos","events_url":"https://api.github.com/users/geany/events{/privacy}","received_events_url":"https://api.github.com/users/geany/received_events","type":"Organization","site_admin":false},"repo":{"id":2532922,"name":"geany","full_name":"geany/geany","owner":{"login":"geany","id":1108795,"avatar_url":"https://avatars.githubusercontent.com/u/1108795?v=3","gravatar_id":"","url":"https://api.github.com/users/geany","html_url":"https://github.com/geany","followers_url":"https://api.github.com/users/geany/followers","following_url":"https://api.github.com/users/geany/following{/other_user}","gists_url":"https://api.github.com/users/geany/gists{/gist_id}","starred_url":"https://api.github.com/users/geany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geany/subscriptions","organizations_url":"https://api.github.com/users/geany/orgs","repos_url":"https://api.github.com/users/geany/repos","events_url":"https://api.github.com/users/geany/events{/privacy}","received_events_url":"https://api.github.com/users/geany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geany/geany","description":"A fast and lightweight IDE","fork":false,"url":"https://api.github.com/repos/geany/geany","forks_url":"https://api.github.com/repos/geany/geany/forks","keys_url":"https://api.github.com/repos/geany/geany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geany/geany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geany/geany/teams","hooks_url":"https://api.github.com/repos/geany/geany/hooks","issue_events_url":"https://api.github.com/repos/geany/geany/issues/events{/number}","events_url":"https://api.github.com/repos/geany/geany/events","assignees_url":"https://api.github.com/repos/geany/geany/assignees{/user}","branches_url":"https://api.github.com/repos/geany/geany/branches{/branch}","tags_url":"https://api.github.com/repos/geany/geany/tags","blobs_url":"https://api.github.com/repos/geany/geany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geany/geany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geany/geany/git/refs{/sha}","trees_url":"https://api.github.com/repos/geany/geany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geany/geany/statuses/{sha}","languages_url":"https://api.github.com/repos/geany/geany/languages","stargazers_url":"https://api.github.com/repos/geany/geany/stargazers","contributors_url":"https://api.github.com/repos/geany/geany/contributors","subscribers_url":"https://api.github.com/repos/geany/geany/subscribers","subscription_url":"https://api.github.com/repos/geany/geany/subscription","commits_url":"https://api.github.com/repos/geany/geany/commits{/sha}","git_commits_url":"https://api.github.com/repos/geany/geany/git/commits{/sha}","comments_url":"https://api.github.com/repos/geany/geany/comments{/number}","issue_comment_url":"https://api.github.com/repos/geany/geany/issues/comments{/number}","contents_url":"https://api.github.com/repos/geany/geany/contents/{+path}","compare_url":"https://api.github.com/repos/geany/geany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geany/geany/merges","archive_url":"https://api.github.com/repos/geany/geany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geany/geany/downloads","issues_url":"https://api.github.com/repos/geany/geany/issues{/number}","pulls_url":"https://api.github.com/repos/geany/geany/pulls{/number}","milestones_url":"https://api.github.com/repos/geany/geany/milestones{/number}","notifications_url":"https://api.github.com/repos/geany/geany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geany/geany/labels{/name}","releases_url":"https://api.github.com/repos/geany/geany/releases{/id}","deployments_url":"https://api.github.com/repos/geany/geany/deployments","created_at":"2011-10-07T14:25:32Z","updated_at":"2016-06-21T11:34:26Z","pushed_at":"2016-06-22T14:19:49Z","git_url":"git://github.com/geany/geany.git","ssh_url":"git@github.com:geany/geany.git","clone_url":"https://github.com/geany/geany.git","svn_url":"https://github.com/geany/geany","homepage":"http://www.geany.org","size":54940,"stargazers_count":768,"watchers_count":768,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":266,"mirror_url":null,"open_issues_count":355,"forks":266,"open_issues":355,"watchers":768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geany/geany/pulls/1038"},"html":{"href":"https://github.com/geany/geany/pull/1038"},"issue":{"href":"https://api.github.com/repos/geany/geany/issues/1038"},"comments":{"href":"https://api.github.com/repos/geany/geany/issues/1038/comments"},"review_comments":{"href":"https://api.github.com/repos/geany/geany/pulls/1038/comments"},"review_comment":{"href":"https://api.github.com/repos/geany/geany/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geany/geany/pulls/1038/commits"},"statuses":{"href":"https://api.github.com/repos/geany/geany/statuses/6b5a47d05f575b321ff158044420864ee9e59889"}}}}
{"actor":{"display_login":"b4n"}}