{"action":"opened","number":818,"pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/818","id":89581578,"html_url":"https://github.com/shopware/shopware/pull/818","diff_url":"https://github.com/shopware/shopware/pull/818.diff","patch_url":"https://github.com/shopware/shopware/pull/818.patch","issue_url":"https://api.github.com/repos/shopware/shopware/issues/818","number":818,"state":"open","locked":false,"title":"Fix error when manufacturer is null","user":{"login":"romanWienicke","id":3491656,"avatar_url":"https://avatars.githubusercontent.com/u/3491656?v=3","gravatar_id":"","url":"https://api.github.com/users/romanWienicke","html_url":"https://github.com/romanWienicke","followers_url":"https://api.github.com/users/romanWienicke/followers","following_url":"https://api.github.com/users/romanWienicke/following{/other_user}","gists_url":"https://api.github.com/users/romanWienicke/gists{/gist_id}","starred_url":"https://api.github.com/users/romanWienicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanWienicke/subscriptions","organizations_url":"https://api.github.com/users/romanWienicke/orgs","repos_url":"https://api.github.com/users/romanWienicke/repos","events_url":"https://api.github.com/users/romanWienicke/events{/privacy}","received_events_url":"https://api.github.com/users/romanWienicke/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to Shopware!\r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\nClick the form's \"Preview button\" to make sure the table is functional in GitHub.\r\n-->\r\n\r\n## Description\r\nPlease describe your pull request:\r\n* Why is it necessary?\r\nAt the moment it is possible to add articles without manufacturers with the REST API. Articles without manufacturers cannot be displayed on the \"details page\" because there is a call to a function of an object which is null.\r\n* What does it improve?\r\nThe function manufacturer object is only called when the object is not null.\r\n* Does it have side effects?\r\nNo known side effects.\r\n\r\n\r\n\r\n| Questions        | Answers\r\n| ---------------- | -------------------------------------------------------\r\n| BC breaks?       | no\r\n| Tests pass?      | manually tested.\r\n| Related tickets? | none\r\n| How to test?     | add an article (via REST) and view the article details page in shopware.\r\n\r\n\r\n","created_at":"2016-10-17T08:40:56Z","updated_at":"2016-10-17T08:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shopware/shopware/pulls/818/commits","review_comments_url":"https://api.github.com/repos/shopware/shopware/pulls/818/comments","review_comment_url":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/818/comments","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/77b657bbeb5261d4899128ea867a6a890c12dd07","head":{"label":"romanWienicke:5.2","ref":"5.2","sha":"77b657bbeb5261d4899128ea867a6a890c12dd07","user":{"login":"romanWienicke","id":3491656,"avatar_url":"https://avatars.githubusercontent.com/u/3491656?v=3","gravatar_id":"","url":"https://api.github.com/users/romanWienicke","html_url":"https://github.com/romanWienicke","followers_url":"https://api.github.com/users/romanWienicke/followers","following_url":"https://api.github.com/users/romanWienicke/following{/other_user}","gists_url":"https://api.github.com/users/romanWienicke/gists{/gist_id}","starred_url":"https://api.github.com/users/romanWienicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanWienicke/subscriptions","organizations_url":"https://api.github.com/users/romanWienicke/orgs","repos_url":"https://api.github.com/users/romanWienicke/repos","events_url":"https://api.github.com/users/romanWienicke/events{/privacy}","received_events_url":"https://api.github.com/users/romanWienicke/received_events","type":"User","site_admin":false},"repo":{"id":71114456,"name":"shopware","full_name":"romanWienicke/shopware","owner":{"login":"romanWienicke","id":3491656,"avatar_url":"https://avatars.githubusercontent.com/u/3491656?v=3","gravatar_id":"","url":"https://api.github.com/users/romanWienicke","html_url":"https://github.com/romanWienicke","followers_url":"https://api.github.com/users/romanWienicke/followers","following_url":"https://api.github.com/users/romanWienicke/following{/other_user}","gists_url":"https://api.github.com/users/romanWienicke/gists{/gist_id}","starred_url":"https://api.github.com/users/romanWienicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanWienicke/subscriptions","organizations_url":"https://api.github.com/users/romanWienicke/orgs","repos_url":"https://api.github.com/users/romanWienicke/repos","events_url":"https://api.github.com/users/romanWienicke/events{/privacy}","received_events_url":"https://api.github.com/users/romanWienicke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romanWienicke/shopware","description":"Shopware Repository","fork":true,"url":"https://api.github.com/repos/romanWienicke/shopware","forks_url":"https://api.github.com/repos/romanWienicke/shopware/forks","keys_url":"https://api.github.com/repos/romanWienicke/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romanWienicke/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romanWienicke/shopware/teams","hooks_url":"https://api.github.com/repos/romanWienicke/shopware/hooks","issue_events_url":"https://api.github.com/repos/romanWienicke/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/romanWienicke/shopware/events","assignees_url":"https://api.github.com/repos/romanWienicke/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/romanWienicke/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/romanWienicke/shopware/tags","blobs_url":"https://api.github.com/repos/romanWienicke/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romanWienicke/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romanWienicke/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/romanWienicke/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romanWienicke/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/romanWienicke/shopware/languages","stargazers_url":"https://api.github.com/repos/romanWienicke/shopware/stargazers","contributors_url":"https://api.github.com/repos/romanWienicke/shopware/contributors","subscribers_url":"https://api.github.com/repos/romanWienicke/shopware/subscribers","subscription_url":"https://api.github.com/repos/romanWienicke/shopware/subscription","commits_url":"https://api.github.com/repos/romanWienicke/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/romanWienicke/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/romanWienicke/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/romanWienicke/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/romanWienicke/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/romanWienicke/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romanWienicke/shopware/merges","archive_url":"https://api.github.com/repos/romanWienicke/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romanWienicke/shopware/downloads","issues_url":"https://api.github.com/repos/romanWienicke/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/romanWienicke/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/romanWienicke/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/romanWienicke/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romanWienicke/shopware/labels{/name}","releases_url":"https://api.github.com/repos/romanWienicke/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/romanWienicke/shopware/deployments","created_at":"2016-10-17T08:08:59Z","updated_at":"2016-10-17T08:09:18Z","pushed_at":"2016-10-17T08:31:59Z","git_url":"git://github.com/romanWienicke/shopware.git","ssh_url":"git@github.com:romanWienicke/shopware.git","clone_url":"https://github.com/romanWienicke/shopware.git","svn_url":"https://github.com/romanWienicke/shopware","homepage":"http://www.shopware.com","size":174266,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"shopware:5.2","ref":"5.2","sha":"120b7ea45fb0e4f561895cffba8f0092c6e379fd","user":{"login":"shopware","id":612628,"avatar_url":"https://avatars.githubusercontent.com/u/612628?v=3","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":5682970,"name":"shopware","full_name":"shopware/shopware","owner":{"login":"shopware","id":612628,"avatar_url":"https://avatars.githubusercontent.com/u/612628?v=3","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/shopware","description":"Shopware Repository","fork":false,"url":"https://api.github.com/repos/shopware/shopware","forks_url":"https://api.github.com/repos/shopware/shopware/forks","keys_url":"https://api.github.com/repos/shopware/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/shopware/teams","hooks_url":"https://api.github.com/repos/shopware/shopware/hooks","issue_events_url":"https://api.github.com/repos/shopware/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/shopware/events","assignees_url":"https://api.github.com/repos/shopware/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/shopware/tags","blobs_url":"https://api.github.com/repos/shopware/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/shopware/languages","stargazers_url":"https://api.github.com/repos/shopware/shopware/stargazers","contributors_url":"https://api.github.com/repos/shopware/shopware/contributors","subscribers_url":"https://api.github.com/repos/shopware/shopware/subscribers","subscription_url":"https://api.github.com/repos/shopware/shopware/subscription","commits_url":"https://api.github.com/repos/shopware/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/shopware/merges","archive_url":"https://api.github.com/repos/shopware/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/shopware/downloads","issues_url":"https://api.github.com/repos/shopware/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/shopware/labels{/name}","releases_url":"https://api.github.com/repos/shopware/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/shopware/deployments","created_at":"2012-09-05T05:32:50Z","updated_at":"2016-10-16T22:03:08Z","pushed_at":"2016-10-17T06:05:30Z","git_url":"git://github.com/shopware/shopware.git","ssh_url":"git@github.com:shopware/shopware.git","clone_url":"https://github.com/shopware/shopware.git","svn_url":"https://github.com/shopware/shopware","homepage":"http://www.shopware.com","size":174266,"stargazers_count":529,"watchers_count":529,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":363,"mirror_url":null,"open_issues_count":116,"forks":363,"open_issues":116,"watchers":529,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/shopware/shopware/pulls/818"},"html":{"href":"https://github.com/shopware/shopware/pull/818"},"issue":{"href":"https://api.github.com/repos/shopware/shopware/issues/818"},"comments":{"href":"https://api.github.com/repos/shopware/shopware/issues/818/comments"},"review_comments":{"href":"https://api.github.com/repos/shopware/shopware/pulls/818/comments"},"review_comment":{"href":"https://api.github.com/repos/shopware/shopware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopware/shopware/pulls/818/commits"},"statuses":{"href":"https://api.github.com/repos/shopware/shopware/statuses/77b657bbeb5261d4899128ea867a6a890c12dd07"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"romanWienicke"}}