{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments/72722672","id":72722672,"diff_hunk":"@@ -22,34 +23,186 @@ public static void ShowHelp()\n             Application.OpenURL(\"https://developer.microsoft.com/en-us/windows/holographic/unity_development_overview#Configuring_a_Unity_project_for_HoloLens\");\n         }\n \n-        /// <summary>\n-        /// Applies recommended scene settings to the current scenes\n-        /// </summary>\n-        [MenuItem(\"HoloToolkit/Configure/Apply HoloLens Scene Settings\", priority = 0)]\n-        public static void ApplySceneSettings()\n+        [MenuItem(\"HoloToolkit/Configure/Apply All HoloLens Settings\", priority = 0)]\n+        public static void ApplyAllSettings()\n         {\n+            var output = new StringBuilder();\n+            ApplySceneSettingsInternal(output);\n+\n+\n+            var reload = ApplyProjectSettingsInternal(output);\n+\n+            EditorUtility.DisplayDialog(\"Results\", output.ToString(), \"Ok\");\n+\n+            if (reload)\n+            {\n+                PromptForReload();\n+            }\n+        }\n+\n+\n+        private static void ApplySceneSettingsInternal(StringBuilder output)\n+        {\n+            //todo if we find more than one camera, hololens will always use MainCamera (should)\n+            //additional cameras could be used from a RenderTexture, etc. Should we warn?\n+\n+            output.AppendLine(\"** Checking Camera Settings\");\n+            Camera[] cameras = new Camera[Camera.allCamerasCount];\n+            Camera.GetAllCameras(cameras);\n+\n             if (Camera.main == null)\n             {\n-                Debug.LogWarning(@\"Could not apply settings - no camera tagged with \"\"MainCamera\"\"\");\n+                output.AppendLine(@\"Could not apply camera settings - no camera tagged with \"\"MainCamera\"\"\");\n                 return;\n             }\n \n-            Camera.main.transform.position = Vector3.zero;\n-            Camera.main.clearFlags = CameraClearFlags.SolidColor;\n-            Camera.main.backgroundColor = Color.black;\n-            Camera.main.nearClipPlane = 0.85f;\n+            SetCameraDefaults(Camera.main, true, output);\n+\n+            //All done with MainCamera\n+            cameras = cameras.Where(o => o != Camera.main).ToArray();","path":"Assets/HoloToolkit/Utilities/Editor/ConfigureMenu.cs","position":58,"original_position":58,"commit_id":"3933b816638f8cce7b4dc9c87ac4fbcaadee4ded","original_commit_id":"3933b816638f8cce7b4dc9c87ac4fbcaadee4ded","user":{"login":"jwittner","id":12958442,"avatar_url":"https://avatars.githubusercontent.com/u/12958442?v=3","gravatar_id":"","url":"https://api.github.com/users/jwittner","html_url":"https://github.com/jwittner","followers_url":"https://api.github.com/users/jwittner/followers","following_url":"https://api.github.com/users/jwittner/following{/other_user}","gists_url":"https://api.github.com/users/jwittner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwittner/subscriptions","organizations_url":"https://api.github.com/users/jwittner/orgs","repos_url":"https://api.github.com/users/jwittner/repos","events_url":"https://api.github.com/users/jwittner/events{/privacy}","received_events_url":"https://api.github.com/users/jwittner/received_events","type":"User","site_admin":false},"body":"I think you're right regarding the swap with the prefab. I think applying the camera changes via the configure menu makes more sense.","created_at":"2016-07-28T23:43:56Z","updated_at":"2016-07-28T23:43:56Z","html_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/134#discussion_r72722672","pull_request_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments/72722672"},"html":{"href":"https://github.com/Microsoft/HoloToolkit-Unity/pull/134#discussion_r72722672"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134","id":78586031,"html_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/134","diff_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/134.diff","patch_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/134.patch","issue_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/134","number":134,"state":"open","locked":false,"title":"Changes to HoloToolkit menu for setting project / scene defaults","user":{"login":"adamtuliper","id":1740557,"avatar_url":"https://avatars.githubusercontent.com/u/1740557?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtuliper","html_url":"https://github.com/adamtuliper","followers_url":"https://api.github.com/users/adamtuliper/followers","following_url":"https://api.github.com/users/adamtuliper/following{/other_user}","gists_url":"https://api.github.com/users/adamtuliper/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtuliper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtuliper/subscriptions","organizations_url":"https://api.github.com/users/adamtuliper/orgs","repos_url":"https://api.github.com/users/adamtuliper/repos","events_url":"https://api.github.com/users/adamtuliper/events{/privacy}","received_events_url":"https://api.github.com/users/adamtuliper/received_events","type":"User","site_admin":false},"body":"Create a log of changes to display to user. Allow other menu options to\r\nadd to scene or project to use these new changes. Add additional checks\r\nfor unchecked/missing holographic options using API (rather than file\r\nprocessing). Don't reload for quality level changes (Unity picks up\r\nchange in file).  Don't set quality if the option is already set\r\n(therefore don't reload when not necessary)","created_at":"2016-07-24T00:18:56Z","updated_at":"2016-07-28T23:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ad6eec0a04e62c8684051860b8cc3671eca7351","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134/commits","review_comments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134/comments","review_comment_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/134/comments","statuses_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/statuses/3933b816638f8cce7b4dc9c87ac4fbcaadee4ded","head":{"label":"adamtuliper:master","ref":"master","sha":"3933b816638f8cce7b4dc9c87ac4fbcaadee4ded","user":{"login":"adamtuliper","id":1740557,"avatar_url":"https://avatars.githubusercontent.com/u/1740557?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtuliper","html_url":"https://github.com/adamtuliper","followers_url":"https://api.github.com/users/adamtuliper/followers","following_url":"https://api.github.com/users/adamtuliper/following{/other_user}","gists_url":"https://api.github.com/users/adamtuliper/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtuliper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtuliper/subscriptions","organizations_url":"https://api.github.com/users/adamtuliper/orgs","repos_url":"https://api.github.com/users/adamtuliper/repos","events_url":"https://api.github.com/users/adamtuliper/events{/privacy}","received_events_url":"https://api.github.com/users/adamtuliper/received_events","type":"User","site_admin":false},"repo":{"id":64041149,"name":"HoloToolkit-Unity","full_name":"adamtuliper/HoloToolkit-Unity","owner":{"login":"adamtuliper","id":1740557,"avatar_url":"https://avatars.githubusercontent.com/u/1740557?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtuliper","html_url":"https://github.com/adamtuliper","followers_url":"https://api.github.com/users/adamtuliper/followers","following_url":"https://api.github.com/users/adamtuliper/following{/other_user}","gists_url":"https://api.github.com/users/adamtuliper/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtuliper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtuliper/subscriptions","organizations_url":"https://api.github.com/users/adamtuliper/orgs","repos_url":"https://api.github.com/users/adamtuliper/repos","events_url":"https://api.github.com/users/adamtuliper/events{/privacy}","received_events_url":"https://api.github.com/users/adamtuliper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamtuliper/HoloToolkit-Unity","description":"This is effectively part of the existing HoloToolkit, but is the repo that will contain all Unity specific components.","fork":true,"url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity","forks_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/forks","keys_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/events","assignees_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/merges","archive_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/adamtuliper/HoloToolkit-Unity/deployments","created_at":"2016-07-24T00:08:33Z","updated_at":"2016-07-24T00:08:35Z","pushed_at":"2016-07-24T00:15:32Z","git_url":"git://github.com/adamtuliper/HoloToolkit-Unity.git","ssh_url":"git@github.com:adamtuliper/HoloToolkit-Unity.git","clone_url":"https://github.com/adamtuliper/HoloToolkit-Unity.git","svn_url":"https://github.com/adamtuliper/HoloToolkit-Unity","homepage":"","size":36556,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"9187bb5bb212fc14fdc6e4d8af9ef5caa18da013","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50605426,"name":"HoloToolkit-Unity","full_name":"Microsoft/HoloToolkit-Unity","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/HoloToolkit-Unity","description":"This is effectively part of the existing HoloToolkit, but is the repo that will contain all Unity specific components.","fork":false,"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity","forks_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/forks","keys_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/events","assignees_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/merges","archive_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/deployments","created_at":"2016-01-28T18:54:58Z","updated_at":"2016-07-28T23:01:13Z","pushed_at":"2016-07-28T17:45:14Z","git_url":"git://github.com/Microsoft/HoloToolkit-Unity.git","ssh_url":"git@github.com:Microsoft/HoloToolkit-Unity.git","clone_url":"https://github.com/Microsoft/HoloToolkit-Unity.git","svn_url":"https://github.com/Microsoft/HoloToolkit-Unity","homepage":"","size":36993,"stargazers_count":174,"watchers_count":174,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":22,"forks":116,"open_issues":22,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134"},"html":{"href":"https://github.com/Microsoft/HoloToolkit-Unity/pull/134"},"issue":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/134"},"comments":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/statuses/3933b816638f8cce7b4dc9c87ac4fbcaadee4ded"}}}}
{"actor":{"display_login":"jwittner"}}