{"action":"created","issue":{"url":"https://api.github.com/repos/vqmod/vqmod/issues/78","repository_url":"https://api.github.com/repos/vqmod/vqmod","labels_url":"https://api.github.com/repos/vqmod/vqmod/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/vqmod/vqmod/issues/78/comments","events_url":"https://api.github.com/repos/vqmod/vqmod/issues/78/events","html_url":"https://github.com/vqmod/vqmod/issues/78","id":136346293,"number":78,"title":"OpenCart version tag","user":{"login":"thekrotek","id":2802073,"avatar_url":"https://avatars.githubusercontent.com/u/2802073?v=3","gravatar_id":"","url":"https://api.github.com/users/thekrotek","html_url":"https://github.com/thekrotek","followers_url":"https://api.github.com/users/thekrotek/followers","following_url":"https://api.github.com/users/thekrotek/following{/other_user}","gists_url":"https://api.github.com/users/thekrotek/gists{/gist_id}","starred_url":"https://api.github.com/users/thekrotek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thekrotek/subscriptions","organizations_url":"https://api.github.com/users/thekrotek/orgs","repos_url":"https://api.github.com/users/thekrotek/repos","events_url":"https://api.github.com/users/thekrotek/events{/privacy}","received_events_url":"https://api.github.com/users/thekrotek/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-02-25T10:36:05Z","updated_at":"2016-02-29T18:42:12Z","closed_at":"2016-02-29T18:42:12Z","body":"Since VQMod now supports both OC 1.5 and 2.0 versions, could you add some tag or parameter to define, which part of XML should be parsed on this particular version?\r\n\r\nThe main purpose of it is to avoid creating 2 vqmod files and simplify installation. Right now you need to have 2 vqmod files and you can't put them both in vqmod/xml folder without risk of having multiple \"cannot redeclare\" errors. But if we had a version tag, this would solve the problem. Something like this:\r\n\r\n<file name=\"file.php\" version=\"2\">\r\n\r\nVersion parameter can be 1 or 2 for all versions or particular OC version (e.g.: 2.1 for all 2.1 versions or 2.1.0.1 for this version only).\r\n\r\nI know, that there's a limitation to XML size and this parameter can increase your chances to hit this limit. But hey, we can always create two XML files and split the code. It's much easier, that always work with 2 files.\r\n\r\nI think it'll make like easier for developers and for customers as well."},"comment":{"url":"https://api.github.com/repos/vqmod/vqmod/issues/comments/190326080","html_url":"https://github.com/vqmod/vqmod/issues/78#issuecomment-190326080","issue_url":"https://api.github.com/repos/vqmod/vqmod/issues/78","id":190326080,"user":{"login":"JAY6390","id":696920,"avatar_url":"https://avatars.githubusercontent.com/u/696920?v=3","gravatar_id":"","url":"https://api.github.com/users/JAY6390","html_url":"https://github.com/JAY6390","followers_url":"https://api.github.com/users/JAY6390/followers","following_url":"https://api.github.com/users/JAY6390/following{/other_user}","gists_url":"https://api.github.com/users/JAY6390/gists{/gist_id}","starred_url":"https://api.github.com/users/JAY6390/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JAY6390/subscriptions","organizations_url":"https://api.github.com/users/JAY6390/orgs","repos_url":"https://api.github.com/users/JAY6390/repos","events_url":"https://api.github.com/users/JAY6390/events{/privacy}","received_events_url":"https://api.github.com/users/JAY6390/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T18:42:12Z","updated_at":"2016-02-29T18:42:12Z","body":"OK, but lets say I have 3 values\r\n- All of 1.5\r\n- 2.0 to 2.1\r\n- 2.1 or above\r\n\r\nThen you have to do comparisons, add what type of comparison, have two separate values for it to be between. It's not just some simple addition. Considering the hundreds (this is not an exaggeration) of VQMods I've made over the last few years for versions as far back as 1.4.7, I've never had an issue where I've needed this feature. Also, I find bundling these huge numbers of code into one file a bit pointless. 2.x is so different from 1.5.x that why you'd have much if any shared code between the two I don't know, and wouldn't be able to justify that for the mammoth VQMod file you'll create as a result. I'm closing this ticket as both myself and Q don't feel this would be beneficial"}}