{"action":"opened","issue":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/98","repository_url":"https://api.github.com/repos/tbeu/Modelica","labels_url":"https://api.github.com/repos/tbeu/Modelica/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/tbeu/Modelica/issues/98/comments","events_url":"https://api.github.com/repos/tbeu/Modelica/issues/98/events","html_url":"https://github.com/tbeu/Modelica/issues/98","id":196453963,"number":98,"title":"Changes in PartialBasicInductionMachine might break user models","user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":503534431,"url":"https://api.github.com/repos/tbeu/Modelica/labels/bug","name":"bug","color":"ee0701","default":true},{"id":503543674,"url":"https://api.github.com/repos/tbeu/Modelica/labels/Electrical.Machines","name":"Electrical.Machines","color":"0000aa","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-19T16:16:11Z","updated_at":"2016-12-19T16:16:11Z","closed_at":null,"body":"**Reported by d&#x69;e&#x74;mar&#119; on 14 Aug 2008 07:57 UTC**\nI noticed that the changes made in [source:trunk/Modelica/Electrical/Machines.mo#L7610 PartialBasicInductionMachine] might break user models when automatic conversion from MSL 2.2.2 to MSL 3.0 is done. \n\nIn 2.2.2 only `PartialBasicMachine` and the two m-phase connectors were present whereas in the present 3.0 version of MSL also these components are now also part of '''`PartialBasicInductionMachine`''':\n```\n#!text/x-modelica\n  Modelica.Electrical.MultiPhase.Basic.Resistor rs(final m=m, final R=fill(Rs, m)) \n  Modelica.Electrical.MultiPhase.Basic.Inductor lssigma(final m=m, final L=fill(Lssigma, m)) \n  SpacePhasors.Components.SpacePhasor spacePhasorS \n```\nLooking at the conversion script I couldn't find a place where care was taken of this. This means that if a user was using the component `PartialBasicInductionMachine` in his models after conversion to MSL3.0 his models would fail.  \n\nA fix, I can think of, would be introducing a new partial model, let's say `PartialBasicInductionMachineSP` (SP = SpacePhasor) which in turn extends from the _2.2.2-style_ PartialBasicInductionMachine and just adds the additional components. That way an automatic conversion could be done without breaking user models.\n\n\nMigrated-From: https://trac.modelica.org/Modelica/ticket/98"}}
{"actor":{"display_login":"modelica-trac-importer"}}