{"action":"created","issue":{"url":"https://api.github.com/repos/lloeki/sprockets-less/issues/5","repository_url":"https://api.github.com/repos/lloeki/sprockets-less","labels_url":"https://api.github.com/repos/lloeki/sprockets-less/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/lloeki/sprockets-less/issues/5/comments","events_url":"https://api.github.com/repos/lloeki/sprockets-less/issues/5/events","html_url":"https://github.com/lloeki/sprockets-less/pull/5","id":173156870,"number":5,"title":"[Major Changes][Sprockets 3 for LESS] Using versionized classes","user":{"login":"bogdanRada","id":1104923,"avatar_url":"https://avatars.githubusercontent.com/u/1104923?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanRada","html_url":"https://github.com/bogdanRada","followers_url":"https://api.github.com/users/bogdanRada/followers","following_url":"https://api.github.com/users/bogdanRada/following{/other_user}","gists_url":"https://api.github.com/users/bogdanRada/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanRada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanRada/subscriptions","organizations_url":"https://api.github.com/users/bogdanRada/orgs","repos_url":"https://api.github.com/users/bogdanRada/repos","events_url":"https://api.github.com/users/bogdanRada/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanRada/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-25T09:36:12Z","updated_at":"2016-09-28T08:52:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lloeki/sprockets-less/pulls/5","html_url":"https://github.com/lloeki/sprockets-less/pull/5","diff_url":"https://github.com/lloeki/sprockets-less/pull/5.diff","patch_url":"https://github.com/lloeki/sprockets-less/pull/5.patch"},"body":"Hello.\r\n I recently added support for Sprockets 3 for sprockets-sass gem ( here: https://github.com/petebrowne/sprockets-sass/pull/38 ) and here https://github.com/petebrowne/sprockets-sass/pull/39  \r\n\r\nAfter some discussion in the first pull request, we decided to use versionized classes, so that would be easier to maintain compatibility with other sprockets versions, so this uses same structure,\r\n\r\nBasically the V2 classes will be used for sprockets 2.x\r\nV3 ...for Sprockets 3.x\r\nand V4...for Sprockets 4.x\r\n\r\nThe Registration class will automatically require the classes based on the version of sprockets loaded.\r\n\r\n\r\nThis pull request will also **DROP Ruby 1.9** and also **DROP TILT DEPENDENCY***\r\n\r\n\r\nThis pull request fixes some issues:\r\n- The importer can now import from globbed files and from deeply nested files\r\n- And now LESS files can be cached, using a custom cache store. \r\n\r\n\r\nAll tests are now passing for both 2.x and 3.x , except 6 tests related to the helpers we have for assets  ( Which are broken because i honestly haven';t found a way to pass arguments to this methods, besides the first argument )\r\n\r\n```Less\r\n body { background: asset-path(\"image.jpg\", @prefix: '/themes'); }\r\n```\r\n\r\nThis seems to thow \"Unrecognized input\" when trying to parse it with the ```Less::Parser``` .\r\n I am going to still try and fix this, but i think this is not available for our ```less.js``` version (1.6.1) which is loaded by ```less.rb```` (version 2.6.0 -- the last version)\r\n\r\nThere is though LESS.js version 1.7.1, which has support for this, but the ```less.js``` repository hasn't been updated though :( \r\n\r\nAlso there are some changes done for Sprockets 4.x but that is not yet complete. It does not fully support it yet. \r\n\r\nBut wanted to get some feedback on this, and maybe we can release the changes for sprockets 3.x and fix those other issues in other pull requests. \r\n\r\nLet me know what you think. Have a nice day :) \r\n\r\nP.S. If you have any idea how to pass those arguments to those helpers i would really appreciate. "},"comment":{"url":"https://api.github.com/repos/lloeki/sprockets-less/issues/comments/250109740","html_url":"https://github.com/lloeki/sprockets-less/pull/5#issuecomment-250109740","issue_url":"https://api.github.com/repos/lloeki/sprockets-less/issues/5","id":250109740,"user":{"login":"bogdanRada","id":1104923,"avatar_url":"https://avatars.githubusercontent.com/u/1104923?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanRada","html_url":"https://github.com/bogdanRada","followers_url":"https://api.github.com/users/bogdanRada/followers","following_url":"https://api.github.com/users/bogdanRada/following{/other_user}","gists_url":"https://api.github.com/users/bogdanRada/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanRada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanRada/subscriptions","organizations_url":"https://api.github.com/users/bogdanRada/orgs","repos_url":"https://api.github.com/users/bogdanRada/repos","events_url":"https://api.github.com/users/bogdanRada/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanRada/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T08:52:48Z","updated_at":"2016-09-28T08:52:48Z","body":"@lloeki , can you please review this pull request again? I fixed some issues with the importer and also the function parsing. I removed also ruby 2.0 and 2.1.5 from Travis YML file since 2.0 is not maintained anymore and 2.1.5 causes issues with bundler (because Travis has a older version of travis on server) \r\n\r\nLet me know what you think. Thank you very much. "}}
{"actor":{"display_login":"bogdanRada"}}