{"action":"created","issue":{"url":"https://api.github.com/repos/g-truc/glm/issues/519","repository_url":"https://api.github.com/repos/g-truc/glm","labels_url":"https://api.github.com/repos/g-truc/glm/issues/519/labels{/name}","comments_url":"https://api.github.com/repos/g-truc/glm/issues/519/comments","events_url":"https://api.github.com/repos/g-truc/glm/issues/519/events","html_url":"https://github.com/g-truc/glm/pull/519","id":162734312,"number":519,"title":"Move header files from /glm to /include/glm subfolder","user":{"login":"mknejp","id":5156768,"avatar_url":"https://avatars.githubusercontent.com/u/5156768?v=3","gravatar_id":"","url":"https://api.github.com/users/mknejp","html_url":"https://github.com/mknejp","followers_url":"https://api.github.com/users/mknejp/followers","following_url":"https://api.github.com/users/mknejp/following{/other_user}","gists_url":"https://api.github.com/users/mknejp/gists{/gist_id}","starred_url":"https://api.github.com/users/mknejp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mknejp/subscriptions","organizations_url":"https://api.github.com/users/mknejp/orgs","repos_url":"https://api.github.com/users/mknejp/repos","events_url":"https://api.github.com/users/mknejp/events{/privacy}","received_events_url":"https://api.github.com/users/mknejp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-28T16:52:49Z","updated_at":"2016-06-28T17:11:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/g-truc/glm/pulls/519","html_url":"https://github.com/g-truc/glm/pull/519","diff_url":"https://github.com/g-truc/glm/pull/519.diff","patch_url":"https://github.com/g-truc/glm/pull/519.patch"},"body":"This makes it safer to include GLM as sources instead of install. By not\r\nhaving the repository root as the header search path, but a dedicated\r\nsubfolder instead, chances of name clashes are reduced and the amount of\r\noptions displayed in IDEs is vastly reduced and disambiguated.\r\n\r\nThis change should not affect anyone relying on CMake's automatic\r\nheader search path setting of target dependencies. A re-run of cmake\r\nmay be necessary if it doesn't automatically pickup the changes. Already\r\ninstalled/exported packages should not be affected.\r\n\r\nThose already building from sources and managing search paths manually\r\nneed to switch from `path/to/glm` to `path/to/glm/include`."},"comment":{"url":"https://api.github.com/repos/g-truc/glm/issues/comments/229116172","html_url":"https://github.com/g-truc/glm/pull/519#issuecomment-229116172","issue_url":"https://api.github.com/repos/g-truc/glm/issues/519","id":229116172,"user":{"login":"Groovounet","id":367227,"avatar_url":"https://avatars.githubusercontent.com/u/367227?v=3","gravatar_id":"","url":"https://api.github.com/users/Groovounet","html_url":"https://github.com/Groovounet","followers_url":"https://api.github.com/users/Groovounet/followers","following_url":"https://api.github.com/users/Groovounet/following{/other_user}","gists_url":"https://api.github.com/users/Groovounet/gists{/gist_id}","starred_url":"https://api.github.com/users/Groovounet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Groovounet/subscriptions","organizations_url":"https://api.github.com/users/Groovounet/orgs","repos_url":"https://api.github.com/users/Groovounet/repos","events_url":"https://api.github.com/users/Groovounet/events{/privacy}","received_events_url":"https://api.github.com/users/Groovounet/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T17:11:35Z","updated_at":"2016-06-28T17:11:35Z","body":"I think this PR breaks all the unit tests. Also, it's a application breaking change but I don't really see how it's safer and it seem to be the only argument on the favour of this PR. I am very inclined to reject this PR... "}}
{"actor":{"display_login":"Groovounet"}}