{"action":"created","issue":{"url":"https://api.github.com/repos/neovim/neovim/issues/5236","repository_url":"https://api.github.com/repos/neovim/neovim","labels_url":"https://api.github.com/repos/neovim/neovim/issues/5236/labels{/name}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/5236/comments","events_url":"https://api.github.com/repos/neovim/neovim/issues/5236/events","html_url":"https://github.com/neovim/neovim/issues/5236","id":172577925,"number":5236,"title":"Windows: functionaltest os.remove() fails to remove directories `Permission Denied`","user":{"login":"equalsraf","id":715238,"avatar_url":"https://avatars.githubusercontent.com/u/715238?v=3","gravatar_id":"","url":"https://api.github.com/users/equalsraf","html_url":"https://github.com/equalsraf","followers_url":"https://api.github.com/users/equalsraf/followers","following_url":"https://api.github.com/users/equalsraf/following{/other_user}","gists_url":"https://api.github.com/users/equalsraf/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsraf/subscriptions","organizations_url":"https://api.github.com/users/equalsraf/orgs","repos_url":"https://api.github.com/users/equalsraf/repos","events_url":"https://api.github.com/users/equalsraf/events{/privacy}","received_events_url":"https://api.github.com/users/equalsraf/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neovim/neovim/labels/tests","name":"tests","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-22T23:22:35Z","updated_at":"2016-09-20T08:28:48Z","closed_at":null,"body":"- Windows: 8.1\r\n\r\ntest/functional/helpers.lua rmdir() uses os.rmdir() to [remove empty folders](https://github.com/neovim/neovim/blob/master/test/functional/helpers.lua#L390), this works in POSIX but not in windows. This is causing some of the functional tests to error out.\r\n\r\nThis appears to be the expected behaviour ([SO](http://stackoverflow.com/questions/29532422/lua-os-remove-folder-results-in-permission-denied)). I expected lfs.rmdir (https://github.com/keplerproject/luafilesystem/issues/4) to work as a replacement here, but I'm getting the same error instead.\r\n\r\nThe following tests are failing because of this\r\n\r\n- getcwd_spec.lua\r\n- recover_spec.lua\r\n"},"comment":{"url":"https://api.github.com/repos/neovim/neovim/issues/comments/248237655","html_url":"https://github.com/neovim/neovim/issues/5236#issuecomment-248237655","issue_url":"https://api.github.com/repos/neovim/neovim/issues/5236","id":248237655,"user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T08:28:48Z","updated_at":"2016-09-20T08:28:48Z","body":"@equalsraf https://github.com/neovim/neovim/pull/5362 with the `lfs.rmdir` change seems to fix the \"Permission denied\" error I observed with the `'directory' option` functional test. I also added a delayed retry to `helpers.rmdir()` to work around the possibility that the nvim session is slow to exit (which I think should help with [this](https://github.com/neovim/neovim/issues/5236#issuecomment-241876716)).\r\n"}}
{"actor":{"display_login":"justinmk"}}