{"action":"created","issue":{"url":"https://api.github.com/repos/nvzqz/FileKit/issues/27","repository_url":"https://api.github.com/repos/nvzqz/FileKit","labels_url":"https://api.github.com/repos/nvzqz/FileKit/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/nvzqz/FileKit/issues/27/comments","events_url":"https://api.github.com/repos/nvzqz/FileKit/issues/27/events","html_url":"https://github.com/nvzqz/FileKit/pull/27","id":171920045,"number":27,"title":"Initial Swift 3 compatibility","user":{"login":"jakeheis","id":1246055,"avatar_url":"https://avatars.githubusercontent.com/u/1246055?v=3","gravatar_id":"","url":"https://api.github.com/users/jakeheis","html_url":"https://github.com/jakeheis","followers_url":"https://api.github.com/users/jakeheis/followers","following_url":"https://api.github.com/users/jakeheis/following{/other_user}","gists_url":"https://api.github.com/users/jakeheis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakeheis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakeheis/subscriptions","organizations_url":"https://api.github.com/users/jakeheis/orgs","repos_url":"https://api.github.com/users/jakeheis/repos","events_url":"https://api.github.com/users/jakeheis/events{/privacy}","received_events_url":"https://api.github.com/users/jakeheis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-18T14:49:30Z","updated_at":"2016-08-18T20:03:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nvzqz/FileKit/pulls/27","html_url":"https://github.com/nvzqz/FileKit/pull/27","diff_url":"https://github.com/nvzqz/FileKit/pull/27.diff","patch_url":"https://github.com/nvzqz/FileKit/pull/27.patch"},"body":"These changes are the minimum required to make FileKit work with Swift 3. This means that the following were not changed, but perhaps should be addressed in a future pull request before a final 4.0 release:\r\n- Access control could be reconsidered - Xcode automatically converted `public` to the now equivalent `open` and similarly `private` to `fileprivate`, though perhaps the new `public` and `private` would be more appropriate in some situations\r\n- Methods names were converted by Xcode to maintain the same API, not to have more Swifty names. For example, `func symlinkFileToPath(path: Path)` was changed to `func symlinkFileToPath(_ path: Path)`, while perhaps its eventual name should be `func symlinkFile(to path: Path)`\r\n\r\nWhile these could be addressed in this pull request, I believe they would be better served by a future one. \r\n\r\nThe only consideration left in this pull request is `Path`'s conformance to `Indexable`. For a reason I could not deduce, Swift 3 throws errors when `Path` conforms to both `Indexable` and `Sequence`, so in this pull request I removed conformance to `Indexable` in order to fix the errors. The `Indexable` conformance is not actually utilized anywhere, so I think it would be best to just remove it, but I'm happy to do whatever you think is best in this situation."},"comment":{"url":"https://api.github.com/repos/nvzqz/FileKit/issues/comments/240839692","html_url":"https://github.com/nvzqz/FileKit/pull/27#issuecomment-240839692","issue_url":"https://api.github.com/repos/nvzqz/FileKit/issues/27","id":240839692,"user":{"login":"nvzqz","id":10367662,"avatar_url":"https://avatars.githubusercontent.com/u/10367662?v=3","gravatar_id":"","url":"https://api.github.com/users/nvzqz","html_url":"https://github.com/nvzqz","followers_url":"https://api.github.com/users/nvzqz/followers","following_url":"https://api.github.com/users/nvzqz/following{/other_user}","gists_url":"https://api.github.com/users/nvzqz/gists{/gist_id}","starred_url":"https://api.github.com/users/nvzqz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvzqz/subscriptions","organizations_url":"https://api.github.com/users/nvzqz/orgs","repos_url":"https://api.github.com/users/nvzqz/repos","events_url":"https://api.github.com/users/nvzqz/events{/privacy}","received_events_url":"https://api.github.com/users/nvzqz/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T20:03:59Z","updated_at":"2016-08-18T20:03:59Z","body":"This fails to build on iOS due to missing DispatchFileSystemWatcherDelegate. Please review your changes."}}
{"actor":{"display_login":"nvzqz"}}