{"action":"created","issue":{"url":"https://api.github.com/repos/Code4SA/wazimap/issues/59","repository_url":"https://api.github.com/repos/Code4SA/wazimap","labels_url":"https://api.github.com/repos/Code4SA/wazimap/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/Code4SA/wazimap/issues/59/comments","events_url":"https://api.github.com/repos/Code4SA/wazimap/issues/59/events","html_url":"https://github.com/Code4SA/wazimap/pull/59","id":185203023,"number":59,"title":"Don't throw exception for empty tables. Fixes #48","user":{"login":"longhotsummer","id":4178542,"avatar_url":"https://avatars.githubusercontent.com/u/4178542?v=3","gravatar_id":"","url":"https://api.github.com/users/longhotsummer","html_url":"https://github.com/longhotsummer","followers_url":"https://api.github.com/users/longhotsummer/followers","following_url":"https://api.github.com/users/longhotsummer/following{/other_user}","gists_url":"https://api.github.com/users/longhotsummer/gists{/gist_id}","starred_url":"https://api.github.com/users/longhotsummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longhotsummer/subscriptions","organizations_url":"https://api.github.com/users/longhotsummer/orgs","repos_url":"https://api.github.com/users/longhotsummer/repos","events_url":"https://api.github.com/users/longhotsummer/events{/privacy}","received_events_url":"https://api.github.com/users/longhotsummer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-25T18:53:14Z","updated_at":"2016-10-27T13:01:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Code4SA/wazimap/pulls/59","html_url":"https://github.com/Code4SA/wazimap/pull/59","diff_url":"https://github.com/Code4SA/wazimap/pull/59.diff","patch_url":"https://github.com/Code4SA/wazimap/pull/59.patch"},"body":"Candidate patch for #48 -- would like some thoughts on it before merging."},"comment":{"url":"https://api.github.com/repos/Code4SA/wazimap/issues/comments/256633921","html_url":"https://github.com/Code4SA/wazimap/pull/59#issuecomment-256633921","issue_url":"https://api.github.com/repos/Code4SA/wazimap/issues/59","id":256633921,"user":{"login":"cliftonmcintosh","id":3824492,"avatar_url":"https://avatars.githubusercontent.com/u/3824492?v=3","gravatar_id":"","url":"https://api.github.com/users/cliftonmcintosh","html_url":"https://github.com/cliftonmcintosh","followers_url":"https://api.github.com/users/cliftonmcintosh/followers","following_url":"https://api.github.com/users/cliftonmcintosh/following{/other_user}","gists_url":"https://api.github.com/users/cliftonmcintosh/gists{/gist_id}","starred_url":"https://api.github.com/users/cliftonmcintosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliftonmcintosh/subscriptions","organizations_url":"https://api.github.com/users/cliftonmcintosh/orgs","repos_url":"https://api.github.com/users/cliftonmcintosh/repos","events_url":"https://api.github.com/users/cliftonmcintosh/events{/privacy}","received_events_url":"https://api.github.com/users/cliftonmcintosh/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T13:01:01Z","updated_at":"2016-10-27T13:01:01Z","body":"@longhotsummer \r\n\r\nDid anyone else have any thoughts on this? @xybrnet?\r\n\r\nI've tested this change on [our project](https://github.com/Code4Nepal/nepalmap_app), and I am able to run `python manage.py migrate` successfully with this change.\r\n\r\nThe one question I have is whether or not a FieldTable with `has_total=False` should not have the `total` column in it? Would that be a breaking change for current implementations of Wazimap?\r\n\r\nIf that seems reasonable and you could point me to where the columns are generated, I would be happy to make an adjustment so that the `total` column is not present when `has_total=False`."}}
{"actor":{"display_login":"cliftonmcintosh"}}