{"action":"closed","number":129,"pull_request":{"url":"https://api.github.com/repos/rsolr/rsolr/pulls/129","id":59107851,"html_url":"https://github.com/rsolr/rsolr/pull/129","diff_url":"https://github.com/rsolr/rsolr/pull/129.diff","patch_url":"https://github.com/rsolr/rsolr/pull/129.patch","issue_url":"https://api.github.com/repos/rsolr/rsolr/issues/129","number":129,"state":"closed","locked":false,"title":"Don't use duck-typing to format values for solr","user":{"login":"cbeer","id":111218,"avatar_url":"https://avatars.githubusercontent.com/u/111218?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeer","html_url":"https://github.com/cbeer","followers_url":"https://api.github.com/users/cbeer/followers","following_url":"https://api.github.com/users/cbeer/following{/other_user}","gists_url":"https://api.github.com/users/cbeer/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeer/subscriptions","organizations_url":"https://api.github.com/users/cbeer/orgs","repos_url":"https://api.github.com/users/cbeer/repos","events_url":"https://api.github.com/users/cbeer/events{/privacy}","received_events_url":"https://api.github.com/users/cbeer/received_events","type":"User","site_admin":false},"body":"Rails helpfully monkey-patches String to include #to_time, and unfortunately\r\nwill throw an ArgumentError if the String isn't time-y. Also, unfortunately, if\r\nthe string is vaguely time-like (e.g. \"2016\"), Rails will provide a time value\r\n(and we certainly don't want to transform every integer into a\r\niso8601-formatted string..)","created_at":"2016-02-11T22:56:28Z","updated_at":"2016-02-12T01:22:53Z","closed_at":"2016-02-12T01:22:52Z","merged_at":"2016-02-12T01:22:52Z","merge_commit_sha":"c93297c6886b3a8d54ee83025db334d5198d4cab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rsolr/rsolr/pulls/129/commits","review_comments_url":"https://api.github.com/repos/rsolr/rsolr/pulls/129/comments","review_comment_url":"https://api.github.com/repos/rsolr/rsolr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsolr/rsolr/issues/129/comments","statuses_url":"https://api.github.com/repos/rsolr/rsolr/statuses/c6d4ff9084647799ece785e9d4e26cbfb0587b78","head":{"label":"rsolr:no-duck-typing","ref":"no-duck-typing","sha":"c6d4ff9084647799ece785e9d4e26cbfb0587b78","user":{"login":"rsolr","id":6413681,"avatar_url":"https://avatars.githubusercontent.com/u/6413681?v=3","gravatar_id":"","url":"https://api.github.com/users/rsolr","html_url":"https://github.com/rsolr","followers_url":"https://api.github.com/users/rsolr/followers","following_url":"https://api.github.com/users/rsolr/following{/other_user}","gists_url":"https://api.github.com/users/rsolr/gists{/gist_id}","starred_url":"https://api.github.com/users/rsolr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsolr/subscriptions","organizations_url":"https://api.github.com/users/rsolr/orgs","repos_url":"https://api.github.com/users/rsolr/repos","events_url":"https://api.github.com/users/rsolr/events{/privacy}","received_events_url":"https://api.github.com/users/rsolr/received_events","type":"Organization","site_admin":false},"repo":{"id":87821,"name":"rsolr","full_name":"rsolr/rsolr","owner":{"login":"rsolr","id":6413681,"avatar_url":"https://avatars.githubusercontent.com/u/6413681?v=3","gravatar_id":"","url":"https://api.github.com/users/rsolr","html_url":"https://github.com/rsolr","followers_url":"https://api.github.com/users/rsolr/followers","following_url":"https://api.github.com/users/rsolr/following{/other_user}","gists_url":"https://api.github.com/users/rsolr/gists{/gist_id}","starred_url":"https://api.github.com/users/rsolr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsolr/subscriptions","organizations_url":"https://api.github.com/users/rsolr/orgs","repos_url":"https://api.github.com/users/rsolr/repos","events_url":"https://api.github.com/users/rsolr/events{/privacy}","received_events_url":"https://api.github.com/users/rsolr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rsolr/rsolr","description":"A Ruby client for Apache Solr","fork":false,"url":"https://api.github.com/repos/rsolr/rsolr","forks_url":"https://api.github.com/repos/rsolr/rsolr/forks","keys_url":"https://api.github.com/repos/rsolr/rsolr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsolr/rsolr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsolr/rsolr/teams","hooks_url":"https://api.github.com/repos/rsolr/rsolr/hooks","issue_events_url":"https://api.github.com/repos/rsolr/rsolr/issues/events{/number}","events_url":"https://api.github.com/repos/rsolr/rsolr/events","assignees_url":"https://api.github.com/repos/rsolr/rsolr/assignees{/user}","branches_url":"https://api.github.com/repos/rsolr/rsolr/branches{/branch}","tags_url":"https://api.github.com/repos/rsolr/rsolr/tags","blobs_url":"https://api.github.com/repos/rsolr/rsolr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsolr/rsolr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsolr/rsolr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsolr/rsolr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsolr/rsolr/statuses/{sha}","languages_url":"https://api.github.com/repos/rsolr/rsolr/languages","stargazers_url":"https://api.github.com/repos/rsolr/rsolr/stargazers","contributors_url":"https://api.github.com/repos/rsolr/rsolr/contributors","subscribers_url":"https://api.github.com/repos/rsolr/rsolr/subscribers","subscription_url":"https://api.github.com/repos/rsolr/rsolr/subscription","commits_url":"https://api.github.com/repos/rsolr/rsolr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsolr/rsolr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsolr/rsolr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsolr/rsolr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsolr/rsolr/contents/{+path}","compare_url":"https://api.github.com/repos/rsolr/rsolr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsolr/rsolr/merges","archive_url":"https://api.github.com/repos/rsolr/rsolr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsolr/rsolr/downloads","issues_url":"https://api.github.com/repos/rsolr/rsolr/issues{/number}","pulls_url":"https://api.github.com/repos/rsolr/rsolr/pulls{/number}","milestones_url":"https://api.github.com/repos/rsolr/rsolr/milestones{/number}","notifications_url":"https://api.github.com/repos/rsolr/rsolr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsolr/rsolr/labels{/name}","releases_url":"https://api.github.com/repos/rsolr/rsolr/releases{/id}","deployments_url":"https://api.github.com/repos/rsolr/rsolr/deployments","created_at":"2008-12-09T20:49:50Z","updated_at":"2016-02-10T03:02:49Z","pushed_at":"2016-02-12T01:22:53Z","git_url":"git://github.com/rsolr/rsolr.git","ssh_url":"git@github.com:rsolr/rsolr.git","clone_url":"https://github.com/rsolr/rsolr.git","svn_url":"https://github.com/rsolr/rsolr","homepage":"","size":64061,"stargazers_count":349,"watchers_count":349,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":128,"mirror_url":null,"open_issues_count":25,"forks":128,"open_issues":25,"watchers":349,"default_branch":"master"}},"base":{"label":"rsolr:master","ref":"master","sha":"1fac3d5c58943b6511d844f874e4848d375649cc","user":{"login":"rsolr","id":6413681,"avatar_url":"https://avatars.githubusercontent.com/u/6413681?v=3","gravatar_id":"","url":"https://api.github.com/users/rsolr","html_url":"https://github.com/rsolr","followers_url":"https://api.github.com/users/rsolr/followers","following_url":"https://api.github.com/users/rsolr/following{/other_user}","gists_url":"https://api.github.com/users/rsolr/gists{/gist_id}","starred_url":"https://api.github.com/users/rsolr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsolr/subscriptions","organizations_url":"https://api.github.com/users/rsolr/orgs","repos_url":"https://api.github.com/users/rsolr/repos","events_url":"https://api.github.com/users/rsolr/events{/privacy}","received_events_url":"https://api.github.com/users/rsolr/received_events","type":"Organization","site_admin":false},"repo":{"id":87821,"name":"rsolr","full_name":"rsolr/rsolr","owner":{"login":"rsolr","id":6413681,"avatar_url":"https://avatars.githubusercontent.com/u/6413681?v=3","gravatar_id":"","url":"https://api.github.com/users/rsolr","html_url":"https://github.com/rsolr","followers_url":"https://api.github.com/users/rsolr/followers","following_url":"https://api.github.com/users/rsolr/following{/other_user}","gists_url":"https://api.github.com/users/rsolr/gists{/gist_id}","starred_url":"https://api.github.com/users/rsolr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsolr/subscriptions","organizations_url":"https://api.github.com/users/rsolr/orgs","repos_url":"https://api.github.com/users/rsolr/repos","events_url":"https://api.github.com/users/rsolr/events{/privacy}","received_events_url":"https://api.github.com/users/rsolr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rsolr/rsolr","description":"A Ruby client for Apache Solr","fork":false,"url":"https://api.github.com/repos/rsolr/rsolr","forks_url":"https://api.github.com/repos/rsolr/rsolr/forks","keys_url":"https://api.github.com/repos/rsolr/rsolr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsolr/rsolr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsolr/rsolr/teams","hooks_url":"https://api.github.com/repos/rsolr/rsolr/hooks","issue_events_url":"https://api.github.com/repos/rsolr/rsolr/issues/events{/number}","events_url":"https://api.github.com/repos/rsolr/rsolr/events","assignees_url":"https://api.github.com/repos/rsolr/rsolr/assignees{/user}","branches_url":"https://api.github.com/repos/rsolr/rsolr/branches{/branch}","tags_url":"https://api.github.com/repos/rsolr/rsolr/tags","blobs_url":"https://api.github.com/repos/rsolr/rsolr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsolr/rsolr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsolr/rsolr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsolr/rsolr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsolr/rsolr/statuses/{sha}","languages_url":"https://api.github.com/repos/rsolr/rsolr/languages","stargazers_url":"https://api.github.com/repos/rsolr/rsolr/stargazers","contributors_url":"https://api.github.com/repos/rsolr/rsolr/contributors","subscribers_url":"https://api.github.com/repos/rsolr/rsolr/subscribers","subscription_url":"https://api.github.com/repos/rsolr/rsolr/subscription","commits_url":"https://api.github.com/repos/rsolr/rsolr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsolr/rsolr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsolr/rsolr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsolr/rsolr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsolr/rsolr/contents/{+path}","compare_url":"https://api.github.com/repos/rsolr/rsolr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsolr/rsolr/merges","archive_url":"https://api.github.com/repos/rsolr/rsolr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsolr/rsolr/downloads","issues_url":"https://api.github.com/repos/rsolr/rsolr/issues{/number}","pulls_url":"https://api.github.com/repos/rsolr/rsolr/pulls{/number}","milestones_url":"https://api.github.com/repos/rsolr/rsolr/milestones{/number}","notifications_url":"https://api.github.com/repos/rsolr/rsolr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsolr/rsolr/labels{/name}","releases_url":"https://api.github.com/repos/rsolr/rsolr/releases{/id}","deployments_url":"https://api.github.com/repos/rsolr/rsolr/deployments","created_at":"2008-12-09T20:49:50Z","updated_at":"2016-02-10T03:02:49Z","pushed_at":"2016-02-12T01:22:53Z","git_url":"git://github.com/rsolr/rsolr.git","ssh_url":"git@github.com:rsolr/rsolr.git","clone_url":"https://github.com/rsolr/rsolr.git","svn_url":"https://github.com/rsolr/rsolr","homepage":"","size":64061,"stargazers_count":349,"watchers_count":349,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":128,"mirror_url":null,"open_issues_count":25,"forks":128,"open_issues":25,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsolr/rsolr/pulls/129"},"html":{"href":"https://github.com/rsolr/rsolr/pull/129"},"issue":{"href":"https://api.github.com/repos/rsolr/rsolr/issues/129"},"comments":{"href":"https://api.github.com/repos/rsolr/rsolr/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/rsolr/rsolr/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/rsolr/rsolr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsolr/rsolr/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/rsolr/rsolr/statuses/c6d4ff9084647799ece785e9d4e26cbfb0587b78"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cbeer","id":111218,"avatar_url":"https://avatars.githubusercontent.com/u/111218?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeer","html_url":"https://github.com/cbeer","followers_url":"https://api.github.com/users/cbeer/followers","following_url":"https://api.github.com/users/cbeer/following{/other_user}","gists_url":"https://api.github.com/users/cbeer/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeer/subscriptions","organizations_url":"https://api.github.com/users/cbeer/orgs","repos_url":"https://api.github.com/users/cbeer/repos","events_url":"https://api.github.com/users/cbeer/events{/privacy}","received_events_url":"https://api.github.com/users/cbeer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":3,"changed_files":1}}