{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/61527999","id":61527999,"diff_hunk":"@@ -73,7 +74,7 @@ func (c *buildConfigs) Get(name string) (result *buildapi.BuildConfig, err error\n func (c *buildConfigs) WebHookURL(name string, trigger *buildapi.BuildTriggerPolicy) (*url.URL, error) {\n \tswitch {\n \tcase trigger.GenericWebHook != nil:\n-\t\treturn c.r.Get().Namespace(c.ns).Resource(\"buildConfigs\").Name(name).SubResource(\"webhooks\").Suffix(trigger.GenericWebHook.Secret, \"generic\").URL(), nil\n+\t\treturn c.r.Get().Namespace(c.ns).Resource(\"buildConfigs\").Name(name).SubResource(\"webhooks\").Suffix(trigger.GenericWebHook.Secret, \"generic\", strconv.FormatBool(trigger.GenericWebHook.AllowEnv)).URL(), nil","path":"pkg/client/buildconfigs.go","position":13,"original_position":13,"commit_id":"06fc70ff1207ca2827bf5844fd5845333b603f49","original_commit_id":"06fc70ff1207ca2827bf5844fd5845333b603f49","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"URL should not have this flag.\n\nOn Thu, Apr 28, 2016 at 9:45 PM, Gabe Montero <notifications@github.com>\nwrote:\n\n> In pkg/client/buildconfigs.go\n> <https://github.com/openshift/origin/pull/8477#discussion_r61527516>:\n>\n> > @@ -73,7 +74,7 @@ func (c *buildConfigs) Get(name string) (result *buildapi.BuildConfig, err error\n> >  func (c *buildConfigs) WebHookURL(name string, trigger *buildapi.BuildTriggerPolicy) (*url.URL, error) {\n> >  \tswitch {\n> >  \tcase trigger.GenericWebHook != nil:\n> > -\t\treturn c.r.Get().Namespace(c.ns).Resource(\"buildConfigs\").Name(name).SubResource(\"webhooks\").Suffix(trigger.GenericWebHook.Secret, \"generic\").URL(), nil\n> > +\t\treturn c.r.Get().Namespace(c.ns).Resource(\"buildConfigs\").Name(name).SubResource(\"webhooks\").Suffix(trigger.GenericWebHook.Secret, \"generic\", strconv.FormatBool(trigger.GenericWebHook.AllowEnv)).URL(), nil\n>\n> I had interpreted the earlier comment (\"you still want to look where i\n> pointed because we do dump out the urls of the webhooks. Adding the value\n> of this field to that output seems reasonable to me.\") as meaning I had to\n> somehow reflect whether allowEnv was true or false in the URL that was\n> returned here.\n>\n> If correct in that assumption, I had tried inserting it after the secret\n> name, but before \"generic\", originally but that messed up the oc\n> start-build --from-webhook parsing.\n>\n> So do I have to include whether allowEnv is either true or false here in\n> some fashion (and if it is a position thing, figure out how to make sure\n> start-build still works)? Or is something else needed?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/openshift/origin/pull/8477/files/06fc70ff1207ca2827bf5844fd5845333b603f49#r61527516>\n>\n","created_at":"2016-04-29T01:56:29Z","updated_at":"2016-04-29T01:56:29Z","html_url":"https://github.com/openshift/origin/pull/8477#discussion_r61527999","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8477","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/61527999"},"html":{"href":"https://github.com/openshift/origin/pull/8477#discussion_r61527999"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8477"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8477","id":66178438,"html_url":"https://github.com/openshift/origin/pull/8477","diff_url":"https://github.com/openshift/origin/pull/8477.diff","patch_url":"https://github.com/openshift/origin/pull/8477.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8477","number":8477,"state":"open","locked":false,"title":"Allow parameters on generic webhook build trigger call","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"@bparees PTAL .... in the end the flow is very similar to how the k/v pairs from a `oc start-build` induced `BuildRequest` object are propagated into copy of the BC that is read in from etcd.  Once in the local copy of the BC, it is available to the build in the same fashion.\r\n\r\nGranted, this is my first time through this portion of the code ... perhaps I've missed an important nuance.","created_at":"2016-04-12T15:31:15Z","updated_at":"2016-04-29T01:56:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"313cba0620ad906f18824344b0909c40a1f703e5","assignee":null,"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/13","html_url":"https://github.com/openshift/origin/milestones/1.2.x","labels_url":"https://api.github.com/repos/openshift/origin/milestones/13/labels","id":1594965,"number":13,"title":"1.2.x","description":"Features delivered after 1.2.","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":21,"state":"open","created_at":"2016-02-20T19:27:29Z","updated_at":"2016-04-28T23:03:20Z","due_on":"2016-05-06T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8477/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8477/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8477/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/06fc70ff1207ca2827bf5844fd5845333b603f49","head":{"label":"gabemontero:kvHook","ref":"kvHook","sha":"06fc70ff1207ca2827bf5844fd5845333b603f49","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36941154,"name":"origin","full_name":"gabemontero/origin","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/gabemontero/origin","forks_url":"https://api.github.com/repos/gabemontero/origin/forks","keys_url":"https://api.github.com/repos/gabemontero/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/origin/teams","hooks_url":"https://api.github.com/repos/gabemontero/origin/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/origin/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/origin/events","assignees_url":"https://api.github.com/repos/gabemontero/origin/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/origin/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/origin/tags","blobs_url":"https://api.github.com/repos/gabemontero/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/origin/languages","stargazers_url":"https://api.github.com/repos/gabemontero/origin/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/origin/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/origin/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/origin/subscription","commits_url":"https://api.github.com/repos/gabemontero/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/origin/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/origin/merges","archive_url":"https://api.github.com/repos/gabemontero/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/origin/downloads","issues_url":"https://api.github.com/repos/gabemontero/origin/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/origin/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/origin/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/origin/deployments","created_at":"2015-06-05T15:48:08Z","updated_at":"2016-01-11T14:36:57Z","pushed_at":"2016-04-28T14:15:21Z","git_url":"git://github.com/gabemontero/origin.git","ssh_url":"git@github.com:gabemontero/origin.git","clone_url":"https://github.com/gabemontero/origin.git","svn_url":"https://github.com/gabemontero/origin","homepage":"http://www.openshift.org","size":260377,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"458998788337e983fa3e5f9a837664ec00a89204","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-04-28T23:54:06Z","pushed_at":"2016-04-29T01:52:46Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":344189,"stargazers_count":1258,"watchers_count":1258,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":758,"mirror_url":null,"open_issues_count":994,"forks":758,"open_issues":994,"watchers":1258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8477"},"html":{"href":"https://github.com/openshift/origin/pull/8477"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8477"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8477/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8477/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8477/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/06fc70ff1207ca2827bf5844fd5845333b603f49"}}}}