{"action":"created","issue":{"url":"https://api.github.com/repos/tvdzwan/hyperion/issues/470","repository_url":"https://api.github.com/repos/tvdzwan/hyperion","labels_url":"https://api.github.com/repos/tvdzwan/hyperion/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/tvdzwan/hyperion/issues/470/comments","events_url":"https://api.github.com/repos/tvdzwan/hyperion/issues/470/events","html_url":"https://github.com/tvdzwan/hyperion/pull/470","id":128985782,"number":470,"title":"Blackborder Improved + (bugfix and enhancement)","user":{"login":"wisc17","id":16512414,"avatar_url":"https://avatars.githubusercontent.com/u/16512414?v=3","gravatar_id":"","url":"https://api.github.com/users/wisc17","html_url":"https://github.com/wisc17","followers_url":"https://api.github.com/users/wisc17/followers","following_url":"https://api.github.com/users/wisc17/following{/other_user}","gists_url":"https://api.github.com/users/wisc17/gists{/gist_id}","starred_url":"https://api.github.com/users/wisc17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wisc17/subscriptions","organizations_url":"https://api.github.com/users/wisc17/orgs","repos_url":"https://api.github.com/users/wisc17/repos","events_url":"https://api.github.com/users/wisc17/events{/privacy}","received_events_url":"https://api.github.com/users/wisc17/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-01-27T00:22:19Z","updated_at":"2016-02-06T15:34:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tvdzwan/hyperion/pulls/470","html_url":"https://github.com/tvdzwan/hyperion/pull/470","diff_url":"https://github.com/tvdzwan/hyperion/pull/470.diff","patch_url":"https://github.com/tvdzwan/hyperion/pull/470.patch"},"body":"fixed a bug that caused undefined behaviour in detection,\r\ncausing it to get stuck at 0,0 border detection.\r\n\r\nAlso made json config accessable in blackborder classes for easy adjusting values that are static in current build.\r\n\r\nAdded different detection modes.\r\n\r\nsee config/hyperion.config.json\r\n```\r\n\"blackborderdetector\" :\r\n \t{\r\n \t\t\"enable\" : true,\r\n \t\t\"threshold\" : 0.01,\r\n+\t\t\"unknownFrameCnt\": 600,         <- optional\r\n+\t\t\"borderFrameCnt\" : 50,          <- optional\r\n+\t\t\"maxInconsistentCnt\" : 10,      <- optional\r\n+\t\t\"blurRemoveCnt\": 1,             <- optional\r\n+\t\t\"mode\" : \"default\"              <- optional\r\n \t}\r\n\r\n```\r\n\r\nModes:\r\n**default**: 3 scanlines per direction - fastest detection so far (because of the nature of movies to have none black content in the center area;)\r\n**classic**: the original implementation - needs less cpu but only covers top left 1/3 of the image and could cause problems with station logos\r\n**osd**: little bit less efficient then default mode but avoids changes caused by receiver OSD overlays like program info or volume bars\r\n\r\n![blackborder_scanlines](https://cloud.githubusercontent.com/assets/16512414/12702277/771e8a48-c824-11e5-8a8b-cd2e32f0c342.jpg)\r\nclick the image for a better view of the scanlines in osd mode"},"comment":{"url":"https://api.github.com/repos/tvdzwan/hyperion/issues/comments/180792195","html_url":"https://github.com/tvdzwan/hyperion/pull/470#issuecomment-180792195","issue_url":"https://api.github.com/repos/tvdzwan/hyperion/issues/470","id":180792195,"user":{"login":"RickDB","id":347084,"avatar_url":"https://avatars.githubusercontent.com/u/347084?v=3","gravatar_id":"","url":"https://api.github.com/users/RickDB","html_url":"https://github.com/RickDB","followers_url":"https://api.github.com/users/RickDB/followers","following_url":"https://api.github.com/users/RickDB/following{/other_user}","gists_url":"https://api.github.com/users/RickDB/gists{/gist_id}","starred_url":"https://api.github.com/users/RickDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RickDB/subscriptions","organizations_url":"https://api.github.com/users/RickDB/orgs","repos_url":"https://api.github.com/users/RickDB/repos","events_url":"https://api.github.com/users/RickDB/events{/privacy}","received_events_url":"https://api.github.com/users/RickDB/received_events","type":"User","site_admin":false},"created_at":"2016-02-06T15:34:54Z","updated_at":"2016-02-06T15:34:54Z","body":"Great explanation and thanks for making these improvements :+1:"}}