{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/11620","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/11620/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/11620/comments","events_url":"https://api.github.com/repos/servo/servo/issues/11620/events","html_url":"https://github.com/servo/servo/pull/11620","id":158555396,"number":11620,"title":"Implement [Unscopable] (fixes #11583)","user":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2016-06-05T13:52:56Z","updated_at":"2016-06-07T12:42:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/11620","html_url":"https://github.com/servo/servo/pull/11620","diff_url":"https://github.com/servo/servo/pull/11620.diff","patch_url":"https://github.com/servo/servo/pull/11620.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/11620)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/224268266","html_url":"https://github.com/servo/servo/pull/11620#issuecomment-224268266","issue_url":"https://api.github.com/repos/servo/servo/issues/11620","id":224268266,"user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T12:42:06Z","updated_at":"2016-06-07T12:42:06Z","body":"-S-awaiting-review +S-needs-code-changes \n\n<details><summary><i>Previously, bors-servo wrote…</i></summary>\n> :sunny: Test successful - [android](http://build.servo.org/builders/android/builds/1309), [arm32](http://build.servo.org/builders/arm32/builds/1399), [arm64](http://build.servo.org/builders/arm64/builds/1385), [linux-dev](http://build.servo.org/builders/linux-dev/builds/1408), [linux-rel](http://build.servo.org/builders/linux-rel/builds/1471), [mac-dev-unit](http://build.servo.org/builders/mac-dev-unit/builds/1451), [mac-rel-css](http://build.servo.org/builders/mac-rel-css/builds/1435), [mac-rel-wpt](http://build.servo.org/builders/mac-rel-wpt/builds/1488), [windows](http://build.servo.org/builders/windows/builds/1117)\n</details>\n\n\n---\n\nReviewed 7 of 7 files at r1.\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[components/script/dom/bindings/interface.rs, line 249 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/11620#-KJersOK53V_Du4iF5E8:-KJersOK53V_Du4iF5E9:79258749) ([raw file](https://github.com/servo/servo/blob/64c1e007bbde437dc9ddccdee960859f5083ce39/components/script/dom/bindings/interface.rs#L249)):*\n> ```Rust\n>         let unscopable_symbol = GetWellKnownSymbol(cx, SymbolCode::unscopables);\n>         assert!(!unscopable_symbol.is_null());\n>         let unscopable_id = RootedId::new(cx, RUST_SYMBOL_TO_JSID(unscopable_symbol));\n> ```\n\nPlease try to add a few empty lines in this block\n\n---\n\n*[components/script/dom/bindings/codegen/CodegenRust.py, line 5121 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/11620#-KJesC3zo6-MJ7awi00u:-KJesC3zo6-MJ7awi00v:1277456304) ([raw file](https://github.com/servo/servo/blob/64c1e007bbde437dc9ddccdee960859f5083ce39/components/script/dom/bindings/codegen/CodegenRust.py#L5121)):*\n> ```Python\n> \n>         haveUnscopables = (len(unscopableNames) != 0 and\n>                            descriptor.interface.hasInterfacePrototypeObject())\n> ```\n\nPlease don't use `hasInterfacePrototypeObject`; make this `if unscopableNames:` under the `if not descriptor.interface.isCallback():` block.\n\n---\n\n*[components/script/dom/webidls/ChildNode.webidl, line 11 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/11620#-KJesQN1CQz94MbboxKw:-KJesQN1CQz94MbboxKx:76269631) ([raw file](https://github.com/servo/servo/blob/64c1e007bbde437dc9ddccdee960859f5083ce39/components/script/dom/webidls/ChildNode.webidl#L11)):*\n> ```WebIDL\n> [NoInterfaceObject]\n> interface ChildNode {\n>   [Throws, Unscopable]\n> ```\n\nI'd like all of those to be tested.  (idlharness?)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/11620#-:-KJesZVN92UJFakHkCTD:1458266033)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Ms2ger"}}