{"action":"created","comment":{"url":"https://api.github.com/repos/kivy/kivy/pulls/comments/93962164","pull_request_review_id":14493251,"id":93962164,"diff_hunk":"@@ -97,12 +146,9 @@ def _update(self, dt):\n \n     def start(self):\n         super(CameraOpenCV, self).start()\n-        if self._update_ev is not None:\n-            self._update_ev.cancel()\n-        self._update_ev = Clock.schedule_interval(self._update, self.fps)\n+        Clock.unschedule(self._update)\n+        Clock.schedule_interval(self._update, self.fps)\n \n     def stop(self):\n         super(CameraOpenCV, self).stop()\n-        if self._update_ev is not None:\n-            self._update_ev.cancel()\n-            self._update_ev = None\n+        Clock.unschedule(self._update)","path":"kivy/core/camera/camera_opencv.py","position":174,"original_position":174,"commit_id":"0286dcb4f6051540051e3db82de3efcdd8fa1290","original_commit_id":"0286dcb4f6051540051e3db82de3efcdd8fa1290","user":{"login":"dessant","id":7513068,"avatar_url":"https://avatars.githubusercontent.com/u/7513068?v=3","gravatar_id":"","url":"https://api.github.com/users/dessant","html_url":"https://github.com/dessant","followers_url":"https://api.github.com/users/dessant/followers","following_url":"https://api.github.com/users/dessant/following{/other_user}","gists_url":"https://api.github.com/users/dessant/gists{/gist_id}","starred_url":"https://api.github.com/users/dessant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dessant/subscriptions","organizations_url":"https://api.github.com/users/dessant/orgs","repos_url":"https://api.github.com/users/dessant/repos","events_url":"https://api.github.com/users/dessant/events{/privacy}","received_events_url":"https://api.github.com/users/dessant/received_events","type":"User","site_admin":false},"body":"Same as https://github.com/kivy/kivy/pull/4828/files#r93962100.","created_at":"2016-12-27T19:19:47Z","updated_at":"2016-12-27T19:19:47Z","html_url":"https://github.com/kivy/kivy/pull/4828#discussion_r93962164","pull_request_url":"https://api.github.com/repos/kivy/kivy/pulls/4828","_links":{"self":{"href":"https://api.github.com/repos/kivy/kivy/pulls/comments/93962164"},"html":{"href":"https://github.com/kivy/kivy/pull/4828#discussion_r93962164"},"pull_request":{"href":"https://api.github.com/repos/kivy/kivy/pulls/4828"}}},"pull_request":{"url":"https://api.github.com/repos/kivy/kivy/pulls/4828","id":98492858,"html_url":"https://github.com/kivy/kivy/pull/4828","diff_url":"https://github.com/kivy/kivy/pull/4828.diff","patch_url":"https://github.com/kivy/kivy/pull/4828.patch","issue_url":"https://api.github.com/repos/kivy/kivy/issues/4828","number":4828,"state":"open","locked":false,"title":"added support for opencv 2 and 3","user":{"login":"amateusz","id":9356928,"avatar_url":"https://avatars.githubusercontent.com/u/9356928?v=3","gravatar_id":"","url":"https://api.github.com/users/amateusz","html_url":"https://github.com/amateusz","followers_url":"https://api.github.com/users/amateusz/followers","following_url":"https://api.github.com/users/amateusz/following{/other_user}","gists_url":"https://api.github.com/users/amateusz/gists{/gist_id}","starred_url":"https://api.github.com/users/amateusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amateusz/subscriptions","organizations_url":"https://api.github.com/users/amateusz/orgs","repos_url":"https://api.github.com/users/amateusz/repos","events_url":"https://api.github.com/users/amateusz/events{/privacy}","received_events_url":"https://api.github.com/users/amateusz/received_events","type":"User","site_admin":false},"body":"I updated this file to deal with current opencv versions 2.4 and 3.x.\r\nThere are elif branches to initalize everything accordingly. Methods differ. My fav one is @ line 106 'frame.width' -> 'frame.shape[0]' indicating different datatype..\r\nOpencv's naming convention is sick IMO.\r\n(tested both on win10 and ver.3 on RPi)\r\n\r\n*** that's my first PR, so please correct me if I'm wrong or something ***","created_at":"2016-12-18T23:58:15Z","updated_at":"2016-12-27T19:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1ca689655d996abeb99632cf3174131ecd535c8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kivy/kivy/pulls/4828/commits","review_comments_url":"https://api.github.com/repos/kivy/kivy/pulls/4828/comments","review_comment_url":"https://api.github.com/repos/kivy/kivy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kivy/kivy/issues/4828/comments","statuses_url":"https://api.github.com/repos/kivy/kivy/statuses/0286dcb4f6051540051e3db82de3efcdd8fa1290","head":{"label":"amateusz:master","ref":"master","sha":"0286dcb4f6051540051e3db82de3efcdd8fa1290","user":{"login":"amateusz","id":9356928,"avatar_url":"https://avatars.githubusercontent.com/u/9356928?v=3","gravatar_id":"","url":"https://api.github.com/users/amateusz","html_url":"https://github.com/amateusz","followers_url":"https://api.github.com/users/amateusz/followers","following_url":"https://api.github.com/users/amateusz/following{/other_user}","gists_url":"https://api.github.com/users/amateusz/gists{/gist_id}","starred_url":"https://api.github.com/users/amateusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amateusz/subscriptions","organizations_url":"https://api.github.com/users/amateusz/orgs","repos_url":"https://api.github.com/users/amateusz/repos","events_url":"https://api.github.com/users/amateusz/events{/privacy}","received_events_url":"https://api.github.com/users/amateusz/received_events","type":"User","site_admin":false},"repo":{"id":76804099,"name":"kivy","full_name":"amateusz/kivy","owner":{"login":"amateusz","id":9356928,"avatar_url":"https://avatars.githubusercontent.com/u/9356928?v=3","gravatar_id":"","url":"https://api.github.com/users/amateusz","html_url":"https://github.com/amateusz","followers_url":"https://api.github.com/users/amateusz/followers","following_url":"https://api.github.com/users/amateusz/following{/other_user}","gists_url":"https://api.github.com/users/amateusz/gists{/gist_id}","starred_url":"https://api.github.com/users/amateusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amateusz/subscriptions","organizations_url":"https://api.github.com/users/amateusz/orgs","repos_url":"https://api.github.com/users/amateusz/repos","events_url":"https://api.github.com/users/amateusz/events{/privacy}","received_events_url":"https://api.github.com/users/amateusz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amateusz/kivy","description":"Open source UI framework written in Python, running on Windows, Linux, macOS, Android and iOS","fork":true,"url":"https://api.github.com/repos/amateusz/kivy","forks_url":"https://api.github.com/repos/amateusz/kivy/forks","keys_url":"https://api.github.com/repos/amateusz/kivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amateusz/kivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amateusz/kivy/teams","hooks_url":"https://api.github.com/repos/amateusz/kivy/hooks","issue_events_url":"https://api.github.com/repos/amateusz/kivy/issues/events{/number}","events_url":"https://api.github.com/repos/amateusz/kivy/events","assignees_url":"https://api.github.com/repos/amateusz/kivy/assignees{/user}","branches_url":"https://api.github.com/repos/amateusz/kivy/branches{/branch}","tags_url":"https://api.github.com/repos/amateusz/kivy/tags","blobs_url":"https://api.github.com/repos/amateusz/kivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amateusz/kivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amateusz/kivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/amateusz/kivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amateusz/kivy/statuses/{sha}","languages_url":"https://api.github.com/repos/amateusz/kivy/languages","stargazers_url":"https://api.github.com/repos/amateusz/kivy/stargazers","contributors_url":"https://api.github.com/repos/amateusz/kivy/contributors","subscribers_url":"https://api.github.com/repos/amateusz/kivy/subscribers","subscription_url":"https://api.github.com/repos/amateusz/kivy/subscription","commits_url":"https://api.github.com/repos/amateusz/kivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/amateusz/kivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/amateusz/kivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/amateusz/kivy/issues/comments{/number}","contents_url":"https://api.github.com/repos/amateusz/kivy/contents/{+path}","compare_url":"https://api.github.com/repos/amateusz/kivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amateusz/kivy/merges","archive_url":"https://api.github.com/repos/amateusz/kivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amateusz/kivy/downloads","issues_url":"https://api.github.com/repos/amateusz/kivy/issues{/number}","pulls_url":"https://api.github.com/repos/amateusz/kivy/pulls{/number}","milestones_url":"https://api.github.com/repos/amateusz/kivy/milestones{/number}","notifications_url":"https://api.github.com/repos/amateusz/kivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amateusz/kivy/labels{/name}","releases_url":"https://api.github.com/repos/amateusz/kivy/releases{/id}","deployments_url":"https://api.github.com/repos/amateusz/kivy/deployments","created_at":"2016-12-18T20:08:47Z","updated_at":"2016-12-18T20:08:52Z","pushed_at":"2016-12-21T22:33:59Z","git_url":"git://github.com/amateusz/kivy.git","ssh_url":"git@github.com:amateusz/kivy.git","clone_url":"https://github.com/amateusz/kivy.git","svn_url":"https://github.com/amateusz/kivy","homepage":"https://kivy.org","size":51206,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kivy:master","ref":"master","sha":"ec4961e3a511976a951ae16c9817d1e4a8d1b82b","user":{"login":"kivy","id":1266152,"avatar_url":"https://avatars.githubusercontent.com/u/1266152?v=3","gravatar_id":"","url":"https://api.github.com/users/kivy","html_url":"https://github.com/kivy","followers_url":"https://api.github.com/users/kivy/followers","following_url":"https://api.github.com/users/kivy/following{/other_user}","gists_url":"https://api.github.com/users/kivy/gists{/gist_id}","starred_url":"https://api.github.com/users/kivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivy/subscriptions","organizations_url":"https://api.github.com/users/kivy/orgs","repos_url":"https://api.github.com/users/kivy/repos","events_url":"https://api.github.com/users/kivy/events{/privacy}","received_events_url":"https://api.github.com/users/kivy/received_events","type":"Organization","site_admin":false},"repo":{"id":1049095,"name":"kivy","full_name":"kivy/kivy","owner":{"login":"kivy","id":1266152,"avatar_url":"https://avatars.githubusercontent.com/u/1266152?v=3","gravatar_id":"","url":"https://api.github.com/users/kivy","html_url":"https://github.com/kivy","followers_url":"https://api.github.com/users/kivy/followers","following_url":"https://api.github.com/users/kivy/following{/other_user}","gists_url":"https://api.github.com/users/kivy/gists{/gist_id}","starred_url":"https://api.github.com/users/kivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivy/subscriptions","organizations_url":"https://api.github.com/users/kivy/orgs","repos_url":"https://api.github.com/users/kivy/repos","events_url":"https://api.github.com/users/kivy/events{/privacy}","received_events_url":"https://api.github.com/users/kivy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kivy/kivy","description":"Open source UI framework written in Python, running on Windows, Linux, macOS, Android and iOS","fork":false,"url":"https://api.github.com/repos/kivy/kivy","forks_url":"https://api.github.com/repos/kivy/kivy/forks","keys_url":"https://api.github.com/repos/kivy/kivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kivy/kivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kivy/kivy/teams","hooks_url":"https://api.github.com/repos/kivy/kivy/hooks","issue_events_url":"https://api.github.com/repos/kivy/kivy/issues/events{/number}","events_url":"https://api.github.com/repos/kivy/kivy/events","assignees_url":"https://api.github.com/repos/kivy/kivy/assignees{/user}","branches_url":"https://api.github.com/repos/kivy/kivy/branches{/branch}","tags_url":"https://api.github.com/repos/kivy/kivy/tags","blobs_url":"https://api.github.com/repos/kivy/kivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kivy/kivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kivy/kivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kivy/kivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kivy/kivy/statuses/{sha}","languages_url":"https://api.github.com/repos/kivy/kivy/languages","stargazers_url":"https://api.github.com/repos/kivy/kivy/stargazers","contributors_url":"https://api.github.com/repos/kivy/kivy/contributors","subscribers_url":"https://api.github.com/repos/kivy/kivy/subscribers","subscription_url":"https://api.github.com/repos/kivy/kivy/subscription","commits_url":"https://api.github.com/repos/kivy/kivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kivy/kivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kivy/kivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kivy/kivy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kivy/kivy/contents/{+path}","compare_url":"https://api.github.com/repos/kivy/kivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kivy/kivy/merges","archive_url":"https://api.github.com/repos/kivy/kivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kivy/kivy/downloads","issues_url":"https://api.github.com/repos/kivy/kivy/issues{/number}","pulls_url":"https://api.github.com/repos/kivy/kivy/pulls{/number}","milestones_url":"https://api.github.com/repos/kivy/kivy/milestones{/number}","notifications_url":"https://api.github.com/repos/kivy/kivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kivy/kivy/labels{/name}","releases_url":"https://api.github.com/repos/kivy/kivy/releases{/id}","deployments_url":"https://api.github.com/repos/kivy/kivy/deployments","created_at":"2010-11-03T20:27:32Z","updated_at":"2016-12-27T15:24:24Z","pushed_at":"2016-12-27T18:09:11Z","git_url":"git://github.com/kivy/kivy.git","ssh_url":"git@github.com:kivy/kivy.git","clone_url":"https://github.com/kivy/kivy.git","svn_url":"https://github.com/kivy/kivy","homepage":"https://kivy.org","size":51308,"stargazers_count":5198,"watchers_count":5198,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1339,"mirror_url":null,"open_issues_count":549,"forks":1339,"open_issues":549,"watchers":5198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kivy/kivy/pulls/4828"},"html":{"href":"https://github.com/kivy/kivy/pull/4828"},"issue":{"href":"https://api.github.com/repos/kivy/kivy/issues/4828"},"comments":{"href":"https://api.github.com/repos/kivy/kivy/issues/4828/comments"},"review_comments":{"href":"https://api.github.com/repos/kivy/kivy/pulls/4828/comments"},"review_comment":{"href":"https://api.github.com/repos/kivy/kivy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kivy/kivy/pulls/4828/commits"},"statuses":{"href":"https://api.github.com/repos/kivy/kivy/statuses/0286dcb4f6051540051e3db82de3efcdd8fa1290"}}}}
{"actor":{"display_login":"dessant"}}