{"action":"closed","number":880,"pull_request":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/880","id":67558965,"html_url":"https://github.com/Microsoft/nodejstools/pull/880","diff_url":"https://github.com/Microsoft/nodejstools/pull/880.diff","patch_url":"https://github.com/Microsoft/nodejstools/pull/880.patch","issue_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/880","number":880,"state":"closed","locked":false,"title":"Fix dispose pattern in a few more cases","user":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars.githubusercontent.com/u/12821956?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"body":"Using the VS static analyzer to find objects that are not being disposed properly and fixing some of these.\r\n\r\nRelated to #870. Still trying to track down who exactly is holding onto the NodeJsProject node after it is unloaded","created_at":"2016-04-22T19:12:08Z","updated_at":"2016-04-25T18:59:23Z","closed_at":"2016-04-25T18:59:23Z","merged_at":null,"merge_commit_sha":"9e551c35d883e4d9f333ec07b1f722ec47ad8d04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/880/commits","review_comments_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/880/comments","review_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/880/comments","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/fab587248b3f92b894e4137c8f005fd20e15a3c7","head":{"label":"mjbvz:more-disposable-fixes","ref":"more-disposable-fixes","sha":"fab587248b3f92b894e4137c8f005fd20e15a3c7","user":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars.githubusercontent.com/u/12821956?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"repo":{"id":52391688,"name":"nodejstools","full_name":"mjbvz/nodejstools","owner":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars.githubusercontent.com/u/12821956?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjbvz/nodejstools","description":"Node.js Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/mjbvz/nodejstools","forks_url":"https://api.github.com/repos/mjbvz/nodejstools/forks","keys_url":"https://api.github.com/repos/mjbvz/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjbvz/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjbvz/nodejstools/teams","hooks_url":"https://api.github.com/repos/mjbvz/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/mjbvz/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/mjbvz/nodejstools/events","assignees_url":"https://api.github.com/repos/mjbvz/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/mjbvz/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/mjbvz/nodejstools/tags","blobs_url":"https://api.github.com/repos/mjbvz/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjbvz/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjbvz/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjbvz/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjbvz/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/mjbvz/nodejstools/languages","stargazers_url":"https://api.github.com/repos/mjbvz/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/mjbvz/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/mjbvz/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/mjbvz/nodejstools/subscription","commits_url":"https://api.github.com/repos/mjbvz/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjbvz/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjbvz/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjbvz/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjbvz/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/mjbvz/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjbvz/nodejstools/merges","archive_url":"https://api.github.com/repos/mjbvz/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjbvz/nodejstools/downloads","issues_url":"https://api.github.com/repos/mjbvz/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/mjbvz/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/mjbvz/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/mjbvz/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjbvz/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/mjbvz/nodejstools/releases{/id}","deployments_url":"https://api.github.com/repos/mjbvz/nodejstools/deployments","created_at":"2016-02-23T21:06:55Z","updated_at":"2016-02-23T21:07:01Z","pushed_at":"2016-04-22T21:00:22Z","git_url":"git://github.com/mjbvz/nodejstools.git","ssh_url":"git@github.com:mjbvz/nodejstools.git","clone_url":"https://github.com/mjbvz/nodejstools.git","svn_url":"https://github.com/mjbvz/nodejstools","homepage":"http://aka.ms/explorentvs","size":92839,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"d4e31e9f45e6b675c778337caa34b60759d7be88","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":33017149,"name":"nodejstools","full_name":"Microsoft/nodejstools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/nodejstools","description":"Node.js Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/nodejstools","forks_url":"https://api.github.com/repos/Microsoft/nodejstools/forks","keys_url":"https://api.github.com/repos/Microsoft/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/nodejstools/teams","hooks_url":"https://api.github.com/repos/Microsoft/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/nodejstools/events","assignees_url":"https://api.github.com/repos/Microsoft/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/nodejstools/tags","blobs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/nodejstools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/nodejstools/subscription","commits_url":"https://api.github.com/repos/Microsoft/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/nodejstools/merges","archive_url":"https://api.github.com/repos/Microsoft/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/nodejstools/downloads","issues_url":"https://api.github.com/repos/Microsoft/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/nodejstools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/nodejstools/deployments","created_at":"2015-03-28T01:37:20Z","updated_at":"2016-04-25T12:53:48Z","pushed_at":"2016-04-22T21:01:03Z","git_url":"git://github.com/Microsoft/nodejstools.git","ssh_url":"git@github.com:Microsoft/nodejstools.git","clone_url":"https://github.com/Microsoft/nodejstools.git","svn_url":"https://github.com/Microsoft/nodejstools","homepage":"http://aka.ms/explorentvs","size":93964,"stargazers_count":1182,"watchers_count":1182,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":221,"forks":180,"open_issues":221,"watchers":1182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/880"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/880"},"issue":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/880"},"comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/nodejstools/statuses/fab587248b3f92b894e4137c8f005fd20e15a3c7"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":2,"commits":3,"additions":44,"deletions":39,"changed_files":8}}