{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/64689123","id":64689123,"diff_hunk":"@@ -25,10 +25,12 @@ var adal = require('adal-node');\n var utils = require('../utils');\n var defaultTokenCacheFile = path.join(utils.azureDir(), 'accessTokens.json');\n \n+var useSecureTokenStorage = utils.ignoreCaseEquals(process.env['AZURE_USE_SECURE_TOKEN_STORAGE'], 'true') ||","path":"lib/util/authentication/adalAuth.js","position":4,"original_position":4,"commit_id":"c7e9464e39f8249908625a8131f624be744ac277","original_commit_id":"c7e9464e39f8249908625a8131f624be744ac277","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"body":"There is no truthy values, it is either set or not set unless we parse the value\r\nFor now till the SDLC gets approved. People must opt-in the file storage explicitly. With you proposed change, the file based storage becomes the default, which is not what we want.\r\nThis flag, for most people, should be completelytransparent. With that, i like people who set the flag will see no behavior change once we switch the default value.  ","created_at":"2016-05-26T03:59:44Z","updated_at":"2016-05-26T03:59:44Z","html_url":"https://github.com/Azure/azure-xplat-cli/pull/2903#discussion_r64689123","pull_request_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/64689123"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/2903#discussion_r64689123"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903","id":71475079,"html_url":"https://github.com/Azure/azure-xplat-cli/pull/2903","diff_url":"https://github.com/Azure/azure-xplat-cli/pull/2903.diff","patch_url":"https://github.com/Azure/azure-xplat-cli/pull/2903.patch","issue_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2903","number":2903,"state":"open","locked":false,"title":"expose a switch to use file based token storage","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-25T22:44:14Z","updated_at":"2016-05-26T03:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0108b7ee1c499cd81f58916108dbf340cd03ed09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2903/comments","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/c7e9464e39f8249908625a8131f624be744ac277","head":{"label":"yugangw-msft:fileoption","ref":"fileoption","sha":"c7e9464e39f8249908625a8131f624be744ac277","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"repo":{"id":20169483,"name":"azure-xplat-cli","full_name":"yugangw-msft/azure-xplat-cli","owner":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yugangw-msft/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":true,"url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli","forks_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/releases{/id}","deployments_url":"https://api.github.com/repos/yugangw-msft/azure-xplat-cli/deployments","created_at":"2014-05-26T00:17:37Z","updated_at":"2016-01-11T21:36:57Z","pushed_at":"2016-05-25T22:43:33Z","git_url":"git://github.com/yugangw-msft/azure-xplat-cli.git","ssh_url":"git@github.com:yugangw-msft/azure-xplat-cli.git","clone_url":"https://github.com/yugangw-msft/azure-xplat-cli.git","svn_url":"https://github.com/yugangw-msft/azure-xplat-cli","homepage":"","size":77602,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"288a480ef168a47a1839914aa17b6ac37798f0a2","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":6506651,"name":"azure-xplat-cli","full_name":"Azure/azure-xplat-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":false,"url":"https://api.github.com/repos/Azure/azure-xplat-cli","forks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-xplat-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/deployments","created_at":"2012-11-02T13:43:50Z","updated_at":"2016-05-24T21:50:59Z","pushed_at":"2016-05-26T01:40:48Z","git_url":"git://github.com/Azure/azure-xplat-cli.git","ssh_url":"git@github.com:Azure/azure-xplat-cli.git","clone_url":"https://github.com/Azure/azure-xplat-cli.git","svn_url":"https://github.com/Azure/azure-xplat-cli","homepage":"","size":89967,"stargazers_count":433,"watchers_count":433,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":314,"mirror_url":null,"open_issues_count":272,"forks":314,"open_issues":272,"watchers":433,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/2903"},"issue":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2903"},"comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2903/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2903/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/c7e9464e39f8249908625a8131f624be744ac277"}}}}
{"actor":{"display_login":"yugangw-msft"}}