{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/5470","repository_url":"https://api.github.com/repos/jekyll/jekyll","labels_url":"https://api.github.com/repos/jekyll/jekyll/issues/5470/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/5470/comments","events_url":"https://api.github.com/repos/jekyll/jekyll/issues/5470/events","html_url":"https://github.com/jekyll/jekyll/pull/5470","id":181868452,"number":5470,"title":"Add ThemeDataReader for data files in theme-gems","user":{"login":"ashmaroli","id":12479464,"avatar_url":"https://avatars.githubusercontent.com/u/12479464?v=3","gravatar_id":"","url":"https://api.github.com/users/ashmaroli","html_url":"https://github.com/ashmaroli","followers_url":"https://api.github.com/users/ashmaroli/followers","following_url":"https://api.github.com/users/ashmaroli/following{/other_user}","gists_url":"https://api.github.com/users/ashmaroli/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmaroli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmaroli/subscriptions","organizations_url":"https://api.github.com/users/ashmaroli/orgs","repos_url":"https://api.github.com/users/ashmaroli/repos","events_url":"https://api.github.com/users/ashmaroli/events{/privacy}","received_events_url":"https://api.github.com/users/ashmaroli/received_events","type":"User","site_admin":false},"labels":[{"id":350839400,"url":"https://api.github.com/repos/jekyll/jekyll/labels/friction","name":"friction","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"benbalter","id":282759,"avatar_url":"https://avatars.githubusercontent.com/u/282759?v=3","gravatar_id":"","url":"https://api.github.com/users/benbalter","html_url":"https://github.com/benbalter","followers_url":"https://api.github.com/users/benbalter/followers","following_url":"https://api.github.com/users/benbalter/following{/other_user}","gists_url":"https://api.github.com/users/benbalter/gists{/gist_id}","starred_url":"https://api.github.com/users/benbalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbalter/subscriptions","organizations_url":"https://api.github.com/users/benbalter/orgs","repos_url":"https://api.github.com/users/benbalter/repos","events_url":"https://api.github.com/users/benbalter/events{/privacy}","received_events_url":"https://api.github.com/users/benbalter/received_events","type":"User","site_admin":true},"assignees":[{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":true},{"login":"benbalter","id":282759,"avatar_url":"https://avatars.githubusercontent.com/u/282759?v=3","gravatar_id":"","url":"https://api.github.com/users/benbalter","html_url":"https://github.com/benbalter","followers_url":"https://api.github.com/users/benbalter/followers","following_url":"https://api.github.com/users/benbalter/following{/other_user}","gists_url":"https://api.github.com/users/benbalter/gists{/gist_id}","starred_url":"https://api.github.com/users/benbalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbalter/subscriptions","organizations_url":"https://api.github.com/users/benbalter/orgs","repos_url":"https://api.github.com/users/benbalter/repos","events_url":"https://api.github.com/users/benbalter/events{/privacy}","received_events_url":"https://api.github.com/users/benbalter/received_events","type":"User","site_admin":true}],"milestone":null,"comments":13,"created_at":"2016-10-09T06:06:36Z","updated_at":"2016-11-21T15:40:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/5470","html_url":"https://github.com/jekyll/jekyll/pull/5470","diff_url":"https://github.com/jekyll/jekyll/pull/5470.diff","patch_url":"https://github.com/jekyll/jekyll/pull/5470.patch"},"body":"If a theme gem contains a `_data` folder at its root, its files will be read and added to the site's internal data hash. The theme-gem's data hash will be overridden by data at source if the same 'key-value' pair exists there.\n## \n\nTODO:\n- [x] Add tests\n- [x] Add cucumber feature\n- [x] Add Documentation\n## \n\nRef: #5434 \n/cc @jekyll/ecosystem, @envygeeks, @pathawks  \n"},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll/issues/comments/261973143","html_url":"https://github.com/jekyll/jekyll/pull/5470#issuecomment-261973143","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/5470","id":261973143,"user":{"login":"Swiftrien","id":10923244,"avatar_url":"https://avatars.githubusercontent.com/u/10923244?v=3","gravatar_id":"","url":"https://api.github.com/users/Swiftrien","html_url":"https://github.com/Swiftrien","followers_url":"https://api.github.com/users/Swiftrien/followers","following_url":"https://api.github.com/users/Swiftrien/following{/other_user}","gists_url":"https://api.github.com/users/Swiftrien/gists{/gist_id}","starred_url":"https://api.github.com/users/Swiftrien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swiftrien/subscriptions","organizations_url":"https://api.github.com/users/Swiftrien/orgs","repos_url":"https://api.github.com/users/Swiftrien/repos","events_url":"https://api.github.com/users/Swiftrien/events{/privacy}","received_events_url":"https://api.github.com/users/Swiftrien/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T15:40:51Z","updated_at":"2016-11-21T15:40:51Z","body":"I have nothing against promotion :-)\r\n[classic-jekyll-theme](https://rubygems.org/gems/classic-jekyll-theme) :-)\r\n\r\nI just added the jekyll-data (0.3.0) gem to a website of mine, removed the _data directory, rebuild the site, and everything is as it should be. Thus jekyll-data seems to work fine. Note that I did not use the \"theme configuration\" only the \"regular data\" files.\r\n\r\nMy bigger issue with external contributions is that is takes away my control. And I have had several experiences where external dependencies costs me huge amounts of time. So in general I try to avoid them where possible. As it is, I think that the jekyll-data gem adds enough value that I will probably include it in the next release. (Mainly because I hope it will be part of Jekyll 3.4 anyhow... ;-))"}}
{"actor":{"display_login":"Swiftrien"}}