{"action":"created","issue":{"url":"https://api.github.com/repos/flyjs/fly/issues/229","repository_url":"https://api.github.com/repos/flyjs/fly","labels_url":"https://api.github.com/repos/flyjs/fly/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/flyjs/fly/issues/229/comments","events_url":"https://api.github.com/repos/flyjs/fly/issues/229/events","html_url":"https://github.com/flyjs/fly/issues/229","id":186415920,"number":229,"title":"Manage `files` & `globs` differently","user":{"login":"lukeed","id":5855893,"avatar_url":"https://avatars.githubusercontent.com/u/5855893?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeed","html_url":"https://github.com/lukeed","followers_url":"https://api.github.com/users/lukeed/followers","following_url":"https://api.github.com/users/lukeed/following{/other_user}","gists_url":"https://api.github.com/users/lukeed/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeed/subscriptions","organizations_url":"https://api.github.com/users/lukeed/orgs","repos_url":"https://api.github.com/users/lukeed/repos","events_url":"https://api.github.com/users/lukeed/events{/privacy}","received_events_url":"https://api.github.com/users/lukeed/received_events","type":"User","site_admin":false},"labels":[{"id":482264101,"url":"https://api.github.com/repos/flyjs/fly/labels/ASAP","name":"ASAP","color":"5319e7","default":false},{"id":231576772,"url":"https://api.github.com/repos/flyjs/fly/labels/improvement","name":"improvement","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/flyjs/fly/milestones/9","html_url":"https://github.com/flyjs/fly/milestone/9","labels_url":"https://api.github.com/repos/flyjs/fly/milestones/9/labels","id":2033463,"number":9,"title":"2.0.0","description":null,"creator":{"login":"lukeed","id":5855893,"avatar_url":"https://avatars.githubusercontent.com/u/5855893?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeed","html_url":"https://github.com/lukeed","followers_url":"https://api.github.com/users/lukeed/followers","following_url":"https://api.github.com/users/lukeed/following{/other_user}","gists_url":"https://api.github.com/users/lukeed/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeed/subscriptions","organizations_url":"https://api.github.com/users/lukeed/orgs","repos_url":"https://api.github.com/users/lukeed/repos","events_url":"https://api.github.com/users/lukeed/events{/privacy}","received_events_url":"https://api.github.com/users/lukeed/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":21,"state":"open","created_at":"2016-09-27T23:50:07Z","updated_at":"2016-11-07T02:21:12Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2016-10-31T22:28:28Z","updated_at":"2016-12-28T17:09:35Z","closed_at":null,"body":"The values are stored & retrieved perfectly with single tasks and `serial` chains.\r\n\r\nBut with _large_ `parallel` chain, the known values aren't 100% consistent. This is because ALL tasks & plugins are looking at & modifying the same internal variables: `fly._.files`, `fly._.globs`.\r\n\r\n#### Ideas\r\n\r\nAttach `files` and `globs` values to each `fly.tasks` entry.\r\n\r\n* Will need a getter & setter for `files()` and `globs()`. These return & set the current task's values.\r\n\r\n* Will need a way to know what `task` is currently being executed."},"comment":{"url":"https://api.github.com/repos/flyjs/fly/issues/comments/269507486","html_url":"https://github.com/flyjs/fly/issues/229#issuecomment-269507486","issue_url":"https://api.github.com/repos/flyjs/fly/issues/229","id":269507486,"user":{"login":"hzlmn","id":8246283,"avatar_url":"https://avatars.githubusercontent.com/u/8246283?v=3","gravatar_id":"","url":"https://api.github.com/users/hzlmn","html_url":"https://github.com/hzlmn","followers_url":"https://api.github.com/users/hzlmn/followers","following_url":"https://api.github.com/users/hzlmn/following{/other_user}","gists_url":"https://api.github.com/users/hzlmn/gists{/gist_id}","starred_url":"https://api.github.com/users/hzlmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzlmn/subscriptions","organizations_url":"https://api.github.com/users/hzlmn/orgs","repos_url":"https://api.github.com/users/hzlmn/repos","events_url":"https://api.github.com/users/hzlmn/events{/privacy}","received_events_url":"https://api.github.com/users/hzlmn/received_events","type":"User","site_admin":false},"created_at":"2016-12-28T17:09:35Z","updated_at":"2016-12-28T17:09:35Z","body":"Hi @lukeed, just a quick thoughts...\r\n\r\nThe one solution (but bad), that won't break current api is to implement `priority queue` for accessing internal `this._.files` from tasks that executes in parallel. \r\n\r\nAnother one that comes to mind, is to move `files` state managment from `fly` to `task` context, basically we should have separate structure for it.\r\nI can not find a situation where i want to share file context between separate tasks, it's kinda hack for me.\r\n\r\nAlso plus from me for @rauchg proposition to use explicit `fly` instance inside config (It won't fix current problem, just a better? design)\r\n\r\nWhat do you thinkg @jbucaran ?"}}
{"actor":{"display_login":"hzlmn"}}