{"action":"created","issue":{"url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL/issues/28","repository_url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL","labels_url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL/issues/28/comments","events_url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL/issues/28/events","html_url":"https://github.com/VisualDataWeb/OWL2VOWL/pull/28","id":193304945,"number":28,"title":"Make `OntologyConverter` use the manager of the ontology provided instead of a new one","user":{"login":"AndreyMZ","id":9609370,"avatar_url":"https://avatars.githubusercontent.com/u/9609370?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyMZ","html_url":"https://github.com/AndreyMZ","followers_url":"https://api.github.com/users/AndreyMZ/followers","following_url":"https://api.github.com/users/AndreyMZ/following{/other_user}","gists_url":"https://api.github.com/users/AndreyMZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyMZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyMZ/subscriptions","organizations_url":"https://api.github.com/users/AndreyMZ/orgs","repos_url":"https://api.github.com/users/AndreyMZ/repos","events_url":"https://api.github.com/users/AndreyMZ/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyMZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AndreyMZ","id":9609370,"avatar_url":"https://avatars.githubusercontent.com/u/9609370?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyMZ","html_url":"https://github.com/AndreyMZ","followers_url":"https://api.github.com/users/AndreyMZ/followers","following_url":"https://api.github.com/users/AndreyMZ/following{/other_user}","gists_url":"https://api.github.com/users/AndreyMZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyMZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyMZ/subscriptions","organizations_url":"https://api.github.com/users/AndreyMZ/orgs","repos_url":"https://api.github.com/users/AndreyMZ/repos","events_url":"https://api.github.com/users/AndreyMZ/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyMZ/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndreyMZ","id":9609370,"avatar_url":"https://avatars.githubusercontent.com/u/9609370?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyMZ","html_url":"https://github.com/AndreyMZ","followers_url":"https://api.github.com/users/AndreyMZ/followers","following_url":"https://api.github.com/users/AndreyMZ/following{/other_user}","gists_url":"https://api.github.com/users/AndreyMZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyMZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyMZ/subscriptions","organizations_url":"https://api.github.com/users/AndreyMZ/orgs","repos_url":"https://api.github.com/users/AndreyMZ/repos","events_url":"https://api.github.com/users/AndreyMZ/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyMZ/received_events","type":"User","site_admin":false},{"login":"BlackDark","id":9947112,"avatar_url":"https://avatars.githubusercontent.com/u/9947112?v=3","gravatar_id":"","url":"https://api.github.com/users/BlackDark","html_url":"https://github.com/BlackDark","followers_url":"https://api.github.com/users/BlackDark/followers","following_url":"https://api.github.com/users/BlackDark/following{/other_user}","gists_url":"https://api.github.com/users/BlackDark/gists{/gist_id}","starred_url":"https://api.github.com/users/BlackDark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlackDark/subscriptions","organizations_url":"https://api.github.com/users/BlackDark/orgs","repos_url":"https://api.github.com/users/BlackDark/repos","events_url":"https://api.github.com/users/BlackDark/events{/privacy}","received_events_url":"https://api.github.com/users/BlackDark/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-03T18:13:27Z","updated_at":"2016-12-04T17:03:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL/pulls/28","html_url":"https://github.com/VisualDataWeb/OWL2VOWL/pull/28","diff_url":"https://github.com/VisualDataWeb/OWL2VOWL/pull/28.diff","patch_url":"https://github.com/VisualDataWeb/OWL2VOWL/pull/28.patch"},"body":"This pull request fixes the following issue.\r\n\r\n#### Steps to reproduce\r\n(Need to define `getMyOntology()` somehow.)\r\n\r\n```java\r\n@Test\r\npublic void testOntologyConverter() throws Exception\r\n{\r\n\tOWLOntology ontology = getMyOntology();\r\n\tConverter converter = new OntologyConverter(ontology);\r\n\tconverter.convert();\r\n\tconverter.export(new Exporter() {\r\n\t\t@Override\r\n\t\tpublic void write(String text) throws Exception {\r\n\t\t}\r\n\t});\r\n}\r\n\r\n```\r\n\r\n#### Actual result\r\n```\r\norg.semanticweb.owlapi.model.UnknownOWLOntologyException: Unknown ontology: OntologyID(OntologyIRI(<http://example.com/my-ontology>) VersionIRI(<null>))\r\n\tat uk.ac.manchester.cs.owl.owlapi.OWLOntologyManagerImpl.getImports(OWLOntologyManagerImpl.java:439)\r\n\tat de.uni_stuttgart.vis.vowl.owl2vowl.parser.vowl.ImportedChecker.execute(ImportedChecker.java:33)\r\n\tat de.uni_stuttgart.vis.vowl.owl2vowl.converter.AbstractConverter.postParsing(AbstractConverter.java:133)\r\n\tat de.uni_stuttgart.vis.vowl.owl2vowl.converter.AbstractConverter.convert(AbstractConverter.java:164)\r\n...\r\n```\r\n\r\n#### Expected result\r\nThe ontology is converted successfully.\r\n\r\n#### Root cause\r\nThe `manager` is defined in `AbstractConverter.java:140`:\r\n\r\n```\r\nmanager = OWLManager.createOWLOntologyManager();\r\n```\r\n\r\n`ImportedChecker.java:33` contains the following line of code:\r\n\r\n```java\r\nSet<OWLOntology> imports = manager.getImports(loadedOntology);\r\n```\r\n\r\nThis throws `UnknownOWLOntologyException` because the `loadedOntology` was loaded in *other* ontology manager.\r\n"},"comment":{"url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL/issues/comments/264715973","html_url":"https://github.com/VisualDataWeb/OWL2VOWL/pull/28#issuecomment-264715973","issue_url":"https://api.github.com/repos/VisualDataWeb/OWL2VOWL/issues/28","id":264715973,"user":{"login":"AndreyMZ","id":9609370,"avatar_url":"https://avatars.githubusercontent.com/u/9609370?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyMZ","html_url":"https://github.com/AndreyMZ","followers_url":"https://api.github.com/users/AndreyMZ/followers","following_url":"https://api.github.com/users/AndreyMZ/following{/other_user}","gists_url":"https://api.github.com/users/AndreyMZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyMZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyMZ/subscriptions","organizations_url":"https://api.github.com/users/AndreyMZ/orgs","repos_url":"https://api.github.com/users/AndreyMZ/repos","events_url":"https://api.github.com/users/AndreyMZ/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyMZ/received_events","type":"User","site_admin":false},"created_at":"2016-12-04T17:03:49Z","updated_at":"2016-12-04T17:03:49Z","body":"Hi, I have updated the pull request description (the first comment)."}}
{"actor":{"display_login":"AndreyMZ"}}