{"action":"created","issue":{"url":"https://api.github.com/repos/cfe-lab/Kive/issues/406","repository_url":"https://api.github.com/repos/cfe-lab/Kive","labels_url":"https://api.github.com/repos/cfe-lab/Kive/issues/406/labels{/name}","comments_url":"https://api.github.com/repos/cfe-lab/Kive/issues/406/comments","events_url":"https://api.github.com/repos/cfe-lab/Kive/issues/406/events","html_url":"https://github.com/cfe-lab/Kive/issues/406","id":94414121,"number":406,"title":"Cannot upload files with unusual characters as CodeResources","user":{"login":"rhliang","id":5862525,"avatar_url":"https://avatars.githubusercontent.com/u/5862525?v=3","gravatar_id":"","url":"https://api.github.com/users/rhliang","html_url":"https://github.com/rhliang","followers_url":"https://api.github.com/users/rhliang/followers","following_url":"https://api.github.com/users/rhliang/following{/other_user}","gists_url":"https://api.github.com/users/rhliang/gists{/gist_id}","starred_url":"https://api.github.com/users/rhliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhliang/subscriptions","organizations_url":"https://api.github.com/users/rhliang/orgs","repos_url":"https://api.github.com/users/rhliang/repos","events_url":"https://api.github.com/users/rhliang/events{/privacy}","received_events_url":"https://api.github.com/users/rhliang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cfe-lab/Kive/milestones/16","html_url":"https://github.com/cfe-lab/Kive/milestones/0.8%20-%20user%20batch%20processing","labels_url":"https://api.github.com/repos/cfe-lab/Kive/milestones/16/labels","id":1556805,"number":16,"title":"0.8 - user batch processing","description":"The main feature of this release will be to provide a graphical interface for mapping multiple sets of inputs to a given pipeline.","creator":{"login":"ArtPoon","id":1109328,"avatar_url":"https://avatars.githubusercontent.com/u/1109328?v=3","gravatar_id":"","url":"https://api.github.com/users/ArtPoon","html_url":"https://github.com/ArtPoon","followers_url":"https://api.github.com/users/ArtPoon/followers","following_url":"https://api.github.com/users/ArtPoon/following{/other_user}","gists_url":"https://api.github.com/users/ArtPoon/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtPoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtPoon/subscriptions","organizations_url":"https://api.github.com/users/ArtPoon/orgs","repos_url":"https://api.github.com/users/ArtPoon/repos","events_url":"https://api.github.com/users/ArtPoon/events{/privacy}","received_events_url":"https://api.github.com/users/ArtPoon/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":32,"state":"open","created_at":"2016-02-01T21:12:01Z","updated_at":"2016-06-24T22:53:11Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-07-10T23:42:07Z","updated_at":"2016-06-24T22:59:49Z","closed_at":"2016-06-24T22:53:11Z","body":"Building on #403, the code that handles creation of new CodeResources sets `filename` to the name of the file that has just been uploaded.  That's why we run into problems: the `filename` field of CodeResource must obey the regular expression `^(\\b|([-_.()\\w]+ *)*[-_.()\\w]+)$`.  Some options for a way forward:\r\n\r\n* continue to only allow users to upload files that are named appropriately on their computers, and instruct them of this requirement\r\n* allow users to upload any file, but allow them to specify an alternate filename that obeys the regex\r\n* loosen the regex so that we just accept more filenames\r\n\r\nOne idea that I think *won't* work is to slugify the filenames ourselves.  Developers that use this CodeResource may rely on the CodeResource filename being known exactly, as it's used when \"installing\" the CodeResourceRevision into a sandbox.\r\n\r\nAlso, whatever check we end up doing should be carried out by the frontend.  As it is, the error is only reported to you *after* uploading your file, which might be slow."},"comment":{"url":"https://api.github.com/repos/cfe-lab/Kive/issues/comments/228483614","html_url":"https://github.com/cfe-lab/Kive/issues/406#issuecomment-228483614","issue_url":"https://api.github.com/repos/cfe-lab/Kive/issues/406","id":228483614,"user":{"login":"rhliang","id":5862525,"avatar_url":"https://avatars.githubusercontent.com/u/5862525?v=3","gravatar_id":"","url":"https://api.github.com/users/rhliang","html_url":"https://github.com/rhliang","followers_url":"https://api.github.com/users/rhliang/followers","following_url":"https://api.github.com/users/rhliang/following{/other_user}","gists_url":"https://api.github.com/users/rhliang/gists{/gist_id}","starred_url":"https://api.github.com/users/rhliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhliang/subscriptions","organizations_url":"https://api.github.com/users/rhliang/orgs","repos_url":"https://api.github.com/users/rhliang/repos","events_url":"https://api.github.com/users/rhliang/events{/privacy}","received_events_url":"https://api.github.com/users/rhliang/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T22:59:49Z","updated_at":"2016-06-24T22:59:49Z","body":"We changed the error message to be more explicit, describing exactly which characters can be used in the filename."}}
{"actor":{"display_login":"rhliang"}}