{"action":"closed","number":315,"pull_request":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/315","id":86668254,"html_url":"https://github.com/jeff-regier/Celeste.jl/pull/315","diff_url":"https://github.com/jeff-regier/Celeste.jl/pull/315.diff","patch_url":"https://github.com/jeff-regier/Celeste.jl/pull/315.patch","issue_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/315","number":315,"state":"closed","locked":false,"title":"Disallow epsilon = 0, and try to catch NaNs earlier","user":{"login":"gostevehoward","id":1097616,"avatar_url":"https://avatars.githubusercontent.com/u/1097616?v=3","gravatar_id":"","url":"https://api.github.com/users/gostevehoward","html_url":"https://github.com/gostevehoward","followers_url":"https://api.github.com/users/gostevehoward/followers","following_url":"https://api.github.com/users/gostevehoward/following{/other_user}","gists_url":"https://api.github.com/users/gostevehoward/gists{/gist_id}","starred_url":"https://api.github.com/users/gostevehoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gostevehoward/subscriptions","organizations_url":"https://api.github.com/users/gostevehoward/orgs","repos_url":"https://api.github.com/users/gostevehoward/repos","events_url":"https://api.github.com/users/gostevehoward/events{/privacy}","received_events_url":"https://api.github.com/users/gostevehoward/received_events","type":"User","site_admin":false},"body":"@jeff-regier What do you think of these? Does the check on epsilon seem reasonable? Is this a good place to check it? Are the asserts going to be too much of a performance hit? I'm not sure if Julia optimizes out asserts under certain conditions or what...I can research it.","created_at":"2016-09-26T00:31:06Z","updated_at":"2016-10-04T07:09:04Z","closed_at":"2016-10-04T07:09:04Z","merged_at":"2016-10-04T07:09:04Z","merge_commit_sha":"835faec0f797d519a7b10197f2ca22ef73e41ae3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/315/commits","review_comments_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/315/comments","review_comment_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/315/comments","statuses_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/statuses/b7798dc1f64f48583c53f9acf0fdfafb9efbdbd4","head":{"label":"gostevehoward:zero_epsilon_nans","ref":"zero_epsilon_nans","sha":"b7798dc1f64f48583c53f9acf0fdfafb9efbdbd4","user":{"login":"gostevehoward","id":1097616,"avatar_url":"https://avatars.githubusercontent.com/u/1097616?v=3","gravatar_id":"","url":"https://api.github.com/users/gostevehoward","html_url":"https://github.com/gostevehoward","followers_url":"https://api.github.com/users/gostevehoward/followers","following_url":"https://api.github.com/users/gostevehoward/following{/other_user}","gists_url":"https://api.github.com/users/gostevehoward/gists{/gist_id}","starred_url":"https://api.github.com/users/gostevehoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gostevehoward/subscriptions","organizations_url":"https://api.github.com/users/gostevehoward/orgs","repos_url":"https://api.github.com/users/gostevehoward/repos","events_url":"https://api.github.com/users/gostevehoward/events{/privacy}","received_events_url":"https://api.github.com/users/gostevehoward/received_events","type":"User","site_admin":false},"repo":{"id":67193981,"name":"Celeste.jl","full_name":"gostevehoward/Celeste.jl","owner":{"login":"gostevehoward","id":1097616,"avatar_url":"https://avatars.githubusercontent.com/u/1097616?v=3","gravatar_id":"","url":"https://api.github.com/users/gostevehoward","html_url":"https://github.com/gostevehoward","followers_url":"https://api.github.com/users/gostevehoward/followers","following_url":"https://api.github.com/users/gostevehoward/following{/other_user}","gists_url":"https://api.github.com/users/gostevehoward/gists{/gist_id}","starred_url":"https://api.github.com/users/gostevehoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gostevehoward/subscriptions","organizations_url":"https://api.github.com/users/gostevehoward/orgs","repos_url":"https://api.github.com/users/gostevehoward/repos","events_url":"https://api.github.com/users/gostevehoward/events{/privacy}","received_events_url":"https://api.github.com/users/gostevehoward/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gostevehoward/Celeste.jl","description":"Scalable inference for a generative model of astronomical images","fork":true,"url":"https://api.github.com/repos/gostevehoward/Celeste.jl","forks_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/forks","keys_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/teams","hooks_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/hooks","issue_events_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/issues/events{/number}","events_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/events","assignees_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/assignees{/user}","branches_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/branches{/branch}","tags_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/tags","blobs_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/languages","stargazers_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/stargazers","contributors_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/contributors","subscribers_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/subscribers","subscription_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/subscription","commits_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/contents/{+path}","compare_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/merges","archive_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/downloads","issues_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/issues{/number}","pulls_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/labels{/name}","releases_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/releases{/id}","deployments_url":"https://api.github.com/repos/gostevehoward/Celeste.jl/deployments","created_at":"2016-09-02T05:50:00Z","updated_at":"2016-09-02T05:50:00Z","pushed_at":"2016-10-04T04:54:53Z","git_url":"git://github.com/gostevehoward/Celeste.jl.git","ssh_url":"git@github.com:gostevehoward/Celeste.jl.git","clone_url":"https://github.com/gostevehoward/Celeste.jl.git","svn_url":"https://github.com/gostevehoward/Celeste.jl","homepage":"","size":4684,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jeff-regier:master","ref":"master","sha":"4b385430d7298f75966a04b2b955cc75f78a396b","user":{"login":"jeff-regier","id":8953355,"avatar_url":"https://avatars.githubusercontent.com/u/8953355?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-regier","html_url":"https://github.com/jeff-regier","followers_url":"https://api.github.com/users/jeff-regier/followers","following_url":"https://api.github.com/users/jeff-regier/following{/other_user}","gists_url":"https://api.github.com/users/jeff-regier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-regier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-regier/subscriptions","organizations_url":"https://api.github.com/users/jeff-regier/orgs","repos_url":"https://api.github.com/users/jeff-regier/repos","events_url":"https://api.github.com/users/jeff-regier/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-regier/received_events","type":"User","site_admin":false},"repo":{"id":28730928,"name":"Celeste.jl","full_name":"jeff-regier/Celeste.jl","owner":{"login":"jeff-regier","id":8953355,"avatar_url":"https://avatars.githubusercontent.com/u/8953355?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-regier","html_url":"https://github.com/jeff-regier","followers_url":"https://api.github.com/users/jeff-regier/followers","following_url":"https://api.github.com/users/jeff-regier/following{/other_user}","gists_url":"https://api.github.com/users/jeff-regier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-regier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-regier/subscriptions","organizations_url":"https://api.github.com/users/jeff-regier/orgs","repos_url":"https://api.github.com/users/jeff-regier/repos","events_url":"https://api.github.com/users/jeff-regier/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-regier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeff-regier/Celeste.jl","description":"Scalable inference for a generative model of astronomical images","fork":false,"url":"https://api.github.com/repos/jeff-regier/Celeste.jl","forks_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/forks","keys_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/teams","hooks_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/hooks","issue_events_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/events{/number}","events_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/events","assignees_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/assignees{/user}","branches_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/branches{/branch}","tags_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/tags","blobs_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/languages","stargazers_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/stargazers","contributors_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/contributors","subscribers_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/subscribers","subscription_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/subscription","commits_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/contents/{+path}","compare_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/merges","archive_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/downloads","issues_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues{/number}","pulls_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/labels{/name}","releases_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/releases{/id}","deployments_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/deployments","created_at":"2015-01-03T00:47:34Z","updated_at":"2016-09-25T01:13:34Z","pushed_at":"2016-10-04T07:09:04Z","git_url":"git://github.com/jeff-regier/Celeste.jl.git","ssh_url":"git@github.com:jeff-regier/Celeste.jl.git","clone_url":"https://github.com/jeff-regier/Celeste.jl.git","svn_url":"https://github.com/jeff-regier/Celeste.jl","homepage":"","size":57265,"stargazers_count":13,"watchers_count":13,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":39,"forks":9,"open_issues":39,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/315"},"html":{"href":"https://github.com/jeff-regier/Celeste.jl/pull/315"},"issue":{"href":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/315"},"comments":{"href":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/jeff-regier/Celeste.jl/statuses/b7798dc1f64f48583c53f9acf0fdfafb9efbdbd4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeff-regier","id":8953355,"avatar_url":"https://avatars.githubusercontent.com/u/8953355?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-regier","html_url":"https://github.com/jeff-regier","followers_url":"https://api.github.com/users/jeff-regier/followers","following_url":"https://api.github.com/users/jeff-regier/following{/other_user}","gists_url":"https://api.github.com/users/jeff-regier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-regier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-regier/subscriptions","organizations_url":"https://api.github.com/users/jeff-regier/orgs","repos_url":"https://api.github.com/users/jeff-regier/repos","events_url":"https://api.github.com/users/jeff-regier/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-regier/received_events","type":"User","site_admin":false},"comments":12,"review_comments":1,"commits":2,"additions":32,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"jeff-regier"}}