{"action":"created","comment":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79196217","id":79196217,"diff_hunk":"@@ -37,8 +37,12 @@ type KubeadmConfig struct {\n \n type InitFlags struct {\n \tAPI struct {\n-\t\tAdvertiseAddrs  []net.IP\n-\t\tExternalDNSName []string\n+\t\tAdvertiseAddrs        []net.IP\n+\t\tExternalDNSName       []string\n+\t\tExternalEtcdEndpoints []string","path":"pkg/kubeadm/api/types.go","position":8,"original_position":8,"commit_id":"ded467b5665f8986de39bd268931d8368646e1c0","original_commit_id":"ded467b5665f8986de39bd268931d8368646e1c0","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"body":"I'd move these into another subfield. This field is meant to be only about settings that relate to \"how is API server reached?\".","created_at":"2016-09-16T15:44:18Z","updated_at":"2016-09-16T15:44:18Z","html_url":"https://github.com/errordeveloper/kubernetes/pull/7#discussion_r79196217","pull_request_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments/79196217"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/7#discussion_r79196217"},"pull_request":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7","id":84892883,"html_url":"https://github.com/errordeveloper/kubernetes/pull/7","diff_url":"https://github.com/errordeveloper/kubernetes/pull/7.diff","patch_url":"https://github.com/errordeveloper/kubernetes/pull/7.patch","issue_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/7","number":7,"state":"open","locked":false,"title":"Add support for external and optionally secured etcd cluster.","user":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"body":"As per request on last week's meeting, I've added support for the usage of external, optionally secured, etcd cluster.\r\n\r\nBy default, a local, non-secured etcd instance will be bootstrapped. Below are some examples on how to use the external etcd cluster:\r\n\r\n\r\n#### Local (right now, no TLS or client authentication enabled)\r\n```\r\nkubeadm init\r\n```\r\n\r\n#### External, two nodes, no TLS\r\n\r\n```\r\nkubeadm init \\\r\n--external-etcd-endpoints=\"http://NODE_1:2379\" \\\r\n--external-etcd-endpoints=\"http://NODE_2:2379\"\r\n```\r\n\r\n#### External, two nodes, TLS enabled with self-signed certificate\r\n\r\nMake sure `/etc/ssl/certs/etcd/ca.pem` file exists on the pod and its contents have the CA certificate.\r\n\r\n```\r\nkubeadm init \\\r\n--external-etcd-endpoints=\"https://NODE_1:2379\" \\\r\n--external-etcd-endpoints=\"https://NODE_2:2379\" \\\r\n--external-etcd-cafile=/etc/ssl/certs/etcd/ca.pem\r\n```\r\n\r\n#### External, two nodes, TLS enabled with self-signed certificate, client authentication enabled\r\n\r\nMake sure:\r\n\r\n* `/etc/ssl/certs/etcd/ca.pem` file exists on the pod and its contents have the CA certificate.\r\n* `/etc/ssl/certs/etcd/client.pem` file exists on the pod and contents have the client certificate.\r\n* `/etc/ssl/certs/etcd/client-key.pem` file exists on the pod and contents have the client key.\r\n\r\n```\r\nkubeadm init \\\r\n--external-etcd-endpoints=\"https://NODE_1:2379\" \\\r\n--external-etcd-endpoints=\"https://NODE_2:2379\" \\\r\n--external-etcd-cafile=/etc/ssl/certs/etcd/ca.pem\\\r\n--external-etcd-certfile=/etc/ssl/certs/etcd/client.pem \\\r\n--external-etcd-keyfile=/etc/ssl/certs/etcd/client-key.pem\r\n```","created_at":"2016-09-12T15:32:44Z","updated_at":"2016-09-16T15:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fafa147efcbadae8f7fc828488a9fc655926e6a5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7/commits","review_comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7/comments","review_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/7/comments","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/ded467b5665f8986de39bd268931d8368646e1c0","head":{"label":"pires:kubeadm-external-etcd","ref":"kubeadm-external-etcd","sha":"ded467b5665f8986de39bd268931d8368646e1c0","user":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"repo":{"id":28869198,"name":"kubernetes","full_name":"pires/kubernetes","owner":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pires/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/pires/kubernetes","forks_url":"https://api.github.com/repos/pires/kubernetes/forks","keys_url":"https://api.github.com/repos/pires/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pires/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pires/kubernetes/teams","hooks_url":"https://api.github.com/repos/pires/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pires/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pires/kubernetes/events","assignees_url":"https://api.github.com/repos/pires/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pires/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pires/kubernetes/tags","blobs_url":"https://api.github.com/repos/pires/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pires/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pires/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pires/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pires/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pires/kubernetes/languages","stargazers_url":"https://api.github.com/repos/pires/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pires/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pires/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pires/kubernetes/subscription","commits_url":"https://api.github.com/repos/pires/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pires/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pires/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pires/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pires/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pires/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pires/kubernetes/merges","archive_url":"https://api.github.com/repos/pires/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pires/kubernetes/downloads","issues_url":"https://api.github.com/repos/pires/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pires/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pires/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pires/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pires/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pires/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/pires/kubernetes/deployments","created_at":"2015-01-06T15:24:52Z","updated_at":"2016-03-22T14:21:11Z","pushed_at":"2016-09-15T09:26:28Z","git_url":"git://github.com/pires/kubernetes.git","ssh_url":"git@github.com:pires/kubernetes.git","clone_url":"https://github.com/pires/kubernetes.git","svn_url":"https://github.com/pires/kubernetes","homepage":null,"size":313293,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"errordeveloper:kubeadm","ref":"kubeadm","sha":"437024f448af12b2e4d3aca3aadac7bb7c877451","user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"repo":{"id":25202727,"name":"kubernetes","full_name":"errordeveloper/kubernetes","owner":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/errordeveloper/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/errordeveloper/kubernetes","forks_url":"https://api.github.com/repos/errordeveloper/kubernetes/forks","keys_url":"https://api.github.com/repos/errordeveloper/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/errordeveloper/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/errordeveloper/kubernetes/teams","hooks_url":"https://api.github.com/repos/errordeveloper/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/errordeveloper/kubernetes/events","assignees_url":"https://api.github.com/repos/errordeveloper/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/errordeveloper/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/tags","blobs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/errordeveloper/kubernetes/languages","stargazers_url":"https://api.github.com/repos/errordeveloper/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/errordeveloper/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/errordeveloper/kubernetes/subscription","commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/errordeveloper/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/errordeveloper/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/errordeveloper/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/errordeveloper/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/errordeveloper/kubernetes/merges","archive_url":"https://api.github.com/repos/errordeveloper/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/errordeveloper/kubernetes/downloads","issues_url":"https://api.github.com/repos/errordeveloper/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/errordeveloper/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/errordeveloper/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/errordeveloper/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/errordeveloper/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/errordeveloper/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/errordeveloper/kubernetes/deployments","created_at":"2014-10-14T11:13:25Z","updated_at":"2016-03-23T12:29:37Z","pushed_at":"2016-09-16T15:34:23Z","git_url":"git://github.com/errordeveloper/kubernetes.git","ssh_url":"git@github.com:errordeveloper/kubernetes.git","clone_url":"https://github.com/errordeveloper/kubernetes.git","svn_url":"https://github.com/errordeveloper/kubernetes","homepage":null,"size":315546,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7"},"html":{"href":"https://github.com/errordeveloper/kubernetes/pull/7"},"issue":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/7"},"comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/errordeveloper/kubernetes/statuses/ded467b5665f8986de39bd268931d8368646e1c0"}}}}
{"actor":{"display_login":"errordeveloper"}}