{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1879","repository_url":"https://api.github.com/repos/w3c/web-platform-tests","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1879/labels{/name}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1879/comments","events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1879/events","html_url":"https://github.com/w3c/web-platform-tests/pull/1879","id":85717351,"number":1879,"title":"Add tests for SVGElement.ownerSVGElement.","user":{"login":"heycam","id":1484434,"avatar_url":"https://avatars.githubusercontent.com/u/1484434?v=3","gravatar_id":"","url":"https://api.github.com/users/heycam","html_url":"https://github.com/heycam","followers_url":"https://api.github.com/users/heycam/followers","following_url":"https://api.github.com/users/heycam/following{/other_user}","gists_url":"https://api.github.com/users/heycam/gists{/gist_id}","starred_url":"https://api.github.com/users/heycam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heycam/subscriptions","organizations_url":"https://api.github.com/users/heycam/orgs","repos_url":"https://api.github.com/users/heycam/repos","events_url":"https://api.github.com/users/heycam/events{/privacy}","received_events_url":"https://api.github.com/users/heycam/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/reviewed","name":"reviewed","color":"009800"},{"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/svg","name":"svg","color":"ededed"},{"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/wg-svg","name":"wg-svg","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2015-06-06T07:32:57Z","updated_at":"2016-09-15T09:38:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/1879","html_url":"https://github.com/w3c/web-platform-tests/pull/1879","diff_url":"https://github.com/w3c/web-platform-tests/pull/1879.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/1879.patch"},"body":"Please let me know if this is the best way to handle scripted SVG tests.  It seemed easier to do everything from an HTML document."},"comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments/247282665","html_url":"https://github.com/w3c/web-platform-tests/pull/1879#issuecomment-247282665","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1879","id":247282665,"user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T09:38:57Z","updated_at":"2016-09-15T09:38:57Z","body":"```\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-01.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12203\r\n--------------------------------------------------------------------------------\r\n29|function q(selector) { return document.querySelector(selector); }\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  Not a big fan of this kind of function; it hurts readability and doesn't save\r\n  all that much.\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-01.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12204\r\n--------------------------------------------------------------------------------\r\n48|    if (typeof t[i] == \"string\") {\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  ===\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-01.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12205\r\n--------------------------------------------------------------------------------\r\n63|container.remove();\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  Is this widely supported now?\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-01.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12206\r\n--------------------------------------------------------------------------------\r\n30|var topSVG = q(\"#top-svg\");\r\n31|var innerSVG = q(\"#inner-svg\");\r\n32|var tests = [\r\n33|  // [Element or selector used to find element,\r\n34|  //  expected ownerSVGElement value,\r\n35|  //  description]\r\n36|  [topSVG, null, \"outer <svg> element\"],\r\n37|  [\"rect\", topSVG, \"non-<svg> child of outer <svg> element\"],\r\n38|  [\"title\", topSVG, \"non-<svg> descendant of outer <svg> element\"],\r\n39|  [innerSVG, topSVG, \"inner <svg> descendant of outer <svg> element\"],\r\n40|  [\"polygon\", innerSVG, \"non-<svg> descendant of inner <svg> element\"],\r\n41|  [\"#svg-in-fo\", null, \"outer <svg> in foreignObject\"],\r\n42|  [\"#inner-svg-in-fo\", \"#svg-in-fo\", \"inner <svg> child of outer <svg> in foreignObject\"],\r\n43|];\r\n44|\r\n45|// Resolve the selectors to actual elements.\r\n46|tests.forEach(function(t) {\r\n47|  for (var i = 0; i < 2; i++) {\r\n48|    if (typeof t[i] == \"string\") {\r\n49|      t[i] = q(t[i]);\r\n50|    }\r\n51|  }\r\n52|});\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  Should all go into setup()\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-01.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12207\r\n--------------------------------------------------------------------------------\r\n74|}, \"non-svg element with no parent\");\r\n75|test(function() {\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  Empty line\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-01.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12208\r\n--------------------------------------------------------------------------------\r\n4|<link rel=\"help\" href=\"http://www.w3.org/TR/SVG2/types.html#__svg__SVGElement__ownerSVGElement\">\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  Please use the ED\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-02.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12209\r\n--------------------------------------------------------------------------------\r\n4|<link rel=\"help\" href=\"http://www.w3.org/TR/SVG2/types.html#__svg__SVGElement__ownerSVGElement\">\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  ED\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-02.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12210\r\n--------------------------------------------------------------------------------\r\n9|  <iframe src=\"helper-SVGElement.ownerSVGElement-02.svg\" onload=\"run()\"></iframe>\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  run() can be called before it's defined; put the script first.\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-02.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12211\r\n--------------------------------------------------------------------------------\r\n18|  }, \"root svg element\");\r\n19|  test(function() {\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  Empty line\r\n\r\n\r\nIssue in svg/types/SVGElement.ownerSVGElement-02.html:\r\n  https://critic.hoppipolla.co.uk/showcomment?chain=12212\r\n--------------------------------------------------------------------------------\r\n11|<script>\r\n12|function run() {\r\n--------------------------------------------------------------------------------\r\nMs2ger at 2015-07-21 13:35 +02:00:\r\n  This test will silently pass if the load event isn't fired (in time).\r\n```"}}
{"actor":{"display_login":"Ms2ger"}}