{"action":"closed","number":514,"pull_request":{"url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/514","id":96595510,"html_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/514","diff_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/514.diff","patch_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/514.patch","issue_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/514","number":514,"state":"closed","locked":false,"title":"Enable unvalued element attributes.","user":{"login":"numical","id":8082596,"avatar_url":"https://avatars.githubusercontent.com/u/8082596?v=3","gravatar_id":"","url":"https://api.github.com/users/numical","html_url":"https://github.com/numical","followers_url":"https://api.github.com/users/numical/followers","following_url":"https://api.github.com/users/numical/following{/other_user}","gists_url":"https://api.github.com/users/numical/gists{/gist_id}","starred_url":"https://api.github.com/users/numical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numical/subscriptions","organizations_url":"https://api.github.com/users/numical/orgs","repos_url":"https://api.github.com/users/numical/repos","events_url":"https://api.github.com/users/numical/events{/privacy}","received_events_url":"https://api.github.com/users/numical/received_events","type":"User","site_admin":false},"body":"Minor fix to [createHtmlTag](https://github.com/ampedandwired/html-webpack-plugin/blob/master/index.js#L583) function to alow elements to have attributes with no values.\r\nThis is an enabler for add-on plugins (such as [ScriptExtHtmlWebpackPlugin](https://github.com/numical/script-ext-html-webpack-plugin/issues/3)).\r\n\r\nThe fix is trivial.  A whole additional Spec object has been created as, conditional on acceptance of this PR, another PR will be submitted with additional Add-On tests to replace [PR#510](https://github.com/ampedandwired/html-webpack-plugin/pull/510).\r\n\r\nThis PR has been tested locally against node v4,v5,v6.\r\n\r\n  ","created_at":"2016-12-05T19:42:33Z","updated_at":"2016-12-27T14:59:37Z","closed_at":"2016-12-27T14:59:37Z","merged_at":null,"merge_commit_sha":"74d70cbabe753150a2f0ca65b31ef55fe7a9fbf2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/514/commits","review_comments_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/514/comments","review_comment_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/514/comments","statuses_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/statuses/86bdc09314b88ac0638806945e89a8a09407716b","head":{"label":"numical:enable-unvalued-element-attributes","ref":"enable-unvalued-element-attributes","sha":"86bdc09314b88ac0638806945e89a8a09407716b","user":{"login":"numical","id":8082596,"avatar_url":"https://avatars.githubusercontent.com/u/8082596?v=3","gravatar_id":"","url":"https://api.github.com/users/numical","html_url":"https://github.com/numical","followers_url":"https://api.github.com/users/numical/followers","following_url":"https://api.github.com/users/numical/following{/other_user}","gists_url":"https://api.github.com/users/numical/gists{/gist_id}","starred_url":"https://api.github.com/users/numical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numical/subscriptions","organizations_url":"https://api.github.com/users/numical/orgs","repos_url":"https://api.github.com/users/numical/repos","events_url":"https://api.github.com/users/numical/events{/privacy}","received_events_url":"https://api.github.com/users/numical/received_events","type":"User","site_admin":false},"repo":{"id":75182285,"name":"html-webpack-plugin","full_name":"numical/html-webpack-plugin","owner":{"login":"numical","id":8082596,"avatar_url":"https://avatars.githubusercontent.com/u/8082596?v=3","gravatar_id":"","url":"https://api.github.com/users/numical","html_url":"https://github.com/numical","followers_url":"https://api.github.com/users/numical/followers","following_url":"https://api.github.com/users/numical/following{/other_user}","gists_url":"https://api.github.com/users/numical/gists{/gist_id}","starred_url":"https://api.github.com/users/numical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numical/subscriptions","organizations_url":"https://api.github.com/users/numical/orgs","repos_url":"https://api.github.com/users/numical/repos","events_url":"https://api.github.com/users/numical/events{/privacy}","received_events_url":"https://api.github.com/users/numical/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/numical/html-webpack-plugin","description":"Simplifies creation of HTML files to serve your webpack bundles","fork":true,"url":"https://api.github.com/repos/numical/html-webpack-plugin","forks_url":"https://api.github.com/repos/numical/html-webpack-plugin/forks","keys_url":"https://api.github.com/repos/numical/html-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numical/html-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numical/html-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/numical/html-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/numical/html-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/numical/html-webpack-plugin/events","assignees_url":"https://api.github.com/repos/numical/html-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/numical/html-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/numical/html-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/numical/html-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numical/html-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numical/html-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/numical/html-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numical/html-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/numical/html-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/numical/html-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/numical/html-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/numical/html-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/numical/html-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/numical/html-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/numical/html-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/numical/html-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/numical/html-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/numical/html-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/numical/html-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numical/html-webpack-plugin/merges","archive_url":"https://api.github.com/repos/numical/html-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numical/html-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/numical/html-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/numical/html-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/numical/html-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/numical/html-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numical/html-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/numical/html-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/numical/html-webpack-plugin/deployments","created_at":"2016-11-30T11:51:32Z","updated_at":"2016-11-30T11:51:34Z","pushed_at":"2016-12-27T14:54:08Z","git_url":"git://github.com/numical/html-webpack-plugin.git","ssh_url":"git@github.com:numical/html-webpack-plugin.git","clone_url":"https://github.com/numical/html-webpack-plugin.git","svn_url":"https://github.com/numical/html-webpack-plugin","homepage":"","size":568,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampedandwired:master","ref":"master","sha":"06b49ff363ff4e5df25c26f9cea2e2b0473e5762","user":{"login":"ampedandwired","id":541054,"avatar_url":"https://avatars.githubusercontent.com/u/541054?v=3","gravatar_id":"","url":"https://api.github.com/users/ampedandwired","html_url":"https://github.com/ampedandwired","followers_url":"https://api.github.com/users/ampedandwired/followers","following_url":"https://api.github.com/users/ampedandwired/following{/other_user}","gists_url":"https://api.github.com/users/ampedandwired/gists{/gist_id}","starred_url":"https://api.github.com/users/ampedandwired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampedandwired/subscriptions","organizations_url":"https://api.github.com/users/ampedandwired/orgs","repos_url":"https://api.github.com/users/ampedandwired/repos","events_url":"https://api.github.com/users/ampedandwired/events{/privacy}","received_events_url":"https://api.github.com/users/ampedandwired/received_events","type":"User","site_admin":false},"repo":{"id":22744595,"name":"html-webpack-plugin","full_name":"ampedandwired/html-webpack-plugin","owner":{"login":"ampedandwired","id":541054,"avatar_url":"https://avatars.githubusercontent.com/u/541054?v=3","gravatar_id":"","url":"https://api.github.com/users/ampedandwired","html_url":"https://github.com/ampedandwired","followers_url":"https://api.github.com/users/ampedandwired/followers","following_url":"https://api.github.com/users/ampedandwired/following{/other_user}","gists_url":"https://api.github.com/users/ampedandwired/gists{/gist_id}","starred_url":"https://api.github.com/users/ampedandwired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampedandwired/subscriptions","organizations_url":"https://api.github.com/users/ampedandwired/orgs","repos_url":"https://api.github.com/users/ampedandwired/repos","events_url":"https://api.github.com/users/ampedandwired/events{/privacy}","received_events_url":"https://api.github.com/users/ampedandwired/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ampedandwired/html-webpack-plugin","description":"Simplifies creation of HTML files to serve your webpack bundles","fork":false,"url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin","forks_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/forks","keys_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/events","assignees_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/merges","archive_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/deployments","created_at":"2014-08-08T03:19:15Z","updated_at":"2016-12-27T13:42:32Z","pushed_at":"2016-12-27T14:58:21Z","git_url":"git://github.com/ampedandwired/html-webpack-plugin.git","ssh_url":"git@github.com:ampedandwired/html-webpack-plugin.git","clone_url":"https://github.com/ampedandwired/html-webpack-plugin.git","svn_url":"https://github.com/ampedandwired/html-webpack-plugin","homepage":"","size":562,"stargazers_count":2319,"watchers_count":2319,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":19,"forks":243,"open_issues":19,"watchers":2319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/514"},"html":{"href":"https://github.com/ampedandwired/html-webpack-plugin/pull/514"},"issue":{"href":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/514"},"comments":{"href":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/514/comments"},"review_comments":{"href":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/514/comments"},"review_comment":{"href":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/514/commits"},"statuses":{"href":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/statuses/86bdc09314b88ac0638806945e89a8a09407716b"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":125,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"numical"}}