{"action":"created","comment":{"url":"https://api.github.com/repos/librenms/librenms/pulls/comments/83509536","pull_request_review_id":4352359,"id":83509536,"diff_hunk":"@@ -1,37 +0,0 @@\n-<?php","path":"includes/discovery/vlans/vlan_functions.inc.php","position":null,"original_position":1,"commit_id":"03bd4be86af9b76c8c6181ac6ef3ac11d5f09b87","original_commit_id":"75956d06bb6f092b77de35c0e2611d941b47d78c","user":{"login":"jonathon-k","id":21371455,"avatar_url":"https://avatars.githubusercontent.com/u/21371455?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathon-k","html_url":"https://github.com/jonathon-k","followers_url":"https://api.github.com/users/jonathon-k/followers","following_url":"https://api.github.com/users/jonathon-k/following{/other_user}","gists_url":"https://api.github.com/users/jonathon-k/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathon-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathon-k/subscriptions","organizations_url":"https://api.github.com/users/jonathon-k/orgs","repos_url":"https://api.github.com/users/jonathon-k/repos","events_url":"https://api.github.com/users/jonathon-k/events{/privacy}","received_events_url":"https://api.github.com/users/jonathon-k/received_events","type":"User","site_admin":false},"body":"@murrant I'm not sure of a good way to fix this... moving these functions into includes/functions.php breaks the unit tests when run locally (not sure why Travis isn't failing them)  But including the functions file in the unit test breaks the snmpsim stuff because of redefined functions... thoughts?","created_at":"2016-10-14T22:05:16Z","updated_at":"2016-10-14T22:05:16Z","html_url":"https://github.com/librenms/librenms/pull/4650#discussion_r83509536","pull_request_url":"https://api.github.com/repos/librenms/librenms/pulls/4650","_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments/83509536"},"html":{"href":"https://github.com/librenms/librenms/pull/4650#discussion_r83509536"},"pull_request":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4650"}}},"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/4650","id":87032498,"html_url":"https://github.com/librenms/librenms/pull/4650","diff_url":"https://github.com/librenms/librenms/pull/4650.diff","patch_url":"https://github.com/librenms/librenms/pull/4650.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/4650","number":4650,"state":"closed","locked":false,"title":"Add q-bridge-mib tagged VLAN membership","user":{"login":"ekoyle","id":1048398,"avatar_url":"https://avatars.githubusercontent.com/u/1048398?v=3","gravatar_id":"","url":"https://api.github.com/users/ekoyle","html_url":"https://github.com/ekoyle","followers_url":"https://api.github.com/users/ekoyle/followers","following_url":"https://api.github.com/users/ekoyle/following{/other_user}","gists_url":"https://api.github.com/users/ekoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ekoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekoyle/subscriptions","organizations_url":"https://api.github.com/users/ekoyle/orgs","repos_url":"https://api.github.com/users/ekoyle/repos","events_url":"https://api.github.com/users/ekoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ekoyle/received_events","type":"User","site_admin":false},"body":"#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you signed the [Contributors agreement](http://docs.librenms.org/General/Contributing/)\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n- [ ] Possibly add untagged VLANs from Q-BRIDGE-MIB as well\r\n\r\nAdd tagged vlans discovered via Q-BRIDGE-MIB to ports_vlans table (technically, it is adding the 'not untagged' ports).  This gives tagged VLAN info on most non-cisco devices.\r\n \r\nfixes: #3285","created_at":"2016-09-27T23:46:03Z","updated_at":"2016-10-14T22:05:16Z","closed_at":"2016-10-11T21:29:06Z","merged_at":"2016-10-11T21:29:06Z","merge_commit_sha":"7ca80410d56d519d1353aae107bee715962ba46f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/4650/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/4650/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/4650/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/03bd4be86af9b76c8c6181ac6ef3ac11d5f09b87","head":{"label":"ekoyle:feature-add-qbridge-vlan-membership","ref":"feature-add-qbridge-vlan-membership","sha":"03bd4be86af9b76c8c6181ac6ef3ac11d5f09b87","user":{"login":"ekoyle","id":1048398,"avatar_url":"https://avatars.githubusercontent.com/u/1048398?v=3","gravatar_id":"","url":"https://api.github.com/users/ekoyle","html_url":"https://github.com/ekoyle","followers_url":"https://api.github.com/users/ekoyle/followers","following_url":"https://api.github.com/users/ekoyle/following{/other_user}","gists_url":"https://api.github.com/users/ekoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ekoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekoyle/subscriptions","organizations_url":"https://api.github.com/users/ekoyle/orgs","repos_url":"https://api.github.com/users/ekoyle/repos","events_url":"https://api.github.com/users/ekoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ekoyle/received_events","type":"User","site_admin":false},"repo":{"id":46449482,"name":"librenms","full_name":"ekoyle/librenms","owner":{"login":"ekoyle","id":1048398,"avatar_url":"https://avatars.githubusercontent.com/u/1048398?v=3","gravatar_id":"","url":"https://api.github.com/users/ekoyle","html_url":"https://github.com/ekoyle","followers_url":"https://api.github.com/users/ekoyle/followers","following_url":"https://api.github.com/users/ekoyle/following{/other_user}","gists_url":"https://api.github.com/users/ekoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ekoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekoyle/subscriptions","organizations_url":"https://api.github.com/users/ekoyle/orgs","repos_url":"https://api.github.com/users/ekoyle/repos","events_url":"https://api.github.com/users/ekoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ekoyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekoyle/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/ekoyle/librenms","forks_url":"https://api.github.com/repos/ekoyle/librenms/forks","keys_url":"https://api.github.com/repos/ekoyle/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekoyle/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekoyle/librenms/teams","hooks_url":"https://api.github.com/repos/ekoyle/librenms/hooks","issue_events_url":"https://api.github.com/repos/ekoyle/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/ekoyle/librenms/events","assignees_url":"https://api.github.com/repos/ekoyle/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/ekoyle/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/ekoyle/librenms/tags","blobs_url":"https://api.github.com/repos/ekoyle/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekoyle/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekoyle/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekoyle/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekoyle/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/ekoyle/librenms/languages","stargazers_url":"https://api.github.com/repos/ekoyle/librenms/stargazers","contributors_url":"https://api.github.com/repos/ekoyle/librenms/contributors","subscribers_url":"https://api.github.com/repos/ekoyle/librenms/subscribers","subscription_url":"https://api.github.com/repos/ekoyle/librenms/subscription","commits_url":"https://api.github.com/repos/ekoyle/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekoyle/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekoyle/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekoyle/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekoyle/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/ekoyle/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekoyle/librenms/merges","archive_url":"https://api.github.com/repos/ekoyle/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekoyle/librenms/downloads","issues_url":"https://api.github.com/repos/ekoyle/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/ekoyle/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/ekoyle/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/ekoyle/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekoyle/librenms/labels{/name}","releases_url":"https://api.github.com/repos/ekoyle/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/ekoyle/librenms/deployments","created_at":"2015-11-18T21:45:18Z","updated_at":"2016-01-21T17:09:33Z","pushed_at":"2016-10-10T15:03:05Z","git_url":"git://github.com/ekoyle/librenms.git","ssh_url":"git@github.com:ekoyle/librenms.git","clone_url":"https://github.com/ekoyle/librenms.git","svn_url":"https://github.com/ekoyle/librenms","homepage":"http://www.librenms.org/","size":75153,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"c0d7ad44b046c85532d7ce610d3e981875e0ce98","user":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"name":"librenms","full_name":"librenms/librenms","owner":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/librenms/librenms/deployments","created_at":"2013-10-28T01:37:13Z","updated_at":"2016-10-14T17:20:37Z","pushed_at":"2016-10-14T21:40:48Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":105211,"stargazers_count":513,"watchers_count":513,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":358,"mirror_url":null,"open_issues_count":311,"forks":358,"open_issues":311,"watchers":513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4650"},"html":{"href":"https://github.com/librenms/librenms/pull/4650"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/4650"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/4650/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4650/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4650/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/03bd4be86af9b76c8c6181ac6ef3ac11d5f09b87"}}}}
{"actor":{"display_login":"jonathon-k"}}