{"action":"created","comment":{"url":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments/61014022","id":61014022,"diff_hunk":"@@ -37,6 +37,7 @@\n     public static final String EMAIL                  = \"email\";\n     public static final String ROLE                   = \"role\";\n     public static final String REALM                  = \"realm\";\n+    public static final String SETTING                = \"setting\";","path":"src/main/java/com/kryptnostic/directory/v1/http/UserDirectoryApi.java","position":4,"original_position":4,"commit_id":"51305830df708acfefb164992856d7ba4ef61d48","original_commit_id":"51305830df708acfefb164992856d7ba4ef61d48","user":{"login":"makosblade","id":336506,"avatar_url":"https://avatars.githubusercontent.com/u/336506?v=3","gravatar_id":"","url":"https://api.github.com/users/makosblade","html_url":"https://github.com/makosblade","followers_url":"https://api.github.com/users/makosblade/followers","following_url":"https://api.github.com/users/makosblade/following{/other_user}","gists_url":"https://api.github.com/users/makosblade/gists{/gist_id}","starred_url":"https://api.github.com/users/makosblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makosblade/subscriptions","organizations_url":"https://api.github.com/users/makosblade/orgs","repos_url":"https://api.github.com/users/makosblade/repos","events_url":"https://api.github.com/users/makosblade/events{/privacy}","received_events_url":"https://api.github.com/users/makosblade/received_events","type":"User","site_admin":false},"body":"It's clear in this class but any calling class has to look at this file to understand that it's not a path variable. It's much more clear to just name it explicitly. No need to update everything since that involves a lot of changes, just SETTINGS => SETTINGS_VAR","created_at":"2016-04-26T00:40:37Z","updated_at":"2016-04-26T00:40:37Z","html_url":"https://github.com/kryptnostic/kodex/pull/203#discussion_r61014022","pull_request_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments/61014022"},"html":{"href":"https://github.com/kryptnostic/kodex/pull/203#discussion_r61014022"},"pull_request":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/kryptnostic/kodex/pulls/203","id":67808470,"html_url":"https://github.com/kryptnostic/kodex/pull/203","diff_url":"https://github.com/kryptnostic/kodex/pull/203.diff","patch_url":"https://github.com/kryptnostic/kodex/pull/203.patch","issue_url":"https://api.github.com/repos/kryptnostic/kodex/issues/203","number":203,"state":"open","locked":false,"title":"user settings feature","user":{"login":"Bloodyhacker","id":6694817,"avatar_url":"https://avatars.githubusercontent.com/u/6694817?v=3","gravatar_id":"","url":"https://api.github.com/users/Bloodyhacker","html_url":"https://github.com/Bloodyhacker","followers_url":"https://api.github.com/users/Bloodyhacker/followers","following_url":"https://api.github.com/users/Bloodyhacker/following{/other_user}","gists_url":"https://api.github.com/users/Bloodyhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/Bloodyhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bloodyhacker/subscriptions","organizations_url":"https://api.github.com/users/Bloodyhacker/orgs","repos_url":"https://api.github.com/users/Bloodyhacker/repos","events_url":"https://api.github.com/users/Bloodyhacker/events{/privacy}","received_events_url":"https://api.github.com/users/Bloodyhacker/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-26T00:09:09Z","updated_at":"2016-04-26T00:40:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24e8244ba18bc5f9c85b086b8b6e0b9a167e1667","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/203/commits","review_comments_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/203/comments","review_comment_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kryptnostic/kodex/issues/203/comments","statuses_url":"https://api.github.com/repos/kryptnostic/kodex/statuses/51305830df708acfefb164992856d7ba4ef61d48","head":{"label":"kryptnostic:feature/BACKEND-419-silence-channel","ref":"feature/BACKEND-419-silence-channel","sha":"51305830df708acfefb164992856d7ba4ef61d48","user":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"repo":{"id":23140778,"name":"kodex","full_name":"kryptnostic/kodex","owner":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kryptnostic/kodex","description":"API and Models for talking with Kryptnostic backend services","fork":false,"url":"https://api.github.com/repos/kryptnostic/kodex","forks_url":"https://api.github.com/repos/kryptnostic/kodex/forks","keys_url":"https://api.github.com/repos/kryptnostic/kodex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kryptnostic/kodex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kryptnostic/kodex/teams","hooks_url":"https://api.github.com/repos/kryptnostic/kodex/hooks","issue_events_url":"https://api.github.com/repos/kryptnostic/kodex/issues/events{/number}","events_url":"https://api.github.com/repos/kryptnostic/kodex/events","assignees_url":"https://api.github.com/repos/kryptnostic/kodex/assignees{/user}","branches_url":"https://api.github.com/repos/kryptnostic/kodex/branches{/branch}","tags_url":"https://api.github.com/repos/kryptnostic/kodex/tags","blobs_url":"https://api.github.com/repos/kryptnostic/kodex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kryptnostic/kodex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kryptnostic/kodex/git/refs{/sha}","trees_url":"https://api.github.com/repos/kryptnostic/kodex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kryptnostic/kodex/statuses/{sha}","languages_url":"https://api.github.com/repos/kryptnostic/kodex/languages","stargazers_url":"https://api.github.com/repos/kryptnostic/kodex/stargazers","contributors_url":"https://api.github.com/repos/kryptnostic/kodex/contributors","subscribers_url":"https://api.github.com/repos/kryptnostic/kodex/subscribers","subscription_url":"https://api.github.com/repos/kryptnostic/kodex/subscription","commits_url":"https://api.github.com/repos/kryptnostic/kodex/commits{/sha}","git_commits_url":"https://api.github.com/repos/kryptnostic/kodex/git/commits{/sha}","comments_url":"https://api.github.com/repos/kryptnostic/kodex/comments{/number}","issue_comment_url":"https://api.github.com/repos/kryptnostic/kodex/issues/comments{/number}","contents_url":"https://api.github.com/repos/kryptnostic/kodex/contents/{+path}","compare_url":"https://api.github.com/repos/kryptnostic/kodex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kryptnostic/kodex/merges","archive_url":"https://api.github.com/repos/kryptnostic/kodex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kryptnostic/kodex/downloads","issues_url":"https://api.github.com/repos/kryptnostic/kodex/issues{/number}","pulls_url":"https://api.github.com/repos/kryptnostic/kodex/pulls{/number}","milestones_url":"https://api.github.com/repos/kryptnostic/kodex/milestones{/number}","notifications_url":"https://api.github.com/repos/kryptnostic/kodex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kryptnostic/kodex/labels{/name}","releases_url":"https://api.github.com/repos/kryptnostic/kodex/releases{/id}","deployments_url":"https://api.github.com/repos/kryptnostic/kodex/deployments","created_at":"2014-08-20T08:01:31Z","updated_at":"2016-01-12T21:36:15Z","pushed_at":"2016-04-26T00:09:09Z","git_url":"git://github.com/kryptnostic/kodex.git","ssh_url":"git@github.com:kryptnostic/kodex.git","clone_url":"https://github.com/kryptnostic/kodex.git","svn_url":"https://github.com/kryptnostic/kodex","homepage":null,"size":1339,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"develop"}},"base":{"label":"kryptnostic:develop","ref":"develop","sha":"c4172d5eac24d7a881059f2e6184d6af679ddd85","user":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"repo":{"id":23140778,"name":"kodex","full_name":"kryptnostic/kodex","owner":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kryptnostic/kodex","description":"API and Models for talking with Kryptnostic backend services","fork":false,"url":"https://api.github.com/repos/kryptnostic/kodex","forks_url":"https://api.github.com/repos/kryptnostic/kodex/forks","keys_url":"https://api.github.com/repos/kryptnostic/kodex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kryptnostic/kodex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kryptnostic/kodex/teams","hooks_url":"https://api.github.com/repos/kryptnostic/kodex/hooks","issue_events_url":"https://api.github.com/repos/kryptnostic/kodex/issues/events{/number}","events_url":"https://api.github.com/repos/kryptnostic/kodex/events","assignees_url":"https://api.github.com/repos/kryptnostic/kodex/assignees{/user}","branches_url":"https://api.github.com/repos/kryptnostic/kodex/branches{/branch}","tags_url":"https://api.github.com/repos/kryptnostic/kodex/tags","blobs_url":"https://api.github.com/repos/kryptnostic/kodex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kryptnostic/kodex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kryptnostic/kodex/git/refs{/sha}","trees_url":"https://api.github.com/repos/kryptnostic/kodex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kryptnostic/kodex/statuses/{sha}","languages_url":"https://api.github.com/repos/kryptnostic/kodex/languages","stargazers_url":"https://api.github.com/repos/kryptnostic/kodex/stargazers","contributors_url":"https://api.github.com/repos/kryptnostic/kodex/contributors","subscribers_url":"https://api.github.com/repos/kryptnostic/kodex/subscribers","subscription_url":"https://api.github.com/repos/kryptnostic/kodex/subscription","commits_url":"https://api.github.com/repos/kryptnostic/kodex/commits{/sha}","git_commits_url":"https://api.github.com/repos/kryptnostic/kodex/git/commits{/sha}","comments_url":"https://api.github.com/repos/kryptnostic/kodex/comments{/number}","issue_comment_url":"https://api.github.com/repos/kryptnostic/kodex/issues/comments{/number}","contents_url":"https://api.github.com/repos/kryptnostic/kodex/contents/{+path}","compare_url":"https://api.github.com/repos/kryptnostic/kodex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kryptnostic/kodex/merges","archive_url":"https://api.github.com/repos/kryptnostic/kodex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kryptnostic/kodex/downloads","issues_url":"https://api.github.com/repos/kryptnostic/kodex/issues{/number}","pulls_url":"https://api.github.com/repos/kryptnostic/kodex/pulls{/number}","milestones_url":"https://api.github.com/repos/kryptnostic/kodex/milestones{/number}","notifications_url":"https://api.github.com/repos/kryptnostic/kodex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kryptnostic/kodex/labels{/name}","releases_url":"https://api.github.com/repos/kryptnostic/kodex/releases{/id}","deployments_url":"https://api.github.com/repos/kryptnostic/kodex/deployments","created_at":"2014-08-20T08:01:31Z","updated_at":"2016-01-12T21:36:15Z","pushed_at":"2016-04-26T00:09:09Z","git_url":"git://github.com/kryptnostic/kodex.git","ssh_url":"git@github.com:kryptnostic/kodex.git","clone_url":"https://github.com/kryptnostic/kodex.git","svn_url":"https://github.com/kryptnostic/kodex","homepage":null,"size":1339,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/203"},"html":{"href":"https://github.com/kryptnostic/kodex/pull/203"},"issue":{"href":"https://api.github.com/repos/kryptnostic/kodex/issues/203"},"comments":{"href":"https://api.github.com/repos/kryptnostic/kodex/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/kryptnostic/kodex/statuses/51305830df708acfefb164992856d7ba4ef61d48"}}}}