{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/36","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/36/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/36/events","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/36","id":173988264,"number":36,"title":"Fix collection of public ip addresses","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-30T10:52:17Z","updated_at":"2016-08-30T11:42:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/pulls/36","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/36","diff_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/36.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/36.patch"},"body":"The collection of the public IP addresses were broken and we were not collecting private addresses for the old ec2 instances.\r\n\r\nFixes Issue:\r\nhttps://github.com/ManageIQ/manageiq/issues/10586\r\n\r\nFixes BZ:\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1371204"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/comments/243412932","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/36#issuecomment-243412932","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/36","id":243412932,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T11:42:01Z","updated_at":"2016-08-30T11:42:01Z","body":"<rubocop />Checked commits https://github.com/Ladas/manageiq-providers-amazon/compare/33b37f4974084491c8a3dbce490310da7f2b5db9~...2d158e01455dc1d21ba22d194ebd08bc04eae2d4 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n3 files checked, 8 offenses detected\n\n**app/models/manageiq/providers/amazon/network_manager/refresh_parser.rb**\n- [ ] :exclamation: - [Line 137](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/app/models/manageiq/providers/amazon/network_manager/refresh_parser.rb#L137), Col 7 - [Style/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AccessorMethodName) - Do not prefix reader method names with `get_`.\n- [ ] :exclamation: - [Line 141](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/app/models/manageiq/providers/amazon/network_manager/refresh_parser.rb#L141), Col 9 - [Style/Next](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/Next) - Use `next` to skip iteration.\n- [ ] :exclamation: - [Line 159](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/app/models/manageiq/providers/amazon/network_manager/refresh_parser.rb#L159), Col 7 - [Style/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AccessorMethodName) - Do not prefix reader method names with `get_`.\n\n**spec/models/manageiq/providers/amazon/cloud_manager/refresher_spec.rb**\n- [ ] :exclamation: - [Line 567](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/spec/models/manageiq/providers/amazon/cloud_manager/refresher_spec.rb#L567), Col 20 - [Style/FirstParameterIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/FirstParameterIndentation) - Indent the first parameter one step more than the start of the previous line.\n- [ ] :exclamation: - [Line 589](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/spec/models/manageiq/providers/amazon/cloud_manager/refresher_spec.rb#L589), Col 18 - [Style/ClosingParenthesisIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/ClosingParenthesisIndentation) - Indent `)` the same as the start of the line where `(` is.\n- [ ] :grey_exclamation: - [Line 564](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/spec/models/manageiq/providers/amazon/cloud_manager/refresher_spec.rb#L564), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for assert_specific_vm_on_cloud_network_1 is too high. [68.01/20]\n- [ ] :grey_exclamation: - [Line 564](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/spec/models/manageiq/providers/amazon/cloud_manager/refresher_spec.rb#L564), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [36/25]\n- [ ] :grey_exclamation: - [Line 5](https://github.com/Ladas/manageiq-providers-amazon/blob/2d158e01455dc1d21ba22d194ebd08bc04eae2d4/spec/models/manageiq/providers/amazon/cloud_manager/refresher_spec.rb#L5), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [137/120]\n"}}
{"actor":{"display_login":"miq-bot"}}