{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/73693625","id":73693625,"diff_hunk":"@@ -425,7 +426,7 @@ def _get_direct_beam(self, meta_data_run, data_set):\n         direct_beam_runs_str = self._read_property(meta_data_run, \"direct_beam_runs\",\n                                                    _direct_beam_runs, is_string=True)\n         # The direct runs in the DAS logs are stored as a string\n-        if isinstance(direct_beam_runs_str, (str, unicode)):\n+        if isinstance(direct_beam_runs_str, str):","path":"Framework/PythonInterface/plugins/algorithms/LRAutoReduction.py","position":13,"original_position":13,"commit_id":"8e459102349cb1f4d5ccf5271a07c42bcf8244d0","original_commit_id":"8e459102349cb1f4d5ccf5271a07c42bcf8244d0","user":{"login":"rosswhitfield","id":5595210,"avatar_url":"https://avatars.githubusercontent.com/u/5595210?v=3","gravatar_id":"","url":"https://api.github.com/users/rosswhitfield","html_url":"https://github.com/rosswhitfield","followers_url":"https://api.github.com/users/rosswhitfield/followers","following_url":"https://api.github.com/users/rosswhitfield/following{/other_user}","gists_url":"https://api.github.com/users/rosswhitfield/gists{/gist_id}","starred_url":"https://api.github.com/users/rosswhitfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosswhitfield/subscriptions","organizations_url":"https://api.github.com/users/rosswhitfield/orgs","repos_url":"https://api.github.com/users/rosswhitfield/repos","events_url":"https://api.github.com/users/rosswhitfield/events{/privacy}","received_events_url":"https://api.github.com/users/rosswhitfield/received_events","type":"User","site_admin":false},"body":"No it doesn't. `isinstance(u\"foobar\",(str,unicode)) = True` while `isinstance(u\"foobar\",str) = False`. But `unicode` isn't a type in python 3 so something else is needed here.\r\n\r\nHow about `isinstance(u\"foobar\",(str,type(u'')))`? It works for python 2 and 3. Unless there is a better way?","created_at":"2016-08-05T13:42:37Z","updated_at":"2016-08-05T13:42:37Z","html_url":"https://github.com/mantidproject/mantid/pull/16953#discussion_r73693625","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/16953","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/73693625"},"html":{"href":"https://github.com/mantidproject/mantid/pull/16953#discussion_r73693625"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16953"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16953","id":78221974,"html_url":"https://github.com/mantidproject/mantid/pull/16953","diff_url":"https://github.com/mantidproject/mantid/pull/16953.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16953.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16953","number":16953,"state":"open","locked":false,"title":"Update algorithms for Python3 - Group 4","user":{"login":"rosswhitfield","id":5595210,"avatar_url":"https://avatars.githubusercontent.com/u/5595210?v=3","gravatar_id":"","url":"https://api.github.com/users/rosswhitfield","html_url":"https://github.com/rosswhitfield","followers_url":"https://api.github.com/users/rosswhitfield/followers","following_url":"https://api.github.com/users/rosswhitfield/following{/other_user}","gists_url":"https://api.github.com/users/rosswhitfield/gists{/gist_id}","starred_url":"https://api.github.com/users/rosswhitfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosswhitfield/subscriptions","organizations_url":"https://api.github.com/users/rosswhitfield/orgs","repos_url":"https://api.github.com/users/rosswhitfield/repos","events_url":"https://api.github.com/users/rosswhitfield/events{/privacy}","received_events_url":"https://api.github.com/users/rosswhitfield/received_events","type":"User","site_admin":false},"body":"This is Group 4 of #16739 \r\n\r\n**To test:**\r\n* Code review\r\n* Make sure the unittests still pass with python2.\r\n* Test that the related unittests pass when using python3.\r\n\r\n\r\nDoes not need to be in the release notes.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [x] How do the changes handle unexpected situations, e.g. bad input?\r\n- [x] Has the relevant documentation been added/updated?\r\n- [x] Is user-facing documentation written in a user-friendly manner?\r\n- [x] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2016-07-20T21:23:53Z","updated_at":"2016-08-05T13:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91f2ab8e48bb68a920aa5d0ca6a48a8710734cb9","assignee":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"assignees":[{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":701,"closed_issues":523,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-08-05T12:10:36Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/16953/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/16953/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16953/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/8e459102349cb1f4d5ccf5271a07c42bcf8244d0","head":{"label":"rosswhitfield:py3_group4","ref":"py3_group4","sha":"8e459102349cb1f4d5ccf5271a07c42bcf8244d0","user":{"login":"rosswhitfield","id":5595210,"avatar_url":"https://avatars.githubusercontent.com/u/5595210?v=3","gravatar_id":"","url":"https://api.github.com/users/rosswhitfield","html_url":"https://github.com/rosswhitfield","followers_url":"https://api.github.com/users/rosswhitfield/followers","following_url":"https://api.github.com/users/rosswhitfield/following{/other_user}","gists_url":"https://api.github.com/users/rosswhitfield/gists{/gist_id}","starred_url":"https://api.github.com/users/rosswhitfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosswhitfield/subscriptions","organizations_url":"https://api.github.com/users/rosswhitfield/orgs","repos_url":"https://api.github.com/users/rosswhitfield/repos","events_url":"https://api.github.com/users/rosswhitfield/events{/privacy}","received_events_url":"https://api.github.com/users/rosswhitfield/received_events","type":"User","site_admin":false},"repo":{"id":38780546,"name":"mantid","full_name":"rosswhitfield/mantid","owner":{"login":"rosswhitfield","id":5595210,"avatar_url":"https://avatars.githubusercontent.com/u/5595210?v=3","gravatar_id":"","url":"https://api.github.com/users/rosswhitfield","html_url":"https://github.com/rosswhitfield","followers_url":"https://api.github.com/users/rosswhitfield/followers","following_url":"https://api.github.com/users/rosswhitfield/following{/other_user}","gists_url":"https://api.github.com/users/rosswhitfield/gists{/gist_id}","starred_url":"https://api.github.com/users/rosswhitfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosswhitfield/subscriptions","organizations_url":"https://api.github.com/users/rosswhitfield/orgs","repos_url":"https://api.github.com/users/rosswhitfield/repos","events_url":"https://api.github.com/users/rosswhitfield/events{/privacy}","received_events_url":"https://api.github.com/users/rosswhitfield/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rosswhitfield/mantid","description":"Main repository for Mantid code","fork":true,"url":"https://api.github.com/repos/rosswhitfield/mantid","forks_url":"https://api.github.com/repos/rosswhitfield/mantid/forks","keys_url":"https://api.github.com/repos/rosswhitfield/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rosswhitfield/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rosswhitfield/mantid/teams","hooks_url":"https://api.github.com/repos/rosswhitfield/mantid/hooks","issue_events_url":"https://api.github.com/repos/rosswhitfield/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/rosswhitfield/mantid/events","assignees_url":"https://api.github.com/repos/rosswhitfield/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/rosswhitfield/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/rosswhitfield/mantid/tags","blobs_url":"https://api.github.com/repos/rosswhitfield/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rosswhitfield/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rosswhitfield/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/rosswhitfield/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rosswhitfield/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/rosswhitfield/mantid/languages","stargazers_url":"https://api.github.com/repos/rosswhitfield/mantid/stargazers","contributors_url":"https://api.github.com/repos/rosswhitfield/mantid/contributors","subscribers_url":"https://api.github.com/repos/rosswhitfield/mantid/subscribers","subscription_url":"https://api.github.com/repos/rosswhitfield/mantid/subscription","commits_url":"https://api.github.com/repos/rosswhitfield/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/rosswhitfield/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/rosswhitfield/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/rosswhitfield/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/rosswhitfield/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/rosswhitfield/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rosswhitfield/mantid/merges","archive_url":"https://api.github.com/repos/rosswhitfield/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rosswhitfield/mantid/downloads","issues_url":"https://api.github.com/repos/rosswhitfield/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/rosswhitfield/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/rosswhitfield/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/rosswhitfield/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rosswhitfield/mantid/labels{/name}","releases_url":"https://api.github.com/repos/rosswhitfield/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/rosswhitfield/mantid/deployments","created_at":"2015-07-08T21:18:50Z","updated_at":"2016-01-11T15:40:38Z","pushed_at":"2016-08-05T13:37:30Z","git_url":"git://github.com/rosswhitfield/mantid.git","ssh_url":"git@github.com:rosswhitfield/mantid.git","clone_url":"https://github.com/rosswhitfield/mantid.git","svn_url":"https://github.com/rosswhitfield/mantid","homepage":"www.mantidproject.org","size":377651,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"a130171afdcd8a4474ff733b72af6fbe930d509d","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-07-15T19:42:24Z","pushed_at":"2016-08-05T12:51:26Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":431658,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":1629,"forks":35,"open_issues":1629,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16953"},"html":{"href":"https://github.com/mantidproject/mantid/pull/16953"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/16953"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/16953/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16953/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/16953/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/8e459102349cb1f4d5ccf5271a07c42bcf8244d0"}}}}
{"actor":{"display_login":"rosswhitfield"}}