{"action":"closed","number":185,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/185","id":92052478,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/185","diff_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/185.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/185.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/185","number":185,"state":"closed","locked":false,"title":"(MODULES-4030) Always prepare package","user":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"body":"Prior to this commit we attempted to \"save\" the master from having to\r\nperform checksum logic on the puppet-agent tarball by only attempting\r\nto checksum if the master_agent_version != aio_agent version. Which\r\nwould be true if\r\nA) The agent was pre-aio (< 3.8)\r\nB) The agent needed to be upgraded\r\nbut not true if the agent was already up to date previous to the\r\npuppet_agent module being installed. If it was already up to date,\r\nthis prepare step would not occur, and the module would later attempt\r\nto install using a tarball that had not been copied over.\r\n\r\nThis commit removes the master_agent_version != aio_agent version\r\ncheck and replaces it with just checking for `is_pe`, since we\r\ndepend on the `pe_build_version` function. It also specifies\r\nthe `sha256lite` checksum method should be used. This seems like a\r\ndecent compromise to both save the puppetserver work as well as\r\nmake reasoning about this module easier (if the prepare class is\r\nincluded, then the agent will be prepared on disk.)","created_at":"2016-11-02T20:49:29Z","updated_at":"2016-11-03T00:15:31Z","closed_at":"2016-11-03T00:15:31Z","merged_at":"2016-11-03T00:15:31Z","merge_commit_sha":"723698f2b2167499ee846e8cb2cc310626765f30","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/185/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/185/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/185/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/a6c9f44b2f86efae67c4a3e8ec395ec1357cb766","head":{"label":"highb:always_prepare_package","ref":"always_prepare_package","sha":"a6c9f44b2f86efae67c4a3e8ec395ec1357cb766","user":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"repo":{"id":42746934,"name":"puppetlabs-puppet_agent","full_name":"highb/puppetlabs-puppet_agent","owner":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/highb/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":true,"url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/releases{/id}","deployments_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/deployments","created_at":"2015-09-18T21:03:46Z","updated_at":"2015-09-18T21:03:47Z","pushed_at":"2016-11-02T23:30:54Z","git_url":"git://github.com/highb/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:highb/puppetlabs-puppet_agent.git","clone_url":"https://github.com/highb/puppetlabs-puppet_agent.git","svn_url":"https://github.com/highb/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/PUP","size":477,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"549706aae16bb854bbedafffc29887427ece5037","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":35058943,"name":"puppetlabs-puppet_agent","full_name":"puppetlabs/puppetlabs-puppet_agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/deployments","created_at":"2015-05-04T20:50:16Z","updated_at":"2016-10-27T01:54:30Z","pushed_at":"2016-11-03T00:15:31Z","git_url":"git://github.com/puppetlabs/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-puppet_agent.git","clone_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent.git","svn_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/MODULES","size":692,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":12,"forks":59,"open_issues":12,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/185"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/185"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/185"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/a6c9f44b2f86efae67c4a3e8ec395ec1357cb766"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":2,"additions":11,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"MikaelSmith"}}