{"action":"created","issue":{"url":"https://api.github.com/repos/plotly/plotly.py/issues/399","repository_url":"https://api.github.com/repos/plotly/plotly.py","labels_url":"https://api.github.com/repos/plotly/plotly.py/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/plotly/plotly.py/issues/399/comments","events_url":"https://api.github.com/repos/plotly/plotly.py/issues/399/events","html_url":"https://github.com/plotly/plotly.py/issues/399","id":132977214,"number":399,"title":"Config options for offline plots","user":{"login":"icaromedeiros","id":275728,"avatar_url":"https://avatars.githubusercontent.com/u/275728?v=3","gravatar_id":"","url":"https://api.github.com/users/icaromedeiros","html_url":"https://github.com/icaromedeiros","followers_url":"https://api.github.com/users/icaromedeiros/followers","following_url":"https://api.github.com/users/icaromedeiros/following{/other_user}","gists_url":"https://api.github.com/users/icaromedeiros/gists{/gist_id}","starred_url":"https://api.github.com/users/icaromedeiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icaromedeiros/subscriptions","organizations_url":"https://api.github.com/users/icaromedeiros/orgs","repos_url":"https://api.github.com/users/icaromedeiros/repos","events_url":"https://api.github.com/users/icaromedeiros/events{/privacy}","received_events_url":"https://api.github.com/users/icaromedeiros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"yankev","id":12302455,"avatar_url":"https://avatars.githubusercontent.com/u/12302455?v=3","gravatar_id":"","url":"https://api.github.com/users/yankev","html_url":"https://github.com/yankev","followers_url":"https://api.github.com/users/yankev/followers","following_url":"https://api.github.com/users/yankev/following{/other_user}","gists_url":"https://api.github.com/users/yankev/gists{/gist_id}","starred_url":"https://api.github.com/users/yankev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yankev/subscriptions","organizations_url":"https://api.github.com/users/yankev/orgs","repos_url":"https://api.github.com/users/yankev/repos","events_url":"https://api.github.com/users/yankev/events{/privacy}","received_events_url":"https://api.github.com/users/yankev/received_events","type":"User","site_admin":false},"assignees":[{"login":"yankev","id":12302455,"avatar_url":"https://avatars.githubusercontent.com/u/12302455?v=3","gravatar_id":"","url":"https://api.github.com/users/yankev","html_url":"https://github.com/yankev","followers_url":"https://api.github.com/users/yankev/followers","following_url":"https://api.github.com/users/yankev/following{/other_user}","gists_url":"https://api.github.com/users/yankev/gists{/gist_id}","starred_url":"https://api.github.com/users/yankev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yankev/subscriptions","organizations_url":"https://api.github.com/users/yankev/orgs","repos_url":"https://api.github.com/users/yankev/repos","events_url":"https://api.github.com/users/yankev/events{/privacy}","received_events_url":"https://api.github.com/users/yankev/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-02-11T13:41:30Z","updated_at":"2016-11-03T14:11:47Z","closed_at":null,"body":"There is no way to set the 4th parameter in plotly.js when using offline plots as it is hardcoded in `_plot_html` (https://github.com/plotly/plotly.py/blob/master/plotly/offline/offline.py#L100)\n\n``` python\nconfig = {}\nconfig['showLink'] = show_link\nconfig['linkText'] = link_text\njconfig = json.dumps(config)\n```\n"},"comment":{"url":"https://api.github.com/repos/plotly/plotly.py/issues/comments/258153104","html_url":"https://github.com/plotly/plotly.py/issues/399#issuecomment-258153104","issue_url":"https://api.github.com/repos/plotly/plotly.py/issues/399","id":258153104,"user":{"login":"gte620v","id":2158394,"avatar_url":"https://avatars.githubusercontent.com/u/2158394?v=3","gravatar_id":"","url":"https://api.github.com/users/gte620v","html_url":"https://github.com/gte620v","followers_url":"https://api.github.com/users/gte620v/followers","following_url":"https://api.github.com/users/gte620v/following{/other_user}","gists_url":"https://api.github.com/users/gte620v/gists{/gist_id}","starred_url":"https://api.github.com/users/gte620v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gte620v/subscriptions","organizations_url":"https://api.github.com/users/gte620v/orgs","repos_url":"https://api.github.com/users/gte620v/repos","events_url":"https://api.github.com/users/gte620v/events{/privacy}","received_events_url":"https://api.github.com/users/gte620v/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T14:11:46Z","updated_at":"2016-11-03T14:11:46Z","body":"This seems to have broken offline mode, which is still expecting the old argument signature for `_plot_html`.  See https://github.com/plotly/plotly.py/blob/4420d794ed58f31cd2c3a1f13558a9e9da798335/plotly/offline/offline.py#L311-L313\r\n\r\nCompared to https://github.com/plotly/plotly.py/blob/4420d794ed58f31cd2c3a1f13558a9e9da798335/plotly/offline/offline.py#L163-L164\r\n\r\nIn this PR, I think line 311 should have been changed to:\r\n```\r\n    plot_html, plotdivid, width, height = _plot_html(\r\n        figure_or_data, {'showLink':show_link, 'linkText':link_text}, validate,\r\n        '100%', 525, global_requirejs=True)\r\n```\r\n\r\nWithout this, even the most basic usage fails."}}
{"actor":{"display_login":"gte620v"}}