{"action":"created","issue":{"url":"https://api.github.com/repos/leeoniya/domvm/issues/97","repository_url":"https://api.github.com/repos/leeoniya/domvm","labels_url":"https://api.github.com/repos/leeoniya/domvm/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/leeoniya/domvm/issues/97/comments","events_url":"https://api.github.com/repos/leeoniya/domvm/issues/97/events","html_url":"https://github.com/leeoniya/domvm/pull/97","id":171483768,"number":97,"title":"add didEnter and didExit events to the router config","user":{"login":"yosbelms","id":12763081,"avatar_url":"https://avatars.githubusercontent.com/u/12763081?v=3","gravatar_id":"","url":"https://api.github.com/users/yosbelms","html_url":"https://github.com/yosbelms","followers_url":"https://api.github.com/users/yosbelms/followers","following_url":"https://api.github.com/users/yosbelms/following{/other_user}","gists_url":"https://api.github.com/users/yosbelms/gists{/gist_id}","starred_url":"https://api.github.com/users/yosbelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosbelms/subscriptions","organizations_url":"https://api.github.com/users/yosbelms/orgs","repos_url":"https://api.github.com/users/yosbelms/repos","events_url":"https://api.github.com/users/yosbelms/events{/privacy}","received_events_url":"https://api.github.com/users/yosbelms/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-16T18:21:47Z","updated_at":"2016-08-17T22:38:50Z","closed_at":"2016-08-16T19:22:49Z","pull_request":{"url":"https://api.github.com/repos/leeoniya/domvm/pulls/97","html_url":"https://github.com/leeoniya/domvm/pull/97","diff_url":"https://github.com/leeoniya/domvm/pull/97.diff","patch_url":"https://github.com/leeoniya/domvm/pull/97.patch"},"body":"docs included"},"comment":{"url":"https://api.github.com/repos/leeoniya/domvm/issues/comments/240570929","html_url":"https://github.com/leeoniya/domvm/pull/97#issuecomment-240570929","issue_url":"https://api.github.com/repos/leeoniya/domvm/issues/97","id":240570929,"user":{"login":"leeoniya","id":43234,"avatar_url":"https://avatars.githubusercontent.com/u/43234?v=3","gravatar_id":"","url":"https://api.github.com/users/leeoniya","html_url":"https://github.com/leeoniya","followers_url":"https://api.github.com/users/leeoniya/followers","following_url":"https://api.github.com/users/leeoniya/following{/other_user}","gists_url":"https://api.github.com/users/leeoniya/gists{/gist_id}","starred_url":"https://api.github.com/users/leeoniya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeoniya/subscriptions","organizations_url":"https://api.github.com/users/leeoniya/orgs","repos_url":"https://api.github.com/users/leeoniya/repos","events_url":"https://api.github.com/users/leeoniya/events{/privacy}","received_events_url":"https://api.github.com/users/leeoniya/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T22:38:50Z","updated_at":"2016-08-17T22:38:50Z","body":"> Actually willEnter can prevent onenter, so onenter should prevent didEnter to standarize the events flow.\r\n\r\nI think that only `willEnter` and `willExit` should be able to prevent further routing and must be responsible for any nav reversion and redirecting. `onenter` is meant to be reactive and is married to `didEnter` (which is just a DRY helper). same goes for `onexit`/`didExit`. Being able to prevent the DRY helpers from already-invoked route handlers that signify successful entry/exit would make things confusing.\r\n\r\nfollowing this reasoning, it means removing the existing `false` return handling for `onenter` and `onexit`. moreover, this only prevented the actual addressbar/history from getting set. this handling was never documented, so I'm okay with removing it. in addition, it was present at first before router-wide `willEnter` and `willExit` existed, so was not doable another way."}}
{"actor":{"display_login":"leeoniya"}}