{"action":"created","comment":{"url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments/67085735","id":67085735,"diff_hunk":"@@ -1277,23 +1289,41 @@ local function Create3DUserGuiToggleIcon(topBarInstance, panel, menubar)\n \t\tImage = \"rbxasset://textures/ui/VR/toggle2D.png\"\n \t}\n \n-\tlocal userGuiPanel = Panel3D.Get(\"UserGui\")\n+\tlocal thisModuleName = \"UserGui\"\n+\n+\tlocal userGuiPanel = Panel3D.Get(thisModuleName)\n \tuserGuiPanel:SetType(Panel3D.Type.Fixed)\n-\tuserGuiPanel:ResizePixels(300, 125)\n+\tuserGuiPanel:ResizeStuds(4, 4, 128)\n \tuserGuiPanel:SetVisible(false, false)\n \n-\tmenuItem.MouseButton1Click:connect(function()\n-\t\tif InputService.VREnabled then\n-\t\t\tuserGuiPanel:SetVisible(not userGuiPanel.isVisible, false)\n+\tlocal VRHub = require(GuiRoot.Modules.VR.VRHub)\n+\n+\tVRHub.ModuleOpened.Event:connect(function(moduleName, isExclusive, shouldCloseNonExclusive, shouldKeepTopbarOpen)\n+\t\tif shouldCloseNonExclusive and menuItem:IsActive() then\n+\t\t\tmenuItem:SetActive(false)\n+\t\t\tuserGuiPanel:SetVisible(false)\n+\n+\t\t\tVRHub:FireModuleClosed(thisModuleName)\n \t\tend\n \tend)\n \n+\tfunction menuItem:OnClicked(wasActive)\n+\t\tmenuItem:SetActive(not wasActive)\n+\t\tuserGuiPanel:SetVisible(not wasActive)\n+\t\n+\t\tif not wasActive then\n+\t\t\tVRHub:FireModuleOpened(thisModuleName, false, false, false)\n+\t\telse\n+\t\t\tVRHub:FireModuleClosed(thisModuleName)\n+\t\tend\n+\tend\n+\n \tfunction userGuiPanel:OnVisibilityChanged(visible)\n \t\tif visible then\n \t\t\tlocal headLook = Panel3D.GetHeadLookXZ(true)\n \t\t\tuserGuiPanel.localCF = headLook * CFrame.Angles(math.rad(5), 0, 0) * CFrame.new(0, 0, 5)\n \t\tend\n-\t\tmenuItem:SetActive(visible)\n+\t\tmenuItem:SetActive(visible, true)","path":"CoreScriptsRoot/CoreScripts/Topbar.lua","position":280,"original_position":283,"commit_id":"9de5474f68faf15c84eec512fadee9657f38443f","original_commit_id":"70e8cd959b6cbda953350ef825e8c42c2bc42f17","user":{"login":"SolarCrane","id":6992752,"avatar_url":"https://avatars.githubusercontent.com/u/6992752?v=3","gravatar_id":"","url":"https://api.github.com/users/SolarCrane","html_url":"https://github.com/SolarCrane","followers_url":"https://api.github.com/users/SolarCrane/followers","following_url":"https://api.github.com/users/SolarCrane/following{/other_user}","gists_url":"https://api.github.com/users/SolarCrane/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarCrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarCrane/subscriptions","organizations_url":"https://api.github.com/users/SolarCrane/orgs","repos_url":"https://api.github.com/users/SolarCrane/repos","events_url":"https://api.github.com/users/SolarCrane/events{/privacy}","received_events_url":"https://api.github.com/users/SolarCrane/received_events","type":"User","site_admin":false},"body":"Is there a `SetActive` that takes 2 args? It looks like the initial definition only takes 1 arg?","created_at":"2016-06-15T01:16:19Z","updated_at":"2016-06-15T01:16:19Z","html_url":"https://github.com/ROBLOX/Core-Scripts/pull/418#discussion_r67085735","pull_request_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments/67085735"},"html":{"href":"https://github.com/ROBLOX/Core-Scripts/pull/418#discussion_r67085735"},"pull_request":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418","id":73262153,"html_url":"https://github.com/ROBLOX/Core-Scripts/pull/418","diff_url":"https://github.com/ROBLOX/Core-Scripts/pull/418.diff","patch_url":"https://github.com/ROBLOX/Core-Scripts/pull/418.patch","issue_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/418","number":418,"state":"open","locked":false,"title":"VR-39: Recenter View button and various cleanup/fixes","user":{"login":"kyle-emmerich","id":1709380,"avatar_url":"https://avatars.githubusercontent.com/u/1709380?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-emmerich","html_url":"https://github.com/kyle-emmerich","followers_url":"https://api.github.com/users/kyle-emmerich/followers","following_url":"https://api.github.com/users/kyle-emmerich/following{/other_user}","gists_url":"https://api.github.com/users/kyle-emmerich/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-emmerich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-emmerich/subscriptions","organizations_url":"https://api.github.com/users/kyle-emmerich/orgs","repos_url":"https://api.github.com/users/kyle-emmerich/repos","events_url":"https://api.github.com/users/kyle-emmerich/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-emmerich/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-09T18:24:58Z","updated_at":"2016-06-15T01:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"180390649a893041dcd1c0261fb055aa443c6f23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418/commits","review_comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418/comments","review_comment_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/418/comments","statuses_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/9de5474f68faf15c84eec512fadee9657f38443f","head":{"label":"kyle-emmerich:panel-refactor","ref":"panel-refactor","sha":"9de5474f68faf15c84eec512fadee9657f38443f","user":{"login":"kyle-emmerich","id":1709380,"avatar_url":"https://avatars.githubusercontent.com/u/1709380?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-emmerich","html_url":"https://github.com/kyle-emmerich","followers_url":"https://api.github.com/users/kyle-emmerich/followers","following_url":"https://api.github.com/users/kyle-emmerich/following{/other_user}","gists_url":"https://api.github.com/users/kyle-emmerich/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-emmerich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-emmerich/subscriptions","organizations_url":"https://api.github.com/users/kyle-emmerich/orgs","repos_url":"https://api.github.com/users/kyle-emmerich/repos","events_url":"https://api.github.com/users/kyle-emmerich/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-emmerich/received_events","type":"User","site_admin":false},"repo":{"id":54408280,"name":"Core-Scripts","full_name":"kyle-emmerich/Core-Scripts","owner":{"login":"kyle-emmerich","id":1709380,"avatar_url":"https://avatars.githubusercontent.com/u/1709380?v=3","gravatar_id":"","url":"https://api.github.com/users/kyle-emmerich","html_url":"https://github.com/kyle-emmerich","followers_url":"https://api.github.com/users/kyle-emmerich/followers","following_url":"https://api.github.com/users/kyle-emmerich/following{/other_user}","gists_url":"https://api.github.com/users/kyle-emmerich/gists{/gist_id}","starred_url":"https://api.github.com/users/kyle-emmerich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyle-emmerich/subscriptions","organizations_url":"https://api.github.com/users/kyle-emmerich/orgs","repos_url":"https://api.github.com/users/kyle-emmerich/repos","events_url":"https://api.github.com/users/kyle-emmerich/events{/privacy}","received_events_url":"https://api.github.com/users/kyle-emmerich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyle-emmerich/Core-Scripts","description":"All of ROBLOX's core client scripts.","fork":true,"url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts","forks_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/forks","keys_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/teams","hooks_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/hooks","issue_events_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/events","assignees_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/tags","blobs_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/languages","stargazers_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/stargazers","contributors_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/contributors","subscribers_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/subscribers","subscription_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/subscription","commits_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/merges","archive_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/downloads","issues_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/kyle-emmerich/Core-Scripts/deployments","created_at":"2016-03-21T17:18:43Z","updated_at":"2016-03-21T17:18:44Z","pushed_at":"2016-06-15T00:42:52Z","git_url":"git://github.com/kyle-emmerich/Core-Scripts.git","ssh_url":"git@github.com:kyle-emmerich/Core-Scripts.git","clone_url":"https://github.com/kyle-emmerich/Core-Scripts.git","svn_url":"https://github.com/kyle-emmerich/Core-Scripts","homepage":"","size":2759,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROBLOX:master","ref":"master","sha":"d8b8a99d32e3b856c9f177b9a56ee54aa7f2e001","user":{"login":"ROBLOX","id":4195619,"avatar_url":"https://avatars.githubusercontent.com/u/4195619?v=3","gravatar_id":"","url":"https://api.github.com/users/ROBLOX","html_url":"https://github.com/ROBLOX","followers_url":"https://api.github.com/users/ROBLOX/followers","following_url":"https://api.github.com/users/ROBLOX/following{/other_user}","gists_url":"https://api.github.com/users/ROBLOX/gists{/gist_id}","starred_url":"https://api.github.com/users/ROBLOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROBLOX/subscriptions","organizations_url":"https://api.github.com/users/ROBLOX/orgs","repos_url":"https://api.github.com/users/ROBLOX/repos","events_url":"https://api.github.com/users/ROBLOX/events{/privacy}","received_events_url":"https://api.github.com/users/ROBLOX/received_events","type":"Organization","site_admin":false},"repo":{"id":19040095,"name":"Core-Scripts","full_name":"ROBLOX/Core-Scripts","owner":{"login":"ROBLOX","id":4195619,"avatar_url":"https://avatars.githubusercontent.com/u/4195619?v=3","gravatar_id":"","url":"https://api.github.com/users/ROBLOX","html_url":"https://github.com/ROBLOX","followers_url":"https://api.github.com/users/ROBLOX/followers","following_url":"https://api.github.com/users/ROBLOX/following{/other_user}","gists_url":"https://api.github.com/users/ROBLOX/gists{/gist_id}","starred_url":"https://api.github.com/users/ROBLOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROBLOX/subscriptions","organizations_url":"https://api.github.com/users/ROBLOX/orgs","repos_url":"https://api.github.com/users/ROBLOX/repos","events_url":"https://api.github.com/users/ROBLOX/events{/privacy}","received_events_url":"https://api.github.com/users/ROBLOX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ROBLOX/Core-Scripts","description":"All of ROBLOX's core client scripts.","fork":false,"url":"https://api.github.com/repos/ROBLOX/Core-Scripts","forks_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/forks","keys_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/teams","hooks_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/hooks","issue_events_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/events","assignees_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/tags","blobs_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/languages","stargazers_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/stargazers","contributors_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/contributors","subscribers_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/subscribers","subscription_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/subscription","commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/merges","archive_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/downloads","issues_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/deployments","created_at":"2014-04-22T18:02:17Z","updated_at":"2016-04-18T23:51:11Z","pushed_at":"2016-06-15T00:42:52Z","git_url":"git://github.com/ROBLOX/Core-Scripts.git","ssh_url":"git@github.com:ROBLOX/Core-Scripts.git","clone_url":"https://github.com/ROBLOX/Core-Scripts.git","svn_url":"https://github.com/ROBLOX/Core-Scripts","homepage":"","size":3129,"stargazers_count":50,"watchers_count":50,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":25,"forks":84,"open_issues":25,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418"},"html":{"href":"https://github.com/ROBLOX/Core-Scripts/pull/418"},"issue":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/418"},"comments":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/9de5474f68faf15c84eec512fadee9657f38443f"}}}}
{"actor":{"display_login":"SolarCrane"}}