{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/72828727","id":72828727,"diff_hunk":"@@ -31,11 +32,60 @@ inline GLint ToGLDataFormat(TextureImageDataFormat dataFormat) {\n   return GL_NONE;\n }\n \n+inline GrPixelConfig ToGrPixelConfig(TextureImageDataFormat dataFormat) {\n+  switch (dataFormat) {\n+    case TextureImageDataFormat::UnsignedByte:\n+      return kRGBA_8888_GrPixelConfig;\n+    case TextureImageDataFormat::UnsignedShort565:\n+      return kRGB_565_GrPixelConfig;\n+  }\n+  return kUnknown_GrPixelConfig;\n+}\n+\n+sk_sp<SkImage> TextureImageCreate(GrContext* context, const SkBitmap& bitmap) {\n+  if (context == nullptr) {\n+    return nullptr;\n+  }\n+\n+  if (bitmap.drawsNothing()) {\n+    return nullptr;\n+  }\n+\n+  TextureImageDataFormat dataFormat = TextureImageDataFormat::UnsignedByte;\n+  TextureImageFormat imageFormat = TextureImageFormat::RGBA;\n+\n+  switch (bitmap.colorType()) {\n+    case kRGB_565_SkColorType:\n+      dataFormat = TextureImageDataFormat::UnsignedShort565;\n+      imageFormat = TextureImageFormat::RGB;\n+      break;\n+    case kRGBA_8888_SkColorType:\n+      dataFormat = TextureImageDataFormat::UnsignedByte;\n+      imageFormat = TextureImageFormat::RGBA;\n+      break;\n+    default:\n+      // Add more as supported.","path":"flow/texture_image.cc","position":44,"original_position":44,"commit_id":"c3f7b77298bd94472f3a8270a803f2e88b8ed35e","original_commit_id":"c3f7b77298bd94472f3a8270a803f2e88b8ed35e","user":{"login":"eseidelGoogle","id":11857803,"avatar_url":"https://avatars.githubusercontent.com/u/11857803?v=3","gravatar_id":"","url":"https://api.github.com/users/eseidelGoogle","html_url":"https://github.com/eseidelGoogle","followers_url":"https://api.github.com/users/eseidelGoogle/followers","following_url":"https://api.github.com/users/eseidelGoogle/following{/other_user}","gists_url":"https://api.github.com/users/eseidelGoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/eseidelGoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eseidelGoogle/subscriptions","organizations_url":"https://api.github.com/users/eseidelGoogle/orgs","repos_url":"https://api.github.com/users/eseidelGoogle/repos","events_url":"https://api.github.com/users/eseidelGoogle/events{/privacy}","received_events_url":"https://api.github.com/users/eseidelGoogle/received_events","type":"User","site_admin":false},"body":"Will users have any way to hit this (based on what kinds of images they provide) or will we only hit this when adding new hardware, or?","created_at":"2016-07-29T17:22:14Z","updated_at":"2016-07-29T17:22:14Z","html_url":"https://github.com/flutter/engine/pull/2837#discussion_r72828727","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/2837","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/72828727"},"html":{"href":"https://github.com/flutter/engine/pull/2837#discussion_r72828727"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/2837"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/2837","id":79106957,"html_url":"https://github.com/flutter/engine/pull/2837","diff_url":"https://github.com/flutter/engine/pull/2837.diff","patch_url":"https://github.com/flutter/engine/pull/2837.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/2837","number":2837,"state":"open","locked":false,"title":"Asynchronous Texture Uploads.","user":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars.githubusercontent.com/u/44085?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-27T22:12:05Z","updated_at":"2016-07-29T17:22:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bbdec2c6c8c27b1557b1753fbf368a3e28a786d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/2837/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/2837/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/2837/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/c3f7b77298bd94472f3a8270a803f2e88b8ed35e","head":{"label":"chinmaygarde:async_tex_upload","ref":"async_tex_upload","sha":"c3f7b77298bd94472f3a8270a803f2e88b8ed35e","user":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars.githubusercontent.com/u/44085?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"repo":{"id":39225162,"name":"flutter_engine","full_name":"chinmaygarde/flutter_engine","owner":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars.githubusercontent.com/u/44085?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chinmaygarde/flutter_engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/chinmaygarde/flutter_engine","forks_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/forks","keys_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/teams","hooks_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/hooks","issue_events_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues/events{/number}","events_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/events","assignees_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/assignees{/user}","branches_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/branches{/branch}","tags_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/tags","blobs_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/languages","stargazers_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/stargazers","contributors_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/contributors","subscribers_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/subscribers","subscription_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/subscription","commits_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/contents/{+path}","compare_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/merges","archive_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/downloads","issues_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues{/number}","pulls_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/labels{/name}","releases_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/releases{/id}","deployments_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/deployments","created_at":"2015-07-16T23:24:34Z","updated_at":"2016-01-11T21:26:09Z","pushed_at":"2016-07-29T17:18:21Z","git_url":"git://github.com/chinmaygarde/flutter_engine.git","ssh_url":"git@github.com:chinmaygarde/flutter_engine.git","clone_url":"https://github.com/chinmaygarde/flutter_engine.git","svn_url":"https://github.com/chinmaygarde/flutter_engine","homepage":null,"size":82859,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"84872e4fd6b320866d8038a7062d89800ec6b20f","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2016-07-29T01:44:16Z","pushed_at":"2016-07-29T17:18:21Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":105356,"stargazers_count":877,"watchers_count":877,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":5,"forks":148,"open_issues":5,"watchers":877,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/2837"},"html":{"href":"https://github.com/flutter/engine/pull/2837"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/2837"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/2837/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/2837/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/2837/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/c3f7b77298bd94472f3a8270a803f2e88b8ed35e"}}}}
{"actor":{"display_login":"eseidelGoogle"}}