{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/49021226","id":49021226,"diff_hunk":"@@ -76,6 +76,9 @@ def Prepare(benchmark_spec):\n       vm.AllowPort(IPERF_PORT)\n     vm.RemoteCommand('nohup iperf --server --port %s &> /dev/null &' %","path":"perfkitbenchmarker/linux_benchmarks/iperf_benchmark.py","position":2,"original_position":2,"commit_id":"dd24e978cdea194d1675425c8644864a16347ec8","original_commit_id":"dd24e978cdea194d1675425c8644864a16347ec8","user":{"login":"cmccoy","id":564884,"avatar_url":"https://avatars.githubusercontent.com/u/564884?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccoy","html_url":"https://github.com/cmccoy","followers_url":"https://api.github.com/users/cmccoy/followers","following_url":"https://api.github.com/users/cmccoy/following{/other_user}","gists_url":"https://api.github.com/users/cmccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccoy/subscriptions","organizations_url":"https://api.github.com/users/cmccoy/orgs","repos_url":"https://api.github.com/users/cmccoy/repos","events_url":"https://api.github.com/users/cmccoy/events{/privacy}","received_events_url":"https://api.github.com/users/cmccoy/received_events","type":"User","site_admin":false},"body":"In case it's useful: elsewhere we've gotten the PID directly via [`echo $!`](https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/traces/dstat.py#L83)","created_at":"2016-01-06T22:51:06Z","updated_at":"2016-01-06T22:51:06Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/784#discussion_r49021226","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/49021226"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/784#discussion_r49021226"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784","id":55275809,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/784","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/784.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/784.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/784","number":784,"state":"open","locked":false,"title":"kill iperf processes started by the benchmark on all machines","user":{"login":"hildrum","id":5419652,"avatar_url":"https://avatars.githubusercontent.com/u/5419652?v=3","gravatar_id":"","url":"https://api.github.com/users/hildrum","html_url":"https://github.com/hildrum","followers_url":"https://api.github.com/users/hildrum/followers","following_url":"https://api.github.com/users/hildrum/following{/other_user}","gists_url":"https://api.github.com/users/hildrum/gists{/gist_id}","starred_url":"https://api.github.com/users/hildrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hildrum/subscriptions","organizations_url":"https://api.github.com/users/hildrum/orgs","repos_url":"https://api.github.com/users/hildrum/repos","events_url":"https://api.github.com/users/hildrum/events{/privacy}","received_events_url":"https://api.github.com/users/hildrum/received_events","type":"User","site_admin":false},"body":"I noticed two minor problems in the iperf benchmark:\r\n* It was only cleaning up iperf on one of the hosts\r\n* It was was killing all iperf processes.\r\n\r\nSo I modified the benchmark to store the pid of the iperf process and only kill that iperf process.  ","created_at":"2016-01-06T22:43:10Z","updated_at":"2016-01-06T22:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e54e27a37af99c9e20ac8f2eddab505b0054aa7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/784/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/dd24e978cdea194d1675425c8644864a16347ec8","head":{"label":"hildrum:iperf_fix","ref":"iperf_fix","sha":"dd24e978cdea194d1675425c8644864a16347ec8","user":{"login":"hildrum","id":5419652,"avatar_url":"https://avatars.githubusercontent.com/u/5419652?v=3","gravatar_id":"","url":"https://api.github.com/users/hildrum","html_url":"https://github.com/hildrum","followers_url":"https://api.github.com/users/hildrum/followers","following_url":"https://api.github.com/users/hildrum/following{/other_user}","gists_url":"https://api.github.com/users/hildrum/gists{/gist_id}","starred_url":"https://api.github.com/users/hildrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hildrum/subscriptions","organizations_url":"https://api.github.com/users/hildrum/orgs","repos_url":"https://api.github.com/users/hildrum/repos","events_url":"https://api.github.com/users/hildrum/events{/privacy}","received_events_url":"https://api.github.com/users/hildrum/received_events","type":"User","site_admin":false},"repo":{"id":46576706,"name":"PerfKitBenchmarker","full_name":"hildrum/PerfKitBenchmarker","owner":{"login":"hildrum","id":5419652,"avatar_url":"https://avatars.githubusercontent.com/u/5419652?v=3","gravatar_id":"","url":"https://api.github.com/users/hildrum","html_url":"https://github.com/hildrum","followers_url":"https://api.github.com/users/hildrum/followers","following_url":"https://api.github.com/users/hildrum/following{/other_user}","gists_url":"https://api.github.com/users/hildrum/gists{/gist_id}","starred_url":"https://api.github.com/users/hildrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hildrum/subscriptions","organizations_url":"https://api.github.com/users/hildrum/orgs","repos_url":"https://api.github.com/users/hildrum/repos","events_url":"https://api.github.com/users/hildrum/events{/privacy}","received_events_url":"https://api.github.com/users/hildrum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hildrum/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/hildrum/PerfKitBenchmarker/releases{/id}","created_at":"2015-11-20T17:29:34Z","updated_at":"2015-11-20T17:29:36Z","pushed_at":"2016-01-06T22:41:03Z","git_url":"git://github.com/hildrum/PerfKitBenchmarker.git","ssh_url":"git@github.com:hildrum/PerfKitBenchmarker.git","clone_url":"https://github.com/hildrum/PerfKitBenchmarker.git","svn_url":"https://github.com/hildrum/PerfKitBenchmarker","homepage":"","size":6469,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6489ce0f65ada05db8f95cf8d1f2706f49b116e4","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","created_at":"2014-07-17T17:23:26Z","updated_at":"2016-01-06T20:35:28Z","pushed_at":"2016-01-06T22:43:11Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":84729,"stargazers_count":556,"watchers_count":556,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"open_issues_count":100,"forks":109,"open_issues":100,"watchers":556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/784"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/784"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/784/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/784/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/dd24e978cdea194d1675425c8644864a16347ec8"}}}}