{"action":"created","issue":{"url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/issues/325","repository_url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin","labels_url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/issues/325/labels{/name}","comments_url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/issues/325/comments","events_url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/issues/325/events","html_url":"https://github.com/orthes/medium-editor-insert-plugin/pull/325","id":154929447,"number":325,"title":"When the upload fails, remove image preview","user":{"login":"orhanveli","id":525103,"avatar_url":"https://avatars.githubusercontent.com/u/525103?v=3","gravatar_id":"","url":"https://api.github.com/users/orhanveli","html_url":"https://github.com/orhanveli","followers_url":"https://api.github.com/users/orhanveli/followers","following_url":"https://api.github.com/users/orhanveli/following{/other_user}","gists_url":"https://api.github.com/users/orhanveli/gists{/gist_id}","starred_url":"https://api.github.com/users/orhanveli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orhanveli/subscriptions","organizations_url":"https://api.github.com/users/orhanveli/orgs","repos_url":"https://api.github.com/users/orhanveli/repos","events_url":"https://api.github.com/users/orhanveli/events{/privacy}","received_events_url":"https://api.github.com/users/orhanveli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/labels/awaiting%20response","name":"awaiting response","color":"fad8c7"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-05-15T20:50:29Z","updated_at":"2016-08-08T11:42:20Z","closed_at":"2016-08-08T11:42:20Z","pull_request":{"url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/pulls/325","html_url":"https://github.com/orthes/medium-editor-insert-plugin/pull/325","diff_url":"https://github.com/orthes/medium-editor-insert-plugin/pull/325.diff","patch_url":"https://github.com/orthes/medium-editor-insert-plugin/pull/325.patch"},"body":"This commit for preventing to submitting failed upload previews which are sources as base64 encoded img hash."},"comment":{"url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/issues/comments/238212036","html_url":"https://github.com/orthes/medium-editor-insert-plugin/pull/325#issuecomment-238212036","issue_url":"https://api.github.com/repos/orthes/medium-editor-insert-plugin/issues/325","id":238212036,"user":{"login":"orthes","id":312938,"avatar_url":"https://avatars.githubusercontent.com/u/312938?v=3","gravatar_id":"","url":"https://api.github.com/users/orthes","html_url":"https://github.com/orthes","followers_url":"https://api.github.com/users/orthes/followers","following_url":"https://api.github.com/users/orthes/following{/other_user}","gists_url":"https://api.github.com/users/orthes/gists{/gist_id}","starred_url":"https://api.github.com/users/orthes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orthes/subscriptions","organizations_url":"https://api.github.com/users/orthes/orgs","repos_url":"https://api.github.com/users/orthes/repos","events_url":"https://api.github.com/users/orthes/events{/privacy}","received_events_url":"https://api.github.com/users/orthes/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T11:42:20Z","updated_at":"2016-08-08T11:42:20Z","body":"I don't think this is a universal behavior for every use case. Sometimes you might want to leave the preview images there. Maybe you want to implement some sort of auto retry after failed images and you don't want to remove previews. Or I even saw projects where they don't have upload API at all for some reason. Even our demo page doesn't have it.\r\n\r\nI think more universal approach would be to remove preview images on save so you prevent sending those huge data URI to your server. But in that case you want to remove it in serialize function, not on failed upload."}}
{"actor":{"display_login":"orthes"}}