{"action":"created","issue":{"url":"https://api.github.com/repos/lbryio/lbry/issues/76","repository_url":"https://api.github.com/repos/lbryio/lbry","labels_url":"https://api.github.com/repos/lbryio/lbry/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/lbryio/lbry/issues/76/comments","events_url":"https://api.github.com/repos/lbryio/lbry/issues/76/events","html_url":"https://github.com/lbryio/lbry/pull/76","id":165939623,"number":76,"title":"Rename metadata field content-type to content_type, as the - characte…","user":{"login":"kimihiro64","id":20328275,"avatar_url":"https://avatars.githubusercontent.com/u/20328275?v=3","gravatar_id":"","url":"https://api.github.com/users/kimihiro64","html_url":"https://github.com/kimihiro64","followers_url":"https://api.github.com/users/kimihiro64/followers","following_url":"https://api.github.com/users/kimihiro64/following{/other_user}","gists_url":"https://api.github.com/users/kimihiro64/gists{/gist_id}","starred_url":"https://api.github.com/users/kimihiro64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimihiro64/subscriptions","organizations_url":"https://api.github.com/users/kimihiro64/orgs","repos_url":"https://api.github.com/users/kimihiro64/repos","events_url":"https://api.github.com/users/kimihiro64/events{/privacy}","received_events_url":"https://api.github.com/users/kimihiro64/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-16T17:41:31Z","updated_at":"2016-07-17T14:08:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lbryio/lbry/pulls/76","html_url":"https://github.com/lbryio/lbry/pull/76","diff_url":"https://github.com/lbryio/lbry/pull/76.diff","patch_url":"https://github.com/lbryio/lbry/pull/76.patch"},"body":"…r makes the property inaccessible when parsed by reactJS."},"comment":{"url":"https://api.github.com/repos/lbryio/lbry/issues/comments/233183756","html_url":"https://github.com/lbryio/lbry/pull/76#issuecomment-233183756","issue_url":"https://api.github.com/repos/lbryio/lbry/issues/76","id":233183756,"user":{"login":"jobevers","id":2380127,"avatar_url":"https://avatars.githubusercontent.com/u/2380127?v=3","gravatar_id":"","url":"https://api.github.com/users/jobevers","html_url":"https://github.com/jobevers","followers_url":"https://api.github.com/users/jobevers/followers","following_url":"https://api.github.com/users/jobevers/following{/other_user}","gists_url":"https://api.github.com/users/jobevers/gists{/gist_id}","starred_url":"https://api.github.com/users/jobevers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobevers/subscriptions","organizations_url":"https://api.github.com/users/jobevers/orgs","repos_url":"https://api.github.com/users/jobevers/repos","events_url":"https://api.github.com/users/jobevers/events{/privacy}","received_events_url":"https://api.github.com/users/jobevers/received_events","type":"User","site_admin":false},"created_at":"2016-07-17T14:08:16Z","updated_at":"2016-07-17T14:08:16Z","body":"First - being picky - please limit the length of the first line of the commit message.  This would read better as:\r\n```Rename metadata field content-type to content_type.\r\n\r\nThe dash in content-type makes the property inaccessible when\r\nparsed by reactJs.  Switching to underscore.\r\n```\r\n\r\nSecond - changes to the meta-data parsing *have to be* backwards compatible. This change will fail here: https://github.com/lbryio/lbry/blob/ed0f9d4fb5b403290cf75833c5063fc2d628a4d6/lbrynet/core/LBRYWallet.py#L329 when the meta-data read from the blockchain is using `content-type` instead of `content_type`\r\n\r\nOn the JS side, can you handle this by using `obj['content-type']` instead of `obj.content-type`?"}}
{"actor":{"display_login":"jobevers"}}