{"action":"closed","number":2729,"pull_request":{"url":"https://api.github.com/repos/ractivejs/ractive/pulls/2729","id":91539379,"html_url":"https://github.com/ractivejs/ractive/pull/2729","diff_url":"https://github.com/ractivejs/ractive/pull/2729.diff","patch_url":"https://github.com/ractivejs/ractive/pull/2729.patch","issue_url":"https://api.github.com/repos/ractivejs/ractive/issues/2729","number":2729,"state":"closed","locked":false,"title":"Various toHTML-when-not-rendered-to-DOM fixes - #2727","user":{"login":"evs-chris","id":161978,"avatar_url":"https://avatars.githubusercontent.com/u/161978?v=3","gravatar_id":"","url":"https://api.github.com/users/evs-chris","html_url":"https://github.com/evs-chris","followers_url":"https://api.github.com/users/evs-chris/followers","following_url":"https://api.github.com/users/evs-chris/following{/other_user}","gists_url":"https://api.github.com/users/evs-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/evs-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evs-chris/subscriptions","organizations_url":"https://api.github.com/users/evs-chris/orgs","repos_url":"https://api.github.com/users/evs-chris/repos","events_url":"https://api.github.com/users/evs-chris/events{/privacy}","received_events_url":"https://api.github.com/users/evs-chris/received_events","type":"User","site_admin":false},"body":"## Description of the pull request:\r\nThis modifies the render browser tests to run `toHTML` testing before rendering to the DOM to simulate what happens in node. The _main_ reason I did that was to track down the issue in #2727, but it also turned up a handful of other issues with code that expected a DOM environment where it shouldn't.\r\n\r\nThe issue #2727 is that the updateAttribute handler that is called on render sets up the special `styleName` and `inlineClass` properties on the `Attribute`. If it's never rendered, `Attribute.toString` won't realize that it's a special directive and render itself as a plain old string attribute. This PR adds a check for style- and class- directives and sets them up to be appropriately `toString`ed if they've not been rendered.\r\n\r\nThis also removes the test involving having an array as root data, as that has been deprecated for quite a while and was interfering with the way the test resets data now.\r\n\r\n## Fixes the following issues:\r\n#2727\r\n\r\n## Is breaking:\r\nNope.","created_at":"2016-10-30T22:29:39Z","updated_at":"2016-10-30T22:41:08Z","closed_at":"2016-10-30T22:41:08Z","merged_at":"2016-10-30T22:41:08Z","merge_commit_sha":"43588aa80e53d5567182ab1d8a856abe54108168","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ractivejs/ractive/pulls/2729/commits","review_comments_url":"https://api.github.com/repos/ractivejs/ractive/pulls/2729/comments","review_comment_url":"https://api.github.com/repos/ractivejs/ractive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ractivejs/ractive/issues/2729/comments","statuses_url":"https://api.github.com/repos/ractivejs/ractive/statuses/23f44296210219652bb4198bb2a28a935db35b66","head":{"label":"ractivejs:gh-2727","ref":"gh-2727","sha":"23f44296210219652bb4198bb2a28a935db35b66","user":{"login":"ractivejs","id":4751469,"avatar_url":"https://avatars.githubusercontent.com/u/4751469?v=3","gravatar_id":"","url":"https://api.github.com/users/ractivejs","html_url":"https://github.com/ractivejs","followers_url":"https://api.github.com/users/ractivejs/followers","following_url":"https://api.github.com/users/ractivejs/following{/other_user}","gists_url":"https://api.github.com/users/ractivejs/gists{/gist_id}","starred_url":"https://api.github.com/users/ractivejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ractivejs/subscriptions","organizations_url":"https://api.github.com/users/ractivejs/orgs","repos_url":"https://api.github.com/users/ractivejs/repos","events_url":"https://api.github.com/users/ractivejs/events{/privacy}","received_events_url":"https://api.github.com/users/ractivejs/received_events","type":"Organization","site_admin":false},"repo":{"id":5245894,"name":"ractive","full_name":"ractivejs/ractive","owner":{"login":"ractivejs","id":4751469,"avatar_url":"https://avatars.githubusercontent.com/u/4751469?v=3","gravatar_id":"","url":"https://api.github.com/users/ractivejs","html_url":"https://github.com/ractivejs","followers_url":"https://api.github.com/users/ractivejs/followers","following_url":"https://api.github.com/users/ractivejs/following{/other_user}","gists_url":"https://api.github.com/users/ractivejs/gists{/gist_id}","starred_url":"https://api.github.com/users/ractivejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ractivejs/subscriptions","organizations_url":"https://api.github.com/users/ractivejs/orgs","repos_url":"https://api.github.com/users/ractivejs/repos","events_url":"https://api.github.com/users/ractivejs/events{/privacy}","received_events_url":"https://api.github.com/users/ractivejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ractivejs/ractive","description":"Next-generation DOM manipulation","fork":false,"url":"https://api.github.com/repos/ractivejs/ractive","forks_url":"https://api.github.com/repos/ractivejs/ractive/forks","keys_url":"https://api.github.com/repos/ractivejs/ractive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ractivejs/ractive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ractivejs/ractive/teams","hooks_url":"https://api.github.com/repos/ractivejs/ractive/hooks","issue_events_url":"https://api.github.com/repos/ractivejs/ractive/issues/events{/number}","events_url":"https://api.github.com/repos/ractivejs/ractive/events","assignees_url":"https://api.github.com/repos/ractivejs/ractive/assignees{/user}","branches_url":"https://api.github.com/repos/ractivejs/ractive/branches{/branch}","tags_url":"https://api.github.com/repos/ractivejs/ractive/tags","blobs_url":"https://api.github.com/repos/ractivejs/ractive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ractivejs/ractive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ractivejs/ractive/git/refs{/sha}","trees_url":"https://api.github.com/repos/ractivejs/ractive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ractivejs/ractive/statuses/{sha}","languages_url":"https://api.github.com/repos/ractivejs/ractive/languages","stargazers_url":"https://api.github.com/repos/ractivejs/ractive/stargazers","contributors_url":"https://api.github.com/repos/ractivejs/ractive/contributors","subscribers_url":"https://api.github.com/repos/ractivejs/ractive/subscribers","subscription_url":"https://api.github.com/repos/ractivejs/ractive/subscription","commits_url":"https://api.github.com/repos/ractivejs/ractive/commits{/sha}","git_commits_url":"https://api.github.com/repos/ractivejs/ractive/git/commits{/sha}","comments_url":"https://api.github.com/repos/ractivejs/ractive/comments{/number}","issue_comment_url":"https://api.github.com/repos/ractivejs/ractive/issues/comments{/number}","contents_url":"https://api.github.com/repos/ractivejs/ractive/contents/{+path}","compare_url":"https://api.github.com/repos/ractivejs/ractive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ractivejs/ractive/merges","archive_url":"https://api.github.com/repos/ractivejs/ractive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ractivejs/ractive/downloads","issues_url":"https://api.github.com/repos/ractivejs/ractive/issues{/number}","pulls_url":"https://api.github.com/repos/ractivejs/ractive/pulls{/number}","milestones_url":"https://api.github.com/repos/ractivejs/ractive/milestones{/number}","notifications_url":"https://api.github.com/repos/ractivejs/ractive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ractivejs/ractive/labels{/name}","releases_url":"https://api.github.com/repos/ractivejs/ractive/releases{/id}","deployments_url":"https://api.github.com/repos/ractivejs/ractive/deployments","created_at":"2012-07-31T13:08:09Z","updated_at":"2016-10-29T17:24:52Z","pushed_at":"2016-10-30T22:41:08Z","git_url":"git://github.com/ractivejs/ractive.git","ssh_url":"git@github.com:ractivejs/ractive.git","clone_url":"https://github.com/ractivejs/ractive.git","svn_url":"https://github.com/ractivejs/ractive","homepage":"http://ractivejs.org","size":127554,"stargazers_count":5015,"watchers_count":5015,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":181,"forks":377,"open_issues":181,"watchers":5015,"default_branch":"dev"}},"base":{"label":"ractivejs:0.8","ref":"0.8","sha":"b4505fe0e6c6eea35615d04538b8098582e8c8fa","user":{"login":"ractivejs","id":4751469,"avatar_url":"https://avatars.githubusercontent.com/u/4751469?v=3","gravatar_id":"","url":"https://api.github.com/users/ractivejs","html_url":"https://github.com/ractivejs","followers_url":"https://api.github.com/users/ractivejs/followers","following_url":"https://api.github.com/users/ractivejs/following{/other_user}","gists_url":"https://api.github.com/users/ractivejs/gists{/gist_id}","starred_url":"https://api.github.com/users/ractivejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ractivejs/subscriptions","organizations_url":"https://api.github.com/users/ractivejs/orgs","repos_url":"https://api.github.com/users/ractivejs/repos","events_url":"https://api.github.com/users/ractivejs/events{/privacy}","received_events_url":"https://api.github.com/users/ractivejs/received_events","type":"Organization","site_admin":false},"repo":{"id":5245894,"name":"ractive","full_name":"ractivejs/ractive","owner":{"login":"ractivejs","id":4751469,"avatar_url":"https://avatars.githubusercontent.com/u/4751469?v=3","gravatar_id":"","url":"https://api.github.com/users/ractivejs","html_url":"https://github.com/ractivejs","followers_url":"https://api.github.com/users/ractivejs/followers","following_url":"https://api.github.com/users/ractivejs/following{/other_user}","gists_url":"https://api.github.com/users/ractivejs/gists{/gist_id}","starred_url":"https://api.github.com/users/ractivejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ractivejs/subscriptions","organizations_url":"https://api.github.com/users/ractivejs/orgs","repos_url":"https://api.github.com/users/ractivejs/repos","events_url":"https://api.github.com/users/ractivejs/events{/privacy}","received_events_url":"https://api.github.com/users/ractivejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ractivejs/ractive","description":"Next-generation DOM manipulation","fork":false,"url":"https://api.github.com/repos/ractivejs/ractive","forks_url":"https://api.github.com/repos/ractivejs/ractive/forks","keys_url":"https://api.github.com/repos/ractivejs/ractive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ractivejs/ractive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ractivejs/ractive/teams","hooks_url":"https://api.github.com/repos/ractivejs/ractive/hooks","issue_events_url":"https://api.github.com/repos/ractivejs/ractive/issues/events{/number}","events_url":"https://api.github.com/repos/ractivejs/ractive/events","assignees_url":"https://api.github.com/repos/ractivejs/ractive/assignees{/user}","branches_url":"https://api.github.com/repos/ractivejs/ractive/branches{/branch}","tags_url":"https://api.github.com/repos/ractivejs/ractive/tags","blobs_url":"https://api.github.com/repos/ractivejs/ractive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ractivejs/ractive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ractivejs/ractive/git/refs{/sha}","trees_url":"https://api.github.com/repos/ractivejs/ractive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ractivejs/ractive/statuses/{sha}","languages_url":"https://api.github.com/repos/ractivejs/ractive/languages","stargazers_url":"https://api.github.com/repos/ractivejs/ractive/stargazers","contributors_url":"https://api.github.com/repos/ractivejs/ractive/contributors","subscribers_url":"https://api.github.com/repos/ractivejs/ractive/subscribers","subscription_url":"https://api.github.com/repos/ractivejs/ractive/subscription","commits_url":"https://api.github.com/repos/ractivejs/ractive/commits{/sha}","git_commits_url":"https://api.github.com/repos/ractivejs/ractive/git/commits{/sha}","comments_url":"https://api.github.com/repos/ractivejs/ractive/comments{/number}","issue_comment_url":"https://api.github.com/repos/ractivejs/ractive/issues/comments{/number}","contents_url":"https://api.github.com/repos/ractivejs/ractive/contents/{+path}","compare_url":"https://api.github.com/repos/ractivejs/ractive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ractivejs/ractive/merges","archive_url":"https://api.github.com/repos/ractivejs/ractive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ractivejs/ractive/downloads","issues_url":"https://api.github.com/repos/ractivejs/ractive/issues{/number}","pulls_url":"https://api.github.com/repos/ractivejs/ractive/pulls{/number}","milestones_url":"https://api.github.com/repos/ractivejs/ractive/milestones{/number}","notifications_url":"https://api.github.com/repos/ractivejs/ractive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ractivejs/ractive/labels{/name}","releases_url":"https://api.github.com/repos/ractivejs/ractive/releases{/id}","deployments_url":"https://api.github.com/repos/ractivejs/ractive/deployments","created_at":"2012-07-31T13:08:09Z","updated_at":"2016-10-29T17:24:52Z","pushed_at":"2016-10-30T22:41:08Z","git_url":"git://github.com/ractivejs/ractive.git","ssh_url":"git@github.com:ractivejs/ractive.git","clone_url":"https://github.com/ractivejs/ractive.git","svn_url":"https://github.com/ractivejs/ractive","homepage":"http://ractivejs.org","size":127554,"stargazers_count":5015,"watchers_count":5015,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":181,"forks":377,"open_issues":181,"watchers":5015,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ractivejs/ractive/pulls/2729"},"html":{"href":"https://github.com/ractivejs/ractive/pull/2729"},"issue":{"href":"https://api.github.com/repos/ractivejs/ractive/issues/2729"},"comments":{"href":"https://api.github.com/repos/ractivejs/ractive/issues/2729/comments"},"review_comments":{"href":"https://api.github.com/repos/ractivejs/ractive/pulls/2729/comments"},"review_comment":{"href":"https://api.github.com/repos/ractivejs/ractive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ractivejs/ractive/pulls/2729/commits"},"statuses":{"href":"https://api.github.com/repos/ractivejs/ractive/statuses/23f44296210219652bb4198bb2a28a935db35b66"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"evs-chris","id":161978,"avatar_url":"https://avatars.githubusercontent.com/u/161978?v=3","gravatar_id":"","url":"https://api.github.com/users/evs-chris","html_url":"https://github.com/evs-chris","followers_url":"https://api.github.com/users/evs-chris/followers","following_url":"https://api.github.com/users/evs-chris/following{/other_user}","gists_url":"https://api.github.com/users/evs-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/evs-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evs-chris/subscriptions","organizations_url":"https://api.github.com/users/evs-chris/orgs","repos_url":"https://api.github.com/users/evs-chris/repos","events_url":"https://api.github.com/users/evs-chris/events{/privacy}","received_events_url":"https://api.github.com/users/evs-chris/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":64,"deletions":26,"changed_files":5}}
{"actor":{"display_login":"evs-chris"}}