{"action":"created","comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/59121431","id":59121431,"diff_hunk":"@@ -318,7 +345,7 @@ public void preRenderSetupLightGeometry() {\n         glDisable(GL_DEPTH_TEST);\n \n         glEnable(GL_BLEND);\n-        glBlendFunc(GL_ONE, GL_ONE);\n+        glBlendFunc(GL_ONE, GL_ONE_MINUS_SRC_COLOR);","path":"engine/src/main/java/org/terasology/rendering/opengl/GraphicState.java","position":43,"original_position":43,"commit_id":"b4e33898eda89f674abaa67a4e6949580e89d091","original_commit_id":"b4e33898eda89f674abaa67a4e6949580e89d091","user":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"body":"@Josharias: regarding light propagation generating a CPU bottleneck: mental note, it'd be nice to move light propagation to the GPU then, as it is probably parallelizable. That been said, I wonder if it would be horrible to wait until a torch has come to rest before light propagation kicks in. \r\n\r\n@Cervator: I think that's what I was hinting at. But I agree with Josharias this is out of this PR's scope as there would be significant changes.\r\n\r\n","created_at":"2016-04-09T21:02:19Z","updated_at":"2016-04-09T21:02:19Z","html_url":"https://github.com/MovingBlocks/Terasology/pull/2281#discussion_r59121431","pull_request_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281","_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/59121431"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2281#discussion_r59121431"},"pull_request":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281"}}},"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281","id":65829312,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2281","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2281.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2281.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2281","number":2281,"state":"open","locked":false,"title":"Reduce overbrightness in various parts of the system","user":{"login":"Josharias","id":5922109,"avatar_url":"https://avatars.githubusercontent.com/u/5922109?v=3","gravatar_id":"","url":"https://api.github.com/users/Josharias","html_url":"https://github.com/Josharias","followers_url":"https://api.github.com/users/Josharias/followers","following_url":"https://api.github.com/users/Josharias/following{/other_user}","gists_url":"https://api.github.com/users/Josharias/gists{/gist_id}","starred_url":"https://api.github.com/users/Josharias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Josharias/subscriptions","organizations_url":"https://api.github.com/users/Josharias/orgs","repos_url":"https://api.github.com/users/Josharias/repos","events_url":"https://api.github.com/users/Josharias/events{/privacy}","received_events_url":"https://api.github.com/users/Josharias/received_events","type":"User","site_admin":false},"body":"### Contains\r\n\r\nThis fixes various parts of the lighting system.  Addressing issues with dropping multiple torches, oddness with specular light, and more usable attenuation values.  Screenshots to follow...\r\n\r\nThis does introduce something that needs addressing.  When a torch is held or dropped in the world,  it does not light itself.  This is probably an already existing issue present,  but made more obvious when I removed the light fading in and out when switching between torches and non torches.  Which brings me to something else that needs addressing,  items that are held need to be better shown in a multiplayer setting.  This will allow us to avoid putting lights on the character altogether.\r\n\r\n### How to test\r\n\r\nDrop lots of torches.  Hold torches.  Watch the sun/moon effect on the world.\r\n","created_at":"2016-04-08T18:41:24Z","updated_at":"2016-04-09T21:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b627612993b7c0c063dcb7e467caa0c4003cb57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2281/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/b4e33898eda89f674abaa67a4e6949580e89d091","head":{"label":"Josharias:OverbrightnessFixes","ref":"OverbrightnessFixes","sha":"b4e33898eda89f674abaa67a4e6949580e89d091","user":{"login":"Josharias","id":5922109,"avatar_url":"https://avatars.githubusercontent.com/u/5922109?v=3","gravatar_id":"","url":"https://api.github.com/users/Josharias","html_url":"https://github.com/Josharias","followers_url":"https://api.github.com/users/Josharias/followers","following_url":"https://api.github.com/users/Josharias/following{/other_user}","gists_url":"https://api.github.com/users/Josharias/gists{/gist_id}","starred_url":"https://api.github.com/users/Josharias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Josharias/subscriptions","organizations_url":"https://api.github.com/users/Josharias/orgs","repos_url":"https://api.github.com/users/Josharias/repos","events_url":"https://api.github.com/users/Josharias/events{/privacy}","received_events_url":"https://api.github.com/users/Josharias/received_events","type":"User","site_admin":false},"repo":{"id":14342114,"name":"Terasology","full_name":"Josharias/Terasology","owner":{"login":"Josharias","id":5922109,"avatar_url":"https://avatars.githubusercontent.com/u/5922109?v=3","gravatar_id":"","url":"https://api.github.com/users/Josharias","html_url":"https://github.com/Josharias","followers_url":"https://api.github.com/users/Josharias/followers","following_url":"https://api.github.com/users/Josharias/following{/other_user}","gists_url":"https://api.github.com/users/Josharias/gists{/gist_id}","starred_url":"https://api.github.com/users/Josharias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Josharias/subscriptions","organizations_url":"https://api.github.com/users/Josharias/orgs","repos_url":"https://api.github.com/users/Josharias/repos","events_url":"https://api.github.com/users/Josharias/events{/privacy}","received_events_url":"https://api.github.com/users/Josharias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Josharias/Terasology","description":"Terasology is an open source project started by Benjamin \"begla\" Glatzel to research procedural terrain generation and efficient rendering techniques in Java using the LWJGL. The engine uses a block-based voxel-like approach as seen in Minecraft.  After proving itself as a solid tech demo begla was joined at first by Anton \"small-jeeper\" Kireev and Rasmus \"Cervator\" Praestholm and a full-fledged game concept was born. Our goal is a game that pays ample tribute to Minecraft in initial look and origin, but stakes out its own niche by adopting the NPC-helper and caretaker feel from such games as Dwarf Fortress and Dungeon Keeper, while striving for added depth and sophistication in the foundation systems akin to DF.","fork":true,"url":"https://api.github.com/repos/Josharias/Terasology","forks_url":"https://api.github.com/repos/Josharias/Terasology/forks","keys_url":"https://api.github.com/repos/Josharias/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Josharias/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Josharias/Terasology/teams","hooks_url":"https://api.github.com/repos/Josharias/Terasology/hooks","issue_events_url":"https://api.github.com/repos/Josharias/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/Josharias/Terasology/events","assignees_url":"https://api.github.com/repos/Josharias/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/Josharias/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/Josharias/Terasology/tags","blobs_url":"https://api.github.com/repos/Josharias/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Josharias/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Josharias/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/Josharias/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Josharias/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/Josharias/Terasology/languages","stargazers_url":"https://api.github.com/repos/Josharias/Terasology/stargazers","contributors_url":"https://api.github.com/repos/Josharias/Terasology/contributors","subscribers_url":"https://api.github.com/repos/Josharias/Terasology/subscribers","subscription_url":"https://api.github.com/repos/Josharias/Terasology/subscription","commits_url":"https://api.github.com/repos/Josharias/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/Josharias/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/Josharias/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/Josharias/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/Josharias/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/Josharias/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Josharias/Terasology/merges","archive_url":"https://api.github.com/repos/Josharias/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Josharias/Terasology/downloads","issues_url":"https://api.github.com/repos/Josharias/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/Josharias/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/Josharias/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/Josharias/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Josharias/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/Josharias/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/Josharias/Terasology/deployments","created_at":"2013-11-12T19:03:12Z","updated_at":"2014-07-02T15:03:53Z","pushed_at":"2016-04-09T00:05:11Z","git_url":"git://github.com/Josharias/Terasology.git","ssh_url":"git@github.com:Josharias/Terasology.git","clone_url":"https://github.com/Josharias/Terasology.git","svn_url":"https://github.com/Josharias/Terasology","homepage":"http://terasology.org/","size":206374,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"b37818c87d4bf891adb7f49b6d40f759970449da","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2016-04-09T19:40:54Z","pushed_at":"2016-04-09T19:41:25Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":331703,"stargazers_count":1440,"watchers_count":1440,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":601,"mirror_url":null,"open_issues_count":311,"forks":601,"open_issues":311,"watchers":1440,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2281"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2281"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2281/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2281/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/b4e33898eda89f674abaa67a4e6949580e89d091"}}}}