{"action":"created","issue":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/276","repository_url":"https://api.github.com/repos/dgraph-io/dgraph","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/276/comments","events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/276/events","html_url":"https://github.com/dgraph-io/dgraph/pull/276","id":181962092,"number":276,"title":"Feature/icuembed","user":{"login":"jchiu0","id":20329402,"avatar_url":"https://avatars.githubusercontent.com/u/20329402?v=3","gravatar_id":"","url":"https://api.github.com/users/jchiu0","html_url":"https://github.com/jchiu0","followers_url":"https://api.github.com/users/jchiu0/followers","following_url":"https://api.github.com/users/jchiu0/following{/other_user}","gists_url":"https://api.github.com/users/jchiu0/gists{/gist_id}","starred_url":"https://api.github.com/users/jchiu0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchiu0/subscriptions","organizations_url":"https://api.github.com/users/jchiu0/orgs","repos_url":"https://api.github.com/users/jchiu0/repos","events_url":"https://api.github.com/users/jchiu0/events{/privacy}","received_events_url":"https://api.github.com/users/jchiu0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-10T08:40:53Z","updated_at":"2016-10-10T10:11:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/276","html_url":"https://github.com/dgraph-io/dgraph/pull/276","diff_url":"https://github.com/dgraph-io/dgraph/pull/276.diff","patch_url":"https://github.com/dgraph-io/dgraph/pull/276.patch"},"body":"If you want to embed a new version of ICU, you need to run `import.sh`. It will download ICU, some data and put them in the right place for our use. Notably, it copies `stubdata.c` into the same directory as `common` so that the build doesn't complain about undefined references.\r\n\r\nIf you already have the ICU code (which is in our codebase), then you just need to build binaries with `-tags embed`. When you do so, you need to specify where the data archive is. Here is a sample test command which does that:\r\n\r\n```\r\ngo test -tags embed . -icu /home/jchiu/go/src/github.com/dgraph-io/dgraph/tok/icu/icudt57l.dat\r\n```\r\n\r\nYou can download this file at:\r\n\r\n```\r\nhttps://github.com/dgraph-io/experiments/tree/master/icu\r\n```\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/dgraph/276)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments/252579017","html_url":"https://github.com/dgraph-io/dgraph/pull/276#issuecomment-252579017","issue_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/276","id":252579017,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T10:11:58Z","updated_at":"2016-10-10T10:11:58Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8259756/badge)](https://coveralls.io/builds/8259756)\n\nCoverage increased (+11.2%) to 66.185% when pulling **c0244d8018b8e176ac55008c8d5c62c4f4a53e7c on feature/icuembed** into **3749c02fe1a45e9ae4bb7f93844bd838e189a705 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}