{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/11875","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/11875/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/11875/comments","events_url":"https://api.github.com/repos/servo/servo/issues/11875/events","html_url":"https://github.com/servo/servo/pull/11875","id":162368188,"number":11875,"title":"Integration and improvements of File API backends","user":{"login":"izgzhen","id":7168454,"avatar_url":"https://avatars.githubusercontent.com/u/7168454?v=3","gravatar_id":"","url":"https://api.github.com/users/izgzhen","html_url":"https://github.com/izgzhen","followers_url":"https://api.github.com/users/izgzhen/followers","following_url":"https://api.github.com/users/izgzhen/following{/other_user}","gists_url":"https://api.github.com/users/izgzhen/gists{/gist_id}","starred_url":"https://api.github.com/users/izgzhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izgzhen/subscriptions","organizations_url":"https://api.github.com/users/izgzhen/orgs","repos_url":"https://api.github.com/users/izgzhen/repos","events_url":"https://api.github.com/users/izgzhen/events{/privacy}","received_events_url":"https://api.github.com/users/izgzhen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"assignees":[{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2016-06-27T03:31:36Z","updated_at":"2016-07-03T15:14:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/11875","html_url":"https://github.com/servo/servo/pull/11875","diff_url":"https://github.com/servo/servo/pull/11875.diff","patch_url":"https://github.com/servo/servo/pull/11875.patch"},"body":"Basically three major changes:\r\n\r\n1. More complete origin check in `FileManagerThreadMsg`\r\n2. Add reference counting logic to file manage store and script API\r\n3. Integrate the support of slicing\r\n\r\n\r\nr? @Manishearth \r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/11875)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/230158355","html_url":"https://github.com/servo/servo/pull/11875#issuecomment-230158355","issue_url":"https://api.github.com/repos/servo/servo/issues/11875","id":230158355,"user":{"login":"izgzhen","id":7168454,"avatar_url":"https://avatars.githubusercontent.com/u/7168454?v=3","gravatar_id":"","url":"https://api.github.com/users/izgzhen","html_url":"https://github.com/izgzhen","followers_url":"https://api.github.com/users/izgzhen/followers","following_url":"https://api.github.com/users/izgzhen/following{/other_user}","gists_url":"https://api.github.com/users/izgzhen/gists{/gist_id}","starred_url":"https://api.github.com/users/izgzhen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izgzhen/subscriptions","organizations_url":"https://api.github.com/users/izgzhen/orgs","repos_url":"https://api.github.com/users/izgzhen/repos","events_url":"https://api.github.com/users/izgzhen/events{/privacy}","received_events_url":"https://api.github.com/users/izgzhen/received_events","type":"User","site_admin":false},"created_at":"2016-07-03T15:14:20Z","updated_at":"2016-07-03T15:14:20Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 14 unresolved discussions.\n\n---\n\n*[components/net/filemanager_thread.rs, line 182 \\[r2\\]](https://reviewable.io:443/reviews/servo/servo/11875#-KLlGe8SxrCiJxr6gdSe:-KLlJVAckKMTwvI-A2yO:1126699593) ([raw file](https://github.com/servo/servo/blob/990422702e669618db7278c4e00888f3cf74f21a/components/net/filemanager_thread.rs#L182)):*\n<details><summary><i>Previously, Manishearth (Manish Goregaokar) wrote…</i></summary>\n> we should incref here, no?\n</details>\nWell ... I suppose that the holder of this indirect UUID will revoke the indirect one so itself is serving like an incref except with extra boundaries\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/11875)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"izgzhen"}}