{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/55238754","id":55238754,"diff_hunk":"@@ -614,6 +614,59 @@\n         Name=\"RememberedPuppetAgentStartupMode\" Type=\"raw\" Win64=\"no\" />\n     </Property>\n \n+    <!-- Properties for existing Ini Values - expanding the remembered properties pattern just a bit\n+    -->\n+\n+    <CustomAction Id=\"SetIniPropertyValues\"\n+                  Script=\"vbscript\"\n+                  Execute=\"firstSequence\"\n+                  Return=\"ignore\">\n+      <![CDATA[\n+On Error Resume Next\n+\n+Function SetPropertyFromIni (keyName, propertyName, textToSearch)\n+  Set iniValueRegex = New RegExp\n+  iniValueRegex.IgnoreCase = true\n+  iniValueRegex.Multiline = true\n+  iniValueRegex.Global = false\n+  iniValueRegex.Pattern = \"^\" & keyName & \"=(.*[^\\s\\r\\n]*)$\"\n+\n+  Set matches = iniValueRegex.Execute(textToSearch)\n+\n+  dim iniValue\n+  iniValue = \"\"\n+\n+  If (matches.Count <> 0) Then\n+    If (matches.Item(0).SubMatches.Count <> 0) Then\n+      iniValue = matches.Item(0).SubMatches(0)\n+      iniValue = Replace(Replace(Replace(iniValue, Chr(13), \"\"), vbNewLine, \"\"), vbLf, \"\")\n+    End If\n+  End If\n+\n+  If (iniValue <> \"\") Then\n+    Session.Property(propertyName) = iniValue\n+  End If\n+End Function\n+\n+Dim fso, wshShell, iniPath\n+Set wshShell = CreateObject(\"WScript.Shell\")\n+iniPath = wshShell.ExpandEnvironmentStrings(\"%ALLUSERSPROFILE%\\PuppetLabs\\puppet\\etc\\puppet.conf\")","path":"wix/puppet.wxs","position":40,"original_position":40,"commit_id":"2c633779a87499e0f136df7911dedd4ee790369f","original_commit_id":"2c633779a87499e0f136df7911dedd4ee790369f","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"As far as grabbing the output location for it, I think it might be possible by scanning the MSI database but I'm not sure it is worth the effort.","created_at":"2016-03-07T17:30:48Z","updated_at":"2016-03-07T17:30:48Z","html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/137#discussion_r55238754","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/55238754"},"html":{"href":"https://github.com/puppetlabs/puppet_for_the_win/pull/137#discussion_r55238754"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137","id":60372051,"html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/137","diff_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/137.diff","patch_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/137.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/137","number":137,"state":"closed","locked":false,"title":"(PA-231) Keep Existing Puppet.Conf Settings","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"In `#20281` (167999a13afd622b0bc823650efbe303106b5ad0), we made a\r\nchange to allow overriding the current puppet.conf settings. This\r\ncame out in Puppet 3.4.0. This allowed being able to pass updated\r\nsettings to the installer and having them persist to the conf\r\nfile. Unfortunately, that also meant that any changes to the\r\npuppet.conf file outside of install/upgrade time would be ignored\r\nand overwritten by the remembered property values, which is\r\nundesirable.\r\n\r\nThe conf file should also be looked at as an additional source of\r\nremembered properties to allow keeping those settings when a user\r\nis not overriding those settings during the install/upgrade. To do\r\nthis we need to copy the conf file to the Windows directory, read\r\nthe property values, and then remove the file from the Windows\r\ndirectory when we are done.","created_at":"2016-02-23T16:56:04Z","updated_at":"2016-03-07T17:30:48Z","closed_at":"2016-03-06T04:48:56Z","merged_at":"2016-03-06T04:48:56Z","merge_commit_sha":"cc26270cd8d500fb05c7e804625217b21ce7a636","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/137/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/2c633779a87499e0f136df7911dedd4ee790369f","head":{"label":"ferventcoder:ticket/master/PUP-5769-fix-server-override","ref":"ticket/master/PUP-5769-fix-server-override","sha":"2c633779a87499e0f136df7911dedd4ee790369f","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"repo":{"id":11299979,"name":"puppet_for_the_win","full_name":"ferventcoder/puppet_for_the_win","owner":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferventcoder/puppet_for_the_win","description":"Rake tasks to automatically build Puppet Windows MSI Packages","fork":true,"url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win","forks_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/forks","keys_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/teams","hooks_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/hooks","issue_events_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues/events{/number}","events_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/events","assignees_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/assignees{/user}","branches_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/branches{/branch}","tags_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/tags","blobs_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/statuses/{sha}","languages_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/languages","stargazers_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/stargazers","contributors_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/contributors","subscribers_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/subscribers","subscription_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/subscription","commits_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/contents/{+path}","compare_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/merges","archive_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/downloads","issues_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues{/number}","pulls_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/pulls{/number}","milestones_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/milestones{/number}","notifications_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/labels{/name}","releases_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/releases{/id}","deployments_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/deployments","created_at":"2013-07-10T02:31:58Z","updated_at":"2015-08-08T22:59:06Z","pushed_at":"2016-03-07T17:27:26Z","git_url":"git://github.com/ferventcoder/puppet_for_the_win.git","ssh_url":"git@github.com:ferventcoder/puppet_for_the_win.git","clone_url":"https://github.com/ferventcoder/puppet_for_the_win.git","svn_url":"https://github.com/ferventcoder/puppet_for_the_win","homepage":"http://puppetlabs.com","size":704,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"d58e6a7346fb1ab249323047fb15ac1016050ce9","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":3166814,"name":"puppet_for_the_win","full_name":"puppetlabs/puppet_for_the_win","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet_for_the_win","description":"Rake tasks to automatically build Puppet Windows MSI Packages","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win","forks_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/deployments","created_at":"2012-01-12T23:13:50Z","updated_at":"2016-02-22T08:19:18Z","pushed_at":"2016-03-06T04:48:56Z","git_url":"git://github.com/puppetlabs/puppet_for_the_win.git","ssh_url":"git@github.com:puppetlabs/puppet_for_the_win.git","clone_url":"https://github.com/puppetlabs/puppet_for_the_win.git","svn_url":"https://github.com/puppetlabs/puppet_for_the_win","homepage":"http://puppetlabs.com","size":786,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":0,"forks":28,"open_issues":0,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137"},"html":{"href":"https://github.com/puppetlabs/puppet_for_the_win/pull/137"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/137"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/2c633779a87499e0f136df7911dedd4ee790369f"}}}}