{"action":"created","issue":{"url":"https://api.github.com/repos/lvc/japi-compliance-checker/issues/28","repository_url":"https://api.github.com/repos/lvc/japi-compliance-checker","labels_url":"https://api.github.com/repos/lvc/japi-compliance-checker/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/lvc/japi-compliance-checker/issues/28/comments","events_url":"https://api.github.com/repos/lvc/japi-compliance-checker/issues/28/events","html_url":"https://github.com/lvc/japi-compliance-checker/issues/28","id":162829502,"number":28,"title":"Annotations list isn't working","user":{"login":"dimaspivak","id":6088908,"avatar_url":"https://avatars.githubusercontent.com/u/6088908?v=3","gravatar_id":"","url":"https://api.github.com/users/dimaspivak","html_url":"https://github.com/dimaspivak","followers_url":"https://api.github.com/users/dimaspivak/followers","following_url":"https://api.github.com/users/dimaspivak/following{/other_user}","gists_url":"https://api.github.com/users/dimaspivak/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaspivak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaspivak/subscriptions","organizations_url":"https://api.github.com/users/dimaspivak/orgs","repos_url":"https://api.github.com/users/dimaspivak/repos","events_url":"https://api.github.com/users/dimaspivak/events{/privacy}","received_events_url":"https://api.github.com/users/dimaspivak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-29T02:43:35Z","updated_at":"2016-06-29T05:59:38Z","closed_at":null,"body":"Sometime since v1.4.3 of this tool, support for listing annotations to analyze appears to have broken. To repro, checkout the master branch of the tool and then do as follows:\r\n* Pull down two JARs. As an example, try [hbase-server v1.1.3](http://search.maven.org/remotecontent?filepath=org/apache/hbase/hbase-server/1.1.3/hbase-server-1.1.3.jar) and [hbase-server v.1.2.0](http://search.maven.org/remotecontent?filepath=org/apache/hbase/hbase-server/1.2.0/hbase-server-1.2.0.jar).\r\n* Run the tool between the two JARs. Verify that methods and classes are properly read.\r\n* Now populate an annotations file. I create one that limits to Public and LimitedPrivate interfaces:\r\n```\r\ndspivak-MBP:javaACC dspivak$ cat list\r\nInterfaceAudience.Public\r\nInterfaceAudience.LimitedPrivate\r\n```\r\n* Re-run the tool, specifying -annotations-list to point to the file. On my machine:\r\n```\r\nperl japi-compliance-checker.pl -annotations-list list /Users/dspivak/Desktop/hbase-server-1.1.3.jar /Users/dspivak/Desktop/hbase-server-1.2.1.jar \r\n```\r\n* The report generated shows that no methods or classes were read."},"comment":{"url":"https://api.github.com/repos/lvc/japi-compliance-checker/issues/comments/229264035","html_url":"https://github.com/lvc/japi-compliance-checker/issues/28#issuecomment-229264035","issue_url":"https://api.github.com/repos/lvc/japi-compliance-checker/issues/28","id":229264035,"user":{"login":"dimaspivak","id":6088908,"avatar_url":"https://avatars.githubusercontent.com/u/6088908?v=3","gravatar_id":"","url":"https://api.github.com/users/dimaspivak","html_url":"https://github.com/dimaspivak","followers_url":"https://api.github.com/users/dimaspivak/followers","following_url":"https://api.github.com/users/dimaspivak/following{/other_user}","gists_url":"https://api.github.com/users/dimaspivak/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaspivak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaspivak/subscriptions","organizations_url":"https://api.github.com/users/dimaspivak/orgs","repos_url":"https://api.github.com/users/dimaspivak/repos","events_url":"https://api.github.com/users/dimaspivak/events{/privacy}","received_events_url":"https://api.github.com/users/dimaspivak/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T05:59:38Z","updated_at":"2016-06-29T05:59:38Z","body":"Ooh, that did it! :) I guess the convention for needing to put the canonical name of the annotation changed with that commit? Feel free to close. Thanks as always, Andrey."}}
{"actor":{"display_login":"dimaspivak"}}