{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/homebrew/issues/49259","repository_url":"https://api.github.com/repos/Homebrew/homebrew","labels_url":"https://api.github.com/repos/Homebrew/homebrew/issues/49259/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/49259/comments","events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/49259/events","html_url":"https://github.com/Homebrew/homebrew/pull/49259","id":134322696,"number":49259,"title":"cfssl: update godeps, fix head build, and rename mkbundle","user":{"login":"3van","id":643978,"avatar_url":"https://avatars.githubusercontent.com/u/643978?v=3","gravatar_id":"","url":"https://api.github.com/users/3van","html_url":"https://github.com/3van","followers_url":"https://api.github.com/users/3van/followers","following_url":"https://api.github.com/users/3van/following{/other_user}","gists_url":"https://api.github.com/users/3van/gists{/gist_id}","starred_url":"https://api.github.com/users/3van/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3van/subscriptions","organizations_url":"https://api.github.com/users/3van/orgs","repos_url":"https://api.github.com/users/3van/repos","events_url":"https://api.github.com/users/3van/events{/privacy}","received_events_url":"https://api.github.com/users/3van/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-17T16:05:15Z","updated_at":"2016-02-17T16:16:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/49259","html_url":"https://github.com/Homebrew/homebrew/pull/49259","diff_url":"https://github.com/Homebrew/homebrew/pull/49259.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/49259.patch"},"body":"A few things:\r\n- HEAD wouldn't build due to a bunch of missing Godeps. So those all got added. As part of this:\r\n  - Updated some of the Godeps to the revisions in HEAD: `GeertJohan/go.rice` (not really used), `cloudflare/cf-tls`, `miekg/pkcs11`, and `kardianos/osext`. v1.1.0 was released last year, and there are some important fixes in `cf-tls` especially. I ran the whole test suite against the v1.1.0 sources built with the newer deps and everything passed. It'd start getting really messy if we had to maintain separate resources for release and head builds.\r\n  - `coreos/go-systemd` (lolwat) and `dgryski/go-rc2` are missing from the vendored Godeps so they went away somewhere between the v1.1.0 tag and then. Keep them around for posterity; it can't hurt.\r\n  - changed `crypto` to go get from the offical repos instead of the GitHub mirror.\r\n- There are a bunch of new commands that get built by default in HEAD: `cfssl-bundle`, `cfssl-certinfo`, `cfssl-newkey`, and `cfssl-scan`. I thought about building them too, but they replicate their respective subcommands in the main `cfssl` binary and just add about 8 MB *each* to the build.\r\n- Following that same supposed naming convention, I renamed `mkbundle` to `cfssl-mkbundle` since there's already a `mkbundle` in the [mono](Library/Formula/mono.rb) formula (and I suspect probably others too)."},"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/185279101","html_url":"https://github.com/Homebrew/homebrew/pull/49259#issuecomment-185279101","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/49259","id":185279101,"user":{"login":"3van","id":643978,"avatar_url":"https://avatars.githubusercontent.com/u/643978?v=3","gravatar_id":"","url":"https://api.github.com/users/3van","html_url":"https://github.com/3van","followers_url":"https://api.github.com/users/3van/followers","following_url":"https://api.github.com/users/3van/following{/other_user}","gists_url":"https://api.github.com/users/3van/gists{/gist_id}","starred_url":"https://api.github.com/users/3van/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3van/subscriptions","organizations_url":"https://api.github.com/users/3van/orgs","repos_url":"https://api.github.com/users/3van/repos","events_url":"https://api.github.com/users/3van/events{/privacy}","received_events_url":"https://api.github.com/users/3van/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T16:16:27Z","updated_at":"2016-02-17T16:16:27Z","body":"Also, in that same vein, it seems like there'd be a lot of utility in parsing the Godeps as part of the formula execution instead of generating resource blocks with go-resources and sticking them in manually. Maybe have it opportunistically look for Godeps, merge anything it finds with the ones explicitly defined in the formula (with the formula definitions taking precedence), and then go get everything.\r\n\r\nIf that sounds somewhat reasonable, I'll whip something up to do that when I get a chance next."}}