{"action":"created","comment":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/comments/90165644","pull_request_review_id":10688390,"id":90165644,"diff_hunk":"@@ -62,9 +63,28 @@ module.exports.Component = registerComponent('hand-controls', {\n     if (hand === 'left') {\n       modelUrl = 'url(' + LEFT_HAND_MODEL_URL + ')';\n     } else {\n+      // NOTE: in theory some controllers may not only 'left' or 'right'\n+      // ... but as we only have two models, here we will use right hand\n       modelUrl = 'url(' + RIGHT_HAND_MODEL_URL + ')';\n     }\n-    el.setAttribute('vive-controls', {hand: hand, model: false});\n+/*\n+    el.setAttribute('auto-detect-controllers', {\n+      hand: hand,\n+      model: false,\n+      rotationOffset: hand === 'left' ? 90 : -90\n+    });\n+*/\n+    el.setAttribute('vive-controls', {","path":"src/components/hand-controls.js","position":26,"original_position":26,"commit_id":"6c9600f0591ad5ad395fa5700d8560de444adbd2","original_commit_id":"6c9600f0591ad5ad395fa5700d8560de444adbd2","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"body":"We can create an object `controlConfiguration` and do:\r\n````javascript\r\nel.setAttribute('vive-controls'controlConfiguration);\r\nel.setAttribute('oculus-touch-controls', controlConfiguration);\r\n````","created_at":"2016-11-30T04:07:36Z","updated_at":"2016-11-30T04:07:36Z","html_url":"https://github.com/aframevr/aframe/pull/2132#discussion_r90165644","pull_request_url":"https://api.github.com/repos/aframevr/aframe/pulls/2132","_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments/90165644"},"html":{"href":"https://github.com/aframevr/aframe/pull/2132#discussion_r90165644"},"pull_request":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2132"}}},"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/2132","id":95053762,"html_url":"https://github.com/aframevr/aframe/pull/2132","diff_url":"https://github.com/aframevr/aframe/pull/2132.diff","patch_url":"https://github.com/aframevr/aframe/pull/2132.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/2132","number":2132,"state":"open","locked":false,"title":"Refactor hand controls","user":{"login":"machenmusik","id":2080738,"avatar_url":"https://avatars.githubusercontent.com/u/2080738?v=3","gravatar_id":"","url":"https://api.github.com/users/machenmusik","html_url":"https://github.com/machenmusik","followers_url":"https://api.github.com/users/machenmusik/followers","following_url":"https://api.github.com/users/machenmusik/following{/other_user}","gists_url":"https://api.github.com/users/machenmusik/gists{/gist_id}","starred_url":"https://api.github.com/users/machenmusik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machenmusik/subscriptions","organizations_url":"https://api.github.com/users/machenmusik/orgs","repos_url":"https://api.github.com/users/machenmusik/repos","events_url":"https://api.github.com/users/machenmusik/events{/privacy}","received_events_url":"https://api.github.com/users/machenmusik/received_events","type":"User","site_admin":false},"body":"refactor hand-controls per discussion on https://github.com/aframevr/aframe/pull/2124","created_at":"2016-11-23T18:05:35Z","updated_at":"2016-11-30T04:07:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d837cd0478bb9e623ffd8a7df8f9e06caf7940f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/2132/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/2132/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/2132/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/6c9600f0591ad5ad395fa5700d8560de444adbd2","head":{"label":"chenzlabs:refactor-hand-controls","ref":"refactor-hand-controls","sha":"6c9600f0591ad5ad395fa5700d8560de444adbd2","user":{"login":"chenzlabs","id":11540216,"avatar_url":"https://avatars.githubusercontent.com/u/11540216?v=3","gravatar_id":"","url":"https://api.github.com/users/chenzlabs","html_url":"https://github.com/chenzlabs","followers_url":"https://api.github.com/users/chenzlabs/followers","following_url":"https://api.github.com/users/chenzlabs/following{/other_user}","gists_url":"https://api.github.com/users/chenzlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/chenzlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenzlabs/subscriptions","organizations_url":"https://api.github.com/users/chenzlabs/orgs","repos_url":"https://api.github.com/users/chenzlabs/repos","events_url":"https://api.github.com/users/chenzlabs/events{/privacy}","received_events_url":"https://api.github.com/users/chenzlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":74418613,"name":"aframe","full_name":"chenzlabs/aframe","owner":{"login":"chenzlabs","id":11540216,"avatar_url":"https://avatars.githubusercontent.com/u/11540216?v=3","gravatar_id":"","url":"https://api.github.com/users/chenzlabs","html_url":"https://github.com/chenzlabs","followers_url":"https://api.github.com/users/chenzlabs/followers","following_url":"https://api.github.com/users/chenzlabs/following{/other_user}","gists_url":"https://api.github.com/users/chenzlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/chenzlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenzlabs/subscriptions","organizations_url":"https://api.github.com/users/chenzlabs/orgs","repos_url":"https://api.github.com/users/chenzlabs/repos","events_url":"https://api.github.com/users/chenzlabs/events{/privacy}","received_events_url":"https://api.github.com/users/chenzlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chenzlabs/aframe","description":"A web framework for building virtual reality experiences.","fork":true,"url":"https://api.github.com/repos/chenzlabs/aframe","forks_url":"https://api.github.com/repos/chenzlabs/aframe/forks","keys_url":"https://api.github.com/repos/chenzlabs/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenzlabs/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenzlabs/aframe/teams","hooks_url":"https://api.github.com/repos/chenzlabs/aframe/hooks","issue_events_url":"https://api.github.com/repos/chenzlabs/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/chenzlabs/aframe/events","assignees_url":"https://api.github.com/repos/chenzlabs/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/chenzlabs/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/chenzlabs/aframe/tags","blobs_url":"https://api.github.com/repos/chenzlabs/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenzlabs/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenzlabs/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenzlabs/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenzlabs/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/chenzlabs/aframe/languages","stargazers_url":"https://api.github.com/repos/chenzlabs/aframe/stargazers","contributors_url":"https://api.github.com/repos/chenzlabs/aframe/contributors","subscribers_url":"https://api.github.com/repos/chenzlabs/aframe/subscribers","subscription_url":"https://api.github.com/repos/chenzlabs/aframe/subscription","commits_url":"https://api.github.com/repos/chenzlabs/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenzlabs/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenzlabs/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenzlabs/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenzlabs/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/chenzlabs/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenzlabs/aframe/merges","archive_url":"https://api.github.com/repos/chenzlabs/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenzlabs/aframe/downloads","issues_url":"https://api.github.com/repos/chenzlabs/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/chenzlabs/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/chenzlabs/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/chenzlabs/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenzlabs/aframe/labels{/name}","releases_url":"https://api.github.com/repos/chenzlabs/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/chenzlabs/aframe/deployments","created_at":"2016-11-22T00:35:28Z","updated_at":"2016-11-22T00:35:29Z","pushed_at":"2016-11-29T18:49:48Z","git_url":"git://github.com/chenzlabs/aframe.git","ssh_url":"git@github.com:chenzlabs/aframe.git","clone_url":"https://github.com/chenzlabs/aframe.git","svn_url":"https://github.com/chenzlabs/aframe","homepage":"https://aframe.io/","size":143007,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"be87d38cf97c23a5fedc0552371be247ea2521b7","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"A web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-11-30T01:29:32Z","pushed_at":"2016-11-29T23:30:54Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":154806,"stargazers_count":4042,"watchers_count":4042,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":803,"mirror_url":null,"open_issues_count":215,"forks":803,"open_issues":215,"watchers":4042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2132"},"html":{"href":"https://github.com/aframevr/aframe/pull/2132"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/2132"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/2132/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2132/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/2132/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/6c9600f0591ad5ad395fa5700d8560de444adbd2"}}}}
{"actor":{"display_login":"dmarcos"}}