{"action":"created","comment":{"url":"https://api.github.com/repos/chef/knife-ec2/pulls/comments/73718295","id":73718295,"diff_hunk":"@@ -2113,5 +2112,39 @@\n         end\n       end\n     end\n+\n+    describe \"--security-group-ids option\" do\n+      before do\n+        allow(Fog::Compute::AWS).to receive(:new).and_return(@ec2_connection)\n+      end\n+\n+      context \"when invalid input is given for --security-group-ids from cli\" do\n+        it \"raises error\" do\n+          @knife_ec2_create.config[:security_group_ids] = 'sg-aabbccdd; sg-3764sdss ; sg-00aa11bb'\n+          expect { @knife_ec2_create.validate! }.to raise_error(SystemExit)\n+        end\n+      end\n+\n+      context \"when valid input is given --security-group-ids from cli\" do\n+        it \"does not raise error\" do\n+          @knife_ec2_create.config[:security_group_ids] = 'sg-aabbccdd, sg-3764sdss, sg-00aa11bb'\n+          expect { @knife_ec2_create.validate! }.to_not raise_error\n+        end\n+      end\n+\n+      context \"when invalid input is given for --security-group-ids from knife.rb\" do","path":"spec/unit/ec2_server_create_spec.rb","position":45,"original_position":45,"commit_id":"6158d26e0dab7a39d2f49b52e1a78fd231fd0031","original_commit_id":"6158d26e0dab7a39d2f49b52e1a78fd231fd0031","user":{"login":"btm","id":4381,"avatar_url":"https://avatars.githubusercontent.com/u/4381?v=3","gravatar_id":"","url":"https://api.github.com/users/btm","html_url":"https://github.com/btm","followers_url":"https://api.github.com/users/btm/followers","following_url":"https://api.github.com/users/btm/following{/other_user}","gists_url":"https://api.github.com/users/btm/gists{/gist_id}","starred_url":"https://api.github.com/users/btm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btm/subscriptions","organizations_url":"https://api.github.com/users/btm/orgs","repos_url":"https://api.github.com/users/btm/repos","events_url":"https://api.github.com/users/btm/events{/privacy}","received_events_url":"https://api.github.com/users/btm/received_events","type":"User","site_admin":false},"body":"I understand that from the CLI, I wouldn't add array support for the CLI. But using an array would be pretty natural from inside the `knife.rb`.","created_at":"2016-08-05T16:10:41Z","updated_at":"2016-08-05T16:10:41Z","html_url":"https://github.com/chef/knife-ec2/pull/439#discussion_r73718295","pull_request_url":"https://api.github.com/repos/chef/knife-ec2/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/comments/73718295"},"html":{"href":"https://github.com/chef/knife-ec2/pull/439#discussion_r73718295"},"pull_request":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/439"}}},"pull_request":{"url":"https://api.github.com/repos/chef/knife-ec2/pulls/439","id":79703004,"html_url":"https://github.com/chef/knife-ec2/pull/439","diff_url":"https://github.com/chef/knife-ec2/pull/439.diff","patch_url":"https://github.com/chef/knife-ec2/pull/439.patch","issue_url":"https://api.github.com/repos/chef/knife-ec2/issues/439","number":439,"state":"open","locked":false,"title":"Allowed to accpet comma seprated values with spaces and Added validation for --secruity-group-ids","user":{"login":"Vasu1105","id":4181545,"avatar_url":"https://avatars.githubusercontent.com/u/4181545?v=3","gravatar_id":"","url":"https://api.github.com/users/Vasu1105","html_url":"https://github.com/Vasu1105","followers_url":"https://api.github.com/users/Vasu1105/followers","following_url":"https://api.github.com/users/Vasu1105/following{/other_user}","gists_url":"https://api.github.com/users/Vasu1105/gists{/gist_id}","starred_url":"https://api.github.com/users/Vasu1105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vasu1105/subscriptions","organizations_url":"https://api.github.com/users/Vasu1105/orgs","repos_url":"https://api.github.com/users/Vasu1105/repos","events_url":"https://api.github.com/users/Vasu1105/events{/privacy}","received_events_url":"https://api.github.com/users/Vasu1105/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-02T09:29:39Z","updated_at":"2016-08-05T16:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d7c685bf6e7cbeb77759d4081198fe4db58b917","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/knife-ec2/pulls/439/commits","review_comments_url":"https://api.github.com/repos/chef/knife-ec2/pulls/439/comments","review_comment_url":"https://api.github.com/repos/chef/knife-ec2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/knife-ec2/issues/439/comments","statuses_url":"https://api.github.com/repos/chef/knife-ec2/statuses/6158d26e0dab7a39d2f49b52e1a78fd231fd0031","head":{"label":"MsysTechnologiesllc:vj/security_group_ids_fix","ref":"vj/security_group_ids_fix","sha":"6158d26e0dab7a39d2f49b52e1a78fd231fd0031","user":{"login":"MsysTechnologiesllc","id":2493241,"avatar_url":"https://avatars.githubusercontent.com/u/2493241?v=3","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"repo":{"id":6089171,"name":"knife-ec2","full_name":"MsysTechnologiesllc/knife-ec2","owner":{"login":"MsysTechnologiesllc","id":2493241,"avatar_url":"https://avatars.githubusercontent.com/u/2493241?v=3","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MsysTechnologiesllc/knife-ec2","description":"Opscode Chef knife plug-in for EC2","fork":true,"url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2","forks_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/forks","keys_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/teams","hooks_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/hooks","issue_events_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/issues/events{/number}","events_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/events","assignees_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/assignees{/user}","branches_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/branches{/branch}","tags_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/tags","blobs_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/refs{/sha}","trees_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/statuses/{sha}","languages_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/languages","stargazers_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/stargazers","contributors_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/contributors","subscribers_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/subscribers","subscription_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/subscription","commits_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/commits{/sha}","git_commits_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/git/commits{/sha}","comments_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/comments{/number}","issue_comment_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/issues/comments{/number}","contents_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/contents/{+path}","compare_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/merges","archive_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/downloads","issues_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/issues{/number}","pulls_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/pulls{/number}","milestones_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/milestones{/number}","notifications_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/labels{/name}","releases_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/releases{/id}","deployments_url":"https://api.github.com/repos/MsysTechnologiesllc/knife-ec2/deployments","created_at":"2012-10-05T11:05:57Z","updated_at":"2015-02-20T13:35:01Z","pushed_at":"2016-08-03T06:12:39Z","git_url":"git://github.com/MsysTechnologiesllc/knife-ec2.git","ssh_url":"git@github.com:MsysTechnologiesllc/knife-ec2.git","clone_url":"https://github.com/MsysTechnologiesllc/knife-ec2.git","svn_url":"https://github.com/MsysTechnologiesllc/knife-ec2","homepage":"","size":1022,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"0db4abbe4e8715ae53862b00a7fdc0499ab19ef9","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":1452458,"name":"knife-ec2","full_name":"chef/knife-ec2","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/knife-ec2","description":"Chef knife plug-in for AWS EC2","fork":false,"url":"https://api.github.com/repos/chef/knife-ec2","forks_url":"https://api.github.com/repos/chef/knife-ec2/forks","keys_url":"https://api.github.com/repos/chef/knife-ec2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/knife-ec2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/knife-ec2/teams","hooks_url":"https://api.github.com/repos/chef/knife-ec2/hooks","issue_events_url":"https://api.github.com/repos/chef/knife-ec2/issues/events{/number}","events_url":"https://api.github.com/repos/chef/knife-ec2/events","assignees_url":"https://api.github.com/repos/chef/knife-ec2/assignees{/user}","branches_url":"https://api.github.com/repos/chef/knife-ec2/branches{/branch}","tags_url":"https://api.github.com/repos/chef/knife-ec2/tags","blobs_url":"https://api.github.com/repos/chef/knife-ec2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/knife-ec2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/knife-ec2/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/knife-ec2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/knife-ec2/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/knife-ec2/languages","stargazers_url":"https://api.github.com/repos/chef/knife-ec2/stargazers","contributors_url":"https://api.github.com/repos/chef/knife-ec2/contributors","subscribers_url":"https://api.github.com/repos/chef/knife-ec2/subscribers","subscription_url":"https://api.github.com/repos/chef/knife-ec2/subscription","commits_url":"https://api.github.com/repos/chef/knife-ec2/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/knife-ec2/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/knife-ec2/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/knife-ec2/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/knife-ec2/contents/{+path}","compare_url":"https://api.github.com/repos/chef/knife-ec2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/knife-ec2/merges","archive_url":"https://api.github.com/repos/chef/knife-ec2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/knife-ec2/downloads","issues_url":"https://api.github.com/repos/chef/knife-ec2/issues{/number}","pulls_url":"https://api.github.com/repos/chef/knife-ec2/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/knife-ec2/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/knife-ec2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/knife-ec2/labels{/name}","releases_url":"https://api.github.com/repos/chef/knife-ec2/releases{/id}","deployments_url":"https://api.github.com/repos/chef/knife-ec2/deployments","created_at":"2011-03-07T23:26:53Z","updated_at":"2016-07-27T16:51:45Z","pushed_at":"2016-08-05T15:34:39Z","git_url":"git://github.com/chef/knife-ec2.git","ssh_url":"git@github.com:chef/knife-ec2.git","clone_url":"https://github.com/chef/knife-ec2.git","svn_url":"https://github.com/chef/knife-ec2","homepage":"","size":1667,"stargazers_count":379,"watchers_count":379,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":326,"mirror_url":null,"open_issues_count":40,"forks":326,"open_issues":40,"watchers":379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/439"},"html":{"href":"https://github.com/chef/knife-ec2/pull/439"},"issue":{"href":"https://api.github.com/repos/chef/knife-ec2/issues/439"},"comments":{"href":"https://api.github.com/repos/chef/knife-ec2/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/knife-ec2/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/chef/knife-ec2/statuses/6158d26e0dab7a39d2f49b52e1a78fd231fd0031"}}}}
{"actor":{"display_login":"btm"}}