{"action":"created","issue":{"url":"https://api.github.com/repos/dblock/oshi/issues/194","repository_url":"https://api.github.com/repos/dblock/oshi","labels_url":"https://api.github.com/repos/dblock/oshi/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/dblock/oshi/issues/194/comments","events_url":"https://api.github.com/repos/dblock/oshi/issues/194/events","html_url":"https://github.com/dblock/oshi/pull/194","id":159852832,"number":194,"title":"Enhanced file system store","user":{"login":"henryx","id":1316723,"avatar_url":"https://avatars.githubusercontent.com/u/1316723?v=3","gravatar_id":"","url":"https://api.github.com/users/henryx","html_url":"https://github.com/henryx","followers_url":"https://api.github.com/users/henryx/followers","following_url":"https://api.github.com/users/henryx/following{/other_user}","gists_url":"https://api.github.com/users/henryx/gists{/gist_id}","starred_url":"https://api.github.com/users/henryx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryx/subscriptions","organizations_url":"https://api.github.com/users/henryx/orgs","repos_url":"https://api.github.com/users/henryx/repos","events_url":"https://api.github.com/users/henryx/events{/privacy}","received_events_url":"https://api.github.com/users/henryx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-12T22:54:11Z","updated_at":"2016-06-13T16:47:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dblock/oshi/pulls/194","html_url":"https://github.com/dblock/oshi/pull/194","diff_url":"https://github.com/dblock/oshi/pull/194.diff","patch_url":"https://github.com/dblock/oshi/pull/194.patch"},"body":"First of all: I've added a volume property in `OSFilestore` object, because it can permit an association of current file system evaluated (value for now is enabled only for Windows and Linux).\r\nSecond: I've rewritten the `LinuxFileSystem.getFileStores()` method, now uses `/proc/self/mounts/` for evaluation.\r\nThird: I've reviewed check of pseudo file systems"},"comment":{"url":"https://api.github.com/repos/dblock/oshi/issues/comments/225639747","html_url":"https://github.com/dblock/oshi/pull/194#issuecomment-225639747","issue_url":"https://api.github.com/repos/dblock/oshi/issues/194","id":225639747,"user":{"login":"dbwiddis","id":9291703,"avatar_url":"https://avatars.githubusercontent.com/u/9291703?v=3","gravatar_id":"","url":"https://api.github.com/users/dbwiddis","html_url":"https://github.com/dbwiddis","followers_url":"https://api.github.com/users/dbwiddis/followers","following_url":"https://api.github.com/users/dbwiddis/following{/other_user}","gists_url":"https://api.github.com/users/dbwiddis/gists{/gist_id}","starred_url":"https://api.github.com/users/dbwiddis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbwiddis/subscriptions","organizations_url":"https://api.github.com/users/dbwiddis/orgs","repos_url":"https://api.github.com/users/dbwiddis/repos","events_url":"https://api.github.com/users/dbwiddis/events{/privacy}","received_events_url":"https://api.github.com/users/dbwiddis/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T16:47:50Z","updated_at":"2016-06-13T16:47:50Z","body":"You are still using exactly the same name as volume on Linux so I'm missing the benefit of adding this volume information which appears to be Windows only, with the only new information being provided is essentially the Volume UUID (all mounted devices on Windows will have a volume name of `\\\\?\\Volume{UUID goes here}\\`\r\n\r\nSo how about instead of a new volume field, we have a UUID field?  This is accessible on Linux (follow symlinks from `/dev/disk/by-uuid`) and OS X (in the IOKit registry accessible a few different ways).  \r\n\r\nI see you made the changes to escaping and / drive, but are you intentionally keeping rootfs?"}}
{"actor":{"display_login":"dbwiddis"}}