{"action":"closed","number":14695,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/14695","id":97206236,"html_url":"https://github.com/emberjs/ember.js/pull/14695","diff_url":"https://github.com/emberjs/ember.js/pull/14695.diff","patch_url":"https://github.com/emberjs/ember.js/pull/14695.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/14695","number":14695,"state":"closed","locked":false,"title":"[DOC] Simplify example for Ember.Route.modelFor","user":{"login":"HeroicEric","id":602204,"avatar_url":"https://avatars.githubusercontent.com/u/602204?v=3","gravatar_id":"","url":"https://api.github.com/users/HeroicEric","html_url":"https://github.com/HeroicEric","followers_url":"https://api.github.com/users/HeroicEric/followers","following_url":"https://api.github.com/users/HeroicEric/following{/other_user}","gists_url":"https://api.github.com/users/HeroicEric/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroicEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroicEric/subscriptions","organizations_url":"https://api.github.com/users/HeroicEric/orgs","repos_url":"https://api.github.com/users/HeroicEric/repos","events_url":"https://api.github.com/users/HeroicEric/events{/privacy}","received_events_url":"https://api.github.com/users/HeroicEric/received_events","type":"User","site_admin":false},"body":"Some updates for the example for `Ember.Route.modelFor`\r\n\r\n- Fixes indentation\r\n- Removes unnecessary `resetNamespace`\r\n- Updates example to avoid setting state on the route","created_at":"2016-12-08T21:40:30Z","updated_at":"2016-12-09T09:14:41Z","closed_at":"2016-12-09T09:14:41Z","merged_at":"2016-12-09T09:14:41Z","merge_commit_sha":"3c8a666d69f6989acdae925e69d5ab24ac434128","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/14695/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/14695/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/14695/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/b0981b88c7525651c5fcae50f1b3d3ce24ca0e9e","head":{"label":"HeroicEric:fix-indentation","ref":"fix-indentation","sha":"b0981b88c7525651c5fcae50f1b3d3ce24ca0e9e","user":{"login":"HeroicEric","id":602204,"avatar_url":"https://avatars.githubusercontent.com/u/602204?v=3","gravatar_id":"","url":"https://api.github.com/users/HeroicEric","html_url":"https://github.com/HeroicEric","followers_url":"https://api.github.com/users/HeroicEric/followers","following_url":"https://api.github.com/users/HeroicEric/following{/other_user}","gists_url":"https://api.github.com/users/HeroicEric/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroicEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroicEric/subscriptions","organizations_url":"https://api.github.com/users/HeroicEric/orgs","repos_url":"https://api.github.com/users/HeroicEric/repos","events_url":"https://api.github.com/users/HeroicEric/events{/privacy}","received_events_url":"https://api.github.com/users/HeroicEric/received_events","type":"User","site_admin":false},"repo":{"id":7848831,"name":"ember.js","full_name":"HeroicEric/ember.js","owner":{"login":"HeroicEric","id":602204,"avatar_url":"https://avatars.githubusercontent.com/u/602204?v=3","gravatar_id":"","url":"https://api.github.com/users/HeroicEric","html_url":"https://github.com/HeroicEric","followers_url":"https://api.github.com/users/HeroicEric/followers","following_url":"https://api.github.com/users/HeroicEric/following{/other_user}","gists_url":"https://api.github.com/users/HeroicEric/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroicEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroicEric/subscriptions","organizations_url":"https://api.github.com/users/HeroicEric/orgs","repos_url":"https://api.github.com/users/HeroicEric/repos","events_url":"https://api.github.com/users/HeroicEric/events{/privacy}","received_events_url":"https://api.github.com/users/HeroicEric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HeroicEric/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/HeroicEric/ember.js","forks_url":"https://api.github.com/repos/HeroicEric/ember.js/forks","keys_url":"https://api.github.com/repos/HeroicEric/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HeroicEric/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HeroicEric/ember.js/teams","hooks_url":"https://api.github.com/repos/HeroicEric/ember.js/hooks","issue_events_url":"https://api.github.com/repos/HeroicEric/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/HeroicEric/ember.js/events","assignees_url":"https://api.github.com/repos/HeroicEric/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/HeroicEric/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/HeroicEric/ember.js/tags","blobs_url":"https://api.github.com/repos/HeroicEric/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HeroicEric/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HeroicEric/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/HeroicEric/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HeroicEric/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/HeroicEric/ember.js/languages","stargazers_url":"https://api.github.com/repos/HeroicEric/ember.js/stargazers","contributors_url":"https://api.github.com/repos/HeroicEric/ember.js/contributors","subscribers_url":"https://api.github.com/repos/HeroicEric/ember.js/subscribers","subscription_url":"https://api.github.com/repos/HeroicEric/ember.js/subscription","commits_url":"https://api.github.com/repos/HeroicEric/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/HeroicEric/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/HeroicEric/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/HeroicEric/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/HeroicEric/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/HeroicEric/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HeroicEric/ember.js/merges","archive_url":"https://api.github.com/repos/HeroicEric/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HeroicEric/ember.js/downloads","issues_url":"https://api.github.com/repos/HeroicEric/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/HeroicEric/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/HeroicEric/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/HeroicEric/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HeroicEric/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/HeroicEric/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/HeroicEric/ember.js/deployments","created_at":"2013-01-27T05:59:45Z","updated_at":"2015-03-30T19:35:13Z","pushed_at":"2016-12-08T23:34:06Z","git_url":"git://github.com/HeroicEric/ember.js.git","ssh_url":"git@github.com:HeroicEric/ember.js.git","clone_url":"https://github.com/HeroicEric/ember.js.git","svn_url":"https://github.com/HeroicEric/ember.js","homepage":"http://www.emberjs.com","size":36418,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"c662b6d1939e48e261169c360541e732fe613ebf","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-12-09T08:55:42Z","pushed_at":"2016-12-09T09:14:41Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":81587,"stargazers_count":17224,"watchers_count":17224,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3613,"mirror_url":null,"open_issues_count":256,"forks":3613,"open_issues":256,"watchers":17224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/14695"},"html":{"href":"https://github.com/emberjs/ember.js/pull/14695"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/14695"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/14695/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/14695/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/14695/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/b0981b88c7525651c5fcae50f1b3d3ce24ca0e9e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"locks","id":32344,"avatar_url":"https://avatars.githubusercontent.com/u/32344?v=3","gravatar_id":"","url":"https://api.github.com/users/locks","html_url":"https://github.com/locks","followers_url":"https://api.github.com/users/locks/followers","following_url":"https://api.github.com/users/locks/following{/other_user}","gists_url":"https://api.github.com/users/locks/gists{/gist_id}","starred_url":"https://api.github.com/users/locks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locks/subscriptions","organizations_url":"https://api.github.com/users/locks/orgs","repos_url":"https://api.github.com/users/locks/repos","events_url":"https://api.github.com/users/locks/events{/privacy}","received_events_url":"https://api.github.com/users/locks/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":7,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"locks"}}