{"action":"created","comment":{"url":"https://api.github.com/repos/greenqloud/cloudstack/pulls/comments/77812521","id":77812521,"diff_hunk":"@@ -0,0 +1,1035 @@\n+#!/usr/bin/python","path":"systemvm/patches/debian/config/opt/cloud/bin/#configure.py#","position":1,"original_position":1,"commit_id":"213607d29762119408658514d7bdced73f194bb1","original_commit_id":"213607d29762119408658514d7bdced73f194bb1","user":{"login":"HrWiggles","id":12530748,"avatar_url":"https://avatars.githubusercontent.com/u/12530748?v=3","gravatar_id":"","url":"https://api.github.com/users/HrWiggles","html_url":"https://github.com/HrWiggles","followers_url":"https://api.github.com/users/HrWiggles/followers","following_url":"https://api.github.com/users/HrWiggles/following{/other_user}","gists_url":"https://api.github.com/users/HrWiggles/gists{/gist_id}","starred_url":"https://api.github.com/users/HrWiggles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HrWiggles/subscriptions","organizations_url":"https://api.github.com/users/HrWiggles/orgs","repos_url":"https://api.github.com/users/HrWiggles/repos","events_url":"https://api.github.com/users/HrWiggles/events{/privacy}","received_events_url":"https://api.github.com/users/HrWiggles/received_events","type":"User","site_admin":false},"body":"What is this file? (i.e. #configure.py#)\r\nWas it supposed to be committed?\r\nIf so, how/where is it used?","created_at":"2016-09-07T12:35:51Z","updated_at":"2016-09-07T12:35:51Z","html_url":"https://github.com/greenqloud/cloudstack/pull/115#discussion_r77812521","pull_request_url":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/greenqloud/cloudstack/pulls/comments/77812521"},"html":{"href":"https://github.com/greenqloud/cloudstack/pull/115#discussion_r77812521"},"pull_request":{"href":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115","id":84286102,"html_url":"https://github.com/greenqloud/cloudstack/pull/115","diff_url":"https://github.com/greenqloud/cloudstack/pull/115.diff","patch_url":"https://github.com/greenqloud/cloudstack/pull/115.patch","issue_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/115","number":115,"state":"open","locked":false,"title":"GQSS-4559: Virtual router cleans up configurations for stopped VMs","user":{"login":"stefaniabergljot","id":5695872,"avatar_url":"https://avatars.githubusercontent.com/u/5695872?v=3","gravatar_id":"","url":"https://api.github.com/users/stefaniabergljot","html_url":"https://github.com/stefaniabergljot","followers_url":"https://api.github.com/users/stefaniabergljot/followers","following_url":"https://api.github.com/users/stefaniabergljot/following{/other_user}","gists_url":"https://api.github.com/users/stefaniabergljot/gists{/gist_id}","starred_url":"https://api.github.com/users/stefaniabergljot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefaniabergljot/subscriptions","organizations_url":"https://api.github.com/users/stefaniabergljot/orgs","repos_url":"https://api.github.com/users/stefaniabergljot/repos","events_url":"https://api.github.com/users/stefaniabergljot/events{/privacy}","received_events_url":"https://api.github.com/users/stefaniabergljot/received_events","type":"User","site_admin":false},"body":"When a NIC is released, a command is sent to the virtual router. The\r\ncommand removes the info on the VM's metadata and password from the\r\njson configuration files in the router, so the router does not spend\r\ntime processing configurations for instances that no longer exist.\r\n\r\nBefore, the VM metadata and password were written to the configuration\r\njson files in the virtual router but never removed. This caused the\r\nvirtual router to waste time processing configurations for VMs that no\r\nlonger exist, resulting in a linear increase in the time needed to\r\nprocess them as more instances were created and deleted.\r\n\r\nNow, when a VM is stopped its metadata and password are removed from\r\nthe configuration files. Therefore the router only processes\r\nconfigurations for instances that are running, so the time spent on it\r\nis constant.","created_at":"2016-09-07T11:53:51Z","updated_at":"2016-09-07T12:35:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08e3fe75845abace751824c02c088e3b02c4e034","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115/commits","review_comments_url":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115/comments","review_comment_url":"https://api.github.com/repos/greenqloud/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/115/comments","statuses_url":"https://api.github.com/repos/greenqloud/cloudstack/statuses/213607d29762119408658514d7bdced73f194bb1","head":{"label":"greenqloud:virtual-router-cleanup","ref":"virtual-router-cleanup","sha":"213607d29762119408658514d7bdced73f194bb1","user":{"login":"greenqloud","id":228758,"avatar_url":"https://avatars.githubusercontent.com/u/228758?v=3","gravatar_id":"","url":"https://api.github.com/users/greenqloud","html_url":"https://github.com/greenqloud","followers_url":"https://api.github.com/users/greenqloud/followers","following_url":"https://api.github.com/users/greenqloud/following{/other_user}","gists_url":"https://api.github.com/users/greenqloud/gists{/gist_id}","starred_url":"https://api.github.com/users/greenqloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenqloud/subscriptions","organizations_url":"https://api.github.com/users/greenqloud/orgs","repos_url":"https://api.github.com/users/greenqloud/repos","events_url":"https://api.github.com/users/greenqloud/events{/privacy}","received_events_url":"https://api.github.com/users/greenqloud/received_events","type":"Organization","site_admin":false},"repo":{"id":36817746,"name":"cloudstack","full_name":"greenqloud/cloudstack","owner":{"login":"greenqloud","id":228758,"avatar_url":"https://avatars.githubusercontent.com/u/228758?v=3","gravatar_id":"","url":"https://api.github.com/users/greenqloud","html_url":"https://github.com/greenqloud","followers_url":"https://api.github.com/users/greenqloud/followers","following_url":"https://api.github.com/users/greenqloud/following{/other_user}","gists_url":"https://api.github.com/users/greenqloud/gists{/gist_id}","starred_url":"https://api.github.com/users/greenqloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenqloud/subscriptions","organizations_url":"https://api.github.com/users/greenqloud/orgs","repos_url":"https://api.github.com/users/greenqloud/repos","events_url":"https://api.github.com/users/greenqloud/events{/privacy}","received_events_url":"https://api.github.com/users/greenqloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenqloud/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/greenqloud/cloudstack","forks_url":"https://api.github.com/repos/greenqloud/cloudstack/forks","keys_url":"https://api.github.com/repos/greenqloud/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenqloud/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenqloud/cloudstack/teams","hooks_url":"https://api.github.com/repos/greenqloud/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/greenqloud/cloudstack/events","assignees_url":"https://api.github.com/repos/greenqloud/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/greenqloud/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/greenqloud/cloudstack/tags","blobs_url":"https://api.github.com/repos/greenqloud/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenqloud/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenqloud/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenqloud/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenqloud/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/greenqloud/cloudstack/languages","stargazers_url":"https://api.github.com/repos/greenqloud/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/greenqloud/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/greenqloud/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/greenqloud/cloudstack/subscription","commits_url":"https://api.github.com/repos/greenqloud/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenqloud/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenqloud/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenqloud/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/greenqloud/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenqloud/cloudstack/merges","archive_url":"https://api.github.com/repos/greenqloud/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenqloud/cloudstack/downloads","issues_url":"https://api.github.com/repos/greenqloud/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/greenqloud/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/greenqloud/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/greenqloud/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenqloud/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/greenqloud/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/greenqloud/cloudstack/deployments","created_at":"2015-06-03T16:58:20Z","updated_at":"2016-08-19T14:55:26Z","pushed_at":"2016-09-07T11:53:51Z","git_url":"git://github.com/greenqloud/cloudstack.git","ssh_url":"git@github.com:greenqloud/cloudstack.git","clone_url":"https://github.com/greenqloud/cloudstack.git","svn_url":"https://github.com/greenqloud/cloudstack","homepage":null,"size":510756,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"greenqloud:development","ref":"development","sha":"054040f2962bf30faba20eec69b9aaa8333d5321","user":{"login":"greenqloud","id":228758,"avatar_url":"https://avatars.githubusercontent.com/u/228758?v=3","gravatar_id":"","url":"https://api.github.com/users/greenqloud","html_url":"https://github.com/greenqloud","followers_url":"https://api.github.com/users/greenqloud/followers","following_url":"https://api.github.com/users/greenqloud/following{/other_user}","gists_url":"https://api.github.com/users/greenqloud/gists{/gist_id}","starred_url":"https://api.github.com/users/greenqloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenqloud/subscriptions","organizations_url":"https://api.github.com/users/greenqloud/orgs","repos_url":"https://api.github.com/users/greenqloud/repos","events_url":"https://api.github.com/users/greenqloud/events{/privacy}","received_events_url":"https://api.github.com/users/greenqloud/received_events","type":"Organization","site_admin":false},"repo":{"id":36817746,"name":"cloudstack","full_name":"greenqloud/cloudstack","owner":{"login":"greenqloud","id":228758,"avatar_url":"https://avatars.githubusercontent.com/u/228758?v=3","gravatar_id":"","url":"https://api.github.com/users/greenqloud","html_url":"https://github.com/greenqloud","followers_url":"https://api.github.com/users/greenqloud/followers","following_url":"https://api.github.com/users/greenqloud/following{/other_user}","gists_url":"https://api.github.com/users/greenqloud/gists{/gist_id}","starred_url":"https://api.github.com/users/greenqloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenqloud/subscriptions","organizations_url":"https://api.github.com/users/greenqloud/orgs","repos_url":"https://api.github.com/users/greenqloud/repos","events_url":"https://api.github.com/users/greenqloud/events{/privacy}","received_events_url":"https://api.github.com/users/greenqloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenqloud/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/greenqloud/cloudstack","forks_url":"https://api.github.com/repos/greenqloud/cloudstack/forks","keys_url":"https://api.github.com/repos/greenqloud/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenqloud/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenqloud/cloudstack/teams","hooks_url":"https://api.github.com/repos/greenqloud/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/greenqloud/cloudstack/events","assignees_url":"https://api.github.com/repos/greenqloud/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/greenqloud/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/greenqloud/cloudstack/tags","blobs_url":"https://api.github.com/repos/greenqloud/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenqloud/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenqloud/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenqloud/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenqloud/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/greenqloud/cloudstack/languages","stargazers_url":"https://api.github.com/repos/greenqloud/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/greenqloud/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/greenqloud/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/greenqloud/cloudstack/subscription","commits_url":"https://api.github.com/repos/greenqloud/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenqloud/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenqloud/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenqloud/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/greenqloud/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenqloud/cloudstack/merges","archive_url":"https://api.github.com/repos/greenqloud/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenqloud/cloudstack/downloads","issues_url":"https://api.github.com/repos/greenqloud/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/greenqloud/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/greenqloud/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/greenqloud/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenqloud/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/greenqloud/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/greenqloud/cloudstack/deployments","created_at":"2015-06-03T16:58:20Z","updated_at":"2016-08-19T14:55:26Z","pushed_at":"2016-09-07T11:53:51Z","git_url":"git://github.com/greenqloud/cloudstack.git","ssh_url":"git@github.com:greenqloud/cloudstack.git","clone_url":"https://github.com/greenqloud/cloudstack.git","svn_url":"https://github.com/greenqloud/cloudstack","homepage":null,"size":510756,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115"},"html":{"href":"https://github.com/greenqloud/cloudstack/pull/115"},"issue":{"href":"https://api.github.com/repos/greenqloud/cloudstack/issues/115"},"comments":{"href":"https://api.github.com/repos/greenqloud/cloudstack/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/greenqloud/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenqloud/cloudstack/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/greenqloud/cloudstack/statuses/213607d29762119408658514d7bdced73f194bb1"}}}}
{"actor":{"display_login":"HrWiggles"}}