{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26049","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26049/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26049/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26049/events","html_url":"https://github.com/kubernetes/kubernetes/pull/26049","id":156199491,"number":26049,"title":"AWS Route53 dnsprovider","user":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/cluster-federation","name":"area/cluster-federation","color":"fad8c7"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/platform/aws","name":"area/platform/aws","color":"d4c5f9"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P1","name":"priority/P1","color":"eb6420"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/control-plane","name":"team/control-plane","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":159,"closed_issues":378,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-06-01T16:42:45Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"comments":7,"created_at":"2016-05-23T04:51:19Z","updated_at":"2016-06-01T17:44:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26049","html_url":"https://github.com/kubernetes/kubernetes/pull/26049","diff_url":"https://github.com/kubernetes/kubernetes/pull/26049.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26049.patch"},"body":"Still needs unit tests, and some other cleanup.  Review not urgent, but feel free to make a first pass.\r\nOnly need to look at the last two commits.  The prior commits will go in as #26020. This will need to be rebased against #26020 once that merges.\r\n \r\nIt's a bare minimum implementation, only what's required for Ubernetes Federated Services (managing basic A and CNAME records).  More functionality (health checks, geolocation etc) can be fairly easily added as required.\r\n\r\nIt also requires github.com/aws/aws-sdk-go/service/route53 to be vendored into godeps, which I haven't managed to do successfully yet (Oh Godep!)\r\n\r\ncc: @justinsb FYI"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/223070271","html_url":"https://github.com/kubernetes/kubernetes/pull/26049#issuecomment-223070271","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26049","id":223070271,"user":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T17:44:11Z","updated_at":"2016-06-01T17:44:11Z","body":"Similar gofmt error to one I saw in one of my other PR's #25991.  I must have an incompatible version of gfmt on my local machine or something.  Pity that gofmt refuses to tell us what version it is :-)\r\n\r\n```\r\n./federation/pkg/dnsprovider/providers/aws/route53/rrsets.go\r\nFAILED   ./hack/../hack/verify-gofmt.sh\t17s\r\n```\r\n\r\n```\r\n which gofmt\r\n/usr/local/go/bin/gofmt\r\n$ which go\r\n/usr/local/go/bin/go\r\n$ go version\r\ngo version go1.6 darwin/amd64\r\n$ gofmt --version\r\nflag provided but not defined: -version\r\nusage: gofmt [flags] [path ...]\r\n  -cpuprofile string\r\n    \twrite cpu profile to this file\r\n  -d\tdisplay diffs instead of rewriting files\r\n  -e\treport all errors (not just the first 10 on different lines)\r\n  -l\tlist files whose formatting differs from gofmt's\r\n  -r string\r\n    \trewrite rule (e.g., 'a[b:len(a)] -> a[b:]')\r\n  -s\tsimplify code\r\n  -w\twrite result to (source) file instead of stdout\r\n```\r\n "}}
{"actor":{"display_login":"quinton-hoole"}}