{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/1033","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033/events","html_url":"https://github.com/triplea-game/triplea/issues/1033","id":169444214,"number":1033,"title":"Map XML Changes/Deletions Request","user":{"login":"Cernelius","id":19562310,"avatar_url":"https://avatars.githubusercontent.com/u/19562310?v=3","gravatar_id":"","url":"https://api.github.com/users/Cernelius","html_url":"https://github.com/Cernelius","followers_url":"https://api.github.com/users/Cernelius/followers","following_url":"https://api.github.com/users/Cernelius/following{/other_user}","gists_url":"https://api.github.com/users/Cernelius/gists{/gist_id}","starred_url":"https://api.github.com/users/Cernelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cernelius/subscriptions","organizations_url":"https://api.github.com/users/Cernelius/orgs","repos_url":"https://api.github.com/users/Cernelius/repos","events_url":"https://api.github.com/users/Cernelius/events{/privacy}","received_events_url":"https://api.github.com/users/Cernelius/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/triplea-game/triplea/labels/Discussion","name":"Discussion","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":39,"created_at":"2016-08-04T18:38:55Z","updated_at":"2016-08-15T20:01:36Z","closed_at":null,"body":"In addition to the already made:\r\nAttatch->Attach\r\nattatch->attach\r\n\r\nI wish to propose the following changes and deletions, to be included in the 1.9 engine:\r\n\r\nEngine behaviour changes:\r\n**Naval Bombard Casualties Return Fire Restricted** invert behaviour (to behave as true like it now does as false, and vice versa)\r\n\r\nXML related engine deletions (if not already done (I don't know)):\r\n**\"takeUnitControl\"**\r\n**\"occupiedTerrOf\"**\r\n**\"isParatroop\"**\r\n**\"isMechanized\"**\r\n**\"isTwoHit\"**\r\n**\"trigger\"**\r\n**\"SBR Affects Unit Production\"**\r\n\r\nXML related engine changes and XML changes:\r\n**isImpassible->isImpassable**\r\n**option name=\"victoryCity\" value=\"true\"->option name=\"victoryCity\" value=\"1\"**\r\n(stop supporting boolean only)\r\n**offence->offensive**\r\n**defence->defensive**\r\n**Battleships repair at end of round->Units Repair Hits End Turn**\r\n**Battleships repair at beginning of round->Units Repair Hits Start Turn**\r\n**option name=\"turns\"->option name=\"rounds\"**\r\n**option name=\"conditionType\" value=\"XOR\"->option name=\"conditionType\" value=\"1\"**\r\n\r\nXML only deletions:\r\n**option name=\"takeUnitControl\" value=\"true\"**\r\n**option name=\"takeUnitControl\" value=\"false\"**\r\n**option name=\"giveUnitControl\" value=\"true\"**\r\n**option name=\"giveUnitControl\" value=\"false\"**\r\n(all and only the boolean occurrences of giveUnitControl must be deleted)\r\n\r\nXML only changes:\r\n**\"occupiedTerrOf\"->\"originalOwner\"**\r\n**\"isParatroop\"->\"isAirTransportable\"**\r\n**\"isMechanized\"->\"isInfantry\"**\r\n**\"isTwoHit\" value=\"true\"->\"hitPoints\" value=\"2\"**\r\n**\"isTwoHit\" value=\"false\"->\"hitPoints\" value=\"1\"**\r\n**\"trigger\"->\"conditions\"**\r\n**\"Naval Bombard Casualties Return Fire Restricted\" value=\"true\"->\"Naval Bombard Casualties Return Fire Restricted\" value=\"false\"**\r\n**\"Naval Bombard Casualties Return Fire Restricted\" value=\"false\"->\"Naval Bombard Casualties Return Fire Restricted\" value=\"true\"**\r\n(on the assumption that the mapmakers set the option on what it does, not on what it says)\r\n**\"SBR Affects Unit Production\"->\"Damage From Bombing Done To Units Instead Of Territories\"**\r\n\r\nmap.properties related engine changes and map.properties changes:\r\n**color.Impassible=->color.Impassable=** \r\n\r\n And the current pos2 descriptions should be updated accordingly, in several of the above cases.\r\n\r\nI suggest these changes not being backward compatible (removed, not deprecated), just like the attatch to attach case.\r\n\r\nI believe this should reduce incorrect or redundant or deprecated elements to only \"artillerySupportable\", \"artillery\", and \"unitSupportCount\", that, albeit duplicative of what done via supportAttachment, I definitively suggest being kept, for some reasons.\r\n\r\nPlease, if any developer willingly to do any of the above changes don't want to make some of them or want to make some of them in a different way or just don't get the point of some of them, let me know specifically which ones you are in disagreement or in doubt with and I will explain you why you should do them the way I said.\r\nWhile I'm of course favourable if all the above changes are fully made exactly the way I said, I may be contrary to make any of them if only some of them are made or if they are made in a different way than I said.\r\n\r\nThanks!\r\n\r\nReferences:\r\nhttp://tripleadev.1671093.n2.nabble.com/Attatch-incorrect-spelling-fixed-tp7591892.html;cid=1470329274322-906\r\nhttp://tripleadev.1671093.n2.nabble.com/PRECONDITIONS-FOR-MAP-UPLOAD-tp7587348.html;cid=1470329274322-906"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/239911783","html_url":"https://github.com/triplea-game/triplea/issues/1033#issuecomment-239911783","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/1033","id":239911783,"user":{"login":"Cernelius","id":19562310,"avatar_url":"https://avatars.githubusercontent.com/u/19562310?v=3","gravatar_id":"","url":"https://api.github.com/users/Cernelius","html_url":"https://github.com/Cernelius","followers_url":"https://api.github.com/users/Cernelius/followers","following_url":"https://api.github.com/users/Cernelius/following{/other_user}","gists_url":"https://api.github.com/users/Cernelius/gists{/gist_id}","starred_url":"https://api.github.com/users/Cernelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cernelius/subscriptions","organizations_url":"https://api.github.com/users/Cernelius/orgs","repos_url":"https://api.github.com/users/Cernelius/repos","events_url":"https://api.github.com/users/Cernelius/events{/privacy}","received_events_url":"https://api.github.com/users/Cernelius/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T20:01:36Z","updated_at":"2016-08-15T20:01:36Z","body":"You can be right (and you probably are, since you are a developer and I'm not) that this issue should be preferably split into multiple issues, but mainly because I'm strongly against making only part of these changes or making them at much different points in time or making them after the 1.9 release at all, I'm not going to do it.\r\n\r\nConsequently, this issue will have to either wait someone else to do the splittings (I'm against) or a developer willingly to undertake the big task of tackling it all in one go, because this is what I'm requesting.\r\n\r\nOf course, I realise this is a demanding task, and I don't demand any developers to actually do it, if it feels overwhelming / confusing to them.\r\n\r\nI will definitively close this issue after the 1.9 is released, as I've already explained.\r\n\r\nLet's say, after the 1.9 release, this can remain as a closed discussion item, from which anyone can carve out stuff.\r\n\r\nAs I've already said, none of this can be made and this issue be just forgotten: no harm done.\r\n\r\nPlease, don't do any changes I proposed anytime but briefly before a new release.\r\n\r\nI also definitively suggest to undo all changes made so far, related to this issue, except only the isImpassible one.\r\n\r\nThanks for your time and attention.\r\n\r\n(I'm anyway going to update the first post to be about as much clear as I can possibly get it to be)"}}
{"actor":{"display_login":"Cernelius"}}