{"action":"created","comment":{"url":"https://api.github.com/repos/Polyconseil/django-npm/pulls/comments/57029822","id":57029822,"diff_hunk":"@@ -55,17 +77,14 @@ def __init__(self, apps=None, *args, **kwargs):\n         self.storages[self.locations[0][1]] = filesystem_storage\n \n     def find(self, path, all=False):\n-        patterns = getattr(settings, 'NPM_FILE_PATTERNS', None)\n-        relpath = os.path.relpath(path, getattr(settings, 'NPM_DESTINATION_PREFIX', ''))\n-        if not matches_patterns(patterns, relpath):\n+        relpath = os.path.relpath(path, self.destination)\n+        if not django_utils.matches_patterns(relpath, self.match_patterns):\n             return []\n         return super(NpmFinder, self).find(path, all=all)\n \n-    def list(self, ignore_patterns):\n-        \"\"\"\n-        List all files in all locations.\n-        \"\"\"\n-        patterns = getattr(settings, 'NPM_FILE_PATTERNS', None)\n-        results = super(NpmFinder, self).list(ignore_patterns)\n-        matches = [(path, storage) for path, storage in results if matches_patterns(patterns, path)]\n-        return matches\n+    def list(self, ignore_patterns=None): # TODO should be configurable, add setting","path":"npm/finders.py","position":115,"original_position":115,"commit_id":"583be891caf40e3fd7d78e3f7ae513947d41ff85","original_commit_id":"583be891caf40e3fd7d78e3f7ae513947d41ff85","user":{"login":"vperron","id":88618,"avatar_url":"https://avatars.githubusercontent.com/u/88618?v=3","gravatar_id":"","url":"https://api.github.com/users/vperron","html_url":"https://github.com/vperron","followers_url":"https://api.github.com/users/vperron/followers","following_url":"https://api.github.com/users/vperron/following{/other_user}","gists_url":"https://api.github.com/users/vperron/gists{/gist_id}","starred_url":"https://api.github.com/users/vperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vperron/subscriptions","organizations_url":"https://api.github.com/users/vperron/orgs","repos_url":"https://api.github.com/users/vperron/repos","events_url":"https://api.github.com/users/vperron/events{/privacy}","received_events_url":"https://api.github.com/users/vperron/received_events","type":"User","site_admin":false},"body":"nit: deux espaces avant le commentaire","created_at":"2016-03-22T17:24:11Z","updated_at":"2016-03-22T17:24:11Z","html_url":"https://github.com/Polyconseil/django-npm/pull/1#discussion_r57029822","pull_request_url":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Polyconseil/django-npm/pulls/comments/57029822"},"html":{"href":"https://github.com/Polyconseil/django-npm/pull/1#discussion_r57029822"},"pull_request":{"href":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1","id":63754338,"html_url":"https://github.com/Polyconseil/django-npm/pull/1","diff_url":"https://github.com/Polyconseil/django-npm/pull/1.diff","patch_url":"https://github.com/Polyconseil/django-npm/pull/1.patch","issue_url":"https://api.github.com/repos/Polyconseil/django-npm/issues/1","number":1,"state":"open","locked":false,"title":"Rboucher/optimization","user":{"login":"raphael-boucher","id":3764018,"avatar_url":"https://avatars.githubusercontent.com/u/3764018?v=3","gravatar_id":"","url":"https://api.github.com/users/raphael-boucher","html_url":"https://github.com/raphael-boucher","followers_url":"https://api.github.com/users/raphael-boucher/followers","following_url":"https://api.github.com/users/raphael-boucher/following{/other_user}","gists_url":"https://api.github.com/users/raphael-boucher/gists{/gist_id}","starred_url":"https://api.github.com/users/raphael-boucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphael-boucher/subscriptions","organizations_url":"https://api.github.com/users/raphael-boucher/orgs","repos_url":"https://api.github.com/users/raphael-boucher/repos","events_url":"https://api.github.com/users/raphael-boucher/events{/privacy}","received_events_url":"https://api.github.com/users/raphael-boucher/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-22T16:54:10Z","updated_at":"2016-03-22T17:24:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b573b9c936a889731e94739218aa93a9951ee08b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Polyconseil/django-npm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polyconseil/django-npm/issues/1/comments","statuses_url":"https://api.github.com/repos/Polyconseil/django-npm/statuses/583be891caf40e3fd7d78e3f7ae513947d41ff85","head":{"label":"Polyconseil:rboucher/optimization","ref":"rboucher/optimization","sha":"583be891caf40e3fd7d78e3f7ae513947d41ff85","user":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"repo":{"id":47629513,"name":"django-npm","full_name":"Polyconseil/django-npm","owner":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polyconseil/django-npm","description":"Automatically pull in npm dependencies as staticfiles in your Django project","fork":true,"url":"https://api.github.com/repos/Polyconseil/django-npm","forks_url":"https://api.github.com/repos/Polyconseil/django-npm/forks","keys_url":"https://api.github.com/repos/Polyconseil/django-npm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polyconseil/django-npm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polyconseil/django-npm/teams","hooks_url":"https://api.github.com/repos/Polyconseil/django-npm/hooks","issue_events_url":"https://api.github.com/repos/Polyconseil/django-npm/issues/events{/number}","events_url":"https://api.github.com/repos/Polyconseil/django-npm/events","assignees_url":"https://api.github.com/repos/Polyconseil/django-npm/assignees{/user}","branches_url":"https://api.github.com/repos/Polyconseil/django-npm/branches{/branch}","tags_url":"https://api.github.com/repos/Polyconseil/django-npm/tags","blobs_url":"https://api.github.com/repos/Polyconseil/django-npm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polyconseil/django-npm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polyconseil/django-npm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polyconseil/django-npm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polyconseil/django-npm/statuses/{sha}","languages_url":"https://api.github.com/repos/Polyconseil/django-npm/languages","stargazers_url":"https://api.github.com/repos/Polyconseil/django-npm/stargazers","contributors_url":"https://api.github.com/repos/Polyconseil/django-npm/contributors","subscribers_url":"https://api.github.com/repos/Polyconseil/django-npm/subscribers","subscription_url":"https://api.github.com/repos/Polyconseil/django-npm/subscription","commits_url":"https://api.github.com/repos/Polyconseil/django-npm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polyconseil/django-npm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polyconseil/django-npm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polyconseil/django-npm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polyconseil/django-npm/contents/{+path}","compare_url":"https://api.github.com/repos/Polyconseil/django-npm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polyconseil/django-npm/merges","archive_url":"https://api.github.com/repos/Polyconseil/django-npm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polyconseil/django-npm/downloads","issues_url":"https://api.github.com/repos/Polyconseil/django-npm/issues{/number}","pulls_url":"https://api.github.com/repos/Polyconseil/django-npm/pulls{/number}","milestones_url":"https://api.github.com/repos/Polyconseil/django-npm/milestones{/number}","notifications_url":"https://api.github.com/repos/Polyconseil/django-npm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polyconseil/django-npm/labels{/name}","releases_url":"https://api.github.com/repos/Polyconseil/django-npm/releases{/id}","deployments_url":"https://api.github.com/repos/Polyconseil/django-npm/deployments","created_at":"2015-12-08T15:06:23Z","updated_at":"2015-12-08T15:06:23Z","pushed_at":"2016-03-22T17:03:22Z","git_url":"git://github.com/Polyconseil/django-npm.git","ssh_url":"git@github.com:Polyconseil/django-npm.git","clone_url":"https://github.com/Polyconseil/django-npm.git","svn_url":"https://github.com/Polyconseil/django-npm","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Polyconseil:master","ref":"master","sha":"3f4f37d0f229a36b5436785662e3e46b340c4f42","user":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"repo":{"id":47629513,"name":"django-npm","full_name":"Polyconseil/django-npm","owner":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polyconseil/django-npm","description":"Automatically pull in npm dependencies as staticfiles in your Django project","fork":true,"url":"https://api.github.com/repos/Polyconseil/django-npm","forks_url":"https://api.github.com/repos/Polyconseil/django-npm/forks","keys_url":"https://api.github.com/repos/Polyconseil/django-npm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polyconseil/django-npm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polyconseil/django-npm/teams","hooks_url":"https://api.github.com/repos/Polyconseil/django-npm/hooks","issue_events_url":"https://api.github.com/repos/Polyconseil/django-npm/issues/events{/number}","events_url":"https://api.github.com/repos/Polyconseil/django-npm/events","assignees_url":"https://api.github.com/repos/Polyconseil/django-npm/assignees{/user}","branches_url":"https://api.github.com/repos/Polyconseil/django-npm/branches{/branch}","tags_url":"https://api.github.com/repos/Polyconseil/django-npm/tags","blobs_url":"https://api.github.com/repos/Polyconseil/django-npm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polyconseil/django-npm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polyconseil/django-npm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polyconseil/django-npm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polyconseil/django-npm/statuses/{sha}","languages_url":"https://api.github.com/repos/Polyconseil/django-npm/languages","stargazers_url":"https://api.github.com/repos/Polyconseil/django-npm/stargazers","contributors_url":"https://api.github.com/repos/Polyconseil/django-npm/contributors","subscribers_url":"https://api.github.com/repos/Polyconseil/django-npm/subscribers","subscription_url":"https://api.github.com/repos/Polyconseil/django-npm/subscription","commits_url":"https://api.github.com/repos/Polyconseil/django-npm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polyconseil/django-npm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polyconseil/django-npm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polyconseil/django-npm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polyconseil/django-npm/contents/{+path}","compare_url":"https://api.github.com/repos/Polyconseil/django-npm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polyconseil/django-npm/merges","archive_url":"https://api.github.com/repos/Polyconseil/django-npm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polyconseil/django-npm/downloads","issues_url":"https://api.github.com/repos/Polyconseil/django-npm/issues{/number}","pulls_url":"https://api.github.com/repos/Polyconseil/django-npm/pulls{/number}","milestones_url":"https://api.github.com/repos/Polyconseil/django-npm/milestones{/number}","notifications_url":"https://api.github.com/repos/Polyconseil/django-npm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polyconseil/django-npm/labels{/name}","releases_url":"https://api.github.com/repos/Polyconseil/django-npm/releases{/id}","deployments_url":"https://api.github.com/repos/Polyconseil/django-npm/deployments","created_at":"2015-12-08T15:06:23Z","updated_at":"2015-12-08T15:06:23Z","pushed_at":"2016-03-22T17:03:22Z","git_url":"git://github.com/Polyconseil/django-npm.git","ssh_url":"git@github.com:Polyconseil/django-npm.git","clone_url":"https://github.com/Polyconseil/django-npm.git","svn_url":"https://github.com/Polyconseil/django-npm","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1"},"html":{"href":"https://github.com/Polyconseil/django-npm/pull/1"},"issue":{"href":"https://api.github.com/repos/Polyconseil/django-npm/issues/1"},"comments":{"href":"https://api.github.com/repos/Polyconseil/django-npm/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Polyconseil/django-npm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polyconseil/django-npm/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Polyconseil/django-npm/statuses/583be891caf40e3fd7d78e3f7ae513947d41ff85"}}}}