{"action":"created","issue":{"url":"https://api.github.com/repos/ilyarom/OPR-Project/issues/2","repository_url":"https://api.github.com/repos/ilyarom/OPR-Project","labels_url":"https://api.github.com/repos/ilyarom/OPR-Project/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ilyarom/OPR-Project/issues/2/comments","events_url":"https://api.github.com/repos/ilyarom/OPR-Project/issues/2/events","html_url":"https://github.com/ilyarom/OPR-Project/issues/2","id":182969917,"number":2,"title":"Замечания по 1.2 (clocks)","user":{"login":"sergey-shambir","id":1856842,"avatar_url":"https://avatars.githubusercontent.com/u/1856842?v=3","gravatar_id":"","url":"https://api.github.com/users/sergey-shambir","html_url":"https://github.com/sergey-shambir","followers_url":"https://api.github.com/users/sergey-shambir/followers","following_url":"https://api.github.com/users/sergey-shambir/following{/other_user}","gists_url":"https://api.github.com/users/sergey-shambir/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-shambir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-shambir/subscriptions","organizations_url":"https://api.github.com/users/sergey-shambir/orgs","repos_url":"https://api.github.com/users/sergey-shambir/repos","events_url":"https://api.github.com/users/sergey-shambir/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-shambir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-14T05:58:10Z","updated_at":"2016-10-14T05:58:18Z","closed_at":null,"body":"- в Git попали постронние файлы `clock.VC.db`, `clock.sdf`, являющиеся продуктами работы IDE и ненужные для сборки\r\n- то же касается каталогов `ipch`, `Debug`, `.vs` - это посторонние продукты сборки, а не сами исходники\r\n- файл `clock.vcxproj.user` хранит опциональные локальные настройки пользователя IDE и не должен попадать под контроль версий\r\n- в случае использования precompiled headers в компиляторе от Microsoft данный define будет проигнорирован:\r\n\r\n```cpp\r\n#define _USE_MATH_DEFINES\r\n#include \"stdafx.h\"\r\n```\r\n\r\n- не надо объявлять несколько переменных на одной строке: `int x, y;`\r\n\r\n![Иллюстрация](https://ps-group.github.io/sfml/img/variables-in-bed.jpg)\r\n\r\n- в функции CreateDots есть магическое число 10\r\n- в функции CreateDigits есть магическое число 35\r\n- в функции DrawElements сбито форматирование кода\r\n- функция SetTime, судя по названию, принимает новое значение времени и устанавливает его для часов. Реально функция сама определяет время, значит, надо сменить глагол\r\n- название функции DrawClocks не отражает её поведение"},"comment":{"url":"https://api.github.com/repos/ilyarom/OPR-Project/issues/comments/253716300","html_url":"https://github.com/ilyarom/OPR-Project/issues/2#issuecomment-253716300","issue_url":"https://api.github.com/repos/ilyarom/OPR-Project/issues/2","id":253716300,"user":{"login":"sergey-shambir","id":1856842,"avatar_url":"https://avatars.githubusercontent.com/u/1856842?v=3","gravatar_id":"","url":"https://api.github.com/users/sergey-shambir","html_url":"https://github.com/sergey-shambir","followers_url":"https://api.github.com/users/sergey-shambir/followers","following_url":"https://api.github.com/users/sergey-shambir/following{/other_user}","gists_url":"https://api.github.com/users/sergey-shambir/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-shambir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-shambir/subscriptions","organizations_url":"https://api.github.com/users/sergey-shambir/orgs","repos_url":"https://api.github.com/users/sergey-shambir/repos","events_url":"https://api.github.com/users/sergey-shambir/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-shambir/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T05:58:18Z","updated_at":"2016-10-14T05:58:18Z","body":"5 из 10"}}
{"actor":{"display_login":"sergey-shambir"}}