{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/minpy/pulls/comments/90370935","pull_request_review_id":10890375,"id":90370935,"diff_hunk":"@@ -4,35 +4,39 @@\n from __future__ import print_function\n import time\n \n+import minpy\n+\n from minpy.nn import optim, init\n from minpy import core\n import minpy.numpy as np\n \n+from minpy.visualize.writer import LegacySummaryWriter as SummaryWriter\n+import minpy.visualize.summaryOps as summaryOps\n \n class Solver(object):\n     \"\"\"\n     A Solver encapsulates all the logic necessary for training classification\n     models. The Solver performs stochastic gradient descent using different\n     update rules defined in optim.py.\n-\n+    ","path":"minpy/nn/solver.py","position":19,"original_position":19,"commit_id":"68f263d475c90258919e31eeb85ee4a92d2b8721","original_commit_id":"68f263d475c90258919e31eeb85ee4a92d2b8721","user":{"login":"jermainewang","id":4057701,"avatar_url":"https://avatars.githubusercontent.com/u/4057701?v=3","gravatar_id":"","url":"https://api.github.com/users/jermainewang","html_url":"https://github.com/jermainewang","followers_url":"https://api.github.com/users/jermainewang/followers","following_url":"https://api.github.com/users/jermainewang/following{/other_user}","gists_url":"https://api.github.com/users/jermainewang/gists{/gist_id}","starred_url":"https://api.github.com/users/jermainewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jermainewang/subscriptions","organizations_url":"https://api.github.com/users/jermainewang/orgs","repos_url":"https://api.github.com/users/jermainewang/repos","events_url":"https://api.github.com/users/jermainewang/events{/privacy}","received_events_url":"https://api.github.com/users/jermainewang/received_events","type":"User","site_admin":false},"body":"That's weird. Just have a try in your forked repo:\r\n```\r\n python ./dmlc-core/scripts/lint.py minpy python minpy/visualize/summaryOps.py                                    ──(Wed,Nov30)─┘\r\nNo config file found, using default configuration\r\n\r\n************* Module summaryOps\r\n minpy/visualize/summaryOps.py:14: warning (W0311, bad-indentation, ) Bad indentation. Found 6 spaces, expected 8\r\n minpy/visualize/summaryOps.py:16: warning (W0311, bad-indentation, ) Bad indentation. Found 6 spaces, expected 8\r\n minpy/visualize/summaryOps.py:39: warning (W0311, bad-indentation, ) Bad indentation. Found 6 spaces, expected 8\r\n minpy/visualize/summaryOps.py:40: warning (W0311, bad-indentation, ) Bad indentation. Found 6 spaces, expected 8\r\n minpy/visualize/summaryOps.py:43: convention (C0330, bad-continuation, ) Wrong continued indentation (add 1 space).\r\n                    if counts[i]]\r\n                    ^|\r\n minpy/visualize/summaryOps.py:56: warning (W0311, bad-indentation, ) Bad indentation. Found 2 spaces, expected 4\r\n minpy/visualize/summaryOps.py:57: warning (W0311, bad-indentation, ) Bad indentation. Found 2 spaces, expected 4\r\n minpy/visualize/summaryOps.py:58: warning (W0311, bad-indentation, ) Bad indentation. Found 2 spaces, expected 4\r\n minpy/visualize/summaryOps.py:59: warning (W0311, bad-indentation, ) Bad indentation. Found 2 spaces, expected 4\r\n minpy/visualize/summaryOps.py:60: warning (W0311, bad-indentation, ) Bad indentation. Found 4 spaces, expected 8\r\n minpy/visualize/summaryOps.py:61: warning (W0311, bad-indentation, ) Bad indentation. Found 4 spaces, expected 8\r\n minpy/visualize/summaryOps.py:62: warning (W0311, bad-indentation, ) Bad indentation. Found 4 spaces, expected 8\r\n minpy/visualize/summaryOps.py:63: warning (W0311, bad-indentation, ) Bad indentation. Found 4 spaces, expected 8\r\n minpy/visualize/summaryOps.py:64: warning (W0311, bad-indentation, ) Bad indentation. Found 4 spaces, expected 8\r\n minpy/visualize/summaryOps.py:65: warning (W0311, bad-indentation, ) Bad indentation. Found 4 spaces, expected 8\r\n minpy/visualize/summaryOps.py:66: warning (W0311, bad-indentation, ) Bad indentation. Found 4 spaces, expected 8\r\n minpy/visualize/summaryOps.py:1: convention (C0103, invalid-name, ) Invalid module name \"summaryOps\"\r\n minpy/visualize/summaryOps.py:1: convention (C0111, missing-docstring, ) Missing module docstring\r\n minpy/visualize/summaryOps.py:7: error (E0401, import-error, ) Unable to import 'minpy'\r\n minpy/visualize/summaryOps.py:10: error (E0401, import-error, ) Unable to import 'minpy.visualization.summary_pb2'\r\n minpy/visualize/summaryOps.py:12: convention (C0103, invalid-name, scalarSummary) Invalid function name \"scalarSummary\"\r\n minpy/visualize/summaryOps.py:12: convention (C0103, invalid-name, scalarSummary) Invalid argument name \"TAG\"\r\n minpy/visualize/summaryOps.py:12: convention (C0111, missing-docstring, scalarSummary) Missing function docstring\r\n minpy/visualize/summaryOps.py:13: convention (C0121, singleton-comparison, scalarSummary) Comparison to True should be just 'expr' or 'expr is True'\r\n minpy/visualize/summaryOps.py:15: convention (C0121, singleton-comparison, scalarSummary) Comparison to True should be just 'expr' or 'expr is True'\r\n minpy/visualize/summaryOps.py:19: convention (C0103, invalid-name, histogramSummary) Invalid function name \"histogramSummary\"\r\n minpy/visualize/summaryOps.py:19: convention (C0103, invalid-name, histogramSummary) Invalid argument name \"TAG\"\r\n minpy/visualize/summaryOps.py:19: convention (C0111, missing-docstring, histogramSummary) Missing function docstring\r\n minpy/visualize/summaryOps.py:23: convention (C0103, invalid-name, _MakeHistogramBuckets) Invalid function name \"_MakeHistogramBuckets\"\r\n minpy/visualize/summaryOps.py:24: convention (C0103, invalid-name, _MakeHistogramBuckets) Invalid variable name \"v\"\r\n minpy/visualize/summaryOps.py:30: convention (C0103, invalid-name, _MakeHistogramBuckets) Invalid variable name \"v\"\r\n minpy/visualize/summaryOps.py:34: convention (C0103, invalid-name, _MakeHistogram) Invalid function name \"_MakeHistogram\"\r\n minpy/visualize/summaryOps.py:38: convention (C0103, invalid-name, _MakeHistogram) Invalid variable name \"v\"\r\n minpy/visualize/summaryOps.py:42: error (E0602, undefined-variable, _MakeHistogram) Undefined variable 'xrange'\r\n minpy/visualize/summaryOps.py:55: convention (C0103, invalid-name, WriteHistogramSeries) Invalid function name \"WriteHistogramSeries\"\r\n minpy/visualize/summaryOps.py:55: convention (C0103, invalid-name, WriteHistogramSeries) Invalid argument name \"n\"\r\n minpy/visualize/summaryOps.py:58: error (E0602, undefined-variable, WriteHistogramSeries) Undefined variable '_start_time'\r\n minpy/visualize/summaryOps.py:60: error (E0602, undefined-variable, WriteHistogramSeries) Undefined variable 'xrange'\r\n minpy/visualize/summaryOps.py:62: error (E0602, undefined-variable, WriteHistogramSeries) Undefined variable 'tf'\r\n minpy/visualize/summaryOps.py:62: error (E0602, undefined-variable, WriteHistogramSeries) Undefined variable 'tf'\r\n minpy/visualize/summaryOps.py:63: error (E0602, undefined-variable, WriteHistogramSeries) Undefined variable 'tf'\r\n minpy/visualize/summaryOps.py:6: convention (C0411, wrong-import-order, ) standard import \"import bisect\" comes before \"import numpy\"\r\n minpy/visualize/summaryOps.py:8: convention (C0411, wrong-import-order, ) standard import \"import random\" comes before \"import numpy\"\r\n```\r\n\r\nYou should try to fix them. You could leave the `solver.py` file right now until @sneakerkg finished the lint fix on this file.","created_at":"2016-12-01T02:06:02Z","updated_at":"2016-12-01T02:06:02Z","html_url":"https://github.com/dmlc/minpy/pull/87#discussion_r90370935","pull_request_url":"https://api.github.com/repos/dmlc/minpy/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/dmlc/minpy/pulls/comments/90370935"},"html":{"href":"https://github.com/dmlc/minpy/pull/87#discussion_r90370935"},"pull_request":{"href":"https://api.github.com/repos/dmlc/minpy/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/minpy/pulls/87","id":95978191,"html_url":"https://github.com/dmlc/minpy/pull/87","diff_url":"https://github.com/dmlc/minpy/pull/87.diff","patch_url":"https://github.com/dmlc/minpy/pull/87.patch","issue_url":"https://api.github.com/repos/dmlc/minpy/issues/87","number":87,"state":"open","locked":false,"title":"Add Visualization Components","user":{"login":"mufeili","id":19576924,"avatar_url":"https://avatars.githubusercontent.com/u/19576924?v=3","gravatar_id":"","url":"https://api.github.com/users/mufeili","html_url":"https://github.com/mufeili","followers_url":"https://api.github.com/users/mufeili/followers","following_url":"https://api.github.com/users/mufeili/following{/other_user}","gists_url":"https://api.github.com/users/mufeili/gists{/gist_id}","starred_url":"https://api.github.com/users/mufeili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mufeili/subscriptions","organizations_url":"https://api.github.com/users/mufeili/orgs","repos_url":"https://api.github.com/users/mufeili/repos","events_url":"https://api.github.com/users/mufeili/events{/privacy}","received_events_url":"https://api.github.com/users/mufeili/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-30T21:33:42Z","updated_at":"2016-12-01T02:06:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"071c5562611e31db15b29f8bc41b676f8aa74fc9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/minpy/pulls/87/commits","review_comments_url":"https://api.github.com/repos/dmlc/minpy/pulls/87/comments","review_comment_url":"https://api.github.com/repos/dmlc/minpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/minpy/issues/87/comments","statuses_url":"https://api.github.com/repos/dmlc/minpy/statuses/68f263d475c90258919e31eeb85ee4a92d2b8721","head":{"label":"mufeili:visualize","ref":"visualize","sha":"68f263d475c90258919e31eeb85ee4a92d2b8721","user":{"login":"mufeili","id":19576924,"avatar_url":"https://avatars.githubusercontent.com/u/19576924?v=3","gravatar_id":"","url":"https://api.github.com/users/mufeili","html_url":"https://github.com/mufeili","followers_url":"https://api.github.com/users/mufeili/followers","following_url":"https://api.github.com/users/mufeili/following{/other_user}","gists_url":"https://api.github.com/users/mufeili/gists{/gist_id}","starred_url":"https://api.github.com/users/mufeili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mufeili/subscriptions","organizations_url":"https://api.github.com/users/mufeili/orgs","repos_url":"https://api.github.com/users/mufeili/repos","events_url":"https://api.github.com/users/mufeili/events{/privacy}","received_events_url":"https://api.github.com/users/mufeili/received_events","type":"User","site_admin":false},"repo":{"id":75228021,"name":"minpy","full_name":"mufeili/minpy","owner":{"login":"mufeili","id":19576924,"avatar_url":"https://avatars.githubusercontent.com/u/19576924?v=3","gravatar_id":"","url":"https://api.github.com/users/mufeili","html_url":"https://github.com/mufeili","followers_url":"https://api.github.com/users/mufeili/followers","following_url":"https://api.github.com/users/mufeili/following{/other_user}","gists_url":"https://api.github.com/users/mufeili/gists{/gist_id}","starred_url":"https://api.github.com/users/mufeili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mufeili/subscriptions","organizations_url":"https://api.github.com/users/mufeili/orgs","repos_url":"https://api.github.com/users/mufeili/repos","events_url":"https://api.github.com/users/mufeili/events{/privacy}","received_events_url":"https://api.github.com/users/mufeili/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mufeili/minpy","description":"Pure NumPy practice with third-party operator integration","fork":true,"url":"https://api.github.com/repos/mufeili/minpy","forks_url":"https://api.github.com/repos/mufeili/minpy/forks","keys_url":"https://api.github.com/repos/mufeili/minpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mufeili/minpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mufeili/minpy/teams","hooks_url":"https://api.github.com/repos/mufeili/minpy/hooks","issue_events_url":"https://api.github.com/repos/mufeili/minpy/issues/events{/number}","events_url":"https://api.github.com/repos/mufeili/minpy/events","assignees_url":"https://api.github.com/repos/mufeili/minpy/assignees{/user}","branches_url":"https://api.github.com/repos/mufeili/minpy/branches{/branch}","tags_url":"https://api.github.com/repos/mufeili/minpy/tags","blobs_url":"https://api.github.com/repos/mufeili/minpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mufeili/minpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mufeili/minpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mufeili/minpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mufeili/minpy/statuses/{sha}","languages_url":"https://api.github.com/repos/mufeili/minpy/languages","stargazers_url":"https://api.github.com/repos/mufeili/minpy/stargazers","contributors_url":"https://api.github.com/repos/mufeili/minpy/contributors","subscribers_url":"https://api.github.com/repos/mufeili/minpy/subscribers","subscription_url":"https://api.github.com/repos/mufeili/minpy/subscription","commits_url":"https://api.github.com/repos/mufeili/minpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mufeili/minpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mufeili/minpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mufeili/minpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mufeili/minpy/contents/{+path}","compare_url":"https://api.github.com/repos/mufeili/minpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mufeili/minpy/merges","archive_url":"https://api.github.com/repos/mufeili/minpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mufeili/minpy/downloads","issues_url":"https://api.github.com/repos/mufeili/minpy/issues{/number}","pulls_url":"https://api.github.com/repos/mufeili/minpy/pulls{/number}","milestones_url":"https://api.github.com/repos/mufeili/minpy/milestones{/number}","notifications_url":"https://api.github.com/repos/mufeili/minpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mufeili/minpy/labels{/name}","releases_url":"https://api.github.com/repos/mufeili/minpy/releases{/id}","deployments_url":"https://api.github.com/repos/mufeili/minpy/deployments","created_at":"2016-11-30T21:18:49Z","updated_at":"2016-11-30T21:18:50Z","pushed_at":"2016-11-30T21:32:19Z","git_url":"git://github.com/mufeili/minpy.git","ssh_url":"git@github.com:mufeili/minpy.git","clone_url":"https://github.com/mufeili/minpy.git","svn_url":"https://github.com/mufeili/minpy","homepage":"https://minpy.readthedocs.io/en/latest/","size":58948,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:visualize","ref":"visualize","sha":"6bac5d149db91b42bff6699edf6beacaac9fbe5e","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":45584086,"name":"minpy","full_name":"dmlc/minpy","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/minpy","description":"Pure NumPy practice with third-party operator integration","fork":false,"url":"https://api.github.com/repos/dmlc/minpy","forks_url":"https://api.github.com/repos/dmlc/minpy/forks","keys_url":"https://api.github.com/repos/dmlc/minpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/minpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/minpy/teams","hooks_url":"https://api.github.com/repos/dmlc/minpy/hooks","issue_events_url":"https://api.github.com/repos/dmlc/minpy/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/minpy/events","assignees_url":"https://api.github.com/repos/dmlc/minpy/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/minpy/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/minpy/tags","blobs_url":"https://api.github.com/repos/dmlc/minpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/minpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/minpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/minpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/minpy/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/minpy/languages","stargazers_url":"https://api.github.com/repos/dmlc/minpy/stargazers","contributors_url":"https://api.github.com/repos/dmlc/minpy/contributors","subscribers_url":"https://api.github.com/repos/dmlc/minpy/subscribers","subscription_url":"https://api.github.com/repos/dmlc/minpy/subscription","commits_url":"https://api.github.com/repos/dmlc/minpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/minpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/minpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/minpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/minpy/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/minpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/minpy/merges","archive_url":"https://api.github.com/repos/dmlc/minpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/minpy/downloads","issues_url":"https://api.github.com/repos/dmlc/minpy/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/minpy/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/minpy/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/minpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/minpy/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/minpy/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/minpy/deployments","created_at":"2015-11-05T03:10:48Z","updated_at":"2016-11-30T14:35:22Z","pushed_at":"2016-11-30T21:33:42Z","git_url":"git://github.com/dmlc/minpy.git","ssh_url":"git@github.com:dmlc/minpy.git","clone_url":"https://github.com/dmlc/minpy.git","svn_url":"https://github.com/dmlc/minpy","homepage":"https://minpy.readthedocs.io/en/latest/","size":58993,"stargazers_count":199,"watchers_count":199,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":7,"forks":38,"open_issues":7,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/minpy/pulls/87"},"html":{"href":"https://github.com/dmlc/minpy/pull/87"},"issue":{"href":"https://api.github.com/repos/dmlc/minpy/issues/87"},"comments":{"href":"https://api.github.com/repos/dmlc/minpy/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/minpy/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/minpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/minpy/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/minpy/statuses/68f263d475c90258919e31eeb85ee4a92d2b8721"}}}}
{"actor":{"display_login":"jermainewang"}}