{"action":"closed","number":4743,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/4743","id":77941714,"html_url":"https://github.com/callemall/material-ui/pull/4743","diff_url":"https://github.com/callemall/material-ui/pull/4743.diff","patch_url":"https://github.com/callemall/material-ui/pull/4743.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/4743","number":4743,"state":"closed","locked":false,"title":"[ListItem] Trigger onNestedListToggle callback after state update","user":{"login":"Hybrid-Force","id":978994,"avatar_url":"https://avatars.githubusercontent.com/u/978994?v=3","gravatar_id":"","url":"https://api.github.com/users/Hybrid-Force","html_url":"https://github.com/Hybrid-Force","followers_url":"https://api.github.com/users/Hybrid-Force/followers","following_url":"https://api.github.com/users/Hybrid-Force/following{/other_user}","gists_url":"https://api.github.com/users/Hybrid-Force/gists{/gist_id}","starred_url":"https://api.github.com/users/Hybrid-Force/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hybrid-Force/subscriptions","organizations_url":"https://api.github.com/users/Hybrid-Force/orgs","repos_url":"https://api.github.com/users/Hybrid-Force/repos","events_url":"https://api.github.com/users/Hybrid-Force/events{/privacy}","received_events_url":"https://api.github.com/users/Hybrid-Force/received_events","type":"User","site_admin":false},"body":"Before the fix, `onNestedListToggle` callback was fired right after `this.setState`.  And when the callback is executed, the toggle state has not changed and you will get the wrong `item.state.open` state due to async state update.\r\n\r\nAfter the fix, the callback is fired *after* state change to make sure the callback get the correct toggle open state.","created_at":"2016-07-19T09:10:25Z","updated_at":"2016-07-19T18:07:03Z","closed_at":"2016-07-19T18:07:03Z","merged_at":"2016-07-19T18:07:03Z","merge_commit_sha":"ce7ee2ffb204ae128445beb4931c4e1020cda5a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/4743/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/4743/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/4743/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/5130b3743ce8d658a99d276cc000d1e9e83acb52","head":{"label":"Hybrid-Force:nested-list-toggle-cb","ref":"nested-list-toggle-cb","sha":"5130b3743ce8d658a99d276cc000d1e9e83acb52","user":{"login":"Hybrid-Force","id":978994,"avatar_url":"https://avatars.githubusercontent.com/u/978994?v=3","gravatar_id":"","url":"https://api.github.com/users/Hybrid-Force","html_url":"https://github.com/Hybrid-Force","followers_url":"https://api.github.com/users/Hybrid-Force/followers","following_url":"https://api.github.com/users/Hybrid-Force/following{/other_user}","gists_url":"https://api.github.com/users/Hybrid-Force/gists{/gist_id}","starred_url":"https://api.github.com/users/Hybrid-Force/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hybrid-Force/subscriptions","organizations_url":"https://api.github.com/users/Hybrid-Force/orgs","repos_url":"https://api.github.com/users/Hybrid-Force/repos","events_url":"https://api.github.com/users/Hybrid-Force/events{/privacy}","received_events_url":"https://api.github.com/users/Hybrid-Force/received_events","type":"User","site_admin":false},"repo":{"id":63674342,"name":"material-ui","full_name":"Hybrid-Force/material-ui","owner":{"login":"Hybrid-Force","id":978994,"avatar_url":"https://avatars.githubusercontent.com/u/978994?v=3","gravatar_id":"","url":"https://api.github.com/users/Hybrid-Force","html_url":"https://github.com/Hybrid-Force","followers_url":"https://api.github.com/users/Hybrid-Force/followers","following_url":"https://api.github.com/users/Hybrid-Force/following{/other_user}","gists_url":"https://api.github.com/users/Hybrid-Force/gists{/gist_id}","starred_url":"https://api.github.com/users/Hybrid-Force/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hybrid-Force/subscriptions","organizations_url":"https://api.github.com/users/Hybrid-Force/orgs","repos_url":"https://api.github.com/users/Hybrid-Force/repos","events_url":"https://api.github.com/users/Hybrid-Force/events{/privacy}","received_events_url":"https://api.github.com/users/Hybrid-Force/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hybrid-Force/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/Hybrid-Force/material-ui","forks_url":"https://api.github.com/repos/Hybrid-Force/material-ui/forks","keys_url":"https://api.github.com/repos/Hybrid-Force/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hybrid-Force/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hybrid-Force/material-ui/teams","hooks_url":"https://api.github.com/repos/Hybrid-Force/material-ui/hooks","issue_events_url":"https://api.github.com/repos/Hybrid-Force/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Hybrid-Force/material-ui/events","assignees_url":"https://api.github.com/repos/Hybrid-Force/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Hybrid-Force/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Hybrid-Force/material-ui/tags","blobs_url":"https://api.github.com/repos/Hybrid-Force/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hybrid-Force/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hybrid-Force/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hybrid-Force/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hybrid-Force/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Hybrid-Force/material-ui/languages","stargazers_url":"https://api.github.com/repos/Hybrid-Force/material-ui/stargazers","contributors_url":"https://api.github.com/repos/Hybrid-Force/material-ui/contributors","subscribers_url":"https://api.github.com/repos/Hybrid-Force/material-ui/subscribers","subscription_url":"https://api.github.com/repos/Hybrid-Force/material-ui/subscription","commits_url":"https://api.github.com/repos/Hybrid-Force/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hybrid-Force/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hybrid-Force/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hybrid-Force/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hybrid-Force/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Hybrid-Force/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hybrid-Force/material-ui/merges","archive_url":"https://api.github.com/repos/Hybrid-Force/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hybrid-Force/material-ui/downloads","issues_url":"https://api.github.com/repos/Hybrid-Force/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Hybrid-Force/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Hybrid-Force/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Hybrid-Force/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hybrid-Force/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/Hybrid-Force/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Hybrid-Force/material-ui/deployments","created_at":"2016-07-19T08:08:11Z","updated_at":"2016-07-19T08:08:14Z","pushed_at":"2016-07-19T08:57:07Z","git_url":"git://github.com/Hybrid-Force/material-ui.git","ssh_url":"git@github.com:Hybrid-Force/material-ui.git","clone_url":"https://github.com/Hybrid-Force/material-ui.git","svn_url":"https://github.com/Hybrid-Force/material-ui","homepage":"http://www.material-ui.com","size":69014,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"053e6ce77b30c7e7d07f1c29208fd61d5aec0d5a","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-07-19T17:14:35Z","pushed_at":"2016-07-19T18:07:03Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":76170,"stargazers_count":17950,"watchers_count":17950,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3218,"mirror_url":null,"open_issues_count":461,"forks":3218,"open_issues":461,"watchers":17950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/4743"},"html":{"href":"https://github.com/callemall/material-ui/pull/4743"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/4743"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/4743/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/4743/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/4743/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/5130b3743ce8d658a99d276cc000d1e9e83acb52"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"oliviertassinari"}}