{"action":"created","issue":{"url":"https://api.github.com/repos/hkellaway/Gloss/issues/225","repository_url":"https://api.github.com/repos/hkellaway/Gloss","labels_url":"https://api.github.com/repos/hkellaway/Gloss/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/hkellaway/Gloss/issues/225/comments","events_url":"https://api.github.com/repos/hkellaway/Gloss/issues/225/events","html_url":"https://github.com/hkellaway/Gloss/pull/225","id":183646531,"number":225,"title":"Reintroduce Nested Keypaths","user":{"login":"ferusinfo","id":1098045,"avatar_url":"https://avatars.githubusercontent.com/u/1098045?v=3","gravatar_id":"","url":"https://api.github.com/users/ferusinfo","html_url":"https://github.com/ferusinfo","followers_url":"https://api.github.com/users/ferusinfo/followers","following_url":"https://api.github.com/users/ferusinfo/following{/other_user}","gists_url":"https://api.github.com/users/ferusinfo/gists{/gist_id}","starred_url":"https://api.github.com/users/ferusinfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferusinfo/subscriptions","organizations_url":"https://api.github.com/users/ferusinfo/orgs","repos_url":"https://api.github.com/users/ferusinfo/repos","events_url":"https://api.github.com/users/ferusinfo/events{/privacy}","received_events_url":"https://api.github.com/users/ferusinfo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hkellaway/Gloss/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hkellaway/Gloss/milestones/17","html_url":"https://github.com/hkellaway/Gloss/milestones/1.1.0","labels_url":"https://api.github.com/repos/hkellaway/Gloss/milestones/17/labels","id":2016279,"number":17,"title":"1.1.0","description":"","creator":{"login":"hkellaway","id":5456481,"avatar_url":"https://avatars.githubusercontent.com/u/5456481?v=3","gravatar_id":"","url":"https://api.github.com/users/hkellaway","html_url":"https://github.com/hkellaway","followers_url":"https://api.github.com/users/hkellaway/followers","following_url":"https://api.github.com/users/hkellaway/following{/other_user}","gists_url":"https://api.github.com/users/hkellaway/gists{/gist_id}","starred_url":"https://api.github.com/users/hkellaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkellaway/subscriptions","organizations_url":"https://api.github.com/users/hkellaway/orgs","repos_url":"https://api.github.com/users/hkellaway/repos","events_url":"https://api.github.com/users/hkellaway/events{/privacy}","received_events_url":"https://api.github.com/users/hkellaway/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2016-09-20T12:01:12Z","updated_at":"2016-10-23T15:33:47Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-10-18T10:22:38Z","updated_at":"2016-10-23T15:35:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hkellaway/Gloss/pulls/225","html_url":"https://github.com/hkellaway/Gloss/pull/225","diff_url":"https://github.com/hkellaway/Gloss/pull/225.diff","patch_url":"https://github.com/hkellaway/Gloss/pull/225.patch"},"body":"Hey @hkellaway :)\r\nAfter your recent changes regarding deprecating nested keypaths in Gloss (https://github.com/hkellaway/Gloss/issues/135), we faced a huge problem - we have A LOT of models using that feature, and we could:\r\n- ditch the Gloss completely (while we admire it a lot ) ❌ \r\n- switch to ObjectMapper (or any other library supporting the feature) ❌ \r\n- or just simply fix the issue ✌️ \r\n\r\nI am happy to say that after few days of sorting that all out, my pull request is reintroducing the nested keypaths. It supports **Swift 3.0** directly and does not need to disable swift optimizations. I've also reintroduced and modified tests that you've previously had for the feature.\r\n\r\nFor those who are interested what was wrong - for `Encoder` it seems that when you put a lot of hard-logic code into Dictionary extension, the compiler is acting weird. I am also passing the sub-dictionaries by reference, so it does not create a new copy. For `Decoder`, I've rewritten the function to find the element by the keypath so it uses a recursive function to traverse the tree.\r\n\r\nFor those who are interested, there is also a `fixes_for_nested` branch in my fork for **Swift 2.3**: https://github.com/ferusinfo/Gloss/tree/fixes_for_nested\r\n\r\nI hope we can discuss the changes and merge it - so we can keep using the Gloss as our favorite JSON parsing library."},"comment":{"url":"https://api.github.com/repos/hkellaway/Gloss/issues/comments/255595248","html_url":"https://github.com/hkellaway/Gloss/pull/225#issuecomment-255595248","issue_url":"https://api.github.com/repos/hkellaway/Gloss/issues/225","id":255595248,"user":{"login":"hkellaway","id":5456481,"avatar_url":"https://avatars.githubusercontent.com/u/5456481?v=3","gravatar_id":"","url":"https://api.github.com/users/hkellaway","html_url":"https://github.com/hkellaway","followers_url":"https://api.github.com/users/hkellaway/followers","following_url":"https://api.github.com/users/hkellaway/following{/other_user}","gists_url":"https://api.github.com/users/hkellaway/gists{/gist_id}","starred_url":"https://api.github.com/users/hkellaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkellaway/subscriptions","organizations_url":"https://api.github.com/users/hkellaway/orgs","repos_url":"https://api.github.com/users/hkellaway/repos","events_url":"https://api.github.com/users/hkellaway/events{/privacy}","received_events_url":"https://api.github.com/users/hkellaway/received_events","type":"User","site_admin":false},"created_at":"2016-10-23T15:35:32Z","updated_at":"2016-10-23T15:35:32Z","body":"@ferusinfo another PR was just merged into `develop` that introduces a new type to decode/encode (`UUID`). can you rebase your PR on develop and update to include `UUID`?\r\n\r\n- [ ] rebase\r\n- [ ] update for UUID type"}}
{"actor":{"display_login":"hkellaway"}}