{"action":"closed","number":126,"pull_request":{"url":"https://api.github.com/repos/KnpLabs/knp-components/pulls/126","id":32882780,"html_url":"https://github.com/KnpLabs/knp-components/pull/126","diff_url":"https://github.com/KnpLabs/knp-components/pull/126.diff","patch_url":"https://github.com/KnpLabs/knp-components/pull/126.patch","issue_url":"https://api.github.com/repos/KnpLabs/knp-components/issues/126","number":126,"state":"closed","locked":false,"title":"Corrected distinct option","user":{"login":"MJBGO","id":8344487,"avatar_url":"https://avatars.githubusercontent.com/u/8344487?v=3","gravatar_id":"","url":"https://api.github.com/users/MJBGO","html_url":"https://github.com/MJBGO","followers_url":"https://api.github.com/users/MJBGO/followers","following_url":"https://api.github.com/users/MJBGO/following{/other_user}","gists_url":"https://api.github.com/users/MJBGO/gists{/gist_id}","starred_url":"https://api.github.com/users/MJBGO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MJBGO/subscriptions","organizations_url":"https://api.github.com/users/MJBGO/orgs","repos_url":"https://api.github.com/users/MJBGO/repos","events_url":"https://api.github.com/users/MJBGO/events{/privacy}","received_events_url":"https://api.github.com/users/MJBGO/received_events","type":"User","site_admin":false},"body":"| Q | A |\r\n| --- | --- |\r\n| Bug fix? | yes |\r\n| New feature? | no |\r\n| BC breaks? | no |\r\n| Deprecations? | no |\r\n| Tests pass? | yes|\r\n\r\nFix of the DISTINCT option.\r\n\r\nSince 1.3.0 (this commit https://github.com/KnpLabs/knp-components/commit/861c2a0b9b816be7e7f0b4106aa6be3f60e86226), the distinct option doesn't have the same effect.\r\n\r\n**Before 1.3.0**\r\n\r\n**distinct: false**\r\n![image](https://cloud.githubusercontent.com/assets/8344487/20690987/2cae057c-b5ce-11e6-995b-ba376d8c13c2.png)\r\n\r\n**distinct: true**\r\n![image](https://cloud.githubusercontent.com/assets/8344487/20691001/41544d06-b5ce-11e6-820c-8ea788dcdbe2.png)\r\n\r\n-----\r\n**1.3.3 without correction**\r\n\r\n**distinct: false**\r\n![image](https://cloud.githubusercontent.com/assets/8344487/20691251/ea09d15e-b5cf-11e6-8694-8c64e5cc5788.png)\r\n\r\n**distinct: true**\r\n![image](https://cloud.githubusercontent.com/assets/8344487/20691239/d770dd44-b5cf-11e6-990b-7ae319ec57a6.png)\r\n\r\n-----\r\n**1.3.3 with correction**\r\n\r\n**distinct: false**\r\n![capture11](https://cloud.githubusercontent.com/assets/8344487/20690888/8a95f006-b5cd-11e6-9145-4400beb17777.JPG)\r\n\r\n**distinct: true**\r\n![image](https://cloud.githubusercontent.com/assets/8344487/20723233/05821578-b66a-11e6-9f77-4c8b13279758.png)\r\n\r\n\r\nSee doctrine documentation : http://doctrine-orm.readthedocs.org/en/latest/tutorials/pagination.html\r\n","created_at":"2015-04-08T17:27:43Z","updated_at":"2016-12-06T18:05:13Z","closed_at":"2016-12-06T18:05:13Z","merged_at":"2016-12-06T18:05:13Z","merge_commit_sha":"6cedcd4c983c3718ade7aaae2071f57ff4b55cb8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KnpLabs/knp-components/pulls/126/commits","review_comments_url":"https://api.github.com/repos/KnpLabs/knp-components/pulls/126/comments","review_comment_url":"https://api.github.com/repos/KnpLabs/knp-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KnpLabs/knp-components/issues/126/comments","statuses_url":"https://api.github.com/repos/KnpLabs/knp-components/statuses/3d7bcdc8d6b82cb1d9d64d15e4a4fa464dc56e3b","head":{"label":"MJBGO:master","ref":"master","sha":"3d7bcdc8d6b82cb1d9d64d15e4a4fa464dc56e3b","user":{"login":"MJBGO","id":8344487,"avatar_url":"https://avatars.githubusercontent.com/u/8344487?v=3","gravatar_id":"","url":"https://api.github.com/users/MJBGO","html_url":"https://github.com/MJBGO","followers_url":"https://api.github.com/users/MJBGO/followers","following_url":"https://api.github.com/users/MJBGO/following{/other_user}","gists_url":"https://api.github.com/users/MJBGO/gists{/gist_id}","starred_url":"https://api.github.com/users/MJBGO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MJBGO/subscriptions","organizations_url":"https://api.github.com/users/MJBGO/orgs","repos_url":"https://api.github.com/users/MJBGO/repos","events_url":"https://api.github.com/users/MJBGO/events{/privacy}","received_events_url":"https://api.github.com/users/MJBGO/received_events","type":"User","site_admin":false},"repo":{"id":33620882,"name":"knp-components","full_name":"MJBGO/knp-components","owner":{"login":"MJBGO","id":8344487,"avatar_url":"https://avatars.githubusercontent.com/u/8344487?v=3","gravatar_id":"","url":"https://api.github.com/users/MJBGO","html_url":"https://github.com/MJBGO","followers_url":"https://api.github.com/users/MJBGO/followers","following_url":"https://api.github.com/users/MJBGO/following{/other_user}","gists_url":"https://api.github.com/users/MJBGO/gists{/gist_id}","starred_url":"https://api.github.com/users/MJBGO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MJBGO/subscriptions","organizations_url":"https://api.github.com/users/MJBGO/orgs","repos_url":"https://api.github.com/users/MJBGO/repos","events_url":"https://api.github.com/users/MJBGO/events{/privacy}","received_events_url":"https://api.github.com/users/MJBGO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MJBGO/knp-components","description":"Various component pack, includes paginator","fork":true,"url":"https://api.github.com/repos/MJBGO/knp-components","forks_url":"https://api.github.com/repos/MJBGO/knp-components/forks","keys_url":"https://api.github.com/repos/MJBGO/knp-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MJBGO/knp-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MJBGO/knp-components/teams","hooks_url":"https://api.github.com/repos/MJBGO/knp-components/hooks","issue_events_url":"https://api.github.com/repos/MJBGO/knp-components/issues/events{/number}","events_url":"https://api.github.com/repos/MJBGO/knp-components/events","assignees_url":"https://api.github.com/repos/MJBGO/knp-components/assignees{/user}","branches_url":"https://api.github.com/repos/MJBGO/knp-components/branches{/branch}","tags_url":"https://api.github.com/repos/MJBGO/knp-components/tags","blobs_url":"https://api.github.com/repos/MJBGO/knp-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MJBGO/knp-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MJBGO/knp-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/MJBGO/knp-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MJBGO/knp-components/statuses/{sha}","languages_url":"https://api.github.com/repos/MJBGO/knp-components/languages","stargazers_url":"https://api.github.com/repos/MJBGO/knp-components/stargazers","contributors_url":"https://api.github.com/repos/MJBGO/knp-components/contributors","subscribers_url":"https://api.github.com/repos/MJBGO/knp-components/subscribers","subscription_url":"https://api.github.com/repos/MJBGO/knp-components/subscription","commits_url":"https://api.github.com/repos/MJBGO/knp-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/MJBGO/knp-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/MJBGO/knp-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/MJBGO/knp-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/MJBGO/knp-components/contents/{+path}","compare_url":"https://api.github.com/repos/MJBGO/knp-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MJBGO/knp-components/merges","archive_url":"https://api.github.com/repos/MJBGO/knp-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MJBGO/knp-components/downloads","issues_url":"https://api.github.com/repos/MJBGO/knp-components/issues{/number}","pulls_url":"https://api.github.com/repos/MJBGO/knp-components/pulls{/number}","milestones_url":"https://api.github.com/repos/MJBGO/knp-components/milestones{/number}","notifications_url":"https://api.github.com/repos/MJBGO/knp-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MJBGO/knp-components/labels{/name}","releases_url":"https://api.github.com/repos/MJBGO/knp-components/releases{/id}","deployments_url":"https://api.github.com/repos/MJBGO/knp-components/deployments","created_at":"2015-04-08T17:15:09Z","updated_at":"2016-11-28T22:14:35Z","pushed_at":"2016-11-28T23:44:47Z","git_url":"git://github.com/MJBGO/knp-components.git","ssh_url":"git@github.com:MJBGO/knp-components.git","clone_url":"https://github.com/MJBGO/knp-components.git","svn_url":"https://github.com/MJBGO/knp-components","homepage":"","size":270,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KnpLabs:master","ref":"master","sha":"d8098bd137fdd01d0416b95b77b937c7b261c781","user":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2740269,"name":"knp-components","full_name":"KnpLabs/knp-components","owner":{"login":"KnpLabs","id":202732,"avatar_url":"https://avatars.githubusercontent.com/u/202732?v=3","gravatar_id":"","url":"https://api.github.com/users/KnpLabs","html_url":"https://github.com/KnpLabs","followers_url":"https://api.github.com/users/KnpLabs/followers","following_url":"https://api.github.com/users/KnpLabs/following{/other_user}","gists_url":"https://api.github.com/users/KnpLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/KnpLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnpLabs/subscriptions","organizations_url":"https://api.github.com/users/KnpLabs/orgs","repos_url":"https://api.github.com/users/KnpLabs/repos","events_url":"https://api.github.com/users/KnpLabs/events{/privacy}","received_events_url":"https://api.github.com/users/KnpLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KnpLabs/knp-components","description":"Various component pack, includes paginator","fork":false,"url":"https://api.github.com/repos/KnpLabs/knp-components","forks_url":"https://api.github.com/repos/KnpLabs/knp-components/forks","keys_url":"https://api.github.com/repos/KnpLabs/knp-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnpLabs/knp-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnpLabs/knp-components/teams","hooks_url":"https://api.github.com/repos/KnpLabs/knp-components/hooks","issue_events_url":"https://api.github.com/repos/KnpLabs/knp-components/issues/events{/number}","events_url":"https://api.github.com/repos/KnpLabs/knp-components/events","assignees_url":"https://api.github.com/repos/KnpLabs/knp-components/assignees{/user}","branches_url":"https://api.github.com/repos/KnpLabs/knp-components/branches{/branch}","tags_url":"https://api.github.com/repos/KnpLabs/knp-components/tags","blobs_url":"https://api.github.com/repos/KnpLabs/knp-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnpLabs/knp-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnpLabs/knp-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnpLabs/knp-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnpLabs/knp-components/statuses/{sha}","languages_url":"https://api.github.com/repos/KnpLabs/knp-components/languages","stargazers_url":"https://api.github.com/repos/KnpLabs/knp-components/stargazers","contributors_url":"https://api.github.com/repos/KnpLabs/knp-components/contributors","subscribers_url":"https://api.github.com/repos/KnpLabs/knp-components/subscribers","subscription_url":"https://api.github.com/repos/KnpLabs/knp-components/subscription","commits_url":"https://api.github.com/repos/KnpLabs/knp-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnpLabs/knp-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnpLabs/knp-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnpLabs/knp-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/KnpLabs/knp-components/contents/{+path}","compare_url":"https://api.github.com/repos/KnpLabs/knp-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnpLabs/knp-components/merges","archive_url":"https://api.github.com/repos/KnpLabs/knp-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnpLabs/knp-components/downloads","issues_url":"https://api.github.com/repos/KnpLabs/knp-components/issues{/number}","pulls_url":"https://api.github.com/repos/KnpLabs/knp-components/pulls{/number}","milestones_url":"https://api.github.com/repos/KnpLabs/knp-components/milestones{/number}","notifications_url":"https://api.github.com/repos/KnpLabs/knp-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnpLabs/knp-components/labels{/name}","releases_url":"https://api.github.com/repos/KnpLabs/knp-components/releases{/id}","deployments_url":"https://api.github.com/repos/KnpLabs/knp-components/deployments","created_at":"2011-11-09T08:31:50Z","updated_at":"2016-09-15T09:56:36Z","pushed_at":"2016-12-06T18:05:14Z","git_url":"git://github.com/KnpLabs/knp-components.git","ssh_url":"git@github.com:KnpLabs/knp-components.git","clone_url":"https://github.com/KnpLabs/knp-components.git","svn_url":"https://github.com/KnpLabs/knp-components","homepage":"","size":414,"stargazers_count":72,"watchers_count":72,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":46,"forks":96,"open_issues":46,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnpLabs/knp-components/pulls/126"},"html":{"href":"https://github.com/KnpLabs/knp-components/pull/126"},"issue":{"href":"https://api.github.com/repos/KnpLabs/knp-components/issues/126"},"comments":{"href":"https://api.github.com/repos/KnpLabs/knp-components/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/KnpLabs/knp-components/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/KnpLabs/knp-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KnpLabs/knp-components/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/KnpLabs/knp-components/statuses/3d7bcdc8d6b82cb1d9d64d15e4a4fa464dc56e3b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"l3pp4rd","id":132389,"avatar_url":"https://avatars.githubusercontent.com/u/132389?v=3","gravatar_id":"","url":"https://api.github.com/users/l3pp4rd","html_url":"https://github.com/l3pp4rd","followers_url":"https://api.github.com/users/l3pp4rd/followers","following_url":"https://api.github.com/users/l3pp4rd/following{/other_user}","gists_url":"https://api.github.com/users/l3pp4rd/gists{/gist_id}","starred_url":"https://api.github.com/users/l3pp4rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l3pp4rd/subscriptions","organizations_url":"https://api.github.com/users/l3pp4rd/orgs","repos_url":"https://api.github.com/users/l3pp4rd/repos","events_url":"https://api.github.com/users/l3pp4rd/events{/privacy}","received_events_url":"https://api.github.com/users/l3pp4rd/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"l3pp4rd"}}