{"action":"reopened","number":1047,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1047","id":74391863,"html_url":"https://github.com/apache/zeppelin/pull/1047","diff_url":"https://github.com/apache/zeppelin/pull/1047.diff","patch_url":"https://github.com/apache/zeppelin/pull/1047.patch","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1047","number":1047,"state":"open","locked":false,"title":"[ TEST ] Selenium test modified according to Shiro failed the test.","user":{"login":"cloverhearts","id":10525473,"avatar_url":"https://avatars.githubusercontent.com/u/10525473?v=3","gravatar_id":"","url":"https://api.github.com/users/cloverhearts","html_url":"https://github.com/cloverhearts","followers_url":"https://api.github.com/users/cloverhearts/followers","following_url":"https://api.github.com/users/cloverhearts/following{/other_user}","gists_url":"https://api.github.com/users/cloverhearts/gists{/gist_id}","starred_url":"https://api.github.com/users/cloverhearts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloverhearts/subscriptions","organizations_url":"https://api.github.com/users/cloverhearts/orgs","repos_url":"https://api.github.com/users/cloverhearts/repos","events_url":"https://api.github.com/users/cloverhearts/events{/privacy}","received_events_url":"https://api.github.com/users/cloverhearts/received_events","type":"User","site_admin":false},"body":"### What is this PR for?\r\nShiro web test is included as an element of Selenium web test.\r\nHowever, Shiro test case is to restart the zeppelin server.\r\nAs a result, the Selenium test does not work properly.\r\n- Shiro modified to proceed to the last test.\r\n\r\n```java\r\npublic class AuthenticationIT extends AbstractZeppelinIT {\r\n  @BeforeClass\r\n  public static void startUp() {\r\n    if (!endToEndTestEnabled()) {\r\n      return;\r\n    }\r\n\r\n    try {\r\n      ZeppelinConfiguration conf = ZeppelinConfiguration.create();\r\n      File file = new File(conf.getShiroPath());\r\n      originalShiro = StringUtils.join(FileUtils.readLines(file, \"UTF-8\"), \"\\n\");\r\n      FileUtils.write(file, authShiro, \"UTF-8\");\r\n    } catch (IOException e) {\r\n      LOG.error(\"Error in AuthenticationIT startUp::\", e);\r\n    }\r\n    ZeppelinITUtils.restartZeppelin(); // <---- restart\r\n    driver = WebDriverManager.getWebDriver();\r\n  }\r\n\r\n\r\n  @AfterClass\r\n  public static void tearDown() {\r\n    if (!endToEndTestEnabled()) {\r\n      return;\r\n    }\r\n    try {\r\n      ZeppelinConfiguration conf = ZeppelinConfiguration.create();\r\n      File file = new File(conf.getShiroPath());\r\n      FileUtils.write(file, originalShiro, \"UTF-8\");\r\n    } catch (IOException e) {\r\n      LOG.error(\"Error in AuthenticationIT tearDown::\", e);\r\n    }\r\n    ZeppelinITUtils.restartZeppelin(); // <----- restart\r\n    driver.quit();\r\n  }\r\n}\r\n```\r\n\r\n### What type of PR is it?\r\nBug Fix\r\n\r\n### Todos\r\n- [x] added plugin (maven-surefire) in zeppelin-server pom.\r\n- [x] modified class name \r\n      (AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test\r\n\r\n### How should this be tested?\r\nthis is a travis result issue.\r\n\r\n### Questions:\r\n* Does the licenses files need update? no\r\n* Is there breaking changes for older versions? no\r\n* Does this needs documentation? no\r\n\r\n","created_at":"2016-06-20T05:43:29Z","updated_at":"2016-06-20T12:32:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ce73665d6814eb502dfe65d00117e102c3bb7f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/zeppelin/pulls/1047/commits","review_comments_url":"https://api.github.com/repos/apache/zeppelin/pulls/1047/comments","review_comment_url":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1047/comments","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/4982f8dee654633083214da53454ab90d26fce90","head":{"label":"cloverhearts:cifail/selenium-testfailed-via-auth","ref":"cifail/selenium-testfailed-via-auth","sha":"4982f8dee654633083214da53454ab90d26fce90","user":{"login":"cloverhearts","id":10525473,"avatar_url":"https://avatars.githubusercontent.com/u/10525473?v=3","gravatar_id":"","url":"https://api.github.com/users/cloverhearts","html_url":"https://github.com/cloverhearts","followers_url":"https://api.github.com/users/cloverhearts/followers","following_url":"https://api.github.com/users/cloverhearts/following{/other_user}","gists_url":"https://api.github.com/users/cloverhearts/gists{/gist_id}","starred_url":"https://api.github.com/users/cloverhearts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloverhearts/subscriptions","organizations_url":"https://api.github.com/users/cloverhearts/orgs","repos_url":"https://api.github.com/users/cloverhearts/repos","events_url":"https://api.github.com/users/cloverhearts/events{/privacy}","received_events_url":"https://api.github.com/users/cloverhearts/received_events","type":"User","site_admin":false},"repo":{"id":57196422,"name":"zeppelin","full_name":"cloverhearts/zeppelin","owner":{"login":"cloverhearts","id":10525473,"avatar_url":"https://avatars.githubusercontent.com/u/10525473?v=3","gravatar_id":"","url":"https://api.github.com/users/cloverhearts","html_url":"https://github.com/cloverhearts","followers_url":"https://api.github.com/users/cloverhearts/followers","following_url":"https://api.github.com/users/cloverhearts/following{/other_user}","gists_url":"https://api.github.com/users/cloverhearts/gists{/gist_id}","starred_url":"https://api.github.com/users/cloverhearts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloverhearts/subscriptions","organizations_url":"https://api.github.com/users/cloverhearts/orgs","repos_url":"https://api.github.com/users/cloverhearts/repos","events_url":"https://api.github.com/users/cloverhearts/events{/privacy}","received_events_url":"https://api.github.com/users/cloverhearts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cloverhearts/zeppelin","description":"Mirror of Apache Zeppelin (Incubating)","fork":true,"url":"https://api.github.com/repos/cloverhearts/zeppelin","forks_url":"https://api.github.com/repos/cloverhearts/zeppelin/forks","keys_url":"https://api.github.com/repos/cloverhearts/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloverhearts/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloverhearts/zeppelin/teams","hooks_url":"https://api.github.com/repos/cloverhearts/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/cloverhearts/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/cloverhearts/zeppelin/events","assignees_url":"https://api.github.com/repos/cloverhearts/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/cloverhearts/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/cloverhearts/zeppelin/tags","blobs_url":"https://api.github.com/repos/cloverhearts/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloverhearts/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloverhearts/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloverhearts/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloverhearts/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/cloverhearts/zeppelin/languages","stargazers_url":"https://api.github.com/repos/cloverhearts/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/cloverhearts/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/cloverhearts/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/cloverhearts/zeppelin/subscription","commits_url":"https://api.github.com/repos/cloverhearts/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloverhearts/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloverhearts/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloverhearts/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloverhearts/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/cloverhearts/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloverhearts/zeppelin/merges","archive_url":"https://api.github.com/repos/cloverhearts/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloverhearts/zeppelin/downloads","issues_url":"https://api.github.com/repos/cloverhearts/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/cloverhearts/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/cloverhearts/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/cloverhearts/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloverhearts/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/cloverhearts/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/cloverhearts/zeppelin/deployments","created_at":"2016-04-27T08:18:40Z","updated_at":"2016-06-10T02:17:24Z","pushed_at":"2016-06-20T11:53:29Z","git_url":"git://github.com/cloverhearts/zeppelin.git","ssh_url":"git@github.com:cloverhearts/zeppelin.git","clone_url":"https://github.com/cloverhearts/zeppelin.git","svn_url":"https://github.com/cloverhearts/zeppelin","homepage":null,"size":28691,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7fd9a66000dc549c4f08a0078aa70b6403cf4e34","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32848140,"name":"zeppelin","full_name":"apache/zeppelin","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/zeppelin","description":"Mirror of Apache Zeppelin","fork":false,"url":"https://api.github.com/repos/apache/zeppelin","forks_url":"https://api.github.com/repos/apache/zeppelin/forks","keys_url":"https://api.github.com/repos/apache/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zeppelin/teams","hooks_url":"https://api.github.com/repos/apache/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/apache/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zeppelin/events","assignees_url":"https://api.github.com/repos/apache/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zeppelin/tags","blobs_url":"https://api.github.com/repos/apache/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zeppelin/languages","stargazers_url":"https://api.github.com/repos/apache/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/apache/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/apache/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/apache/zeppelin/subscription","commits_url":"https://api.github.com/repos/apache/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zeppelin/merges","archive_url":"https://api.github.com/repos/apache/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zeppelin/downloads","issues_url":"https://api.github.com/repos/apache/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/apache/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zeppelin/deployments","created_at":"2015-03-25T07:00:06Z","updated_at":"2016-06-20T12:24:30Z","pushed_at":"2016-06-20T11:53:30Z","git_url":"git://github.com/apache/zeppelin.git","ssh_url":"git@github.com:apache/zeppelin.git","clone_url":"https://github.com/apache/zeppelin.git","svn_url":"https://github.com/apache/zeppelin","homepage":"","size":105565,"stargazers_count":1579,"watchers_count":1579,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":801,"mirror_url":"git://git.apache.org/incubator-zeppelin.git","open_issues_count":108,"forks":801,"open_issues":108,"watchers":1579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/1047"},"html":{"href":"https://github.com/apache/zeppelin/pull/1047"},"issue":{"href":"https://api.github.com/repos/apache/zeppelin/issues/1047"},"comments":{"href":"https://api.github.com/repos/apache/zeppelin/issues/1047/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/1047/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/1047/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zeppelin/statuses/4982f8dee654633083214da53454ab90d26fce90"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":12,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"cloverhearts"}}