{"action":"closed","number":1272,"pull_request":{"url":"https://api.github.com/repos/octokit/octokit.net/pulls/1272","id":66835702,"html_url":"https://github.com/octokit/octokit.net/pull/1272","diff_url":"https://github.com/octokit/octokit.net/pull/1272.diff","patch_url":"https://github.com/octokit/octokit.net/pull/1272.patch","issue_url":"https://api.github.com/repos/octokit/octokit.net/issues/1272","number":1272,"state":"closed","locked":false,"title":"Add ApiOption overloads to methods on IRepositoryHooksClient","user":{"login":"dampir","id":3888372,"avatar_url":"https://avatars.githubusercontent.com/u/3888372?v=3","gravatar_id":"","url":"https://api.github.com/users/dampir","html_url":"https://github.com/dampir","followers_url":"https://api.github.com/users/dampir/followers","following_url":"https://api.github.com/users/dampir/following{/other_user}","gists_url":"https://api.github.com/users/dampir/gists{/gist_id}","starred_url":"https://api.github.com/users/dampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dampir/subscriptions","organizations_url":"https://api.github.com/users/dampir/orgs","repos_url":"https://api.github.com/users/dampir/repos","events_url":"https://api.github.com/users/dampir/events{/privacy}","received_events_url":"https://api.github.com/users/dampir/received_events","type":"User","site_admin":false},"body":"Fixes #1149 .\r\n\r\nTo-do:\r\n\r\n - [x]  Add overload <Task> GetAll(ApiOptions options) on IRepositoryHooksClient.\r\n - [x]  Add overload IObservable GetAll(ApiOptions options) on IObservableRepositoryHooksClient.\r\n - [x]  Add unit tests for these new methods.\r\n - [x]  Add integration tests for these new methods.\r\n\r\nPlease review these changes, especially changes in RepositoriesHooksFixture.cs. I had to change it in order to get additional hooks and properly test methods with ApiOptions parameter.\r\n\r\n/cc @shiftkey, @ryangribble ","created_at":"2016-04-18T11:11:35Z","updated_at":"2016-04-19T07:08:02Z","closed_at":"2016-04-19T07:08:02Z","merged_at":"2016-04-19T07:08:02Z","merge_commit_sha":"190ccf04c2ea978410d74659b1669887b24d3e88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/octokit/octokit.net/pulls/1272/commits","review_comments_url":"https://api.github.com/repos/octokit/octokit.net/pulls/1272/comments","review_comment_url":"https://api.github.com/repos/octokit/octokit.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/octokit/octokit.net/issues/1272/comments","statuses_url":"https://api.github.com/repos/octokit/octokit.net/statuses/c595d4d1d2eaae73300680101219d25c762442fa","head":{"label":"dampir:fixes-1177","ref":"fixes-1177","sha":"c595d4d1d2eaae73300680101219d25c762442fa","user":{"login":"dampir","id":3888372,"avatar_url":"https://avatars.githubusercontent.com/u/3888372?v=3","gravatar_id":"","url":"https://api.github.com/users/dampir","html_url":"https://github.com/dampir","followers_url":"https://api.github.com/users/dampir/followers","following_url":"https://api.github.com/users/dampir/following{/other_user}","gists_url":"https://api.github.com/users/dampir/gists{/gist_id}","starred_url":"https://api.github.com/users/dampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dampir/subscriptions","organizations_url":"https://api.github.com/users/dampir/orgs","repos_url":"https://api.github.com/users/dampir/repos","events_url":"https://api.github.com/users/dampir/events{/privacy}","received_events_url":"https://api.github.com/users/dampir/received_events","type":"User","site_admin":false},"repo":{"id":53028639,"name":"octokit.net","full_name":"dampir/octokit.net","owner":{"login":"dampir","id":3888372,"avatar_url":"https://avatars.githubusercontent.com/u/3888372?v=3","gravatar_id":"","url":"https://api.github.com/users/dampir","html_url":"https://github.com/dampir","followers_url":"https://api.github.com/users/dampir/followers","following_url":"https://api.github.com/users/dampir/following{/other_user}","gists_url":"https://api.github.com/users/dampir/gists{/gist_id}","starred_url":"https://api.github.com/users/dampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dampir/subscriptions","organizations_url":"https://api.github.com/users/dampir/orgs","repos_url":"https://api.github.com/users/dampir/repos","events_url":"https://api.github.com/users/dampir/events{/privacy}","received_events_url":"https://api.github.com/users/dampir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dampir/octokit.net","description":"My contribution in GitHub API client library for .NET ","fork":true,"url":"https://api.github.com/repos/dampir/octokit.net","forks_url":"https://api.github.com/repos/dampir/octokit.net/forks","keys_url":"https://api.github.com/repos/dampir/octokit.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dampir/octokit.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dampir/octokit.net/teams","hooks_url":"https://api.github.com/repos/dampir/octokit.net/hooks","issue_events_url":"https://api.github.com/repos/dampir/octokit.net/issues/events{/number}","events_url":"https://api.github.com/repos/dampir/octokit.net/events","assignees_url":"https://api.github.com/repos/dampir/octokit.net/assignees{/user}","branches_url":"https://api.github.com/repos/dampir/octokit.net/branches{/branch}","tags_url":"https://api.github.com/repos/dampir/octokit.net/tags","blobs_url":"https://api.github.com/repos/dampir/octokit.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dampir/octokit.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dampir/octokit.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/dampir/octokit.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dampir/octokit.net/statuses/{sha}","languages_url":"https://api.github.com/repos/dampir/octokit.net/languages","stargazers_url":"https://api.github.com/repos/dampir/octokit.net/stargazers","contributors_url":"https://api.github.com/repos/dampir/octokit.net/contributors","subscribers_url":"https://api.github.com/repos/dampir/octokit.net/subscribers","subscription_url":"https://api.github.com/repos/dampir/octokit.net/subscription","commits_url":"https://api.github.com/repos/dampir/octokit.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/dampir/octokit.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/dampir/octokit.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/dampir/octokit.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/dampir/octokit.net/contents/{+path}","compare_url":"https://api.github.com/repos/dampir/octokit.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dampir/octokit.net/merges","archive_url":"https://api.github.com/repos/dampir/octokit.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dampir/octokit.net/downloads","issues_url":"https://api.github.com/repos/dampir/octokit.net/issues{/number}","pulls_url":"https://api.github.com/repos/dampir/octokit.net/pulls{/number}","milestones_url":"https://api.github.com/repos/dampir/octokit.net/milestones{/number}","notifications_url":"https://api.github.com/repos/dampir/octokit.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dampir/octokit.net/labels{/name}","releases_url":"https://api.github.com/repos/dampir/octokit.net/releases{/id}","deployments_url":"https://api.github.com/repos/dampir/octokit.net/deployments","created_at":"2016-03-03T07:01:00Z","updated_at":"2016-03-25T06:07:07Z","pushed_at":"2016-04-19T07:00:43Z","git_url":"git://github.com/dampir/octokit.net.git","ssh_url":"git@github.com:dampir/octokit.net.git","clone_url":"https://github.com/dampir/octokit.net.git","svn_url":"https://github.com/dampir/octokit.net","homepage":"","size":83400,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"octokit:master","ref":"master","sha":"09ea3b26e1eeca48562944b18ea27385df9e6979","user":{"login":"octokit","id":3430433,"avatar_url":"https://avatars.githubusercontent.com/u/3430433?v=3","gravatar_id":"","url":"https://api.github.com/users/octokit","html_url":"https://github.com/octokit","followers_url":"https://api.github.com/users/octokit/followers","following_url":"https://api.github.com/users/octokit/following{/other_user}","gists_url":"https://api.github.com/users/octokit/gists{/gist_id}","starred_url":"https://api.github.com/users/octokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octokit/subscriptions","organizations_url":"https://api.github.com/users/octokit/orgs","repos_url":"https://api.github.com/users/octokit/repos","events_url":"https://api.github.com/users/octokit/events{/privacy}","received_events_url":"https://api.github.com/users/octokit/received_events","type":"Organization","site_admin":false},"repo":{"id":7528679,"name":"octokit.net","full_name":"octokit/octokit.net","owner":{"login":"octokit","id":3430433,"avatar_url":"https://avatars.githubusercontent.com/u/3430433?v=3","gravatar_id":"","url":"https://api.github.com/users/octokit","html_url":"https://github.com/octokit","followers_url":"https://api.github.com/users/octokit/followers","following_url":"https://api.github.com/users/octokit/following{/other_user}","gists_url":"https://api.github.com/users/octokit/gists{/gist_id}","starred_url":"https://api.github.com/users/octokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octokit/subscriptions","organizations_url":"https://api.github.com/users/octokit/orgs","repos_url":"https://api.github.com/users/octokit/repos","events_url":"https://api.github.com/users/octokit/events{/privacy}","received_events_url":"https://api.github.com/users/octokit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/octokit/octokit.net","description":"A GitHub API client library for .NET ","fork":false,"url":"https://api.github.com/repos/octokit/octokit.net","forks_url":"https://api.github.com/repos/octokit/octokit.net/forks","keys_url":"https://api.github.com/repos/octokit/octokit.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octokit/octokit.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octokit/octokit.net/teams","hooks_url":"https://api.github.com/repos/octokit/octokit.net/hooks","issue_events_url":"https://api.github.com/repos/octokit/octokit.net/issues/events{/number}","events_url":"https://api.github.com/repos/octokit/octokit.net/events","assignees_url":"https://api.github.com/repos/octokit/octokit.net/assignees{/user}","branches_url":"https://api.github.com/repos/octokit/octokit.net/branches{/branch}","tags_url":"https://api.github.com/repos/octokit/octokit.net/tags","blobs_url":"https://api.github.com/repos/octokit/octokit.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octokit/octokit.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octokit/octokit.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/octokit/octokit.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octokit/octokit.net/statuses/{sha}","languages_url":"https://api.github.com/repos/octokit/octokit.net/languages","stargazers_url":"https://api.github.com/repos/octokit/octokit.net/stargazers","contributors_url":"https://api.github.com/repos/octokit/octokit.net/contributors","subscribers_url":"https://api.github.com/repos/octokit/octokit.net/subscribers","subscription_url":"https://api.github.com/repos/octokit/octokit.net/subscription","commits_url":"https://api.github.com/repos/octokit/octokit.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/octokit/octokit.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/octokit/octokit.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/octokit/octokit.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/octokit/octokit.net/contents/{+path}","compare_url":"https://api.github.com/repos/octokit/octokit.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octokit/octokit.net/merges","archive_url":"https://api.github.com/repos/octokit/octokit.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octokit/octokit.net/downloads","issues_url":"https://api.github.com/repos/octokit/octokit.net/issues{/number}","pulls_url":"https://api.github.com/repos/octokit/octokit.net/pulls{/number}","milestones_url":"https://api.github.com/repos/octokit/octokit.net/milestones{/number}","notifications_url":"https://api.github.com/repos/octokit/octokit.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octokit/octokit.net/labels{/name}","releases_url":"https://api.github.com/repos/octokit/octokit.net/releases{/id}","deployments_url":"https://api.github.com/repos/octokit/octokit.net/deployments","created_at":"2013-01-09T20:48:45Z","updated_at":"2016-04-15T02:33:25Z","pushed_at":"2016-04-19T07:08:02Z","git_url":"git://github.com/octokit/octokit.net.git","ssh_url":"git@github.com:octokit/octokit.net.git","clone_url":"https://github.com/octokit/octokit.net.git","svn_url":"https://github.com/octokit/octokit.net","homepage":null,"size":90503,"stargazers_count":922,"watchers_count":922,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":460,"mirror_url":null,"open_issues_count":130,"forks":460,"open_issues":130,"watchers":922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/1272"},"html":{"href":"https://github.com/octokit/octokit.net/pull/1272"},"issue":{"href":"https://api.github.com/repos/octokit/octokit.net/issues/1272"},"comments":{"href":"https://api.github.com/repos/octokit/octokit.net/issues/1272/comments"},"review_comments":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/1272/comments"},"review_comment":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/1272/commits"},"statuses":{"href":"https://api.github.com/repos/octokit/octokit.net/statuses/c595d4d1d2eaae73300680101219d25c762442fa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"comments":2,"review_comments":0,"commits":6,"additions":370,"deletions":11,"changed_files":11}}