{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/55943151","id":55943151,"diff_hunk":"@@ -105,9 +108,13 @@ public static Thing createThing(ThingUID thingUID, Configuration configuration,\n         for (ThingHandlerFactory thingHandlerFactory : thingHandlerFactories) {\n             if (thingHandlerFactory.supportsThingType(thingTypeUID)) {\n                 Thing thing = thingHandlerFactory.createThing(thingTypeUID, configuration, thingUID, bridgeUID);\n-                if (properties != null) {\n-                    for (String key : properties.keySet()) {\n-                        thing.setProperty(key, properties.get(key));\n+                if (thing == null) {\n+                    logger.error(\"Thing factory returned null when it reports to support the thing\");","path":"bundles/core/org.eclipse.smarthome.core.thing/src/main/java/org/eclipse/smarthome/core/thing/binding/ThingFactory.java","position":25,"original_position":25,"commit_id":"dd611ceddb789a6e92b9249098a13c5e1e958319","original_commit_id":"dd611ceddb789a6e92b9249098a13c5e1e958319","user":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars.githubusercontent.com/u/204670?v=3","gravatar_id":"","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"body":"Perhaps we could also add the thing handler factory class and all the UIDs.\r\nWhat do you think, IMHO this more verbose message will identify the handler easier.","created_at":"2016-03-13T20:30:15Z","updated_at":"2016-03-13T20:30:15Z","html_url":"https://github.com/eclipse/smarthome/pull/1172#discussion_r55943151","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1172","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/55943151"},"html":{"href":"https://github.com/eclipse/smarthome/pull/1172#discussion_r55943151"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1172"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/1172","id":62653538,"html_url":"https://github.com/eclipse/smarthome/pull/1172","diff_url":"https://github.com/eclipse/smarthome/pull/1172.diff","patch_url":"https://github.com/eclipse/smarthome/pull/1172.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/1172","number":1172,"state":"open","locked":false,"title":"Fix NPE in thing factory","user":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"body":"`thingHandlerFactory.createThing` may return null in which case NPE is thrown here when we try and access the thing. Checking for this ultimately results in the 'no binding supports the thing type' response.\r\nSigned-off-by: Chris Jackson <chris@cd-jackson.com>","created_at":"2016-03-12T21:54:06Z","updated_at":"2016-03-13T20:30:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f5d413f0a09bc1b527d3c63718fbb0f1c3bd1ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1172/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1172/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/1172/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/dd611ceddb789a6e92b9249098a13c5e1e958319","head":{"label":"cdjackson:thing_factory","ref":"thing_factory","sha":"dd611ceddb789a6e92b9249098a13c5e1e958319","user":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"repo":{"id":17073319,"name":"smarthome","full_name":"cdjackson/smarthome","owner":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdjackson/smarthome","description":"Eclipse SmartHome project","fork":true,"url":"https://api.github.com/repos/cdjackson/smarthome","forks_url":"https://api.github.com/repos/cdjackson/smarthome/forks","keys_url":"https://api.github.com/repos/cdjackson/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdjackson/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdjackson/smarthome/teams","hooks_url":"https://api.github.com/repos/cdjackson/smarthome/hooks","issue_events_url":"https://api.github.com/repos/cdjackson/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/cdjackson/smarthome/events","assignees_url":"https://api.github.com/repos/cdjackson/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/cdjackson/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/cdjackson/smarthome/tags","blobs_url":"https://api.github.com/repos/cdjackson/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdjackson/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdjackson/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdjackson/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdjackson/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/cdjackson/smarthome/languages","stargazers_url":"https://api.github.com/repos/cdjackson/smarthome/stargazers","contributors_url":"https://api.github.com/repos/cdjackson/smarthome/contributors","subscribers_url":"https://api.github.com/repos/cdjackson/smarthome/subscribers","subscription_url":"https://api.github.com/repos/cdjackson/smarthome/subscription","commits_url":"https://api.github.com/repos/cdjackson/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdjackson/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdjackson/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdjackson/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdjackson/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/cdjackson/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdjackson/smarthome/merges","archive_url":"https://api.github.com/repos/cdjackson/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdjackson/smarthome/downloads","issues_url":"https://api.github.com/repos/cdjackson/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/cdjackson/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/cdjackson/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/cdjackson/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdjackson/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/cdjackson/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/cdjackson/smarthome/deployments","created_at":"2014-02-21T23:24:18Z","updated_at":"2016-01-23T18:32:58Z","pushed_at":"2016-03-13T20:23:50Z","git_url":"git://github.com/cdjackson/smarthome.git","ssh_url":"git@github.com:cdjackson/smarthome.git","clone_url":"https://github.com/cdjackson/smarthome.git","svn_url":"https://github.com/cdjackson/smarthome","homepage":null,"size":14829,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"b52539b15e0950807bbd2caa6f4846ce94fc899b","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2016-03-12T07:44:40Z","pushed_at":"2016-03-13T20:23:50Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":null,"size":28960,"stargazers_count":260,"watchers_count":260,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":258,"mirror_url":null,"open_issues_count":175,"forks":258,"open_issues":175,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1172"},"html":{"href":"https://github.com/eclipse/smarthome/pull/1172"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/1172"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/1172/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1172/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1172/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/dd611ceddb789a6e92b9249098a13c5e1e958319"}}}}