{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/72894456","id":72894456,"diff_hunk":"@@ -1241,7 +1248,14 @@ MaxType!T max(T...)(T args)\n \n     //Do the \"max\" proper with a and b\n     import std.functional : lessThan;\n-    immutable chooseB = lessThan!(T0, T1)(a, b);\n+    import std.math : isNaN;\n+    static if (propagateNaN && isFloatingPoint!T1)\n+        immutable chooseB = lessThan(a, b) || isNaN(b);\n+    else static if (!propagateNaN && isFloatingPoint!T0)","path":"std/algorithm/comparison.d","position":61,"original_position":59,"commit_id":"a50d4f88effa49f540b18e8558dd7967461e4645","original_commit_id":"54f2cf2e51a163b6e4e9e0c815b85b9590f229a1","user":{"login":"9il","id":845083,"avatar_url":"https://avatars.githubusercontent.com/u/845083?v=3","gravatar_id":"","url":"https://api.github.com/users/9il","html_url":"https://github.com/9il","followers_url":"https://api.github.com/users/9il/followers","following_url":"https://api.github.com/users/9il/following{/other_user}","gists_url":"https://api.github.com/users/9il/gists{/gist_id}","starred_url":"https://api.github.com/users/9il/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9il/subscriptions","organizations_url":"https://api.github.com/users/9il/orgs","repos_url":"https://api.github.com/users/9il/repos","events_url":"https://api.github.com/users/9il/events{/privacy}","received_events_url":"https://api.github.com/users/9il/received_events","type":"User","site_admin":false},"body":"the behaviour by default should be the same as it was.","created_at":"2016-07-30T21:27:55Z","updated_at":"2016-07-30T21:27:55Z","html_url":"https://github.com/dlang/phobos/pull/3217#discussion_r72894456","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/3217","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/72894456"},"html":{"href":"https://github.com/dlang/phobos/pull/3217#discussion_r72894456"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/3217"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/3217","id":33971515,"html_url":"https://github.com/dlang/phobos/pull/3217","diff_url":"https://github.com/dlang/phobos/pull/3217.diff","patch_url":"https://github.com/dlang/phobos/pull/3217.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/3217","number":3217,"state":"open","locked":false,"title":"Partial fix for issue 10448: add opt-out NaN propagation to min and max","user":{"login":"ivan-timokhin","id":9802104,"avatar_url":"https://avatars.githubusercontent.com/u/9802104?v=3","gravatar_id":"","url":"https://api.github.com/users/ivan-timokhin","html_url":"https://github.com/ivan-timokhin","followers_url":"https://api.github.com/users/ivan-timokhin/followers","following_url":"https://api.github.com/users/ivan-timokhin/following{/other_user}","gists_url":"https://api.github.com/users/ivan-timokhin/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan-timokhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan-timokhin/subscriptions","organizations_url":"https://api.github.com/users/ivan-timokhin/orgs","repos_url":"https://api.github.com/users/ivan-timokhin/repos","events_url":"https://api.github.com/users/ivan-timokhin/events{/privacy}","received_events_url":"https://api.github.com/users/ivan-timokhin/received_events","type":"User","site_admin":false},"body":"With this change, both `min` and `max` will propagate NaN by default, and ignore it (mimicking behaviour of C `fmin` and `fmax`) if requested.\r\n\r\nhttps://issues.dlang.org/show_bug.cgi?id=10448","created_at":"2015-04-23T16:15:04Z","updated_at":"2016-07-30T21:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53910334e8a187ef497b64d1756dd6e91541f2aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/3217/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/3217/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/3217/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/a50d4f88effa49f540b18e8558dd7967461e4645","head":{"label":"ivan-timokhin:minmaxFP","ref":"minmaxFP","sha":"a50d4f88effa49f540b18e8558dd7967461e4645","user":{"login":"ivan-timokhin","id":9802104,"avatar_url":"https://avatars.githubusercontent.com/u/9802104?v=3","gravatar_id":"","url":"https://api.github.com/users/ivan-timokhin","html_url":"https://github.com/ivan-timokhin","followers_url":"https://api.github.com/users/ivan-timokhin/followers","following_url":"https://api.github.com/users/ivan-timokhin/following{/other_user}","gists_url":"https://api.github.com/users/ivan-timokhin/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan-timokhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan-timokhin/subscriptions","organizations_url":"https://api.github.com/users/ivan-timokhin/orgs","repos_url":"https://api.github.com/users/ivan-timokhin/repos","events_url":"https://api.github.com/users/ivan-timokhin/events{/privacy}","received_events_url":"https://api.github.com/users/ivan-timokhin/received_events","type":"User","site_admin":false},"repo":{"id":31202260,"name":"phobos","full_name":"ivan-timokhin/phobos","owner":{"login":"ivan-timokhin","id":9802104,"avatar_url":"https://avatars.githubusercontent.com/u/9802104?v=3","gravatar_id":"","url":"https://api.github.com/users/ivan-timokhin","html_url":"https://github.com/ivan-timokhin","followers_url":"https://api.github.com/users/ivan-timokhin/followers","following_url":"https://api.github.com/users/ivan-timokhin/following{/other_user}","gists_url":"https://api.github.com/users/ivan-timokhin/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan-timokhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan-timokhin/subscriptions","organizations_url":"https://api.github.com/users/ivan-timokhin/orgs","repos_url":"https://api.github.com/users/ivan-timokhin/repos","events_url":"https://api.github.com/users/ivan-timokhin/events{/privacy}","received_events_url":"https://api.github.com/users/ivan-timokhin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivan-timokhin/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/ivan-timokhin/phobos","forks_url":"https://api.github.com/repos/ivan-timokhin/phobos/forks","keys_url":"https://api.github.com/repos/ivan-timokhin/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivan-timokhin/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivan-timokhin/phobos/teams","hooks_url":"https://api.github.com/repos/ivan-timokhin/phobos/hooks","issue_events_url":"https://api.github.com/repos/ivan-timokhin/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/ivan-timokhin/phobos/events","assignees_url":"https://api.github.com/repos/ivan-timokhin/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/ivan-timokhin/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/ivan-timokhin/phobos/tags","blobs_url":"https://api.github.com/repos/ivan-timokhin/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivan-timokhin/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivan-timokhin/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivan-timokhin/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivan-timokhin/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/ivan-timokhin/phobos/languages","stargazers_url":"https://api.github.com/repos/ivan-timokhin/phobos/stargazers","contributors_url":"https://api.github.com/repos/ivan-timokhin/phobos/contributors","subscribers_url":"https://api.github.com/repos/ivan-timokhin/phobos/subscribers","subscription_url":"https://api.github.com/repos/ivan-timokhin/phobos/subscription","commits_url":"https://api.github.com/repos/ivan-timokhin/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivan-timokhin/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivan-timokhin/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivan-timokhin/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivan-timokhin/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/ivan-timokhin/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivan-timokhin/phobos/merges","archive_url":"https://api.github.com/repos/ivan-timokhin/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivan-timokhin/phobos/downloads","issues_url":"https://api.github.com/repos/ivan-timokhin/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/ivan-timokhin/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/ivan-timokhin/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/ivan-timokhin/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivan-timokhin/phobos/labels{/name}","releases_url":"https://api.github.com/repos/ivan-timokhin/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/ivan-timokhin/phobos/deployments","created_at":"2015-02-23T09:59:54Z","updated_at":"2015-02-23T09:59:58Z","pushed_at":"2016-07-30T20:20:02Z","git_url":"git://github.com/ivan-timokhin/phobos.git","ssh_url":"git@github.com:ivan-timokhin/phobos.git","clone_url":"https://github.com/ivan-timokhin/phobos.git","svn_url":"https://github.com/ivan-timokhin/phobos","homepage":"dlang.org/phobos","size":45329,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"69c00bc1a9ea94f3c49a055f56906e6abf491642","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-07-30T12:25:13Z","pushed_at":"2016-07-30T20:20:03Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":74506,"stargazers_count":726,"watchers_count":726,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":504,"mirror_url":null,"open_issues_count":106,"forks":504,"open_issues":106,"watchers":726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/3217"},"html":{"href":"https://github.com/dlang/phobos/pull/3217"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/3217"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/3217/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/3217/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/3217/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/a50d4f88effa49f540b18e8558dd7967461e4645"}}}}
{"actor":{"display_login":"9il"}}