{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/comments/75878199","id":75878199,"diff_hunk":"@@ -150,7 +176,7 @@ def inside_file_root?(log_path)\n   end\n \n   private\n-  def write_event(event, data)\n+  def write_event(event)","path":"lib/logstash/outputs/file.rb","position":104,"original_position":104,"commit_id":"d90197a6d50db1808abf44638d3de4482531605e","original_commit_id":"d90197a6d50db1808abf44638d3de4482531605e","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"This method should be renamed","created_at":"2016-08-23T14:32:36Z","updated_at":"2016-08-23T14:32:36Z","html_url":"https://github.com/logstash-plugins/logstash-output-file/pull/46#discussion_r75878199","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/comments/75878199"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-file/pull/46#discussion_r75878199"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46","id":82372239,"html_url":"https://github.com/logstash-plugins/logstash-output-file/pull/46","diff_url":"https://github.com/logstash-plugins/logstash-output-file/pull/46.diff","patch_url":"https://github.com/logstash-plugins/logstash-output-file/pull/46.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/issues/46","number":46,"state":"open","locked":false,"title":"[WIP] Use `concurrency :shared` and sync codecs to optimize performance","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"This is a WIP. This commit has added locking, but I may have missed some locks in a few spots, so it needs another pass before its really ready.\r\n\r\nThis provides a nice boost:\r\n\r\nBefore:\r\n\r\n```\r\ntime bin/logstash -e \"input { generator { count => 3000000} } filter {  } output { file { path => '/tmp/newfileout'} }\"\r\nSettings: Default pipeline workers: 8\r\nPipeline main started\r\nPipeline main has been shutdown\r\nstopping pipeline {:id=>\"main\"}\r\n      139.95 real       223.61 user        28.93 sys\r\n```\r\n\r\nAfter\r\n\r\n```\r\nrm /tmp/newfileout; time bin/logstash -e \"input { generator { count => 3000000} } filter {  } output { file { codec => json_lines path => '/tmp/newfileout'} }\" ; ls -lh /tmp/newfileout\r\nSettings: Default pipeline workers: 8\r\nPipeline main started\r\nPipeline main has been shutdown\r\nstopping pipeline {:id=>\"main\"}\r\n       56.12 real       192.99 user        17.38 sys\r\n```","created_at":"2016-08-23T14:11:47Z","updated_at":"2016-08-23T14:32:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba23ad3ab6cd2e9986ab7133c0b25fc724114bfa","assignee":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/issues/46/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/statuses/d90197a6d50db1808abf44638d3de4482531605e","head":{"label":"andrewvc:concurrent-and-sync","ref":"concurrent-and-sync","sha":"d90197a6d50db1808abf44638d3de4482531605e","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":48444283,"name":"logstash-output-file","full_name":"andrewvc/logstash-output-file","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash-output-file","description":null,"fork":true,"url":"https://api.github.com/repos/andrewvc/logstash-output-file","forks_url":"https://api.github.com/repos/andrewvc/logstash-output-file/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash-output-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash-output-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash-output-file/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash-output-file/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash-output-file/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash-output-file/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash-output-file/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash-output-file/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash-output-file/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash-output-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash-output-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash-output-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash-output-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash-output-file/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash-output-file/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash-output-file/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash-output-file/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash-output-file/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash-output-file/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash-output-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash-output-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash-output-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash-output-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash-output-file/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash-output-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash-output-file/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash-output-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash-output-file/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash-output-file/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash-output-file/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash-output-file/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash-output-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash-output-file/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash-output-file/releases{/id}","deployments_url":"https://api.github.com/repos/andrewvc/logstash-output-file/deployments","created_at":"2015-12-22T17:09:21Z","updated_at":"2015-12-22T17:09:22Z","pushed_at":"2016-08-23T14:11:34Z","git_url":"git://github.com/andrewvc/logstash-output-file.git","ssh_url":"git@github.com:andrewvc/logstash-output-file.git","clone_url":"https://github.com/andrewvc/logstash-output-file.git","svn_url":"https://github.com/andrewvc/logstash-output-file","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"2cf887893aa3e7b135c2fa6c819336ea61be2c46","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25471096,"name":"logstash-output-file","full_name":"logstash-plugins/logstash-output-file","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-output-file","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-output-file","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-file/deployments","created_at":"2014-10-20T14:49:11Z","updated_at":"2016-01-21T11:45:35Z","pushed_at":"2016-08-23T14:11:47Z","git_url":"git://github.com/logstash-plugins/logstash-output-file.git","ssh_url":"git@github.com:logstash-plugins/logstash-output-file.git","clone_url":"https://github.com/logstash-plugins/logstash-output-file.git","svn_url":"https://github.com/logstash-plugins/logstash-output-file","homepage":null,"size":88,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":20,"forks":31,"open_issues":20,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46"},"html":{"href":"https://github.com/logstash-plugins/logstash-output-file/pull/46"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/issues/46"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-output-file/statuses/d90197a6d50db1808abf44638d3de4482531605e"}}}}
{"actor":{"display_login":"andrewvc"}}