{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/87995497","pull_request_review_id":8582532,"id":87995497,"diff_hunk":"@@ -0,0 +1,60 @@\n+/**\n+ * Copyright 2016 Palantir Technologies\n+ *\n+ * Licensed under the BSD-3 License (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://opensource.org/licenses/BSD-3-Clause\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.palantir.atlasdb.containers;\n+\n+import com.google.common.base.Strings;\n+\n+public enum CassandraVersion {\n+    VERSION_2_2_X(\n+            \"^.*\\\"replication_factor\\\":\\\"(\\\\d+)\\\"\\\\}$\",","path":"atlasdb-container-test-utils/src/main/java/com/palantir/atlasdb/containers/CassandraVersion.java","position":22,"original_position":22,"commit_id":"dd0b3a9a4c2738e12dff64b407cf709f746b593c","original_commit_id":"dd0b3a9a4c2738e12dff64b407cf709f746b593c","user":{"login":"SerialVelocity","id":422338,"avatar_url":"https://avatars.githubusercontent.com/u/422338?v=3","gravatar_id":"","url":"https://api.github.com/users/SerialVelocity","html_url":"https://github.com/SerialVelocity","followers_url":"https://api.github.com/users/SerialVelocity/followers","following_url":"https://api.github.com/users/SerialVelocity/following{/other_user}","gists_url":"https://api.github.com/users/SerialVelocity/gists{/gist_id}","starred_url":"https://api.github.com/users/SerialVelocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerialVelocity/subscriptions","organizations_url":"https://api.github.com/users/SerialVelocity/orgs","repos_url":"https://api.github.com/users/SerialVelocity/repos","events_url":"https://api.github.com/users/SerialVelocity/events{/privacy}","received_events_url":"https://api.github.com/users/SerialVelocity/received_events","type":"User","site_admin":false},"body":"These should be `Pattern.compile`.","created_at":"2016-11-15T11:15:41Z","updated_at":"2016-11-15T11:15:46Z","html_url":"https://github.com/palantir/atlasdb/pull/1206#discussion_r87995497","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1206","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/87995497"},"html":{"href":"https://github.com/palantir/atlasdb/pull/1206#discussion_r87995497"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1206"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/1206","id":93555025,"html_url":"https://github.com/palantir/atlasdb/pull/1206","diff_url":"https://github.com/palantir/atlasdb/pull/1206.diff","patch_url":"https://github.com/palantir/atlasdb/pull/1206.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/1206","number":1206,"state":"open","locked":false,"title":"Feature/cassandra 3.7 support","user":{"login":"gsheasby","id":15610492,"avatar_url":"https://avatars.githubusercontent.com/u/15610492?v=3","gravatar_id":"","url":"https://api.github.com/users/gsheasby","html_url":"https://github.com/gsheasby","followers_url":"https://api.github.com/users/gsheasby/followers","following_url":"https://api.github.com/users/gsheasby/following{/other_user}","gists_url":"https://api.github.com/users/gsheasby/gists{/gist_id}","starred_url":"https://api.github.com/users/gsheasby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsheasby/subscriptions","organizations_url":"https://api.github.com/users/gsheasby/orgs","repos_url":"https://api.github.com/users/gsheasby/repos","events_url":"https://api.github.com/users/gsheasby/events{/privacy}","received_events_url":"https://api.github.com/users/gsheasby/received_events","type":"User","site_admin":false},"body":"No release notes: we shouldn't announce 3.7 support until we have an SLS module for 3.7 (and testing infrastructure).\r\n\r\nThis PR keeps the standard circle tests testing on 2.2.8, but this is now set via a gradle property and an environment variable.\r\n- To run tests from IntelliJ, you need to set the CASSANDRA_VERSION environment variable to 2.2.8 or 3.7.\r\n- To run tests from gradle on Cassandra 3.7, it's `./gradlew -PcassVer=3.7 <project>:test` (note: needs to be without quotes).\r\n\r\nOpen question: should we switch to compiling against Cassandra 3.7, or keep it 2.2.8?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/1206)\n<!-- Reviewable:end -->\n","created_at":"2016-11-14T12:07:11Z","updated_at":"2016-11-15T11:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3c2e08cf43295657e904e28beed240f753b5886","assignee":{"login":"SerialVelocity","id":422338,"avatar_url":"https://avatars.githubusercontent.com/u/422338?v=3","gravatar_id":"","url":"https://api.github.com/users/SerialVelocity","html_url":"https://github.com/SerialVelocity","followers_url":"https://api.github.com/users/SerialVelocity/followers","following_url":"https://api.github.com/users/SerialVelocity/following{/other_user}","gists_url":"https://api.github.com/users/SerialVelocity/gists{/gist_id}","starred_url":"https://api.github.com/users/SerialVelocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerialVelocity/subscriptions","organizations_url":"https://api.github.com/users/SerialVelocity/orgs","repos_url":"https://api.github.com/users/SerialVelocity/repos","events_url":"https://api.github.com/users/SerialVelocity/events{/privacy}","received_events_url":"https://api.github.com/users/SerialVelocity/received_events","type":"User","site_admin":false},"assignees":[{"login":"SerialVelocity","id":422338,"avatar_url":"https://avatars.githubusercontent.com/u/422338?v=3","gravatar_id":"","url":"https://api.github.com/users/SerialVelocity","html_url":"https://github.com/SerialVelocity","followers_url":"https://api.github.com/users/SerialVelocity/followers","following_url":"https://api.github.com/users/SerialVelocity/following{/other_user}","gists_url":"https://api.github.com/users/SerialVelocity/gists{/gist_id}","starred_url":"https://api.github.com/users/SerialVelocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerialVelocity/subscriptions","organizations_url":"https://api.github.com/users/SerialVelocity/orgs","repos_url":"https://api.github.com/users/SerialVelocity/repos","events_url":"https://api.github.com/users/SerialVelocity/events{/privacy}","received_events_url":"https://api.github.com/users/SerialVelocity/received_events","type":"User","site_admin":false},{"login":"tpetracca","id":2554328,"avatar_url":"https://avatars.githubusercontent.com/u/2554328?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetracca","html_url":"https://github.com/tpetracca","followers_url":"https://api.github.com/users/tpetracca/followers","following_url":"https://api.github.com/users/tpetracca/following{/other_user}","gists_url":"https://api.github.com/users/tpetracca/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetracca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetracca/subscriptions","organizations_url":"https://api.github.com/users/tpetracca/orgs","repos_url":"https://api.github.com/users/tpetracca/repos","events_url":"https://api.github.com/users/tpetracca/events{/privacy}","received_events_url":"https://api.github.com/users/tpetracca/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/palantir/atlasdb/milestones/4","html_url":"https://github.com/palantir/atlasdb/milestones/0.25.0","labels_url":"https://api.github.com/repos/palantir/atlasdb/milestones/4/labels","id":2125263,"number":4,"title":"0.25.0","description":"","creator":{"login":"rhero","id":7671354,"avatar_url":"https://avatars.githubusercontent.com/u/7671354?v=3","gravatar_id":"","url":"https://api.github.com/users/rhero","html_url":"https://github.com/rhero","followers_url":"https://api.github.com/users/rhero/followers","following_url":"https://api.github.com/users/rhero/following{/other_user}","gists_url":"https://api.github.com/users/rhero/gists{/gist_id}","starred_url":"https://api.github.com/users/rhero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhero/subscriptions","organizations_url":"https://api.github.com/users/rhero/orgs","repos_url":"https://api.github.com/users/rhero/repos","events_url":"https://api.github.com/users/rhero/events{/privacy}","received_events_url":"https://api.github.com/users/rhero/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2016-11-09T17:34:29Z","updated_at":"2016-11-14T13:41:10Z","due_on":"2016-11-19T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1206/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1206/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/1206/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/dd0b3a9a4c2738e12dff64b407cf709f746b593c","head":{"label":"palantir:feature/cassandra-3.7-support","ref":"feature/cassandra-3.7-support","sha":"dd0b3a9a4c2738e12dff64b407cf709f746b593c","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-11-15T08:46:29Z","pushed_at":"2016-11-15T10:38:31Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":28573,"stargazers_count":409,"watchers_count":409,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":105,"forks":62,"open_issues":105,"watchers":409,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"b4949d5c4f2a5f3d8f9a5ee9c71b616f1a639c76","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-11-15T08:46:29Z","pushed_at":"2016-11-15T10:38:31Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":28573,"stargazers_count":409,"watchers_count":409,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":105,"forks":62,"open_issues":105,"watchers":409,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1206"},"html":{"href":"https://github.com/palantir/atlasdb/pull/1206"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/1206"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/1206/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1206/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1206/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/dd0b3a9a4c2738e12dff64b407cf709f746b593c"}}}}
{"actor":{"display_login":"SerialVelocity"}}