{"action":"created","issue":{"url":"https://api.github.com/repos/donkirkby/pinyincushion/issues/11","repository_url":"https://api.github.com/repos/donkirkby/pinyincushion","labels_url":"https://api.github.com/repos/donkirkby/pinyincushion/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/donkirkby/pinyincushion/issues/11/comments","events_url":"https://api.github.com/repos/donkirkby/pinyincushion/issues/11/events","html_url":"https://github.com/donkirkby/pinyincushion/issues/11","id":183514892,"number":11,"title":"Move from Heroku to GitHub pages","user":{"login":"donkirkby","id":1639148,"avatar_url":"https://avatars.githubusercontent.com/u/1639148?v=3","gravatar_id":"","url":"https://api.github.com/users/donkirkby","html_url":"https://github.com/donkirkby","followers_url":"https://api.github.com/users/donkirkby/followers","following_url":"https://api.github.com/users/donkirkby/following{/other_user}","gists_url":"https://api.github.com/users/donkirkby/gists{/gist_id}","starred_url":"https://api.github.com/users/donkirkby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donkirkby/subscriptions","organizations_url":"https://api.github.com/users/donkirkby/orgs","repos_url":"https://api.github.com/users/donkirkby/repos","events_url":"https://api.github.com/users/donkirkby/events{/privacy}","received_events_url":"https://api.github.com/users/donkirkby/received_events","type":"User","site_admin":false},"labels":[{"id":449119865,"url":"https://api.github.com/repos/donkirkby/pinyincushion/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":449472306,"url":"https://api.github.com/repos/donkirkby/pinyincushion/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"donkirkby","id":1639148,"avatar_url":"https://avatars.githubusercontent.com/u/1639148?v=3","gravatar_id":"","url":"https://api.github.com/users/donkirkby","html_url":"https://github.com/donkirkby","followers_url":"https://api.github.com/users/donkirkby/followers","following_url":"https://api.github.com/users/donkirkby/following{/other_user}","gists_url":"https://api.github.com/users/donkirkby/gists{/gist_id}","starred_url":"https://api.github.com/users/donkirkby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donkirkby/subscriptions","organizations_url":"https://api.github.com/users/donkirkby/orgs","repos_url":"https://api.github.com/users/donkirkby/repos","events_url":"https://api.github.com/users/donkirkby/events{/privacy}","received_events_url":"https://api.github.com/users/donkirkby/received_events","type":"User","site_admin":false},"assignees":[{"login":"donkirkby","id":1639148,"avatar_url":"https://avatars.githubusercontent.com/u/1639148?v=3","gravatar_id":"","url":"https://api.github.com/users/donkirkby","html_url":"https://github.com/donkirkby","followers_url":"https://api.github.com/users/donkirkby/followers","following_url":"https://api.github.com/users/donkirkby/following{/other_user}","gists_url":"https://api.github.com/users/donkirkby/gists{/gist_id}","starred_url":"https://api.github.com/users/donkirkby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donkirkby/subscriptions","organizations_url":"https://api.github.com/users/donkirkby/orgs","repos_url":"https://api.github.com/users/donkirkby/repos","events_url":"https://api.github.com/users/donkirkby/events{/privacy}","received_events_url":"https://api.github.com/users/donkirkby/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-10-17T20:11:43Z","updated_at":"2016-10-31T15:28:32Z","closed_at":null,"body":"Since we decided not to store anything on the server, we're not really benefiting from Heroku. We could deploy to GitHub pages using pure Javascript instead.\n- [x] create a `github-pages` branch, and set it up with a template\n- [ ] copy Javascript code from master, and replace JSX style of ReactJS with JS style\n  - [x] convert basic features\n  - [ ] enable local storage\n  - [ ] fix bug when pasting large HTML blob\n- [ ] set up unit tests\n- [ ] make sure it works on the branch\n- [ ] create a `docs` folder, and move the old Javascript code in there\n- [ ] replace with the Javascript code from the `github-pages` branch, and switch GitHub pages to load from `docs`\n- [ ] put a redirect page in the main folder that will redirect from Heroku to the new version on GitHub, then push that to Heroku\n- [ ] remove any old Heroku code and the `github-pages` branch"},"comment":{"url":"https://api.github.com/repos/donkirkby/pinyincushion/issues/comments/257325409","html_url":"https://github.com/donkirkby/pinyincushion/issues/11#issuecomment-257325409","issue_url":"https://api.github.com/repos/donkirkby/pinyincushion/issues/11","id":257325409,"user":{"login":"zyxue","id":527862,"avatar_url":"https://avatars.githubusercontent.com/u/527862?v=3","gravatar_id":"","url":"https://api.github.com/users/zyxue","html_url":"https://github.com/zyxue","followers_url":"https://api.github.com/users/zyxue/followers","following_url":"https://api.github.com/users/zyxue/following{/other_user}","gists_url":"https://api.github.com/users/zyxue/gists{/gist_id}","starred_url":"https://api.github.com/users/zyxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyxue/subscriptions","organizations_url":"https://api.github.com/users/zyxue/orgs","repos_url":"https://api.github.com/users/zyxue/repos","events_url":"https://api.github.com/users/zyxue/events{/privacy}","received_events_url":"https://api.github.com/users/zyxue/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T15:28:32Z","updated_at":"2016-10-31T15:28:32Z","body":"I see. You have some valid points. But I thought the app is only simple for the current. We don't know when it would become useful to add a server side stuff to it or have a more complicated state on the browser side. Keeping the practice in an extensible (or scalable) way sounds a good idea to me. I thought more React developers who wants to contrinbute would be more familiar with JSX than the javascript way because facebook is encouraging it, but I don't have any numbers to support that :P."}}
{"actor":{"display_login":"zyxue"}}