{"action":"created","issue":{"url":"https://api.github.com/repos/neos/flow-development-collection/issues/746","repository_url":"https://api.github.com/repos/neos/flow-development-collection","labels_url":"https://api.github.com/repos/neos/flow-development-collection/issues/746/labels{/name}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/746/comments","events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/746/events","html_url":"https://github.com/neos/flow-development-collection/issues/746","id":192861194,"number":746,"title":"TYPO3Fluid: Document changed behavior of `AbstractConditionViewHelper`","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"labels":[{"id":446791167,"url":"https://api.github.com/repos/neos/flow-development-collection/labels/Bug","name":"Bug","color":"ededed","default":false},{"id":274949249,"url":"https://api.github.com/repos/neos/flow-development-collection/labels/P:%20Fluid(Adaptor)","name":"P: Fluid(Adaptor)","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-01T14:28:29Z","updated_at":"2016-12-20T10:40:02Z","closed_at":null,"body":"### Description\r\n\r\nIn TYPO3Fluid the behavior of the  `AbstractConditionViewHelper` has been changed and it's hardcoded to evaluate a boolean argument `condition` by default.\r\nIn order to implement a custom condition VH one has to override the static `evaluateCondition` function.\r\n\r\n### Steps to Reproduce\r\n\r\n1. Create a simple custom ViewHelper, e.g.:\r\n\r\n```php\r\nclass MyViewHelper extends AbstractConditionViewHelper\r\n{\r\n  public function render()\r\n  {\r\n    return $this->renderThenChild();\r\n  }\r\n}\r\n```\r\n\r\n2. Put it in a template\r\n\r\n```html\r\n{namespace x:My\\Package\\ViewHelpers}\r\n<x:my>\r\n  <f:then>THEN</f:then>\r\n  <f:else>ELSE</f:else>\r\n</x:my>\r\n```\r\n\r\n#### Expected behavior\r\n\r\n```\r\nTHEN\r\n```\r\n\r\n#### Actual behavior\r\n\r\n```\r\nELSE\r\n```\r\n\r\n(only renders \"THEN\" correctly on the first hit, before the template is compiled)\r\n\r\n### Affected Versions\r\n\r\nFlow 4.0  (using TYPO3Fluid).\r\n"},"comment":{"url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments/268211044","html_url":"https://github.com/neos/flow-development-collection/issues/746#issuecomment-268211044","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/746","id":268211044,"user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T10:40:02Z","updated_at":"2016-12-20T10:40:02Z","body":"@robertlemke This is just about *documenting* the changed behavior. I already added it to the release todos, but IMO we should keep the ticket open just in case"}}
{"actor":{"display_login":"bwaidelich"}}