{"action":"created","issue":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/462","repository_url":"https://api.github.com/repos/vert-x3/vertx-web","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/462/labels{/name}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/462/comments","events_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/462/events","html_url":"https://github.com/vert-x3/vertx-web/issues/462","id":181643714,"number":462,"title":"Deprecate sub-router","user":{"login":"pmlopes","id":849467,"avatar_url":"https://avatars.githubusercontent.com/u/849467?v=3","gravatar_id":"","url":"https://api.github.com/users/pmlopes","html_url":"https://github.com/pmlopes","followers_url":"https://api.github.com/users/pmlopes/followers","following_url":"https://api.github.com/users/pmlopes/following{/other_user}","gists_url":"https://api.github.com/users/pmlopes/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlopes/subscriptions","organizations_url":"https://api.github.com/users/pmlopes/orgs","repos_url":"https://api.github.com/users/pmlopes/repos","events_url":"https://api.github.com/users/pmlopes/events{/privacy}","received_events_url":"https://api.github.com/users/pmlopes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-07T11:16:36Z","updated_at":"2016-10-07T13:39:20Z","closed_at":null,"body":"Currently sub routing is a cause of confusion and introduces many ambiguity on the behaviour of the core `Router`. On top of that in introduces complex internal code flows when dealing with `reroute`, error handling, matching, etc...\r\n\r\nI propose that we deprecate and later remove the following methods:\r\n\r\n```\r\n /**\r\n   * Mount a sub router on this router\r\n   *\r\n   * @param mountPoint  the mount point (path prefix) to mount it on\r\n   * @param subRouter  the router to mount as a sub router\r\n   * @return a reference to this, so the API can be used fluently\r\n   */\r\n  @Fluent\r\nRouter mountSubRouter(String mountPoint, Router subRouter);\r\n```"},"comment":{"url":"https://api.github.com/repos/vert-x3/vertx-web/issues/comments/252254391","html_url":"https://github.com/vert-x3/vertx-web/issues/462#issuecomment-252254391","issue_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/462","id":252254391,"user":{"login":"alexGalushka","id":7980390,"avatar_url":"https://avatars.githubusercontent.com/u/7980390?v=3","gravatar_id":"","url":"https://api.github.com/users/alexGalushka","html_url":"https://github.com/alexGalushka","followers_url":"https://api.github.com/users/alexGalushka/followers","following_url":"https://api.github.com/users/alexGalushka/following{/other_user}","gists_url":"https://api.github.com/users/alexGalushka/gists{/gist_id}","starred_url":"https://api.github.com/users/alexGalushka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexGalushka/subscriptions","organizations_url":"https://api.github.com/users/alexGalushka/orgs","repos_url":"https://api.github.com/users/alexGalushka/repos","events_url":"https://api.github.com/users/alexGalushka/events{/privacy}","received_events_url":"https://api.github.com/users/alexGalushka/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T13:39:20Z","updated_at":"2016-10-07T13:39:20Z","body":"Subrouters is a great feature, don't deprecate."}}
{"actor":{"display_login":"alexGalushka"}}