{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/76390944","id":76390944,"diff_hunk":"@@ -0,0 +1,245 @@\n+ /**\n+ * Copyright (c) 2012-2016, OpenGeoSys Community (http://www.opengeosys.org)\n+ *            Distributed under a Modified BSD License.\n+ *              See accompanying file LICENSE.txt or\n+ *              http://www.opengeosys.org/project/license\n+ */\n+\n+#ifndef SWMMINTERFACE_H_\n+#define SWMMINTERFACE_H_\n+\n+#include <iostream>\n+#include <map>\n+#include <memory>\n+#include <string>\n+#include <vector>\n+\n+#include <logog/include/logog.hpp>\n+\n+#include \"ThirdParty/SWMMInterface/swmm5_iface.h\"\n+\n+#include \"GeoLib/Station.h\"\n+\n+namespace GeoLib {\n+    class GEOObjects;\n+    class Point;\n+    class Polyline;\n+}\n+\n+namespace MeshLib {\n+    class Mesh;\n+    class Node;\n+    class Element;\n+}\n+\n+/// SWMM object types\n+enum class SwmmObject\n+{\n+    SUBCATCHMENT = 0,\n+    NODE = 1,\n+    LINK = 2,\n+    SYSTEM = 3\n+};\n+\n+/**\n+ * Interface for reading files used within the  * Storm Water Management Model (SWMM) and\n+ * converting the data therein into corresponding OGS data structures.\n+ * SWMM distinguishes four different object types (defined in the SwmmObject enum):\n+ *     * Subcatchments\n+ *     * Nodes (or junctions)\n+ *     * Links (or conduits)\n+ *     * System\n+ * Note that each object in a SWMM input file has a name.\n+ * Each of the four object types has a (different) number of parameters. There can be an arbitrary\n+ * number of nodes, links or subcatchments but only ever one system.","path":"Applications/FileIO/SWMM/SWMMInterface.h","position":54,"original_position":54,"commit_id":"2e420f2e0f0e0efe97e35ebbb85e3de570a6f2ff","original_commit_id":"2e420f2e0f0e0efe97e35ebbb85e3de570a6f2ff","user":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=3","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"body":"Each SWMM model/simulation has only one System-object. Since one interface can only open one SWMM project, each interface also has one System-object. \r\nIf you create multiple SWMM interfaces in your application, each of those would have its own System object.","created_at":"2016-08-26T09:29:22Z","updated_at":"2016-08-26T09:29:22Z","html_url":"https://github.com/ufz/ogs/pull/1355#discussion_r76390944","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1355","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/76390944"},"html":{"href":"https://github.com/ufz/ogs/pull/1355#discussion_r76390944"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1355"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1355","id":81306161,"html_url":"https://github.com/ufz/ogs/pull/1355","diff_url":"https://github.com/ufz/ogs/pull/1355.diff","patch_url":"https://github.com/ufz/ogs/pull/1355.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1355","number":1355,"state":"open","locked":false,"title":"SWMM Interface","user":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=3","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"body":"Interface to Storm Water Management Model (SWMM) input/output files.\r\n* Conversion of input into Geometry/Mesh/CSV\r\n* Simulation results can be attached to meshes as scalar arrays or output to CSV\r\n\r\nThe SwmmConverter utility is just a prototype / script example of how to use the interface.  Tom suggested including it as example code. Implementing the full range of available information found in output files would require 4 objects types with a minimum of 37 possible parameters (not counting optional ones) + time step managment. It's relatively easy to write scripts for the interface but a full fledged user interface would require more time and effort than I can currently muster.\r\n\r\nThe inclusion into CMake works with a new flag, OGS_USE_SWMM. Not sure how testing works with that.\r\n\r\nThanks to Tom + Lars for all the CMake/Git/Submodule help.","created_at":"2016-08-15T12:37:06Z","updated_at":"2016-08-26T09:29:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"990bf2788fc70e6918339d0d3159fa9915baf903","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1355/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1355/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1355/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/2e420f2e0f0e0efe97e35ebbb85e3de570a6f2ff","head":{"label":"rinkk:AddSwmmInterface2","ref":"AddSwmmInterface2","sha":"2e420f2e0f0e0efe97e35ebbb85e3de570a6f2ff","user":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=3","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"repo":{"id":7148641,"name":"ogs","full_name":"rinkk/ogs","owner":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=3","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rinkk/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/rinkk/ogs","forks_url":"https://api.github.com/repos/rinkk/ogs/forks","keys_url":"https://api.github.com/repos/rinkk/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rinkk/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rinkk/ogs/teams","hooks_url":"https://api.github.com/repos/rinkk/ogs/hooks","issue_events_url":"https://api.github.com/repos/rinkk/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/rinkk/ogs/events","assignees_url":"https://api.github.com/repos/rinkk/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/rinkk/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/rinkk/ogs/tags","blobs_url":"https://api.github.com/repos/rinkk/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rinkk/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rinkk/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rinkk/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rinkk/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/rinkk/ogs/languages","stargazers_url":"https://api.github.com/repos/rinkk/ogs/stargazers","contributors_url":"https://api.github.com/repos/rinkk/ogs/contributors","subscribers_url":"https://api.github.com/repos/rinkk/ogs/subscribers","subscription_url":"https://api.github.com/repos/rinkk/ogs/subscription","commits_url":"https://api.github.com/repos/rinkk/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rinkk/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rinkk/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rinkk/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rinkk/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/rinkk/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rinkk/ogs/merges","archive_url":"https://api.github.com/repos/rinkk/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rinkk/ogs/downloads","issues_url":"https://api.github.com/repos/rinkk/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/rinkk/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/rinkk/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/rinkk/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rinkk/ogs/labels{/name}","releases_url":"https://api.github.com/repos/rinkk/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/rinkk/ogs/deployments","created_at":"2012-12-13T13:27:20Z","updated_at":"2016-02-15T09:53:46Z","pushed_at":"2016-08-17T08:40:16Z","git_url":"git://github.com/rinkk/ogs.git","ssh_url":"git@github.com:rinkk/ogs.git","clone_url":"https://github.com/rinkk/ogs.git","svn_url":"https://github.com/rinkk/ogs","homepage":"www.opengeosys.org","size":15250,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"dc2b0ae78c1879ed3483fad7692337e057427535","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-08-21T12:22:28Z","pushed_at":"2016-08-26T09:03:52Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":19748,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":97,"forks":49,"open_issues":97,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1355"},"html":{"href":"https://github.com/ufz/ogs/pull/1355"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1355"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1355/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1355/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1355/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/2e420f2e0f0e0efe97e35ebbb85e3de570a6f2ff"}}}}
{"actor":{"display_login":"rinkk"}}