{"action":"created","comment":{"url":"https://api.github.com/repos/seecloud/spamostack/pulls/comments/93205712","pull_request_review_id":13726965,"id":93205712,"diff_hunk":"@@ -119,6 +120,10 @@ def get(self, client_name, resource_name, param=None, func=None,\n                     else:\n                         probe = getattr(el, param)(*args, **kwargs)\n \n+                    if (resource_name == \"flavors\"","path":"spamostack/keeper.py","position":12,"original_position":12,"commit_id":"2a79bb9be9801e5d279b5c2fe68e26522425284f","original_commit_id":"2a79bb9be9801e5d279b5c2fe68e26522425284f","user":{"login":"ivanovmi","id":6911438,"avatar_url":"https://avatars.githubusercontent.com/u/6911438?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanovmi","html_url":"https://github.com/ivanovmi","followers_url":"https://api.github.com/users/ivanovmi/followers","following_url":"https://api.github.com/users/ivanovmi/following{/other_user}","gists_url":"https://api.github.com/users/ivanovmi/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanovmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanovmi/subscriptions","organizations_url":"https://api.github.com/users/ivanovmi/orgs","repos_url":"https://api.github.com/users/ivanovmi/repos","events_url":"https://api.github.com/users/ivanovmi/events{/privacy}","received_events_url":"https://api.github.com/users/ivanovmi/received_events","type":"User","site_admin":false},"body":"@FromZeus Hi, thank for review! I think that hardcoding a bunch of names is a wrong way :)\r\nBut, also i think that I can move `validate_uuid` method to `spam_factory` module, and iterate over list of flavors - and if id of flavor is uuid - we can remove this flavor. This allow us doesn't to break our cloud, and doesn't disrupt logic of `keeper.get()` method\r\nReason, why I using uuid validation - because standard flavors creates with custom id (not uuid) and our flavors will be created with auto-generated uuid","created_at":"2016-12-20T10:07:54Z","updated_at":"2016-12-20T10:07:54Z","html_url":"https://github.com/seecloud/spamostack/pull/33#discussion_r93205712","pull_request_url":"https://api.github.com/repos/seecloud/spamostack/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/seecloud/spamostack/pulls/comments/93205712"},"html":{"href":"https://github.com/seecloud/spamostack/pull/33#discussion_r93205712"},"pull_request":{"href":"https://api.github.com/repos/seecloud/spamostack/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/seecloud/spamostack/pulls/33","id":98568241,"html_url":"https://github.com/seecloud/spamostack/pull/33","diff_url":"https://github.com/seecloud/spamostack/pull/33.diff","patch_url":"https://github.com/seecloud/spamostack/pull/33.patch","issue_url":"https://api.github.com/repos/seecloud/spamostack/issues/33","number":33,"state":"open","locked":false,"title":"Update keeper module","user":{"login":"ivanovmi","id":6911438,"avatar_url":"https://avatars.githubusercontent.com/u/6911438?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanovmi","html_url":"https://github.com/ivanovmi","followers_url":"https://api.github.com/users/ivanovmi/followers","following_url":"https://api.github.com/users/ivanovmi/following{/other_user}","gists_url":"https://api.github.com/users/ivanovmi/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanovmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanovmi/subscriptions","organizations_url":"https://api.github.com/users/ivanovmi/orgs","repos_url":"https://api.github.com/users/ivanovmi/repos","events_url":"https://api.github.com/users/ivanovmi/events{/privacy}","received_events_url":"https://api.github.com/users/ivanovmi/received_events","type":"User","site_admin":false},"body":"- Added static method for validating uuid4\r\n- Added simple check, that continues keeping\r\n  default flavors in openstack without deleting\r\n- Remove strong constraint. Reason:\r\n  https://github.com/openstack-dev/pbr/blob/e0d26741/pbr/packaging.py#L915","created_at":"2016-12-19T13:50:28Z","updated_at":"2016-12-20T10:07:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d83042bb6f44490bf69208705347ce58cb832d56","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/seecloud/spamostack/pulls/33/commits","review_comments_url":"https://api.github.com/repos/seecloud/spamostack/pulls/33/comments","review_comment_url":"https://api.github.com/repos/seecloud/spamostack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seecloud/spamostack/issues/33/comments","statuses_url":"https://api.github.com/repos/seecloud/spamostack/statuses/2a79bb9be9801e5d279b5c2fe68e26522425284f","head":{"label":"seecloud:fix_flavor_removing","ref":"fix_flavor_removing","sha":"2a79bb9be9801e5d279b5c2fe68e26522425284f","user":{"login":"seecloud","id":21331534,"avatar_url":"https://avatars.githubusercontent.com/u/21331534?v=3","gravatar_id":"","url":"https://api.github.com/users/seecloud","html_url":"https://github.com/seecloud","followers_url":"https://api.github.com/users/seecloud/followers","following_url":"https://api.github.com/users/seecloud/following{/other_user}","gists_url":"https://api.github.com/users/seecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/seecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seecloud/subscriptions","organizations_url":"https://api.github.com/users/seecloud/orgs","repos_url":"https://api.github.com/users/seecloud/repos","events_url":"https://api.github.com/users/seecloud/events{/privacy}","received_events_url":"https://api.github.com/users/seecloud/received_events","type":"Organization","site_admin":false},"repo":{"id":69031131,"name":"spamostack","full_name":"seecloud/spamostack","owner":{"login":"seecloud","id":21331534,"avatar_url":"https://avatars.githubusercontent.com/u/21331534?v=3","gravatar_id":"","url":"https://api.github.com/users/seecloud","html_url":"https://github.com/seecloud","followers_url":"https://api.github.com/users/seecloud/followers","following_url":"https://api.github.com/users/seecloud/following{/other_user}","gists_url":"https://api.github.com/users/seecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/seecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seecloud/subscriptions","organizations_url":"https://api.github.com/users/seecloud/orgs","repos_url":"https://api.github.com/users/seecloud/repos","events_url":"https://api.github.com/users/seecloud/events{/privacy}","received_events_url":"https://api.github.com/users/seecloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seecloud/spamostack","description":"Tool for creating requests to OpenStack with fake drivers","fork":false,"url":"https://api.github.com/repos/seecloud/spamostack","forks_url":"https://api.github.com/repos/seecloud/spamostack/forks","keys_url":"https://api.github.com/repos/seecloud/spamostack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seecloud/spamostack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seecloud/spamostack/teams","hooks_url":"https://api.github.com/repos/seecloud/spamostack/hooks","issue_events_url":"https://api.github.com/repos/seecloud/spamostack/issues/events{/number}","events_url":"https://api.github.com/repos/seecloud/spamostack/events","assignees_url":"https://api.github.com/repos/seecloud/spamostack/assignees{/user}","branches_url":"https://api.github.com/repos/seecloud/spamostack/branches{/branch}","tags_url":"https://api.github.com/repos/seecloud/spamostack/tags","blobs_url":"https://api.github.com/repos/seecloud/spamostack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seecloud/spamostack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seecloud/spamostack/git/refs{/sha}","trees_url":"https://api.github.com/repos/seecloud/spamostack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seecloud/spamostack/statuses/{sha}","languages_url":"https://api.github.com/repos/seecloud/spamostack/languages","stargazers_url":"https://api.github.com/repos/seecloud/spamostack/stargazers","contributors_url":"https://api.github.com/repos/seecloud/spamostack/contributors","subscribers_url":"https://api.github.com/repos/seecloud/spamostack/subscribers","subscription_url":"https://api.github.com/repos/seecloud/spamostack/subscription","commits_url":"https://api.github.com/repos/seecloud/spamostack/commits{/sha}","git_commits_url":"https://api.github.com/repos/seecloud/spamostack/git/commits{/sha}","comments_url":"https://api.github.com/repos/seecloud/spamostack/comments{/number}","issue_comment_url":"https://api.github.com/repos/seecloud/spamostack/issues/comments{/number}","contents_url":"https://api.github.com/repos/seecloud/spamostack/contents/{+path}","compare_url":"https://api.github.com/repos/seecloud/spamostack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seecloud/spamostack/merges","archive_url":"https://api.github.com/repos/seecloud/spamostack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seecloud/spamostack/downloads","issues_url":"https://api.github.com/repos/seecloud/spamostack/issues{/number}","pulls_url":"https://api.github.com/repos/seecloud/spamostack/pulls{/number}","milestones_url":"https://api.github.com/repos/seecloud/spamostack/milestones{/number}","notifications_url":"https://api.github.com/repos/seecloud/spamostack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seecloud/spamostack/labels{/name}","releases_url":"https://api.github.com/repos/seecloud/spamostack/releases{/id}","deployments_url":"https://api.github.com/repos/seecloud/spamostack/deployments","created_at":"2016-09-23T14:14:00Z","updated_at":"2016-11-19T10:39:29Z","pushed_at":"2016-12-19T15:24:11Z","git_url":"git://github.com/seecloud/spamostack.git","ssh_url":"git@github.com:seecloud/spamostack.git","clone_url":"https://github.com/seecloud/spamostack.git","svn_url":"https://github.com/seecloud/spamostack","homepage":"","size":111,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"seecloud:master","ref":"master","sha":"0a380b4c14bfa9d2cf070f1a185330f5eae5003f","user":{"login":"seecloud","id":21331534,"avatar_url":"https://avatars.githubusercontent.com/u/21331534?v=3","gravatar_id":"","url":"https://api.github.com/users/seecloud","html_url":"https://github.com/seecloud","followers_url":"https://api.github.com/users/seecloud/followers","following_url":"https://api.github.com/users/seecloud/following{/other_user}","gists_url":"https://api.github.com/users/seecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/seecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seecloud/subscriptions","organizations_url":"https://api.github.com/users/seecloud/orgs","repos_url":"https://api.github.com/users/seecloud/repos","events_url":"https://api.github.com/users/seecloud/events{/privacy}","received_events_url":"https://api.github.com/users/seecloud/received_events","type":"Organization","site_admin":false},"repo":{"id":69031131,"name":"spamostack","full_name":"seecloud/spamostack","owner":{"login":"seecloud","id":21331534,"avatar_url":"https://avatars.githubusercontent.com/u/21331534?v=3","gravatar_id":"","url":"https://api.github.com/users/seecloud","html_url":"https://github.com/seecloud","followers_url":"https://api.github.com/users/seecloud/followers","following_url":"https://api.github.com/users/seecloud/following{/other_user}","gists_url":"https://api.github.com/users/seecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/seecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seecloud/subscriptions","organizations_url":"https://api.github.com/users/seecloud/orgs","repos_url":"https://api.github.com/users/seecloud/repos","events_url":"https://api.github.com/users/seecloud/events{/privacy}","received_events_url":"https://api.github.com/users/seecloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seecloud/spamostack","description":"Tool for creating requests to OpenStack with fake drivers","fork":false,"url":"https://api.github.com/repos/seecloud/spamostack","forks_url":"https://api.github.com/repos/seecloud/spamostack/forks","keys_url":"https://api.github.com/repos/seecloud/spamostack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seecloud/spamostack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seecloud/spamostack/teams","hooks_url":"https://api.github.com/repos/seecloud/spamostack/hooks","issue_events_url":"https://api.github.com/repos/seecloud/spamostack/issues/events{/number}","events_url":"https://api.github.com/repos/seecloud/spamostack/events","assignees_url":"https://api.github.com/repos/seecloud/spamostack/assignees{/user}","branches_url":"https://api.github.com/repos/seecloud/spamostack/branches{/branch}","tags_url":"https://api.github.com/repos/seecloud/spamostack/tags","blobs_url":"https://api.github.com/repos/seecloud/spamostack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seecloud/spamostack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seecloud/spamostack/git/refs{/sha}","trees_url":"https://api.github.com/repos/seecloud/spamostack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seecloud/spamostack/statuses/{sha}","languages_url":"https://api.github.com/repos/seecloud/spamostack/languages","stargazers_url":"https://api.github.com/repos/seecloud/spamostack/stargazers","contributors_url":"https://api.github.com/repos/seecloud/spamostack/contributors","subscribers_url":"https://api.github.com/repos/seecloud/spamostack/subscribers","subscription_url":"https://api.github.com/repos/seecloud/spamostack/subscription","commits_url":"https://api.github.com/repos/seecloud/spamostack/commits{/sha}","git_commits_url":"https://api.github.com/repos/seecloud/spamostack/git/commits{/sha}","comments_url":"https://api.github.com/repos/seecloud/spamostack/comments{/number}","issue_comment_url":"https://api.github.com/repos/seecloud/spamostack/issues/comments{/number}","contents_url":"https://api.github.com/repos/seecloud/spamostack/contents/{+path}","compare_url":"https://api.github.com/repos/seecloud/spamostack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seecloud/spamostack/merges","archive_url":"https://api.github.com/repos/seecloud/spamostack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seecloud/spamostack/downloads","issues_url":"https://api.github.com/repos/seecloud/spamostack/issues{/number}","pulls_url":"https://api.github.com/repos/seecloud/spamostack/pulls{/number}","milestones_url":"https://api.github.com/repos/seecloud/spamostack/milestones{/number}","notifications_url":"https://api.github.com/repos/seecloud/spamostack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seecloud/spamostack/labels{/name}","releases_url":"https://api.github.com/repos/seecloud/spamostack/releases{/id}","deployments_url":"https://api.github.com/repos/seecloud/spamostack/deployments","created_at":"2016-09-23T14:14:00Z","updated_at":"2016-11-19T10:39:29Z","pushed_at":"2016-12-19T15:24:11Z","git_url":"git://github.com/seecloud/spamostack.git","ssh_url":"git@github.com:seecloud/spamostack.git","clone_url":"https://github.com/seecloud/spamostack.git","svn_url":"https://github.com/seecloud/spamostack","homepage":"","size":111,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seecloud/spamostack/pulls/33"},"html":{"href":"https://github.com/seecloud/spamostack/pull/33"},"issue":{"href":"https://api.github.com/repos/seecloud/spamostack/issues/33"},"comments":{"href":"https://api.github.com/repos/seecloud/spamostack/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/seecloud/spamostack/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/seecloud/spamostack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seecloud/spamostack/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/seecloud/spamostack/statuses/2a79bb9be9801e5d279b5c2fe68e26522425284f"}}}}
{"actor":{"display_login":"ivanovmi"}}