{"action":"created","comment":{"url":"https://api.github.com/repos/krb5/krb5/pulls/comments/71902107","id":71902107,"diff_hunk":"@@ -45,6 +45,122 @@ krb5int_free_srv_dns_data (struct srv_dns_entry *p)\n     }\n }\n \n+static krb5_error_code\n+prepare_lookup_buf(const krb5_data *realm, const char *service,\n+                   const char *protocol, char *fixed_buf, size_t bufsize)\n+{\n+    struct k5buf buf;\n+    if (memchr(realm->data, 0, realm->length))\n+        return EINVAL;\n+\n+    k5_buf_init_fixed(&buf, fixed_buf, bufsize);\n+    k5_buf_add_fmt(&buf, \"%s.\", service);\n+    if (protocol != NULL)\n+        k5_buf_add_fmt(&buf, \"%s.\", protocol);\n+    k5_buf_add_len(&buf, realm->data, realm->length);\n+\n+    /* Realm names don't (normally) end with \".\", but if the query\n+       doesn't end with \".\" and doesn't get an answer as is, the\n+       resolv code will try appending the local domain.  Since the\n+       realm names are absolutes, let's stop that.\n+\n+       But only if a name has been specified.  If we are performing\n+       a search on the prefix alone then the intention is to allow\n+       the local domain or domain search lists to be expanded.  */\n+\n+    if (buf.len > 0 && fixed_buf[buf.len - 1] != '.')\n+        k5_buf_add(&buf, \".\");\n+\n+    return k5_buf_status(&buf);\n+}\n+\n+/* Insert into the list, ordering by priority. Weight is not currently","path":"src/lib/krb5/os/dnssrv.c","position":33,"original_position":33,"commit_id":"4cdbcc984c8cac534b4f80f8b0c8d7c82ea0a092","original_commit_id":"ffe41f0e220a040ddba5d59245ded27667d25732","user":{"login":"greghudson","id":1131421,"avatar_url":"https://avatars.githubusercontent.com/u/1131421?v=3","gravatar_id":"","url":"https://api.github.com/users/greghudson","html_url":"https://github.com/greghudson","followers_url":"https://api.github.com/users/greghudson/followers","following_url":"https://api.github.com/users/greghudson/following{/other_user}","gists_url":"https://api.github.com/users/greghudson/gists{/gist_id}","starred_url":"https://api.github.com/users/greghudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greghudson/subscriptions","organizations_url":"https://api.github.com/users/greghudson/orgs","repos_url":"https://api.github.com/users/greghudson/repos","events_url":"https://api.github.com/users/greghudson/events{/privacy}","received_events_url":"https://api.github.com/users/greghudson/received_events","type":"User","site_admin":false},"body":"Two spaces between sentences, please.","created_at":"2016-07-22T15:56:57Z","updated_at":"2016-07-22T15:56:57Z","html_url":"https://github.com/krb5/krb5/pull/481#discussion_r71902107","pull_request_url":"https://api.github.com/repos/krb5/krb5/pulls/481","_links":{"self":{"href":"https://api.github.com/repos/krb5/krb5/pulls/comments/71902107"},"html":{"href":"https://github.com/krb5/krb5/pull/481#discussion_r71902107"},"pull_request":{"href":"https://api.github.com/repos/krb5/krb5/pulls/481"}}},"pull_request":{"url":"https://api.github.com/repos/krb5/krb5/pulls/481","id":76345438,"html_url":"https://github.com/krb5/krb5/pull/481","diff_url":"https://github.com/krb5/krb5/pull/481.diff","patch_url":"https://github.com/krb5/krb5/pull/481.patch","issue_url":"https://api.github.com/repos/krb5/krb5/issues/481","number":481,"state":"open","locked":false,"title":"Enable KDC discovery through URI records","user":{"login":"mrogers950","id":3697177,"avatar_url":"https://avatars.githubusercontent.com/u/3697177?v=3","gravatar_id":"","url":"https://api.github.com/users/mrogers950","html_url":"https://github.com/mrogers950","followers_url":"https://api.github.com/users/mrogers950/followers","following_url":"https://api.github.com/users/mrogers950/following{/other_user}","gists_url":"https://api.github.com/users/mrogers950/gists{/gist_id}","starred_url":"https://api.github.com/users/mrogers950/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrogers950/subscriptions","organizations_url":"https://api.github.com/users/mrogers950/orgs","repos_url":"https://api.github.com/users/mrogers950/repos","events_url":"https://api.github.com/users/mrogers950/events{/privacy}","received_events_url":"https://api.github.com/users/mrogers950/received_events","type":"User","site_admin":false},"body":"This adds the service locator for URI records for https://tools.ietf.org/html/draft-mccallum-kitten-krb-service-discovery-02. The leading flags field is not mentioned in the draft but is carried over from the initial TXT record plans. Another item addressed is letting k5_kdc_is_master() check the master flag from the URI lookup before performing an additional search.","created_at":"2016-07-05T21:23:04Z","updated_at":"2016-07-22T15:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7323ae0ac070b4eae4110b1e94dfdbf6d6805d68","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/krb5/krb5/pulls/481/commits","review_comments_url":"https://api.github.com/repos/krb5/krb5/pulls/481/comments","review_comment_url":"https://api.github.com/repos/krb5/krb5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krb5/krb5/issues/481/comments","statuses_url":"https://api.github.com/repos/krb5/krb5/statuses/4cdbcc984c8cac534b4f80f8b0c8d7c82ea0a092","head":{"label":"mrogers950:discover_uri","ref":"discover_uri","sha":"4cdbcc984c8cac534b4f80f8b0c8d7c82ea0a092","user":{"login":"mrogers950","id":3697177,"avatar_url":"https://avatars.githubusercontent.com/u/3697177?v=3","gravatar_id":"","url":"https://api.github.com/users/mrogers950","html_url":"https://github.com/mrogers950","followers_url":"https://api.github.com/users/mrogers950/followers","following_url":"https://api.github.com/users/mrogers950/following{/other_user}","gists_url":"https://api.github.com/users/mrogers950/gists{/gist_id}","starred_url":"https://api.github.com/users/mrogers950/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrogers950/subscriptions","organizations_url":"https://api.github.com/users/mrogers950/orgs","repos_url":"https://api.github.com/users/mrogers950/repos","events_url":"https://api.github.com/users/mrogers950/events{/privacy}","received_events_url":"https://api.github.com/users/mrogers950/received_events","type":"User","site_admin":false},"repo":{"id":50367656,"name":"krb5","full_name":"mrogers950/krb5","owner":{"login":"mrogers950","id":3697177,"avatar_url":"https://avatars.githubusercontent.com/u/3697177?v=3","gravatar_id":"","url":"https://api.github.com/users/mrogers950","html_url":"https://github.com/mrogers950","followers_url":"https://api.github.com/users/mrogers950/followers","following_url":"https://api.github.com/users/mrogers950/following{/other_user}","gists_url":"https://api.github.com/users/mrogers950/gists{/gist_id}","starred_url":"https://api.github.com/users/mrogers950/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrogers950/subscriptions","organizations_url":"https://api.github.com/users/mrogers950/orgs","repos_url":"https://api.github.com/users/mrogers950/repos","events_url":"https://api.github.com/users/mrogers950/events{/privacy}","received_events_url":"https://api.github.com/users/mrogers950/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrogers950/krb5","description":"mirror of MIT krb5 repository","fork":true,"url":"https://api.github.com/repos/mrogers950/krb5","forks_url":"https://api.github.com/repos/mrogers950/krb5/forks","keys_url":"https://api.github.com/repos/mrogers950/krb5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrogers950/krb5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrogers950/krb5/teams","hooks_url":"https://api.github.com/repos/mrogers950/krb5/hooks","issue_events_url":"https://api.github.com/repos/mrogers950/krb5/issues/events{/number}","events_url":"https://api.github.com/repos/mrogers950/krb5/events","assignees_url":"https://api.github.com/repos/mrogers950/krb5/assignees{/user}","branches_url":"https://api.github.com/repos/mrogers950/krb5/branches{/branch}","tags_url":"https://api.github.com/repos/mrogers950/krb5/tags","blobs_url":"https://api.github.com/repos/mrogers950/krb5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrogers950/krb5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrogers950/krb5/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrogers950/krb5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrogers950/krb5/statuses/{sha}","languages_url":"https://api.github.com/repos/mrogers950/krb5/languages","stargazers_url":"https://api.github.com/repos/mrogers950/krb5/stargazers","contributors_url":"https://api.github.com/repos/mrogers950/krb5/contributors","subscribers_url":"https://api.github.com/repos/mrogers950/krb5/subscribers","subscription_url":"https://api.github.com/repos/mrogers950/krb5/subscription","commits_url":"https://api.github.com/repos/mrogers950/krb5/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrogers950/krb5/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrogers950/krb5/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrogers950/krb5/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrogers950/krb5/contents/{+path}","compare_url":"https://api.github.com/repos/mrogers950/krb5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrogers950/krb5/merges","archive_url":"https://api.github.com/repos/mrogers950/krb5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrogers950/krb5/downloads","issues_url":"https://api.github.com/repos/mrogers950/krb5/issues{/number}","pulls_url":"https://api.github.com/repos/mrogers950/krb5/pulls{/number}","milestones_url":"https://api.github.com/repos/mrogers950/krb5/milestones{/number}","notifications_url":"https://api.github.com/repos/mrogers950/krb5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrogers950/krb5/labels{/name}","releases_url":"https://api.github.com/repos/mrogers950/krb5/releases{/id}","deployments_url":"https://api.github.com/repos/mrogers950/krb5/deployments","created_at":"2016-01-25T17:24:08Z","updated_at":"2016-01-25T17:24:18Z","pushed_at":"2016-07-18T21:45:15Z","git_url":"git://github.com/mrogers950/krb5.git","ssh_url":"git@github.com:mrogers950/krb5.git","clone_url":"https://github.com/mrogers950/krb5.git","svn_url":"https://github.com/mrogers950/krb5","homepage":null,"size":67183,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"krb5:master","ref":"master","sha":"77c3f655f684761efe957722e500887f3199fc5f","user":{"login":"krb5","id":523797,"avatar_url":"https://avatars.githubusercontent.com/u/523797?v=3","gravatar_id":"","url":"https://api.github.com/users/krb5","html_url":"https://github.com/krb5","followers_url":"https://api.github.com/users/krb5/followers","following_url":"https://api.github.com/users/krb5/following{/other_user}","gists_url":"https://api.github.com/users/krb5/gists{/gist_id}","starred_url":"https://api.github.com/users/krb5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krb5/subscriptions","organizations_url":"https://api.github.com/users/krb5/orgs","repos_url":"https://api.github.com/users/krb5/repos","events_url":"https://api.github.com/users/krb5/events{/privacy}","received_events_url":"https://api.github.com/users/krb5/received_events","type":"Organization","site_admin":false},"repo":{"id":4307702,"name":"krb5","full_name":"krb5/krb5","owner":{"login":"krb5","id":523797,"avatar_url":"https://avatars.githubusercontent.com/u/523797?v=3","gravatar_id":"","url":"https://api.github.com/users/krb5","html_url":"https://github.com/krb5","followers_url":"https://api.github.com/users/krb5/followers","following_url":"https://api.github.com/users/krb5/following{/other_user}","gists_url":"https://api.github.com/users/krb5/gists{/gist_id}","starred_url":"https://api.github.com/users/krb5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krb5/subscriptions","organizations_url":"https://api.github.com/users/krb5/orgs","repos_url":"https://api.github.com/users/krb5/repos","events_url":"https://api.github.com/users/krb5/events{/privacy}","received_events_url":"https://api.github.com/users/krb5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krb5/krb5","description":"mirror of MIT krb5 repository","fork":false,"url":"https://api.github.com/repos/krb5/krb5","forks_url":"https://api.github.com/repos/krb5/krb5/forks","keys_url":"https://api.github.com/repos/krb5/krb5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krb5/krb5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krb5/krb5/teams","hooks_url":"https://api.github.com/repos/krb5/krb5/hooks","issue_events_url":"https://api.github.com/repos/krb5/krb5/issues/events{/number}","events_url":"https://api.github.com/repos/krb5/krb5/events","assignees_url":"https://api.github.com/repos/krb5/krb5/assignees{/user}","branches_url":"https://api.github.com/repos/krb5/krb5/branches{/branch}","tags_url":"https://api.github.com/repos/krb5/krb5/tags","blobs_url":"https://api.github.com/repos/krb5/krb5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krb5/krb5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krb5/krb5/git/refs{/sha}","trees_url":"https://api.github.com/repos/krb5/krb5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krb5/krb5/statuses/{sha}","languages_url":"https://api.github.com/repos/krb5/krb5/languages","stargazers_url":"https://api.github.com/repos/krb5/krb5/stargazers","contributors_url":"https://api.github.com/repos/krb5/krb5/contributors","subscribers_url":"https://api.github.com/repos/krb5/krb5/subscribers","subscription_url":"https://api.github.com/repos/krb5/krb5/subscription","commits_url":"https://api.github.com/repos/krb5/krb5/commits{/sha}","git_commits_url":"https://api.github.com/repos/krb5/krb5/git/commits{/sha}","comments_url":"https://api.github.com/repos/krb5/krb5/comments{/number}","issue_comment_url":"https://api.github.com/repos/krb5/krb5/issues/comments{/number}","contents_url":"https://api.github.com/repos/krb5/krb5/contents/{+path}","compare_url":"https://api.github.com/repos/krb5/krb5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krb5/krb5/merges","archive_url":"https://api.github.com/repos/krb5/krb5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krb5/krb5/downloads","issues_url":"https://api.github.com/repos/krb5/krb5/issues{/number}","pulls_url":"https://api.github.com/repos/krb5/krb5/pulls{/number}","milestones_url":"https://api.github.com/repos/krb5/krb5/milestones{/number}","notifications_url":"https://api.github.com/repos/krb5/krb5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krb5/krb5/labels{/name}","releases_url":"https://api.github.com/repos/krb5/krb5/releases{/id}","deployments_url":"https://api.github.com/repos/krb5/krb5/deployments","created_at":"2012-05-12T16:01:32Z","updated_at":"2016-06-23T20:06:00Z","pushed_at":"2016-07-22T15:47:02Z","git_url":"git://github.com/krb5/krb5.git","ssh_url":"git@github.com:krb5/krb5.git","clone_url":"https://github.com/krb5/krb5.git","svn_url":"https://github.com/krb5/krb5","homepage":null,"size":81230,"stargazers_count":103,"watchers_count":103,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":17,"forks":121,"open_issues":17,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krb5/krb5/pulls/481"},"html":{"href":"https://github.com/krb5/krb5/pull/481"},"issue":{"href":"https://api.github.com/repos/krb5/krb5/issues/481"},"comments":{"href":"https://api.github.com/repos/krb5/krb5/issues/481/comments"},"review_comments":{"href":"https://api.github.com/repos/krb5/krb5/pulls/481/comments"},"review_comment":{"href":"https://api.github.com/repos/krb5/krb5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krb5/krb5/pulls/481/commits"},"statuses":{"href":"https://api.github.com/repos/krb5/krb5/statuses/4cdbcc984c8cac534b4f80f8b0c8d7c82ea0a092"}}}}
{"actor":{"display_login":"greghudson"}}