{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/rfcs/pulls/comments/88490620","pull_request_review_id":9063111,"id":88490620,"diff_hunk":"@@ -343,6 +343,24 @@ Export alternative](#everything-is-a-named-export).\n \n [decorators]: http://tc39.github.io/proposal-decorators/\n \n+### One Level Deep\n+\n+To avoid deep directory hierarchies with mostly-empty directories, this proposal\n+limits nesting inside a top-level package to a single level. Deep nesting like\n+this can add additional time to navigating the hierarchy without adding much\n+benefit.\n+\n+Java packages often have this problem due to their URL-based namespacing; see\n+e.g. [this Java\n+library](https://github.com/elvishew/xLog/tree/fbfb60f9472e32723436b3d6bdd6c1878a5afb37/library/src)\n+where you end up with deeply nested directories, like\n+`xLog/library/src/test/java/com/elvishew/xlog/printer/AndroidPrinterTest.java`.\n+\n+This rule leads to including the type in the name of the module in some cases\n+where it might otherwise be grouped instead. For example, instead of\n+`@ember/routing/locations/none`, we prefer `@ember/routing/none-location` to\n+avoid the second level of nesting.","path":"text/0000-javascript-module-api.md","position":357,"original_position":20,"commit_id":"b2dd7d10b38d13e5612df3c0bdb922171af21c27","original_commit_id":"90cf471943c9a3d63de708ea9da1453a80bdd6d9","user":{"login":"bcardarella","id":18524,"avatar_url":"https://avatars.githubusercontent.com/u/18524?v=3","gravatar_id":"","url":"https://api.github.com/users/bcardarella","html_url":"https://github.com/bcardarella","followers_url":"https://api.github.com/users/bcardarella/followers","following_url":"https://api.github.com/users/bcardarella/following{/other_user}","gists_url":"https://api.github.com/users/bcardarella/gists{/gist_id}","starred_url":"https://api.github.com/users/bcardarella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcardarella/subscriptions","organizations_url":"https://api.github.com/users/bcardarella/orgs","repos_url":"https://api.github.com/users/bcardarella/repos","events_url":"https://api.github.com/users/bcardarella/events{/privacy}","received_events_url":"https://api.github.com/users/bcardarella/received_events","type":"User","site_admin":false},"body":"I agree with @scottmessinger's point here. The mental model one starts to develop will be more difficult to absorb with a mix of nested and hyphenated modules. Let's stick with one","created_at":"2016-11-17T16:31:43Z","updated_at":"2016-11-17T16:31:43Z","html_url":"https://github.com/emberjs/rfcs/pull/176#discussion_r88490620","pull_request_url":"https://api.github.com/repos/emberjs/rfcs/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/comments/88490620"},"html":{"href":"https://github.com/emberjs/rfcs/pull/176#discussion_r88490620"},"pull_request":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/rfcs/pulls/176","id":92474150,"html_url":"https://github.com/emberjs/rfcs/pull/176","diff_url":"https://github.com/emberjs/rfcs/pull/176.diff","patch_url":"https://github.com/emberjs/rfcs/pull/176.patch","issue_url":"https://api.github.com/repos/emberjs/rfcs/issues/176","number":176,"state":"open","locked":false,"title":"RFC: JavaScript Modules API","user":{"login":"tomdale","id":90888,"avatar_url":"https://avatars.githubusercontent.com/u/90888?v=3","gravatar_id":"","url":"https://api.github.com/users/tomdale","html_url":"https://github.com/tomdale","followers_url":"https://api.github.com/users/tomdale/followers","following_url":"https://api.github.com/users/tomdale/following{/other_user}","gists_url":"https://api.github.com/users/tomdale/gists{/gist_id}","starred_url":"https://api.github.com/users/tomdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomdale/subscriptions","organizations_url":"https://api.github.com/users/tomdale/orgs","repos_url":"https://api.github.com/users/tomdale/repos","events_url":"https://api.github.com/users/tomdale/events{/privacy}","received_events_url":"https://api.github.com/users/tomdale/received_events","type":"User","site_admin":false},"body":"### [Rendered RFC](https://github.com/tomdale/rfcs/blob/js-modules/text/0000-javascript-module-api.md)\r\n\r\n### Author Responses\r\n\r\n#### [11/16/2016](https://github.com/emberjs/rfcs/pull/176#issuecomment-261100221)\r\n\r\n* Distribution & Versioning\r\n* File Size\r\n* Scoped Packages\r\n* Templates\r\n* Computed Properties\r\n* Owner API\r\n* Testing\r\n* Formalization\r\n* Generators\r\n* Ember Data\r\n* Churn / Complexity\r\n\r\n### Changelog\r\n\r\n#### 11/16/2016\r\n\r\n- [Add missing AutoLocation](https://github.com/emberjs/rfcs/pull/176/commits/13698de3344ed8498ec8349e58e9010cb1cdbb17)\r\n- [Move `getOwner` and `setOwner` to `@ember/application` from `@ember/object/internal`](https://github.com/emberjs/rfcs/pull/176/commits/dc4fc8706a16816391518a4cbb856f09a32bf6a5), per [@tchak's suggestion](https://github.com/emberjs/rfcs/pull/176#issuecomment-258678662)\r\n- [Add @zeppelin's previous module RFC, #68, to Prior Art section](https://github.com/emberjs/rfcs/pull/176/commits/c8283adfad47a308b10b42d1777b2d45aa9a7133)\r\n- [Note that we need to update generators to the How We Teach This section](https://github.com/emberjs/rfcs/pull/176/commits/cea5cc30b4d2d06d62db9f5ffe77889cc7b4fe2a), per [@HeroicEric's suggestion](https://github.com/emberjs/rfcs/pull/176#issuecomment-259201703)\r\n- [Add constraint around not deeply nesting modules](https://github.com/emberjs/rfcs/pull/176/commits/90cf471943c9a3d63de708ea9da1453a80bdd6d9), per [@nathanhammond's suggestion](https://github.com/emberjs/rfcs/pull/176#discussion_r87094024).\r\n- [Indicate intent to tackle migration strategy for addon authors in a separate RFC, now that we think we have a feasible approach](https://github.com/emberjs/rfcs/pull/176/commits/078c16ff8a23b64fd2d31722624765d636db9466), per [@nathanhammond's recommendation](https://github.com/emberjs/rfcs/pull/176#discussion_r87092134)\r\n- [Clarify that functions like `Ember.run` no longer act as namespaces](https://github.com/emberjs/rfcs/pull/176/commits/62d796da12347a7070a04cb4b932bd63aae14e7a), in response to [@nathanhammond's question](https://github.com/emberjs/rfcs/pull/176#discussion_r86680849)\r\n- [Remove discussion of multiple versions of Ember at the same](https://github.com/emberjs/rfcs/pull/176/commits/b2dd7d10b38d13e5612df3c0bdb922171af21c27) as it's outside of the scope of this RFC, based on [@nathanhammond's concerns](https://github.com/emberjs/rfcs/pull/176#discussion_r86680990)","created_at":"2016-11-06T01:55:03Z","updated_at":"2016-11-17T16:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43d25c0ed96db61c3319570aed89ddc49f245a34","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/rfcs/pulls/176/commits","review_comments_url":"https://api.github.com/repos/emberjs/rfcs/pulls/176/comments","review_comment_url":"https://api.github.com/repos/emberjs/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/rfcs/issues/176/comments","statuses_url":"https://api.github.com/repos/emberjs/rfcs/statuses/b2dd7d10b38d13e5612df3c0bdb922171af21c27","head":{"label":"tomdale:js-modules","ref":"js-modules","sha":"b2dd7d10b38d13e5612df3c0bdb922171af21c27","user":{"login":"tomdale","id":90888,"avatar_url":"https://avatars.githubusercontent.com/u/90888?v=3","gravatar_id":"","url":"https://api.github.com/users/tomdale","html_url":"https://github.com/tomdale","followers_url":"https://api.github.com/users/tomdale/followers","following_url":"https://api.github.com/users/tomdale/following{/other_user}","gists_url":"https://api.github.com/users/tomdale/gists{/gist_id}","starred_url":"https://api.github.com/users/tomdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomdale/subscriptions","organizations_url":"https://api.github.com/users/tomdale/orgs","repos_url":"https://api.github.com/users/tomdale/repos","events_url":"https://api.github.com/users/tomdale/events{/privacy}","received_events_url":"https://api.github.com/users/tomdale/received_events","type":"User","site_admin":false},"repo":{"id":25714304,"name":"rfcs","full_name":"tomdale/rfcs","owner":{"login":"tomdale","id":90888,"avatar_url":"https://avatars.githubusercontent.com/u/90888?v=3","gravatar_id":"","url":"https://api.github.com/users/tomdale","html_url":"https://github.com/tomdale","followers_url":"https://api.github.com/users/tomdale/followers","following_url":"https://api.github.com/users/tomdale/following{/other_user}","gists_url":"https://api.github.com/users/tomdale/gists{/gist_id}","starred_url":"https://api.github.com/users/tomdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomdale/subscriptions","organizations_url":"https://api.github.com/users/tomdale/orgs","repos_url":"https://api.github.com/users/tomdale/repos","events_url":"https://api.github.com/users/tomdale/events{/privacy}","received_events_url":"https://api.github.com/users/tomdale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomdale/rfcs","description":"RFCs for changes to Ember","fork":true,"url":"https://api.github.com/repos/tomdale/rfcs","forks_url":"https://api.github.com/repos/tomdale/rfcs/forks","keys_url":"https://api.github.com/repos/tomdale/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomdale/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomdale/rfcs/teams","hooks_url":"https://api.github.com/repos/tomdale/rfcs/hooks","issue_events_url":"https://api.github.com/repos/tomdale/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/tomdale/rfcs/events","assignees_url":"https://api.github.com/repos/tomdale/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/tomdale/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/tomdale/rfcs/tags","blobs_url":"https://api.github.com/repos/tomdale/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomdale/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomdale/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomdale/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomdale/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/tomdale/rfcs/languages","stargazers_url":"https://api.github.com/repos/tomdale/rfcs/stargazers","contributors_url":"https://api.github.com/repos/tomdale/rfcs/contributors","subscribers_url":"https://api.github.com/repos/tomdale/rfcs/subscribers","subscription_url":"https://api.github.com/repos/tomdale/rfcs/subscription","commits_url":"https://api.github.com/repos/tomdale/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomdale/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomdale/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomdale/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomdale/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/tomdale/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomdale/rfcs/merges","archive_url":"https://api.github.com/repos/tomdale/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomdale/rfcs/downloads","issues_url":"https://api.github.com/repos/tomdale/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/tomdale/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/tomdale/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/tomdale/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomdale/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/tomdale/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/tomdale/rfcs/deployments","created_at":"2014-10-25T00:27:31Z","updated_at":"2016-11-14T21:06:26Z","pushed_at":"2016-11-16T22:59:01Z","git_url":"git://github.com/tomdale/rfcs.git","ssh_url":"git@github.com:tomdale/rfcs.git","clone_url":"https://github.com/tomdale/rfcs.git","svn_url":"https://github.com/tomdale/rfcs","homepage":null,"size":236,"stargazers_count":25,"watchers_count":25,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":0,"forks":8,"open_issues":0,"watchers":25,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"c1f3a6587ff8979f75c0fc48b5a9d4fa035fe791","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":22664562,"name":"rfcs","full_name":"emberjs/rfcs","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/rfcs","description":"RFCs for changes to Ember","fork":false,"url":"https://api.github.com/repos/emberjs/rfcs","forks_url":"https://api.github.com/repos/emberjs/rfcs/forks","keys_url":"https://api.github.com/repos/emberjs/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/rfcs/teams","hooks_url":"https://api.github.com/repos/emberjs/rfcs/hooks","issue_events_url":"https://api.github.com/repos/emberjs/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/rfcs/events","assignees_url":"https://api.github.com/repos/emberjs/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/rfcs/tags","blobs_url":"https://api.github.com/repos/emberjs/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/rfcs/languages","stargazers_url":"https://api.github.com/repos/emberjs/rfcs/stargazers","contributors_url":"https://api.github.com/repos/emberjs/rfcs/contributors","subscribers_url":"https://api.github.com/repos/emberjs/rfcs/subscribers","subscription_url":"https://api.github.com/repos/emberjs/rfcs/subscription","commits_url":"https://api.github.com/repos/emberjs/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/rfcs/merges","archive_url":"https://api.github.com/repos/emberjs/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/rfcs/downloads","issues_url":"https://api.github.com/repos/emberjs/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/rfcs/deployments","created_at":"2014-08-06T00:49:22Z","updated_at":"2016-11-12T03:51:54Z","pushed_at":"2016-11-16T22:59:01Z","git_url":"git://github.com/emberjs/rfcs.git","ssh_url":"git@github.com:emberjs/rfcs.git","clone_url":"https://github.com/emberjs/rfcs.git","svn_url":"https://github.com/emberjs/rfcs","homepage":null,"size":702,"stargazers_count":457,"watchers_count":457,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":67,"forks":140,"open_issues":67,"watchers":457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/176"},"html":{"href":"https://github.com/emberjs/rfcs/pull/176"},"issue":{"href":"https://api.github.com/repos/emberjs/rfcs/issues/176"},"comments":{"href":"https://api.github.com/repos/emberjs/rfcs/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/rfcs/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/rfcs/statuses/b2dd7d10b38d13e5612df3c0bdb922171af21c27"}}}}
{"actor":{"display_login":"bcardarella"}}