{"action":"created","comment":{"url":"https://api.github.com/repos/isotope/core/pulls/comments/74222915","id":74222915,"diff_hunk":"@@ -168,4 +164,22 @@ function(&$option) {\n \n         return $objTemplate->parse();\n     }\n+\n+    /**\n+     * Escape the parameter value so it's correctly handled by Payone\n+     *\n+     * @param string $value\n+     *\n+     * @return string\n+     */\n+    protected function escapeParameterValue($value)\n+    {\n+        $value = strip_insert_tags(strip_tags($value));\n+        $value = \\StringUtil::restoreBasicEntities($value);\n+        $value = html_entity_decode($value);\n+        $value = str_replace(\"\\xC2\\xA0\", ' ', $value); // strip &nbsp;\n+        $value = str_replace('\"', '\\'', $value); // replace double quotes with single quotes","path":"system/modules/isotope/library/Isotope/Model/Payment/Payone.php","position":42,"original_position":42,"commit_id":"2028b9646375dfaf3c11a5b60b532a64b393d0da","original_commit_id":"2028b9646375dfaf3c11a5b60b532a64b393d0da","user":{"login":"qzminski","id":193483,"avatar_url":"https://avatars.githubusercontent.com/u/193483?v=3","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"body":"Absolutely not you mean 😉  The ```\\'``` is escape only in PHP so it results as a single quote in HTML. You can't escape the form value as follows:\r\n\r\n```html\r\n<input type=\"hidden\" name=\"foobar\" value=\"my \\\"super\\\" product name\">\r\n```","created_at":"2016-08-10T10:48:36Z","updated_at":"2016-08-10T10:48:36Z","html_url":"https://github.com/isotope/core/pull/1687#discussion_r74222915","pull_request_url":"https://api.github.com/repos/isotope/core/pulls/1687","_links":{"self":{"href":"https://api.github.com/repos/isotope/core/pulls/comments/74222915"},"html":{"href":"https://github.com/isotope/core/pull/1687#discussion_r74222915"},"pull_request":{"href":"https://api.github.com/repos/isotope/core/pulls/1687"}}},"pull_request":{"url":"https://api.github.com/repos/isotope/core/pulls/1687","id":80637556,"html_url":"https://github.com/isotope/core/pull/1687","diff_url":"https://github.com/isotope/core/pull/1687.diff","patch_url":"https://github.com/isotope/core/pull/1687.patch","issue_url":"https://api.github.com/repos/isotope/core/issues/1687","number":1687,"state":"open","locked":false,"title":"Clean the parameter value in the Payone payment method","user":{"login":"qzminski","id":193483,"avatar_url":"https://avatars.githubusercontent.com/u/193483?v=3","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"body":"Fixes #1256","created_at":"2016-08-09T15:05:14Z","updated_at":"2016-08-10T10:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"146cbd36395eccbf5904275c2f461c2ca27d5276","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/isotope/core/pulls/1687/commits","review_comments_url":"https://api.github.com/repos/isotope/core/pulls/1687/comments","review_comment_url":"https://api.github.com/repos/isotope/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/isotope/core/issues/1687/comments","statuses_url":"https://api.github.com/repos/isotope/core/statuses/2028b9646375dfaf3c11a5b60b532a64b393d0da","head":{"label":"qzminski:bugfix/payone-nbsp","ref":"bugfix/payone-nbsp","sha":"2028b9646375dfaf3c11a5b60b532a64b393d0da","user":{"login":"qzminski","id":193483,"avatar_url":"https://avatars.githubusercontent.com/u/193483?v=3","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"repo":{"id":53856162,"name":"isotope-core","full_name":"qzminski/isotope-core","owner":{"login":"qzminski","id":193483,"avatar_url":"https://avatars.githubusercontent.com/u/193483?v=3","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qzminski/isotope-core","description":"Core repository of Isotope eCommerce, an eCommerce extension for Contao Open Source CMS","fork":true,"url":"https://api.github.com/repos/qzminski/isotope-core","forks_url":"https://api.github.com/repos/qzminski/isotope-core/forks","keys_url":"https://api.github.com/repos/qzminski/isotope-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qzminski/isotope-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qzminski/isotope-core/teams","hooks_url":"https://api.github.com/repos/qzminski/isotope-core/hooks","issue_events_url":"https://api.github.com/repos/qzminski/isotope-core/issues/events{/number}","events_url":"https://api.github.com/repos/qzminski/isotope-core/events","assignees_url":"https://api.github.com/repos/qzminski/isotope-core/assignees{/user}","branches_url":"https://api.github.com/repos/qzminski/isotope-core/branches{/branch}","tags_url":"https://api.github.com/repos/qzminski/isotope-core/tags","blobs_url":"https://api.github.com/repos/qzminski/isotope-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qzminski/isotope-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qzminski/isotope-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/qzminski/isotope-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qzminski/isotope-core/statuses/{sha}","languages_url":"https://api.github.com/repos/qzminski/isotope-core/languages","stargazers_url":"https://api.github.com/repos/qzminski/isotope-core/stargazers","contributors_url":"https://api.github.com/repos/qzminski/isotope-core/contributors","subscribers_url":"https://api.github.com/repos/qzminski/isotope-core/subscribers","subscription_url":"https://api.github.com/repos/qzminski/isotope-core/subscription","commits_url":"https://api.github.com/repos/qzminski/isotope-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/qzminski/isotope-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/qzminski/isotope-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/qzminski/isotope-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/qzminski/isotope-core/contents/{+path}","compare_url":"https://api.github.com/repos/qzminski/isotope-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qzminski/isotope-core/merges","archive_url":"https://api.github.com/repos/qzminski/isotope-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qzminski/isotope-core/downloads","issues_url":"https://api.github.com/repos/qzminski/isotope-core/issues{/number}","pulls_url":"https://api.github.com/repos/qzminski/isotope-core/pulls{/number}","milestones_url":"https://api.github.com/repos/qzminski/isotope-core/milestones{/number}","notifications_url":"https://api.github.com/repos/qzminski/isotope-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qzminski/isotope-core/labels{/name}","releases_url":"https://api.github.com/repos/qzminski/isotope-core/releases{/id}","deployments_url":"https://api.github.com/repos/qzminski/isotope-core/deployments","created_at":"2016-03-14T12:55:43Z","updated_at":"2016-03-14T12:56:12Z","pushed_at":"2016-08-10T10:12:18Z","git_url":"git://github.com/qzminski/isotope-core.git","ssh_url":"git@github.com:qzminski/isotope-core.git","clone_url":"https://github.com/qzminski/isotope-core.git","svn_url":"https://github.com/qzminski/isotope-core","homepage":"www.isotopeecommerce.com","size":36369,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"isotope:develop","ref":"develop","sha":"4983245961ad6cacebe272bc9995bfb5e5c43d10","user":{"login":"isotope","id":1202906,"avatar_url":"https://avatars.githubusercontent.com/u/1202906?v=3","gravatar_id":"","url":"https://api.github.com/users/isotope","html_url":"https://github.com/isotope","followers_url":"https://api.github.com/users/isotope/followers","following_url":"https://api.github.com/users/isotope/following{/other_user}","gists_url":"https://api.github.com/users/isotope/gists{/gist_id}","starred_url":"https://api.github.com/users/isotope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isotope/subscriptions","organizations_url":"https://api.github.com/users/isotope/orgs","repos_url":"https://api.github.com/users/isotope/repos","events_url":"https://api.github.com/users/isotope/events{/privacy}","received_events_url":"https://api.github.com/users/isotope/received_events","type":"Organization","site_admin":false},"repo":{"id":3041962,"name":"core","full_name":"isotope/core","owner":{"login":"isotope","id":1202906,"avatar_url":"https://avatars.githubusercontent.com/u/1202906?v=3","gravatar_id":"","url":"https://api.github.com/users/isotope","html_url":"https://github.com/isotope","followers_url":"https://api.github.com/users/isotope/followers","following_url":"https://api.github.com/users/isotope/following{/other_user}","gists_url":"https://api.github.com/users/isotope/gists{/gist_id}","starred_url":"https://api.github.com/users/isotope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isotope/subscriptions","organizations_url":"https://api.github.com/users/isotope/orgs","repos_url":"https://api.github.com/users/isotope/repos","events_url":"https://api.github.com/users/isotope/events{/privacy}","received_events_url":"https://api.github.com/users/isotope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/isotope/core","description":"Core repository of Isotope eCommerce, an eCommerce extension for Contao Open Source CMS","fork":false,"url":"https://api.github.com/repos/isotope/core","forks_url":"https://api.github.com/repos/isotope/core/forks","keys_url":"https://api.github.com/repos/isotope/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isotope/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isotope/core/teams","hooks_url":"https://api.github.com/repos/isotope/core/hooks","issue_events_url":"https://api.github.com/repos/isotope/core/issues/events{/number}","events_url":"https://api.github.com/repos/isotope/core/events","assignees_url":"https://api.github.com/repos/isotope/core/assignees{/user}","branches_url":"https://api.github.com/repos/isotope/core/branches{/branch}","tags_url":"https://api.github.com/repos/isotope/core/tags","blobs_url":"https://api.github.com/repos/isotope/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isotope/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isotope/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/isotope/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isotope/core/statuses/{sha}","languages_url":"https://api.github.com/repos/isotope/core/languages","stargazers_url":"https://api.github.com/repos/isotope/core/stargazers","contributors_url":"https://api.github.com/repos/isotope/core/contributors","subscribers_url":"https://api.github.com/repos/isotope/core/subscribers","subscription_url":"https://api.github.com/repos/isotope/core/subscription","commits_url":"https://api.github.com/repos/isotope/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/isotope/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/isotope/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/isotope/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/isotope/core/contents/{+path}","compare_url":"https://api.github.com/repos/isotope/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isotope/core/merges","archive_url":"https://api.github.com/repos/isotope/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isotope/core/downloads","issues_url":"https://api.github.com/repos/isotope/core/issues{/number}","pulls_url":"https://api.github.com/repos/isotope/core/pulls{/number}","milestones_url":"https://api.github.com/repos/isotope/core/milestones{/number}","notifications_url":"https://api.github.com/repos/isotope/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isotope/core/labels{/name}","releases_url":"https://api.github.com/repos/isotope/core/releases{/id}","deployments_url":"https://api.github.com/repos/isotope/core/deployments","created_at":"2011-12-23T19:35:54Z","updated_at":"2016-06-14T09:36:06Z","pushed_at":"2016-08-10T10:12:39Z","git_url":"git://github.com/isotope/core.git","ssh_url":"git@github.com:isotope/core.git","clone_url":"https://github.com/isotope/core.git","svn_url":"https://github.com/isotope/core","homepage":"www.isotopeecommerce.com","size":40714,"stargazers_count":107,"watchers_count":107,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":103,"forks":74,"open_issues":103,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/isotope/core/pulls/1687"},"html":{"href":"https://github.com/isotope/core/pull/1687"},"issue":{"href":"https://api.github.com/repos/isotope/core/issues/1687"},"comments":{"href":"https://api.github.com/repos/isotope/core/issues/1687/comments"},"review_comments":{"href":"https://api.github.com/repos/isotope/core/pulls/1687/comments"},"review_comment":{"href":"https://api.github.com/repos/isotope/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/isotope/core/pulls/1687/commits"},"statuses":{"href":"https://api.github.com/repos/isotope/core/statuses/2028b9646375dfaf3c11a5b60b532a64b393d0da"}}}}
{"actor":{"display_login":"qzminski"}}