{"action":"created","issue":{"url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows/issues/660","repository_url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows","labels_url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows/issues/660/labels{/name}","comments_url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows/issues/660/comments","events_url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows/issues/660/events","html_url":"https://github.com/shadowsocks/shadowsocks-windows/pull/660","id":171205140,"number":660,"title":"Resolving domain name through socks5 proxy","user":{"login":"Noisyfox","id":1537155,"avatar_url":"https://avatars.githubusercontent.com/u/1537155?v=3","gravatar_id":"","url":"https://api.github.com/users/Noisyfox","html_url":"https://github.com/Noisyfox","followers_url":"https://api.github.com/users/Noisyfox/followers","following_url":"https://api.github.com/users/Noisyfox/following{/other_user}","gists_url":"https://api.github.com/users/Noisyfox/gists{/gist_id}","starred_url":"https://api.github.com/users/Noisyfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noisyfox/subscriptions","organizations_url":"https://api.github.com/users/Noisyfox/orgs","repos_url":"https://api.github.com/users/Noisyfox/repos","events_url":"https://api.github.com/users/Noisyfox/events{/privacy}","received_events_url":"https://api.github.com/users/Noisyfox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-15T16:20:28Z","updated_at":"2016-08-16T08:04:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows/pulls/660","html_url":"https://github.com/shadowsocks/shadowsocks-windows/pull/660","diff_url":"https://github.com/shadowsocks/shadowsocks-windows/pull/660.diff","patch_url":"https://github.com/shadowsocks/shadowsocks-windows/pull/660.patch"},"body":"When using ss through another socks5 proxy, the prev version still resolves ss server's domain name locally. This could lead to wrong results.\r\n\r\nThis patch allow proxy module to resolve domain name itself.\r\n-Socks5 proxy: just pass the domain name to socks5 proxy server cuz the protocol support domain name.\r\n-Direct connect: still resolves locally and synchronously."},"comment":{"url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows/issues/comments/240031433","html_url":"https://github.com/shadowsocks/shadowsocks-windows/pull/660#issuecomment-240031433","issue_url":"https://api.github.com/repos/shadowsocks/shadowsocks-windows/issues/660","id":240031433,"user":{"login":"wongsyrone","id":5462232,"avatar_url":"https://avatars.githubusercontent.com/u/5462232?v=3","gravatar_id":"","url":"https://api.github.com/users/wongsyrone","html_url":"https://github.com/wongsyrone","followers_url":"https://api.github.com/users/wongsyrone/followers","following_url":"https://api.github.com/users/wongsyrone/following{/other_user}","gists_url":"https://api.github.com/users/wongsyrone/gists{/gist_id}","starred_url":"https://api.github.com/users/wongsyrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongsyrone/subscriptions","organizations_url":"https://api.github.com/users/wongsyrone/orgs","repos_url":"https://api.github.com/users/wongsyrone/repos","events_url":"https://api.github.com/users/wongsyrone/events{/privacy}","received_events_url":"https://api.github.com/users/wongsyrone/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T08:04:48Z","updated_at":"2016-08-16T08:04:48Z","body":"Can we use something like:\r\n```C#\r\nif (typeof(Socket).GetProperty(\"DualMode\") == null)\r\n```\r\nto detect DualMode availibility, and prefer to use it?"}}
{"actor":{"display_login":"wongsyrone"}}