{"action":"created","issue":{"url":"https://api.github.com/repos/imposters-handbook/feedback/issues/182","repository_url":"https://api.github.com/repos/imposters-handbook/feedback","labels_url":"https://api.github.com/repos/imposters-handbook/feedback/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/imposters-handbook/feedback/issues/182/comments","events_url":"https://api.github.com/repos/imposters-handbook/feedback/issues/182/events","html_url":"https://github.com/imposters-handbook/feedback/issues/182","id":188358777,"number":182,"title":"Software Design (PDF in imposter_1_0.zip)","user":{"login":"joeratzer","id":2004631,"avatar_url":"https://avatars.githubusercontent.com/u/2004631?v=3","gravatar_id":"","url":"https://api.github.com/users/joeratzer","html_url":"https://github.com/joeratzer","followers_url":"https://api.github.com/users/joeratzer/followers","following_url":"https://api.github.com/users/joeratzer/following{/other_user}","gists_url":"https://api.github.com/users/joeratzer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeratzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeratzer/subscriptions","organizations_url":"https://api.github.com/users/joeratzer/orgs","repos_url":"https://api.github.com/users/joeratzer/repos","events_url":"https://api.github.com/users/joeratzer/events{/privacy}","received_events_url":"https://api.github.com/users/joeratzer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-09T21:37:22Z","updated_at":"2016-11-14T20:41:13Z","closed_at":"2016-11-14T18:24:47Z","body":"As before, thank you for writing the book!\r\n\r\nHere's my initial feedback from reading Software Design from the PDF in imposter_1_0.zip:\r\n\r\n**Page 555**\r\n**Current**: A Singleton is a class that only allows one instance of itself. It's is not an easy thing to do correctly...\r\n**Suggestion**: A Singleton is a class that only allows one instance of itself. It's not an easy thing to do correctly...\r\n\r\n\r\n**Page 559**\r\n**Current**: The problem is that we now have to go implement it for every adapter...\r\n**Suggestion**: The problem is that we now have to go and implement it for every adapter...\r\n\r\n\r\n**Page 561**\r\n**Current**: It turns out that the some of the drivers we've been using don't implement connection pools...\r\n**Suggestion**: It turns out that some of the drivers we've been using don't implement connection pools...\r\n\r\n\r\n**Page 569**\r\n**Current**: ...but when it comes to validations there are better ways to do this.\r\n**Suggestion**: Why not choose an example that makes more sense?\r\n\r\n\r\n**Page 585**\r\n**Current**: I started working in a functional language (Elixir) this last year and I love it. \r\n**Suggestion**: I started working in a functional language (Elixir) last year and I love it. \r\n\r\n\r\n**Page 599**\r\n**Current**: As you build applications using the patterns we learned in the in a\r\nprevious chapter...\r\n**Suggestion**: As you build applications using the patterns we have been learning...\r\n\r\n\r\n**Page 606**\r\n**Current**: YAGNI (You Aint Gonna Need It)...\r\n**Suggestion**: YAGNI (You Ain't Gonna Need It)...\r\n\r\n\r\n**Page 618**\r\n**Current**: We still have coupling to a the notion of an IDataStore...\r\n**Suggestion**: We still have coupling to the notion of an IDataStore...\r\n\r\n\r\n**Page 623**\r\n**Current**: As your application grows and becomes more complex, it's becomes easier to find yourself creating circular dependencies.\r\n**Suggestion**: As your application grows and becomes more complex, it becomes easier to find yourself creating circular dependencies.\r\n\r\n\r\n**Page 639**\r\n**Current**: I know that people like to argue about what they think it is and what think it is not.\r\n**Suggestion**: I know that people like to argue about what they think it is and what they think it is not.\r\n\r\n\r\n**Page 650**\r\n**Current**: This where we venture into silly land.\r\n**Suggestion**: This is where we venture into silly land\r\n\r\n\r\n**General**\r\nI think the discussion on IoC should include a mention on why it makes unit testing easier."},"comment":{"url":"https://api.github.com/repos/imposters-handbook/feedback/issues/comments/260456109","html_url":"https://github.com/imposters-handbook/feedback/issues/182#issuecomment-260456109","issue_url":"https://api.github.com/repos/imposters-handbook/feedback/issues/182","id":260456109,"user":{"login":"joeratzer","id":2004631,"avatar_url":"https://avatars.githubusercontent.com/u/2004631?v=3","gravatar_id":"","url":"https://api.github.com/users/joeratzer","html_url":"https://github.com/joeratzer","followers_url":"https://api.github.com/users/joeratzer/followers","following_url":"https://api.github.com/users/joeratzer/following{/other_user}","gists_url":"https://api.github.com/users/joeratzer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeratzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeratzer/subscriptions","organizations_url":"https://api.github.com/users/joeratzer/orgs","repos_url":"https://api.github.com/users/joeratzer/repos","events_url":"https://api.github.com/users/joeratzer/events{/privacy}","received_events_url":"https://api.github.com/users/joeratzer/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T20:41:13Z","updated_at":"2016-11-14T20:41:13Z","body":"No worries, it's good seeing the book come together. That all looks done in the latest version, except YAGNI is still missing an apostrophe. Sorry! :)\r\n\r\nAnd just in case you didn't see it - I added a comment to the old closed issue titled \"Comp Sci, Baby (v0.0.3)\"."}}
{"actor":{"display_login":"joeratzer"}}