{"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/85081049","pull_request_review_id":5816473,"id":85081049,"diff_hunk":"@@ -450,6 +462,41 @@ def add_remove_errata_to_filter(self, cv_name, filter_name,\n         else:\n             self.click(locators['contentviews.remove_errata'])\n \n+    def edit_erratum_date_range_filter(\n+            self, cv_name, filter_name, errata_types=None, date_type=None,\n+            start_date=None, end_date=None, open_filter=True):\n+        \"\"\"Edit Erratum Date Range Filter\"\"\"\n+        allowed_errata_types = ['security', 'enhancement', 'bugfix']\n+        allowed_date_types = ['updated', 'issued']\n+        if not errata_types:\n+            errata_types = ['security']\n+        if not date_type:\n+            date_type = 'updated'\n+        if date_type not in allowed_date_types:\n+            raise UIError('date type \"{0}\" does not exit'.format(date_type))\n+        if open_filter:\n+            self.go_to_filter_page(cv_name, filter_name)\n+        for errata_type in allowed_errata_types:\n+            errata_type_elm = self.wait_until_element(\n+                locators['contentviews.erratum_type_checkbox'] % errata_type)\n+            if errata_type_elm:\n+                if errata_type_elm.get_attribute('value') == 'true':\n+                    checked = True\n+                else:\n+                    checked = False\n+                if (errata_type in errata_types and not checked)\\","path":"robottelo/ui/contentviews.py","position":45,"original_position":45,"commit_id":"9fd32c0d7efcccf26e8c860eac0c3761b14f9d32","original_commit_id":"9fd32c0d7efcccf26e8c860eac0c3761b14f9d32","user":{"login":"oshtaier","id":10895065,"avatar_url":"https://avatars.githubusercontent.com/u/10895065?v=3","gravatar_id":"","url":"https://api.github.com/users/oshtaier","html_url":"https://github.com/oshtaier","followers_url":"https://api.github.com/users/oshtaier/followers","following_url":"https://api.github.com/users/oshtaier/following{/other_user}","gists_url":"https://api.github.com/users/oshtaier/gists{/gist_id}","starred_url":"https://api.github.com/users/oshtaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshtaier/subscriptions","organizations_url":"https://api.github.com/users/oshtaier/orgs","repos_url":"https://api.github.com/users/oshtaier/repos","events_url":"https://api.github.com/users/oshtaier/events{/privacy}","received_events_url":"https://api.github.com/users/oshtaier/received_events","type":"User","site_admin":false},"body":"I would say that `\\`  style is not recommended at all. Please try:\r\n```\r\nif ((errata_type in errata_types and not checked) or \r\n                errata_type  not in errata_types and checked)):\r\n```","created_at":"2016-10-26T09:20:21Z","updated_at":"2016-10-26T09:20:21Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/3940#discussion_r85081049","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/85081049"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/3940#discussion_r85081049"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940","id":90769720,"html_url":"https://github.com/SatelliteQE/robottelo/pull/3940","diff_url":"https://github.com/SatelliteQE/robottelo/pull/3940.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/3940.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3940","number":3940,"state":"open","locked":false,"title":"#3586-UI-CV- add-edit_rh_custom_spin","user":{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"body":"```bash\r\ndlezz@elysion:~/projects/robottelo-fork$ py.test tests/foreman/ui/test_contentview.py -v -k 'test_positive_edit_rh_custom_spin'\r\n================================================= test session starts ==================================================\r\nplatform linux2 -- Python 2.7.12, pytest-3.0.3, py-1.4.31, pluggy-0.4.0 -- /home/dlezz/bin/redhat/python/2.7/bin/python\r\ncachedir: .cache\r\nrootdir: /home/dlezz/projects/robottelo-fork, inifile: \r\nplugins: cov-2.4.0, xdist-1.15.0\r\ncollected 65 items \r\n\r\ntests/foreman/ui/test_contentview.py::ContentViewTestCase::test_positive_edit_rh_custom_spin <- robottelo/decorators/__init__.py PASSED\r\n\r\n================================================= 64 tests deselected ==================================================\r\n====================================== 1 passed, 64 deselected in 306.83 seconds =======================================\r\n```\r\n```bash\r\ndlezz@elysion:~/projects/robottelo-fork$ py.test tests/foreman/ui/test_contentview.py -v -k 'test_positive_add_rh_custom_spin'\r\n================================================= test session starts ==================================================\r\nplatform linux2 -- Python 2.7.12, pytest-3.0.3, py-1.4.31, pluggy-0.4.0 -- /home/dlezz/bin/redhat/python/2.7/bin/python\r\ncachedir: .cache\r\nrootdir: /home/dlezz/projects/robottelo-fork, inifile: \r\nplugins: cov-2.4.0, xdist-1.15.0\r\ncollected 65 items \r\n\r\ntests/foreman/ui/test_contentview.py::ContentViewTestCase::test_positive_add_rh_custom_spin <- robottelo/decorators/__init__.py PASSED\r\n\r\n================================================= 64 tests deselected ==================================================\r\n====================================== 1 passed, 64 deselected in 304.04 seconds =======================================\r\n```","created_at":"2016-10-25T09:25:13Z","updated_at":"2016-10-26T09:20:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be2a0694a2100f7b72e8e17f0d98f4143855932e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3940/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/9fd32c0d7efcccf26e8c860eac0c3761b14f9d32","head":{"label":"ldjebran:#3586-UI-CV-add-edit-rh_custom_spin","ref":"#3586-UI-CV-add-edit-rh_custom_spin","sha":"9fd32c0d7efcccf26e8c860eac0c3761b14f9d32","user":{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"repo":{"id":71339453,"name":"robottelo","full_name":"ldjebran/robottelo","owner":{"login":"ldjebran","id":131553,"avatar_url":"https://avatars.githubusercontent.com/u/131553?v=3","gravatar_id":"","url":"https://api.github.com/users/ldjebran","html_url":"https://github.com/ldjebran","followers_url":"https://api.github.com/users/ldjebran/followers","following_url":"https://api.github.com/users/ldjebran/following{/other_user}","gists_url":"https://api.github.com/users/ldjebran/gists{/gist_id}","starred_url":"https://api.github.com/users/ldjebran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldjebran/subscriptions","organizations_url":"https://api.github.com/users/ldjebran/orgs","repos_url":"https://api.github.com/users/ldjebran/repos","events_url":"https://api.github.com/users/ldjebran/events{/privacy}","received_events_url":"https://api.github.com/users/ldjebran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldjebran/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":true,"url":"https://api.github.com/repos/ldjebran/robottelo","forks_url":"https://api.github.com/repos/ldjebran/robottelo/forks","keys_url":"https://api.github.com/repos/ldjebran/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldjebran/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldjebran/robottelo/teams","hooks_url":"https://api.github.com/repos/ldjebran/robottelo/hooks","issue_events_url":"https://api.github.com/repos/ldjebran/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/ldjebran/robottelo/events","assignees_url":"https://api.github.com/repos/ldjebran/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/ldjebran/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/ldjebran/robottelo/tags","blobs_url":"https://api.github.com/repos/ldjebran/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldjebran/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldjebran/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldjebran/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldjebran/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/ldjebran/robottelo/languages","stargazers_url":"https://api.github.com/repos/ldjebran/robottelo/stargazers","contributors_url":"https://api.github.com/repos/ldjebran/robottelo/contributors","subscribers_url":"https://api.github.com/repos/ldjebran/robottelo/subscribers","subscription_url":"https://api.github.com/repos/ldjebran/robottelo/subscription","commits_url":"https://api.github.com/repos/ldjebran/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldjebran/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldjebran/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldjebran/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldjebran/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/ldjebran/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldjebran/robottelo/merges","archive_url":"https://api.github.com/repos/ldjebran/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldjebran/robottelo/downloads","issues_url":"https://api.github.com/repos/ldjebran/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/ldjebran/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/ldjebran/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/ldjebran/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldjebran/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/ldjebran/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/ldjebran/robottelo/deployments","created_at":"2016-10-19T09:11:49Z","updated_at":"2016-10-19T09:11:52Z","pushed_at":"2016-10-25T09:40:21Z","git_url":"git://github.com/ldjebran/robottelo.git","ssh_url":"git@github.com:ldjebran/robottelo.git","clone_url":"https://github.com/ldjebran/robottelo.git","svn_url":"https://github.com/ldjebran/robottelo","homepage":"","size":13649,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"b44e08eab18504dc527d33be37dee3f02f5e47ed","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/SatelliteQE/robottelo/deployments","created_at":"2012-04-12T01:36:39Z","updated_at":"2016-09-30T08:33:16Z","pushed_at":"2016-10-26T09:01:04Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":"","size":14885,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":172,"forks":47,"open_issues":172,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/3940"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3940"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3940/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3940/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/9fd32c0d7efcccf26e8c860eac0c3761b14f9d32"}}}}
{"actor":{"display_login":"oshtaier"}}