{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments/64008806","id":64008806,"diff_hunk":"@@ -365,6 +365,13 @@ public function canEdit($member = null) {\n         $parent = $this->Parent();\n \t\tif($parent && $parent->exists()) {\n \t\t\treturn $parent->canEdit($member) && !$this->isReadonly();\n+\t\t} else if ($this->ID == 0) {\n+\t\t\t// This is for GridFieldOrderableRows support as it checks edit permissions on \n+\t\t\t// singleton of the class. Fixes backwards compatibility issues where \n+\t\t\t// 'Content Authors' used to be able to re-order items on the old interface 2.x version.\n+\t\t\t$parentClass = $this->config()->has_one['Parent'];\n+\t\t\t$parent = singleton($parentClass);\n+\t\t\treturn $parent->canEdit($member);","path":"code/model/editableformfields/EditableFormField.php","position":10,"original_position":10,"commit_id":"0bc42376abd0d94fd9cd4cd8b5114f2539fdd537","original_commit_id":"0bc42376abd0d94fd9cd4cd8b5114f2539fdd537","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"body":"I'm not super familiar with the new user-defined forms so I'll defer to @tractorcow ","created_at":"2016-05-20T08:51:06Z","updated_at":"2016-05-20T08:51:06Z","html_url":"https://github.com/silverstripe/silverstripe-userforms/pull/478#discussion_r64008806","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments/64008806"},"html":{"href":"https://github.com/silverstripe/silverstripe-userforms/pull/478#discussion_r64008806"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478","id":70631924,"html_url":"https://github.com/silverstripe/silverstripe-userforms/pull/478","diff_url":"https://github.com/silverstripe/silverstripe-userforms/pull/478.diff","patch_url":"https://github.com/silverstripe/silverstripe-userforms/pull/478.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/478","number":478,"state":"open","locked":false,"title":"fix(Reorder): Fix bug where 'Content Authors' can no longer re-order form fields due to how GridFieldOrderableRows checks canEdit() permissions.","user":{"login":"SilbinaryWolf","id":3859574,"avatar_url":"https://avatars.githubusercontent.com/u/3859574?v=3","gravatar_id":"","url":"https://api.github.com/users/SilbinaryWolf","html_url":"https://github.com/SilbinaryWolf","followers_url":"https://api.github.com/users/SilbinaryWolf/followers","following_url":"https://api.github.com/users/SilbinaryWolf/following{/other_user}","gists_url":"https://api.github.com/users/SilbinaryWolf/gists{/gist_id}","starred_url":"https://api.github.com/users/SilbinaryWolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilbinaryWolf/subscriptions","organizations_url":"https://api.github.com/users/SilbinaryWolf/orgs","repos_url":"https://api.github.com/users/SilbinaryWolf/repos","events_url":"https://api.github.com/users/SilbinaryWolf/events{/privacy}","received_events_url":"https://api.github.com/users/SilbinaryWolf/received_events","type":"User","site_admin":false},"body":"fix(Reorder): Fix bug where 'Content Authors' can no longer re-order form fields due to how GridFieldOrderableRows checks canEdit() permissions.\r\n\r\nI also request that this be pulled in to 3.0.x and 3.1.x as its a bug fix, and people upgrading from 2.x are bound to get nabbed by it.","created_at":"2016-05-19T03:26:16Z","updated_at":"2016-05-20T08:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"938a876a05764ffcbad43cd382cf187778f6645e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/478/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/statuses/0bc42376abd0d94fd9cd4cd8b5114f2539fdd537","head":{"label":"SilbinaryWolf:fix-reorderissue","ref":"fix-reorderissue","sha":"0bc42376abd0d94fd9cd4cd8b5114f2539fdd537","user":{"login":"SilbinaryWolf","id":3859574,"avatar_url":"https://avatars.githubusercontent.com/u/3859574?v=3","gravatar_id":"","url":"https://api.github.com/users/SilbinaryWolf","html_url":"https://github.com/SilbinaryWolf","followers_url":"https://api.github.com/users/SilbinaryWolf/followers","following_url":"https://api.github.com/users/SilbinaryWolf/following{/other_user}","gists_url":"https://api.github.com/users/SilbinaryWolf/gists{/gist_id}","starred_url":"https://api.github.com/users/SilbinaryWolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilbinaryWolf/subscriptions","organizations_url":"https://api.github.com/users/SilbinaryWolf/orgs","repos_url":"https://api.github.com/users/SilbinaryWolf/repos","events_url":"https://api.github.com/users/SilbinaryWolf/events{/privacy}","received_events_url":"https://api.github.com/users/SilbinaryWolf/received_events","type":"User","site_admin":false},"repo":{"id":56122901,"name":"silverstripe-userforms","full_name":"SilbinaryWolf/silverstripe-userforms","owner":{"login":"SilbinaryWolf","id":3859574,"avatar_url":"https://avatars.githubusercontent.com/u/3859574?v=3","gravatar_id":"","url":"https://api.github.com/users/SilbinaryWolf","html_url":"https://github.com/SilbinaryWolf","followers_url":"https://api.github.com/users/SilbinaryWolf/followers","following_url":"https://api.github.com/users/SilbinaryWolf/following{/other_user}","gists_url":"https://api.github.com/users/SilbinaryWolf/gists{/gist_id}","starred_url":"https://api.github.com/users/SilbinaryWolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilbinaryWolf/subscriptions","organizations_url":"https://api.github.com/users/SilbinaryWolf/orgs","repos_url":"https://api.github.com/users/SilbinaryWolf/repos","events_url":"https://api.github.com/users/SilbinaryWolf/events{/privacy}","received_events_url":"https://api.github.com/users/SilbinaryWolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SilbinaryWolf/silverstripe-userforms","description":"UserForms module provides a visual form builder for the SilverStripe CMS. No coding required to build forms such as contact pages.","fork":true,"url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms","forks_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/forks","keys_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/teams","hooks_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/hooks","issue_events_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/issues/events{/number}","events_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/events","assignees_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/assignees{/user}","branches_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/branches{/branch}","tags_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/tags","blobs_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/statuses/{sha}","languages_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/languages","stargazers_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/stargazers","contributors_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/contributors","subscribers_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/subscribers","subscription_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/subscription","commits_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/contents/{+path}","compare_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/merges","archive_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/downloads","issues_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/issues{/number}","pulls_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/pulls{/number}","milestones_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/milestones{/number}","notifications_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/labels{/name}","releases_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/releases{/id}","deployments_url":"https://api.github.com/repos/SilbinaryWolf/silverstripe-userforms/deployments","created_at":"2016-04-13T05:15:24Z","updated_at":"2016-04-13T05:15:25Z","pushed_at":"2016-05-19T03:24:04Z","git_url":"git://github.com/SilbinaryWolf/silverstripe-userforms.git","ssh_url":"git@github.com:SilbinaryWolf/silverstripe-userforms.git","clone_url":"https://github.com/SilbinaryWolf/silverstripe-userforms.git","svn_url":"https://github.com/SilbinaryWolf/silverstripe-userforms","homepage":"","size":7561,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:master","ref":"master","sha":"069f29e26af4a10118fefb8267f95874fbfb5dad","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1247754,"name":"silverstripe-userforms","full_name":"silverstripe/silverstripe-userforms","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-userforms","description":"UserForms module provides a visual form builder for the SilverStripe CMS. No coding required to build forms such as contact pages.","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-userforms","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-userforms/deployments","created_at":"2011-01-12T20:46:46Z","updated_at":"2016-05-18T21:12:39Z","pushed_at":"2016-05-20T04:36:01Z","git_url":"git://github.com/silverstripe/silverstripe-userforms.git","ssh_url":"git@github.com:silverstripe/silverstripe-userforms.git","clone_url":"https://github.com/silverstripe/silverstripe-userforms.git","svn_url":"https://github.com/silverstripe/silverstripe-userforms","homepage":"","size":8555,"stargazers_count":114,"watchers_count":114,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":87,"forks":150,"open_issues":87,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478"},"html":{"href":"https://github.com/silverstripe/silverstripe-userforms/pull/478"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/478"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-userforms/statuses/0bc42376abd0d94fd9cd4cd8b5114f2539fdd537"}}}}
{"actor":{"display_login":"dhensby"}}