{"action":"created","issue":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5764","repository_url":"https://api.github.com/repos/ParadiseSS13/Paradise","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5764/labels{/name}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5764/comments","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5764/events","html_url":"https://github.com/ParadiseSS13/Paradise/pull/5764","id":182371587,"number":5764,"title":"TEG refactor [SEMI-UNTESTED]","user":{"login":"Markolie","id":3009534,"avatar_url":"https://avatars.githubusercontent.com/u/3009534?v=3","gravatar_id":"","url":"https://api.github.com/users/Markolie","html_url":"https://github.com/Markolie","followers_url":"https://api.github.com/users/Markolie/followers","following_url":"https://api.github.com/users/Markolie/following{/other_user}","gists_url":"https://api.github.com/users/Markolie/gists{/gist_id}","starred_url":"https://api.github.com/users/Markolie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Markolie/subscriptions","organizations_url":"https://api.github.com/users/Markolie/orgs","repos_url":"https://api.github.com/users/Markolie/repos","events_url":"https://api.github.com/users/Markolie/events{/privacy}","received_events_url":"https://api.github.com/users/Markolie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Fix","name":"Fix","color":"26C5E2"},{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Refactor","name":"Refactor","color":"FFB626"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-10-11T20:54:07Z","updated_at":"2016-10-13T19:04:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5764","html_url":"https://github.com/ParadiseSS13/Paradise/pull/5764","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/5764.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/5764.patch"},"body":"Refactors our TEG so it's up-to-date with /tg/'s latest version. No real functional changes, except that the TEG now actually works, and the cold/heat circulation side of the TEG can now be adjusted using a multitool. \r\n\r\nThis is largely untested, as I'm not familiar enough with the TEG to determine whether or not it's working well enough. The code works, the TEG works, I just don't know if it works well. If anyone's willing to test if for me, let me know and I can host a server for you. This shouldn't be merged before then.\r\n\r\nMaybe fixes https://github.com/ParadiseSS13/Paradise/issues/2860.\r\nMaybe fixes https://github.com/ParadiseSS13/Paradise/issues/1850.\r\n\r\n🆑\r\nbugfix: Thermo-electric generators (TEG's) are once again fully functional. \r\ntweak: The cold/heat side of a TEG can now be adjusted using a multitool.\r\n/🆑"},"comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments/253607820","html_url":"https://github.com/ParadiseSS13/Paradise/pull/5764#issuecomment-253607820","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5764","id":253607820,"user":{"login":"Markolie","id":3009534,"avatar_url":"https://avatars.githubusercontent.com/u/3009534?v=3","gravatar_id":"","url":"https://api.github.com/users/Markolie","html_url":"https://github.com/Markolie","followers_url":"https://api.github.com/users/Markolie/followers","following_url":"https://api.github.com/users/Markolie/following{/other_user}","gists_url":"https://api.github.com/users/Markolie/gists{/gist_id}","starred_url":"https://api.github.com/users/Markolie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Markolie/subscriptions","organizations_url":"https://api.github.com/users/Markolie/orgs","repos_url":"https://api.github.com/users/Markolie/repos","events_url":"https://api.github.com/users/Markolie/events{/privacy}","received_events_url":"https://api.github.com/users/Markolie/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T19:04:15Z","updated_at":"2016-10-13T19:04:15Z","body":"Thanks once more!\r\n- I'm not sure what you mean by the TEG generator spawning vertically. Do you have a screenshot of that?\r\n- There's no hard cap on the TEG, so it really depends on the mixes/temperature. It may well be the most you can get out of it though - not sure.\r\n- The SMES cells not taking the TEG power is most likely not a TEG bug (as it uses generic procs to add power to the network). Perhaps it's because the SMES is on Z2?\r\n\r\nEither way, I think this is ready for merging. If the vertical TEG generator issue does turn out to be a bug I'll make sure to fix that."}}
{"actor":{"display_login":"Markolie"}}