{"action":"created","issue":{"url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/299","repository_url":"https://api.github.com/repos/ckeditor/ckeditor5","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/299/labels{/name}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/299/comments","events_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/299/events","html_url":"https://github.com/ckeditor/ckeditor5/pull/299","id":171433689,"number":299,"title":"Introduced tasks and configuration for testing releases.","user":{"login":"pomek","id":2270764,"avatar_url":"https://avatars.githubusercontent.com/u/2270764?v=3","gravatar_id":"","url":"https://api.github.com/users/pomek","html_url":"https://github.com/pomek","followers_url":"https://api.github.com/users/pomek/followers","following_url":"https://api.github.com/users/pomek/following{/other_user}","gists_url":"https://api.github.com/users/pomek/gists{/gist_id}","starred_url":"https://api.github.com/users/pomek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomek/subscriptions","organizations_url":"https://api.github.com/users/pomek/orgs","repos_url":"https://api.github.com/users/pomek/repos","events_url":"https://api.github.com/users/pomek/events{/privacy}","received_events_url":"https://api.github.com/users/pomek/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-16T14:47:29Z","updated_at":"2016-08-24T15:17:28Z","closed_at":"2016-08-24T15:17:28Z","pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5/pulls/299","html_url":"https://github.com/ckeditor/ckeditor5/pull/299","diff_url":"https://github.com/ckeditor/ckeditor5/pull/299.diff","patch_url":"https://github.com/ckeditor/ckeditor5/pull/299.patch"},"body":"Fixes: #260 \r\n\r\n**Requires:** https://github.com/ckeditor/ckeditor5-dev-compiler/pull/23\r\n\r\nThis PR will introduce new tasks:\r\n\r\n* `test:samples:local` - building tests with local modules,\r\n* `test:samples:bundled` - building tests with bundled editor,\r\n* `test:samples` - an alias for above tasks,\r\n* `compile:samples` - building editors (needed for `test:samples:bundled`),\r\n* `compile:samples:clean` - removes built editors. \r\n\r\nFor testing it, you need to create some sample files:\r\n\r\n**`ckeditor5-typing/docs/samples/typing.js`**\r\n```js\r\n/**\r\n * @license Copyright (c) 2003-2016, CKSource - Frederico Knabben. All rights reserved.\r\n * For licensing, see LICENSE.md.\r\n */\r\n\r\n/* global console:false, bender: false */\r\n\r\nimport ClassicEditor from '/ckeditor5/editor-classic/classic.js'; // editor:module\r\n\r\nconst done = bender.defer();\r\n\r\n// sample:start\r\nClassicEditor.create( document.querySelector( '#editor' ), { // editor:name\r\n\tfeatures: [ 'enter', 'typing', 'paragraph', 'undo', 'basic-styles/bold', 'basic-styles/italic' ], // sample:remove|editor:features\r\n\ttoolbar: [ 'bold', 'italic', 'undo', 'redo' ]\r\n} )\r\n.then( editor => {\r\n\twindow.editor = editor;\r\n\tdone(); // sample:remove\r\n}, err => {\r\n\tconsole.error( err.stack );\r\n} );\r\n// sample:end\r\n\r\ndescribe( 'Typing sample', () => {\r\n\tit( 'contains default value', () => {\r\n\t\tconst output = '<p><em>This</em> is an <strong>editor</strong> instance...</p>';\r\n\r\n\t\texpect( editor.getData() ).to.equal( output );\r\n\t} );\r\n} );\r\n```\r\n\r\n**`ckeditor5-typing/docs/samples/typing.html`**\r\n```html\r\n<div id=\"editor\">\r\n\t<p><em>This</em> is an <strong>editor</strong> instance...</p>\r\n</div>\r\n```\r\n\r\n**`ckeditor5-basic-samples/docs/samples/basic-styles.js`**\r\n```js\r\n/**\r\n * @license Copyright (c) 2003-2016, CKSource - Frederico Knabben. All rights reserved.\r\n * For licensing, see LICENSE.md.\r\n */\r\n\r\n/* global console:false, bender: false */\r\n\r\nimport ClassicEditor from '/ckeditor5/editor-classic/classic.js'; // editor:module\r\n\r\nconst done = bender.defer();\r\n\r\n// sample:start\r\nClassicEditor.create( document.querySelector( '#editor' ), { // editor:name\r\n\tfeatures: [ 'enter', 'typing', 'paragraph', 'undo', 'basic-styles/bold', 'basic-styles/italic' ], // sample:remove|editor:features\r\n\ttoolbar: [ 'bold', 'italic', 'undo', 'redo' ]\r\n} )\r\n.then( editor => {\r\n\twindow.editor = editor;\r\n\tdone(); // sample:remove\r\n}, err => {\r\n\tconsole.error( err.stack );\r\n} );\r\n// sample:end\r\n\r\ndescribe( 'Basic Styles sample', () => {\r\n\tit( 'contains default value', () => {\r\n\t\tconst output = '<p><em>This</em> is an <strong>editor</strong> instance...</p>';\r\n\r\n\t\texpect( editor.getData() ).to.equal( output );\r\n\t} );\r\n} );\r\n```\r\n\r\n**`ckeditor5-basic-samples/docs/samples/basic-styles.html`**\r\n```html\r\n<div id=\"editor\">\r\n\t<p><em>This</em> is an <strong>editor</strong> instance...</p>\r\n</div>\r\n```"},"comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/comments/242101714","html_url":"https://github.com/ckeditor/ckeditor5/pull/299#issuecomment-242101714","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5/issues/299","id":242101714,"user":{"login":"Reinmar","id":156149,"avatar_url":"https://avatars.githubusercontent.com/u/156149?v=3","gravatar_id":"","url":"https://api.github.com/users/Reinmar","html_url":"https://github.com/Reinmar","followers_url":"https://api.github.com/users/Reinmar/followers","following_url":"https://api.github.com/users/Reinmar/following{/other_user}","gists_url":"https://api.github.com/users/Reinmar/gists{/gist_id}","starred_url":"https://api.github.com/users/Reinmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reinmar/subscriptions","organizations_url":"https://api.github.com/users/Reinmar/orgs","repos_url":"https://api.github.com/users/Reinmar/repos","events_url":"https://api.github.com/users/Reinmar/events{/privacy}","received_events_url":"https://api.github.com/users/Reinmar/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T15:17:28Z","updated_at":"2016-08-24T15:17:28Z","body":"OK, I've done some refactoring here and there, moved some code from dependent PRs to this one (temporarily) and merged this code to branch `docs`. I changed deps to use GH links so running `npm i` after cleaning up `node_modules/@ckeditor` should switch all deps correctly.\r\n\r\nLet's keep this code out of master until we have the documentation ready."}}
{"actor":{"display_login":"Reinmar"}}