{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments/65306022","id":65306022,"diff_hunk":"@@ -64,9 +66,34 @@ and run this command before committing your modifications:\n php-cs-fixer fix --verbose\n ```\n \n+#### The documentation\n+\n+The documentation is mostly written with the `rst` format. You can test the doc rendering with the `make docs` command.\n+\n+If your PR contains a new feature, you must add documentation for it.\n+\n+#### The tests\n+\n+If your PR contains a fix, tests should be added to prove the bug.\n+\n+If your PR contains an addition, a new feature, this one has to be fully covered by tests.\n+\n+Some rules have to be respected about the test:\n+\n+* Annotations about coverage are prohibited. This concerns:\n+  * `@covers`\n+  * `@coversDefaultClass`\n+  * `@coversNothing`\n+  * `@codeCoverageIgnore`\n+  * `@codeCoverageIgnoreStart`\n+  * `codeCoverageIgnoreEnd`","path":"project/CONTRIBUTING.md","position":35,"original_position":35,"commit_id":"b7f54ad7e4372f9b1bc6c8e5f83e186f7b9ae5d9","original_commit_id":"b7f54ad7e4372f9b1bc6c8e5f83e186f7b9ae5d9","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"Erf, too bad. Will fix it, thanks!","created_at":"2016-06-01T05:59:25Z","updated_at":"2016-06-01T05:59:25Z","html_url":"https://github.com/sonata-project/dev-kit/pull/123#discussion_r65306022","pull_request_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments/65306022"},"html":{"href":"https://github.com/sonata-project/dev-kit/pull/123#discussion_r65306022"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123","id":72071706,"html_url":"https://github.com/sonata-project/dev-kit/pull/123","diff_url":"https://github.com/sonata-project/dev-kit/pull/123.diff","patch_url":"https://github.com/sonata-project/dev-kit/pull/123.patch","issue_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/123","number":123,"state":"closed","locked":false,"title":"Add some notes about tests and documentation","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"About `@cover` usage, this was discussed on another PR, we are following the Symfony way.\r\n\r\nIf someone can retrieve the link... @greg0ire maybe?","created_at":"2016-05-31T19:26:49Z","updated_at":"2016-06-01T05:59:25Z","closed_at":"2016-05-31T22:04:32Z","merged_at":"2016-05-31T22:04:32Z","merge_commit_sha":"a54eb7ca36f889cb876ade9b105947e173f146bc","assignee":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123/commits","review_comments_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123/comments","review_comment_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/123/comments","statuses_url":"https://api.github.com/repos/sonata-project/dev-kit/statuses/b7f54ad7e4372f9b1bc6c8e5f83e186f7b9ae5d9","head":{"label":"Soullivaneuh:contributing-tests-docs","ref":"contributing-tests-docs","sha":"b7f54ad7e4372f9b1bc6c8e5f83e186f7b9ae5d9","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"repo":{"id":55150683,"name":"sonata-dev-kit","full_name":"Soullivaneuh/sonata-dev-kit","owner":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Soullivaneuh/sonata-dev-kit","description":"","fork":true,"url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit","forks_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/forks","keys_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/teams","hooks_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/hooks","issue_events_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/issues/events{/number}","events_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/events","assignees_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/assignees{/user}","branches_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/branches{/branch}","tags_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/tags","blobs_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/languages","stargazers_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/stargazers","contributors_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/contributors","subscribers_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/subscribers","subscription_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/subscription","commits_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/contents/{+path}","compare_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/merges","archive_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/downloads","issues_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/issues{/number}","pulls_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/labels{/name}","releases_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/releases{/id}","deployments_url":"https://api.github.com/repos/Soullivaneuh/sonata-dev-kit/deployments","created_at":"2016-03-31T12:58:08Z","updated_at":"2016-05-01T16:03:16Z","pushed_at":"2016-05-31T22:08:26Z","git_url":"git://github.com/Soullivaneuh/sonata-dev-kit.git","ssh_url":"git@github.com:Soullivaneuh/sonata-dev-kit.git","clone_url":"https://github.com/Soullivaneuh/sonata-dev-kit.git","svn_url":"https://github.com/Soullivaneuh/sonata-dev-kit","homepage":null,"size":134,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"cb3fceaa46c79f056e18cf6c76468dc18bc01d8d","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":55150410,"name":"dev-kit","full_name":"sonata-project/dev-kit","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/dev-kit","description":"","fork":false,"url":"https://api.github.com/repos/sonata-project/dev-kit","forks_url":"https://api.github.com/repos/sonata-project/dev-kit/forks","keys_url":"https://api.github.com/repos/sonata-project/dev-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/dev-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/dev-kit/teams","hooks_url":"https://api.github.com/repos/sonata-project/dev-kit/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/dev-kit/events","assignees_url":"https://api.github.com/repos/sonata-project/dev-kit/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/dev-kit/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/dev-kit/tags","blobs_url":"https://api.github.com/repos/sonata-project/dev-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/dev-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/dev-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/dev-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/dev-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/dev-kit/languages","stargazers_url":"https://api.github.com/repos/sonata-project/dev-kit/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/dev-kit/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/dev-kit/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/dev-kit/subscription","commits_url":"https://api.github.com/repos/sonata-project/dev-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/dev-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/dev-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/dev-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/dev-kit/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/dev-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/dev-kit/merges","archive_url":"https://api.github.com/repos/sonata-project/dev-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/dev-kit/downloads","issues_url":"https://api.github.com/repos/sonata-project/dev-kit/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/dev-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/dev-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/dev-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/dev-kit/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/dev-kit/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/dev-kit/deployments","created_at":"2016-03-31T12:54:15Z","updated_at":"2016-05-22T17:50:55Z","pushed_at":"2016-05-31T22:12:20Z","git_url":"git://github.com/sonata-project/dev-kit.git","ssh_url":"git@github.com:sonata-project/dev-kit.git","clone_url":"https://github.com/sonata-project/dev-kit.git","svn_url":"https://github.com/sonata-project/dev-kit","homepage":null,"size":229,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":28,"forks":8,"open_issues":28,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123"},"html":{"href":"https://github.com/sonata-project/dev-kit/pull/123"},"issue":{"href":"https://api.github.com/repos/sonata-project/dev-kit/issues/123"},"comments":{"href":"https://api.github.com/repos/sonata-project/dev-kit/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/dev-kit/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/dev-kit/statuses/b7f54ad7e4372f9b1bc6c8e5f83e186f7b9ae5d9"}}}}
{"actor":{"display_login":"Soullivaneuh"}}