{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/83370476","pull_request_review_id":4219183,"id":83370476,"diff_hunk":"@@ -661,10 +661,10 @@ protected function _decode($source)\n \t\t$source = strtr($source, $ttr);\n \n \t\t// Convert decimal\n-\t\t$source = preg_replace('/&#(\\d+);/me', \"utf8_encode(chr(\\\\1))\", $source); // decimal notation\n+\t\t$source = preg_replace_callback('/&#(\\d+);/m', function($m){return utf8_encode(chr($m[1]));}, $source); // decimal notation\n \n \t\t// Convert hex\n-\t\t$source = preg_replace('/&#x([a-f0-9]+);/mei', \"utf8_encode(chr(0x\\\\1))\", $source); // hex notation\n+\t\t$source = preg_replace_callback('/&#x([a-f0-9]+);/mi', function($m){return utf8_encode(chr('0x'.$m[1]));}, $source); // hex notation","path":"libraries/joomla/filter/input.php","position":9,"original_position":9,"commit_id":"a7bb98d46be1cfb6a4eac13a83739b6983849bf8","original_commit_id":"a7bb98d46be1cfb6a4eac13a83739b6983849bf8","user":{"login":"mfarooqi","id":6302459,"avatar_url":"https://avatars.githubusercontent.com/u/6302459?v=3","gravatar_id":"","url":"https://api.github.com/users/mfarooqi","html_url":"https://github.com/mfarooqi","followers_url":"https://api.github.com/users/mfarooqi/followers","following_url":"https://api.github.com/users/mfarooqi/following{/other_user}","gists_url":"https://api.github.com/users/mfarooqi/gists{/gist_id}","starred_url":"https://api.github.com/users/mfarooqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfarooqi/subscriptions","organizations_url":"https://api.github.com/users/mfarooqi/orgs","repos_url":"https://api.github.com/users/mfarooqi/repos","events_url":"https://api.github.com/users/mfarooqi/events{/privacy}","received_events_url":"https://api.github.com/users/mfarooqi/received_events","type":"User","site_admin":false},"body":"Thanks.. reaching up to this solution took... more than 1.5 week(s) :) ","created_at":"2016-10-14T07:32:20Z","updated_at":"2016-10-14T07:32:20Z","html_url":"https://github.com/joomla/joomla-cms/pull/1309#discussion_r83370476","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/83370476"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/1309#discussion_r83370476"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309","id":6440159,"html_url":"https://github.com/joomla/joomla-cms/pull/1309","diff_url":"https://github.com/joomla/joomla-cms/pull/1309.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/1309.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/1309","number":1309,"state":"closed","locked":false,"title":"replaced deprecated option /e with callable function","user":{"login":"yurii-github","id":1162656,"avatar_url":"https://avatars.githubusercontent.com/u/1162656?v=3","gravatar_id":"","url":"https://api.github.com/users/yurii-github","html_url":"https://github.com/yurii-github","followers_url":"https://api.github.com/users/yurii-github/followers","following_url":"https://api.github.com/users/yurii-github/following{/other_user}","gists_url":"https://api.github.com/users/yurii-github/gists{/gist_id}","starred_url":"https://api.github.com/users/yurii-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurii-github/subscriptions","organizations_url":"https://api.github.com/users/yurii-github/orgs","repos_url":"https://api.github.com/users/yurii-github/repos","events_url":"https://api.github.com/users/yurii-github/events{/privacy}","received_events_url":"https://api.github.com/users/yurii-github/received_events","type":"User","site_admin":false},"body":"http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31197\r\n\r\n\r\noption /e was marked as deprecated since PHP 5.5.0\r\n\r\n\r\n> ( ! ) Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in  ~\\libraries\\joomla\\filter\\input.php on line 664\r\n\r\nregards,\r\nYurii","created_at":"2013-06-20T10:24:03Z","updated_at":"2016-10-14T07:32:20Z","closed_at":"2013-08-07T10:56:44Z","merged_at":null,"merge_commit_sha":"caa610de089a23fd57216e1b1a2f4c996e8c8b6a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/1309/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/a7bb98d46be1cfb6a4eac13a83739b6983849bf8","head":{"label":"yurii-github:preg_replace","ref":"preg_replace","sha":"a7bb98d46be1cfb6a4eac13a83739b6983849bf8","user":{"login":"yurii-github","id":1162656,"avatar_url":"https://avatars.githubusercontent.com/u/1162656?v=3","gravatar_id":"","url":"https://api.github.com/users/yurii-github","html_url":"https://github.com/yurii-github","followers_url":"https://api.github.com/users/yurii-github/followers","following_url":"https://api.github.com/users/yurii-github/following{/other_user}","gists_url":"https://api.github.com/users/yurii-github/gists{/gist_id}","starred_url":"https://api.github.com/users/yurii-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurii-github/subscriptions","organizations_url":"https://api.github.com/users/yurii-github/orgs","repos_url":"https://api.github.com/users/yurii-github/repos","events_url":"https://api.github.com/users/yurii-github/events{/privacy}","received_events_url":"https://api.github.com/users/yurii-github/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"joomla:master","ref":"master","sha":"9680049115cb15713fb45af017a173683ec1a3f2","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-10-13T03:03:34Z","pushed_at":"2016-10-14T05:12:07Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":304081,"stargazers_count":2155,"watchers_count":2155,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2312,"mirror_url":null,"open_issues_count":508,"forks":2312,"open_issues":508,"watchers":2155,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/1309"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/1309"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/1309/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/1309/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/a7bb98d46be1cfb6a4eac13a83739b6983849bf8"}}}}
{"actor":{"display_login":"mfarooqi"}}