{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34548","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34548/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34548/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34548/events","html_url":"https://github.com/kubernetes/kubernetes/pull/34548","id":182298683,"number":34548,"title":"[WIP] controller: set minReadySeconds in deployment's replica sets","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-10-11T15:37:31Z","updated_at":"2016-10-11T15:46:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34548","html_url":"https://github.com/kubernetes/kubernetes/pull/34548","diff_url":"https://github.com/kubernetes/kubernetes/pull/34548.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/34548.patch"},"body":"* Estimate available pods for a deployment by using minReadySeconds on\r\nthe replica set.\r\n* Stop requeueing deployments on pod events, superseded by following the\r\nreplica set status.\r\n* Cleanup redundant deployment utilities\r\n\r\nOne more thing I need to do before bringing this out of WIP is to make the controller sync active replica sets with MinReadySeconds different from the one specified in the deployment spec.\r\n\r\nFixes https://github.com/kubernetes/kubernetes/issues/26079\r\n\r\n@kubernetes/deployment ptal\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/34548)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/252957346","html_url":"https://github.com/kubernetes/kubernetes/pull/34548#issuecomment-252957346","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34548","id":252957346,"user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T15:46:12Z","updated_at":"2016-10-11T15:46:12Z","body":"@bgrant0607 @smarterclayton question:\r\n* I have a D with minReadySeconds=20s and a RS1 with minReadySeconds=20s.\r\n* I switch D.spec.minReadySeconds to 40s and trigger a new rollout\r\n* Now, D.spec.minReadySeconds=40, RS1.spec.minReadySeconds=20, RS2.spec.minReadySeconds=40\r\nRS1 should switch to 40s, right? \r\n\r\nMostly I want to touch base on this. Currently that's the way we estimate available pods, we just don't use the new availableReplicas fiels on replica sets. I want to use the new field which will help in stop requeueing deployments on pod events (what this PR is doing). Does it make sense to have the active replica sets always be synced to deployment's mnReadySeconds?"}}
{"actor":{"display_login":"kargakis"}}