{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip-android/issues/52","repository_url":"https://api.github.com/repos/zulip/zulip-android","labels_url":"https://api.github.com/repos/zulip/zulip-android/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip-android/issues/52/comments","events_url":"https://api.github.com/repos/zulip/zulip-android/issues/52/events","html_url":"https://github.com/zulip/zulip-android/pull/52","id":150194769,"number":52,"title":"Add Server Option (armooo)","user":{"login":"niftynei","id":1097769,"avatar_url":"https://avatars.githubusercontent.com/u/1097769?v=3","gravatar_id":"","url":"https://api.github.com/users/niftynei","html_url":"https://github.com/niftynei","followers_url":"https://api.github.com/users/niftynei/followers","following_url":"https://api.github.com/users/niftynei/following{/other_user}","gists_url":"https://api.github.com/users/niftynei/gists{/gist_id}","starred_url":"https://api.github.com/users/niftynei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niftynei/subscriptions","organizations_url":"https://api.github.com/users/niftynei/orgs","repos_url":"https://api.github.com/users/niftynei/repos","events_url":"https://api.github.com/users/niftynei/events{/privacy}","received_events_url":"https://api.github.com/users/niftynei/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-21T21:23:57Z","updated_at":"2016-05-03T22:37:23Z","closed_at":"2016-05-03T22:36:22Z","pull_request":{"url":"https://api.github.com/repos/zulip/zulip-android/pulls/52","html_url":"https://github.com/zulip/zulip-android/pull/52","diff_url":"https://github.com/zulip/zulip-android/pull/52.diff","patch_url":"https://github.com/zulip/zulip-android/pull/52.patch"},"body":"This builds off of PR #20, fixing up the validation for login, and updating the Google Login code to use the newest APIs. \r\n\r\n- Fixed server name validation\r\n- Adds very basic validation for username/password fields\r\n- Updated Google Login to latest API\r\n- Added a debug signing certificate and registered for a debug `google-services.json`; testing Google Login on a dev server should be a *lot* simpler now. Needs documentation tho.\r\n- Re-orged code into appropriately named packages\r\n- Hide Google Login button when using a server other than `zulip.com`\r\n- Added a checkbox to make logging in screen a bit nicer.\r\n\r\nThere's some work that will need to be done to set up Google Login for production builds, @timabbott we should talk about this when you're pushing a production build.  I've tested it with a local install of Zulip and it works great, but I'd like to test it with the prod keys as well before we push it out to the store. \r\n\r\nScreenshots of Login Screen:\r\n\r\n![screenshot_20160421-122749](https://cloud.githubusercontent.com/assets/1097769/14724777/324e91ea-07e6-11e6-9a43-5ef50c1addda.png)\r\n![screenshot_20160421-122752](https://cloud.githubusercontent.com/assets/1097769/14724776/324d8020-07e6-11e6-95a6-1085caeb7e21.png)\r\n"},"comment":{"url":"https://api.github.com/repos/zulip/zulip-android/issues/comments/216685452","html_url":"https://github.com/zulip/zulip-android/pull/52#issuecomment-216685452","issue_url":"https://api.github.com/repos/zulip/zulip-android/issues/52","id":216685452,"user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T22:37:22Z","updated_at":"2016-05-03T22:37:22Z","body":"Yay!\n\n-Tim Abbott (mobile)\nOn May 3, 2016 3:34 PM, \"neil saitug\" <notifications@github.com> wrote:\n\n> summarily reviewed by @kunall17 <https://github.com/kunall17>. Going to\n> go ahead and merge this. :)\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/zulip/zulip-android/pull/52#issuecomment-216684875>\n>\n"}}