{"action":"created","comment":{"url":"https://api.github.com/repos/zeit/hyperterm/pulls/comments/72365436","id":72365436,"diff_hunk":"@@ -50,7 +50,10 @@ module.exports = {\n \n     // the shell to run when spawning a new session (i.e. /usr/local/bin/fish)\n     // if left empty, your system's login shell will be used by default\n-    shell: ''\n+    shell: '',\n+\n+    // enable audible bell\n+    audibleBell: true","path":"config-default.js","position":8,"original_position":8,"commit_id":"66c283493829a06a8bd2cd4db57af11df576d9d3","original_commit_id":"66c283493829a06a8bd2cd4db57af11df576d9d3","user":{"login":"rauchg","id":13041,"avatar_url":"https://avatars.githubusercontent.com/u/13041?v=3","gravatar_id":"","url":"https://api.github.com/users/rauchg","html_url":"https://github.com/rauchg","followers_url":"https://api.github.com/users/rauchg/followers","following_url":"https://api.github.com/users/rauchg/following{/other_user}","gists_url":"https://api.github.com/users/rauchg/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchg/subscriptions","organizations_url":"https://api.github.com/users/rauchg/orgs","repos_url":"https://api.github.com/users/rauchg/repos","events_url":"https://api.github.com/users/rauchg/events{/privacy}","received_events_url":"https://api.github.com/users/rauchg/received_events","type":"User","site_admin":false},"body":"I think string / true / falsy is fine honestly.","created_at":"2016-07-27T01:02:06Z","updated_at":"2016-07-27T01:02:06Z","html_url":"https://github.com/zeit/hyperterm/pull/204#discussion_r72365436","pull_request_url":"https://api.github.com/repos/zeit/hyperterm/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/zeit/hyperterm/pulls/comments/72365436"},"html":{"href":"https://github.com/zeit/hyperterm/pull/204#discussion_r72365436"},"pull_request":{"href":"https://api.github.com/repos/zeit/hyperterm/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/zeit/hyperterm/pulls/204","id":77739352,"html_url":"https://github.com/zeit/hyperterm/pull/204","diff_url":"https://github.com/zeit/hyperterm/pull/204.diff","patch_url":"https://github.com/zeit/hyperterm/pull/204.patch","issue_url":"https://api.github.com/repos/zeit/hyperterm/issues/204","number":204,"state":"open","locked":false,"title":"Config option to silence bell","user":{"login":"bekher","id":9370623,"avatar_url":"https://avatars.githubusercontent.com/u/9370623?v=3","gravatar_id":"","url":"https://api.github.com/users/bekher","html_url":"https://github.com/bekher","followers_url":"https://api.github.com/users/bekher/followers","following_url":"https://api.github.com/users/bekher/following{/other_user}","gists_url":"https://api.github.com/users/bekher/gists{/gist_id}","starred_url":"https://api.github.com/users/bekher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekher/subscriptions","organizations_url":"https://api.github.com/users/bekher/orgs","repos_url":"https://api.github.com/users/bekher/repos","events_url":"https://api.github.com/users/bekher/events{/privacy}","received_events_url":"https://api.github.com/users/bekher/received_events","type":"User","site_admin":false},"body":"Add a config option `audibleBell` and handlers to silence the bell by muting hterm's bell audio. This is achieved by toggling `this.term.bellAudio_.muted` in app/lib/components/term.js. \r\n\r\nWe leave the bell on by default so users with out of date config files will not wonder where their bell audio went. \r\n\r\nCloses issue #125 ","created_at":"2016-07-17T16:22:18Z","updated_at":"2016-07-27T01:02:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff914c5c9962042407c1a843dfa04244e3598001","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/hyperterm/pulls/204/commits","review_comments_url":"https://api.github.com/repos/zeit/hyperterm/pulls/204/comments","review_comment_url":"https://api.github.com/repos/zeit/hyperterm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/hyperterm/issues/204/comments","statuses_url":"https://api.github.com/repos/zeit/hyperterm/statuses/66c283493829a06a8bd2cd4db57af11df576d9d3","head":{"label":"bekher:silence-bell","ref":"silence-bell","sha":"66c283493829a06a8bd2cd4db57af11df576d9d3","user":{"login":"bekher","id":9370623,"avatar_url":"https://avatars.githubusercontent.com/u/9370623?v=3","gravatar_id":"","url":"https://api.github.com/users/bekher","html_url":"https://github.com/bekher","followers_url":"https://api.github.com/users/bekher/followers","following_url":"https://api.github.com/users/bekher/following{/other_user}","gists_url":"https://api.github.com/users/bekher/gists{/gist_id}","starred_url":"https://api.github.com/users/bekher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekher/subscriptions","organizations_url":"https://api.github.com/users/bekher/orgs","repos_url":"https://api.github.com/users/bekher/repos","events_url":"https://api.github.com/users/bekher/events{/privacy}","received_events_url":"https://api.github.com/users/bekher/received_events","type":"User","site_admin":false},"repo":{"id":63487296,"name":"hyperterm","full_name":"bekher/hyperterm","owner":{"login":"bekher","id":9370623,"avatar_url":"https://avatars.githubusercontent.com/u/9370623?v=3","gravatar_id":"","url":"https://api.github.com/users/bekher","html_url":"https://github.com/bekher","followers_url":"https://api.github.com/users/bekher/followers","following_url":"https://api.github.com/users/bekher/following{/other_user}","gists_url":"https://api.github.com/users/bekher/gists{/gist_id}","starred_url":"https://api.github.com/users/bekher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekher/subscriptions","organizations_url":"https://api.github.com/users/bekher/orgs","repos_url":"https://api.github.com/users/bekher/repos","events_url":"https://api.github.com/users/bekher/events{/privacy}","received_events_url":"https://api.github.com/users/bekher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bekher/hyperterm","description":null,"fork":true,"url":"https://api.github.com/repos/bekher/hyperterm","forks_url":"https://api.github.com/repos/bekher/hyperterm/forks","keys_url":"https://api.github.com/repos/bekher/hyperterm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bekher/hyperterm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bekher/hyperterm/teams","hooks_url":"https://api.github.com/repos/bekher/hyperterm/hooks","issue_events_url":"https://api.github.com/repos/bekher/hyperterm/issues/events{/number}","events_url":"https://api.github.com/repos/bekher/hyperterm/events","assignees_url":"https://api.github.com/repos/bekher/hyperterm/assignees{/user}","branches_url":"https://api.github.com/repos/bekher/hyperterm/branches{/branch}","tags_url":"https://api.github.com/repos/bekher/hyperterm/tags","blobs_url":"https://api.github.com/repos/bekher/hyperterm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bekher/hyperterm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bekher/hyperterm/git/refs{/sha}","trees_url":"https://api.github.com/repos/bekher/hyperterm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bekher/hyperterm/statuses/{sha}","languages_url":"https://api.github.com/repos/bekher/hyperterm/languages","stargazers_url":"https://api.github.com/repos/bekher/hyperterm/stargazers","contributors_url":"https://api.github.com/repos/bekher/hyperterm/contributors","subscribers_url":"https://api.github.com/repos/bekher/hyperterm/subscribers","subscription_url":"https://api.github.com/repos/bekher/hyperterm/subscription","commits_url":"https://api.github.com/repos/bekher/hyperterm/commits{/sha}","git_commits_url":"https://api.github.com/repos/bekher/hyperterm/git/commits{/sha}","comments_url":"https://api.github.com/repos/bekher/hyperterm/comments{/number}","issue_comment_url":"https://api.github.com/repos/bekher/hyperterm/issues/comments{/number}","contents_url":"https://api.github.com/repos/bekher/hyperterm/contents/{+path}","compare_url":"https://api.github.com/repos/bekher/hyperterm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bekher/hyperterm/merges","archive_url":"https://api.github.com/repos/bekher/hyperterm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bekher/hyperterm/downloads","issues_url":"https://api.github.com/repos/bekher/hyperterm/issues{/number}","pulls_url":"https://api.github.com/repos/bekher/hyperterm/pulls{/number}","milestones_url":"https://api.github.com/repos/bekher/hyperterm/milestones{/number}","notifications_url":"https://api.github.com/repos/bekher/hyperterm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bekher/hyperterm/labels{/name}","releases_url":"https://api.github.com/repos/bekher/hyperterm/releases{/id}","deployments_url":"https://api.github.com/repos/bekher/hyperterm/deployments","created_at":"2016-07-16T14:45:15Z","updated_at":"2016-07-16T14:45:16Z","pushed_at":"2016-07-20T03:03:20Z","git_url":"git://github.com/bekher/hyperterm.git","ssh_url":"git@github.com:bekher/hyperterm.git","clone_url":"https://github.com/bekher/hyperterm.git","svn_url":"https://github.com/bekher/hyperterm","homepage":null,"size":1053,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeit:master","ref":"master","sha":"b938ad4c58ecaa26aae3a6a32b9a5923fa711836","user":{"login":"zeit","id":14985020,"avatar_url":"https://avatars.githubusercontent.com/u/14985020?v=3","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":62367558,"name":"hyperterm","full_name":"zeit/hyperterm","owner":{"login":"zeit","id":14985020,"avatar_url":"https://avatars.githubusercontent.com/u/14985020?v=3","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeit/hyperterm","description":"HTML/JS/CSS Terminal","fork":false,"url":"https://api.github.com/repos/zeit/hyperterm","forks_url":"https://api.github.com/repos/zeit/hyperterm/forks","keys_url":"https://api.github.com/repos/zeit/hyperterm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/hyperterm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/hyperterm/teams","hooks_url":"https://api.github.com/repos/zeit/hyperterm/hooks","issue_events_url":"https://api.github.com/repos/zeit/hyperterm/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/hyperterm/events","assignees_url":"https://api.github.com/repos/zeit/hyperterm/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/hyperterm/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/hyperterm/tags","blobs_url":"https://api.github.com/repos/zeit/hyperterm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/hyperterm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/hyperterm/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/hyperterm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/hyperterm/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/hyperterm/languages","stargazers_url":"https://api.github.com/repos/zeit/hyperterm/stargazers","contributors_url":"https://api.github.com/repos/zeit/hyperterm/contributors","subscribers_url":"https://api.github.com/repos/zeit/hyperterm/subscribers","subscription_url":"https://api.github.com/repos/zeit/hyperterm/subscription","commits_url":"https://api.github.com/repos/zeit/hyperterm/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/hyperterm/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/hyperterm/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/hyperterm/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/hyperterm/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/hyperterm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/hyperterm/merges","archive_url":"https://api.github.com/repos/zeit/hyperterm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/hyperterm/downloads","issues_url":"https://api.github.com/repos/zeit/hyperterm/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/hyperterm/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/hyperterm/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/hyperterm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/hyperterm/labels{/name}","releases_url":"https://api.github.com/repos/zeit/hyperterm/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/hyperterm/deployments","created_at":"2016-07-01T06:01:21Z","updated_at":"2016-07-27T00:39:01Z","pushed_at":"2016-07-27T00:20:19Z","git_url":"git://github.com/zeit/hyperterm.git","ssh_url":"git@github.com:zeit/hyperterm.git","clone_url":"https://github.com/zeit/hyperterm.git","svn_url":"https://github.com/zeit/hyperterm","homepage":"https://hyperterm.org","size":1429,"stargazers_count":6453,"watchers_count":6453,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":204,"forks":282,"open_issues":204,"watchers":6453,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/hyperterm/pulls/204"},"html":{"href":"https://github.com/zeit/hyperterm/pull/204"},"issue":{"href":"https://api.github.com/repos/zeit/hyperterm/issues/204"},"comments":{"href":"https://api.github.com/repos/zeit/hyperterm/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/hyperterm/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/hyperterm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/hyperterm/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/hyperterm/statuses/66c283493829a06a8bd2cd4db57af11df576d9d3"}}}}
{"actor":{"display_login":"rauchg"}}