{"action":"created","comment":{"url":"https://api.github.com/repos/monetate/ectou-export/pulls/comments/86364536","pull_request_review_id":7026712,"id":86364536,"diff_hunk":"@@ -82,11 +85,6 @@ EOF\n # Disable sudo tty requirement\n sed -i.bak -e 's/^Defaults    requiretty/#Defaults    requiretty/g' $MNT/etc/sudoers\n \n-# Ensure vagrant is able to detect guest as redhat\n-# https://github.com/mitchellh/vagrant/blob/7caaffbf389fb298840eafb1edcdf554b977182e/plugins/guests/redhat/guest.rb#L7\n-touch $MNT/etc/redhat-release","path":"scripts/export-vmdk.sh","position":16,"original_position":16,"commit_id":"6d1bf4158471519a8dd8d3f805fd9837d666d608","original_commit_id":"6d1bf4158471519a8dd8d3f805fd9837d666d608","user":{"login":"jjpersch","id":1018467,"avatar_url":"https://avatars.githubusercontent.com/u/1018467?v=3","gravatar_id":"","url":"https://api.github.com/users/jjpersch","html_url":"https://github.com/jjpersch","followers_url":"https://api.github.com/users/jjpersch/followers","following_url":"https://api.github.com/users/jjpersch/following{/other_user}","gists_url":"https://api.github.com/users/jjpersch/gists{/gist_id}","starred_url":"https://api.github.com/users/jjpersch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjpersch/subscriptions","organizations_url":"https://api.github.com/users/jjpersch/orgs","repos_url":"https://api.github.com/users/jjpersch/repos","events_url":"https://api.github.com/users/jjpersch/events{/privacy}","received_events_url":"https://api.github.com/users/jjpersch/received_events","type":"User","site_admin":false},"body":"This was added for Vagrantfiles that attempted to configure private networking.\r\nWill need to verify if still required.\r\n\r\nExample:\r\n```\r\nn.vm.guest = :redhat\r\nn.vm.network \"private_network\", ip: 172.30.0.10\r\n```\r\n","created_at":"2016-11-03T15:05:59Z","updated_at":"2016-11-03T15:06:00Z","html_url":"https://github.com/monetate/ectou-export/pull/6#discussion_r86364536","pull_request_url":"https://api.github.com/repos/monetate/ectou-export/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/monetate/ectou-export/pulls/comments/86364536"},"html":{"href":"https://github.com/monetate/ectou-export/pull/6#discussion_r86364536"},"pull_request":{"href":"https://api.github.com/repos/monetate/ectou-export/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/monetate/ectou-export/pulls/6","id":86402500,"html_url":"https://github.com/monetate/ectou-export/pull/6","diff_url":"https://github.com/monetate/ectou-export/pull/6.diff","patch_url":"https://github.com/monetate/ectou-export/pull/6.patch","issue_url":"https://api.github.com/repos/monetate/ectou-export/issues/6","number":6,"state":"open","locked":false,"title":"Some small fixes to make it work.","user":{"login":"mvanbaak","id":1928231,"avatar_url":"https://avatars.githubusercontent.com/u/1928231?v=3","gravatar_id":"","url":"https://api.github.com/users/mvanbaak","html_url":"https://github.com/mvanbaak","followers_url":"https://api.github.com/users/mvanbaak/followers","following_url":"https://api.github.com/users/mvanbaak/following{/other_user}","gists_url":"https://api.github.com/users/mvanbaak/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanbaak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanbaak/subscriptions","organizations_url":"https://api.github.com/users/mvanbaak/orgs","repos_url":"https://api.github.com/users/mvanbaak/repos","events_url":"https://api.github.com/users/mvanbaak/events{/privacy}","received_events_url":"https://api.github.com/users/mvanbaak/received_events","type":"User","site_admin":false},"body":"First of all, thanks for the work. It almost works perfectly.\nWhile testing it I found some small issues, which I fixed.\n- Amazon released 2016.03.3 AMI so use that as default\n- /etc/redhat-release is not needed and confuses ansible\n- /vagrant cannot be mounted without Guest additions and breaks. So don't mount it\n- The base AMI misses gcc and kernel-devel packages. They are needed to compile the kernel module. Install them.\n","created_at":"2016-09-22T19:49:55Z","updated_at":"2016-11-03T15:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de3811c7330e20d7d8713f385485e7f572fb6f11","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/monetate/ectou-export/pulls/6/commits","review_comments_url":"https://api.github.com/repos/monetate/ectou-export/pulls/6/comments","review_comment_url":"https://api.github.com/repos/monetate/ectou-export/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monetate/ectou-export/issues/6/comments","statuses_url":"https://api.github.com/repos/monetate/ectou-export/statuses/6d1bf4158471519a8dd8d3f805fd9837d666d608","head":{"label":"mvanbaak:fixes","ref":"fixes","sha":"6d1bf4158471519a8dd8d3f805fd9837d666d608","user":{"login":"mvanbaak","id":1928231,"avatar_url":"https://avatars.githubusercontent.com/u/1928231?v=3","gravatar_id":"","url":"https://api.github.com/users/mvanbaak","html_url":"https://github.com/mvanbaak","followers_url":"https://api.github.com/users/mvanbaak/followers","following_url":"https://api.github.com/users/mvanbaak/following{/other_user}","gists_url":"https://api.github.com/users/mvanbaak/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanbaak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanbaak/subscriptions","organizations_url":"https://api.github.com/users/mvanbaak/orgs","repos_url":"https://api.github.com/users/mvanbaak/repos","events_url":"https://api.github.com/users/mvanbaak/events{/privacy}","received_events_url":"https://api.github.com/users/mvanbaak/received_events","type":"User","site_admin":false},"repo":{"id":68953443,"name":"ectou-export","full_name":"mvanbaak/ectou-export","owner":{"login":"mvanbaak","id":1928231,"avatar_url":"https://avatars.githubusercontent.com/u/1928231?v=3","gravatar_id":"","url":"https://api.github.com/users/mvanbaak","html_url":"https://github.com/mvanbaak","followers_url":"https://api.github.com/users/mvanbaak/followers","following_url":"https://api.github.com/users/mvanbaak/following{/other_user}","gists_url":"https://api.github.com/users/mvanbaak/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanbaak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanbaak/subscriptions","organizations_url":"https://api.github.com/users/mvanbaak/orgs","repos_url":"https://api.github.com/users/mvanbaak/repos","events_url":"https://api.github.com/users/mvanbaak/events{/privacy}","received_events_url":"https://api.github.com/users/mvanbaak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvanbaak/ectou-export","description":"This project enables running an Amazon Linux AMI on a local VirtualBox virtual machine via Vagrant.","fork":true,"url":"https://api.github.com/repos/mvanbaak/ectou-export","forks_url":"https://api.github.com/repos/mvanbaak/ectou-export/forks","keys_url":"https://api.github.com/repos/mvanbaak/ectou-export/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvanbaak/ectou-export/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvanbaak/ectou-export/teams","hooks_url":"https://api.github.com/repos/mvanbaak/ectou-export/hooks","issue_events_url":"https://api.github.com/repos/mvanbaak/ectou-export/issues/events{/number}","events_url":"https://api.github.com/repos/mvanbaak/ectou-export/events","assignees_url":"https://api.github.com/repos/mvanbaak/ectou-export/assignees{/user}","branches_url":"https://api.github.com/repos/mvanbaak/ectou-export/branches{/branch}","tags_url":"https://api.github.com/repos/mvanbaak/ectou-export/tags","blobs_url":"https://api.github.com/repos/mvanbaak/ectou-export/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvanbaak/ectou-export/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvanbaak/ectou-export/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvanbaak/ectou-export/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvanbaak/ectou-export/statuses/{sha}","languages_url":"https://api.github.com/repos/mvanbaak/ectou-export/languages","stargazers_url":"https://api.github.com/repos/mvanbaak/ectou-export/stargazers","contributors_url":"https://api.github.com/repos/mvanbaak/ectou-export/contributors","subscribers_url":"https://api.github.com/repos/mvanbaak/ectou-export/subscribers","subscription_url":"https://api.github.com/repos/mvanbaak/ectou-export/subscription","commits_url":"https://api.github.com/repos/mvanbaak/ectou-export/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvanbaak/ectou-export/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvanbaak/ectou-export/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvanbaak/ectou-export/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvanbaak/ectou-export/contents/{+path}","compare_url":"https://api.github.com/repos/mvanbaak/ectou-export/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvanbaak/ectou-export/merges","archive_url":"https://api.github.com/repos/mvanbaak/ectou-export/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvanbaak/ectou-export/downloads","issues_url":"https://api.github.com/repos/mvanbaak/ectou-export/issues{/number}","pulls_url":"https://api.github.com/repos/mvanbaak/ectou-export/pulls{/number}","milestones_url":"https://api.github.com/repos/mvanbaak/ectou-export/milestones{/number}","notifications_url":"https://api.github.com/repos/mvanbaak/ectou-export/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvanbaak/ectou-export/labels{/name}","releases_url":"https://api.github.com/repos/mvanbaak/ectou-export/releases{/id}","deployments_url":"https://api.github.com/repos/mvanbaak/ectou-export/deployments","created_at":"2016-09-22T19:07:02Z","updated_at":"2016-09-22T19:07:03Z","pushed_at":"2016-09-22T19:47:22Z","git_url":"git://github.com/mvanbaak/ectou-export.git","ssh_url":"git@github.com:mvanbaak/ectou-export.git","clone_url":"https://github.com/mvanbaak/ectou-export.git","svn_url":"https://github.com/mvanbaak/ectou-export","homepage":"","size":11,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"monetate:master","ref":"master","sha":"57f9231630d9d21f741c894a48455148e7e50e07","user":{"login":"monetate","id":1292620,"avatar_url":"https://avatars.githubusercontent.com/u/1292620?v=3","gravatar_id":"","url":"https://api.github.com/users/monetate","html_url":"https://github.com/monetate","followers_url":"https://api.github.com/users/monetate/followers","following_url":"https://api.github.com/users/monetate/following{/other_user}","gists_url":"https://api.github.com/users/monetate/gists{/gist_id}","starred_url":"https://api.github.com/users/monetate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monetate/subscriptions","organizations_url":"https://api.github.com/users/monetate/orgs","repos_url":"https://api.github.com/users/monetate/repos","events_url":"https://api.github.com/users/monetate/events{/privacy}","received_events_url":"https://api.github.com/users/monetate/received_events","type":"Organization","site_admin":false},"repo":{"id":49444975,"name":"ectou-export","full_name":"monetate/ectou-export","owner":{"login":"monetate","id":1292620,"avatar_url":"https://avatars.githubusercontent.com/u/1292620?v=3","gravatar_id":"","url":"https://api.github.com/users/monetate","html_url":"https://github.com/monetate","followers_url":"https://api.github.com/users/monetate/followers","following_url":"https://api.github.com/users/monetate/following{/other_user}","gists_url":"https://api.github.com/users/monetate/gists{/gist_id}","starred_url":"https://api.github.com/users/monetate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monetate/subscriptions","organizations_url":"https://api.github.com/users/monetate/orgs","repos_url":"https://api.github.com/users/monetate/repos","events_url":"https://api.github.com/users/monetate/events{/privacy}","received_events_url":"https://api.github.com/users/monetate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/monetate/ectou-export","description":"This project enables running an Amazon Linux AMI on a local VirtualBox virtual machine via Vagrant.","fork":false,"url":"https://api.github.com/repos/monetate/ectou-export","forks_url":"https://api.github.com/repos/monetate/ectou-export/forks","keys_url":"https://api.github.com/repos/monetate/ectou-export/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monetate/ectou-export/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monetate/ectou-export/teams","hooks_url":"https://api.github.com/repos/monetate/ectou-export/hooks","issue_events_url":"https://api.github.com/repos/monetate/ectou-export/issues/events{/number}","events_url":"https://api.github.com/repos/monetate/ectou-export/events","assignees_url":"https://api.github.com/repos/monetate/ectou-export/assignees{/user}","branches_url":"https://api.github.com/repos/monetate/ectou-export/branches{/branch}","tags_url":"https://api.github.com/repos/monetate/ectou-export/tags","blobs_url":"https://api.github.com/repos/monetate/ectou-export/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monetate/ectou-export/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monetate/ectou-export/git/refs{/sha}","trees_url":"https://api.github.com/repos/monetate/ectou-export/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monetate/ectou-export/statuses/{sha}","languages_url":"https://api.github.com/repos/monetate/ectou-export/languages","stargazers_url":"https://api.github.com/repos/monetate/ectou-export/stargazers","contributors_url":"https://api.github.com/repos/monetate/ectou-export/contributors","subscribers_url":"https://api.github.com/repos/monetate/ectou-export/subscribers","subscription_url":"https://api.github.com/repos/monetate/ectou-export/subscription","commits_url":"https://api.github.com/repos/monetate/ectou-export/commits{/sha}","git_commits_url":"https://api.github.com/repos/monetate/ectou-export/git/commits{/sha}","comments_url":"https://api.github.com/repos/monetate/ectou-export/comments{/number}","issue_comment_url":"https://api.github.com/repos/monetate/ectou-export/issues/comments{/number}","contents_url":"https://api.github.com/repos/monetate/ectou-export/contents/{+path}","compare_url":"https://api.github.com/repos/monetate/ectou-export/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monetate/ectou-export/merges","archive_url":"https://api.github.com/repos/monetate/ectou-export/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monetate/ectou-export/downloads","issues_url":"https://api.github.com/repos/monetate/ectou-export/issues{/number}","pulls_url":"https://api.github.com/repos/monetate/ectou-export/pulls{/number}","milestones_url":"https://api.github.com/repos/monetate/ectou-export/milestones{/number}","notifications_url":"https://api.github.com/repos/monetate/ectou-export/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monetate/ectou-export/labels{/name}","releases_url":"https://api.github.com/repos/monetate/ectou-export/releases{/id}","deployments_url":"https://api.github.com/repos/monetate/ectou-export/deployments","created_at":"2016-01-11T18:18:13Z","updated_at":"2016-11-02T23:37:08Z","pushed_at":"2016-11-03T02:29:59Z","git_url":"git://github.com/monetate/ectou-export.git","ssh_url":"git@github.com:monetate/ectou-export.git","clone_url":"https://github.com/monetate/ectou-export.git","svn_url":"https://github.com/monetate/ectou-export","homepage":"","size":19,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monetate/ectou-export/pulls/6"},"html":{"href":"https://github.com/monetate/ectou-export/pull/6"},"issue":{"href":"https://api.github.com/repos/monetate/ectou-export/issues/6"},"comments":{"href":"https://api.github.com/repos/monetate/ectou-export/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/monetate/ectou-export/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/monetate/ectou-export/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monetate/ectou-export/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/monetate/ectou-export/statuses/6d1bf4158471519a8dd8d3f805fd9837d666d608"}}}}
{"actor":{"display_login":"jjpersch"}}