{"action":"created","issue":{"url":"https://api.github.com/repos/dteviot/WebToEpub/issues/32","repository_url":"https://api.github.com/repos/dteviot/WebToEpub","labels_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/32/comments","events_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/32/events","html_url":"https://github.com/dteviot/WebToEpub/issues/32","id":162836660,"number":32,"title":"Baka-Tsuki - epubcheck errors","user":{"login":"dreamer2908","id":1423237,"avatar_url":"https://avatars.githubusercontent.com/u/1423237?v=3","gravatar_id":"","url":"https://api.github.com/users/dreamer2908","html_url":"https://github.com/dreamer2908","followers_url":"https://api.github.com/users/dreamer2908/followers","following_url":"https://api.github.com/users/dreamer2908/following{/other_user}","gists_url":"https://api.github.com/users/dreamer2908/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamer2908/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamer2908/subscriptions","organizations_url":"https://api.github.com/users/dreamer2908/orgs","repos_url":"https://api.github.com/users/dreamer2908/repos","events_url":"https://api.github.com/users/dreamer2908/events{/privacy}","received_events_url":"https://api.github.com/users/dreamer2908/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-29T04:04:26Z","updated_at":"2016-06-29T08:06:37Z","closed_at":null,"body":"1. Images can be embedded in B-T stories in form of inline images instead of thumbnails. The result xhtml code will be (slightly) invalid if WebToEpub encounters this type of images: `div` tag is inside `p` tag.  \r\nExample: All non-gallery images here: [Utsuro no Hako:Volume 1](https://www.baka-tsuki.org/project/index.php?title=Utsuro_no_Hako:Volume_1)  \r\nResult xhtml code for the first image:  \r\n```<p><div class=\"svg_outer svg_inner\"><svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" height=\"100%\" width=\"100%\" version=\"1.1\" preserveAspectRatio=\"xMidYMid meet\" viewBox=\"0 0 1368 1000\"><image xlink:href=\"../Images/0006_Utsuro_no_..._vol1_pic1.jpg\" height=\"1000\" width=\"1368\"/><desc>https://www.baka-tsuki.org/project/index.php?title=File:Utsuro_no_Hako_vol1_pic1.jpg</desc></svg></div>\r\n</p>```  \r\nEpubcheck error message:  \r\n```ERROR: /home/yumi/Downloads/Utsuro_no_...koVolume_1.epub/OEBPS/Text/0000_Novel_Illustrations.xhtml(2,34): element \"div\" not allowed here; expected the element end-tag, text or element \"a\", \"abbr\", \"acronym\", \"applet\", \"b\", \"bdo\", \"big\", \"br\", \"cite\", \"code\", \"del\", \"dfn\", \"em\", \"i\", \"iframe\", \"img\", \"ins\", \"kbd\", \"map\", \"noscript\", \"ns:svg\", \"object\", \"q\", \"samp\", \"script\", \"small\", \"span\", \"strong\", \"sub\", \"sup\", \"tt\" or \"var\" (with xmlns:ns=\"http://www.w3.org/2000/svg\")```\r\n2. WebToEpub doesn't convert the deprecated `u` tag (underline) into suitable form for epub.  \r\n`<p>Normal <u>underline></u></p>` should become `<p>Normal <span style=\"text-decoration: underline;\">underline></span></p>`  \r\nSample: same as above.  \r\nEpubcheck error message:  \r\n```ERROR: /home/yumi/Downloads/Utsuro_no_...koVolume_1.epub/OEBPS/Text/0001_Prologue.xhtml(4,85): element \"u\" not allowed anywhere; expected the element end-tag, text or element \"a\", \"abbr\", \"acronym\", \"applet\", \"b\", \"bdo\", \"big\", \"br\", \"cite\", \"code\", \"del\", \"dfn\", \"em\", \"i\", \"iframe\", \"img\", \"ins\", \"kbd\", \"map\", \"noscript\", \"ns:svg\", \"object\", \"q\", \"samp\", \"script\", \"small\", \"span\", \"strong\", \"sub\", \"sup\", \"tt\" or \"var\" (with xmlns:ns=\"http://www.w3.org/2000/svg\")```\r\n3. Invalid id in `span` tag inside h* tag are not fixed, like `<h3><span class=\"mw-headline\" id=\"1st_time\">1<sup>st</sup> time</span></h3>`  \r\nEpubcheck error message:  \r\n```ERROR: /home/yumi/Downloads/Utsuro_no_...koVolume_1.epub/OEBPS/Text/0002_1st_time.xhtml(1,497): value of attribute \"id\" is invalid; must be an XML name without colons```  \r\nSide note: BTE-GEN converts it into `<h3 id=\"1st_time\">`, but it's still not fixed, and not useful here.\r\n\r\nWell, some more, but I lost the samples.\r\n\r\n- `center` tag isn't allowed in epub, too. `<center>text</center>` should become `<p style=\"text-align: center;\"></p>`\r\n- `align` attribute in p/span/div should be converted into css style `text-align:`\r\n\r\nBTE-GEN moves up heading if higher levels are missing, i.e `h2` to `h1`, `h3` to `h2` if there's no `h1`. Can this be considered?\r\n\r\nIn list of references (translator's notes) in B-T web, the link to jump up to where the reference belongs to only has a single `↑` symbol. The same in BTE-GEN's output. In WebToEpub's output, it becomes `Jump up ↑`. If you remove `cite-accessibility-label` (class), the `Jump up` text will stop popping up out of nowhere.\r\n\r\nFull disclose: I'm developing my own (not easy-to-use) Baka-Tsuki to epub converter, which is for freaks like me, and not for normal users at all."},"comment":{"url":"https://api.github.com/repos/dteviot/WebToEpub/issues/comments/229285839","html_url":"https://github.com/dteviot/WebToEpub/issues/32#issuecomment-229285839","issue_url":"https://api.github.com/repos/dteviot/WebToEpub/issues/32","id":229285839,"user":{"login":"dteviot","id":5157081,"avatar_url":"https://avatars.githubusercontent.com/u/5157081?v=3","gravatar_id":"","url":"https://api.github.com/users/dteviot","html_url":"https://github.com/dteviot","followers_url":"https://api.github.com/users/dteviot/followers","following_url":"https://api.github.com/users/dteviot/following{/other_user}","gists_url":"https://api.github.com/users/dteviot/gists{/gist_id}","starred_url":"https://api.github.com/users/dteviot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dteviot/subscriptions","organizations_url":"https://api.github.com/users/dteviot/orgs","repos_url":"https://api.github.com/users/dteviot/repos","events_url":"https://api.github.com/users/dteviot/events{/privacy}","received_events_url":"https://api.github.com/users/dteviot/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T08:06:37Z","updated_at":"2016-06-29T08:06:37Z","body":"Yup.  That's one of the two key problems I'm currently trying to solve for\nhttps://github.com/dteviot/WebToEpub/issues/9\nHopefully I'll have it solved by the end of the weekend.\n\nOn Wed, Jun 29, 2016 at 5:21 PM, dreamer2908 <notifications@github.com>\nwrote:\n\n> One more (potential) issue, well, if you have free time to play with.\n>\n> Images, both in thumbnail and inline form, can have a custom target link,\n> rather than link to image page. I haven't seen anyone using it in B-T, so\n> it's not really important.\n>\n> Example: User_talk:Dreamer2908\n> <https://www.baka-tsuki.org/project/index.php?title=User_talk:Dreamer2908>.\n> WebToEpub breaks pretty hard.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/dteviot/WebToEpub/issues/32#issuecomment-229259152>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AE6w2ZmnNcP6IBVv6G0V1zUWkm1IpKPYks5qQgDPgaJpZM4JAwH7>\n> .\n>\n"}}
{"actor":{"display_login":"dteviot"}}