{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/69982783","id":69982783,"diff_hunk":"@@ -77,41 +64,85 @@ + (BOOL)automaticallyNotifiesObserversForKey:(NSString*)key {\n     return NO;\n }\n \n-/**\n- @Status Interoperable\n-*/\n-+ (id)allocWithZone:(NSZone*)zone {\n-    NSOperation* ret = [super allocWithZone:zone];\n+- (void)_checkReady {","path":"Frameworks/Foundation/NSOperation.mm","position":103,"original_position":103,"commit_id":"1afbad9df2a488202678c2bb5cfa7b12bf6d049f","original_commit_id":"1afbad9df2a488202678c2bb5cfa7b12bf6d049f","user":{"login":"rajsesh-msft","id":15148713,"avatar_url":"https://avatars.githubusercontent.com/u/15148713?v=3","gravatar_id":"","url":"https://api.github.com/users/rajsesh-msft","html_url":"https://github.com/rajsesh-msft","followers_url":"https://api.github.com/users/rajsesh-msft/followers","following_url":"https://api.github.com/users/rajsesh-msft/following{/other_user}","gists_url":"https://api.github.com/users/rajsesh-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/rajsesh-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajsesh-msft/subscriptions","organizations_url":"https://api.github.com/users/rajsesh-msft/orgs","repos_url":"https://api.github.com/users/rajsesh-msft/repos","events_url":"https://api.github.com/users/rajsesh-msft/events{/privacy}","received_events_url":"https://api.github.com/users/rajsesh-msft/received_events","type":"User","site_admin":false},"body":">_checkReady [](start = 8, length = 11)\r\n\r\n_checkReady can be changed to O(1) instead of O(N) by keeping the ready count.  since you are observing dependencies and their 'finished' state, incrementing/decrementing the counter should do the trick.","created_at":"2016-07-07T20:42:23Z","updated_at":"2016-07-07T20:42:23Z","html_url":"https://github.com/Microsoft/WinObjC/pull/602#discussion_r69982783","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/69982783"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/602#discussion_r69982783"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602","id":76016045,"html_url":"https://github.com/Microsoft/WinObjC/pull/602","diff_url":"https://github.com/Microsoft/WinObjC/pull/602.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/602.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/602","number":602,"state":"open","locked":false,"title":"Fix #580, add support for concurrent NSOperation subclass","user":{"login":"jofre-ms","id":15270533,"avatar_url":"https://avatars.githubusercontent.com/u/15270533?v=3","gravatar_id":"","url":"https://api.github.com/users/jofre-ms","html_url":"https://github.com/jofre-ms","followers_url":"https://api.github.com/users/jofre-ms/followers","following_url":"https://api.github.com/users/jofre-ms/following{/other_user}","gists_url":"https://api.github.com/users/jofre-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jofre-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofre-ms/subscriptions","organizations_url":"https://api.github.com/users/jofre-ms/orgs","repos_url":"https://api.github.com/users/jofre-ms/repos","events_url":"https://api.github.com/users/jofre-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jofre-ms/received_events","type":"User","site_admin":false},"body":"This change redesigns NSOperation for subclassability as documented for the reference platform, and adds a test to verify that the subclass no longer deadlocks in waitUntilFinished.","created_at":"2016-07-01T18:02:34Z","updated_at":"2016-07-07T20:42:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"666f0b218d2289b2366689c92293f3ecf18dd4da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/602/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/1afbad9df2a488202678c2bb5cfa7b12bf6d049f","head":{"label":"jofre-ms:jofre/NSOperation","ref":"jofre/NSOperation","sha":"1afbad9df2a488202678c2bb5cfa7b12bf6d049f","user":{"login":"jofre-ms","id":15270533,"avatar_url":"https://avatars.githubusercontent.com/u/15270533?v=3","gravatar_id":"","url":"https://api.github.com/users/jofre-ms","html_url":"https://github.com/jofre-ms","followers_url":"https://api.github.com/users/jofre-ms/followers","following_url":"https://api.github.com/users/jofre-ms/following{/other_user}","gists_url":"https://api.github.com/users/jofre-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jofre-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofre-ms/subscriptions","organizations_url":"https://api.github.com/users/jofre-ms/orgs","repos_url":"https://api.github.com/users/jofre-ms/repos","events_url":"https://api.github.com/users/jofre-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jofre-ms/received_events","type":"User","site_admin":false},"repo":{"id":62094153,"name":"WinObjC","full_name":"jofre-ms/WinObjC","owner":{"login":"jofre-ms","id":15270533,"avatar_url":"https://avatars.githubusercontent.com/u/15270533?v=3","gravatar_id":"","url":"https://api.github.com/users/jofre-ms","html_url":"https://github.com/jofre-ms","followers_url":"https://api.github.com/users/jofre-ms/followers","following_url":"https://api.github.com/users/jofre-ms/following{/other_user}","gists_url":"https://api.github.com/users/jofre-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/jofre-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofre-ms/subscriptions","organizations_url":"https://api.github.com/users/jofre-ms/orgs","repos_url":"https://api.github.com/users/jofre-ms/repos","events_url":"https://api.github.com/users/jofre-ms/events{/privacy}","received_events_url":"https://api.github.com/users/jofre-ms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jofre-ms/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/jofre-ms/WinObjC","forks_url":"https://api.github.com/repos/jofre-ms/WinObjC/forks","keys_url":"https://api.github.com/repos/jofre-ms/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jofre-ms/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jofre-ms/WinObjC/teams","hooks_url":"https://api.github.com/repos/jofre-ms/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/jofre-ms/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/jofre-ms/WinObjC/events","assignees_url":"https://api.github.com/repos/jofre-ms/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/jofre-ms/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/jofre-ms/WinObjC/tags","blobs_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jofre-ms/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/jofre-ms/WinObjC/languages","stargazers_url":"https://api.github.com/repos/jofre-ms/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/jofre-ms/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/jofre-ms/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/jofre-ms/WinObjC/subscription","commits_url":"https://api.github.com/repos/jofre-ms/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/jofre-ms/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/jofre-ms/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/jofre-ms/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/jofre-ms/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/jofre-ms/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jofre-ms/WinObjC/merges","archive_url":"https://api.github.com/repos/jofre-ms/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jofre-ms/WinObjC/downloads","issues_url":"https://api.github.com/repos/jofre-ms/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/jofre-ms/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/jofre-ms/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/jofre-ms/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jofre-ms/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/jofre-ms/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/jofre-ms/WinObjC/deployments","created_at":"2016-06-27T23:07:21Z","updated_at":"2016-06-27T23:07:36Z","pushed_at":"2016-07-07T18:27:50Z","git_url":"git://github.com/jofre-ms/WinObjC.git","ssh_url":"git@github.com:jofre-ms/WinObjC.git","clone_url":"https://github.com/jofre-ms/WinObjC.git","svn_url":"https://github.com/jofre-ms/WinObjC","homepage":"","size":326545,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"1cad5214e7c81dbe01cb569b38d632718f60533d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-07-07T18:18:13Z","pushed_at":"2016-07-07T18:27:51Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":328888,"stargazers_count":5311,"watchers_count":5311,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":667,"mirror_url":null,"open_issues_count":165,"forks":667,"open_issues":165,"watchers":5311,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/602"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/602"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/1afbad9df2a488202678c2bb5cfa7b12bf6d049f"}}}}
{"actor":{"display_login":"rajsesh-msft"}}