{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/69437436","id":69437436,"diff_hunk":"@@ -77,6 +77,9 @@ public void process(K key, Change<V> change) {\n             V newValue = computeValue(key, change.newValue);\n             V oldValue = sendOldValues ? computeValue(key, change.oldValue) : null;\n \n+            if (sendOldValues && oldValue == null && newValue == null)","path":"streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableFilter.java","position":4,"original_position":4,"commit_id":"1dccdbad81bdf5fcd13d0c6d36ddc5c6533e1ef4","original_commit_id":"1dccdbad81bdf5fcd13d0c6d36ddc5c6533e1ef4","user":{"login":"miguno","id":294849,"avatar_url":"https://avatars.githubusercontent.com/u/294849?v=3","gravatar_id":"","url":"https://api.github.com/users/miguno","html_url":"https://github.com/miguno","followers_url":"https://api.github.com/users/miguno/followers","following_url":"https://api.github.com/users/miguno/following{/other_user}","gists_url":"https://api.github.com/users/miguno/gists{/gist_id}","starred_url":"https://api.github.com/users/miguno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguno/subscriptions","organizations_url":"https://api.github.com/users/miguno/orgs","repos_url":"https://api.github.com/users/miguno/repos","events_url":"https://api.github.com/users/miguno/events{/privacy}","received_events_url":"https://api.github.com/users/miguno/received_events","type":"User","site_admin":false},"body":"Just to double-check because the JIRA ticket is a bit difficult to follow: Is this single condition sufficient to cover the following discussion/flow in the JIRA ticket?\r\n\r\n> 3) If \"send old value\" is enabled, then there are a couple of cases we can consider:\r\n>\r\n> a. If old value is <key: null> and new value is <key: not-null>, and the filter predicate return false for the new value, then in this case it is safe to optimize and not returning anything to the downstream operator, since in this case we know there is no value for the key previously anyways; otherwise we send the original pair.\r\n>\r\n> b. If old value is <key: not-null> and new value is <key: null>, indicating to delete this key, and the filter predicate return false for the old value, then in this case it is safe to optimize and not returning anything to the downstream operator, since we know that the old value has already been filtered in a previous message; otherwise we send the original pair.\r\n>\r\n> c. If both old and new values are not null, and:\r\n>   1) predicate return true on both, send the original pair;\r\n>   2) predicate return false on both, we can optimize and do not send anything;\r\n>   3) predicate return true on old and false on new, send the key: {old -> null};\r\n>   4) predicate return false on old and true on new, send the key: {null -> new};\r\n","created_at":"2016-07-04T10:18:18Z","updated_at":"2016-07-04T10:18:18Z","html_url":"https://github.com/apache/kafka/pull/1556#discussion_r69437436","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1556","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/69437436"},"html":{"href":"https://github.com/apache/kafka/pull/1556#discussion_r69437436"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1556"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1556","id":75228653,"html_url":"https://github.com/apache/kafka/pull/1556","diff_url":"https://github.com/apache/kafka/pull/1556.diff","patch_url":"https://github.com/apache/kafka/pull/1556.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1556","number":1556,"state":"closed","locked":false,"title":"KAFKA-3902","user":{"login":"phderome","id":11035032,"avatar_url":"https://avatars.githubusercontent.com/u/11035032?v=3","gravatar_id":"","url":"https://api.github.com/users/phderome","html_url":"https://github.com/phderome","followers_url":"https://api.github.com/users/phderome/followers","following_url":"https://api.github.com/users/phderome/following{/other_user}","gists_url":"https://api.github.com/users/phderome/gists{/gist_id}","starred_url":"https://api.github.com/users/phderome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phderome/subscriptions","organizations_url":"https://api.github.com/users/phderome/orgs","repos_url":"https://api.github.com/users/phderome/repos","events_url":"https://api.github.com/users/phderome/events{/privacy}","received_events_url":"https://api.github.com/users/phderome/received_events","type":"User","site_admin":false},"body":"The contribution is my original work and that I license the work to the project under the project's open source license.\r\n\r\nContributors: Guozhang Wang, Phil Derome\r\n@guozhangwang \r\n\r\nAdded checkEmpty to validate processor does nothing  and added a inhibit check for filter to fix issue.","created_at":"2016-06-26T12:33:09Z","updated_at":"2016-07-04T10:18:18Z","closed_at":"2016-07-01T23:47:39Z","merged_at":null,"merge_commit_sha":"24e37276b4f3aab464bc8f4b9131eb31f2eed11c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1556/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1556/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1556/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/1dccdbad81bdf5fcd13d0c6d36ddc5c6533e1ef4","head":{"label":"phderome:DEROME-3902","ref":"DEROME-3902","sha":"1dccdbad81bdf5fcd13d0c6d36ddc5c6533e1ef4","user":{"login":"phderome","id":11035032,"avatar_url":"https://avatars.githubusercontent.com/u/11035032?v=3","gravatar_id":"","url":"https://api.github.com/users/phderome","html_url":"https://github.com/phderome","followers_url":"https://api.github.com/users/phderome/followers","following_url":"https://api.github.com/users/phderome/following{/other_user}","gists_url":"https://api.github.com/users/phderome/gists{/gist_id}","starred_url":"https://api.github.com/users/phderome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phderome/subscriptions","organizations_url":"https://api.github.com/users/phderome/orgs","repos_url":"https://api.github.com/users/phderome/repos","events_url":"https://api.github.com/users/phderome/events{/privacy}","received_events_url":"https://api.github.com/users/phderome/received_events","type":"User","site_admin":false},"repo":{"id":61250785,"name":"kafka","full_name":"phderome/kafka","owner":{"login":"phderome","id":11035032,"avatar_url":"https://avatars.githubusercontent.com/u/11035032?v=3","gravatar_id":"","url":"https://api.github.com/users/phderome","html_url":"https://github.com/phderome","followers_url":"https://api.github.com/users/phderome/followers","following_url":"https://api.github.com/users/phderome/following{/other_user}","gists_url":"https://api.github.com/users/phderome/gists{/gist_id}","starred_url":"https://api.github.com/users/phderome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phderome/subscriptions","organizations_url":"https://api.github.com/users/phderome/orgs","repos_url":"https://api.github.com/users/phderome/repos","events_url":"https://api.github.com/users/phderome/events{/privacy}","received_events_url":"https://api.github.com/users/phderome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phderome/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/phderome/kafka","forks_url":"https://api.github.com/repos/phderome/kafka/forks","keys_url":"https://api.github.com/repos/phderome/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phderome/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phderome/kafka/teams","hooks_url":"https://api.github.com/repos/phderome/kafka/hooks","issue_events_url":"https://api.github.com/repos/phderome/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/phderome/kafka/events","assignees_url":"https://api.github.com/repos/phderome/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/phderome/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/phderome/kafka/tags","blobs_url":"https://api.github.com/repos/phderome/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phderome/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phderome/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/phderome/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phderome/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/phderome/kafka/languages","stargazers_url":"https://api.github.com/repos/phderome/kafka/stargazers","contributors_url":"https://api.github.com/repos/phderome/kafka/contributors","subscribers_url":"https://api.github.com/repos/phderome/kafka/subscribers","subscription_url":"https://api.github.com/repos/phderome/kafka/subscription","commits_url":"https://api.github.com/repos/phderome/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/phderome/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/phderome/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/phderome/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/phderome/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/phderome/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phderome/kafka/merges","archive_url":"https://api.github.com/repos/phderome/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phderome/kafka/downloads","issues_url":"https://api.github.com/repos/phderome/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/phderome/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/phderome/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/phderome/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phderome/kafka/labels{/name}","releases_url":"https://api.github.com/repos/phderome/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/phderome/kafka/deployments","created_at":"2016-06-16T00:51:10Z","updated_at":"2016-06-16T00:51:15Z","pushed_at":"2016-07-01T21:08:15Z","git_url":"git://github.com/phderome/kafka.git","ssh_url":"git@github.com:phderome/kafka.git","clone_url":"https://github.com/phderome/kafka.git","svn_url":"https://github.com/phderome/kafka","homepage":null,"size":32431,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"7edaa3dd89d1a7300a12e101e23f66459a9cc33d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-07-04T08:35:26Z","pushed_at":"2016-07-04T07:54:23Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":44571,"stargazers_count":3368,"watchers_count":3368,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2067,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":206,"forks":2067,"open_issues":206,"watchers":3368,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1556"},"html":{"href":"https://github.com/apache/kafka/pull/1556"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1556"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1556/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1556/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1556/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/1dccdbad81bdf5fcd13d0c6d36ddc5c6533e1ef4"}}}}
{"actor":{"display_login":"miguno"}}