{"action":"created","comment":{"url":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/comments/71531737","id":71531737,"diff_hunk":"@@ -319,7 +320,19 @@ namespace ISMRMRD\n   };\n \n   struct IsmrmrdHeader\n+  : public Entity","path":"include/ismrmrd/xml.h","position":12,"original_position":12,"commit_id":"415ea8584c347a8b9246fcdc11ce389084fee76b","original_commit_id":"415ea8584c347a8b9246fcdc11ce389084fee76b","user":{"login":"vadre","id":11231820,"avatar_url":"https://avatars.githubusercontent.com/u/11231820?v=3","gravatar_id":"","url":"https://api.github.com/users/vadre","html_url":"https://github.com/vadre","followers_url":"https://api.github.com/users/vadre/followers","following_url":"https://api.github.com/users/vadre/following{/other_user}","gists_url":"https://api.github.com/users/vadre/gists{/gist_id}","starred_url":"https://api.github.com/users/vadre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadre/subscriptions","organizations_url":"https://api.github.com/users/vadre/orgs","repos_url":"https://api.github.com/users/vadre/repos","events_url":"https://api.github.com/users/vadre/events{/privacy}","received_events_url":"https://api.github.com/users/vadre/received_events","type":"User","site_admin":false},"body":"When should I stop by?\n\nVlad Dreyvitser [C] | Computer Programmer, NIH/NHLBI\nEmail: vlad.dreyvitser@nih.gov<mailto:vlad.dreyvitser@nih.gov>\nMobile: +1-703-835-3559\n9000 Rockville Pike, Bethesda, MD 20814\n\nFrom: Michael Hansen <notifications@github.com<mailto:notifications@github.com>>\nReply-To: ismrmrd/ismrmrd <reply@reply.github.com<mailto:reply@reply.github.com>>\nDate: Wednesday, July 20, 2016 at 8:56 AM\nTo: ismrmrd/ismrmrd <ismrmrd@noreply.github.com<mailto:ismrmrd@noreply.github.com>>\nCc: \"Dreyvitser, Vlad (NIH/NHLBI) [C]\" <vlad.dreyvitser@nih.gov<mailto:vlad.dreyvitser@nih.gov>>, Author <author@noreply.github.com<mailto:author@noreply.github.com>>\nSubject: Re: [ismrmrd/ismrmrd] Added virtual getVersion to Entity class. Made IsmrmrdHeader subclass… (#61)\n\n\nIn include/ismrmrd/xml.h<https://github.com/ismrmrd/ismrmrd/pull/61#discussion_r71518628>:\n\n> @@ -319,7 +320,19 @@ namespace ISMRMRD\n>    };\n>\n>    struct IsmrmrdHeader\n> +  : public Entity\n\n\nThis is wrong. This ismrmrd header is the deserialized version of the XML header. Not the actual acquisitions. When the XML header is an \"entity\" on the wire, we need a different class for it or something. We should discuss.\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub<https://github.com/ismrmrd/ismrmrd/pull/61/files/415ea8584c347a8b9246fcdc11ce389084fee76b#r71518628>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKtiTErWVoBstSx5oF1oGjH9sAuq4oFeks5qXhr2gaJpZM4JQOqn>.\n","created_at":"2016-07-20T14:12:04Z","updated_at":"2016-07-20T14:12:04Z","html_url":"https://github.com/ismrmrd/ismrmrd/pull/61#discussion_r71531737","pull_request_url":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/comments/71531737"},"html":{"href":"https://github.com/ismrmrd/ismrmrd/pull/61#discussion_r71531737"},"pull_request":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61","id":78058402,"html_url":"https://github.com/ismrmrd/ismrmrd/pull/61","diff_url":"https://github.com/ismrmrd/ismrmrd/pull/61.diff","patch_url":"https://github.com/ismrmrd/ismrmrd/pull/61.patch","issue_url":"https://api.github.com/repos/ismrmrd/ismrmrd/issues/61","number":61,"state":"open","locked":false,"title":"Added virtual getVersion to Entity class. Made IsmrmrdHeader subclass…","user":{"login":"vadre","id":11231820,"avatar_url":"https://avatars.githubusercontent.com/u/11231820?v=3","gravatar_id":"","url":"https://api.github.com/users/vadre","html_url":"https://github.com/vadre","followers_url":"https://api.github.com/users/vadre/followers","following_url":"https://api.github.com/users/vadre/following{/other_user}","gists_url":"https://api.github.com/users/vadre/gists{/gist_id}","starred_url":"https://api.github.com/users/vadre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadre/subscriptions","organizations_url":"https://api.github.com/users/vadre/orgs","repos_url":"https://api.github.com/users/vadre/repos","events_url":"https://api.github.com/users/vadre/events{/privacy}","received_events_url":"https://api.github.com/users/vadre/received_events","type":"User","site_admin":false},"body":"Added virtual getVersion to Entity class.\r\nMade IsmrmrdHeader subclass of Entity, added virtual getters and constructor. \r\nDrafted Waveform class and methods. \r\nAdded test_waveform and updated test_image and test_xml. \r\nAdded bounds checking for image and NDArray classes per TODOs.","created_at":"2016-07-19T22:11:55Z","updated_at":"2016-07-20T14:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3795140a625873d1a52becf0e3e8aed7902d6103","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61/commits","review_comments_url":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61/comments","review_comment_url":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ismrmrd/ismrmrd/issues/61/comments","statuses_url":"https://api.github.com/repos/ismrmrd/ismrmrd/statuses/415ea8584c347a8b9246fcdc11ce389084fee76b","head":{"label":"vadre:icp2","ref":"icp2","sha":"415ea8584c347a8b9246fcdc11ce389084fee76b","user":{"login":"vadre","id":11231820,"avatar_url":"https://avatars.githubusercontent.com/u/11231820?v=3","gravatar_id":"","url":"https://api.github.com/users/vadre","html_url":"https://github.com/vadre","followers_url":"https://api.github.com/users/vadre/followers","following_url":"https://api.github.com/users/vadre/following{/other_user}","gists_url":"https://api.github.com/users/vadre/gists{/gist_id}","starred_url":"https://api.github.com/users/vadre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadre/subscriptions","organizations_url":"https://api.github.com/users/vadre/orgs","repos_url":"https://api.github.com/users/vadre/repos","events_url":"https://api.github.com/users/vadre/events{/privacy}","received_events_url":"https://api.github.com/users/vadre/received_events","type":"User","site_admin":false},"repo":{"id":52556882,"name":"ismrmrd","full_name":"vadre/ismrmrd","owner":{"login":"vadre","id":11231820,"avatar_url":"https://avatars.githubusercontent.com/u/11231820?v=3","gravatar_id":"","url":"https://api.github.com/users/vadre","html_url":"https://github.com/vadre","followers_url":"https://api.github.com/users/vadre/followers","following_url":"https://api.github.com/users/vadre/following{/other_user}","gists_url":"https://api.github.com/users/vadre/gists{/gist_id}","starred_url":"https://api.github.com/users/vadre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadre/subscriptions","organizations_url":"https://api.github.com/users/vadre/orgs","repos_url":"https://api.github.com/users/vadre/repos","events_url":"https://api.github.com/users/vadre/events{/privacy}","received_events_url":"https://api.github.com/users/vadre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadre/ismrmrd","description":"ISMRM Raw Data Format","fork":true,"url":"https://api.github.com/repos/vadre/ismrmrd","forks_url":"https://api.github.com/repos/vadre/ismrmrd/forks","keys_url":"https://api.github.com/repos/vadre/ismrmrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadre/ismrmrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadre/ismrmrd/teams","hooks_url":"https://api.github.com/repos/vadre/ismrmrd/hooks","issue_events_url":"https://api.github.com/repos/vadre/ismrmrd/issues/events{/number}","events_url":"https://api.github.com/repos/vadre/ismrmrd/events","assignees_url":"https://api.github.com/repos/vadre/ismrmrd/assignees{/user}","branches_url":"https://api.github.com/repos/vadre/ismrmrd/branches{/branch}","tags_url":"https://api.github.com/repos/vadre/ismrmrd/tags","blobs_url":"https://api.github.com/repos/vadre/ismrmrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadre/ismrmrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadre/ismrmrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadre/ismrmrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadre/ismrmrd/statuses/{sha}","languages_url":"https://api.github.com/repos/vadre/ismrmrd/languages","stargazers_url":"https://api.github.com/repos/vadre/ismrmrd/stargazers","contributors_url":"https://api.github.com/repos/vadre/ismrmrd/contributors","subscribers_url":"https://api.github.com/repos/vadre/ismrmrd/subscribers","subscription_url":"https://api.github.com/repos/vadre/ismrmrd/subscription","commits_url":"https://api.github.com/repos/vadre/ismrmrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadre/ismrmrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadre/ismrmrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadre/ismrmrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/vadre/ismrmrd/contents/{+path}","compare_url":"https://api.github.com/repos/vadre/ismrmrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadre/ismrmrd/merges","archive_url":"https://api.github.com/repos/vadre/ismrmrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadre/ismrmrd/downloads","issues_url":"https://api.github.com/repos/vadre/ismrmrd/issues{/number}","pulls_url":"https://api.github.com/repos/vadre/ismrmrd/pulls{/number}","milestones_url":"https://api.github.com/repos/vadre/ismrmrd/milestones{/number}","notifications_url":"https://api.github.com/repos/vadre/ismrmrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadre/ismrmrd/labels{/name}","releases_url":"https://api.github.com/repos/vadre/ismrmrd/releases{/id}","deployments_url":"https://api.github.com/repos/vadre/ismrmrd/deployments","created_at":"2016-02-25T21:08:08Z","updated_at":"2016-02-25T21:08:09Z","pushed_at":"2016-07-19T22:07:04Z","git_url":"git://github.com/vadre/ismrmrd.git","ssh_url":"git@github.com:vadre/ismrmrd.git","clone_url":"https://github.com/vadre/ismrmrd.git","svn_url":"https://github.com/vadre/ismrmrd","homepage":null,"size":1674,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ismrmrd:2.x","ref":"2.x","sha":"868539d1b84ae5bca44f45de6a37951cc2ad9227","user":{"login":"ismrmrd","id":9696820,"avatar_url":"https://avatars.githubusercontent.com/u/9696820?v=3","gravatar_id":"","url":"https://api.github.com/users/ismrmrd","html_url":"https://github.com/ismrmrd","followers_url":"https://api.github.com/users/ismrmrd/followers","following_url":"https://api.github.com/users/ismrmrd/following{/other_user}","gists_url":"https://api.github.com/users/ismrmrd/gists{/gist_id}","starred_url":"https://api.github.com/users/ismrmrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismrmrd/subscriptions","organizations_url":"https://api.github.com/users/ismrmrd/orgs","repos_url":"https://api.github.com/users/ismrmrd/repos","events_url":"https://api.github.com/users/ismrmrd/events{/privacy}","received_events_url":"https://api.github.com/users/ismrmrd/received_events","type":"Organization","site_admin":false},"repo":{"id":26539825,"name":"ismrmrd","full_name":"ismrmrd/ismrmrd","owner":{"login":"ismrmrd","id":9696820,"avatar_url":"https://avatars.githubusercontent.com/u/9696820?v=3","gravatar_id":"","url":"https://api.github.com/users/ismrmrd","html_url":"https://github.com/ismrmrd","followers_url":"https://api.github.com/users/ismrmrd/followers","following_url":"https://api.github.com/users/ismrmrd/following{/other_user}","gists_url":"https://api.github.com/users/ismrmrd/gists{/gist_id}","starred_url":"https://api.github.com/users/ismrmrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismrmrd/subscriptions","organizations_url":"https://api.github.com/users/ismrmrd/orgs","repos_url":"https://api.github.com/users/ismrmrd/repos","events_url":"https://api.github.com/users/ismrmrd/events{/privacy}","received_events_url":"https://api.github.com/users/ismrmrd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ismrmrd/ismrmrd","description":"ISMRM Raw Data Format","fork":false,"url":"https://api.github.com/repos/ismrmrd/ismrmrd","forks_url":"https://api.github.com/repos/ismrmrd/ismrmrd/forks","keys_url":"https://api.github.com/repos/ismrmrd/ismrmrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ismrmrd/ismrmrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ismrmrd/ismrmrd/teams","hooks_url":"https://api.github.com/repos/ismrmrd/ismrmrd/hooks","issue_events_url":"https://api.github.com/repos/ismrmrd/ismrmrd/issues/events{/number}","events_url":"https://api.github.com/repos/ismrmrd/ismrmrd/events","assignees_url":"https://api.github.com/repos/ismrmrd/ismrmrd/assignees{/user}","branches_url":"https://api.github.com/repos/ismrmrd/ismrmrd/branches{/branch}","tags_url":"https://api.github.com/repos/ismrmrd/ismrmrd/tags","blobs_url":"https://api.github.com/repos/ismrmrd/ismrmrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ismrmrd/ismrmrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ismrmrd/ismrmrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ismrmrd/ismrmrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ismrmrd/ismrmrd/statuses/{sha}","languages_url":"https://api.github.com/repos/ismrmrd/ismrmrd/languages","stargazers_url":"https://api.github.com/repos/ismrmrd/ismrmrd/stargazers","contributors_url":"https://api.github.com/repos/ismrmrd/ismrmrd/contributors","subscribers_url":"https://api.github.com/repos/ismrmrd/ismrmrd/subscribers","subscription_url":"https://api.github.com/repos/ismrmrd/ismrmrd/subscription","commits_url":"https://api.github.com/repos/ismrmrd/ismrmrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ismrmrd/ismrmrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ismrmrd/ismrmrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ismrmrd/ismrmrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ismrmrd/ismrmrd/contents/{+path}","compare_url":"https://api.github.com/repos/ismrmrd/ismrmrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ismrmrd/ismrmrd/merges","archive_url":"https://api.github.com/repos/ismrmrd/ismrmrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ismrmrd/ismrmrd/downloads","issues_url":"https://api.github.com/repos/ismrmrd/ismrmrd/issues{/number}","pulls_url":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls{/number}","milestones_url":"https://api.github.com/repos/ismrmrd/ismrmrd/milestones{/number}","notifications_url":"https://api.github.com/repos/ismrmrd/ismrmrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ismrmrd/ismrmrd/labels{/name}","releases_url":"https://api.github.com/repos/ismrmrd/ismrmrd/releases{/id}","deployments_url":"https://api.github.com/repos/ismrmrd/ismrmrd/deployments","created_at":"2014-11-12T14:30:50Z","updated_at":"2016-02-15T09:59:28Z","pushed_at":"2016-07-19T22:11:55Z","git_url":"git://github.com/ismrmrd/ismrmrd.git","ssh_url":"git@github.com:ismrmrd/ismrmrd.git","clone_url":"https://github.com/ismrmrd/ismrmrd.git","svn_url":"https://github.com/ismrmrd/ismrmrd","homepage":null,"size":1645,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":18,"forks":21,"open_issues":18,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61"},"html":{"href":"https://github.com/ismrmrd/ismrmrd/pull/61"},"issue":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/issues/61"},"comments":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/ismrmrd/ismrmrd/statuses/415ea8584c347a8b9246fcdc11ce389084fee76b"}}}}
{"actor":{"display_login":"vadre"}}