{"action":"opened","number":26405,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/26405","id":84413943,"html_url":"https://github.com/docker/docker/pull/26405","diff_url":"https://github.com/docker/docker/pull/26405.diff","patch_url":"https://github.com/docker/docker/pull/26405.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/26405","number":26405,"state":"open","locked":false,"title":"Fix Ulimits in `docker inspect` when daemon default exists","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"body":"**- What I did**\r\n\r\nThis fix tries to fix #26326 where `docker inspect` will not show Ulimits even when daemon default ulimits has been set.\r\n\r\n**- How I did it**\r\n\r\nThis fix merge the HostConfig's ulimit with daemon default in `docker inspect`, so that when daemon is started with `default-ulimits` and HostConfig's ulimits is not set, `docker inspect` will output the daemon default.\r\n\r\n**- How to verify it**\r\n\r\nAn integration test has been added to cover the changes.\r\n\r\n**- Description for the changelog**\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\nThis fix fixes #26326.\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","created_at":"2016-09-08T04:43:03Z","updated_at":"2016-09-08T04:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3906bd1be1d33b4fe57b443edcd717281009730","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/26405/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/26405/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/26405/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/9ac41ba0245ab0a5933d309486ee0d277e3fda04","head":{"label":"yongtang:26326-inspect-ulimit-with-daemon-default","ref":"26326-inspect-ulimit-with-daemon-default","sha":"9ac41ba0245ab0a5933d309486ee0d277e3fda04","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"repo":{"id":53518876,"name":"docker","full_name":"yongtang/docker","owner":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yongtang/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/yongtang/docker","forks_url":"https://api.github.com/repos/yongtang/docker/forks","keys_url":"https://api.github.com/repos/yongtang/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yongtang/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yongtang/docker/teams","hooks_url":"https://api.github.com/repos/yongtang/docker/hooks","issue_events_url":"https://api.github.com/repos/yongtang/docker/issues/events{/number}","events_url":"https://api.github.com/repos/yongtang/docker/events","assignees_url":"https://api.github.com/repos/yongtang/docker/assignees{/user}","branches_url":"https://api.github.com/repos/yongtang/docker/branches{/branch}","tags_url":"https://api.github.com/repos/yongtang/docker/tags","blobs_url":"https://api.github.com/repos/yongtang/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yongtang/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yongtang/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/yongtang/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yongtang/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/yongtang/docker/languages","stargazers_url":"https://api.github.com/repos/yongtang/docker/stargazers","contributors_url":"https://api.github.com/repos/yongtang/docker/contributors","subscribers_url":"https://api.github.com/repos/yongtang/docker/subscribers","subscription_url":"https://api.github.com/repos/yongtang/docker/subscription","commits_url":"https://api.github.com/repos/yongtang/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/yongtang/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/yongtang/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/yongtang/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/yongtang/docker/contents/{+path}","compare_url":"https://api.github.com/repos/yongtang/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yongtang/docker/merges","archive_url":"https://api.github.com/repos/yongtang/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yongtang/docker/downloads","issues_url":"https://api.github.com/repos/yongtang/docker/issues{/number}","pulls_url":"https://api.github.com/repos/yongtang/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/yongtang/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/yongtang/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yongtang/docker/labels{/name}","releases_url":"https://api.github.com/repos/yongtang/docker/releases{/id}","deployments_url":"https://api.github.com/repos/yongtang/docker/deployments","created_at":"2016-03-09T17:51:45Z","updated_at":"2016-03-09T17:51:56Z","pushed_at":"2016-09-08T04:40:18Z","git_url":"git://github.com/yongtang/docker.git","ssh_url":"git@github.com:yongtang/docker.git","clone_url":"https://github.com/yongtang/docker.git","svn_url":"https://github.com/yongtang/docker","homepage":"http://www.docker.com","size":97676,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"5be6ccc433e8c9207c67087304dfb72fa00ba544","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-09-08T04:22:21Z","pushed_at":"2016-09-08T04:43:04Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":207881,"stargazers_count":34741,"watchers_count":34741,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10217,"mirror_url":null,"open_issues_count":2254,"forks":10217,"open_issues":2254,"watchers":34741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/26405"},"html":{"href":"https://github.com/docker/docker/pull/26405"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/26405"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/26405/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/26405/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/26405/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/9ac41ba0245ab0a5933d309486ee0d277e3fda04"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":42,"deletions":13,"changed_files":4}}
{"actor":{"display_login":"yongtang"}}