{"action":"opened","number":47,"pull_request":{"url":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/47","id":69181008,"html_url":"https://github.com/Spomky-Labs/otphp/pull/47","diff_url":"https://github.com/Spomky-Labs/otphp/pull/47.diff","patch_url":"https://github.com/Spomky-Labs/otphp/pull/47.patch","issue_url":"https://api.github.com/repos/Spomky-Labs/otphp/issues/47","number":47,"state":"open","locked":false,"title":"Don't include issuer in URI path when it is included as a parameter","user":{"login":"dapphp","id":552712,"avatar_url":"https://avatars.githubusercontent.com/u/552712?v=3","gravatar_id":"","url":"https://api.github.com/users/dapphp","html_url":"https://github.com/dapphp","followers_url":"https://api.github.com/users/dapphp/followers","following_url":"https://api.github.com/users/dapphp/following{/other_user}","gists_url":"https://api.github.com/users/dapphp/gists{/gist_id}","starred_url":"https://api.github.com/users/dapphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapphp/subscriptions","organizations_url":"https://api.github.com/users/dapphp/orgs","repos_url":"https://api.github.com/users/dapphp/repos","events_url":"https://api.github.com/users/dapphp/events{/privacy}","received_events_url":"https://api.github.com/users/dapphp/received_events","type":"User","site_admin":false},"body":"I noticed when testing with QR codes that Google Authenticator doesn't recognize the issuer when the `otpauth://totp/Issuer:Label?secret=1234` scheme is used and it instead needs to be `otpauth://totp/Label?secret=1234&issuer=Issuer`.\r\n\r\nThis minor change makes it so if the `isIssuerIncludedAsParameter()` property is true, the path component won't get the issuer, and instead it will be a query parameter as is already the case.\r\n\r\nFeel free to merge if this change makes sense overall.","created_at":"2016-05-06T17:09:48Z","updated_at":"2016-05-06T17:09:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/47/commits","review_comments_url":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/47/comments","review_comment_url":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Spomky-Labs/otphp/issues/47/comments","statuses_url":"https://api.github.com/repos/Spomky-Labs/otphp/statuses/e3db862d03887f81b82637054b3c7f5d5c93859b","head":{"label":"dapphp:master","ref":"master","sha":"e3db862d03887f81b82637054b3c7f5d5c93859b","user":{"login":"dapphp","id":552712,"avatar_url":"https://avatars.githubusercontent.com/u/552712?v=3","gravatar_id":"","url":"https://api.github.com/users/dapphp","html_url":"https://github.com/dapphp","followers_url":"https://api.github.com/users/dapphp/followers","following_url":"https://api.github.com/users/dapphp/following{/other_user}","gists_url":"https://api.github.com/users/dapphp/gists{/gist_id}","starred_url":"https://api.github.com/users/dapphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapphp/subscriptions","organizations_url":"https://api.github.com/users/dapphp/orgs","repos_url":"https://api.github.com/users/dapphp/repos","events_url":"https://api.github.com/users/dapphp/events{/privacy}","received_events_url":"https://api.github.com/users/dapphp/received_events","type":"User","site_admin":false},"repo":{"id":58221623,"name":"otphp","full_name":"dapphp/otphp","owner":{"login":"dapphp","id":552712,"avatar_url":"https://avatars.githubusercontent.com/u/552712?v=3","gravatar_id":"","url":"https://api.github.com/users/dapphp","html_url":"https://github.com/dapphp","followers_url":"https://api.github.com/users/dapphp/followers","following_url":"https://api.github.com/users/dapphp/following{/other_user}","gists_url":"https://api.github.com/users/dapphp/gists{/gist_id}","starred_url":"https://api.github.com/users/dapphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapphp/subscriptions","organizations_url":"https://api.github.com/users/dapphp/orgs","repos_url":"https://api.github.com/users/dapphp/repos","events_url":"https://api.github.com/users/dapphp/events{/privacy}","received_events_url":"https://api.github.com/users/dapphp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dapphp/otphp","description":":closed_lock_with_key: A PHP library for generating one time passwords according to RFC 4226 (HOTP Algorithm) and the RFC 6238 (TOTP Algorithm)","fork":true,"url":"https://api.github.com/repos/dapphp/otphp","forks_url":"https://api.github.com/repos/dapphp/otphp/forks","keys_url":"https://api.github.com/repos/dapphp/otphp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dapphp/otphp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dapphp/otphp/teams","hooks_url":"https://api.github.com/repos/dapphp/otphp/hooks","issue_events_url":"https://api.github.com/repos/dapphp/otphp/issues/events{/number}","events_url":"https://api.github.com/repos/dapphp/otphp/events","assignees_url":"https://api.github.com/repos/dapphp/otphp/assignees{/user}","branches_url":"https://api.github.com/repos/dapphp/otphp/branches{/branch}","tags_url":"https://api.github.com/repos/dapphp/otphp/tags","blobs_url":"https://api.github.com/repos/dapphp/otphp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dapphp/otphp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dapphp/otphp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dapphp/otphp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dapphp/otphp/statuses/{sha}","languages_url":"https://api.github.com/repos/dapphp/otphp/languages","stargazers_url":"https://api.github.com/repos/dapphp/otphp/stargazers","contributors_url":"https://api.github.com/repos/dapphp/otphp/contributors","subscribers_url":"https://api.github.com/repos/dapphp/otphp/subscribers","subscription_url":"https://api.github.com/repos/dapphp/otphp/subscription","commits_url":"https://api.github.com/repos/dapphp/otphp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dapphp/otphp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dapphp/otphp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dapphp/otphp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dapphp/otphp/contents/{+path}","compare_url":"https://api.github.com/repos/dapphp/otphp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dapphp/otphp/merges","archive_url":"https://api.github.com/repos/dapphp/otphp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dapphp/otphp/downloads","issues_url":"https://api.github.com/repos/dapphp/otphp/issues{/number}","pulls_url":"https://api.github.com/repos/dapphp/otphp/pulls{/number}","milestones_url":"https://api.github.com/repos/dapphp/otphp/milestones{/number}","notifications_url":"https://api.github.com/repos/dapphp/otphp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dapphp/otphp/labels{/name}","releases_url":"https://api.github.com/repos/dapphp/otphp/releases{/id}","deployments_url":"https://api.github.com/repos/dapphp/otphp/deployments","created_at":"2016-05-06T16:52:07Z","updated_at":"2016-05-06T16:52:08Z","pushed_at":"2016-05-06T17:03:18Z","git_url":"git://github.com/dapphp/otphp.git","ssh_url":"git@github.com:dapphp/otphp.git","clone_url":"https://github.com/dapphp/otphp.git","svn_url":"https://github.com/dapphp/otphp","homepage":"","size":246,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Spomky-Labs:master","ref":"master","sha":"e97fcdc6902f893a93c1c396ba2a9f2d242d9562","user":{"login":"Spomky-Labs","id":6738606,"avatar_url":"https://avatars.githubusercontent.com/u/6738606?v=3","gravatar_id":"","url":"https://api.github.com/users/Spomky-Labs","html_url":"https://github.com/Spomky-Labs","followers_url":"https://api.github.com/users/Spomky-Labs/followers","following_url":"https://api.github.com/users/Spomky-Labs/following{/other_user}","gists_url":"https://api.github.com/users/Spomky-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/Spomky-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spomky-Labs/subscriptions","organizations_url":"https://api.github.com/users/Spomky-Labs/orgs","repos_url":"https://api.github.com/users/Spomky-Labs/repos","events_url":"https://api.github.com/users/Spomky-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/Spomky-Labs/received_events","type":"Organization","site_admin":false},"repo":{"id":13716817,"name":"otphp","full_name":"Spomky-Labs/otphp","owner":{"login":"Spomky-Labs","id":6738606,"avatar_url":"https://avatars.githubusercontent.com/u/6738606?v=3","gravatar_id":"","url":"https://api.github.com/users/Spomky-Labs","html_url":"https://github.com/Spomky-Labs","followers_url":"https://api.github.com/users/Spomky-Labs/followers","following_url":"https://api.github.com/users/Spomky-Labs/following{/other_user}","gists_url":"https://api.github.com/users/Spomky-Labs/gists{/gist_id}","starred_url":"https://api.github.com/users/Spomky-Labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spomky-Labs/subscriptions","organizations_url":"https://api.github.com/users/Spomky-Labs/orgs","repos_url":"https://api.github.com/users/Spomky-Labs/repos","events_url":"https://api.github.com/users/Spomky-Labs/events{/privacy}","received_events_url":"https://api.github.com/users/Spomky-Labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Spomky-Labs/otphp","description":":closed_lock_with_key: A PHP library for generating one time passwords according to RFC 4226 (HOTP Algorithm) and the RFC 6238 (TOTP Algorithm)","fork":true,"url":"https://api.github.com/repos/Spomky-Labs/otphp","forks_url":"https://api.github.com/repos/Spomky-Labs/otphp/forks","keys_url":"https://api.github.com/repos/Spomky-Labs/otphp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spomky-Labs/otphp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spomky-Labs/otphp/teams","hooks_url":"https://api.github.com/repos/Spomky-Labs/otphp/hooks","issue_events_url":"https://api.github.com/repos/Spomky-Labs/otphp/issues/events{/number}","events_url":"https://api.github.com/repos/Spomky-Labs/otphp/events","assignees_url":"https://api.github.com/repos/Spomky-Labs/otphp/assignees{/user}","branches_url":"https://api.github.com/repos/Spomky-Labs/otphp/branches{/branch}","tags_url":"https://api.github.com/repos/Spomky-Labs/otphp/tags","blobs_url":"https://api.github.com/repos/Spomky-Labs/otphp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spomky-Labs/otphp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spomky-Labs/otphp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spomky-Labs/otphp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spomky-Labs/otphp/statuses/{sha}","languages_url":"https://api.github.com/repos/Spomky-Labs/otphp/languages","stargazers_url":"https://api.github.com/repos/Spomky-Labs/otphp/stargazers","contributors_url":"https://api.github.com/repos/Spomky-Labs/otphp/contributors","subscribers_url":"https://api.github.com/repos/Spomky-Labs/otphp/subscribers","subscription_url":"https://api.github.com/repos/Spomky-Labs/otphp/subscription","commits_url":"https://api.github.com/repos/Spomky-Labs/otphp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spomky-Labs/otphp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spomky-Labs/otphp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spomky-Labs/otphp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spomky-Labs/otphp/contents/{+path}","compare_url":"https://api.github.com/repos/Spomky-Labs/otphp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spomky-Labs/otphp/merges","archive_url":"https://api.github.com/repos/Spomky-Labs/otphp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spomky-Labs/otphp/downloads","issues_url":"https://api.github.com/repos/Spomky-Labs/otphp/issues{/number}","pulls_url":"https://api.github.com/repos/Spomky-Labs/otphp/pulls{/number}","milestones_url":"https://api.github.com/repos/Spomky-Labs/otphp/milestones{/number}","notifications_url":"https://api.github.com/repos/Spomky-Labs/otphp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spomky-Labs/otphp/labels{/name}","releases_url":"https://api.github.com/repos/Spomky-Labs/otphp/releases{/id}","deployments_url":"https://api.github.com/repos/Spomky-Labs/otphp/deployments","created_at":"2013-10-20T09:59:08Z","updated_at":"2016-05-04T16:51:21Z","pushed_at":"2016-04-29T18:52:21Z","git_url":"git://github.com/Spomky-Labs/otphp.git","ssh_url":"git@github.com:Spomky-Labs/otphp.git","clone_url":"https://github.com/Spomky-Labs/otphp.git","svn_url":"https://github.com/Spomky-Labs/otphp","homepage":"","size":256,"stargazers_count":233,"watchers_count":233,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":1,"forks":19,"open_issues":1,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/47"},"html":{"href":"https://github.com/Spomky-Labs/otphp/pull/47"},"issue":{"href":"https://api.github.com/repos/Spomky-Labs/otphp/issues/47"},"comments":{"href":"https://api.github.com/repos/Spomky-Labs/otphp/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Spomky-Labs/otphp/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/Spomky-Labs/otphp/statuses/e3db862d03887f81b82637054b3c7f5d5c93859b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}