{"action":"created","issue":{"url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging/issues/61","repository_url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging","labels_url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging/issues/61/comments","events_url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging/issues/61/events","html_url":"https://github.com/NuGet/NuGet.Build.Packaging/pull/61","id":189627269,"number":61,"title":"Fix issue with native projects .vcxproj being built in IDE not seeing…","user":{"login":"bbowman","id":15642573,"avatar_url":"https://avatars.githubusercontent.com/u/15642573?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowman","html_url":"https://github.com/bbowman","followers_url":"https://api.github.com/users/bbowman/followers","following_url":"https://api.github.com/users/bbowman/following{/other_user}","gists_url":"https://api.github.com/users/bbowman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowman/subscriptions","organizations_url":"https://api.github.com/users/bbowman/orgs","repos_url":"https://api.github.com/users/bbowman/repos","events_url":"https://api.github.com/users/bbowman/events{/privacy}","received_events_url":"https://api.github.com/users/bbowman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-16T08:23:20Z","updated_at":"2016-11-29T18:51:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging/pulls/61","html_url":"https://github.com/NuGet/NuGet.Build.Packaging/pull/61","diff_url":"https://github.com/NuGet/NuGet.Build.Packaging/pull/61.diff","patch_url":"https://github.com/NuGet/NuGet.Build.Packaging/pull/61.patch"},"body":"… that they had the Packaging project installed.\r\n\r\nWasn't sure how to go about unit testing since Design time is involved.\r\n\r\n  === TEST EXECUTION SUMMARY ===\r\n     NuGet.Build.Packaging.Tests  Total: 119, Errors: 0, Failed: 8, Skipped: 0, Time: 13.841s\r\n\r\nAre failures expected?"},"comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging/issues/comments/263661948","html_url":"https://github.com/NuGet/NuGet.Build.Packaging/pull/61#issuecomment-263661948","issue_url":"https://api.github.com/repos/NuGet/NuGet.Build.Packaging/issues/61","id":263661948,"user":{"login":"bbowman","id":15642573,"avatar_url":"https://avatars.githubusercontent.com/u/15642573?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowman","html_url":"https://github.com/bbowman","followers_url":"https://api.github.com/users/bbowman/followers","following_url":"https://api.github.com/users/bbowman/following{/other_user}","gists_url":"https://api.github.com/users/bbowman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowman/subscriptions","organizations_url":"https://api.github.com/users/bbowman/orgs","repos_url":"https://api.github.com/users/bbowman/repos","events_url":"https://api.github.com/users/bbowman/events{/privacy}","received_events_url":"https://api.github.com/users/bbowman/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T18:51:21Z","updated_at":"2016-11-29T18:51:21Z","body":"@olgaark @yuehuang010 @rainersigwald \r\n\r\nThe issue we are seeing is that the native design time targets, Microsoft.Cpp.DesignTime.targets, uses **_MainProjectOutput** as the ItemGroup returned by the **GetTargetPathWithTargetPlatformMoniker** target. This is an issue for Nugetizer because it assumes that **TargetPathWithTargetPlatformMoniker** will be used and adjusts its ItemDefinitionGroup as a way to smuggle extra information out of the standard targets. \r\n\r\nThe _real_ way to accomplish what @kzu wants here is a way to interrogate project files for the targets they define but this is obviously complicated by Conditions and the rest (not easily observable from outside the build). Instead he sets a flag on a standard target to know that he is safe to call his target on a referenced project.\r\n\r\nHis approach _should_ be safe if everyone obeys the contract laid out by the common props and targets but there is a small violation for DesignTime which bit me when building in visual studio."}}
{"actor":{"display_login":"bbowman"}}