{"action":"created","comment":{"url":"https://api.github.com/repos/NetSys/bess/pulls/comments/84837776","pull_request_review_id":5588723,"id":84837776,"diff_hunk":"@@ -937,6 +963,9 @@ class BESSControlImpl final : public BESSControl::Service {\n   Status GetModuleInfo(ClientContext* context,\n                        const GetModuleInfoRequest& request,\n                        GetModuleInfoResponse* response) {\n+    if (is_any_worker_running()) {","path":"core/bessctl.cc","position":98,"original_position":86,"commit_id":"2ab0743d30ae38017dd8e88a16bda31f19a2831f","original_commit_id":"f97983ef0949347e02d8d757f511f3330bbc39cb","user":{"login":"sangjinhan","id":1916976,"avatar_url":"https://avatars.githubusercontent.com/u/1916976?v=3","gravatar_id":"","url":"https://api.github.com/users/sangjinhan","html_url":"https://github.com/sangjinhan","followers_url":"https://api.github.com/users/sangjinhan/followers","following_url":"https://api.github.com/users/sangjinhan/following{/other_user}","gists_url":"https://api.github.com/users/sangjinhan/gists{/gist_id}","starred_url":"https://api.github.com/users/sangjinhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangjinhan/subscriptions","organizations_url":"https://api.github.com/users/sangjinhan/orgs","repos_url":"https://api.github.com/users/sangjinhan/repos","events_url":"https://api.github.com/users/sangjinhan/events{/privacy}","received_events_url":"https://api.github.com/users/sangjinhan/received_events","type":"User","site_admin":false},"body":"get_module_info() does not require worker threads to be stopped (see sn_handlers() in snctl.cc)","created_at":"2016-10-25T06:30:10Z","updated_at":"2016-10-25T06:30:11Z","html_url":"https://github.com/NetSys/bess/pull/76#discussion_r84837776","pull_request_url":"https://api.github.com/repos/NetSys/bess/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments/84837776"},"html":{"href":"https://github.com/NetSys/bess/pull/76#discussion_r84837776"},"pull_request":{"href":"https://api.github.com/repos/NetSys/bess/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/NetSys/bess/pulls/76","id":90718682,"html_url":"https://github.com/NetSys/bess/pull/76","diff_url":"https://github.com/NetSys/bess/pull/76.diff","patch_url":"https://github.com/NetSys/bess/pull/76.patch","issue_url":"https://api.github.com/repos/NetSys/bess/issues/76","number":76,"state":"open","locked":false,"title":"gRPC for modules","user":{"login":"changlan","id":603293,"avatar_url":"https://avatars.githubusercontent.com/u/603293?v=3","gravatar_id":"","url":"https://api.github.com/users/changlan","html_url":"https://github.com/changlan","followers_url":"https://api.github.com/users/changlan/followers","following_url":"https://api.github.com/users/changlan/following{/other_user}","gists_url":"https://api.github.com/users/changlan/gists{/gist_id}","starred_url":"https://api.github.com/users/changlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/changlan/subscriptions","organizations_url":"https://api.github.com/users/changlan/orgs","repos_url":"https://api.github.com/users/changlan/repos","events_url":"https://api.github.com/users/changlan/events{/privacy}","received_events_url":"https://api.github.com/users/changlan/received_events","type":"User","site_admin":false},"body":"- Reorganize proto files\r\n- Change BPF, Dump, ExactMatch, and FlowGen modules\r\n- More modules to come..","created_at":"2016-10-25T00:30:54Z","updated_at":"2016-10-25T06:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80b91a58277183c3b1facbe8af8b4ae6c13c2e73","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetSys/bess/pulls/76/commits","review_comments_url":"https://api.github.com/repos/NetSys/bess/pulls/76/comments","review_comment_url":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetSys/bess/issues/76/comments","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/2ab0743d30ae38017dd8e88a16bda31f19a2831f","head":{"label":"NetSys:grpc-modules","ref":"grpc-modules","sha":"2ab0743d30ae38017dd8e88a16bda31f19a2831f","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":41328795,"name":"bess","full_name":"NetSys/bess","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/bess","description":"BESS: Berkeley Extensible Software Switch","fork":false,"url":"https://api.github.com/repos/NetSys/bess","forks_url":"https://api.github.com/repos/NetSys/bess/forks","keys_url":"https://api.github.com/repos/NetSys/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/bess/teams","hooks_url":"https://api.github.com/repos/NetSys/bess/hooks","issue_events_url":"https://api.github.com/repos/NetSys/bess/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/bess/events","assignees_url":"https://api.github.com/repos/NetSys/bess/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/bess/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/bess/tags","blobs_url":"https://api.github.com/repos/NetSys/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/bess/languages","stargazers_url":"https://api.github.com/repos/NetSys/bess/stargazers","contributors_url":"https://api.github.com/repos/NetSys/bess/contributors","subscribers_url":"https://api.github.com/repos/NetSys/bess/subscribers","subscription_url":"https://api.github.com/repos/NetSys/bess/subscription","commits_url":"https://api.github.com/repos/NetSys/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/bess/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/bess/merges","archive_url":"https://api.github.com/repos/NetSys/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/bess/downloads","issues_url":"https://api.github.com/repos/NetSys/bess/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/bess/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/bess/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/bess/deployments","created_at":"2015-08-24T21:51:31Z","updated_at":"2016-10-24T17:11:32Z","pushed_at":"2016-10-25T06:18:07Z","git_url":"git://github.com/NetSys/bess.git","ssh_url":"git@github.com:NetSys/bess.git","clone_url":"https://github.com/NetSys/bess.git","svn_url":"https://github.com/NetSys/bess","homepage":"","size":3870,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":42,"default_branch":"develop"}},"base":{"label":"NetSys:c++","ref":"c++","sha":"0b1f2e9f64345c351e72290cfcb8d13bf84997ac","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":41328795,"name":"bess","full_name":"NetSys/bess","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/bess","description":"BESS: Berkeley Extensible Software Switch","fork":false,"url":"https://api.github.com/repos/NetSys/bess","forks_url":"https://api.github.com/repos/NetSys/bess/forks","keys_url":"https://api.github.com/repos/NetSys/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/bess/teams","hooks_url":"https://api.github.com/repos/NetSys/bess/hooks","issue_events_url":"https://api.github.com/repos/NetSys/bess/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/bess/events","assignees_url":"https://api.github.com/repos/NetSys/bess/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/bess/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/bess/tags","blobs_url":"https://api.github.com/repos/NetSys/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/bess/languages","stargazers_url":"https://api.github.com/repos/NetSys/bess/stargazers","contributors_url":"https://api.github.com/repos/NetSys/bess/contributors","subscribers_url":"https://api.github.com/repos/NetSys/bess/subscribers","subscription_url":"https://api.github.com/repos/NetSys/bess/subscription","commits_url":"https://api.github.com/repos/NetSys/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/bess/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/bess/merges","archive_url":"https://api.github.com/repos/NetSys/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/bess/downloads","issues_url":"https://api.github.com/repos/NetSys/bess/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/bess/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/bess/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/bess/deployments","created_at":"2015-08-24T21:51:31Z","updated_at":"2016-10-24T17:11:32Z","pushed_at":"2016-10-25T06:18:07Z","git_url":"git://github.com/NetSys/bess.git","ssh_url":"git@github.com:NetSys/bess.git","clone_url":"https://github.com/NetSys/bess.git","svn_url":"https://github.com/NetSys/bess","homepage":"","size":3870,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":42,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/76"},"html":{"href":"https://github.com/NetSys/bess/pull/76"},"issue":{"href":"https://api.github.com/repos/NetSys/bess/issues/76"},"comments":{"href":"https://api.github.com/repos/NetSys/bess/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/NetSys/bess/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetSys/bess/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/NetSys/bess/statuses/2ab0743d30ae38017dd8e88a16bda31f19a2831f"}}}}
{"actor":{"display_login":"sangjinhan"}}