{"action":"created","issue":{"url":"https://api.github.com/repos/docker/compose/issues/3748","repository_url":"https://api.github.com/repos/docker/compose","labels_url":"https://api.github.com/repos/docker/compose/issues/3748/labels{/name}","comments_url":"https://api.github.com/repos/docker/compose/issues/3748/comments","events_url":"https://api.github.com/repos/docker/compose/issues/3748/events","html_url":"https://github.com/docker/compose/pull/3748","id":166583687,"number":3748,"title":"tearDown the project override at the end of each test case","user":{"login":"ijc25","id":12985729,"avatar_url":"https://avatars.githubusercontent.com/u/12985729?v=3","gravatar_id":"","url":"https://api.github.com/users/ijc25","html_url":"https://github.com/ijc25","followers_url":"https://api.github.com/users/ijc25/followers","following_url":"https://api.github.com/users/ijc25/following{/other_user}","gists_url":"https://api.github.com/users/ijc25/gists{/gist_id}","starred_url":"https://api.github.com/users/ijc25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijc25/subscriptions","organizations_url":"https://api.github.com/users/ijc25/orgs","repos_url":"https://api.github.com/users/ijc25/repos","events_url":"https://api.github.com/users/ijc25/events{/privacy}","received_events_url":"https://api.github.com/users/ijc25/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/compose/labels/area/tests","name":"area/tests","color":"c7def8"},{"url":"https://api.github.com/repos/docker/compose/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-20T13:39:58Z","updated_at":"2016-07-20T14:57:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/compose/pulls/3748","html_url":"https://github.com/docker/compose/pull/3748","diff_url":"https://github.com/docker/compose/pull/3748.diff","patch_url":"https://github.com/docker/compose/pull/3748.patch"},"body":"self._project.client is a docker.client.Client, so creating a new self._project\r\nleaks (via the embedded connection pool) a bunch of Unix socket file\r\ndescriptors for each test which overrides self.project using this mechanism.\r\n\r\nIn my tests I observed the test harness using 800-900 file descriptor, which is\r\nOK on Linux with the default limit of 1024 but breaks on OSX (e.g. with\r\nDocker4Mac) where the default limit is only 256. The failure can be provoked on\r\nLinux too with `ulimit -n 256`.\r\n\r\nWith this fix I have observed the process ending with ~100 file descriptors\r\nopen, including 83 Unix sockets, so I think there is likely at least one more\r\nleak lurking.\r\n\r\nSigned-off-by: Ian Campbell <ian.campbell@docker.com>"},"comment":{"url":"https://api.github.com/repos/docker/compose/issues/comments/233975361","html_url":"https://github.com/docker/compose/pull/3748#issuecomment-233975361","issue_url":"https://api.github.com/repos/docker/compose/issues/3748","id":233975361,"user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars.githubusercontent.com/u/442180?v=3","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T14:57:32Z","updated_at":"2016-07-20T14:57:32Z","body":"LGTM"}}
{"actor":{"display_login":"dnephin"}}