{"action":"created","issue":{"url":"https://api.github.com/repos/grommet/grommet/issues/895","repository_url":"https://api.github.com/repos/grommet/grommet","labels_url":"https://api.github.com/repos/grommet/grommet/issues/895/labels{/name}","comments_url":"https://api.github.com/repos/grommet/grommet/issues/895/comments","events_url":"https://api.github.com/repos/grommet/grommet/issues/895/events","html_url":"https://github.com/grommet/grommet/pull/895","id":179825228,"number":895,"title":"Card: make copy truncation optional + Accordion Panel style tweak","user":{"login":"jwijay","id":10161095,"avatar_url":"https://avatars.githubusercontent.com/u/10161095?v=3","gravatar_id":"","url":"https://api.github.com/users/jwijay","html_url":"https://github.com/jwijay","followers_url":"https://api.github.com/users/jwijay/followers","following_url":"https://api.github.com/users/jwijay/following{/other_user}","gists_url":"https://api.github.com/users/jwijay/gists{/gist_id}","starred_url":"https://api.github.com/users/jwijay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwijay/subscriptions","organizations_url":"https://api.github.com/users/jwijay/orgs","repos_url":"https://api.github.com/users/jwijay/repos","events_url":"https://api.github.com/users/jwijay/events{/privacy}","received_events_url":"https://api.github.com/users/jwijay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/grommet/grommet/labels/ready","name":"ready","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-28T16:42:47Z","updated_at":"2016-09-28T17:31:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grommet/grommet/pulls/895","html_url":"https://github.com/grommet/grommet/pull/895","diff_url":"https://github.com/grommet/grommet/pull/895.diff","patch_url":"https://github.com/grommet/grommet/pull/895.patch"},"body":"<!--- Provide a general summary of the PR in the Title above -->\r\n\r\n#### What does this PR do?\r\n* makes copy truncation for Card optional (`truncateCopy` option, defaults to `false`).\r\n* allow Accordion Panel to expand full container width (currently `.grommet li` max-width gets applied).\r\n\r\n#### What testing has been done on this PR?\r\nTested against hpe-digitaltoolkit repo in Chrome, Firefox, and Safari.\r\n\r\n#### Any background context you want to provide?\r\nCopy truncation was previously desired for Card, but after Stack (which was used by Marquee/Section (toolkit components) was merged with Card, the copy truncation behavior was still applied.\r\n\r\n#### What are the relevant issues?\r\nhttps://github.com/grommet/hpe-digitaltoolkit/issues/137\r\n\r\n#### Do the grommet docs need to be updated?\r\nYes, update Card examples with truncateCopy option.\r\n\r\n#### Is this change backwards compatible or is it a breaking change?\r\nBreaking change for previously truncated `<p>` copy in Cards."},"comment":{"url":"https://api.github.com/repos/grommet/grommet/issues/comments/250238532","html_url":"https://github.com/grommet/grommet/pull/895#issuecomment-250238532","issue_url":"https://api.github.com/repos/grommet/grommet/issues/895","id":250238532,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T17:31:07Z","updated_at":"2016-09-28T17:31:07Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8095150/badge)](https://coveralls.io/builds/8095150)\n\nCoverage increased (+0.01%) to 42.534% when pulling **eadeaf94d80b4b5de4a263f18d47f2cb679d20ba on jwijay:card-accordion** into **b7fe9eca89682b7d1bfd0ffb07f345bc0466c154 on grommet:master**.\n"}}
{"actor":{"display_login":"coveralls"}}