{"action":"created","comment":{"url":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/comments/81245769","pull_request_review_id":2240996,"id":81245769,"diff_hunk":"@@ -23,84 +23,149 @@ Dependencies\n Installation\n -----------\n \n-1. Download the python-rtmbot code\n+1. Create your project\n \n-        git clone https://github.com/slackhq/python-rtmbot.git\n-        cd python-rtmbot\n+        mkdir myproject\n+        cd myproject\n \n-2. Install dependencies ([virtualenv](http://virtualenv.readthedocs.org/en/latest/) is recommended.)\n+2. Install rtmbot (ideally into a virtualenv https://virtualenv.readthedocs.io/en/latest/)","path":"README.md","position":25,"original_position":25,"commit_id":"81f0819d21314463b614583026912bba22f90a55","original_commit_id":"81f0819d21314463b614583026912bba22f90a55","user":{"login":"jammons","id":113554,"avatar_url":"https://avatars.githubusercontent.com/u/113554?v=3","gravatar_id":"","url":"https://api.github.com/users/jammons","html_url":"https://github.com/jammons","followers_url":"https://api.github.com/users/jammons/followers","following_url":"https://api.github.com/users/jammons/following{/other_user}","gists_url":"https://api.github.com/users/jammons/gists{/gist_id}","starred_url":"https://api.github.com/users/jammons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jammons/subscriptions","organizations_url":"https://api.github.com/users/jammons/orgs","repos_url":"https://api.github.com/users/jammons/repos","events_url":"https://api.github.com/users/jammons/events{/privacy}","received_events_url":"https://api.github.com/users/jammons/received_events","type":"User","site_admin":false},"body":"✅ ","created_at":"2016-09-29T22:12:57Z","updated_at":"2016-09-29T22:12:57Z","html_url":"https://github.com/slackhq/python-rtmbot/pull/62#discussion_r81245769","pull_request_url":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/comments/81245769"},"html":{"href":"https://github.com/slackhq/python-rtmbot/pull/62#discussion_r81245769"},"pull_request":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62","id":86434328,"html_url":"https://github.com/slackhq/python-rtmbot/pull/62","diff_url":"https://github.com/slackhq/python-rtmbot/pull/62.diff","patch_url":"https://github.com/slackhq/python-rtmbot/pull/62.patch","issue_url":"https://api.github.com/repos/slackhq/python-rtmbot/issues/62","number":62,"state":"open","locked":false,"title":"Refactor the Plugin architecture to make this work as a PyPi installable package","user":{"login":"jammons","id":113554,"avatar_url":"https://avatars.githubusercontent.com/u/113554?v=3","gravatar_id":"","url":"https://api.github.com/users/jammons","html_url":"https://github.com/jammons","followers_url":"https://api.github.com/users/jammons/followers","following_url":"https://api.github.com/users/jammons/following{/other_user}","gists_url":"https://api.github.com/users/jammons/gists{/gist_id}","starred_url":"https://api.github.com/users/jammons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jammons/subscriptions","organizations_url":"https://api.github.com/users/jammons/orgs","repos_url":"https://api.github.com/users/jammons/repos","events_url":"https://api.github.com/users/jammons/events{/privacy}","received_events_url":"https://api.github.com/users/jammons/received_events","type":"User","site_admin":false},"body":"* [X] I've read and understood the [Contributing guidelines](./CONTRIBUTING.md) and have done my best effort to follow them.\r\n* [X] I've read and agree to the [Code of Conduct](./CODE_OF_CONDUCT.md).\r\n* [X] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.\r\n* [X] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).\r\n* [ :( ] I've written tests to cover the new code and functionality included in this PR.\r\n* [X] I've read, agree to, and signed the [Contributor License Agreement (CLA)](https://docs.google.com/a/slack-corp.com/forms/d/1q_w8rlJG_x_xJOoSUMNl7R35rkpA7N6pUkKhfHHMD9c/viewform).\r\n\r\n#### PR Summary\r\n> This refactors how plugins and jobs are built and loaded. This makes it possible to encapsulate the core functionality into a python package and make it available via PyPi. It also simplifies the conceptual model of plugins and makes it much easier to test them in isolation. There are a few tradeoffs in complexity that we should look at in terms of some of the method call and class object instantiation signatures.\r\n\r\nPlease give me any feedback on style, code, documentation that would be helpful in making this better!\r\n\r\n#### Test strategy\r\n> I tested this manually by starting a project from scratch and working my way through the README. I'd love another set of eyes to do so. \r\n\r\nIf you want to run this as if it's coming from PyPi, you can run `python setup.py sdist` to generate the package, then within your test project, you can run `pip install rtmbot --find-links file:///Users/path/to/python-rtmbot/dist/rtmbot-0.2.11.tar.gz` to install from the local package into your virtualenv.\r\n","created_at":"2016-09-22T23:54:00Z","updated_at":"2016-09-29T22:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b45f7fe6b69d545b24af2a10e0432c1ffae50a2d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62/commits","review_comments_url":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62/comments","review_comment_url":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slackhq/python-rtmbot/issues/62/comments","statuses_url":"https://api.github.com/repos/slackhq/python-rtmbot/statuses/81f0819d21314463b614583026912bba22f90a55","head":{"label":"jammons:plugin_refactor","ref":"plugin_refactor","sha":"81f0819d21314463b614583026912bba22f90a55","user":{"login":"jammons","id":113554,"avatar_url":"https://avatars.githubusercontent.com/u/113554?v=3","gravatar_id":"","url":"https://api.github.com/users/jammons","html_url":"https://github.com/jammons","followers_url":"https://api.github.com/users/jammons/followers","following_url":"https://api.github.com/users/jammons/following{/other_user}","gists_url":"https://api.github.com/users/jammons/gists{/gist_id}","starred_url":"https://api.github.com/users/jammons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jammons/subscriptions","organizations_url":"https://api.github.com/users/jammons/orgs","repos_url":"https://api.github.com/users/jammons/repos","events_url":"https://api.github.com/users/jammons/events{/privacy}","received_events_url":"https://api.github.com/users/jammons/received_events","type":"User","site_admin":false},"repo":{"id":56349840,"name":"python-rtmbot","full_name":"jammons/python-rtmbot","owner":{"login":"jammons","id":113554,"avatar_url":"https://avatars.githubusercontent.com/u/113554?v=3","gravatar_id":"","url":"https://api.github.com/users/jammons","html_url":"https://github.com/jammons","followers_url":"https://api.github.com/users/jammons/followers","following_url":"https://api.github.com/users/jammons/following{/other_user}","gists_url":"https://api.github.com/users/jammons/gists{/gist_id}","starred_url":"https://api.github.com/users/jammons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jammons/subscriptions","organizations_url":"https://api.github.com/users/jammons/orgs","repos_url":"https://api.github.com/users/jammons/repos","events_url":"https://api.github.com/users/jammons/events{/privacy}","received_events_url":"https://api.github.com/users/jammons/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jammons/python-rtmbot","description":"","fork":true,"url":"https://api.github.com/repos/jammons/python-rtmbot","forks_url":"https://api.github.com/repos/jammons/python-rtmbot/forks","keys_url":"https://api.github.com/repos/jammons/python-rtmbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jammons/python-rtmbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jammons/python-rtmbot/teams","hooks_url":"https://api.github.com/repos/jammons/python-rtmbot/hooks","issue_events_url":"https://api.github.com/repos/jammons/python-rtmbot/issues/events{/number}","events_url":"https://api.github.com/repos/jammons/python-rtmbot/events","assignees_url":"https://api.github.com/repos/jammons/python-rtmbot/assignees{/user}","branches_url":"https://api.github.com/repos/jammons/python-rtmbot/branches{/branch}","tags_url":"https://api.github.com/repos/jammons/python-rtmbot/tags","blobs_url":"https://api.github.com/repos/jammons/python-rtmbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jammons/python-rtmbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jammons/python-rtmbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/jammons/python-rtmbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jammons/python-rtmbot/statuses/{sha}","languages_url":"https://api.github.com/repos/jammons/python-rtmbot/languages","stargazers_url":"https://api.github.com/repos/jammons/python-rtmbot/stargazers","contributors_url":"https://api.github.com/repos/jammons/python-rtmbot/contributors","subscribers_url":"https://api.github.com/repos/jammons/python-rtmbot/subscribers","subscription_url":"https://api.github.com/repos/jammons/python-rtmbot/subscription","commits_url":"https://api.github.com/repos/jammons/python-rtmbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/jammons/python-rtmbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/jammons/python-rtmbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/jammons/python-rtmbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/jammons/python-rtmbot/contents/{+path}","compare_url":"https://api.github.com/repos/jammons/python-rtmbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jammons/python-rtmbot/merges","archive_url":"https://api.github.com/repos/jammons/python-rtmbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jammons/python-rtmbot/downloads","issues_url":"https://api.github.com/repos/jammons/python-rtmbot/issues{/number}","pulls_url":"https://api.github.com/repos/jammons/python-rtmbot/pulls{/number}","milestones_url":"https://api.github.com/repos/jammons/python-rtmbot/milestones{/number}","notifications_url":"https://api.github.com/repos/jammons/python-rtmbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jammons/python-rtmbot/labels{/name}","releases_url":"https://api.github.com/repos/jammons/python-rtmbot/releases{/id}","deployments_url":"https://api.github.com/repos/jammons/python-rtmbot/deployments","created_at":"2016-04-15T21:07:34Z","updated_at":"2016-04-15T21:07:35Z","pushed_at":"2016-09-22T23:59:43Z","git_url":"git://github.com/jammons/python-rtmbot.git","ssh_url":"git@github.com:jammons/python-rtmbot.git","clone_url":"https://github.com/jammons/python-rtmbot.git","svn_url":"https://github.com/jammons/python-rtmbot","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slackhq:master","ref":"master","sha":"cccf2b5bc53bbfd35c6c41a71832bf2457e26e00","user":{"login":"slackhq","id":6911160,"avatar_url":"https://avatars.githubusercontent.com/u/6911160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackhq","html_url":"https://github.com/slackhq","followers_url":"https://api.github.com/users/slackhq/followers","following_url":"https://api.github.com/users/slackhq/following{/other_user}","gists_url":"https://api.github.com/users/slackhq/gists{/gist_id}","starred_url":"https://api.github.com/users/slackhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackhq/subscriptions","organizations_url":"https://api.github.com/users/slackhq/orgs","repos_url":"https://api.github.com/users/slackhq/repos","events_url":"https://api.github.com/users/slackhq/events{/privacy}","received_events_url":"https://api.github.com/users/slackhq/received_events","type":"Organization","site_admin":false},"repo":{"id":26785102,"name":"python-rtmbot","full_name":"slackhq/python-rtmbot","owner":{"login":"slackhq","id":6911160,"avatar_url":"https://avatars.githubusercontent.com/u/6911160?v=3","gravatar_id":"","url":"https://api.github.com/users/slackhq","html_url":"https://github.com/slackhq","followers_url":"https://api.github.com/users/slackhq/followers","following_url":"https://api.github.com/users/slackhq/following{/other_user}","gists_url":"https://api.github.com/users/slackhq/gists{/gist_id}","starred_url":"https://api.github.com/users/slackhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slackhq/subscriptions","organizations_url":"https://api.github.com/users/slackhq/orgs","repos_url":"https://api.github.com/users/slackhq/repos","events_url":"https://api.github.com/users/slackhq/events{/privacy}","received_events_url":"https://api.github.com/users/slackhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slackhq/python-rtmbot","description":"","fork":false,"url":"https://api.github.com/repos/slackhq/python-rtmbot","forks_url":"https://api.github.com/repos/slackhq/python-rtmbot/forks","keys_url":"https://api.github.com/repos/slackhq/python-rtmbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slackhq/python-rtmbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slackhq/python-rtmbot/teams","hooks_url":"https://api.github.com/repos/slackhq/python-rtmbot/hooks","issue_events_url":"https://api.github.com/repos/slackhq/python-rtmbot/issues/events{/number}","events_url":"https://api.github.com/repos/slackhq/python-rtmbot/events","assignees_url":"https://api.github.com/repos/slackhq/python-rtmbot/assignees{/user}","branches_url":"https://api.github.com/repos/slackhq/python-rtmbot/branches{/branch}","tags_url":"https://api.github.com/repos/slackhq/python-rtmbot/tags","blobs_url":"https://api.github.com/repos/slackhq/python-rtmbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slackhq/python-rtmbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slackhq/python-rtmbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/slackhq/python-rtmbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slackhq/python-rtmbot/statuses/{sha}","languages_url":"https://api.github.com/repos/slackhq/python-rtmbot/languages","stargazers_url":"https://api.github.com/repos/slackhq/python-rtmbot/stargazers","contributors_url":"https://api.github.com/repos/slackhq/python-rtmbot/contributors","subscribers_url":"https://api.github.com/repos/slackhq/python-rtmbot/subscribers","subscription_url":"https://api.github.com/repos/slackhq/python-rtmbot/subscription","commits_url":"https://api.github.com/repos/slackhq/python-rtmbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/slackhq/python-rtmbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/slackhq/python-rtmbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/slackhq/python-rtmbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/slackhq/python-rtmbot/contents/{+path}","compare_url":"https://api.github.com/repos/slackhq/python-rtmbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slackhq/python-rtmbot/merges","archive_url":"https://api.github.com/repos/slackhq/python-rtmbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slackhq/python-rtmbot/downloads","issues_url":"https://api.github.com/repos/slackhq/python-rtmbot/issues{/number}","pulls_url":"https://api.github.com/repos/slackhq/python-rtmbot/pulls{/number}","milestones_url":"https://api.github.com/repos/slackhq/python-rtmbot/milestones{/number}","notifications_url":"https://api.github.com/repos/slackhq/python-rtmbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slackhq/python-rtmbot/labels{/name}","releases_url":"https://api.github.com/repos/slackhq/python-rtmbot/releases{/id}","deployments_url":"https://api.github.com/repos/slackhq/python-rtmbot/deployments","created_at":"2014-11-18T00:54:25Z","updated_at":"2016-09-29T19:50:17Z","pushed_at":"2016-09-22T23:59:43Z","git_url":"git://github.com/slackhq/python-rtmbot.git","ssh_url":"git@github.com:slackhq/python-rtmbot.git","clone_url":"https://github.com/slackhq/python-rtmbot.git","svn_url":"https://github.com/slackhq/python-rtmbot","homepage":null,"size":642,"stargazers_count":355,"watchers_count":355,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"open_issues_count":10,"forks":216,"open_issues":10,"watchers":355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62"},"html":{"href":"https://github.com/slackhq/python-rtmbot/pull/62"},"issue":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/issues/62"},"comments":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/slackhq/python-rtmbot/statuses/81f0819d21314463b614583026912bba22f90a55"}}}}
{"actor":{"display_login":"jammons"}}