{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/universal-search/pulls/comments/55426342","id":55426342,"diff_hunk":"@@ -41,8 +41,21 @@ textbox#urlbar {\n #universal-search-recommendation-image,\n #universal-search-recommendation-letterbox {\n   border-radius: 3px;\n+  box-shadow: inset 0 0 0 1px rgba(0, 0, 0, 0.1);\n   height: 32px;\n   margin-right: 8px;\n+  overflow: hidden;\n+  width: 32px;\n+}\n+\n+#universal-search-recommendation-logo,\n+#universal-search-recommendation-keyimage {\n+  position: relative;\n+  z-index: -1;","path":"chrome/skin/style.css","position":14,"original_position":14,"commit_id":"080a38fbfc8abc3570d2530a241855e350a2b84b","original_commit_id":"080a38fbfc8abc3570d2530a241855e350a2b84b","user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"body":"This is weird. In order for the inset shadow of the wrapper to overlay the image contained by its children, it needs to have a negative z-index. In order for z-index to apply, it needs to be relatively positioned.\r\n\r\nExample of what it allows:\r\n\r\n<img width=\"195\" alt=\"screen shot 2016-03-08 at 1 58 54 pm\" src=\"https://cloud.githubusercontent.com/assets/23885/13616189/07ba4b2c-e536-11e5-8e83-6c0d9904580b.png\">\r\n","created_at":"2016-03-08T20:59:55Z","updated_at":"2016-03-08T20:59:55Z","html_url":"https://github.com/mozilla/universal-search/pull/74#discussion_r55426342","pull_request_url":"https://api.github.com/repos/mozilla/universal-search/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/mozilla/universal-search/pulls/comments/55426342"},"html":{"href":"https://github.com/mozilla/universal-search/pull/74#discussion_r55426342"},"pull_request":{"href":"https://api.github.com/repos/mozilla/universal-search/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/universal-search/pulls/74","id":62112586,"html_url":"https://github.com/mozilla/universal-search/pull/74","diff_url":"https://github.com/mozilla/universal-search/pull/74.diff","patch_url":"https://github.com/mozilla/universal-search/pull/74.patch","issue_url":"https://api.github.com/repos/mozilla/universal-search/issues/74","number":74,"state":"open","locked":false,"title":"Refactors construction and styling of injected recommendation (closes #5):","user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"body":"* Handles errors on any images.\r\n* Uses the Clearbit logo, if available, before falling back to a key image from Embedly and finally a letterbox.\r\n* Gracefully handles all feasible cases of missing data.\r\n* Moves recommendation templating to a separate module.\r\n\r\nr? @6a68 ","created_at":"2016-03-08T18:17:58Z","updated_at":"2016-03-08T20:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baf625b0aba6df69b94b6445662e92fed3d68d90","assignee":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mozilla/universal-search/milestones/1","html_url":"https://github.com/mozilla/universal-search/milestones/Test%20Pilot%20launch","labels_url":"https://api.github.com/repos/mozilla/universal-search/milestones/1/labels","id":1575466,"number":1,"title":"Test Pilot launch","description":"","creator":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":26,"state":"open","created_at":"2016-02-10T18:35:16Z","updated_at":"2016-03-08T18:17:58Z","due_on":"2016-03-15T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mozilla/universal-search/pulls/74/commits","review_comments_url":"https://api.github.com/repos/mozilla/universal-search/pulls/74/comments","review_comment_url":"https://api.github.com/repos/mozilla/universal-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/universal-search/issues/74/comments","statuses_url":"https://api.github.com/repos/mozilla/universal-search/statuses/080a38fbfc8abc3570d2530a241855e350a2b84b","head":{"label":"chuckharmston:5-refactor-style","ref":"5-refactor-style","sha":"080a38fbfc8abc3570d2530a241855e350a2b84b","user":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"repo":{"id":51524058,"name":"universal-search","full_name":"chuckharmston/universal-search","owner":{"login":"chuckharmston","id":23885,"avatar_url":"https://avatars.githubusercontent.com/u/23885?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckharmston","html_url":"https://github.com/chuckharmston","followers_url":"https://api.github.com/users/chuckharmston/followers","following_url":"https://api.github.com/users/chuckharmston/following{/other_user}","gists_url":"https://api.github.com/users/chuckharmston/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckharmston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckharmston/subscriptions","organizations_url":"https://api.github.com/users/chuckharmston/orgs","repos_url":"https://api.github.com/users/chuckharmston/repos","events_url":"https://api.github.com/users/chuckharmston/events{/privacy}","received_events_url":"https://api.github.com/users/chuckharmston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuckharmston/universal-search","description":"","fork":true,"url":"https://api.github.com/repos/chuckharmston/universal-search","forks_url":"https://api.github.com/repos/chuckharmston/universal-search/forks","keys_url":"https://api.github.com/repos/chuckharmston/universal-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuckharmston/universal-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuckharmston/universal-search/teams","hooks_url":"https://api.github.com/repos/chuckharmston/universal-search/hooks","issue_events_url":"https://api.github.com/repos/chuckharmston/universal-search/issues/events{/number}","events_url":"https://api.github.com/repos/chuckharmston/universal-search/events","assignees_url":"https://api.github.com/repos/chuckharmston/universal-search/assignees{/user}","branches_url":"https://api.github.com/repos/chuckharmston/universal-search/branches{/branch}","tags_url":"https://api.github.com/repos/chuckharmston/universal-search/tags","blobs_url":"https://api.github.com/repos/chuckharmston/universal-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuckharmston/universal-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuckharmston/universal-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuckharmston/universal-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuckharmston/universal-search/statuses/{sha}","languages_url":"https://api.github.com/repos/chuckharmston/universal-search/languages","stargazers_url":"https://api.github.com/repos/chuckharmston/universal-search/stargazers","contributors_url":"https://api.github.com/repos/chuckharmston/universal-search/contributors","subscribers_url":"https://api.github.com/repos/chuckharmston/universal-search/subscribers","subscription_url":"https://api.github.com/repos/chuckharmston/universal-search/subscription","commits_url":"https://api.github.com/repos/chuckharmston/universal-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuckharmston/universal-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuckharmston/universal-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuckharmston/universal-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/chuckharmston/universal-search/contents/{+path}","compare_url":"https://api.github.com/repos/chuckharmston/universal-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuckharmston/universal-search/merges","archive_url":"https://api.github.com/repos/chuckharmston/universal-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuckharmston/universal-search/downloads","issues_url":"https://api.github.com/repos/chuckharmston/universal-search/issues{/number}","pulls_url":"https://api.github.com/repos/chuckharmston/universal-search/pulls{/number}","milestones_url":"https://api.github.com/repos/chuckharmston/universal-search/milestones{/number}","notifications_url":"https://api.github.com/repos/chuckharmston/universal-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuckharmston/universal-search/labels{/name}","releases_url":"https://api.github.com/repos/chuckharmston/universal-search/releases{/id}","deployments_url":"https://api.github.com/repos/chuckharmston/universal-search/deployments","created_at":"2016-02-11T15:30:01Z","updated_at":"2016-02-11T15:30:02Z","pushed_at":"2016-03-08T20:57:55Z","git_url":"git://github.com/chuckharmston/universal-search.git","ssh_url":"git@github.com:chuckharmston/universal-search.git","clone_url":"https://github.com/chuckharmston/universal-search.git","svn_url":"https://github.com/chuckharmston/universal-search","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"6f7e852320b9d2f7da973e492543de18c1166cc4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50941242,"name":"universal-search","full_name":"mozilla/universal-search","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/universal-search","description":"Test Pilot add-on that inserts server recommendations into the Awesome Bar","fork":false,"url":"https://api.github.com/repos/mozilla/universal-search","forks_url":"https://api.github.com/repos/mozilla/universal-search/forks","keys_url":"https://api.github.com/repos/mozilla/universal-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/universal-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/universal-search/teams","hooks_url":"https://api.github.com/repos/mozilla/universal-search/hooks","issue_events_url":"https://api.github.com/repos/mozilla/universal-search/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/universal-search/events","assignees_url":"https://api.github.com/repos/mozilla/universal-search/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/universal-search/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/universal-search/tags","blobs_url":"https://api.github.com/repos/mozilla/universal-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/universal-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/universal-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/universal-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/universal-search/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/universal-search/languages","stargazers_url":"https://api.github.com/repos/mozilla/universal-search/stargazers","contributors_url":"https://api.github.com/repos/mozilla/universal-search/contributors","subscribers_url":"https://api.github.com/repos/mozilla/universal-search/subscribers","subscription_url":"https://api.github.com/repos/mozilla/universal-search/subscription","commits_url":"https://api.github.com/repos/mozilla/universal-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/universal-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/universal-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/universal-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/universal-search/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/universal-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/universal-search/merges","archive_url":"https://api.github.com/repos/mozilla/universal-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/universal-search/downloads","issues_url":"https://api.github.com/repos/mozilla/universal-search/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/universal-search/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/universal-search/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/universal-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/universal-search/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/universal-search/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/universal-search/deployments","created_at":"2016-02-02T18:16:02Z","updated_at":"2016-03-02T18:00:39Z","pushed_at":"2016-03-08T20:57:55Z","git_url":"git://github.com/mozilla/universal-search.git","ssh_url":"git@github.com:mozilla/universal-search.git","clone_url":"https://github.com/mozilla/universal-search.git","svn_url":"https://github.com/mozilla/universal-search","homepage":"https://wiki.mozilla.org/Firefox/Universal_Search","size":68,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":22,"forks":4,"open_issues":22,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/universal-search/pulls/74"},"html":{"href":"https://github.com/mozilla/universal-search/pull/74"},"issue":{"href":"https://api.github.com/repos/mozilla/universal-search/issues/74"},"comments":{"href":"https://api.github.com/repos/mozilla/universal-search/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/universal-search/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/universal-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/universal-search/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/universal-search/statuses/080a38fbfc8abc3570d2530a241855e350a2b84b"}}}}