{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12645","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12645/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12645/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12645/events","html_url":"https://github.com/ManageIQ/manageiq/pull/12645","id":189412561,"number":12645,"title":"[WIP] Orchestration stack naming in case of VMware","user":{"login":"aiperon","id":435679,"avatar_url":"https://avatars.githubusercontent.com/u/435679?v=3","gravatar_id":"","url":"https://api.github.com/users/aiperon","html_url":"https://github.com/aiperon","followers_url":"https://api.github.com/users/aiperon/followers","following_url":"https://api.github.com/users/aiperon/following{/other_user}","gists_url":"https://api.github.com/users/aiperon/gists{/gist_id}","starred_url":"https://api.github.com/users/aiperon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiperon/subscriptions","organizations_url":"https://api.github.com/users/aiperon/orgs","repos_url":"https://api.github.com/users/aiperon/repos","events_url":"https://api.github.com/users/aiperon/events{/privacy}","received_events_url":"https://api.github.com/users/aiperon/received_events","type":"User","site_admin":false},"labels":[{"id":397449636,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/vmware/cloud","name":"providers/vmware/cloud","color":"5319e7","default":false},{"id":182909575,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7","default":false},{"id":176168677,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"assignees":[{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-11-15T14:53:21Z","updated_at":"2016-11-29T21:57:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12645","html_url":"https://github.com/ManageIQ/manageiq/pull/12645","diff_url":"https://github.com/ManageIQ/manageiq/pull/12645.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/12645.patch"},"body":"Each provider should use its own terminology if only a single provider is used. In case of VMware only provider, Stack should be called vApp.\r\nI've implemented it in a way how similar logic was introduced for OpenStack:\r\nhttps://github.com/ManageIQ/manageiq/pull/2708 Model methods to determine host/clusters types.\r\nhttps://github.com/ManageIQ/manageiq/pull/2762 Changes to display appropriate Host/Cluster titles in UI.\r\nhttps://github.com/ManageIQ/manageiq/pull/2764 Menu items changing names on show time for infra.\r\n\r\nOpen questions:\r\n1. Is it still the right way how to do things?\r\n2. Which part of application shouldn't be changed?\r\n\r\n@dclarizio @martinpovolny please review.\r\n\r\n**Compute->Clouds->Providers section**\r\nBefore: \r\n![before_vapp1](https://cloud.githubusercontent.com/assets/435679/20397412/e7ce4ecc-ace9-11e6-99f3-edb8c904c452.png)\r\nAfter:\r\n![vapp1](https://cloud.githubusercontent.com/assets/435679/20397458/193c356e-acea-11e6-82ea-799f91076abe.png)\r\n\r\n\r\n**Compute->Clouds sub-menu**\r\nBefore:\r\n![before_vapp2](https://cloud.githubusercontent.com/assets/435679/20397489/3309a04e-acea-11e6-8f18-af6bc274f833.png)\r\nAfter:\r\n![vapp2](https://cloud.githubusercontent.com/assets/435679/20397494/386482fc-acea-11e6-9816-44086093775c.png)\r\n\r\n**Compute->Clouds->Stacks(vApps) section**\r\nBefore:\r\n![before_vapp4](https://cloud.githubusercontent.com/assets/435679/20397553/6ff0ed28-acea-11e6-8b93-5559aa95f86e.png)\r\nAfter:\r\n![vapp4](https://cloud.githubusercontent.com/assets/435679/20397562/773129ae-acea-11e6-844c-2a8b53802a95.png)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/263712701","html_url":"https://github.com/ManageIQ/manageiq/pull/12645#issuecomment-263712701","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12645","id":263712701,"user":{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T21:57:55Z","updated_at":"2016-11-29T21:57:55Z","body":"> @dclarizio can you see if someone can help with this?\r\n\r\nHaving @h-kataria take a look as she did some of the others.  Wondering if the nav menus might need to show both names if both types of providers are in the DB."}}
{"actor":{"display_login":"dclarizio"}}