{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/comments/73060433","id":73060433,"diff_hunk":"@@ -0,0 +1,220 @@\n+﻿<#\n+.SYNOPSIS ","path":"host/ProtocolGateway.Host.Fabric/Scripts/Deploy-FabricApplication.ps1","position":2,"original_position":2,"commit_id":"42afaf2a3d093622636102568454ec69c4f480d6","original_commit_id":"42afaf2a3d093622636102568454ec69c4f480d6","user":{"login":"nayato","id":818017,"avatar_url":"https://avatars.githubusercontent.com/u/818017?v=3","gravatar_id":"","url":"https://api.github.com/users/nayato","html_url":"https://github.com/nayato","followers_url":"https://api.github.com/users/nayato/followers","following_url":"https://api.github.com/users/nayato/following{/other_user}","gists_url":"https://api.github.com/users/nayato/gists{/gist_id}","starred_url":"https://api.github.com/users/nayato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nayato/subscriptions","organizations_url":"https://api.github.com/users/nayato/orgs","repos_url":"https://api.github.com/users/nayato/repos","events_url":"https://api.github.com/users/nayato/events{/privacy}","received_events_url":"https://api.github.com/users/nayato/received_events","type":"User","site_admin":false},"body":">SYNOPSIS [](start = 1, length = 8)\r\n\r\nWould be nice to have SF host deployment instructions in README","created_at":"2016-08-01T21:55:04Z","updated_at":"2016-08-01T21:55:04Z","html_url":"https://github.com/Azure/azure-iot-protocol-gateway/pull/58#discussion_r73060433","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/comments/73060433"},"html":{"href":"https://github.com/Azure/azure-iot-protocol-gateway/pull/58#discussion_r73060433"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58","id":79056225,"html_url":"https://github.com/Azure/azure-iot-protocol-gateway/pull/58","diff_url":"https://github.com/Azure/azure-iot-protocol-gateway/pull/58.diff","patch_url":"https://github.com/Azure/azure-iot-protocol-gateway/pull/58.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/issues/58","number":58,"state":"open","locked":false,"title":"Pull request for team to review layout, direction etc.","user":{"login":"chrisgclayton","id":1773754,"avatar_url":"https://avatars.githubusercontent.com/u/1773754?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisgclayton","html_url":"https://github.com/chrisgclayton","followers_url":"https://api.github.com/users/chrisgclayton/followers","following_url":"https://api.github.com/users/chrisgclayton/following{/other_user}","gists_url":"https://api.github.com/users/chrisgclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgclayton/subscriptions","organizations_url":"https://api.github.com/users/chrisgclayton/orgs","repos_url":"https://api.github.com/users/chrisgclayton/repos","events_url":"https://api.github.com/users/chrisgclayton/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgclayton/received_events","type":"User","site_admin":false},"body":"Please take a look at this and let me know if it aligns with your direction. I tried to use the coding style of the previous gateway code. A few of the things that I did change that are a larger impact include (and we may not want to but to develop in VS 2015 I had to and for SF updates)\r\n\r\n- Updated with Azure 2.9 (2.6 is not supported in 2015)\r\n- Changed to 64 bit architecture\r\n- Only a couple changes were made outside of the Host projects including template support for List<string> etc. as the app.config will not be used in preference of SF config settings\r\n- I removed the NUGET usage in the host to make sure I had the most recent, if general approach is agreed to the NUGET use can be reintroduced with the newer code\r\n- Goal was to change as little outside the host as possible\r\n\r\n","created_at":"2016-07-27T16:32:10Z","updated_at":"2016-08-01T21:55:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6706b4c36c740e78ba71697cc0f3e11090031a7e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/issues/58/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/statuses/42afaf2a3d093622636102568454ec69c4f480d6","head":{"label":"chrisgclayton:master","ref":"master","sha":"42afaf2a3d093622636102568454ec69c4f480d6","user":{"login":"chrisgclayton","id":1773754,"avatar_url":"https://avatars.githubusercontent.com/u/1773754?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisgclayton","html_url":"https://github.com/chrisgclayton","followers_url":"https://api.github.com/users/chrisgclayton/followers","following_url":"https://api.github.com/users/chrisgclayton/following{/other_user}","gists_url":"https://api.github.com/users/chrisgclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgclayton/subscriptions","organizations_url":"https://api.github.com/users/chrisgclayton/orgs","repos_url":"https://api.github.com/users/chrisgclayton/repos","events_url":"https://api.github.com/users/chrisgclayton/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgclayton/received_events","type":"User","site_admin":false},"repo":{"id":64244867,"name":"azure-iot-protocol-gateway","full_name":"chrisgclayton/azure-iot-protocol-gateway","owner":{"login":"chrisgclayton","id":1773754,"avatar_url":"https://avatars.githubusercontent.com/u/1773754?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisgclayton","html_url":"https://github.com/chrisgclayton","followers_url":"https://api.github.com/users/chrisgclayton/followers","following_url":"https://api.github.com/users/chrisgclayton/following{/other_user}","gists_url":"https://api.github.com/users/chrisgclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgclayton/subscriptions","organizations_url":"https://api.github.com/users/chrisgclayton/orgs","repos_url":"https://api.github.com/users/chrisgclayton/repos","events_url":"https://api.github.com/users/chrisgclayton/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgclayton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisgclayton/azure-iot-protocol-gateway","description":"Azure IoT protocol gateway enables protocol translation for Azure IoT Hub","fork":true,"url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway","forks_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/forks","keys_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/teams","hooks_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/hooks","issue_events_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/events","assignees_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/tags","blobs_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/languages","stargazers_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/stargazers","contributors_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/contributors","subscribers_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/subscribers","subscription_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/subscription","commits_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/merges","archive_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/downloads","issues_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/labels{/name}","releases_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/chrisgclayton/azure-iot-protocol-gateway/deployments","created_at":"2016-07-26T18:28:16Z","updated_at":"2016-07-26T18:28:18Z","pushed_at":"2016-08-01T14:29:32Z","git_url":"git://github.com/chrisgclayton/azure-iot-protocol-gateway.git","ssh_url":"git@github.com:chrisgclayton/azure-iot-protocol-gateway.git","clone_url":"https://github.com/chrisgclayton/azure-iot-protocol-gateway.git","svn_url":"https://github.com/chrisgclayton/azure-iot-protocol-gateway","homepage":null,"size":5518,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"85d6d504cf1d7dba9e3cf1c703151119f9fd1a97","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":31940017,"name":"azure-iot-protocol-gateway","full_name":"Azure/azure-iot-protocol-gateway","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-protocol-gateway","description":"Azure IoT protocol gateway enables protocol translation for Azure IoT Hub","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway","forks_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/deployments","created_at":"2015-03-10T05:25:08Z","updated_at":"2016-08-01T17:44:35Z","pushed_at":"2016-08-01T14:29:32Z","git_url":"git://github.com/Azure/azure-iot-protocol-gateway.git","ssh_url":"git@github.com:Azure/azure-iot-protocol-gateway.git","clone_url":"https://github.com/Azure/azure-iot-protocol-gateway.git","svn_url":"https://github.com/Azure/azure-iot-protocol-gateway","homepage":null,"size":447,"stargazers_count":72,"watchers_count":72,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":9,"forks":41,"open_issues":9,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58"},"html":{"href":"https://github.com/Azure/azure-iot-protocol-gateway/pull/58"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/issues/58"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-protocol-gateway/statuses/42afaf2a3d093622636102568454ec69c4f480d6"}}}}
{"actor":{"display_login":"nayato"}}