{"action":"created","issue":{"url":"https://api.github.com/repos/HPCE/hpce-2016-cw1/issues/3","repository_url":"https://api.github.com/repos/HPCE/hpce-2016-cw1","labels_url":"https://api.github.com/repos/HPCE/hpce-2016-cw1/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/HPCE/hpce-2016-cw1/issues/3/comments","events_url":"https://api.github.com/repos/HPCE/hpce-2016-cw1/issues/3/events","html_url":"https://github.com/HPCE/hpce-2016-cw1/issues/3","id":182163593,"number":3,"title":"Undeclared 'juliaFrameRender_ParallelBoth'","user":{"login":"OJFord","id":3946014,"avatar_url":"https://avatars.githubusercontent.com/u/3946014?v=3","gravatar_id":"","url":"https://api.github.com/users/OJFord","html_url":"https://github.com/OJFord","followers_url":"https://api.github.com/users/OJFord/followers","following_url":"https://api.github.com/users/OJFord/following{/other_user}","gists_url":"https://api.github.com/users/OJFord/gists{/gist_id}","starred_url":"https://api.github.com/users/OJFord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJFord/subscriptions","organizations_url":"https://api.github.com/users/OJFord/orgs","repos_url":"https://api.github.com/users/OJFord/repos","events_url":"https://api.github.com/users/OJFord/events{/privacy}","received_events_url":"https://api.github.com/users/OJFord/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-11T03:13:43Z","updated_at":"2016-10-11T04:02:29Z","closed_at":"2016-10-11T04:02:29Z","body":"During the first step, `make bin/julia`:\r\n```sh\r\nc++ -o bin/julia -W -Wall -std=c++11 -Wno-unused-parameter -I include -pthread src/julia_frame_reference.cpp src/julia_frame_parallel_inner.cpp src/julia_frame_parallel_outer.cpp src/julia_frame_parallel_both.cpp src/julia_driver.cpp  \r\nsrc/julia_driver.cpp:283:29: error: use of undeclared identifier 'juliaFrameRender_ParallelBoth'; did you mean 'juliaFrameRender_ParallelOuter'?\r\n                juliaEngine=juliaFrameRender_ParallelBoth;\r\n                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n                            juliaFrameRender_ParallelOuter\r\ninclude/julia.hpp:51:6: note: 'juliaFrameRender_ParallelOuter' declared here\r\nvoid juliaFrameRender_ParallelOuter(\r\n     ^\r\n1 error generated.\r\nmake: *** [bin/julia] Error 1\r\n```\r\n\r\nSince the implementation of this appears as a later task, I tried removing it:\r\n```diff\r\nindex 5089200..1e303bc 100644\r\n--- a/src/julia_driver.cpp\r\n+++ b/src/julia_driver.cpp\r\n@@ -280,7 +280,7 @@ int main(int argc, char *argv[])\r\n             }else if(!strcmp(argv[ai+1], \"parallel_outer\")){\r\n                 juliaEngine=juliaFrameRender_ParallelOuter;\r\n                 }else if(!strcmp(argv[ai+1], \"parallel_both\")){\r\n-                juliaEngine=juliaFrameRender_ParallelBoth;\r\n+                //juliaEngine=juliaFrameRender_ParallelBoth;\r\n             }else{\r\n                 fprintf(stderr, \"Uknown argument to -engine : '%s'\\n\", argv[ai+1]);\r\n                 exit(1);\r\n```\r\nwhich was successful.\r\n\r\n(`echo $above_patch | git apply`.)"},"comment":{"url":"https://api.github.com/repos/HPCE/hpce-2016-cw1/issues/comments/252805986","html_url":"https://github.com/HPCE/hpce-2016-cw1/issues/3#issuecomment-252805986","issue_url":"https://api.github.com/repos/HPCE/hpce-2016-cw1/issues/3","id":252805986,"user":{"login":"OJFord","id":3946014,"avatar_url":"https://avatars.githubusercontent.com/u/3946014?v=3","gravatar_id":"","url":"https://api.github.com/users/OJFord","html_url":"https://github.com/OJFord","followers_url":"https://api.github.com/users/OJFord/followers","following_url":"https://api.github.com/users/OJFord/following{/other_user}","gists_url":"https://api.github.com/users/OJFord/gists{/gist_id}","starred_url":"https://api.github.com/users/OJFord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJFord/subscriptions","organizations_url":"https://api.github.com/users/OJFord/orgs","repos_url":"https://api.github.com/users/OJFord/repos","events_url":"https://api.github.com/users/OJFord/events{/privacy}","received_events_url":"https://api.github.com/users/OJFord/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T04:02:29Z","updated_at":"2016-10-11T04:02:29Z","body":"Oops, duplicate of #1. (And the solution there of adding to header file is better than pretending the problem doesn't exist per above 😆 .)"}}
{"actor":{"display_login":"OJFord"}}