{"action":"created","comment":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/94234071","pull_request_review_id":14764505,"id":94234071,"diff_hunk":"@@ -53,10 +49,9 @@ defmodule Thrift.Protocols.Binary do\n   def serialize(_, nil) do\n     []\n   end","path":"lib/thrift/protocols/binary.ex","position":14,"original_position":14,"commit_id":"c6ed05c15a6030c5caa20f90449ea5effa443dae","original_commit_id":"c6ed05c15a6030c5caa20f90449ea5effa443dae","user":{"login":"pguillory","id":304366,"avatar_url":"https://avatars.githubusercontent.com/u/304366?v=3","gravatar_id":"","url":"https://api.github.com/users/pguillory","html_url":"https://github.com/pguillory","followers_url":"https://api.github.com/users/pguillory/followers","following_url":"https://api.github.com/users/pguillory/following{/other_user}","gists_url":"https://api.github.com/users/pguillory/gists{/gist_id}","starred_url":"https://api.github.com/users/pguillory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguillory/subscriptions","organizations_url":"https://api.github.com/users/pguillory/orgs","repos_url":"https://api.github.com/users/pguillory/repos","events_url":"https://api.github.com/users/pguillory/events{/privacy}","received_events_url":"https://api.github.com/users/pguillory/received_events","type":"User","site_admin":false},"body":"This clause should not exist. The way we serialize nil depends on its context.","created_at":"2016-12-30T15:10:06Z","updated_at":"2016-12-30T15:21:00Z","html_url":"https://github.com/pinterest/elixir-thrift/pull/104#discussion_r94234071","pull_request_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/94234071"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/104#discussion_r94234071"},"pull_request":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104","id":99719375,"html_url":"https://github.com/pinterest/elixir-thrift/pull/104","diff_url":"https://github.com/pinterest/elixir-thrift/pull/104.diff","patch_url":"https://github.com/pinterest/elixir-thrift/pull/104.patch","issue_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/104","number":104,"state":"open","locked":false,"title":"Use pattern matching to serialize bool values","user":{"login":"jparise","id":10311,"avatar_url":"https://avatars.githubusercontent.com/u/10311?v=3","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"body":"This eliminates the private bool_to_int/1 function and lets us return\r\nconstant binary result values directly.\r\n\r\nThere is a nominal performance improvement, but nothing significant.","created_at":"2016-12-30T03:24:03Z","updated_at":"2016-12-30T15:21:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"249fdc94ee3995e5d388fcda50c56b10606c8f58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104/commits","review_comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104/comments","review_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/104/comments","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/c6ed05c15a6030c5caa20f90449ea5effa443dae","head":{"label":"jparise:serialize-bool","ref":"serialize-bool","sha":"c6ed05c15a6030c5caa20f90449ea5effa443dae","user":{"login":"jparise","id":10311,"avatar_url":"https://avatars.githubusercontent.com/u/10311?v=3","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"repo":{"id":71505731,"name":"elixir-thrift","full_name":"jparise/elixir-thrift","owner":{"login":"jparise","id":10311,"avatar_url":"https://avatars.githubusercontent.com/u/10311?v=3","gravatar_id":"","url":"https://api.github.com/users/jparise","html_url":"https://github.com/jparise","followers_url":"https://api.github.com/users/jparise/followers","following_url":"https://api.github.com/users/jparise/following{/other_user}","gists_url":"https://api.github.com/users/jparise/gists{/gist_id}","starred_url":"https://api.github.com/users/jparise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jparise/subscriptions","organizations_url":"https://api.github.com/users/jparise/orgs","repos_url":"https://api.github.com/users/jparise/repos","events_url":"https://api.github.com/users/jparise/events{/privacy}","received_events_url":"https://api.github.com/users/jparise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jparise/elixir-thrift","description":"Thrift Utilities for Elixir","fork":true,"url":"https://api.github.com/repos/jparise/elixir-thrift","forks_url":"https://api.github.com/repos/jparise/elixir-thrift/forks","keys_url":"https://api.github.com/repos/jparise/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jparise/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jparise/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/jparise/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/jparise/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/jparise/elixir-thrift/events","assignees_url":"https://api.github.com/repos/jparise/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/jparise/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/jparise/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/jparise/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jparise/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jparise/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jparise/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jparise/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/jparise/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/jparise/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/jparise/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/jparise/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/jparise/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/jparise/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jparise/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jparise/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jparise/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jparise/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/jparise/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jparise/elixir-thrift/merges","archive_url":"https://api.github.com/repos/jparise/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jparise/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/jparise/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/jparise/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/jparise/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/jparise/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jparise/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/jparise/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/jparise/elixir-thrift/deployments","created_at":"2016-10-20T21:26:23Z","updated_at":"2016-12-09T19:17:34Z","pushed_at":"2016-12-30T15:04:48Z","git_url":"git://github.com/jparise/elixir-thrift.git","ssh_url":"git@github.com:jparise/elixir-thrift.git","clone_url":"https://github.com/jparise/elixir-thrift.git","svn_url":"https://github.com/jparise/elixir-thrift","homepage":"https://hexdocs.pm/thrift/","size":234,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pinterest:thrift_tng","ref":"thrift_tng","sha":"ed0ee43c1dfc995966f3aef59fe5889692d02331","user":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"repo":{"id":43914111,"name":"elixir-thrift","full_name":"pinterest/elixir-thrift","owner":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pinterest/elixir-thrift","description":"Thrift Utilities for Elixir","fork":false,"url":"https://api.github.com/repos/pinterest/elixir-thrift","forks_url":"https://api.github.com/repos/pinterest/elixir-thrift/forks","keys_url":"https://api.github.com/repos/pinterest/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinterest/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinterest/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/pinterest/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/pinterest/elixir-thrift/events","assignees_url":"https://api.github.com/repos/pinterest/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/pinterest/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/pinterest/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/pinterest/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/pinterest/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinterest/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/pinterest/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinterest/elixir-thrift/merges","archive_url":"https://api.github.com/repos/pinterest/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinterest/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/pinterest/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/pinterest/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinterest/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/pinterest/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/pinterest/elixir-thrift/deployments","created_at":"2015-10-08T20:17:30Z","updated_at":"2016-12-19T20:27:29Z","pushed_at":"2016-12-30T05:58:54Z","git_url":"git://github.com/pinterest/elixir-thrift.git","ssh_url":"git@github.com:pinterest/elixir-thrift.git","clone_url":"https://github.com/pinterest/elixir-thrift.git","svn_url":"https://github.com/pinterest/elixir-thrift","homepage":"https://hexdocs.pm/thrift/","size":232,"stargazers_count":36,"watchers_count":36,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/104"},"issue":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/104"},"comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/c6ed05c15a6030c5caa20f90449ea5effa443dae"}}}}
{"actor":{"display_login":"pguillory"}}