{"action":"closed","number":4963,"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4963","id":55970054,"html_url":"https://github.com/angular-ui/ui-grid/pull/4963","diff_url":"https://github.com/angular-ui/ui-grid/pull/4963.diff","patch_url":"https://github.com/angular-ui/ui-grid/pull/4963.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/4963","number":4963,"state":"closed","locked":false,"title":"fix(core): Fix watcher handler columnDefs assignment","user":{"login":"mattslocum","id":2158161,"avatar_url":"https://avatars.githubusercontent.com/u/2158161?v=3","gravatar_id":"","url":"https://api.github.com/users/mattslocum","html_url":"https://github.com/mattslocum","followers_url":"https://api.github.com/users/mattslocum/followers","following_url":"https://api.github.com/users/mattslocum/following{/other_user}","gists_url":"https://api.github.com/users/mattslocum/gists{/gist_id}","starred_url":"https://api.github.com/users/mattslocum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattslocum/subscriptions","organizations_url":"https://api.github.com/users/mattslocum/orgs","repos_url":"https://api.github.com/users/mattslocum/repos","events_url":"https://api.github.com/users/mattslocum/events{/privacy}","received_events_url":"https://api.github.com/users/mattslocum/received_events","type":"User","site_admin":false},"body":"If you want to use fastWatch:true for data and columnDefs then the $watch handler needs to work with both fastWatch:true and false (or undefined). When mapping the incoming columnDefs with the internal columnDefs, always use what is on $scope instead of what the watcher is watching because the watcher is watching different things in the two different cases.\r\n\r\nhttps://github.com/angular-ui/ui-grid/issues/3755","created_at":"2016-01-13T23:06:11Z","updated_at":"2016-01-22T00:53:44Z","closed_at":"2016-01-22T00:53:44Z","merged_at":"2016-01-22T00:53:44Z","merge_commit_sha":"55be8687775b500b0afdddf0a301977809a11f69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4963/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4963/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/4963/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-grid/statuses/33da5f080260cbcff776c31a5535f8bb557c67ec","head":{"label":"mattslocum:patch-1","ref":"patch-1","sha":"33da5f080260cbcff776c31a5535f8bb557c67ec","user":{"login":"mattslocum","id":2158161,"avatar_url":"https://avatars.githubusercontent.com/u/2158161?v=3","gravatar_id":"","url":"https://api.github.com/users/mattslocum","html_url":"https://github.com/mattslocum","followers_url":"https://api.github.com/users/mattslocum/followers","following_url":"https://api.github.com/users/mattslocum/following{/other_user}","gists_url":"https://api.github.com/users/mattslocum/gists{/gist_id}","starred_url":"https://api.github.com/users/mattslocum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattslocum/subscriptions","organizations_url":"https://api.github.com/users/mattslocum/orgs","repos_url":"https://api.github.com/users/mattslocum/repos","events_url":"https://api.github.com/users/mattslocum/events{/privacy}","received_events_url":"https://api.github.com/users/mattslocum/received_events","type":"User","site_admin":false},"repo":{"id":49600223,"name":"ui-grid","full_name":"mattslocum/ui-grid","owner":{"login":"mattslocum","id":2158161,"avatar_url":"https://avatars.githubusercontent.com/u/2158161?v=3","gravatar_id":"","url":"https://api.github.com/users/mattslocum","html_url":"https://github.com/mattslocum","followers_url":"https://api.github.com/users/mattslocum/followers","following_url":"https://api.github.com/users/mattslocum/following{/other_user}","gists_url":"https://api.github.com/users/mattslocum/gists{/gist_id}","starred_url":"https://api.github.com/users/mattslocum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattslocum/subscriptions","organizations_url":"https://api.github.com/users/mattslocum/orgs","repos_url":"https://api.github.com/users/mattslocum/repos","events_url":"https://api.github.com/users/mattslocum/events{/privacy}","received_events_url":"https://api.github.com/users/mattslocum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattslocum/ui-grid","description":"UI Grid: an Angular Data Grid","fork":true,"url":"https://api.github.com/repos/mattslocum/ui-grid","forks_url":"https://api.github.com/repos/mattslocum/ui-grid/forks","keys_url":"https://api.github.com/repos/mattslocum/ui-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattslocum/ui-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattslocum/ui-grid/teams","hooks_url":"https://api.github.com/repos/mattslocum/ui-grid/hooks","issue_events_url":"https://api.github.com/repos/mattslocum/ui-grid/issues/events{/number}","events_url":"https://api.github.com/repos/mattslocum/ui-grid/events","assignees_url":"https://api.github.com/repos/mattslocum/ui-grid/assignees{/user}","branches_url":"https://api.github.com/repos/mattslocum/ui-grid/branches{/branch}","tags_url":"https://api.github.com/repos/mattslocum/ui-grid/tags","blobs_url":"https://api.github.com/repos/mattslocum/ui-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattslocum/ui-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattslocum/ui-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattslocum/ui-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattslocum/ui-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/mattslocum/ui-grid/languages","stargazers_url":"https://api.github.com/repos/mattslocum/ui-grid/stargazers","contributors_url":"https://api.github.com/repos/mattslocum/ui-grid/contributors","subscribers_url":"https://api.github.com/repos/mattslocum/ui-grid/subscribers","subscription_url":"https://api.github.com/repos/mattslocum/ui-grid/subscription","commits_url":"https://api.github.com/repos/mattslocum/ui-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattslocum/ui-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattslocum/ui-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattslocum/ui-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattslocum/ui-grid/contents/{+path}","compare_url":"https://api.github.com/repos/mattslocum/ui-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattslocum/ui-grid/merges","archive_url":"https://api.github.com/repos/mattslocum/ui-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattslocum/ui-grid/downloads","issues_url":"https://api.github.com/repos/mattslocum/ui-grid/issues{/number}","pulls_url":"https://api.github.com/repos/mattslocum/ui-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/mattslocum/ui-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/mattslocum/ui-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattslocum/ui-grid/labels{/name}","releases_url":"https://api.github.com/repos/mattslocum/ui-grid/releases{/id}","deployments_url":"https://api.github.com/repos/mattslocum/ui-grid/deployments","created_at":"2016-01-13T20:35:37Z","updated_at":"2016-01-13T20:35:39Z","pushed_at":"2016-01-13T23:05:45Z","git_url":"git://github.com/mattslocum/ui-grid.git","ssh_url":"git@github.com:mattslocum/ui-grid.git","clone_url":"https://github.com/mattslocum/ui-grid.git","svn_url":"https://github.com/mattslocum/ui-grid","homepage":"http://ui-grid.info","size":15633,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"6032ac0bac9a114cf04c730a03108f6cd39ce6ad","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6198699,"name":"ui-grid","full_name":"angular-ui/ui-grid","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-grid","description":"UI Grid: an Angular Data Grid","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-grid","forks_url":"https://api.github.com/repos/angular-ui/ui-grid/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-grid/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-grid/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-grid/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-grid/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-grid/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-grid/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-grid/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-grid/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-grid/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-grid/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-grid/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-grid/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-grid/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-grid/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-grid/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-grid/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-grid/releases{/id}","deployments_url":"https://api.github.com/repos/angular-ui/ui-grid/deployments","created_at":"2012-10-13T01:39:25Z","updated_at":"2016-01-21T21:24:21Z","pushed_at":"2016-01-22T00:53:44Z","git_url":"git://github.com/angular-ui/ui-grid.git","ssh_url":"git@github.com:angular-ui/ui-grid.git","clone_url":"https://github.com/angular-ui/ui-grid.git","svn_url":"https://github.com/angular-ui/ui-grid","homepage":"http://ui-grid.info","size":20560,"stargazers_count":3636,"watchers_count":3636,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1796,"mirror_url":null,"open_issues_count":878,"forks":1796,"open_issues":878,"watchers":3636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4963"},"html":{"href":"https://github.com/angular-ui/ui-grid/pull/4963"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-grid/issues/4963"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-grid/issues/4963/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4963/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-grid/pulls/4963/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-grid/statuses/33da5f080260cbcff776c31a5535f8bb557c67ec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"swalters","id":195646,"avatar_url":"https://avatars.githubusercontent.com/u/195646?v=3","gravatar_id":"","url":"https://api.github.com/users/swalters","html_url":"https://github.com/swalters","followers_url":"https://api.github.com/users/swalters/followers","following_url":"https://api.github.com/users/swalters/following{/other_user}","gists_url":"https://api.github.com/users/swalters/gists{/gist_id}","starred_url":"https://api.github.com/users/swalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalters/subscriptions","organizations_url":"https://api.github.com/users/swalters/orgs","repos_url":"https://api.github.com/users/swalters/repos","events_url":"https://api.github.com/users/swalters/events{/privacy}","received_events_url":"https://api.github.com/users/swalters/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}