{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6435","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6435/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6435/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6435/events","html_url":"https://github.com/Automattic/wp-calypso/pull/6435","id":163030520,"number":6435,"title":"Framework: Fix infinite scroll","user":{"login":"seear","id":7767559,"avatar_url":"https://avatars.githubusercontent.com/u/7767559?v=3","gravatar_id":"","url":"https://api.github.com/users/seear","html_url":"https://github.com/seear","followers_url":"https://api.github.com/users/seear/followers","following_url":"https://api.github.com/users/seear/following{/other_user}","gists_url":"https://api.github.com/users/seear/gists{/gist_id}","starred_url":"https://api.github.com/users/seear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seear/subscriptions","organizations_url":"https://api.github.com/users/seear/orgs","repos_url":"https://api.github.com/users/seear/repos","events_url":"https://api.github.com/users/seear/events{/privacy}","received_events_url":"https://api.github.com/users/seear/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Themes","name":"Themes","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"seear","id":7767559,"avatar_url":"https://avatars.githubusercontent.com/u/7767559?v=3","gravatar_id":"","url":"https://api.github.com/users/seear","html_url":"https://github.com/seear","followers_url":"https://api.github.com/users/seear/followers","following_url":"https://api.github.com/users/seear/following{/other_user}","gists_url":"https://api.github.com/users/seear/gists{/gist_id}","starred_url":"https://api.github.com/users/seear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seear/subscriptions","organizations_url":"https://api.github.com/users/seear/orgs","repos_url":"https://api.github.com/users/seear/repos","events_url":"https://api.github.com/users/seear/events{/privacy}","received_events_url":"https://api.github.com/users/seear/received_events","type":"User","site_admin":false},"assignees":[{"login":"seear","id":7767559,"avatar_url":"https://avatars.githubusercontent.com/u/7767559?v=3","gravatar_id":"","url":"https://api.github.com/users/seear","html_url":"https://github.com/seear","followers_url":"https://api.github.com/users/seear/followers","following_url":"https://api.github.com/users/seear/following{/other_user}","gists_url":"https://api.github.com/users/seear/gists{/gist_id}","starred_url":"https://api.github.com/users/seear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seear/subscriptions","organizations_url":"https://api.github.com/users/seear/orgs","repos_url":"https://api.github.com/users/seear/repos","events_url":"https://api.github.com/users/seear/events{/privacy}","received_events_url":"https://api.github.com/users/seear/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-06-29T21:26:25Z","updated_at":"2016-06-30T16:05:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6435","html_url":"https://github.com/Automattic/wp-calypso/pull/6435","diff_url":"https://github.com/Automattic/wp-calypso/pull/6435.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/6435.patch"},"body":"Remove a layout tweak introduced in #4506 that causes infinite-scroll to constantly request data.\r\n\r\nSince a CSS [change](https://github.com/Automattic/wp-calypso/pull/4506/files#diff-73fb7e175d9b17f2f1a188509b0a4168R76) in #4506, `document.body.clientHeight` is always equal to `window.innerHeight`, meaning infinite-scroll always [thinks it needs](https://github.com/Automattic/wp-calypso/blob/f248c9aecc968dc01321d6a10230cda1cf22470b/client/lib/mixins/infinite-scroll/index.js#L42) more data.\r\n\r\nThis chage uses `scrollHeight`, which includes the space not visible in the viewport, instead of `clientHeight`.\r\n\r\n**To Test**\r\n* Note that currently at https://wordpress.com/design, the themes are loaded until the complete list is on the page (check the network tab in the browser tools)\r\n* With this PR, the themes are loaded in blocks of 20 as you scroll, as intended\r\n\r\n@hoverduck: I'd be interested to know if this PR fixes the e2e test problem with the theme list?\r\n\r\n\r\n\r\nTest live: https://calypso.live/?branch=fix/infinite-scroll"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/229706386","html_url":"https://github.com/Automattic/wp-calypso/pull/6435#issuecomment-229706386","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6435","id":229706386,"user":{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T16:05:57Z","updated_at":"2016-06-30T16:05:57Z","body":"This amazingly fixes #6424! 🎉 "}}
{"actor":{"display_login":"ockham"}}