{"action":"closed","number":10900,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10900","id":93457511,"html_url":"https://github.com/facebook/react-native/pull/10900","diff_url":"https://github.com/facebook/react-native/pull/10900.diff","patch_url":"https://github.com/facebook/react-native/pull/10900.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10900","number":10900,"state":"closed","locked":false,"title":"Android: Add disableExtractUI prop to TextInput on Android","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"body":"On Android, if there is a small amount of space available around a text input (e.g. landscape orientation on a phone), Android may choose to have the user edit the text inside of a full screen text input mode. This behavior isn't always desirable. For example, if your app offers some UI controls for controlling the formatting of the text, you want the controls to be visible while the user is editing the text. This Android feature conflicts with that desired experience because the UI controls would be hidden while the text is being edited.\r\n\r\nThe `disableExtractUI` prop enables developers to choose whether or not Android's full screen text input editing mode is enabled. When this prop is true, Android's `IME_FLAG_NO_EXTRACT_UI` flag is passed to the `setImeOptions` method.\r\n\r\n**Test plan (required)**\r\n\r\nVerified `disableExtractUI` works for both `true` and `false` values in a test app.\r\n\r\nMy team is also using this change in our app.\r\n\r\nAdam Comella\r\nMicrosoft Corp.","created_at":"2016-11-13T00:46:17Z","updated_at":"2016-11-23T14:44:18Z","closed_at":"2016-11-23T14:44:18Z","merged_at":null,"merge_commit_sha":"515b0072cf2cc40603e255a01e108d4594738cf5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/10900/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/10900/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10900/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/bf7df65c7f48074639947a9a385a7dd80acbf119","head":{"label":"rigdern:rigdern/disableExtractUi","ref":"rigdern/disableExtractUi","sha":"bf7df65c7f48074639947a9a385a7dd80acbf119","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"repo":{"id":39579697,"name":"react-native","full_name":"rigdern/react-native","owner":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rigdern/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/rigdern/react-native","forks_url":"https://api.github.com/repos/rigdern/react-native/forks","keys_url":"https://api.github.com/repos/rigdern/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigdern/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigdern/react-native/teams","hooks_url":"https://api.github.com/repos/rigdern/react-native/hooks","issue_events_url":"https://api.github.com/repos/rigdern/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/rigdern/react-native/events","assignees_url":"https://api.github.com/repos/rigdern/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/rigdern/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/rigdern/react-native/tags","blobs_url":"https://api.github.com/repos/rigdern/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigdern/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigdern/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigdern/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigdern/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/rigdern/react-native/languages","stargazers_url":"https://api.github.com/repos/rigdern/react-native/stargazers","contributors_url":"https://api.github.com/repos/rigdern/react-native/contributors","subscribers_url":"https://api.github.com/repos/rigdern/react-native/subscribers","subscription_url":"https://api.github.com/repos/rigdern/react-native/subscription","commits_url":"https://api.github.com/repos/rigdern/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigdern/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigdern/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigdern/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigdern/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/rigdern/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigdern/react-native/merges","archive_url":"https://api.github.com/repos/rigdern/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigdern/react-native/downloads","issues_url":"https://api.github.com/repos/rigdern/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/rigdern/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/rigdern/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/rigdern/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigdern/react-native/labels{/name}","releases_url":"https://api.github.com/repos/rigdern/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/rigdern/react-native/deployments","created_at":"2015-07-23T16:53:43Z","updated_at":"2016-07-20T02:47:21Z","pushed_at":"2016-11-23T06:30:53Z","git_url":"git://github.com/rigdern/react-native.git","ssh_url":"git@github.com:rigdern/react-native.git","clone_url":"https://github.com/rigdern/react-native.git","svn_url":"https://github.com/rigdern/react-native","homepage":"http://facebook.github.io/react-native/","size":60219,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c612c615449b8645976429ad1c0661a4f6e56115","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-11-23T14:31:19Z","pushed_at":"2016-11-23T14:43:51Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":159126,"stargazers_count":40722,"watchers_count":40722,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9239,"mirror_url":null,"open_issues_count":859,"forks":9239,"open_issues":859,"watchers":40722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10900"},"html":{"href":"https://github.com/facebook/react-native/pull/10900"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/10900"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/10900/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10900/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10900/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/bf7df65c7f48074639947a9a385a7dd80acbf119"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":6,"review_comments":0,"commits":2,"additions":75,"deletions":24,"changed_files":3}}
{"actor":{"display_login":"facebook-github-bot"}}