{"action":"created","issue":{"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/228","repository_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc","labels_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/228/comments","events_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/228/events","html_url":"https://github.com/eface2face/cordova-plugin-iosrtc/issues/228","id":187680437,"number":228,"title":"Update libwebrtc patch","user":{"login":"ibc","id":16191,"avatar_url":"https://avatars.githubusercontent.com/u/16191?v=3","gravatar_id":"","url":"https://api.github.com/users/ibc","html_url":"https://github.com/ibc","followers_url":"https://api.github.com/users/ibc/followers","following_url":"https://api.github.com/users/ibc/following{/other_user}","gists_url":"https://api.github.com/users/ibc/gists{/gist_id}","starred_url":"https://api.github.com/users/ibc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibc/subscriptions","organizations_url":"https://api.github.com/users/ibc/orgs","repos_url":"https://api.github.com/users/ibc/repos","events_url":"https://api.github.com/users/ibc/events{/privacy}","received_events_url":"https://api.github.com/users/ibc/received_events","type":"User","site_admin":false},"labels":[{"id":213002706,"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-11-07T10:52:46Z","updated_at":"2016-11-16T20:38:31Z","closed_at":null,"body":"It seems that the latest libwebrtc code changes some files so the existing patch no longer works:\r\n\r\n```bash\r\n$ patch -p1 < ~/src/cordova-plugin-iosrtc/extra/libwebrtc-objc-iosrtc.patch\r\ncan't find file to patch at input line 3\r\nPerhaps you used the wrong -p or --strip option?\r\nThe text leading up to this was:\r\n--------------------------\r\n|--- a/talk/app/webrtc/objc/RTCMediaStream+Internal.h\r\n|+++ b/talk/app/webrtc/objc/RTCMediaStream+Internal.h\r\n--------------------------\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/comments/261064621","html_url":"https://github.com/eface2face/cordova-plugin-iosrtc/issues/228#issuecomment-261064621","issue_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/228","id":261064621,"user":{"login":"hk0i","id":755669,"avatar_url":"https://avatars.githubusercontent.com/u/755669?v=3","gravatar_id":"","url":"https://api.github.com/users/hk0i","html_url":"https://github.com/hk0i","followers_url":"https://api.github.com/users/hk0i/followers","following_url":"https://api.github.com/users/hk0i/following{/other_user}","gists_url":"https://api.github.com/users/hk0i/gists{/gist_id}","starred_url":"https://api.github.com/users/hk0i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hk0i/subscriptions","organizations_url":"https://api.github.com/users/hk0i/orgs","repos_url":"https://api.github.com/users/hk0i/repos","events_url":"https://api.github.com/users/hk0i/events{/privacy}","received_events_url":"https://api.github.com/users/hk0i/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T20:38:31Z","updated_at":"2016-11-16T20:38:31Z","body":"If I send over a PR with just the patch changes would anyone be able to test and get it fully integrated with the cordova plugin? I have something that compiles on the libwebrtc side but I still haven't been able to get the appropriate changes in for the cordova plugin side so I'm not sure how much value there is in that.\r\n\r\nThe build instructions will probably need updating as well."}}
{"actor":{"display_login":"hk0i"}}