{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/capital-framework/issues/386","repository_url":"https://api.github.com/repos/cfpb/capital-framework","labels_url":"https://api.github.com/repos/cfpb/capital-framework/issues/386/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/capital-framework/issues/386/comments","events_url":"https://api.github.com/repos/cfpb/capital-framework/issues/386/events","html_url":"https://github.com/cfpb/capital-framework/pull/386","id":172127053,"number":386,"title":"Featured Content Module - the Atomic Era","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-19T13:05:05Z","updated_at":"2016-08-23T19:22:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/capital-framework/pulls/386","html_url":"https://github.com/cfpb/capital-framework/pull/386","diff_url":"https://github.com/cfpb/capital-framework/pull/386.diff","patch_url":"https://github.com/cfpb/capital-framework/pull/386.patch"},"body":"This PR atomizes the featured content module (as an organism, `o-featured-content-module`) and adds some features to that organism.\r\n\r\n- Makes featured-content-module an organism (`.o-featured-content-module`)\r\n- Adds LESS for the \"map\" image option (`.o-featured-content-module_img__map`, anchors the image to the right)\r\n- Adds LESS for the \"video\" option (`.o-featured-content-module_img__video`, anchors image in the center)\r\n- Makes the \"default\" anchoring images to the left\r\n\r\n__Note:__ Some of the elements in the featured content module will use atomic classes from the cf-typography package. Specifically, `category-slug` and `jump-link` will have to wait for cf-typography to be atomized. \r\n\r\n## Changes\r\n- Moved featured content module LESS to `src/organisms/featured-content-module.less` (__Note!__ cf-layout has a different directory structure than other modules, like cf-forms. The `organisms` and `molecules` folders in cf-layout are inside `src`, but in cf-forms, those folders are at the top level. I'm not sure which is correct - for cf-layout, `heroes.less` was already inside `src/molecules` - but the package should be fixed to be consistent.)\r\n\r\n## Testing\r\n- You should be able to pull my branch into `capital-framework` and test it with `capital-framework-sandbox`. I have an updated `cf-layout/index.md` __[here](https://github.com/mistergone/capital-framework-sandbox/blob/test/components/cf-layout/index.md)__ -  (should I PR this commit into `capital-framework-sandbox`?). If you copy the contents of that file to the `index.md` file in your sandbox's cf-layout directory, you should see the three test cases for featured content modules.\r\n\r\n## Review\r\n- @KimberlyMunoz or @jimmynotjim ?\r\n- @Scotchester always has an opinion I'm interested in hearing, if he has time\r\n\r\n## Screenshots\r\n<img width=\"872\" alt=\"screen shot 2016-08-19 at 8 54 10 am\" src=\"https://cloud.githubusercontent.com/assets/1490703/17810339/96f233ba-65ea-11e6-9759-ba863fab71d7.png\">\r\n\r\n<img width=\"841\" alt=\"screen shot 2016-08-19 at 8 55 03 am\" src=\"https://cloud.githubusercontent.com/assets/1490703/17810352/ac1ba442-65ea-11e6-9f6a-ad0e4c646326.png\">\r\n\r\n<img width=\"848\" alt=\"screen shot 2016-08-19 at 8 55 46 am\" src=\"https://cloud.githubusercontent.com/assets/1490703/17810373/c584e664-65ea-11e6-82a9-f6bc9b4d7835.png\">\r\n\r\n## Notes\r\n- This is my first atomic design attempt, so y'know... I expect to be wrong. 😆 \r\n\r\n## Todos\r\n- Figure out what's going on with the directory structure\r\n- Update the `usage.md` documentation with cf-typography atomic classes.\r\n- PR a change to `capital-framework-sandbox`?\r\n\r\n## Checklist\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [x] Visually tested in supported browsers and devices\r\n* [x] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n\r\n## Animated GIF\r\n\r\nI feel like a competent FEWD, then I go back to LESS and I feel like this:\r\n\r\n![liz-lemon-speak-to-pizza](https://cloud.githubusercontent.com/assets/1490703/17810549/d3a95670-65eb-11e6-8afd-fd59c188c0a8.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/capital-framework/issues/comments/241846979","html_url":"https://github.com/cfpb/capital-framework/pull/386#issuecomment-241846979","issue_url":"https://api.github.com/repos/cfpb/capital-framework/issues/386","id":241846979,"user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T19:22:03Z","updated_at":"2016-08-23T19:22:03Z","body":"I've pushed two commits which contain `.lt-ie10` cases for `.o-featured-content-module_img__map` and `.o-featured-content-module_img__video`.\r\n\r\nThe fix for `.o-featured-content-module_img__video` (centering the image) looks fairly hacky, but it works.\r\n\r\nI've tested this in IE9. I also checked this out in IE8, but none of the Featured Content Module renders in the desired manner in IE8. It renders similar to the \"small-screen\" version. I don't know what our support policy is in this case, but I'm not going to worry about IE8 until someone instructs me to. 😄  "}}
{"actor":{"display_login":"mistergone"}}