{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14674","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14674/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14674/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14674/events","html_url":"https://github.com/NixOS/nixpkgs/pull/14674","id":148211415,"number":14674,"title":"xdg_utils: fix replacement of which with type -P","user":{"login":"Forkk","id":1300078,"avatar_url":"https://avatars.githubusercontent.com/u/1300078?v=3","gravatar_id":"","url":"https://api.github.com/users/Forkk","html_url":"https://github.com/Forkk","followers_url":"https://api.github.com/users/Forkk/followers","following_url":"https://api.github.com/users/Forkk/following{/other_user}","gists_url":"https://api.github.com/users/Forkk/gists{/gist_id}","starred_url":"https://api.github.com/users/Forkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Forkk/subscriptions","organizations_url":"https://api.github.com/users/Forkk/orgs","repos_url":"https://api.github.com/users/Forkk/repos","events_url":"https://api.github.com/users/Forkk/events{/privacy}","received_events_url":"https://api.github.com/users/Forkk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-13T23:37:01Z","updated_at":"2016-04-28T12:39:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14674","html_url":"https://github.com/NixOS/nixpkgs/pull/14674","diff_url":"https://github.com/NixOS/nixpkgs/pull/14674.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/14674.patch"},"body":"Before, the postInstall in xdg_utils failed to properly replace all instances of `which` with `type -P` due to some errant spaces in the sed command. This fixes the problem (hopefully).\r\n\r\nI'm lazy and I don't have a local copy of the nixpkgs repo at the moment, so I haven't really tested this yet, but I have tested a similar fix using `overrideDerivation`, so it'll probably work. ;)\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing (`nix-build --option build-use-chroot true` or [nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/215410825","html_url":"https://github.com/NixOS/nixpkgs/pull/14674#issuecomment-215410825","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14674","id":215410825,"user":{"login":"domenkozar","id":126339,"avatar_url":"https://avatars.githubusercontent.com/u/126339?v=3","gravatar_id":"","url":"https://api.github.com/users/domenkozar","html_url":"https://github.com/domenkozar","followers_url":"https://api.github.com/users/domenkozar/followers","following_url":"https://api.github.com/users/domenkozar/following{/other_user}","gists_url":"https://api.github.com/users/domenkozar/gists{/gist_id}","starred_url":"https://api.github.com/users/domenkozar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenkozar/subscriptions","organizations_url":"https://api.github.com/users/domenkozar/orgs","repos_url":"https://api.github.com/users/domenkozar/repos","events_url":"https://api.github.com/users/domenkozar/events{/privacy}","received_events_url":"https://api.github.com/users/domenkozar/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T12:39:50Z","updated_at":"2016-04-28T12:39:50Z","body":"Fixes https://github.com/NixOS/nixos/issues/301"}}