{"action":"opened","number":348,"pull_request":{"url":"https://api.github.com/repos/twitter/finatra/pulls/348","id":84244965,"html_url":"https://github.com/twitter/finatra/pull/348","diff_url":"https://github.com/twitter/finatra/pull/348.diff","patch_url":"https://github.com/twitter/finatra/pull/348.patch","issue_url":"https://api.github.com/repos/twitter/finatra/issues/348","number":348,"state":"open","locked":false,"title":"[AsyncStream] it consumes 34 secs for only one 104 KB string request","user":{"login":"pittwu","id":14215443,"avatar_url":"https://avatars.githubusercontent.com/u/14215443?v=3","gravatar_id":"","url":"https://api.github.com/users/pittwu","html_url":"https://github.com/pittwu","followers_url":"https://api.github.com/users/pittwu/followers","following_url":"https://api.github.com/users/pittwu/following{/other_user}","gists_url":"https://api.github.com/users/pittwu/gists{/gist_id}","starred_url":"https://api.github.com/users/pittwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pittwu/subscriptions","organizations_url":"https://api.github.com/users/pittwu/orgs","repos_url":"https://api.github.com/users/pittwu/repos","events_url":"https://api.github.com/users/pittwu/events{/privacy}","received_events_url":"https://api.github.com/users/pittwu/received_events","type":"User","site_admin":false},"body":"Problem\r\n\r\nExplain the context and why you're making that change.  What is the\r\nproblem you're trying to solve? In some cases there is not a problem\r\nand this can be thought of being the motivation for your change.\r\n\r\nSolution\r\n\r\nDescribe the modifications you've done.\r\n\r\nResult\r\n\r\nWhat will change as a result of your pull request? Note that sometimes\r\nthis section is unnecessary because it is self-explanatory based on\r\nthe solution.\r\n\r\nProblem\r\n\r\nThe endpoint with request type AsyncStream is time-consuming. From test, it\r\ntotally consumes 34 seconds in 38 seconds for only one string request with 104KB\r\n(Note, 38 seconds is duration of http request completion). The root cause is\r\nthat the method buf.utf8str is time-consuming and called by\r\nByteBufferUtils.debugBuffer.\r\n\r\nSolution\r\n\r\nSince ByteBufferUtils.debugBuffer is for debugging purpose, we can limit it to\r\nrun only in debugging mode by logger.isDebugEnabled\r\n\r\nResult\r\n\r\nAfter applying solution, the time consumption is reduced to 0.254 seconds. It\r\nimproves a lot.","created_at":"2016-09-07T06:43:34Z","updated_at":"2016-09-07T06:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c06abc4666270f0b18759dd5f4e4df4d1c648bd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/finatra/pulls/348/commits","review_comments_url":"https://api.github.com/repos/twitter/finatra/pulls/348/comments","review_comment_url":"https://api.github.com/repos/twitter/finatra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/finatra/issues/348/comments","statuses_url":"https://api.github.com/repos/twitter/finatra/statuses/59fbae94f51d6cde0f86840adc2a887112ac6546","head":{"label":"pittwu:imporve_asyncstream_performance","ref":"imporve_asyncstream_performance","sha":"59fbae94f51d6cde0f86840adc2a887112ac6546","user":{"login":"pittwu","id":14215443,"avatar_url":"https://avatars.githubusercontent.com/u/14215443?v=3","gravatar_id":"","url":"https://api.github.com/users/pittwu","html_url":"https://github.com/pittwu","followers_url":"https://api.github.com/users/pittwu/followers","following_url":"https://api.github.com/users/pittwu/following{/other_user}","gists_url":"https://api.github.com/users/pittwu/gists{/gist_id}","starred_url":"https://api.github.com/users/pittwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pittwu/subscriptions","organizations_url":"https://api.github.com/users/pittwu/orgs","repos_url":"https://api.github.com/users/pittwu/repos","events_url":"https://api.github.com/users/pittwu/events{/privacy}","received_events_url":"https://api.github.com/users/pittwu/received_events","type":"User","site_admin":false},"repo":{"id":42246205,"name":"finatra","full_name":"pittwu/finatra","owner":{"login":"pittwu","id":14215443,"avatar_url":"https://avatars.githubusercontent.com/u/14215443?v=3","gravatar_id":"","url":"https://api.github.com/users/pittwu","html_url":"https://github.com/pittwu","followers_url":"https://api.github.com/users/pittwu/followers","following_url":"https://api.github.com/users/pittwu/following{/other_user}","gists_url":"https://api.github.com/users/pittwu/gists{/gist_id}","starred_url":"https://api.github.com/users/pittwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pittwu/subscriptions","organizations_url":"https://api.github.com/users/pittwu/orgs","repos_url":"https://api.github.com/users/pittwu/repos","events_url":"https://api.github.com/users/pittwu/events{/privacy}","received_events_url":"https://api.github.com/users/pittwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pittwu/finatra","description":"Fast, testable, Scala HTTP services built on Twitter-Server and Finagle","fork":true,"url":"https://api.github.com/repos/pittwu/finatra","forks_url":"https://api.github.com/repos/pittwu/finatra/forks","keys_url":"https://api.github.com/repos/pittwu/finatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pittwu/finatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pittwu/finatra/teams","hooks_url":"https://api.github.com/repos/pittwu/finatra/hooks","issue_events_url":"https://api.github.com/repos/pittwu/finatra/issues/events{/number}","events_url":"https://api.github.com/repos/pittwu/finatra/events","assignees_url":"https://api.github.com/repos/pittwu/finatra/assignees{/user}","branches_url":"https://api.github.com/repos/pittwu/finatra/branches{/branch}","tags_url":"https://api.github.com/repos/pittwu/finatra/tags","blobs_url":"https://api.github.com/repos/pittwu/finatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pittwu/finatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pittwu/finatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/pittwu/finatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pittwu/finatra/statuses/{sha}","languages_url":"https://api.github.com/repos/pittwu/finatra/languages","stargazers_url":"https://api.github.com/repos/pittwu/finatra/stargazers","contributors_url":"https://api.github.com/repos/pittwu/finatra/contributors","subscribers_url":"https://api.github.com/repos/pittwu/finatra/subscribers","subscription_url":"https://api.github.com/repos/pittwu/finatra/subscription","commits_url":"https://api.github.com/repos/pittwu/finatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/pittwu/finatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/pittwu/finatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/pittwu/finatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/pittwu/finatra/contents/{+path}","compare_url":"https://api.github.com/repos/pittwu/finatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pittwu/finatra/merges","archive_url":"https://api.github.com/repos/pittwu/finatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pittwu/finatra/downloads","issues_url":"https://api.github.com/repos/pittwu/finatra/issues{/number}","pulls_url":"https://api.github.com/repos/pittwu/finatra/pulls{/number}","milestones_url":"https://api.github.com/repos/pittwu/finatra/milestones{/number}","notifications_url":"https://api.github.com/repos/pittwu/finatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pittwu/finatra/labels{/name}","releases_url":"https://api.github.com/repos/pittwu/finatra/releases{/id}","deployments_url":"https://api.github.com/repos/pittwu/finatra/deployments","created_at":"2015-09-10T13:29:03Z","updated_at":"2015-09-10T13:29:05Z","pushed_at":"2016-09-07T06:38:21Z","git_url":"git://github.com/pittwu/finatra.git","ssh_url":"git@github.com:pittwu/finatra.git","clone_url":"https://github.com/pittwu/finatra.git","svn_url":"https://github.com/pittwu/finatra","homepage":"https://twitter.github.io/finatra/","size":10480,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:develop","ref":"develop","sha":"6efd2f1f291f63c61c114fe690555ef99ed9e1ea","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3465312,"name":"finatra","full_name":"twitter/finatra","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/finatra","description":"Fast, testable, Scala services built on Twitter-Server and Finagle","fork":false,"url":"https://api.github.com/repos/twitter/finatra","forks_url":"https://api.github.com/repos/twitter/finatra/forks","keys_url":"https://api.github.com/repos/twitter/finatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/finatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/finatra/teams","hooks_url":"https://api.github.com/repos/twitter/finatra/hooks","issue_events_url":"https://api.github.com/repos/twitter/finatra/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/finatra/events","assignees_url":"https://api.github.com/repos/twitter/finatra/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/finatra/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/finatra/tags","blobs_url":"https://api.github.com/repos/twitter/finatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/finatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/finatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/finatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/finatra/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/finatra/languages","stargazers_url":"https://api.github.com/repos/twitter/finatra/stargazers","contributors_url":"https://api.github.com/repos/twitter/finatra/contributors","subscribers_url":"https://api.github.com/repos/twitter/finatra/subscribers","subscription_url":"https://api.github.com/repos/twitter/finatra/subscription","commits_url":"https://api.github.com/repos/twitter/finatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/finatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/finatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/finatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/finatra/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/finatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/finatra/merges","archive_url":"https://api.github.com/repos/twitter/finatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/finatra/downloads","issues_url":"https://api.github.com/repos/twitter/finatra/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/finatra/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/finatra/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/finatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/finatra/labels{/name}","releases_url":"https://api.github.com/repos/twitter/finatra/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/finatra/deployments","created_at":"2012-02-16T23:55:29Z","updated_at":"2016-09-07T05:27:33Z","pushed_at":"2016-09-07T06:43:34Z","git_url":"git://github.com/twitter/finatra.git","ssh_url":"git@github.com:twitter/finatra.git","clone_url":"https://github.com/twitter/finatra.git","svn_url":"https://github.com/twitter/finatra","homepage":"https://twitter.github.io/finatra/","size":22578,"stargazers_count":1354,"watchers_count":1354,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":248,"mirror_url":null,"open_issues_count":9,"forks":248,"open_issues":9,"watchers":1354,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/finatra/pulls/348"},"html":{"href":"https://github.com/twitter/finatra/pull/348"},"issue":{"href":"https://api.github.com/repos/twitter/finatra/issues/348"},"comments":{"href":"https://api.github.com/repos/twitter/finatra/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/finatra/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/finatra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/finatra/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/finatra/statuses/59fbae94f51d6cde0f86840adc2a887112ac6546"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"pittwu"}}