{"action":"closed","number":52,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/52","id":76177440,"html_url":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/52","diff_url":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/52.diff","patch_url":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/52.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/52","number":52,"state":"closed","locked":false,"title":"gcloud preview app gen-config doesn't work","user":{"login":"ithinkihaveacat","id":51244,"avatar_url":"https://avatars.githubusercontent.com/u/51244?v=3","gravatar_id":"","url":"https://api.github.com/users/ithinkihaveacat","html_url":"https://github.com/ithinkihaveacat","followers_url":"https://api.github.com/users/ithinkihaveacat/followers","following_url":"https://api.github.com/users/ithinkihaveacat/following{/other_user}","gists_url":"https://api.github.com/users/ithinkihaveacat/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinkihaveacat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinkihaveacat/subscriptions","organizations_url":"https://api.github.com/users/ithinkihaveacat/orgs","repos_url":"https://api.github.com/users/ithinkihaveacat/repos","events_url":"https://api.github.com/users/ithinkihaveacat/events{/privacy}","received_events_url":"https://api.github.com/users/ithinkihaveacat/received_events","type":"User","site_admin":false},"body":"I wasn't able to get the following sequence of commands (from the `README`) to work:\r\n\r\n````\r\n$ git clone https://github.com/GoogleCloudPlatform/nodejs-docker\r\n$ cd nodejs-docker\r\n$ gcloud preview app gen-config --custom\r\n  WARNING: No node version specified.  Please add your node version, see https://docs.npmjs.com/files/package.json#engines\r\n  ERROR: (gcloud.preview.app.gen-config) Unrecognized directory type: [/Users/stillers/workspace/nodejs-docker]\r\n````\r\n\r\n(This is with gcloud version 116.0.0.)\r\n\r\nTo generate the appropriate Docker files (`Dockerfile`, `app.yaml`, `.dockerignore`, I needed by make the changes indicated in this PR, and then run the command:\r\n\r\n````\r\n$ gcloud preview app gen-config --custom --runtime nodejs\r\n````\r\n(There are possibly other ways to workaround bug, but this worked for me.)","created_at":"2016-07-04T15:16:04Z","updated_at":"2016-07-12T23:50:33Z","closed_at":"2016-07-12T23:50:33Z","merged_at":null,"merge_commit_sha":"89d7ab0875a53fb778f452630a3fc02c253a8b8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/52/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/52/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/52/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/statuses/367db09868284ca92137e3b0b16c000faee6f126","head":{"label":"ithinkihaveacat:tweak","ref":"tweak","sha":"367db09868284ca92137e3b0b16c000faee6f126","user":{"login":"ithinkihaveacat","id":51244,"avatar_url":"https://avatars.githubusercontent.com/u/51244?v=3","gravatar_id":"","url":"https://api.github.com/users/ithinkihaveacat","html_url":"https://github.com/ithinkihaveacat","followers_url":"https://api.github.com/users/ithinkihaveacat/followers","following_url":"https://api.github.com/users/ithinkihaveacat/following{/other_user}","gists_url":"https://api.github.com/users/ithinkihaveacat/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinkihaveacat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinkihaveacat/subscriptions","organizations_url":"https://api.github.com/users/ithinkihaveacat/orgs","repos_url":"https://api.github.com/users/ithinkihaveacat/repos","events_url":"https://api.github.com/users/ithinkihaveacat/events{/privacy}","received_events_url":"https://api.github.com/users/ithinkihaveacat/received_events","type":"User","site_admin":false},"repo":{"id":62570713,"name":"nodejs-docker","full_name":"ithinkihaveacat/nodejs-docker","owner":{"login":"ithinkihaveacat","id":51244,"avatar_url":"https://avatars.githubusercontent.com/u/51244?v=3","gravatar_id":"","url":"https://api.github.com/users/ithinkihaveacat","html_url":"https://github.com/ithinkihaveacat","followers_url":"https://api.github.com/users/ithinkihaveacat/followers","following_url":"https://api.github.com/users/ithinkihaveacat/following{/other_user}","gists_url":"https://api.github.com/users/ithinkihaveacat/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinkihaveacat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinkihaveacat/subscriptions","organizations_url":"https://api.github.com/users/ithinkihaveacat/orgs","repos_url":"https://api.github.com/users/ithinkihaveacat/repos","events_url":"https://api.github.com/users/ithinkihaveacat/events{/privacy}","received_events_url":"https://api.github.com/users/ithinkihaveacat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ithinkihaveacat/nodejs-docker","description":"The Node.js Docker image used by Google App Engine Flexible.","fork":true,"url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker","forks_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/forks","keys_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/teams","hooks_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/hooks","issue_events_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/issues/events{/number}","events_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/events","assignees_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/assignees{/user}","branches_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/branches{/branch}","tags_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/tags","blobs_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/languages","stargazers_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/stargazers","contributors_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/contributors","subscribers_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/subscribers","subscription_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/subscription","commits_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/contents/{+path}","compare_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/merges","archive_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/downloads","issues_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/issues{/number}","pulls_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/labels{/name}","releases_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/releases{/id}","deployments_url":"https://api.github.com/repos/ithinkihaveacat/nodejs-docker/deployments","created_at":"2016-07-04T15:08:02Z","updated_at":"2016-07-04T15:08:03Z","pushed_at":"2016-07-04T15:09:41Z","git_url":"git://github.com/ithinkihaveacat/nodejs-docker.git","ssh_url":"git@github.com:ithinkihaveacat/nodejs-docker.git","clone_url":"https://github.com/ithinkihaveacat/nodejs-docker.git","svn_url":"https://github.com/ithinkihaveacat/nodejs-docker","homepage":"https://cloud.google.com/nodejs","size":47,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"80782a2f0e3c96733d7183736cd9b379d4f2a595","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19798221,"name":"nodejs-docker","full_name":"GoogleCloudPlatform/nodejs-docker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/nodejs-docker","description":"The Node.js Docker image used by Google App Engine Flexible.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/deployments","created_at":"2014-05-14T22:22:56Z","updated_at":"2016-07-11T03:44:27Z","pushed_at":"2016-07-12T23:50:33Z","git_url":"git://github.com/GoogleCloudPlatform/nodejs-docker.git","ssh_url":"git@github.com:GoogleCloudPlatform/nodejs-docker.git","clone_url":"https://github.com/GoogleCloudPlatform/nodejs-docker.git","svn_url":"https://github.com/GoogleCloudPlatform/nodejs-docker","homepage":"https://cloud.google.com/nodejs","size":77,"stargazers_count":135,"watchers_count":135,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":3,"forks":40,"open_issues":3,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/52"},"html":{"href":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/52"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/52"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/statuses/367db09868284ca92137e3b0b16c000faee6f126"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":3,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"ofrobots"}}