{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/77670230","id":77670230,"diff_hunk":"@@ -172,8 +184,13 @@ NeedleDiff.prototype.draw = function() {\n       var textSize = this.ctx.measureText(text);\n       var tx;\n       var ty = a['ypos'] + a['height'] + 19;\n-      if (ty > this.screenshotImg.height) {\n-        ty = a['ypos'] - 4;\n+      if (ty > this.height) {\n+        // Place text above match box\n+        ty = a['ypos'] - 10;\n+      }\n+      if (ty < 14) {","path":"assets/javascripts/needlediff.js","position":75,"original_position":75,"commit_id":"a6b0a52ca240e116f7a3585f44351e45fa1147f2","original_commit_id":"2cd7b0edfe79e00de17be55d53606186966671f8","user":{"login":"okurz","id":1693432,"avatar_url":"https://avatars.githubusercontent.com/u/1693432?v=3","gravatar_id":"","url":"https://api.github.com/users/okurz","html_url":"https://github.com/okurz","followers_url":"https://api.github.com/users/okurz/followers","following_url":"https://api.github.com/users/okurz/following{/other_user}","gists_url":"https://api.github.com/users/okurz/gists{/gist_id}","starred_url":"https://api.github.com/users/okurz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okurz/subscriptions","organizations_url":"https://api.github.com/users/okurz/orgs","repos_url":"https://api.github.com/users/okurz/repos","events_url":"https://api.github.com/users/okurz/events{/privacy}","received_events_url":"https://api.github.com/users/okurz/received_events","type":"User","site_admin":false},"body":"yes, it is now. done.","created_at":"2016-09-06T16:30:26Z","updated_at":"2016-09-06T16:30:26Z","html_url":"https://github.com/os-autoinst/openQA/pull/851#discussion_r77670230","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/851","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/77670230"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/851#discussion_r77670230"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/851"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/851","id":84103501,"html_url":"https://github.com/os-autoinst/openQA/pull/851","diff_url":"https://github.com/os-autoinst/openQA/pull/851.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/851.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/851","number":851,"state":"open","locked":false,"title":"Draw needle match labels after match boxes","user":{"login":"asdil12","id":725608,"avatar_url":"https://avatars.githubusercontent.com/u/725608?v=3","gravatar_id":"","url":"https://api.github.com/users/asdil12","html_url":"https://github.com/asdil12","followers_url":"https://api.github.com/users/asdil12/followers","following_url":"https://api.github.com/users/asdil12/following{/other_user}","gists_url":"https://api.github.com/users/asdil12/gists{/gist_id}","starred_url":"https://api.github.com/users/asdil12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdil12/subscriptions","organizations_url":"https://api.github.com/users/asdil12/orgs","repos_url":"https://api.github.com/users/asdil12/repos","events_url":"https://api.github.com/users/asdil12/events{/privacy}","received_events_url":"https://api.github.com/users/asdil12/received_events","type":"User","site_admin":false},"body":"This prevents match boxes from covering up labels of other boxes.\r\n\r\nhttps://progress.opensuse.org/issues/12296","created_at":"2016-09-06T11:14:12Z","updated_at":"2016-09-06T16:30:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d53b1e9ab35f6b6988141f9c816a51639bca2563","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/851/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/851/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/851/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/a6b0a52ca240e116f7a3585f44351e45fa1147f2","head":{"label":"asdil12:needle_label_zindex","ref":"needle_label_zindex","sha":"a6b0a52ca240e116f7a3585f44351e45fa1147f2","user":{"login":"asdil12","id":725608,"avatar_url":"https://avatars.githubusercontent.com/u/725608?v=3","gravatar_id":"","url":"https://api.github.com/users/asdil12","html_url":"https://github.com/asdil12","followers_url":"https://api.github.com/users/asdil12/followers","following_url":"https://api.github.com/users/asdil12/following{/other_user}","gists_url":"https://api.github.com/users/asdil12/gists{/gist_id}","starred_url":"https://api.github.com/users/asdil12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdil12/subscriptions","organizations_url":"https://api.github.com/users/asdil12/orgs","repos_url":"https://api.github.com/users/asdil12/repos","events_url":"https://api.github.com/users/asdil12/events{/privacy}","received_events_url":"https://api.github.com/users/asdil12/received_events","type":"User","site_admin":false},"repo":{"id":34267921,"name":"openQA","full_name":"asdil12/openQA","owner":{"login":"asdil12","id":725608,"avatar_url":"https://avatars.githubusercontent.com/u/725608?v=3","gravatar_id":"","url":"https://api.github.com/users/asdil12","html_url":"https://github.com/asdil12","followers_url":"https://api.github.com/users/asdil12/followers","following_url":"https://api.github.com/users/asdil12/following{/other_user}","gists_url":"https://api.github.com/users/asdil12/gists{/gist_id}","starred_url":"https://api.github.com/users/asdil12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdil12/subscriptions","organizations_url":"https://api.github.com/users/asdil12/orgs","repos_url":"https://api.github.com/users/asdil12/repos","events_url":"https://api.github.com/users/asdil12/events{/privacy}","received_events_url":"https://api.github.com/users/asdil12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asdil12/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/asdil12/openQA","forks_url":"https://api.github.com/repos/asdil12/openQA/forks","keys_url":"https://api.github.com/repos/asdil12/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asdil12/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asdil12/openQA/teams","hooks_url":"https://api.github.com/repos/asdil12/openQA/hooks","issue_events_url":"https://api.github.com/repos/asdil12/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/asdil12/openQA/events","assignees_url":"https://api.github.com/repos/asdil12/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/asdil12/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/asdil12/openQA/tags","blobs_url":"https://api.github.com/repos/asdil12/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asdil12/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asdil12/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/asdil12/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asdil12/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/asdil12/openQA/languages","stargazers_url":"https://api.github.com/repos/asdil12/openQA/stargazers","contributors_url":"https://api.github.com/repos/asdil12/openQA/contributors","subscribers_url":"https://api.github.com/repos/asdil12/openQA/subscribers","subscription_url":"https://api.github.com/repos/asdil12/openQA/subscription","commits_url":"https://api.github.com/repos/asdil12/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/asdil12/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/asdil12/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/asdil12/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/asdil12/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/asdil12/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asdil12/openQA/merges","archive_url":"https://api.github.com/repos/asdil12/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asdil12/openQA/downloads","issues_url":"https://api.github.com/repos/asdil12/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/asdil12/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/asdil12/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/asdil12/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asdil12/openQA/labels{/name}","releases_url":"https://api.github.com/repos/asdil12/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/asdil12/openQA/deployments","created_at":"2015-04-20T15:12:26Z","updated_at":"2015-04-20T15:12:29Z","pushed_at":"2016-09-06T12:45:35Z","git_url":"git://github.com/asdil12/openQA.git","ssh_url":"git@github.com:asdil12/openQA.git","clone_url":"https://github.com/asdil12/openQA.git","svn_url":"https://github.com/asdil12/openQA","homepage":"http://openqa.opensuse.org/","size":15308,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"3ab22121b1f0a0a667e4c6e22416c36e94de1e79","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2016-09-01T12:19:24Z","pushed_at":"2016-09-06T14:15:23Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":16567,"stargazers_count":67,"watchers_count":67,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"open_issues_count":26,"forks":52,"open_issues":26,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/851"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/851"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/851"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/851/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/851/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/851/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/a6b0a52ca240e116f7a3585f44351e45fa1147f2"}}}}
{"actor":{"display_login":"okurz"}}