{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-charts/issues/86","repository_url":"https://api.github.com/repos/vaadin/vaadin-charts","labels_url":"https://api.github.com/repos/vaadin/vaadin-charts/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-charts/issues/86/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-charts/issues/86/events","html_url":"https://github.com/vaadin/vaadin-charts/pull/86","id":140627491,"number":86,"title":"Fix parsing tags values always as strings charts-276","user":{"login":"rogozinds","id":1339320,"avatar_url":"https://avatars.githubusercontent.com/u/1339320?v=3","gravatar_id":"","url":"https://api.github.com/users/rogozinds","html_url":"https://github.com/rogozinds","followers_url":"https://api.github.com/users/rogozinds/followers","following_url":"https://api.github.com/users/rogozinds/following{/other_user}","gists_url":"https://api.github.com/users/rogozinds/gists{/gist_id}","starred_url":"https://api.github.com/users/rogozinds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogozinds/subscriptions","organizations_url":"https://api.github.com/users/rogozinds/orgs","repos_url":"https://api.github.com/users/rogozinds/repos","events_url":"https://api.github.com/users/rogozinds/events{/privacy}","received_events_url":"https://api.github.com/users/rogozinds/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-14T10:01:32Z","updated_at":"2016-03-15T07:54:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-charts/pulls/86","html_url":"https://github.com/vaadin/vaadin-charts/pull/86","diff_url":"https://github.com/vaadin/vaadin-charts/pull/86.diff","patch_url":"https://github.com/vaadin/vaadin-charts/pull/86.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-charts/86)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-charts/issues/comments/196706922","html_url":"https://github.com/vaadin/vaadin-charts/pull/86#issuecomment-196706922","issue_url":"https://api.github.com/repos/vaadin/vaadin-charts/issues/86","id":196706922,"user":{"login":"rogozinds","id":1339320,"avatar_url":"https://avatars.githubusercontent.com/u/1339320?v=3","gravatar_id":"","url":"https://api.github.com/users/rogozinds","html_url":"https://github.com/rogozinds","followers_url":"https://api.github.com/users/rogozinds/followers","following_url":"https://api.github.com/users/rogozinds/following{/other_user}","gists_url":"https://api.github.com/users/rogozinds/gists{/gist_id}","starred_url":"https://api.github.com/users/rogozinds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogozinds/subscriptions","organizations_url":"https://api.github.com/users/rogozinds/orgs","repos_url":"https://api.github.com/users/rogozinds/repos","events_url":"https://api.github.com/users/rogozinds/events{/privacy}","received_events_url":"https://api.github.com/users/rogozinds/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T07:54:57Z","updated_at":"2016-03-15T07:54:57Z","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[configuration-reader.html, line 176 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/vaadin-charts/86#-KCtFFQjlWFXRksuHezn:-KCtFFQjlWFXRksuHezo:-1171317701) ([raw file](https://github.com/vaadin/vaadin-charts/blob/6ee0aad2581741349325f58233bdfb405dd300ad/configuration-reader.html#L176)):*\nThis one is not needed, because JSON.parse(\"true\") === true and JSON.parse('false\") === false\n\n---\n\n*[configuration-reader.html, line 185 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/vaadin-charts/86#-KCpUAxCH6ztH0br0jZu:-KCtEzL5c4AUGg7N-Ri8:-1375594769) ([raw file](https://github.com/vaadin/vaadin-charts/blob/6ee0aad2581741349325f58233bdfb405dd300ad/configuration-reader.html#L185)):*\nYeah it's needed if node.textContent is just a String, then JSON.parse(content) will raise an exception\n\n---\n\n*[test/pie-config-test.html, line 45 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/vaadin-charts/86#-KCpUICz-uE2bnmtNau6:-KCtGIgvxT1ldJqW_d6e:-499146009) ([raw file](https://github.com/vaadin/vaadin-charts/blob/6ee0aad2581741349325f58233bdfb405dd300ad/test/pie-config-test.html#L45)):*\nDone.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/vaadin/vaadin-charts/86)*\n<!-- Sent from Reviewable.io -->\n"}}