{"action":"opened","number":12234,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12234","id":65580787,"html_url":"https://github.com/apache/spark/pull/12234","diff_url":"https://github.com/apache/spark/pull/12234.diff","patch_url":"https://github.com/apache/spark/pull/12234.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/12234","number":12234,"state":"open","locked":false,"title":"[SPARK-14454] Better exception handling while marking tasks as failed","user":{"login":"sameeragarwal","id":166454,"avatar_url":"https://avatars.githubusercontent.com/u/166454?v=3","gravatar_id":"","url":"https://api.github.com/users/sameeragarwal","html_url":"https://github.com/sameeragarwal","followers_url":"https://api.github.com/users/sameeragarwal/followers","following_url":"https://api.github.com/users/sameeragarwal/following{/other_user}","gists_url":"https://api.github.com/users/sameeragarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/sameeragarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameeragarwal/subscriptions","organizations_url":"https://api.github.com/users/sameeragarwal/orgs","repos_url":"https://api.github.com/users/sameeragarwal/repos","events_url":"https://api.github.com/users/sameeragarwal/events{/privacy}","received_events_url":"https://api.github.com/users/sameeragarwal/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis patch adds support for better handling of exceptions inside catch blocks if the code within the block throws an exception. For instance here is the code in a catch block before this change in `WriterContainer.scala`: \r\n\r\n```scala\r\nlogError(\"Aborting task.\", cause)\r\n// call failure callbacks first, so we could have a chance to cleanup the writer.\r\nTaskContext.get().asInstanceOf[TaskContextImpl].markTaskFailed(cause)\r\nif (currentWriter != null) {\r\n  currentWriter.close()\r\n}\r\nabortTask()\r\nthrow new SparkException(\"Task failed while writing rows.\", cause)\r\n```\r\n\r\nIf `markTaskFailed` or `currentWriter.close` throws an exception, we currently lose the original cause. This PR fixes this problem by implementing a utility function `Utils.tryWithSafeCatch` that suppresses (`Throwable.addSuppressed`) the exception that are thrown within the catch block and rethrowing the original exception.\r\n\r\n## How was this patch tested?\r\n\r\nNo new functionality added","created_at":"2016-04-07T06:40:35Z","updated_at":"2016-04-07T06:40:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/12234/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/12234/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/12234/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/eebd2ef7c566c3a0d2bd14766efbf5d12b831ae6","head":{"label":"sameeragarwal:fix-exception","ref":"fix-exception","sha":"eebd2ef7c566c3a0d2bd14766efbf5d12b831ae6","user":{"login":"sameeragarwal","id":166454,"avatar_url":"https://avatars.githubusercontent.com/u/166454?v=3","gravatar_id":"","url":"https://api.github.com/users/sameeragarwal","html_url":"https://github.com/sameeragarwal","followers_url":"https://api.github.com/users/sameeragarwal/followers","following_url":"https://api.github.com/users/sameeragarwal/following{/other_user}","gists_url":"https://api.github.com/users/sameeragarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/sameeragarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameeragarwal/subscriptions","organizations_url":"https://api.github.com/users/sameeragarwal/orgs","repos_url":"https://api.github.com/users/sameeragarwal/repos","events_url":"https://api.github.com/users/sameeragarwal/events{/privacy}","received_events_url":"https://api.github.com/users/sameeragarwal/received_events","type":"User","site_admin":false},"repo":{"id":20599564,"name":"spark","full_name":"sameeragarwal/spark","owner":{"login":"sameeragarwal","id":166454,"avatar_url":"https://avatars.githubusercontent.com/u/166454?v=3","gravatar_id":"","url":"https://api.github.com/users/sameeragarwal","html_url":"https://github.com/sameeragarwal","followers_url":"https://api.github.com/users/sameeragarwal/followers","following_url":"https://api.github.com/users/sameeragarwal/following{/other_user}","gists_url":"https://api.github.com/users/sameeragarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/sameeragarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameeragarwal/subscriptions","organizations_url":"https://api.github.com/users/sameeragarwal/orgs","repos_url":"https://api.github.com/users/sameeragarwal/repos","events_url":"https://api.github.com/users/sameeragarwal/events{/privacy}","received_events_url":"https://api.github.com/users/sameeragarwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sameeragarwal/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sameeragarwal/spark","forks_url":"https://api.github.com/repos/sameeragarwal/spark/forks","keys_url":"https://api.github.com/repos/sameeragarwal/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sameeragarwal/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sameeragarwal/spark/teams","hooks_url":"https://api.github.com/repos/sameeragarwal/spark/hooks","issue_events_url":"https://api.github.com/repos/sameeragarwal/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sameeragarwal/spark/events","assignees_url":"https://api.github.com/repos/sameeragarwal/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sameeragarwal/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sameeragarwal/spark/tags","blobs_url":"https://api.github.com/repos/sameeragarwal/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sameeragarwal/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sameeragarwal/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sameeragarwal/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sameeragarwal/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sameeragarwal/spark/languages","stargazers_url":"https://api.github.com/repos/sameeragarwal/spark/stargazers","contributors_url":"https://api.github.com/repos/sameeragarwal/spark/contributors","subscribers_url":"https://api.github.com/repos/sameeragarwal/spark/subscribers","subscription_url":"https://api.github.com/repos/sameeragarwal/spark/subscription","commits_url":"https://api.github.com/repos/sameeragarwal/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sameeragarwal/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sameeragarwal/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sameeragarwal/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sameeragarwal/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sameeragarwal/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sameeragarwal/spark/merges","archive_url":"https://api.github.com/repos/sameeragarwal/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sameeragarwal/spark/downloads","issues_url":"https://api.github.com/repos/sameeragarwal/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sameeragarwal/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sameeragarwal/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sameeragarwal/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sameeragarwal/spark/labels{/name}","releases_url":"https://api.github.com/repos/sameeragarwal/spark/releases{/id}","deployments_url":"https://api.github.com/repos/sameeragarwal/spark/deployments","created_at":"2014-06-07T18:15:55Z","updated_at":"2014-06-28T02:17:20Z","pushed_at":"2016-04-07T06:29:44Z","git_url":"git://github.com/sameeragarwal/spark.git","ssh_url":"git@github.com:sameeragarwal/spark.git","clone_url":"https://github.com/sameeragarwal/spark.git","svn_url":"https://github.com/sameeragarwal/spark","homepage":null,"size":147079,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"blinkdb"}},"base":{"label":"apache:master","ref":"master","sha":"21d5ca128bf3afd5c2d4c7fcc56240e28443474f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-04-07T06:31:06Z","pushed_at":"2016-04-07T06:12:10Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":453161,"stargazers_count":8041,"watchers_count":8041,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7438,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":425,"forks":7438,"open_issues":425,"watchers":8041,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/12234"},"html":{"href":"https://github.com/apache/spark/pull/12234"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/12234"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/12234/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/12234/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/12234/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/eebd2ef7c566c3a0d2bd14766efbf5d12b831ae6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":78,"deletions":42,"changed_files":3}}