{"action":"closed","issue":{"url":"https://api.github.com/repos/nette/forms/issues/114","repository_url":"https://api.github.com/repos/nette/forms","labels_url":"https://api.github.com/repos/nette/forms/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/nette/forms/issues/114/comments","events_url":"https://api.github.com/repos/nette/forms/issues/114/events","html_url":"https://github.com/nette/forms/issues/114","id":138766950,"number":114,"title":"Danger setValue","user":{"login":"nechutny","id":5719315,"avatar_url":"https://avatars.githubusercontent.com/u/5719315?v=3","gravatar_id":"","url":"https://api.github.com/users/nechutny","html_url":"https://github.com/nechutny","followers_url":"https://api.github.com/users/nechutny/followers","following_url":"https://api.github.com/users/nechutny/following{/other_user}","gists_url":"https://api.github.com/users/nechutny/gists{/gist_id}","starred_url":"https://api.github.com/users/nechutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nechutny/subscriptions","organizations_url":"https://api.github.com/users/nechutny/orgs","repos_url":"https://api.github.com/users/nechutny/repos","events_url":"https://api.github.com/users/nechutny/events{/privacy}","received_events_url":"https://api.github.com/users/nechutny/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-03-06T08:26:30Z","updated_at":"2016-06-30T16:07:12Z","closed_at":"2016-06-30T16:07:12Z","body":"Hello,\r\n\r\nbefore some time I've been fixing a bug in our project which was caused by using setValue on input instead of setDefaultValue, so typed value by user was overwritten. After investigation I've found same bug across our projects and made by a lot of different developers.\r\nThis moved me to think about setValue method which is confusing. Is there any use-case, when it can't be protected? I think, that it's only used in creating custom inputs and then protected or at least @internal annotation should help with eliminating this mistake. Custom inputs are extending input so protected is ok. \r\nIn my opinion is this more confusing, than eg. method callbacks so we should think about it."}}
{"actor":{"display_login":"dg"}}