{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/74493312","id":74493312,"diff_hunk":"@@ -1044,18 +1055,26 @@ def validate(self):\n                                           \"for datetimelike and offset \"\n                                           \"based windows\")\n \n+            if self.left_closed is not None and not is_bool(self.left_closed):\n+                raise ValueError(\"left_closed must be a boolean\")\n+\n             # this will raise ValueError on non-fixed freqs\n             self.window = freq.nanos\n+            if self.left_closed:\n+                self.window += 1","path":"pandas/core/window.py","position":28,"original_position":28,"commit_id":"4c8c3b6b26a2cb2fcbcfc2c7f5443b2e1984db98","original_commit_id":"4c8c3b6b26a2cb2fcbcfc2c7f5443b2e1984db98","user":{"login":"chris-b1","id":1924092,"avatar_url":"https://avatars.githubusercontent.com/u/1924092?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-b1","html_url":"https://github.com/chris-b1","followers_url":"https://api.github.com/users/chris-b1/followers","following_url":"https://api.github.com/users/chris-b1/following{/other_user}","gists_url":"https://api.github.com/users/chris-b1/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-b1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-b1/subscriptions","organizations_url":"https://api.github.com/users/chris-b1/orgs","repos_url":"https://api.github.com/users/chris-b1/repos","events_url":"https://api.github.com/users/chris-b1/events{/privacy}","received_events_url":"https://api.github.com/users/chris-b1/received_events","type":"User","site_admin":false},"body":"Can you add a test or two with values at finer resolutions than the offset to confirm this?  for example\r\n\r\n```\r\nIn [11]: df = pd.DataFrame({'B': [1, 1, 1]},\r\n    ...:                   index = [pd.Timestamp('20130101 09:00:30'),\r\n    ...:                            pd.Timestamp('20130101 09:01:00'),\r\n    ...:                            pd.Timestamp('20130101 09:02:00')])\r\n\r\nIn [12]: df.rolling('1Min').sum()\r\nOut[12]: \r\n                       B\r\n2013-01-01 09:00:30  1.0\r\n2013-01-01 09:01:00  2.0\r\n2013-01-01 09:02:00  1.0\r\n```","created_at":"2016-08-11T20:05:50Z","updated_at":"2016-08-11T20:05:50Z","html_url":"https://github.com/pydata/pandas/pull/13968#discussion_r74493312","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/13968","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/74493312"},"html":{"href":"https://github.com/pydata/pandas/pull/13968#discussion_r74493312"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13968"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/13968","id":81015709,"html_url":"https://github.com/pydata/pandas/pull/13968","diff_url":"https://github.com/pydata/pandas/pull/13968.diff","patch_url":"https://github.com/pydata/pandas/pull/13968.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/13968","number":13968,"state":"open","locked":false,"title":"ENH: allow exact matches in time-based .rolling()","user":{"login":"agraboso","id":7795093,"avatar_url":"https://avatars.githubusercontent.com/u/7795093?v=3","gravatar_id":"","url":"https://api.github.com/users/agraboso","html_url":"https://github.com/agraboso","followers_url":"https://api.github.com/users/agraboso/followers","following_url":"https://api.github.com/users/agraboso/following{/other_user}","gists_url":"https://api.github.com/users/agraboso/gists{/gist_id}","starred_url":"https://api.github.com/users/agraboso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraboso/subscriptions","organizations_url":"https://api.github.com/users/agraboso/orgs","repos_url":"https://api.github.com/users/agraboso/repos","events_url":"https://api.github.com/users/agraboso/events{/privacy}","received_events_url":"https://api.github.com/users/agraboso/received_events","type":"User","site_admin":false},"body":" - [x] closes #13965\r\n - [x] tests added / passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n - [ ] whatsnew entry\r\n\r\nTODO: update docs.","created_at":"2016-08-11T19:25:51Z","updated_at":"2016-08-11T20:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8561b1bfb0a6dc231b98e6c6fedf3687113d2bd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/13968/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/13968/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/13968/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/4c8c3b6b26a2cb2fcbcfc2c7f5443b2e1984db98","head":{"label":"agraboso:fix-13965","ref":"fix-13965","sha":"4c8c3b6b26a2cb2fcbcfc2c7f5443b2e1984db98","user":{"login":"agraboso","id":7795093,"avatar_url":"https://avatars.githubusercontent.com/u/7795093?v=3","gravatar_id":"","url":"https://api.github.com/users/agraboso","html_url":"https://github.com/agraboso","followers_url":"https://api.github.com/users/agraboso/followers","following_url":"https://api.github.com/users/agraboso/following{/other_user}","gists_url":"https://api.github.com/users/agraboso/gists{/gist_id}","starred_url":"https://api.github.com/users/agraboso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraboso/subscriptions","organizations_url":"https://api.github.com/users/agraboso/orgs","repos_url":"https://api.github.com/users/agraboso/repos","events_url":"https://api.github.com/users/agraboso/events{/privacy}","received_events_url":"https://api.github.com/users/agraboso/received_events","type":"User","site_admin":false},"repo":{"id":62963161,"name":"pandas","full_name":"agraboso/pandas","owner":{"login":"agraboso","id":7795093,"avatar_url":"https://avatars.githubusercontent.com/u/7795093?v=3","gravatar_id":"","url":"https://api.github.com/users/agraboso","html_url":"https://github.com/agraboso","followers_url":"https://api.github.com/users/agraboso/followers","following_url":"https://api.github.com/users/agraboso/following{/other_user}","gists_url":"https://api.github.com/users/agraboso/gists{/gist_id}","starred_url":"https://api.github.com/users/agraboso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraboso/subscriptions","organizations_url":"https://api.github.com/users/agraboso/orgs","repos_url":"https://api.github.com/users/agraboso/repos","events_url":"https://api.github.com/users/agraboso/events{/privacy}","received_events_url":"https://api.github.com/users/agraboso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agraboso/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/agraboso/pandas","forks_url":"https://api.github.com/repos/agraboso/pandas/forks","keys_url":"https://api.github.com/repos/agraboso/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agraboso/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agraboso/pandas/teams","hooks_url":"https://api.github.com/repos/agraboso/pandas/hooks","issue_events_url":"https://api.github.com/repos/agraboso/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/agraboso/pandas/events","assignees_url":"https://api.github.com/repos/agraboso/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/agraboso/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/agraboso/pandas/tags","blobs_url":"https://api.github.com/repos/agraboso/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agraboso/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agraboso/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/agraboso/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agraboso/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/agraboso/pandas/languages","stargazers_url":"https://api.github.com/repos/agraboso/pandas/stargazers","contributors_url":"https://api.github.com/repos/agraboso/pandas/contributors","subscribers_url":"https://api.github.com/repos/agraboso/pandas/subscribers","subscription_url":"https://api.github.com/repos/agraboso/pandas/subscription","commits_url":"https://api.github.com/repos/agraboso/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/agraboso/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/agraboso/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/agraboso/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/agraboso/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/agraboso/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agraboso/pandas/merges","archive_url":"https://api.github.com/repos/agraboso/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agraboso/pandas/downloads","issues_url":"https://api.github.com/repos/agraboso/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/agraboso/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/agraboso/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/agraboso/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agraboso/pandas/labels{/name}","releases_url":"https://api.github.com/repos/agraboso/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/agraboso/pandas/deployments","created_at":"2016-07-09T18:22:37Z","updated_at":"2016-07-09T18:22:43Z","pushed_at":"2016-08-11T19:28:24Z","git_url":"git://github.com/agraboso/pandas.git","ssh_url":"git@github.com:agraboso/pandas.git","clone_url":"https://github.com/agraboso/pandas.git","svn_url":"https://github.com/agraboso/pandas","homepage":"http://pandas.pydata.org","size":79718,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"4a805216d99b37955c97625d304980eff10cab56","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-08-11T10:49:03Z","pushed_at":"2016-08-11T19:36:10Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":150036,"stargazers_count":6819,"watchers_count":6819,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2814,"mirror_url":null,"open_issues_count":1825,"forks":2814,"open_issues":1825,"watchers":6819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13968"},"html":{"href":"https://github.com/pydata/pandas/pull/13968"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/13968"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/13968/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13968/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13968/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/4c8c3b6b26a2cb2fcbcfc2c7f5443b2e1984db98"}}}}
{"actor":{"display_login":"chris-b1"}}