{"action":"created","comment":{"url":"https://api.github.com/repos/geany/geany/pulls/comments/76513785","id":76513785,"diff_hunk":"@@ -1906,8 +1915,25 @@ static gchar *find_calltip(const gchar *word, GeanyFiletype *ft)\n \n \tg_return_val_if_fail(ft && word && *word, NULL);\n \n-\t/* use all types in case language uses wrong tag type e.g. python \"members\" instead of \"methods\" */\n-\ttags = tm_workspace_find(word, NULL, tm_tag_max_t, NULL, ft->lang);\n+\ttags = get_scoped_tags(editor, pos - strlen(word));\n+\tif (tags)\n+\t{\n+\t\tGPtrArray *filtered = g_ptr_array_new();\n+\n+\t\tforeach_ptr_array(tag, i, tags)\n+\t\t{\n+\t\t\tif (strcmp(tag->name, word) == 0)\n+\t\t\t\tg_ptr_array_add(filtered, tag);\n+\t\t}\n+\n+\t\tg_ptr_array_free(tags, TRUE);\n+\t\ttags = filtered;\n+\t}\n+\telse\n+\t{\n+\t\t/* use all types in case language uses wrong tag type e.g. python \"members\" instead of \"methods\" */","path":"src/editor.c","position":null,"original_position":128,"commit_id":"342e636b9d46e30b05bdfe68ec4c3b5ce9695db9","original_commit_id":"91ccf4842a1f86559d419db5582683be2e1f1938","user":{"login":"techee","id":713965,"avatar_url":"https://avatars.githubusercontent.com/u/713965?v=3","gravatar_id":"","url":"https://api.github.com/users/techee","html_url":"https://github.com/techee","followers_url":"https://api.github.com/users/techee/followers","following_url":"https://api.github.com/users/techee/following{/other_user}","gists_url":"https://api.github.com/users/techee/gists{/gist_id}","starred_url":"https://api.github.com/users/techee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techee/subscriptions","organizations_url":"https://api.github.com/users/techee/orgs","repos_url":"https://api.github.com/users/techee/repos","events_url":"https://api.github.com/users/techee/events{/privacy}","received_events_url":"https://api.github.com/users/techee/received_events","type":"User","site_admin":false},"body":"In symbols.c there's yet another table which defines section names and icons used for individual tags:\r\n\r\nhttps://github.com/geany/geany/blob/master/src/symbols.c#L463","created_at":"2016-08-27T09:57:49Z","updated_at":"2016-08-27T09:57:49Z","html_url":"https://github.com/geany/geany/pull/1188#discussion_r76513785","pull_request_url":"https://api.github.com/repos/geany/geany/pulls/1188","_links":{"self":{"href":"https://api.github.com/repos/geany/geany/pulls/comments/76513785"},"html":{"href":"https://github.com/geany/geany/pull/1188#discussion_r76513785"},"pull_request":{"href":"https://api.github.com/repos/geany/geany/pulls/1188"}}},"pull_request":{"url":"https://api.github.com/repos/geany/geany/pulls/1188","id":82274558,"html_url":"https://github.com/geany/geany/pull/1188","diff_url":"https://github.com/geany/geany/pull/1188.diff","patch_url":"https://github.com/geany/geany/pull/1188.patch","issue_url":"https://api.github.com/repos/geany/geany/issues/1188","number":1188,"state":"open","locked":false,"title":"WIP: Scoped calltips","user":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"body":"Patch from https://github.com/geany/geany/pull/1177#issuecomment-241438625, plus an attempt at considering the current scope (which is likely riddled with bad stuff, but still a POC).\r\n\r\nI can drop the second (toy) patch if the first is interesting enough, and possibly make a separate PR afterward if it's somehow interesting still.  In any case, reviewing each commit separately is likely a better approach.\r\n\r\n@techee @krogank9","created_at":"2016-08-22T22:28:29Z","updated_at":"2016-08-27T09:57:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9356b077d3dc7281540aa77e3d6529cf830619ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/geany/geany/pulls/1188/commits","review_comments_url":"https://api.github.com/repos/geany/geany/pulls/1188/comments","review_comment_url":"https://api.github.com/repos/geany/geany/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geany/geany/issues/1188/comments","statuses_url":"https://api.github.com/repos/geany/geany/statuses/342e636b9d46e30b05bdfe68ec4c3b5ce9695db9","head":{"label":"b4n:scoped-calltips-wip","ref":"scoped-calltips-wip","sha":"342e636b9d46e30b05bdfe68ec4c3b5ce9695db9","user":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"repo":{"id":2737453,"name":"geany","full_name":"b4n/geany","owner":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/b4n/geany","description":"A fast and lightweight IDE","fork":true,"url":"https://api.github.com/repos/b4n/geany","forks_url":"https://api.github.com/repos/b4n/geany/forks","keys_url":"https://api.github.com/repos/b4n/geany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b4n/geany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b4n/geany/teams","hooks_url":"https://api.github.com/repos/b4n/geany/hooks","issue_events_url":"https://api.github.com/repos/b4n/geany/issues/events{/number}","events_url":"https://api.github.com/repos/b4n/geany/events","assignees_url":"https://api.github.com/repos/b4n/geany/assignees{/user}","branches_url":"https://api.github.com/repos/b4n/geany/branches{/branch}","tags_url":"https://api.github.com/repos/b4n/geany/tags","blobs_url":"https://api.github.com/repos/b4n/geany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b4n/geany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b4n/geany/git/refs{/sha}","trees_url":"https://api.github.com/repos/b4n/geany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b4n/geany/statuses/{sha}","languages_url":"https://api.github.com/repos/b4n/geany/languages","stargazers_url":"https://api.github.com/repos/b4n/geany/stargazers","contributors_url":"https://api.github.com/repos/b4n/geany/contributors","subscribers_url":"https://api.github.com/repos/b4n/geany/subscribers","subscription_url":"https://api.github.com/repos/b4n/geany/subscription","commits_url":"https://api.github.com/repos/b4n/geany/commits{/sha}","git_commits_url":"https://api.github.com/repos/b4n/geany/git/commits{/sha}","comments_url":"https://api.github.com/repos/b4n/geany/comments{/number}","issue_comment_url":"https://api.github.com/repos/b4n/geany/issues/comments{/number}","contents_url":"https://api.github.com/repos/b4n/geany/contents/{+path}","compare_url":"https://api.github.com/repos/b4n/geany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b4n/geany/merges","archive_url":"https://api.github.com/repos/b4n/geany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b4n/geany/downloads","issues_url":"https://api.github.com/repos/b4n/geany/issues{/number}","pulls_url":"https://api.github.com/repos/b4n/geany/pulls{/number}","milestones_url":"https://api.github.com/repos/b4n/geany/milestones{/number}","notifications_url":"https://api.github.com/repos/b4n/geany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b4n/geany/labels{/name}","releases_url":"https://api.github.com/repos/b4n/geany/releases{/id}","deployments_url":"https://api.github.com/repos/b4n/geany/deployments","created_at":"2011-11-08T21:50:08Z","updated_at":"2016-02-28T09:10:20Z","pushed_at":"2016-08-23T12:37:44Z","git_url":"git://github.com/b4n/geany.git","ssh_url":"git@github.com:b4n/geany.git","clone_url":"https://github.com/b4n/geany.git","svn_url":"https://github.com/b4n/geany","homepage":"http://www.geany.org","size":51064,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"geany:master","ref":"master","sha":"095d88958296200ee890dc2b45e0123f1559705b","user":{"login":"geany","id":1108795,"avatar_url":"https://avatars.githubusercontent.com/u/1108795?v=3","gravatar_id":"","url":"https://api.github.com/users/geany","html_url":"https://github.com/geany","followers_url":"https://api.github.com/users/geany/followers","following_url":"https://api.github.com/users/geany/following{/other_user}","gists_url":"https://api.github.com/users/geany/gists{/gist_id}","starred_url":"https://api.github.com/users/geany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geany/subscriptions","organizations_url":"https://api.github.com/users/geany/orgs","repos_url":"https://api.github.com/users/geany/repos","events_url":"https://api.github.com/users/geany/events{/privacy}","received_events_url":"https://api.github.com/users/geany/received_events","type":"Organization","site_admin":false},"repo":{"id":2532922,"name":"geany","full_name":"geany/geany","owner":{"login":"geany","id":1108795,"avatar_url":"https://avatars.githubusercontent.com/u/1108795?v=3","gravatar_id":"","url":"https://api.github.com/users/geany","html_url":"https://github.com/geany","followers_url":"https://api.github.com/users/geany/followers","following_url":"https://api.github.com/users/geany/following{/other_user}","gists_url":"https://api.github.com/users/geany/gists{/gist_id}","starred_url":"https://api.github.com/users/geany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geany/subscriptions","organizations_url":"https://api.github.com/users/geany/orgs","repos_url":"https://api.github.com/users/geany/repos","events_url":"https://api.github.com/users/geany/events{/privacy}","received_events_url":"https://api.github.com/users/geany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geany/geany","description":"A fast and lightweight IDE","fork":false,"url":"https://api.github.com/repos/geany/geany","forks_url":"https://api.github.com/repos/geany/geany/forks","keys_url":"https://api.github.com/repos/geany/geany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geany/geany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geany/geany/teams","hooks_url":"https://api.github.com/repos/geany/geany/hooks","issue_events_url":"https://api.github.com/repos/geany/geany/issues/events{/number}","events_url":"https://api.github.com/repos/geany/geany/events","assignees_url":"https://api.github.com/repos/geany/geany/assignees{/user}","branches_url":"https://api.github.com/repos/geany/geany/branches{/branch}","tags_url":"https://api.github.com/repos/geany/geany/tags","blobs_url":"https://api.github.com/repos/geany/geany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geany/geany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geany/geany/git/refs{/sha}","trees_url":"https://api.github.com/repos/geany/geany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geany/geany/statuses/{sha}","languages_url":"https://api.github.com/repos/geany/geany/languages","stargazers_url":"https://api.github.com/repos/geany/geany/stargazers","contributors_url":"https://api.github.com/repos/geany/geany/contributors","subscribers_url":"https://api.github.com/repos/geany/geany/subscribers","subscription_url":"https://api.github.com/repos/geany/geany/subscription","commits_url":"https://api.github.com/repos/geany/geany/commits{/sha}","git_commits_url":"https://api.github.com/repos/geany/geany/git/commits{/sha}","comments_url":"https://api.github.com/repos/geany/geany/comments{/number}","issue_comment_url":"https://api.github.com/repos/geany/geany/issues/comments{/number}","contents_url":"https://api.github.com/repos/geany/geany/contents/{+path}","compare_url":"https://api.github.com/repos/geany/geany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geany/geany/merges","archive_url":"https://api.github.com/repos/geany/geany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geany/geany/downloads","issues_url":"https://api.github.com/repos/geany/geany/issues{/number}","pulls_url":"https://api.github.com/repos/geany/geany/pulls{/number}","milestones_url":"https://api.github.com/repos/geany/geany/milestones{/number}","notifications_url":"https://api.github.com/repos/geany/geany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geany/geany/labels{/name}","releases_url":"https://api.github.com/repos/geany/geany/releases{/id}","deployments_url":"https://api.github.com/repos/geany/geany/deployments","created_at":"2011-10-07T14:25:32Z","updated_at":"2016-08-27T08:53:49Z","pushed_at":"2016-08-25T22:12:48Z","git_url":"git://github.com/geany/geany.git","ssh_url":"git@github.com:geany/geany.git","clone_url":"https://github.com/geany/geany.git","svn_url":"https://github.com/geany/geany","homepage":"http://www.geany.org","size":58652,"stargazers_count":798,"watchers_count":798,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":397,"forks":277,"open_issues":397,"watchers":798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geany/geany/pulls/1188"},"html":{"href":"https://github.com/geany/geany/pull/1188"},"issue":{"href":"https://api.github.com/repos/geany/geany/issues/1188"},"comments":{"href":"https://api.github.com/repos/geany/geany/issues/1188/comments"},"review_comments":{"href":"https://api.github.com/repos/geany/geany/pulls/1188/comments"},"review_comment":{"href":"https://api.github.com/repos/geany/geany/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geany/geany/pulls/1188/commits"},"statuses":{"href":"https://api.github.com/repos/geany/geany/statuses/342e636b9d46e30b05bdfe68ec4c3b5ce9695db9"}}}}
{"actor":{"display_login":"techee"}}