{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/34970","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/34970/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/34970/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/34970/events","html_url":"https://github.com/rust-lang/rust/pull/34970","id":166970302,"number":34970,"title":"Add diagnostics for rustc_metadata","user":{"login":"jhod0","id":8944001,"avatar_url":"https://avatars.githubusercontent.com/u/8944001?v=3","gravatar_id":"","url":"https://api.github.com/users/jhod0","html_url":"https://github.com/jhod0","followers_url":"https://api.github.com/users/jhod0/followers","following_url":"https://api.github.com/users/jhod0/following{/other_user}","gists_url":"https://api.github.com/users/jhod0/gists{/gist_id}","starred_url":"https://api.github.com/users/jhod0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhod0/subscriptions","organizations_url":"https://api.github.com/users/jhod0/orgs","repos_url":"https://api.github.com/users/jhod0/repos","events_url":"https://api.github.com/users/jhod0/events{/privacy}","received_events_url":"https://api.github.com/users/jhod0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-07-22T04:59:09Z","updated_at":"2016-07-22T22:57:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/34970","html_url":"https://github.com/rust-lang/rust/pull/34970","diff_url":"https://github.com/rust-lang/rust/pull/34970.diff","patch_url":"https://github.com/rust-lang/rust/pull/34970.patch"},"body":"Part of #32777 \r\n\r\nDiagnostics messages are added for:\r\nE0466 E0467 E0468 E0469 E0470\r\n\r\nAdditionally, rustc_driver is modified so that rustc_metadata diagnostics are available at runtime\r\n\r\ncc @GuillaumeGomez "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/234676633","html_url":"https://github.com/rust-lang/rust/pull/34970#issuecomment-234676633","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/34970","id":234676633,"user":{"login":"jhod0","id":8944001,"avatar_url":"https://avatars.githubusercontent.com/u/8944001?v=3","gravatar_id":"","url":"https://api.github.com/users/jhod0","html_url":"https://github.com/jhod0","followers_url":"https://api.github.com/users/jhod0/followers","following_url":"https://api.github.com/users/jhod0/following{/other_user}","gists_url":"https://api.github.com/users/jhod0/gists{/gist_id}","starred_url":"https://api.github.com/users/jhod0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhod0/subscriptions","organizations_url":"https://api.github.com/users/jhod0/orgs","repos_url":"https://api.github.com/users/jhod0/repos","events_url":"https://api.github.com/users/jhod0/events{/privacy}","received_events_url":"https://api.github.com/users/jhod0/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T22:57:27Z","updated_at":"2016-07-22T22:57:27Z","body":"Now that the metadata diagnostics are registered, it runs some doctests which were not previously registered.\r\n\r\nSo they had never been checked before, and naturally, they failed. I set them to ignore\r\n\r\nThat's not a cop-out: the failing tests were about attributes to `extern crate`'s, there was no real functionality going on. I suppose they could be set to `compile_fail`"}}
{"actor":{"display_login":"jhod0"}}