{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/31200","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/31200/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/31200/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/31200/events","html_url":"https://github.com/saltstack/salt/pull/31200","id":133474112,"number":31200,"title":"py3 rejects foo.decode(\"base64\") so switch to base64.b64decode(foo)","user":{"login":"FirefighterBlu3","id":3165044,"avatar_url":"https://avatars.githubusercontent.com/u/3165044?v=3","gravatar_id":"","url":"https://api.github.com/users/FirefighterBlu3","html_url":"https://github.com/FirefighterBlu3","followers_url":"https://api.github.com/users/FirefighterBlu3/followers","following_url":"https://api.github.com/users/FirefighterBlu3/following{/other_user}","gists_url":"https://api.github.com/users/FirefighterBlu3/gists{/gist_id}","starred_url":"https://api.github.com/users/FirefighterBlu3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirefighterBlu3/subscriptions","organizations_url":"https://api.github.com/users/FirefighterBlu3/orgs","repos_url":"https://api.github.com/users/FirefighterBlu3/repos","events_url":"https://api.github.com/users/FirefighterBlu3/events{/privacy}","received_events_url":"https://api.github.com/users/FirefighterBlu3/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-13T21:16:35Z","updated_at":"2016-03-03T18:46:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/31200","html_url":"https://github.com/saltstack/salt/pull/31200","diff_url":"https://github.com/saltstack/salt/pull/31200.diff","patch_url":"https://github.com/saltstack/salt/pull/31200.patch"},"body":"```log\r\n[ERROR   ] An un-handled exception from the multiprocessing process 'MWorker-2' was caught:\r\nTraceback (most recent call last):\r\n  File \"/home/david/Desktop/Projects/salt/salt/utils/process.py\", line 613, in _run\r\n    return self._original_run()\r\n  File \"/home/david/Desktop/Projects/salt/salt/master.py\", line 866, in run\r\n    self.__bind()\r\n  File \"/home/david/Desktop/Projects/salt/salt/master.py\", line 795, in __bind\r\n    req_channel.post_fork(self._handle_payload, io_loop=self.io_loop)  # TODO: cleaner? Maybe lazily?\r\n  File \"/home/david/Desktop/Projects/salt/salt/transport/zeromq.py\", line 535, in post_fork\r\n    salt.transport.mixins.auth.AESReqServerMixin.post_fork(self, payload_handler, io_loop)\r\n  File \"/home/david/Desktop/Projects/salt/salt/transport/mixins/auth.py\", line 75, in post_fork\r\n    self.crypticle = salt.crypt.Crypticle(self.opts, salt.master.SMaster.secrets['aes']['secret'].value)\r\n  File \"/home/david/Desktop/Projects/salt/salt/crypt.py\", line 1136, in __init__\r\n    self.keys = self.extract_keys(self.key_string, key_size)\r\n  File \"/home/david/Desktop/Projects/salt/salt/crypt.py\", line 1150, in extract_keys\r\n    key = key_string.decode('base64')\r\nLookupError: 'base64' is not a text encoding; use codecs.decode() to handle arbitrary codecs\r\n```\r\n\r\nsince we are already using the base64 module in some places, continue using it for consistency rather than import yet another module (codecs).\r\n\r\nthis makes for a happy py2 and py3"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/191909553","html_url":"https://github.com/saltstack/salt/pull/31200#issuecomment-191909553","issue_url":"https://api.github.com/repos/saltstack/salt/issues/31200","id":191909553,"user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T18:46:17Z","updated_at":"2016-03-03T18:46:17Z","body":"@FirefighterBlu3 Nice! Now that we've got that change in, we just need to address the failing tests. Is there anything I can do to help there?"}}