{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/51973337","id":51973337,"diff_hunk":"@@ -1,17 +1,23 @@\n {\n-  \"dependencies\": {\n-    \"System.Collections\": \"4.0.0\",\n-    \"System.Collections.NonGeneric\": \"4.0.0\",\n-    \"System.Globalization\": \"4.0.0\",\n-    \"System.IO\": \"4.0.0\",\n-    \"System.Resources.ResourceManager\": \"4.0.0\",\n-    \"System.Text.RegularExpressions\": \"4.0.0\",\n-    \"System.Runtime\": \"4.0.0\",\n-    \"System.Runtime.Extensions\": \"4.0.0\",\n-    \"System.Threading.Tasks\": \"4.0.0\",\n-    \"System.Diagnostics.Tools\": \"4.0.0\"\n-  },\n   \"frameworks\": {\n-    \"dnxcore50\": {}\n+    \"dotnet5.1\": {\n+      \"dependencies\": {\n+        \"System.Collections\": \"4.0.0\",\n+        \"System.Diagnostics.Debug\": \"4.0.0\",\n+        \"System.Diagnostics.Tools\": \"4.0.0\",\n+        \"System.Globalization\": \"4.0.0\",\n+        \"System.IO\": \"4.0.0\",\n+        \"System.Resources.ResourceManager\": \"4.0.0\",\n+        \"System.Runtime\": \"4.0.0\",\n+        \"System.Runtime.Extensions\": \"4.0.0\",\n+        \"System.Text.RegularExpressions\": \"4.0.0\",\n+        \"System.Threading.Tasks\": \"4.0.0\"\n+      }\n+    },\n+    \"net45\": {\n+      \"dependencies\": {\n+        \"Microsoft.TargetingPack.NETFramework.v4.5\": \"1.0.1\"","path":"src/System.Data.Common/src/project.json","position":32,"original_position":32,"commit_id":"b2ca979bde934da5ef3ac4271b3e94b7e517359f","original_commit_id":"b2ca979bde934da5ef3ac4271b3e94b7e517359f","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"body":"Yeah, I noticed this just a bit ago when I was trying to use that rule to upgrade the targetingpack dependencies. In my (TFS) changes I've included `(?i)` near the beginning of each rule, although we could also fix this by changing the regex mode in buildtools.","created_at":"2016-02-05T03:27:27Z","updated_at":"2016-02-05T03:27:27Z","html_url":"https://github.com/dotnet/corefx/pull/5913#discussion_r51973337","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/5913","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/51973337"},"html":{"href":"https://github.com/dotnet/corefx/pull/5913#discussion_r51973337"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5913"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/5913","id":58372759,"html_url":"https://github.com/dotnet/corefx/pull/5913","diff_url":"https://github.com/dotnet/corefx/pull/5913.diff","patch_url":"https://github.com/dotnet/corefx/pull/5913.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/5913","number":5913,"state":"open","locked":false,"title":"System.data.common dotnet5.1","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"body":"System.Data.Common needs to support dotnet5.1 & net45 but was\r\ncurrently targeting dotnet5.4 and net46.\r\n\r\nThis fixes both the portable implementation and the facade and merges\r\nthe facade into the main project.\r\n\r\n/cc @weshaggard @saurabh500 @chcosta ","created_at":"2016-02-05T00:38:03Z","updated_at":"2016-02-05T03:27:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02fb90ad4ee911d24052fa1babecc4f341b25381","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/5913/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/5913/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/5913/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/b2ca979bde934da5ef3ac4271b3e94b7e517359f","head":{"label":"ericstj:system.data.common-dotnet5.1","ref":"system.data.common-dotnet5.1","sha":"b2ca979bde934da5ef3ac4271b3e94b7e517359f","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"repo":{"id":27736722,"name":"corefx","full_name":"ericstj/corefx","owner":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericstj/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/ericstj/corefx","forks_url":"https://api.github.com/repos/ericstj/corefx/forks","keys_url":"https://api.github.com/repos/ericstj/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericstj/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericstj/corefx/teams","hooks_url":"https://api.github.com/repos/ericstj/corefx/hooks","issue_events_url":"https://api.github.com/repos/ericstj/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ericstj/corefx/events","assignees_url":"https://api.github.com/repos/ericstj/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ericstj/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ericstj/corefx/tags","blobs_url":"https://api.github.com/repos/ericstj/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericstj/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericstj/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericstj/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericstj/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ericstj/corefx/languages","stargazers_url":"https://api.github.com/repos/ericstj/corefx/stargazers","contributors_url":"https://api.github.com/repos/ericstj/corefx/contributors","subscribers_url":"https://api.github.com/repos/ericstj/corefx/subscribers","subscription_url":"https://api.github.com/repos/ericstj/corefx/subscription","commits_url":"https://api.github.com/repos/ericstj/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericstj/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericstj/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericstj/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericstj/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ericstj/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericstj/corefx/merges","archive_url":"https://api.github.com/repos/ericstj/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericstj/corefx/downloads","issues_url":"https://api.github.com/repos/ericstj/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ericstj/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ericstj/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ericstj/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericstj/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ericstj/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ericstj/corefx/deployments","created_at":"2014-12-08T21:44:45Z","updated_at":"2016-01-11T20:03:34Z","pushed_at":"2016-02-05T00:48:33Z","git_url":"git://github.com/ericstj/corefx.git","ssh_url":"git@github.com:ericstj/corefx.git","clone_url":"https://github.com/ericstj/corefx.git","svn_url":"https://github.com/ericstj/corefx","homepage":"","size":51296,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c4251554ef65d96ba4dee7f5313ae3a37da5ea19","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-02-04T23:00:23Z","pushed_at":"2016-02-05T02:45:31Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":61802,"stargazers_count":9079,"watchers_count":9079,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2104,"mirror_url":null,"open_issues_count":817,"forks":2104,"open_issues":817,"watchers":9079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5913"},"html":{"href":"https://github.com/dotnet/corefx/pull/5913"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5913"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5913/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5913/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5913/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/b2ca979bde934da5ef3ac4271b3e94b7e517359f"}}}}