{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/86249810","pull_request_review_id":6917379,"id":86249810,"diff_hunk":"@@ -38,13 +38,11 @@ class Libelf(Package):\n     version('0.8.12', 'e21f8273d9f5f6d43a59878dc274fec7')\n \n     provides('elf')\n+    depends_on('automake')\n \n-    def install(self, spec, prefix):\n-        configure(\"--prefix=\" + prefix,\n-                  \"--enable-shared\",\n-                  \"--disable-dependency-tracking\",\n-                  \"--disable-debug\")\n-        make()\n-\n-        # The mkdir commands in libelf's install can fail in parallel\n-        make(\"install\", parallel=False)","path":"var/spack/repos/builtin/packages/libelf/package.py","position":23,"original_position":23,"commit_id":"e10d497982a7ed093acc9fd66ee7bf22352aa902","original_commit_id":"e10d497982a7ed093acc9fd66ee7bf22352aa902","user":{"login":"lee218llnl","id":3641995,"avatar_url":"https://avatars.githubusercontent.com/u/3641995?v=3","gravatar_id":"","url":"https://api.github.com/users/lee218llnl","html_url":"https://github.com/lee218llnl","followers_url":"https://api.github.com/users/lee218llnl/followers","following_url":"https://api.github.com/users/lee218llnl/following{/other_user}","gists_url":"https://api.github.com/users/lee218llnl/gists{/gist_id}","starred_url":"https://api.github.com/users/lee218llnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee218llnl/subscriptions","organizations_url":"https://api.github.com/users/lee218llnl/orgs","repos_url":"https://api.github.com/users/lee218llnl/repos","events_url":"https://api.github.com/users/lee218llnl/events{/privacy}","received_events_url":"https://api.github.com/users/lee218llnl/received_events","type":"User","site_admin":false},"body":"it worked OK for me, should I put it back in case it is still broken for others?","created_at":"2016-11-02T21:45:35Z","updated_at":"2016-11-02T21:45:35Z","html_url":"https://github.com/LLNL/spack/pull/2221#discussion_r86249810","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/2221","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/86249810"},"html":{"href":"https://github.com/LLNL/spack/pull/2221#discussion_r86249810"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2221"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/2221","id":92058186,"html_url":"https://github.com/LLNL/spack/pull/2221","diff_url":"https://github.com/LLNL/spack/pull/2221.diff","patch_url":"https://github.com/LLNL/spack/pull/2221.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/2221","number":2221,"state":"open","locked":false,"title":"patch older config.guess for newer architectures","user":{"login":"lee218llnl","id":3641995,"avatar_url":"https://avatars.githubusercontent.com/u/3641995?v=3","gravatar_id":"","url":"https://api.github.com/users/lee218llnl","html_url":"https://github.com/lee218llnl","followers_url":"https://api.github.com/users/lee218llnl/followers","following_url":"https://api.github.com/users/lee218llnl/following{/other_user}","gists_url":"https://api.github.com/users/lee218llnl/gists{/gist_id}","starred_url":"https://api.github.com/users/lee218llnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee218llnl/subscriptions","organizations_url":"https://api.github.com/users/lee218llnl/orgs","repos_url":"https://api.github.com/users/lee218llnl/repos","events_url":"https://api.github.com/users/lee218llnl/events{/privacy}","received_events_url":"https://api.github.com/users/lee218llnl/received_events","type":"User","site_admin":false},"body":"For issue #2063.\r\n\r\n@becker33 @tgamblin ","created_at":"2016-11-02T21:22:49Z","updated_at":"2016-11-02T21:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"862ab83a1119b5539a216973ea1ccb850b862c1c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/2221/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/2221/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/2221/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/e10d497982a7ed093acc9fd66ee7bf22352aa902","head":{"label":"LLNL:features/config_guess_gh_2063","ref":"features/config_guess_gh_2063","sha":"e10d497982a7ed093acc9fd66ee7bf22352aa902","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-11-01T21:16:54Z","pushed_at":"2016-11-02T21:22:49Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":21030,"stargazers_count":167,"watchers_count":167,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":154,"mirror_url":null,"open_issues_count":379,"forks":154,"open_issues":379,"watchers":167,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"b706da1109e5bf71f3f7ffd56598677ebb9c3dad","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-11-01T21:16:54Z","pushed_at":"2016-11-02T21:22:49Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":21030,"stargazers_count":167,"watchers_count":167,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":154,"mirror_url":null,"open_issues_count":379,"forks":154,"open_issues":379,"watchers":167,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2221"},"html":{"href":"https://github.com/LLNL/spack/pull/2221"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/2221"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/2221/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2221/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2221/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/e10d497982a7ed093acc9fd66ee7bf22352aa902"}}}}
{"actor":{"display_login":"lee218llnl"}}