{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/62090583","id":62090583,"diff_hunk":"@@ -132,47 +130,29 @@ typedef enum\n   ECMA_INTERNAL_PROPERTY_PRIMITIVE_NUMBER_VALUE, /**< [[Primitive value]] for Number objects */\n   ECMA_INTERNAL_PROPERTY_PRIMITIVE_BOOLEAN_VALUE, /**< [[Primitive value]] for Boolean objects */\n \n-  /** Part of an array, that is indexed by numbers */\n-  ECMA_INTERNAL_PROPERTY_NUMBER_INDEXED_ARRAY_VALUES,\n+  ECMA_INTERNAL_PROPERTY_BUILT_IN_ID, /**< Implementation-defined identifier of built-in object */\n \n-  /** Part of an array, that is indexed by strings */\n-  ECMA_INTERNAL_PROPERTY_STRING_INDEXED_ARRAY_VALUES,\n-\n-  /** Implementation-defined identifier of built-in object */\n-  ECMA_INTERNAL_PROPERTY_BUILT_IN_ID,\n-\n-  /** Implementation-defined identifier of built-in routine\n-      that corresponds to a built-in function object\n-      ([[Built-in routine's description]]) */\n-  ECMA_INTERNAL_PROPERTY_BUILT_IN_ROUTINE_DESC,\n-\n-  /** Identifier of implementation-defined extension object */\n-  ECMA_INTERNAL_PROPERTY_EXTENSION_ID,\n+  ECMA_INTERNAL_PROPERTY_BUILT_IN_ROUTINE_DESC,   /**< Implementation-defined identifier of built-in routine\n+                                                   * that corresponds to a built-in function object\n+                                                   * ([[Built-in routine's description]])\n+                                                   */\n \n   /** Bound function internal properties **/\n   ECMA_INTERNAL_PROPERTY_BOUND_FUNCTION_TARGET_FUNCTION,\n   ECMA_INTERNAL_PROPERTY_BOUND_FUNCTION_BOUND_THIS,\n   ECMA_INTERNAL_PROPERTY_BOUND_FUNCTION_BOUND_ARGS,\n \n-  /**\n-   * Bit-mask of non-instantiated built-in's properties (bits 0-31)\n-   */\n-  ECMA_INTERNAL_PROPERTY_NON_INSTANTIATED_BUILT_IN_MASK_0_31,\n+  ECMA_INTERNAL_PROPERTY_NON_INSTANTIATED_BUILT_IN_MASK_0_31, /**< Bit-mask of non-instantiated\n+                                                               * built-in's properties (bits 0-31)\n+                                                               */","path":"jerry-core/ecma/base/ecma-globals.h","position":46,"original_position":46,"commit_id":"e81513d0dc9f4587f7199fe01ff56892b60ce22c","original_commit_id":"e81513d0dc9f4587f7199fe01ff56892b60ce22c","user":{"login":"zherczeg","id":2270193,"avatar_url":"https://avatars.githubusercontent.com/u/2270193?v=3","gravatar_id":"","url":"https://api.github.com/users/zherczeg","html_url":"https://github.com/zherczeg","followers_url":"https://api.github.com/users/zherczeg/followers","following_url":"https://api.github.com/users/zherczeg/following{/other_user}","gists_url":"https://api.github.com/users/zherczeg/gists{/gist_id}","starred_url":"https://api.github.com/users/zherczeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherczeg/subscriptions","organizations_url":"https://api.github.com/users/zherczeg/orgs","repos_url":"https://api.github.com/users/zherczeg/repos","events_url":"https://api.github.com/users/zherczeg/events{/privacy}","received_events_url":"https://api.github.com/users/zherczeg/received_events","type":"User","site_admin":false},"body":"Do we still need these two numbers?","created_at":"2016-05-04T18:31:41Z","updated_at":"2016-05-04T18:31:41Z","html_url":"https://github.com/Samsung/jerryscript/pull/1040#discussion_r62090583","pull_request_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040","_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/62090583"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/1040#discussion_r62090583"},"pull_request":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040","id":68870064,"html_url":"https://github.com/Samsung/jerryscript/pull/1040","diff_url":"https://github.com/Samsung/jerryscript/pull/1040.diff","patch_url":"https://github.com/Samsung/jerryscript/pull/1040.patch","issue_url":"https://api.github.com/repos/Samsung/jerryscript/issues/1040","number":1040,"state":"open","locked":false,"title":"Unified the commenting form of the internal properties and removed th…","user":{"login":"robertsipka","id":4920564,"avatar_url":"https://avatars.githubusercontent.com/u/4920564?v=3","gravatar_id":"","url":"https://api.github.com/users/robertsipka","html_url":"https://github.com/robertsipka","followers_url":"https://api.github.com/users/robertsipka/followers","following_url":"https://api.github.com/users/robertsipka/following{/other_user}","gists_url":"https://api.github.com/users/robertsipka/gists{/gist_id}","starred_url":"https://api.github.com/users/robertsipka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertsipka/subscriptions","organizations_url":"https://api.github.com/users/robertsipka/orgs","repos_url":"https://api.github.com/users/robertsipka/repos","events_url":"https://api.github.com/users/robertsipka/events{/privacy}","received_events_url":"https://api.github.com/users/robertsipka/received_events","type":"User","site_admin":false},"body":"…e unused types.\r\n\r\nJerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com","created_at":"2016-05-04T14:22:00Z","updated_at":"2016-05-04T18:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74a0ee02b81190ddff7149f6cd8c41ed11b8fae0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040/commits","review_comments_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040/comments","review_comment_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/issues/1040/comments","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/e81513d0dc9f4587f7199fe01ff56892b60ce22c","head":{"label":"robertsipka:remove_unused_internal_properties","ref":"remove_unused_internal_properties","sha":"e81513d0dc9f4587f7199fe01ff56892b60ce22c","user":{"login":"robertsipka","id":4920564,"avatar_url":"https://avatars.githubusercontent.com/u/4920564?v=3","gravatar_id":"","url":"https://api.github.com/users/robertsipka","html_url":"https://github.com/robertsipka","followers_url":"https://api.github.com/users/robertsipka/followers","following_url":"https://api.github.com/users/robertsipka/following{/other_user}","gists_url":"https://api.github.com/users/robertsipka/gists{/gist_id}","starred_url":"https://api.github.com/users/robertsipka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertsipka/subscriptions","organizations_url":"https://api.github.com/users/robertsipka/orgs","repos_url":"https://api.github.com/users/robertsipka/repos","events_url":"https://api.github.com/users/robertsipka/events{/privacy}","received_events_url":"https://api.github.com/users/robertsipka/received_events","type":"User","site_admin":false},"repo":{"id":51063380,"name":"jerryscript","full_name":"robertsipka/jerryscript","owner":{"login":"robertsipka","id":4920564,"avatar_url":"https://avatars.githubusercontent.com/u/4920564?v=3","gravatar_id":"","url":"https://api.github.com/users/robertsipka","html_url":"https://github.com/robertsipka","followers_url":"https://api.github.com/users/robertsipka/followers","following_url":"https://api.github.com/users/robertsipka/following{/other_user}","gists_url":"https://api.github.com/users/robertsipka/gists{/gist_id}","starred_url":"https://api.github.com/users/robertsipka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertsipka/subscriptions","organizations_url":"https://api.github.com/users/robertsipka/orgs","repos_url":"https://api.github.com/users/robertsipka/repos","events_url":"https://api.github.com/users/robertsipka/events{/privacy}","received_events_url":"https://api.github.com/users/robertsipka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertsipka/jerryscript","description":"Ultra-lightweight JavaScript engine for Internet of Things. http://www.jerryscript.net","fork":true,"url":"https://api.github.com/repos/robertsipka/jerryscript","forks_url":"https://api.github.com/repos/robertsipka/jerryscript/forks","keys_url":"https://api.github.com/repos/robertsipka/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertsipka/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertsipka/jerryscript/teams","hooks_url":"https://api.github.com/repos/robertsipka/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/robertsipka/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/robertsipka/jerryscript/events","assignees_url":"https://api.github.com/repos/robertsipka/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/robertsipka/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/robertsipka/jerryscript/tags","blobs_url":"https://api.github.com/repos/robertsipka/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertsipka/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertsipka/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertsipka/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertsipka/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/robertsipka/jerryscript/languages","stargazers_url":"https://api.github.com/repos/robertsipka/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/robertsipka/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/robertsipka/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/robertsipka/jerryscript/subscription","commits_url":"https://api.github.com/repos/robertsipka/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertsipka/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertsipka/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertsipka/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertsipka/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/robertsipka/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertsipka/jerryscript/merges","archive_url":"https://api.github.com/repos/robertsipka/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertsipka/jerryscript/downloads","issues_url":"https://api.github.com/repos/robertsipka/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/robertsipka/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/robertsipka/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/robertsipka/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertsipka/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/robertsipka/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/robertsipka/jerryscript/deployments","created_at":"2016-02-04T08:49:02Z","updated_at":"2016-02-04T08:49:05Z","pushed_at":"2016-05-04T14:21:43Z","git_url":"git://github.com/robertsipka/jerryscript.git","ssh_url":"git@github.com:robertsipka/jerryscript.git","clone_url":"https://github.com/robertsipka/jerryscript.git","svn_url":"https://github.com/robertsipka/jerryscript","homepage":"","size":10118,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"7813801cd32c7307550fc5b328ae85e38c90712b","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"Samsung/jerryscript","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/jerryscript","description":"Ultra-lightweight JavaScript engine for Internet of Things. http://www.jerryscript.net","fork":false,"url":"https://api.github.com/repos/Samsung/jerryscript","forks_url":"https://api.github.com/repos/Samsung/jerryscript/forks","keys_url":"https://api.github.com/repos/Samsung/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/jerryscript/teams","hooks_url":"https://api.github.com/repos/Samsung/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/Samsung/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/jerryscript/events","assignees_url":"https://api.github.com/repos/Samsung/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/jerryscript/tags","blobs_url":"https://api.github.com/repos/Samsung/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/jerryscript/languages","stargazers_url":"https://api.github.com/repos/Samsung/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/Samsung/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/Samsung/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/Samsung/jerryscript/subscription","commits_url":"https://api.github.com/repos/Samsung/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/jerryscript/merges","archive_url":"https://api.github.com/repos/Samsung/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/jerryscript/downloads","issues_url":"https://api.github.com/repos/Samsung/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2016-05-04T16:50:06Z","pushed_at":"2016-05-04T17:26:56Z","git_url":"git://github.com/Samsung/jerryscript.git","ssh_url":"git@github.com:Samsung/jerryscript.git","clone_url":"https://github.com/Samsung/jerryscript.git","svn_url":"https://github.com/Samsung/jerryscript","homepage":"","size":21853,"stargazers_count":1256,"watchers_count":1256,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":137,"mirror_url":null,"open_issues_count":61,"forks":137,"open_issues":61,"watchers":1256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/1040"},"issue":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/1040"},"comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/1040/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1040/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/jerryscript/statuses/e81513d0dc9f4587f7199fe01ff56892b60ce22c"}}}}