{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9400","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9400/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9400/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9400/events","html_url":"https://github.com/bitcoin/bitcoin/pull/9400","id":196940064,"number":9400,"title":"Set peers as HB peers upon full block validation","user":{"login":"instagibbs","id":5767891,"avatar_url":"https://avatars.githubusercontent.com/u/5767891?v=3","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"labels":[{"id":98298007,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-21T14:02:04Z","updated_at":"2016-12-21T16:18:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9400","html_url":"https://github.com/bitcoin/bitcoin/pull/9400","diff_url":"https://github.com/bitcoin/bitcoin/pull/9400.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/9400.patch"},"body":"We would rather select HB peers to be those that are getting us full valid blocks the fastest, versus merely letting us know about the next valid PoW block header the earliest. Currently a peer can just share a header, withhold the full block, and be selected as a HB peer, denying other less-malicious peers their slot. The attacker could possibly get 3 connections with the node, then block all useful CB propagation gains.\r\n\r\nAfter this fix the worst that can happen is malicious peers are first to give you valid full blocks to stay in the HB slots.\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/268564171","html_url":"https://github.com/bitcoin/bitcoin/pull/9400#issuecomment-268564171","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9400","id":268564171,"user":{"login":"rebroad","id":1530283,"avatar_url":"https://avatars.githubusercontent.com/u/1530283?v=3","gravatar_id":"","url":"https://api.github.com/users/rebroad","html_url":"https://github.com/rebroad","followers_url":"https://api.github.com/users/rebroad/followers","following_url":"https://api.github.com/users/rebroad/following{/other_user}","gists_url":"https://api.github.com/users/rebroad/gists{/gist_id}","starred_url":"https://api.github.com/users/rebroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebroad/subscriptions","organizations_url":"https://api.github.com/users/rebroad/orgs","repos_url":"https://api.github.com/users/rebroad/repos","events_url":"https://api.github.com/users/rebroad/events{/privacy}","received_events_url":"https://api.github.com/users/rebroad/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T16:18:33Z","updated_at":"2016-12-21T16:18:33Z","body":"Is it still the case that the first peer to send us the header is the only peer we'll request the block from (with a timeout for non-response of 10 minutes)? "}}
{"actor":{"display_login":"rebroad"}}