{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/comments/71064987","id":71064987,"diff_hunk":"@@ -455,15 +469,17 @@ function do_install(package::Package)\n     local err = nothing\n     for cmd = [`7z x -y $path2 -o$cache`, `7z x -y $cpio -o$installdir`]\n         (out, pc) = open(cmd,\"r\")\n-        stdoutstr = readall(out)\n+        stdoutstr = readstring(out)\n         if !success(pc)\n             wait_close(out)\n             println(stdoutstr)\n             err = pc\n-            @unix_only cd(installdir) do\n-                if success(`rpm2cpio $path2` | `cpio -imud`)\n-                    err = nothing\n-                end\n+            if is_unix()\n+                cd(installdir) do\n+                  if success(`rpm2cpio $path2` | `cpio -imud`)","path":"src/WinRPM.jl","position":97,"original_position":97,"commit_id":"7964265a9d3b033e08b1b60569fbbe8f788336b6","original_commit_id":"7964265a9d3b033e08b1b60569fbbe8f788336b6","user":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"body":"ugh, my editor settings are messed up on windows -.-","created_at":"2016-07-16T11:43:03Z","updated_at":"2016-07-16T11:43:03Z","html_url":"https://github.com/JuliaLang/WinRPM.jl/pull/77#discussion_r71064987","pull_request_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/comments/71064987"},"html":{"href":"https://github.com/JuliaLang/WinRPM.jl/pull/77#discussion_r71064987"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77","id":74081896,"html_url":"https://github.com/JuliaLang/WinRPM.jl/pull/77","diff_url":"https://github.com/JuliaLang/WinRPM.jl/pull/77.diff","patch_url":"https://github.com/JuliaLang/WinRPM.jl/pull/77.patch","issue_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/issues/77","number":77,"state":"open","locked":false,"title":"Fix Depwarns","user":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"body":"I just tried using WinRPM on 0.4, not sure if that's a sufficient test... Actually, the depwarns are so bad, that WinRPM just stops installing binaries without any error. So this also needs the depwarn removal from LibExpat (amitmurthy/LibExpat.jl#45)","created_at":"2016-06-16T13:37:40Z","updated_at":"2016-07-16T11:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4e539776530186777fe29d9ff12b872c1302090","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/issues/77/comments","statuses_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/statuses/7964265a9d3b033e08b1b60569fbbe8f788336b6","head":{"label":"SimonDanisch:master","ref":"master","sha":"7964265a9d3b033e08b1b60569fbbe8f788336b6","user":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"repo":{"id":39596180,"name":"WinRPM.jl","full_name":"SimonDanisch/WinRPM.jl","owner":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonDanisch/WinRPM.jl","description":"RPM-md processing library","fork":true,"url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl","forks_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/forks","keys_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/teams","hooks_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/hooks","issue_events_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/issues/events{/number}","events_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/events","assignees_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/assignees{/user}","branches_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/branches{/branch}","tags_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/tags","blobs_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/languages","stargazers_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/stargazers","contributors_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/contributors","subscribers_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/subscribers","subscription_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/subscription","commits_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/contents/{+path}","compare_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/merges","archive_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/downloads","issues_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/issues{/number}","pulls_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/labels{/name}","releases_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/releases{/id}","deployments_url":"https://api.github.com/repos/SimonDanisch/WinRPM.jl/deployments","created_at":"2015-07-23T22:12:15Z","updated_at":"2016-06-16T13:10:52Z","pushed_at":"2016-07-16T11:37:37Z","git_url":"git://github.com/SimonDanisch/WinRPM.jl.git","ssh_url":"git@github.com:SimonDanisch/WinRPM.jl.git","clone_url":"https://github.com/SimonDanisch/WinRPM.jl.git","svn_url":"https://github.com/SimonDanisch/WinRPM.jl","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"38d778689678e457480869f2300a1070b6408636","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":10292644,"name":"WinRPM.jl","full_name":"JuliaLang/WinRPM.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/WinRPM.jl","description":"RPM-md processing library","fork":false,"url":"https://api.github.com/repos/JuliaLang/WinRPM.jl","forks_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/WinRPM.jl/deployments","created_at":"2013-05-26T02:31:56Z","updated_at":"2016-01-19T16:07:50Z","pushed_at":"2016-07-16T11:37:37Z","git_url":"git://github.com/JuliaLang/WinRPM.jl.git","ssh_url":"git@github.com:JuliaLang/WinRPM.jl.git","clone_url":"https://github.com/JuliaLang/WinRPM.jl.git","svn_url":"https://github.com/JuliaLang/WinRPM.jl","homepage":null,"size":112,"stargazers_count":4,"watchers_count":4,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":17,"forks":16,"open_issues":17,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77"},"html":{"href":"https://github.com/JuliaLang/WinRPM.jl/pull/77"},"issue":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/issues/77"},"comments":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/WinRPM.jl/statuses/7964265a9d3b033e08b1b60569fbbe8f788336b6"}}}}
{"actor":{"display_login":"SimonDanisch"}}