{"action":"created","issue":{"url":"https://api.github.com/repos/klange/toaruos/issues/137","repository_url":"https://api.github.com/repos/klange/toaruos","labels_url":"https://api.github.com/repos/klange/toaruos/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/klange/toaruos/issues/137/comments","events_url":"https://api.github.com/repos/klange/toaruos/issues/137/events","html_url":"https://github.com/klange/toaruos/pull/137","id":195116260,"number":137,"title":"Update ext2.c","user":{"login":"lazear","id":14057244,"avatar_url":"https://avatars.githubusercontent.com/u/14057244?v=3","gravatar_id":"","url":"https://api.github.com/users/lazear","html_url":"https://github.com/lazear","followers_url":"https://api.github.com/users/lazear/followers","following_url":"https://api.github.com/users/lazear/following{/other_user}","gists_url":"https://api.github.com/users/lazear/gists{/gist_id}","starred_url":"https://api.github.com/users/lazear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lazear/subscriptions","organizations_url":"https://api.github.com/users/lazear/orgs","repos_url":"https://api.github.com/users/lazear/repos","events_url":"https://api.github.com/users/lazear/events{/privacy}","received_events_url":"https://api.github.com/users/lazear/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-12T23:25:31Z","updated_at":"2016-12-14T03:03:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/klange/toaruos/pulls/137","html_url":"https://github.com/klange/toaruos/pull/137","diff_url":"https://github.com/klange/toaruos/pull/137.diff","patch_url":"https://github.com/klange/toaruos/pull/137.patch"},"body":"Fix bad triple-indirect block math. Juxtaposition of a '+' and '*' limited current code to just 256 more blocks than the doubly indirect blocks... instead of an additional ~1.6 million blocks per inode"},"comment":{"url":"https://api.github.com/repos/klange/toaruos/issues/comments/266929889","html_url":"https://github.com/klange/toaruos/pull/137#issuecomment-266929889","issue_url":"https://api.github.com/repos/klange/toaruos/issues/137","id":266929889,"user":{"login":"klange","id":223546,"avatar_url":"https://avatars.githubusercontent.com/u/223546?v=3","gravatar_id":"","url":"https://api.github.com/users/klange","html_url":"https://github.com/klange","followers_url":"https://api.github.com/users/klange/followers","following_url":"https://api.github.com/users/klange/following{/other_user}","gists_url":"https://api.github.com/users/klange/gists{/gist_id}","starred_url":"https://api.github.com/users/klange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klange/subscriptions","organizations_url":"https://api.github.com/users/klange/orgs","repos_url":"https://api.github.com/users/klange/repos","events_url":"https://api.github.com/users/klange/events{/privacy}","received_events_url":"https://api.github.com/users/klange/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T03:03:48Z","updated_at":"2016-12-14T03:03:48Z","body":"`EXT2_DIRECT_BLOCKS + p + p * p + p * p * p` is the correct calculation for the upper limit of the *logical* block count for this set of blocks (there are `p * p * p` blocks in this set, there are `p * p` blocks in the set before it, `p` before that, and `EXT2_DIRECT_BLOCKS` are accessible directly). I am planning a rewrite of most of the VFS to use 64-bit offsets and sizes and am rewriting quite a bit of the EXT2 driver at the moment, so this will get fixed as part of that."}}
{"actor":{"display_login":"klange"}}