{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/ocitools/issues/159","repository_url":"https://api.github.com/repos/opencontainers/ocitools","labels_url":"https://api.github.com/repos/opencontainers/ocitools/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/ocitools/issues/159/comments","events_url":"https://api.github.com/repos/opencontainers/ocitools/issues/159/events","html_url":"https://github.com/opencontainers/ocitools/pull/159","id":167987558,"number":159,"title":"Use seccomp library for adding seccomp configuration flags","user":{"login":"GrantSeltzer","id":10857349,"avatar_url":"https://avatars.githubusercontent.com/u/10857349?v=3","gravatar_id":"","url":"https://api.github.com/users/GrantSeltzer","html_url":"https://github.com/GrantSeltzer","followers_url":"https://api.github.com/users/GrantSeltzer/followers","following_url":"https://api.github.com/users/GrantSeltzer/following{/other_user}","gists_url":"https://api.github.com/users/GrantSeltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/GrantSeltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrantSeltzer/subscriptions","organizations_url":"https://api.github.com/users/GrantSeltzer/orgs","repos_url":"https://api.github.com/users/GrantSeltzer/repos","events_url":"https://api.github.com/users/GrantSeltzer/events{/privacy}","received_events_url":"https://api.github.com/users/GrantSeltzer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2016-07-28T00:29:57Z","updated_at":"2016-09-01T22:40:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/ocitools/pulls/159","html_url":"https://github.com/opencontainers/ocitools/pull/159","diff_url":"https://github.com/opencontainers/ocitools/pull/159.diff","patch_url":"https://github.com/opencontainers/ocitools/pull/159.patch"},"body":"I added functionality to specify syscalls and their arguments for all actions. Also changed default action and archs flags to ociseccompgen library. \r\n\r\nNow we can do things like:\r\n\r\n`ocitools generate --seccomp-errno clone,write --seccomp-trace getcwd --seccomp-trap umount:0:1:2:NE`\r\n\r\nThe behavior mimics that of: https://github.com/GrantSeltzer/Manhattan\r\n\r\nAlso updated man page to reflect this change. \r\n\r\nSigned-off-by: Grantseltzer <grantseltzer@gmail.com>"},"comment":{"url":"https://api.github.com/repos/opencontainers/ocitools/issues/comments/244234423","html_url":"https://github.com/opencontainers/ocitools/pull/159#issuecomment-244234423","issue_url":"https://api.github.com/repos/opencontainers/ocitools/issues/159","id":244234423,"user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T22:40:53Z","updated_at":"2016-09-01T22:40:53Z","body":"I just tried this out and the runtime tests fail:\r\n```\r\n-----------------------------------------------------------------------------------\r\nVALIDATING RUNTIME: runc\r\n-----------------------------------------------------------------------------------\r\nruntime: failed to create new OS thread (have 2 already; errno=1)\r\nfatal error: newosproc\r\n\r\nruntime stack:\r\nruntime.throw(0x57c714, 0x9)\r\n        /usr/lib/golang/src/runtime/panic.go:566 +0x95\r\nruntime.newosproc(0xc420028000, 0xc420037fc0)\r\n        /usr/lib/golang/src/runtime/os_linux.go:160 +0x194\r\nruntime.newm(0x5907f8, 0x0)\r\n        /usr/lib/golang/src/runtime/proc.go:1572 +0x132\r\nruntime.main.func1()\r\n        /usr/lib/golang/src/runtime/proc.go:126 +0x36\r\nruntime.systemstack(0x63bb00)\r\n        /usr/lib/golang/src/runtime/asm_amd64.s:298 +0x79\r\nruntime.mstart()\r\n        /usr/lib/golang/src/runtime/proc.go:1079\r\n\r\ngoroutine 1 [running]:\r\nruntime.systemstack_switch()\r\n        /usr/lib/golang/src/runtime/asm_amd64.s:252 fp=0xc420022768 sp=0xc420022760\r\nruntime.main()\r\n        /usr/lib/golang/src/runtime/proc.go:127 +0x6c fp=0xc4200227c0 sp=0xc420022768\r\nruntime.goexit()\r\n        /usr/lib/golang/src/runtime/asm_amd64.s:2086 +0x1 fp=0xc4200227c8 sp=0xc4200227c0\r\nRuntime runc failed validation\r\n```"}}
{"actor":{"display_login":"mrunalp"}}