{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/68448796","id":68448796,"diff_hunk":"@@ -127,7 +126,7 @@ export function main() {\n \n   describe('using the test injector with the inject helper', () => {\n     describe('setting up Providers', () => {\n-      beforeEachProviders(() => [{provide: FancyService, useValue: new FancyService()}]);\n+      beforeEach(() => addProviders([{provide: FancyService, useValue: new FancyService()}]));","path":"modules/@angular/platform-browser/test/testing_public_spec.ts","position":18,"original_position":18,"commit_id":"a59436c89b5fcb9c6a32906d52eee6e8dff373ae","original_commit_id":"a59436c89b5fcb9c6a32906d52eee6e8dff373ae","user":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"body":"Update: After offline discussion, decided to leave as-is for now.","created_at":"2016-06-24T19:18:10Z","updated_at":"2016-06-24T19:18:10Z","html_url":"https://github.com/angular/angular/pull/9564#discussion_r68448796","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/9564","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/68448796"},"html":{"href":"https://github.com/angular/angular/pull/9564#discussion_r68448796"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/9564"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/9564","id":75069130,"html_url":"https://github.com/angular/angular/pull/9564","diff_url":"https://github.com/angular/angular/pull/9564.diff","patch_url":"https://github.com/angular/angular/pull/9564.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/9564","number":9564,"state":"open","locked":false,"title":"refactor(testing): remove wrapping of Jasmine functions","user":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"body":"Instead, the async function now determines whether it should return a promise\r\nor instead call a done function parameter. Importing Jasmine functions\r\nfrom `@angular/core/testing` is no longer necessary and is now deprecated.\r\n\r\nAdditionally, beforeEachProviders is also deprecated, as it is specific\r\nto the testing framework. Instead, use the new addProviders method directly.\r\n\r\nBefore:\r\n```js\r\nimport {beforeEachProviders, it, describe, inject} from 'angular2/testing/core';\r\n\r\ndescribe('my code', () => {\r\n  beforeEachProviders(() => [MyService]);\r\n\r\n  it('does stuff', inject([MyService], (service) => {\r\n    // actual test\r\n  });\r\n});\r\n```\r\n\r\nAfter:\r\n```js\r\nimport {addProviders, inject} from 'angular2/testing/core';\r\n\r\ndescribe('my code', () => {\r\n  beforeEach(() => {\r\n    addProviders([MyService]);\r\n  });\r\n\r\n  it('does stuff', inject([MyService], (service) => {\r\n    // actual test\r\n  });\r\n});\r\n```","created_at":"2016-06-24T06:17:54Z","updated_at":"2016-06-24T19:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d3d366044f7408bec6fbd19fe3c9847acf293fd","assignee":{"login":"vikerman","id":85066,"avatar_url":"https://avatars.githubusercontent.com/u/85066?v=3","gravatar_id":"","url":"https://api.github.com/users/vikerman","html_url":"https://github.com/vikerman","followers_url":"https://api.github.com/users/vikerman/followers","following_url":"https://api.github.com/users/vikerman/following{/other_user}","gists_url":"https://api.github.com/users/vikerman/gists{/gist_id}","starred_url":"https://api.github.com/users/vikerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikerman/subscriptions","organizations_url":"https://api.github.com/users/vikerman/orgs","repos_url":"https://api.github.com/users/vikerman/repos","events_url":"https://api.github.com/users/vikerman/events{/privacy}","received_events_url":"https://api.github.com/users/vikerman/received_events","type":"User","site_admin":false},"assignees":[{"login":"vikerman","id":85066,"avatar_url":"https://avatars.githubusercontent.com/u/85066?v=3","gravatar_id":"","url":"https://api.github.com/users/vikerman","html_url":"https://github.com/vikerman","followers_url":"https://api.github.com/users/vikerman/followers","following_url":"https://api.github.com/users/vikerman/following{/other_user}","gists_url":"https://api.github.com/users/vikerman/gists{/gist_id}","starred_url":"https://api.github.com/users/vikerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikerman/subscriptions","organizations_url":"https://api.github.com/users/vikerman/orgs","repos_url":"https://api.github.com/users/vikerman/repos","events_url":"https://api.github.com/users/vikerman/events{/privacy}","received_events_url":"https://api.github.com/users/vikerman/received_events","type":"User","site_admin":false},{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/64","html_url":"https://github.com/angular/angular/milestones/2.0.0-rc.5","labels_url":"https://api.github.com/repos/angular/angular/milestones/64/labels","id":1846149,"number":64,"title":"2.0.0-rc.5","description":"","creator":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2016-06-23T20:42:00Z","updated_at":"2016-06-24T06:17:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/9564/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/9564/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/9564/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/a59436c89b5fcb9c6a32906d52eee6e8dff373ae","head":{"label":"juliemr:6-22-remove-test-wrap","ref":"6-22-remove-test-wrap","sha":"a59436c89b5fcb9c6a32906d52eee6e8dff373ae","user":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"repo":{"id":28985296,"name":"angular","full_name":"juliemr/angular","owner":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliemr/angular","description":"","fork":true,"url":"https://api.github.com/repos/juliemr/angular","forks_url":"https://api.github.com/repos/juliemr/angular/forks","keys_url":"https://api.github.com/repos/juliemr/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliemr/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliemr/angular/teams","hooks_url":"https://api.github.com/repos/juliemr/angular/hooks","issue_events_url":"https://api.github.com/repos/juliemr/angular/issues/events{/number}","events_url":"https://api.github.com/repos/juliemr/angular/events","assignees_url":"https://api.github.com/repos/juliemr/angular/assignees{/user}","branches_url":"https://api.github.com/repos/juliemr/angular/branches{/branch}","tags_url":"https://api.github.com/repos/juliemr/angular/tags","blobs_url":"https://api.github.com/repos/juliemr/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliemr/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliemr/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliemr/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliemr/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/juliemr/angular/languages","stargazers_url":"https://api.github.com/repos/juliemr/angular/stargazers","contributors_url":"https://api.github.com/repos/juliemr/angular/contributors","subscribers_url":"https://api.github.com/repos/juliemr/angular/subscribers","subscription_url":"https://api.github.com/repos/juliemr/angular/subscription","commits_url":"https://api.github.com/repos/juliemr/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliemr/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliemr/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliemr/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliemr/angular/contents/{+path}","compare_url":"https://api.github.com/repos/juliemr/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliemr/angular/merges","archive_url":"https://api.github.com/repos/juliemr/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliemr/angular/downloads","issues_url":"https://api.github.com/repos/juliemr/angular/issues{/number}","pulls_url":"https://api.github.com/repos/juliemr/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/juliemr/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/juliemr/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliemr/angular/labels{/name}","releases_url":"https://api.github.com/repos/juliemr/angular/releases{/id}","deployments_url":"https://api.github.com/repos/juliemr/angular/deployments","created_at":"2015-01-08T20:46:47Z","updated_at":"2016-01-04T21:42:38Z","pushed_at":"2016-06-24T19:17:20Z","git_url":"git://github.com/juliemr/angular.git","ssh_url":"git@github.com:juliemr/angular.git","clone_url":"https://github.com/juliemr/angular.git","svn_url":"https://github.com/juliemr/angular","homepage":null,"size":31994,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"0ad1215a92e16aa36f3969e6116f68f4aa854cba","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-06-24T17:33:05Z","pushed_at":"2016-06-24T19:17:21Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":648988,"stargazers_count":13185,"watchers_count":13185,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3419,"mirror_url":null,"open_issues_count":1417,"forks":3419,"open_issues":1417,"watchers":13185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/9564"},"html":{"href":"https://github.com/angular/angular/pull/9564"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/9564"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/9564/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/9564/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/9564/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/a59436c89b5fcb9c6a32906d52eee6e8dff373ae"}}}}
{"actor":{"display_login":"juliemr"}}