{"action":"closed","number":272,"pull_request":{"url":"https://api.github.com/repos/askmike/gekko/pulls/272","id":30641660,"html_url":"https://github.com/askmike/gekko/pull/272","diff_url":"https://github.com/askmike/gekko/pull/272.diff","patch_url":"https://github.com/askmike/gekko/pull/272.patch","issue_url":"https://api.github.com/repos/askmike/gekko/issues/272","number":272,"state":"closed","locked":false,"title":"Fix #266 bitstamp trader fails to buy","user":{"login":"Siim","id":44247,"avatar_url":"https://avatars.githubusercontent.com/u/44247?v=3","gravatar_id":"","url":"https://api.github.com/users/Siim","html_url":"https://github.com/Siim","followers_url":"https://api.github.com/users/Siim/followers","following_url":"https://api.github.com/users/Siim/following{/other_user}","gists_url":"https://api.github.com/users/Siim/gists{/gist_id}","starred_url":"https://api.github.com/users/Siim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siim/subscriptions","organizations_url":"https://api.github.com/users/Siim/orgs","repos_url":"https://api.github.com/users/Siim/repos","events_url":"https://api.github.com/users/Siim/events{/privacy}","received_events_url":"https://api.github.com/users/Siim/received_events","type":"User","site_admin":false},"body":"#### Fix #266 \r\n**ticker.ask** had type of **string** and as a result the amount calculation failed. The price should be parsed as **float**.\r\n\r\n    amount = this.getBalance(this.currency) / (parseFloat(this.ticker.ask) + (parseFloat(this.ticker.ask)*this.fee));\r\n\r\n#### Fix #240 \r\nFixed floating point to 4 decimal places, because more than 4 places caused inaccurate calculations. \r\n\r\nBtw shouldn't we make all the calculations using cents and satoshis and store all the monetary and asset values in an integer type?","created_at":"2015-03-06T12:38:35Z","updated_at":"2016-06-16T19:53:55Z","closed_at":"2016-06-16T19:53:55Z","merged_at":null,"merge_commit_sha":"453640cc52e64efec2a280fe568f2fc91f7fd821","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/askmike/gekko/pulls/272/commits","review_comments_url":"https://api.github.com/repos/askmike/gekko/pulls/272/comments","review_comment_url":"https://api.github.com/repos/askmike/gekko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/askmike/gekko/issues/272/comments","statuses_url":"https://api.github.com/repos/askmike/gekko/statuses/b68c83c28b3a11fade1e338d011676dafd07d3fc","head":{"label":"Siim:master","ref":"master","sha":"b68c83c28b3a11fade1e338d011676dafd07d3fc","user":{"login":"Siim","id":44247,"avatar_url":"https://avatars.githubusercontent.com/u/44247?v=3","gravatar_id":"","url":"https://api.github.com/users/Siim","html_url":"https://github.com/Siim","followers_url":"https://api.github.com/users/Siim/followers","following_url":"https://api.github.com/users/Siim/following{/other_user}","gists_url":"https://api.github.com/users/Siim/gists{/gist_id}","starred_url":"https://api.github.com/users/Siim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siim/subscriptions","organizations_url":"https://api.github.com/users/Siim/orgs","repos_url":"https://api.github.com/users/Siim/repos","events_url":"https://api.github.com/users/Siim/events{/privacy}","received_events_url":"https://api.github.com/users/Siim/received_events","type":"User","site_admin":false},"repo":{"id":31601827,"name":"gekko","full_name":"Siim/gekko","owner":{"login":"Siim","id":44247,"avatar_url":"https://avatars.githubusercontent.com/u/44247?v=3","gravatar_id":"","url":"https://api.github.com/users/Siim","html_url":"https://github.com/Siim","followers_url":"https://api.github.com/users/Siim/followers","following_url":"https://api.github.com/users/Siim/following{/other_user}","gists_url":"https://api.github.com/users/Siim/gists{/gist_id}","starred_url":"https://api.github.com/users/Siim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siim/subscriptions","organizations_url":"https://api.github.com/users/Siim/orgs","repos_url":"https://api.github.com/users/Siim/repos","events_url":"https://api.github.com/users/Siim/events{/privacy}","received_events_url":"https://api.github.com/users/Siim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Siim/gekko","description":"A bitcoin trading bot written in node","fork":true,"url":"https://api.github.com/repos/Siim/gekko","forks_url":"https://api.github.com/repos/Siim/gekko/forks","keys_url":"https://api.github.com/repos/Siim/gekko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Siim/gekko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Siim/gekko/teams","hooks_url":"https://api.github.com/repos/Siim/gekko/hooks","issue_events_url":"https://api.github.com/repos/Siim/gekko/issues/events{/number}","events_url":"https://api.github.com/repos/Siim/gekko/events","assignees_url":"https://api.github.com/repos/Siim/gekko/assignees{/user}","branches_url":"https://api.github.com/repos/Siim/gekko/branches{/branch}","tags_url":"https://api.github.com/repos/Siim/gekko/tags","blobs_url":"https://api.github.com/repos/Siim/gekko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Siim/gekko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Siim/gekko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Siim/gekko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Siim/gekko/statuses/{sha}","languages_url":"https://api.github.com/repos/Siim/gekko/languages","stargazers_url":"https://api.github.com/repos/Siim/gekko/stargazers","contributors_url":"https://api.github.com/repos/Siim/gekko/contributors","subscribers_url":"https://api.github.com/repos/Siim/gekko/subscribers","subscription_url":"https://api.github.com/repos/Siim/gekko/subscription","commits_url":"https://api.github.com/repos/Siim/gekko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Siim/gekko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Siim/gekko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Siim/gekko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Siim/gekko/contents/{+path}","compare_url":"https://api.github.com/repos/Siim/gekko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Siim/gekko/merges","archive_url":"https://api.github.com/repos/Siim/gekko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Siim/gekko/downloads","issues_url":"https://api.github.com/repos/Siim/gekko/issues{/number}","pulls_url":"https://api.github.com/repos/Siim/gekko/pulls{/number}","milestones_url":"https://api.github.com/repos/Siim/gekko/milestones{/number}","notifications_url":"https://api.github.com/repos/Siim/gekko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Siim/gekko/labels{/name}","releases_url":"https://api.github.com/repos/Siim/gekko/releases{/id}","deployments_url":"https://api.github.com/repos/Siim/gekko/deployments","created_at":"2015-03-03T14:16:15Z","updated_at":"2015-03-20T10:41:24Z","pushed_at":"2015-03-20T10:41:23Z","git_url":"git://github.com/Siim/gekko.git","ssh_url":"git@github.com:Siim/gekko.git","clone_url":"https://github.com/Siim/gekko.git","svn_url":"https://github.com/Siim/gekko","homepage":"","size":830,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"askmike:master","ref":"master","sha":"21de73cc292b3a499c32a2f736e52e745eff64af","user":{"login":"askmike","id":969743,"avatar_url":"https://avatars.githubusercontent.com/u/969743?v=3","gravatar_id":"","url":"https://api.github.com/users/askmike","html_url":"https://github.com/askmike","followers_url":"https://api.github.com/users/askmike/followers","following_url":"https://api.github.com/users/askmike/following{/other_user}","gists_url":"https://api.github.com/users/askmike/gists{/gist_id}","starred_url":"https://api.github.com/users/askmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askmike/subscriptions","organizations_url":"https://api.github.com/users/askmike/orgs","repos_url":"https://api.github.com/users/askmike/repos","events_url":"https://api.github.com/users/askmike/events{/privacy}","received_events_url":"https://api.github.com/users/askmike/received_events","type":"User","site_admin":false},"repo":{"id":10020773,"name":"gekko","full_name":"askmike/gekko","owner":{"login":"askmike","id":969743,"avatar_url":"https://avatars.githubusercontent.com/u/969743?v=3","gravatar_id":"","url":"https://api.github.com/users/askmike","html_url":"https://github.com/askmike","followers_url":"https://api.github.com/users/askmike/followers","following_url":"https://api.github.com/users/askmike/following{/other_user}","gists_url":"https://api.github.com/users/askmike/gists{/gist_id}","starred_url":"https://api.github.com/users/askmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askmike/subscriptions","organizations_url":"https://api.github.com/users/askmike/orgs","repos_url":"https://api.github.com/users/askmike/repos","events_url":"https://api.github.com/users/askmike/events{/privacy}","received_events_url":"https://api.github.com/users/askmike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/askmike/gekko","description":"A bitcoin trading bot written in node","fork":false,"url":"https://api.github.com/repos/askmike/gekko","forks_url":"https://api.github.com/repos/askmike/gekko/forks","keys_url":"https://api.github.com/repos/askmike/gekko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/askmike/gekko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/askmike/gekko/teams","hooks_url":"https://api.github.com/repos/askmike/gekko/hooks","issue_events_url":"https://api.github.com/repos/askmike/gekko/issues/events{/number}","events_url":"https://api.github.com/repos/askmike/gekko/events","assignees_url":"https://api.github.com/repos/askmike/gekko/assignees{/user}","branches_url":"https://api.github.com/repos/askmike/gekko/branches{/branch}","tags_url":"https://api.github.com/repos/askmike/gekko/tags","blobs_url":"https://api.github.com/repos/askmike/gekko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/askmike/gekko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/askmike/gekko/git/refs{/sha}","trees_url":"https://api.github.com/repos/askmike/gekko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/askmike/gekko/statuses/{sha}","languages_url":"https://api.github.com/repos/askmike/gekko/languages","stargazers_url":"https://api.github.com/repos/askmike/gekko/stargazers","contributors_url":"https://api.github.com/repos/askmike/gekko/contributors","subscribers_url":"https://api.github.com/repos/askmike/gekko/subscribers","subscription_url":"https://api.github.com/repos/askmike/gekko/subscription","commits_url":"https://api.github.com/repos/askmike/gekko/commits{/sha}","git_commits_url":"https://api.github.com/repos/askmike/gekko/git/commits{/sha}","comments_url":"https://api.github.com/repos/askmike/gekko/comments{/number}","issue_comment_url":"https://api.github.com/repos/askmike/gekko/issues/comments{/number}","contents_url":"https://api.github.com/repos/askmike/gekko/contents/{+path}","compare_url":"https://api.github.com/repos/askmike/gekko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/askmike/gekko/merges","archive_url":"https://api.github.com/repos/askmike/gekko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/askmike/gekko/downloads","issues_url":"https://api.github.com/repos/askmike/gekko/issues{/number}","pulls_url":"https://api.github.com/repos/askmike/gekko/pulls{/number}","milestones_url":"https://api.github.com/repos/askmike/gekko/milestones{/number}","notifications_url":"https://api.github.com/repos/askmike/gekko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/askmike/gekko/labels{/name}","releases_url":"https://api.github.com/repos/askmike/gekko/releases{/id}","deployments_url":"https://api.github.com/repos/askmike/gekko/deployments","created_at":"2013-05-12T22:52:01Z","updated_at":"2016-06-16T09:01:21Z","pushed_at":"2016-06-15T16:07:58Z","git_url":"git://github.com/askmike/gekko.git","ssh_url":"git@github.com:askmike/gekko.git","clone_url":"https://github.com/askmike/gekko.git","svn_url":"https://github.com/askmike/gekko","homepage":"","size":1360,"stargazers_count":959,"watchers_count":959,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":336,"mirror_url":null,"open_issues_count":3,"forks":336,"open_issues":3,"watchers":959,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/askmike/gekko/pulls/272"},"html":{"href":"https://github.com/askmike/gekko/pull/272"},"issue":{"href":"https://api.github.com/repos/askmike/gekko/issues/272"},"comments":{"href":"https://api.github.com/repos/askmike/gekko/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/askmike/gekko/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/askmike/gekko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/askmike/gekko/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/askmike/gekko/statuses/b68c83c28b3a11fade1e338d011676dafd07d3fc"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":6,"additions":163,"deletions":7,"changed_files":5}}
{"actor":{"display_login":"askmike"}}