{"action":"created","issue":{"url":"https://api.github.com/repos/phpbb/phpbb-translation-validator/issues/29","labels_url":"https://api.github.com/repos/phpbb/phpbb-translation-validator/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/phpbb/phpbb-translation-validator/issues/29/comments","events_url":"https://api.github.com/repos/phpbb/phpbb-translation-validator/issues/29/events","html_url":"https://github.com/phpbb/phpbb-translation-validator/issues/29","id":124580376,"number":29,"title":"False fatal error (File must not contain a PHP closing tag, but end with one new line)","user":{"login":"maelsoucaze","id":206263,"avatar_url":"https://avatars.githubusercontent.com/u/206263?v=3","gravatar_id":"","url":"https://api.github.com/users/maelsoucaze","html_url":"https://github.com/maelsoucaze","followers_url":"https://api.github.com/users/maelsoucaze/followers","following_url":"https://api.github.com/users/maelsoucaze/following{/other_user}","gists_url":"https://api.github.com/users/maelsoucaze/gists{/gist_id}","starred_url":"https://api.github.com/users/maelsoucaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maelsoucaze/subscriptions","organizations_url":"https://api.github.com/users/maelsoucaze/orgs","repos_url":"https://api.github.com/users/maelsoucaze/repos","events_url":"https://api.github.com/users/maelsoucaze/events{/privacy}","received_events_url":"https://api.github.com/users/maelsoucaze/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-02T07:54:16Z","updated_at":"2016-01-09T08:07:56Z","closed_at":null,"body":"I applied StyleCI guidelines as coding standards. It replaced, for example, `array()` elements with `[]`. Note that's a language pack compatible with phpBB 3.2, which is fine because phpBB 3.2 requires > PHP 5.6. My language pack for phpBB 3.1 is untouched to be compatible with PHP 5.3.3.\r\n\r\nHowever, the Translation Validator wrongly returns that four files, *help_bbcode.php*, *help_faq.php*, *search_ignore_words.php* and *search_synonyms.php*, **must not contain a PHP closing tag, but end with one new line**, but these files don't contain any PHP closing tag, and end with a new line.\r\n\r\nIt causes a fatal failure and wi*ll lead to an automatic rejection in the Customisation Database, which is really bad. Note that all the other files are not affected with this \"bug\".\r\n\r\nYou can see the issue here: https://travis-ci.org/maelsoucaze/phpbb/jobs/99797166#L148-L158"},"comment":{"url":"https://api.github.com/repos/phpbb/phpbb-translation-validator/issues/comments/170208487","html_url":"https://github.com/phpbb/phpbb-translation-validator/issues/29#issuecomment-170208487","issue_url":"https://api.github.com/repos/phpbb/phpbb-translation-validator/issues/29","id":170208487,"user":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"created_at":"2016-01-09T08:07:56Z","updated_at":"2016-01-09T08:07:56Z","body":"`help_bbcode.php` and `help_faq.php` don't really matter.\r\nThey are going to be removed anyway.\r\n\r\nFor the 5.4 array syntax, that needs a patch in \r\nhttps://github.com/phpbb/phpbb-translation-validator/blob/2ae856d34a0e2575a69afd4dd360bd1a19f7b413/src/Phpbb/TranslationValidator/Validator/FileValidator.php#L594-L595"}}