{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/86957291","pull_request_review_id":7587610,"id":86957291,"diff_hunk":"@@ -18,16 +18,20 @@ type pluginOptions struct {\n \tname       string\n \tgrantPerms bool\n \tdisable    bool\n+\targs       []string\n }\n \n func newInstallCommand(dockerCli *command.DockerCli) *cobra.Command {\n \tvar options pluginOptions\n \tcmd := &cobra.Command{\n-\t\tUse:   \"install [OPTIONS] PLUGIN\",\n+\t\tUse:   \"install [OPTIONS] PLUGIN [key=value...]\",","path":"cli/command/plugin/install.go","position":11,"original_position":11,"commit_id":"2d4970224495783e3b5725c2b32e2a427f91b483","original_commit_id":"2d4970224495783e3b5725c2b32e2a427f91b483","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"I even think it should be `[NAME[.FIELD][=VALUE]...]` and same in set. WDYT @tiborvass ?\r\n","created_at":"2016-11-08T10:03:23Z","updated_at":"2016-11-08T10:03:23Z","html_url":"https://github.com/docker/docker/pull/28142#discussion_r86957291","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/28142","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/86957291"},"html":{"href":"https://github.com/docker/docker/pull/28142#discussion_r86957291"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/28142"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28142","id":92700547,"html_url":"https://github.com/docker/docker/pull/28142","diff_url":"https://github.com/docker/docker/pull/28142.diff","patch_url":"https://github.com/docker/docker/pull/28142.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/28142","number":28142,"state":"open","locked":false,"title":"support settings in docker plugins install","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"`docker plugin install tiborvass/no-remove DEBUG=1`","created_at":"2016-11-08T01:44:16Z","updated_at":"2016-11-08T10:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fa592d11ada32c344fb2b1881068f1aba061c20","assignee":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"assignees":[{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},{"login":"anusha-ragunathan","id":14184178,"avatar_url":"https://avatars.githubusercontent.com/u/14184178?v=3","gravatar_id":"","url":"https://api.github.com/users/anusha-ragunathan","html_url":"https://github.com/anusha-ragunathan","followers_url":"https://api.github.com/users/anusha-ragunathan/followers","following_url":"https://api.github.com/users/anusha-ragunathan/following{/other_user}","gists_url":"https://api.github.com/users/anusha-ragunathan/gists{/gist_id}","starred_url":"https://api.github.com/users/anusha-ragunathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anusha-ragunathan/subscriptions","organizations_url":"https://api.github.com/users/anusha-ragunathan/orgs","repos_url":"https://api.github.com/users/anusha-ragunathan/repos","events_url":"https://api.github.com/users/anusha-ragunathan/events{/privacy}","received_events_url":"https://api.github.com/users/anusha-ragunathan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":113,"closed_issues":618,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-08T09:37:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/28142/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/28142/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/28142/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/2d4970224495783e3b5725c2b32e2a427f91b483","head":{"label":"vieux:plugin_install_args","ref":"plugin_install_args","sha":"2d4970224495783e3b5725c2b32e2a427f91b483","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"repo":{"id":9343231,"name":"docker","full_name":"vieux/docker","owner":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vieux/docker","description":"Docker - the Linux container runtime","fork":true,"url":"https://api.github.com/repos/vieux/docker","forks_url":"https://api.github.com/repos/vieux/docker/forks","keys_url":"https://api.github.com/repos/vieux/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vieux/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vieux/docker/teams","hooks_url":"https://api.github.com/repos/vieux/docker/hooks","issue_events_url":"https://api.github.com/repos/vieux/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vieux/docker/events","assignees_url":"https://api.github.com/repos/vieux/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vieux/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vieux/docker/tags","blobs_url":"https://api.github.com/repos/vieux/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vieux/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vieux/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vieux/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vieux/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vieux/docker/languages","stargazers_url":"https://api.github.com/repos/vieux/docker/stargazers","contributors_url":"https://api.github.com/repos/vieux/docker/contributors","subscribers_url":"https://api.github.com/repos/vieux/docker/subscribers","subscription_url":"https://api.github.com/repos/vieux/docker/subscription","commits_url":"https://api.github.com/repos/vieux/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vieux/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vieux/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vieux/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vieux/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vieux/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vieux/docker/merges","archive_url":"https://api.github.com/repos/vieux/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vieux/docker/downloads","issues_url":"https://api.github.com/repos/vieux/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vieux/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vieux/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vieux/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vieux/docker/labels{/name}","releases_url":"https://api.github.com/repos/vieux/docker/releases{/id}","deployments_url":"https://api.github.com/repos/vieux/docker/deployments","created_at":"2013-04-10T09:57:14Z","updated_at":"2014-07-24T21:22:20Z","pushed_at":"2016-11-08T07:08:57Z","git_url":"git://github.com/vieux/docker.git","ssh_url":"git@github.com:vieux/docker.git","clone_url":"https://github.com/vieux/docker.git","svn_url":"https://github.com/vieux/docker","homepage":"http://docker.io","size":113373,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"03da822ee9afa1713fe28c3996b0872a0e228c28","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-11-08T10:01:37Z","pushed_at":"2016-11-08T09:57:02Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":218791,"stargazers_count":36671,"watchers_count":36671,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10829,"mirror_url":null,"open_issues_count":1899,"forks":10829,"open_issues":1899,"watchers":36671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/28142"},"html":{"href":"https://github.com/docker/docker/pull/28142"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/28142"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/28142/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/28142/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/28142/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/2d4970224495783e3b5725c2b32e2a427f91b483"}}}}
{"actor":{"display_login":"vieux"}}