{"action":"created","issue":{"url":"https://api.github.com/repos/hawkular/hawkular-client-go/issues/10","repository_url":"https://api.github.com/repos/hawkular/hawkular-client-go","labels_url":"https://api.github.com/repos/hawkular/hawkular-client-go/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/hawkular/hawkular-client-go/issues/10/comments","events_url":"https://api.github.com/repos/hawkular/hawkular-client-go/issues/10/events","html_url":"https://github.com/hawkular/hawkular-client-go/issues/10","id":186055029,"number":10,"title":"why does DeleteTags ask for map?","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars.githubusercontent.com/u/2029470?v=3","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"labels":[{"id":202309389,"url":"https://api.github.com/repos/hawkular/hawkular-client-go/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-29T02:43:36Z","updated_at":"2016-10-30T08:22:33Z","closed_at":null,"body":"The signature for DeleteTags is:\r\n\r\n````\r\n// DeleteTags deletes given tags from the definition\r\nfunc (c *Client) DeleteTags(t MetricType, id string, tags map[string]string, o ...Modifier) error {\r\n````\r\n\r\nWhy does it take a map[string]string? You delete tags by name; the value is irrelevent. However, it looks like the code actually builds the DELETE URL with the values which is probably why I'm gettting a error when I try to delete tags:\r\n\r\n````\r\no = prepend(o, c.URL(\"DELETE\", TypeEndpoint(t), SingleMetricEndpoint(id), TagEndpoint(), TagsEndpoint(tags)))\r\nr, err := c.Send(o...)\r\n````\r\n\r\nThis method should only take a slice of strings (the tag names):\r\n\r\n````\r\n// DeleteTags deletes given tags from the definition\r\nfunc (c *Client) DeleteTags(t MetricType, id string, tags []string, o ...Modifier) error {\r\n````\r\n\r\nOr if you don't want to change the signature, just have the code ignore the values and just take the keys of \"tags\""},"comment":{"url":"https://api.github.com/repos/hawkular/hawkular-client-go/issues/comments/257138348","html_url":"https://github.com/hawkular/hawkular-client-go/issues/10#issuecomment-257138348","issue_url":"https://api.github.com/repos/hawkular/hawkular-client-go/issues/10","id":257138348,"user":{"login":"burmanm","id":562574,"avatar_url":"https://avatars.githubusercontent.com/u/562574?v=3","gravatar_id":"","url":"https://api.github.com/users/burmanm","html_url":"https://github.com/burmanm","followers_url":"https://api.github.com/users/burmanm/followers","following_url":"https://api.github.com/users/burmanm/following{/other_user}","gists_url":"https://api.github.com/users/burmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/burmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burmanm/subscriptions","organizations_url":"https://api.github.com/users/burmanm/orgs","repos_url":"https://api.github.com/users/burmanm/repos","events_url":"https://api.github.com/users/burmanm/events{/privacy}","received_events_url":"https://api.github.com/users/burmanm/received_events","type":"User","site_admin":false},"created_at":"2016-10-30T08:22:33Z","updated_at":"2016-10-30T08:22:33Z","body":"HWKMETRICS-385 also says that the backwards compatibility should be preserved."}}
{"actor":{"display_login":"burmanm"}}