{"action":"created","comment":{"url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/comments/64191632","id":64191632,"diff_hunk":"@@ -65,19 +62,16 @@ public static function text_field( $args ) {\n         $text_template = '<input name=\"%s\" type=\"text\" value=\"%s\" />';\n \n         // Text input template\n-        $template = sprintf($text_template,\n+        $escaped_template = sprintf($text_template,\n             esc_attr( $args['name'] ), // Input's name.\n             esc_attr( $args['value'] ) // Input's value.\n         );\n \n         // Description template\n         if ( isset( $args['description'] ) && ! empty( $args['description'] ) ) {\n-            $description_template = sprintf( '<p class=\"description\">%s</p>', $args['description'] );\n-            $template .= $description_template;\n+            $escaped_template .= sprintf( '<p class=\"description\">%s</p>', $args['description'] );","path":"inc/class-spotim-settings-fields.php","position":69,"original_position":69,"commit_id":"01766b7985c3b394ecde16858ad3f80ceb3308f9","original_commit_id":"01766b7985c3b394ecde16858ad3f80ceb3308f9","user":{"login":"tal-moshayov","id":1967992,"avatar_url":"https://avatars.githubusercontent.com/u/1967992?v=3","gravatar_id":"","url":"https://api.github.com/users/tal-moshayov","html_url":"https://github.com/tal-moshayov","followers_url":"https://api.github.com/users/tal-moshayov/followers","following_url":"https://api.github.com/users/tal-moshayov/following{/other_user}","gists_url":"https://api.github.com/users/tal-moshayov/gists{/gist_id}","starred_url":"https://api.github.com/users/tal-moshayov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tal-moshayov/subscriptions","organizations_url":"https://api.github.com/users/tal-moshayov/orgs","repos_url":"https://api.github.com/users/tal-moshayov/repos","events_url":"https://api.github.com/users/tal-moshayov/events{/privacy}","received_events_url":"https://api.github.com/users/tal-moshayov/received_events","type":"User","site_admin":false},"body":"as mentioned above, `description` is an internal arguments and not user input. therefore escaping is not needed.\r\n","created_at":"2016-05-23T09:20:56Z","updated_at":"2016-05-23T09:20:56Z","html_url":"https://github.com/SpotIM/wordpress-comments-plugin/pull/1#discussion_r64191632","pull_request_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/comments/64191632"},"html":{"href":"https://github.com/SpotIM/wordpress-comments-plugin/pull/1#discussion_r64191632"},"pull_request":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1","id":71027597,"html_url":"https://github.com/SpotIM/wordpress-comments-plugin/pull/1","diff_url":"https://github.com/SpotIM/wordpress-comments-plugin/pull/1.diff","patch_url":"https://github.com/SpotIM/wordpress-comments-plugin/pull/1.patch","issue_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/1","number":1,"state":"open","locked":false,"title":"Code review fixes","user":{"login":"tal-moshayov","id":1967992,"avatar_url":"https://avatars.githubusercontent.com/u/1967992?v=3","gravatar_id":"","url":"https://api.github.com/users/tal-moshayov","html_url":"https://github.com/tal-moshayov","followers_url":"https://api.github.com/users/tal-moshayov/followers","following_url":"https://api.github.com/users/tal-moshayov/following{/other_user}","gists_url":"https://api.github.com/users/tal-moshayov/gists{/gist_id}","starred_url":"https://api.github.com/users/tal-moshayov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tal-moshayov/subscriptions","organizations_url":"https://api.github.com/users/tal-moshayov/orgs","repos_url":"https://api.github.com/users/tal-moshayov/repos","events_url":"https://api.github.com/users/tal-moshayov/events{/privacy}","received_events_url":"https://api.github.com/users/tal-moshayov/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-23T09:11:54Z","updated_at":"2016-05-23T09:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59940756152049a138435f6ac1f97bdf4c2ee783","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/1/comments","statuses_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/statuses/01766b7985c3b394ecde16858ad3f80ceb3308f9","head":{"label":"SpotIM:code-review-fixes","ref":"code-review-fixes","sha":"01766b7985c3b394ecde16858ad3f80ceb3308f9","user":{"login":"SpotIM","id":3000076,"avatar_url":"https://avatars.githubusercontent.com/u/3000076?v=3","gravatar_id":"","url":"https://api.github.com/users/SpotIM","html_url":"https://github.com/SpotIM","followers_url":"https://api.github.com/users/SpotIM/followers","following_url":"https://api.github.com/users/SpotIM/following{/other_user}","gists_url":"https://api.github.com/users/SpotIM/gists{/gist_id}","starred_url":"https://api.github.com/users/SpotIM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpotIM/subscriptions","organizations_url":"https://api.github.com/users/SpotIM/orgs","repos_url":"https://api.github.com/users/SpotIM/repos","events_url":"https://api.github.com/users/SpotIM/events{/privacy}","received_events_url":"https://api.github.com/users/SpotIM/received_events","type":"Organization","site_admin":false},"repo":{"id":49566014,"name":"wordpress-comments-plugin","full_name":"SpotIM/wordpress-comments-plugin","owner":{"login":"SpotIM","id":3000076,"avatar_url":"https://avatars.githubusercontent.com/u/3000076?v=3","gravatar_id":"","url":"https://api.github.com/users/SpotIM","html_url":"https://github.com/SpotIM","followers_url":"https://api.github.com/users/SpotIM/followers","following_url":"https://api.github.com/users/SpotIM/following{/other_user}","gists_url":"https://api.github.com/users/SpotIM/gists{/gist_id}","starred_url":"https://api.github.com/users/SpotIM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpotIM/subscriptions","organizations_url":"https://api.github.com/users/SpotIM/orgs","repos_url":"https://api.github.com/users/SpotIM/repos","events_url":"https://api.github.com/users/SpotIM/events{/privacy}","received_events_url":"https://api.github.com/users/SpotIM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpotIM/wordpress-comments-plugin","description":"Spot.IM WP Comments Plugin","fork":false,"url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin","forks_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/forks","keys_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/teams","hooks_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/hooks","issue_events_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/events","assignees_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/tags","blobs_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/languages","stargazers_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/stargazers","contributors_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/contributors","subscribers_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/subscribers","subscription_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/subscription","commits_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/merges","archive_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/downloads","issues_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/labels{/name}","releases_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/deployments","created_at":"2016-01-13T10:11:32Z","updated_at":"2016-05-12T15:07:25Z","pushed_at":"2016-05-23T09:11:54Z","git_url":"git://github.com/SpotIM/wordpress-comments-plugin.git","ssh_url":"git@github.com:SpotIM/wordpress-comments-plugin.git","clone_url":"https://github.com/SpotIM/wordpress-comments-plugin.git","svn_url":"https://github.com/SpotIM/wordpress-comments-plugin","homepage":"https://wordpress.org/plugins/spotim-comments/","size":122,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"SpotIM:master","ref":"master","sha":"21cd62e227023df146b96982cc6996dea0721c5f","user":{"login":"SpotIM","id":3000076,"avatar_url":"https://avatars.githubusercontent.com/u/3000076?v=3","gravatar_id":"","url":"https://api.github.com/users/SpotIM","html_url":"https://github.com/SpotIM","followers_url":"https://api.github.com/users/SpotIM/followers","following_url":"https://api.github.com/users/SpotIM/following{/other_user}","gists_url":"https://api.github.com/users/SpotIM/gists{/gist_id}","starred_url":"https://api.github.com/users/SpotIM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpotIM/subscriptions","organizations_url":"https://api.github.com/users/SpotIM/orgs","repos_url":"https://api.github.com/users/SpotIM/repos","events_url":"https://api.github.com/users/SpotIM/events{/privacy}","received_events_url":"https://api.github.com/users/SpotIM/received_events","type":"Organization","site_admin":false},"repo":{"id":49566014,"name":"wordpress-comments-plugin","full_name":"SpotIM/wordpress-comments-plugin","owner":{"login":"SpotIM","id":3000076,"avatar_url":"https://avatars.githubusercontent.com/u/3000076?v=3","gravatar_id":"","url":"https://api.github.com/users/SpotIM","html_url":"https://github.com/SpotIM","followers_url":"https://api.github.com/users/SpotIM/followers","following_url":"https://api.github.com/users/SpotIM/following{/other_user}","gists_url":"https://api.github.com/users/SpotIM/gists{/gist_id}","starred_url":"https://api.github.com/users/SpotIM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpotIM/subscriptions","organizations_url":"https://api.github.com/users/SpotIM/orgs","repos_url":"https://api.github.com/users/SpotIM/repos","events_url":"https://api.github.com/users/SpotIM/events{/privacy}","received_events_url":"https://api.github.com/users/SpotIM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpotIM/wordpress-comments-plugin","description":"Spot.IM WP Comments Plugin","fork":false,"url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin","forks_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/forks","keys_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/teams","hooks_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/hooks","issue_events_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/events","assignees_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/tags","blobs_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/languages","stargazers_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/stargazers","contributors_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/contributors","subscribers_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/subscribers","subscription_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/subscription","commits_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/merges","archive_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/downloads","issues_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/labels{/name}","releases_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/deployments","created_at":"2016-01-13T10:11:32Z","updated_at":"2016-05-12T15:07:25Z","pushed_at":"2016-05-23T09:11:54Z","git_url":"git://github.com/SpotIM/wordpress-comments-plugin.git","ssh_url":"git@github.com:SpotIM/wordpress-comments-plugin.git","clone_url":"https://github.com/SpotIM/wordpress-comments-plugin.git","svn_url":"https://github.com/SpotIM/wordpress-comments-plugin","homepage":"https://wordpress.org/plugins/spotim-comments/","size":122,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1"},"html":{"href":"https://github.com/SpotIM/wordpress-comments-plugin/pull/1"},"issue":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/1"},"comments":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SpotIM/wordpress-comments-plugin/statuses/01766b7985c3b394ecde16858ad3f80ceb3308f9"}}}}
{"actor":{"display_login":"tal-moshayov"}}