{"action":"created","issue":{"url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/issues/172","repository_url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs","labels_url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/issues/172/comments","events_url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/issues/172/events","html_url":"https://github.com/find-sec-bugs/find-sec-bugs/issues/172","id":132870206,"number":172,"title":"CustomInjection issues","user":{"login":"dcsobral","id":141079,"avatar_url":"https://avatars.githubusercontent.com/u/141079?v=3","gravatar_id":"","url":"https://api.github.com/users/dcsobral","html_url":"https://github.com/dcsobral","followers_url":"https://api.github.com/users/dcsobral/followers","following_url":"https://api.github.com/users/dcsobral/following{/other_user}","gists_url":"https://api.github.com/users/dcsobral/gists{/gist_id}","starred_url":"https://api.github.com/users/dcsobral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcsobral/subscriptions","organizations_url":"https://api.github.com/users/dcsobral/orgs","repos_url":"https://api.github.com/users/dcsobral/repos","events_url":"https://api.github.com/users/dcsobral/events{/privacy}","received_events_url":"https://api.github.com/users/dcsobral/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"h3xstream","id":593130,"avatar_url":"https://avatars.githubusercontent.com/u/593130?v=3","gravatar_id":"","url":"https://api.github.com/users/h3xstream","html_url":"https://github.com/h3xstream","followers_url":"https://api.github.com/users/h3xstream/followers","following_url":"https://api.github.com/users/h3xstream/following{/other_user}","gists_url":"https://api.github.com/users/h3xstream/gists{/gist_id}","starred_url":"https://api.github.com/users/h3xstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h3xstream/subscriptions","organizations_url":"https://api.github.com/users/h3xstream/orgs","repos_url":"https://api.github.com/users/h3xstream/repos","events_url":"https://api.github.com/users/h3xstream/events{/privacy}","received_events_url":"https://api.github.com/users/h3xstream/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/milestones/11","html_url":"https://github.com/find-sec-bugs/find-sec-bugs/milestones/version-1.4.6","labels_url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/milestones/11/labels","id":1490598,"number":11,"title":"version-1.4.6","description":"","creator":{"login":"h3xstream","id":593130,"avatar_url":"https://avatars.githubusercontent.com/u/593130?v=3","gravatar_id":"","url":"https://api.github.com/users/h3xstream","html_url":"https://github.com/h3xstream","followers_url":"https://api.github.com/users/h3xstream/followers","following_url":"https://api.github.com/users/h3xstream/following{/other_user}","gists_url":"https://api.github.com/users/h3xstream/gists{/gist_id}","starred_url":"https://api.github.com/users/h3xstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h3xstream/subscriptions","organizations_url":"https://api.github.com/users/h3xstream/orgs","repos_url":"https://api.github.com/users/h3xstream/repos","events_url":"https://api.github.com/users/h3xstream/events{/privacy}","received_events_url":"https://api.github.com/users/h3xstream/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":13,"state":"open","created_at":"2016-01-07T23:19:03Z","updated_at":"2016-05-31T18:53:59Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-02-11T02:00:02Z","updated_at":"2016-05-31T19:03:08Z","closed_at":null,"body":" - [ ] Clearer documentation\r\n - [x] Support for files and resources\r\n - [x] Noisy error message\r\n\r\n## 1. Clearer documentation\r\n\r\nThis is a mix of documentation and implementation issues. On the documentation side, no mention of `com/h3xstream/findsecbugs/injection/custom/CustomInjectionSource.properties` is made, though that resource is always loaded by default.\r\n\r\nThe error message produced when it isn't found points to the documentation, which seems to imply that no error message will be produced unless `findsecbugs.injection.sources` is set, or, alternatively, that no error message will be produced _if_ `findsecbugs.injection.sources` is set (the text is really unclear). Neither is the case, however.\r\n\r\nSo, the documentation should mention that the above file is always searched for and will always produce an error message if not found, and further that `findsecbugs.injection.sources` is used to provide _additional_ sources. It should also point out that multiple sources can be provided, something I only learned from the source code.\r\n\r\n## 2. Support for files and resources\r\n\r\nSecond, `findsecbugs.injection.sources` searches _only_ for files. The findbugs plugin searches first for files then for resources, copying whatever it finds to the target directory for use, when configuring include and exclude filters. The checkstyle plugin does something similar, though the documentation suggests the order there is reversed. It would be really helpful if `findsecbugs.injection.sources` could be similarly configured, and documented.\r\n\r\n## 3. Noisy error message\r\n\r\nI'd rather `CustomInjectionSource` error message was omitted if `findsecbugs.injection.sources` is specified, as the documentation implies, so that one doesn't need to provide a file with `h3xstream`'s package path.\r\n\r\nI'm putting all this in one ticket because the docs need to be changed in any case, and they need to be updated if any of the implementation is changed too."},"comment":{"url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/issues/comments/222787706","html_url":"https://github.com/find-sec-bugs/find-sec-bugs/issues/172#issuecomment-222787706","issue_url":"https://api.github.com/repos/find-sec-bugs/find-sec-bugs/issues/172","id":222787706,"user":{"login":"h3xstream","id":593130,"avatar_url":"https://avatars.githubusercontent.com/u/593130?v=3","gravatar_id":"","url":"https://api.github.com/users/h3xstream","html_url":"https://github.com/h3xstream","followers_url":"https://api.github.com/users/h3xstream/followers","following_url":"https://api.github.com/users/h3xstream/following{/other_user}","gists_url":"https://api.github.com/users/h3xstream/gists{/gist_id}","starred_url":"https://api.github.com/users/h3xstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h3xstream/subscriptions","organizations_url":"https://api.github.com/users/h3xstream/orgs","repos_url":"https://api.github.com/users/h3xstream/repos","events_url":"https://api.github.com/users/h3xstream/events{/privacy}","received_events_url":"https://api.github.com/users/h3xstream/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T19:03:08Z","updated_at":"2016-05-31T19:03:08Z","body":"Status update.\r\n\r\n@dcsobral I numbered your requests in the original.\r\n\r\n2. It now test the path with first file based loading and than as a resource.\r\n3. The warning is no longer present.\r\n1. Documentation will be refactored soon."}}
{"actor":{"display_login":"h3xstream"}}