{"action":"created","comment":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/83174530","pull_request_review_id":3422859,"id":83174530,"diff_hunk":"@@ -656,44 +686,37 @@ aeif_cond_beta_multisynapse_dynamics( double,\n   // good compiler will optimize the verbosity away ...\n \n   // shorthand for state variables\n-  const double& V = y[ S::V_M ];\n+  const double& V = std::min( y[ S::V_M ], node.P_.V_peak_ ); // bound V\n   const double& w = y[ S::W ];\n \n   double I_syn = 0.0;\n \n-  for ( size_t i = 0; i < ( node.P_.num_of_receptors_\n-                            * S::NUMBER_OF_STATES_ELEMENTS_PER_RECEPTOR );\n-        i += S::NUMBER_OF_STATES_ELEMENTS_PER_RECEPTOR )\n+  for ( size_t i = 0; i < node.P_.num_of_receptors; ++i )\n   {\n-    double g = y[ S::G + i ];\n-    if ( g > 0 )\n-    {\n-      I_syn += g * ( node.P_.E_ex - V ); // g>0, E_ex>V => I_syn increases\n-    }\n-    else\n-    {\n-      I_syn += g * ( V - node.P_.E_in ); // g<0, V>E_in => I_syn decreases\n-    }\n+    size_t j = i * S::NUMBER_OF_STATES_ELEMENTS_PER_RECEPTOR;\n+    // I_syn = I_syn + g*(E_rev - V)","path":"models/aeif_cond_beta_multisynapse.cpp","position":338,"original_position":338,"commit_id":"5e3f5dbfb202298cf14e8f14c99d37770f7436fb","original_commit_id":"5e3f5dbfb202298cf14e8f14c99d37770f7436fb","user":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"body":"Maybe move this comment above the `I_syn = 0` initialization and make the summation explicit: `I_syn = - sum_k g_k (V - E_rev_k)`.\r\n","created_at":"2016-10-13T09:19:57Z","updated_at":"2016-10-13T09:19:57Z","html_url":"https://github.com/nest/nest-simulator/pull/516#discussion_r83174530","pull_request_url":"https://api.github.com/repos/nest/nest-simulator/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/83174530"},"html":{"href":"https://github.com/nest/nest-simulator/pull/516#discussion_r83174530"},"pull_request":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/516","id":88516109,"html_url":"https://github.com/nest/nest-simulator/pull/516","diff_url":"https://github.com/nest/nest-simulator/pull/516.diff","patch_url":"https://github.com/nest/nest-simulator/pull/516.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/516","number":516,"state":"open","locked":false,"title":"Correct input handling for aeif_cond_beta_multisynapse #510 and Update aeif_cond_beta_multisynapse to new aeif numerics approach #514","user":{"login":"golosio","id":3852089,"avatar_url":"https://avatars.githubusercontent.com/u/3852089?v=3","gravatar_id":"","url":"https://api.github.com/users/golosio","html_url":"https://github.com/golosio","followers_url":"https://api.github.com/users/golosio/followers","following_url":"https://api.github.com/users/golosio/following{/other_user}","gists_url":"https://api.github.com/users/golosio/gists{/gist_id}","starred_url":"https://api.github.com/users/golosio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golosio/subscriptions","organizations_url":"https://api.github.com/users/golosio/orgs","repos_url":"https://api.github.com/users/golosio/repos","events_url":"https://api.github.com/users/golosio/events{/privacy}","received_events_url":"https://api.github.com/users/golosio/received_events","type":"User","site_admin":false},"body":"I modified input handling for aeif_cond_beta_multisynapse according to the decision made in the NEST Developer VC 19 Sep 2016, see issue https://github.com/nest/nest-simulator/issues/510\r\n","created_at":"2016-10-07T22:11:16Z","updated_at":"2016-10-13T09:25:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fdba6be409ee6291084754c65f85bcecbc367e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/516/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/516/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/516/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/5e3f5dbfb202298cf14e8f14c99d37770f7436fb","head":{"label":"golosio:reversal_potential","ref":"reversal_potential","sha":"5e3f5dbfb202298cf14e8f14c99d37770f7436fb","user":{"login":"golosio","id":3852089,"avatar_url":"https://avatars.githubusercontent.com/u/3852089?v=3","gravatar_id":"","url":"https://api.github.com/users/golosio","html_url":"https://github.com/golosio","followers_url":"https://api.github.com/users/golosio/followers","following_url":"https://api.github.com/users/golosio/following{/other_user}","gists_url":"https://api.github.com/users/golosio/gists{/gist_id}","starred_url":"https://api.github.com/users/golosio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golosio/subscriptions","organizations_url":"https://api.github.com/users/golosio/orgs","repos_url":"https://api.github.com/users/golosio/repos","events_url":"https://api.github.com/users/golosio/events{/privacy}","received_events_url":"https://api.github.com/users/golosio/received_events","type":"User","site_admin":false},"repo":{"id":64515913,"name":"nest-simulator","full_name":"golosio/nest-simulator","owner":{"login":"golosio","id":3852089,"avatar_url":"https://avatars.githubusercontent.com/u/3852089?v=3","gravatar_id":"","url":"https://api.github.com/users/golosio","html_url":"https://github.com/golosio","followers_url":"https://api.github.com/users/golosio/followers","following_url":"https://api.github.com/users/golosio/following{/other_user}","gists_url":"https://api.github.com/users/golosio/gists{/gist_id}","starred_url":"https://api.github.com/users/golosio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golosio/subscriptions","organizations_url":"https://api.github.com/users/golosio/orgs","repos_url":"https://api.github.com/users/golosio/repos","events_url":"https://api.github.com/users/golosio/events{/privacy}","received_events_url":"https://api.github.com/users/golosio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/golosio/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/golosio/nest-simulator","forks_url":"https://api.github.com/repos/golosio/nest-simulator/forks","keys_url":"https://api.github.com/repos/golosio/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golosio/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golosio/nest-simulator/teams","hooks_url":"https://api.github.com/repos/golosio/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/golosio/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/golosio/nest-simulator/events","assignees_url":"https://api.github.com/repos/golosio/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/golosio/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/golosio/nest-simulator/tags","blobs_url":"https://api.github.com/repos/golosio/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golosio/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golosio/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/golosio/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golosio/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/golosio/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/golosio/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/golosio/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/golosio/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/golosio/nest-simulator/subscription","commits_url":"https://api.github.com/repos/golosio/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/golosio/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/golosio/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/golosio/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/golosio/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/golosio/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golosio/nest-simulator/merges","archive_url":"https://api.github.com/repos/golosio/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golosio/nest-simulator/downloads","issues_url":"https://api.github.com/repos/golosio/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/golosio/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/golosio/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/golosio/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golosio/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/golosio/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/golosio/nest-simulator/deployments","created_at":"2016-07-29T23:24:46Z","updated_at":"2016-07-29T23:24:49Z","pushed_at":"2016-10-13T09:12:08Z","git_url":"git://github.com/golosio/nest-simulator.git","ssh_url":"git@github.com:golosio/nest-simulator.git","clone_url":"https://github.com/golosio/nest-simulator.git","svn_url":"https://github.com/golosio/nest-simulator","homepage":null,"size":25186,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"75fd1354428e7793cc6e817185400061b5346d42","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2016-09-30T00:55:47Z","pushed_at":"2016-10-13T09:12:09Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":33515,"stargazers_count":87,"watchers_count":87,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":89,"mirror_url":null,"open_issues_count":164,"forks":89,"open_issues":164,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/516"},"html":{"href":"https://github.com/nest/nest-simulator/pull/516"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/516"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/5e3f5dbfb202298cf14e8f14c99d37770f7436fb"}}}}
{"actor":{"display_login":"heplesser"}}