{"action":"created","comment":{"url":"https://api.github.com/repos/getnikola/nikola/pulls/comments/90759756","pull_request_review_id":11279301,"id":90759756,"diff_hunk":"@@ -73,6 +73,12 @@ def _do_classification(self, site):\n                                 post.meta[lang][taxonomy.metadata_name] = classifications[lang]\n                             else:\n                                 post.meta[lang][taxonomy.metadata_name] = classifications[lang][0] if len(classifications[lang]) > 0 else None\n+                        if taxonomy.metadata_friendly_name is not None:","path":"nikola/plugins/misc/taxonomies_classifier.py","position":null,"original_position":25,"commit_id":"8291489473dd83ab08b53881b979001a763550c5","original_commit_id":"e91fe1d74da59cf30364522ba104d4df4f1d7b00","user":{"login":"felixfontein","id":5781356,"avatar_url":"https://avatars.githubusercontent.com/u/5781356?v=3","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"body":"This is gone, too.","created_at":"2016-12-03T15:57:48Z","updated_at":"2016-12-03T15:57:48Z","html_url":"https://github.com/getnikola/nikola/pull/2535#discussion_r90759756","pull_request_url":"https://api.github.com/repos/getnikola/nikola/pulls/2535","_links":{"self":{"href":"https://api.github.com/repos/getnikola/nikola/pulls/comments/90759756"},"html":{"href":"https://github.com/getnikola/nikola/pull/2535#discussion_r90759756"},"pull_request":{"href":"https://api.github.com/repos/getnikola/nikola/pulls/2535"}}},"pull_request":{"url":"https://api.github.com/repos/getnikola/nikola/pulls/2535","id":89522414,"html_url":"https://github.com/getnikola/nikola/pull/2535","diff_url":"https://github.com/getnikola/nikola/pull/2535.diff","patch_url":"https://github.com/getnikola/nikola/pull/2535.patch","issue_url":"https://api.github.com/repos/getnikola/nikola/issues/2535","number":2535,"state":"open","locked":false,"title":"Experiments for generalization of taxonomies.","user":{"login":"felixfontein","id":5781356,"avatar_url":"https://avatars.githubusercontent.com/u/5781356?v=3","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"body":"This is about #2107. I added a new plugin category, `Taxonomy`, as well as two plugins which take care to classify posts with all `Taxonomy` plugins and render all associated pages for them.\n\nThe next step is re-implementing the following plugins with this framework and see if it works:\n- `archive`\n- `authors`\n- `indexes` (needs to be split up into two plugins, one for the main index and one for section indexes)\n\nIt's not possible to recreate the `tags` plugin with this framework as it contains the option (which is even default!) to put tags and categories onto the _same overview page_. But that problem will be solved in v8 anyway when categories go away :)\n","created_at":"2016-10-16T10:47:43Z","updated_at":"2016-12-03T15:57:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33793613af02187175610aec53b4d966a082350e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/getnikola/nikola/pulls/2535/commits","review_comments_url":"https://api.github.com/repos/getnikola/nikola/pulls/2535/comments","review_comment_url":"https://api.github.com/repos/getnikola/nikola/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getnikola/nikola/issues/2535/comments","statuses_url":"https://api.github.com/repos/getnikola/nikola/statuses/8291489473dd83ab08b53881b979001a763550c5","head":{"label":"getnikola:generalization-of-taxonomies","ref":"generalization-of-taxonomies","sha":"8291489473dd83ab08b53881b979001a763550c5","user":{"login":"getnikola","id":5413476,"avatar_url":"https://avatars.githubusercontent.com/u/5413476?v=3","gravatar_id":"","url":"https://api.github.com/users/getnikola","html_url":"https://github.com/getnikola","followers_url":"https://api.github.com/users/getnikola/followers","following_url":"https://api.github.com/users/getnikola/following{/other_user}","gists_url":"https://api.github.com/users/getnikola/gists{/gist_id}","starred_url":"https://api.github.com/users/getnikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getnikola/subscriptions","organizations_url":"https://api.github.com/users/getnikola/orgs","repos_url":"https://api.github.com/users/getnikola/repos","events_url":"https://api.github.com/users/getnikola/events{/privacy}","received_events_url":"https://api.github.com/users/getnikola/received_events","type":"Organization","site_admin":false},"repo":{"id":4025121,"name":"nikola","full_name":"getnikola/nikola","owner":{"login":"getnikola","id":5413476,"avatar_url":"https://avatars.githubusercontent.com/u/5413476?v=3","gravatar_id":"","url":"https://api.github.com/users/getnikola","html_url":"https://github.com/getnikola","followers_url":"https://api.github.com/users/getnikola/followers","following_url":"https://api.github.com/users/getnikola/following{/other_user}","gists_url":"https://api.github.com/users/getnikola/gists{/gist_id}","starred_url":"https://api.github.com/users/getnikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getnikola/subscriptions","organizations_url":"https://api.github.com/users/getnikola/orgs","repos_url":"https://api.github.com/users/getnikola/repos","events_url":"https://api.github.com/users/getnikola/events{/privacy}","received_events_url":"https://api.github.com/users/getnikola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getnikola/nikola","description":"A static website and blog generator","fork":false,"url":"https://api.github.com/repos/getnikola/nikola","forks_url":"https://api.github.com/repos/getnikola/nikola/forks","keys_url":"https://api.github.com/repos/getnikola/nikola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getnikola/nikola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getnikola/nikola/teams","hooks_url":"https://api.github.com/repos/getnikola/nikola/hooks","issue_events_url":"https://api.github.com/repos/getnikola/nikola/issues/events{/number}","events_url":"https://api.github.com/repos/getnikola/nikola/events","assignees_url":"https://api.github.com/repos/getnikola/nikola/assignees{/user}","branches_url":"https://api.github.com/repos/getnikola/nikola/branches{/branch}","tags_url":"https://api.github.com/repos/getnikola/nikola/tags","blobs_url":"https://api.github.com/repos/getnikola/nikola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getnikola/nikola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getnikola/nikola/git/refs{/sha}","trees_url":"https://api.github.com/repos/getnikola/nikola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getnikola/nikola/statuses/{sha}","languages_url":"https://api.github.com/repos/getnikola/nikola/languages","stargazers_url":"https://api.github.com/repos/getnikola/nikola/stargazers","contributors_url":"https://api.github.com/repos/getnikola/nikola/contributors","subscribers_url":"https://api.github.com/repos/getnikola/nikola/subscribers","subscription_url":"https://api.github.com/repos/getnikola/nikola/subscription","commits_url":"https://api.github.com/repos/getnikola/nikola/commits{/sha}","git_commits_url":"https://api.github.com/repos/getnikola/nikola/git/commits{/sha}","comments_url":"https://api.github.com/repos/getnikola/nikola/comments{/number}","issue_comment_url":"https://api.github.com/repos/getnikola/nikola/issues/comments{/number}","contents_url":"https://api.github.com/repos/getnikola/nikola/contents/{+path}","compare_url":"https://api.github.com/repos/getnikola/nikola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getnikola/nikola/merges","archive_url":"https://api.github.com/repos/getnikola/nikola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getnikola/nikola/downloads","issues_url":"https://api.github.com/repos/getnikola/nikola/issues{/number}","pulls_url":"https://api.github.com/repos/getnikola/nikola/pulls{/number}","milestones_url":"https://api.github.com/repos/getnikola/nikola/milestones{/number}","notifications_url":"https://api.github.com/repos/getnikola/nikola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getnikola/nikola/labels{/name}","releases_url":"https://api.github.com/repos/getnikola/nikola/releases{/id}","deployments_url":"https://api.github.com/repos/getnikola/nikola/deployments","created_at":"2012-04-14T13:53:22Z","updated_at":"2016-11-30T20:09:31Z","pushed_at":"2016-12-03T15:54:51Z","git_url":"git://github.com/getnikola/nikola.git","ssh_url":"git@github.com:getnikola/nikola.git","clone_url":"https://github.com/getnikola/nikola.git","svn_url":"https://github.com/getnikola/nikola","homepage":"https://getnikola.com/","size":29594,"stargazers_count":1123,"watchers_count":1123,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":92,"forks":285,"open_issues":92,"watchers":1123,"default_branch":"master"}},"base":{"label":"getnikola:master","ref":"master","sha":"85b22e8e76df86777c981b31820806166dfcc79a","user":{"login":"getnikola","id":5413476,"avatar_url":"https://avatars.githubusercontent.com/u/5413476?v=3","gravatar_id":"","url":"https://api.github.com/users/getnikola","html_url":"https://github.com/getnikola","followers_url":"https://api.github.com/users/getnikola/followers","following_url":"https://api.github.com/users/getnikola/following{/other_user}","gists_url":"https://api.github.com/users/getnikola/gists{/gist_id}","starred_url":"https://api.github.com/users/getnikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getnikola/subscriptions","organizations_url":"https://api.github.com/users/getnikola/orgs","repos_url":"https://api.github.com/users/getnikola/repos","events_url":"https://api.github.com/users/getnikola/events{/privacy}","received_events_url":"https://api.github.com/users/getnikola/received_events","type":"Organization","site_admin":false},"repo":{"id":4025121,"name":"nikola","full_name":"getnikola/nikola","owner":{"login":"getnikola","id":5413476,"avatar_url":"https://avatars.githubusercontent.com/u/5413476?v=3","gravatar_id":"","url":"https://api.github.com/users/getnikola","html_url":"https://github.com/getnikola","followers_url":"https://api.github.com/users/getnikola/followers","following_url":"https://api.github.com/users/getnikola/following{/other_user}","gists_url":"https://api.github.com/users/getnikola/gists{/gist_id}","starred_url":"https://api.github.com/users/getnikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getnikola/subscriptions","organizations_url":"https://api.github.com/users/getnikola/orgs","repos_url":"https://api.github.com/users/getnikola/repos","events_url":"https://api.github.com/users/getnikola/events{/privacy}","received_events_url":"https://api.github.com/users/getnikola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getnikola/nikola","description":"A static website and blog generator","fork":false,"url":"https://api.github.com/repos/getnikola/nikola","forks_url":"https://api.github.com/repos/getnikola/nikola/forks","keys_url":"https://api.github.com/repos/getnikola/nikola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getnikola/nikola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getnikola/nikola/teams","hooks_url":"https://api.github.com/repos/getnikola/nikola/hooks","issue_events_url":"https://api.github.com/repos/getnikola/nikola/issues/events{/number}","events_url":"https://api.github.com/repos/getnikola/nikola/events","assignees_url":"https://api.github.com/repos/getnikola/nikola/assignees{/user}","branches_url":"https://api.github.com/repos/getnikola/nikola/branches{/branch}","tags_url":"https://api.github.com/repos/getnikola/nikola/tags","blobs_url":"https://api.github.com/repos/getnikola/nikola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getnikola/nikola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getnikola/nikola/git/refs{/sha}","trees_url":"https://api.github.com/repos/getnikola/nikola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getnikola/nikola/statuses/{sha}","languages_url":"https://api.github.com/repos/getnikola/nikola/languages","stargazers_url":"https://api.github.com/repos/getnikola/nikola/stargazers","contributors_url":"https://api.github.com/repos/getnikola/nikola/contributors","subscribers_url":"https://api.github.com/repos/getnikola/nikola/subscribers","subscription_url":"https://api.github.com/repos/getnikola/nikola/subscription","commits_url":"https://api.github.com/repos/getnikola/nikola/commits{/sha}","git_commits_url":"https://api.github.com/repos/getnikola/nikola/git/commits{/sha}","comments_url":"https://api.github.com/repos/getnikola/nikola/comments{/number}","issue_comment_url":"https://api.github.com/repos/getnikola/nikola/issues/comments{/number}","contents_url":"https://api.github.com/repos/getnikola/nikola/contents/{+path}","compare_url":"https://api.github.com/repos/getnikola/nikola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getnikola/nikola/merges","archive_url":"https://api.github.com/repos/getnikola/nikola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getnikola/nikola/downloads","issues_url":"https://api.github.com/repos/getnikola/nikola/issues{/number}","pulls_url":"https://api.github.com/repos/getnikola/nikola/pulls{/number}","milestones_url":"https://api.github.com/repos/getnikola/nikola/milestones{/number}","notifications_url":"https://api.github.com/repos/getnikola/nikola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getnikola/nikola/labels{/name}","releases_url":"https://api.github.com/repos/getnikola/nikola/releases{/id}","deployments_url":"https://api.github.com/repos/getnikola/nikola/deployments","created_at":"2012-04-14T13:53:22Z","updated_at":"2016-11-30T20:09:31Z","pushed_at":"2016-12-03T15:54:51Z","git_url":"git://github.com/getnikola/nikola.git","ssh_url":"git@github.com:getnikola/nikola.git","clone_url":"https://github.com/getnikola/nikola.git","svn_url":"https://github.com/getnikola/nikola","homepage":"https://getnikola.com/","size":29594,"stargazers_count":1123,"watchers_count":1123,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":92,"forks":285,"open_issues":92,"watchers":1123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getnikola/nikola/pulls/2535"},"html":{"href":"https://github.com/getnikola/nikola/pull/2535"},"issue":{"href":"https://api.github.com/repos/getnikola/nikola/issues/2535"},"comments":{"href":"https://api.github.com/repos/getnikola/nikola/issues/2535/comments"},"review_comments":{"href":"https://api.github.com/repos/getnikola/nikola/pulls/2535/comments"},"review_comment":{"href":"https://api.github.com/repos/getnikola/nikola/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getnikola/nikola/pulls/2535/commits"},"statuses":{"href":"https://api.github.com/repos/getnikola/nikola/statuses/8291489473dd83ab08b53881b979001a763550c5"}}}}
{"actor":{"display_login":"felixfontein"}}