{"action":"created","issue":{"url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab/issues/4","repository_url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab","labels_url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab/issues/4/comments","events_url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab/issues/4/events","html_url":"https://github.com/ga-adi-nyc/Joins-Lab/pull/4","id":165995027,"number":4,"title":"Finished Lab","user":{"login":"StacyZol","id":18058741,"avatar_url":"https://avatars.githubusercontent.com/u/18058741?v=3","gravatar_id":"","url":"https://api.github.com/users/StacyZol","html_url":"https://github.com/StacyZol","followers_url":"https://api.github.com/users/StacyZol/followers","following_url":"https://api.github.com/users/StacyZol/following{/other_user}","gists_url":"https://api.github.com/users/StacyZol/gists{/gist_id}","starred_url":"https://api.github.com/users/StacyZol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StacyZol/subscriptions","organizations_url":"https://api.github.com/users/StacyZol/orgs","repos_url":"https://api.github.com/users/StacyZol/repos","events_url":"https://api.github.com/users/StacyZol/events{/privacy}","received_events_url":"https://api.github.com/users/StacyZol/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-17T20:41:57Z","updated_at":"2016-07-26T14:17:47Z","closed_at":"2016-07-26T14:17:47Z","pull_request":{"url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab/pulls/4","html_url":"https://github.com/ga-adi-nyc/Joins-Lab/pull/4","diff_url":"https://github.com/ga-adi-nyc/Joins-Lab/pull/4.diff","patch_url":"https://github.com/ga-adi-nyc/Joins-Lab/pull/4.patch"},"body":"I think I need to close the cursor so the list doesn't repeat infinitely in the list view but I couldn't figure out how to close the cursor in my database helper if I'm returning the cursor"},"comment":{"url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab/issues/comments/235281553","html_url":"https://github.com/ga-adi-nyc/Joins-Lab/pull/4#issuecomment-235281553","issue_url":"https://api.github.com/repos/ga-adi-nyc/Joins-Lab/issues/4","id":235281553,"user":{"login":"drew-mahrt","id":15946547,"avatar_url":"https://avatars.githubusercontent.com/u/15946547?v=3","gravatar_id":"","url":"https://api.github.com/users/drew-mahrt","html_url":"https://github.com/drew-mahrt","followers_url":"https://api.github.com/users/drew-mahrt/followers","following_url":"https://api.github.com/users/drew-mahrt/following{/other_user}","gists_url":"https://api.github.com/users/drew-mahrt/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-mahrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-mahrt/subscriptions","organizations_url":"https://api.github.com/users/drew-mahrt/orgs","repos_url":"https://api.github.com/users/drew-mahrt/repos","events_url":"https://api.github.com/users/drew-mahrt/events{/privacy}","received_events_url":"https://api.github.com/users/drew-mahrt/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T14:17:47Z","updated_at":"2016-07-26T14:17:47Z","body":"# ![](https://ga-dash.s3.amazonaws.com/production/assets/logo-9f88ae6c9c3871690e33280fcf557f33.png) RUBRIC\r\n**Joins Lab | ADI** \t \t\t\t\t\t\t\r\n\r\n\r\n#### Performance Evaluation\r\n> Mark boxes with an 'X'; if did not achieve bonus, mark with a '-'\r\n\r\n| Requirements | Incomplete (0) | Does Not Meet Expectations (1) | Meets Expectations (2) | Exceeds Expectations (3) |\r\n|---|---|---|---|---|\r\n| The SQLiteOpenHelper establishes a database with the necessary Employee and Job tables | | | x| n/a |\r\n| The \"Add Data\" button in MainActivity populates the 2 database tables | | | x| n/a |\r\n| The floating action button launches a dialog to collect a new entry for the employe table | | | x| n/a |\r\n| The \"Add Data\" button in the dialog adds the new entry to the database and notifies the user via toast | | |  x| n/a |\r\n| The \"employee working at the same company\" button shows the relevant employees' full names in the ListView in MainActivity | | | x | n/a |\r\n| The \"companies in Boston\" button shows the relevant companies in the ListView in MainActivity | | | x| n/a |\r\n| The \"company with the highest salary\" button shows the relevant company in the TextView in MainActivity | |x | | n/a |\r\n| **Bonus**: The app uses SQLiteQueryBuilder to create the join queries | n/a | n/a | n/a | -  |\r\n\r\n\r\nNotes:\r\n\r\nGood job! You seem to have a really good handle on working with SQLite, and how joins work. I took off a point from the highest salary requirement, because the result should have been Stop, but Macy's showed up.\r\n\r\nTo answer your question about how to close the cursor, you can close them in MainActivity. Before we were closing them in the database helper, but it doesn't really matter where you do it. You would just call cursor.close() in your MainActivity, or when you are changing cursors in the ListView you could get a reference to the cursor there and then close it.\r\n\r\n---\r\n\r\n## Score:\r\nBased on the requirements, you can earn a maximum of  **14**  points on this project.\r\n\r\n#### Your total score is: **13**"}}
{"actor":{"display_login":"drew-mahrt"}}