{"action":"created","comment":{"url":"https://api.github.com/repos/indico/indico/pulls/comments/78343761","id":78343761,"diff_hunk":"@@ -11,7 +11,15 @@\n         {% for reminder in reminders %}\n             <li>\n                 <strong>\n-                    <a href=\"{{ url_for('.edit', reminder) }}\">\n+                    <a href=\"#\" data-href=\"{{ url_for('.edit', reminder) }}\"\n+                       data-ajax-dialog\n+                       data-hide-page-header\n+                       data-reload-after\n+                       data-title=\"{% if not reminder.is_sent %}","path":"indico/modules/events/reminders/templates/reminders.html","position":9,"original_position":9,"commit_id":"71c35f9fc0655953edb7dd0e7b531d53b82d31e8","original_commit_id":"71c35f9fc0655953edb7dd0e7b531d53b82d31e8","user":{"login":"ThiefMaster","id":179599,"avatar_url":"https://avatars.githubusercontent.com/u/179599?v=3","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"body":"we usually put the no-argument attributes last, so I'd move this one before `data-ajax-dialog`\r\n\r\nit might also be more readable to assign it first and just use `data-title=\"{{ button_title }}\"`:\r\n\r\n```\r\n{% if ... %}\r\n    {% set button_title = _(\"Edit reminder\") %}\r\n{% else %}\r\n    {% set button_title = _(\"Reminder details\") %}\r\n{% endif %}\r\n```","created_at":"2016-09-12T09:52:08Z","updated_at":"2016-09-12T09:52:08Z","html_url":"https://github.com/indico/indico/pull/2598#discussion_r78343761","pull_request_url":"https://api.github.com/repos/indico/indico/pulls/2598","_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/comments/78343761"},"html":{"href":"https://github.com/indico/indico/pull/2598#discussion_r78343761"},"pull_request":{"href":"https://api.github.com/repos/indico/indico/pulls/2598"}}},"pull_request":{"url":"https://api.github.com/repos/indico/indico/pulls/2598","id":84842646,"html_url":"https://github.com/indico/indico/pull/2598","diff_url":"https://github.com/indico/indico/pull/2598.diff","patch_url":"https://github.com/indico/indico/pull/2598.patch","issue_url":"https://api.github.com/repos/indico/indico/issues/2598","number":2598,"state":"open","locked":false,"title":"Change Add and Edit Reminder from page to dialog","user":{"login":"DavidAndreev","id":9071624,"avatar_url":"https://avatars.githubusercontent.com/u/9071624?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidAndreev","html_url":"https://github.com/DavidAndreev","followers_url":"https://api.github.com/users/DavidAndreev/followers","following_url":"https://api.github.com/users/DavidAndreev/following{/other_user}","gists_url":"https://api.github.com/users/DavidAndreev/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidAndreev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidAndreev/subscriptions","organizations_url":"https://api.github.com/users/DavidAndreev/orgs","repos_url":"https://api.github.com/users/DavidAndreev/repos","events_url":"https://api.github.com/users/DavidAndreev/events{/privacy}","received_events_url":"https://api.github.com/users/DavidAndreev/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-12T09:47:15Z","updated_at":"2016-09-12T09:52:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bde361d31a4e742d14b1857b37602ea28aa881b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/indico/indico/pulls/2598/commits","review_comments_url":"https://api.github.com/repos/indico/indico/pulls/2598/comments","review_comment_url":"https://api.github.com/repos/indico/indico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indico/indico/issues/2598/comments","statuses_url":"https://api.github.com/repos/indico/indico/statuses/71c35f9fc0655953edb7dd0e7b531d53b82d31e8","head":{"label":"DavidAndreev:move-forms-to-dialogs","ref":"move-forms-to-dialogs","sha":"71c35f9fc0655953edb7dd0e7b531d53b82d31e8","user":{"login":"DavidAndreev","id":9071624,"avatar_url":"https://avatars.githubusercontent.com/u/9071624?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidAndreev","html_url":"https://github.com/DavidAndreev","followers_url":"https://api.github.com/users/DavidAndreev/followers","following_url":"https://api.github.com/users/DavidAndreev/following{/other_user}","gists_url":"https://api.github.com/users/DavidAndreev/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidAndreev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidAndreev/subscriptions","organizations_url":"https://api.github.com/users/DavidAndreev/orgs","repos_url":"https://api.github.com/users/DavidAndreev/repos","events_url":"https://api.github.com/users/DavidAndreev/events{/privacy}","received_events_url":"https://api.github.com/users/DavidAndreev/received_events","type":"User","site_admin":false},"repo":{"id":67125805,"name":"indico","full_name":"DavidAndreev/indico","owner":{"login":"DavidAndreev","id":9071624,"avatar_url":"https://avatars.githubusercontent.com/u/9071624?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidAndreev","html_url":"https://github.com/DavidAndreev","followers_url":"https://api.github.com/users/DavidAndreev/followers","following_url":"https://api.github.com/users/DavidAndreev/following{/other_user}","gists_url":"https://api.github.com/users/DavidAndreev/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidAndreev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidAndreev/subscriptions","organizations_url":"https://api.github.com/users/DavidAndreev/orgs","repos_url":"https://api.github.com/users/DavidAndreev/repos","events_url":"https://api.github.com/users/DavidAndreev/events{/privacy}","received_events_url":"https://api.github.com/users/DavidAndreev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidAndreev/indico","description":"The Indico Project","fork":true,"url":"https://api.github.com/repos/DavidAndreev/indico","forks_url":"https://api.github.com/repos/DavidAndreev/indico/forks","keys_url":"https://api.github.com/repos/DavidAndreev/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidAndreev/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidAndreev/indico/teams","hooks_url":"https://api.github.com/repos/DavidAndreev/indico/hooks","issue_events_url":"https://api.github.com/repos/DavidAndreev/indico/issues/events{/number}","events_url":"https://api.github.com/repos/DavidAndreev/indico/events","assignees_url":"https://api.github.com/repos/DavidAndreev/indico/assignees{/user}","branches_url":"https://api.github.com/repos/DavidAndreev/indico/branches{/branch}","tags_url":"https://api.github.com/repos/DavidAndreev/indico/tags","blobs_url":"https://api.github.com/repos/DavidAndreev/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidAndreev/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidAndreev/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidAndreev/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidAndreev/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidAndreev/indico/languages","stargazers_url":"https://api.github.com/repos/DavidAndreev/indico/stargazers","contributors_url":"https://api.github.com/repos/DavidAndreev/indico/contributors","subscribers_url":"https://api.github.com/repos/DavidAndreev/indico/subscribers","subscription_url":"https://api.github.com/repos/DavidAndreev/indico/subscription","commits_url":"https://api.github.com/repos/DavidAndreev/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidAndreev/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidAndreev/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidAndreev/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidAndreev/indico/contents/{+path}","compare_url":"https://api.github.com/repos/DavidAndreev/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidAndreev/indico/merges","archive_url":"https://api.github.com/repos/DavidAndreev/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidAndreev/indico/downloads","issues_url":"https://api.github.com/repos/DavidAndreev/indico/issues{/number}","pulls_url":"https://api.github.com/repos/DavidAndreev/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidAndreev/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidAndreev/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidAndreev/indico/labels{/name}","releases_url":"https://api.github.com/repos/DavidAndreev/indico/releases{/id}","deployments_url":"https://api.github.com/repos/DavidAndreev/indico/deployments","created_at":"2016-09-01T11:34:44Z","updated_at":"2016-09-01T11:34:50Z","pushed_at":"2016-09-12T09:45:27Z","git_url":"git://github.com/DavidAndreev/indico.git","ssh_url":"git@github.com:DavidAndreev/indico.git","clone_url":"https://github.com/DavidAndreev/indico.git","svn_url":"https://github.com/DavidAndreev/indico","homepage":"http://indico-software.org","size":189317,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"indico:master","ref":"master","sha":"0b95332fcdac1ac614942629639fcd962fa285b9","user":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"repo":{"id":2113067,"name":"indico","full_name":"indico/indico","owner":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indico/indico","description":"The Indico Project","fork":false,"url":"https://api.github.com/repos/indico/indico","forks_url":"https://api.github.com/repos/indico/indico/forks","keys_url":"https://api.github.com/repos/indico/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indico/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indico/indico/teams","hooks_url":"https://api.github.com/repos/indico/indico/hooks","issue_events_url":"https://api.github.com/repos/indico/indico/issues/events{/number}","events_url":"https://api.github.com/repos/indico/indico/events","assignees_url":"https://api.github.com/repos/indico/indico/assignees{/user}","branches_url":"https://api.github.com/repos/indico/indico/branches{/branch}","tags_url":"https://api.github.com/repos/indico/indico/tags","blobs_url":"https://api.github.com/repos/indico/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indico/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indico/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/indico/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indico/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/indico/indico/languages","stargazers_url":"https://api.github.com/repos/indico/indico/stargazers","contributors_url":"https://api.github.com/repos/indico/indico/contributors","subscribers_url":"https://api.github.com/repos/indico/indico/subscribers","subscription_url":"https://api.github.com/repos/indico/indico/subscription","commits_url":"https://api.github.com/repos/indico/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/indico/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/indico/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/indico/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/indico/indico/contents/{+path}","compare_url":"https://api.github.com/repos/indico/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indico/indico/merges","archive_url":"https://api.github.com/repos/indico/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indico/indico/downloads","issues_url":"https://api.github.com/repos/indico/indico/issues{/number}","pulls_url":"https://api.github.com/repos/indico/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/indico/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/indico/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indico/indico/labels{/name}","releases_url":"https://api.github.com/repos/indico/indico/releases{/id}","deployments_url":"https://api.github.com/repos/indico/indico/deployments","created_at":"2011-07-27T13:56:30Z","updated_at":"2016-09-09T15:50:20Z","pushed_at":"2016-09-12T09:47:15Z","git_url":"git://github.com/indico/indico.git","ssh_url":"git@github.com:indico/indico.git","clone_url":"https://github.com/indico/indico.git","svn_url":"https://github.com/indico/indico","homepage":"http://indico-software.org","size":202611,"stargazers_count":164,"watchers_count":164,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":615,"forks":81,"open_issues":615,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/2598"},"html":{"href":"https://github.com/indico/indico/pull/2598"},"issue":{"href":"https://api.github.com/repos/indico/indico/issues/2598"},"comments":{"href":"https://api.github.com/repos/indico/indico/issues/2598/comments"},"review_comments":{"href":"https://api.github.com/repos/indico/indico/pulls/2598/comments"},"review_comment":{"href":"https://api.github.com/repos/indico/indico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indico/indico/pulls/2598/commits"},"statuses":{"href":"https://api.github.com/repos/indico/indico/statuses/71c35f9fc0655953edb7dd0e7b531d53b82d31e8"}}}}
{"actor":{"display_login":"ThiefMaster"}}