{"action":"created","comment":{"url":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/comments/54279208","id":54279208,"diff_hunk":"@@ -1,8 +1,8 @@\n ARCH=i686-elf\n TEST_CC=clang\n-GCOV=gcov\n+COV= llvm-cov\n GRUB_MKRESCUE=grub-mkrescue\n-CC=compiler/$(ARCH)/bin/$(ARCH)-gcc\n+CC=env $(ARCH)-gcc","path":"Makefile","position":7,"original_position":7,"commit_id":"40782be45578395b56e0c67856095c8e98f87725","original_commit_id":"40782be45578395b56e0c67856095c8e98f87725","user":{"login":"iankronquist","id":5192353,"avatar_url":"https://avatars.githubusercontent.com/u/5192353?v=3","gravatar_id":"","url":"https://api.github.com/users/iankronquist","html_url":"https://github.com/iankronquist","followers_url":"https://api.github.com/users/iankronquist/followers","following_url":"https://api.github.com/users/iankronquist/following{/other_user}","gists_url":"https://api.github.com/users/iankronquist/gists{/gist_id}","starred_url":"https://api.github.com/users/iankronquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankronquist/subscriptions","organizations_url":"https://api.github.com/users/iankronquist/orgs","repos_url":"https://api.github.com/users/iankronquist/repos","events_url":"https://api.github.com/users/iankronquist/events{/privacy}","received_events_url":"https://api.github.com/users/iankronquist/received_events","type":"User","site_admin":false},"body":"If we make this:\r\n`CC=$(ARCH)-gcc`\r\nwill it still work?","created_at":"2016-02-26T18:11:36Z","updated_at":"2016-02-26T18:11:36Z","html_url":"https://github.com/iankronquist/kernel-of-truth/pull/39#discussion_r54279208","pull_request_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/comments/54279208"},"html":{"href":"https://github.com/iankronquist/kernel-of-truth/pull/39#discussion_r54279208"},"pull_request":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39","id":60714077,"html_url":"https://github.com/iankronquist/kernel-of-truth/pull/39","diff_url":"https://github.com/iankronquist/kernel-of-truth/pull/39.diff","patch_url":"https://github.com/iankronquist/kernel-of-truth/pull/39.patch","issue_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/issues/39","number":39,"state":"open","locked":false,"title":"Get code coverage results for kmem and physical_allocator","user":{"login":"awensaunders","id":3837160,"avatar_url":"https://avatars.githubusercontent.com/u/3837160?v=3","gravatar_id":"","url":"https://api.github.com/users/awensaunders","html_url":"https://github.com/awensaunders","followers_url":"https://api.github.com/users/awensaunders/followers","following_url":"https://api.github.com/users/awensaunders/following{/other_user}","gists_url":"https://api.github.com/users/awensaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/awensaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awensaunders/subscriptions","organizations_url":"https://api.github.com/users/awensaunders/orgs","repos_url":"https://api.github.com/users/awensaunders/repos","events_url":"https://api.github.com/users/awensaunders/events{/privacy}","received_events_url":"https://api.github.com/users/awensaunders/received_events","type":"User","site_admin":false},"body":"Solves #14? \r\nI switched from using gcov to llvm-cov for code coverage tests. When make run-tests is invoked, it leaves kmem.cov and physical_allocator.cov in the project directory for analysis. ","created_at":"2016-02-25T17:16:21Z","updated_at":"2016-02-26T18:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f59745a56e30b267fa634da807101825903054b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39/commits","review_comments_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39/comments","review_comment_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/issues/39/comments","statuses_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/statuses/40782be45578395b56e0c67856095c8e98f87725","head":{"label":"awensaunders:coverage","ref":"coverage","sha":"40782be45578395b56e0c67856095c8e98f87725","user":{"login":"awensaunders","id":3837160,"avatar_url":"https://avatars.githubusercontent.com/u/3837160?v=3","gravatar_id":"","url":"https://api.github.com/users/awensaunders","html_url":"https://github.com/awensaunders","followers_url":"https://api.github.com/users/awensaunders/followers","following_url":"https://api.github.com/users/awensaunders/following{/other_user}","gists_url":"https://api.github.com/users/awensaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/awensaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awensaunders/subscriptions","organizations_url":"https://api.github.com/users/awensaunders/orgs","repos_url":"https://api.github.com/users/awensaunders/repos","events_url":"https://api.github.com/users/awensaunders/events{/privacy}","received_events_url":"https://api.github.com/users/awensaunders/received_events","type":"User","site_admin":false},"repo":{"id":52236341,"name":"kernel-of-truth","full_name":"awensaunders/kernel-of-truth","owner":{"login":"awensaunders","id":3837160,"avatar_url":"https://avatars.githubusercontent.com/u/3837160?v=3","gravatar_id":"","url":"https://api.github.com/users/awensaunders","html_url":"https://github.com/awensaunders","followers_url":"https://api.github.com/users/awensaunders/followers","following_url":"https://api.github.com/users/awensaunders/following{/other_user}","gists_url":"https://api.github.com/users/awensaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/awensaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awensaunders/subscriptions","organizations_url":"https://api.github.com/users/awensaunders/orgs","repos_url":"https://api.github.com/users/awensaunders/repos","events_url":"https://api.github.com/users/awensaunders/events{/privacy}","received_events_url":"https://api.github.com/users/awensaunders/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awensaunders/kernel-of-truth","description":"A simple kernel written in C","fork":true,"url":"https://api.github.com/repos/awensaunders/kernel-of-truth","forks_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/forks","keys_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/teams","hooks_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/hooks","issue_events_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/issues/events{/number}","events_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/events","assignees_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/assignees{/user}","branches_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/branches{/branch}","tags_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/tags","blobs_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/git/refs{/sha}","trees_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/statuses/{sha}","languages_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/languages","stargazers_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/stargazers","contributors_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/contributors","subscribers_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/subscribers","subscription_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/subscription","commits_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/commits{/sha}","git_commits_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/git/commits{/sha}","comments_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/comments{/number}","issue_comment_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/issues/comments{/number}","contents_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/contents/{+path}","compare_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/merges","archive_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/downloads","issues_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/issues{/number}","pulls_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/pulls{/number}","milestones_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/milestones{/number}","notifications_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/labels{/name}","releases_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/releases{/id}","deployments_url":"https://api.github.com/repos/awensaunders/kernel-of-truth/deployments","created_at":"2016-02-22T00:39:31Z","updated_at":"2016-02-22T00:39:32Z","pushed_at":"2016-02-25T17:01:02Z","git_url":"git://github.com/awensaunders/kernel-of-truth.git","ssh_url":"git@github.com:awensaunders/kernel-of-truth.git","clone_url":"https://github.com/awensaunders/kernel-of-truth.git","svn_url":"https://github.com/awensaunders/kernel-of-truth","homepage":null,"size":292,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iankronquist:master","ref":"master","sha":"e1ad060d4d054496df5111cbc030569d7999a69b","user":{"login":"iankronquist","id":5192353,"avatar_url":"https://avatars.githubusercontent.com/u/5192353?v=3","gravatar_id":"","url":"https://api.github.com/users/iankronquist","html_url":"https://github.com/iankronquist","followers_url":"https://api.github.com/users/iankronquist/followers","following_url":"https://api.github.com/users/iankronquist/following{/other_user}","gists_url":"https://api.github.com/users/iankronquist/gists{/gist_id}","starred_url":"https://api.github.com/users/iankronquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankronquist/subscriptions","organizations_url":"https://api.github.com/users/iankronquist/orgs","repos_url":"https://api.github.com/users/iankronquist/repos","events_url":"https://api.github.com/users/iankronquist/events{/privacy}","received_events_url":"https://api.github.com/users/iankronquist/received_events","type":"User","site_admin":false},"repo":{"id":16471054,"name":"kernel-of-truth","full_name":"iankronquist/kernel-of-truth","owner":{"login":"iankronquist","id":5192353,"avatar_url":"https://avatars.githubusercontent.com/u/5192353?v=3","gravatar_id":"","url":"https://api.github.com/users/iankronquist","html_url":"https://github.com/iankronquist","followers_url":"https://api.github.com/users/iankronquist/followers","following_url":"https://api.github.com/users/iankronquist/following{/other_user}","gists_url":"https://api.github.com/users/iankronquist/gists{/gist_id}","starred_url":"https://api.github.com/users/iankronquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankronquist/subscriptions","organizations_url":"https://api.github.com/users/iankronquist/orgs","repos_url":"https://api.github.com/users/iankronquist/repos","events_url":"https://api.github.com/users/iankronquist/events{/privacy}","received_events_url":"https://api.github.com/users/iankronquist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iankronquist/kernel-of-truth","description":"A simple kernel written in C","fork":false,"url":"https://api.github.com/repos/iankronquist/kernel-of-truth","forks_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/forks","keys_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/teams","hooks_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/hooks","issue_events_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/issues/events{/number}","events_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/events","assignees_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/assignees{/user}","branches_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/branches{/branch}","tags_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/tags","blobs_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/git/refs{/sha}","trees_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/statuses/{sha}","languages_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/languages","stargazers_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/stargazers","contributors_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/contributors","subscribers_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/subscribers","subscription_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/subscription","commits_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/commits{/sha}","git_commits_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/git/commits{/sha}","comments_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/comments{/number}","issue_comment_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/issues/comments{/number}","contents_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/contents/{+path}","compare_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/merges","archive_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/downloads","issues_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/issues{/number}","pulls_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls{/number}","milestones_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/milestones{/number}","notifications_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/labels{/name}","releases_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/releases{/id}","deployments_url":"https://api.github.com/repos/iankronquist/kernel-of-truth/deployments","created_at":"2014-02-03T05:53:54Z","updated_at":"2016-01-13T04:28:18Z","pushed_at":"2016-02-25T17:16:21Z","git_url":"git://github.com/iankronquist/kernel-of-truth.git","ssh_url":"git@github.com:iankronquist/kernel-of-truth.git","clone_url":"https://github.com/iankronquist/kernel-of-truth.git","svn_url":"https://github.com/iankronquist/kernel-of-truth","homepage":null,"size":303,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39"},"html":{"href":"https://github.com/iankronquist/kernel-of-truth/pull/39"},"issue":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/issues/39"},"comments":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/iankronquist/kernel-of-truth/statuses/40782be45578395b56e0c67856095c8e98f87725"}}}}