{"action":"created","issue":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/817","repository_url":"https://api.github.com/repos/Unvanquished/Unvanquished","labels_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/817/labels{/name}","comments_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/817/comments","events_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/817/events","html_url":"https://github.com/Unvanquished/Unvanquished/issues/817","id":113161544,"number":817,"title":"Hardcoded references to Unvanquished in the engine","user":{"login":"mbasaglia","id":2465791,"avatar_url":"https://avatars.githubusercontent.com/u/2465791?v=3","gravatar_id":"","url":"https://api.github.com/users/mbasaglia","html_url":"https://github.com/mbasaglia","followers_url":"https://api.github.com/users/mbasaglia/followers","following_url":"https://api.github.com/users/mbasaglia/following{/other_user}","gists_url":"https://api.github.com/users/mbasaglia/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasaglia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasaglia/subscriptions","organizations_url":"https://api.github.com/users/mbasaglia/orgs","repos_url":"https://api.github.com/users/mbasaglia/repos","events_url":"https://api.github.com/users/mbasaglia/events{/privacy}","received_events_url":"https://api.github.com/users/mbasaglia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2015-10-24T13:58:26Z","updated_at":"2016-06-24T10:05:38Z","closed_at":null,"body":"There are some string literals that mention Unvanquished in the Daemon sources, maybe they should be moved or changed since the engine is supposed to be usable by other games.\r\n\r\nSome of these strings can moved in files generated by CMake, other maybe can be changed to mention Daemon.\r\n\r\nHere is the list:\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/qcommon/q_shared.h#L49-L52\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/client/cl_irc.cpp#L2190\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/qcommon/common.cpp#L1689\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/qcommon/files.cpp#L32\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/qcommon/qcommon.h#L286-L299\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/server/sv_init.cpp#L646\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/server/sv_init.cpp#L695\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/src/engine/server/sv_main.cpp#L341-L342\r\n* https://github.com/Unvanquished/Unvanquished/blob/master/daemon/CMakeLists.txt#L349"},"comment":{"url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/comments/228307756","html_url":"https://github.com/Unvanquished/Unvanquished/issues/817#issuecomment-228307756","issue_url":"https://api.github.com/repos/Unvanquished/Unvanquished/issues/817","id":228307756,"user":{"login":"Viech","id":3780206,"avatar_url":"https://avatars.githubusercontent.com/u/3780206?v=3","gravatar_id":"","url":"https://api.github.com/users/Viech","html_url":"https://github.com/Viech","followers_url":"https://api.github.com/users/Viech/followers","following_url":"https://api.github.com/users/Viech/following{/other_user}","gists_url":"https://api.github.com/users/Viech/gists{/gist_id}","starred_url":"https://api.github.com/users/Viech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Viech/subscriptions","organizations_url":"https://api.github.com/users/Viech/orgs","repos_url":"https://api.github.com/users/Viech/repos","events_url":"https://api.github.com/users/Viech/events{/privacy}","received_events_url":"https://api.github.com/users/Viech/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T10:05:38Z","updated_at":"2016-06-24T10:05:38Z","body":"I think we should have one binary for both games ideally, but it should bind to the game on startup and present itself as just one of the games throughout execution. Everything else would be just too much coordination hassle. The upside of sharing an engine binary is that we make sure that it's flexible enough to support a third game and we might even do fancy things like distribute the engine like a library or even coordinate two of our bigger releases and release both games in one package (additionally) to get players hooked up on both games."}}
{"actor":{"display_login":"Viech"}}