{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/22","id":78477429,"html_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy/pull/22","diff_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy/pull/22.diff","patch_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy/pull/22.patch","issue_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/22","number":22,"state":"closed","locked":false,"title":"Compatibility fix for older Scrapy versions","user":{"login":"vshlapakov","id":448111,"avatar_url":"https://avatars.githubusercontent.com/u/448111?v=3","gravatar_id":"","url":"https://api.github.com/users/vshlapakov","html_url":"https://github.com/vshlapakov","followers_url":"https://api.github.com/users/vshlapakov/followers","following_url":"https://api.github.com/users/vshlapakov/following{/other_user}","gists_url":"https://api.github.com/users/vshlapakov/gists{/gist_id}","starred_url":"https://api.github.com/users/vshlapakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vshlapakov/subscriptions","organizations_url":"https://api.github.com/users/vshlapakov/orgs","repos_url":"https://api.github.com/users/vshlapakov/repos","events_url":"https://api.github.com/users/vshlapakov/events{/privacy}","received_events_url":"https://api.github.com/users/vshlapakov/received_events","type":"User","site_admin":false},"body":"This is a bugfix for PR #21 fixing a compatibility issue for older Scrapy versions which don't have `scrapy.settings.BaseSettings` class and `scrapy.settings.Settings` class instead uploading default settings on init.\r\n\r\nReview, please.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/scrapinghub/scrapinghub-entrypoint-scrapy/22)\n<!-- Reviewable:end -->\n","created_at":"2016-07-22T13:32:12Z","updated_at":"2016-07-22T13:36:45Z","closed_at":"2016-07-22T13:36:45Z","merged_at":"2016-07-22T13:36:45Z","merge_commit_sha":"4d2c3cadb99466f42e8c10025a492cecbb30800b","assignee":{"login":"chekunkov","id":744331,"avatar_url":"https://avatars.githubusercontent.com/u/744331?v=3","gravatar_id":"","url":"https://api.github.com/users/chekunkov","html_url":"https://github.com/chekunkov","followers_url":"https://api.github.com/users/chekunkov/followers","following_url":"https://api.github.com/users/chekunkov/following{/other_user}","gists_url":"https://api.github.com/users/chekunkov/gists{/gist_id}","starred_url":"https://api.github.com/users/chekunkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chekunkov/subscriptions","organizations_url":"https://api.github.com/users/chekunkov/orgs","repos_url":"https://api.github.com/users/chekunkov/repos","events_url":"https://api.github.com/users/chekunkov/events{/privacy}","received_events_url":"https://api.github.com/users/chekunkov/received_events","type":"User","site_admin":false},"assignees":[{"login":"chekunkov","id":744331,"avatar_url":"https://avatars.githubusercontent.com/u/744331?v=3","gravatar_id":"","url":"https://api.github.com/users/chekunkov","html_url":"https://github.com/chekunkov","followers_url":"https://api.github.com/users/chekunkov/followers","following_url":"https://api.github.com/users/chekunkov/following{/other_user}","gists_url":"https://api.github.com/users/chekunkov/gists{/gist_id}","starred_url":"https://api.github.com/users/chekunkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chekunkov/subscriptions","organizations_url":"https://api.github.com/users/chekunkov/orgs","repos_url":"https://api.github.com/users/chekunkov/repos","events_url":"https://api.github.com/users/chekunkov/events{/privacy}","received_events_url":"https://api.github.com/users/chekunkov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/22/commits","review_comments_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/22/comments","review_comment_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/22/comments","statuses_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/statuses/cf29386aabdb3c1c6ddc59ec2aa54d94fc004f7b","head":{"label":"scrapinghub:sc670-compatibility-fix","ref":"sc670-compatibility-fix","sha":"cf29386aabdb3c1c6ddc59ec2aa54d94fc004f7b","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":22356590,"name":"scrapinghub-entrypoint-scrapy","full_name":"scrapinghub/scrapinghub-entrypoint-scrapy","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy","description":"Scrapy entrypoint for Scrapinghub job runner","fork":false,"url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy","forks_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/forks","keys_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/teams","hooks_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/events","assignees_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/tags","blobs_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/subscription","commits_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/merges","archive_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/downloads","issues_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/deployments","created_at":"2014-07-28T20:22:14Z","updated_at":"2016-07-11T13:01:37Z","pushed_at":"2016-07-22T13:36:45Z","git_url":"git://github.com/scrapinghub/scrapinghub-entrypoint-scrapy.git","ssh_url":"git@github.com:scrapinghub/scrapinghub-entrypoint-scrapy.git","clone_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy.git","svn_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy","homepage":null,"size":111,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"scrapinghub:master","ref":"master","sha":"e7526a2d648012f97bcaf01da337749e14b39956","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":22356590,"name":"scrapinghub-entrypoint-scrapy","full_name":"scrapinghub/scrapinghub-entrypoint-scrapy","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy","description":"Scrapy entrypoint for Scrapinghub job runner","fork":false,"url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy","forks_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/forks","keys_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/teams","hooks_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/events","assignees_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/tags","blobs_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/subscription","commits_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/merges","archive_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/downloads","issues_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/deployments","created_at":"2014-07-28T20:22:14Z","updated_at":"2016-07-11T13:01:37Z","pushed_at":"2016-07-22T13:36:45Z","git_url":"git://github.com/scrapinghub/scrapinghub-entrypoint-scrapy.git","ssh_url":"git@github.com:scrapinghub/scrapinghub-entrypoint-scrapy.git","clone_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy.git","svn_url":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy","homepage":null,"size":111,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/22"},"html":{"href":"https://github.com/scrapinghub/scrapinghub-entrypoint-scrapy/pull/22"},"issue":{"href":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/22"},"comments":{"href":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/scrapinghub/scrapinghub-entrypoint-scrapy/statuses/cf29386aabdb3c1c6ddc59ec2aa54d94fc004f7b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chekunkov","id":744331,"avatar_url":"https://avatars.githubusercontent.com/u/744331?v=3","gravatar_id":"","url":"https://api.github.com/users/chekunkov","html_url":"https://github.com/chekunkov","followers_url":"https://api.github.com/users/chekunkov/followers","following_url":"https://api.github.com/users/chekunkov/following{/other_user}","gists_url":"https://api.github.com/users/chekunkov/gists{/gist_id}","starred_url":"https://api.github.com/users/chekunkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chekunkov/subscriptions","organizations_url":"https://api.github.com/users/chekunkov/orgs","repos_url":"https://api.github.com/users/chekunkov/repos","events_url":"https://api.github.com/users/chekunkov/events{/privacy}","received_events_url":"https://api.github.com/users/chekunkov/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":31,"deletions":22,"changed_files":2}}
{"actor":{"display_login":"chekunkov"}}