{"action":"created","comment":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/55026264","id":55026264,"diff_hunk":"@@ -194,12 +194,12 @@ private void closeCache(final String alias, final Ehcache<?, ?> ehcache) {\n \n   /**\n    * Perform cache closure actions specific to a cache manager implementation.\n-   * This method is called <i>after</i> the {@code Ehcache} instance is closed.\n+   * This method is called <i>after</i> the {@code EhcacheWithLoaderWriter} instance is closed.\n    *\n    * @param alias the cache alias\n-   * @param ehcache the {@code Ehcache} instance for the cache to close\n+   * @param ehcache the {@code EhcacheWithLoaderWriter} instance for the cache to close\n    */\n-  protected void closeEhcache(final String alias, final Ehcache<?, ?> ehcache) {\n+  protected void closeEhcache(final String alias, final Cache<?, ?> ehcache) {","path":"core/src/main/java/org/ehcache/core/EhcacheManager.java","position":30,"original_position":30,"commit_id":"3ec5875321bbe18247e8270b016b41b1aa9ace99","original_commit_id":"3ec5875321bbe18247e8270b016b41b1aa9ace99","user":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"body":"I would use `InternalCache` here","created_at":"2016-03-04T12:57:00Z","updated_at":"2016-03-04T12:57:00Z","html_url":"https://github.com/ehcache/ehcache3/pull/804#discussion_r55026264","pull_request_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/804","_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/55026264"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/804#discussion_r55026264"},"pull_request":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/804"}}},"pull_request":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/804","id":61407509,"html_url":"https://github.com/ehcache/ehcache3/pull/804","diff_url":"https://github.com/ehcache/ehcache3/pull/804.diff","patch_url":"https://github.com/ehcache/ehcache3/pull/804.patch","issue_url":"https://api.github.com/repos/ehcache/ehcache3/issues/804","number":804,"state":"open","locked":false,"title":"Issue 777","user":{"login":"AbfrmBlr","id":4498935,"avatar_url":"https://avatars.githubusercontent.com/u/4498935?v=3","gravatar_id":"","url":"https://api.github.com/users/AbfrmBlr","html_url":"https://github.com/AbfrmBlr","followers_url":"https://api.github.com/users/AbfrmBlr/followers","following_url":"https://api.github.com/users/AbfrmBlr/following{/other_user}","gists_url":"https://api.github.com/users/AbfrmBlr/gists{/gist_id}","starred_url":"https://api.github.com/users/AbfrmBlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbfrmBlr/subscriptions","organizations_url":"https://api.github.com/users/AbfrmBlr/orgs","repos_url":"https://api.github.com/users/AbfrmBlr/repos","events_url":"https://api.github.com/users/AbfrmBlr/events{/privacy}","received_events_url":"https://api.github.com/users/AbfrmBlr/received_events","type":"User","site_admin":false},"body":"WIth XA tests failing.\r\nAdded two interfaces JSRIntegrableCache and Hookable.\r\nStore apis return StoreOpStatus , which does not look good.","created_at":"2016-03-02T14:27:54Z","updated_at":"2016-03-04T12:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a54b76a62e683cbcc49659f73dc1973907de6f70","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/804/commits","review_comments_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/804/comments","review_comment_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/issues/804/comments","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/3ec5875321bbe18247e8270b016b41b1aa9ace99","head":{"label":"AbfrmBlr:issue-777","ref":"issue-777","sha":"3ec5875321bbe18247e8270b016b41b1aa9ace99","user":{"login":"AbfrmBlr","id":4498935,"avatar_url":"https://avatars.githubusercontent.com/u/4498935?v=3","gravatar_id":"","url":"https://api.github.com/users/AbfrmBlr","html_url":"https://github.com/AbfrmBlr","followers_url":"https://api.github.com/users/AbfrmBlr/followers","following_url":"https://api.github.com/users/AbfrmBlr/following{/other_user}","gists_url":"https://api.github.com/users/AbfrmBlr/gists{/gist_id}","starred_url":"https://api.github.com/users/AbfrmBlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbfrmBlr/subscriptions","organizations_url":"https://api.github.com/users/AbfrmBlr/orgs","repos_url":"https://api.github.com/users/AbfrmBlr/repos","events_url":"https://api.github.com/users/AbfrmBlr/events{/privacy}","received_events_url":"https://api.github.com/users/AbfrmBlr/received_events","type":"User","site_admin":false},"repo":{"id":28589092,"name":"ehcache3","full_name":"AbfrmBlr/ehcache3","owner":{"login":"AbfrmBlr","id":4498935,"avatar_url":"https://avatars.githubusercontent.com/u/4498935?v=3","gravatar_id":"","url":"https://api.github.com/users/AbfrmBlr","html_url":"https://github.com/AbfrmBlr","followers_url":"https://api.github.com/users/AbfrmBlr/followers","following_url":"https://api.github.com/users/AbfrmBlr/following{/other_user}","gists_url":"https://api.github.com/users/AbfrmBlr/gists{/gist_id}","starred_url":"https://api.github.com/users/AbfrmBlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbfrmBlr/subscriptions","organizations_url":"https://api.github.com/users/AbfrmBlr/orgs","repos_url":"https://api.github.com/users/AbfrmBlr/repos","events_url":"https://api.github.com/users/AbfrmBlr/events{/privacy}","received_events_url":"https://api.github.com/users/AbfrmBlr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AbfrmBlr/ehcache3","description":"Ehcache 3.x line ","fork":true,"url":"https://api.github.com/repos/AbfrmBlr/ehcache3","forks_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/forks","keys_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/teams","hooks_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/events","assignees_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/tags","blobs_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/languages","stargazers_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/subscription","commits_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/merges","archive_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/downloads","issues_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/AbfrmBlr/ehcache3/deployments","created_at":"2014-12-29T10:47:44Z","updated_at":"2016-01-19T07:22:30Z","pushed_at":"2016-03-04T12:06:36Z","git_url":"git://github.com/AbfrmBlr/ehcache3.git","ssh_url":"git@github.com:AbfrmBlr/ehcache3.git","clone_url":"https://github.com/AbfrmBlr/ehcache3.git","svn_url":"https://github.com/AbfrmBlr/ehcache3","homepage":"ehcache.org","size":6707,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ehcache:master","ref":"master","sha":"388b9a8b10e1a86375fe6594794a6017f0bb3cf8","user":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"repo":{"id":17224514,"name":"ehcache3","full_name":"ehcache/ehcache3","owner":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ehcache/ehcache3","description":"Ehcache 3.x line ","fork":false,"url":"https://api.github.com/repos/ehcache/ehcache3","forks_url":"https://api.github.com/repos/ehcache/ehcache3/forks","keys_url":"https://api.github.com/repos/ehcache/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehcache/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehcache/ehcache3/teams","hooks_url":"https://api.github.com/repos/ehcache/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/ehcache/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/ehcache/ehcache3/events","assignees_url":"https://api.github.com/repos/ehcache/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/ehcache/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/ehcache/ehcache3/tags","blobs_url":"https://api.github.com/repos/ehcache/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehcache/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehcache/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehcache/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/ehcache/ehcache3/languages","stargazers_url":"https://api.github.com/repos/ehcache/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/ehcache/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/ehcache/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/ehcache/ehcache3/subscription","commits_url":"https://api.github.com/repos/ehcache/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehcache/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehcache/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehcache/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/ehcache/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehcache/ehcache3/merges","archive_url":"https://api.github.com/repos/ehcache/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehcache/ehcache3/downloads","issues_url":"https://api.github.com/repos/ehcache/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/ehcache/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/ehcache/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/ehcache/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehcache/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/ehcache/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/ehcache/ehcache3/deployments","created_at":"2014-02-26T20:39:16Z","updated_at":"2016-03-04T08:53:51Z","pushed_at":"2016-03-04T12:06:37Z","git_url":"git://github.com/ehcache/ehcache3.git","ssh_url":"git@github.com:ehcache/ehcache3.git","clone_url":"https://github.com/ehcache/ehcache3.git","svn_url":"https://github.com/ehcache/ehcache3","homepage":"http://www.ehcache.org","size":8790,"stargazers_count":303,"watchers_count":303,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":57,"forks":167,"open_issues":57,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/804"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/804"},"issue":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/804"},"comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/804/comments"},"review_comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/804/comments"},"review_comment":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/804/commits"},"statuses":{"href":"https://api.github.com/repos/ehcache/ehcache3/statuses/3ec5875321bbe18247e8270b016b41b1aa9ace99"}}}}