{"action":"created","issue":{"url":"https://api.github.com/repos/atk4/data/issues/144","repository_url":"https://api.github.com/repos/atk4/data","labels_url":"https://api.github.com/repos/atk4/data/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/atk4/data/issues/144/comments","events_url":"https://api.github.com/repos/atk4/data/issues/144/events","html_url":"https://github.com/atk4/data/pull/144","id":175258603,"number":144,"title":"Implement Strict Types","user":{"login":"romaninsh","id":453929,"avatar_url":"https://avatars.githubusercontent.com/u/453929?v=3","gravatar_id":"","url":"https://api.github.com/users/romaninsh","html_url":"https://github.com/romaninsh","followers_url":"https://api.github.com/users/romaninsh/followers","following_url":"https://api.github.com/users/romaninsh/following{/other_user}","gists_url":"https://api.github.com/users/romaninsh/gists{/gist_id}","starred_url":"https://api.github.com/users/romaninsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romaninsh/subscriptions","organizations_url":"https://api.github.com/users/romaninsh/orgs","repos_url":"https://api.github.com/users/romaninsh/repos","events_url":"https://api.github.com/users/romaninsh/events{/privacy}","received_events_url":"https://api.github.com/users/romaninsh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atk4/data/labels/in%20review","name":"in review","color":"e6e6e6"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/atk4/data/milestones/7","html_url":"https://github.com/atk4/data/milestones/1.1.0","labels_url":"https://api.github.com/repos/atk4/data/milestones/7/labels","id":1918087,"number":7,"title":"1.1.0","description":"This release is to standardise on field types, improve support for Validators and Normalizers. \r\n\r\nCompared to 1.0 branch there will be minor changes that are not backwards-compatible and those will be listed in release notes.","creator":{"login":"romaninsh","id":453929,"avatar_url":"https://avatars.githubusercontent.com/u/453929?v=3","gravatar_id":"","url":"https://api.github.com/users/romaninsh","html_url":"https://github.com/romaninsh","followers_url":"https://api.github.com/users/romaninsh/followers","following_url":"https://api.github.com/users/romaninsh/following{/other_user}","gists_url":"https://api.github.com/users/romaninsh/gists{/gist_id}","starred_url":"https://api.github.com/users/romaninsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romaninsh/subscriptions","organizations_url":"https://api.github.com/users/romaninsh/orgs","repos_url":"https://api.github.com/users/romaninsh/repos","events_url":"https://api.github.com/users/romaninsh/events{/privacy}","received_events_url":"https://api.github.com/users/romaninsh/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":9,"state":"open","created_at":"2016-08-02T12:41:39Z","updated_at":"2016-09-06T16:10:46Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-09-06T14:16:07Z","updated_at":"2016-09-06T16:11:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atk4/data/pulls/144","html_url":"https://github.com/atk4/data/pull/144","diff_url":"https://github.com/atk4/data/pull/144.diff","patch_url":"https://github.com/atk4/data/pull/144.patch"},"body":"Previously when you execute `$m['date'] = time()` the value would be stored as integer until the save. Save would then convert it and subsequential load would now store field as DateTime.\r\n\r\nThis pattern creates uncertainty. Will your \"date\" field be int or DateTime? how can you rely on that?\r\n\r\nThis PR introduces strict_types. Now when you set `$m['date'] = time()` it will be converted into DateTime right away. No more ambiguity. \r\n\r\nIt also makes it simpler for persisting data, because we no longer need to look into various cases.\r\n\r\nA full documentation included!\r\n\r\nTODO (before this can be accepted):\r\n\r\n - [ ] no tests or implementation for \"load normalization\"\r\n - [ ] See #131 for some problems with Currency and Date formats.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/atk4/data/issues/comments/245002849","html_url":"https://github.com/atk4/data/pull/144#issuecomment-245002849","issue_url":"https://api.github.com/repos/atk4/data/issues/144","id":245002849,"user":{"login":"DarkSide666","id":1969119,"avatar_url":"https://avatars.githubusercontent.com/u/1969119?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkSide666","html_url":"https://github.com/DarkSide666","followers_url":"https://api.github.com/users/DarkSide666/followers","following_url":"https://api.github.com/users/DarkSide666/following{/other_user}","gists_url":"https://api.github.com/users/DarkSide666/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkSide666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkSide666/subscriptions","organizations_url":"https://api.github.com/users/DarkSide666/orgs","repos_url":"https://api.github.com/users/DarkSide666/repos","events_url":"https://api.github.com/users/DarkSide666/events{/privacy}","received_events_url":"https://api.github.com/users/DarkSide666/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T16:11:41Z","updated_at":"2016-09-06T16:11:41Z","body":"review done, bunch of fixes commited, but there are still few questions."}}
{"actor":{"display_login":"DarkSide666"}}