{"action":"created","comment":{"url":"https://api.github.com/repos/18F/calc/pulls/comments/89144481","pull_request_review_id":9693074,"id":89144481,"diff_hunk":"@@ -127,11 +161,9 @@ gulp.task('sass', () => gulp.src(path.join(dirs.src.style, paths.sass))\n );\n \n // Compile and lint JavaScript sources\n-gulp.task('js', ['lint', 'js:data-explorer',\n-  'js:data-capture', 'js:styleguide',\n-  'js:tests', 'js:legacy']);\n+gulp.task('js', ['lint'].concat(browserifiedBundles).concat(['js:legacy']));","path":"gulpfile.js","position":136,"original_position":136,"commit_id":"5e41a6f285591f96c5594a447d59082518d030aa","original_commit_id":"5e41a6f285591f96c5594a447d59082518d030aa","user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"body":"The two `concat`s here look weird but I wanted to preserve the ordering of the original dependency list just in case it mattered. If it doesn't actually matter, we can smoosh this down to just one `concat`.","created_at":"2016-11-22T15:48:47Z","updated_at":"2016-11-22T15:48:47Z","html_url":"https://github.com/18F/calc/pull/1054#discussion_r89144481","pull_request_url":"https://api.github.com/repos/18F/calc/pulls/1054","_links":{"self":{"href":"https://api.github.com/repos/18F/calc/pulls/comments/89144481"},"html":{"href":"https://github.com/18F/calc/pull/1054#discussion_r89144481"},"pull_request":{"href":"https://api.github.com/repos/18F/calc/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/18F/calc/pulls/1054","id":94838207,"html_url":"https://github.com/18F/calc/pull/1054","diff_url":"https://github.com/18F/calc/pull/1054.diff","patch_url":"https://github.com/18F/calc/pull/1054.patch","issue_url":"https://api.github.com/repos/18F/calc/issues/1054","number":1054,"state":"open","locked":false,"title":"Refactor gulpfile to make it easier to add new bundles","user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"body":"This reduces repetition in our gulpfile to make it easier to add new JS bundles for individual pages as we see fit, as per https://github.com/18F/calc/pull/1043#discussion_r89008703.\r\n\r\nI'm not super happy with the way I refactored this but I think maybe we can refactor it more in the future to make it better. Right now it has been refactored to be sort of grunt-ish, in that `bundles` is now a configuration object that we iterate through to define actual tasks and stuff.  Hrm.","created_at":"2016-11-22T15:38:52Z","updated_at":"2016-11-22T15:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a3ce2620dc0c086a13d8a20803d159f618e1fff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/calc/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/18F/calc/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/18F/calc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/calc/issues/1054/comments","statuses_url":"https://api.github.com/repos/18F/calc/statuses/5e41a6f285591f96c5594a447d59082518d030aa","head":{"label":"18F:gulpfile-refactor","ref":"gulpfile-refactor","sha":"5e41a6f285591f96c5594a447d59082518d030aa","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2016-11-05T23:07:54Z","pushed_at":"2016-11-22T15:38:52Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":21965,"stargazers_count":86,"watchers_count":86,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":132,"forks":43,"open_issues":132,"watchers":86,"default_branch":"develop"}},"base":{"label":"18F:develop","ref":"develop","sha":"9ca2517c3759338efe6218783701762a14a429cc","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2016-11-05T23:07:54Z","pushed_at":"2016-11-22T15:38:52Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":21965,"stargazers_count":86,"watchers_count":86,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":132,"forks":43,"open_issues":132,"watchers":86,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/calc/pulls/1054"},"html":{"href":"https://github.com/18F/calc/pull/1054"},"issue":{"href":"https://api.github.com/repos/18F/calc/issues/1054"},"comments":{"href":"https://api.github.com/repos/18F/calc/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/calc/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/calc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/calc/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/18F/calc/statuses/5e41a6f285591f96c5594a447d59082518d030aa"}}}}
{"actor":{"display_login":"toolness"}}