{"action":"created","issue":{"url":"https://api.github.com/repos/frappe/erpnext/issues/5756","repository_url":"https://api.github.com/repos/frappe/erpnext","labels_url":"https://api.github.com/repos/frappe/erpnext/issues/5756/labels{/name}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/5756/comments","events_url":"https://api.github.com/repos/frappe/erpnext/issues/5756/events","html_url":"https://github.com/frappe/erpnext/issues/5756","id":165529834,"number":5756,"title":"[v7] Deadlock in Item Variant Table","user":{"login":"adityaduggal","id":1057509,"avatar_url":"https://avatars.githubusercontent.com/u/1057509?v=3","gravatar_id":"","url":"https://api.github.com/users/adityaduggal","html_url":"https://github.com/adityaduggal","followers_url":"https://api.github.com/users/adityaduggal/followers","following_url":"https://api.github.com/users/adityaduggal/following{/other_user}","gists_url":"https://api.github.com/users/adityaduggal/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaduggal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaduggal/subscriptions","organizations_url":"https://api.github.com/users/adityaduggal/orgs","repos_url":"https://api.github.com/users/adityaduggal/repos","events_url":"https://api.github.com/users/adityaduggal/events{/privacy}","received_events_url":"https://api.github.com/users/adityaduggal/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"rmehta","id":140076,"avatar_url":"https://avatars.githubusercontent.com/u/140076?v=3","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmehta","id":140076,"avatar_url":"https://avatars.githubusercontent.com/u/140076?v=3","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/frappe/erpnext/milestones/26","html_url":"https://github.com/frappe/erpnext/milestones/ERPNext%207","labels_url":"https://api.github.com/repos/frappe/erpnext/milestones/26/labels","id":1455410,"number":26,"title":"ERPNext 7","description":"","creator":{"login":"rmehta","id":140076,"avatar_url":"https://avatars.githubusercontent.com/u/140076?v=3","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":96,"state":"open","created_at":"2015-12-11T04:56:46Z","updated_at":"2016-07-18T12:25:09Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-07-14T10:34:18Z","updated_at":"2016-07-19T06:29:39Z","closed_at":"2016-07-18T11:08:53Z","body":"Hi,\r\n\r\nJust was trying to add a new value in an existing attribute in v7 develop branch and found out the system just hangs and sometimes I get the error Another Transaction is blocking this and try after sometime\r\n\r\nI have tried to do this after stopping and starting the bench but to no avail. I think the way the code is running to check the existing item codes for the attributes is creating a deadlock into the system, I think the problem is with:\r\n\r\nhttps://github.com/frappe/erpnext/blob/develop/erpnext/stock/doctype/item_attribute/item_attribute.py#L25-L29\r\n\r\nWhich used to be like this below:\r\n\r\nhttps://github.com/frappe/erpnext/blob/master/erpnext/stock/doctype/item_attribute/item_attribute.py#L43-L57\r\n\r\n@rmehta: Could you please shed some light on this as this commit was made by you: https://github.com/frappe/erpnext/commit/aed79e993f51a7b2d4379359e516705115a55fd0"},"comment":{"url":"https://api.github.com/repos/frappe/erpnext/issues/comments/233543588","html_url":"https://github.com/frappe/erpnext/issues/5756#issuecomment-233543588","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/5756","id":233543588,"user":{"login":"adityaduggal","id":1057509,"avatar_url":"https://avatars.githubusercontent.com/u/1057509?v=3","gravatar_id":"","url":"https://api.github.com/users/adityaduggal","html_url":"https://github.com/adityaduggal","followers_url":"https://api.github.com/users/adityaduggal/followers","following_url":"https://api.github.com/users/adityaduggal/following{/other_user}","gists_url":"https://api.github.com/users/adityaduggal/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaduggal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaduggal/subscriptions","organizations_url":"https://api.github.com/users/adityaduggal/orgs","repos_url":"https://api.github.com/users/adityaduggal/repos","events_url":"https://api.github.com/users/adityaduggal/events{/privacy}","received_events_url":"https://api.github.com/users/adityaduggal/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T06:29:39Z","updated_at":"2016-07-19T06:29:39Z","body":"I fully agree that this validation should have been there and I guess that if there is some kind of issue in a user's DB then they would have to do it at backend if its in more than one attribute.\r\nBut again :+1:  for this validation. I must say the team does skip a lot of validations initially :stuck_out_tongue_winking_eye: "}}
{"actor":{"display_login":"adityaduggal"}}