{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/comments/55260110","id":55260110,"diff_hunk":"@@ -295,18 +273,14 @@ public bool Remove(KeyValuePair<string, dynamic> item)\n \t\t/// Gets an <see cref=\"T:System.Collections.Generic.ICollection`1\"/> containing the values in the <see cref=\"DynamicResponse\"/>.\r\n \t\t/// </summary>\r\n \t\t/// <returns>An <see cref=\"T:System.Collections.Generic.ICollection`1\"/> containing the values in the <see cref=\"DynamicResponse\"/>.</returns>\r\n-\t\tpublic ICollection<dynamic> Values\r\n-\t\t{\r\n-\t\t\tget { return this.BackingDictionary.Values; }\r\n-\t\t}\r\n+\t\tpublic ICollection<dynamic> Values => this.BackingDictionary.Values;\r\n \r\n \t\tprivate static KeyValuePair<string, dynamic> GetDynamicKeyValuePair(KeyValuePair<string, dynamic> item)\r\n \t\t{\r\n-\t\t\tvar dynamicValueKeyValuePair =\r\n-\t\t\t\tnew KeyValuePair<string, dynamic>(item.Key, new ElasticsearchDynamicValue(item.Value));\r\n-\t\t\treturn dynamicValueKeyValuePair;\r\n+\t\t\treturn new KeyValuePair<string, dynamic>(item.Key, new ElasticsearchDynamicValue(item.Value));\r\n \t\t}\r\n \r\n+\t\t//TODO:For what purpose do you use this function?\r","path":"src/Elasticsearch.Net/Responses/DynamicResponse.cs","position":158,"original_position":158,"commit_id":"0efaf8442e27dee479541becfbd824c527922538","original_commit_id":"0efaf8442e27dee479541becfbd824c527922538","user":{"login":"Mpdreamz","id":245275,"avatar_url":"https://avatars.githubusercontent.com/u/245275?v=3","gravatar_id":"","url":"https://api.github.com/users/Mpdreamz","html_url":"https://github.com/Mpdreamz","followers_url":"https://api.github.com/users/Mpdreamz/followers","following_url":"https://api.github.com/users/Mpdreamz/following{/other_user}","gists_url":"https://api.github.com/users/Mpdreamz/gists{/gist_id}","starred_url":"https://api.github.com/users/Mpdreamz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mpdreamz/subscriptions","organizations_url":"https://api.github.com/users/Mpdreamz/orgs","repos_url":"https://api.github.com/users/Mpdreamz/repos","events_url":"https://api.github.com/users/Mpdreamz/events{/privacy}","received_events_url":"https://api.github.com/users/Mpdreamz/received_events","type":"User","site_admin":false},"body":"Our DynamicDictionary is a source copy of NancyFX's https://github.com/NancyFx/Nancy/wiki/Taking-a-look-at-the-DynamicDictionary, this method might have made sense at some point. ","created_at":"2016-03-07T19:45:37Z","updated_at":"2016-03-07T19:45:37Z","html_url":"https://github.com/elastic/elasticsearch-net/pull/1896#discussion_r55260110","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/comments/55260110"},"html":{"href":"https://github.com/elastic/elasticsearch-net/pull/1896#discussion_r55260110"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896","id":61968074,"html_url":"https://github.com/elastic/elasticsearch-net/pull/1896","diff_url":"https://github.com/elastic/elasticsearch-net/pull/1896.diff","patch_url":"https://github.com/elastic/elasticsearch-net/pull/1896.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch-net/issues/1896","number":1896,"state":"open","locked":false,"title":"Minor refactoring","user":{"login":"dubrovkinmaxim","id":897527,"avatar_url":"https://avatars.githubusercontent.com/u/897527?v=3","gravatar_id":"","url":"https://api.github.com/users/dubrovkinmaxim","html_url":"https://github.com/dubrovkinmaxim","followers_url":"https://api.github.com/users/dubrovkinmaxim/followers","following_url":"https://api.github.com/users/dubrovkinmaxim/following{/other_user}","gists_url":"https://api.github.com/users/dubrovkinmaxim/gists{/gist_id}","starred_url":"https://api.github.com/users/dubrovkinmaxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubrovkinmaxim/subscriptions","organizations_url":"https://api.github.com/users/dubrovkinmaxim/orgs","repos_url":"https://api.github.com/users/dubrovkinmaxim/repos","events_url":"https://api.github.com/users/dubrovkinmaxim/events{/privacy}","received_events_url":"https://api.github.com/users/dubrovkinmaxim/received_events","type":"User","site_admin":false},"body":"@Mpdreamz I applied code formatting rules from .editorconfig for all files in my PR. Sorry I forgot about it in [previous PR](https://github.com/elastic/elasticsearch-net/pull/1892)  =) \r\n\r\n\"We didn't use default arguments for our dependency chain on purpose, they don't version well if we want to introduce an additional dependency in 2.x's lifetime.\" Ok. I have reverted this change. ","created_at":"2016-03-07T19:36:44Z","updated_at":"2016-03-07T19:45:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16fab72644498048cb5ab91e8b8c3516eb2d5141","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch-net/issues/1896/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch-net/statuses/0efaf8442e27dee479541becfbd824c527922538","head":{"label":"dubrovkinmaxim:minor-refactoring","ref":"minor-refactoring","sha":"0efaf8442e27dee479541becfbd824c527922538","user":{"login":"dubrovkinmaxim","id":897527,"avatar_url":"https://avatars.githubusercontent.com/u/897527?v=3","gravatar_id":"","url":"https://api.github.com/users/dubrovkinmaxim","html_url":"https://github.com/dubrovkinmaxim","followers_url":"https://api.github.com/users/dubrovkinmaxim/followers","following_url":"https://api.github.com/users/dubrovkinmaxim/following{/other_user}","gists_url":"https://api.github.com/users/dubrovkinmaxim/gists{/gist_id}","starred_url":"https://api.github.com/users/dubrovkinmaxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubrovkinmaxim/subscriptions","organizations_url":"https://api.github.com/users/dubrovkinmaxim/orgs","repos_url":"https://api.github.com/users/dubrovkinmaxim/repos","events_url":"https://api.github.com/users/dubrovkinmaxim/events{/privacy}","received_events_url":"https://api.github.com/users/dubrovkinmaxim/received_events","type":"User","site_admin":false},"repo":{"id":52988166,"name":"elasticsearch-net","full_name":"dubrovkinmaxim/elasticsearch-net","owner":{"login":"dubrovkinmaxim","id":897527,"avatar_url":"https://avatars.githubusercontent.com/u/897527?v=3","gravatar_id":"","url":"https://api.github.com/users/dubrovkinmaxim","html_url":"https://github.com/dubrovkinmaxim","followers_url":"https://api.github.com/users/dubrovkinmaxim/followers","following_url":"https://api.github.com/users/dubrovkinmaxim/following{/other_user}","gists_url":"https://api.github.com/users/dubrovkinmaxim/gists{/gist_id}","starred_url":"https://api.github.com/users/dubrovkinmaxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubrovkinmaxim/subscriptions","organizations_url":"https://api.github.com/users/dubrovkinmaxim/orgs","repos_url":"https://api.github.com/users/dubrovkinmaxim/repos","events_url":"https://api.github.com/users/dubrovkinmaxim/events{/privacy}","received_events_url":"https://api.github.com/users/dubrovkinmaxim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dubrovkinmaxim/elasticsearch-net","description":"Elasticsearch.Net & NEST","fork":true,"url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net","forks_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/forks","keys_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/teams","hooks_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/hooks","issue_events_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/issues/events{/number}","events_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/events","assignees_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/assignees{/user}","branches_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/branches{/branch}","tags_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/tags","blobs_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/statuses/{sha}","languages_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/languages","stargazers_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/stargazers","contributors_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/contributors","subscribers_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/subscribers","subscription_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/subscription","commits_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/contents/{+path}","compare_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/merges","archive_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/downloads","issues_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/issues{/number}","pulls_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/pulls{/number}","milestones_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/milestones{/number}","notifications_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/labels{/name}","releases_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/releases{/id}","deployments_url":"https://api.github.com/repos/dubrovkinmaxim/elasticsearch-net/deployments","created_at":"2016-03-02T18:58:35Z","updated_at":"2016-03-02T18:58:39Z","pushed_at":"2016-03-07T17:52:33Z","git_url":"git://github.com/dubrovkinmaxim/elasticsearch-net.git","ssh_url":"git@github.com:dubrovkinmaxim/elasticsearch-net.git","clone_url":"https://github.com/dubrovkinmaxim/elasticsearch-net.git","svn_url":"https://github.com/dubrovkinmaxim/elasticsearch-net","homepage":"","size":83455,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"72086345cbae639e98ab8d8a976f90228100b439","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":942613,"name":"elasticsearch-net","full_name":"elastic/elasticsearch-net","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch-net","description":"Elasticsearch.Net & NEST","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch-net","forks_url":"https://api.github.com/repos/elastic/elasticsearch-net/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch-net/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch-net/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch-net/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch-net/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch-net/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch-net/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch-net/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch-net/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch-net/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch-net/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch-net/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch-net/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch-net/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch-net/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch-net/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch-net/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch-net/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch-net/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch-net/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch-net/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch-net/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch-net/deployments","created_at":"2010-09-27T13:55:00Z","updated_at":"2016-03-07T12:39:42Z","pushed_at":"2016-03-07T19:36:45Z","git_url":"git://github.com/elastic/elasticsearch-net.git","ssh_url":"git@github.com:elastic/elasticsearch-net.git","clone_url":"https://github.com/elastic/elasticsearch-net.git","svn_url":"https://github.com/elastic/elasticsearch-net","homepage":"","size":87021,"stargazers_count":970,"watchers_count":970,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":493,"mirror_url":null,"open_issues_count":33,"forks":493,"open_issues":33,"watchers":970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896"},"html":{"href":"https://github.com/elastic/elasticsearch-net/pull/1896"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/issues/1896"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/issues/1896/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/pulls/1896/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch-net/statuses/0efaf8442e27dee479541becfbd824c527922538"}}}}