{"action":"created","comment":{"url":"https://api.github.com/repos/pbc-2016/D04/pulls/comments/73918906","id":73918906,"diff_hunk":"@@ -30,8 +48,16 @@ def verbing(s):\n # So 'This dinner is not that bad!' yields:\n # This dinner is good!\n def not_bad(s):\n-    # +++your code here+++\n-    return\n+\t# +++your code here+++\n+\tnott = s.find(\"not\")\n+\tbad= s.find(\"bad\")\n+\tbad1 = s.find(\"bad\") + 3\n+\tif nott < bad :\n+\t\ts1 = s[:nott]\n+\t\ts2 = s[bad1:]\n+\t\ts3 = \"good\"\n+\t\ts = s1 + s3 + s2\n+\treturn(s)","path":"HW04_string2.py","position":45,"original_position":45,"commit_id":"d81f7658911e2303fd9b1fad830bbbeef71225b1","original_commit_id":"d81f7658911e2303fd9b1fad830bbbeef71225b1","user":{"login":"dalmia-nihar","id":20780476,"avatar_url":"https://avatars.githubusercontent.com/u/20780476?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmia-nihar","html_url":"https://github.com/dalmia-nihar","followers_url":"https://api.github.com/users/dalmia-nihar/followers","following_url":"https://api.github.com/users/dalmia-nihar/following{/other_user}","gists_url":"https://api.github.com/users/dalmia-nihar/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmia-nihar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmia-nihar/subscriptions","organizations_url":"https://api.github.com/users/dalmia-nihar/orgs","repos_url":"https://api.github.com/users/dalmia-nihar/repos","events_url":"https://api.github.com/users/dalmia-nihar/events{/privacy}","received_events_url":"https://api.github.com/users/dalmia-nihar/received_events","type":"User","site_admin":false},"body":"The check to find if \"not\" actually exists has not been done. \r\n\r\nThe `nott = s.find(\"not\")` will return -1, and `bad= s.find(\"bad\")` will return the location of 'b' in 'bad' .\r\n\r\nMeaning the condition 'nott < bad' gets satisfied, and even though 'not .. bad' does not exist, 'good' is inserted.\r\n","created_at":"2016-08-08T17:39:45Z","updated_at":"2016-08-08T17:39:45Z","html_url":"https://github.com/pbc-2016/D04/pull/6#discussion_r73918906","pull_request_url":"https://api.github.com/repos/pbc-2016/D04/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/pbc-2016/D04/pulls/comments/73918906"},"html":{"href":"https://github.com/pbc-2016/D04/pull/6#discussion_r73918906"},"pull_request":{"href":"https://api.github.com/repos/pbc-2016/D04/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/pbc-2016/D04/pulls/6","id":80359858,"html_url":"https://github.com/pbc-2016/D04/pull/6","diff_url":"https://github.com/pbc-2016/D04/pull/6.diff","patch_url":"https://github.com/pbc-2016/D04/pull/6.patch","issue_url":"https://api.github.com/repos/pbc-2016/D04/issues/6","number":6,"state":"closed","locked":false,"title":"Karan's submission","user":{"login":"karan01891","id":20626963,"avatar_url":"https://avatars.githubusercontent.com/u/20626963?v=3","gravatar_id":"","url":"https://api.github.com/users/karan01891","html_url":"https://github.com/karan01891","followers_url":"https://api.github.com/users/karan01891/followers","following_url":"https://api.github.com/users/karan01891/following{/other_user}","gists_url":"https://api.github.com/users/karan01891/gists{/gist_id}","starred_url":"https://api.github.com/users/karan01891/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan01891/subscriptions","organizations_url":"https://api.github.com/users/karan01891/orgs","repos_url":"https://api.github.com/users/karan01891/repos","events_url":"https://api.github.com/users/karan01891/events{/privacy}","received_events_url":"https://api.github.com/users/karan01891/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-07T06:45:55Z","updated_at":"2016-08-08T17:39:45Z","closed_at":"2016-08-08T09:42:40Z","merged_at":null,"merge_commit_sha":"e77cf0bdbeb80143cf75e6eb343c58e8f7e0ee47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pbc-2016/D04/pulls/6/commits","review_comments_url":"https://api.github.com/repos/pbc-2016/D04/pulls/6/comments","review_comment_url":"https://api.github.com/repos/pbc-2016/D04/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pbc-2016/D04/issues/6/comments","statuses_url":"https://api.github.com/repos/pbc-2016/D04/statuses/d81f7658911e2303fd9b1fad830bbbeef71225b1","head":{"label":"karan01891:master","ref":"master","sha":"d81f7658911e2303fd9b1fad830bbbeef71225b1","user":{"login":"karan01891","id":20626963,"avatar_url":"https://avatars.githubusercontent.com/u/20626963?v=3","gravatar_id":"","url":"https://api.github.com/users/karan01891","html_url":"https://github.com/karan01891","followers_url":"https://api.github.com/users/karan01891/followers","following_url":"https://api.github.com/users/karan01891/following{/other_user}","gists_url":"https://api.github.com/users/karan01891/gists{/gist_id}","starred_url":"https://api.github.com/users/karan01891/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan01891/subscriptions","organizations_url":"https://api.github.com/users/karan01891/orgs","repos_url":"https://api.github.com/users/karan01891/repos","events_url":"https://api.github.com/users/karan01891/events{/privacy}","received_events_url":"https://api.github.com/users/karan01891/received_events","type":"User","site_admin":false},"repo":{"id":65038986,"name":"D04","full_name":"karan01891/D04","owner":{"login":"karan01891","id":20626963,"avatar_url":"https://avatars.githubusercontent.com/u/20626963?v=3","gravatar_id":"","url":"https://api.github.com/users/karan01891","html_url":"https://github.com/karan01891","followers_url":"https://api.github.com/users/karan01891/followers","following_url":"https://api.github.com/users/karan01891/following{/other_user}","gists_url":"https://api.github.com/users/karan01891/gists{/gist_id}","starred_url":"https://api.github.com/users/karan01891/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan01891/subscriptions","organizations_url":"https://api.github.com/users/karan01891/orgs","repos_url":"https://api.github.com/users/karan01891/repos","events_url":"https://api.github.com/users/karan01891/events{/privacy}","received_events_url":"https://api.github.com/users/karan01891/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karan01891/D04","description":null,"fork":true,"url":"https://api.github.com/repos/karan01891/D04","forks_url":"https://api.github.com/repos/karan01891/D04/forks","keys_url":"https://api.github.com/repos/karan01891/D04/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karan01891/D04/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karan01891/D04/teams","hooks_url":"https://api.github.com/repos/karan01891/D04/hooks","issue_events_url":"https://api.github.com/repos/karan01891/D04/issues/events{/number}","events_url":"https://api.github.com/repos/karan01891/D04/events","assignees_url":"https://api.github.com/repos/karan01891/D04/assignees{/user}","branches_url":"https://api.github.com/repos/karan01891/D04/branches{/branch}","tags_url":"https://api.github.com/repos/karan01891/D04/tags","blobs_url":"https://api.github.com/repos/karan01891/D04/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karan01891/D04/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karan01891/D04/git/refs{/sha}","trees_url":"https://api.github.com/repos/karan01891/D04/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karan01891/D04/statuses/{sha}","languages_url":"https://api.github.com/repos/karan01891/D04/languages","stargazers_url":"https://api.github.com/repos/karan01891/D04/stargazers","contributors_url":"https://api.github.com/repos/karan01891/D04/contributors","subscribers_url":"https://api.github.com/repos/karan01891/D04/subscribers","subscription_url":"https://api.github.com/repos/karan01891/D04/subscription","commits_url":"https://api.github.com/repos/karan01891/D04/commits{/sha}","git_commits_url":"https://api.github.com/repos/karan01891/D04/git/commits{/sha}","comments_url":"https://api.github.com/repos/karan01891/D04/comments{/number}","issue_comment_url":"https://api.github.com/repos/karan01891/D04/issues/comments{/number}","contents_url":"https://api.github.com/repos/karan01891/D04/contents/{+path}","compare_url":"https://api.github.com/repos/karan01891/D04/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karan01891/D04/merges","archive_url":"https://api.github.com/repos/karan01891/D04/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karan01891/D04/downloads","issues_url":"https://api.github.com/repos/karan01891/D04/issues{/number}","pulls_url":"https://api.github.com/repos/karan01891/D04/pulls{/number}","milestones_url":"https://api.github.com/repos/karan01891/D04/milestones{/number}","notifications_url":"https://api.github.com/repos/karan01891/D04/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karan01891/D04/labels{/name}","releases_url":"https://api.github.com/repos/karan01891/D04/releases{/id}","deployments_url":"https://api.github.com/repos/karan01891/D04/deployments","created_at":"2016-08-05T18:04:30Z","updated_at":"2016-08-05T18:04:31Z","pushed_at":"2016-08-07T06:45:23Z","git_url":"git://github.com/karan01891/D04.git","ssh_url":"git@github.com:karan01891/D04.git","clone_url":"https://github.com/karan01891/D04.git","svn_url":"https://github.com/karan01891/D04","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pbc-2016:master","ref":"master","sha":"29db477bc5554348a6ac382f0f6128d88d9c8482","user":{"login":"pbc-2016","id":20786246,"avatar_url":"https://avatars.githubusercontent.com/u/20786246?v=3","gravatar_id":"","url":"https://api.github.com/users/pbc-2016","html_url":"https://github.com/pbc-2016","followers_url":"https://api.github.com/users/pbc-2016/followers","following_url":"https://api.github.com/users/pbc-2016/following{/other_user}","gists_url":"https://api.github.com/users/pbc-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/pbc-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbc-2016/subscriptions","organizations_url":"https://api.github.com/users/pbc-2016/orgs","repos_url":"https://api.github.com/users/pbc-2016/repos","events_url":"https://api.github.com/users/pbc-2016/events{/privacy}","received_events_url":"https://api.github.com/users/pbc-2016/received_events","type":"Organization","site_admin":false},"repo":{"id":65019784,"name":"D04","full_name":"pbc-2016/D04","owner":{"login":"pbc-2016","id":20786246,"avatar_url":"https://avatars.githubusercontent.com/u/20786246?v=3","gravatar_id":"","url":"https://api.github.com/users/pbc-2016","html_url":"https://github.com/pbc-2016","followers_url":"https://api.github.com/users/pbc-2016/followers","following_url":"https://api.github.com/users/pbc-2016/following{/other_user}","gists_url":"https://api.github.com/users/pbc-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/pbc-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbc-2016/subscriptions","organizations_url":"https://api.github.com/users/pbc-2016/orgs","repos_url":"https://api.github.com/users/pbc-2016/repos","events_url":"https://api.github.com/users/pbc-2016/events{/privacy}","received_events_url":"https://api.github.com/users/pbc-2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pbc-2016/D04","description":null,"fork":false,"url":"https://api.github.com/repos/pbc-2016/D04","forks_url":"https://api.github.com/repos/pbc-2016/D04/forks","keys_url":"https://api.github.com/repos/pbc-2016/D04/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbc-2016/D04/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbc-2016/D04/teams","hooks_url":"https://api.github.com/repos/pbc-2016/D04/hooks","issue_events_url":"https://api.github.com/repos/pbc-2016/D04/issues/events{/number}","events_url":"https://api.github.com/repos/pbc-2016/D04/events","assignees_url":"https://api.github.com/repos/pbc-2016/D04/assignees{/user}","branches_url":"https://api.github.com/repos/pbc-2016/D04/branches{/branch}","tags_url":"https://api.github.com/repos/pbc-2016/D04/tags","blobs_url":"https://api.github.com/repos/pbc-2016/D04/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbc-2016/D04/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbc-2016/D04/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbc-2016/D04/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbc-2016/D04/statuses/{sha}","languages_url":"https://api.github.com/repos/pbc-2016/D04/languages","stargazers_url":"https://api.github.com/repos/pbc-2016/D04/stargazers","contributors_url":"https://api.github.com/repos/pbc-2016/D04/contributors","subscribers_url":"https://api.github.com/repos/pbc-2016/D04/subscribers","subscription_url":"https://api.github.com/repos/pbc-2016/D04/subscription","commits_url":"https://api.github.com/repos/pbc-2016/D04/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbc-2016/D04/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbc-2016/D04/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbc-2016/D04/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbc-2016/D04/contents/{+path}","compare_url":"https://api.github.com/repos/pbc-2016/D04/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbc-2016/D04/merges","archive_url":"https://api.github.com/repos/pbc-2016/D04/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbc-2016/D04/downloads","issues_url":"https://api.github.com/repos/pbc-2016/D04/issues{/number}","pulls_url":"https://api.github.com/repos/pbc-2016/D04/pulls{/number}","milestones_url":"https://api.github.com/repos/pbc-2016/D04/milestones{/number}","notifications_url":"https://api.github.com/repos/pbc-2016/D04/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbc-2016/D04/labels{/name}","releases_url":"https://api.github.com/repos/pbc-2016/D04/releases{/id}","deployments_url":"https://api.github.com/repos/pbc-2016/D04/deployments","created_at":"2016-08-05T13:16:48Z","updated_at":"2016-08-05T13:20:28Z","pushed_at":"2016-08-08T17:29:48Z","git_url":"git://github.com/pbc-2016/D04.git","ssh_url":"git@github.com:pbc-2016/D04.git","clone_url":"https://github.com/pbc-2016/D04.git","svn_url":"https://github.com/pbc-2016/D04","homepage":null,"size":123,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":3,"forks":34,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pbc-2016/D04/pulls/6"},"html":{"href":"https://github.com/pbc-2016/D04/pull/6"},"issue":{"href":"https://api.github.com/repos/pbc-2016/D04/issues/6"},"comments":{"href":"https://api.github.com/repos/pbc-2016/D04/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/pbc-2016/D04/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/pbc-2016/D04/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pbc-2016/D04/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/pbc-2016/D04/statuses/d81f7658911e2303fd9b1fad830bbbeef71225b1"}}}}
{"actor":{"display_login":"dalmia-nihar"}}