{"action":"created","issue":{"url":"https://api.github.com/repos/Kenshino/HelpHub/issues/71","repository_url":"https://api.github.com/repos/Kenshino/HelpHub","labels_url":"https://api.github.com/repos/Kenshino/HelpHub/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/Kenshino/HelpHub/issues/71/comments","events_url":"https://api.github.com/repos/Kenshino/HelpHub/issues/71/events","html_url":"https://github.com/Kenshino/HelpHub/pull/71","id":197162184,"number":71,"title":"Fix phpcs error in helphub post types","user":{"login":"miya0001","id":309946,"avatar_url":"https://avatars.githubusercontent.com/u/309946?v=3","gravatar_id":"","url":"https://api.github.com/users/miya0001","html_url":"https://github.com/miya0001","followers_url":"https://api.github.com/users/miya0001/followers","following_url":"https://api.github.com/users/miya0001/following{/other_user}","gists_url":"https://api.github.com/users/miya0001/gists{/gist_id}","starred_url":"https://api.github.com/users/miya0001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miya0001/subscriptions","organizations_url":"https://api.github.com/users/miya0001/orgs","repos_url":"https://api.github.com/users/miya0001/repos","events_url":"https://api.github.com/users/miya0001/events{/privacy}","received_events_url":"https://api.github.com/users/miya0001/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-22T12:15:33Z","updated_at":"2016-12-23T00:01:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Kenshino/HelpHub/pulls/71","html_url":"https://github.com/Kenshino/HelpHub/pull/71","diff_url":"https://github.com/Kenshino/HelpHub/pull/71.diff","patch_url":"https://github.com/Kenshino/HelpHub/pull/71.patch"},"body":"But there are some issues.\r\n\r\nhttps://github.com/Kenshino/HelpHub/blob/64f9df65b1daee94efcc57c24162588cd7cceb2d/plugins/helphub-post-types/classes/class-helphub-post-types-post-type.php\r\n\r\nI couldn't find out the solution to fix error in the following lines.\r\nSo I added the `/* @codingStandardsIgnoreLine */`.\r\n\r\n@ntwb Do you know any solution?\r\n\r\n```\r\n123:\t\t\t'name' => sprintf( _x( '%s', 'post type general name', 'helphub' ), $this->plural ), /* @codingStandardsIgnoreLine */\r\n124:\t\t\t'singular_name' => sprintf( _x( '%s', 'post type singular name', 'helphub' ), $this->singular ), /* @codingStandardsIgnoreLine */\r\n455:\t\t/* @codingStandardsIgnoreLine */\r\n477:\t\t\t\t\t${$f} = isset( $_POST[ $f ] ) ? esc_url( $_POST[ $f ] ) : ''; /* @codingStandardsIgnoreLine */\r\n481:\t\t\t\t\t${$f} = isset( $_POST[ $f ] ) ? wp_kses_post( trim( $_POST[ $f ] ) ) : ''; /* @codingStandardsIgnoreLine */\r\n488:\t\t\t\t\t${$f} = isset( $_POST[ $f ] ) && is_array( $field_data[ $f ]['options'] ) ? (array) array_intersect( (array) $_POST[ $f ], array_flip( $field_data[ $f ]['options'] ) ) : ''; /* @codingStandardsIgnoreLine */\r\n497:\t\t\t\t\t${$f} = isset( $_POST[ $f ] ) && in_array( $_POST[ $f ], $values ) ? $_POST[ $f ] : ''; /* @codingStandardsIgnoreLine */\r\n500:\t\t\t\t\t${$f} = isset( $_POST[ $f ] ) ? strip_tags( trim( $_POST[ $f ] ) ) : ''; /* @codingStandardsIgnoreLine */\r\n512:\t\t$attachment_ids = array_filter( explode( ',', sanitize_text_field( $_POST['helphub_image_gallery'] ) ) ); /* @codingStandardsIgnoreLine */\r\n```\r\n\r\nAnd following lines can't be translated.\r\n@Kenshino How should we fix them?\r\n\r\n```\r\n138: /* @codingStandardsIgnoreLine */\r\n139: $single_slug = apply_filters( 'helphub_single_slug', sanitize_title_with_dashes( $this->singular ) );\r\n140: /* @codingStandardsIgnoreLine */\r\n141: $archive_slug = apply_filters( 'helphub_archive_slug', sanitize_title_with_dashes( $this->plural ) );\r\n```"},"comment":{"url":"https://api.github.com/repos/Kenshino/HelpHub/issues/comments/268917396","html_url":"https://github.com/Kenshino/HelpHub/pull/71#issuecomment-268917396","issue_url":"https://api.github.com/repos/Kenshino/HelpHub/issues/71","id":268917396,"user":{"login":"ntwb","id":1016458,"avatar_url":"https://avatars.githubusercontent.com/u/1016458?v=3","gravatar_id":"","url":"https://api.github.com/users/ntwb","html_url":"https://github.com/ntwb","followers_url":"https://api.github.com/users/ntwb/followers","following_url":"https://api.github.com/users/ntwb/following{/other_user}","gists_url":"https://api.github.com/users/ntwb/gists{/gist_id}","starred_url":"https://api.github.com/users/ntwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntwb/subscriptions","organizations_url":"https://api.github.com/users/ntwb/orgs","repos_url":"https://api.github.com/users/ntwb/repos","events_url":"https://api.github.com/users/ntwb/events{/privacy}","received_events_url":"https://api.github.com/users/ntwb/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T00:01:26Z","updated_at":"2016-12-23T00:01:26Z","body":"> Omg Travis passed.\r\n\r\nClose, the Grunt task is currently using `--force` to force all the tests to run, there are some JSHint and JSCS fixes still required before everything passes, getting very close though 😄 "}}
{"actor":{"display_login":"ntwb"}}