{"action":"opened","number":8097,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8097","id":71265184,"html_url":"https://github.com/bitcoin/bitcoin/pull/8097","diff_url":"https://github.com/bitcoin/bitcoin/pull/8097.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8097.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8097","number":8097,"state":"open","locked":false,"title":"RFC: rpc: Remove dns argument for getaddednodeinfo","user":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"body":"As discussed with @laanwj and @sdaftuar in Zurich. The output format is kept the same as before, though the input params change.\r\n\r\nAs far as I can tell, this has no test coverage, and I'm willing to bet it gets very little usage. The behavior is subtle and non-obvious: it does a real-time resolve in order to check whether an addnode entry is connected at the time of that resolve, and makes no mention of whether or not a connection once matched a resolved addnode.\r\n\r\nThis complicates the net encapsulation work, so I propose that we simply drop it unless there's a good reason not to. If preferred, it could swallow a dummy bool parameter, in order to remain api compatible.","created_at":"2016-05-24T17:59:38Z","updated_at":"2016-05-24T17:59:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8097/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8097/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8097/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/3c6fe920d8235b058eb12b5978f06d7540d8dc53","head":{"label":"theuni:remove-getaddednodeinfo-dns","ref":"remove-getaddednodeinfo-dns","sha":"3c6fe920d8235b058eb12b5978f06d7540d8dc53","user":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"repo":{"id":10302141,"name":"bitcoin","full_name":"theuni/bitcoin","owner":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theuni/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/theuni/bitcoin","forks_url":"https://api.github.com/repos/theuni/bitcoin/forks","keys_url":"https://api.github.com/repos/theuni/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theuni/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theuni/bitcoin/teams","hooks_url":"https://api.github.com/repos/theuni/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/theuni/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/theuni/bitcoin/events","assignees_url":"https://api.github.com/repos/theuni/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/theuni/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/theuni/bitcoin/tags","blobs_url":"https://api.github.com/repos/theuni/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theuni/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theuni/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/theuni/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theuni/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/theuni/bitcoin/languages","stargazers_url":"https://api.github.com/repos/theuni/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/theuni/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/theuni/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/theuni/bitcoin/subscription","commits_url":"https://api.github.com/repos/theuni/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/theuni/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/theuni/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/theuni/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/theuni/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/theuni/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theuni/bitcoin/merges","archive_url":"https://api.github.com/repos/theuni/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theuni/bitcoin/downloads","issues_url":"https://api.github.com/repos/theuni/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/theuni/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/theuni/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/theuni/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theuni/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/theuni/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/theuni/bitcoin/deployments","created_at":"2013-05-26T18:55:06Z","updated_at":"2016-05-04T03:36:21Z","pushed_at":"2016-05-24T17:48:12Z","git_url":"git://github.com/theuni/bitcoin.git","ssh_url":"git@github.com:theuni/bitcoin.git","clone_url":"https://github.com/theuni/bitcoin.git","svn_url":"https://github.com/theuni/bitcoin","homepage":"http://www.bitcoin.org","size":74244,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"trivial-next"}},"base":{"label":"bitcoin:master","ref":"master","sha":"77b49acc85d05eda96b6892db835d79f30314a3b","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-05-24T17:15:12Z","pushed_at":"2016-05-24T15:37:12Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":137600,"stargazers_count":9089,"watchers_count":9089,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6122,"mirror_url":null,"open_issues_count":482,"forks":6122,"open_issues":482,"watchers":9089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8097"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8097"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8097"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8097/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8097/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8097/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/3c6fe920d8235b058eb12b5978f06d7540d8dc53"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":75,"changed_files":1}}
{"actor":{"display_login":"theuni"}}