{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/91822909","pull_request_review_id":12336346,"id":91822909,"diff_hunk":"@@ -300,7 +300,15 @@ func ensureDestinationExists(source, destination string) error {\n \treturn nil\n }\n \n-func AppAddMounts(p *stage1commontypes.Pod, ra *schema.RuntimeApp, enterCmd []string) {\n+func AppAddMounts(p *stage1commontypes.Pod, ra *schema.RuntimeApp, enterCmd []string) error {\n+\tsharedVolPath := common.SharedVolumesPath(p.Root)","path":"stage1/init/common/mount.go","position":6,"original_position":6,"commit_id":"25284c0207d0ee148bee0d1fa7e5c7c509557066","original_commit_id":"25284c0207d0ee148bee0d1fa7e5c7c509557066","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"this is called in two places, honestly this whole thing should probably be in `common`. maybe as `sharedVolPath, err := common.InitSharedVolumePath()`","created_at":"2016-12-10T00:59:58Z","updated_at":"2016-12-10T00:59:58Z","html_url":"https://github.com/coreos/rkt/pull/3468#discussion_r91822909","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/3468","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/91822909"},"html":{"href":"https://github.com/coreos/rkt/pull/3468#discussion_r91822909"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3468"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/3468","id":97391872,"html_url":"https://github.com/coreos/rkt/pull/3468","diff_url":"https://github.com/coreos/rkt/pull/3468.diff","patch_url":"https://github.com/coreos/rkt/pull/3468.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/3468","number":3468,"state":"open","locked":false,"title":"mount: ensure empty volume paths exist for copy-up","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"Before this change, the `copy-up` operation could fail with:\r\n`stage1: could not prepare mountpoint: mkdir sharedVolumes/foo: no such file or directory`\r\n\r\nThis would occur because `CopyTree` does not implicitly create the\r\ntarget directory, so we must create it prior to calling.\r\n\r\ncc @squeed \r\n\r\nTODO:\r\n\r\n- [ ] A functional test for this","created_at":"2016-12-09T22:30:06Z","updated_at":"2016-12-10T00:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce8db0262e17e30d2d49baf61eb7987ef2cb0e97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/3468/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/3468/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/3468/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/25284c0207d0ee148bee0d1fa7e5c7c509557066","head":{"label":"euank:rkt-mkdir-implicit-mount","ref":"rkt-mkdir-implicit-mount","sha":"25284c0207d0ee148bee0d1fa7e5c7c509557066","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"repo":{"id":54994558,"name":"rkt","full_name":"euank/rkt","owner":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/euank/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/euank/rkt","forks_url":"https://api.github.com/repos/euank/rkt/forks","keys_url":"https://api.github.com/repos/euank/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euank/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euank/rkt/teams","hooks_url":"https://api.github.com/repos/euank/rkt/hooks","issue_events_url":"https://api.github.com/repos/euank/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/euank/rkt/events","assignees_url":"https://api.github.com/repos/euank/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/euank/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/euank/rkt/tags","blobs_url":"https://api.github.com/repos/euank/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euank/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euank/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/euank/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euank/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/euank/rkt/languages","stargazers_url":"https://api.github.com/repos/euank/rkt/stargazers","contributors_url":"https://api.github.com/repos/euank/rkt/contributors","subscribers_url":"https://api.github.com/repos/euank/rkt/subscribers","subscription_url":"https://api.github.com/repos/euank/rkt/subscription","commits_url":"https://api.github.com/repos/euank/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/euank/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/euank/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/euank/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/euank/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/euank/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euank/rkt/merges","archive_url":"https://api.github.com/repos/euank/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euank/rkt/downloads","issues_url":"https://api.github.com/repos/euank/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/euank/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/euank/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/euank/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euank/rkt/labels{/name}","releases_url":"https://api.github.com/repos/euank/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/euank/rkt/deployments","created_at":"2016-03-29T17:05:10Z","updated_at":"2016-03-29T17:05:12Z","pushed_at":"2016-12-10T00:56:27Z","git_url":"git://github.com/euank/rkt.git","ssh_url":"git@github.com:euank/rkt.git","clone_url":"https://github.com/euank/rkt.git","svn_url":"https://github.com/euank/rkt","homepage":"","size":24471,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"db71adb4dfe2b3b0a418a4e727349adf46dc06da","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is a pod-native container engine for Linux. It is composable, secure, and built on standards.","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-12-09T18:45:13Z","pushed_at":"2016-12-10T00:56:28Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":35775,"stargazers_count":6500,"watchers_count":6500,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":639,"mirror_url":null,"open_issues_count":403,"forks":639,"open_issues":403,"watchers":6500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3468"},"html":{"href":"https://github.com/coreos/rkt/pull/3468"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/3468"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/3468/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3468/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3468/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/25284c0207d0ee148bee0d1fa7e5c7c509557066"}}}}
{"actor":{"display_login":"euank"}}